On 2012-12-13, at 07:59, commits@source.squeak.org wrote:
Karl Ramberg uploaded a new version of Tools to project Etoys: http://source.squeak.org/etoys/Tools-kfr.14.mcz
==================== Summary ====================
Name: Tools-kfr.14 Author: kfr Time: 13 December 2012, 8:59:15 am UUID: ca9017f6-5c84-284c-a508-fbabbe39c1dd Ancestors: Tools-kfr.13
A little better conversion of tiles to code
=============== Diff against Tools-kfr.13 ===============
Item was changed: ----- Method: MethodHolder>>acceptDroppingMorph:event:inMorph: (in category 'drag and drop') ----- acceptDroppingMorph: dropee event: evt inMorph: targetMorph "Return the dropee to its old position, and add a reference to it at the cursor point." | externalName | (dropee isTileLike) ifTrue:[dropee isTileMorph
ifFalse:[ externalName := dropee codeString unparenthetically]
targetMorph correctSelectionWithString: externalName. dropee rejectDropMorphEvent: evt. ^ true "success"ifFalse:[^dropee rejectDropMorphEvent: evt. ] ifTrue:[externalName := dropee actualObject uniqueNameForReference]] ifFalse:[externalName := dropee assuredPlayer uniqueNameForReference].
!
It's a bit misleading that you call the temp var "externalName" because the #externalName message returns the user-visible name of a player, not the unique name for reference. They are sometimes the same, but sometimes not. "referenceName" would be better.
- Bert -