Vm-dev August 2020

vm-dev@lists.squeakfoundation.org

15 participants
109 discussions

[OpenSmalltalk/opensmalltalk-vm] Be explicit about which test image version - move to CI config (#331)
by Ben Coman 10 Sep '20

10 Sep '20

First try to see what Travis thinks about these changes. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/331 -- Commit Summary -- * Be explicit about which test image version - move to CI config -- File Changes -- M .travis.yml (91) M scripts/ci/travis_test.sh (6) M tests/smalltalkCI.sh (25) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/331.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/331.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/331

3 4

[OpenSmalltalk/opensmalltalk-vm] Simplify gitignore build directories [skip ci] (#351)
by Ben Coman 10 Sep '20

10 Sep '20

I noticed that modified Makefiles weren't being pickup up by `git status`. It was too tedious trying to fix the existing definitions, so I've condensed them down to 4 lines from 34. I'm reasonably sure the result is the same, but if I've missed something its low impact, so maybe just integrate first to let everyone suck-n-see. Doing a `git status` before each `git commit` will let you confirm that its working. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/351 -- Commit Summary -- * Simplify gitignore build directories -- File Changes -- M .gitignore (43) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/351.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/351.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/351

2 2

[OpenSmalltalk/opensmalltalk-vm] third-party: Stop building/using vulnerable software (#386)
by Holger Freyther 10 Sep '20

10 Sep '20

You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386 -- Commit Summary -- * third-party: Stop building/using vulnerable software -- File Changes -- M third-party/libgit2.spec (10) M third-party/libpng.spec (6) M third-party/libssh2.spec (6) M third-party/openssl.spec (6) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386

7 13

[OpenSmalltalk/opensmalltalk-vm] fix libgit2 makefile (#390)
by maenu 10 Sep '20

10 Sep '20

I am using MacPort's CMake which works fine, except that it needs a path argument for the libgit2 makefile. Can somebody check if this is compatible with their CMakes? You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/390 -- Commit Summary -- * fix libgit2 makefile -- File Changes -- M build.macos64x64/third-party/Makefile.libgit2 (2) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/390.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/390.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/390

2 2

[OpenSmalltalk/opensmalltalk-vm] Sunupdate (#496)
by David Stes 03 Sep '20

03 Sep '20

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hello, There's two updates for the SunOS port here. - - Change #define sk_GENERAL_NAME_freefunc for SunPRO C compiler - - SunOS: add a note in HowToBuild on pkg-config The first change is for the OpenSSL SqueakSSL case of openssl 1.0.2, to fix a type cast ... I think this potentially impacts all openssl 1.0.2 platforms that use --disable-dynamicopenssl but it seems OK (I think/hope). For the second change this is a "documentation" update to the HowToBuild "HOWTO" documentation in the build.sunos directory; this has no further impact. Thanks, David Stes -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJes8ijAAoJEAwpOKXMq1MamV8H/2MrggX6VzRxGCdP40MN5vyE HuynHVCC68dLneHoYSvaMi4IrVGXS6lYMGa8FfNZsWuVCZDW/rii1nZNH9qo6zCM 6QRekLwKOpp63tXGpKj3C/e8skju6cPvCd9LGWguSqPUVHwFCqOSawYI4OEckvvr 6Nvnqk7ER2yE/iuJSeWgIRLVq4kE/Aq3x8wAtf7zgITHhxr8fEG5+H/Y7icKHW1J aTv2Z7jDHTcJqM/sEC0la2e8K2iDHkhKBim0K/PS1LtLgzZGAfycdmHJoq0KccRT gXpEHjsDIEdfvWmIU9xjIiwsIdg5Cz7l5Y7ipb8s1l5cZKv4ct5JnwBl2+Rw+MY= =oc8N -----END PGP SIGNATURE----- You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/496 -- Commit Summary -- * Merge pull request #4 from OpenSmalltalk/Cog * Merge pull request #5 from OpenSmalltalk/Cog * SunOS: add a note in HowToBuild on pkg-config * Change #define sk_GENERAL_NAME_freefunc for SunPRO C compiler -- File Changes -- M build.sunos64x64/HowToBuild (10) M platforms/unix/plugins/SqueakSSL/openssl_overlay.h (2) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/496.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/496.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/496

2 15

[OpenSmalltalk/opensmalltalk-vm] DropPlugin: Unify numFiles fallback value before DragDrop has been recorded (#514)
by Christoph Thiede 02 Sep '20

02 Sep '20

This PR aligns the default `numFiles` value recorded for `DragEnter`, `DragMove`, and `DragLeave` events recorded by the X11 implementation of the DropPlugin, which was `1`, to the default value used by the Win32 implementation of the plugin, which is `0`. The motivation for this change is to unify the event protocol along with different platforms. It would technically be highly expensive and questionable to find out this value before the drop event has been recorded. Concretely, Win32 does not support this at all without switching the library, and on Linux, this would require a performance-extensive ping-pong of "Target to source: Please hand a copy of all dragged files", "Source to target: I converted these files for you", "Target to source: Thank you, but I was only interested into their total number" messages. (However, interestingly macOS appears to support this (I could not yet test it) and https://github.com/codefrau/SqueakJS/ could do so, too.) While pursuing the same master plan, this PR is not dependent nor reverse-dependent on #508. They can be merged independently of each other. Please review and merge if you agree. I hereby confirm that I did not observe any regressions when dragging files or folders into a recent Squeak image. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/514 -- Commit Summary -- * X11 DropPlugin: Don't specify numFiles= 1 before DragDrop -- File Changes -- M platforms/unix/vm-display-X11/sqUnixXdnd.c (14) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/514.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/514.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/514

3 12

questions about a couple of primitives
by Florin Mateoc 01 Sep '20

01 Sep '20

Hi, I had some unexpected results while looking at some primitives in the system, and I wanted to ask if they are expected/intentional: 1. 'ab' instVarAt: 1 => 97 (and 'ab' instVarAt: 2 => 98) I would have thought that #instVarAt: has pointer granularity, so I am curious if the observed behavior is an accident or intentional (and maybe even used somewhere) 2. | o | o := Object new. (WeakArray with: o) pointsTo: o => true I thought the main use case for #pointsTo: was to find hard references (e.g. for chasing memory leaks). The current behavior actually makes that use case a little more difficult to implement, since you have to special case weak references. When would one be interested in finding weak references? 3. The comment and the primitive used in #ensure: and #ifCurtailed: are the same, but the primitive failure code is different - the one for #ifCurtailed seems buggy, it never evaluates the argument None of the above are critical, but I am curious about them. Thank you in advance for any clarifications, Florin

5 22

Still Failing: OpenSmalltalk/opensmalltalk-vm#2149 (Cog - 16ffd5b)
by Travis CI 31 Aug '20

31 Aug '20

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #2149 Status: Still Failing Duration: 20 mins and 52 secs Commit: 16ffd5b (Cog) Author: Eliot Miranda Message: CogVM source as per VMMaker.oscog-eem.2797 Plugins: Squash a few C compiler warnings from the SocketPlugin and ZipPlugin. Eliminate the -fobjc-weak unused command line arg warning for MacOS builds. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/671bcff621d1...16… View the full build log and details: https://travis-ci.org/github/OpenSmalltalk/opensmalltalk-vm/builds/72259414… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

[OpenSmalltalk/opensmalltalk-vm] 16ffd5: CogVM source as per VMMaker.oscog-eem.2797
by Eliot Miranda 31 Aug '20

31 Aug '20

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 16ffd5b3c4c6e48968277e40543ca1f96b984473 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/16ffd5b3c4c6e48968… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2020-08-30 (Sun, 30 Aug 2020) Changed paths: M build.macos32x86/common/Makefile.flags M build.macos32x86/common/Makefile.rules M build.macos64ARMv8/common/Makefile.flags M build.macos64ARMv8/common/Makefile.rules M build.macos64x64/common/Makefile.flags M build.macos64x64/common/Makefile.rules M src/plugins/SocketPlugin/SocketPlugin.c M src/plugins/ZipPlugin/ZipPlugin.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2797 Plugins: Squash a few C compiler warnings from the SocketPlugin and ZipPlugin. Eliminate the -fobjc-weak unused command line arg warning for MacOS builds.

1 0

VM Maker: VMMaker.oscog-eem.2797.mcz
by commits＠source.squeak.org 31 Aug '20

31 Aug '20

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2797.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2797 Author: eem Time: 30 August 2020, 6:17:59.909283 pm UUID: 84f54ca7-0a17-408a-9fc5-fb30a1ac6c6f Ancestors: VMMaker.oscog-eem.2796 Plugins: Squash a few C compiler warnings =============== Diff against VMMaker.oscog-eem.2796 =============== Item was changed: ----- Method: DeflatePlugin>>sendBlock:with:with:with: (in category 'encoding') ----- sendBlock: literalStream with: distanceStream with: litTree with: distTree "Require: zipCollection, zipCollectionSize, zipPosition, zipBitBuf, zipBitPos. " | oop litPos litLimit litArray distArray lit dist sum llBitLengths llCodes distBitLengths distCodes code extra litBlCount distBlCount | + <var: #dist type: #sqInt> "must be signed" <var: #litArray type: #'unsigned char *'> <var: #distArray type: #'unsigned int *'> <var: #llBitLengths type: #'unsigned int *'> <var: #llCodes type: #'unsigned int *'> <var: #distBitLengths type: #'unsigned int *'> <var: #distCodes type: #'unsigned int *'> oop := interpreterProxy fetchPointer: 0 ofObject: literalStream. litPos := interpreterProxy fetchInteger: 1 ofObject: literalStream. litLimit := interpreterProxy fetchInteger: 2 ofObject: literalStream. (litPos <= litLimit and: [(interpreterProxy isBytes: oop) and: [litLimit <= (interpreterProxy byteSizeOf: oop)]]) ifFalse: [^interpreterProxy primitiveFail]. litArray := interpreterProxy firstIndexableField: oop. oop := interpreterProxy fetchPointer: 0 ofObject: distanceStream. ((interpreterProxy isWords: oop) and: [litLimit <= (interpreterProxy slotSizeOf: oop) and: [(interpreterProxy fetchInteger: 1 ofObject: distanceStream) = litPos and: [(interpreterProxy fetchInteger: 2 ofObject: distanceStream) = litLimit]]]) ifFalse: [^interpreterProxy primitiveFail]. distArray := interpreterProxy firstIndexableField: oop. oop := interpreterProxy fetchPointer: 0 ofObject: litTree. (interpreterProxy isWords: oop) ifFalse: [^interpreterProxy primitiveFail]. litBlCount := interpreterProxy slotSizeOf: oop. llBitLengths := interpreterProxy firstIndexableField: oop. oop := interpreterProxy fetchPointer: 1 ofObject: litTree. ((interpreterProxy isWords: oop) and: [litBlCount = (interpreterProxy slotSizeOf: oop)]) ifFalse: [^interpreterProxy primitiveFail]. llCodes := interpreterProxy firstIndexableField: oop. oop := interpreterProxy fetchPointer: 0 ofObject: distTree. (interpreterProxy isWords: oop) ifFalse: [^interpreterProxy primitiveFail]. distBlCount := interpreterProxy slotSizeOf: oop. distBitLengths := interpreterProxy firstIndexableField: oop. oop := interpreterProxy fetchPointer: 1 ofObject: distTree. ((interpreterProxy isWords: oop) and: [distBlCount = (interpreterProxy slotSizeOf: oop)]) ifFalse: [^interpreterProxy primitiveFail]. distCodes := interpreterProxy firstIndexableField: oop. self nextZipBits: 0 put: 0. "Flush pending bits if necessary" sum := 0. [litPos < litLimit and:[zipPosition + 4 < zipCollectionSize]] whileTrue:[ lit := litArray at: litPos. dist := distArray at: litPos. litPos := litPos + 1. dist = 0 ifTrue:["literal" sum := sum + 1. lit < litBlCount ifFalse:[^interpreterProxy primitiveFail]. self nextZipBits: (llBitLengths at: lit) put: (llCodes at: lit). ] ifFalse:["match" sum := sum + lit + DeflateMinMatch. + "eem 8/30/2020 Can't happen; litArray has type unsigned char *, lit unsigned char. Leaving this in causes a C compiler warning." + false ifTrue: [lit < 256 ifFalse:[^interpreterProxy primitiveFail]]. - lit < 256 ifFalse:[^interpreterProxy primitiveFail]. code := zipMatchLengthCodes at: lit. code < litBlCount ifFalse:[^interpreterProxy primitiveFail]. self nextZipBits: (llBitLengths at: code) put: (llCodes at: code). extra := zipExtraLengthBits at: code - 257. extra = 0 ifFalse:[ lit := lit - (zipBaseLength at: code - 257). self nextZipBits: extra put: lit]. dist := dist - 1. dist < 16r8000 ifFalse:[^interpreterProxy primitiveFail]. dist < 256 ifTrue:[code := zipDistanceCodes at: dist] ifFalse:[code := zipDistanceCodes at: 256 + (dist >> 7)]. code < distBlCount ifFalse:[^interpreterProxy primitiveFail]. self nextZipBits: (distBitLengths at: code) put: (distCodes at: code). extra := zipExtraDistanceBits at: code. extra = 0 ifFalse:[ dist := dist - (zipBaseDistance at: code). self nextZipBits: extra put: dist]. ]. ]. interpreterProxy failed ifTrue:[^nil]. interpreterProxy storeInteger: 1 ofObject: literalStream withValue: litPos. interpreterProxy storeInteger: 1 ofObject: distanceStream withValue: litPos. ^sum! Item was changed: ----- Method: SocketPlugin>>netAddressToInt: (in category 'primitives') ----- netAddressToInt: ptrToByteArray "Convert the given internet network address (represented as a four-byte ByteArray) into a 32-bit integer. Fail if the given ptrToByteArray does not appear to point to a four-byte ByteArray." + <var: #ptrToByteArray type: #'unsigned char *'> | sz | + <inline: #always> - <var: #ptrToByteArray type: 'unsigned char * '> sz := interpreterProxy byteSizeOf: ptrToByteArray cPtrAsOop. + sz = 4 ifFalse: [^interpreterProxy primitiveFail]. - sz = 4 ifFalse: [^ interpreterProxy primitiveFail]. ^ (ptrToByteArray at: 3 ) + ((ptrToByteArray at: 2) <<8) + ((ptrToByteArray at: 1) <<16) + ((ptrToByteArray at: 0) <<24)! Item was changed: ----- Method: SocketPlugin>>socketRecordSize (in category 'primitives') ----- socketRecordSize + "Answer the size of a Smalltalk socket record in bytes." + <inline: #always> + ^self sizeof: #SQSocket! - "Return the size of a Smalltalk socket record in bytes." - <inline: true> - ^ self sizeof: #SQSocket! Item was changed: ----- Method: SocketPlugin>>socketValueOf: (in category 'primitives') ----- socketValueOf: socketOop "Answer a pointer to the first byte of of the socket record within the given Smalltalk object, or nil if socketOop is not a socket record." <returnTypeC: #SocketPtr> + <inline: #always> ^((interpreterProxy isBytes: socketOop) and: [(interpreterProxy byteSizeOf: socketOop) = self socketRecordSize]) ifTrue: [self cCoerce: (interpreterProxy firstIndexableField: socketOop) to: #SocketPtr] ifFalse: [interpreterProxy primitiveFailFor: PrimErrBadArgument. nil]!

1 0

← Newer
1
2
3
4
5
6
7
...
11
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev August 2020