Vm-dev December 2023

vm-dev@lists.squeakfoundation.org

14 participants
33 discussions

[OpenSmalltalk/opensmalltalk-vm] mmap() sqUnixSpurMemory patch (Issue #665)
by David Stes 03 Mar '24

03 Mar '24

Hi, I have sent in the past email to Eliot Miranda about an issue which I discovered in August 2021 (two years ago), and I thought to raise an issue here. It is a Linux/UNIX patch issue with the behavior of the mmap() system call or library call as used by the OpenSmalltalk COG vm. When way back in 2021 some changes were made for Linux ARM8 to the file saUnixSpurMemory.c I reported that this was breaking the Solaris 11.3 build. Curiously the Solaris 11.4 build was still working fine. I think (I don't know) that perhaps the behavior of mmap() on Solaris 11.4 is slightly diferent than on 11.3, to match (perhaps) the Linux kernel behavior of mmap(). An idea that I have is to ask some UNIX guru's whether there exist a autoconf-archive (configure script) test or script to test the behavior of mmap() for portability. However here I will just report what the issue is : since august 2021 I am building succesfully on Solaris with the following patch ``` --- opensmalltalk-vm-sun-v5.0.34/platforms/unix/vm/sqUnixSpurMemory.c Fri Aug 13 19:54:42 2021 +++ p0/opensmalltalk-vm-sun-v5.0.34/platforms/unix/vm/sqUnixSpurMemory.c Sun Aug 15 14:11:58 2021 @@ -277,16 +277,21 @@ { void *hint = sbrk(0); // a hint of the lowest possible address for mmap void *result; + char *address; + unsigned long alignment; pageSize = getpagesize(); pageMask = ~(pageSize - 1); + alignment = max(pageSize,1024*1024); + address = (char *)(((usqInt)hint + alignment - 1) & ~(alignment - 1)); + #if !defined(MAP_JIT) # define MAP_JIT 0 #endif *desiredSize = roundUpToPage(*desiredSize); - result = mmap(hint, *desiredSize, + result = mmap(address, *desiredSize, #if DUAL_MAPPED_CODE_ZONE PROT_READ | PROT_EXEC, #else ``` I really need Eliot's help on this. Eliot : what I did was try to understand your code and you seem to make some alignment calculations on the desired memory location that you request through mmap(). I believe that the traditional UNIX mmap() or the Solaris 10 and Solaris 11.3 mmap() is reacting slightly differently to the requested memory "hint". By some experimentatoin and debugging I found the above patch, which I wrote based on looking at your code and try to mirror the calculations that you are doing, which are not fully symmetric. By copying some code, I discovered that with the above patch the build for both Solaris 11.3 and Solaris 11.4 are working fine again. I think this is a general UNIX issue that could be of interest to all UNIX software. If an autoconfigure autoconf-archive test would exist to test the behavior of mmap() then that could be dealt in all software that uses mmap() with anonymous memory mapping. As far as I know the history of the mmap() call is that it originated in the world of Sun and Solaris and is since a very long time present in Linux as well, and I think some improvements in Linux where then backported to Solaris 11.4. That would explain why the current OpenSmalltalk-VM code works fine on Solaris 11.4. For reasons of portability to all flavors of UNIX and Linux, I think a configure build test for the code could benefit portability of your Cog VM. Let us know please what you think. I could simply submit my patch as a patch to mainstream upstream OpenSmalltalk but I don't know your opinion about it. And the way I have been using it as a platform specific patch (that I apply prior to the build on Solaris) is fine for me as well. Regards, David Stes -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/665 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/issues/665(a)github.com>

4 19

Unit Test Failures on VM Candidate
by ken.dickey＠whidbey.com 29 Dec '23

29 Dec '23

Raspberry Pi 4; Raspian Linux; Latest Cuis; squeak.cog.sput aarch64 VM built from opensmalltalk-vm-202311211431.tar.gz Current unit tests mostly show green, but repeated runs fail on _separate_ trials for 'ProcessTerminateUnwindNonLocalReturn>>#test3DResume' 'ProcessTerminateBug>>#testTerminationDuringNestedUnwind7' 'ProcessTerminateBug>>#testTerminationDuringNestedUnwind4' Any ideas on cause and how to fencepost? Thanks, -KenD

2 1

VM Maker: VMMaker-dtl.441.mcz
by commits＠source.squeak.org 21 Dec '23

21 Dec '23

David T. Lewis uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker-dtl.441.mcz ==================== Summary ==================== Name: VMMaker-dtl.441 Author: dtl Time: 21 December 2023, 1:16:30.261 pm UUID: 0fd710ff-2d5f-4e78-8a09-40aae16e8bf2 Ancestors: VMMaker-dtl.440 VMMaker 4.20.7 - Fix myList handling in transferTo: All opensmalltalk-vm VMs set myList to nil in transferTo, classic VM did not. Process scheduling and debugger in recent images require this now. Adopt fix from SqueakJS, with change applicable to all non-closure images. SqueakJS commit is at https://github.com/codefrau/SqueakJS/commit/4f915baaaac3a5d078b09eb7c3abd55… Discussion on vm-dev Re: [SqueakJS] Smalltalk Debugger support https://lists.squeakfoundation.org/archives/list/vm-dev@lists.squeakfoundat… =============== Diff against VMMaker-dtl.440 =============== Item was added: + ----- Method: ContextInterpreter>>oldPrims (in category 'primitive support') ----- + oldPrims + "True if the running image has an image format that requires an older set of primitives. + Refer to the SqueakJS implementation for a better understanding of older image support, + and see class PrimitiveTableHistory for historical record of primitives used in various + versions of the VM. See class ImageFormat for explaination of the image format number + encoding." + + "ImageFormat knownVersionNumbers + select: [ :i | ( ImageFormat fromInteger: i) + requiresClosureSupport not] ==> #(6502 68000)" + + "In SqueakJS, image format 6501 is also recognized: + this.hasClosures = !!([6501, 6502, 68000].indexOf(version) >= 0);" + + ^ imageFormatVersionNumber = 6501 + or: [imageFormatVersionNumber = 6502 + or: [imageFormatVersionNumber = 68000]]! Item was changed: ----- Method: ContextInterpreter>>transferTo: (in category 'process primitive support') ----- transferTo: aProc "Record a process to be awoken on the next interpreter cycle. ikp 11/24/1999 06:07 -- added hook for external runtime compiler " | sched oldProc newProc | newProc := aProc. sched := self schedulerPointer. oldProc := objectMemory fetchPointer: ActiveProcessIndex ofObject: sched. objectMemory storePointer: ActiveProcessIndex ofObject: sched withValue: newProc. + self oldPrims ifFalse: [ + "Earlier images did not require this but process scheduling has changed so ensure + that myList is nil here. The check for oldPrims may be unnecessary, but is harmless. " + objectMemory storePointerUnchecked: MyListIndex ofObject: newProc withValue: objectMemory getNilObj]. compilerInitialized ifTrue: [self compilerProcessChange: oldProc to: newProc] ifFalse: [objectMemory storePointer: SuspendedContextIndex ofObject: oldProc withValue: activeContext. self newActiveContext: (objectMemory fetchPointer: SuspendedContextIndex ofObject: newProc). objectMemory storePointer: SuspendedContextIndex ofObject: newProc withValue: objectMemory getNilObj]. reclaimableContextCount := 0! Item was changed: ----- Method: VMMaker class>>versionString (in category 'version testing') ----- versionString "VMMaker versionString" + ^'4.20.7'! - ^'4.20.6'!

1 0

SqueakJS turned 10 today
by Vanessa Freudenberg 21 Dec '23

21 Dec '23

... and it can not only run the very oldest Squeak images, but even update (!) the latest trunk image. I started working on it in Nov 2013, and the first public release was on 20th December 2013. That one could really only run Dan's old "mini" image. We've come a long way. SqueakJS certainly isn't the fastest Squeak VM. But it is the most compatible one, and arguably the one easiest to understand and debug. You can try it yourself at https://squeak.js.org Either click one of the demos (like Etoys or Scratch), or drag-and-drop your favorite image into the "launcher" page. Recently I've been working on resurrecting "old" Croquet from 2005 – which included creating a proper FFI plugin to relay OpenGL calls, plus writing an OpenGL emulator mapping those functions to WebGL: Try it: https://codefrau.github.io/jasmine/ Code: https://github.com/codefrau/jasmine This is obviously work in progress, a lot of the rendering is not working yet, and I haven't even started on the networking emulation. But a lot is also working – like you can right-click in any of the teapot morphs to move around, and Tweak is alive too. Contributions to both core SqueakJS and this Croquet project are very welcome! Or support some other projects based on SqueakJS, like Craig Latta's https://caffeine.js.org or Erik Stel's https://codeparadise.nl/ (using Pharo). Happy holidays everyone! Vanessa [image: image.png]

5 4

VM Maker: CogTools.threaded-LM.99.mcz
by commits＠source.squeak.org 21 Dec '23

21 Dec '23

Leon Matthes uploaded a new version of CogTools to project VM Maker: http://source.squeak.org/VMMaker/CogTools.threaded-LM.99.mcz ==================== Summary ==================== Name: CogTools.threaded-LM.99 Author: LM Time: 21 December 2023, 4:31:24.557954 pm UUID: bd415344-8dbd-4777-b766-0b4fe6928662 Ancestors: CogTools.threaded-LM.98 Improve ThreadInspector by: 1. increased log size 2. a new plot series line type #steppedHorizontal. 3. a zoom stack to zoom out to the previous zoom level. =============== Diff against CogTools.threaded-LM.98 =============== Item was changed: ----- Method: PlotSeries>>drawOn: (in category 'drawing') ----- drawOn: aCanvas points isEmpty ifTrue: [^ self]. "" drawArea ifTrue: ["" type == #straightened ifTrue: [self drawStraightenedAreaOn: aCanvas]. type == #stepped + ifTrue: [self drawSteppedAreaOn: aCanvas]. + type == #steppedHorizontal + ifTrue: [self drawSteppedHorizontalLineOn: aCanvas]]. - ifTrue: [self drawSteppedAreaOn: aCanvas]]. drawLine ifTrue: ["" type == #straightened ifTrue: [self drawStraightenedLineOn: aCanvas]. type == #stepped ifTrue: [self drawSteppedLineOn: aCanvas]]. drawPoints ifTrue: [self drawPointsOn: aCanvas]! Item was added: + ----- Method: PlotSeries>>drawSteppedHorizontalLineOn: (in category 'drawing') ----- + drawSteppedHorizontalLineOn: aCanvas + | lineColor lastScaledPoint | + lineColor := self lineColor. + lastScaledPoint := nil. + points + do: [:point | + | scaledPoint | + scaledPoint := point scaledPoint. + lastScaledPoint + ifNotNil: [aCanvas + line: lastScaledPoint + to: scaledPoint x @ lastScaledPoint y + width: width + color: lineColor.]. + lastScaledPoint := scaledPoint]! Item was changed: ----- Method: PlotSeries>>drawSteppedLineOn: (in category 'drawing') ----- drawSteppedLineOn: aCanvas | lineColor lastScaledPoint | lineColor := self lineColor. lastScaledPoint := nil. points do: [:point | | scaledPoint | scaledPoint := point scaledPoint. lastScaledPoint ifNotNil: [""aCanvas line: lastScaledPoint to: scaledPoint x @ lastScaledPoint y width: width color: lineColor. + "aCanvas - aCanvas line: scaledPoint x @ lastScaledPoint y to: scaledPoint width: width + color: lineColor"]. - color: lineColor]. lastScaledPoint := scaledPoint]! Item was changed: Model subclass: #ThreadInspector + instanceVariableNames: 'startTime ownerLog graph currentStartTime currentEndTime zoomStack' - instanceVariableNames: 'startTime ownerLog graph currentStartTime currentEndTime' classVariableNames: '' poolDictionaries: '' category: 'CogTools-ThreadInspector'! Item was changed: + ----- Method: ThreadInspector>>afterBuildWith: (in category 'toolbuilder') ----- - ----- Method: ThreadInspector>>afterBuildWith: (in category 'as yet unclassified') ----- afterBuildWith: builder self initializeGraph. self plotGraphFrom: startTime to: self ownerLog last timestamp. (builder widgetAt: #PlotViewport) addMorph: graph fullFrame: (LayoutFrame fractions: (0@0 corner: 1@1)).! Item was changed: + ----- Method: ThreadInspector>>buildWith: (in category 'toolbuilder') ----- - ----- Method: ThreadInspector>>buildWith: (in category 'as yet unclassified') ----- buildWith: builder |windowSpec window| windowSpec := builder pluggableWindowSpec new. windowSpec model: self; label: 'VM Owner Inspector'; extent: 400@400; children: (self windowMemberSpecsFor: builder). window := builder build: windowSpec. self afterBuildWith: builder. ^ window! Item was changed: ----- Method: ThreadInspector>>getOwnerLogFromVM (in category 'accessing') ----- getOwnerLogFromVM |bytes numElements bigEndian| + bytes := (ByteArray new: 3*8*1024*100 "The log is currently 100Ki entries"). - bytes := (ByteArray new: 3*8*1024). numElements := self primitiveGetOwnerLog: bytes. bigEndian := Smalltalk endianness = #big. self assert: Smalltalk wordSize = 8. "TODO: Decode 32-bit VM log" ^ (0 to: numElements - 1) collect: [:index | |bytesOffset| bytesOffset := index * 24. CogVMOwnerLog new timestamp: (bytes long64At: bytesOffset + 1 bigEndian: bigEndian); "+1 because Smalltalk is 1-indexed" vmOwner: (bytes long64At: bytesOffset + 9 bigEndian: bigEndian); successfulSwitch: (bytes long64At: bytesOffset + 17 bigEndian: bigEndian) ~= 0; yourself].! Item was changed: + ----- Method: ThreadInspector>>initialize (in category 'initialize-release') ----- - ----- Method: ThreadInspector>>initialize (in category 'as yet unclassified') ----- initialize self currentStartTime: 0. self currentEndTime: 1. + self zoomStack: Stack new.! - ! Item was changed: ----- Method: ThreadInspector>>initializeGraph (in category 'plotting') ----- initializeGraph graph := ThreadInspectorPlotMorph new model: self; yourself. graph series: #vmOwner color: Color green; series: #vmOwner description: 'vm owner'; + series: #vmOwner type: #steppedHorizontal; + series: #vmOwner width: 2 px. - series: #vmOwner type: #stepped. graph series: #failedLocks color: Color red; series: #failedLocks description: 'failed locking attempts'; series: #failedLocks drawLine: false; + series: #failedLocks width: 3 px. - series: #failedLocks width: 2. graph xAxisFormatter: [:value | ((value - (self currentStartTime)/ 1000) asFloat printShowingMaxDecimalPlaces: 4), ' ms']. "make sure we always have at least -1, 0 and 1 in view, even if there were no owner switches to them." graph minPoint y > -1 ifTrue: [graph limitMinY: -1]. graph maxPoint y < 1 ifTrue: [graph limitMaxY: 1].! Item was changed: + ----- Method: ThreadInspector>>menuBarHeight (in category 'toolbuilder') ----- - ----- Method: ThreadInspector>>menuBarHeight (in category 'as yet unclassified') ----- menuBarHeight ^ Preferences standardButtonFont height * 3! Item was changed: + ----- Method: ThreadInspector>>menuBarSpec: (in category 'toolbuilder') ----- - ----- Method: ThreadInspector>>menuBarSpec: (in category 'as yet unclassified') ----- menuBarSpec: builder ^ builder pluggablePanelSpec new model: self; frame: (LayoutFrame new leftFraction: 0; rightFraction: 1; topFraction: 1 offset: self menuBarHeight negated; bottomFraction: 1; yourself); children: { builder pluggableButtonSpec new model: self; action: #zoomOut; label: 'Zoom out'; frame: LayoutFrame fullFrame; yourself. }! Item was changed: + ----- Method: ThreadInspector>>open (in category 'toolbuilder') ----- - ----- Method: ThreadInspector>>open (in category 'as yet unclassified') ----- open (self buildWith: ToolBuilder default) openInWorld.! Item was changed: + ----- Method: ThreadInspector>>plotSpec: (in category 'toolbuilder') ----- - ----- Method: ThreadInspector>>plotSpec: (in category 'as yet unclassified') ----- plotSpec: builder ^ builder pluggablePanelSpec new model: self; frame: (LayoutFrame new leftFraction: 0; topFraction: 0; rightFraction: 1; bottomFraction: 1 offset: self menuBarHeight negated; yourself); name: #PlotViewport; children: {}; yourself! Item was changed: ----- Method: ThreadInspector>>selectProportionFrom:to: (in category 'plotting') ----- selectProportionFrom: lowPortion to: highPortion + |timeRange newStartTime newEndTime| - |timeRange| timeRange := self currentEndTime - self currentStartTime. + newStartTime := self currentStartTime + (timeRange * lowPortion) rounded. + newEndTime := self currentStartTime + (timeRange * highPortion) rounded. + "Push the current zoom level on the stack so that we can find it later in #zoomOut." + self zoomStack push: {self currentStartTime. self currentEndTime}. + self plotGraphFrom: newStartTime to: newEndTime.! - self plotGraphFrom: self currentStartTime + (timeRange * lowPortion) rounded - to: self currentStartTime + (timeRange * highPortion) rounded.! Item was changed: ----- Method: ThreadInspector>>visualize (in category 'plotting') ----- visualize self initializeGraph. self plotGraphFrom: self startTime to: self ownerLog last timestamp. graph openInWorld.! Item was changed: + ----- Method: ThreadInspector>>windowMemberSpecsFor: (in category 'toolbuilder') ----- - ----- Method: ThreadInspector>>windowMemberSpecsFor: (in category 'as yet unclassified') ----- windowMemberSpecsFor: builder ^ { self plotSpec: builder. self menuBarSpec: builder. }! Item was changed: ----- Method: ThreadInspector>>zoomOut (in category 'plotting') ----- zoomOut + |zoomEntry| + zoomEntry := self zoomStack isEmpty + ifTrue: [{self startTime. self ownerLog last timestamp}] + ifFalse: [self zoomStack pop]. + self plotGraphFrom: zoomEntry first to: zoomEntry second.! - self plotGraphFrom: startTime to: self ownerLog last timestamp.! Item was added: + ----- Method: ThreadInspector>>zoomStack (in category 'accessing') ----- + zoomStack + + ^ zoomStack! Item was added: + ----- Method: ThreadInspector>>zoomStack: (in category 'accessing') ----- + zoomStack: aStack + + zoomStack := aStack.! Item was changed: ----- Method: ThreadInspectorPlotMorph>>moveYMidToZero (in category 'as yet unclassified') ----- moveYMidToZero "This is the most useful marker for thread inspection as 0 means 'disowned'." | zeroFraction | ymid contents: (yAxisFormatter value: 0). self assert: (self minPoint y < 0 and: [0 < self maxPoint y]). zeroFraction := self maxPoint y / (self maxPoint y - self minPoint y). ymid position: (self topLeft + + ((15 - ymid width max: 0) @ (self height - (ymid height*2) * zeroFraction) rounded) - + ((15 - ymid width max: 0) @ (self height - ymid height * zeroFraction) rounded) + (self borderWidth @ 0)).!

1 0

VM Maker: VMMaker.threaded-LM.3353.mcz
by commits＠source.squeak.org 21 Dec '23

21 Dec '23

Leon Matthes uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.threaded-LM.3353.mcz ==================== Summary ==================== Name: VMMaker.threaded-LM.3353 Author: LM Time: 21 December 2023, 4:24:17.659525 pm UUID: c431b328-cc1f-49b9-8427-ebfc50b37d7e Ancestors: VMMaker.threaded-LM.3352 Do not make primitives pin themselves, rather check for pinned arguments as a condition for disowning. Also: Increase size of VM Owner Log to 100Ki entries. TODO: Make VMOwnerLog optional for release builds. =============== Diff against VMMaker.threaded-LM.3352 =============== Item was changed: ----- Method: CoInterpreterMT>>loadInitialContext (in category 'initialization') ----- loadInitialContext | activeProc threadAffinity | super loadInitialContext. activeProc := self activeProcess. threadAffinity := self threadAffinityOfProcess: activeProc. + + self assert: (threadAffinity = 0 or: [threadAffinity = 1]). + self cCode: [] inSmalltalk: [self flag: #todoMT "Ensure we cannot save an image, where the 'activeProc' is affined to another thread!!"]. + + activeProcessAffined := threadAffinity ~= 0! - self assert: (threadAffinity = 0 or: [threadAffinity = 1]). "TODO: Ensure we cannot save an image, where the 'activeProc' is affined to another thread!!" - activeProcessAffined := (self threadAffinityOfProcess: activeProc) ~= 0! Item was changed: ----- Method: CogThreadManager class>>initialize (in category 'class initialization') ----- initialize "CogThreadManager initialize" CTMUninitialized := 0. CTMInitializing := 1. CTMUnavailable := 2. "off doing its own thing and not available to run the VM, e.g. calling-out." CTMAssignableOrInVM := 3. "either owning the VM or blocked on its osSemaphore available for VM work" CTMWantingOwnership := 4. "with something specific to do in the VM (e.g. return a result from a call-out, make a call-back)" CTMUnknownOwner := -1. "Define the size of the stack of processes at time of disown/own." AWOLProcessesIncrement := 4. + OwnerLogSize := 100 * 1024.! - OwnerLogSize := 1024.! Item was changed: ----- Method: CogThreadManager>>copyLogTo: (in category 'logging') ----- copyLogTo: aPointer | bufferPointer bytesCopied index startIndex bytesToCopy | <var: #aPointer type: #'char *'> <var: #bufferPointer type: #'char *'> bufferPointer := aPointer. index := self atomic_load: (self addressOf: ownerLogIndex). bytesCopied := 0. + "NOTE: The ownerLogWrapped isn't synchronized atomically. Therefore, if this primitive is called exactly when we start wrapping the very first time, we'll read the wrong value here. + However, as this is very unlikely, don't bother fixing this (yet)." + ownerLogWrapped ifTrue: [ |entriesToSpare| + "NOTE: The owner log is still written to whilst this primitive is running. + Therefore copy only 90% of the log, such that the remaining 10% can be spared + to still be written." + entriesToSpare := OwnerLogSize / 10. + startIndex := index + entriesToSpare min: (OwnerLogSize - 1). - However, as this is very unlikely, don't bother fixing this yet." - ownerLogWrapped ifTrue: [ - "If we've reached the limit of our Ringbuffer, deliberately don't copy the last 100 entries, - so that new log entries don't overwrite during the memcpy." - startIndex := index + 100 min: (OwnerLogSize - 1). bytesToCopy := (OwnerLogSize - startIndex) * (self sizeof: CogVMOwnerLog). self memcpy: bufferPointer _: ownerLog + startIndex _: bytesToCopy. bytesCopied := bytesCopied + bytesToCopy]. bytesToCopy := index * (self sizeof: CogVMOwnerLog). self memcpy: bufferPointer + bytesCopied _: ownerLog _: bytesToCopy. bytesCopied := bytesCopied + bytesToCopy. ^ bytesCopied ! Item was changed: ----- Method: FilePlugin>>primitiveFileReadPinningAndDisowning (in category 'file primitives') ----- primitiveFileReadPinningAndDisowning "This version of primitiveFileRead is for garbage collectors that support pinning + and the multi-threaded VM. It actually does the own/disown dance if the bytearray is pinned." + | count startIndex array file slotSize elementSize bytesRead vmHandle | - and the multi-threaded VM. It actually does the own/disown dance." - | count startIndex array file slotSize elementSize bytesRead vmHandle wasPinned | <inline: true> <var: 'file' type: #'SQFile *'> <var: 'count' type: #'size_t'> <var: 'startIndex' type: #'size_t'> <var: 'slotSize' type: #'size_t'> <var: 'elementSize' type: #'size_t'> count := interpreterProxy positiveMachineIntegerValueOf: (interpreterProxy stackValue: 0). startIndex := interpreterProxy positiveMachineIntegerValueOf: (interpreterProxy stackValue: 1). array := interpreterProxy stackValue: 2. file := self fileValueOf: (interpreterProxy stackValue: 3). + vmHandle := nil. (interpreterProxy failed "buffer can be any indexable words or bytes object except CompiledMethod" or: [(interpreterProxy isWordsOrBytes: array) not]) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. slotSize := interpreterProxy slotSizeOf: array. (startIndex >= 1 and: [startIndex + count - 1 <= slotSize]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. + (interpreterProxy isPinned: array) ifTrue: + [vmHandle := interpreterProxy disownVM: DisownVMForThreading]. - (wasPinned := interpreterProxy isPinned: array) ifFalse: - [array := interpreterProxy pinObject: array]. - vmHandle := interpreterProxy disownVM: DisownVMForThreading. "Note: adjust startIndex for zero-origin byte indexing" elementSize := slotSize = 0 ifTrue: [1] ifFalse: [(interpreterProxy byteSizeOf: array) // slotSize]. bytesRead := self sqFile: file Read: count * elementSize Into: (interpreterProxy cCoerce: (interpreterProxy firstIndexableField: array) to: #'char *') At: startIndex - 1 * elementSize. + vmHandle ifNotNil: + [interpreterProxy ownVM: vmHandle]. + - interpreterProxy ownVM: vmHandle. - wasPinned ifFalse: - [interpreterProxy unpinObject: array]. interpreterProxy failed ifFalse: [interpreterProxy methodReturnInteger: bytesRead // elementSize] "answer # of elements read"! Item was changed: ----- Method: SocketPlugin>>primitiveSocketCloseConnection: (in category 'primitives') ----- primitiveSocketCloseConnection: socket | s | <var: #s type: 'SocketPtr '> self primitive: 'primitiveSocketCloseConnection' parameters: #(Oop). s := self socketValueOf: socket. interpreterProxy failed ifFalse: [ + self sqSocketCloseConnection: s isPinned: (interpreterProxy isPinned: socket)]! - self sqSocketCloseConnection: s]! Item was added: + ----- Method: SocketPluginSimulator>>sqSocketCloseConnection:isPinned: (in category 'simulation') ----- + sqSocketCloseConnection: socketHandleCArray isPinned: isPinned + + |result handle| + isPinned ifTrue: [handle := interpreterProxy disownVM: DisownVMForThreading]. + result := [Socket basicNew + primSocketCloseConnection: ((self hostSocketHandleFromSimSocketHandle: socketHandleCArray) ifNil: [^false])] + on: SocketPrimitiveFailed + do: [:ex| + interpreterProxy primitiveFail. + false]. + isPinned ifTrue: [interpreterProxy ownVM: handle]. + ^ result! Item was changed: ----- Method: SqueakSSLPlugin>>primitiveConnect (in category 'primitives') ----- primitiveConnect "Primitive. Starts or continues a client handshake using the provided data. Will eventually produce output to be sent to the server. Requires the host name to be set for the session. Returns: > 0 - Number of bytes to be sent to the server 0 - Success. The connection is established. -1 - More input is required. < -1 - Other errors. " + | start srcLen dstLen srcOop dstOop handle srcPtr dstPtr result vmHandle canDisown | - | start srcLen dstLen srcOop dstOop handle srcPtr dstPtr result wasSrcPinned wasDestPinned vmHandle | <var: #srcPtr type: #'char *'> <var: #dstPtr type: #'char *'> <export: true> interpreterProxy methodArgumentCount = 5 ifFalse:[^interpreterProxy primitiveFail]. dstOop := interpreterProxy stackValue: 0. srcLen := interpreterProxy stackIntegerValue: 1. start := interpreterProxy stackIntegerValue: 2. srcOop := interpreterProxy stackValue: 3. handle := interpreterProxy stackIntegerValue: 4. interpreterProxy failed ifTrue:[^nil]. ((start > 0 and:[srcLen >= 0]) and:[(interpreterProxy isBytes: srcOop) and:[(interpreterProxy isBytes: dstOop) and:[(interpreterProxy byteSizeOf: srcOop) >= (start + srcLen - 1)]]]) ifFalse:[^interpreterProxy primitiveFail]. - "Careful!! The object may move when being pinned!!" - (wasSrcPinned := interpreterProxy isPinned: srcOop) - ifFalse: [srcOop := interpreterProxy pinObject: srcOop]. - (wasDestPinned := interpreterProxy isPinned: dstOop) - ifFalse: [dstOop := interpreterProxy pinObject: dstOop]. - - "Pinning may fail (only if we're out of memory)" - (srcOop isNil or: [dstOop isNil]) - ifTrue: [^ interpreterProxy primitiveFail]. - srcPtr := interpreterProxy firstIndexableField: srcOop. dstPtr := interpreterProxy firstIndexableField: dstOop. srcPtr := srcPtr + start - 1. dstLen := interpreterProxy byteSizeOf: dstOop. + canDisown := (interpreterProxy isPinned: srcOop) and: [interpreterProxy isPinned: dstOop]. + canDisown ifTrue: [vmHandle := interpreterProxy disownVM: DisownVMForThreading]. - "vmHandle := interpreterProxy disownVM: DisownVMForThreading." result := self cCode: 'sqConnectSSL(handle, srcPtr, srcLen, dstPtr, dstLen)' inSmalltalk:[handle. srcPtr. srcLen. dstPtr. dstLen. -2]. + + canDisown ifTrue: [interpreterProxy ownVM: vmHandle]. - "interpreterProxy ownVM: vmHandle." - wasSrcPinned ifFalse: [interpreterProxy unpinObject: srcOop]. - wasDestPinned ifFalse: [interpreterProxy unpinObject: dstOop]. - interpreterProxy failed ifTrue:[^nil]. interpreterProxy pop: interpreterProxy methodArgumentCount+1. interpreterProxy pushInteger: result.!

1 0

VM Maker: VMMaker.threaded-LM.3353.mcz
by commits＠source.squeak.org 21 Dec '23

21 Dec '23

1 0

Please test | Relase candidate for OSVM 2023
by Taeumel, Marcel 21 Dec '23

21 Dec '23

Hi all -- Please test this VM version (includes a small change log): https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/202311211431 Choose your preferred platform. Focus on cog.spur flavors for 64-bit machines. Thank you! Best, Marcel

9 26

[OpenSmalltalk/opensmalltalk-vm] Pre-release 202312181441 - 202312181441
by github-actions[bot] 20 Dec '23

20 Dec '23

-- View it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/202312181441 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/releases/134633678(a)github.com>

1 0

[OpenSmalltalk/opensmalltalk-vm]
by Marcel Taeumel 20 Dec '23

20 Dec '23

Branch: refs/tags/202312181441 Home: https://github.com/OpenSmalltalk/opensmalltalk-vm

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev December 2023