Vm-dev December 2023

vm-dev@lists.squeakfoundation.org

14 participants
33 discussions

[OpenSmalltalk/opensmalltalk-vm] cc2dd9: [osx] Fix Drag-n-drop
by Tobias Pape 19 Dec '23

19 Dec '23

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: cc2dd909045721f6cbf16cb62f5662fe68158021 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/cc2dd909045721f6cb… Author: Tobias Pape <tobias(a)netshed.de> Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M platforms/iOS/vm/OSX/SqSqueakOSXView.m.inc Log Message: ----------- [osx] Fix Drag-n-drop Old-style `NSFilenamesPboardType` would give an array of (string) file names. New-style `NSPasteboardTypeFileURL` gives exactly one file URL. Also, all file urls are Reference-type urls which we must massage first.

4 8

[OpenSmalltalk/opensmalltalk-vm] On RaspPi4 w/ Nov23 OS, --enable-fast-bitblt not linking as expected (Issue #671)
by Marcel Taeumel 14 Dec '23

14 Dec '23

Since Raspberry Pi OS November 2023, there is a 64-bit kernel and thus `uname -m` answers `aarch64`, even though userland is still 32-bit. Does probably only affect Pi4, not Pi5. So, our `configure` script for unix builds is probably broken in that sense: - https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/833bc124c29fc8573b38… The linker will choose `BitBltArm64.o` instead of `BitBltArm.o`. -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/671 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/issues/671(a)github.com>

4 4

Questions about weakling-finalization vs. ephemeron-finalization
by Taeumel, Marcel 13 Dec '23

13 Dec '23

Hi Eliot -- vm-dev in CC I am currently looking into using ephemerons in Squeak Trunk. There, I noticed the possibility to also let the VM/GC enqueue weaklings into the mourning-queue. Even in Pharo 12, I could not find this feature used. Only ephemeron mourning, no weakling mourning. Is this an older feature? To me, it seems that mourning over ephemerons should be enough to provide robust and efficient in-image finalization (or just removal from surrounding containers, e.g., action maps). If we would mourn over all weaklings as well, we could potentially get notified about every element in a larger WeakArray being nil'ed ... with #mourn being a no-op because this is how many larger WeakArrays are used: only the next insert/remove will check for the next possible slot or whether to grow/shrink. No "finalization" needed there. So ... at this time ... there a benefit of enabling weakling-finalization besides ephemeron-based finalization? (Note that this is unrelated to have a finalization semaphore being signalled whenver we should start processing the mourning queue. So, the comment in #supportsQueueingFinalization: is a bit misleading.) Best, Marcel

1 1

VM Maker: VMMaker.oscog-topa.3346.mcz
by commits＠source.squeak.org 12 Dec '23

12 Dec '23

Tobias Pape uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-topa.3346.mcz ==================== Summary ==================== Name: VMMaker.oscog-topa.3346 Author: topa Time: 12 December 2023, 2:01:22.797575 pm UUID: 3dd5b91b-eb78-4b0a-8a75-f210e427aae7 Ancestors: VMMaker.oscog-mt.3345 Fix precedence. This did not work in either Smalltalk/SLANG nor C and clang now is upset. =============== Diff against VMMaker.oscog-mt.3345 =============== Item was changed: ----- Method: B3DAcceleratorPlugin>>stackPrimitiveVertexArray:ofSize: (in category 'primitive support') ----- stackPrimitiveVertexArray: index ofSize: nItems "Load a primitive vertex array from the interpreter stack. Return a pointer to the vertex data if successful, nil otherwise." | oop oopSize | <inline: false> <returnTypeC:'void*'> oop := interpreterProxy stackObjectValue: index. oop = nil ifTrue:[^nil]. (interpreterProxy isWords: oop) ifTrue:[ oopSize := interpreterProxy slotSizeOf: oop. + (oopSize >= (nItems * 16) and:[oopSize \\ 16 = 0]) - (oopSize >= nItems * 16 and:[oopSize \\ 16 = 0]) ifTrue:[^interpreterProxy firstIndexableField: oop]]. ^nil!

1 0

[OpenSmalltalk/opensmalltalk-vm] primitiveDoNamedPrimitiveWithArgs fails for B2DPlugin primitives (Issue #670)
by Christoph Thiede 12 Dec '23

12 Dec '23

`thisContext tryNamedPrimitiveIn: BalloonEngine>>#primGetFailureReason for: BalloonEngine new withArgs: #()` should answer the same as `BalloonEngine new primGetFailureReason`, but instead the meta primitive fails with error 106, which is not even documented in `Context>>#tryNamedPrimitiveIn:for:withArgs:`. The same is also true for at least `primFlushNeeded`. In consequence, one cannot debug/simulate some Balloon code at the moment ... -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/670 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/issues/670(a)github.com>

1 0

Re: [OpenSmalltalk/opensmalltalk-vm] For macOS, support applicationSupportsSecureRestorableState to avoid warning on modern macOS (12+), Intel-based platforms. Thanks Juan for the hint! (833bc12)
by Marcel Taeumel 12 Dec '23

12 Dec '23

I suppose this fix also benefits ARMv8 users on macOS 12+, not just Intel-based Macs. -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/833bc124c29fc8573b… You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/commit/833bc124c29fc8573b386eca4c24b94d1f96a1a5/134773131(a)github.com>

1 0

[OpenSmalltalk/opensmalltalk-vm] Mixed-arithmetic handling only works for float+int, not int+float (Issue #669)
by Marcel Taeumel 11 Dec '23

11 Dec '23

I played around with VM parameter 75. It does indeed show a change for the float-based primitives (i.e., 541, 542, ...) but not the integer-based primitives (i.e., 1, 2, 3, ...). Is this expected behavior? In the VMMaker sources, it looks like it should work at least for comparisons (i.e., 3 to 8): ```Smalltalk genPrimitiveLessThan ^coInterpreter primitiveDoMixedArithmetic ifTrue: [self genSmallIntegerComparison: JumpLess orDoubleComparison: #JumpFPGreater: invert: true] ifFalse: [self genSmallIntegerComparison: JumpLess] ``` Is `genPrimitiveLessThan` not the one in charge here? Hm.... -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/669 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/issues/669(a)github.com>

2 3

VM Maker: VMMaker.threaded-LM.3352.mcz
by commits＠source.squeak.org 11 Dec '23

11 Dec '23

Leon Matthes uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.threaded-LM.3352.mcz ==================== Summary ==================== Name: VMMaker.threaded-LM.3352 Author: LM Time: 11 December 2023, 6:49:53.248534 pm UUID: 549d31a1-9ae0-4620-923d-af4ea62dff9c Ancestors: VMMaker.threaded-LM.3351 Fix a critical issue that caused duplicate threads to be spawned. Binding two processes (or the same process twice) to the same thread caused it to spawn two threads for the same CogVMThread, which of course caused critical errors as both threads might think they were in fact the vm owner, which caused all kinds of issues. =============== Diff against VMMaker.threaded-LM.3351 =============== Item was changed: ----- Method: CoInterpreterMT>>loadInitialContext (in category 'initialization') ----- loadInitialContext + | activeProc threadAffinity | - | activeProc | super loadInitialContext. activeProc := self activeProcess. + threadAffinity := self threadAffinityOfProcess: activeProc. + self assert: (threadAffinity = 0 or: [threadAffinity = 1]). "TODO: Ensure we cannot save an image, where the 'activeProc' is affined to another thread!!" - self assert: (self threadAffinityOfProcess: activeProc) = 0. activeProcessAffined := (self threadAffinityOfProcess: activeProc) ~= 0! Item was changed: ----- Method: CogThreadManager>>startThreadForThreadInfo: (in category 'scheduling') ----- startThreadForThreadInfo: vmThread <var: #vmThread type: #'CogVMThread *'> <inline: false> + vmThread vmThreadState ~= CTMUninitialized + ifTrue: [^true "Already started"]. + self assert: vmThread vmThreadState = CTMUninitialized. vmThread setVmThreadState: CTMInitializing. "self cCode: '' inSmalltalk: [coInterpreter transcript cr; nextPutAll: 'starting VM thread '; print: vmThread index; flush. (thisContext home stackOfSize: 10) do: [:ctxt| coInterpreter transcript cr; print: ctxt; flush]]." (self ioNewOS: (self cCoerce: #startVMThread: to: 'void (*)(void*)') Thread: vmThread) = 0 ifTrue: [self ioTransferTimeslice. ^true]. memoryIsScarce := true. "self cCode: [coInterpreter print: 'ERVT failed to spawn so memory is scarce'; cr]" ^false!

1 0

VM Maker: VMMaker.threaded-LM.3352.mcz
by commits＠source.squeak.org 11 Dec '23

11 Dec '23

1 0

VM Maker: CogTools.threaded-LM.98.mcz
by commits＠source.squeak.org 11 Dec '23

11 Dec '23

Leon Matthes uploaded a new version of CogTools to project VM Maker: http://source.squeak.org/VMMaker/CogTools.threaded-LM.98.mcz ==================== Summary ==================== Name: CogTools.threaded-LM.98 Author: LM Time: 11 December 2023, 6:45:51.961251 pm UUID: 5ddbc164-f9fa-4ef9-95f3-b4197e06ad8a Ancestors: CogTools.threaded-LM.97 Add a small GUI to the ThreadInspector. =============== Diff against CogTools.threaded-LM.97 =============== Item was changed: Model subclass: #ThreadInspector + instanceVariableNames: 'startTime ownerLog graph currentStartTime currentEndTime' - instanceVariableNames: 'startTime ownerLog' classVariableNames: '' poolDictionaries: '' category: 'CogTools-ThreadInspector'! Item was added: + ----- Method: ThreadInspector>>afterBuildWith: (in category 'as yet unclassified') ----- + afterBuildWith: builder + + self initializeGraph. + self plotGraphFrom: startTime to: self ownerLog last timestamp. + (builder widgetAt: #PlotViewport) + addMorph: graph + fullFrame: (LayoutFrame fractions: (0@0 corner: 1@1)).! Item was added: + ----- Method: ThreadInspector>>buildWith: (in category 'as yet unclassified') ----- + buildWith: builder + + |windowSpec window| + windowSpec := builder pluggableWindowSpec new. + windowSpec + model: self; + label: 'VM Owner Inspector'; + extent: 400@400; + children: (self windowMemberSpecsFor: builder). + + window := builder build: windowSpec. + self afterBuildWith: builder. + ^ window! Item was added: + ----- Method: ThreadInspector>>currentEndTime (in category 'accessing') ----- + currentEndTime + + ^ currentEndTime! Item was added: + ----- Method: ThreadInspector>>currentEndTime: (in category 'accessing') ----- + currentEndTime: anObject + + currentEndTime := anObject.! Item was added: + ----- Method: ThreadInspector>>currentStartTime (in category 'accessing') ----- + currentStartTime + + ^ currentStartTime! Item was added: + ----- Method: ThreadInspector>>currentStartTime: (in category 'accessing') ----- + currentStartTime: anObject + + currentStartTime := anObject.! Item was added: + ----- Method: ThreadInspector>>graph (in category 'accessing') ----- + graph + + ^ graph! Item was added: + ----- Method: ThreadInspector>>graph: (in category 'accessing') ----- + graph: anObject + + graph := anObject.! Item was added: + ----- Method: ThreadInspector>>initialize (in category 'as yet unclassified') ----- + initialize + + self currentStartTime: 0. + self currentEndTime: 1. + ! Item was added: + ----- Method: ThreadInspector>>initializeGraph (in category 'plotting') ----- + initializeGraph + + graph := ThreadInspectorPlotMorph new + model: self; + yourself. + graph + series: #vmOwner color: Color green; + series: #vmOwner description: 'vm owner'; + series: #vmOwner type: #stepped. + + graph + series: #failedLocks color: Color red; + series: #failedLocks description: 'failed locking attempts'; + series: #failedLocks drawLine: false; + series: #failedLocks width: 2. + + graph xAxisFormatter: [:value | + ((value - (self currentStartTime)/ 1000) asFloat printShowingMaxDecimalPlaces: 4), ' ms']. + + "make sure we always have at least -1, 0 and 1 in view, even if there were no owner switches to them." + graph minPoint y > -1 + ifTrue: [graph limitMinY: -1]. + graph maxPoint y < 1 + ifTrue: [graph limitMaxY: 1].! Item was added: + ----- Method: ThreadInspector>>menuBarHeight (in category 'as yet unclassified') ----- + menuBarHeight + + ^ Preferences standardButtonFont height * 3! Item was added: + ----- Method: ThreadInspector>>menuBarSpec: (in category 'as yet unclassified') ----- + menuBarSpec: builder + + ^ builder pluggablePanelSpec new + model: self; + frame: (LayoutFrame new + leftFraction: 0; + rightFraction: 1; + topFraction: 1 offset: self menuBarHeight negated; + bottomFraction: 1; + yourself); + children: { + builder pluggableButtonSpec new + model: self; + action: #zoomOut; + label: 'Zoom out'; + frame: LayoutFrame fullFrame; + yourself. + }! Item was added: + ----- Method: ThreadInspector>>open (in category 'as yet unclassified') ----- + open + + (self buildWith: ToolBuilder default) openInWorld.! Item was added: + ----- Method: ThreadInspector>>plotGraphFrom:to: (in category 'plotting') ----- + plotGraphFrom: startTime to: endTime + + | successful failed startIndex endIndex lastVMOwner | + graph clear. + + successful := self ownerLog select: #successfulSwitch. + failed := self ownerLog select: [:entry | entry successfulSwitch not and: [entry timestamp between: startTime and: endTime]]. + + startIndex := (successful findLast: [:entry | entry timestamp <= startTime]). + startIndex := startIndex max: 1. + + endIndex := (successful findLast: [:entry | entry timestamp <= endTime]). + endIndex := endIndex max: 1. + startIndex to: endIndex + do: [:index | |entry timestamp | + entry := (successful at: index). + "The first entry that we want to visualize may be before the start time, but because + we only want to show the plot from the start time, make sure to 'round up' in that case." + timestamp := (entry timestamp max: startTime) min: endTime. + graph series: #vmOwner addPoint: timestamp @ entry vmOwner]. + lastVMOwner := (successful at: endIndex) vmOwner. + graph series: #vmOwner addPoint: endTime @ lastVMOwner. + + failed do: [:entry | graph series: #failedLocks addPoint: entry timestamp @ entry vmOwner]. + + graph + limitMinX: startTime; + limitMaxX: endTime. + self currentStartTime: startTime. + self currentEndTime: endTime.! Item was added: + ----- Method: ThreadInspector>>plotSpec: (in category 'as yet unclassified') ----- + plotSpec: builder + + ^ builder pluggablePanelSpec new + model: self; + frame: (LayoutFrame new + leftFraction: 0; + topFraction: 0; + rightFraction: 1; + bottomFraction: 1 offset: self menuBarHeight negated; + yourself); + name: #PlotViewport; + children: {}; + yourself! Item was removed: - ----- Method: ThreadInspector>>primitiveMillisecondsNow (in category 'primitives') ----- - primitiveMillisecondsNow - <primitive: 245> - ^ self primitiveFailed! Item was added: + ----- Method: ThreadInspector>>primitiveTimeNow (in category 'primitives') ----- + primitiveTimeNow + <primitive: 245> + ^ self primitiveFailed! Item was added: + ----- Method: ThreadInspector>>selectProportionFrom:to: (in category 'plotting') ----- + selectProportionFrom: lowPortion to: highPortion + + |timeRange| + timeRange := self currentEndTime - self currentStartTime. + self plotGraphFrom: self currentStartTime + (timeRange * lowPortion) rounded + to: self currentStartTime + (timeRange * highPortion) rounded.! Item was changed: + ----- Method: ThreadInspector>>spyOn: (in category 'profiling') ----- - ----- Method: ThreadInspector>>spyOn: (in category 'as yet unclassified') ----- spyOn: aBlock | newStartTime | + newStartTime := self primitiveTimeNow. - newStartTime := self primitiveMillisecondsNow. aBlock value. "Only update the startTime & ownerLog if the block succeeded." self startTime: newStartTime. self ownerLog: self getOwnerLogFromVM.! Item was changed: + ----- Method: ThreadInspector>>visualize (in category 'plotting') ----- - ----- Method: ThreadInspector>>visualize (in category 'as yet unclassified') ----- visualize + self initializeGraph. + self plotGraphFrom: self startTime to: self ownerLog last timestamp. - | pm startIndex lastVMOwner | - pm := ThreadInspectorPlotMorph new. - pm - series: #vmOwner color: Color green; - series: #vmOwner description: 'vm owner'; - series: #vmOwner type: #stepped. + graph openInWorld.! - pm - series: #failedLocks color: Color red; - series: #failedLocks description: 'failed locking attempts'; - series: #failedLocks drawLine: false. - - startIndex := (self ownerLog findLast: [:entry | entry successfulSwitch and: [entry timestamp <= self startTime]]). - startIndex := startIndex max: 1. - startIndex to: self ownerLog size - do: [:index | |entry series | - entry := (self ownerLog at: index). - series := entry successfulSwitch ifTrue: [#vmOwner] ifFalse: [#failedLocks]. - pm series: series addPoint: entry timestamp @ entry vmOwner]. - lastVMOwner := (self ownerLog at: (self ownerLog findLast: [:entry | entry successfulSwitch])) vmOwner. - pm series: #vmOwner addPoint: self ownerLog last timestamp@ lastVMOwner. - "make sure we always have at least -1, 0 and 1 in view, even if there were no owner switches to them." - pm minPoint y > -1 - ifTrue: [pm limitMinY: -1]. - pm maxPoint y < 1 - ifTrue: [pm limitMaxY: 1]. - - pm openInWorld. - ! Item was added: + ----- Method: ThreadInspector>>windowMemberSpecsFor: (in category 'as yet unclassified') ----- + windowMemberSpecsFor: builder + + ^ { + self plotSpec: builder. + self menuBarSpec: builder. + }! Item was added: + ----- Method: ThreadInspector>>zoomOut (in category 'plotting') ----- + zoomOut + + self plotGraphFrom: startTime to: self ownerLog last timestamp.!

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev December 2023