Vm-dev December 2023

vm-dev@lists.squeakfoundation.org

14 participants
33 discussions

VM Maker: VMMaker.threaded-LM.3351.mcz
by commits＠source.squeak.org 11 Dec '23

11 Dec '23

Leon Matthes uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.threaded-LM.3351.mcz ==================== Summary ==================== Name: VMMaker.threaded-LM.3351 Author: LM Time: 11 December 2023, 5:15:46.245581 pm UUID: b0fab7fd-14f0-4711-8797-67aa939e295f Ancestors: VMMaker.threaded-LM.3350 Use Micro instead of milli-seconds for logging VM owner switches =============== Diff against VMMaker.threaded-LM.3350 =============== Item was changed: ----- Method: CogThreadManager>>saveOwnerSwitchTo:successful: (in category 'logging') ----- saveOwnerSwitchTo: newOwner successful: aBoolean <var: #logEntry type: 'CogVMOwnerLog *'> <var: #currentIndex type: 'int'> <var: #newIndex type: 'int'> | currentIndex newIndex timestamp logEntry | + timestamp := coInterpreter ioUTCMicrosecondsNow. - timestamp := coInterpreter ioMSecs. currentIndex := self atomic_load: (self addressOf: ownerLogIndex). self cCode: '' inSmalltalk: [currentIndex := AtomicValue newFrom: currentIndex]. [newIndex := currentIndex + 1 \\ OwnerLogSize. self atomic: (self addressOf: ownerLogIndex) _compare: (self addressOf: currentIndex) _exchange_strong: newIndex] whileFalse: []. newIndex < currentIndex ifTrue: [ownerLogWrapped := true]. logEntry := (self addressOf: (ownerLog at: (self cCode: [currentIndex] inSmalltalk: [currentIndex value]))). logEntry timestamp: timestamp; successfulSwitch: aBoolean; vmOwner: newOwner.!

1 0

VM Maker: VMMaker.threaded-LM.3350.mcz
by commits＠source.squeak.org 11 Dec '23

11 Dec '23

Leon Matthes uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.threaded-LM.3350.mcz ==================== Summary ==================== Name: VMMaker.threaded-LM.3350 Author: LM Time: 11 December 2023, 5:12:31.161674 pm UUID: a0133d03-fcf9-4875-8abc-a1bc9468e56c Ancestors: VMMaker.threaded-LM.3349 Make sure the InterpreterProxy and friends follow the new ownVM/disownVM API. =============== Diff against VMMaker.threaded-LM.3349 =============== Item was changed: ----- Method: InterpreterProxy>>disownVM: (in category 'FFI support') ----- disownVM: flags + <returnTypeC: #'void *'> ^self notYetImplementedError! Item was changed: ----- Method: InterpreterProxy>>ownVM: (in category 'FFI support') ----- + ownVM: handle + <var: #handle type: #'void*'> - ownVM: flags ^self notYetImplementedError! Item was changed: ----- Method: NewObjectMemory>>disownVM: (in category 'simulation only') ----- disownVM: flags + <returnTypeC: #'void*'> "hack around the CoInterpreter/ObjectMemory split refactoring" <doNotGenerate> ^coInterpreter disownVM: flags! Item was changed: ----- Method: NewObjectMemory>>ownVM: (in category 'simulation only') ----- + ownVM: handle - ownVM: flags "hack around the CoInterpreter/ObjectMemory split refactoring" <doNotGenerate> + <var: #handle type: #'void *'> + ^coInterpreter ownVM: handle! - ^coInterpreter ownVM: flags! Item was changed: ----- Method: SpurMemoryManager>>disownVM: (in category 'simulation only') ----- disownVM: flags + <returnTypeC: #'void*'> "hack around the CoInterpreter/ObjectMemory split refactoring" <doNotGenerate> ^coInterpreter disownVM: flags! Item was changed: ----- Method: SpurMemoryManager>>ownVM: (in category 'simulation only') ----- + ownVM: handle - ownVM: flags "hack around the CoInterpreter/ObjectMemory split refactoring" <doNotGenerate> + <var: #handle type: #'void *'> + ^coInterpreter ownVM: handle! - ^coInterpreter ownVM: flags!

1 0

VM Maker: VMMaker.threaded-LM.3350.mcz
by commits＠source.squeak.org 11 Dec '23

11 Dec '23

1 0

[OpenSmalltalk/opensmalltalk-vm] 833bc1: For macOS, support applicationSupportsSecureRestor...
by Marcel Taeumel 11 Dec '23

11 Dec '23

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 833bc124c29fc8573b386eca4c24b94d1f96a1a5 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/833bc124c29fc8573b… Author: Marcel Taeumel <marcel.taeumel(a)hpi.de> Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: M platforms/iOS/vm/OSX/SqueakOSXAppDelegate.m Log Message: ----------- For macOS, support applicationSupportsSecureRestorableState to avoid warning on modern macOS (12+), Intel-based platforms. Thanks Juan for the hint!

1 0

[OpenSmalltalk/opensmalltalk-vm] Crash in macOS ARM upon disabling primitive mixed-arithmetics handling (Issue #667)
by Cristián Pérez 09 Dec '23

09 Dec '23

Hi folks, First some context: - I'm working on an M1 Pro, macOS 14.1, **no Rosetta**, fully native. - This was first discovered on **Cuis** but I reproduced it in **Squeak** as well. - I'm using the latest release of the VM from this repository while using Cuis. For Squeak I'm using the latest AIO release. I've tried to disable primitive mixed-arithmetics handling by the two following ways, getting the same results. ```smalltalk Smalltalk vmParameterAt: 48 put: 64 ``` ```smalltalk Smalltalk vmParameterAt: 75 put: false ``` Here is the trace I get when it crashes ``` C stack backtrace & registers: x0 0x104908657 x1 0x10f7c1b70 x2 0x0 x3 0x104940010 x4 0x1b588bb3 x5 0x10492e940 x6 0x11345d358 x7 0x1126efcd8 x8 0x259 x9 0x10f795690 x10 0x10f7c1b00 x11 0x112200000 x12 0x50 x13 0x50 x14 0x10493f000 x15 0x10f7c1b00 x16 0x10492be50 x17 0x7 x18 0x10493fff0 x19 0x0 x20 0x0 x21 0x113389900 x22 0x10491f000 x23 0x10491f000 x24 0x10491f000 x25 0x10491f000 x26 0x10491f000 x27 0x10492bd38 x29 0x0 fp 0x10491f000 lr 0x16b598db0 sp 0x104815aa0 0 ??? 0x000000010f795690 0x0 + 4554577552 1 Squeak 0x0000000104898c9c reportStackState + 840 2 Squeak 0x0000000104899020 sigsegv + 240 3 libsystem_platform.dylib 0x0000000186b33a24 _sigtramp + 56 4 Squeak 0x0000000104815aa0 returntoExecutive + 128 5 Squeak 0x000000010481b0e8 ceSendsupertonumArgs + 1084 6 ??? 0x000000010f794178 0x0 + 4554572152 7 Squeak 0x0000000104809268 interpret + 660 8 Squeak 0x000000010489a488 -[sqSqueakMainApplication runSqueak] + 424 9 Foundation 0x0000000187d99aac __NSFirePerformWithOrder + 296 10 CoreFoundation 0x0000000186be10a0 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 36 11 CoreFoundation 0x0000000186be0f8c __CFRunLoopDoObservers + 532 12 CoreFoundation 0x0000000186be05bc __CFRunLoopRun + 776 13 CoreFoundation 0x0000000186bdfc5c CFRunLoopRunSpecific + 608 14 HIToolbox 0x0000000191159448 RunCurrentEventLoopInMode + 292 15 HIToolbox 0x00000001911590d8 ReceiveNextEventCommon + 220 16 HIToolbox 0x0000000191158fdc _BlockUntilNextEventMatchingListInModeWithFilter + 76 17 AppKit 0x000000018a3bac54 _DPSNextEvent + 660 18 AppKit 0x000000018ab90ebc -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 716 19 AppKit 0x000000018a3ae100 -[NSApplication run] + 476 20 AppKit 0x000000018a3853cc NSApplicationMain + 880 21 dyld 0x00000001867890e0 start + 2360 ``` -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/667 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/issues/667(a)github.com>

6 16

5.0-202311211431-64bit ARM64/Aarch64 Unit Test Results
by ken.dickey＠whidbey.com 08 Dec '23

08 Dec '23

Looks like I need to take a deep dive into each of these, but I am getting odd breakages on Aarch64 Linux SoCs. In each case, I am updating Linux to latest, building a VM on local machine from sources at: https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/202311211431 downloading a Squeak image from Squeak.org: https://files.squeak.org/6.0/Squeak6.0-22104-64bit/Squeak6.0-22104-64bit.zip updating Squeak to latest (22142) and running all unit tests. Synopis: ----Raspberry Pi 4/Aarch64/Raspian Linux---- 5376 run in 0:00:15:56.159, 5289 passes, 51 expected failures, 24 failures, 12 errors, 0 unexpected passes -------------------------------------------- ---------PineBook/Aarch64/Manjaro Linux----- 5376 run in 0:00:10:17.503, 5305 passes, 51 expected failures, 19 failures, 1 errors, 0 unexpected passes -------------------------------------------- -------LePotato/Aarch64/Armbian Linux------- 5376 run in 0:00:19:24.591, 5266 passes, 51 expected failures, 45 failures, 14 errors, 0 unexpected passes ------------------------------------------- I am noting console reports, usually SSL failures, but of note: sqAllocateMemorySegmentOfSizeAboveAllocatedSizeInto mmap: Cannot allocate memory Details attached. FYI, -KenD

1 0

VM Maker: VMMaker.oscog-mt.3345.mcz
by commits＠source.squeak.org 08 Dec '23

08 Dec '23

Marcel Taeumel uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-mt.3345.mcz ==================== Summary ==================== Name: VMMaker.oscog-mt.3345 Author: mt Time: 8 December 2023, 10:38:26.611445 am UUID: d976ade6-fda9-834f-85fe-5ce5c4f45a21 Ancestors: VMMaker.oscog-mt.3344 Fixes inconsistency between setting image-header flags from within the image and then storing them in snapshots: - preserve now officially unused 16r20 in both single-threaded and multi-threaded VMs - fileTimesInUTC could be set but was not stored, is it actually used somewhere? =============== Diff against VMMaker.oscog-mt.3344 =============== Item was changed: ----- Method: CoInterpreter>>getImageHeaderFlags (in category 'image save/restore') ----- getImageHeaderFlags "Answer the flags that are contained in the 7th long of the image header." ^fullScreenFlag "0 or 1" + (VMBIGENDIAN ifTrue: [0] ifFalse: [2]) "this is the imageFloatsLittleEndian flag" + "+ (processHasThreadAffinity ifTrue: [4] ifFalse: [0]) -- see MT VM" + (flagInterpretedMethods ifTrue: [8] ifFalse: [0]) + (preemptionYields ifTrue: [0] ifFalse: [16r10]) + "+ 16r20 -- unassigned" + (newFinalization ifTrue: [16r40] ifFalse: [0]) + (sendWheelEvents ifTrue: [16r80] ifFalse: [0]) + (primitiveDoMixedArithmetic ifTrue: [0] ifFalse: [16r100]) + "+ 16r200 -- N.B. flag mask 16r200 is fileTimesInUTC, responded to by the FilePlugin & FileAttributesPlugin" - "N.B. flag mask 16r200 is fileTimesInUTC, responded to by the FilePlugin & FileAttributesPlugin" + (upscaleDisplayIfHighDPI ifTrue: [0] ifFalse: [16r400]) + + (imageHeaderFlags bitClear: 1+2"+4"+8+16r10"+16r20"+16r40+16r80+16r100"+16r200"+16r400) "these are any flags we do not recognize"! - + (imageHeaderFlags bitClear: 1+2+8+16r10+16r40+16r80+16r100+16r200+16r400) "these are any flags we do not recognize"! Item was changed: ----- Method: CoInterpreter>>setImageHeaderFlags: (in category 'internal interpreter access') ----- setImageHeaderFlags: flags "Set an array of flags indicating various properties of the saved image, responded to on image load. These are the same as the image header flags shifted right two bits, omitting the fullScreenFlag and float byte order flag. Bit 0: if set, implies the image's Process class has threadAffinity as its 3rd inst var (zero relative) (meaningful to the MT VM only) Bit 1: if set, methods that are interpreted will have the flag bit set in their header Bit 2: if set, implies preempting a process does not put it to the back of its run queue + Bit 3: (unassigned) - Bit 3: if set, implies a threaded VM will not disown the VM if owned by the GUI thread (meaningful to the MT VM only) Bit 4: if set, implies the new finalization scheme where WeakArrays are queued Bit 5: if set, implies wheel events will be delivered as such and not mapped to arrow key events Bit 6: if set, implies arithmetic primitives will fail if given arguments of different types (float vs int) Bit 7: if set, implies file primitives (FilePlugin, FileAttributesPlugin) will answer file times in UTC not local times Bit 8: if set, implies the VM will not upscale the display on high DPI monitors; older VMs did this by default." flags asUnsignedInteger > 511 ifTrue: [^self primitiveFailFor: PrimErrUnsupported]. "processHasThreadAffinity := flags anyMask: 1. specific to CoInterpreterMT" imageHeaderFlags := (flags anyMask: 1) ifTrue: [imageHeaderFlags bitOr: 4] ifFalse: [imageHeaderFlags bitClear: 4]. flagInterpretedMethods := flags anyMask: 2. preemptionYields := flags noMask: 4. "noThreadingOfGUIThread := flags anyMask: 8.. specific to CoInterpreterMT" imageHeaderFlags := (flags anyMask: 8) ifTrue: [imageHeaderFlags bitOr: 32] ifFalse: [imageHeaderFlags bitClear: 32]. newFinalization := flags anyMask: 16. sendWheelEvents := flags anyMask: 32. primitiveDoMixedArithmetic := flags noMask: 64. + "fileTimesInUTC := flags anyMask: 128. see FilePlugin & FileAttributesPlugin" imageHeaderFlags := (flags anyMask: 128) ifTrue: [imageHeaderFlags bitOr: 512] ifFalse: [imageHeaderFlags bitClear: 512]. upscaleDisplayIfHighDPI := flags noMask: 256! Item was changed: ----- Method: CoInterpreterMT>>getImageHeaderFlags (in category 'image save/restore') ----- getImageHeaderFlags "Answer the flags that are contained in the 7th long of the image header." ^fullScreenFlag "0 or 1" + (VMBIGENDIAN ifTrue: [0] ifFalse: [2]) "this is the imageFloatsLittleEndian flag" + (processHasThreadAffinity ifTrue: [4] ifFalse: [0]) + (flagInterpretedMethods ifTrue: [8] ifFalse: [0]) + (preemptionYields ifTrue: [0] ifFalse: [16r10]) + "+ 16r20 -- unassigned" - "was: noThreadingOfGUIThread ifTrue: [16r20] ifFalse: [0]); a broken idea" + (newFinalization ifTrue: [16r40] ifFalse: [0]) + (sendWheelEvents ifTrue: [16r80] ifFalse: [0]) + (primitiveDoMixedArithmetic ifTrue: [0] ifFalse: [16r100]) "N.B. flag mask 16r200 is fileTimesInUTC, responded to by the FilePlugin & FileAttributesPlugin" + (upscaleDisplayIfHighDPI ifTrue: [0] ifFalse: [16r400]) + + (imageHeaderFlags bitClear: 1+2+4+8+16r10"+16r20"+16r40+16r80+16r100"+16r200"+16r400) "these are any flags we do not recognize"! - + (imageHeaderFlags bitClear: 16r7FF) "these are any flags we do not recognize"! Item was changed: ----- Method: CoInterpreterMT>>setImageHeaderFlags: (in category 'internal interpreter access') ----- setImageHeaderFlags: flags "Set an array of flags indicating various properties of the saved image, responded to on image load. These are the same as the image header flags shifted right two bits, omitting the fullScreenFlag and float byte order flag. Bit 0: if set, implies the image's Process class has threadAffinity as its 3rd inst var (zero relative) Bit 1: if set, methods that are interpreted will have the flag bit set in their header Bit 2: if set, implies preempting a process does not put it to the back of its run queue + Bit 3: (unassigned) - Bit 3: unassigned; used to mean if set, implies a threaded VM will not disown the VM if owned by the GUI thread; a broken idea Bit 4: if set, implies the new finalization scheme where WeakArrays are queued Bit 5: if set, implies wheel events will be delivered as such and not mapped to arrow key events Bit 6: if set, implies arithmetic primitives will fail if given arguments of different types (float vs int) Bit 7: if set, implies file primitives (FilePlugin, FileAttributesPlugin) will answer file times in UTC not local times Bit 8: if set, implies the VM will not upscale the display on high DPI monitors; older VMs did this by default." flags asUnsignedInteger > 511 ifTrue: [^self primitiveFailFor: PrimErrUnsupported]. (flags anyMask: 8) ifTrue: [^self primitiveFailFor: PrimErrInappropriate]. processHasThreadAffinity := flags anyMask: 1. flagInterpretedMethods := flags anyMask: 2. preemptionYields := flags noMask: 4. "was: noThreadingOfGUIThread := flags anyMask: 8. a broken idea" + imageHeaderFlags := (flags anyMask: 8) + ifTrue: [imageHeaderFlags bitOr: 32] + ifFalse: [imageHeaderFlags bitClear: 32]. newFinalization := flags anyMask: 16. sendWheelEvents := flags anyMask: 32. primitiveDoMixedArithmetic := flags noMask: 64. + "fileTimesInUTC := flags anyMask: 128. see FilePlugin & FileAttributesPlugin" imageHeaderFlags := (flags anyMask: 128) ifTrue: [imageHeaderFlags bitOr: 512] ifFalse: [imageHeaderFlags bitClear: 512]. upscaleDisplayIfHighDPI := flags noMask: 256!

1 0

VM Maker: CogTools.threaded-LM.97.mcz
by commits＠source.squeak.org 06 Dec '23

06 Dec '23

Leon Matthes uploaded a new version of CogTools to project VM Maker: http://source.squeak.org/VMMaker/CogTools.threaded-LM.97.mcz ==================== Summary ==================== Name: CogTools.threaded-LM.97 Author: LM Time: 6 December 2023, 5:40:47.431589 pm UUID: f3c69d53-4c8d-441f-989a-b691bc5b7ae7 Ancestors: CogTools.threaded-LM.96 Add a rudamentary thread inspector. =============== Diff against CogTools.threaded-LM.96 =============== Item was changed: SystemOrganization addCategory: #'CogTools-VMProfiler'! + SystemOrganization addCategory: #'CogTools-Listener'! + SystemOrganization addCategory: #'CogTools-ThreadInspector'! Item was removed: - ----- Method: AxesMorph>>drawGridOn: (in category 'drawing') ----- - drawGridOn: aCanvas - | gridColor right bottom width height lighter darker baseColor | - baseColor := self baseColor. - lighter := baseColor twiceLighter. - darker := baseColor twiceDarker. - gridColor := (lighter diff: baseColor) - > (darker diff: baseColor) ifTrue: [lighter] ifFalse: [darker]. - "" - right := self bounds width - margin. - width := self bounds width - (margin * 2). - bottom := self bounds height - margin. - height := self bounds height - (margin * 2). - (margin to: right by: width / 10) do: - [:x | | xRounded | - xRounded := x rounded. - aCanvas - line: xRounded @ margin - to: xRounded @ bottom - color: gridColor]. - (margin to: bottom by: height / 10) do: - [:y | | yRounded | - yRounded := y rounded. - aCanvas - line: margin @ yRounded - to: right @ yRounded - color: gridColor]! Item was added: + ----- Method: AxesMorph>>gridClass (in category 'accessing') ----- + gridClass + + ^ PlotMorphGrid! Item was changed: ----- Method: AxesMorph>>initialize (in category 'initialization') ----- initialize super initialize. self color: Color gray. + grid := self gridClass on: self. - grid := PlotMorphGrid on: self. xAxisFormatter := [:x | x printString]. yAxisFormatter := [:y | y printString]. self initializeCotas. margin := 15 max: (title height + 2). form := nil. self extent: 1@1.! Item was added: + ----- Method: PositionableStream>>nextChunkNoTag (in category '*CogTools-Listener') ----- + nextChunkNoTag + "Answer the contents of the receiver, up to the next terminator character. + Doubled terminators indicate an embedded terminator character. + Unlike nextChunk, do not look for ]lang[ tags." + | skippingSeparators terminator out ch | + terminator := $!!. + skippingSeparators := true. "inline skipSeparators since restoreStateOf:with: is not reliable" + out := WriteStream on: (String new: 1000). + [(ch := self next) == nil] whileFalse: + [ch == terminator ifTrue: + [self peek == terminator + ifTrue:"skip doubled terminator" + [self next] + ifFalse: + [^out contents "terminator is not doubled; we're done!!"]]. + (skippingSeparators and: [ch isSeparator]) ifFalse: + [out nextPut: ch. + skippingSeparators := false]]. + ^out contents! Item was added: + PlotMorph subclass: #RangeSelectablePlotMorph + instanceVariableNames: 'selectionStart selectionStop oldSelectionRectangle model' + classVariableNames: '' + poolDictionaries: '' + category: 'CogTools-VMProfiler'! Item was added: + ----- Method: RangeSelectablePlotMorph class>>LICENSE (in category 'LICENSE') ----- + LICENSE + ^'Project Squeak + + Copyright (c) 2005-2013, 3D Immersive Collaboration Consulting, LLC., All Rights Reserved + + Redistributions in source code form must reproduce the above copyright and this condition. + + Licensed under MIT License (MIT) + Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: + + The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. + + THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.'! Item was added: + ----- Method: RangeSelectablePlotMorph class>>model: (in category 'instance creation') ----- + model: aProfiler + ^self new model: aProfiler; yourself! Item was added: + ----- Method: RangeSelectablePlotMorph>>drawOn: (in category 'drawing') ----- + drawOn: aCanvas + + super drawOn: aCanvas. + self selectionRectangle ifNotNil: + [:selectionRectangle| + aCanvas fillRectangle: selectionRectangle color: (Color lightBlue alpha: 0.5)].! Item was added: + ----- Method: RangeSelectablePlotMorph>>invalidateSelection (in category 'selection') ----- + invalidateSelection + self selectionRectangle + ifNil: + [oldSelectionRectangle ifNotNil: + [self invalidRect: oldSelectionRectangle. + oldSelectionRectangle := nil]] + ifNotNil: + [:selectionRectangle| + self invalidRect: (oldSelectionRectangle + ifNil: [selectionRectangle] + ifNotNil: [oldSelectionRectangle merge: selectionRectangle]). + oldSelectionRectangle := selectionRectangle]! Item was added: + ----- Method: RangeSelectablePlotMorph>>model (in category 'accessing') ----- + model + ^model! Item was added: + ----- Method: RangeSelectablePlotMorph>>model: (in category 'accessing') ----- + model: anObject + "Set my model and make me me a dependent of the given object." + + model ifNotNil: [model removeDependent: self]. + anObject ifNotNil: [anObject addDependent: self]. + model := anObject! Item was added: + ----- Method: RangeSelectablePlotMorph>>mouseDown: (in category 'event handling') ----- + mouseDown: anEvent + + selectionStart := anEvent position x. + self invalidateSelection! Item was added: + ----- Method: RangeSelectablePlotMorph>>mouseMove: (in category 'event handling') ----- + mouseMove: anEvent + selectionStop := anEvent position x. + self invalidateSelection! Item was added: + ----- Method: RangeSelectablePlotMorph>>mouseUp: (in category 'event handling') ----- + mouseUp: anEvent + | selectionRect screenDrawBounds range | + selectionRect := self selectionRectangle. + screenDrawBounds := self bounds insetBy: margin. + range := screenDrawBounds width asFloat. + selectionStart := selectionStop := nil. + self invalidateSelection. + (selectionRect notNil and: [model notNil]) + ifTrue: [model + selectProportionFrom: ((selectionRect left - screenDrawBounds left) / range max: 0.0) + to: ((selectionRect right - screenDrawBounds left) / range min: 1.0)].! Item was added: + ----- Method: RangeSelectablePlotMorph>>selectionRectangle (in category 'selection') ----- + selectionRectangle + ^(selectionStart notNil and: [selectionStop notNil]) ifTrue: + [| bounds | + bounds := self bounds. + ((selectionStart min: selectionStop) max: bounds left)@bounds top + corner: ((selectionStart max: selectionStop) min: bounds right)@bounds bottom]! Item was added: + ----- Method: SmalltalkImage>>quit (in category '*CogTools-Listener') ----- + quit + self snapshot: false andQuit: true! Item was changed: ----- Method: SqueakVMProfiler>>threadIndexText: (in category 'accessing') ----- threadIndexText: aText aText asString asInteger ifNotNil: [:integer | threadIndex := integer]. self initializeSamples. self computeHistograms. + self plotGraph. + self changed: #total.! - self plotGraph.! Item was added: + Object subclass: #StdioListener + instanceVariableNames: 'quitOnEof stdin stdout stderr' + classVariableNames: '' + poolDictionaries: '' + category: 'CogTools-Listener'! Item was added: + ----- Method: StdioListener>>initialize (in category 'initialize-release') ----- + initialize + quitOnEof := true. + stdin := FileStream stdin. + stdout := FileStream stdout. + stderr := FileStream stderr! Item was added: + ----- Method: StdioListener>>logError:inContext:to: (in category 'run loop') ----- + logError: errMsg inContext: aContext to: aStream + aStream nextPutAll: errMsg; cr. + aContext errorReportOn: aStream. + aStream cr! Item was added: + ----- Method: StdioListener>>quitOnEof (in category 'accessing') ----- + quitOnEof + ^quitOnEof! Item was added: + ----- Method: StdioListener>>quitOnEof: (in category 'accessing') ----- + quitOnEof: aBoolean + quitOnEof := aBoolean! Item was added: + ----- Method: StdioListener>>run (in category 'run loop') ----- + run + [stdin atEnd] whileFalse: + [| nextChunk | + stdout nextPutAll: 'squeak> '; flush. + nextChunk := stdin nextChunkNoTag. + [nextChunk notEmpty and: [nextChunk first isSeparator]] whileTrue: + [nextChunk := nextChunk allButFirst]. + Transcript cr; nextPutAll: nextChunk; cr; flush. + [stdout print: (Compiler evaluate: nextChunk); cr; flush] + on: Error + do: [:ex| self logError: ex description inContext: ex signalerContext to: stderr]]. + quitOnEof ifTrue: + [SourceFiles at: 2 put: nil. + Smalltalk snapshot: false andQuit: true]! Item was added: + Model subclass: #ThreadInspector + instanceVariableNames: 'startTime ownerLog' + classVariableNames: '' + poolDictionaries: '' + category: 'CogTools-ThreadInspector'! Item was added: + ----- Method: ThreadInspector>>getOwnerLogFromVM (in category 'accessing') ----- + getOwnerLogFromVM + + |bytes numElements bigEndian| + bytes := (ByteArray new: 3*8*1024). + numElements := self primitiveGetOwnerLog: bytes. + bigEndian := Smalltalk endianness = #big. + self assert: Smalltalk wordSize = 8. "TODO: Decode 32-bit VM log" + + ^ (0 to: numElements - 1) + collect: [:index | |bytesOffset| + bytesOffset := index * 24. + CogVMOwnerLog new + timestamp: (bytes long64At: bytesOffset + 1 bigEndian: bigEndian); "+1 because Smalltalk is 1-indexed" + vmOwner: (bytes long64At: bytesOffset + 9 bigEndian: bigEndian); + successfulSwitch: (bytes long64At: bytesOffset + 17 bigEndian: bigEndian) ~= 0; + yourself].! Item was added: + ----- Method: ThreadInspector>>ownerLog (in category 'accessing') ----- + ownerLog + + ^ ownerLog! Item was added: + ----- Method: ThreadInspector>>ownerLog: (in category 'accessing') ----- + ownerLog: anOrderedCollection + + ownerLog := anOrderedCollection.! Item was added: + ----- Method: ThreadInspector>>primitiveGetOwnerLog: (in category 'primitives') ----- + primitiveGetOwnerLog: aByteArray + + <primitive: 226 error: ec> + ^ self primitiveFailed: ec! Item was added: + ----- Method: ThreadInspector>>primitiveMillisecondsNow (in category 'primitives') ----- + primitiveMillisecondsNow + <primitive: 245> + ^ self primitiveFailed! Item was added: + ----- Method: ThreadInspector>>spyOn: (in category 'as yet unclassified') ----- + spyOn: aBlock + + | newStartTime | + newStartTime := self primitiveMillisecondsNow. + + aBlock value. + + "Only update the startTime & ownerLog if the block succeeded." + self startTime: newStartTime. + self ownerLog: self getOwnerLogFromVM.! Item was added: + ----- Method: ThreadInspector>>startTime (in category 'accessing') ----- + startTime + + ^ startTime! Item was added: + ----- Method: ThreadInspector>>startTime: (in category 'accessing') ----- + startTime: aNumber + + startTime := aNumber.! Item was added: + ----- Method: ThreadInspector>>visualize (in category 'as yet unclassified') ----- + visualize + + | pm startIndex lastVMOwner | + pm := ThreadInspectorPlotMorph new. + pm + series: #vmOwner color: Color green; + series: #vmOwner description: 'vm owner'; + series: #vmOwner type: #stepped. + + pm + series: #failedLocks color: Color red; + series: #failedLocks description: 'failed locking attempts'; + series: #failedLocks drawLine: false. + + startIndex := (self ownerLog findLast: [:entry | entry successfulSwitch and: [entry timestamp <= self startTime]]). + startIndex := startIndex max: 1. + startIndex to: self ownerLog size + do: [:index | |entry series | + entry := (self ownerLog at: index). + series := entry successfulSwitch ifTrue: [#vmOwner] ifFalse: [#failedLocks]. + pm series: series addPoint: entry timestamp @ entry vmOwner]. + lastVMOwner := (self ownerLog at: (self ownerLog findLast: [:entry | entry successfulSwitch])) vmOwner. + pm series: #vmOwner addPoint: self ownerLog last timestamp@ lastVMOwner. + "make sure we always have at least -1, 0 and 1 in view, even if there were no owner switches to them." + pm minPoint y > -1 + ifTrue: [pm limitMinY: -1]. + pm maxPoint y < 1 + ifTrue: [pm limitMaxY: 1]. + + pm openInWorld. + ! Item was added: + PlotMorphGrid subclass: #ThreadInspectorGrid + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'CogTools-ThreadInspector'! Item was added: + ----- Method: ThreadInspectorGrid>>bestStep: (in category 'as yet unclassified') ----- + bestStep: height + + | maxY minY | + maxY := plot maxPoint y. + minY := plot minPoint y. + ^ height / (maxY - minY)! Item was added: + ----- Method: ThreadInspectorGrid>>drawGridOn: (in category 'as yet unclassified') ----- + drawGridOn: aCanvas + + | gridColor lighter darker baseColor bounds | + baseColor := plot baseColor alpha: 1. + lighter := baseColor twiceLighter. + darker := baseColor twiceDarker. + gridColor := (lighter diff: baseColor) + > (darker diff: baseColor) + ifTrue: [lighter] + ifFalse: [darker]. + bounds := plot drawBounds. + (bounds top + to: bounds bottom + by: (self bestStep: bounds height)) + do: [:y | | yRounded | + yRounded := y rounded. + aCanvas + line: bounds left @ yRounded + to: bounds right @ yRounded + color: gridColor]! Item was added: + RangeSelectablePlotMorph subclass: #ThreadInspectorPlotMorph + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'CogTools-ThreadInspector'! Item was added: + ----- Method: ThreadInspectorPlotMorph>>gridClass (in category 'as yet unclassified') ----- + gridClass + + ^ ThreadInspectorGrid! Item was added: + ----- Method: ThreadInspectorPlotMorph>>moveYMidToZero (in category 'as yet unclassified') ----- + moveYMidToZero + "This is the most useful marker for thread inspection as 0 means 'disowned'." + | zeroFraction | + ymid contents: (yAxisFormatter value: 0). + + self assert: (self minPoint y < 0 and: [0 < self maxPoint y]). + + zeroFraction := self maxPoint y / (self maxPoint y - self minPoint y). + ymid position: (self topLeft + + ((15 - ymid width max: 0) @ (self height - ymid height * zeroFraction) rounded) + + (self borderWidth @ 0)).! Item was added: + ----- Method: ThreadInspectorPlotMorph>>updateCotas (in category 'as yet unclassified') ----- + updateCotas + + super updateCotas. + (series notNil and: [self minPoint y < 0 and: [0 < self maxPoint y]]) + ifTrue: [self moveYMidToZero].! Item was changed: + RangeSelectablePlotMorph subclass: #VMProfilePlotMorph + instanceVariableNames: 'alternateSeries cachedAlternateMaxPoint cachedAlternateMinPoint aymax aymid aymin' - PlotMorph subclass: #VMProfilePlotMorph - instanceVariableNames: 'alternateSeries selectionStart selectionStop oldSelectionRectangle model cachedAlternateMaxPoint cachedAlternateMinPoint aymax aymid aymin' classVariableNames: '' poolDictionaries: '' category: 'CogTools-VMProfiler'! Item was removed: - ----- Method: VMProfilePlotMorph>>drawOn: (in category 'drawing') ----- - drawOn: aCanvas - self selectionRectangle ifNotNil: - [:selectionRectangle| - aCanvas fillRectangle: selectionRectangle color: Color lightBlue]. - super drawOn: aCanvas! Item was removed: - ----- Method: VMProfilePlotMorph>>invalidateSelection (in category 'selection') ----- - invalidateSelection - self selectionRectangle - ifNil: - [oldSelectionRectangle ifNotNil: - [self invalidRect: oldSelectionRectangle. - oldSelectionRectangle := nil]] - ifNotNil: - [:selectionRectangle| - self invalidRect: (oldSelectionRectangle - ifNil: [selectionRectangle] - ifNotNil: [oldSelectionRectangle merge: selectionRectangle]). - oldSelectionRectangle := selectionRectangle]! Item was removed: - ----- Method: VMProfilePlotMorph>>model (in category 'accessing') ----- - model - ^model! Item was removed: - ----- Method: VMProfilePlotMorph>>model: (in category 'accessing') ----- - model: anObject - "Set my model and make me me a dependent of the given object." - - model ifNotNil: [model removeDependent: self]. - anObject ifNotNil: [anObject addDependent: self]. - model := anObject! Item was removed: - ----- Method: VMProfilePlotMorph>>mouseDown: (in category 'event handling') ----- - mouseDown: anEvent - selectionStart := anEvent position x. - self invalidateSelection! Item was removed: - ----- Method: VMProfilePlotMorph>>mouseMove: (in category 'event handling') ----- - mouseMove: anEvent - selectionStop := anEvent position x. - self invalidateSelection! Item was removed: - ----- Method: VMProfilePlotMorph>>mouseUp: (in category 'event handling') ----- - mouseUp: anEvent - | selectionRect screenDrawBounds range | - selectionRect := self selectionRectangle. - screenDrawBounds := self bounds insetBy: margin. - range := screenDrawBounds width asFloat. - selectionStart := selectionStop := nil. - self invalidateSelection. - selectionRect ifNotNil: - [model - selectProportionFrom: ((selectionRect left - screenDrawBounds left) / range max: 0.0) - to: ((selectionRect right - screenDrawBounds left) / range min: 1.0)]! Item was removed: - ----- Method: VMProfilePlotMorph>>selectionRectangle (in category 'selection') ----- - selectionRectangle - ^(selectionStart notNil and: [selectionStop notNil]) ifTrue: - [| bounds | - bounds := self bounds. - ((selectionStart min: selectionStop) max: bounds left)@bounds top - corner: ((selectionStart max: selectionStop) min: bounds right)@bounds bottom]! Item was changed: ----- Method: VMProfiler>>putReportPreambleOn: (in category 'reports') ----- putReportPreambleOn: s | expr | s nextPutAll: (SmalltalkImage current getSystemAttribute: 0); space; nextPutAll: Date today yyyymmdd; space. Time now print24: true on: s. s cr. (startStats size >= 44 and: [(startStats at: 44) isNumber]) ifTrue: [s nextPutAll: 'eden size: '; nextPutAll: (startStats at: 44) asStringWithCommas. s nextPutAll: ' stack pages: '; print: (startStats at: 42). (startStats size >= 46 and: [(startStats at: 46) isNumber and: [(startStats at: 46) > 0]]) ifTrue: [s nextPutAll: ' code size: '; nextPutAll: (startStats at: 46) asStringWithCommas]. s cr]. + s nextPutAll: 'OS Thread: ', threadIndex. + threadIndex = 1 ifTrue: [s nextPutAll: ' (Heartbeat thread)']. s cr. + s cr. (expr := self trimmedExpressionText) notEmpty ifTrue: [s nextPutAll: expr; cr; cr]. (gcPriorToProfile or: [clearPriorToProfile or: [forkProfile]]) ifTrue: [gcPriorToProfile ifTrue: [s nextPutAll: 'gc prior. ']. clearPriorToProfile ifTrue: [s nextPutAll: 'clear prior. ']. forkProfile ifTrue: [s nextPutAll: 'run in separate process.']. s cr]. elapsedTime > 0 ifTrue: [s print: elapsedTime / 1000.0; nextPutAll: ' seconds; sampling frequency '; print: (total * 1000 / elapsedTime) rounded; nextPutAll: ' hz'; cr]!

1 0

VM Maker: VMMaker.threaded-LM.3349.mcz
by commits＠source.squeak.org 06 Dec '23

06 Dec '23

Leon Matthes uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.threaded-LM.3349.mcz ==================== Summary ==================== Name: VMMaker.threaded-LM.3349 Author: LM Time: 6 December 2023, 11:29:35.587268 am UUID: 5d97125e-0dec-4acd-acd5-ae9fd8a5b14b Ancestors: VMMaker.threaded-LM.3348 Log VM owner switches and add primitive to query the log. =============== Diff against VMMaker.threaded-LM.3348 =============== Item was added: + ----- Method: AtomicValue>>+ (in category 'as yet unclassified') ----- + + aValue + + ^ self value + aValue.! Item was changed: ----- Method: CoInterpreterMT class>>ancilliaryClasses (in category 'translation') ----- ancilliaryClasses "Answer any extra classes to be included in the translation." + ^super ancilliaryClasses, { CogThreadManager. CogVMThread . CogVMOwnerLog }! - ^super ancilliaryClasses, { CogThreadManager. CogVMThread }! Item was changed: ----- Method: CoInterpreterMT class>>initializePrimitiveTable (in category 'initialization') ----- initializePrimitiveTable super initializePrimitiveTable. PrimNumberRelinquishProcessor := 230. COGMTVM ifTrue: + [(226 to: 229) do: - [(227 to: 229) do: [:pidx| self assert: (PrimitiveTable at: pidx + 1) = #primitiveFail]. PrimitiveTable + at: 226 + 1 put: #primitiveGetOwnerLog; at: 227 + 1 put: #primitiveVMCurrentThreadId; at: 228 + 1 put: #primitiveProcessBoundThreadId; at: 229 + 1 put: #primitiveProcessBindToThreadAffinity]! Item was added: + ----- Method: CoInterpreterMT>>primitiveGetOwnerLog (in category 'logging primitives') ----- + primitiveGetOwnerLog + "Write the owner log to the given ByteArray. + All members of the owner log struct are always written as defined by the C struct. + Return the number of instances of CogVMOwnerLog written into the ByteArray." + | logBuffer bufferPointer bytesCopied | + <export: true> + <var: #bufferPointer type: #'char *'> + argumentCount ~= 1 + ifTrue: [^ self primitiveFailFor: PrimErrBadNumArgs]. + + logBuffer := self stackTop. + ((objectMemory isNonImmediate: logBuffer) + and: [(objectMemory isPureBitsNonImm: logBuffer) + and: [(objectMemory numBytesOf: logBuffer) >= (OwnerLogSize * (self sizeof: CogVMOwnerLog))]]) + ifFalse: [^ self primitiveFailFor: PrimErrBadArgument]. + + bufferPointer := (self objectMemory firstFixedField: logBuffer). + bytesCopied := cogThreadManager copyLogTo: bufferPointer. + + self pop: argumentCount + 1 thenPushInteger: bytesCopied / (self sizeof: CogVMOwnerLog). + ! Item was changed: ----- Method: CoInterpreterMT>>reduceWaitingPriorityFrom:to: (in category 'accessing') ----- reduceWaitingPriorityFrom: existingWaitingPriority to: newMaxPriority <var: #existing type: #int> | existing | self cCode: [existing := existingWaitingPriority] + inSmalltalk: [existing := AtomicValue newFrom: existingWaitingPriority.]. - inSmalltalk: [existing := AtomicValue new. - existing value: existingWaitingPriority.]. "This CPXCHG may fail, that's fine though, as there may have been another thread that increased the priority in the meantime. In that case that threads priority is the correct one to use." ^ self atomic: (self addressOf: maxWaitingPriority) _compare: (self addressOf: existing) _exchange_strong: newMaxPriority! Item was changed: ----- Method: CoInterpreterMT>>waitingPriorityIsAtLeast: (in category 'accessing') ----- waitingPriorityIsAtLeast: minPriority "Set the maxWaitingPriority to at least minPriority on behalf of a thread wanting to acquire the VM. If maxWaitingPriority is increased, schedule a thread activation check asap." <var: #currentWaitingPriority type: #int> | currentWaitingPriority didIncrease | self cCode: [currentWaitingPriority := self getMaxWaitingPriority.] + inSmalltalk: [currentWaitingPriority := AtomicValue newFrom: self getMaxWaitingPriority]. - inSmalltalk: [currentWaitingPriority := AtomicValue new. - currentWaitingPriority value: self getMaxWaitingPriority]. didIncrease := false. [(self cCode: [currentWaitingPriority] inSmalltalk: [currentWaitingPriority value]) >= minPriority or: [didIncrease := self atomic: (self addressOf: maxWaitingPriority) _compare: (self addressOf: currentWaitingPriority) _exchange_strong: minPriority]] whileFalse. didIncrease ifTrue: [ self assert: (self cCode: [currentWaitingPriority] inSmalltalk: [currentWaitingPriority value]) < minPriority. checkThreadActivation := true. self forceInterruptCheck]! Item was changed: CogClass subclass: #CogThreadManager (excessive size, no diff calculated) Item was changed: ----- Method: CogThreadManager class>>declareCVarsIn: (in category 'translation') ----- declareCVarsIn: cCodeGen cCodeGen removeVariable: 'coInterpreter'; removeVariable: 'cogit'; removeVariable: 'threadLocalStorage'; removeVariable: 'processorOwner'; removeVariable: 'registerStates'. cCodeGen var: #threads type: #'CogVMThread **'; var: #vmOSThread type: #sqOSThread; var: #vmOwner type: #'volatile atomic_int'; + var: #maxWaitingPriority type: #'volatile atomic_int'; + var: #ownerLog type: #'CogVMOwnerLog *'; + var: #ownerLogIndex type: #'volatile atomic_int'. - var: #maxWaitingPriority type: #'volatile atomic_int'. cCodeGen addHeaderFile: '<stdatomic.h>'! Item was changed: ----- Method: CogThreadManager class>>initialize (in category 'class initialization') ----- initialize "CogThreadManager initialize" CTMUninitialized := 0. CTMInitializing := 1. CTMUnavailable := 2. "off doing its own thing and not available to run the VM, e.g. calling-out." CTMAssignableOrInVM := 3. "either owning the VM or blocked on its osSemaphore available for VM work" CTMWantingOwnership := 4. "with something specific to do in the VM (e.g. return a result from a call-out, make a call-back)" CTMUnknownOwner := -1. "Define the size of the stack of processes at time of disown/own." + AWOLProcessesIncrement := 4. + OwnerLogSize := 1024.! - AWOLProcessesIncrement := 4! Item was added: + ----- Method: CogThreadManager>>copyLogTo: (in category 'logging') ----- + copyLogTo: aPointer + | bufferPointer bytesCopied index startIndex bytesToCopy | + <var: #aPointer type: #'char *'> + <var: #bufferPointer type: #'char *'> + bufferPointer := aPointer. + index := self atomic_load: (self addressOf: ownerLogIndex). + bytesCopied := 0. + + "NOTE: The ownerLogWrapped isn't synchronized atomically. + Therefore, if this primitive is called exactly when we start wrapping the very first time, we'll read the wrong value here. + However, as this is very unlikely, don't bother fixing this yet." + ownerLogWrapped ifTrue: [ + "If we've reached the limit of our Ringbuffer, deliberately don't copy the last 100 entries, + so that new log entries don't overwrite during the memcpy." + startIndex := index + 100 min: (OwnerLogSize - 1). + bytesToCopy := (OwnerLogSize - startIndex) * (self sizeof: CogVMOwnerLog). + self memcpy: bufferPointer + _: ownerLog + startIndex + _: bytesToCopy. + bytesCopied := bytesCopied + bytesToCopy]. + + bytesToCopy := index * (self sizeof: CogVMOwnerLog). + self memcpy: bufferPointer + bytesCopied + _: ownerLog + _: bytesToCopy. + bytesCopied := bytesCopied + bytesToCopy. + ^ bytesCopied + ! Item was changed: ----- Method: CogThreadManager>>doTryLockVMOwnerTo: (in category 'Cogit lock implementation') ----- doTryLockVMOwnerTo: threadIndex "In the simulation, this is being called by #simulateTryLockVMOwnerTo:, in C this method will just be called directly. Returns true if the vmOwner has been successfully set to the given thread index." <inline: #always> <var: #expected type: #int> + | expected success | - | expected | expected := self cCode: 0 inSmalltalk: [AtomicValue newFrom: 0]. + success := (self atomic: (self addressOf: vmOwner) - ^ (self atomic: (self addressOf: vmOwner) _compare: (self addressOf: expected) _exchange_strong: threadIndex) or: ["We may already be vmOwner. The current vmOwner will be stored in expected. However, if an unknown owner is present, we cannot assume that's us!!" + expected = threadIndex and: [threadIndex ~= CTMUnknownOwner]]. + + self logOwnerSwitchTo: threadIndex successful: success. + ^ success! - expected = threadIndex and: [threadIndex ~= CTMUnknownOwner]]! Item was changed: ----- Method: CogThreadManager>>initialize (in category 'initialize-release') ----- initialize + "Initialize is only called in Smalltalk simulation, don't initialize anything here that's important for C. + For that use #startThreadSubsystem." numThreads := numThreadsIncrement := 0. + vmOwner := AtomicValue newFrom: 0. + - self cCode: [self atomic_store: (self addressOf: vmOwner) _: 0] - inSmalltalk: [vmOwner := AtomicValue newFrom: 0]. memoryIsScarce := false. "N.B. Do not initialize threadLocalStorage; leave this to ioInitThreadLocalThreadIndices". + registerStates := IdentityDictionary new.! - registerStates := IdentityDictionary new! Item was added: + ----- Method: CogThreadManager>>initializeOwnerLog (in category 'public api') ----- + initializeOwnerLog + "The owner log isn't actually used in Simulation, we just directly print everything, so we can leave those variables empty during simulation." + self cCode: [ownerLog := self calloc: OwnerLogSize _: (self sizeof: CogVMOwnerLog). + self atomic_store: (self addressOf: ownerLogIndex) _: 0. + ownerLogWrapped := false.].! Item was added: + ----- Method: CogThreadManager>>logOwnerSwitchTo:successful: (in category 'logging') ----- + logOwnerSwitchTo: newOwner successful: aBoolean + <inline: false> + self cCode: [self saveOwnerSwitchTo: newOwner successful: aBoolean] + inSmalltalk: [self printOwnerSwitchTo: newOwner successful: aBoolean].! Item was added: + ----- Method: CogThreadManager>>printOwnerSwitchTo:successful: (in category 'logging') ----- + printOwnerSwitchTo: newOwner successful: aBoolean + <doNotGenerate> + coInterpreter transcript + ensureCr; + f: 'VM Owner: %d :: %d -> %d %s\n' + printf: { coInterpreter ioMSecs. + self getVMOwner. + newOwner. + aBoolean ifTrue: ['ok'] ifFalse: ['FAILED'] }.! Item was added: + ----- Method: CogThreadManager>>saveOwnerSwitchTo:successful: (in category 'logging') ----- + saveOwnerSwitchTo: newOwner successful: aBoolean + <var: #logEntry type: 'CogVMOwnerLog *'> + <var: #currentIndex type: 'int'> + <var: #newIndex type: 'int'> + | currentIndex newIndex timestamp logEntry | + timestamp := coInterpreter ioMSecs. + currentIndex := self atomic_load: (self addressOf: ownerLogIndex). + self cCode: '' inSmalltalk: [currentIndex := AtomicValue newFrom: currentIndex]. + + [newIndex := currentIndex + 1 \\ OwnerLogSize. + self atomic: (self addressOf: ownerLogIndex) + _compare: (self addressOf: currentIndex) + _exchange_strong: newIndex] whileFalse: []. + + newIndex < currentIndex ifTrue: [ownerLogWrapped := true]. + logEntry := (self addressOf: (ownerLog at: (self cCode: [currentIndex] inSmalltalk: [currentIndex value]))). + logEntry + timestamp: timestamp; + successfulSwitch: aBoolean; + vmOwner: newOwner.! Item was changed: ----- Method: CogThreadManager>>setVMOwner: (in category 'public api') ----- setVMOwner: indexOrZero "An ugly accessor used in only three cases: 1. by ownVMFromUnidentifiedThread when the VM is first locked to the thread id of the unidentified thread, and then, once identified, to the thread's index. 2. by wakeVMThreadFor: used by the two-level scheduler to switch threads when a Smalltalk process switch occurs to a process affined to another thread. 3. to release the VM (set the owner to zero)" <inline: #always> + "This can only be used when we're the VM Owner. It shall not be used to gain ownership. + Make sure this is the case!!" + self assert: (self getVMOwner = -1 or: [self getVMOwner = self ioGetThreadLocalThreadIndex]). - self assert: (self getVMOwner = self ioGetThreadLocalThreadIndex or: [self getVMOwner = -1]). self assert: (self getVMOwner ~= indexOrZero). + self logOwnerSwitchTo: indexOrZero successful: true. - self cCode: '' inSmalltalk: - [coInterpreter transcript - ensureCr; - f: 'setVMOwner: %d -> %d (%s)\n' - printf: { self getVMOwner. indexOrZero. thisContext home sender selector }]. "TODO: We could make this a `release` ordering, which may perform better on ARM." self atomic_store: (self addressOf: vmOwner) _: indexOrZero! Item was changed: ----- Method: CogThreadManager>>simulateTryLockVMOwnerTo: (in category 'simulation') ----- simulateTryLockVMOwnerTo: threadIndex "In the real VM this is a direct call of #tryLockVMOwnerTo:. In the simulation this is where register state is restored, simulating a thread switch. State is stored in saveRegisterStateForCurrentProcess (sent by disownVM:, ioWaitOnOSSemaphore: and ioTransferTimeslice). The code here and in saveRegisterStateForCurrentProcess allow us to avoid the expensive and complex MultiProcessor hack. The idea here is to save the register state around the invocation of tryLockVMOwnerTo:, and set the register state to that for the owner, changing the state if ownership has changed, restoring it if ownership has not changed." <doNotGenerate> self deny: threadIndex = 0. ^cogit withProcessorHaltedDo: [| previousOwner currentOwner processor result | processor := cogit processor. "After switching, the 'current' owner will be the 'previous' owner. Though the value will be the same, let's still introduce a second variable that we can use after the switch to make it more clear what's going on." previousOwner := currentOwner := self getVMOwner. "If we currently have a VM owner, the register state should be valid for that owner, otherwise it should be empty. It may be CTMUnknownOwner (-1), in that case it should also be empty." currentOwner > 0 ifTrue: [self assertValidStackPointersInState: processor registerState forIndex: currentOwner] ifFalse: [self assertEmptyRegisterStates: processor registerState]. result := self doTryLockVMOwnerTo: threadIndex. self assert: result = (threadIndex = self getVMOwner). result ifTrue: ["If we did actually change owners, assert that previously the processor was emtpy." previousOwner ~= self getVMOwner ifTrue: [self assertEmptyRegisterStates: processor registerState. self loadOrInitializeRegisterStateFor: threadIndex]]. + - - coInterpreter transcript - ensureCr; - f: 'tryLockVMOwner %d -> %d (%s) %s\n' - printf: { previousOwner. threadIndex. thisContext home sender selector. result ifTrue: ['ok'] ifFalse: ['FAILED'] }. self assertValidProcessorStackPointersForIndex: self getVMOwner. result]! Item was changed: ----- Method: CogThreadManager>>startThreadSubsystem (in category 'public api') ----- startThreadSubsystem "Initialize the threading subsystem, aborting if there is an error." | vmThread | <inline: false> self assert: threads = nil. vmOSThread := self ioCurrentOSThread. numThreadsIncrement := (self ioNumProcessors max: 2) min: 16. (self growThreadInfosToAtLeast: numThreadsIncrement * 2) ifFalse: [self error: 'no memory to start thread system']. self atomic_store: (self addressOf: vmOwner) _: 1. vmThread := threads at: self getVMOwner. vmThread setVmThreadState: CTMInitializing. self registerVMThread: vmThread. + vmThread setVmThreadState: CTMAssignableOrInVM. + + self initializeOwnerLog.! - vmThread setVmThreadState: CTMAssignableOrInVM! Item was added: + VMStructType subclass: #CogVMOwnerLog + instanceVariableNames: 'timestamp vmOwner successfulSwitch' + classVariableNames: '' + poolDictionaries: 'VMThreadingConstants' + category: 'VMMaker-Multithreading'! Item was added: + ----- Method: CogVMOwnerLog class>>instVarNamesAndTypesForTranslationDo: (in category 'translation') ----- + instVarNamesAndTypesForTranslationDo: aBinaryBlock + "enumerate aBinaryBlock with the names and C type strings for the inst vars to include in a CogVMThread struct." + + self allInstVarNames do: + [:ivn| aBinaryBlock value: ivn value: #sqInt]! Item was added: + ----- Method: CogVMOwnerLog>>successfulSwitch (in category 'accessing') ----- + successfulSwitch + + ^ successfulSwitch! Item was added: + ----- Method: CogVMOwnerLog>>successfulSwitch: (in category 'accessing') ----- + successfulSwitch: anObject + + ^ successfulSwitch := anObject.! Item was added: + ----- Method: CogVMOwnerLog>>timestamp (in category 'accessing') ----- + timestamp + + ^ timestamp! Item was added: + ----- Method: CogVMOwnerLog>>timestamp: (in category 'accessing') ----- + timestamp: anObject + + ^ timestamp := anObject.! Item was added: + ----- Method: CogVMOwnerLog>>vmOwner (in category 'accessing') ----- + vmOwner + + ^ vmOwner! Item was added: + ----- Method: CogVMOwnerLog>>vmOwner: (in category 'accessing') ----- + vmOwner: anObject + + ^ vmOwner := anObject.! Item was added: + ----- Method: CogVMSimulator>>ownVM:withFlags: (in category 'multi-threading simulation switch') ----- + ownVM: vmThreadHandle withFlags: additionalFlags + "This method includes or excludes CoInterpreterMT methods as required. + Auto-generated by CogVMSimulator>>ensureMultiThreadingOverridesAreUpToDate" + + ^self perform: #ownVM:withFlags: + withArguments: {vmThreadHandle. additionalFlags} + inSuperclass: (cogThreadManager ifNil: [CoInterpreterPrimitives] ifNotNil: [CoInterpreterMT])! Item was changed: ----- Method: Interpreter>>primitiveVMProfileSamplesInto (in category 'process primitives') ----- primitiveVMProfileSamplesInto "Primitive. 0 args: Answer whether the VM Profiler is running or not. 1 arg: Copy the sample data into the supplied argument, which must be a Bitmap of suitable size. Answer the number of samples copied into the buffer." | sampleBuffer sampleBufferAddress running bufferSize numSamples | <var: #bufferSize type: #long> <var: #sampleBufferAddress type: #'unsigned long *'> self cCode: 'ioNewProfileStatus(&running,&bufferSize)' inSmalltalk: [running := false. bufferSize := 0]. argumentCount = 0 ifTrue: [^self pop: 1 thenPushBool: running]. self success: argumentCount = 1. successFlag ifTrue: [sampleBuffer := self stackObjectValue: 0. self assertClassOf: sampleBuffer is: (self splObj: ClassBitmap). self success: (self numSlotsOf: sampleBuffer) >= bufferSize]. successFlag ifFalse: [^nil]. sampleBufferAddress := self firstFixedField: sampleBuffer. + "We use thread 0 here, as the normal Interpreter doesn't support threading anyway." + numSamples := self cCode: 'ioNewProfileThreadSamplesInto(0,sampleBufferAddress)' - numSamples := self cCode: 'ioNewProfileSamplesInto(sampleBufferAddress)' inSmalltalk: [sampleBufferAddress := sampleBufferAddress]. self pop: argumentCount + 1 thenPushInteger: numSamples! Item was changed: ----- Method: InterpreterPrimitives>>primitiveVMProfileSamplesInto (in category 'process primitives') ----- primitiveVMProfileSamplesInto "Primitive. 0 args: Answer whether the VM Profiler is running or not. + 2 arg: Copy the sample data for the thread with the given index into the second + supplied argument, which must be a Bitmap of suitable size. + Answer the number of samples copied into the buffer." + | sampleBuffer running bufferSize numSamples threadIndex | - 1 arg: Copy the sample data into the supplied argument, which must be a Bitmap - of suitable size. Answer the number of samples copied into the buffer." - | sampleBuffer running bufferSize numSamples | <var: #bufferSize type: #long> + "Initialize to shut up the warning about 'uninitialized variables' in Squeak" + running := 0. + bufferSize := 0. self ioNewProfile: (self addressOf: running put: [:v| running := v]) Status: (self addressOf: bufferSize put: [:v| bufferSize := v]). argumentCount = 0 ifTrue: [^self pop: 1 thenPushBool: running]. + argumentCount = 2 ifFalse: - argumentCount = 1 ifFalse: [^self primitiveFailFor: PrimErrBadNumArgs]. + + threadIndex := self stackIntegerValue: 1. + sampleBuffer := self stackValue: 0. ((objectMemory isNonImmediate: sampleBuffer) and: [(objectMemory isPureBitsNonImm: sampleBuffer) and: [(objectMemory numBytesOf: sampleBuffer) >= (bufferSize * objectMemory wordSize)]]) ifFalse: [^self primitiveFailFor: PrimErrBadArgument]. + + numSamples := self ioNewProfileThread: threadIndex SamplesInto: (objectMemory firstFixedField: sampleBuffer). - numSamples := self ioNewProfileSamplesInto: (objectMemory firstFixedField: sampleBuffer). self pop: argumentCount + 1 thenPushInteger: numSamples! Item was changed: ----- Method: SqueakSSLPlugin>>primitiveConnect (in category 'primitives') ----- primitiveConnect "Primitive. Starts or continues a client handshake using the provided data. Will eventually produce output to be sent to the server. Requires the host name to be set for the session. Returns: > 0 - Number of bytes to be sent to the server 0 - Success. The connection is established. -1 - More input is required. < -1 - Other errors. " | start srcLen dstLen srcOop dstOop handle srcPtr dstPtr result wasSrcPinned wasDestPinned vmHandle | <var: #srcPtr type: #'char *'> <var: #dstPtr type: #'char *'> <export: true> interpreterProxy methodArgumentCount = 5 ifFalse:[^interpreterProxy primitiveFail]. dstOop := interpreterProxy stackValue: 0. srcLen := interpreterProxy stackIntegerValue: 1. start := interpreterProxy stackIntegerValue: 2. srcOop := interpreterProxy stackValue: 3. handle := interpreterProxy stackIntegerValue: 4. interpreterProxy failed ifTrue:[^nil]. ((start > 0 and:[srcLen >= 0]) and:[(interpreterProxy isBytes: srcOop) and:[(interpreterProxy isBytes: dstOop) and:[(interpreterProxy byteSizeOf: srcOop) >= (start + srcLen - 1)]]]) ifFalse:[^interpreterProxy primitiveFail]. "Careful!! The object may move when being pinned!!" (wasSrcPinned := interpreterProxy isPinned: srcOop) ifFalse: [srcOop := interpreterProxy pinObject: srcOop]. (wasDestPinned := interpreterProxy isPinned: dstOop) ifFalse: [dstOop := interpreterProxy pinObject: dstOop]. "Pinning may fail (only if we're out of memory)" (srcOop isNil or: [dstOop isNil]) ifTrue: [^ interpreterProxy primitiveFail]. srcPtr := interpreterProxy firstIndexableField: srcOop. dstPtr := interpreterProxy firstIndexableField: dstOop. srcPtr := srcPtr + start - 1. dstLen := interpreterProxy byteSizeOf: dstOop. + "vmHandle := interpreterProxy disownVM: DisownVMForThreading." - vmHandle := interpreterProxy disownVM: DisownVMForThreading. result := self cCode: 'sqConnectSSL(handle, srcPtr, srcLen, dstPtr, dstLen)' inSmalltalk:[handle. srcPtr. srcLen. dstPtr. dstLen. -2]. + "interpreterProxy ownVM: vmHandle." - interpreterProxy ownVM: vmHandle. wasSrcPinned ifFalse: [interpreterProxy unpinObject: srcOop]. wasDestPinned ifFalse: [interpreterProxy unpinObject: dstOop]. interpreterProxy failed ifTrue:[^nil]. interpreterProxy pop: interpreterProxy methodArgumentCount+1. interpreterProxy pushInteger: result.! Item was changed: SharedPool subclass: #VMThreadingConstants instanceVariableNames: '' + classVariableNames: 'AWOLProcessesIncrement CTMAssignableOrInVM CTMInitializing CTMUnavailable CTMUninitialized CTMUnknownOwner CTMWantingOwnership OwnerLogSize ThreadIdIndex ThreadIdShift' - classVariableNames: 'AWOLProcessesIncrement CTMAssignableOrInVM CTMInitializing CTMUnavailable CTMUninitialized CTMUnknownOwner CTMWantingOwnership ThreadIdIndex ThreadIdShift' poolDictionaries: '' category: 'VMMaker-Multithreading'! !VMThreadingConstants commentStamp: '<historical>' prior: 0! VMThreadingConstants ensureClassPool. CogThreadManager classPool keys do: [:k| VMThreadingConstants classPool declare: k from: CogThreadManager classPool]. CoInterpreterMT classPool keys do: [:k| VMThreadingConstants classPool declare: k from: CoInterpreterMT classPool].!

1 0

VM Maker: VMMaker.threaded-LM.3349.mcz
by commits＠source.squeak.org 06 Dec '23

06 Dec '23

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev December 2023