Vm-dev October 2021

vm-dev@lists.squeakfoundation.org

9 participants
59 discussions

[OpenSmalltalk/opensmalltalk-vm] 3b8be3: CogVM source as per VMMaker.oscog-eem.3088
by Eliot Miranda 14 Oct '21

14 Oct '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 3b8be36b3e512d47aecf780199dc1103b2a0402a https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3b8be36b3e512d47ae… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M src/spur32.cog/cogit.h M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.cog/interp.h M src/spur32.sista/cogit.h M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/validImage.c M src/spur64.cog/cogit.h M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.cog/interp.h M src/spur64.sista/cogit.h M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/validImage.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3088 Spur: primitiveSpurStringReplace can be a little faster if checking for compatibility is done separately for pointer and non-pointer objects, but crucially we can afford to make WeakArray and Array compatible, which is profitable for Croquet.

1 0

VM Maker: VMMaker.oscog-eem.3088.mcz
by commits＠source.squeak.org 14 Oct '21

14 Oct '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3088.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3088 Author: eem Time: 13 October 2021, 5:48:13.254256 pm UUID: cea4ec86-a5a1-4850-accb-099f31030ea5 Ancestors: VMMaker.oscog-eem.3087 Spur: primitiveSpurStringReplace can be a little faster if checking for compatibility is done separately for pointer and non-pointer objects, but crucially we can afford to make WeakArray and Array compatible, which is useful for Croquet. =============== Diff against VMMaker.oscog-eem.3087 =============== Item was changed: ----- Method: InterpreterPrimitives>>primitiveSpurStringReplace (in category 'indexing primitives') ----- primitiveSpurStringReplace "<array> primReplaceFrom: start to: stop with: replacement startingAt: repStart <primitive: 105>" <inline: true> | array start stop repl replStart arrayFmt arrayLength arrayInstSize replFmt replLength replInstSize srcDelta | array := self stackValue: 4. start := self stackValue: 3. stop := self stackValue: 2. repl := self stackValue: 1. replStart := self stackValue: 0. ((objectMemory isNonIntegerObject: start) or: [(objectMemory isNonIntegerObject: stop) or: [(objectMemory isNonIntegerObject: replStart) or: [objectMemory isImmediate: repl]]]) ifTrue: "can happen in LgInt copy" [^self primitiveFailFor: PrimErrBadArgument]. start := objectMemory integerValueOf: start. stop := objectMemory integerValueOf: stop. replStart := objectMemory integerValueOf: replStart. (stop >= start and: [objectMemory isObjImmutable: array]) ifTrue: [^self primitiveFailFor: PrimErrNoModification]. arrayFmt := objectMemory formatOf: array. - arrayLength := objectMemory lengthOf: array format: arrayFmt. - arrayFmt := objectMemory classFormatFromInstFormat: arrayFmt. replFmt := objectMemory formatOf: repl. - replLength := objectMemory lengthOf: repl format: replFmt. - replFmt := objectMemory classFormatFromInstFormat: replFmt. - "Array formats (without oddFields bits) must be the same" - (arrayFmt = replFmt - and: [arrayFmt < objectMemory firstCompiledMethodFormat]) ifFalse: - [^self primitiveFailFor: PrimErrInappropriate]. - "N.B. In the below start - 1 to: stop - 1 do:, Slang is intelligent enough to use < instead of <= so avoiding the stop - 1." + arrayFmt <= objectMemory lastPointerFormat ifTrue: + ["Array formats must be the same; but for copying, weak arrays are equivalent to arrays." + arrayFmt = objectMemory weakArrayFormat ifTrue: + [arrayFmt := objectMemory arrayFormat]. + replFmt = objectMemory weakArrayFormat ifTrue: + [replFmt := objectMemory arrayFormat]. + arrayFmt ~= replFmt ifTrue: + [^self primitiveFailFor: PrimErrInappropriate]. + + arrayLength := objectMemory numSlotsOf: array. + arrayInstSize := objectMemory fixedFieldsOf: array format: arrayFmt length: arrayLength. + replLength := objectMemory numSlotsOf: repl. + replInstSize := objectMemory fixedFieldsOf: repl format: replFmt length: replLength. + (start >= 1 and: [start - 1 <= stop and: [stop + arrayInstSize <= arrayLength + and: [replStart >= 1 and: [stop - start + replStart + replInstSize <= replLength]]]]) ifFalse: + [^self primitiveFailFor: PrimErrBadIndex]. + + start := start + arrayInstSize. + stop := stop + arrayInstSize. + srcDelta := (replStart + replInstSize) - start. + (objectMemory isOldObject: array) + ifTrue: + [| mustRemember oop | + mustRemember := false. + start - 1 to: stop - 1 do: + [:i | + oop := objectMemory fetchPointer: srcDelta + i ofObject: repl. + (objectMemory isYoung: oop) ifTrue: + [mustRemember := true]. + objectMemory storePointerUnchecked: i ofObject: array withValue: oop]. + mustRemember ifTrue: + [objectMemory possibleRootStoreInto: array]] + ifFalse: + [start - 1 to: stop - 1 do: + [:i | objectMemory storePointerUnchecked: i ofObject: array withValue: (objectMemory fetchPointer: srcDelta + i ofObject: repl)]]. + "We might consider comparing stop - start to some value here and using forceInterruptCheck" + ^self pop: argumentCount. "leave rcvr on stack"]. + + "Non-pointer array formats (without oddFields bits) must be the same" + arrayLength := objectMemory lengthOf: array format: arrayFmt. + replLength := objectMemory lengthOf: repl format: replFmt. + arrayFmt := objectMemory classFormatFromInstFormat: arrayFmt. + replFmt := objectMemory classFormatFromInstFormat: replFmt. + (arrayFmt = replFmt + and: [objectMemory sixtyFourBitIndexableFormat >= objectMemory sixtyFourBitIndexableFormat + and: [arrayFmt < objectMemory firstCompiledMethodFormat]]) ifFalse: + [^self primitiveFailFor: PrimErrInappropriate]. + (start >= 1 and: [start - 1 <= stop and: [stop <= arrayLength + and: [replStart >= 1 and: [stop - start + replStart <= replLength]]]]) ifFalse: + [^self primitiveFailFor: PrimErrBadIndex]. + srcDelta := replStart - start. + arrayFmt >= objectMemory firstShortFormat + ifTrue: "8 & 16-bit word type objects" + [arrayFmt >= objectMemory firstByteFormat + ifTrue: "byte-type objects" - arrayFmt <= objectMemory lastPointerFormat - ifTrue: - [arrayInstSize := objectMemory fixedFieldsOf: array format: arrayFmt length: arrayLength. - replInstSize := objectMemory fixedFieldsOf: repl format: replFmt length: replLength. - (start >= 1 and: [start - 1 <= stop and: [stop + arrayInstSize <= arrayLength - and: [replStart >= 1 and: [stop - start + replStart + replInstSize <= replLength]]]]) ifFalse: - [^self primitiveFailFor: PrimErrBadIndex]. - start := start + arrayInstSize. - stop := stop + arrayInstSize. - srcDelta := (replStart + replInstSize) - start. - (objectMemory isOldObject: array) - ifTrue: - [| mustRemember oop | - mustRemember := false. - start - 1 to: stop - 1 do: - [:i | - oop := objectMemory fetchPointer: srcDelta + i ofObject: repl. - (objectMemory isYoung: oop) ifTrue: - [mustRemember := true]. - objectMemory storePointerUnchecked: i ofObject: array withValue: oop]. - mustRemember ifTrue: - [objectMemory possibleRootStoreInto: array]] - ifFalse: [start - 1 to: stop - 1 do: + [:i | objectMemory storeByte: i ofObject: array withValue: (objectMemory fetchByte: srcDelta + i ofObject: repl)]] + ifFalse: "short type objects" + [start - 1 to: stop - 1 do: + [:i | objectMemory storeShort16: i ofObject: array withValue: (objectMemory fetchShort16: srcDelta + i ofObject: repl)]]] + ifFalse: "32 & 64-bit word type objects" + [arrayFmt >= objectMemory firstLongFormat + ifTrue: "word-type objects" + [start - 1 to: stop - 1 do: + [:i | objectMemory storeLong32: i ofObject: array withValue: (objectMemory fetchLong32: srcDelta + i ofObject: repl)]] + ifFalse: "long type objects" + [start - 1 to: stop - 1 do: + [:i | objectMemory storeLong64: i ofObject: array withValue: (objectMemory fetchLong64: srcDelta + i ofObject: repl)]]]. - [:i | objectMemory storePointerUnchecked: i ofObject: array withValue: (objectMemory fetchPointer: srcDelta + i ofObject: repl)]]] - ifFalse: - [(start >= 1 and: [start - 1 <= stop and: [stop <= arrayLength - and: [replStart >= 1 and: [stop - start + replStart <= replLength]]]]) ifFalse: - [^self primitiveFailFor: PrimErrBadIndex]. - srcDelta := replStart - start. - arrayFmt >= objectMemory firstShortFormat - ifTrue: "8 & 16-bit word type objects" - [arrayFmt >= objectMemory firstByteFormat - ifTrue: "byte-type objects" - [start - 1 to: stop - 1 do: - [:i | objectMemory storeByte: i ofObject: array withValue: (objectMemory fetchByte: srcDelta + i ofObject: repl)]] - ifFalse: "short type objects" - [start - 1 to: stop - 1 do: - [:i | objectMemory storeShort16: i ofObject: array withValue: (objectMemory fetchShort16: srcDelta + i ofObject: repl)]]] - ifFalse: "32 & 64-bit word type objects" - [arrayFmt >= objectMemory firstLongFormat - ifTrue: "word-type objects" - [start - 1 to: stop - 1 do: - [:i | objectMemory storeLong32: i ofObject: array withValue: (objectMemory fetchLong32: srcDelta + i ofObject: repl)]] - ifFalse: "long type objects" - [start - 1 to: stop - 1 do: - [:i | objectMemory storeLong64: i ofObject: array withValue: (objectMemory fetchLong64: srcDelta + i ofObject: repl)]]]]. "We might consider comparing stop - start to some value here and using forceInterruptCheck" + ^self pop: argumentCount "leave rcvr on stack"! - - self pop: argumentCount "leave rcvr on stack"!

1 0

[OpenSmalltalk/opensmalltalk-vm] 7798c7: CogVM source as per VMMaker.oscog-eem.3087
by Eliot Miranda 13 Oct '21

13 Oct '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 7798c72ccf90c0d553d43b9fe5463d039188c683 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7798c72ccf90c0d553… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M image/LoadReader.st M image/StartReader.st M src/spur32.cog.lowcode/cogit.h M src/spur32.cog.lowcode/cogitARMv5.c M src/spur32.cog.lowcode/cogitIA32.c M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cogit.h M src/spur32.cog/cogitARMv5.c M src/spur32.cog/cogitIA32.c M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.cog/interp.h M src/spur32.sista/cogit.h M src/spur32.sista/cogitARMv5.c M src/spur32.sista/cogitIA32.c M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/validImage.c M src/spur64.cog.lowcode/cogit.h M src/spur64.cog.lowcode/cogitARMv8.c M src/spur64.cog.lowcode/cogitX64SysV.c M src/spur64.cog.lowcode/cogitX64WIN64.c M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cogit.h M src/spur64.cog/cogitARMv8.c M src/spur64.cog/cogitX64SysV.c M src/spur64.cog/cogitX64WIN64.c M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.cog/interp.h M src/spur64.sista/cogit.h M src/spur64.sista/cogitARMv8.c M src/spur64.sista/cogitX64SysV.c M src/spur64.sista/cogitX64WIN64.c M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/validImage.c M src/v3.cog/cogit.h M src/v3.cog/cogitARMv5.c M src/v3.cog/cogitIA32.c M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3087 CoInterpreter prim trace log: - log the primitive method instead of the message selector - add the class of the receiver as a parameter of TracePrimitiveFailure events image directory: Include CogThreads in readers. Invoke doNotBindToGUIThread in reader startup.

1 0

VM Maker: VMMaker.oscog-eem.3087.mcz
by commits＠source.squeak.org 13 Oct '21

13 Oct '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3087.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3087 Author: eem Time: 13 October 2021, 3:32:02.224265 pm UUID: 27c5bd11-8d79-40f2-b273-5794bb04cea2 Ancestors: VMMaker.oscog-eem.3086 CoInterpreter prim trace log: - record the primitive method instead of the message selector - add the class of the receiver as a parameter in printing TracePrimitiveFailure events Fix an anachronism in SpurMemoryManager's class comment. Fix a slip in Slang revealled by the prim trace log changes. =============== Diff against VMMaker.oscog-eem.3086 =============== Item was changed: ----- Method: CoInterpreter>>ceCheckAndMaybeRetryPrimitive: (in category 'primitive support') ----- ceCheckAndMaybeRetryPrimitive: primIndex "Log failure and then retry if there's an accessorDepth or failure due to no memory." <api> <option: #SpurObjectMemory> | retried | (cogit recordPrimTrace and: [primTracePluginName isNil]) ifTrue: + [self fastLogPrim: TracePrimitiveFailure. + self fastLogPrim: (objectMemory fetchClassOf: (self stackValue: argumentCount))]. - [self fastLogPrim: TracePrimitiveFailure]. retried := self retryPrimitiveOnFailure. (retried and: [cogit recordPrimTrace]) ifTrue: [self fastLogPrim: TracePrimitiveRetry]! Item was changed: ----- Method: CoInterpreter>>checkForAndFollowForwardedPrimitiveState (in category 'primitive support') ----- checkForAndFollowForwardedPrimitiveState "Override to log and export to Cogit" <api> <option: #SpurObjectMemory> | found | (cogit recordPrimTrace and: [primTracePluginName isNil]) ifTrue: + [self fastLogPrim: TracePrimitiveFailure. + self fastLogPrim: (objectMemory fetchClassOf: (self stackValue: argumentCount))]. - [self fastLogPrim: TracePrimitiveFailure]. found := super checkForAndFollowForwardedPrimitiveState. (found and: [cogit recordPrimTrace]) ifTrue: [self fastLogPrim: TracePrimitiveRetry]. ^found! Item was changed: ----- Method: CoInterpreter>>dumpPrimTraceLog (in category 'debug support') ----- dumpPrimTraceLog "The prim trace log is a circular buffer of entries. If there is an entry at primTraceLogIndex \\ PrimTraceLogSize it has entries. If there is something at primTraceLogIndex it has wrapped." <api> <inline: false> + | hasParameter | (primTraceLog at: (self safe: primTraceLogIndex - 1 mod: PrimTraceLogSize)) = 0 ifTrue: [^self]. + hasParameter := false. (primTraceLog at: primTraceLogIndex) ~= 0 ifTrue: [primTraceLogIndex to: PrimTraceLogSize - 1 do: + [:i | hasParameter := self printPrimLogEntryAt: i hasParameter: hasParameter]]. - [:i | self printPrimLogEntryAt: i; cr]]. 0 to: primTraceLogIndex - 1 do: + [:i | hasParameter := self printPrimLogEntryAt: i hasParameter: hasParameter]! - [:i | self printPrimLogEntryAt: i; cr]! Item was changed: ----- Method: CoInterpreter>>fastLogPrim: (in category 'debug support') ----- + fastLogPrim: aMethodSelectorOrImmediate - fastLogPrim: aSelectorOrImmediate "Fast tracing of named primitives. primTraceLogIndex is a byte variable. + aMethodSelectorOrImmediate is a method oop, a selector oop or one of TraceCodeCompaction et al. - aSelectorOrImmediate is a selector oop or one of TraceCodeCompaction et al. primTraceLog has 256 entries. In C the + 1 below is hence implicitly modulo 256." <inline: true> + primTraceLog at: primTraceLogIndex put: aMethodSelectorOrImmediate. - primTraceLog at: primTraceLogIndex put: aSelectorOrImmediate. self primTraceLogIndex: primTraceLogIndex + 1! Item was changed: ----- Method: CoInterpreter>>mapPrimTraceLog (in category 'debug support') ----- mapPrimTraceLog + "The prim trace log is a circular buffer of objects. If there is - "The prim trace log is a circular buffer of selectors. If there is an entry at primTraceLogIndex - 1 \\ PrimTraceBufferSize it has entries. If there is something at primTraceLogIndex it has wrapped." <inline: false> + | entryOop | (primTraceLog at: (self safe: primTraceLogIndex - 1 mod: PrimTraceLogSize)) = 0 ifTrue: [^self]. (primTraceLog at: primTraceLogIndex) ~= 0 ifTrue: [primTraceLogIndex to: PrimTraceLogSize - 1 do: + [:i| + entryOop := primTraceLog at: i. + (entryOop ~= 0 + and: [objectMemory shouldRemapOop: entryOop]) ifTrue: + [primTraceLog at: i put: (objectMemory remapObj: entryOop)]]]. - [:i| | selector | - selector := primTraceLog at: i. - (selector ~= 0 - and: [objectMemory shouldRemapOop: selector]) ifTrue: - [primTraceLog at: i put: (objectMemory remapObj: selector)]]]. 0 to: primTraceLogIndex - 1 do: + [:i| + entryOop := primTraceLog at: i. + (entryOop ~= 0 + and: [objectMemory shouldRemapOop: entryOop]) ifTrue: + [primTraceLog at: i put: (objectMemory remapObj: entryOop)]]! - [:i| | selector | - selector := primTraceLog at: i. - (selector ~= 0 - and: [objectMemory shouldRemapOop: selector]) ifTrue: - [primTraceLog at: i put: (objectMemory remapObj: selector)]]! Item was changed: ----- Method: CoInterpreter>>markAndTracePrimTraceLog (in category 'debug support') ----- markAndTracePrimTraceLog + "The prim trace log is a circular buffer of objects. If there is - "The prim trace log is a circular buffer of selectors. If there is an entry at primTraceLogIndex - 1 \\ PrimTraceBufferSize it has entries. If there is something at primTraceLogIndex it has wrapped." <inline: false> + | entryOop | (primTraceLog at: (self safe: primTraceLogIndex - 1 mod: PrimTraceLogSize)) = 0 ifTrue: [^self]. (primTraceLog at: primTraceLogIndex) ~= 0 ifTrue: [primTraceLogIndex to: PrimTraceLogSize - 1 do: + [:i| + entryOop := primTraceLog at: i. + (entryOop ~= 0 + and: [objectMemory isNonImmediate: entryOop]) ifTrue: + [objectMemory markAndTrace: entryOop]]]. - [:i| | selector | - selector := primTraceLog at: i. - (selector ~= 0 - and: [objectMemory isNonImmediate: selector]) ifTrue: - [objectMemory markAndTrace: selector]]]. 0 to: primTraceLogIndex - 1 do: + [:i| + entryOop := primTraceLog at: i. + (entryOop ~= 0 + and: [objectMemory isNonImmediate: entryOop]) ifTrue: + [objectMemory markAndTrace: entryOop]]! - [:i| | selector | - selector := primTraceLog at: i. - (selector ~= 0 - and: [objectMemory isNonImmediate: selector]) ifTrue: - [objectMemory markAndTrace: selector]]! Item was removed: - ----- Method: CoInterpreter>>printPrimLogEntryAt: (in category 'debug support') ----- - printPrimLogEntryAt: i - <inline: false> - | intOrSelector | - intOrSelector := primTraceLog at: i. - (objectMemory isImmediate: intOrSelector) - ifTrue: - [intOrSelector = TraceIncrementalGC ifTrue: - [self print: '**IncrementalGC**'. ^nil]. - intOrSelector = TraceFullGC ifTrue: - [self print: '**FullGC**'. ^nil]. - intOrSelector = TraceCodeCompaction ifTrue: - [self print: '**CompactCode**'. ^nil]. - intOrSelector = TraceStackOverflow ifTrue: - [self print: '**StackOverflow**'. ^nil]. - intOrSelector = TracePrimitiveFailure ifTrue: - [self print: '**PrimitiveFailure**'. ^nil]. - intOrSelector = TracePrimitiveRetry ifTrue: - [self print: '**PrimitiveRetry**'. ^nil]. - self print: '???'] - ifFalse: - [intOrSelector = 0 - ifTrue: ['%d!!!!!!' f: transcript printf: i] - ifFalse: [objectMemory safePrintStringOf: intOrSelector]]! Item was added: + ----- Method: CoInterpreter>>printPrimLogEntryAt:hasParameter: (in category 'debug support') ----- + printPrimLogEntryAt: i hasParameter: hasParameter + <inline: false> + "print the entry and answer if it takes a parameter (as the following entry)" + | entryOop className length | + entryOop := primTraceLog at: i. + hasParameter ifTrue: + [(objectMemory addressCouldBeObj: entryOop) + ifTrue: [className := self nameOfClass: entryOop lengthInto: (self addressOf: length put: [:v| length := v])] + ifFalse: [className := 'bad class'. length := 9]. + '%.*s\n' f: transcript printf: { length. className }. + ^false]. + (objectMemory isImmediate: entryOop) + ifTrue: + [entryOop = TraceIncrementalGC ifTrue: + [self print: '**IncrementalGC**\n'. ^false]. + entryOop = TraceFullGC ifTrue: + [self print: '**FullGC**\n'. ^false]. + entryOop = TraceCodeCompaction ifTrue: + [self print: '**CompactCode**\n'. ^false]. + entryOop = TraceStackOverflow ifTrue: + [self print: '**StackOverflow**\n'. ^false]. + entryOop = TracePrimitiveFailure ifTrue: + [self print: '**PrimitiveFailure** '. ^true]. + entryOop = TracePrimitiveRetry ifTrue: + [self print: '**PrimitiveRetry**\n'. ^false]. + self print: '???\n'] + ifFalse: + [(objectMemory addressCouldBeObj: entryOop) + ifFalse: ['%d!!!!!!\n' f: transcript printf: i] + ifTrue: + [(objectMemory isCompiledMethod: entryOop) + ifTrue: + [| methodClass methodSel | + className := '???'. length := 3. + methodClass := self safeMethodClassOf: entryOop. + methodClass ~= objectMemory nilObject ifTrue: + [className := self nameOfClass: methodClass lengthInto: (self addressOf: length put: [:v| length := v])]. + methodSel := self findSelectorOfMethod: entryOop. + methodSel = objectMemory nilObject + ifTrue: + ['%.*s>>bad selector %p\n' + f: transcript + printf: { length. className. methodSel }] + ifFalse: + ['%.*s>>#%.*s\n' + f: transcript + printf: { length. className. + objectMemory numBytesOfBytes: methodSel. objectMemory firstIndexableField: methodSel }]] + ifFalse: [objectMemory safePrintStringOf: entryOop. self cr]]]. + ^false! Item was changed: ----- Method: CoInterpreter>>slowPrimitiveResponse (in category 'primitive support') ----- slowPrimitiveResponse "Invoke a normal (non-quick) primitive. Called under the assumption that primFunctionPointer has been preloaded. Override to log primitive." (self recordPrimTraceForMethod: newMethod) ifTrue: + [self fastLogPrim: newMethod]. - [self fastLogPrim: messageSelector]. ^super slowPrimitiveResponse! Item was changed: ----- Method: InterpreterPrimitives>>primitiveSetOrHasIdentityHash (in category 'object access primitives') ----- primitiveSetOrHasIdentityHash | hash oldHash thisReceiver isReceiverAClass | argumentCount = 0 ifTrue: [| hasHash | hasHash := (objectMemory isNonImmediate: self stackTop) and: [objectMemory hasIdentityHash: self stackTop]. ^self methodReturnBool: hasHash]. isReceiverAClass := false. argumentCount = 2 ifTrue: [| lastArg | lastArg := self stackTop. (objectMemory isIntegerObject: lastArg) ifTrue: "e.g. Symbol primitiveSetIdentityHashOf: aSymbol to: hash" [hash := lastArg. thisReceiver := self stackValue: 1] ifFalse: "anObject primitiveSetIdentityHash: hashValue isBehavior: boolean" [thisReceiver := self stackValue: 2. hash := self stackValue: 1. lastArg = objectMemory trueObject ifTrue: [isReceiverAClass := true] ifFalse: [lastArg = objectMemory falseObject ifFalse: [^self primitiveFailFor: PrimErrBadArgument]]]] ifFalse: "anObject primitiveSetIdentityHashTo: hash" [thisReceiver := self stackValue: 1. hash := self stackTop]. ((objectMemory isIntegerObject: hash) + and: [hash := objectMemory integerValueOf: hash. "if written naturally, clang warns: unsequenced modification and access to 'hash' " + (hash bitAnd: objectMemory maxIdentityHash) = hash]) ifFalse: + [^self primitiveFailFor: PrimErrBadArgument]. - and: [((hash := objectMemory integerValueOf: hash) bitAnd: objectMemory maxIdentityHash) = hash]) ifFalse: - [^self primitiveFailFor: PrimErrBadArgument]. (objectMemory isNonImmediate: thisReceiver) ifFalse: [^self primitiveFailFor: (thisReceiver = (self stackValue: argumentCount) ifTrue: [PrimErrBadReceiver] ifFalse: [PrimErrBadArgument])]. oldHash := objectMemory hashBitsOf: thisReceiver. objectMemory setHashBitsOf: thisReceiver to: hash. (isReceiverAClass and: [objectMemory hasSpurMemoryManagerAPI]) ifTrue: [objectMemory classAtIndex: hash put: thisReceiver. "this figures out if the index is ambiguous and fixes all the instances if needed" objectMemory allInstancesOf: thisReceiver]. self methodReturnInteger: oldHash! Item was changed: ----- Method: SimpleStackBasedCogit>>genFastPrimTraceUsing:and: (in category 'primitive generators') ----- genFastPrimTraceUsing: r1 and: r2 + "Suport for compileInterpreterPrimitive. Generate inline code + so as to record the primitive trace as fast as possible." - "Suport for compileInterpreterPrimitive. Generate inline code so as to record the primitive - trace as fast as possible." backEnd byteReadsZeroExtend ifFalse: [self MoveCq: 0 R: r2]. self MoveAb: coInterpreter primTraceLogIndexAddress R: r2. self LoadEffectiveAddressMw: 1 r: r2 R: r1. self MoveR: r1 Ab: coInterpreter primTraceLogIndexAddress. methodLabel addDependent: (self annotateAbsolutePCRef: (self MoveCw: methodLabel asInteger R: r1)). + self MoveMw: (self offset: CogMethod of: #methodObject) r: r1 R: TempReg. - self MoveMw: (self offset: CogMethod of: #selector) r: r1 R: TempReg. self MoveCw: coInterpreter primTraceLogAddress asInteger R: r1. self MoveR: TempReg Xwr: r2 R: r1! Item was changed: CogClass subclass: #SpurMemoryManager (excessive size, no diff calculated) Item was added: + ----- Method: TVarArgsSendNode>>isSameAs: (in category 'comparing') ----- + isSameAs: aTParseNode + (aTParseNode isSend + and: [self numArgs = aTParseNode numArgs]) ifFalse: + [^false]. + ^super isSameAs: aTParseNode!

1 0

VM Maker: VMMaker.oscog-eem.3086.mcz
by commits＠source.squeak.org 13 Oct '21

13 Oct '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3086.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3086 Author: eem Time: 13 October 2021, 10:54:48.735388 am UUID: 326d7993-ca3c-4987-a17d-85db2e6c85fd Ancestors: VMMaker.oscog-eem.3085 CoInterpreterMT Work in progress towards being able to bind to any other thread than a specific thread. Process's threadId is now organized as two bits fields. The most significant 14 bits are the threadId; if negative, this means "bind to any thread other than the negation"; if positive, this means "bind to this thread". The least significant 14 bits are the thread the proces is affined to (temporarily bound to). If zero, the Process is not temporarily bound. Nuke noThreadingOfGUIThread. (hoping also to nuke activeProcessAffined & disowningVMThread). =============== Diff against VMMaker.oscog-eem.3085 =============== Item was changed: CoInterpreterPrimitives subclass: #CoInterpreterMT + instanceVariableNames: 'cogThreadManager checkThreadActivation maxWaitingPriority foreignCallbackPriority deferThreadSwitch disowningVMThread disownCount foreignCallbackProcessSlot activeProcessAffined relinquishing processHasThreadId reenterThreadSchedulingLoop willNotThreadWarnCount' + classVariableNames: 'DisownFlagsShift DisownVMForProcessorRelinquish OwnVMForeignThreadFlag PrimNumberRelinquishProcessor ProcessUnaffinedOnDisown ReturnToThreadSchedulingLoop VMAlreadyOwnedHenceDoNotDisown' - instanceVariableNames: 'cogThreadManager checkThreadActivation maxWaitingPriority foreignCallbackPriority deferThreadSwitch disowningVMThread disownCount foreignCallbackProcessSlot willNotThreadWarnCount activeProcessAffined relinquishing processHasThreadId noThreadingOfGUIThread reenterThreadSchedulingLoop' - classVariableNames: 'DisownFlagsShift DisownVMForProcessorRelinquish LockGUIThreadFlag LockGUIThreadShift OwnVMForeignThreadFlag PrimNumberRelinquishProcessor ProcessUnaffinedOnDisown ReturnToThreadSchedulingLoop VMAlreadyOwnedHenceDoNotDisown' poolDictionaries: 'VMThreadingConstants' category: 'VMMaker-Multithreading'! Item was changed: ----- Method: CoInterpreterMT class>>initializeSchedulerIndices (in category 'initialization') ----- initializeSchedulerIndices super initializeSchedulerIndices. "Class Process" + "The thread id of a process is either nil or a SmallInteger that defines how a process binds to threads. + If nil, the process may run on any thread. + The least significant bit of threadId is a flag. The most significant bits are a threadId. + If the threadId is nil the process can run on any thread. + If the flag (least significant bit) is set then + If the threadId is positive the process can only be run on the thread with that thread Id. + If the threadId is negative the process must not be run on the thread with that thread Id. + If the flag (least significant bit) is not set then + the thread id will not be negative and if non-zero is the id of the thread the process is currenty running on + The flag is probably a mistake..." + + "In part, what's really going on here is an attempt to deal with threading on Mac. Events can only be delivered + on the GUi thread. To avoid blocking and/or crashing the VM by making a blocking (e.g. FFI) call on the GUI + thread we want a nice way of preventing a process from running on the GUI thread. We can then use a process + whose threadId precludes running on the GUI thread to make blocking calls. The alternative, of arranging that + events are delivered to a thread the VM does not run on, is problematic; it cannot support event callbacks." + + "So if we simplify, and threadId is only instructive to the VM, (i.e. can say ''run on a given thread'', or ''don't run + on a given thread'', and ''don't care; run on any thread'') and does not necessarily hold the threadId of the thread + the process is currenty bound to, how do we locate the threadId for a process temporarily affined to a thread for + the duration of an FFI call? Note that a process *must* be bound to a thread for the duration of a threaded call + (or foreign callback) so that return occurs on the correct thread. We can use the least significant bit to mean + ''temporarily affined'', but we need to support ''don't run on this thread''. We could use bit fields (yuck); we + could allocate a two field object and assign it to threadId when setting a process to not run on a given thread. + + This isn't so bad; use negative values to mean ''don't run on this thread'', and positive values to mean ''run on this thread''. + Split the smallest SmallInteger (32-bit, 1 bit sign, 2-bit tags, leaving 29//2) into two 14 bit fields. The least significant + 14 bits are the thread id the receiver is temporarily affined to. The most significant 14 bits are the thread id of the + thread the proess is either bound to or excluded from. If zero, the process is agnostic. See CogThreadManager>>#maxNumThreads" ThreadIdIndex := 4. + ThreadIdShift := 14. "could be 30 in 64-bits" + "disown result/own argument flags" + OwnVMForeignThreadFlag := 1. + VMAlreadyOwnedHenceDoNotDisown := 2. + ProcessUnaffinedOnDisown := 4. + "& defined in StackInterpreter are..." + DisownVMForFFICall := 8. + DisownVMForThreading := 16. + DisownFlagsShift := 5! - "disown result/own argument flags & max number of threads" - LockGUIThreadShift := 16. - LockGUIThreadFlag := 1 << LockGUIThreadShift. - OwnVMForeignThreadFlag := 1 << (LockGUIThreadShift + 1). - VMAlreadyOwnedHenceDoNotDisown := 1 << (LockGUIThreadShift + 2). - ProcessUnaffinedOnDisown := 1 << (LockGUIThreadShift + 3). - DisownFlagsShift := LockGUIThreadShift + 4. - ThreadIdMask := (1 << LockGUIThreadShift) - 1 "results in 64k thread indices" - ! Item was added: + ----- Method: CoInterpreterMT>>affinedThreadId: (in category 'process primitive support') ----- + affinedThreadId: threadIdField + "Answer the threadId of the thread threadIdField is temporarily bound to, or 0 if none." + ^(objectMemory isIntegerObject: threadIdField) + ifTrue: [(objectMemory integerValueOf: threadIdField) anyMask: 1 << ThreadIdShift - 1] + ifFalse: [0]! Item was changed: ----- Method: CoInterpreterMT>>bindProcess:toId: (in category 'process primitive support') ----- bindProcess: aProcess toId: newId "Change a Process's thread binding and answer 0, otherwise answer a suitable error code. Cases: process is unbound & unaffined id 0 nothing to do id non-zero ensure thread and bind process is affined (temporarily bound to a thread for the duration of a surrender of ownership) id = affined index nothing to do id = 0 nothing to do id ~= 0 && id ~= affined index fail process is bound (permanently bound to a thread) id = bound index nothing to do id ~= bound index set bound index" + | threadIdField ownerIndex affinedId | - | threadId ownerIndex newThreadIndex | processHasThreadId ifFalse: [^PrimErrUnsupported]. + threadIdField := self threadIdFieldOf: aProcess. + ownerIndex := self ownerIndexOfThreadId: threadIdField. - threadId := self threadIdFieldOf: aProcess. - newThreadIndex := self ownerIndexOfThreadId: newId. - ownerIndex := self ownerIndexOfThreadId: threadId. + "If aProcess is affined (temporarily bound to) a thread then the operation can only + succeed if the newId is the same as that aProcess is affined to, or is zero (is unbinding)." + (self isAffinedThreadId: threadIdField) ifTrue: + [affinedId := self affinedThreadId: threadIdField. + (newId = 0 + or: [newId = affinedId]) ifTrue: + [self setThreadIdFieldOfProcess: aProcess to: newId << ThreadIdShift + affinedId. + ^0]. - (self isAffinedThreadId: threadId) ifTrue: - [(ownerIndex = newId - or: [newId = 0]) ifTrue: - [^0]. ^PrimErrInappropriate]. + ownerIndex > 0 ifTrue: + [(self startThreadForThreadIndex: ownerIndex) ifFalse: - newThreadIndex > 0 ifTrue: - [(self startThreadForThreadIndex: newThreadIndex) ifFalse: [^PrimErrLimitExceeded]]. + self setThreadIdFieldOfProcess: aProcess to: newId << ThreadIdShift. - self setOwnerIndexOfProcess: aProcess to: newId bind: true. ^0! Item was changed: ----- Method: CoInterpreterMT>>disownVM: (in category 'vm scheduling') ----- disownVM: flags "Release the VM to other threads and answer the current thread's index. Currently valid flags: DisownVMForFFICall - informs the VM that it is entering an FFI call DisownVMForThreading - informs the VM that it is entering code during which threading should be permitted OwnVMForeignThreadFlag - indicates lowest-level entry from a foreign thread - not to be used explicitly by clients - only set by ownVMFromUnidentifiedThread VMAlreadyOwnedHenceDoNotDisown - indicates an ownVM from a callback was made when the vm was still owned. - not to be used explicitly by clients - only set by ownVMFromUnidentifiedThread This is the entry-point for plugins and primitives that wish to release the VM while performing some operation that may potentially block, and for callbacks returning back to some blocking operation. If this thread does not reclaim the VM before- hand then when the next heartbeat occurs the thread manager will schedule a thread to acquire the VM which may start running the VM in place of this thread. N.B. Most of the state needed to resume after preemption is set in preemptDisowningThread." <api> <inline: false> | vmThread result | + self assert: (flags >= 0 and: [flags < (1 bitShift: DisownFlagsShift)]). - <var: #vmThread type: #'CogVMThread *'> self assert: self successful. cogit recordEventTrace ifTrue: [self recordTrace: TraceDisownVM thing: (objectMemory integerObjectOf: flags) source: 0]. processHasThreadId ifFalse: [willNotThreadWarnCount < 10 ifTrue: [self print: 'warning: VM parameter 48 indicates Process doesn''t have threadId; VM will not thread'; cr. willNotThreadWarnCount := willNotThreadWarnCount + 1]]. vmThread := cogThreadManager currentVMThread. (flags anyMask: VMAlreadyOwnedHenceDoNotDisown) ifTrue: [disowningVMThread := vmThread. vmThread state: CTMUnavailable. ^0]. self assertCStackPointersBelongToCurrentThread. self assertValidNewMethodPropertyFlags. (flags anyMask: DisownVMForProcessorRelinquish) ifTrue: [| proc | (proc := objectMemory splObj: foreignCallbackProcessSlot) ~= objectMemory nilObject ifTrue: [foreignCallbackPriority := self quickFetchInteger: PriorityIndex ofObject: proc]. relinquishing := true. self sqLowLevelMFence]. - (noThreadingOfGUIThread and: [self inGUIThread]) ifTrue: - [^vmThread index - + LockGUIThreadFlag - + (activeProcessAffined ifTrue: [0] ifFalse: [ProcessUnaffinedOnDisown]) - + (flags << DisownFlagsShift)]. disownCount := disownCount + 1. disowningVMThread := vmThread. "self cr; cr; print: 'disownVM Csp: '; printHex: vmThread cStackPointer; cr. (0 to: 16 by: 4) do: [:offset| self print: ' *(esp+'; printNum: offset; print: ': '; printHex: (stackPages longAt: cogit processor sp + offset); cr]. cogit processor printIntegerRegistersOn: Transcript." "OwnVMForeignThreadFlag indicates lowest-level of entry by a foreign thread. If that's where we are then release the vmThread. Otherwise indicate the vmThread is off doing something outside of the VM." (flags anyMask: OwnVMForeignThreadFlag) ifTrue: ["I don't think this is quite right. Josh's use case is creating some foreign thread and then registering it with the VM. That's not the same as binding a process to a foreign thread given that the foreign callback process is about to terminate anyway (it is returning from a callback here). So do we need an additional concept, that of a vmThread being either of the set known to the VM or floating?" self flag: 'issue with registering foreign threads with the VM'. (self isBoundProcess: self activeProcess) ifFalse: [cogThreadManager unregisterVMThread: vmThread]] ifFalse: [vmThread state: CTMUnavailable]. + result := ((vmThread index bitShift: DisownFlagsShift) + bitOr: (activeProcessAffined ifTrue: [0] ifFalse: [ProcessUnaffinedOnDisown])) + bitOr: flags. - result := vmThread index - + (activeProcessAffined ifTrue: [0] ifFalse: [ProcessUnaffinedOnDisown]) - + (flags << DisownFlagsShift). cogThreadManager releaseVM. ^result! Item was changed: ----- Method: CoInterpreterMT>>getImageHeaderFlags (in category 'image save/restore') ----- getImageHeaderFlags "Answer the flags that are contained in the 7th long of the image header." ^fullScreenFlag "0 or 1" + (VMBIGENDIAN ifTrue: [0] ifFalse: [2]) "this is the imageFloatsLittleEndian flag" + (processHasThreadId ifTrue: [4] ifFalse: [0]) + (flagInterpretedMethods ifTrue: [8] ifFalse: [0]) + (preemptionYields ifTrue: [0] ifFalse: [16r10]) + "was: noThreadingOfGUIThread ifTrue: [16r20] ifFalse: [0]); a broken idea" - + (noThreadingOfGUIThread ifTrue: [16r20] ifFalse: [0]) + (newFinalization ifTrue: [16r40] ifFalse: [0]) + (sendWheelEvents ifTrue: [16r80] ifFalse: [0]) + (primitiveDoMixedArithmetic ifTrue: [0] ifFalse: [16r100]) + (imageHeaderFlags bitClear: 16r1FF) "these are any flags we do not recognize"! Item was removed: - ----- Method: CoInterpreterMT>>inGUIThread (in category 'vm scheduling') ----- - inGUIThread - "The first thread is assumed to be the GUI thread, the VM thread that expects to receive - window events, etc. This might appear to invite race conditions but it is only to be used - to decide whether to not give up the VM from the GUI thread (see disownVM:)." - self assert: noThreadingOfGUIThread. - ^cogThreadManager vmOwnerIs: 1! Item was changed: ----- Method: CoInterpreterMT>>isAffinedProcess: (in category 'process primitive support') ----- isAffinedProcess: aProcess + ^self isAffinedThreadId: (self threadIdFieldValueOf: aProcess)! - ^self isAffinedThreadId: (self ownerIndexOfProcess: aProcess)! Item was changed: ----- Method: CoInterpreterMT>>isAffinedThreadId: (in category 'process primitive support') ----- + isAffinedThreadId: threadIdField + "Answer if the threadId has the bits set indicating the thread it is temporarily bound to." + ^(self affinedThreadId: threadIdField) ~= 0! - isAffinedThreadId: threadId - ^(objectMemory isIntegerObject: threadId) - and: [((objectMemory integerValueOf: threadId) bitAnd: 1) = 0]! Item was removed: - ----- Method: CoInterpreterMT>>isUnboundThreadId: (in category 'process primitive support') ----- - isUnboundThreadId: threadId - "Answer if the threadId is neither affined nor bound. Not the same as bound not." - ^threadId = objectMemory nilObject - or: [((objectMemory integerValueOf: threadId) bitAnd: (ThreadIdMask << 1) + 1) = 0]! Item was changed: ----- Method: CoInterpreterMT>>ownVM: (in category 'vm scheduling') ----- ownVM: threadIndexAndFlags <api> <inline: false> "This is the entry-point for plugins and primitives that wish to reacquire the VM after having released it via disownVM or callbacks that want to acquire it without knowing their ownership status. This call will block until the VM is owned by the current thread or an error occurs. The argument should be the value answered by disownVM, or 0 for callbacks that don't know if they have disowned or not. This is both an optimization to avoid having to query thread- local storage for the current thread's index (since it can easily keep it in some local variable), and a record of when an unbound process becomes affined to a thread for the dynamic extent of some operation. Answer 0 if the current thread is known to the VM (and on return owns the VM). Answer 1 if the current thread is unknown to the VM and takes ownership. Answer -1 if the current thread is unknown to the VM and fails to take ownership." | threadIndex flags vmThread | threadIndexAndFlags = 0 ifTrue: [^self ownVMFromUnidentifiedThread]. + threadIndex := threadIndexAndFlags bitShift: DisownFlagsShift negated. + flags := threadIndexAndFlags bitAnd: (1 bitShift: DisownFlagsShift) - 1. - threadIndex := threadIndexAndFlags bitAnd: ThreadIdMask. - flags := threadIndexAndFlags >> DisownFlagsShift. (flags anyMask: DisownVMForProcessorRelinquish) ifTrue: ["Presumably we have nothing to do; this primitive is typically called from the background process. So we should /not/ try and activate any threads in the pool; they will waste cycles finding there is no runnable process, and will cause a VM abort if no runnable process is found. But we /do/ want to allow FFI calls that have completed, or callbacks a chance to get into the VM; they do have something to do. DisownVMForProcessorRelinquish indicates this." relinquishing := false. self sqLowLevelMFence]. - (threadIndexAndFlags anyMask: LockGUIThreadFlag) ifTrue: - [self assert: (noThreadingOfGUIThread and: [self inGUIThread]). - self assert: disowningVMThread isNil. - cogit recordEventTrace ifTrue: - [self recordTrace: TraceOwnVM thing: ConstZero source: 0]. - ^0]. - vmThread := cogThreadManager acquireVMFor: threadIndex. disownCount := disownCount - 1. disowningVMThread ifNotNil: [vmThread = disowningVMThread ifTrue: [self assert: (vmThread cFramePointer isNil or: [CFramePointer = vmThread cFramePointer and: [CStackPointer = vmThread cStackPointer]]). self assert: self successful. self assert: (objectMemory fetchPointer: MyListIndex ofObject: self activeProcess) = objectMemory nilObject. disowningVMThread := nil. cogit recordEventTrace ifTrue: [self recordTrace: TraceOwnVM thing: ConstOne source: 0]. ^0]. "if not preempted we're done." self preemptDisowningThread]. "We've been preempted; we must restore state and update the threadId in our process, and may have to put the active process to sleep." self restoreVMStateFor: vmThread threadIndexAndFlags: threadIndexAndFlags. cogit recordEventTrace ifTrue: [self recordTrace: TraceOwnVM thing: ConstTwo source: 0]. ^threadIndexAndFlags bitAnd: OwnVMForeignThreadFlag! Item was changed: ----- Method: CoInterpreterMT>>ownerIndexOfThreadId: (in category 'process primitive support') ----- ownerIndexOfThreadId: threadId ^(objectMemory isIntegerObject: threadId) + ifTrue: [(objectMemory integerValueOf: threadId) >> ThreadIdShift] - ifTrue: [(objectMemory integerValueOf: threadId) >> 1 bitAnd: ThreadIdMask] ifFalse: [0]! Item was changed: ----- Method: CoInterpreterMT>>primitiveProcessBindToThreadId (in category 'process primitives') ----- primitiveProcessBindToThreadId "Attempt to bind the receiver to the thread with the id of the argument or nil, where the receiver is a Process. If successful the VM will ensure that there are at least id many threads active." + | aProcess id | - | aProcess id ec | <export: true> self cCode: [] inSmalltalk: [cogThreadManager isNil ifTrue: [^self primitiveFail]]. + processHasThreadId ifFalse: + [^self primitiveFailFor: PrimErrUnsupported]. id := self stackTop. aProcess := self stackValue: 1. ((id = objectMemory nilObject or: [(objectMemory isIntegerObject: id) + and: [id ~= (objectMemory integerObjectOf: 0)]]) - and: [(objectMemory integerValueOf: id) >= 0]]) and: [(objectMemory isPointers: aProcess) and: [(objectMemory slotSizeOf: aProcess) >= (ThreadIdIndex + 1)]]) ifFalse: [^self primitiveFailFor: PrimErrBadArgument]. id := id = objectMemory nilObject ifTrue: [0] ifFalse: [objectMemory integerValueOf: id]. + id abs >= cogThreadManager maxNumThreads ifTrue: - id >= cogThreadManager maxNumThreads ifTrue: [^self primitiveFailFor: PrimErrLimitExceeded]. + (self bindProcess: aProcess toId: id) ifNotNil: + [:ec| ^self primitiveFailFor: ec]. + id := self ownerIndexOfProcess: aProcess. - (ec := self bindProcess: aProcess toId: id) ~= 0 ifTrue: - [^self primitiveFailFor: ec]. (aProcess = self activeProcess and: [(activeProcessAffined := id ~= 0) + and: [(cogThreadManager vmOwnerIsCompatibleWith: id) not]]) ifTrue: - and: [(cogThreadManager vmOwnerIs: id) not]]) ifTrue: [(self quickFetchInteger: PriorityIndex ofObject: aProcess) < maxWaitingPriority ifTrue: [maxWaitingPriority = self quickFetchInteger: PriorityIndex ofObject: aProcess]. checkThreadActivation := true. self forceInterruptCheck]. self methodReturnReceiver! Item was changed: ----- Method: CoInterpreterMT>>primitiveProcessBoundThreadId (in category 'process primitives') ----- primitiveProcessBoundThreadId + "Answer the receiver's current thread Id or nil, where the receiver is a Process. + If the threadId is positive then the receiver is bound to the thread with that id. + If the threadId is negative then the receiver is excluded from running on the thread with that id." - "Answer the receiver's current thread Id or nil, where the receiver is a Process." | aProcess id | <export: true> self cCode: [] inSmalltalk: [cogThreadManager isNil ifTrue: [^self primitiveFail]]. + processHasThreadId ifFalse: + [^self primitiveFailFor: PrimErrUnsupported]. aProcess := self stackTop. id := self ownerIndexOfProcess: aProcess. + self methodReturnValue: (id = 0 + ifTrue: [objectMemory nilObject] + ifFalse: [objectMemory integerObjectOf: id])! - self pop: argumentCount + 1 - thenPush: (id = 0 - ifTrue: [objectMemory nilObject] - ifFalse: [objectMemory integerObjectOf: id])! Item was changed: ----- Method: CoInterpreterMT>>setImageHeaderFlags: (in category 'internal interpreter access') ----- setImageHeaderFlags: flags "Set an array of flags indicating various properties of the saved image, responded to on image load. These are the same as the image header flags shifted right two bits, omitting the fullScreenFlag and float byte order flag. Bit 0: if set, implies the image's Process class has threadId as its 3rd inst var (zero relative) Bit 1: if set, methods that are interpreted will have the flag bit set in their header Bit 2: if set, implies preempting a process does not put it to the back of its run queue + Bit 3: unassigned; used to mean if set, implies a threaded VM will not disown the VM if owned by the GUI thread; a broken idea - Bit 3: if set, implies a threaded VM will not disown the VM if owned by the GUI thread Bit 4: if set, implies the new finalization scheme where WeakArrays are queued Bit 5: if set, implies wheel events will be delivered as such and not mapped to arrow key events Bit 6: if set, implies arithmetic primitives will fail if given arguments of different types (float vs int) Bit 7: if set, implies file primitives (FilePlugin, FileAttributesPlugin) will answer file times in UTC not local times" flags asUnsignedInteger > 255 ifTrue: [^self primitiveFailFor: PrimErrUnsupported]. + (flags anyMask: 8) ifTrue: + [^self primitiveFailFor: PrimErrInappropriate]. processHasThreadId := flags anyMask: 1. flagInterpretedMethods := flags anyMask: 2. preemptionYields := flags noMask: 4. + "was: noThreadingOfGUIThread := flags anyMask: 8. a broken idea" - noThreadingOfGUIThread := flags anyMask: 8. newFinalization := flags anyMask: 16. sendWheelEvents := flags anyMask: 32. primitiveDoMixedArithmetic := flags noMask: 64. imageHeaderFlags := (flags anyMask: 128) ifTrue: [imageHeaderFlags bitOr: 512] ifFalse: [imageHeaderFlags bitClear: 512]! Item was changed: ----- Method: CoInterpreterMT>>setImageHeaderFlagsFrom: (in category 'image save/restore') ----- setImageHeaderFlagsFrom: headerFlags "Set the flags that are contained in the 7th long of the image header." imageHeaderFlags := headerFlags. "so as to preserve unrecognised flags." fullScreenFlag := headerFlags bitAnd: 1. imageFloatsBigEndian := (headerFlags noMask: 2) ifTrue: [1] ifFalse: [0]. processHasThreadId := headerFlags anyMask: 4. flagInterpretedMethods := headerFlags anyMask: 8. preemptionYields := headerFlags noMask: 16. + "was: noThreadingOfGUIThread := headerFlags anyMask: 32. a broken idea" - noThreadingOfGUIThread := headerFlags anyMask: 32. newFinalization := headerFlags anyMask: 64. sendWheelEvents := headerFlags anyMask: 128. primitiveDoMixedArithmetic := headerFlags noMask: 256. processHasThreadId ifFalse: [self print: 'warning, processHasThreadId flag is unset; cannot function as a threaded VM if so.'; cr]! Item was added: + ----- Method: CoInterpreterMT>>setOwnerIndexOfProcess:to: (in category 'process primitive support') ----- + setOwnerIndexOfProcess: aProcess to: threadIdField + | threadIdSlot | + threadIdSlot := threadIdField = 0 + ifTrue: [objectMemory nilObject] + ifFalse: [objectMemory integerObjectOf: threadIdField]. + objectMemory storePointerUnchecked: ThreadIdIndex ofObject: aProcess withValue: threadIdSlot! Item was added: + ----- Method: CoInterpreterMT>>setThreadIdFieldOfProcess:to: (in category 'process primitive support') ----- + setThreadIdFieldOfProcess: aProcess to: threadIdField + | threadIdSlot | + threadIdSlot := threadIdField = 0 + ifTrue: [objectMemory nilObject] + ifFalse: [objectMemory integerObjectOf: threadIdField]. + objectMemory storePointerUnchecked: ThreadIdIndex ofObject: aProcess withValue: threadIdSlot! Item was added: + ----- Method: CoInterpreterMT>>threadIdFieldValueOf: (in category 'process primitive support') ----- + threadIdFieldValueOf: aProcess + ^processHasThreadId + ifTrue: + [| field | + field := objectMemory fetchPointer: ThreadIdIndex ofObject: aProcess. + field = objectMemory nilObject + ifTrue: [0] + ifFalse: [objectMemory integerValueOf: field]] + ifFalse: [0]! Item was changed: ----- Method: CogThreadManager>>maxNumThreads (in category 'simulation') ----- maxNumThreads + "This could be a VM parameter (within the proscribed limits described below)... + It is chosen so that two fields of this width fit in a SmallInteger, to fit the needs of threadId. + The sign flag is used to say ``don't run on this thread'', and 32-bit Spur has 2-bit immediate tags, + which leaves us 29 bits to play with. 2 raisedTo: (29 // 2) is 16k. If this ever becomes a serious limit + we can use a different value in 64-bits. 64-bit Spur has 3-bit immediate tags, which leaves us 60 + bits to play with. 2 raisedTo: (60 / 2) is 1g. Note that the max number is 1 << ThreadIdShift - 1 + because 0 is not a valid threadId; it means ''the VM is unowned''" + + ^self cCode: [1 << ThreadIdShift - 1] inSmalltalk: [16]! - ^self cCode: [ThreadIdMask] inSmalltalk: [16]! Item was added: + ----- Method: CogThreadManager>>threadIndex:isCompatibleWith: (in category 'public api-testing') ----- + threadIndex: aThreadIndex isCompatibleWith: processThreadId + "Test if processThreadId is ok to run on a thread with the given index." + <inline: true> + ^processThreadId >= 0 + ifTrue: [aThreadIndex = (processThreadId >> 1)] + ifFalse: [aThreadIndex ~= (0 - (processThreadId >> 1))]! Item was added: + ----- Method: CogThreadManager>>vmOwnerIsCompatibleWith: (in category 'public api-testing') ----- + vmOwnerIsCompatibleWith: processThreadId + "Test if the vmOwner is index." + <inline: true> + self sqLowLevelMFence. + ^self threadIndex: vmOwner isCompatibleWith: processThreadId! Item was removed: - ----- Method: CogVMSimulator>>inGUIThread (in category 'multi-threading simulation switch') ----- - inGUIThread - "This method includes or excludes CoInterpreterMT methods as required. - Auto-generated by CogVMSimulator>>ensureMultiThreadingOverridesAreUpToDate" - - ^self perform: #inGUIThread - withArguments: {} - inSuperclass: (cogThreadManager ifNil: [CoInterpreterPrimitives] ifNotNil: [CoInterpreterMT])! Item was removed: - ----- Method: CogVMSimulator>>isUnboundThreadId: (in category 'multi-threading simulation switch') ----- - isUnboundThreadId: threadId - "This method includes or excludes CoInterpreterMT methods as required. - Auto-generated by CogVMSimulator>>ensureMultiThreadingOverridesAreUpToDate" - - ^self perform: #isUnboundThreadId: - withArguments: {threadId} - inSuperclass: (cogThreadManager ifNil: [CoInterpreterPrimitives] ifNotNil: [CoInterpreterMT])! Item was changed: SharedPool subclass: #VMThreadingConstants instanceVariableNames: '' + classVariableNames: 'AWOLProcessesIncrement CTMAssignableOrInVM CTMInitializing CTMUnavailable CTMWantingOwnership ThreadIdIndex ThreadIdShift' - classVariableNames: 'AWOLProcessesIncrement CTMAssignableOrInVM CTMInitializing CTMUnavailable CTMWantingOwnership ThreadIdIndex ThreadIdMask' poolDictionaries: '' category: 'VMMaker-Multithreading'! !VMThreadingConstants commentStamp: '<historical>' prior: 0! VMThreadingConstants ensureClassPool. CogThreadManager classPool keys do: [:k| VMThreadingConstants classPool declare: k from: CogThreadManager classPool]. CoInterpreterMT classPool keys do: [:k| VMThreadingConstants classPool declare: k from: CoInterpreterMT classPool].!

1 0

VM Maker: VMMaker.oscog-eem.3085.mcz
by commits＠source.squeak.org 13 Oct '21

13 Oct '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3085.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3085 Author: eem Time: 12 October 2021, 5:10:25.197347 pm UUID: 8944e76f-f64a-4576-8754-c8dd1d2abf83 Ancestors: VMMaker.oscog-eem.3084 Spur32BitPreen to SpurImagePreener rename. Nuke the unused inSortedFreeListLink:to:given: When building a code generator, exclude all simulator classes. =============== Diff against VMMaker.oscog-eem.3084 =============== Item was removed: - ----- Method: Spur32BitMMLESimulator>>inSortedFreeListLink:to:given: (in category 'compaction') ----- - inSortedFreeListLink: freeChunk to: nextFree given: prevFree - "thisContext sender selector = #sweepToCoallesceFreeSpaceForPigCompactFrom: ifTrue: - [| pit | - pit := [:label :thing| - coInterpreter print: label; space; printHex: thing. - (thing ~= 0 and: [self isFreeObject: thing]) ifTrue: - [coInterpreter print: ' (free) ']]. - pit value: 'link ' value: freeChunk. - pit value: ' to ' value: nextFree. - pit value: ' from ' value: prevFree. - coInterpreter cr]." - "freeChunk = 16r10B0730 ifTrue: - [self halt]." - super inSortedFreeListLink: freeChunk to: nextFree given: prevFree! Item was removed: - ----- Method: Spur64BitMMLESimulator>>inSortedFreeListLink:to:given: (in category 'compaction') ----- - inSortedFreeListLink: freeChunk to: nextFree given: prevFree - "thisContext sender selector = #sweepToCoallesceFreeSpaceForPigCompactFrom: ifTrue: - [| pit | - pit := [:label :thing| - coInterpreter print: label; space; printHex: thing. - (thing ~= 0 and: [self isFreeObject: thing]) ifTrue: - [coInterpreter print: ' (free) ']]. - pit value: 'link ' value: freeChunk. - pit value: ' to ' value: nextFree. - pit value: ' from ' value: prevFree. - coInterpreter cr]." - "freeChunk = 16r10B0730 ifTrue: - [self halt]." - super inSortedFreeListLink: freeChunk to: nextFree given: prevFree! Item was changed: ----- Method: SpurImageTestResource class>>preenImage (in category 'preening') ----- preenImage + "Assume there's a trunk image in ., oscogvm/image or ../oscogvm/image. - "Assume there's a Pharo bootstrap core32.image in ../oscogvm/image/core32.image. We should find out where the image directory is and write a download script to get it. But for now assume it's there. See e.g. https://bintray.com/pharo-project/pharo/Pharo/201701061402-32bit#files" "[self preenImage] timeToRun" + SpurImagePreener new - Spur32BitPreen new writeDefaultHeader: true; savedWindowSize: 640@480; preenImage: self imageNameForTests! Item was changed: ----- Method: SpurMemoryManager class>>initialize (in category 'class initialization') ----- initialize "SpurMemoryManager initialize" BitsPerByte := 8. "Initialize at least the become constants for the Spur bootstrap where the old ObjectMemory simulator is used before a Spur simulator is created.." self initializeSpurObjectRepresentationConstants. "An obj stack is a stack of objects stored in a hidden root slot, such as the markStack or the ephemeronQueue. It is a linked list of segments, with the hot end at the head of the list. It is a word object. The stack pointer is in ObjStackTopx and 0 means empty. The list goes through ObjStackNextx. We don't want to shrink objStacks, since they're used in GC and it's good to keep their memory around. So unused pages created by popping emptied pages are kept on the ObjStackFreex list. ObjStackNextx must be the last field for swizzleObjStackAt:." ObjStackPageSlots := 4092. "+ double header = 16k bytes per page in 32-bits, 32k bytes per page in 64 bits" ObjStackTopx := 0. ObjStackMyx := 1. ObjStackFreex := 2. ObjStackNextx := 3. ObjStackFixedSlots := 4. ObjStackLimit := ObjStackPageSlots - ObjStackFixedSlots. "The hiddenRootsObject contains the classTable pages and up to 8 additional objects. Currently we use four; the three objStacks (the mark stack, the weaklings and the mourn queue), and the rememberedSet." MarkStackRootIndex := self basicNew classTableRootSlots. WeaklingStackRootIndex := MarkStackRootIndex + 1. MournQueueRootIndex := MarkStackRootIndex + 2. RememberedSetRootIndex := MarkStackRootIndex + 3. MarkObjectsForEnumerationPrimitives := false. "The remap buffer support is for compatibility; Spur doesn't GC during allocation. Eventually this should die." RemapBufferSize := 25. "Extra roots are for plugin support." + ExtraRootsSize := 64. "max. # of external roots; used e.g. by the PyBridge plugin which uses three entries" - ExtraRootsSize := 2048. "max. # of external roots" "gcPhaseInProgress takes these values to identify phases as required." ScavengeInProgress := 1. SlidingCompactionInProgress := 2! Item was changed: ----- Method: SpurPlanningCompactorTests class>>preenImage (in category 'utilities') ----- preenImage "Assume there's a Pharo bootstrap core32.image in ../oscogvm/image/core32.image. We should find out where the image directory is and write a download script to get it. But for now assume it's there. See e.g. https://bintray.com/pharo-project/pharo/Pharo/201701061402-32bit#files" "[SpurPlanningCompactorTests preenImage] timeToRun" + SpurImagePreener new - Spur32BitPreen new writeDefaultHeader: true; savedWindowSize: 640@480; preenImage: '../oscogvm/image/core32'! Item was added: + ----- Method: VMClass class>>theNonSimulatorClass (in category 'translation') ----- + theNonSimulatorClass + | class | + class := self. + [class name includesSubstring: 'Simulator'] whileTrue: + [class := class superclass]. + ^class! Item was changed: ----- Method: VMMaker>>buildCodeGeneratorForInterpreter:includeAPIMethods:initializeClasses: (in category 'generate sources') ----- buildCodeGeneratorForInterpreter: interpreterClass includeAPIMethods: getAPIMethods initializeClasses: initializeClasses "Answer the code generator for translating the interpreter." + | cg interpreterClasses addedClasses | - | cg interpreterClasses | initializeClasses ifTrue: [interpreterClass initializeWithOptions: optionsDictionary. interpreterClass hasCogit ifTrue: [interpreterClass cogitClass initializeWithOptions: optionsDictionary]]. (cg := self createCodeGenerator) vmClass: interpreterClass. "Construct interpreterClasses as all classes from interpreterClass & objectMemoryClass up to VMClass in superclass to subclass order." interpreterClasses := OrderedCollection new. {interpreterClass. interpreterClass objectMemoryClass} do: [:vmClass| | theClass | + theClass := vmClass theNonSimulatorClass. - theClass := vmClass. [theClass ~~ VMClass] whileTrue: [interpreterClasses addFirst: theClass. theClass := theClass superclass]]. interpreterClasses addFirst: VMClass; + addAllLast: ((cg nonStructClassesForTranslationClasses: interpreterClasses) collect: [:vmClass| vmClass theNonSimulatorClass]). - addAllLast: (cg nonStructClassesForTranslationClasses: interpreterClasses). initializeClasses ifTrue: [interpreterClasses do: [:ic| (ic respondsTo: #initializeWithOptions:) ifTrue: [ic initializeWithOptions: interpreterClass initializationOptions] ifFalse: [ic initialize]]. (cg structClassesForTranslationClasses: interpreterClasses) do: [:structClass| structClass initialize]]. cg addStructClasses: (cg structClassesForTranslationClasses: interpreterClasses). + addedClasses := IdentitySet new. + interpreterClasses do: + [:ic| (addedClasses ifAbsentAdd: ic) ifTrue: [cg addClass: ic]]. - interpreterClasses do: [:ic| cg addClass: ic]. getAPIMethods ifTrue: [interpreterClass cogitClass ifNotNil: [:cogitClass| cg includeAPIFrom: (self buildCodeGeneratorForCogit: cogitClass includeAPIMethods: false initializeClasses: false)]]. ^cg!

1 0

VM Maker: Cog-eem.443.mcz
by commits＠source.squeak.org 13 Oct '21

13 Oct '21

Eliot Miranda uploaded a new version of Cog to project VM Maker: http://source.squeak.org/VMMaker/Cog-eem.443.mcz ==================== Summary ==================== Name: Cog-eem.443 Author: eem Time: 12 October 2021, 5:06:25.327116 pm UUID: a2a61f70-7cad-4dcb-9939-a2a46b71d13a Ancestors: Cog-eem.442 Make Spur32BitPreen image size agnostic, and hence also rename it to SpurImagePreener =============== Diff against Cog-eem.442 =============== Item was removed: - SimulatorHarness subclass: #Spur32BitPreen - instanceVariableNames: 'oldHeap newHeap map reverseMap oldInterpreter newInterpreter imageHeaderFlags savedWindowSize writeDefaultHeader' - classVariableNames: '' - poolDictionaries: 'VMObjectIndices' - category: 'Cog-Bootstrapping'! - - !Spur32BitPreen commentStamp: 'eem 2/6/2020 18:44' prior: 0! - A Spur32BitPreen is a simple image rewriter for 32-bit Spur images that eliminates free space and hence shrinks the preened image. Use via - Spur32BitPreen new preenImage: 'spur' - which will produce spur-preen.image and spur-preen.changes from spur.image and spur.changes. - - Instance Variables - imageHeaderFlags: <Integer> - map: <Dictionary> - newHeap: <Spur32BitMMLESimulator> - newInterpreter: <StackInterpreterSimulatorLSB> - oldHeap: <Spur32BitMMLESimulator> - oldInterpreter: <StackInterpreterSimulatorLSB> - reverseMap: <Dictionary> - savedWindowSize: <Integer> - - imageHeaderFlags - - flags word in image header - - map - - map from oops in old image to oops in new image - - newHeap - - the preened heap - - newInterpreter - - the interpreter wrapping the preened heap - - oldHeap - - the heap to be preened - - oldInterpreter - - the interpreter wrapping the heap to be preened - - reverseMap - - map from oops in new image to oops in old image - - savedWindowSize - - screen size word in mage header - ! Item was removed: - ----- Method: Spur32BitPreen>>cloneFreeLists: (in category 'bootstrap image') ----- - cloneFreeLists: oldObj - | newObj | - newObj := newHeap - allocateSlots: newHeap numFreeLists - format: newHeap wordIndexableFormat - classIndex: newHeap wordSizeClassIndexPun. - reverseMap at: newObj put: oldObj. - ^map at: oldObj put: newObj! Item was removed: - ----- Method: Spur32BitPreen>>cloneObject: (in category 'bootstrap image') ----- - cloneObject: oldObj - | newObj hash | - newObj := newHeap - allocateSlots: (oldHeap numSlotsOf: oldObj) - format: (oldHeap formatOf: oldObj) - classIndex: (oldHeap classIndexOf: oldObj). - (hash := oldHeap rawHashBitsOf: oldObj) ~= 0 ifTrue: - [newHeap setHashBitsOf: newObj to: hash]. - (oldHeap isImmutable: oldObj) ifTrue: - [newHeap setIsImmutableOf: newObj to: true]. - (oldHeap isPinned: oldObj) ifTrue: - [newHeap setIsPinnedOf: newObj to: true]. - self deny: (oldHeap isRemembered: oldObj). - self deny: (oldHeap isMarked: oldObj). - self deny: (oldHeap isGrey: oldObj). - reverseMap at: newObj put: oldObj. - ^map at: oldObj put: newObj! Item was removed: - ----- Method: Spur32BitPreen>>cloneObjects (in category 'bootstrap image') ----- - cloneObjects - "Clone all normal objects. Of hidden objects only clone the freeLists object and - the classTableRoot and class table pages. In particular, dont clone objStacks. - The refs to the objStacks are nilled out in fillInHeap." - | i freeListsObject | - i := 0. - freeListsObject := oldHeap freeListsObject. - oldHeap allOldSpaceObjectsDo: - [:obj32| - (i := i + 1) >= 100000 ifTrue: - [Transcript nextPut: $:; flush. i := 0]. - obj32 = freeListsObject - ifTrue: - [self cloneFreeLists: obj32] - ifFalse: - [(self shouldClone: obj32) ifTrue: - [self cloneObject: obj32]]]! Item was removed: - ----- Method: Spur32BitPreen>>fillInBitsObject:from: (in category 'bootstrap image') ----- - fillInBitsObject: obj64 from: obj32 - 0 to: (oldHeap numBytesOf: obj32) - 1 do: - [:i| - newHeap - storeByte: i - ofObject: obj64 - withValue: (oldHeap fetchByte: i ofObject: obj32)]! Item was removed: - ----- Method: Spur32BitPreen>>fillInClassTable (in category 'bootstrap image') ----- - fillInClassTable - self fillInPointerObject: (map at: oldHeap classTableRootObj) from: oldHeap classTableRootObj! Item was removed: - ----- Method: Spur32BitPreen>>fillInCompiledMethod:from: (in category 'bootstrap image') ----- - fillInCompiledMethod: newObj from: oldObj - "oldInterpreter printOop: oldObj" - "newInterpreter printOop: newObj" - 0 to: (oldHeap numPointerSlotsOf: oldObj) - 1 do: - [:i| | oldOop newOop | - oldOop := oldHeap fetchPointer: i ofObject: oldObj. - newOop := self map32BitOop: oldOop. - newHeap - storePointerUnchecked: i - ofObject: newObj - withValue: newOop]. - (oldInterpreter startPCOfMethod: oldObj) - to: (oldHeap numBytesOf: oldObj) - 1 - do: [:j| - newHeap - storeByte: j - ofObject: newObj - withValue: (oldHeap fetchByte: j ofObject: oldObj)]! Item was removed: - ----- Method: Spur32BitPreen>>fillInHeap (in category 'bootstrap image') ----- - fillInHeap - | heapEnd freeListsObj | - heapEnd := newHeap freeStart. - newHeap - nilObject: (map at: oldHeap nilObject); - falseObject: (map at: oldHeap falseObject); - trueObject: (map at: oldHeap trueObject); - specialObjectsOop: (map at: oldHeap specialObjectsOop); - lastHash: oldHeap lastHash; - setHiddenRootsObj: (map at: oldHeap classTableRootObj). - newHeap segmentManager - initSegmentForInImageCompilationFrom: newHeap nilObject - to: heapEnd + newHeap bridgeSize. - freeListsObj := newHeap objectAfter: newHeap trueObject. - "Nil-out the free lists." - newHeap - fillObj: freeListsObj numSlots: (newHeap numSlotsOf: freeListsObj) with: 0; - initializeFreeSpacePostLoad: freeListsObj; - initializePostBootstrap; - setEndOfMemory: (newHeap segmentManager bridgeAt: 0) + newHeap baseHeaderSize! Item was removed: - ----- Method: Spur32BitPreen>>fillInObjects (in category 'bootstrap image') ----- - fillInObjects - "interpreter32 printOop: oldObj" - | i | - {oldHeap markStack. oldHeap weaklingStack. oldHeap mournQueue} do: - [:obj| - obj ~= oldHeap nilObject ifTrue: - [map at: obj put: (map at: oldHeap nilObject)]]. - i := 0. - oldHeap allObjectsDo: - [:oldObj| - (i := i + 1) >= 10000 ifTrue: - [Transcript nextPut: $.; flush. i := 0]. - (map at: oldObj ifAbsent: nil) - ifNotNil: - [:newObj| | format | - (newHeap numSlotsOf: newObj) > 0 ifTrue: "filter-out filtered objStack pages" - [format := oldHeap formatOf: oldObj. - (newHeap isPointersFormat: format) - ifTrue: - [self fillInPointerObject: newObj from: oldObj] - ifFalse: - [(newHeap isCompiledMethodFormat: format) - ifTrue: [self fillInCompiledMethod: newObj from: oldObj] - ifFalse: [self fillInBitsObject: newObj from: oldObj]]]] - ifNil: [self assert: (self isUnmappedObject: oldObj)]]! Item was removed: - ----- Method: Spur32BitPreen>>fillInPointerObject:from: (in category 'bootstrap image') ----- - fillInPointerObject: newObj from: oldObj - 0 to: (oldHeap numSlotsOf: oldObj) - 1 do: - [:i| - newHeap - storePointerUnchecked: i - ofObject: newObj - withValue: (self map32BitOop: (oldHeap fetchPointer: i ofObject: oldObj))]! Item was removed: - ----- Method: Spur32BitPreen>>incrementPCField:ofObject:for: (in category 'bootstrap image') ----- - incrementPCField: fieldIndex ofObject: obj64 for: method32 - | value nLits | - value := newHeap fetchPointer: fieldIndex ofObject: obj64. - (newHeap isIntegerObject: value) - ifTrue: - [nLits := oldHeap literalCountOf: method32. - newHeap - storePointerUnchecked: fieldIndex - ofObject: obj64 - withValue: (newHeap integerObjectOf: nLits + LiteralStart * 4 + (newHeap integerValueOf: value))] - ifFalse: - [self assert: (reverseMap at: value) = oldHeap nilObject]! Item was removed: - ----- Method: Spur32BitPreen>>initMaps (in category 'initialize-release') ----- - initMaps - map := Dictionary new: oldHeap memory size // 32. - reverseMap := Dictionary new: oldHeap memory size // 32! Item was removed: - ----- Method: Spur32BitPreen>>isUnmappedObject: (in category 'bootstrap image') ----- - isUnmappedObject: obj32 - "Answer if obj32 is an object that is not cloned by the bootstrap." - ^obj32 = oldHeap freeListsObject - or: [(oldHeap isValidObjStackPage: obj32)]! Item was removed: - ----- Method: Spur32BitPreen>>map32BitOop: (in category 'bootstrap image') ----- - map32BitOop: obj32 - "oldInterpreter printOop: obj32" - ^map - at: obj32 - ifAbsent: - [(oldHeap isImmediateCharacter: obj32) - ifTrue: [newHeap characterObjectOf: (oldHeap characterValueOf: obj32)] - ifFalse: [newHeap integerObjectOf: (oldHeap integerValueOf: obj32)]]! Item was removed: - ----- Method: Spur32BitPreen>>on: (in category 'public access') ----- - on: imageName - (oldInterpreter := StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur32BitMemoryManager)) - openOn: imageName extraMemory: 0. - oldHeap := oldInterpreter objectMemory. - imageHeaderFlags := oldInterpreter getImageHeaderFlags. - savedWindowSize ifNil: [savedWindowSize := oldInterpreter savedWindowSize]. - newInterpreter := StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur32BitMemoryManager). - newHeap := newInterpreter objectMemory. - newHeap - allocateMemoryOfSize: oldHeap oldSpaceSize - newSpaceSize: 8 * 1024 * 1024 - stackSize: 16 * 1024 - codeSize: 0. - newHeap bootstrapping: true. - self initMaps! Item was removed: - ----- Method: Spur32BitPreen>>preenImage (in category 'public access') ----- - preenImage - self cloneObjects. - self fillInObjects. - self fillInClassTable. - self fillInHeap. - self reportSizes! Item was removed: - ----- Method: Spur32BitPreen>>preenImage: (in category 'public access') ----- - preenImage: imageName - (Smalltalk classNamed: #FileReference) ifNotNil: - [^self preenImageUsingFileReference: imageName]. - (Smalltalk classNamed: #FileDirectory) ifNotNil: - [^self preenImageUsingFileDirectory: imageName]. - self error: 'at a loss as to what file system support to use'! Item was removed: - ----- Method: Spur32BitPreen>>preenImageUsingFileDirectory: (in category 'public access') ----- - preenImageUsingFileDirectory: imageName - | dirName baseName dir | - dirName := FileDirectory dirPathFor: imageName. - baseName := (imageName endsWith: '.image') - ifTrue: [FileDirectory baseNameFor: imageName] - ifFalse: [FileDirectory localNameFor: imageName]. - dir := dirName isEmpty ifTrue: [FileDirectory default] ifFalse: [FileDirectory default on: dirName]. - self on: (dir fullNameFor: baseName, '.image'). - [self preenImage] - on: Halt - do: [:ex| - "suppress halts from the usual suspects (development time halts)" - (#(fullGC compactImage) includes: ex signalerContext sender selector) - ifTrue: [ex resume] - ifFalse: [ex pass]]. - self writeSnapshot: (dir fullNameFor: baseName, '-preen.image') - headerFlags: imageHeaderFlags - screenSize: savedWindowSize. - (dir fileExists: baseName, '.changes') - ifTrue: - [dir deleteFileNamed: baseName, '-preen.changes'; - copyFileNamed: baseName, '.changes' toFileNamed: baseName, '-preen.changes'] - ifFalse: - [Transcript cr; show: 'could not find ', baseName, '.changes']! Item was removed: - ----- Method: Spur32BitPreen>>reportSizes (in category 'bootstrap image') ----- - reportSizes - | change oldHeapSize newHeapSize | - oldHeapSize := oldHeap oldSpaceSize. - newHeap segmentManager computeTotalHeapSizeIncludingBridges. "To avoid assert fail" - newHeapSize := newHeap oldSpaceSize. - change := newHeapSize - oldHeapSize / oldHeapSize. - Transcript - nextPutAll: 'done.'; cr; - nextPutAll: 'old heap size: '; nextPutAll: oldHeapSize asStringWithCommas; tab; - nextPutAll: 'initial new heap size: '; nextPutAll: newHeapSize asStringWithCommas; cr; - nextPutAll: 'change: '; print: change * 100.0 maxDecimalPlaces: 2; nextPut: $%; cr; - flush. - newHeapSize := newHeap endOfMemory - - newHeap scavenger eden limit - - newHeap totalFreeListBytes. - change := newHeapSize - oldHeapSize / oldHeapSize. - Transcript - nextPutAll: 'final new heap size: '; nextPutAll: newHeapSize asStringWithCommas; tab; - nextPutAll: 'change: '; print: change * 100.0 maxDecimalPlaces: 2; nextPut: $%; cr; - flush! Item was removed: - ----- Method: Spur32BitPreen>>savedWindowSize: (in category 'public access') ----- - savedWindowSize: aPointOrInteger - savedWindowSize := aPointOrInteger isInteger - ifTrue: [aPointOrInteger] - ifFalse: [(aPointOrInteger x min: 65535) << 16 + (aPointOrInteger y min: 65535)]! Item was removed: - ----- Method: Spur32BitPreen>>shouldClone: (in category 'bootstrap image') ----- - shouldClone: obj32 - ^(oldHeap isValidObjStackPage: obj32) not! Item was removed: - ----- Method: Spur32BitPreen>>writeDefaultHeader: (in category 'public access') ----- - writeDefaultHeader: aBoolean - writeDefaultHeader := aBoolean! Item was removed: - ----- Method: Spur32BitPreen>>writeSnapshot:headerFlags:screenSize: (in category 'snapshot') ----- - writeSnapshot: imageFileName headerFlags: headerFlags screenSize: screenSizeInteger - newHeap - checkFreeSpace; - runLeakCheckerForFullGC. - writeDefaultHeader == true ifTrue: - [newInterpreter - desiredEdenBytes: 0; - desiredNumStackPages: 0; - setDesiredCogCodeSize: 0; - setMaxExtSemSizeTo: 0]. - newInterpreter - setImageHeaderFlagsFrom: headerFlags; - setDisplayForm: nil; - setSavedWindowSize: savedWindowSize; - imageName: imageFileName; - writeImageFileIO. - Transcript cr; show: 'Done!!'! Item was added: + SimulatorHarness subclass: #SpurImagePreener + instanceVariableNames: 'oldHeap newHeap map reverseMap oldInterpreter newInterpreter imageHeaderFlags savedWindowSize writeDefaultHeader wordSize' + classVariableNames: '' + poolDictionaries: 'VMObjectIndices' + category: 'Cog-Bootstrapping'! + + !SpurImagePreener commentStamp: 'eem 10/12/2021 16:58' prior: 0! + A SpurImagePreener is a simple image rewriter for Spur images that eliminates free space and hence shrinks the preened image. Use via e.g. + SpurImagePreener new preenImage: 'spur' + which will produce spur-preen.image and spur-preen.changes from spur.image and spur.changes, etc. + + Instance Variables + imageHeaderFlags: <Integer> + map: <Dictionary> + newHeap: <Spur[32|64]BitMMLESimulator> + newInterpreter: <StackInterpreterSimulatorLSB> + oldHeap: <Spur[32|64]BitMMLESimulator> + oldInterpreter: <StackInterpreterSimulatorLSB> + reverseMap: <Dictionary> + savedWindowSize: <Integer> + + imageHeaderFlags + - flags word in image header + + map + - map from oops in old image to oops in new image + + newHeap + - the preened heap + + newInterpreter + - the interpreter wrapping the preened heap + + oldHeap + - the heap to be preened + + oldInterpreter + - the interpreter wrapping the heap to be preened + + reverseMap + - map from oops in new image to oops in old image + + savedWindowSize + - screen size word in mage header + ! Item was added: + ----- Method: SpurImagePreener>>cloneFreeLists: (in category 'bootstrap image') ----- + cloneFreeLists: oldObj + | newObj | + newObj := newHeap + allocateSlots: newHeap numFreeLists + format: newHeap wordIndexableFormat + classIndex: newHeap wordSizeClassIndexPun. + reverseMap at: newObj put: oldObj. + ^map at: oldObj put: newObj! Item was added: + ----- Method: SpurImagePreener>>cloneObject: (in category 'bootstrap image') ----- + cloneObject: oldObj + | newObj hash | + newObj := newHeap + allocateSlots: (oldHeap numSlotsOf: oldObj) + format: (oldHeap formatOf: oldObj) + classIndex: (oldHeap classIndexOf: oldObj). + (hash := oldHeap rawHashBitsOf: oldObj) ~= 0 ifTrue: + [newHeap setHashBitsOf: newObj to: hash]. + (oldHeap isImmutable: oldObj) ifTrue: + [newHeap setIsImmutableOf: newObj to: true]. + (oldHeap isPinned: oldObj) ifTrue: + [newHeap setIsPinnedOf: newObj to: true]. + self deny: (oldHeap isRemembered: oldObj). + self deny: (oldHeap isMarked: oldObj). + self deny: (oldHeap isGrey: oldObj). + reverseMap at: newObj put: oldObj. + ^map at: oldObj put: newObj! Item was added: + ----- Method: SpurImagePreener>>cloneObjects (in category 'bootstrap image') ----- + cloneObjects + "Clone all normal objects. Of hidden objects only clone the freeLists object and + the classTableRoot and class table pages. In particular, dont clone objStacks. + The refs to the objStacks are nilled out in fillInHeap." + | i freeListsObject | + i := 0. + freeListsObject := oldHeap freeListsObject. + oldHeap allOldSpaceObjectsDo: + [:obj| + (i := i + 1) >= 100000 ifTrue: + [Transcript nextPut: $:; flush. i := 0]. + obj = freeListsObject + ifTrue: + [self cloneFreeLists: obj] + ifFalse: + [(self shouldClone: obj) ifTrue: + [self cloneObject: obj]]]! Item was added: + ----- Method: SpurImagePreener>>determineWordSizeFrom: (in category 'initialize-release') ----- + determineWordSizeFrom: fileName + ^(ImageFormat fromFile: fileName) wordSize! Item was added: + ----- Method: SpurImagePreener>>fillInBitsObject:from: (in category 'bootstrap image') ----- + fillInBitsObject: newObj from: oldObj + 0 to: (oldHeap numSlotsOf: oldObj) - 1 do: + [:i| + newHeap + storePointerUnchecked: i + ofObject: newObj + withValue: (oldHeap fetchPointer: i ofObject: oldObj)]! Item was added: + ----- Method: SpurImagePreener>>fillInClassTable (in category 'bootstrap image') ----- + fillInClassTable + self fillInPointerObject: (map at: oldHeap classTableRootObj) from: oldHeap classTableRootObj! Item was added: + ----- Method: SpurImagePreener>>fillInCompiledMethod:from: (in category 'bootstrap image') ----- + fillInCompiledMethod: newObj from: oldObj + "oldInterpreter printOop: oldObj" + "newInterpreter printOop: newObj" + 0 to: (oldHeap numPointerSlotsOf: oldObj) - 1 do: + [:i| | oldOop newOop | + oldOop := oldHeap fetchPointer: i ofObject: oldObj. + newOop := self mapOop: oldOop. + newHeap + storePointerUnchecked: i + ofObject: newObj + withValue: newOop]. + (oldInterpreter startPCOfMethod: oldObj) + to: (oldHeap numBytesOf: oldObj) - 1 + do: [:j| + newHeap + storeByte: j + ofObject: newObj + withValue: (oldHeap fetchByte: j ofObject: oldObj)]! Item was added: + ----- Method: SpurImagePreener>>fillInHeap (in category 'bootstrap image') ----- + fillInHeap + | heapEnd freeListsObj | + heapEnd := newHeap freeStart. + newHeap + nilObject: (map at: oldHeap nilObject); + falseObject: (map at: oldHeap falseObject); + trueObject: (map at: oldHeap trueObject); + specialObjectsOop: (map at: oldHeap specialObjectsOop); + lastHash: oldHeap lastHash; + setHiddenRootsObj: (map at: oldHeap classTableRootObj). + newHeap segmentManager + initSegmentForInImageCompilationFrom: newHeap nilObject + to: heapEnd + newHeap bridgeSize. + freeListsObj := newHeap objectAfter: newHeap trueObject. + "Nil-out the free lists." + newHeap + fillObj: freeListsObj numSlots: (newHeap numSlotsOf: freeListsObj) with: 0; + initializeFreeSpacePostLoad: freeListsObj; + initializePostBootstrap; + setEndOfMemory: (newHeap segmentManager bridgeAt: 0) + newHeap baseHeaderSize! Item was added: + ----- Method: SpurImagePreener>>fillInObjects (in category 'bootstrap image') ----- + fillInObjects + "oldInterpreter printOop: oldObj" + | i | + {oldHeap markStack. oldHeap weaklingStack. oldHeap mournQueue} do: + [:obj| + obj ~= oldHeap nilObject ifTrue: + [map at: obj put: (map at: oldHeap nilObject)]]. + i := 0. + oldHeap allObjectsDo: + [:oldObj| + (i := i + 1) >= 10000 ifTrue: + [Transcript nextPut: $.; flush. i := 0]. + (map at: oldObj ifAbsent: nil) + ifNotNil: + [:newObj| | format | + (newHeap numSlotsOf: newObj) > 0 ifTrue: "filter-out filtered objStack pages" + [format := oldHeap formatOf: oldObj. + (newHeap isPointersFormat: format) + ifTrue: + [self fillInPointerObject: newObj from: oldObj] + ifFalse: + [(newHeap isCompiledMethodFormat: format) + ifTrue: [self fillInCompiledMethod: newObj from: oldObj] + ifFalse: [self fillInBitsObject: newObj from: oldObj]]]] + ifNil: [self assert: (self isUnmappedObject: oldObj)]]! Item was added: + ----- Method: SpurImagePreener>>fillInPointerObject:from: (in category 'bootstrap image') ----- + fillInPointerObject: newObj from: oldObj + 0 to: (oldHeap numSlotsOf: oldObj) - 1 do: + [:i| + newHeap + storePointerUnchecked: i + ofObject: newObj + withValue: (self mapOop: (oldHeap fetchPointer: i ofObject: oldObj))]! Item was added: + ----- Method: SpurImagePreener>>initMaps (in category 'initialize-release') ----- + initMaps + map := Dictionary new: oldHeap memory size // 32. + reverseMap := Dictionary new: oldHeap memory size // 32! Item was added: + ----- Method: SpurImagePreener>>isUnmappedObject: (in category 'bootstrap image') ----- + isUnmappedObject: obj + "Answer if obj is an object that is not cloned by the bootstrap." + ^obj = oldHeap freeListsObject + or: [(oldHeap isValidObjStackPage: obj)]! Item was added: + ----- Method: SpurImagePreener>>mapOop: (in category 'bootstrap image') ----- + mapOop: obj + "oldInterpreter printOop: obj" + ^map + at: obj + ifAbsent: + [(oldHeap isImmediate: obj) + ifTrue: [obj] + ifFalse: [self error: 'cannot map']]! Item was added: + ----- Method: SpurImagePreener>>newInterpreter (in category 'initialize-release') ----- + newInterpreter + ^StackInterpreterSimulator newWithOptions: (wordSize = 4 + ifTrue: [#(ObjectMemory Spur32BitMemoryManager)] + ifFalse: [#(ObjectMemory Spur64BitMemoryManager)])! Item was added: + ----- Method: SpurImagePreener>>newSpaceSize (in category 'initialize-release') ----- + newSpaceSize + ^16 * 1024 * 1024! Item was added: + ----- Method: SpurImagePreener>>on: (in category 'public access') ----- + on: imageName + wordSize ifNil: [wordSize := self determineWordSizeFrom: imageName]. + (oldInterpreter := self newInterpreter) openOn: imageName extraMemory: 0. + oldHeap := oldInterpreter objectMemory. + imageHeaderFlags := oldInterpreter getImageHeaderFlags. + savedWindowSize ifNil: [savedWindowSize := oldInterpreter savedWindowSize]. + newInterpreter := self newInterpreter. + newHeap := newInterpreter objectMemory. + newHeap + allocateMemoryOfSize: oldHeap oldSpaceSize + newSpaceSize: self newSpaceSize + stackSize: 16 * 1024 + codeSize: 0. + newHeap bootstrapping: true. + self initMaps! Item was added: + ----- Method: SpurImagePreener>>preenImage (in category 'public access') ----- + preenImage + self cloneObjects. + self fillInObjects. + self fillInClassTable. + self fillInHeap. + self reportSizes! Item was added: + ----- Method: SpurImagePreener>>preenImage: (in category 'public access') ----- + preenImage: imageName + (Smalltalk classNamed: #FileReference) ifNotNil: + [^self preenImageUsingFileReference: imageName]. + (Smalltalk classNamed: #FileDirectory) ifNotNil: + [^self preenImageUsingFileDirectory: imageName]. + self error: 'at a loss as to what file system support to use'! Item was added: + ----- Method: SpurImagePreener>>preenImageUsingFileDirectory: (in category 'public access') ----- + preenImageUsingFileDirectory: imageName + | dirName baseName dir | + dirName := FileDirectory dirPathFor: imageName. + baseName := (imageName endsWith: '.image') + ifTrue: [FileDirectory baseNameFor: imageName] + ifFalse: [FileDirectory localNameFor: imageName]. + dir := dirName isEmpty ifTrue: [FileDirectory default] ifFalse: [FileDirectory default on: dirName]. + self on: (dir fullNameFor: baseName, '.image'). + [self preenImage] + on: Halt + do: [:ex| + "suppress halts from the usual suspects (development time halts)" + (#(fullGC compactImage) includes: ex signalerContext sender selector) + ifTrue: [ex resume] + ifFalse: [ex pass]]. + self writeSnapshot: (dir fullNameFor: baseName, '-preen.image') + headerFlags: imageHeaderFlags + screenSize: savedWindowSize. + (dir fileExists: baseName, '.changes') + ifTrue: + [dir deleteFileNamed: baseName, '-preen.changes'; + copyFileNamed: baseName, '.changes' toFileNamed: baseName, '-preen.changes'] + ifFalse: + [Transcript cr; show: 'could not find ', baseName, '.changes']! Item was added: + ----- Method: SpurImagePreener>>reportSizes (in category 'bootstrap image') ----- + reportSizes + | change oldHeapSize newHeapSize | + oldHeapSize := oldHeap oldSpaceSize. + newHeap segmentManager computeTotalHeapSizeIncludingBridges. "To avoid assert fail" + newHeapSize := newHeap oldSpaceSize. + change := newHeapSize - oldHeapSize / oldHeapSize. + Transcript + nextPutAll: 'done.'; cr; + nextPutAll: 'old heap size: '; nextPutAll: oldHeapSize asStringWithCommas; tab; + nextPutAll: 'initial new heap size: '; nextPutAll: newHeapSize asStringWithCommas; cr; + nextPutAll: 'change: '; print: change * 100.0 maxDecimalPlaces: 2; nextPut: $%; cr; + flush. + newHeapSize := newHeap endOfMemory + - newHeap scavenger eden limit + - newHeap totalFreeListBytes. + change := newHeapSize - oldHeapSize / oldHeapSize. + Transcript + nextPutAll: 'final new heap size: '; nextPutAll: newHeapSize asStringWithCommas; tab; + nextPutAll: 'change: '; print: change * 100.0 maxDecimalPlaces: 2; nextPut: $%; cr; + flush! Item was added: + ----- Method: SpurImagePreener>>savedWindowSize: (in category 'public access') ----- + savedWindowSize: aPointOrInteger + savedWindowSize := aPointOrInteger isInteger + ifTrue: [aPointOrInteger] + ifFalse: [(aPointOrInteger x min: 65535) << 16 + (aPointOrInteger y min: 65535)]! Item was added: + ----- Method: SpurImagePreener>>shouldClone: (in category 'bootstrap image') ----- + shouldClone: obj + ^(oldHeap isValidObjStackPage: obj) not! Item was added: + ----- Method: SpurImagePreener>>writeDefaultHeader: (in category 'public access') ----- + writeDefaultHeader: aBoolean + writeDefaultHeader := aBoolean! Item was added: + ----- Method: SpurImagePreener>>writeSnapshot:headerFlags:screenSize: (in category 'snapshot') ----- + writeSnapshot: imageFileName headerFlags: headerFlags screenSize: screenSizeInteger + newHeap + checkFreeSpace; + runLeakCheckerForFullGC. + writeDefaultHeader == true ifTrue: + [newInterpreter + desiredEdenBytes: 0; + desiredNumStackPages: 0; + setDesiredCogCodeSize: 0; + setMaxExtSemSizeTo: 0]. + newInterpreter + setImageHeaderFlagsFrom: headerFlags; + setDisplayForm: nil; + setSavedWindowSize: savedWindowSize; + imageName: imageFileName; + writeImageFileIO. + Transcript cr; show: 'Done!!'!

1 0

[OpenSmalltalk/opensmalltalk-vm] nscogspur64linuxht Segmentation fault (#600)
by Stefan Hertenberger 12 Oct '21

12 Oct '21

When i try to open a repository in the newspeak ide, i get an segmentation fault. > Segmentation fault Tue Oct 12 22:32:24 2021 > > > /home/stefan/Devel/newspeak/nsvm/nscogspur64linuxht/lib/nsvm/5.0-202110090030-64bit/nsvm > Newspeak VM version: 5.0-202110090030 Tue Oct 12 20:32:51 CEST 2021 gcc 11.1.0 [Production Spur 64-bit VM] > Built from: CoInterpreter VMMaker.oscog-mt.3083 uuid: 0d345f2b-f29d-7148-b84c-cb4ed3775bb1 Oct 12 2021 > With: StackToRegisterMappingCogit VMMaker.oscog-mt.3083 uuid: 0d345f2b-f29d-7148-b84c-cb4ed3775bb1 Oct 12 2021 > Revision: VM: 202110090030 stefan@:Devel/smalltalk/opensmalltalk-vm > Date: Fri Oct 8 17:30:23 2021 CommitHash: 43ff6e5 > Plugins: 202110090030 stefan@:Devel/smalltalk/opensmalltalk-vm > Build host: Linux lenovo 5.14.9-arch2-1 #1 SMP PREEMPT Fri, 01 Oct 2021 19:03:20 +0000 x86_64 GNU/Linux > plugin path: ../nsvm/nscogspur64linuxht/bin/../lib/nsvm/5.0-202110090030-64bit [default: /home/stefan/Devel/newspeak/nsvm/nscogspur64linuxht/lib/nsvm/5.0-202110090030-64bit/] > > > C stack backtrace & registers: > rax 0x558f5c1898e0 rbx 0x558f5975ec68 rcx 0x7f42ce69693f rdx 0x1 > rdi 0x7f42ce76a4d0 rsi 0x7f42cc792170 rbp 0x558f5c1898e0 rsp 0x7ffc4d950d90 > r8 0xa r9 0x7ffc4d950bc7 r10 0x1 r11 0x293 > r12 0x558f5ea0f6d0 r13 0x558f596f9cba r14 0x200000401 r15 0x7ffc4d98a9d0 > rip 0x558f59660a64 > *../nsvm/nscogspur64linuxht/bin/../lib/nsvm/5.0-202110090030-64bit/nsvm(+0x88a64)[0x558f59660a64] > ../nsvm/nscogspur64linuxht/bin/../lib/nsvm/5.0-202110090030-64bit/nsvm(+0x2f085)[0x558f59607085] > ../nsvm/nscogspur64linuxht/bin/../lib/nsvm/5.0-202110090030-64bit/nsvm(+0x2f422)[0x558f59607422] > /lib/libpthread.so.0(+0x13870)[0x7f42ce8d1870] > ../nsvm/nscogspur64linuxht/bin/../lib/nsvm/5.0-202110090030-64bit/nsvm(+0x88a64)[0x558f59660a64] > ../nsvm/nscogspur64linuxht/bin/../lib/nsvm/5.0-202110090030-64bit/nsvm(ceSelfSendreceiver+0x1d1)[0x558f59661401] > [0x558f5b6b01cc] > /lib/libc.so.6(+0x1c2000)[0x7f42ce769000] > > > Smalltalk stack dump: > 0x7ffc4d98a988 M INVALID RECEIVER>ClassMirror 0x558f5b91b9f8 is in new space > 0x7ffc4d98a9b8 M ClassMirror`3120419>superclass 0x558f5bd1b568: a(n) ClassMirror`3120419 > 0x7ffc4d98aa08 I ClassMirror`3120419>allSuperclasses 0x558f5bd1b568: a(n) ClassMirror`3120419 > 0x7ffc4d98aa40 M ClassMirror`3120419>computeMirrorGroup: 0x558f5bd1b568: a(n) ClassMirror`3120419 > 0x7ffc4d98aa80 M ClassMirror`3120419>slots 0x558f5bd1b568: a(n) ClassMirror`3120419 > 0x7ffc4d98aac8 M SourceMirrorParser`4082533(ExecutableGrammar`2612245)>setupForwardReferences 0x558f5bd1af98: a(n) SourceMirrorParser`4082533 > 0x7ffc4d98ab08 I SourceMirrorParser`4082533(ExecutableGrammar`2612245)>initializer`new 0x558f5bd1af98: a(n) SourceMirrorParser`4082533 > 0x7ffc4d98ab60 I SourceMirrorParser`4082533(NS3Grammar`1028181)>initializer`new 0x558f5bd1af98: a(n) SourceMirrorParser`4082533 > 0x7ffc4d98aba0 I SourceMirrorParser`4082533(TypedNS3Grammar`1028181)>initializer`new 0x558f5bd1af98: a(n) SourceMirrorParser`4082533 > 0x7ffc4d98abe0 I SourceMirrorParser`4082533>initializer`new 0x558f5bd1af98: a(n) SourceMirrorParser`4082533 > 0x7ffc4d98ac28 I SourceMirrorParser`4082533 class>new 0x558f5bd11c48: a(n) SourceMirrorParser`4082533 > 0x7ffc4d98ac68 I MirrorCache`4082533>initializer`onSelector: 0x558f5ba130b0: a(n) MirrorCache`4082533 > 0x7ffc4d98acb8 I MirrorCache`4082533 class>onSelector: 0x558f5ba0ece0: a(n) MirrorCache`4082533 > 0x7ffc4d98acf0 M [] in VCSNewspeakSourceMirrors>initializer`usingPlatform:vcs:ide: 0x558f5ff38c20: a(n) VCSNewspeakSourceMirrors > 0x7ffc4d98ad20 M Future`2952908>resolve 0x558f5ff59fe0: a(n) Future`2952908 > 0x7ffc4d98ad58 M Future`2952908>doesNotUnderstand: mirrorForStream: 0x558f5ff59fe0: a(n) Future`2952908 > 0x7ffc4d98ada0 I VCSNewspeakSourceMirrors>mirrorForStream: 0x558f5ff38c20: a(n) VCSNewspeakSourceMirrors > 0x7ffc4d98add8 M Message>sendTo: 0x558f5ba111d8: a(n) Message > 0x7ffc4d982940 M Future`2952908>doesNotUnderstand: mirrorForStream: 0x558f5ff59dc8: a(n) Future`2952908 > 0x7ffc4d982978 M MirrorLoader`512995>mirrorForStream:name: 0x558f5ba0f658: a(n) MirrorLoader`512995 > 0x7ffc4d9829b8 M Message>sendTo: 0x558f5ba11238: a(n) Message > 0x7ffc4d9829f0 M Future`2952908>doesNotUnderstand: mirrorForStream:name: 0x558f5ff59e10: a(n) Future`2952908 > 0x7ffc4d982a28 M VCSSourceMirrors>mirrorForStream:name: 0x558f5ff38a80: a(n) VCSSourceMirrors > 0x7ffc4d982a68 M Message>sendTo: 0x558f5ba11258: a(n) Message > 0x7ffc4d982aa0 M Future`2952908>doesNotUnderstand: mirrorForStream:name: 0x558f5ff421b8: a(n) Future`2952908 > 0x7ffc4d982af0 M [] in RepositoryVersion`273299>mirrors 0x558f5ba11298: a(n) RepositoryVersion`273299 > 0x7ffc4d982b30 M OrderedCollection>do: 0x558f5ba112f8: a(n) OrderedCollection > 0x7ffc4d982b98 I RepositoryVersion`273299>mirrors 0x558f5ba11298: a(n) RepositoryVersion`273299 > 0x7ffc4d982be8 I ImageBasedChangeSubject`135144969>buildVersion 0x558f5ba113f0: a(n) ImageBasedChangeSubject`135144969 > 0x7ffc4d982c28 I ImageBasedChangeSubject`135144969>version 0x558f5ba113f0: a(n) ImageBasedChangeSubject`135144969 > 0x7ffc4d982c70 I ImageBasedChangeSubject`135144969>hasChanges 0x558f5ba113f0: a(n) ImageBasedChangeSubject`135144969 > 0x7ffc4d982cb0 I ImageBasedChangePresenter`1096835>definitionHolderContents 0x558f5ba0fb30: a(n) ImageBasedChangePresenter`1096835 > 0x7ffc4d982ce0 M [] in ImageBasedChangePresenter`1096835>definition 0x558f5ba0fb30: a(n) ImageBasedChangePresenter`1096835 > 0x7ffc4d982d10 M [] in HolderComposer`1721269>content 0x558f5ba11440: a(n) HolderComposer`1721269 > 0x7ffc4d982d40 M UndefinedObject>ifNil: 0x558f5c1898e0: a(n) UndefinedObject > 0x7ffc4d982d78 M HolderComposer`1721269>content 0x558f5ba11440: a(n) HolderComposer`1721269 > 0x7ffc4d982db0 M HolderComposer`1721269>createVisual 0x558f5ba11440: a(n) HolderComposer`1721269 > 0x7ffc4d982de0 M HolderComposer`1721269(Fragment`3861765)>visual 0x558f5ba11440: a(n) HolderComposer`1721269 > 0x7ffc4d954958 I ImageBasedChangePresenter`1096835(Presenter`3861765)>createVisual 0x558f5ba0fb30: a(n) ImageBasedChangePresenter`1096835 > 0x7ffc4d954988 M ImageBasedChangePresenter`1096835(Fragment`3861765)>visual 0x558f5ba0fb30: a(n) ImageBasedChangePresenter`1096835 > 0x7ffc4d9549b8 M [] in ColumnComposer`1721269(SequenceComposer`1721269)>createVisual 0x558f5ba0fc30: a(n) ColumnComposer`1721269 > 0x7ffc4d954a08 M OrderedCollection>collect: 0x558f5ba0fca0: a(n) OrderedCollection > 0x7ffc4d954a50 M ColumnComposer`1721269(SequenceComposer`1721269)>createVisual 0x558f5ba0fc30: a(n) ColumnComposer`1721269 > 0x7ffc4d954a80 M ColumnComposer`1721269(Fragment`3861765)>visual 0x558f5ba0fc30: a(n) ColumnComposer`1721269 > 0x7ffc4d954ab8 M HolderComposer`1721269>createVisual 0x558f5ba0fdf0: a(n) HolderComposer`1721269 > 0x7ffc4d954ae8 M HolderComposer`1721269(Fragment`3861765)>visual 0x558f5ba0fdf0: a(n) HolderComposer`1721269 > 0x7ffc4d954b18 M [] in ColumnComposer`1721269(SequenceComposer`1721269)>createVisual 0x558f5ba0fe20: a(n) ColumnComposer`1721269 > 0x7ffc4d954b68 M OrderedCollection>collect: 0x558f5ba0fe90: a(n) OrderedCollection > 0x7ffc4d954bc0 I ColumnComposer`1721269(SequenceComposer`1721269)>createVisual 0x558f5ba0fe20: a(n) ColumnComposer`1721269 > 0x7ffc4d954c00 I ColumnComposer`1721269(Fragment`3861765)>visual 0x558f5ba0fe20: a(n) ColumnComposer`1721269 > 0x7ffc4d954c48 I HolderComposer`1721269>content: 0x558f5ba10050: a(n) HolderComposer`1721269 > 0x7ffc4d954c80 M [] in LocalRepositoryPresenter`1096835>refreshSCAfter: 0x558f5ba0c540: a(n) LocalRepositoryPresenter`1096835 > 0x7ffc4d954cd0 M WorldState>runStepMethodsIn: 0x558f5c75fe70: a(n) WorldState > 0x7ffc4d954d08 M PasteUpMorph>runStepMethods 0x558f5c589538: a(n) PasteUpMorph > 0x7ffc4d954d40 M WorldState>doOneCycleNowFor: 0x558f5c75fe70: a(n) WorldState > 0x7ffc4d954d78 M WorldState>doOneCycleFor: 0x558f5c75fe70: a(n) WorldState > 0x7ffc4d954db0 M PasteUpMorph>doOneCycle 0x558f5c589538: a(n) PasteUpMorph > 0x7ffc4d954de0 M [] in MorphicProject>spawnNewProcess 0x558f5c922ab8: a(n) MorphicProject > 0x558f5e18e350 s [] in BlockClosure>newProcess > > Most recent primitives > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > shallowCopy > at:put: > at:put: > at:put: > perform:withArguments: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > shallowCopy > at:put: > at:put: > at:put: > at:put: > perform:withArguments: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > at:put: > at:put: > at:put: > at:put: > flushCache > flushCache > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > shallowCopy > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > shallowCopy > at:put: > at:put: > at:put: > perform:withArguments: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > shallowCopy > at:put: > at:put: > at:put: > at:put: > perform:withArguments: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > at:put: > at:put: > at:put: > at:put: > flushCache > flushCache > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > shallowCopy > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > shallowCopy > at:put: > at:put: > at:put: > perform:withArguments: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > shallowCopy > at:put: > at:put: > at:put: > at:put: > perform:withArguments: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > at:put: > at:put: > at:put: > at:put: > flushCache > flushCache > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > shallowCopy > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > shallowCopy > at:put: > at:put: > at:put: > perform:withArguments: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > shallowCopy > at:put: > at:put: > at:put: > at:put: > perform:withArguments: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > at:put: > at:put: > at:put: > at:put: > flushCache > flushCache > behaviorHashOf: > is:identicalTo: > is:identicalTo: > is:identicalTo: > is:identicalTo: > is:identicalTo: > is:identicalTo: > is:identicalTo: > instantiateFixedClass: > behaviorHashOf: > is:identicalTo: > new: > behaviorHashOf: > is:identicalTo: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > shallowCopy > new: > + > + > + > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > at:put: > at:put: > at:put: > perform:withArguments: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > shallowCopy > at:put: > at:put: > at:put: > at:put: > perform:withArguments: > perform:withArguments: > perform:withArguments: > newMethod:header: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > replaceFrom:to:with:startingAt: > at:put: > at:put: > at:put: > at:put: > flushCache > flushCache > flushCache > behaviorHashOf: > is:identicalTo: > classOf: > > > (Segmentation fault) > -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/600

1 0

VM Maker: CogThreads-eem.1.mcz
by commits＠source.squeak.org 11 Oct '21

11 Oct '21

Eliot Miranda uploaded a new version of CogThreads to project VM Maker: http://source.squeak.org/VMMaker/CogThreads-eem.1.mcz ==================== Summary ==================== Name: CogThreads-eem.1 Author: eem Time: 10 October 2021, 6:51:42.200606 pm UUID: 35d06e65-6487-49c1-a014-76ef81b3ca07 Ancestors: Define the basic threading facilities for the threaded FFI. Provide the esserntial convenience Process>>doNotRunOnGUIThread. ==================== Snapshot ==================== ----- Method: Process>>doNotRunOnGUIThread (in category '*CogThreads-thread binding') ----- doNotRunOnGUIThread "Arrange that the receiver will not run on the GUI thread. This is useful in ensuring that the VM can stll receive events while using threaded call-outs." self setThreadBinding: Processor guiThreadId negated! ----- Method: Process>>getThreadBinding (in category '*CogThreads-primitives') ----- getThreadBinding "Answer nil or a non-zero integer that indicates the binding of the receiver to a particular thread. If the result is nil, the receiver is not bound to any particular thread and free to run on any thread. If the result is strictly positive, the receiver is bound to the thread with the result's numeric id, and the receiver will only run on that thread. If the result is negative then the receiver will run on any thread other than the thread with the result's numeric id. Hence, if the result is an integer, when the receiver becomes active a thread switch may occur, and will occur if necessary to meet these two constraints." <primitive: 228 error: ec> self primitiveFailed! ----- Method: Process>>setThreadBinding: (in category '*CogThreads-primitives') ----- setThreadBinding: anIntegerOrNil "Set the binding of the receiver to a particular thread. If anIntegerOrNil is nil, then make the receiverfree to run on any thread. If anIntegerOrNil is strictly positive, then bind the receiver to the thread with id anIntegerOrNil, and arrange that the receiver will only run on that thread. If anIntegerOrNil is negative then arrange that the receiver will run on any thread other than the thread with id anIntegerOrNil. Hence, if the result is an integer, when the receiver becomes active a thread switch may occur, and will occur if necessary to meet these two constraints." <primitive: 229 error: ec> self primitiveFailed! ----- Method: ProcessorScheduler>>currentThreadId (in category '*CogThreads-primitives') ----- currentThreadId <primitive: 227 error: ec> self primitiveFailed! ----- Method: ProcessorScheduler>>guiThreadId (in category '*CogThreads-primitives') ----- guiThreadId "In the VM there may be a designated thread upon which to receive events. The VM guarantees that if such a thread exists it will have numeric id 1." ^1!

1 0

[OpenSmalltalk/opensmalltalk-vm] 43ff6e: Generate $(BUILD)/subdir/object.o style dependenci...
by Eliot Miranda 09 Oct '21

09 Oct '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 43ff6e5d8ed3a9027714af44ea857335db430ea2 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/43ff6e5d8ed3a90277… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M building/macos32x86/common/Makefile.rules M building/macos64ARMv8/common/Makefile.rules M building/macos64x64/common/Makefile.rules M building/win32x86/common/Makefile.rules Log Message: ----------- Generate $(BUILD)/subdir/object.o style dependencies on Mac * win32, as opposed to $(OBJDIR)/object.o for plugin objects.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev October 2021