Please send me the valid source to findSubstringViaPrimitive:in:startingAt:matchTable: asap so I can fix the builds. The currently generated MiscPrimitivePlugin is invalid.
_,,,^..^,,,_ best, Eliot
On Fri, Sep 30, 2016 at 9:22 PM, Eliot Miranda eliot.miranda@gmail.com wrote:
Please send me the valid source to findSubstringViaPrimitive:in:startingAt:matchTable: asap so I can fix the builds. The currently generated MiscPrimitivePlugin is invalid.
A bit more context, maybe?
I don't see this method in any Squeak image.
- Bert -
On Sat, 1 Oct 2016, Bert Freudenberg wrote:
That name is a pharoism. In Squeak it's still findSubstring:in:startingAt:matchTable:. Perhaps the recent merge has overwritten it.
Levente
On Sat, Oct 01, 2016 at 05:14:14PM +0200, Levente Uzonyi wrote:
On Sat, 1 Oct 2016, Bert Freudenberg wrote:
That name is a pharoism. In Squeak it's still findSubstring:in:startingAt:matchTable:. Perhaps the recent merge has overwritten it.
Levente
This naming inconsistency is a long standing annoyance that should be fixed. As of Feb 2011, I thought that we had reached agreement to do the necessary cleanup in the Pharo image:
http://lists.squeakfoundation.org/pipermail/vm-dev/2011-February/006781.html
Maybe that was just wishful thinking on my part. I can no longer find the original email exchange, but I think it was on the pharo list.
Maybe someone could open an issue on the Pharo bug tracker to make this problem go away?
The original problem was addressed by Nicolas and Andreas:
http://bugs.squeak.org/view.php?id=6366
Meanwhile a workaround was introduced in Pharo, resulting in the renamed method.
But once fixed in the VM, the Pharo workaround was no longer required, and should have been removed so that the Squeak and Pharo images would not require different VMMaker versions:
http://bugs.squeak.org/view.php?id=7479
Dave
On 1 Oct 2016, at 22:17, David T. Lewis lewis@mail.msen.com wrote:
On Sat, Oct 01, 2016 at 05:14:14PM +0200, Levente Uzonyi wrote:
On Sat, 1 Oct 2016, Bert Freudenberg wrote:
That name is a pharoism. In Squeak it's still findSubstring:in:startingAt:matchTable:. Perhaps the recent merge has overwritten it.
Levente
This naming inconsistency is a long standing annoyance that should be fixed. As of Feb 2011, I thought that we had reached agreement to do the necessary cleanup in the Pharo image:
http://lists.squeakfoundation.org/pipermail/vm-dev/2011-February/006781.html
Maybe that was just wishful thinking on my part. I can no longer find the original email exchange, but I think it was on the pharo list.
Maybe someone could open an issue on the Pharo bug tracker to make this problem go away?
The original problem was addressed by Nicolas and Andreas:
http://bugs.squeak.org/view.php?id=6366
Meanwhile a workaround was introduced in Pharo, resulting in the renamed method.
But once fixed in the VM, the Pharo workaround was no longer required, and should have been removed so that the Squeak and Pharo images would not require different VMMaker versions:
http://bugs.squeak.org/view.php?id=7479 http://bugs.squeak.org/view.php?id=7479
well.. this kind of things is the reason why there should not be a fork anymore :) I just didn’t remember that change and then I didn’t work on merge it :P
I will address this tomorrow.
Esteban
Dave
On Sun, Oct 02, 2016 at 11:00:43AM +0200, Esteban Lorenzano wrote:
On 1 Oct 2016, at 22:17, David T. Lewis lewis@mail.msen.com wrote:
On Sat, Oct 01, 2016 at 05:14:14PM +0200, Levente Uzonyi wrote:
On Sat, 1 Oct 2016, Bert Freudenberg wrote:
That name is a pharoism. In Squeak it's still findSubstring:in:startingAt:matchTable:. Perhaps the recent merge has overwritten it.
Levente
This naming inconsistency is a long standing annoyance that should be fixed. As of Feb 2011, I thought that we had reached agreement to do the necessary cleanup in the Pharo image:
http://lists.squeakfoundation.org/pipermail/vm-dev/2011-February/006781.html
Maybe that was just wishful thinking on my part. I can no longer find the original email exchange, but I think it was on the pharo list.
Maybe someone could open an issue on the Pharo bug tracker to make this problem go away?
The original problem was addressed by Nicolas and Andreas:
http://bugs.squeak.org/view.php?id=6366
Meanwhile a workaround was introduced in Pharo, resulting in the renamed method.
But once fixed in the VM, the Pharo workaround was no longer required, and should have been removed so that the Squeak and Pharo images would not require different VMMaker versions:
http://bugs.squeak.org/view.php?id=7479 http://bugs.squeak.org/view.php?id=7479
well.. this kind of things is the reason why there should not be a fork anymore :) I just didn???t remember that change and then I didn???t work on merge it :P
I will address this tomorrow.
Thanks Esteban :)
Dave
vm-dev@lists.squeakfoundation.org
-
Bert Freudenberg -
David T. Lewis -
Eliot Miranda -
Esteban Lorenzano -
Levente Uzonyi