Vm-dev March 2013

vm-dev@lists.squeakfoundation.org

38 participants
135 discussions

Re: Issue 13 in cog: [ENH] Disable module loading support
by cog＠googlecode.com 12 Mar '13

12 Mar '13

Updates: Status: Done Comment #3 on issue 13 by esteba...(a)gmail.com: [ENH] Disable module loading support http://code.google.com/p/cog/issues/detail?id=13 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings

1 0

Re: Issue 92 in cog: 3 LargeInteger arithmetic primitive bugs with minimum signed 64 bit value
by cog＠googlecode.com 12 Mar '13

12 Mar '13

Comment #6 on issue 92 by nicolas....(a)gmail.com: 3 LargeInteger arithmetic primitive bugs with minimum signed 64 bit value http://code.google.com/p/cog/issues/detail?id=92 As long as SmallInteger minVal negated (2^30) fits on 32 bits, there would be no such problem in SmallInteger primitives. AFAICT, 0 - INT_MIN like problem was only in LargeInt primitives, and those are not jitted. However, JIT is clever and for example in genPrimitiveAdd avoid shifting the SmallInteger tag (genShiftAwaySmallIntegerTagsInScratchReg:), and just remove it from one of operands (genRemoveSmallIntegerTagsInScratchReg:) so as to directly produce a tagged integer. Thus, testing if the result fits in 31 bit SmallInteger, become as simple as testing for 32 bit overflow... Testing for overflow is much simpler than in C, see senders of #JumpOverflow: Note that genPrimitiveDivide use another strategy for testing overflow case of (SmallInteger minVal/-1).

1 1

Issue 109 in cog: CogVM crashes with simple code
by cog＠googlecode.com 12 Mar '13

12 Mar '13

Status: New Owner: ---- Labels: Type-Defect Priority-Medium New issue 109 by jonkande...(a)gmail.com: CogVM crashes with simple code http://code.google.com/p/cog/issues/detail?id=109 Below are a few lines of code that crashes the CogVM on both Linux and Windows. File-in the Smalltalk code below, then evaluate [nil crashCogVM]. The code uses [1-1] but it could use [1+1] or [56+98]. I put the code on nil, but that is not important either. I think the important thing is that the primitive (+ or -) is evaluated but the result is not assigned into any variable. Also important is that the code is put into a loop that I assume has been JIT optimized. The image I used is Pharo 1.4 one-click with latest update #14459. This code does not crash StackVM. !UndefinedObject methodsFor: 'crash' stamp: 'JonKAnderson 11/29/2012 17:26'! crashCogVM " Evaluate [ nil crashCogVM ]" | i | i := 20. 1 to: i do: [:d | 1-1 ] ! !

2 4

Re: Issue 27 in cog: Add a new primitive: #primitiveImageFormatVersion
by cog＠googlecode.com 12 Mar '13

12 Mar '13

Updates: Status: Done Comment #3 on issue 27 by esteba...(a)gmail.com: Add a new primitive: #primitiveImageFormatVersion http://code.google.com/p/cog/issues/detail?id=27 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings

1 0

Bad links on http://www.squeakvm.org/mac/
by phil＠highoctane.be 12 Mar '13

12 Mar '13

Looks like you guys are going to https://ci.lille.inria.fr/pharo/job/Cog-VM/Architecture=32,OS=mac/lastSucce… but the servername is not that anymore. Stuff now lives here: http://pharo.gforge.inria.fr/ci/ Please adjust the links accordingly... Phil

2 1

VM Maker: VMMaker-oscog-EstebanLorenzano.236.mcz
by commits＠source.squeak.org 12 Mar '13

12 Mar '13

Esteban Lorenzano uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker-oscog-EstebanLorenzano.236.mcz ==================== Summary ==================== Name: VMMaker-oscog-EstebanLorenzano.236 Author: EstebanLorenzano Time: 12 March 2013, 10:43:57.384 am UUID: 1dbdb1d5-7f43-44db-9cec-f2095b90345e Ancestors: VMMaker-oscog-EstebanLorenzano.235, VMMaker.oscog-eem.272 - merged with Eliot's. More becomeForward: fixes. =============== Diff against VMMaker-oscog-EstebanLorenzano.235 =============== Item was added: + ----- Method: CoInterpreterStackPages>>markStackPageLeastMostRecentlyUsed: (in category 'page access') ----- + markStackPageLeastMostRecentlyUsed: page "<InterpreterStackPage>" + "This method is used to move a page to the end of the used pages. + This is to keep asserts checking pageListIsWellFormed happy." + + "MRUP-->used page<->used page<->used page<->used page<--LRUP + ^ <-next-prev-> ^ + | | + v <-prev-next-> v + free page<->free page<->free page<->free page" + + <var: #page type: #'StackPage *'> + <returnTypeC: #void> + | lastUsedPage | + <var: #lastUsedPage type: #'StackPage *'> + self assert: page = mostRecentlyUsedPage nextPage. + lastUsedPage := page nextPage. + [lastUsedPage isFree] whileTrue: + [lastUsedPage := lastUsedPage nextPage]. + lastUsedPage nextPage = page ifTrue: + [^nil]. + page prevPage nextPage: page nextPage. + page nextPage prevPage: page prevPage. + lastUsedPage prevPage nextPage: page. + page prevPage: lastUsedPage prevPage. + page nextPage: lastUsedPage. + lastUsedPage prevPage: page. + self assert: self pageListIsWellFormed! Item was changed: ----- Method: CoInterpreterStackPages>>markStackPageMostRecentlyUsed: (in category 'page access') ----- markStackPageMostRecentlyUsed: page "<InterpreterStackPage>" "MRUP-->used page<->used page<->used page<->used page<--LRUP ^ <-next-prev-> ^ | | v <-prev-next-> v free page<->free page<->free page<->free page" + <var: #page type: #'StackPage *'> - <var: #page type: 'StackPage *'> <asmLabel: false> <returnTypeC: #void> page == mostRecentlyUsedPage ifTrue: [^nil]. "Common case; making new page most recently used." page prevPage == mostRecentlyUsedPage ifTrue: [mostRecentlyUsedPage := page. self assert: self pageListIsWellFormed. ^nil]. page prevPage nextPage: page nextPage. page nextPage prevPage: page prevPage. mostRecentlyUsedPage nextPage prevPage: page. page prevPage: mostRecentlyUsedPage. page nextPage: mostRecentlyUsedPage nextPage. mostRecentlyUsedPage nextPage: page. mostRecentlyUsedPage := page. self assert: self pageListIsWellFormed! Item was changed: ----- Method: CoInterpreterStackPages>>markStackPageNextMostRecentlyUsed: (in category 'page access') ----- markStackPageNextMostRecentlyUsed: page "<InterpreterStackPage>" "This method is used to move a page to a position in the list such that it cannot be deallocated when a new page is allocated, without changing the most recently used page. There must be at least 3 pages in the system. So making the page the MRU's prevPage is sufficient to ensure it won't be deallocated." "MRUP-->used page<->used page<->used page<->used page<--LRUP ^ <-next-prev-> ^ | | v <-prev-next-> v free page<->free page<->free page<->free page" + <var: #page type: #'StackPage *'> - <var: #page type: 'StackPage *'> <returnTypeC: #void> self assert: page ~~ mostRecentlyUsedPage. page nextPage == mostRecentlyUsedPage ifTrue: [^nil]. page prevPage nextPage: page nextPage. page nextPage prevPage: page prevPage. mostRecentlyUsedPage prevPage nextPage: page. page prevPage: mostRecentlyUsedPage prevPage. page nextPage: mostRecentlyUsedPage. mostRecentlyUsedPage prevPage: page. self assert: self pageListIsWellFormed! Item was changed: ----- Method: CoInterpreterStackPages>>pageListIsWellFormed (in category 'assertions') ----- pageListIsWellFormed "Answer if the stack page list is well-formed. MRUP-->used page<->used page<->used page<->used page<--LRUP ^ <-next-prev-> ^ | | v <-prev-next-> v free page<->free page<->free page<->free page" | ok page count limit | <inline: false> + <var: #page type: #'StackPage *'> - <var: #page type: 'StackPage *'> ok := true. page := mostRecentlyUsedPage nextPage. count := 1. limit := coInterpreter numStkPages * 2. [page isFree and: [page ~= mostRecentlyUsedPage and: [count <= limit]]] whileTrue: [(self asserta: page nextPage prevPage == page) ifFalse: [ok := false]. page := page nextPage. count := count + 1]. [page ~= mostRecentlyUsedPage and: [count <= limit]] whileTrue: [(self asserta: page nextPage prevPage == page) ifFalse: [ok := false]. (self asserta: page isFree not) ifTrue: [(self asserta: (self stackPageFor: page baseFP) == page) ifFalse: [ok := false]. (self asserta: (self stackPageFor: page headSP) == page) ifFalse: [ok := false]] ifFalse: [ok := false]. page := page nextPage. count := count + 1]. (self asserta: count = coInterpreter numStkPages) ifFalse: [ok := false]. ^ok! Item was changed: ----- Method: CoInterpreterStackPages>>stackPageAt: (in category 'page access') ----- stackPageAt: index "Answer the page for a page index. N.B. This is a zero-relative index." + <returnTypeC: #'StackPage *'> - <returnTypeC: 'StackPage *'> ^self stackPageAt: index pages: pages! Item was changed: ----- Method: InterpreterStackPages>>isFree: (in category 'page access') ----- isFree: thePage + "This is an anachronism. Previously Slang couldn't generate the method correctly + from e.g. InterpreterStackPage>>isFree since Slang didn't do substitution on self. + Now it does, but there are still callers of isFree: so we keep this for simulation." - "This is a sad workaround. Ideally this is an accessor on InterpreterStackPages. - But it isn't easy to extend Slang to deal with this. There's no easy place to put - the type information and Slang doesn't ever do substitution on self. It merely - elides self." <doNotGenerate> + ^thePage baseFP = 0! - <inline: true> - <var: #thePage type: 'StackPage *'> - ^thePage baseFP = 0 - ! Item was added: + ----- Method: InterpreterStackPages>>markStackPageLeastMostRecentlyUsed: (in category 'page access') ----- + markStackPageLeastMostRecentlyUsed: page "<InterpreterStackPage>" + "This method is used to move a page to the end of the used pages. + This is to keep asserts checking pageListIsWellFormed happy." + + "MRUP-->used page<->used page<->used page<->used page<--LRUP + ^ <-next-prev-> ^ + | | + v <-prev-next-> v + free page<->free page<->free page<->free page" + + <var: #page type: #'StackPage *'> + <returnTypeC: #void> + | lastUsedPage | + <var: #lastUsedPage type: #'StackPage *'> + self assert: page = mostRecentlyUsedPage nextPage. + lastUsedPage := page nextPage. + [lastUsedPage isFree] whileTrue: + [lastUsedPage := lastUsedPage nextPage]. + lastUsedPage nextPage = page ifTrue: + [^nil]. + page prevPage nextPage: page nextPage. + page nextPage prevPage: page prevPage. + lastUsedPage prevPage nextPage: page. + page prevPage: lastUsedPage prevPage. + page nextPage: lastUsedPage. + lastUsedPage prevPage: page. + self assert: self pageListIsWellFormed! Item was changed: ----- Method: InterpreterStackPages>>markStackPageMostRecentlyUsed: (in category 'page access') ----- markStackPageMostRecentlyUsed: page "<InterpreterStackPage>" "MRUP-->used page<->used page<->used page<->used page<--LRUP ^ <-next-prev-> ^ | | v <-prev-next-> v free page<->free page<->free page<->free page" + <var: #page type: #'StackPage *'> - <var: #page type: 'StackPage *'> <asmLabel: false> page == mostRecentlyUsedPage ifTrue: [^nil]. "Common case; making new page most recently used." page prevPage == mostRecentlyUsedPage ifTrue: [mostRecentlyUsedPage := page. self assert: self pageListIsWellFormed. ^nil]. page prevPage nextPage: page nextPage. page nextPage prevPage: page prevPage. mostRecentlyUsedPage nextPage prevPage: page. page prevPage: mostRecentlyUsedPage. page nextPage: mostRecentlyUsedPage nextPage. mostRecentlyUsedPage nextPage: page. mostRecentlyUsedPage := page. self assert: self pageListIsWellFormed! Item was changed: ----- Method: InterpreterStackPages>>markStackPageNextMostRecentlyUsed: (in category 'page access') ----- markStackPageNextMostRecentlyUsed: page "<InterpreterStackPage>" "This method is used to move a page to a position in the list such that it cannot be deallocated when a new page is allocated, without changing the most recently used page. There must be at least 3 pages in the system. So making the page the MRU's prevPage is sufficient to ensure it won't be deallocated." "MRUP-->used page<->used page<->used page<->used page<--LRUP ^ <-next-prev-> ^ | | v <-prev-next-> v free page<->free page<->free page<->free page" + <var: #page type: #'StackPage *'> - <var: #page type: 'StackPage *'> self assert: page ~~ mostRecentlyUsedPage. page nextPage == mostRecentlyUsedPage ifTrue: [^nil]. page prevPage nextPage: page nextPage. page nextPage prevPage: page prevPage. mostRecentlyUsedPage prevPage nextPage: page. page prevPage: mostRecentlyUsedPage prevPage. page nextPage: mostRecentlyUsedPage. mostRecentlyUsedPage prevPage: page. self assert: self pageListIsWellFormed! Item was changed: ----- Method: InterpreterStackPages>>pageIndexFor: (in category 'page access') ----- pageIndexFor: pointer "<Integer>" "Answer the page index for a pointer into stack memory, i.e. the index for the page the address is in. N.B. This is a zero-relative index." + <var: #pointer type: #'void *'> - <var: #pointer type: 'void *'> ^self pageIndexFor: pointer stackMemory: stackMemory bytesPerPage: bytesPerPage! Item was changed: ----- Method: InterpreterStackPages>>pageListIsWellFormed (in category 'assertions') ----- pageListIsWellFormed "Answer if the stack page list is well-formed. MRUP-->used page<->used page<->used page<->used page<--LRUP ^ <-next-prev-> ^ | | v <-prev-next-> v free page<->free page<->free page<->free page" | ok page count limit | <inline: false> + <var: #page type: #'StackPage *'> - <var: #page type: 'StackPage *'> ok := true. page := mostRecentlyUsedPage nextPage. count := 1. limit := numPages * 2. [page isFree and: [page ~= mostRecentlyUsedPage and: [count <= limit]]] whileTrue: [(self asserta: page nextPage prevPage == page) ifFalse: [ok := false]. page := page nextPage. count := count + 1]. [page ~= mostRecentlyUsedPage and: [count <= limit]] whileTrue: [(self asserta: page nextPage prevPage == page) ifFalse: [ok := false]. (self asserta: page isFree not) ifTrue: [(self asserta: (self stackPageFor: page baseFP) == page) ifFalse: [ok := false]. (self asserta: (self stackPageFor: page headSP) == page) ifFalse: [ok := false]] ifFalse: [ok := false]. page := page nextPage. count := count + 1]. (self asserta: count = numPages) ifFalse: [ok := false]. ^ok! Item was changed: ----- Method: InterpreterStackPages>>stackPageAt: (in category 'page access') ----- stackPageAt: index "Answer the page for a page index. N.B. This is a zero-relative index." + <returnTypeC: #'StackPage *'> - <returnTypeC: 'StackPage *'> ^self stackPageAt: index pages: pages! Item was changed: ----- Method: StackInterpreter>>assertValidExecutionPointe:r:s:imbar: (in category 'debug support') ----- assertValidExecutionPointe: lip r: lfp s: lsp imbar: inInterpreter + <var: #lip type: #usqInt> - <var: #lip type: #'char *'> <var: #lfp type: #'char *'> <var: #lsp type: #'char *'> self assert: inInterpreter. self assert: stackPage = (stackPages stackPageFor: lfp). self assert: stackPage = stackPages mostRecentlyUsedPage. self assertValidStackLimits. self assert: lfp < stackPage baseAddress. self assert: lsp < lfp. self assert: lfp > lsp. self assert: lsp >= (stackPage realStackLimit - self stackLimitOffset). self assert: (lfp - lsp) < LargeContextSize. self assert: (self validInstructionPointer: lip inFrame: lfp). self assert: ((self frameIsBlockActivation: lfp) or: [(self pushedReceiverOrClosureOfFrame: lfp) = (self frameReceiver: lfp)]). self assert: method = (self frameMethod: lfp). self cppIf: MULTIPLEBYTECODESETS ifTrue: [self assert: (self methodUsesAlternateBytecodeSet: method) = (bytecodeSetSelector = 256)].! Item was changed: ----- Method: StackInterpreter>>externalSetStackPageAndPointersForSuspendedContextOfProcess: (in category 'frame access') ----- externalSetStackPageAndPointersForSuspendedContextOfProcess: aProcess "Set stackPage, framePointer and stackPointer for the suspendedContext of aProcess, marrying the context if necessary, and niling the suspendedContext slot. This is used on process switch to ensure a context has a stack frame and so can continue execution." + | newContext theFrame thePage newPage | - | newContext theFrame thePage | <var: #theFrame type: #'char *'> <var: #thePage type: #'StackPage *'> + <var: #newPage type: #'StackPage *'> newContext := objectMemory fetchPointer: SuspendedContextIndex ofObject: aProcess. self assert: (objectMemory isContext: newContext). (self isMarriedOrWidowedContext: newContext) ifTrue: [self assert: (self checkIsStillMarriedContext: newContext currentFP: framePointer)]. + objectMemory + storePointerUnchecked: SuspendedContextIndex + ofObject: aProcess + withValue: objectMemory nilObject. - objectMemory storePointerUnchecked: SuspendedContextIndex ofObject: aProcess withValue: objectMemory nilObject. (self isStillMarriedContext: newContext) ifTrue: [theFrame := self frameOfMarriedContext: newContext. + thePage := stackPages stackPageFor: theFrame. + theFrame ~= thePage headFP ifTrue: + ["explicit assignment of suspendedContext can cause switch to interior frame." + newPage := self newStackPage. + self moveFramesIn: thePage + through: (self findFrameAbove: theFrame inPage: thePage) + toPage: newPage. + stackPages markStackPageLeastMostRecentlyUsed: newPage]. + self assert: thePage headFP = theFrame] - thePage := stackPages stackPageFor: theFrame] ifFalse: [thePage := self makeBaseFrameFor: newContext. theFrame := thePage baseFP]. - self assert: thePage headFP = theFrame. self setStackPageAndLimit: thePage. stackPointer := thePage headSP. framePointer := thePage headFP. (self isMachineCodeFrame: framePointer) ifFalse: [self setMethod: (self iframeMethod: framePointer)]. self assertValidExecutionPointe: self stackTop asUnsignedInteger r: framePointer s: stackPointer! Item was changed: ----- Method: StackInterpreter>>respondToUnknownBytecode (in category 'miscellaneous bytecodes') ----- respondToUnknownBytecode "If an error selector is available then send it to the activeContext, otherwise abort." <sharedCodeNamed: #respondToUnknownBytecode inCase: #unknownBytecode> + | ourContext | + messageSelector := objectMemory maybeSplObj: SelectorUnknownBytecode. + (messageSelector isNil + or: [messageSelector = objectMemory nilObject]) ifTrue: - | unknownBytecodeSelector ourContext | - unknownBytecodeSelector := objectMemory maybeSplObj: SelectorUnknownBytecode. - unknownBytecodeSelector isNil ifTrue: [self error: 'Unknown bytecode']. ourContext := self ensureFrameIsMarried: localFP SP: localSP. + "undo fetch of bytecode so that context's pc is pointing to the unknown bytecode." + localIP := localIP - 1. - "N.B. Do Not: - self fetchNextBytecode." self internalPush: ourContext. - messageSelector := unknownBytecodeSelector. argumentCount := 0. + self normalSend! - self commonSend! Item was changed: ----- Method: StackInterpreter>>validInstructionPointer:inMethod:framePointer: (in category 'debug support') ----- validInstructionPointer: theInstrPointer inMethod: aMethod framePointer: fp <var: #theInstrPointer type: #usqInt> <var: #aMethod type: #usqInt> + <var: #fp type: #'char *'> ^self cppIf: MULTIPLEBYTECODESETS ifTrue: [| methodHeader | methodHeader := self noAssertHeaderOf: aMethod. "-1 for pre-increment in fetchNextBytecode" theInstrPointer >= (aMethod + (objectMemory lastPointerOf: aMethod) + BaseHeaderSize - 1) and: [theInstrPointer < (aMethod + (objectMemory byteLengthOf: aMethod) + BaseHeaderSize - 1) and: ["If the method starts with a CallPrimitive opcode the instruction pointer should be past it." ((self headerIndicatesAlternateBytecodeSet: methodHeader) and: [(self alternateHeaderHasPrimitiveFlag: methodHeader) and: [theInstrPointer < (aMethod + BaseHeaderSize - 1 + (objectMemory lastPointerOf: aMethod) + (self sizeOfCallPrimitiveBytecode: methodHeader) - 1)]]) not]]] ifFalse: "-1 for pre-increment in fetchNextBytecode" [theInstrPointer >= (aMethod + (objectMemory lastPointerOf: aMethod) + BaseHeaderSize - 1) and: [theInstrPointer < (aMethod + (objectMemory byteLengthOf: aMethod) + BaseHeaderSize - 1)]]!

1 0

VM Maker: VMMaker-dtl.304.mcz
by commits＠source.squeak.org 12 Mar '13

12 Mar '13

David T. Lewis uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker-dtl.304.mcz ==================== Summary ==================== Name: VMMaker-dtl.304 Author: dtl Time: 11 March 2013, 9:54:49.662 pm UUID: 7381d88a-6574-4f47-9a1e-ad72ddc48520 Ancestors: VMMaker-dtl.303 VMMaker 4.10.14 Reference Mantis 0007751: Add SSL plugin Add Andreas Raab's SqueakSSLPlugin to the update map for source.squeak.org/VMMaker. Add SqueakSSLPlugin to the VMMakerTool defaultUnixSpec. Follow up required: Add platform sources to SVN from Andreas' respository at http://code.google.com/p/squeakssl for from the oscog branch. =============== Diff against VMMaker-dtl.303 =============== Item was changed: ----- Method: VMMaker class>>versionString (in category 'version testing') ----- versionString "VMMaker versionString" + ^'4.10.14'! - ^'4.10.13'! Item was changed: ----- Method: VMMakerTool class>>defaultUnixSpec (in category 'configurations') ----- defaultUnixSpec "Typical VMMaker spec for a unix/linux target platform" "VMMakerTool defaultUnixSpec" ^#( #( "internal plugins" #ADPCMCodecPlugin #AsynchFilePlugin #BMPReadWriterPlugin #BalloonEnginePlugin #BitBltSimulation #CroquetPlugin #DSAPlugin #DeflatePlugin #DropPlugin #FFTPlugin #FT2Plugin #FilePlugin #FloatArrayPlugin #FloatMathPlugin #GeniePlugin #JPEGReadWriter2Plugin #JPEGReaderPlugin #JoystickTabletPlugin #KlattSynthesizerPlugin #LargeIntegersPlugin #LocalePlugin #MD5Plugin #Matrix2x3Plugin #MiscPrimitivePlugin #RandPlugin #RePlugin #SHA256Plugin #SecurityPlugin #SerialPlugin #SlangTestPlugin #SlangTestSupportPlugin #SocketPlugin #SoundCodecPlugin #SoundGenerationPlugin #SoundPlugin #StarSqueakPlugin #SurfacePlugin ) #( "external plugins" #B3DAcceleratorPlugin #B3DEnginePlugin #ClipboardExtendedPlugin #DBusPlugin #FFIPlugin #FileCopyPlugin #GStreamerPlugin #HostWindowPlugin #KedamaPlugin #KedamaPlugin2 #MIDIPlugin #Mpeg3Plugin #RomePlugin #UUIDPlugin #UnixAioPlugin #UnixOSProcessPlugin #XDisplayControlPlugin #CameraPlugin #ScratchPlugin #UnicodePlugin #WeDoPlugin + #SqueakSSLPlugin ) true "inline flag" false "forBrowser flag" 'unix' "platform" 'src' "source directory for generated sources" 'platforms' "path to platform sources" 4 "unused, was bytesPerWord which is now a compile time definition" true "unused, was flag for source directtory pathname is relative" true "unused, was flag for platforms directory path is relative" 'Interpreter' "interpreter class name" )!

1 0

VM Maker: VMMaker-dtl.303.mcz
by commits＠source.squeak.org 12 Mar '13

12 Mar '13

David T. Lewis uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker-dtl.303.mcz ==================== Summary ==================== Name: VMMaker-dtl.303 Author: dtl Time: 11 March 2013, 9:25:44.432 pm UUID: 2ff403f4-35f2-4889-899f-e89f4e421870 Ancestors: VMMaker-dtl.302 Add SlangTest unit tests to document the slang C preprocessor directives. Background: Mantis 0005238: Integer bug on 64bit image/32bit VM VMMaker-dtl.133: VMMaker 3.11.0 Add support for C preprocessor statements in Slang =============== Diff against VMMaker-dtl.302 =============== Item was added: + ----- Method: SlangTest>>testIfElseEndif (in category 'testing preprocessor directives') ----- + testIfElseEndif + "Test isDefinedTrueExpression:inSmalltalk:comment:ifTrue:ifFalse: " + + "(SlangTest selector: #testIfElseEndif) run" + + | cString stringWithoutWhiteSpace lines | + "verify that the default Smalltalk block that is evaluated in simulation" + self assert: SlangTestSupportInterpreter new ifDefinedTrueElseEndif = 4. + + "verify generated C string" + cString := SlangTestSupportInterpreter asCString: #ifDefinedTrueElseEndif. + lines := (cString findTokens: Character cr) select: [:e | + { + '# if (SIZE == 8) // SIZE may be 4 or 8' . + ' return 8;' . + '# else' . + ' return 4;' . + '# endif // SIZE == 8' + } includes: e ]. + self should: lines size = 5. + self should: ('*return 8*' match: lines second). + self should: ('*return 4*' match: lines fourth). + + "check the rest of the method, ignoring whitespace" + cString := SlangTestSupportInterpreter asCString: #ifDefinedTrueElseEndif. + stringWithoutWhiteSpace := cString reject: [:e | e isSeparator]. + self should: stringWithoutWhiteSpace = + 'sqIntifDefinedTrueElseEndif(void){#if(SIZE==8)//SIZEmaybe4or8return8;#elsereturn4;#endif//SIZE==8returnnull;}'. + + " + sqInt ifDefinedTrueElseEndif(void) { + + # if (SIZE == 8) // SIZE may be 4 or 8 + return 8; + # else + return 4; + # endif // SIZE == 8 + + return null; + } + "! Item was added: + ----- Method: SlangTest>>testIfdefElseEndif (in category 'testing preprocessor directives') ----- + testIfdefElseEndif + "Test isDefined:inSmalltalk:comment:ifTrue:ifFalse: " + + "(SlangTest selector: #testIfdefElseEndif) run" + + | cString stringWithoutWhiteSpace lines | + self flag: #FIXME. "See redundant implementation in oscog #cppIf:ifTrue:ifFalse:" + + "verify that the default Smalltalk block that is evaluated in simulation" + self assert: SlangTestSupportInterpreter new ifdefElseEndif = #defaultBlockForSimulation. + + "verify generated C string" + cString := SlangTestSupportInterpreter asCString: #ifdefElseEndif. + lines := (cString findTokens: Character cr) select: [:e | + { + '# ifdef HAVE_FOO // some platforms do not support foo properly' . + ' return 1;' . + '# else' . + ' return 0;' . + '# endif // HAVE_FOO' + } includes: e ]. + self should: lines size = 5. + self should: ('*return 1*' match: lines second). + self should: ('*return 0*' match: lines fourth). + + "check the rest of the method, ignoring whitespace" + stringWithoutWhiteSpace := cString reject: [:e | e isSeparator]. + self should: stringWithoutWhiteSpace = + 'sqIntifdefElseEndif(void){#ifdefHAVE_FOO//someplatformsdonotsupportfooproperlyreturn1;#elsereturn0;#endif//HAVE_FOOreturnnull;}'. + + " + sqInt ifdefElseEndif(void) { + + # ifdef HAVE_FOO // some platforms do not support foo properly + return 1; + # else + return 0; + # endif // HAVE_FOO + + return null; + } + "! Item was added: + ----- Method: SlangTest>>testIfdefEndif (in category 'testing preprocessor directives') ----- + testIfdefEndif + "Test isDefined:inSmalltalk:comment:ifTrue: " + + "(SlangTest selector: #testIfdefEndif) run" + + | cString stringWithoutWhiteSpace lines | + self flag: #FIXME. "See redundant implementation in oscog #cppIf:ifTrue:" + + "verify that the default Smalltalk block that is evaluated in simulation" + self assert: SlangTestSupportInterpreter new ifdefEndif = #defaultBlockForSimulation. + + "verify generated C string" + cString := SlangTestSupportInterpreter asCString: #ifdefEndif. + lines := (cString findTokens: Character cr) select: [:e | + { + '# ifdef HAVE_FOO // some platforms do not support foo properly' . + ' return 1;' . + '# endif // HAVE_FOO' + } includes: e ]. + self should: lines size = 3. + + "check the rest of the method, ignoring whitespace" + cString := SlangTestSupportInterpreter asCString: #ifdefEndif. + stringWithoutWhiteSpace := cString reject: [:e | e isSeparator]. + self should: stringWithoutWhiteSpace = + 'sqIntifdefEndif(void){#ifdefHAVE_FOO//someplatformsdonotsupportfooproperlyreturn1;#endif//HAVE_FOOreturn0;}'. + + " + sqInt ifdefEndif(void) { + + # ifdef HAVE_FOO // some platforms do not support foo properly + return 1; + # endif // HAVE_FOO + + return 0; + } + "! Item was added: + ----- Method: SlangTest>>testPreprocessorExpression (in category 'testing preprocessor directives') ----- + testPreprocessorExpression + "Test preprocessorExpression: " + + "(SlangTest selector: #testPreprocessorExpression) run" + + | cString | + self flag: #FIXME. "See redundant implementation in oscog #cPreprocessorDirective: " + + cString := SlangTestSupportInterpreter asCString: #preprocessorExpression. + self should: ('*# define FOO bar*' match: cString). + self should: ((cString findTokens: Character cr) select: [:e | e = '# define FOO bar' ]) size = 1. + self should: ((cString findTokens: Character cr) select: [:e | e = '## define FOO bar' ]) size = 0. + ! Item was added: + ----- Method: SlangTestSupportInterpreter>>ifDefinedTrueElseEndif (in category 'preprocessor directives') ----- + ifDefinedTrueElseEndif + + self isDefinedTrueExpression: 'SIZE == 8' + inSmalltalk: [ ^ 4 ] + comment: 'SIZE may be 4 or 8' + ifTrue: [ ^8 ] + ifFalse: [ ^4 ]. + ^nil + ! Item was added: + ----- Method: SlangTestSupportInterpreter>>ifdefElseEndif (in category 'preprocessor directives') ----- + ifdefElseEndif + + self isDefined: 'HAVE_FOO' + inSmalltalk: [ ^ #defaultBlockForSimulation ] + comment: 'some platforms do not support foo properly' + ifTrue: [ ^true ] + ifFalse: [ ^false ]. + ^nil + ! Item was added: + ----- Method: SlangTestSupportInterpreter>>ifdefEndif (in category 'preprocessor directives') ----- + ifdefEndif + + self isDefined: 'HAVE_FOO' + inSmalltalk: [ ^ #defaultBlockForSimulation ] + comment: 'some platforms do not support foo properly' + ifTrue: [ ^ true ]. + ^ false + ! Item was added: + ----- Method: SlangTestSupportInterpreter>>preprocessorExpression (in category 'preprocessor directives') ----- + preprocessorExpression + + self preprocessorExpression: 'define FOO bar'. + !

1 0

new Cog VMs available
by Eliot Miranda 12 Mar '13

12 Mar '13

at http://www.mirandabanda.org/files/Cog/VM/VM.r2701/. CogVM binaries as per VMMaker.oscog-eem.272/r2701. Fix unknownBytecode processing to leave pc at unknown bytecode. Fix case of process switch to an interior frame. Fix some assert function signatures in the stack vm. Use symbols for types instead of strings in stack page funcs. Fix the become issue where methods that are identical are failing the code test because their penultimate literals are different objects. Add a flag "cmUsesPenultimateLit" to jitted methods, stealing bits from stackCheckOffset (which was way larger than needed). Shrink stackCheckOffset to 12 bits (still an order of magnitude larger than needed) and add an error check on assigning it. Also add a check for max method size (2^16-1 bytes) and refuse to jit a method that generates too much code. When comparing code, use the cmUsesPenultimateLit flag to decide if comparison includes penultimate lit or not. This is mildly insane, but the VM really doesn't know about the penultimate literal and it shouldn't depend on knowing it can be ignored. Note that the CoInterpreter knows about the last literal; it uses this in supersends. With this hack, Pharo's condenseSources works. -- best, Eliot

1 0

Re: [squeak-dev] error when updating Squeak4.4-12327 to trunk
by Eliot Miranda 12 Mar '13

12 Mar '13

On Sun, Mar 10, 2013 at 12:10 PM, Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> wrote: > OK, see the VM thread, I now think that problems does not come from > COG, but from ClassBuilder which in some cases fail to clean a cache > (primitive 116). > The problem does not show up in interpreter VM thanks to primitive 119 > (this primitives does not unlink send in cogit). it does unlink sends, but only for that selector. But is it really the case that it is a missing cache flush or is it a bug in Cog with its cache flushing? I realised the way to test this is to try the Stack VM and see if it crashes or not. I just tried that but now neither Cog nor the Stack VM crash although both fail the load with an MNU of #do: to UndefinedObject in Environment>>bindingOf:ifAbsent:. So how do I get the system back to a state where I can reproduce the Cog crash to compare the Stack and Cog VMs with each other? (Apologies for being unresponsive; I've just moved into a new apartment and only got my internet connection yesterday afternoon; at least its fast (for the states) :) ). > I have attempted a ClassBuilder fix and posted new updates from > nice-222 to cwp-227. > > Can I please ask our testers contribution once again? > > Nicolas > > 2013/3/8 Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>: >> 2013/3/8 Bert Freudenberg <bert(a)freudenbergs.de>: >>> >>> On 2013-03-08, at 10:55, Frank Shearar <frank.shearar(a)gmail.com> wrote: >>> >>>> On 7 March 2013 23:25, Frank Shearar <frank.shearar(a)gmail.com> wrote: >>>>> On 7 March 2013 23:11, Bert Freudenberg <bert(a)freudenbergs.de> wrote: >>>>>> On 2013-03-07, at 23:42, Frank Shearar <frank.shearar(a)gmail.com> wrote: >>>>>> >>>>>>>>> On 6 March 2013 15:59, Ken G. Brown <kbrown(a)mac.com> wrote: >>>>>>>>>> Running on COG 2397, and after updating fresh Squeak4.4-12327 Release to >>>>>>>>>> 12332, updating to Trunk fails at first attempt in the same place, then by >>>>>>>>>> abandoning and trying the update again, it apparently completes to 12511. >>>>>>>>>> >>>>>>>>>> Ken G. Brown >>>>>>>>>> >>>>>>>>>>> With COG 2678, pretty well the same. First attempt it timed out during >>>>>>>>>>> the same update-nice-223, then trying again from what had already been >>>>>>>>>>> loaded, got the following during the same update, during compiling >>>>>>>>>>> SMLoader-fbs-78 as before: >>>>>>> >>>>>>> What I find strange about all this is that we take a 4.4-12327 image >>>>>>> and whatever the latest Cog is and update it all the way without any >>>>>>> probems quite a few times a day on the CI server. >>>>>>> >>>>>>> frank >>>>>> >>>>>> Looks like it's an intermittent problem, unfortunately: >>>>>> >>>>>> I just updated the new all-in-one-cog to latest trunk, no problem. This is a 4.4-12327 image with Cog VM 2697. >>>>>> >>>>>> I then tried what Ken described: update the fresh image first from the squeak44 stream, then switch to trunk, then update again. >>>>>> >>>>>> BOOM. Cog crash. Didn't save the log unfortunately. >>>>>> >>>>>> Tried again. Update, switch to trunk, update again. No crash. What?! >>>>>> >>>>>> Once more. Update, switch to trunk, update. Crash! See below. >>>>>> >>>>>> Tried yet again, with switching to trunk immediately in a fresh image. Crashes, too, same place. >>>>>> >>>>>> So it does crash, just not always. But it's been more than 50% in my case. >>>>> >>>>> Ah, interesting. The CI jobs, naturally, don't update from squeak44; >>>>> they switch to trunk and update just like that. Which I would have >>>>> thought would make no difference... >>>> >>>> Actually, I lie. Here's an example of the CI jobs hitting the same >>>> issue: http://build.squeak.org/job/SqueakTrunk/204/console And further >>>> if you look at http://build.squeak.org/job/SqueakTrunk/ and choose to >>>> see the failing tests you'll see times (say around build #184) where >>>> the test failure count is unusually low. And >>>> http://build.squeak.org/job/SqueakTrunk/buildTimeTrend shows grey >>>> streaks where builds die. >>> >>> Curious that it still runs the tests at all if the update failed ... >>> >>> So Cog crashes, but has someone tried to replicate this on an interpreter? >>> >>> - Bert - >>> >> >> I think that the problem comes form COG which tries to use an obsolete >> method sent AFTER the recompilation of Parser which is not the >> expected behavior. >> I have triggered such kind of strange behavior that does not happen on >> an Interpreter VM, see the thread opened by Jeff Gonis '[Vm-dev] Cog >> VM Crash on Windows' >> For me, it must be related to a cache that is not cleaned-up, I don't know why. >> >> Nicolas > -- best, Eliot

1 0

← Newer
1
...
8
9
10
11
12
13
14
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev March 2013