Vm-dev November 2016

vm-dev@lists.squeakfoundation.org

34 participants
155 discussions

intAt from sqMemoryAccess.h does not extend sign
by Nicolas Cellier 08 Nov '16

08 Nov '16

In this code: static inline sqInt intAtPointer(char *ptr) { return (sqInt)(*((unsigned int *)ptr)); } static inline sqInt intAtPointerput(char *ptr, int val) { return (sqInt)(*((unsigned int *)ptr)= val); } the usage of unsigned int is questionable... It means that intAt and long32At won't perform sign extension in 64bits Spur VM. Since it returns a signed result (sqInt), that's troubling. The sole real sender of intAt seems to be primitiveIntegerAt: which fails for this reason on 64bits spur when fed with negative integers. For long32At, it's difficult to analyze: many senders! IMO, if we don't want a signed quantity, we should better write unsignedLong32At (or use lowcode uint32AtPointer which answers a 32 bits result)

2 7

[OpenSmalltalk/opensmalltalk-vm] 005130: add requirement for rpi (curl, for download depend...
by GitHub 08 Nov '16

08 Nov '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 0051301e27c4b095dbb0afce10ee4882941e200b https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0051301e27c4b095db… Author: Esteban Lorenzano <estebanlm(a)gmail.com> Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M build.linux32ARMv6/pharo.cog.spur/prepare-rpi.sh Log Message: ----------- add requirement for rpi (curl, for download dependencies) Commit: 1c4226da97af5121a0fa18148454047b0ad82b2c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1c4226da97af5121a0… Author: Esteban Lorenzano <estebanlm(a)gmail.com> Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m Log Message: ----------- add double dash (--) option for pharo vm (mac) Commit: 16510c0d1a0b593505411f03dfc0416ecc928ef6 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/16510c0d1a0b593505… Author: Esteban Lorenzano <estebanlm(a)gmail.com> Date: 2016-11-08 (Tue, 08 Nov 2016) Changed paths: M build.linux32ARMv6/pharo.cog.spur/prepare-rpi.sh M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m Log Message: ----------- Merge pull request #91 from estebanlm/doubledash-macOS pharovm: add double-dash for command line options (macOS) Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/7a1f71c8c718...16…

1 0

[OpenSmalltalk/opensmalltalk-vm] 7a1f71: Make sure that alloca prototype is defined in sqFF...
by GitHub 08 Nov '16

08 Nov '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 7a1f71c8c71863ff910024d9919c3051ecfdb7ec https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7a1f71c8c71863ff91… Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com> Date: 2016-11-08 (Tue, 08 Nov 2016) Changed paths: M platforms/Cross/plugins/SqueakFFIPrims/sqFFIPlugin.c Log Message: ----------- Make sure that alloca prototype is defined in sqFFIPlugin

1 0

[OpenSmalltalk/opensmalltalk-vm] 073040: Cosmetic use { } to remove warning about possible ...
by GitHub 08 Nov '16

08 Nov '16

Branch: refs/heads/LLP64_v2 Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 07304029c928266f0f1bb8c970763a6954746aa3 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/07304029c928266f0f… Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com> Date: 2016-11-08 (Tue, 08 Nov 2016) Changed paths: M platforms/win32/plugins/HostWindowPlugin/sqWin32HostWindowPlugin.c M platforms/win32/plugins/MIDIPlugin/sqWin32MIDI.c M platforms/win32/vm/sqWin32Window.c Log Message: ----------- Cosmetic use { } to remove warning about possible ambiguous nested if/else constructs Commit: 1fdb462305307d5eac73e644d578f59466f4767a https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1fdb462305307d5eac… Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com> Date: 2016-11-08 (Tue, 08 Nov 2016) Changed paths: M platforms/win32/plugins/JoystickTabletPlugin/sqWin32Joystick.c Log Message: ----------- Cosmetic: move extern function prototypes upward in file rather than inside functions There is no such thing as nested function prototypes. Ideally all these prototypes should be moved in some header Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/91569469c31e...1f…

1 0

Win32 Squeak.cog.spur FFI failure
by Nicolas Cellier 08 Nov '16

08 Nov '16

Hi, Win32 FFI fails for some time now. For example, load latest versions of FFI from http://source.squeak.org/FFI Then try this snippet: FFIPluginTests new testGenericDoubleCall. And you'll get a segmentation fault, crash.dmp. The latest vmI found in bintray already has the problem. https://dl.bintray.com/opensmalltalk/vm/:cog_win32x86_squeak.cog.spur_20160… This bug delayed the Win64 squeak.stack.spur delivery, because I thought I introduced a regression somewhere... I did not have time to check other OSes, but it would be worth trying. (Before declaring any VM+plugins as stable...) If someone has a way to easily dissect without precompiled artifacts, let me know. Nicolas

1 3

InterpreterProxy>>positiveMachineIntegerValueOf
by Eliot Miranda 08 Nov '16

08 Nov '16

Hi Nicolas, with Win64 what;s the right way to declare something as having an unsigned integer type as large as the word size (unsigned long long on 64-bits, unsigned long on 32-bits)? This is to declare the following correctly. Its return type is used to declare the function pointers inside a plugin correctly. Currently it is not correctly defined for Win64: InterpreterProxy>>positiveMachineIntegerValueOf: oop <returnTypeC: #'unsigned long'> oop isInteger ifFalse:[self error: 'Not an integer object']. ^oop < 0 ifTrue: [self primitiveFail. 0] ifFalse: [oop] _,,,^..^,,,_ best, Eliot

2 3

VM Maker: VMMaker.oscog-nice.1985.mcz
by commits＠source.squeak.org 08 Nov '16

08 Nov '16

Nicolas Cellier uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-nice.1985.mcz ==================== Summary ==================== Name: VMMaker.oscog-nice.1985 Author: nice Time: 8 November 2016, 12:43:20.98015 am UUID: 7c12723c-9f09-4d4e-832b-f01fd783899b Ancestors: VMMaker.oscog-eem.1984 Fix generation of signed32BitIntegerFor: for 64 bits VM. signed32BitIntegerFor: must work for any 32bit int, but current version will overflow if this int is large, for example -16r80000000. Indeed, not only constants must be extended to sqInt, but any expression whose type is shorter. Also, use unsigned usqInt, rather than signed sqInt, because it's well defined behavior (sign extension will occur during the conversion). =============== Diff against VMMaker.oscog-eem.1984 =============== Item was changed: ----- Method: CCodeGenerator>>generateIntegerObjectOf:on:indent: (in category 'C translation') ----- generateIntegerObjectOf: msgNode on: aStream indent: level "Generate the C code for this message onto the given stream." + | expr mustCastToUnsigned type typeIsUnsigned | - | expr castToSqint | expr := msgNode args first. aStream nextPutAll: '(('. "Note that the default type of an integer constant in C is int. Hence we /must/ + cast expression to long if in the 64-bit world, since e.g. in 64-bits - cast constants to long if in the 64-bit world, since e.g. in 64-bits (int)(16r1FFFFF << 3) = (int)16rFFFFFFF8 = -8 whereas (long)(16r1FFFFF << 3) = (long) 16rFFFFFFF8 = 4294967288." + type := self typeFor: expr in: currentMethod. + typeIsUnsigned := type first = $u. + mustCastToUnsigned := typeIsUnsigned not + or: [(self sizeOfIntegralCType: type) < (self sizeOfIntegralCType: #usqInt)]. + mustCastToUnsigned ifTrue: + [aStream nextPutAll: '(usqInt)']. - castToSqint := expr isConstant and: [vmClass isNil or: [vmClass objectMemoryClass wordSize = 8]]. - castToSqint ifTrue: - [aStream nextPutAll: '(sqInt)']. self emitCExpression: expr on: aStream. aStream nextPutAll: ' << '; print: vmClass objectMemoryClass numSmallIntegerTagBits; nextPutAll: ') | 1)'!

1 0

what is SqueakUnstripped.exe?
by Esteban Lorenzano 07 Nov '16

07 Nov '16

Hi, I wonder what are those files? what is the difference between them and the regular VM? Esteban

1 0

VM Maker: VMMaker.oscog-eem.1984.mcz
by commits＠source.squeak.org 07 Nov '16

07 Nov '16

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.1984.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.1984 Author: eem Time: 7 November 2016, 8:34:15.049799 am UUID: 3e33772d-bcef-4224-8a19-5dad15afb8c6 Ancestors: VMMaker.oscog-nice.1983 Minor correction to VMMaker.oscog-nice.1977 to note that Sista counters are always 32-bits, having two 16-bit halves for the reached and taken counts. =============== Diff against VMMaker.oscog-nice.1983 =============== Item was changed: ----- Method: SistaCogit>>picDataFor:Annotation:Mcpc:Bcpc:Method: (in category 'method introspection') ----- picDataFor: descriptor Annotation: isBackwardBranchAndAnnotation Mcpc: mcpc Bcpc: bcpc Method: cogMethodArg <var: #descriptor type: #'BytecodeDescriptor *'> <var: #mcpc type: #'char *'> <var: #cogMethodArg type: #'void *'> | annotation entryPoint tuple counter | + "N.B. Counters are always 32-bits, having two 16-bit halves for the reached and taken counts." + <var: #counter type: #'unsigned int'> - <var: #counter type: #usqInt> descriptor ifNil: [^0]. descriptor isBranch ifTrue: ["it's a branch; conditional?" (descriptor isBranchTrue or: [descriptor isBranchFalse]) ifTrue: [counter := (self cCoerce: ((self cCoerceSimple: cogMethodArg to: #'CogMethod *') counters) to: #'usqInt *') at: counterIndex. tuple := self picDataForCounter: counter at: bcpc + 1. tuple = 0 ifTrue: [^PrimErrNoMemory]. objectMemory storePointer: introspectionDataIndex ofObject: introspectionData withValue: tuple. introspectionDataIndex := introspectionDataIndex + 1. counterIndex := counterIndex + 1]. ^0]. annotation := isBackwardBranchAndAnnotation >> 1. ((self isPureSendAnnotation: annotation) and: [entryPoint := backEnd callTargetFromReturnAddress: mcpc asUnsignedInteger. entryPoint > methodZoneBase]) ifFalse: "send is not linked, or is not a send" [^0]. self targetMethodAndSendTableFor: entryPoint "It's a linked send; find which kind." annotation: annotation into: [:targetMethod :sendTable| | methodClassIfSuper association | methodClassIfSuper := nil. sendTable = superSendTrampolines ifTrue: [methodClassIfSuper := coInterpreter methodClassOf: (self cCoerceSimple: cogMethodArg to: #'CogMethod *') methodObject]. sendTable = directedSuperSendTrampolines ifTrue: [association := backEnd literalBeforeInlineCacheTagAt: mcpc asUnsignedInteger. methodClassIfSuper := objectRepresentation valueOfAssociation: association]. tuple := self picDataForSendTo: targetMethod methodClassIfSuper: methodClassIfSuper at: mcpc bcpc: bcpc + 1]. tuple = 0 ifTrue: [^PrimErrNoMemory]. objectMemory storePointer: introspectionDataIndex ofObject: introspectionData withValue: tuple. introspectionDataIndex := introspectionDataIndex + 1. ^0! Item was changed: ----- Method: SistaCogit>>picDataForCounter:at: (in category 'method introspection') ----- picDataForCounter: counter at: bcpc | executedCount tuple untakenCount | + "N.B. Counters are always 32-bits, having two 16-bit halves for the reached and taken counts." + <var: #counter type: #'unsigned int'> - <var: #counter type: #usqInt> tuple := objectMemory eeInstantiateClassIndex: ClassArrayCompactIndex format: objectMemory arrayFormat numSlots: 3. tuple = 0 ifTrue: [^0]. self assert: CounterBytes = 4. executedCount := initialCounterValue - (counter >> 16). untakenCount := initialCounterValue - (counter bitAnd: 16rFFFF). objectMemory storePointerUnchecked: 0 ofObject: tuple withValue: (objectMemory integerObjectOf: bcpc); storePointerUnchecked: 1 ofObject: tuple withValue: (objectMemory integerObjectOf: executedCount); storePointerUnchecked: 2 ofObject: tuple withValue: (objectMemory integerObjectOf: untakenCount). ^tuple!

1 0

[OpenSmalltalk/opensmalltalk-vm] 0e0fbe: Enable SUnit testing via smalltalkCI for Squeak
by GitHub 06 Nov '16

06 Nov '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 0e0fbe5e6dbbc5d22d5951d26d30040270a6cc21 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0e0fbe5e6dbbc5d22d… Author: Fabio Niephaus <code(a)fniephaus.com> Date: 2016-11-06 (Sun, 06 Nov 2016) Changed paths: M .travis_install.sh M .travis_test.sh A tests/smalltalk.ston A tests/smalltalkCI.sh Log Message: ----------- Enable SUnit testing via smalltalkCI for Squeak Commit: 50547f0796c729640c591e4c1b0d5a35904d6b9a https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/50547f0796c729640c… Author: Fabio Niephaus <code(a)fniephaus.com> Date: 2016-11-06 (Sun, 06 Nov 2016) Changed paths: M .travis_install.sh M .travis_test.sh A tests/smalltalk.ston A tests/smalltalkCI.sh Log Message: ----------- Merge pull request #90 from fniephaus/smalltalkCI Enable SUnit testing via smalltalkCI for Squeak Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/34930ff36ab3...50…

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev November 2016