Vm-dev March 2016

vm-dev@lists.squeakfoundation.org

33 participants
139 discussions

[commit][3638] Squelch deprecation warnings when updating a trunk image.
by commits＠squeakvm.org 08 Mar '16

08 Mar '16

Revision: 3638 Author: eliot Date: 2016-03-08 13:38:11 -0800 (Tue, 08 Mar 2016) Log Message: ----------- Squelch deprecation warnings when updating a trunk image. Modified Paths: -------------- branches/Cog/image/UpdateSqueakTrunkImage.st Modified: branches/Cog/image/UpdateSqueakTrunkImage.st =================================================================== --- branches/Cog/image/UpdateSqueakTrunkImage.st 2016-03-05 01:03:53 UTC (rev 3637) +++ branches/Cog/image/UpdateSqueakTrunkImage.st 2016-03-08 21:38:11 UTC (rev 3638) @@ -1,5 +1,7 @@ -[MCMcmUpdater - defaultUpdateURL: 'http://source.squeak.org/trunk'; - updateFromServer] valueSupplyingAnswer: true. +[[MCMcmUpdater + defaultUpdateURL: 'http://source.squeak.org/trunk'; + updateFromServer] valueSupplyingAnswer: true] + on: Deprecation + do: [:ex| ex resume: nil]. Smalltalk snapshot: true andQuit: true

1 0

VM Maker: VMMaker.oscog-EstebanLorenzano.1714.mcz
by commits＠source.squeak.org 08 Mar '16

08 Mar '16

Esteban Lorenzano uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-EstebanLorenzano.1714.mcz ==================== Summary ==================== Name: VMMaker.oscog-EstebanLorenzano.1714 Author: EstebanLorenzano Time: 8 March 2016, 6:16:11.06581 pm UUID: e83d2c5f-76cd-47fc-ac29-6c4a25fa5deb Ancestors: VMMaker.oscog-nice.1713 Remove wrong coertion. If coertion is present, this assertion fails: ref := ByteArray new: 4. ref integerAt: 1 put: -10 size: 4 signed: true. self assert: (ref integerAt: 1 size: 4 signed: true) = -10 =============== Diff against VMMaker.oscog-nice.1713 =============== Item was changed: ----- Method: ThreadedFFIPlugin>>primitiveFFIIntegerAt (in category 'primitives') ----- primitiveFFIIntegerAt "Answer a (signed or unsigned) n byte integer from the given byte offset in the receiver, using the platform's endianness." | isSigned byteSize byteOffset rcvr addr value mask valueOop | <var: 'value' type: #usqLong> <var: 'mask' type: #usqLong> <export: true> <inline: false> isSigned := interpreterProxy booleanValueOf: (interpreterProxy stackValue: 0). byteSize := interpreterProxy stackIntegerValue: 1. byteOffset := interpreterProxy stackIntegerValue: 2. rcvr := interpreterProxy stackObjectValue: 3. interpreterProxy failed ifTrue:[^0]. (byteOffset > 0 and: [(byteSize between: 1 and: 8) and: [(byteSize bitAnd: byteSize - 1) = 0 "a.k.a. isPowerOfTwo"]]) ifFalse: [^interpreterProxy primitiveFail]. addr := self ffiAddressOf: rcvr startingAt: byteOffset size: byteSize. interpreterProxy failed ifTrue:[^0]. byteSize <= 2 ifTrue: [byteSize = 1 ifTrue: [value := self cCoerceSimple: (interpreterProxy byteAt: addr) to: #'unsigned char'] ifFalse: [value := self cCoerceSimple: (interpreterProxy shortAt: addr) to: #'unsigned short']] ifFalse: [byteSize = 4 + ifTrue: [value := interpreterProxy long32At: addr] - ifTrue: [value := self cCoerceSimple: (interpreterProxy long32At: addr) to: #'unsigned int'] ifFalse: [value := interpreterProxy long64At: addr]]. byteSize < BytesPerWord ifTrue: [isSigned ifTrue: "sign extend value" [mask := 1 << (byteSize * 8 - 1). value := (value bitAnd: mask-1) - (value bitAnd: mask)]. "note: byte/short (&long if BytesPerWord=8) never exceed SmallInteger range" valueOop := interpreterProxy integerObjectOf: value] ifFalse: "general 64 bit integer; note these never fail" [valueOop := isSigned ifTrue:[interpreterProxy signed64BitIntegerFor: value] ifFalse:[interpreterProxy positive64BitIntegerFor: value]]. ^interpreterProxy pop: 4 thenPush: valueOop!

1 0

Fwd: [Pharo-users] Understanding Slang for building a compiler to C++
by Dimitris Chloupis 08 Mar '16

08 Mar '16

---------- Forwarded message --------- From: Dimitris Chloupis <kilon.alios(a)gmail.com> Date: Sat, Mar 5, 2016 at 1:05 AM Subject: Re: [Pharo-users] Understanding Slang for building a compiler to C++ To: Any question about pharo is welcome <pharo-users(a)lists.pharo.org> Thanks guys for the pointers, Clement I dont care about the VM my goal is not something like Slang but rather something that I will take a small piece of code in pharo lets say a few classes and convert it to C++ code that is human readable. But Esteban recommended to take a look at Slang anyway for what I want to create. My priority here is readable C++ code, rather than keeping the code as close to Pharo as possible. I know that compromises will have to be made, so no GC, static types etc. So I am looking into creating something that can take pharo code then the user adds annotations or extra syntax like types, pointers, manual memory managment, templates etc and then my compiler takes that and turns it to readable C++. I think this approach would be much easier for me to do instead of doing the hard work of trying to map Pharo to C++ which most likely is not possible since C++ even lacks simple reflection and of course will have to implement my own VM and my own GC . Essentially my goal is writing C++ with Pharo syntax or close to Pharo syntax. So people like me that want to take Pharo code and port it to C++ can do it easier than a manual rewrite. On Fri, Mar 4, 2016 at 10:36 PM Bernardo Ezequiel Contreras < vonbecmann(a)gmail.com> wrote: > Hi Dimitris, > Pavel has extracted the code generator in this project > > http://smalltalkhub.com/#!/~PavelKrivanek/CCodeGenerator > > On Fri, Mar 4, 2016 at 9:06 AM, Dimitris Chloupis <kilon.alios(a)gmail.com> > wrote: > >> Hey pharo experts I am interesting into studying how Slang works for >> making a compiler that takes pharo code and turns it to C++ code, my >> questions is where to find Slang , how to extract the code that compiles >> Slang to C and study it as an example for making my own compiler for C++. >> > > > > -- > Bernardo E.C. > > Sent from a cheap desktop computer in South America. >

4 4

Re: [Vm-dev] VM Maker: VMMaker.oscog-nice.1712.mcz
by Eliot Miranda 07 Mar '16

07 Mar '16

Hi Nicolas, how about refactoring like this: ? MacMenubarPlugin>>oopAsMenuHandle: menuHandleOop <returnTypeC: #MenuHandle> ^self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: #MenuHandle primitiveSetMenuItemKeyGlyph: menuHandleOop item: anInteger glyph: inGlyphInteger | menuHandle | self primitive: 'primitiveSetMenuItemKeyGlyph' parameters: #(Oop SmallInteger SmallInteger). menuHandle := self oopAsMenuHandle: menuHandleOop. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'SetMenuItemKeyGlyph(menuHandle,anInteger,inGlyphInteger)' inSmalltalk:[menuHandle]. ^nil or this? MacMenubarPlugin>>checkedMenuHandle: menuHandleOop | menuHandle | <returnTypeC: #MenuHandle> menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: #MenuHandle. self ioCheckMenuHandle: menuHandle. ^ menuHandle primitiveSetMenuItemKeyGlyph: menuHandleOop item: anInteger glyph: inGlyphInteger | menuHandle | self primitive: 'primitiveSetMenuItemKeyGlyph' parameters: #(Oop SmallInteger SmallInteger). menuHandle := self checkedMenuHandle: menuHandleOop. interpreterProxy failed ifFalse: [self SetMenu: menuHandle ItemKey: anInteger Glyph: inGlyphInteger] On Fri, Mar 4, 2016 at 5:33 PM, <commits(a)source.squeak.org> wrote: > > Nicolas Cellier uploaded a new version of VMMaker to project VM Maker: > http://source.squeak.org/VMMaker/VMMaker.oscog-nice.1712.mcz > > ==================== Summary ==================== > > Name: VMMaker.oscog-nice.1712 > Author: nice > Time: 5 March 2016, 2:32:35.84 am > UUID: 5c7fb203-b18c-4143-a2b9-cd59c2acc47c > Ancestors: VMMaker.oscog-nice.1711 > > Make the MacMenubarPlugin 64bits aware: the menuHandle does not > necessarily fit on a 32bits int. > > =============== Diff against VMMaker.oscog-nice.1711 =============== > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveAppendMenu:data: (in category > 'system primitives') ----- > primitiveAppendMenu: menuHandleOop data: str255 > | menuHandle constStr255 | > self primitive: 'primitiveAppendMenu' > parameters: #(Oop ByteArray). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'constStr255' type: 'ConstStr255Param'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > constStr255 := self cCoerce: str255 to: 'ConstStr255Param'. > self cCode: 'AppendMenu(menuHandle,constStr255)' > inSmalltalk:[menuHandle]. > ^nil! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveAppendMenuItemText:data: (in > category 'system primitives') ----- > primitiveAppendMenuItemText: menuHandleOop data: str255 > | menuHandle constStr255 | > self primitive: 'primitiveAppendMenuItemText' > parameters: #(Oop ByteArray). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'constStr255' type: 'ConstStr255Param'. > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > constStr255 := self cCoerce: str255 to: 'ConstStr255Param'. > self cCode: 'AppendMenuItemText(menuHandle,constStr255)' > inSmalltalk:[menuHandle]. > ^nil! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveCheckMenuItem:item:checked: (in > category 'system primitives') ----- > primitiveCheckMenuItem: menuHandleOop item: anInteger checked: aBoolean > | menuHandle | > self primitive: 'primitiveCheckMenuItem' > parameters: #(Oop SmallInteger Boolean). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'CheckMenuItem(menuHandle,anInteger,aBoolean)' > inSmalltalk:[menuHandle]. > ^nil > > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveCountMenuItems: (in category > 'system primitives') ----- > primitiveCountMenuItems: menuHandleOop > | menuHandle returnValue | > self primitive: 'primitiveCountMenuItems' > parameters: #(Oop). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > returnValue := self cCode: 'CountMenuItems(menuHandle)' > inSmalltalk:[0]. > ^returnValue asSmallIntegerObj > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveCreateStandardWindowMenu: (in > category 'system primitives') ----- > primitiveCreateStandardWindowMenu: inOptions > > | menuHandle result | > self primitive: 'primitiveCreateStandardWindowMenu' > parameters: #(SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > > self cCode: '#if TARGET_API_MAC_CARBON > '. > result := self cCode: > 'CreateStandardWindowMenu(inOptions,&menuHandle); > #endif' inSmalltalk:[0]. > + ^interpreterProxy positiveMachineIntegerFor: (self cCoerce: > menuHandle to: 'long')! > - ^interpreterProxy positive32BitIntegerFor: (self cCoerce: > menuHandle to: 'long')! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveDeleteMenuItem:item: (in > category 'system primitives') ----- > primitiveDeleteMenuItem: menuHandleOop item: anInteger > | menuHandle | > self primitive: 'primitiveDeleteMenuItem' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'DeleteMenuItem(menuHandle,anInteger)' > inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveDisableMenuCommand:item: (in > category 'system primitives') ----- > primitiveDisableMenuCommand: menuHandleOop item: anInteger > | menuHandle commandID | > self primitive: 'primitiveDisableMenuCommand' > parameters: #(Oop Oop). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'commandID' type: 'MenuCommand'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > commandID := self cCoerce: (interpreterProxy positive32BitValueOf: > anInteger) to: 'MenuCommand'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: '#if TARGET_API_MAC_CARBON > DisableMenuCommand(menuHandle,commandID); > #endif' inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveDisableMenuItem:item: (in > category 'system primitives') ----- > primitiveDisableMenuItem: menuHandleOop item: anInteger > | menuHandle | > self primitive: 'primitiveDisableMenuItem' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'DisableMenuItem(menuHandle,anInteger)' > inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveDisableMenuItemIcon:item: (in > category 'system primitives') ----- > primitiveDisableMenuItemIcon: menuHandleOop item: anInteger > | menuHandle | > self primitive: 'primitiveDisableMenuItemIcon' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'DisableMenuItemIcon(menuHandle,anInteger)' > inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveDisposeMenu: (in category > 'system primitives') ----- > primitiveDisposeMenu: menuHandleOop > | menuHandle | > self primitive: 'primitiveDisposeMenu' > parameters: #(Oop). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'DisposeMenu(menuHandle)' inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveEnableMenuCommand:item: (in > category 'system primitives') ----- > primitiveEnableMenuCommand: menuHandleOop item: anInteger > | menuHandle commandID | > self primitive: 'primitiveEnableMenuCommand' > parameters: #(Oop Oop). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'commandID' type: 'MenuCommand'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > commandID := self cCoerce: (interpreterProxy positive32BitValueOf: > anInteger) to: 'MenuCommand'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: '#if TARGET_API_MAC_CARBON > EnableMenuCommand(menuHandle,commandID); > #endif' inSmalltalk:[menuHandle]. > ^nil! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveEnableMenuItem:item: (in > category 'system primitives') ----- > primitiveEnableMenuItem: menuHandleOop item: anInteger > | menuHandle | > self primitive: 'primitiveEnableMenuItem' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'EnableMenuItem(menuHandle,anInteger)' > inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveEnableMenuItemIcon:item: (in > category 'system primitives') ----- > primitiveEnableMenuItemIcon: menuHandleOop item: anInteger > | menuHandle | > self primitive: 'primitiveEnableMenuItemIcon' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'EnableMenuItemIcon(menuHandle,anInteger)' > inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: > MacMenubarPlugin>>primitiveGetIndMenuItemWithCommandID:commandID: (in > category 'system primitives') ----- > primitiveGetIndMenuItemWithCommandID: menuHandleOop commandID: aCommandID > | menuHandle MenuItemIndex commandID applicationMenu outIndex | > self primitive: 'primitiveGetIndMenuItemWithCommandID' > parameters: #(Oop Oop). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'commandID' type: 'MenuCommand'. > self var: 'applicationMenu' type: 'MenuHandle'. > self var: 'outIndex' type: 'MenuItemIndex'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > commandID := self cCoerce: (interpreterProxy positive32BitValueOf: > aCommandID) to: 'MenuCommand'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: '#if TARGET_API_MAC_CARBON > GetIndMenuItemWithCommandID(menuHandle, kHICommandHide, 1, > &applicationMenu, &outIndex); > #endif' inSmalltalk:[menuHandle]. > ^outIndex asSmallIntegerObj > ! > > Item was changed: > ----- Method: > MacMenubarPlugin>>primitiveGetIndMenuWithCommandID:commandID: (in category > 'system primitives') ----- > primitiveGetIndMenuWithCommandID: menuHandleOop commandID: aCommandID > + | menuHandle commandID applicationMenu outIndex | > - | menuHandle MenuItemIndex commandID applicationMenu outIndex | > self primitive: 'primitiveGetIndMenuWithCommandID' > parameters: #(Oop Oop). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'commandID' type: 'MenuCommand'. > self var: 'applicationMenu' type: 'MenuHandle'. > self var: 'outIndex' type: 'MenuItemIndex'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > commandID := self cCoerce: (interpreterProxy positive32BitValueOf: > aCommandID) to: 'MenuCommand'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: '#if TARGET_API_MAC_CARBON > GetIndMenuItemWithCommandID(menuHandle, kHICommandHide, 1, > &applicationMenu, &outIndex); > #endif ' inSmalltalk:[menuHandle]. > + outIndex asSmallIntegerObj. "to avoid elimination of the > variable..." > + ^interpreterProxy positiveMachineIntegerFor: (self cCoerce: > applicationMenu to: 'long') > - ^interpreterProxy positive32BitIntegerFor: (self cCoerce: > applicationMenu to: 'long') > > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetItemCmd:item: (in category > 'system primitives') ----- > primitiveGetItemCmd: menuHandleOop item: anInteger > | menuHandle aCharacter | > <var: 'menuHandle' type: 'MenuHandle'> > <var: #aCharacter type: 'CharParameter'> > self primitive: 'primitiveGetItemCmd' > parameters: #(Oop SmallInteger). > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > aCharacter := 0. > self cCode: 'GetItemCmd(menuHandle,anInteger,&aCharacter)' > inSmalltalk:[menuHandle]. > ^aCharacter asSmallIntegerObj > > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetItemIcon:item: (in category > 'system primitives') ----- > primitiveGetItemIcon: menuHandleOop item: anInteger > | menuHandle iconIndex | > self primitive: 'primitiveGetItemIcon' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'iconIndex' type: 'short'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > iconIndex := 0. > self cCode: 'GetItemIcon(menuHandle,anInteger,&iconIndex)' > inSmalltalk:[menuHandle]. > ^iconIndex asSmallIntegerObj > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetItemMark:item: (in category > 'system primitives') ----- > primitiveGetItemMark: menuHandleOop item: anInteger > | menuHandle aCharacter | > <var: 'menuHandle' type: 'MenuHandle'> > <var: #aCharacter type: 'CharParameter'> > self primitive: 'primitiveGetItemMark' > parameters: #(Oop SmallInteger). > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > aCharacter := 0. > self cCode: 'GetItemMark(menuHandle,anInteger,&aCharacter)' > inSmalltalk:[menuHandle]. > ^aCharacter asSmallIntegerObj > > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetItemStyle:item: (in category > 'system primitives') ----- > primitiveGetItemStyle: menuHandleOop item: anInteger > | menuHandle chStyle | > self primitive: 'primitiveGetItemStyle' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'chStyle' type: 'Style'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > chStyle := 0. > self cCode: 'GetItemStyle(menuHandle,anInteger,&chStyle)' > inSmalltalk:[menuHandle]. > ^chStyle asSmallIntegerObj > > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetMenuBar (in category 'system > primitives') ----- > primitiveGetMenuBar > | menuHandle | > self primitive: 'primitiveGetMenuBar' > parameters: #(). > self var: 'menuHandle' type: 'Handle'. > menuHandle := self cCode: 'GetMenuBar()' inSmalltalk:[0]. > + ^interpreterProxy positiveMachineIntegerFor: (self cCoerce: > menuHandle to: 'long')! > - ^interpreterProxy positive32BitIntegerFor: (self cCoerce: > menuHandle to: 'long')! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetMenuHandle: (in category > 'system primitives') ----- > primitiveGetMenuHandle: menuID > | menuHandle | > self primitive: 'primitiveGetMenuHandle' > parameters: #(SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'menuID' type: 'MenuID'. > menuHandle := self cCode: 'GetMenuHandle(menuID)' inSmalltalk:[0]. > + ^interpreterProxy positiveMachineIntegerFor: (self cCoerce: > menuHandle to: 'long')! > - ^interpreterProxy positive32BitIntegerFor: (self cCoerce: > menuHandle to: 'long')! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetMenuID: (in category 'system > primitives') ----- > primitiveGetMenuID: menuHandleOop > | menuHandle menuID | > > self primitive: 'primitiveGetMenuID' > parameters: #(Oop ). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'menuID' type: 'MenuID'. > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'menuID = GetMenuID(menuHandle)' > inSmalltalk:[menuHandle]. > ^menuID asSmallIntegerObj > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetMenuItemCommandID:item: (in > category 'system primitives') ----- > primitiveGetMenuItemCommandID: menuHandleOop item: anInteger > | menuHandle outCommandID | > self primitive: 'primitiveGetMenuItemCommandID' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'outCommandID' type: 'MenuCommand'. > outCommandID := 0. > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: > 'GetMenuItemCommandID(menuHandle,anInteger,&outCommandID)' > inSmalltalk:[menuHandle]. > ^interpreterProxy positive32BitIntegerFor: outCommandID > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetMenuItemFontID:item: (in > category 'system primitives') ----- > primitiveGetMenuItemFontID: menuHandleOop item: anInteger > | menuHandle outFontID | > self primitive: 'primitiveGetMenuItemFontID' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'outFontID' type: 'SInt16'. > outFontID := 0. > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'GetMenuItemFontID(menuHandle,anInteger,&outFontID)' > inSmalltalk:[menuHandle]. > ^outFontID asSmallIntegerObj > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetMenuItemHierarchicalID:item: > (in category 'system primitives') ----- > primitiveGetMenuItemHierarchicalID: menuHandleOop item: anInteger > | menuHandle outHierID | > self primitive: 'primitiveGetMenuItemHierarchicalID' > parameters: #(Oop SmallInteger ). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'outHierID' type: 'MenuID'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > outHierID := 0. > self cCode: > 'GetMenuItemHierarchicalID(menuHandle,anInteger,&outHierID)' > inSmalltalk:[menuHandle]. > ^outHierID asSmallIntegerObj > > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetMenuItemKeyGlyph:item: (in > category 'system primitives') ----- > primitiveGetMenuItemKeyGlyph: menuHandleOop item: anInteger > | menuHandle outGlyph | > self primitive: 'primitiveGetMenuItemKeyGlyph' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'outGlyph' type: 'SInt16'. > outGlyph := 0. > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'GetMenuItemKeyGlyph(menuHandle,anInteger,&outGlyph)' > inSmalltalk:[menuHandle]. > ^interpreterProxy positive32BitIntegerFor: outGlyph > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetMenuItemModifiers:item: (in > category 'system primitives') ----- > primitiveGetMenuItemModifiers: menuHandleOop item: anInteger > | menuHandle outModifers | > self primitive: 'primitiveGetMenuItemModifiers' > parameters: #(Oop SmallInteger ). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'outModifers' type: 'Style'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > outModifers := 0. > self cCode: > 'GetMenuItemModifiers(menuHandle,anInteger,&outModifers)' > inSmalltalk:[menuHandle]. > ^outModifers asSmallIntegerObj > > > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetMenuItemText:item: (in > category 'system primitives') ----- > primitiveGetMenuItemText: menuHandleOop item: anInteger > | menuHandle size oop ptr aString | > <var: 'menuHandle' type: 'MenuHandle'> > <var: #aString type: 'Str255 '> > <var: #ptr type: 'char *'> > self primitive: 'primitiveGetMenuItemText' > parameters: #(Oop SmallInteger). > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > aString at: 0 put: 0. > self cCode: 'GetMenuItemText(menuHandle,anInteger,aString)' > inSmalltalk:[menuHandle]. > size := self cCode: 'aString[0]' inSmalltalk: [0]. > oop := interpreterProxy instantiateClass: interpreterProxy > classString indexableSize: size. > ptr := interpreterProxy firstIndexableField: oop. > 0 to: size-1 do:[:i| > ptr at: i put: (aString at: (i+1))]. > ^oop > > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetMenuItemTextEncoding:item: > (in category 'system primitives') ----- > primitiveGetMenuItemTextEncoding: menuHandleOop item: anInteger > | menuHandle outScriptID | > self primitive: 'primitiveGetMenuItemTextEncoding' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'outScriptID' type: 'TextEncoding'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: > 'GetMenuItemTextEncoding(menuHandle,anInteger,&outScriptID)' > inSmalltalk:[menuHandle]. > ^interpreterProxy positive32BitIntegerFor: outScriptID! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveGetMenuTitle: (in category > 'system primitives') ----- > primitiveGetMenuTitle: menuHandleOop > | menuHandle size oop ptr aString | > <var: 'menuHandle' type: 'MenuHandle'> > <var: #aString type: 'Str255 '> > <var: #ptr type: 'char *'> > self primitive: 'primitiveGetMenuTitle' > parameters: #(Oop). > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > aString at: 0 put: 0. > self cCode: 'GetMenuTitle(menuHandle,aString)' > inSmalltalk:[menuHandle]. > size := self cCode: 'aString[0]' inSmalltalk: [0]. > oop := interpreterProxy instantiateClass: interpreterProxy > classString indexableSize: size. > ptr := interpreterProxy firstIndexableField: oop. > 0 to: size-1 do:[:i| > ptr at: i put: (aString at: (i+1))]. > ^oop > > ! > > Item was changed: > ----- Method: > MacMenubarPlugin>>primitiveInsertFontResMenu:afterItem:scriptFilter: (in > category 'system primitives') ----- > primitiveInsertFontResMenu: menuHandleOop afterItem: afterItemInteger > scriptFilter: scriptFilterInteger > | menuHandle | > self primitive: 'primitiveInsertFontResMenu' > parameters: #(Oop SmallInteger SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: > 'InsertFontResMenu(menuHandle,afterItemInteger,scriptFilterInteger)' > inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: > MacMenubarPlugin>>primitiveInsertIntlResMenu:theType:afterItem:scriptFilter: > (in category 'system primitives') ----- > primitiveInsertIntlResMenu: menuHandleOop theType: aResType afterItem: > afterItemInteger scriptFilter: scriptFilterInteger > | menuHandle resType | > self primitive: 'primitiveInsertIntlResMenu' > parameters: #(Oop SmallInteger SmallInteger SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'resType' type: 'ResType'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > resType := self cCoerce: (interpreterProxy positive32BitValueOf: > aResType) to: 'ResType'. > self cCode: > 'InsertIntlResMenu(menuHandle,resType,afterItemInteger,scriptFilterInteger)' > inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveInsertMenu:beforeID: (in > category 'system primitives') ----- > primitiveInsertMenu: menuHandleOop beforeID: anInteger > | menuHandle | > self primitive: 'primitiveInsertMenu' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'anInteger' type: 'MenuID'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'InsertMenu(menuHandle,anInteger)' > inSmalltalk:[menuHandle]. > ^nil! > > Item was changed: > ----- Method: > MacMenubarPlugin>>primitiveInsertMenuItem:itemString:afterItem: (in > category 'system primitives') ----- > primitiveInsertMenuItem: menuHandleOop itemString: str255 afterItem: > anInteger > | menuHandle constStr255 | > self primitive: 'primitiveInsertMenuItem' > parameters: #(Oop ByteArray SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'constStr255' type: 'ConstStr255Param'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > constStr255 := self cCoerce: str255 to: 'ConstStr255Param'. > self cCode: 'InsertMenuItem(menuHandle,constStr255,anInteger)' > inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveIsMenuItemEnabled:item: (in > category 'system primitives') ----- > primitiveIsMenuItemEnabled: menuHandleOop item: anInteger > > | menuHandle result | > self primitive: 'primitiveIsMenuItemEnabled' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > result := self cCode: 'IsMenuItemEnabled(menuHandle,anInteger)' > inSmalltalk:[0]. > ^result asOop: Boolean! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveIsMenuItemIconEnabled:item: (in > category 'system primitives') ----- > primitiveIsMenuItemIconEnabled: menuHandleOop item: anInteger > > | menuHandle result | > self primitive: 'primitiveIsMenuItemIconEnabled' > parameters: #(Oop SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > result := self cCode: > 'IsMenuItemIconEnabled(menuHandle,anInteger)' inSmalltalk:[0]. > ^result asOop: Boolean! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveNewMenu:menuTitle: (in category > 'system primitives') ----- > primitiveNewMenu: menuID menuTitle: menuTitle > > | menuHandle constStr255 | > self primitive: 'primitiveNewMenu' > parameters: #(SmallInteger ByteArray). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'constStr255' type: 'ConstStr255Param'. > self var: 'menuID' type: 'MenuID'. > > constStr255 := self cCoerce: menuTitle to: 'ConstStr255Param'. > menuHandle := self cCode: 'NewMenu(menuID,constStr255)' > inSmalltalk:[0]. > + ^interpreterProxy positiveMachineIntegerFor: (self cCoerce: > menuHandle to: 'long')! > - ^interpreterProxy positive32BitIntegerFor: (self cCoerce: > menuHandle to: 'long')! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveSetItemCmd:item:cmdChar: (in > category 'system primitives') ----- > primitiveSetItemCmd: menuHandleOop item: anInteger cmdChar: > anIntegerCmdChar > | menuHandle aCharacter | > <var: 'menuHandle' type: 'MenuHandle'> > <var: #aCharacter type: 'CharParameter '> > self primitive: 'primitiveSetItemCmd' > parameters: #(Oop SmallInteger SmallInteger). > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > aCharacter := anIntegerCmdChar. > self cCode: 'SetItemCmd(menuHandle,anInteger,aCharacter)' > inSmalltalk:[menuHandle]. > ^nil > > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveSetItemIcon:item:iconIndex: (in > category 'system primitives') ----- > primitiveSetItemIcon: menuHandleOop item: anInteger iconIndex: > aIconIndexInteger > | menuHandle | > self primitive: 'primitiveSetItemIcon' > parameters: #(Oop SmallInteger SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'SetItemIcon(menuHandle,anInteger,aIconIndexInteger)' > inSmalltalk:[menuHandle]. > ^nil > > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveSetItemMark:item:markChar: (in > category 'system primitives') ----- > primitiveSetItemMark: menuHandleOop item: anInteger markChar: aMarkChar > | menuHandle aCharacter | > <var: 'menuHandle' type: 'MenuHandle'> > <var: #aCharacter type: 'CharParameter '> > self primitive: 'primitiveSetItemMark' > parameters: #(Oop SmallInteger SmallInteger). > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > aCharacter := aMarkChar. > self cCode: 'SetItemMark(menuHandle,anInteger,aCharacter)' > inSmalltalk:[menuHandle]. > ^nil > > ! > > Item was changed: > ----- Method: > MacMenubarPlugin>>primitiveSetItemStyle:item:styleParameter: (in category > 'system primitives') ----- > primitiveSetItemStyle: menuHandleOop item: anInteger styleParameter: > chStyleInteger > | menuHandle | > self primitive: 'primitiveSetItemStyle' > parameters: #(Oop SmallInteger SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'SetItemStyle(menuHandle,anInteger,chStyleInteger)' > inSmalltalk:[menuHandle]. > ^nil > > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveSetMenuBar: (in category > 'system primitives') ----- > primitiveSetMenuBar: menuHandleOop > > | menuBarHandle | > self primitive: 'primitiveSetMenuBar' > parameters: #(Oop). > self var: 'menuBarHandle' type: 'MenuBarHandle'. > + menuBarHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuBarHandle'. > - menuBarHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuBarHandle'. > self cCode: 'SetMenuBar(menuBarHandle)' > inSmalltalk:[menuBarHandle]. > ^nil! > > Item was changed: > ----- Method: > MacMenubarPlugin>>primitiveSetMenuItemCommandID:item:menuCommand: (in > category 'system primitives') ----- > primitiveSetMenuItemCommandID: menuHandleOop item: anInteger > menuCommand: inCommandID > | menuHandle commandID | > self primitive: 'primitiveSetMenuItemCommandID' > parameters: #(Oop SmallInteger Oop). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'commandID' type: 'MenuCommand'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > commandID := self cCoerce: (interpreterProxy positive32BitValueOf: > inCommandID) to: 'MenuCommand'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'SetMenuItemCommandID(menuHandle,anInteger,commandID)' > inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveSetMenuItemFontID:item:fontID: > (in category 'system primitives') ----- > primitiveSetMenuItemFontID: menuHandleOop item: anInteger fontID: > aFontIDInteger > | menuHandle | > self primitive: 'primitiveSetMenuItemFontID' > parameters: #(Oop SmallInteger SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: > 'SetMenuItemFontID(menuHandle,anInteger,aFontIDInteger)' > inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: > MacMenubarPlugin>>primitiveSetMenuItemHierarchicalID:item:hierID: (in > category 'system primitives') ----- > primitiveSetMenuItemHierarchicalID: menuHandleOop item: anInteger > hierID: aMenuID > | menuHandle | > self primitive: 'primitiveSetMenuItemHierarchicalID' > parameters: #(Oop SmallInteger SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'menuID' type: 'MenuID'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: > 'SetMenuItemHierarchicalID(menuHandle,anInteger,aMenuID)' > inSmalltalk:[menuHandle]. > ^nil! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveSetMenuItemKeyGlyph:item:glyph: > (in category 'system primitives') ----- > primitiveSetMenuItemKeyGlyph: menuHandleOop item: anInteger glyph: > inGlyphInteger > | menuHandle | > self primitive: 'primitiveSetMenuItemKeyGlyph' > parameters: #(Oop SmallInteger SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: > 'SetMenuItemKeyGlyph(menuHandle,anInteger,inGlyphInteger)' > inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: > MacMenubarPlugin>>primitiveSetMenuItemModifiers:item:inModifiers: (in > category 'system primitives') ----- > primitiveSetMenuItemModifiers: menuHandleOop item: anInteger > inModifiers: aUInt8 > | menuHandle | > self primitive: 'primitiveSetMenuItemModifiers' > parameters: #(Oop SmallInteger SmallInteger). > self var: 'menuHandle' type: 'MenuHandle'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > self cCode: 'SetMenuItemModifiers(menuHandle,anInteger,aUInt8)' > inSmalltalk:[menuHandle]. > ^nil! > > Item was changed: > ----- Method: > MacMenubarPlugin>>primitiveSetMenuItemText:item:itemString: (in category > 'system primitives') ----- > primitiveSetMenuItemText: menuHandleOop item: anInteger itemString: > str255 > | menuHandle constStr255 | > self primitive: 'primitiveSetMenuItemText' > parameters: #(Oop SmallInteger ByteArray). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'constStr255' type: 'ConstStr255Param'. > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > constStr255 := self cCoerce: str255 to: 'ConstStr255Param'. > self cCode: 'SetMenuItemText(menuHandle,anInteger,constStr255)' > inSmalltalk:[menuHandle]. > ^nil > ! > > Item was changed: > ----- Method: > MacMenubarPlugin>>primitiveSetMenuItemTextEncoding:item:inScriptID: (in > category 'system primitives') ----- > primitiveSetMenuItemTextEncoding: menuHandleOop item: anInteger > inScriptID: aTextEncodingOop > | menuHandle inScriptID | > self primitive: 'primitiveSetMenuItemTextEncoding' > parameters: #(Oop SmallInteger Oop). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'inScriptID' type: 'TextEncoding'. > > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > inScriptID := self cCoerce: (interpreterProxy > positive32BitValueOf: aTextEncodingOop) to: 'TextEncoding'. > self cCode: > 'SetMenuItemTextEncoding(menuHandle,anInteger,inScriptID)' > inSmalltalk:[menuHandle]. > ^nil! > > Item was changed: > ----- Method: MacMenubarPlugin>>primitiveSetMenuTitle:title: (in > category 'system primitives') ----- > primitiveSetMenuTitle: menuHandleOop title: str255 > | menuHandle constStr255 | > self primitive: 'primitiveSetMenuTitle' > parameters: #(Oop ByteArray). > self var: 'menuHandle' type: 'MenuHandle'. > self var: 'constStr255' type: 'ConstStr255Param'. > + menuHandle := self cCoerce: (interpreterProxy > positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. > - menuHandle := self cCoerce: (interpreterProxy > positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. > (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy > success: false]. > constStr255 := self cCoerce: str255 to: 'ConstStr255Param'. > self cCode: 'SetMenuTitle(menuHandle,constStr255)' > inSmalltalk:[menuHandle]. > ^nil > ! > > -- _,,,^..^,,,_ best, Eliot

1 0

Re: [Vm-dev] VM Maker: VMMaker.oscog-nice.1713.mcz
by Nicolas Cellier 05 Mar '16

05 Mar '16

Another explanation for VM foolproofing is here: http://forum.world.st/VM-safety-td4816223.html 2016-03-05 3:16 GMT+01:00 <commits(a)source.squeak.org>: > > Nicolas Cellier uploaded a new version of VMMaker to project VM Maker: > http://source.squeak.org/VMMaker/VMMaker.oscog-nice.1713.mcz > > ==================== Summary ==================== > > Name: VMMaker.oscog-nice.1713 > Author: nice > Time: 5 March 2016, 3:15:22.817 am > UUID: ac270981-d3ba-4c42-a2b1-3a83693776be > Ancestors: VMMaker.oscog-nice.1712 > > The size of [unsigned] long long was not infered... > > VM fool proofing: > > Fix a missing guard in SmartSyntaxPlugin like explained at > > http://forum.world.st/VM-safety-missing-failing-guards-in-SmartSyntaxPlugin… > > Fix two missing guards in VM profiling primitives: one should not use the > result of stackObjectValue: before checking for success, otherwise a null > pointer exception will occur in case of failure. > > =============== Diff against VMMaker.oscog-nice.1712 =============== > > Item was changed: > ----- Method: CCodeGenerator>>sizeOfIntegralCType: (in category > 'inlining') ----- > sizeOfIntegralCType: anIntegralCType "<String>" > "N.B. Only works for values for which isIntegralCType: answers > true." > | prunedCType index | > (anIntegralCType beginsWith: 'register ') ifTrue: > [^self sizeOfIntegralCType: (anIntegralCType allButFirst: > 9)]. > prunedCType := (anIntegralCType beginsWith: 'unsigned ') > ifTrue: [(anIntegralCType > allButFirst: 9) withBlanksTrimmed] > ifFalse: [(anIntegralCType > beginsWith: 'signed ') > > ifTrue: [(anIntegralCType allButFirst: 7) withBlanksTrimmed] > > ifFalse: [anIntegralCType]]. > ^prunedCType asString caseOf: { > ['sqLong'] -> [8]. > ['usqLong'] -> [8]. > + ['long long'] -> [8]. > ['sqInt'] -> [BytesPerWord]. > ['usqInt'] -> [BytesPerWord]. > ['int'] -> [4]. > ['short'] -> [2]. > ['short int'] -> [2]. > ['char'] -> [1]. > ['long'] -> [BytesPerWord]. > ['size_t'] -> [BytesPerWord]. > ['pid_t'] -> [BytesPerWord]. > } > otherwise: > [((anIntegralCType beginsWith: 'unsigned') "e.g. > 'unsigned : 8'" > and: [(anIntegralCType includesAnyOf: '[*]') not > and: [(index := anIntegralCType indexOf: $:) > 0]]) > ifTrue: [(Integer readFrom: (anIntegralCType > copyFrom: index + 1 to: anIntegralCType size) withBlanksTrimmed readStream) > + 7 // 8] > ifFalse: [self error: 'unrecognized integral > type']]! > > Item was changed: > ----- Method: InterpreterPrimitives>>primitiveVMProfileInfoInto (in > category 'process primitives') ----- > primitiveVMProfileInfoInto > "Primitive. Answer whether the profiler is running or not. > If the argument is an Array of suitable size fill it with the > following information: > 1. the addresses of the first element of the VM histogram > (the first address in the executable) > 2. the address following the last element (the last > address in the executable, excluding dynamically linked libraries) > 3. the size of the VM histogram in bins (each bin is a 4 > byte unsigned long) > 4. the size of the VM histogram in bins (each bin is a 4 > byte unsigned long)" > | info running exeStart exeLimit vmBins easBins | > <var: #exeStart type: #'char *'> > <var: #exeLimit type: #'char *'> > <var: #vmBins type: #long> > <var: #easBins type: #long> > self success: argumentCount = 1. > self successful ifTrue: > + [info := self stackObjectValue: 0]. > + self successful ifTrue: > + [info ~= objectMemory nilObject ifTrue: > - [info := self stackObjectValue: 0. > - info ~= objectMemory nilObject ifTrue: > [self assertClassOf: info is: (objectMemory > splObj: ClassArray). > self success: (objectMemory numSlotsOf: info) >= > 4]]. > self successful ifFalse: > [^nil]. > > self cCode: > 'ioProfileStatus(&running,&exeStart,&exeLimit,0,&vmBins,0,&easBins)' > inSmalltalk: [running := exeStart := exeLimit := vmBins := > easBins := 0]. > info ~= objectMemory nilObject ifTrue: > [objectMemory storePointerUnchecked: 0 > ofObject: info > withValue: (objectMemory integerObjectOf: (self > oopForPointer: exeStart)). > objectMemory storePointerUnchecked: 1 > ofObject: info > withValue: (objectMemory integerObjectOf: (self > oopForPointer: exeLimit)). > objectMemory storePointerUnchecked: 2 > ofObject: info > withValue: (objectMemory integerObjectOf: vmBins). > objectMemory storePointerUnchecked: 3 > ofObject: info > withValue: (objectMemory integerObjectOf: > easBins)]. > self pop: 2 thenPushBool: running! > > Item was changed: > ----- Method: InterpreterPrimitives>>primitiveVMProfileSamplesInto (in > category 'process primitives') ----- > primitiveVMProfileSamplesInto > "Primitive. > 0 args: Answer whether the VM Profiler is running or not. > 1 arg: Copy the sample data into the supplied argument, which > must be a Bitmap > of suitable size. Answer the number of samples > copied into the buffer." > | sampleBuffer sampleBufferAddress running bufferSize numSamples | > <var: #bufferSize type: #long> > <var: #sampleBufferAddress type: #'unsigned long *'> > self cCode: 'ioNewProfileStatus(&running,&bufferSize)' > inSmalltalk: [running := false. bufferSize := 0]. > argumentCount = 0 ifTrue: > [^self pop: 1 thenPushBool: running]. > self success: argumentCount = 1. > self successful ifTrue: > + [sampleBuffer := self stackObjectValue: 0]. > + self successful ifTrue: > + [self assertClassOf: sampleBuffer is: (objectMemory > splObj: ClassBitmap). > - [sampleBuffer := self stackObjectValue: 0. > - self assertClassOf: sampleBuffer is: (objectMemory > splObj: ClassBitmap). > self success: (objectMemory numSlotsOf: sampleBuffer) >= > bufferSize]. > self successful ifFalse: > [^nil]. > sampleBufferAddress := objectMemory firstFixedField: sampleBuffer. > numSamples := self cCode: > 'ioNewProfileSamplesInto(sampleBufferAddress)' > inSmalltalk: > [sampleBufferAddress := sampleBufferAddress]. > self pop: argumentCount + 1 thenPushInteger: numSamples! > > Item was changed: > ----- Method: SmartSyntaxPluginTMethod>>fixUpReturnOneStmt:on: (in > category 'transforming') ----- > fixUpReturnOneStmt: stmt on: sStream > > stmt isReturn ifFalse: [^sStream nextPut: stmt]. > (stmt expression isSend > and: [#('primitiveFail' 'primitiveFailFor:') includes: stmt > expression selector]) ifTrue: > ["failure return" > sStream nextPut: stmt expression. > sStream nextPut: self nullReturnExpr. > ^nil]. > (stmt expression isVariable and: ['nil' = stmt expression name]) > ifTrue: > ["^ nil -- this is never right unless automatically > generated" > sStream nextPut: stmt. > ^nil]. > (stmt expression isVariable and: ['self' = stmt expression name]) > ifTrue: > ["^ self" > self generateFailureGuardOn: sStream. > fullArgs isEmpty ifFalse:[ sStream nextPut: (self > popExpr: fullArgs size)]. > sStream nextPut: self nullReturnExpr. > ^nil]. > (stmt expression isVariable | stmt expression isConstant | > suppressingFailureGuards) ifTrue: > ["^ variable or ^ constant or ^ expr without guardchecking" > self generateFailureGuardOn: sStream. > sStream nextPut: (self pop: fullArgs size + 1 > thenReturnExpr: stmt expression). > sStream nextPut: self nullReturnExpr. > ^nil]. > "^ expr with guardchecking" > + self generateFailureGuardOn: sStream. > sStream nextPut: (self assign: (self oopVariable: '_return_value') > expression: stmt expression). > self generateFailureGuardOn: sStream. > sStream nextPut: (self pop: fullArgs size + 1 thenReturnExpr: > (self oopVariable: '_return_value')). > sStream nextPut: self nullReturnExpr > ! > >

1 0

VM Maker: VMMaker.oscog-nice.1713.mcz
by commits＠source.squeak.org 05 Mar '16

05 Mar '16

Nicolas Cellier uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-nice.1713.mcz ==================== Summary ==================== Name: VMMaker.oscog-nice.1713 Author: nice Time: 5 March 2016, 3:15:22.817 am UUID: ac270981-d3ba-4c42-a2b1-3a83693776be Ancestors: VMMaker.oscog-nice.1712 The size of [unsigned] long long was not infered... VM fool proofing: Fix a missing guard in SmartSyntaxPlugin like explained at http://forum.world.st/VM-safety-missing-failing-guards-in-SmartSyntaxPlugin… Fix two missing guards in VM profiling primitives: one should not use the result of stackObjectValue: before checking for success, otherwise a null pointer exception will occur in case of failure. =============== Diff against VMMaker.oscog-nice.1712 =============== Item was changed: ----- Method: CCodeGenerator>>sizeOfIntegralCType: (in category 'inlining') ----- sizeOfIntegralCType: anIntegralCType "<String>" "N.B. Only works for values for which isIntegralCType: answers true." | prunedCType index | (anIntegralCType beginsWith: 'register ') ifTrue: [^self sizeOfIntegralCType: (anIntegralCType allButFirst: 9)]. prunedCType := (anIntegralCType beginsWith: 'unsigned ') ifTrue: [(anIntegralCType allButFirst: 9) withBlanksTrimmed] ifFalse: [(anIntegralCType beginsWith: 'signed ') ifTrue: [(anIntegralCType allButFirst: 7) withBlanksTrimmed] ifFalse: [anIntegralCType]]. ^prunedCType asString caseOf: { ['sqLong'] -> [8]. ['usqLong'] -> [8]. + ['long long'] -> [8]. ['sqInt'] -> [BytesPerWord]. ['usqInt'] -> [BytesPerWord]. ['int'] -> [4]. ['short'] -> [2]. ['short int'] -> [2]. ['char'] -> [1]. ['long'] -> [BytesPerWord]. ['size_t'] -> [BytesPerWord]. ['pid_t'] -> [BytesPerWord]. } otherwise: [((anIntegralCType beginsWith: 'unsigned') "e.g. 'unsigned : 8'" and: [(anIntegralCType includesAnyOf: '[*]') not and: [(index := anIntegralCType indexOf: $:) > 0]]) ifTrue: [(Integer readFrom: (anIntegralCType copyFrom: index + 1 to: anIntegralCType size) withBlanksTrimmed readStream) + 7 // 8] ifFalse: [self error: 'unrecognized integral type']]! Item was changed: ----- Method: InterpreterPrimitives>>primitiveVMProfileInfoInto (in category 'process primitives') ----- primitiveVMProfileInfoInto "Primitive. Answer whether the profiler is running or not. If the argument is an Array of suitable size fill it with the following information: 1. the addresses of the first element of the VM histogram (the first address in the executable) 2. the address following the last element (the last address in the executable, excluding dynamically linked libraries) 3. the size of the VM histogram in bins (each bin is a 4 byte unsigned long) 4. the size of the VM histogram in bins (each bin is a 4 byte unsigned long)" | info running exeStart exeLimit vmBins easBins | <var: #exeStart type: #'char *'> <var: #exeLimit type: #'char *'> <var: #vmBins type: #long> <var: #easBins type: #long> self success: argumentCount = 1. self successful ifTrue: + [info := self stackObjectValue: 0]. + self successful ifTrue: + [info ~= objectMemory nilObject ifTrue: - [info := self stackObjectValue: 0. - info ~= objectMemory nilObject ifTrue: [self assertClassOf: info is: (objectMemory splObj: ClassArray). self success: (objectMemory numSlotsOf: info) >= 4]]. self successful ifFalse: [^nil]. self cCode: 'ioProfileStatus(&running,&exeStart,&exeLimit,0,&vmBins,0,&easBins)' inSmalltalk: [running := exeStart := exeLimit := vmBins := easBins := 0]. info ~= objectMemory nilObject ifTrue: [objectMemory storePointerUnchecked: 0 ofObject: info withValue: (objectMemory integerObjectOf: (self oopForPointer: exeStart)). objectMemory storePointerUnchecked: 1 ofObject: info withValue: (objectMemory integerObjectOf: (self oopForPointer: exeLimit)). objectMemory storePointerUnchecked: 2 ofObject: info withValue: (objectMemory integerObjectOf: vmBins). objectMemory storePointerUnchecked: 3 ofObject: info withValue: (objectMemory integerObjectOf: easBins)]. self pop: 2 thenPushBool: running! Item was changed: ----- Method: InterpreterPrimitives>>primitiveVMProfileSamplesInto (in category 'process primitives') ----- primitiveVMProfileSamplesInto "Primitive. 0 args: Answer whether the VM Profiler is running or not. 1 arg: Copy the sample data into the supplied argument, which must be a Bitmap of suitable size. Answer the number of samples copied into the buffer." | sampleBuffer sampleBufferAddress running bufferSize numSamples | <var: #bufferSize type: #long> <var: #sampleBufferAddress type: #'unsigned long *'> self cCode: 'ioNewProfileStatus(&running,&bufferSize)' inSmalltalk: [running := false. bufferSize := 0]. argumentCount = 0 ifTrue: [^self pop: 1 thenPushBool: running]. self success: argumentCount = 1. self successful ifTrue: + [sampleBuffer := self stackObjectValue: 0]. + self successful ifTrue: + [self assertClassOf: sampleBuffer is: (objectMemory splObj: ClassBitmap). - [sampleBuffer := self stackObjectValue: 0. - self assertClassOf: sampleBuffer is: (objectMemory splObj: ClassBitmap). self success: (objectMemory numSlotsOf: sampleBuffer) >= bufferSize]. self successful ifFalse: [^nil]. sampleBufferAddress := objectMemory firstFixedField: sampleBuffer. numSamples := self cCode: 'ioNewProfileSamplesInto(sampleBufferAddress)' inSmalltalk: [sampleBufferAddress := sampleBufferAddress]. self pop: argumentCount + 1 thenPushInteger: numSamples! Item was changed: ----- Method: SmartSyntaxPluginTMethod>>fixUpReturnOneStmt:on: (in category 'transforming') ----- fixUpReturnOneStmt: stmt on: sStream stmt isReturn ifFalse: [^sStream nextPut: stmt]. (stmt expression isSend and: [#('primitiveFail' 'primitiveFailFor:') includes: stmt expression selector]) ifTrue: ["failure return" sStream nextPut: stmt expression. sStream nextPut: self nullReturnExpr. ^nil]. (stmt expression isVariable and: ['nil' = stmt expression name]) ifTrue: ["^ nil -- this is never right unless automatically generated" sStream nextPut: stmt. ^nil]. (stmt expression isVariable and: ['self' = stmt expression name]) ifTrue: ["^ self" self generateFailureGuardOn: sStream. fullArgs isEmpty ifFalse:[ sStream nextPut: (self popExpr: fullArgs size)]. sStream nextPut: self nullReturnExpr. ^nil]. (stmt expression isVariable | stmt expression isConstant | suppressingFailureGuards) ifTrue: ["^ variable or ^ constant or ^ expr without guardchecking" self generateFailureGuardOn: sStream. sStream nextPut: (self pop: fullArgs size + 1 thenReturnExpr: stmt expression). sStream nextPut: self nullReturnExpr. ^nil]. "^ expr with guardchecking" + self generateFailureGuardOn: sStream. sStream nextPut: (self assign: (self oopVariable: '_return_value') expression: stmt expression). self generateFailureGuardOn: sStream. sStream nextPut: (self pop: fullArgs size + 1 thenReturnExpr: (self oopVariable: '_return_value')). sStream nextPut: self nullReturnExpr !

1 0

VM Maker: VMMaker.oscog-nice.1712.mcz
by commits＠source.squeak.org 05 Mar '16

05 Mar '16

Nicolas Cellier uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-nice.1712.mcz ==================== Summary ==================== Name: VMMaker.oscog-nice.1712 Author: nice Time: 5 March 2016, 2:32:35.84 am UUID: 5c7fb203-b18c-4143-a2b9-cd59c2acc47c Ancestors: VMMaker.oscog-nice.1711 Make the MacMenubarPlugin 64bits aware: the menuHandle does not necessarily fit on a 32bits int. =============== Diff against VMMaker.oscog-nice.1711 =============== Item was changed: ----- Method: MacMenubarPlugin>>primitiveAppendMenu:data: (in category 'system primitives') ----- primitiveAppendMenu: menuHandleOop data: str255 | menuHandle constStr255 | self primitive: 'primitiveAppendMenu' parameters: #(Oop ByteArray). self var: 'menuHandle' type: 'MenuHandle'. self var: 'constStr255' type: 'ConstStr255Param'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. constStr255 := self cCoerce: str255 to: 'ConstStr255Param'. self cCode: 'AppendMenu(menuHandle,constStr255)' inSmalltalk:[menuHandle]. ^nil! Item was changed: ----- Method: MacMenubarPlugin>>primitiveAppendMenuItemText:data: (in category 'system primitives') ----- primitiveAppendMenuItemText: menuHandleOop data: str255 | menuHandle constStr255 | self primitive: 'primitiveAppendMenuItemText' parameters: #(Oop ByteArray). self var: 'menuHandle' type: 'MenuHandle'. self var: 'constStr255' type: 'ConstStr255Param'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. constStr255 := self cCoerce: str255 to: 'ConstStr255Param'. self cCode: 'AppendMenuItemText(menuHandle,constStr255)' inSmalltalk:[menuHandle]. ^nil! Item was changed: ----- Method: MacMenubarPlugin>>primitiveCheckMenuItem:item:checked: (in category 'system primitives') ----- primitiveCheckMenuItem: menuHandleOop item: anInteger checked: aBoolean | menuHandle | self primitive: 'primitiveCheckMenuItem' parameters: #(Oop SmallInteger Boolean). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'CheckMenuItem(menuHandle,anInteger,aBoolean)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveCountMenuItems: (in category 'system primitives') ----- primitiveCountMenuItems: menuHandleOop | menuHandle returnValue | self primitive: 'primitiveCountMenuItems' parameters: #(Oop). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. returnValue := self cCode: 'CountMenuItems(menuHandle)' inSmalltalk:[0]. ^returnValue asSmallIntegerObj ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveCreateStandardWindowMenu: (in category 'system primitives') ----- primitiveCreateStandardWindowMenu: inOptions | menuHandle result | self primitive: 'primitiveCreateStandardWindowMenu' parameters: #(SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. self cCode: '#if TARGET_API_MAC_CARBON '. result := self cCode: 'CreateStandardWindowMenu(inOptions,&menuHandle); #endif' inSmalltalk:[0]. + ^interpreterProxy positiveMachineIntegerFor: (self cCoerce: menuHandle to: 'long')! - ^interpreterProxy positive32BitIntegerFor: (self cCoerce: menuHandle to: 'long')! Item was changed: ----- Method: MacMenubarPlugin>>primitiveDeleteMenuItem:item: (in category 'system primitives') ----- primitiveDeleteMenuItem: menuHandleOop item: anInteger | menuHandle | self primitive: 'primitiveDeleteMenuItem' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'DeleteMenuItem(menuHandle,anInteger)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveDisableMenuCommand:item: (in category 'system primitives') ----- primitiveDisableMenuCommand: menuHandleOop item: anInteger | menuHandle commandID | self primitive: 'primitiveDisableMenuCommand' parameters: #(Oop Oop). self var: 'menuHandle' type: 'MenuHandle'. self var: 'commandID' type: 'MenuCommand'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. commandID := self cCoerce: (interpreterProxy positive32BitValueOf: anInteger) to: 'MenuCommand'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: '#if TARGET_API_MAC_CARBON DisableMenuCommand(menuHandle,commandID); #endif' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveDisableMenuItem:item: (in category 'system primitives') ----- primitiveDisableMenuItem: menuHandleOop item: anInteger | menuHandle | self primitive: 'primitiveDisableMenuItem' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'DisableMenuItem(menuHandle,anInteger)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveDisableMenuItemIcon:item: (in category 'system primitives') ----- primitiveDisableMenuItemIcon: menuHandleOop item: anInteger | menuHandle | self primitive: 'primitiveDisableMenuItemIcon' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'DisableMenuItemIcon(menuHandle,anInteger)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveDisposeMenu: (in category 'system primitives') ----- primitiveDisposeMenu: menuHandleOop | menuHandle | self primitive: 'primitiveDisposeMenu' parameters: #(Oop). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'DisposeMenu(menuHandle)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveEnableMenuCommand:item: (in category 'system primitives') ----- primitiveEnableMenuCommand: menuHandleOop item: anInteger | menuHandle commandID | self primitive: 'primitiveEnableMenuCommand' parameters: #(Oop Oop). self var: 'menuHandle' type: 'MenuHandle'. self var: 'commandID' type: 'MenuCommand'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. commandID := self cCoerce: (interpreterProxy positive32BitValueOf: anInteger) to: 'MenuCommand'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: '#if TARGET_API_MAC_CARBON EnableMenuCommand(menuHandle,commandID); #endif' inSmalltalk:[menuHandle]. ^nil! Item was changed: ----- Method: MacMenubarPlugin>>primitiveEnableMenuItem:item: (in category 'system primitives') ----- primitiveEnableMenuItem: menuHandleOop item: anInteger | menuHandle | self primitive: 'primitiveEnableMenuItem' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'EnableMenuItem(menuHandle,anInteger)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveEnableMenuItemIcon:item: (in category 'system primitives') ----- primitiveEnableMenuItemIcon: menuHandleOop item: anInteger | menuHandle | self primitive: 'primitiveEnableMenuItemIcon' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'EnableMenuItemIcon(menuHandle,anInteger)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetIndMenuItemWithCommandID:commandID: (in category 'system primitives') ----- primitiveGetIndMenuItemWithCommandID: menuHandleOop commandID: aCommandID | menuHandle MenuItemIndex commandID applicationMenu outIndex | self primitive: 'primitiveGetIndMenuItemWithCommandID' parameters: #(Oop Oop). self var: 'menuHandle' type: 'MenuHandle'. self var: 'commandID' type: 'MenuCommand'. self var: 'applicationMenu' type: 'MenuHandle'. self var: 'outIndex' type: 'MenuItemIndex'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. commandID := self cCoerce: (interpreterProxy positive32BitValueOf: aCommandID) to: 'MenuCommand'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: '#if TARGET_API_MAC_CARBON GetIndMenuItemWithCommandID(menuHandle, kHICommandHide, 1, &applicationMenu, &outIndex); #endif' inSmalltalk:[menuHandle]. ^outIndex asSmallIntegerObj ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetIndMenuWithCommandID:commandID: (in category 'system primitives') ----- primitiveGetIndMenuWithCommandID: menuHandleOop commandID: aCommandID + | menuHandle commandID applicationMenu outIndex | - | menuHandle MenuItemIndex commandID applicationMenu outIndex | self primitive: 'primitiveGetIndMenuWithCommandID' parameters: #(Oop Oop). self var: 'menuHandle' type: 'MenuHandle'. self var: 'commandID' type: 'MenuCommand'. self var: 'applicationMenu' type: 'MenuHandle'. self var: 'outIndex' type: 'MenuItemIndex'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. commandID := self cCoerce: (interpreterProxy positive32BitValueOf: aCommandID) to: 'MenuCommand'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: '#if TARGET_API_MAC_CARBON GetIndMenuItemWithCommandID(menuHandle, kHICommandHide, 1, &applicationMenu, &outIndex); #endif ' inSmalltalk:[menuHandle]. + outIndex asSmallIntegerObj. "to avoid elimination of the variable..." + ^interpreterProxy positiveMachineIntegerFor: (self cCoerce: applicationMenu to: 'long') - ^interpreterProxy positive32BitIntegerFor: (self cCoerce: applicationMenu to: 'long') ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetItemCmd:item: (in category 'system primitives') ----- primitiveGetItemCmd: menuHandleOop item: anInteger | menuHandle aCharacter | <var: 'menuHandle' type: 'MenuHandle'> <var: #aCharacter type: 'CharParameter'> self primitive: 'primitiveGetItemCmd' parameters: #(Oop SmallInteger). + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. aCharacter := 0. self cCode: 'GetItemCmd(menuHandle,anInteger,&aCharacter)' inSmalltalk:[menuHandle]. ^aCharacter asSmallIntegerObj ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetItemIcon:item: (in category 'system primitives') ----- primitiveGetItemIcon: menuHandleOop item: anInteger | menuHandle iconIndex | self primitive: 'primitiveGetItemIcon' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. self var: 'iconIndex' type: 'short'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. iconIndex := 0. self cCode: 'GetItemIcon(menuHandle,anInteger,&iconIndex)' inSmalltalk:[menuHandle]. ^iconIndex asSmallIntegerObj ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetItemMark:item: (in category 'system primitives') ----- primitiveGetItemMark: menuHandleOop item: anInteger | menuHandle aCharacter | <var: 'menuHandle' type: 'MenuHandle'> <var: #aCharacter type: 'CharParameter'> self primitive: 'primitiveGetItemMark' parameters: #(Oop SmallInteger). + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. aCharacter := 0. self cCode: 'GetItemMark(menuHandle,anInteger,&aCharacter)' inSmalltalk:[menuHandle]. ^aCharacter asSmallIntegerObj ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetItemStyle:item: (in category 'system primitives') ----- primitiveGetItemStyle: menuHandleOop item: anInteger | menuHandle chStyle | self primitive: 'primitiveGetItemStyle' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. self var: 'chStyle' type: 'Style'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. chStyle := 0. self cCode: 'GetItemStyle(menuHandle,anInteger,&chStyle)' inSmalltalk:[menuHandle]. ^chStyle asSmallIntegerObj ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetMenuBar (in category 'system primitives') ----- primitiveGetMenuBar | menuHandle | self primitive: 'primitiveGetMenuBar' parameters: #(). self var: 'menuHandle' type: 'Handle'. menuHandle := self cCode: 'GetMenuBar()' inSmalltalk:[0]. + ^interpreterProxy positiveMachineIntegerFor: (self cCoerce: menuHandle to: 'long')! - ^interpreterProxy positive32BitIntegerFor: (self cCoerce: menuHandle to: 'long')! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetMenuHandle: (in category 'system primitives') ----- primitiveGetMenuHandle: menuID | menuHandle | self primitive: 'primitiveGetMenuHandle' parameters: #(SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. self var: 'menuID' type: 'MenuID'. menuHandle := self cCode: 'GetMenuHandle(menuID)' inSmalltalk:[0]. + ^interpreterProxy positiveMachineIntegerFor: (self cCoerce: menuHandle to: 'long')! - ^interpreterProxy positive32BitIntegerFor: (self cCoerce: menuHandle to: 'long')! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetMenuID: (in category 'system primitives') ----- primitiveGetMenuID: menuHandleOop | menuHandle menuID | self primitive: 'primitiveGetMenuID' parameters: #(Oop ). self var: 'menuHandle' type: 'MenuHandle'. self var: 'menuID' type: 'MenuID'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'menuID = GetMenuID(menuHandle)' inSmalltalk:[menuHandle]. ^menuID asSmallIntegerObj ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetMenuItemCommandID:item: (in category 'system primitives') ----- primitiveGetMenuItemCommandID: menuHandleOop item: anInteger | menuHandle outCommandID | self primitive: 'primitiveGetMenuItemCommandID' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. self var: 'outCommandID' type: 'MenuCommand'. outCommandID := 0. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'GetMenuItemCommandID(menuHandle,anInteger,&outCommandID)' inSmalltalk:[menuHandle]. ^interpreterProxy positive32BitIntegerFor: outCommandID ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetMenuItemFontID:item: (in category 'system primitives') ----- primitiveGetMenuItemFontID: menuHandleOop item: anInteger | menuHandle outFontID | self primitive: 'primitiveGetMenuItemFontID' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. self var: 'outFontID' type: 'SInt16'. outFontID := 0. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'GetMenuItemFontID(menuHandle,anInteger,&outFontID)' inSmalltalk:[menuHandle]. ^outFontID asSmallIntegerObj ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetMenuItemHierarchicalID:item: (in category 'system primitives') ----- primitiveGetMenuItemHierarchicalID: menuHandleOop item: anInteger | menuHandle outHierID | self primitive: 'primitiveGetMenuItemHierarchicalID' parameters: #(Oop SmallInteger ). self var: 'menuHandle' type: 'MenuHandle'. self var: 'outHierID' type: 'MenuID'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. outHierID := 0. self cCode: 'GetMenuItemHierarchicalID(menuHandle,anInteger,&outHierID)' inSmalltalk:[menuHandle]. ^outHierID asSmallIntegerObj ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetMenuItemKeyGlyph:item: (in category 'system primitives') ----- primitiveGetMenuItemKeyGlyph: menuHandleOop item: anInteger | menuHandle outGlyph | self primitive: 'primitiveGetMenuItemKeyGlyph' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. self var: 'outGlyph' type: 'SInt16'. outGlyph := 0. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'GetMenuItemKeyGlyph(menuHandle,anInteger,&outGlyph)' inSmalltalk:[menuHandle]. ^interpreterProxy positive32BitIntegerFor: outGlyph ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetMenuItemModifiers:item: (in category 'system primitives') ----- primitiveGetMenuItemModifiers: menuHandleOop item: anInteger | menuHandle outModifers | self primitive: 'primitiveGetMenuItemModifiers' parameters: #(Oop SmallInteger ). self var: 'menuHandle' type: 'MenuHandle'. self var: 'outModifers' type: 'Style'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. outModifers := 0. self cCode: 'GetMenuItemModifiers(menuHandle,anInteger,&outModifers)' inSmalltalk:[menuHandle]. ^outModifers asSmallIntegerObj ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetMenuItemText:item: (in category 'system primitives') ----- primitiveGetMenuItemText: menuHandleOop item: anInteger | menuHandle size oop ptr aString | <var: 'menuHandle' type: 'MenuHandle'> <var: #aString type: 'Str255 '> <var: #ptr type: 'char *'> self primitive: 'primitiveGetMenuItemText' parameters: #(Oop SmallInteger). + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. aString at: 0 put: 0. self cCode: 'GetMenuItemText(menuHandle,anInteger,aString)' inSmalltalk:[menuHandle]. size := self cCode: 'aString[0]' inSmalltalk: [0]. oop := interpreterProxy instantiateClass: interpreterProxy classString indexableSize: size. ptr := interpreterProxy firstIndexableField: oop. 0 to: size-1 do:[:i| ptr at: i put: (aString at: (i+1))]. ^oop ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetMenuItemTextEncoding:item: (in category 'system primitives') ----- primitiveGetMenuItemTextEncoding: menuHandleOop item: anInteger | menuHandle outScriptID | self primitive: 'primitiveGetMenuItemTextEncoding' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. self var: 'outScriptID' type: 'TextEncoding'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'GetMenuItemTextEncoding(menuHandle,anInteger,&outScriptID)' inSmalltalk:[menuHandle]. ^interpreterProxy positive32BitIntegerFor: outScriptID! Item was changed: ----- Method: MacMenubarPlugin>>primitiveGetMenuTitle: (in category 'system primitives') ----- primitiveGetMenuTitle: menuHandleOop | menuHandle size oop ptr aString | <var: 'menuHandle' type: 'MenuHandle'> <var: #aString type: 'Str255 '> <var: #ptr type: 'char *'> self primitive: 'primitiveGetMenuTitle' parameters: #(Oop). + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. aString at: 0 put: 0. self cCode: 'GetMenuTitle(menuHandle,aString)' inSmalltalk:[menuHandle]. size := self cCode: 'aString[0]' inSmalltalk: [0]. oop := interpreterProxy instantiateClass: interpreterProxy classString indexableSize: size. ptr := interpreterProxy firstIndexableField: oop. 0 to: size-1 do:[:i| ptr at: i put: (aString at: (i+1))]. ^oop ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveInsertFontResMenu:afterItem:scriptFilter: (in category 'system primitives') ----- primitiveInsertFontResMenu: menuHandleOop afterItem: afterItemInteger scriptFilter: scriptFilterInteger | menuHandle | self primitive: 'primitiveInsertFontResMenu' parameters: #(Oop SmallInteger SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'InsertFontResMenu(menuHandle,afterItemInteger,scriptFilterInteger)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveInsertIntlResMenu:theType:afterItem:scriptFilter: (in category 'system primitives') ----- primitiveInsertIntlResMenu: menuHandleOop theType: aResType afterItem: afterItemInteger scriptFilter: scriptFilterInteger | menuHandle resType | self primitive: 'primitiveInsertIntlResMenu' parameters: #(Oop SmallInteger SmallInteger SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. self var: 'resType' type: 'ResType'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. resType := self cCoerce: (interpreterProxy positive32BitValueOf: aResType) to: 'ResType'. self cCode: 'InsertIntlResMenu(menuHandle,resType,afterItemInteger,scriptFilterInteger)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveInsertMenu:beforeID: (in category 'system primitives') ----- primitiveInsertMenu: menuHandleOop beforeID: anInteger | menuHandle | self primitive: 'primitiveInsertMenu' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. self var: 'anInteger' type: 'MenuID'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'InsertMenu(menuHandle,anInteger)' inSmalltalk:[menuHandle]. ^nil! Item was changed: ----- Method: MacMenubarPlugin>>primitiveInsertMenuItem:itemString:afterItem: (in category 'system primitives') ----- primitiveInsertMenuItem: menuHandleOop itemString: str255 afterItem: anInteger | menuHandle constStr255 | self primitive: 'primitiveInsertMenuItem' parameters: #(Oop ByteArray SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. self var: 'constStr255' type: 'ConstStr255Param'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. constStr255 := self cCoerce: str255 to: 'ConstStr255Param'. self cCode: 'InsertMenuItem(menuHandle,constStr255,anInteger)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveIsMenuItemEnabled:item: (in category 'system primitives') ----- primitiveIsMenuItemEnabled: menuHandleOop item: anInteger | menuHandle result | self primitive: 'primitiveIsMenuItemEnabled' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. result := self cCode: 'IsMenuItemEnabled(menuHandle,anInteger)' inSmalltalk:[0]. ^result asOop: Boolean! Item was changed: ----- Method: MacMenubarPlugin>>primitiveIsMenuItemIconEnabled:item: (in category 'system primitives') ----- primitiveIsMenuItemIconEnabled: menuHandleOop item: anInteger | menuHandle result | self primitive: 'primitiveIsMenuItemIconEnabled' parameters: #(Oop SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. result := self cCode: 'IsMenuItemIconEnabled(menuHandle,anInteger)' inSmalltalk:[0]. ^result asOop: Boolean! Item was changed: ----- Method: MacMenubarPlugin>>primitiveNewMenu:menuTitle: (in category 'system primitives') ----- primitiveNewMenu: menuID menuTitle: menuTitle | menuHandle constStr255 | self primitive: 'primitiveNewMenu' parameters: #(SmallInteger ByteArray). self var: 'menuHandle' type: 'MenuHandle'. self var: 'constStr255' type: 'ConstStr255Param'. self var: 'menuID' type: 'MenuID'. constStr255 := self cCoerce: menuTitle to: 'ConstStr255Param'. menuHandle := self cCode: 'NewMenu(menuID,constStr255)' inSmalltalk:[0]. + ^interpreterProxy positiveMachineIntegerFor: (self cCoerce: menuHandle to: 'long')! - ^interpreterProxy positive32BitIntegerFor: (self cCoerce: menuHandle to: 'long')! Item was changed: ----- Method: MacMenubarPlugin>>primitiveSetItemCmd:item:cmdChar: (in category 'system primitives') ----- primitiveSetItemCmd: menuHandleOop item: anInteger cmdChar: anIntegerCmdChar | menuHandle aCharacter | <var: 'menuHandle' type: 'MenuHandle'> <var: #aCharacter type: 'CharParameter '> self primitive: 'primitiveSetItemCmd' parameters: #(Oop SmallInteger SmallInteger). + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. aCharacter := anIntegerCmdChar. self cCode: 'SetItemCmd(menuHandle,anInteger,aCharacter)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveSetItemIcon:item:iconIndex: (in category 'system primitives') ----- primitiveSetItemIcon: menuHandleOop item: anInteger iconIndex: aIconIndexInteger | menuHandle | self primitive: 'primitiveSetItemIcon' parameters: #(Oop SmallInteger SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'SetItemIcon(menuHandle,anInteger,aIconIndexInteger)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveSetItemMark:item:markChar: (in category 'system primitives') ----- primitiveSetItemMark: menuHandleOop item: anInteger markChar: aMarkChar | menuHandle aCharacter | <var: 'menuHandle' type: 'MenuHandle'> <var: #aCharacter type: 'CharParameter '> self primitive: 'primitiveSetItemMark' parameters: #(Oop SmallInteger SmallInteger). + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. aCharacter := aMarkChar. self cCode: 'SetItemMark(menuHandle,anInteger,aCharacter)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveSetItemStyle:item:styleParameter: (in category 'system primitives') ----- primitiveSetItemStyle: menuHandleOop item: anInteger styleParameter: chStyleInteger | menuHandle | self primitive: 'primitiveSetItemStyle' parameters: #(Oop SmallInteger SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'SetItemStyle(menuHandle,anInteger,chStyleInteger)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveSetMenuBar: (in category 'system primitives') ----- primitiveSetMenuBar: menuHandleOop | menuBarHandle | self primitive: 'primitiveSetMenuBar' parameters: #(Oop). self var: 'menuBarHandle' type: 'MenuBarHandle'. + menuBarHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuBarHandle'. - menuBarHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuBarHandle'. self cCode: 'SetMenuBar(menuBarHandle)' inSmalltalk:[menuBarHandle]. ^nil! Item was changed: ----- Method: MacMenubarPlugin>>primitiveSetMenuItemCommandID:item:menuCommand: (in category 'system primitives') ----- primitiveSetMenuItemCommandID: menuHandleOop item: anInteger menuCommand: inCommandID | menuHandle commandID | self primitive: 'primitiveSetMenuItemCommandID' parameters: #(Oop SmallInteger Oop). self var: 'menuHandle' type: 'MenuHandle'. self var: 'commandID' type: 'MenuCommand'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. commandID := self cCoerce: (interpreterProxy positive32BitValueOf: inCommandID) to: 'MenuCommand'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'SetMenuItemCommandID(menuHandle,anInteger,commandID)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveSetMenuItemFontID:item:fontID: (in category 'system primitives') ----- primitiveSetMenuItemFontID: menuHandleOop item: anInteger fontID: aFontIDInteger | menuHandle | self primitive: 'primitiveSetMenuItemFontID' parameters: #(Oop SmallInteger SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'SetMenuItemFontID(menuHandle,anInteger,aFontIDInteger)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveSetMenuItemHierarchicalID:item:hierID: (in category 'system primitives') ----- primitiveSetMenuItemHierarchicalID: menuHandleOop item: anInteger hierID: aMenuID | menuHandle | self primitive: 'primitiveSetMenuItemHierarchicalID' parameters: #(Oop SmallInteger SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. self var: 'menuID' type: 'MenuID'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'SetMenuItemHierarchicalID(menuHandle,anInteger,aMenuID)' inSmalltalk:[menuHandle]. ^nil! Item was changed: ----- Method: MacMenubarPlugin>>primitiveSetMenuItemKeyGlyph:item:glyph: (in category 'system primitives') ----- primitiveSetMenuItemKeyGlyph: menuHandleOop item: anInteger glyph: inGlyphInteger | menuHandle | self primitive: 'primitiveSetMenuItemKeyGlyph' parameters: #(Oop SmallInteger SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'SetMenuItemKeyGlyph(menuHandle,anInteger,inGlyphInteger)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveSetMenuItemModifiers:item:inModifiers: (in category 'system primitives') ----- primitiveSetMenuItemModifiers: menuHandleOop item: anInteger inModifiers: aUInt8 | menuHandle | self primitive: 'primitiveSetMenuItemModifiers' parameters: #(Oop SmallInteger SmallInteger). self var: 'menuHandle' type: 'MenuHandle'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. self cCode: 'SetMenuItemModifiers(menuHandle,anInteger,aUInt8)' inSmalltalk:[menuHandle]. ^nil! Item was changed: ----- Method: MacMenubarPlugin>>primitiveSetMenuItemText:item:itemString: (in category 'system primitives') ----- primitiveSetMenuItemText: menuHandleOop item: anInteger itemString: str255 | menuHandle constStr255 | self primitive: 'primitiveSetMenuItemText' parameters: #(Oop SmallInteger ByteArray). self var: 'menuHandle' type: 'MenuHandle'. self var: 'constStr255' type: 'ConstStr255Param'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. constStr255 := self cCoerce: str255 to: 'ConstStr255Param'. self cCode: 'SetMenuItemText(menuHandle,anInteger,constStr255)' inSmalltalk:[menuHandle]. ^nil ! Item was changed: ----- Method: MacMenubarPlugin>>primitiveSetMenuItemTextEncoding:item:inScriptID: (in category 'system primitives') ----- primitiveSetMenuItemTextEncoding: menuHandleOop item: anInteger inScriptID: aTextEncodingOop | menuHandle inScriptID | self primitive: 'primitiveSetMenuItemTextEncoding' parameters: #(Oop SmallInteger Oop). self var: 'menuHandle' type: 'MenuHandle'. self var: 'inScriptID' type: 'TextEncoding'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. inScriptID := self cCoerce: (interpreterProxy positive32BitValueOf: aTextEncodingOop) to: 'TextEncoding'. self cCode: 'SetMenuItemTextEncoding(menuHandle,anInteger,inScriptID)' inSmalltalk:[menuHandle]. ^nil! Item was changed: ----- Method: MacMenubarPlugin>>primitiveSetMenuTitle:title: (in category 'system primitives') ----- primitiveSetMenuTitle: menuHandleOop title: str255 | menuHandle constStr255 | self primitive: 'primitiveSetMenuTitle' parameters: #(Oop ByteArray). self var: 'menuHandle' type: 'MenuHandle'. self var: 'constStr255' type: 'ConstStr255Param'. + menuHandle := self cCoerce: (interpreterProxy positiveMachineIntegerValueOf: menuHandleOop) to: 'MenuHandle'. - menuHandle := self cCoerce: (interpreterProxy positive32BitValueOf: menuHandleOop) to: 'MenuHandle'. (self ioCheckMenuHandle: menuHandle) ifFalse: [^interpreterProxy success: false]. constStr255 := self cCoerce: str255 to: 'ConstStr255Param'. self cCode: 'SetMenuTitle(menuHandle,constStr255)' inSmalltalk:[menuHandle]. ^nil !

1 0

Re: [Vm-dev] VM Maker: VMMaker.oscog-nice.1711.mcz
by Eliot Miranda 05 Mar '16

05 Mar '16

Thanks Nicolas! And great that you found slips. The more eyes the merrier. On Fri, Mar 4, 2016 at 5:24 PM, <commits(a)source.squeak.org> wrote: > > Nicolas Cellier uploaded a new version of VMMaker to project VM Maker: > http://source.squeak.org/VMMaker/VMMaker.oscog-nice.1711.mcz > > ==================== Summary ==================== > > Name: VMMaker.oscog-nice.1711 > Author: nice > Time: 5 March 2016, 2:14:57.11 am > UUID: 9e7ba417-b6ed-4263-82f2-27ec641d8f30 > Ancestors: VMMaker.oscog-eem.1709 > > 3 minor fixes for type inference: > 1) remove unecessary block argument assignment > 2) infer type of allMask: > 3) infer type of rem: instead of mod: (mod: does not exist) > > Don't use cCode: pointer aliasing for storing/fetching float/double in FFI > primitives. > Replace with a call to mem:cp:y: > - the first one is dangerous with modern C compilers > - while the second is optimized away (no call to memcpy) > > =============== Diff against VMMaker.oscog-eem.1709 =============== > > Item was changed: > ----- Method: FFIPlugin>>primitiveFFIDoubleAt (in category 'primitives') > ----- > primitiveFFIDoubleAt > "Return a (signed or unsigned) n byte integer from the given byte > offset." > | byteOffset rcvr addr floatValue | > <export: true> > <inline: false> > + <var: #floatValue type: #double> > - <var: #floatValue type:'double '> > byteOffset := interpreterProxy stackIntegerValue: 0. > rcvr := interpreterProxy stackObjectValue: 1. > interpreterProxy failed ifTrue:[^0]. > addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 8. > interpreterProxy failed ifTrue:[^0]. > + self mem: (self addressOf: floatValue) cp: addr y: (self sizeof: > floatValue). > - self cCode:'((int*)(&floatValue))[0] = ((int*)addr)[0]'. > - self cCode:'((int*)(&floatValue))[1] = ((int*)addr)[1]'. > interpreterProxy pop: 2. > ^interpreterProxy pushFloat: floatValue > ! > > Item was changed: > ----- Method: FFIPlugin>>primitiveFFIDoubleAtPut (in category > 'primitives') ----- > primitiveFFIDoubleAtPut > "Return a (signed or unsigned) n byte integer from the given byte > offset." > | byteOffset rcvr addr floatValue floatOop | > <export: true> > <inline: false> > + <var: #floatValue type: #double> > - <var: #floatValue type:'double '> > floatOop := interpreterProxy stackValue: 0. > (interpreterProxy isIntegerObject: floatOop) > ifTrue:[floatValue := self cCoerce: (interpreterProxy > integerValueOf: floatOop) to:'double'] > ifFalse:[floatValue := self cCoerce: (interpreterProxy > floatValueOf: floatOop) to:'double']. > byteOffset := interpreterProxy stackIntegerValue: 1. > rcvr := interpreterProxy stackObjectValue: 2. > interpreterProxy failed ifTrue:[^0]. > addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 8. > interpreterProxy failed ifTrue:[^0]. > + self mem: addr cp: (self addressOf: floatValue) y: (self sizeof: > floatValue). > - self cCode:'((int*)addr)[0] = ((int*)(&floatValue))[0]'. > - self cCode:'((int*)addr)[1] = ((int*)(&floatValue))[1]'. > interpreterProxy pop: 3. > ^interpreterProxy push: floatOop! > > Item was changed: > ----- Method: FFIPlugin>>primitiveFFIFloatAt (in category 'primitives') > ----- > primitiveFFIFloatAt > "Return a (signed or unsigned) n byte integer from the given byte > offset." > | byteOffset rcvr addr floatValue | > <export: true> > <inline: false> > + <var: #floatValue type: #float> > - <var: #floatValue type:'float '> > byteOffset := interpreterProxy stackIntegerValue: 0. > rcvr := interpreterProxy stackObjectValue: 1. > interpreterProxy failed ifTrue:[^0]. > addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 4. > interpreterProxy failed ifTrue:[^0]. > + self mem: (self addressOf: floatValue) cp: addr y: (self sizeof: > floatValue). > - self cCode:'((int*)(&floatValue))[0] = ((int*)addr)[0]'. > interpreterProxy pop: 2. > ^interpreterProxy pushFloat: floatValue! > > Item was changed: > ----- Method: FFIPlugin>>primitiveFFIFloatAtPut (in category > 'primitives') ----- > primitiveFFIFloatAtPut > "Return a (signed or unsigned) n byte integer from the given byte > offset." > | byteOffset rcvr addr floatValue floatOop | > <export: true> > <inline: false> > + <var: #floatValue type: #float> > - <var: #floatValue type:'float '> > floatOop := interpreterProxy stackValue: 0. > (interpreterProxy isIntegerObject: floatOop) > ifTrue:[floatValue := self cCoerce: (interpreterProxy > integerValueOf: floatOop) to:'float'] > ifFalse:[floatValue := self cCoerce: (interpreterProxy > floatValueOf: floatOop) to:'float']. > byteOffset := interpreterProxy stackIntegerValue: 1. > rcvr := interpreterProxy stackObjectValue: 2. > interpreterProxy failed ifTrue:[^0]. > addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 4. > interpreterProxy failed ifTrue:[^0]. > + self mem: addr cp: (self addressOf: floatValue) y: (self sizeof: > floatValue). > - self cCode:'((int*)addr)[0] = ((int*)(&floatValue))[0]'. > interpreterProxy pop: 3. > ^interpreterProxy push: floatOop! > > Item was changed: > ----- Method: IA32ABIPlugin>>primDoubleAt (in category > 'primitives-accessing') ----- > primDoubleAt > "Answer the 64-bit double starting at the given byte offset > (little endian)." > "<Alien> doubleAt: index <Integer> ^<Float> > <primitive: 'primDoubleAt' error: errorCode module: > 'IA32ABI'>" > | byteOffset rcvr startAddr addr floatValue | > <export: true> > + <var: #floatValue type: #double> > - <var: #floatValue type:'double '> > > byteOffset := (interpreterProxy stackPositiveMachineIntegerValue: > 0) - 1. > rcvr := interpreterProxy stackObjectValue: 1. > interpreterProxy failed ifTrue: > [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. > (self index: byteOffset length: 8 inRange: rcvr) ifFalse: > [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. > (startAddr := self startOfData: rcvr) = 0 ifTrue: > [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. > addr := startAddr + byteOffset. > + self mem: (self addressOf: floatValue) cp: addr y: (self sizeof: > floatValue). > - self cCode:'((long *)(&floatValue))[0] = ((long *)addr)[0]; ((long > *)(&floatValue))[1] = ((long *)addr)[1]' > - inSmalltalk: [floatValue := rcvr doubleAt: byteOffset]. > interpreterProxy pop: 2. > ^interpreterProxy pushFloat: floatValue! > > Item was changed: > ----- Method: IA32ABIPlugin>>primDoubleAtPut (in category > 'primitives-accessing') ----- > primDoubleAtPut > "Store a double into 64 bits starting at the given byte offset > (little endian)." > "<Alien> doubleAt: index <Integer> put: value <Float | Integer> > ^<Float | Integer> > <primitive: 'primDoubleAtPut' error: errorCode module: > 'IA32ABI'>" > | byteOffset rcvr startAddr addr valueOop floatValue | > <export: true> > <var: #floatValue type: #double> > > valueOop := interpreterProxy stackValue: 0. > (interpreterProxy isIntegerObject: valueOop) > ifTrue:[floatValue := self cCoerce: (interpreterProxy > integerValueOf: valueOop) to: #double] > ifFalse:[floatValue := self cCoerce: (interpreterProxy > floatValueOf: valueOop) to: #double]. > byteOffset := (interpreterProxy stackPositiveMachineIntegerValue: > 1) - 1. > rcvr := interpreterProxy stackObjectValue: 2. > interpreterProxy failed ifTrue: > [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. > (self index: byteOffset length: 8 inRange: rcvr) ifFalse: > [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. > (interpreterProxy isOopImmutable: rcvr) ifTrue: > [^interpreterProxy primitiveFailFor: > PrimErrNoModification]. > (startAddr := self startOfData: rcvr) = 0 ifTrue: > [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. > addr := startAddr + byteOffset. > + self mem: addr cp: (self addressOf: floatValue) y: (self sizeof: > floatValue). > - self cCode:'((int*)addr)[0] = ((int*)(&floatValue))[0]'. > - self cCode:'((int*)addr)[1] = ((int*)(&floatValue))[1]'. > interpreterProxy methodReturnValue: valueOop! > > Item was changed: > ----- Method: IA32ABIPlugin>>primFloatAt (in category > 'primitives-accessing') ----- > primFloatAt > "Answer the 32-bit float starting at the given byte offset (little > endian)." > "<Alien> floatAt: index <Integer> ^<Float> > <primitive: 'primFloatAt' error: errorCode module: > 'IA32ABI'>" > | byteOffset rcvr startAddr addr floatValue | > <export: true> > + <var: #floatValue type: #float> > - <var: #floatValue type: 'float '> > > byteOffset := (interpreterProxy stackPositiveMachineIntegerValue: > 0) - 1. > rcvr := interpreterProxy stackObjectValue: 1. > interpreterProxy failed ifTrue: > [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. > (self index: byteOffset length: 4 inRange: rcvr) ifFalse: > [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. > (startAddr := self startOfData: rcvr) = 0 ifTrue: > [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. > addr := startAddr + byteOffset. > + self mem: (self addressOf: floatValue) cp: addr y: (self sizeof: > floatValue). > - self cCode:'((long *)(&floatValue))[0] = ((long *)addr)[0]' > - inSmalltalk: [floatValue := rcvr floatAt: byteOffset]. > interpreterProxy pop: 2. > ^interpreterProxy pushFloat: floatValue! > > Item was changed: > ----- Method: IA32ABIPlugin>>primFloatAtPut (in category > 'primitives-accessing') ----- > primFloatAtPut > "Store a float into 32 bits starting at the given byte offset > (little endian)." > "<Alien> floatAt: index <Integer> put: value <Float | Integer> > ^<Float | Integer> > <primitive: 'primFloatAtPut' error: errorCode module: > 'IA32ABI'>" > | byteOffset rcvr startAddr addr valueOop floatValue | > <export: true> > <var: #floatValue type: #float> > > valueOop := interpreterProxy stackValue: 0. > (interpreterProxy isIntegerObject: valueOop) > ifTrue:[floatValue := self cCoerce: (interpreterProxy > integerValueOf: valueOop) to: #double] > ifFalse:[floatValue := self cCoerce: (interpreterProxy > floatValueOf: valueOop) to: #double]. > byteOffset := (interpreterProxy stackPositiveMachineIntegerValue: > 1) - 1. > rcvr := interpreterProxy stackObjectValue: 2. > interpreterProxy failed ifTrue: > [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. > (self index: byteOffset length: 4 inRange: rcvr) ifFalse: > [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. > (interpreterProxy isOopImmutable: rcvr) ifTrue: > [^interpreterProxy primitiveFailFor: > PrimErrNoModification]. > (startAddr := self startOfData: rcvr) = 0 ifTrue: > [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. > addr := startAddr + byteOffset. > + self mem: addr cp: (self addressOf: floatValue) y: (self sizeof: > floatValue). > - self cCode:'((long *)addr)[0] = ((long *)(&floatValue))[0]'. > interpreterProxy methodReturnValue: valueOop! > > Item was changed: > ----- Method: TMethod>>addTypesFor:to:in: (in category 'type inference') > ----- > addTypesFor: node to: typeSet in: aCodeGen > "Add the value tupes for the node to typeSet. > Answer if any type was derived from an as-yet-untyped method, > which allows us to abort > inferReturnTypeFromReturnsIn: if the return type depends on a > yet-to-be-typed method." > | expr | > expr := node. > [expr isAssignment or: [expr isStmtList]] whileTrue: > [expr isAssignment ifTrue: > [expr := expr variable]. > expr isStmtList ifTrue: > [expr := expr statements last]]. > expr isSend ifTrue: > [(#(ifTrue: ifFalse: ifTrue:ifFalse: ifFalse:ifTrue:) > includes: expr selector) ifTrue: > [^expr args > inject: false > into: [:asYetUntyped :block| > + asYetUntyped | (self addTypesFor: > block to: typeSet in: aCodeGen)]]. > + (#(= ~= == ~~ < > <= >= anyMask: allMask: noMask:) > includes: expr selector) ifTrue: > - asYetUntyped := asYetUntyped | > (self addTypesFor: block to: typeSet in: aCodeGen)]]. > - (#(= ~= == ~~ < > <= >= anyMask: noMask:) includes: expr > selector) ifTrue: > [typeSet add: #sqInt. ^false]. > + (#(+ - * / // \\ rem: quo: bitAnd: bitClear: bitOr: > bitXor: bitShift:) includes: expr selector) ifTrue: > - (#(+ - * / // \\ mod: quo: bitAnd: bitClear: bitOr: > bitXor: bitShift:) includes: expr selector) ifTrue: > [| types | > types := Set new. > self addTypesFor: expr receiver to: types in: > aCodeGen. > (types size = 1 and: [types anyOne last = $*]) > ifTrue: "pointer arithmetic" > [typeSet add: types anyOne. ^false]. > self addTypesFor: expr args first to: types in: > aCodeGen. > types := aCodeGen harmonizeReturnTypesIn: types. > types size = 2 ifTrue: > [(types includes: #double) ifTrue: > [typeSet add: #double. ^false]. > (types includes: #float) ifTrue: > [typeSet add: #float. ^false]. > ^false]. "don't know; leave unspecified." > types notEmpty ifTrue: > [typeSet add: types anyOne]. > ^false]. > "Abort only for untyped methods that will be typed, but > don't be phased by recursion." > ^(aCodeGen returnTypeForSend: expr in: self) > ifNotNil: [:type| typeSet add: type. false] > ifNil: [(aCodeGen methodNamed: expr selector) > notNil and: [expr selector ~~ selector]]]. > expr isVariable ifTrue: > [(aCodeGen typeOfVariable: expr name) > ifNotNil: [:type| typeSet add: type] > ifNil: [typeSet add: (expr name = 'self' > > ifTrue: [#void] > > ifFalse: [#sqInt])]]. > expr isConstant ifTrue: > [| val | > val := expr value. > val isInteger ifTrue: > [typeSet add: ((val >= 0 ifTrue: [val] ifFalse: > [-1 - val]) highBit <= 32 > > ifTrue: [#sqInt] > > ifFalse: [#sqLong])]. > (#(nil true false) includes: val) ifTrue: > [typeSet add: #sqInt]. > val isFloat ifTrue: > [typeSet add: #float]]. > ^false! > > Item was changed: > ----- Method: ThreadedFFIPlugin>>primitiveFFIDoubleAt (in category > 'primitives') ----- > primitiveFFIDoubleAt > "Return a (signed or unsigned) n byte integer from the given byte > offset." > | byteOffset rcvr addr floatValue | > <export: true> > <inline: false> > + <var: #floatValue type: #double> > - <var: #floatValue type:'double '> > byteOffset := interpreterProxy stackIntegerValue: 0. > rcvr := interpreterProxy stackObjectValue: 1. > interpreterProxy failed ifTrue:[^0]. > addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 8. > interpreterProxy failed ifTrue:[^0]. > + self mem: (self addressOf: floatValue) cp: addr y: (self sizeof: > floatValue). > - self cCode:'((int*)(&floatValue))[0] = ((int*)addr)[0]'. > - self cCode:'((int*)(&floatValue))[1] = ((int*)addr)[1]'. > interpreterProxy pop: 2. > ^interpreterProxy pushFloat: floatValue > ! > > Item was changed: > ----- Method: ThreadedFFIPlugin>>primitiveFFIDoubleAtPut (in category > 'primitives') ----- > primitiveFFIDoubleAtPut > "Return a (signed or unsigned) n byte integer from the given byte > offset." > | byteOffset rcvr addr floatValue floatOop | > <export: true> > <inline: false> > + <var: #floatValue type: #double> > - <var: #floatValue type:'double '> > floatOop := interpreterProxy stackValue: 0. > (interpreterProxy isIntegerObject: floatOop) > ifTrue:[floatValue := self cCoerce: (interpreterProxy > integerValueOf: floatOop) to:'double'] > ifFalse:[floatValue := self cCoerce: (interpreterProxy > floatValueOf: floatOop) to:'double']. > byteOffset := interpreterProxy stackIntegerValue: 1. > rcvr := interpreterProxy stackObjectValue: 2. > interpreterProxy failed ifTrue:[^0]. > addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 8. > interpreterProxy failed ifTrue:[^0]. > + self mem: addr cp: (self addressOf: floatValue) y: (self sizeof: > floatValue). > - self cCode:'((int*)addr)[0] = ((int*)(&floatValue))[0]'. > - self cCode:'((int*)addr)[1] = ((int*)(&floatValue))[1]'. > ^interpreterProxy pop: 3 thenPush: floatOop! > > Item was changed: > ----- Method: ThreadedFFIPlugin>>primitiveFFIFloatAt (in category > 'primitives') ----- > primitiveFFIFloatAt > "Return a (signed or unsigned) n byte integer from the given byte > offset." > | byteOffset rcvr addr floatValue | > <export: true> > <inline: false> > + <var: #floatValue type: #float> > - <var: #floatValue type:'float '> > byteOffset := interpreterProxy stackIntegerValue: 0. > rcvr := interpreterProxy stackObjectValue: 1. > interpreterProxy failed ifTrue:[^0]. > addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 4. > interpreterProxy failed ifTrue:[^0]. > + self mem: (self addressOf: floatValue) cp: addr y: (self sizeof: > floatValue). > - self cCode:'((int*)(&floatValue))[0] = ((int*)addr)[0]'. > interpreterProxy pop: 2. > ^interpreterProxy pushFloat: floatValue! > > Item was changed: > ----- Method: ThreadedFFIPlugin>>primitiveFFIFloatAtPut (in category > 'primitives') ----- > primitiveFFIFloatAtPut > "Return a (signed or unsigned) n byte integer from the given byte > offset." > | byteOffset rcvr addr floatValue floatOop | > <export: true> > <inline: false> > + <var: #floatValue type: #float> > - <var: #floatValue type:'float '> > floatOop := interpreterProxy stackValue: 0. > (interpreterProxy isIntegerObject: floatOop) > ifTrue:[floatValue := self cCoerce: (interpreterProxy > integerValueOf: floatOop) to:'float'] > ifFalse:[floatValue := self cCoerce: (interpreterProxy > floatValueOf: floatOop) to:'float']. > byteOffset := interpreterProxy stackIntegerValue: 1. > rcvr := interpreterProxy stackObjectValue: 2. > interpreterProxy failed ifTrue:[^0]. > addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 4. > interpreterProxy failed ifTrue:[^0]. > + self mem: addr cp: (self addressOf: floatValue) y: (self sizeof: > floatValue). > - self cCode:'((int*)addr)[0] = ((int*)(&floatValue))[0]'. > ^interpreterProxy pop: 3 thenPush: floatOop! > > -- _,,,^..^,,,_ best, Eliot

1 0

VM Maker: VMMaker.oscog-nice.1711.mcz
by commits＠source.squeak.org 05 Mar '16

05 Mar '16

Nicolas Cellier uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-nice.1711.mcz ==================== Summary ==================== Name: VMMaker.oscog-nice.1711 Author: nice Time: 5 March 2016, 2:14:57.11 am UUID: 9e7ba417-b6ed-4263-82f2-27ec641d8f30 Ancestors: VMMaker.oscog-eem.1709 3 minor fixes for type inference: 1) remove unecessary block argument assignment 2) infer type of allMask: 3) infer type of rem: instead of mod: (mod: does not exist) Don't use cCode: pointer aliasing for storing/fetching float/double in FFI primitives. Replace with a call to mem:cp:y: - the first one is dangerous with modern C compilers - while the second is optimized away (no call to memcpy) =============== Diff against VMMaker.oscog-eem.1709 =============== Item was changed: ----- Method: FFIPlugin>>primitiveFFIDoubleAt (in category 'primitives') ----- primitiveFFIDoubleAt "Return a (signed or unsigned) n byte integer from the given byte offset." | byteOffset rcvr addr floatValue | <export: true> <inline: false> + <var: #floatValue type: #double> - <var: #floatValue type:'double '> byteOffset := interpreterProxy stackIntegerValue: 0. rcvr := interpreterProxy stackObjectValue: 1. interpreterProxy failed ifTrue:[^0]. addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 8. interpreterProxy failed ifTrue:[^0]. + self mem: (self addressOf: floatValue) cp: addr y: (self sizeof: floatValue). - self cCode:'((int*)(&floatValue))[0] = ((int*)addr)[0]'. - self cCode:'((int*)(&floatValue))[1] = ((int*)addr)[1]'. interpreterProxy pop: 2. ^interpreterProxy pushFloat: floatValue ! Item was changed: ----- Method: FFIPlugin>>primitiveFFIDoubleAtPut (in category 'primitives') ----- primitiveFFIDoubleAtPut "Return a (signed or unsigned) n byte integer from the given byte offset." | byteOffset rcvr addr floatValue floatOop | <export: true> <inline: false> + <var: #floatValue type: #double> - <var: #floatValue type:'double '> floatOop := interpreterProxy stackValue: 0. (interpreterProxy isIntegerObject: floatOop) ifTrue:[floatValue := self cCoerce: (interpreterProxy integerValueOf: floatOop) to:'double'] ifFalse:[floatValue := self cCoerce: (interpreterProxy floatValueOf: floatOop) to:'double']. byteOffset := interpreterProxy stackIntegerValue: 1. rcvr := interpreterProxy stackObjectValue: 2. interpreterProxy failed ifTrue:[^0]. addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 8. interpreterProxy failed ifTrue:[^0]. + self mem: addr cp: (self addressOf: floatValue) y: (self sizeof: floatValue). - self cCode:'((int*)addr)[0] = ((int*)(&floatValue))[0]'. - self cCode:'((int*)addr)[1] = ((int*)(&floatValue))[1]'. interpreterProxy pop: 3. ^interpreterProxy push: floatOop! Item was changed: ----- Method: FFIPlugin>>primitiveFFIFloatAt (in category 'primitives') ----- primitiveFFIFloatAt "Return a (signed or unsigned) n byte integer from the given byte offset." | byteOffset rcvr addr floatValue | <export: true> <inline: false> + <var: #floatValue type: #float> - <var: #floatValue type:'float '> byteOffset := interpreterProxy stackIntegerValue: 0. rcvr := interpreterProxy stackObjectValue: 1. interpreterProxy failed ifTrue:[^0]. addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 4. interpreterProxy failed ifTrue:[^0]. + self mem: (self addressOf: floatValue) cp: addr y: (self sizeof: floatValue). - self cCode:'((int*)(&floatValue))[0] = ((int*)addr)[0]'. interpreterProxy pop: 2. ^interpreterProxy pushFloat: floatValue! Item was changed: ----- Method: FFIPlugin>>primitiveFFIFloatAtPut (in category 'primitives') ----- primitiveFFIFloatAtPut "Return a (signed or unsigned) n byte integer from the given byte offset." | byteOffset rcvr addr floatValue floatOop | <export: true> <inline: false> + <var: #floatValue type: #float> - <var: #floatValue type:'float '> floatOop := interpreterProxy stackValue: 0. (interpreterProxy isIntegerObject: floatOop) ifTrue:[floatValue := self cCoerce: (interpreterProxy integerValueOf: floatOop) to:'float'] ifFalse:[floatValue := self cCoerce: (interpreterProxy floatValueOf: floatOop) to:'float']. byteOffset := interpreterProxy stackIntegerValue: 1. rcvr := interpreterProxy stackObjectValue: 2. interpreterProxy failed ifTrue:[^0]. addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 4. interpreterProxy failed ifTrue:[^0]. + self mem: addr cp: (self addressOf: floatValue) y: (self sizeof: floatValue). - self cCode:'((int*)addr)[0] = ((int*)(&floatValue))[0]'. interpreterProxy pop: 3. ^interpreterProxy push: floatOop! Item was changed: ----- Method: IA32ABIPlugin>>primDoubleAt (in category 'primitives-accessing') ----- primDoubleAt "Answer the 64-bit double starting at the given byte offset (little endian)." "<Alien> doubleAt: index <Integer> ^<Float> <primitive: 'primDoubleAt' error: errorCode module: 'IA32ABI'>" | byteOffset rcvr startAddr addr floatValue | <export: true> + <var: #floatValue type: #double> - <var: #floatValue type:'double '> byteOffset := (interpreterProxy stackPositiveMachineIntegerValue: 0) - 1. rcvr := interpreterProxy stackObjectValue: 1. interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. (self index: byteOffset length: 8 inRange: rcvr) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. (startAddr := self startOfData: rcvr) = 0 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. addr := startAddr + byteOffset. + self mem: (self addressOf: floatValue) cp: addr y: (self sizeof: floatValue). - self cCode:'((long *)(&floatValue))[0] = ((long *)addr)[0]; ((long *)(&floatValue))[1] = ((long *)addr)[1]' - inSmalltalk: [floatValue := rcvr doubleAt: byteOffset]. interpreterProxy pop: 2. ^interpreterProxy pushFloat: floatValue! Item was changed: ----- Method: IA32ABIPlugin>>primDoubleAtPut (in category 'primitives-accessing') ----- primDoubleAtPut "Store a double into 64 bits starting at the given byte offset (little endian)." "<Alien> doubleAt: index <Integer> put: value <Float | Integer> ^<Float | Integer> <primitive: 'primDoubleAtPut' error: errorCode module: 'IA32ABI'>" | byteOffset rcvr startAddr addr valueOop floatValue | <export: true> <var: #floatValue type: #double> valueOop := interpreterProxy stackValue: 0. (interpreterProxy isIntegerObject: valueOop) ifTrue:[floatValue := self cCoerce: (interpreterProxy integerValueOf: valueOop) to: #double] ifFalse:[floatValue := self cCoerce: (interpreterProxy floatValueOf: valueOop) to: #double]. byteOffset := (interpreterProxy stackPositiveMachineIntegerValue: 1) - 1. rcvr := interpreterProxy stackObjectValue: 2. interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. (self index: byteOffset length: 8 inRange: rcvr) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. (interpreterProxy isOopImmutable: rcvr) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. (startAddr := self startOfData: rcvr) = 0 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. addr := startAddr + byteOffset. + self mem: addr cp: (self addressOf: floatValue) y: (self sizeof: floatValue). - self cCode:'((int*)addr)[0] = ((int*)(&floatValue))[0]'. - self cCode:'((int*)addr)[1] = ((int*)(&floatValue))[1]'. interpreterProxy methodReturnValue: valueOop! Item was changed: ----- Method: IA32ABIPlugin>>primFloatAt (in category 'primitives-accessing') ----- primFloatAt "Answer the 32-bit float starting at the given byte offset (little endian)." "<Alien> floatAt: index <Integer> ^<Float> <primitive: 'primFloatAt' error: errorCode module: 'IA32ABI'>" | byteOffset rcvr startAddr addr floatValue | <export: true> + <var: #floatValue type: #float> - <var: #floatValue type: 'float '> byteOffset := (interpreterProxy stackPositiveMachineIntegerValue: 0) - 1. rcvr := interpreterProxy stackObjectValue: 1. interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. (self index: byteOffset length: 4 inRange: rcvr) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. (startAddr := self startOfData: rcvr) = 0 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. addr := startAddr + byteOffset. + self mem: (self addressOf: floatValue) cp: addr y: (self sizeof: floatValue). - self cCode:'((long *)(&floatValue))[0] = ((long *)addr)[0]' - inSmalltalk: [floatValue := rcvr floatAt: byteOffset]. interpreterProxy pop: 2. ^interpreterProxy pushFloat: floatValue! Item was changed: ----- Method: IA32ABIPlugin>>primFloatAtPut (in category 'primitives-accessing') ----- primFloatAtPut "Store a float into 32 bits starting at the given byte offset (little endian)." "<Alien> floatAt: index <Integer> put: value <Float | Integer> ^<Float | Integer> <primitive: 'primFloatAtPut' error: errorCode module: 'IA32ABI'>" | byteOffset rcvr startAddr addr valueOop floatValue | <export: true> <var: #floatValue type: #float> valueOop := interpreterProxy stackValue: 0. (interpreterProxy isIntegerObject: valueOop) ifTrue:[floatValue := self cCoerce: (interpreterProxy integerValueOf: valueOop) to: #double] ifFalse:[floatValue := self cCoerce: (interpreterProxy floatValueOf: valueOop) to: #double]. byteOffset := (interpreterProxy stackPositiveMachineIntegerValue: 1) - 1. rcvr := interpreterProxy stackObjectValue: 2. interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. (self index: byteOffset length: 4 inRange: rcvr) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. (interpreterProxy isOopImmutable: rcvr) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. (startAddr := self startOfData: rcvr) = 0 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. addr := startAddr + byteOffset. + self mem: addr cp: (self addressOf: floatValue) y: (self sizeof: floatValue). - self cCode:'((long *)addr)[0] = ((long *)(&floatValue))[0]'. interpreterProxy methodReturnValue: valueOop! Item was changed: ----- Method: TMethod>>addTypesFor:to:in: (in category 'type inference') ----- addTypesFor: node to: typeSet in: aCodeGen "Add the value tupes for the node to typeSet. Answer if any type was derived from an as-yet-untyped method, which allows us to abort inferReturnTypeFromReturnsIn: if the return type depends on a yet-to-be-typed method." | expr | expr := node. [expr isAssignment or: [expr isStmtList]] whileTrue: [expr isAssignment ifTrue: [expr := expr variable]. expr isStmtList ifTrue: [expr := expr statements last]]. expr isSend ifTrue: [(#(ifTrue: ifFalse: ifTrue:ifFalse: ifFalse:ifTrue:) includes: expr selector) ifTrue: [^expr args inject: false into: [:asYetUntyped :block| + asYetUntyped | (self addTypesFor: block to: typeSet in: aCodeGen)]]. + (#(= ~= == ~~ < > <= >= anyMask: allMask: noMask:) includes: expr selector) ifTrue: - asYetUntyped := asYetUntyped | (self addTypesFor: block to: typeSet in: aCodeGen)]]. - (#(= ~= == ~~ < > <= >= anyMask: noMask:) includes: expr selector) ifTrue: [typeSet add: #sqInt. ^false]. + (#(+ - * / // \\ rem: quo: bitAnd: bitClear: bitOr: bitXor: bitShift:) includes: expr selector) ifTrue: - (#(+ - * / // \\ mod: quo: bitAnd: bitClear: bitOr: bitXor: bitShift:) includes: expr selector) ifTrue: [| types | types := Set new. self addTypesFor: expr receiver to: types in: aCodeGen. (types size = 1 and: [types anyOne last = $*]) ifTrue: "pointer arithmetic" [typeSet add: types anyOne. ^false]. self addTypesFor: expr args first to: types in: aCodeGen. types := aCodeGen harmonizeReturnTypesIn: types. types size = 2 ifTrue: [(types includes: #double) ifTrue: [typeSet add: #double. ^false]. (types includes: #float) ifTrue: [typeSet add: #float. ^false]. ^false]. "don't know; leave unspecified." types notEmpty ifTrue: [typeSet add: types anyOne]. ^false]. "Abort only for untyped methods that will be typed, but don't be phased by recursion." ^(aCodeGen returnTypeForSend: expr in: self) ifNotNil: [:type| typeSet add: type. false] ifNil: [(aCodeGen methodNamed: expr selector) notNil and: [expr selector ~~ selector]]]. expr isVariable ifTrue: [(aCodeGen typeOfVariable: expr name) ifNotNil: [:type| typeSet add: type] ifNil: [typeSet add: (expr name = 'self' ifTrue: [#void] ifFalse: [#sqInt])]]. expr isConstant ifTrue: [| val | val := expr value. val isInteger ifTrue: [typeSet add: ((val >= 0 ifTrue: [val] ifFalse: [-1 - val]) highBit <= 32 ifTrue: [#sqInt] ifFalse: [#sqLong])]. (#(nil true false) includes: val) ifTrue: [typeSet add: #sqInt]. val isFloat ifTrue: [typeSet add: #float]]. ^false! Item was changed: ----- Method: ThreadedFFIPlugin>>primitiveFFIDoubleAt (in category 'primitives') ----- primitiveFFIDoubleAt "Return a (signed or unsigned) n byte integer from the given byte offset." | byteOffset rcvr addr floatValue | <export: true> <inline: false> + <var: #floatValue type: #double> - <var: #floatValue type:'double '> byteOffset := interpreterProxy stackIntegerValue: 0. rcvr := interpreterProxy stackObjectValue: 1. interpreterProxy failed ifTrue:[^0]. addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 8. interpreterProxy failed ifTrue:[^0]. + self mem: (self addressOf: floatValue) cp: addr y: (self sizeof: floatValue). - self cCode:'((int*)(&floatValue))[0] = ((int*)addr)[0]'. - self cCode:'((int*)(&floatValue))[1] = ((int*)addr)[1]'. interpreterProxy pop: 2. ^interpreterProxy pushFloat: floatValue ! Item was changed: ----- Method: ThreadedFFIPlugin>>primitiveFFIDoubleAtPut (in category 'primitives') ----- primitiveFFIDoubleAtPut "Return a (signed or unsigned) n byte integer from the given byte offset." | byteOffset rcvr addr floatValue floatOop | <export: true> <inline: false> + <var: #floatValue type: #double> - <var: #floatValue type:'double '> floatOop := interpreterProxy stackValue: 0. (interpreterProxy isIntegerObject: floatOop) ifTrue:[floatValue := self cCoerce: (interpreterProxy integerValueOf: floatOop) to:'double'] ifFalse:[floatValue := self cCoerce: (interpreterProxy floatValueOf: floatOop) to:'double']. byteOffset := interpreterProxy stackIntegerValue: 1. rcvr := interpreterProxy stackObjectValue: 2. interpreterProxy failed ifTrue:[^0]. addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 8. interpreterProxy failed ifTrue:[^0]. + self mem: addr cp: (self addressOf: floatValue) y: (self sizeof: floatValue). - self cCode:'((int*)addr)[0] = ((int*)(&floatValue))[0]'. - self cCode:'((int*)addr)[1] = ((int*)(&floatValue))[1]'. ^interpreterProxy pop: 3 thenPush: floatOop! Item was changed: ----- Method: ThreadedFFIPlugin>>primitiveFFIFloatAt (in category 'primitives') ----- primitiveFFIFloatAt "Return a (signed or unsigned) n byte integer from the given byte offset." | byteOffset rcvr addr floatValue | <export: true> <inline: false> + <var: #floatValue type: #float> - <var: #floatValue type:'float '> byteOffset := interpreterProxy stackIntegerValue: 0. rcvr := interpreterProxy stackObjectValue: 1. interpreterProxy failed ifTrue:[^0]. addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 4. interpreterProxy failed ifTrue:[^0]. + self mem: (self addressOf: floatValue) cp: addr y: (self sizeof: floatValue). - self cCode:'((int*)(&floatValue))[0] = ((int*)addr)[0]'. interpreterProxy pop: 2. ^interpreterProxy pushFloat: floatValue! Item was changed: ----- Method: ThreadedFFIPlugin>>primitiveFFIFloatAtPut (in category 'primitives') ----- primitiveFFIFloatAtPut "Return a (signed or unsigned) n byte integer from the given byte offset." | byteOffset rcvr addr floatValue floatOop | <export: true> <inline: false> + <var: #floatValue type: #float> - <var: #floatValue type:'float '> floatOop := interpreterProxy stackValue: 0. (interpreterProxy isIntegerObject: floatOop) ifTrue:[floatValue := self cCoerce: (interpreterProxy integerValueOf: floatOop) to:'float'] ifFalse:[floatValue := self cCoerce: (interpreterProxy floatValueOf: floatOop) to:'float']. byteOffset := interpreterProxy stackIntegerValue: 1. rcvr := interpreterProxy stackObjectValue: 2. interpreterProxy failed ifTrue:[^0]. addr := self ffiAddressOf: rcvr startingAt: byteOffset size: 4. interpreterProxy failed ifTrue:[^0]. + self mem: addr cp: (self addressOf: floatValue) y: (self sizeof: floatValue). - self cCode:'((int*)addr)[0] = ((int*)(&floatValue))[0]'. ^interpreterProxy pop: 3 thenPush: floatOop!

1 0

[commit][3637] Fix a slip in the Win32OSProcessPlugin when deleting sizeOfHandle.
by commits＠squeakvm.org 05 Mar '16

05 Mar '16

Revision: 3637 Author: eliot Date: 2016-03-04 17:03:53 -0800 (Fri, 04 Mar 2016) Log Message: ----------- Fix a slip in the Win32OSProcessPlugin when deleting sizeOfHandle. Modified Paths: -------------- branches/Cog/src/plugins/Win32OSProcessPlugin/Win32OSProcessPlugin.c Property Changed: ---------------- branches/Cog/platforms/Cross/vm/sqSCCSVersion.h Property changes on: branches/Cog/platforms/Cross/vm/sqSCCSVersion.h ___________________________________________________________________ Modified: checkindate - Fri Mar 4 10:56:58 PST 2016 + Fri Mar 4 17:02:37 PST 2016 Modified: branches/Cog/src/plugins/Win32OSProcessPlugin/Win32OSProcessPlugin.c =================================================================== --- branches/Cog/src/plugins/Win32OSProcessPlugin/Win32OSProcessPlugin.c 2016-03-05 00:37:43 UTC (rev 3636) +++ branches/Cog/src/plugins/Win32OSProcessPlugin/Win32OSProcessPlugin.c 2016-03-05 01:03:53 UTC (rev 3637) @@ -1,9 +1,9 @@ /* Automatically generated by - VMPluginCodeGenerator VMMaker.oscog-eem.1702 uuid: ca289ff1-8bc0-40d7-a4bb-42b583f02dd1 + VMPluginCodeGenerator VMMaker.oscog-eem.1709 uuid: 10ded6ee-4717-4e34-84d0-9c501aed252b from - Win32OSProcessPlugin VMConstruction-Plugins-OSProcessPlugin.oscog-eem.52 uuid: 930c915e-b58e-4177-9f8b-99f9cecd3431 + Win32OSProcessPlugin VMConstruction-Plugins-OSProcessPlugin.oscog-eem.53 uuid: 19679cb9-5840-4a5d-876f-a506bf70a1b6 */ -static char __buildInfo[] = "Win32OSProcessPlugin VMConstruction-Plugins-OSProcessPlugin.oscog-eem.52 uuid: 930c915e-b58e-4177-9f8b-99f9cecd3431 " __DATE__ ; +static char __buildInfo[] = "Win32OSProcessPlugin VMConstruction-Plugins-OSProcessPlugin.oscog-eem.53 uuid: 19679cb9-5840-4a5d-876f-a506bf70a1b6 " __DATE__ ; /* D T Lewis - Win32OSProcessPlugin.c translated from class Win32OSProcessPlugin of OSProcessPlugin version 4.3.3 Cog */ @@ -217,9 +217,9 @@ struct VirtualMachine* interpreterProxy; static const char *moduleName = #ifdef SQUEAK_BUILTIN_PLUGIN - "Win32OSProcessPlugin VMConstruction-Plugins-OSProcessPlugin.oscog-eem.52 (i)" + "Win32OSProcessPlugin VMConstruction-Plugins-OSProcessPlugin.oscog-eem.53 (i)" #else - "Win32OSProcessPlugin VMConstruction-Plugins-OSProcessPlugin.oscog-eem.52 (e)" + "Win32OSProcessPlugin VMConstruction-Plugins-OSProcessPlugin.oscog-eem.53 (e)" #endif ; static int osprocessSandboxSecurity; @@ -491,7 +491,7 @@ } ptr = arrayValueOf(aHandleObject); idx = 0; - while (idx < (sizeOfHandle())) { + while (idx < (sizeof(HANDLE))) { handleUnion.bytes[idx] = ptr[idx]; idx += 1; }

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev March 2016