Vm-dev October 2017

vm-dev@lists.squeakfoundation.org

29 participants
47 discussions

[OpenSmalltalk/opensmalltalk-vm] fe63cb: Skip deploy check
by GitHub 22 Oct '17

22 Oct '17

Branch: refs/heads/fniephaus/xcode-update Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: fe63cb130721097ca308d8c5e133556a592b2164 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/fe63cb130721097ca3… Author: Fabio Niephaus <code(a)fniephaus.com> Date: 2017-10-22 (Sun, 22 Oct 2017) Changed paths: M .travis_deploy.sh Log Message: ----------- Skip deploy check

1 0

[OpenSmalltalk/opensmalltalk-vm] 3a71b3: Use xcode7.3
by GitHub 22 Oct '17

22 Oct '17

Branch: refs/heads/fniephaus/xcode-update Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 3a71b3e6192ef98505a30dd86ae26f09c46dd579 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3a71b3e6192ef98505… Author: Fabio Niephaus <code(a)fniephaus.com> Date: 2017-10-22 (Sun, 22 Oct 2017) Changed paths: M .travis.yml Log Message: ----------- Use xcode7.3

1 0

Spur, memfd and a restart trick?
by Holger Freyther 22 Oct '17

22 Oct '17

Hey, a small thought experiment. One issue of running a system a long time is how to make small and bigger upgrades? In theory a long running image can be updated in place but in practice this is problematic[1]. For C based systems we played with the idea of using shared memory to "park" state so that we can read it later but shm has some cleanup and management issues. IIRC in a system like Minix an upgrade is done by externalizing the state, starting a new server, parsing/upgrading the state, downgrading the state and if it is the same and then the new server is allowed to take over. Yesterday I wondered how spur memory segments and memfd could play together to implement something like the above. Imagine a REST server with some open connections, how can we restart it without dropping the open connections? Maybe something like this could work: * Use memfd_create to allocate memory and use setenv to "remember" the fd * Serialize Fuel/STON the server data * Serialize/remember the open file descriptors sockets * exec the VM/new image * Materialize the state * Re-create Socket/Fileplugin resources * Close the memory One issue with Fuel is that the representation of objects must be similar between the old/new version of the image (but that could be solved). What would be more neat and a lot more difficult is something like that... * Use memfd_create and treat this as a memory segment of spur (old space?) * Move/copy the "state" (whatever that is, transitive cover might be too large) into that segment * On re-exec move these objects into the main image again Again the issue is if sizes of instances changed...but maybe we can do the object migration from the image where we have the old and new class around? What do you think holger [1] When does an update take place (so state can be updated)? If you have put too much code into a block closure that is currently executing it will not be updated. E.g. in Erlang it is well defined when one process receives the update.

1 0

Re: [Vm-dev] Sista alternate bytecodes + Java Bytecode ?
by Raffaello Giulietti 21 Oct '17

21 Oct '17

Hi Ben, in addition to Clément's observations, you should not forget that much existing JVM bytecode depends on the multi-threading capabilities of any contemporary JVM implementation and its supporting platform libraries (e.g., java.util.concurrent.* for concurrency frameworks, java.util.stream.* for parallel streams, etc.) So, besides the humongous work mentioned by Clément, I can only imagine how hyper-humongous a work would it be to make the current OpenSmalltalk VM multi-threaded to accommodate the JVM computational model inherent in almost any real-world Java bytecode. Think only of the impact on the garbage collectors, for example. (Or on how to present multi-threading to Smalltalkers accustomed to the vastly simpler shared memory model of Process, where the happens-before relationship is trivial.) Greetings Raffaello On 2017-10-17 16:12, Raffaello Giulietti wrote: > Hi, > > That question should be asked on vm-dev. > > Just a detail, multibytecode set support is prior to the Sista > implementation, it was used for example in the context of Newspeak (Squeak > and Newspeak bytecodes supported together). Sista uses that feature, which > makes it look like new in the Pharo community since afaik no one used it > before in the context of Pharo. > > Then yes it is feasible to have the VM process Java bytecode, but it's > humongous work. On the top my head, we would need to support typed > bytecodes for Numbers and exceptions at the bytecode level (which in itself > is month of work, imagine raising an exception from Java/ST and catch it > from the other runtime, with multiple ensure/try finally in between) > > Note that supporting the Java bytecode is far from enough to be able to run > Java code (We also need core Java libraries support at least, including > exceptions/stack reification model that should be able to interact with > each other) > > You can have a look at Smalltalk/X where the VM can run Java, C and > Smalltalk. > > Regards > > > On Tue, Oct 3, 2017 at 1:57 PM, Ben Coman <btc at openinworld.com> wrote: > > > Just wondering about an exotic idea, with Sista facilitating alternate > > bytecodes (btw, is that multiple bytecode sets within one Image?), how > > feasible would it be to have the VM process Java bytecode? > > > > cheers -ben > > >

11 18

Working eLinda. Was Re: Multi-core system Squeak
by henry 21 Oct '17

21 Oct '17

Hi everyone. I made ETuple a subclass of ERef and provided an ETupleResolver. I also repaired the TreeBrancher, which was returning a closure rather than scaling through th ETuple space. All fixed now, for your contemplation. http://www.squeaksource.com/Cryptography/elinda-HenryHouse.13.mcz - HH On Thu, Oct 19, 2017 at 15:03, henry <henry(a)callistohouse.club> wrote: > This was my thinking on eLinda, whose combination of evaluating in Linda TupleSpace Subspaces and also the eventual sending based upon Erights.org ELib. I added event registrations of Tuples with ETupleSpace default eventuallyDo: [:tuple | count := count + 1]. Every eval afterwards would count. That eventual reactor runs on the PriorityVat' > s Process. If tuple evals in the subspace started using the Vat's process, then it would be single-threaded, multitasking. I feel it could be a monitor of task dispersal. > > Here is the latest eLinda, for Squeak and Pharo: http://www.squeaksource.com/Cryptography/elinda-HenryHouse.3.mcz > > I also think it would make a good parsing engine for scripting ai computations. I was looking at PeitiParser and thinking of changing their baskends to generate Scripts that could run through this linda-vat engine. > > As you have said, just thinking out loud. > > - HH > >> -------- Original Message -------- >> Subject: Re: [Vm-dev] Multi-core system Squeak (was Re: Sista alternate bytecodes + Java Bytecode ?) >> Local Time: October 19, 2017 1:20 PM >> UTC Time: October 19, 2017 5:20 PM >> From: tblanchard(a)mac.com >> To: Squeak Virtual Machine Development Discussion <vm-dev(a)lists.squeakfoundation.org> >> >> K, so if you were to marry that with Craig Latta"s micro images and "imprinting" strategy, offloading work to other "queues" might be a really cool way to chuck over a minimal amount of code associated with a task - where each work queue is just another micro worker image. >> >> Just thinking out loud. >> >>> On Oct 19, 2017, at 10:09 AM, K K Subbu <kksubbu.ml(a)gmail.com> wrote: >>> >>> On Thursday 19 October 2017 10:16 PM, tim Rowledge wrote: >>>>> On 19-10-2017, at 7:31 AM, Todd Blanchard<tblanchard(a)mac.com> >>>>> wrote: >>>>> It works very well and this idea of mini worker images sounds like >>>>> it might be a good fit for that model. >>>> One thing I noticed with surprise was how astonishingly fast Dave’s >>>> OSProcess could spawn an entire image, even on a Pi. >>> >>> I second this idea. LatexMorph is a good example of that. It uses OSProcess to pipe LaTeX text through latex engine and Ghostscript into an image and import that image back into Squeak. The pipeline was fast enough for live rendering of image as the text was typed on laptops way back in 2010. >>> >>> Regards .. Subbu

1 1

A problem with macOS VM
by Esteban Lorenzano 21 Oct '17

21 Oct '17

Hi, I discovered interacting with UI (for example, the menu) in mac actually freezes the image. You can check it with this example: [ 30 timesRepeat: [ DateAndTime now crLog. 1 second wait. ] ] open a transcript and then go to play with the menu… you will see how the log stops. I think this happens because the vm is running in the main thread. And I remember years ago the VM was running on a worker thread while now is running on a single thread but the logic for run on worker thread is still there so I changed that (is just uncommenting a method send and commenting another) but then when I executed VM I got this error: fish: './Pharo.app/Contents/MacOS/Ph...' terminated by signal SIGPROF (Profiling timer expired) this is with fish, the shell I use… if I execute with bash I obtain a simple: ./Pharo.app/Contents/MacOS/Pharo: ./Pharo.app/Contents/MacOS/Pharo: cannot execute binary file So… I would like to try again the worker thread, I feel is kind of bad the image freezes when interacting its (not much, but possible) native UI elements. Also, since I was woking on an ObjectiveC bridge (a simple port of John’s Alien bridge to UFFI), I want to enable the possibility of doing some native UI at least for macs. cheers, Esteban

2 1

Pharo 64 bit vm segmentation fault on garbageCollect
by Andrei Chis 20 Oct '17

20 Oct '17

Hi, I got a few times the following crash while using the latest Pharo 64 bit image (Pharo64-60513) with the latest vm (pharo-mac-x86_64-201710101955-47390dc) on Mac OS. The image is around 3.5GB when the crash happens. Attached is a crash report containing the reports for three crashes. --------------------------------------------------------------------------------------------------------- Segmentation fault 0 Pharo 0x000000010ac13ad8 fixFollowedFieldofObjectwithInitialValue + 33 1 Pharo 0x000000010ac8f64e reportStackState + 884 2 Pharo 0x000000010ac8f984 sigsegv + 155 3 libsystem_platform.dylib 0x00007fff934dff1a _sigtramp + 26 4 ??? 0x0000000000000000 0x0 + 0 5 Pharo 0x000000010ac2d8a1 markAndTrace + 858 6 Pharo 0x000000010ac2a584 markObjects + 464 7 Pharo 0x000000010ac29d6c fullGC + 72 8 Pharo 0x000000010ac49df8 primitiveFullGC + 45 9 Pharo 0x000000010ac09445 interpret + 26715 10 Pharo 0x000000010ac13816 enterSmalltalkExecutiveImplementation + 152 11 Pharo 0x000000010ac02e8c interpret + 674 12 Pharo 0x000000010ac90cd1 -[sqSqueakMainApplication runSqueak] + 394 13 Foundation 0x00007fff8ecb0641 __NSFirePerformWithOrder + 326 14 CoreFoundation 0x00007fff87892127 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23 15 CoreFoundation 0x00007fff87892080 __CFRunLoopDoObservers + 368 16 CoreFoundation 0x00007fff87884188 __CFRunLoopRun + 872 17 CoreFoundation 0x00007fff87883bd8 CFRunLoopRunSpecific + 296 18 HIToolbox 0x00007fff88ffd56f RunCurrentEventLoopInMode + 235 19 HIToolbox 0x00007fff88ffd1ee ReceiveNextEventCommon + 179 20 HIToolbox 0x00007fff88ffd12b _BlockUntilNextEventMatchingListInModeWithFilter + 71 21 AppKit 0x00007fff8d56c8ab _DPSNextEvent + 978 22 AppKit 0x00007fff8d56be58 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 346 23 AppKit 0x00007fff8d561af3 -[NSApplication run] + 594 24 AppKit 0x00007fff8d4de244 NSApplicationMain + 1832 25 libdyld.dylib 0x00007fff8ea3a5c9 start + 1 Smalltalk stack dump: 0x7fff54ff9fb0 I SmalltalkImage>garbageCollect 0x11317f1c8: a(n) SmalltalkImage 0x7fff54ff9ff8 I Array class(Behavior)>handleFailingBasicNew: 0x112d62738: a(n) Array class 0x7fff54ffa038 M Array class(Behavior)>basicNew: 0x112d62738: a(n) Array class 0x7fff54ffa070 M Array class>new: 0x112d62738: a(n) Array class 0x7fff54ffa0b0 M OrderedCollection>growAtLast 0x11235e740: a(n) OrderedCollection 0x7fff54fe4948 M OrderedCollection>makeRoomAtLast 0x11235e740: a(n) OrderedCollection 0x7fff54fe4978 M OrderedCollection>addLast: 0x11235e740: a(n) OrderedCollection 0x7fff54fe49b0 M [] in OrderedCollection>addAllLast: 0x11235e740: a(n) OrderedCollection 0x7fff54fe49f8 M OrderedCollection>do: 0x176a416e8: a(n) OrderedCollection ... --------------------------------------------------------------------------------------------------------- Cheers, Andrei

1 0

Overview of the OpenSmalltalk VM and its build process
by Raffaello Giulietti 18 Oct '17

18 Oct '17

Hi, I'm interested in understanding the overall OpenSmalltalk VM structure and design and its build process. I read [1] and [2] to get a high level picture of the vm and its interesting strategy to development (Slang, VMMaker, etc.) Apart from these, are there other useful documents/sites/tutorials on the vm development process in general and about the underlying ideas in the build process? I'm aware that vm construction is a rather special topic but any useful reference or hint is welcome. I'm already familiar with the interesting [3] and [4] websites and their authors papers, talks and slides, but these do not seem to help much in clarifying the development process itself. In particular, I'm targeting Pharo 64 bit/Win 64 bit (x64-86). I hope to be able someday to actively participate in bringing Cog/Spur/Sista to a more mature status on this platform. The questions I would like to find an answer to are of the following kind: * Where should I start? * Should I use Squaek or can I use Pharo for vm development purposes? * What are the restrictions of Slang? * Where does VMMaker live? * Which C toolchain shall I use? * Which release of gcc, ld, make are known to work? * What about clang? * Which version of cygwin64 or mingw64 are OK? * etc. Greetings Raffaello --- [1] http://www.vpri.org/pdf/tr1997001_backto.pdf [2] http://design.cs.iastate.edu/vmil/2011/papers/p03-miranda.pdf [3] http://www.mirandabanda.org/cogblog/ [4] https://clementbera.wordpress.com/

5 6

VM Maker: VMMaker.oscog-cb.2272.mcz
by commits＠source.squeak.org 16 Oct '17

16 Oct '17

ClementBera uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-cb.2272.mcz ==================== Summary ==================== Name: VMMaker.oscog-cb.2272 Author: cb Time: 16 October 2017, 5:29:38.689276 pm UUID: 9da58356-7b3b-4d97-b4e3-8d145a725827 Ancestors: VMMaker.oscog-cb.2271 Fixed bug with large struct in FFI with SysV . =============== Diff against VMMaker.oscog-cb.2271 =============== Item was changed: ----- Method: ThreadedX64SysVFFIPlugin>>ffiPushStructure:ofSize:typeSpec:ofLength:in: (in category 'marshalling') ----- ffiPushStructure: pointer ofSize: structSize typeSpec: argSpec ofLength: argSpecSize in: calloutState <var: #pointer type: #'void *'> <var: #argSpec type: #'sqInt *'> <var: #calloutState type: #'CalloutState *'> <inline: true> | roundedSize doubleType floatType numDoubleRegisters numIntegerRegisters passField0InXmmReg passField1InXmmReg | structSize <= 16 ifTrue: ["See sec 3.2.3 of http://people.freebsd.org/~obrien/amd64-elf-abi.pdf. (dravft version 0.90). All of the folowing are passed in registers: typedef struct { long a; } s0; typedef struct { double a; } s1; typedef struct { long a; double b; } s2; typedef struct { int a; int b; double c; } s2a; typedef struct { short a; short b; short c; short d; double e; } s2b; typedef struct { long a; float b; } s2f; typedef struct { long a; float b; float c; } s2g; but not ones like this: typedef struct { int a; float b; int c; float d; } s2h;" doubleType := FFITypeDoubleFloat << FFIAtomicTypeShift + FFITypeDoubleFloat. floatType := FFITypeDoubleFloat << FFIAtomicTypeShift + FFITypeSingleFloat. passField0InXmmReg := doubleType = ((self cCoerce: argSpec to: #'int *') at: 1) "0th field is struct type and size" or: [floatType = ((self cCoerce: argSpec to: #'int *') at: 1) and: [floatType = ((self cCoerce: argSpec to: #'int *') at: 2)]]. structSize <= 8 ifTrue: [numDoubleRegisters := passField0InXmmReg ifTrue: [1] ifFalse: [0]. numIntegerRegisters := 1 - numDoubleRegisters] ifFalse: [passField1InXmmReg := doubleType = ((self cCoerce: argSpec to: #'int *') at: argSpecSize - 1) "Nth field is last field of struct" or: [floatType = ((self cCoerce: argSpec to: #'int *') at: argSpecSize - 2) and: [floatType = ((self cCoerce: argSpec to: #'int *') at: argSpecSize - 1)]]. numDoubleRegisters := (passField0InXmmReg ifTrue: [1] ifFalse: [0]) + (passField1InXmmReg ifTrue: [1] ifFalse: [0]). numIntegerRegisters := 2 - numDoubleRegisters]. (calloutState floatRegisterIndex + numDoubleRegisters <= NumFloatRegArgs and: [calloutState integerRegisterIndex + numIntegerRegisters <= NumIntRegArgs]) ifTrue: [passField0InXmmReg ifTrue: [self ffiPushDoubleFloat: ((self cCoerceSimple: pointer to: #'double *') at: 0) in: calloutState] ifFalse: [self ffiPushSignedLongLong: ((self cCoerceSimple: pointer to: #'long long *') at: 0) in: calloutState]. structSize > 8 ifTrue: [passField1InXmmReg ifTrue: [self ffiPushDoubleFloat: ((self cCoerceSimple: pointer to: #'double *') at: 1) in: calloutState] ifFalse: [self ffiPushSignedLongLong: ((self cCoerceSimple: pointer to: #'long long *') at: 1) in: calloutState]]. + ^0]]. - ^0]. roundedSize := structSize + 7 bitClear: 7. calloutState currentArg + roundedSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. self mem: calloutState currentArg cp: (self cCoerceSimple: pointer to: 'char *') y: structSize. + calloutState currentArg: calloutState currentArg + roundedSize. - calloutState currentArg: calloutState currentArg + roundedSize]. ^0!

1 0

VM Maker: VMMaker.oscog-EstebanLorenzano.2273.mcz
by commits＠source.squeak.org 16 Oct '17

16 Oct '17

Esteban Lorenzano uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-EstebanLorenzano.2273.mcz ==================== Summary ==================== Name: VMMaker.oscog-EstebanLorenzano.2273 Author: EstebanLorenzano Time: 16 October 2017, 2:36:10.432545 pm UUID: 52109b4e-0757-4034-96bd-315af49be0fc Ancestors: VMMaker.oscog-cb.2271 fix incorrect SistaCogitClone removal =============== Diff against VMMaker.oscog-cb.2271 =============== Item was removed: - ----- Method: SistaCogitClone class>>methodZoneClass (in category 'accessing class hierarchy') ----- - methodZoneClass - ^SistaMethodZone! Item was removed: - ----- Method: SistaCogitClone>>defaultCogCodeSize (in category 'accessing') ----- - defaultCogCodeSize - "Return the default number of bytes to allocate for native code at startup. - The actual value can be set via vmParameterAt: and/or a preference in the ini file." - <api> - ^2 * backEnd getDefaultCogCodeSize! Item was removed: - ----- Method: SistaCogitClone>>genAtPutInlinePrimitive: (in category 'inline primitive generators') ----- - genAtPutInlinePrimitive: prim - "Unary inline primitives." - "SistaV1: 248 11111000 iiiiiiii mjjjjjjj Call Primitive #iiiiiiii + (jjjjjjj * 256) m=1 means inlined primitive, no hard return after execution. - See EncoderForSistaV1's class comment and StackInterpreter>>#trinaryInlinePrimitive:" - | ra1 ra2 rr adjust needsStoreCheck | - "The store check requires rr to be ReceiverResultReg" - needsStoreCheck := (objectRepresentation isUnannotatableConstant: self ssTop) not. - self - allocateRegForStackTopThreeEntriesInto: [:rTop :rNext :rThird | ra2 := rTop. ra1 := rNext. rr := rThird ] - thirdIsReceiver: (prim = 0 and: [ needsStoreCheck ]). - self assert: (rr ~= ra1 and: [rr ~= ra2 and: [ra1 ~= ra2]]). - self ssTop popToReg: ra2. - self ssPop: 1. - self ssTop popToReg: ra1. - self ssPop: 1. - self ssTop popToReg: rr. - self ssPop: 1. - objectRepresentation genConvertSmallIntegerToIntegerInReg: ra1. - "Now: ra is the variable object, rr is long, TempReg holds the value to store." - self flag: #TODO. "This is not really working as the immutability and store check needs to be present. " - prim caseOf: { - "0 - 1 pointerAt:put: and byteAt:Put:" - [0] -> [ adjust := (objectMemory baseHeaderSize >> objectMemory shiftForWord) - 1. "shift by baseHeaderSize and then move from 1 relative to zero relative" - adjust ~= 0 ifTrue: [ self AddCq: adjust R: ra1. ]. - self MoveR: ra2 Xwr: ra1 R: rr. - "I added needsStoreCheck so if you initialize an array with a Smi such as 0 or a boolean you don't need the store check" - needsStoreCheck ifTrue: - [ self assert: needsFrame. - objectRepresentation genStoreCheckReceiverReg: rr valueReg: ra2 scratchReg: TempReg inFrame: true] ]. - [1] -> [ objectRepresentation genConvertSmallIntegerToIntegerInReg: ra2. - adjust := objectMemory baseHeaderSize - 1. "shift by baseHeaderSize and then move from 1 relative to zero relative" - self AddCq: adjust R: ra1. - self MoveR: ra2 Xbr: ra1 R: rr. - objectRepresentation genConvertIntegerToSmallIntegerInReg: ra2. ]. - } - otherwise: [^EncounteredUnknownBytecode]. - self ssPushRegister: ra2. - ^0! Item was removed: - ----- Method: SistaCogitClone>>genByteEqualsInlinePrimitive: (in category 'inline primitive generators') ----- - genByteEqualsInlinePrimitive: prim - - "3021 Byte Object >> equals:length: - The receiver and the arguments are both byte objects and have both the same size (length in bytes). - The length argument is a smallinteger. - Answers true if all fields are equal, false if not. - Comparison is bulked to word comparison." - - "Overview: - 1. The primitive is called like that: [byteObj1 equals: byteObj2 length: length]. - In the worst case we use 5 registers including TempReg - and we produce a loop bulk comparing words. - 2. The common case is a comparison against a cst: [byteString = 'foo']. - which produces in Scorch [byteString equals: 'foo' length: 3]. - We try to generate fast code for this case with 3 heuristics: - - specific fast code if len is a constant - - unroll the loop if len < 2 * wordSize - - compile-time reads if str1 or str2 is a constant and loop is unrolled. - We use 3 registers including TempReg in the common case. - We could use 1 less reg if the loop is unrolled, the instr is followed by a branch - AND one operand is a constant, but this is complicated enough. - 3. We ignore the case where all operands are constants - (We assume Scorch simplifies it, it works but it is not optimised)" - - | str1Reg str2Reg lenReg extraReg jmp jmp2 needjmpZeroSize needLoop unroll jmpZeroSize instr lenCst mask | - <var: #jmp type: #'AbstractInstruction *'> - <var: #instr type: #'AbstractInstruction *'> - <var: #jmp2 type: #'AbstractInstruction *'> - <var: #jmpZeroSize type: #'AbstractInstruction *'> - - "--- quick path for empty string---" - "This path does not allocate registers and right shift on negative int later in the code. - Normally this is resolved by Scorch but we keep it for correctness and consistency" - self ssTop type = SSConstant ifTrue: - [ lenCst := objectMemory integerValueOf: self ssTop constant. - lenCst = 0 ifTrue: [ self ssPop: 3. self ssPushConstant: objectMemory trueObject. ^ 0 ] ]. - - "--- Allocating & loading registers --- " - needLoop := (self ssTop type = SSConstant and: [ lenCst <= (objectMemory wordSize * 2) ]) not. - unroll := needLoop not and: [lenCst > objectMemory wordSize ]. - needLoop - ifTrue: - [ str1Reg := self allocateRegForStackEntryAt: 1 notConflictingWith: self emptyRegisterMask. - str2Reg := self allocateRegForStackEntryAt: 2 notConflictingWith: (self registerMaskFor: str1Reg). - lenReg := self allocateRegForStackEntryAt: 0 notConflictingWith: (self registerMaskFor:str1Reg and: str2Reg). - (self ssValue: 1) popToReg: str1Reg. - (self ssValue: 2) popToReg: str2Reg. - extraReg := self allocateRegNotConflictingWith: (self registerMaskFor: str1Reg and: str2Reg and: lenReg)] - ifFalse: - [ mask := self emptyRegisterMask. - (self ssValue: 1) type = SSConstant ifFalse: - [ str1Reg := self allocateRegForStackEntryAt: 1 notConflictingWith: mask. - (self ssValue: 1) popToReg: str1Reg. - mask := mask bitOr: (self registerMaskFor: str1Reg) ]. - (self ssValue: 2) type = SSConstant ifFalse: - [ str2Reg := self allocateRegForStackEntryAt: 2 notConflictingWith: mask. - (self ssValue: 2) popToReg: str2Reg. - mask := mask bitOr: (self registerMaskFor: str2Reg) ]. - extraReg := self allocateRegNotConflictingWith: mask]. - - "--- Loading LenReg (or statically resolving it) --- " - "LenReg is loaded with (lenInBytes + objectMemory baseHeaderSize - 1 >> shiftForWord) - LenReg is the index for the last word to compare with MoveXwr:r:R:. - The loop iterates from LenReg to first word of ByteObj" - self ssTop type = SSConstant - ifTrue: "common case, str = 'foo'. We can precompute lenReg." - [ lenCst := lenCst + objectMemory baseHeaderSize - 1 >> objectMemory shiftForWord. - needLoop ifTrue: [self MoveCq: lenCst R: lenReg ]. - needjmpZeroSize := false] - ifFalse: "uncommon case, str = str2. lenReg in word computed at runtime." - [ self ssTop popToReg: lenReg. - objectRepresentation genConvertSmallIntegerToIntegerInReg: lenReg. - self CmpCq: 0 R: lenReg. - jmpZeroSize := self JumpZero: 0. - needjmpZeroSize := true. - self AddCq: objectMemory baseHeaderSize - 1 R: lenReg. - self ArithmeticShiftRightCq: objectMemory shiftForWord R: lenReg ]. - - "--- Comparing the strings --- " - "LenReg has the index of the last word to read (unless no loop). - We decrement it to adjust -1 (0 in 64 bits) while comparing" - needLoop - ifTrue: - [instr := self MoveXwr: lenReg R: str1Reg R: extraReg. - self MoveXwr: lenReg R: str2Reg R: TempReg. - self CmpR: extraReg R: TempReg. - jmp := self JumpNonZero: 0. "then string are not equal (jmp target)" - self AddCq: -1 R: lenReg. - self CmpCq: (objectMemory baseHeaderSize >> objectMemory shiftForWord) - 1 R: lenReg. "first word of ByteObj, stop looping." - self JumpNonZero: instr] - ifFalse: "Common case, only 1 or 2 word to check: no lenReg allocation, cst micro optimisations" - [self genByteEqualsInlinePrimitiveCmp: str1Reg with: str2Reg scratch1: extraReg scratch2: TempReg field: 0. - jmp := self JumpNonZero: 0. "then string are not equal (jmp target)" - unroll ifTrue: "unrolling more than twice generate more instructions than the loop so we don't do it" - [self genByteEqualsInlinePrimitiveCmp: str1Reg with: str2Reg scratch1: extraReg scratch2: TempReg field: 1. - jmp2 := self JumpNonZero: 0. "then string are not equal (jmp target)"]]. - needjmpZeroSize ifTrue: [ jmpZeroSize jmpTarget: self Label ]. - "fall through, strings are equal" - - "--- Pushing the result or pipelining a branch --- " - self ssPop: 3. - self genByteEqualsInlinePrimitiveResult: jmp returnReg: extraReg. - unroll ifTrue: [jmp2 jmpTarget: jmp getJmpTarget]. - ^0! Item was removed: - ----- Method: SistaCogitClone>>genByteEqualsInlinePrimitiveCmp:with:scratch1:scratch2:field: (in category 'inline primitive generators') ----- - genByteEqualsInlinePrimitiveCmp: str1Reg with: str2Reg scratch1: scratch1Reg scratch2: scratch2Reg field: index - | shift | - <inline: true> - shift := objectMemory baseHeaderSize + (index * objectMemory wordSize). - (self ssValue: 1) type = SSConstant - ifTrue: [self MoveCq: (objectMemory fetchPointer: index ofObject: (self ssValue: 1) constant) R: scratch1Reg] - ifFalse: [self MoveMw: shift r: str1Reg R: scratch1Reg]. - (self ssValue: 2) type = SSConstant - ifTrue: [self MoveCq: (objectMemory fetchPointer: index ofObject: (self ssValue: 2) constant) R: scratch2Reg] - ifFalse: [self MoveMw: shift r: str2Reg R: scratch2Reg]. - self CmpR: scratch1Reg R: scratch2Reg.! Item was removed: - ----- Method: SistaCogitClone>>genByteEqualsInlinePrimitiveResult:returnReg: (in category 'inline primitive generators') ----- - genByteEqualsInlinePrimitiveResult: jmp returnReg: reg - "Byte equal is falling through if the result is true, or jumping using jmp if the result is false. - The method is required to set the jump target of jmp. - We look ahead for a branch and pipeline the jumps if possible.. - ReturnReg is used only if not followed immediately by a branch." - | branchDescriptor nextPC postBranchPC targetBytecodePC localJump canElide | - <var: #localJump type: #'AbstractInstruction *'> - <var: #branchDescriptor type: #'BytecodeDescriptor *'> - self extractMaybeBranchDescriptorInto: [ :descr :next :postBranch :target | - branchDescriptor := descr. nextPC := next. postBranchPC := postBranch. targetBytecodePC := target ]. - - "Case 1 - not followed by a branch" - (branchDescriptor isBranchTrue or: [branchDescriptor isBranchFalse]) - ifFalse: - [self genMoveTrueR: reg. - localJump := self Jump: 0. - jmp jmpTarget: (self genMoveFalseR: reg). - localJump jmpTarget: self Label. - self ssPushRegister: reg. - ^ 0]. - - "Case 2 - followed by a branch" - (self fixupAt: nextPC) notAFixup - ifTrue: "The next instruction is dead. we can skip it." - [deadCode := true. - self ensureFixupAt: targetBytecodePC. - self ensureFixupAt: postBranchPC ] - ifFalse: - [self ssPushConstant: objectMemory trueObject]. "dummy value" - "We can only elide the jump if the pc after nextPC is the same as postBranchPC. - Branch following means it may not be." - self nextDescriptorExtensionsAndNextPCInto: - [:iguana1 :iguana2 :iguana3 :followingPC| nextPC := followingPC]. - canElide := deadCode and: [nextPC = postBranchPC]. - branchDescriptor isBranchTrue - ifTrue: - [ self Jump: (self ensureNonMergeFixupAt: targetBytecodePC). - canElide - ifFalse: [ jmp jmpTarget: (self ensureNonMergeFixupAt: postBranchPC) ] - ifTrue: [ jmp jmpTarget: self Label ] ] - ifFalse: [ canElide ifFalse: [ self Jump: (self ensureNonMergeFixupAt: postBranchPC). - jmp jmpTarget: (self ensureNonMergeFixupAt: targetBytecodePC) ] ]. - ^0! Item was removed: - ----- Method: SistaCogitClone>>genQuaternaryInlinePrimitive: (in category 'inline primitive generators') ----- - genQuaternaryInlinePrimitive: prim - "Quaternary inline primitives." - "SistaV1: 248 11111000 iiiiiiii mjjjjjjj Call Primitive #iiiiiiii + (jjjjjjj * 256) m=1 means inlined primitive, no hard return after execution. - See EncoderForSistaV1's class comment and StackInterpreter>>#quaternaryInlinePrimitive:" - | needStoreCheck sourceReg stopReg objReg adjust jmp cmp isStartCst isStopCst startCst stopCst iteratorReg | - <var: #jmp type: #'AbstractInstruction *'> - <var: #cmp type: #'AbstractInstruction *'> - prim = 0 ifFalse: [^EncounteredUnknownBytecode]. - - "4000 Pointer Object>> fillFrom:to:with: The receiver is a Pointer object. the middle two arguments are smallintegers. Last argument is any object. Fills the object in between the two indexes with last argument. Receiver is guaranteed to be mutable. The pointer accesses are raw (no inst var check). If ExtB is set to 1, no store check is present. Else a single store check is done for the bulk operation. Answers the receiver." - needStoreCheck := self sistaNeedsStoreCheck. - extB := numExtB := 0. - - "Allocate reg for src, objToStore, iterator and stop." - sourceReg := needStoreCheck - ifTrue: [ self ssAllocateRequiredReg: ReceiverResultReg. - self voidReceiverResultRegContainsSelf. - ReceiverResultReg ] - ifFalse: [ self allocateRegForStackEntryAt: 3 notConflictingWith: self emptyRegisterMask ]. - (self ssValue: 3) popToReg: sourceReg. - objReg := self allocateRegForStackEntryAt: 0 notConflictingWith: (self registerMaskFor: sourceReg). - self ssTop popToReg: objReg. - - "Set up iterator to first index to write and stop to last index to write" - adjust := (objectMemory baseHeaderSize >> objectMemory shiftForWord) - 1. "shift by baseHeaderSize and then move from 1 relative to zero relative" - isStartCst := (self ssValue: 2) type = SSConstant. - isStopCst := (self ssValue: 1) type = SSConstant. - isStartCst ifTrue: [startCst := adjust + (objectMemory integerValueOf: (self ssValue: 2) constant)]. - isStopCst ifTrue: [stopCst := adjust + (objectMemory integerValueOf: (self ssValue: 1) constant)]. - - (isStartCst - and: [isStopCst - and: [stopCst - startCst < 7 ]]) "The other path generates at least 7 instructions" - ifTrue: ["unroll" - startCst - to: stopCst - do: [ :i | self MoveMw: i r: sourceReg R: objReg ] ] - ifFalse: ["loop" - stopReg := self allocateRegNotConflictingWith: (self registerMaskFor: sourceReg and: objReg). - iteratorReg := self allocateRegNotConflictingWith: (self registerMaskFor: sourceReg and: objReg and: stopReg). - isStartCst - ifTrue: [ self MoveCq: startCst R: iteratorReg ] - ifFalse: [ (self ssValue: 2) popToReg: iteratorReg. - adjust ~= 0 ifTrue: [ self AddCq: adjust R: iteratorReg ] ]. - isStopCst - ifTrue: [ self MoveCq: stopCst R: stopReg ] - ifFalse: [ (self ssValue: 1) popToReg: stopReg. - adjust ~= 0 ifTrue: [ self AddCq: adjust R: stopReg ] ]. - cmp := self CmpR: stopReg R: iteratorReg. - jmp := self JumpAbove: 0. - self MoveR: objReg Xwr: iteratorReg R: sourceReg. - self AddCq: 1 R: iteratorReg. - self Jump: cmp. - jmp jmpTarget: self Label]. - - needStoreCheck ifTrue: [objectRepresentation genStoreCheckReceiverReg: sourceReg valueReg: objReg scratchReg: TempReg inFrame: true]. - - self ssPop: 4. - self ssPushRegister: sourceReg. - ^0! Item was removed: - ----- Method: SistaCogitClone>>genQuinaryInlinePrimitive: (in category 'inline primitive generators') ----- - genQuinaryInlinePrimitive: prim - "SistaV1: 248 11111000 iiiiiiii mjjjjjjj Call Primitive #iiiiiiii + (jjjjjjj * 256) m=1 means inlined primitive, no hard return after execution. - See EncoderForSistaV1's class comment and StackInterpreter>>#quaternaryInlinePrimitive:" - ^EncounteredUnknownBytecode! Item was removed: - ----- Method: SistaCogitClone>>isTrapAt: (in category 'simulation only') ----- - isTrapAt: retpc - "For stack depth checking." - <doNotGenerate> - ^(backEnd isCallPrecedingReturnPC: retpc) - and: [(backEnd callTargetFromReturnAddress: retpc) = ceTrapTrampoline]! Item was removed: - ----- Method: SistaCogitClone>>setCogCodeZoneThreshold: (in category 'accessing') ----- - setCogCodeZoneThreshold: threshold - <doNotGenerate> - ^methodZone setCogCodeZoneThreshold: threshold! Item was changed: ----- Method: ThreadedX64SysVFFIPlugin>>ffiPushStructure:ofSize:typeSpec:ofLength:in: (in category 'marshalling') ----- ffiPushStructure: pointer ofSize: structSize typeSpec: argSpec ofLength: argSpecSize in: calloutState <var: #pointer type: #'void *'> <var: #argSpec type: #'sqInt *'> <var: #calloutState type: #'CalloutState *'> <inline: true> | roundedSize doubleType floatType numDoubleRegisters numIntegerRegisters passField0InXmmReg passField1InXmmReg | structSize <= 16 ifTrue: ["See sec 3.2.3 of http://people.freebsd.org/~obrien/amd64-elf-abi.pdf. (dravft version 0.90). All of the folowing are passed in registers: typedef struct { long a; } s0; typedef struct { double a; } s1; typedef struct { long a; double b; } s2; typedef struct { int a; int b; double c; } s2a; typedef struct { short a; short b; short c; short d; double e; } s2b; typedef struct { long a; float b; } s2f; typedef struct { long a; float b; float c; } s2g; but not ones like this: typedef struct { int a; float b; int c; float d; } s2h;" doubleType := FFITypeDoubleFloat << FFIAtomicTypeShift + FFITypeDoubleFloat. floatType := FFITypeDoubleFloat << FFIAtomicTypeShift + FFITypeSingleFloat. passField0InXmmReg := doubleType = ((self cCoerce: argSpec to: #'int *') at: 1) "0th field is struct type and size" or: [floatType = ((self cCoerce: argSpec to: #'int *') at: 1) and: [floatType = ((self cCoerce: argSpec to: #'int *') at: 2)]]. structSize <= 8 ifTrue: [numDoubleRegisters := passField0InXmmReg ifTrue: [1] ifFalse: [0]. numIntegerRegisters := 1 - numDoubleRegisters] ifFalse: [passField1InXmmReg := doubleType = ((self cCoerce: argSpec to: #'int *') at: argSpecSize - 1) "Nth field is last field of struct" or: [floatType = ((self cCoerce: argSpec to: #'int *') at: argSpecSize - 2) and: [floatType = ((self cCoerce: argSpec to: #'int *') at: argSpecSize - 1)]]. numDoubleRegisters := (passField0InXmmReg ifTrue: [1] ifFalse: [0]) + (passField1InXmmReg ifTrue: [1] ifFalse: [0]). numIntegerRegisters := 2 - numDoubleRegisters]. (calloutState floatRegisterIndex + numDoubleRegisters <= NumFloatRegArgs and: [calloutState integerRegisterIndex + numIntegerRegisters <= NumIntRegArgs]) ifTrue: [passField0InXmmReg ifTrue: [self ffiPushDoubleFloat: ((self cCoerceSimple: pointer to: #'double *') at: 0) in: calloutState] ifFalse: [self ffiPushSignedLongLong: ((self cCoerceSimple: pointer to: #'long long *') at: 0) in: calloutState]. structSize > 8 ifTrue: [passField1InXmmReg ifTrue: [self ffiPushDoubleFloat: ((self cCoerceSimple: pointer to: #'double *') at: 1) in: calloutState] ifFalse: [self ffiPushSignedLongLong: ((self cCoerceSimple: pointer to: #'long long *') at: 1) in: calloutState]]. + ^0] ]. - ^0]. roundedSize := structSize + 7 bitClear: 7. calloutState currentArg + roundedSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. self mem: calloutState currentArg cp: (self cCoerceSimple: pointer to: 'char *') y: structSize. + calloutState currentArg: calloutState currentArg + roundedSize. - calloutState currentArg: calloutState currentArg + roundedSize]. ^0!

3 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev October 2017