Vm-dev October 2018

vm-dev@lists.squeakfoundation.org

36 participants
189 discussions

Start a nNew thread

Build completed: opensmalltalk-vm 1.0.1427
by AppVeyor 13 Oct '18

13 Oct '18

1 0

Errored: OpenSmalltalk/opensmalltalk-vm#1449 (Cog - 9791f4d)
by Travis CI 12 Oct '18

12 Oct '18

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1449 Status: Errored Duration: 38 mins and 3 secs Commit: 9791f4d (Cog) Author: Eliot Miranda Message: CogVM source as per VMMaker.oscog-eem.2454 General: Correct a slip in primitiveVMParameter; statMaxAllocSegmentTime is Spur only. Rewrite primitiveGetVMParameter: & primitiveSetVMParameter:arg: as case statements. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/8f5a4f277797...97… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/440785091?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

[OpenSmalltalk/opensmalltalk-vm] 9791f4: CogVM source as per VMMaker.oscog-eem.2454
by GitHub 12 Oct '18

12 Oct '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 9791f4d6c2fd520a74ef87b1637688ba562d5d06 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9791f4d6c2fd520a74… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-10-12 (Fri, 12 Oct 2018) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/cointerpmt.c M spur64src/vm/cointerpmt.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/gcc3x-cointerpmt.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/cointerpmt.c M spursrc/vm/cointerpmt.h M spursrc/vm/gcc3x-cointerp.c M spursrc/vm/gcc3x-cointerpmt.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/vm/cogit.h M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2454 General: Correct a slip in primitiveVMParameter; statMaxAllocSegmentTime is Spur only. Rewrite primitiveGetVMParameter: & primitiveSetVMParameter:arg: as case statements. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

VM Maker: VMMaker.oscog-eem.2454.mcz
by commits＠source.squeak.org 12 Oct '18

12 Oct '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2454.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2454 Author: eem Time: 12 October 2018, 12:25:47.804334 pm UUID: 1a484e25-1628-4326-8054-8d4fbbbc3d65 Ancestors: VMMaker.oscog-eem.2453 General: Correct a slip in primitiveVMParameter; statMaxAllocSegmentTime is Spur only. Rewrite primitiveGetVMParameter: & primitiveSetVMParameter:arg: as case statements. Slang: Consequently fix a bug with various generate*AsArgument:on:indent: forms that failed to output anything if they did constant folding that folded down to a nil block. =============== Diff against VMMaker.oscog-eem.2453 =============== Item was changed: ----- Method: CCodeGenerator>>generateIfFalseAsArgument:on:indent: (in category 'C translation') ----- generateIfFalseAsArgument: msgNode on: aStream indent: level "Generate the C code for this message onto the given stream." (self nilOrBooleanConstantReceiverOf: msgNode receiver) ifNil: ["Eliminate double-negatives" (msgNode receiver isSend and: [msgNode receiver selector == #not]) ifTrue: [^self generateIfTrueAsArgument: (TSendNode new setSelector: msgNode selector receiver: msgNode receiver receiver arguments: msgNode args isBuiltInOp: msgNode isBuiltinOperator) on: aStream indent: level]. aStream nextPutAll: '(!!('. msgNode receiver emitCCodeAsArgumentOn: aStream level: 0 generator: self. aStream nextPut: $); crtab: level + 1; nextPut: $?; space. msgNode args last emitCCodeAsArgumentOn: aStream level: level + 2 generator: self. aStream crtab: level + 1; nextPutAll: ': 0)'] ifNotNil: [:const| + const + ifFalse: [msgNode args first emitCCodeAsArgumentOn: aStream level: level generator: self] + ifTrue: [aStream nextPutAll: (self cLiteralFor: nil)]]! - const ifFalse: - [msgNode args first emitCCodeAsArgumentOn: aStream level: level generator: self]]! Item was changed: ----- Method: CCodeGenerator>>generateIfNotNilAsArgument:on:indent: (in category 'C translation') ----- generateIfNotNilAsArgument: msgNode on: aStream indent: level "Generate the C code for this message onto the given stream." (self isNilConstantReceiverOf: msgNode) ifFalse: [aStream nextPut: $(. msgNode receiver emitCCodeAsArgumentOn: aStream level: level generator: self. aStream crtab: level + 1; nextPut: $?; space. msgNode args first emitCCodeAsArgumentOn: aStream level: level + 2 generator: self. + aStream crtab: level + 1; nextPutAll: ': 0)'] + ifTrue: + [aStream nextPutAll: (self cLiteralFor: nil)]! - aStream crtab: level + 1; nextPutAll: ': 0)']! Item was changed: ----- Method: CCodeGenerator>>generateIfTrueAsArgument:on:indent: (in category 'C translation') ----- generateIfTrueAsArgument: msgNode on: aStream indent: level "Generate the C code for this message onto the given stream." (self nilOrBooleanConstantReceiverOf: msgNode receiver) ifNil: [aStream nextPut: $(. msgNode receiver emitCCodeAsArgumentOn: aStream level: level generator: self. aStream crtab: level + 1; nextPut: $?; space. msgNode args first emitCCodeAsArgumentOn: aStream level: level + 2 generator: self. aStream crtab: level + 1; nextPutAll: ': 0)'] ifNotNil: [:const| + const + ifTrue: [msgNode args first emitCCodeAsArgumentOn: aStream level: level generator: self] + ifFalse: [aStream nextPutAll: (self cLiteralFor: nil)]]! - const ifTrue: - [msgNode args first emitCCodeAsArgumentOn: aStream level: level generator: self]]! Item was changed: ----- Method: CCodeGenerator>>generateIfTrueIfFalseAsArgument:on:indent: (in category 'C translation') ----- generateIfTrueIfFalseAsArgument: msgNode on: aStream indent: level "Generate the C code for this message onto the given stream." (self nilOrBooleanConstantReceiverOf: msgNode receiver) ifNil: [(self tryToCollapseBothArmsOfConditionalExpression: msgNode on: aStream indent: level) ifFalse: [aStream nextPut: $(. msgNode receiver emitCCodeAsExpressionOn: aStream level: level generator: self. aStream crtab: level + 1; nextPut: $?; space. msgNode args first emitCCodeAsArgumentOn: aStream level: level + 2 generator: self. aStream crtab: level + 1; nextPut: $:; space. msgNode args last emitCCodeAsArgumentOn: aStream level: level + 2 generator: self. aStream nextPut: $)]] ifNotNil: [:const| + (const + ifTrue: [msgNode args first] + ifFalse: [msgNode args last]) + emitCCodeAsArgumentOn: aStream level: level generator: self]! - (const ifTrue: [msgNode args first] ifFalse: [msgNode args last]) - emitCCodeAsArgumentOn: aStream level: level generator: self]! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveAllVMParameters: (in category 'system control primitives') ----- primitiveAllVMParameters: paramsArraySize "See primitiveVMParameter method comment" | result | result := objectMemory instantiateClass: (objectMemory splObj: ClassArray) indexableSize: paramsArraySize. objectMemory storePointerUnchecked: 0 ofObject: result withValue: (self positiveMachineIntegerFor: objectMemory oldSpaceSize). objectMemory storePointerUnchecked: 1 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory newSpaceSize). objectMemory storePointerUnchecked: 2 ofObject: result withValue: (self positiveMachineIntegerFor: objectMemory totalMemorySize). "objectMemory storePointerUnchecked: 3 ofObject: result withValue: objectMemory nilObject was allocationCount". "objectMemory storePointerUnchecked: 4 ofObject: result withValue: objectMemory nilObject allocationsBetweenGCs". objectMemory storePointerUnchecked: 5 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory tenuringThreshold). objectMemory storePointerUnchecked: 6 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statFullGCs). objectMemory storePointerUnchecked: 7 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statFullGCUsecs + 500 // 1000). objectMemory storePointerUnchecked: 8 ofObject: result withValue: (objectMemory integerObjectOf: (objectMemory hasSpurMemoryManagerAPI ifTrue: [objectMemory statScavenges] ifFalse: [objectMemory statIncrGCs])). objectMemory storePointerUnchecked: 9 ofObject: result withValue: (objectMemory integerObjectOf: (objectMemory hasSpurMemoryManagerAPI ifTrue: [objectMemory statScavengeGCUsecs] ifFalse: [objectMemory statIncrGCUsecs]) + 500 // 1000). objectMemory storePointerUnchecked: 10 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statTenures). "JITTER VM info unused; 11 - 14/12 - 15 available for reuse" 11 to: 18 do: [:i | objectMemory storePointerUnchecked: i ofObject: result withValue: ConstZero]. objectMemory storePointerUnchecked: 15 ofObject: result withValue: (objectMemory positive64BitIntegerFor: statIdleUsecs). (SistaVM and: [self isCog]) ifTrue: [objectMemory storePointerUnchecked: 16 ofObject: result withValue: (objectMemory floatObjectOf: self getCogCodeZoneThreshold)]. objectMemory hasSpurMemoryManagerAPI ifTrue: [objectMemory storePointerUnchecked: 17 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statCompactionUsecs + 500 // 1000); storePointerUnchecked: 18 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory scavengeThresholdAsExtent)]. objectMemory storePointerUnchecked: 19 ofObject: result withValue: (objectMemory positive64BitIntegerFor: self ioUTCStartMicroseconds). objectMemory storePointerUnchecked: 20 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory rootTableCount). objectMemory storePointerUnchecked: 21 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statRootTableOverflows). objectMemory storePointerUnchecked: 22 ofObject: result withValue: (objectMemory integerObjectOf: extraVMMemory). objectMemory storePointerUnchecked: 23 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory shrinkThreshold). objectMemory storePointerUnchecked: 24 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory growHeadroom). objectMemory storePointerUnchecked: 25 ofObject: result withValue: (objectMemory integerObjectOf: self ioHeartbeatMilliseconds). objectMemory storePointerUnchecked: 26 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statMarkCount). objectMemory storePointerUnchecked: 27 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statSweepCount). objectMemory storePointerUnchecked: 28 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statMkFwdCount). objectMemory storePointerUnchecked: 29 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statCompMoveCount). objectMemory storePointerUnchecked: 30 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statGrowMemory). objectMemory storePointerUnchecked: 31 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statShrinkMemory). objectMemory storePointerUnchecked: 32 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statRootTableCount). objectMemory hasSpurMemoryManagerAPI ifTrue: "was statAllocationCount" [objectMemory storePointerUnchecked: 33 ofObject: result withValue: (objectMemory positive64BitIntegerFor: objectMemory currentAllocatedBytes)]. objectMemory storePointerUnchecked: 34 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statSurvivorCount). objectMemory storePointerUnchecked: 35 ofObject: result withValue: (objectMemory integerObjectOf: (self microsecondsToMilliseconds: objectMemory statGCEndUsecs)). objectMemory storePointerUnchecked: 36 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statSpecialMarkCount). objectMemory storePointerUnchecked: 37 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statIGCDeltaUsecs + 500 // 1000). objectMemory storePointerUnchecked: 38 ofObject: result withValue: (objectMemory integerObjectOf: statPendingFinalizationSignals). objectMemory storePointerUnchecked: 39 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory wordSize). objectMemory storePointerUnchecked: 40 ofObject: result withValue: (objectMemory integerObjectOf: self imageFormatVersion). objectMemory storePointerUnchecked: 41 ofObject: result withValue: (objectMemory integerObjectOf: numStackPages). objectMemory storePointerUnchecked: 42 ofObject: result withValue: (objectMemory integerObjectOf: desiredNumStackPages). objectMemory storePointerUnchecked: 43 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory edenBytes). objectMemory storePointerUnchecked: 44 ofObject: result withValue: (objectMemory integerObjectOf: desiredEdenBytes). objectMemory storePointerUnchecked: 45 ofObject: result withValue: self getCogCodeSize. objectMemory storePointerUnchecked: 46 ofObject: result withValue: self getDesiredCogCodeSize. objectMemory storePointerUnchecked: 47 ofObject: result withValue: self getCogVMFlags. objectMemory storePointerUnchecked: 48 ofObject: result withValue: (objectMemory integerObjectOf: self ioGetMaxExtSemTableSize). "50 & 51 (49 & 50) reserved for parameters that persist in the image" objectMemory storePointerUnchecked: 51 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory rootTableCapacity). objectMemory hasSpurMemoryManagerAPI ifTrue: [objectMemory storePointerUnchecked: 52 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory numSegments); storePointerUnchecked: 53 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory freeSize); storePointerUnchecked: 54 ofObject: result withValue: (objectMemory floatObjectOf: objectMemory getHeapGrowthToSizeGCRatio)]. objectMemory storePointerUnchecked: 55 ofObject: result withValue: (self positive64BitIntegerFor: statProcessSwitch). objectMemory storePointerUnchecked: 56 ofObject: result withValue: (self positive64BitIntegerFor: statIOProcessEvents). objectMemory storePointerUnchecked: 57 ofObject: result withValue: (self positive64BitIntegerFor: statForceInterruptCheck). objectMemory storePointerUnchecked: 58 ofObject: result withValue: (self positive64BitIntegerFor: statCheckForEvents). objectMemory storePointerUnchecked: 59 ofObject: result withValue: (self positive64BitIntegerFor: statStackOverflow). objectMemory storePointerUnchecked: 60 ofObject: result withValue: (self positive64BitIntegerFor: statStackPageDivorce). objectMemory storePointerUnchecked: 61 ofObject: result withValue: self getCodeCompactionCount. objectMemory storePointerUnchecked: 62 ofObject: result withValue: self getCodeCompactionMSecs. objectMemory storePointerUnchecked: 63 ofObject: result withValue: self getCogMethodCount. objectMemory storePointerUnchecked: 64 ofObject: result withValue: self getCogVMFeatureFlags. objectMemory storePointerUnchecked: 65 ofObject: result withValue: (objectMemory integerObjectOf: self stackPageByteSize). objectMemory hasSpurMemoryManagerAPI ifTrue: [objectMemory storePointerUnchecked: 66 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory maxOldSpaceSize)]. objectMemory storePointerUnchecked: 67 ofObject: result withValue: (objectMemory floatObjectOf: stackPages statAverageLivePagesWhenMapping). objectMemory storePointerUnchecked: 68 ofObject: result withValue: (objectMemory integerObjectOf: stackPages statMaxPageCountWhenMapping). objectMemory storePointerUnchecked: 69 ofObject: result withValue: (objectMemory integerObjectOf: (self cCode: 'VM_PROXY_MAJOR' inSmalltalk: [self class vmProxyMajorVersion])). objectMemory storePointerUnchecked: 70 ofObject: result withValue: (objectMemory integerObjectOf: (self cCode: 'VM_PROXY_MINOR' inSmalltalk: [self class vmProxyMinorVersion])). objectMemory storePointerUnchecked: 71 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statMarkUsecs + 500 // 1000). objectMemory storePointerUnchecked: 72 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statSweepUsecs + 500 // 1000). + objectMemory hasSpurMemoryManagerAPI ifTrue: + [objectMemory + storePointerUnchecked: 73 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statMaxAllocSegmentTime + 500 // 1000)]. + - objectMemory storePointerUnchecked: 73 ofObject: result withValue: (objectMemory integerObjectOf: objectMemory statMaxAllocSegmentTime + 500 // 1000). objectMemory beRootIfOld: result. + self methodReturnValue: result! - self pop: 1 thenPush: result. - ^nil! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveGetVMParameter: (in category 'system control primitives') ----- primitiveGetVMParameter: arg + "See primitiveVMParameter method comment. + N.B. written as a returning case to avoid branch limits in the V3 bytecode set." + arg caseOf: { + [1] -> [^self positiveMachineIntegerFor: objectMemory oldSpaceSize]. + [2] -> [^objectMemory integerObjectOf: objectMemory newSpaceSize]. + [3] -> [^self positiveMachineIntegerFor: objectMemory totalMemorySize]. + [6] -> [^objectMemory integerObjectOf: objectMemory tenuringThreshold]. + [7] -> [^objectMemory integerObjectOf: objectMemory statFullGCs]. + [8] -> [^objectMemory integerObjectOf: objectMemory statFullGCUsecs + 500 // 1000]. + [9] -> [^objectMemory integerObjectOf: (objectMemory hasSpurMemoryManagerAPI + ifTrue: [objectMemory statScavenges] + ifFalse: [objectMemory statIncrGCs])]. + [10] -> [^objectMemory integerObjectOf: (objectMemory hasSpurMemoryManagerAPI + ifTrue: [objectMemory statScavengeGCUsecs] + ifFalse: [objectMemory statIncrGCUsecs]) + 500 // 1000]. + [11] -> [^objectMemory integerObjectOf: objectMemory statTenures]. + [12] -> [^ConstZero]. "Was JITTER VM info" + [13] -> [^ConstZero]. "Was JITTER VM info" + [14] -> [^ConstZero]. "Was JITTER VM info" + [15] -> [^ConstZero]. "Was JITTER VM info" + [16] -> [^self positive64BitIntegerFor: statIdleUsecs]. + [17] -> [^(SistaVM and: [self isCog]) + ifTrue: [objectMemory floatObjectOf: self getCogCodeZoneThreshold] + ifFalse: [ConstZero]]. + [18] -> [^objectMemory hasSpurMemoryManagerAPI + ifTrue: [objectMemory integerObjectOf: objectMemory statCompactionUsecs + 500 // 1000] + ifFalse: [ConstZero]]. + [19] -> [^objectMemory hasSpurMemoryManagerAPI + ifTrue: [objectMemory integerObjectOf: objectMemory scavengeThresholdAsExtent] + ifFalse: [ConstZero]]. + [20] -> [^objectMemory positive64BitIntegerFor: self ioUTCStartMicroseconds]. + [21] -> [^objectMemory integerObjectOf: objectMemory rootTableCount]. + [22] -> [^objectMemory integerObjectOf: objectMemory statRootTableOverflows]. + [23] -> [^objectMemory integerObjectOf: extraVMMemory]. + [24] -> [^objectMemory integerObjectOf: objectMemory shrinkThreshold]. + [25] -> [^objectMemory integerObjectOf: objectMemory growHeadroom]. + [26] -> [^objectMemory integerObjectOf: self ioHeartbeatMilliseconds]. + [27] -> [^objectMemory integerObjectOf: objectMemory statMarkCount]. + [28] -> [^objectMemory integerObjectOf: objectMemory statSweepCount]. + [29] -> [^objectMemory integerObjectOf: objectMemory statMkFwdCount]. + [30] -> [^objectMemory integerObjectOf: objectMemory statCompMoveCount]. + [31] -> [^objectMemory integerObjectOf: objectMemory statGrowMemory]. + [32] -> [^objectMemory integerObjectOf: objectMemory statShrinkMemory]. + [33] -> [^objectMemory integerObjectOf: objectMemory statRootTableCount]. + [34] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue:"was statAllocationCount" + [objectMemory positive64BitIntegerFor: objectMemory currentAllocatedBytes]]. + [35] -> [^objectMemory integerObjectOf: objectMemory statSurvivorCount]. + [36] -> [^objectMemory integerObjectOf: (self microsecondsToMilliseconds: objectMemory statGCEndUsecs)]. + [37] -> [^objectMemory integerObjectOf: objectMemory statSpecialMarkCount]. + [38] -> [^objectMemory integerObjectOf: objectMemory statIGCDeltaUsecs + 500 // 1000]. + [39] -> [^objectMemory integerObjectOf: statPendingFinalizationSignals]. + [40] -> [^objectMemory integerObjectOf: objectMemory wordSize]. + [41] -> [^objectMemory integerObjectOf: self imageFormatVersion]. + [42] -> [^objectMemory integerObjectOf: numStackPages]. + [43] -> [^objectMemory integerObjectOf: desiredNumStackPages]. + [44] -> [^objectMemory integerObjectOf: objectMemory edenBytes]. + [45] -> [^objectMemory integerObjectOf: desiredEdenBytes]. + [46] -> [^self getCogCodeSize]. + [47] -> [^self getDesiredCogCodeSize]. + [48] -> [^self getCogVMFlags]. + [49] -> [^objectMemory integerObjectOf: self ioGetMaxExtSemTableSize]. + [52] -> [^objectMemory integerObjectOf: objectMemory rootTableCapacity]. + [53] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue: + [objectMemory integerObjectOf: objectMemory numSegments]]. + [54] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue: + [objectMemory integerObjectOf: objectMemory freeSize]]. + [55] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue: + [objectMemory floatObjectOf: objectMemory getHeapGrowthToSizeGCRatio]]. + [56] -> [^self positive64BitIntegerFor: statProcessSwitch]. + [57] -> [^self positive64BitIntegerFor: statIOProcessEvents]. + [58] -> [^self positive64BitIntegerFor: statForceInterruptCheck]. + [59] -> [^self positive64BitIntegerFor: statCheckForEvents]. + [60] -> [^self positive64BitIntegerFor: statStackOverflow]. + [61] -> [^self positive64BitIntegerFor: statStackPageDivorce]. + [62] -> [^self getCodeCompactionCount]. + [63] -> [^self getCodeCompactionMSecs]. + [64] -> [^self getCogMethodCount]. + [65] -> [^self getCogVMFeatureFlags]. + [66] -> [^objectMemory integerObjectOf: self stackPageByteSize]. + [67] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue: + [objectMemory integerObjectOf: objectMemory maxOldSpaceSize]]. + [68] -> [^objectMemory floatObjectOf: stackPages statAverageLivePagesWhenMapping]. + [69] -> [^objectMemory integerObjectOf: stackPages statMaxPageCountWhenMapping]. + [70] -> [^self integerObjectOf: (self cCode: 'VM_PROXY_MAJOR' inSmalltalk: [self class vmProxyMajorVersion])]. + [71] -> [^self integerObjectOf: (self cCode: 'VM_PROXY_MINOR' inSmalltalk: [self class vmProxyMinorVersion])]. + [72] -> [^objectMemory integerObjectOf: objectMemory statMarkUsecs + 500 // 1000]. + [73] -> [^objectMemory integerObjectOf: objectMemory statSweepUsecs + 500 // 1000]. + [74] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue: + [objectMemory integerObjectOf: objectMemory statMaxAllocSegmentTime + 500 // 1000]] } + otherwise: [^nil]! - "See primitiveVMParameter method comment" - | result | - result := objectMemory nilObject. - arg = 1 ifTrue: [result := self positiveMachineIntegerFor: objectMemory oldSpaceSize]. - arg = 2 ifTrue: [result := objectMemory integerObjectOf: objectMemory newSpaceSize]. - arg = 3 ifTrue: [result := self positiveMachineIntegerFor: objectMemory totalMemorySize]. - arg = 4 ifTrue: [result := objectMemory nilObject "was allocationCount"]. - arg = 5 ifTrue: [result := objectMemory nilObject "was allocationsBetweenGCs"]. - arg = 6 ifTrue: [result := objectMemory integerObjectOf: objectMemory tenuringThreshold]. - arg = 7 ifTrue: [result := objectMemory integerObjectOf: objectMemory statFullGCs]. - arg = 8 ifTrue: [result := objectMemory integerObjectOf: objectMemory statFullGCUsecs + 500 // 1000]. - arg = 9 ifTrue: [result := objectMemory integerObjectOf: (objectMemory hasSpurMemoryManagerAPI - ifTrue: [objectMemory statScavenges] - ifFalse: [objectMemory statIncrGCs])]. - arg = 10 ifTrue: [result := objectMemory integerObjectOf: (objectMemory hasSpurMemoryManagerAPI - ifTrue: [objectMemory statScavengeGCUsecs] - ifFalse: [objectMemory statIncrGCUsecs]) + 500 // 1000]. - arg = 11 ifTrue: [result := objectMemory integerObjectOf: objectMemory statTenures]. - (arg between: 12 and: 15) ifTrue: [result := ConstZero]. "Was JITTER VM info" - arg = 16 ifTrue: [result := self positive64BitIntegerFor: statIdleUsecs]. - arg = 17 ifTrue: [result := (SistaVM and: [self isCog]) - ifTrue: [objectMemory floatObjectOf: self getCogCodeZoneThreshold] - ifFalse: [ConstZero]]. - arg = 18 ifTrue: [result := objectMemory hasSpurMemoryManagerAPI - ifTrue: [objectMemory integerObjectOf: objectMemory statCompactionUsecs + 500 // 1000] - ifFalse: [ConstZero]]. - arg = 19 ifTrue: [result := objectMemory hasSpurMemoryManagerAPI - ifTrue: [objectMemory integerObjectOf: objectMemory scavengeThresholdAsExtent] - ifFalse: [ConstZero]]. - arg = 20 ifTrue: [result := objectMemory positive64BitIntegerFor: self ioUTCStartMicroseconds]. - arg = 21 ifTrue: [result := objectMemory integerObjectOf: objectMemory rootTableCount]. - arg = 22 ifTrue: [result := objectMemory integerObjectOf: objectMemory statRootTableOverflows]. - arg = 23 ifTrue: [result := objectMemory integerObjectOf: extraVMMemory]. - arg = 24 ifTrue: [result := objectMemory integerObjectOf: objectMemory shrinkThreshold]. - arg = 25 ifTrue: [result := objectMemory integerObjectOf: objectMemory growHeadroom]. - arg = 26 ifTrue: [result := objectMemory integerObjectOf: self ioHeartbeatMilliseconds]. - arg = 27 ifTrue: [result := objectMemory integerObjectOf: objectMemory statMarkCount]. - arg = 28 ifTrue: [result := objectMemory integerObjectOf: objectMemory statSweepCount]. - arg = 29 ifTrue: [result := objectMemory integerObjectOf: objectMemory statMkFwdCount]. - arg = 30 ifTrue: [result := objectMemory integerObjectOf: objectMemory statCompMoveCount]. - arg = 31 ifTrue: [result := objectMemory integerObjectOf: objectMemory statGrowMemory]. - arg = 32 ifTrue: [result := objectMemory integerObjectOf: objectMemory statShrinkMemory]. - arg = 33 ifTrue: [result := objectMemory integerObjectOf: objectMemory statRootTableCount]. - arg = 34 ifTrue: [result := objectMemory hasSpurMemoryManagerAPI "was statAllocationCount" - ifTrue: [objectMemory positive64BitIntegerFor: objectMemory currentAllocatedBytes] - ifFalse: [objectMemory nilObject]]. - arg = 35 ifTrue: [result := objectMemory integerObjectOf: objectMemory statSurvivorCount]. - arg = 36 ifTrue: [result := objectMemory integerObjectOf: (self microsecondsToMilliseconds: objectMemory statGCEndUsecs)]. - arg = 37 ifTrue: [result := objectMemory integerObjectOf: objectMemory statSpecialMarkCount]. - arg = 38 ifTrue: [result := objectMemory integerObjectOf: objectMemory statIGCDeltaUsecs + 500 // 1000]. - arg = 39 ifTrue: [result := objectMemory integerObjectOf: statPendingFinalizationSignals]. - arg = 40 ifTrue: [result := objectMemory integerObjectOf: objectMemory wordSize]. - arg = 41 ifTrue: [result := objectMemory integerObjectOf: self imageFormatVersion]. - arg = 42 ifTrue: [result := objectMemory integerObjectOf: numStackPages]. - arg = 43 ifTrue: [result := objectMemory integerObjectOf: desiredNumStackPages]. - arg = 44 ifTrue: [result := objectMemory integerObjectOf: objectMemory edenBytes]. - arg = 45 ifTrue: [result := objectMemory integerObjectOf: desiredEdenBytes]. - arg = 46 ifTrue: [result := self getCogCodeSize]. - arg = 47 ifTrue: [result := self getDesiredCogCodeSize]. - arg = 48 ifTrue: [result := self getCogVMFlags]. - arg = 49 ifTrue: [result := objectMemory integerObjectOf: self ioGetMaxExtSemTableSize]. - arg = 52 ifTrue: [result := objectMemory integerObjectOf: objectMemory rootTableCapacity]. - (arg = 53 - and: [objectMemory hasSpurMemoryManagerAPI]) ifTrue: - [result := objectMemory integerObjectOf: objectMemory numSegments]. - (arg = 54 - and: [objectMemory hasSpurMemoryManagerAPI]) ifTrue: - [result := objectMemory integerObjectOf: objectMemory freeSize]. - (arg = 55 - and: [objectMemory hasSpurMemoryManagerAPI]) ifTrue: - [result := objectMemory floatObjectOf: objectMemory getHeapGrowthToSizeGCRatio]. - arg = 56 ifTrue: [result := self positive64BitIntegerFor: statProcessSwitch]. - arg = 57 ifTrue: [result := self positive64BitIntegerFor: statIOProcessEvents]. - arg = 58 ifTrue: [result := self positive64BitIntegerFor: statForceInterruptCheck]. - arg = 59 ifTrue: [result := self positive64BitIntegerFor: statCheckForEvents]. - arg = 60 ifTrue: [result := self positive64BitIntegerFor: statStackOverflow]. - arg = 61 ifTrue: [result := self positive64BitIntegerFor: statStackPageDivorce]. - arg = 62 ifTrue: [result := self getCodeCompactionCount]. - arg = 63 ifTrue: [result := self getCodeCompactionMSecs]. - arg = 64 ifTrue: [result := self getCogMethodCount]. - arg = 65 ifTrue: [result := self getCogVMFeatureFlags]. - arg = 66 ifTrue: [result := objectMemory integerObjectOf: self stackPageByteSize]. - (arg = 67 - and: [objectMemory hasSpurMemoryManagerAPI]) ifTrue: - [result := objectMemory integerObjectOf: objectMemory maxOldSpaceSize]. - arg = 68 ifTrue: [result := objectMemory floatObjectOf: stackPages statAverageLivePagesWhenMapping]. - arg = 69 ifTrue: [result := objectMemory integerObjectOf: stackPages statMaxPageCountWhenMapping]. - arg = 70 ifTrue: [result := self integerObjectOf: (self cCode: 'VM_PROXY_MAJOR' inSmalltalk: [self class vmProxyMajorVersion])]. - arg = 71 ifTrue: [result := self integerObjectOf: (self cCode: 'VM_PROXY_MINOR' inSmalltalk: [self class vmProxyMinorVersion])]. - arg = 72 ifTrue: [result := objectMemory integerObjectOf: objectMemory statMarkUsecs + 500 // 1000]. - arg = 73 ifTrue: [result := objectMemory integerObjectOf: objectMemory statSweepUsecs + 500 // 1000]. - arg = 74 ifTrue: [result := objectMemory integerObjectOf: objectMemory statMaxAllocSegmentTime + 500 // 1000]. - self pop: 2 thenPush: result. - ^nil! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveSetVMParameter:arg: (in category 'system control primitives') ----- + primitiveSetVMParameter: index arg: argOop - primitiveSetVMParameter: index arg: arg "See primitiveVMParameter method comment" + | arg result | + + "argOop read & checks; in most cases this is an integer parameter. In some it is either an integer or a Float" + (index = 17 or: [index = 55 or: [index = 68]]) + ifTrue: + [((objectMemory isFloatInstance: argOop) + or: [objectMemory isIntegerObject: argOop]) ifFalse: + [^self primitiveFailFor: PrimErrBadArgument]] + ifFalse: + [(objectMemory isIntegerObject: argOop) ifFalse: + [^self primitiveFailFor: PrimErrBadArgument]. + arg := objectMemory integerValueOf: argOop]. + - | result | "assume failure, then set success for handled indices" self primitiveFailFor: PrimErrBadArgument. + index caseOf: { + [5] -> [objectMemory hasSpurMemoryManagerAPI ifFalse: + ["Was: + result := allocationsBetweenGCs. + allocationsBetweenGCs := arg." + "Ignore for now, because old images won't start up otherwise. + See 45 for eden size setting." + result := objectMemory nilObject. + self initPrimCall]]. + [6] -> [result := objectMemory integerObjectOf: objectMemory tenuringThreshold. + primFailCode := objectMemory tenuringThreshold: arg]. + [11] -> [arg >= 0 ifTrue: + [result := objectMemory integerObjectOf: objectMemory statTenures. + objectMemory statTenures: arg. + self initPrimCall]]. + [17] -> [(SistaVM and: [self isCog]) ifTrue: + [result := objectMemory floatObjectOf: self getCogCodeZoneThreshold. + primFailCode := self setCogCodeZoneThreshold: (self noInlineLoadFloatOrIntFrom: argOop)]]. + [23] -> [result := objectMemory integerObjectOf: extraVMMemory. + extraVMMemory := arg. + self initPrimCall]. + [24] -> [arg > 0 ifTrue: + [result := objectMemory integerObjectOf: objectMemory shrinkThreshold. + objectMemory shrinkThreshold: arg. + self initPrimCall]]. + [25] -> [arg > 0 ifTrue: + [result := objectMemory integerObjectOf: objectMemory growHeadroom. + objectMemory growHeadroom: arg. + self initPrimCall]]. + [26] -> [arg >= 0 ifTrue: "0 turns off the heartbeat" + [result := objectMemory integerObjectOf: self ioHeartbeatMilliseconds. + self ioSetHeartbeatMilliseconds: arg. + self initPrimCall]]. + [34] -> [(objectMemory hasSpurMemoryManagerAPI "was statAllocationCount; now statAllocatedBytes" + and: [arg >= 0]) ifTrue: + [result := objectMemory positive64BitIntegerFor: objectMemory currentAllocatedBytes. + objectMemory setCurrentAllocatedBytesTo: arg. + self initPrimCall]]. + [43] -> [(arg between: 0 and: 65535) ifTrue: + [result := objectMemory integerObjectOf: desiredNumStackPages. + desiredNumStackPages := arg. + self initPrimCall]]. + [45] -> [arg >= 0 ifTrue: + [result := objectMemory integerObjectOf: desiredEdenBytes. + desiredEdenBytes := arg. + self initPrimCall]]. + [47] -> [(self isCog + and: [arg between: 0 and: self maxCogCodeSize]) ifTrue: + [result := objectMemory integerObjectOf: self getDesiredCogCodeSize. + self setDesiredCogCodeSize: arg. + self initPrimCall]]. + [48] -> [arg >= 0 ifTrue: + [result := objectMemory integerObjectOf: self getCogVMFlags. + self initPrimCall. "i.e. setCogVMFlags: can fail" + self setCogVMFlags: arg]]. + [49] -> [(arg between: 0 and: 65535) ifTrue: + [result := objectMemory integerObjectOf: self ioGetMaxExtSemTableSize. + self initPrimCall. "i.e. ioSetMaxExtSemTableSize: is allowed to fail" + self setMaxExtSemSizeTo: arg]]. + [55] -> [objectMemory hasSpurMemoryManagerAPI ifTrue: + [result := objectMemory floatObjectOf: objectMemory getHeapGrowthToSizeGCRatio. + primFailCode := objectMemory setHeapGrowthToSizeGCRatio: (self noInlineLoadFloatOrIntFrom: argOop)]]. + [67] -> [(arg >= 0 + and: [objectMemory hasSpurMemoryManagerAPI]) ifTrue: + [result := objectMemory integerObjectOf: objectMemory maxOldSpaceSize. + primFailCode := objectMemory setMaxOldSpaceSize: arg]]. + [68] -> [result := objectMemory floatObjectOf: stackPages statAverageLivePagesWhenMapping. + self initPrimCall. "i.e. statAverageLivePagesWhenMapping: is allowed to fail" + stackPages statAverageLivePagesWhenMapping: (self noInlineLoadFloatOrIntFrom: argOop)]. + [69] -> [arg >= 0 ifTrue: + [result := objectMemory integerObjectOf: stackPages statMaxPageCountWhenMapping. + stackPages statMaxPageCountWhenMapping: arg. + self initPrimCall]]. + [74] -> [(arg >= 0 + and: [objectMemory hasSpurMemoryManagerAPI]) ifTrue: + [result := objectMemory integerObjectOf: objectMemory statMaxAllocSegmentTime + 500 // 1000. + stackPages statMaxAllocSegmentTime: arg. "usually 0" + self initPrimCall]] } + otherwise: []. - objectMemory hasSpurMemoryManagerAPI ifFalse: - [index = 5 ifTrue: "Was: - result := allocationsBetweenGCs. - allocationsBetweenGCs := arg." - "Ignore for now, because old images won't start up otherwise. - See 44 & 45 for eden size setting." - [result := objectMemory nilObject. - self initPrimCall]]. - index = 6 ifTrue: - [result := objectMemory integerObjectOf: objectMemory tenuringThreshold. - primFailCode := objectMemory tenuringThreshold: arg]. - index = 11 ifTrue: - [result := objectMemory integerObjectOf: objectMemory statTenures. - arg >= 0 ifTrue: - [objectMemory statTenures: arg. - self initPrimCall]]. - (SistaVM and: [self isCog and: [index = 17]]) ifTrue: - [result := objectMemory floatObjectOf: self getCogCodeZoneThreshold. - primFailCode := self setCogCodeZoneThreshold: (self noInlineLoadFloatOrIntFrom: arg)]. - index = 23 ifTrue: - [result := objectMemory integerObjectOf: extraVMMemory. - extraVMMemory := arg. - self initPrimCall]. - index = 24 ifTrue: - [result := objectMemory integerObjectOf: objectMemory shrinkThreshold. - arg > 0 ifTrue: - [objectMemory shrinkThreshold: arg. - self initPrimCall]]. - index = 25 ifTrue: - [result := objectMemory integerObjectOf: objectMemory growHeadroom. - arg > 0 ifTrue: - [objectMemory growHeadroom: arg. - self initPrimCall]]. - index = 26 ifTrue: - [arg >= 0 ifTrue: "0 turns off the heartbeat" - [result := objectMemory integerObjectOf: self ioHeartbeatMilliseconds. - self ioSetHeartbeatMilliseconds: arg. - self initPrimCall]]. - (index = 34 and: [objectMemory hasSpurMemoryManagerAPI]) ifTrue:"was statAllocationCount; now statAllocatedBytes" - [arg >= 0 ifTrue: - [result := objectMemory positive64BitIntegerFor: objectMemory currentAllocatedBytes. - objectMemory setCurrentAllocatedBytesTo: arg. - self initPrimCall]]. - index = 43 ifTrue: - [(arg >= 0 and: [arg <= 65535]) ifTrue: - [result := objectMemory integerObjectOf: desiredNumStackPages. - desiredNumStackPages := arg. - self initPrimCall]]. - index = 45 ifTrue: - [(arg >= 0) ifTrue: - [result := objectMemory integerObjectOf: desiredEdenBytes. - desiredEdenBytes := arg. - self initPrimCall]]. - (index = 47 and: [self isCog]) ifTrue: - [(arg >= 0 and: [arg <= self maxCogCodeSize]) ifTrue: - [result := objectMemory integerObjectOf: self getDesiredCogCodeSize. - self setDesiredCogCodeSize: arg. - self initPrimCall]]. - index = 48 ifTrue: - [(arg >= 0) ifTrue: - [result := objectMemory integerObjectOf: self getCogVMFlags. - self initPrimCall. "i.e. setCogVMFlags: can fail" - self setCogVMFlags: arg]]. - index = 49 ifTrue: - [(arg >= 0 and: [arg <= 65535]) ifTrue: - [result := objectMemory integerObjectOf: self ioGetMaxExtSemTableSize. - self initPrimCall. "i.e. ioSetMaxExtSemTableSize: is allowed to fail" - self setMaxExtSemSizeTo: arg]]. + self successful + ifTrue: [self methodReturnValue: result] "return old value" + ifFalse: [self primitiveFailFor: PrimErrInappropriate] "attempting to write a read-only or non-existent parameter"! - (index = 55 - and: [objectMemory hasSpurMemoryManagerAPI]) ifTrue: - [result := objectMemory floatObjectOf: objectMemory getHeapGrowthToSizeGCRatio. - primFailCode := objectMemory setHeapGrowthToSizeGCRatio: (self noInlineLoadFloatOrIntFrom: arg)]. - - (index = 67 - and: [arg >= 0 - and: [objectMemory hasSpurMemoryManagerAPI]]) ifTrue: - [result := objectMemory integerObjectOf: objectMemory maxOldSpaceSize. - primFailCode := objectMemory setMaxOldSpaceSize: arg]. - - index = 68 ifTrue: - [result := objectMemory floatObjectOf: stackPages statAverageLivePagesWhenMapping. - self initPrimCall. "i.e. statAverageLivePagesWhenMapping: is allowed to fail" - stackPages statAverageLivePagesWhenMapping: (self noInlineLoadFloatOrIntFrom: arg)]. - - (index = 69 - and: [arg >= 0]) ifTrue: - [result := objectMemory integerObjectOf: stackPages statMaxPageCountWhenMapping. - stackPages statMaxPageCountWhenMapping: arg. - self initPrimCall]. - - (index = 74 - and: [arg >= 0]) ifTrue: - [result := objectMemory integerObjectOf: objectMemory statMaxAllocSegmentTime + 500 // 1000. - stackPages statMaxAllocSegmentTime: arg. "usually 0" - self initPrimCall]. - - self successful ifTrue: - [self pop: 3 thenPush: result. "return old value" - ^nil]. - - self primitiveFailFor: PrimErrInappropriate "attempting to write a read-only or non-existent parameter"! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveVMParameter (in category 'system control primitives') ----- primitiveVMParameter "Behaviour depends on argument count: 0 args: return an Array of VM parameter values; 1 arg: return the indicated VM parameter; 2 args: set the VM indicated parameter. VM parameters are numbered as follows: 1 end (v3)/size(Spur) of old-space (0-based, read-only) 2 end (v3)/size(Spur) of young/new-space (read-only) 3 end (v3)/size(Spur) of heap (read-only) 4 nil (was allocationCount (read-only)) 5 nil (was allocations between GCs (read-write) 6 survivor count tenuring threshold (read-write) 7 full GCs since startup (read-only) 8 total milliseconds in full GCs since startup (read-only) 9 incremental GCs (SqueakV3) or scavenges (Spur) since startup (read-only) 10 total milliseconds in incremental GCs (SqueakV3) or scavenges (Spur) since startup (read-only) 11 tenures of surving objects since startup or reset (read-write) 12-20 were specific to ikp's JITTER VM, now 12-15 are open for use 16 total microseconds at idle since start-up (if non-zero) 17 fraction of the code zone to use (Sista only; used to control code zone use to preserve sendAndBranchData on counter tripped callback) 18 total milliseconds in compaction phase of full GC since start-up (Spur only) 19 scavenge threshold, the effective size of eden. When eden fills to the threshold a scavenge is scheduled. Newer Spur VMs only. 20 utc microseconds at VM start-up (actually at time initialization, which precedes image load). 21 root/remembered table size (occupancy) (read-only) 22 root table overflows since startup (read-only) 23 bytes of extra memory to reserve for VM buffers, plugins, etc (stored in image file header). 24 memory threshold above which shrinking object memory (rw) 25 memory headroom when growing object memory (rw) 26 interruptChecksEveryNms - force an ioProcessEvents every N milliseconds (rw) 27 number of times mark loop iterated for current IGC/FGC (read-only) includes ALL marking 28 number of times sweep loop iterated for current IGC/FGC (read-only) 29 number of times make forward loop iterated for current IGC/FGC (read-only) 30 number of times compact move loop iterated for current IGC/FGC (read-only) 31 number of grow memory requests (read-only) 32 number of shrink memory requests (read-only) 33 number of root table entries used for current IGC/FGC (read-only) 34 Spur: bytes allocated in total since start-up or reset (read-write) (Used to be number of allocations done before current IGC/FGC (read-only)) 35 number of survivor objects after current IGC/FGC (read-only) 36 millisecond clock when current IGC/FGC completed (read-only) 37 number of marked objects for Roots of the world, not including Root Table entries for current IGC/FGC (read-only) 38 milliseconds taken by current IGC (read-only) 39 Number of finalization signals for Weak Objects pending when current IGC/FGC completed (read-only) 40 BytesPerOop for this image 41 imageFormatVersion for the VM 42 number of stack pages in use 43 desired number of stack pages (stored in image file header, max 65535) 44 size of eden, in bytes 45 desired size of eden, in bytes (stored in image file header) 46 machine code zone size, in bytes (Cog only; otherwise nil) 47 desired machine code zone size (stored in image file header; Cog only; otherwise nil) 48 various header flags. See getCogVMFlags. 49 max size the image promises to grow the external semaphore table to (0 sets to default, which is 256 as of writing) 50-51 nil; reserved for VM parameters that persist in the image (such as eden above) 52 root/remembered table capacity 53 number of segments (Spur only; otherwise nil) 54 total size of free old space (Spur only, otherwise nil) 55 ratio of growth and image size at or above which a GC will be performed post scavenge 56 number of process switches since startup (read-only) 57 number of ioProcessEvents calls since startup (read-only) 58 number of ForceInterruptCheck calls since startup (read-only) 59 number of check event calls since startup (read-only) 60 number of stack page overflows since startup (read-only) 61 number of stack page divorces since startup (read-only) 62 compiled code compactions since startup (read-only; Cog only; otherwise nil) 63 total milliseconds in compiled code compactions since startup (read-only; Cog only; otherwise nil) 64 the number of methods that currently have jitted machine-code 65 whether the VM supports a certain feature, MULTIPLE_BYTECODE_SETS is bit 0, IMMUTABILITY is bit 1 66 the byte size of a stack page 67 the max allowed size of old space (Spur only; nil otherwise; 0 implies no limit except that of the underlying platform) 68 the average number of live stack pages when scanned by GC (at scavenge/gc/become et al) (read-write) 69 the maximum number of live stack pages when scanned by GC (at scavenge/gc/become et al) (read-write) 70 the vmProxyMajorVersion (the interpreterProxy VM_MAJOR_VERSION) 71 the vmProxyMinorVersion (the interpreterProxy VM_MINOR_VERSION) 72 total milliseconds in full GCs Mark phase since startup (read-only) 73 total milliseconds in full GCs Sweep phase since startup (read-only, can be 0 depending on compactors) + 74 maximum pause time due to segment allocation - 74 Maximum pause time due to segment allocation Note: Thanks to Ian Piumarta for this primitive." + | paramsArraySize index | - | paramsArraySize arg index | paramsArraySize := 74. argumentCount = 0 ifTrue: [^self primitiveAllVMParameters: paramsArraySize]. argumentCount > 2 ifTrue: [^self primitiveFailFor: PrimErrBadNumArgs]. "index read & checks" + index := self stackValue: (argumentCount = 1 ifTrue: [0] ifFalse: [1]). - index := argumentCount = 1 ifTrue: [self stackTop] ifFalse: [self stackValue: 1]. (objectMemory isIntegerObject: index) ifFalse: [^self primitiveFailFor: PrimErrBadArgument]. index := objectMemory integerValueOf: index. (index < 1 or: [index > paramsArraySize]) ifTrue: [^self primitiveFailFor: PrimErrBadIndex]. + argumentCount = 1 ifTrue: "read VM parameter; written this way to avoid branch limits in V3 bytecode set" + [| result | + result := self primitiveGetVMParameter: index. + ^self methodReturnValue: (result ifNil: [objectMemory nilObject])]. - argumentCount = 1 ifTrue: "read VM parameter" - [^self primitiveGetVMParameter: index]. - "2nd arg read & checks" - arg := self stackTop. - (index = 17 or: [index = 55 or: [index = 68]]) - ifTrue: - [((objectMemory isFloatInstance: arg) - or: [objectMemory isIntegerObject: arg]) ifFalse: - [^self primitiveFailFor: PrimErrBadArgument]] - ifFalse: - [(objectMemory isIntegerObject: arg) ifFalse: - [^self primitiveFailFor: PrimErrBadArgument]. - arg := objectMemory integerValueOf: arg]. - "write a VM parameter" + self primitiveSetVMParameter: index arg: self stackTop! - ^self primitiveSetVMParameter: index arg: arg!

1 0

Build failed: opensmalltalk-vm 1.0.1426
by AppVeyor 12 Oct '18

12 Oct '18

1 0

Broken: OpenSmalltalk/opensmalltalk-vm#1448 (Cog - 8f5a4f2)
by Travis CI 12 Oct '18

12 Oct '18

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1448 Status: Broken Duration: 20 mins and 2 secs Commit: 8f5a4f2 (Cog) Author: Eliot Miranda Message: CogVM source as per VMMaker.oscog-eem.2453 General: Fix error code reporting for primitiveAdoptInstance. It uses changeClassOf:to: which expects the class to be the argument, so BadArgument/BadReceiver errors must be swapped. Spur: Simplify the two changeClassOf:to: implementations, fixing a bug when a byte class adopts a 32 bit indexable instance on the 32 bit system. Spur Cogit: Fix a regression in 32 bit genGetSizeOf:into:formatReg:scratchReg:abortJumpsInto: that failed to abort for 64 bit indexable receivers. Eliminate unnecessary branch in 32 bit version of genPrimitiveAtSigned:, to match the 64 bit version. Plugins: Eliminate cCode: usage in the B3DAcceleratorPlugin and HostWindowPlugin using the new "var args" style. Rewrite mem:mo:ve: et al in the new style. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/c8f507066cc5...8f… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/440490100?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

[OpenSmalltalk/opensmalltalk-vm] 8f5a4f: CogVM source as per VMMaker.oscog-eem.2453
by GitHub 12 Oct '18

12 Oct '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 8f5a4f277797edf797a1d3fd6c52912708a9bea3 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8f5a4f277797edf797… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-10-11 (Thu, 11 Oct 2018) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64SysV.c M nsspur64src/vm/cogitX64WIN64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/cointerpmt.c M spur64src/vm/cointerpmt.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/gcc3x-cointerpmt.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/cointerpmt.c M spursrc/vm/cointerpmt.h M spursrc/vm/gcc3x-cointerp.c M spursrc/vm/gcc3x-cointerpmt.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/plugins/B3DAcceleratorPlugin/B3DAcceleratorPlugin.c M src/plugins/HostWindowPlugin/HostWindowPlugin.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2453 General: Fix error code reporting for primitiveAdoptInstance. It uses changeClassOf:to: which expects the class to be the argument, so BadArgument/BadReceiver errors must be swapped. Spur: Simplify the two changeClassOf:to: implementations, fixing a bug when a byte class adopts a 32 bit indexable instance on the 32 bit system. Spur Cogit: Fix a regression in 32 bit genGetSizeOf:into:formatReg:scratchReg:abortJumpsInto: that failed to abort for 64 bit indexable receivers. Eliminate unnecessary branch in 32 bit version of genPrimitiveAtSigned:, to match the 64 bit version. Plugins: Eliminate cCode: usage in the B3DAcceleratorPlugin and HostWindowPlugin using the new "var args" style. Rewrite mem:mo:ve: et al in the new style. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

VM Maker: VMMaker.oscog-eem.2453.mcz
by commits＠source.squeak.org 12 Oct '18

12 Oct '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2453.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2453 Author: eem Time: 11 October 2018, 10:59:54.286133 pm UUID: a9a84e27-b3e7-47f3-a811-f86a44fb4252 Ancestors: VMMaker.oscog-eem.2452 Cog Spur: Eliminate unnecessary branch in 32 bit version of genPrimitiveAtSigned:, to match the 64 bit version. =============== Diff against VMMaker.oscog-eem.2452 =============== Item was changed: ----- Method: CogObjectRepresentationFor32BitSpur>>genPrimitiveAtSigned: (in category 'primitive generators') ----- genPrimitiveAtSigned: signedVersion "Generate the code for primitives 60 & 164, at:/basicAt: & integerAt:. If signedVersion is true then generate signed accesses to the bits classes (a la 164 & 165). If signedVersion is false, generate unsigned accesses (a la 60, 61, 63 & 64)." | formatReg nSlotsOrBytesReg convertToIntAndReturn methodInBounds jumpNotIndexable jumpImmediate jumpBadIndex jumpIsBytes jumpIsShorts jumpIsWords jumpIsMethod jumpWordTooBig jumpIsArray jumpHasFixedFields jumpIsContext jumpBytesOutOfBounds jumpShortsOutOfBounds jumpWordsOutOfBounds + jumpArrayOutOfBounds jumpFixedFieldsOutOfBounds | - jumpMethodOutOfBounds jumpArrayOutOfBounds jumpFixedFieldsOutOfBounds | "c.f. StackInterpreter>>stSizeOf: SpurMemoryManager>>lengthOf:format: fixedFieldsOf:format:length:" nSlotsOrBytesReg := ClassReg. cogit genLoadArgAtDepth: 0 into: Arg0Reg. jumpImmediate := self genJumpImmediate: ReceiverResultReg. cogit MoveR: Arg0Reg R: Arg1Reg. jumpBadIndex := self genJumpNotSmallInteger: Arg0Reg scratchReg: TempReg. self genConvertSmallIntegerToIntegerInReg: Arg1Reg. cogit SubCq: 1 R: Arg1Reg. "1-rel => 0-rel" "formatReg := self formatOf: ReceiverResultReg" self genGetFormatOf: ReceiverResultReg into: (formatReg := SendNumArgsReg) leastSignificantHalfOfBaseHeaderIntoScratch: TempReg. self genGetNumSlotsOf: ReceiverResultReg into: nSlotsOrBytesReg. "dispatch on format in a combination of highest dynamic frequency order first and convenience. 0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? 9 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" cogit CmpCq: objectMemory firstByteFormat R: formatReg. jumpIsBytes := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory arrayFormat R: formatReg. jumpIsArray := cogit JumpZero: 0. jumpNotIndexable := cogit JumpBelow: 0. cogit CmpCq: objectMemory weakArrayFormat R: formatReg. jumpHasFixedFields := cogit JumpBelowOrEqual: 0. cogit CmpCq: objectMemory firstShortFormat R: formatReg. jumpIsShorts := cogit JumpAboveOrEqual: 0. cogit CmpCq: objectMemory firstLongFormat R: formatReg. jumpIsWords := cogit JumpAboveOrEqual: 0. "For now ignore 64-bit indexability." jumpNotIndexable jmpTarget: cogit Label. jumpNotIndexable := cogit Jump: 0. jumpIsArray jmpTarget: (cogit CmpR: Arg1Reg R: nSlotsOrBytesReg). jumpArrayOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: Arg1Reg. cogit MoveXwr: Arg1Reg R: ReceiverResultReg R: ReceiverResultReg. cogit genPrimReturn. jumpIsBytes jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord R: nSlotsOrBytesReg). cogit AndCq: objectMemory wordSize - 1 R: formatReg R: TempReg. cogit SubR: TempReg R: nSlotsOrBytesReg; CmpR: Arg1Reg R: nSlotsOrBytesReg. jumpBytesOutOfBounds := cogit JumpBelowOrEqual: 0. cogit CmpCq: objectMemory firstCompiledMethodFormat R: formatReg. jumpIsMethod := cogit JumpAboveOrEqual: 0. methodInBounds := cogit AddCq: objectMemory baseHeaderSize R: Arg1Reg. (cogit backEnd byteReadsZeroExtend or: [signedVersion]) ifTrue: [cogit MoveXbr: Arg1Reg R: ReceiverResultReg R: ReceiverResultReg] ifFalse: [cogit "formatReg already contains a value <= 16r1f, so no need to zero it" MoveXbr: Arg1Reg R: ReceiverResultReg R: formatReg; MoveR: formatReg R: ReceiverResultReg]. signedVersion ifTrue: [cogit SignExtend8R: ReceiverResultReg R: ReceiverResultReg]. convertToIntAndReturn := cogit Label. self genConvertIntegerToSmallIntegerInReg: ReceiverResultReg. cogit genPrimReturn. jumpIsShorts jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord - 1 R: nSlotsOrBytesReg). cogit AndCq: 1 R: formatReg. cogit SubR: formatReg R: nSlotsOrBytesReg; CmpR: Arg1Reg R: nSlotsOrBytesReg. jumpShortsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddR: Arg1Reg R: ReceiverResultReg. cogit AddR: Arg1Reg R: ReceiverResultReg. cogit MoveM16: objectMemory baseHeaderSize r: ReceiverResultReg R: ReceiverResultReg. signedVersion ifTrue: [cogit SignExtend16R: ReceiverResultReg R: ReceiverResultReg]. cogit Jump: convertToIntAndReturn. jumpIsWords jmpTarget: (cogit CmpR: Arg1Reg R: nSlotsOrBytesReg). jumpWordsOutOfBounds := cogit JumpBelowOrEqual: 0. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: Arg1Reg. cogit MoveXwr: Arg1Reg R: ReceiverResultReg R: TempReg. jumpWordTooBig := self jumpNotSmallIntegerUnsignedValueInRegister: TempReg. cogit MoveR: TempReg R: ReceiverResultReg. cogit Jump: convertToIntAndReturn. jumpHasFixedFields jmpTarget: (cogit AndCq: objectMemory classIndexMask R: TempReg). cogit MoveR: TempReg R: formatReg. cogit CmpCq: ClassMethodContextCompactIndex R: TempReg. jumpIsContext := cogit JumpZero: 0. cogit PushR: nSlotsOrBytesReg. self genGetClassObjectOfClassIndex: formatReg into: nSlotsOrBytesReg scratchReg: TempReg. self genLoadSlot: InstanceSpecificationIndex sourceReg: nSlotsOrBytesReg destReg: formatReg. cogit PopR: nSlotsOrBytesReg. self genConvertSmallIntegerToIntegerInReg: formatReg. cogit AndCq: objectMemory fixedFieldsOfClassFormatMask R: formatReg; SubR: formatReg R: nSlotsOrBytesReg; CmpR: Arg1Reg R: nSlotsOrBytesReg. jumpFixedFieldsOutOfBounds := cogit JumpBelowOrEqual: 0. "index is (formatReg (fixed fields) + Arg1Reg (0-rel index)) * wordSize + baseHeaderSize" cogit AddR: formatReg R: Arg1Reg. cogit AddCq: objectMemory baseHeaderSize >> objectMemory shiftForWord R: Arg1Reg. cogit MoveXwr: Arg1Reg R: ReceiverResultReg R: ReceiverResultReg. cogit genPrimReturn. jumpIsMethod jmpTarget: cogit Label. "Now check that the index is beyond the method's literals..." self getLiteralCountOf: ReceiverResultReg plusOne: true inBytes: true into: nSlotsOrBytesReg scratch: TempReg. cogit CmpR: Arg1Reg R: nSlotsOrBytesReg. cogit JumpBelow: methodInBounds. - jumpMethodOutOfBounds := cogit Jump: 0. jumpWordTooBig jmpTarget: (jumpFixedFieldsOutOfBounds jmpTarget: (jumpArrayOutOfBounds jmpTarget: (jumpBytesOutOfBounds jmpTarget: - (jumpMethodOutOfBounds jmpTarget: (jumpShortsOutOfBounds jmpTarget: (jumpWordsOutOfBounds jmpTarget: (jumpNotIndexable jmpTarget: (jumpIsContext jmpTarget: (jumpBadIndex jmpTarget: + (jumpImmediate jmpTarget: cogit Label))))))))). - (jumpImmediate jmpTarget: cogit Label)))))))))). ^0 "Can't be complete because of contexts."!

1 0

VM Maker: VMMaker.oscog-eem.2452.mcz
by commits＠source.squeak.org 12 Oct '18

12 Oct '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2452.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2452 Author: eem Time: 11 October 2018, 10:44:32.529708 pm UUID: fbf68fea-bb48-48c2-b1b0-8e712167cdbb Ancestors: VMMaker.oscog-eem.2451 General: Fix error code reporting for primitiveAdoptInstance. It uses changeClassOf:to: which expects the class to be the argument, so BadArgument/BadReceiver errors must be swapped. Spur: Simplify the two changeClassOf:to: implementations, fixing a bug when a byte class adopts a 32 bit indexable instance on the 32 bit system. Spur Cogit: Fix a regression in 32 bit genGetSizeOf:into:formatReg:scratchReg:abortJumpsInto: that failed to abort for 64 bit indexable receivers. Nuke the now inferred jump type declarations from both versions. Slang: Fix a regression in cFunctionNameFor: caused by adding support for foo:_: selectors too carelessly which consequently generated __LINE__ as __LINE. Simulator: Fix as[Double|Single]FloatAccessor given that adoptInstance: answers the receiver (the class), not the adopted instance. Exclude primitiveAdoptInstance from halts in stack simulator's getErrorObjectFromPrimFailCode. Hernan, if this halt annoys you, feel free to delete the method. I've included it just to catch potentially interesting primitive failures. =============== Diff against VMMaker.oscog-eem.2451 =============== Item was changed: ----- Method: CArray>>asDoubleFloatAccessor (in category 'converting') ----- asDoubleFloatAccessor + | accessor | + CFloatArray adoptInstance: (accessor := self shallowCopy unitSize: 8). + ^accessor! - ^CFloatArray adoptInstance: (self shallowCopy unitSize: 8)! Item was changed: ----- Method: CArray>>asSingleFloatAccessor (in category 'converting') ----- asSingleFloatAccessor + | accessor | + CFloatArray adoptInstance: (accessor := self shallowCopy unitSize: 4). + ^accessor! - ^CFloatArray adoptInstance: (self shallowCopy unitSize: 4)! Item was changed: ----- Method: CCodeGenerator>>cFunctionNameFor: (in category 'C code generator') ----- cFunctionNameFor: aSelector "Create a C function name from the given selector by finding a specific translation, or if none, simply omitting colons, and any trailing underscores (this supports a varargs convention)." ^selectorTranslations at: aSelector ifAbsent: [| cSelector | cSelector := aSelector copyWithout: $:. + aSelector last = $: ifTrue: + [[cSelector last = $_] whileTrue: + [cSelector := cSelector allButLast]]. - [cSelector last = $_] whileTrue: - [cSelector := cSelector allButLast]. cSelector]! Item was changed: ----- Method: CogObjectRepresentationFor32BitSpur>>genGetSizeOf:into:formatReg:scratchReg:abortJumpsInto: (in category 'primitive generators') ----- genGetSizeOf: sourceReg into: destReg formatReg: formatReg scratchReg: scratchReg abortJumpsInto: aBinaryBlock "Get the size of the non-immediate object in sourceReg into destReg using formatReg and scratchReg as temps. None of these registers can overlap. Supply the jumps taken if the object in sourceReg is not indexable, or if the object in sourceReg is a context.. Hack: If the object has a pointer format other than 2 leave the number of fixed fields in formatReg. Used by primitiveSize, primitiveAt, and primitiveAtPut" <returnTypeC: #'AbstractInstruction *'> | jumpNotIndexable + jumpBytesDone jumpShortsDone jumpArrayDone jump32BitLongsDone jump64BitLongsDone + jumpIsBytes jumpHasFixedFields jumpIsShorts jumpIs64BitLongs jumpIsContext | - jumpBytesDone jumpShortsDone jumpArrayDone jump32BitLongsDone - jumpIsBytes jumpHasFixedFields jumpIsShorts jumpIsContext | <inline: true> "c.f. StackInterpreter>>stSizeOf: SpurMemoryManager>>lengthOf:format: fixedFieldsOf:format:length:" - <var: #jumpIsBytes type: #'AbstractInstruction *'> - <var: #jumpIsShorts type: #'AbstractInstruction *'> - <var: #jumpIsContext type: #'AbstractInstruction *'> - <var: #jumpArrayDone type: #'AbstractInstruction *'> - <var: #jumpNotIndexable type: #'AbstractInstruction *'> - <var: #jumpHasFixedFields type: #'AbstractInstruction *'> - <var: #jump32BitLongsDone type: #'AbstractInstruction *'> "formatReg := self formatOf: sourceReg" self genGetFormatOf: sourceReg into: formatReg leastSignificantHalfOfBaseHeaderIntoScratch: scratchReg. self genGetNumSlotsOf: sourceReg into: destReg. "dispatch on format in a combination of highest dynamic frequency order first and convenience. 0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? 9 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" cogit CmpCq: objectMemory firstByteFormat R: formatReg. jumpIsBytes := cogit JumpGreaterOrEqual: 0. cogit CmpCq: objectMemory arrayFormat R: formatReg. jumpArrayDone := cogit JumpZero: 0. jumpNotIndexable := cogit JumpLess: 0. cogit CmpCq: objectMemory weakArrayFormat R: formatReg. jumpHasFixedFields := cogit JumpLessOrEqual: 0. cogit CmpCq: objectMemory firstShortFormat R: formatReg. jumpIsShorts := cogit JumpGreaterOrEqual: 0. cogit CmpCq: objectMemory firstLongFormat R: formatReg. jump32BitLongsDone := cogit JumpGreaterOrEqual: 0. + cogit CmpCq: objectMemory sixtyFourBitIndexableFormat R: formatReg. + jumpIs64BitLongs := cogit JumpZero: 0. "For now ignore 64-bit indexability." jumpNotIndexable jmpTarget: cogit Label. jumpNotIndexable := cogit Jump: 0. jumpIsBytes jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord R: destReg). cogit AndCq: objectMemory wordSize - 1 R: formatReg. cogit SubR: formatReg R: destReg. jumpBytesDone := cogit Jump: 0. jumpIsShorts jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord - 1 R: destReg). cogit AndCq: 1 R: formatReg. cogit SubR: formatReg R: destReg. jumpShortsDone := cogit Jump: 0. + jumpIs64BitLongs jmpTarget: + (cogit LogicalShiftRightCq: 1 R: destReg). + jump64BitLongsDone := cogit Jump: 0. + "formatReg contains fmt, now up for grabs. destReg contains numSlots, precious. sourceReg must be preserved" jumpHasFixedFields jmpTarget: (cogit AndCq: objectMemory classIndexMask R: scratchReg). cogit MoveR: scratchReg R: formatReg. cogit CmpCq: ClassMethodContextCompactIndex R: scratchReg. jumpIsContext := cogit JumpZero: 0. cogit PushR: destReg. self genGetClassObjectOfClassIndex: formatReg into: destReg scratchReg: scratchReg. self genLoadSlot: InstanceSpecificationIndex sourceReg: destReg destReg: formatReg. self genConvertSmallIntegerToIntegerInReg: formatReg. cogit PopR: destReg; AndCq: objectMemory fixedFieldsOfClassFormatMask R: formatReg; SubR: formatReg R: destReg. jumpArrayDone jmpTarget: + (jump64BitLongsDone jmpTarget: (jump32BitLongsDone jmpTarget: (jumpShortsDone jmpTarget: (jumpBytesDone jmpTarget: + cogit Label)))). - cogit Label))). aBinaryBlock value: jumpNotIndexable value: jumpIsContext! Item was changed: ----- Method: CogObjectRepresentationFor64BitSpur>>genGetSizeOf:into:formatReg:scratchReg:abortJumpsInto: (in category 'primitive generators') ----- genGetSizeOf: sourceReg into: destReg formatReg: formatReg scratchReg: scratchReg abortJumpsInto: aBinaryBlock "Get the size of the non-immediate object in sourceReg into destReg using formatReg and scratchReg as temps. None of these registers can overlap. Supply the jumps taken if the object in sourceReg is not indexable, or if the object in sourceReg is a context.. Hack: If the object has a pointer format other than 2 leave the number of fixed fields in formatReg. Used by primitiveSize, primitiveAt, and primitiveAtPut" <returnTypeC: #'AbstractInstruction *'> | jumpNotIndexable jumpBytesDone jumpShortsDone jumpArrayDone jump32BitLongsDone jump64BitLongsDone jumpIsBytes jumpHasFixedFields jumpIsShorts jumpIs32BitLongs jumpIsContext | <inline: true> "c.f. StackInterpreter>>stSizeOf: SpurMemoryManager>>lengthOf:format: fixedFieldsOf:format:length:" - <var: #jumpIsBytes type: #'AbstractInstruction *'> - <var: #jumpIsShorts type: #'AbstractInstruction *'> - <var: #jumpIsContext type: #'AbstractInstruction *'> - <var: #jumpArrayDone type: #'AbstractInstruction *'> - <var: #jumpIs32BitLongs type: #'AbstractInstruction *'> - <var: #jumpNotIndexable type: #'AbstractInstruction *'> - <var: #jumpHasFixedFields type: #'AbstractInstruction *'> - <var: #jump32BitLongsDone type: #'AbstractInstruction *'> - <var: #jump64BitLongsDone type: #'AbstractInstruction *'> "formatReg := self formatOf: sourceReg" self genGetFormatOf: sourceReg into: formatReg leastSignificantHalfOfBaseHeaderIntoScratch: scratchReg. self genGetNumSlotsOf: sourceReg into: destReg. "dispatch on format in a combination of highest dynamic frequency order first and convenience. 0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) 4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) 6 unused, reserved for exotic pointer objects? 7 Forwarded Object, 1st field is pointer, rest of fields are ignored 8 unused, reserved for exotic non-pointer objects? 9 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method" cogit CmpCq: objectMemory firstByteFormat R: formatReg. jumpIsBytes := cogit JumpGreaterOrEqual: 0. cogit CmpCq: objectMemory arrayFormat R: formatReg. jumpArrayDone := cogit JumpZero: 0. jumpNotIndexable := cogit JumpLess: 0. cogit CmpCq: objectMemory weakArrayFormat R: formatReg. jumpHasFixedFields := cogit JumpLessOrEqual: 0. cogit CmpCq: objectMemory firstShortFormat R: formatReg. jumpIsShorts := cogit JumpGreaterOrEqual: 0. cogit CmpCq: objectMemory firstLongFormat R: formatReg. jumpIs32BitLongs := cogit JumpGreaterOrEqual: 0. cogit CmpCq: objectMemory sixtyFourBitIndexableFormat R: formatReg. jump64BitLongsDone := cogit JumpZero: 0. jumpNotIndexable jmpTarget: cogit Label. jumpNotIndexable := cogit Jump: 0. jumpIsBytes jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord R: destReg). cogit AndCq: objectMemory wordSize - 1 R: formatReg. cogit SubR: formatReg R: destReg. jumpBytesDone := cogit Jump: 0. jumpIsShorts jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord - 1 R: destReg). cogit AndCq: objectMemory wordSize >> 1 - 1 R: formatReg. cogit SubR: formatReg R: destReg. jumpShortsDone := cogit Jump: 0. jumpIs32BitLongs jmpTarget: (cogit LogicalShiftLeftCq: objectMemory shiftForWord - 2 R: destReg). cogit AndCq: objectMemory wordSize >> 2 - 1 R: formatReg. cogit SubR: formatReg R: destReg. jump32BitLongsDone := cogit Jump: 0. "formatReg contains fmt, now up for grabs. destReg contains numSlots, precious. sourceReg must be preserved" jumpHasFixedFields jmpTarget: (cogit AndCq: objectMemory classIndexMask R: scratchReg). cogit MoveR: scratchReg R: formatReg. cogit CmpCq: ClassMethodContextCompactIndex R: scratchReg. jumpIsContext := cogit JumpZero: 0. self genGetClassObjectOfClassIndex: formatReg into: Extra0Reg scratchReg: scratchReg. self genLoadSlot: InstanceSpecificationIndex sourceReg: Extra0Reg destReg: formatReg. self genConvertSmallIntegerToIntegerInReg: formatReg. cogit AndCq: objectMemory fixedFieldsOfClassFormatMask R: formatReg; SubR: formatReg R: destReg. jumpArrayDone jmpTarget: (jump64BitLongsDone jmpTarget: (jump32BitLongsDone jmpTarget: (jumpShortsDone jmpTarget: (jumpBytesDone jmpTarget: cogit Label)))). aBinaryBlock value: jumpNotIndexable value: jumpIsContext! Item was changed: ----- Method: InterpreterPrimitives>>primitiveAdoptInstance (in category 'object access primitives') ----- primitiveAdoptInstance "Primitive. Change the class of the argument to make it an instance of the receiver given that the format of the receiver matches the format of the argument's class. Fail if receiver or argument are SmallIntegers, or the receiver is an instance of a compact class and the argument isn't, or when the argument's class is compact and the receiver isn't, or when the format of the receiver is different from the format of the argument's class, or when the arguments class is fixed and the receiver's size differs from the size that an instance of the argument's class should have." | rcvr arg err | arg := self stackTop. rcvr := self stackValue: 1. ((objectMemory isImmediate: arg) or: [argumentCount > 1 and: [(objectMemory isImmediate: rcvr) or: [(self objCouldBeClassObj: rcvr) not]]]) ifTrue: [^self primitiveFailFor: PrimErrBadArgument]. err := objectMemory changeClassOf: arg to: rcvr. err = 0 + ifTrue: + ["Flush at cache because rcvr's class has changed." + self flushAtCache. + self pop: self methodArgumentCount] + ifFalse: + ["changeClassOf:to: answers errors as if rcvr (the class) is an argument..." + err = PrimErrBadReceiver + ifTrue: + [err := PrimErrBadArgument] + ifFalse: + [err = PrimErrBadArgument ifTrue: + [err := PrimErrBadReceiver]]. + self primitiveFailFor: err]. - ifTrue: ["Flush at cache because rcvr's class has changed." - self flushAtCache. - self pop: self methodArgumentCount] - ifFalse: [self primitiveFailFor: err]. ^nil! Item was changed: ----- Method: Spur32BitMemoryManager>>changeClassOf:to: (in category 'interpreter access') ----- changeClassOf: rcvr to: argClass "Attempt to change the class of the receiver to the argument given that the format of the receiver matches the format of the argument. If successful, answer 0, otherwise answer an error code indicating the reason for failure. Fail if the format of the receiver is incompatible with the format of the argument, or if the argument is a fixed class and the receiver's size differs from the size that an instance of the argument should have." <inline: false> + | classFormat fixedFields instFormat newFormat classIndex instSlots instBytes | - | classFormat fixedFields instFormat normalizedInstFormat newFormat classIndex | (self isObjImmutable: rcvr) ifTrue: [^PrimErrNoModification]. classFormat := self formatOfClass: argClass. fixedFields := self fixedFieldsOfClassFormat: classFormat. classFormat := self instSpecOfClassFormat: classFormat. instFormat := self formatOf: rcvr. - normalizedInstFormat := self classFormatForInstanceFormat: instFormat. "Fail for inability to access classIndex before making contexts snapshot-safe." (classIndex := self ensureBehaviorHash: argClass) < 0 ifTrue: [^classIndex negated]. + "Now check the instance for compatibility and compute odd bits if necessary." + classFormat <= self lastPointerFormat + ifTrue: + [instFormat > self lastPointerFormat ifTrue: + [^PrimErrInappropriate]. + ((instSlots := self numSlotsOf: rcvr) < fixedFields + or: [instSlots > fixedFields and: [self isFixedSizePointerFormat: classFormat]]) ifTrue: + [^PrimErrBadReceiver]. + (instFormat = self indexablePointersFormat + and: [self isContextNonImm: rcvr]) ifTrue: + [coInterpreter makeContextSnapshotSafe: rcvr]. + newFormat := classFormat] - (normalizedInstFormat > self lastPointerFormat - and: [normalizedInstFormat = classFormat]) - ifTrue: [newFormat := instFormat] ifFalse: + ["Fail if the class's format is somehow invalid." + classFormat ~= (self classFormatForInstanceFormat: classFormat) ifTrue: + [^PrimErrBadArgument]. + + instBytes := self numBytesOf: rcvr. + classFormat + caseOf: { + [self sixtyFourBitIndexableFormat] + -> [(instBytes anyMask: 7) ifTrue: [^PrimErrBadReceiver]. + newFormat := classFormat]. + [self firstLongFormat] + -> [(instBytes anyMask: 3) ifTrue: [^PrimErrBadReceiver]. + newFormat := classFormat]. + [self firstShortFormat] + -> [(instBytes anyMask: 1) ifTrue: [^PrimErrBadReceiver]. + newFormat := classFormat + (2 - (instBytes >> 1) bitAnd: 1)]. + [self firstByteFormat] + -> [newFormat := classFormat + (4 - instBytes bitAnd: 3)]. + [self firstCompiledMethodFormat] + -> [classFormat ~= self firstCompiledMethodFormat ifTrue: + [^PrimErrInappropriate]. + newFormat := instFormat] } + otherwise: "bits instances cannot be adopted by pointer-like classes..." + [^PrimErrInappropriate]]. + - [normalizedInstFormat <= self lastPointerFormat - ifTrue: - [classFormat > self lastPointerFormat ifTrue: - [^PrimErrInappropriate]. - (self numSlotsOf: rcvr) < fixedFields ifTrue: - [^PrimErrBadReceiver]. - (instFormat = self indexablePointersFormat - and: [self isContextNonImm: rcvr]) ifTrue: - [coInterpreter makeContextSnapshotSafe: rcvr]. - newFormat := classFormat] - ifFalse: - [| instBytes | - instBytes := self numBytesOf: rcvr. - normalizedInstFormat caseOf: { - [self sixtyFourBitIndexableFormat] -> - [(classFormat < self sixtyFourBitIndexableFormat - or: [classFormat >= self firstCompiledMethodFormat]) ifTrue: - [^PrimErrInappropriate]. - newFormat := classFormat]. - [self firstLongFormat] -> - [(classFormat < self sixtyFourBitIndexableFormat - or: [classFormat >= self firstCompiledMethodFormat]) ifTrue: - [^PrimErrInappropriate]. - (classFormat = self sixtyFourBitIndexableFormat and: [instBytes anyMask: 1]) ifTrue: - [^PrimErrBadReceiver]. - newFormat := classFormat]. - [self firstShortFormat] -> - [(classFormat < self sixtyFourBitIndexableFormat - or: [classFormat >= self firstCompiledMethodFormat]) ifTrue: - [^PrimErrInappropriate]. - classFormat caseOf: { - [self sixtyFourBitIndexableFormat] - -> [(instBytes anyMask: 3) ifTrue: [^PrimErrBadReceiver]. - newFormat := classFormat]. - [self firstLongFormat] - -> [(instBytes anyMask: 1) ifTrue: [^PrimErrBadReceiver]. - newFormat := classFormat]. - [self firstByteFormat] - -> [newFormat := classFormat + (4 - instBytes bitAnd: 3)] }]. - [self firstByteFormat] -> - [(classFormat < self sixtyFourBitIndexableFormat - or: [classFormat >= self firstCompiledMethodFormat]) ifTrue: - [^PrimErrInappropriate]. - classFormat caseOf: { - [self sixtyFourBitIndexableFormat] - -> [(instBytes anyMask: 7) ifTrue: [^PrimErrBadReceiver]]. - [self firstLongFormat] - -> [(instBytes anyMask: 3) ifTrue: [^PrimErrBadReceiver]]. - [self firstShortFormat] - -> [(instBytes anyMask: 1) ifTrue: [^PrimErrBadReceiver]] }. - newFormat := classFormat]. - [self firstCompiledMethodFormat] -> - [classFormat ~= self firstCompiledMethodFormat ifTrue: - [^PrimErrInappropriate]. - newFormat := instFormat] }]]. self set: rcvr classIndexTo: classIndex formatTo: newFormat. + + self assert: (self numBytesOf: rcvr) = (classFormat <= self lastPointerFormat + ifTrue: [instSlots * self bytesPerOop] + ifFalse: [instBytes]). "ok" ^0! Item was changed: ----- Method: Spur64BitMemoryManager>>changeClassOf:to: (in category 'interpreter access') ----- changeClassOf: rcvr to: argClass "Attempt to change the class of the receiver to the argument given that the format of the receiver matches the format of the argument. If successful, answer 0, otherwise answer an error code indicating the reason for failure. Fail if the format of the receiver is incompatible with the format of the argument, or if the argument is a fixed class and the receiver's size differs from the size that an instance of the argument should have." <inline: false> + | classFormat fixedFields instFormat newFormat classIndex instSlots instBytes | - | classFormat fixedFields instFormat normalizedInstFormat newFormat classIndex | (self isObjImmutable: rcvr) ifTrue: [^PrimErrNoModification]. classFormat := self formatOfClass: argClass. fixedFields := self fixedFieldsOfClassFormat: classFormat. classFormat := self instSpecOfClassFormat: classFormat. instFormat := self formatOf: rcvr. - normalizedInstFormat := self classFormatForInstanceFormat: instFormat. "Fail for inability to access classIndex before making contexts snapshot-safe." (classIndex := self ensureBehaviorHash: argClass) < 0 ifTrue: [^classIndex negated]. + "Now check the instance for compatibility and compute odd bits if necessary." + classFormat <= self lastPointerFormat + ifTrue: + [instFormat > self lastPointerFormat ifTrue: + [^PrimErrInappropriate]. + ((instSlots := self numSlotsOf: rcvr) < fixedFields + or: [instSlots > fixedFields and: [self isFixedSizePointerFormat: classFormat]]) ifTrue: + [^PrimErrBadReceiver]. + (instFormat = self indexablePointersFormat + and: [self isContextNonImm: rcvr]) ifTrue: + [coInterpreter makeContextSnapshotSafe: rcvr]. + newFormat := classFormat] - (normalizedInstFormat > self lastPointerFormat - and: [normalizedInstFormat = classFormat]) - ifTrue: [newFormat := instFormat] ifFalse: + ["Fail if the class's format is somehow invalid." + classFormat ~= (self classFormatForInstanceFormat: classFormat) ifTrue: + [^PrimErrBadArgument]. - [normalizedInstFormat <= self lastPointerFormat - ifTrue: - [classFormat > self lastPointerFormat ifTrue: - [^PrimErrInappropriate]. - (self numSlotsOf: rcvr) < fixedFields ifTrue: - [^PrimErrBadReceiver]. - (instFormat = self indexablePointersFormat - and: [self isContextNonImm: rcvr]) ifTrue: - [coInterpreter makeContextSnapshotSafe: rcvr]. - newFormat := classFormat] - ifFalse: - [| instBytes | - instBytes := self numBytesOf: rcvr. - normalizedInstFormat caseOf: { - [self sixtyFourBitIndexableFormat] -> - [(classFormat < self sixtyFourBitIndexableFormat - or: [classFormat >= self firstCompiledMethodFormat]) ifTrue: - [^PrimErrInappropriate]. - newFormat := classFormat]. - [self firstLongFormat] -> - [(classFormat < self sixtyFourBitIndexableFormat - or: [classFormat >= self firstCompiledMethodFormat]) ifTrue: - [^PrimErrInappropriate]. - (classFormat = self sixtyFourBitIndexableFormat and: [instBytes anyMask: 1]) ifTrue: - [^PrimErrBadReceiver]. - newFormat := classFormat]. - [self firstShortFormat] -> - [(classFormat < self sixtyFourBitIndexableFormat - or: [classFormat >= self firstCompiledMethodFormat]) ifTrue: - [^PrimErrInappropriate]. - classFormat caseOf: { - [self sixtyFourBitIndexableFormat] - -> [(instBytes anyMask: 7) ifTrue: [^PrimErrBadReceiver]. - newFormat := classFormat]. - [self firstLongFormat] - -> [(instBytes anyMask: 3) ifTrue: [^PrimErrBadReceiver]. - newFormat := classFormat + (2 - instBytes bitAnd: 1)]. - [self firstByteFormat] - -> [newFormat := classFormat + (8 - instBytes bitAnd: 7)] }]. - [self firstByteFormat] -> - [(classFormat < self sixtyFourBitIndexableFormat - or: [classFormat >= self firstCompiledMethodFormat]) ifTrue: - [^PrimErrInappropriate]. - classFormat caseOf: { - [self sixtyFourBitIndexableFormat] - -> [(instBytes anyMask: 7) ifTrue: [^PrimErrBadReceiver]. - newFormat := classFormat]. - [self firstLongFormat] - -> [(instBytes anyMask: 3) ifTrue: [^PrimErrBadReceiver]. - newFormat := classFormat + (2 - instBytes bitAnd: 1)]. - [self firstShortFormat] - -> [(instBytes anyMask: 1) ifTrue: [^PrimErrBadReceiver]. - newFormat := classFormat + (4 - instBytes bitAnd: 3)] }. - newFormat := classFormat]. - [self firstCompiledMethodFormat] -> - [classFormat ~= self firstCompiledMethodFormat ifTrue: - [^PrimErrInappropriate]. - newFormat := instFormat] }]]. + instBytes := self numBytesOf: rcvr. + classFormat + caseOf: { + [self sixtyFourBitIndexableFormat] + -> [(instBytes anyMask: 7) ifTrue: [^PrimErrBadReceiver]. + newFormat := classFormat]. + [self firstLongFormat] + -> [(instBytes anyMask: 3) ifTrue: [^PrimErrBadReceiver]. + newFormat := classFormat + (2 - (instBytes >> 2) bitAnd: 1)]. + [self firstShortFormat] + -> [(instBytes anyMask: 1) ifTrue: [^PrimErrBadReceiver]. + newFormat := classFormat + (4 - (instBytes >> 1) bitAnd: 3)]. + [self firstByteFormat] + -> [newFormat := classFormat + (8 - instBytes bitAnd: 7)]. + [self firstCompiledMethodFormat] + -> [classFormat ~= self firstCompiledMethodFormat ifTrue: + [^PrimErrInappropriate]. + newFormat := instFormat] } + otherwise: "bits instances cannot be adopted by pointer-like classes..." + [^PrimErrInappropriate]]. + self set: rcvr classIndexTo: classIndex formatTo: newFormat. + + self assert: (self numBytesOf: rcvr) = (classFormat <= self lastPointerFormat + ifTrue: [instSlots * self bytesPerOop] + ifFalse: [instBytes]). "ok" ^0! Item was changed: ----- Method: StackInterpreterSimulator>>getErrorObjectFromPrimFailCode (in category 'debugging traps') ----- getErrorObjectFromPrimFailCode + (primFailCode > 1 and: [(#(primitiveNew primitiveFetchNextMourner primitiveAdoptInstance) includes: primitiveFunctionPointer) not]) ifTrue: [self halt]. - (primFailCode > 1 and: [(#(primitiveNew primitiveFetchNextMourner) includes: primitiveFunctionPointer) not]) ifTrue: [self halt]. ^super getErrorObjectFromPrimFailCode!

1 0

Byte ordering in Form (urgent)
by Eliot Miranda 12 Oct '18

12 Oct '18

Hi All, in trying to fix a bug in BitBLT to do with accessing a word following a bitmap I have had to understand Form and BitBlt's extensions for handling multiple byte order. In particular, if a Form has a negative depth its byte ordering is reversed w.r.t. a Form with positive depth. But in examining this code I think I have found an inconsistency, and I urgently need to check my understanding. In the Form and BitBlt code, a negative depth is stated to mean a Form whose bits are in little-endian byte order: *Form methods for accessing* *depth* ^ depth < 0 ifTrue:[0-depth] ifFalse:[depth] *nativeDepth* "Return the 'native' depth of the receiver, e.g., including the endianess" ^depth *Form methods for testing* *isBigEndian* "Return true if the receiver contains big endian pixels, meaning the left-most pixel is stored in the most significant bits of a word." ^depth > 0 *isLittleEndian* "Return true if the receiver contains little endian pixels, meaning the left-most pixel is stored in the least significant bits of a word." ^depth < 0 and BitBltSimulation (the Smalltalk code for the plugin that implements BitBlt) has two instance variables destMSW and sourceMSW that are true if the destination form or source form has a positive depth: *BitBltSimulation methods for interpreter interface* *loadBitBltDestForm* "Load the dest form for BitBlt. Answer false if anything is wrong, true otherwise." ... destDepth := interpreterProxy fetchInteger: FormDepthIndex ofObject: destForm. destMSB := destDepth > 0. destDepth < 0 ifTrue: [destDepth := 0 - destDepth]. ... *loadBitBltSourceForm* "Load the source form for BitBlt. Return false if anything is wrong, true otherwise." ... sourceDepth := interpreterProxy fetchInteger: FormDepthIndex ofObject: sourceForm. sourceMSB := sourceDepth > 0. sourceDepth < 0 ifTrue: [sourceDepth := 0 - sourceDepth]. ... But if I have a look at the actual layout of bytes in a Form I see that the meaning of depth is that if it is positive it is the *native* byte order (little endian on x86, x86-64, ARM, big end on SPARC, PowerPC): Display fill: (0@0 extent: 1@100) rule: Form over fillColor: Color black. (Display bits at: 1) hex '16rFF000001' | bytes | bytes := Display bits copy. ByteArray adoptInstance: bytes. bytes copyFrom: 1 to: 4 #[1 0 0 255] i.e. the first word of the Display after writing the color black into the first 32-bit pixel is 16rFF000001 on Mac OS x86-64, or #[1 0 0 255] , which is little endian. When the Squeak BttF VM was first written it was written on Motorola 68k Macs and PowerPC Macs, which are big-endian. So it is natural that at the time the terms isBigEndian and isLittleEndian and destMSB sourceMSB were as they are now, because the platform was big endian. But subsequently when the code was ported to Windows x86 by Andreas Raab, the meaning seems to me to have changed. Now depth > 0 implies *native* byte order, not big endian byte order, and depth < 0 implies the *opposite of native* byte order, not little endian order. Does anyone disagree? Does anyone have corroborating or contradicting evidence? I ask because to make sense of the code I would at least like to change the variables in BitBltSimulation to be destNativeByteOrder and sourceNativeByteOrder, and I want to either delete Form>>isBigEndian and Form>>isLittleEndian and replace it with Form>>isNativeByteOrder, or redefine isBigEndian and isLittleEndian, eg as *isBigEndian* "Return true if the receiver contains big endian pixels, meaning the left-most pixel is stored in the most significant bits of a word." ^depth > 0 == Smalltalk isBigEndian _,,,^..^,,,_ best, Eliot

4 5

← Newer
1
...
10
11
12
13
14
15
16
...
19
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev October 2018