Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: c79879b4b4bd5991bb2a9e7142286c75906700d5
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c79879b4b4bd5991bb…
Author: Eliot Miranda <eliot.miranda(a)gmail.com>
Date: 2018-12-03 (Mon, 03 Dec 2018)
Changed paths:
M platforms/iOS/plugins/AioPlugin/Makefile
M platforms/iOS/plugins/AsynchFilePlugin/Makefile
M platforms/iOS/plugins/B3DAcceleratorPlugin/Makefile
M platforms/iOS/plugins/FileAttributesPlugin/Makefile
M platforms/iOS/plugins/FileCopyPlugin/Makefile
M platforms/iOS/plugins/FilePlugin/Makefile
M platforms/iOS/plugins/Mpeg3Plugin/Makefile
M platforms/iOS/plugins/ObjectiveCPlugin/Makefile
M platforms/iOS/plugins/SecurityPlugin/Makefile
R platforms/iOS/plugins/SecurityPlugin/sqUnixSecurity.c
M platforms/iOS/plugins/SerialPlugin/Makefile
M platforms/iOS/plugins/SocketPlugin/Makefile
M platforms/iOS/plugins/SoundPlugin/Makefile
M platforms/iOS/plugins/UnixOSProcessPlugin/Makefile
M platforms/unix/plugins/SecurityPlugin/sqUnixSecurity.c
Log Message:
-----------
Fix the issue raised by Pablo Tesone for startup of the SecurityPlugin.
http://lists.squeakfoundation.org/pipermail/vm-dev/2018-December/029337.html
Also eliminate the duplicate in platforms/iOS/plugins/SecurityPlugin, and
change all iOS plugin Makefiles to use $(PLATDIR) instead of a hard-coded path
that constrains the build directory hierarchy.
**NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
In the unix variant (& hence the Mac variant), there are many environment variables that can specify such things as
SQUEAK_PLUGINS
SQUEAK_ENCODING
SQUEAK_PATHENC
SQUEAK_TEXTENC
SQUEAK_VM
First these should be dialect-specific (PHARO_PLUGINS CUIS_PLUGINS NEWSPEAK_PLUGINS etc), and for backward-compatibility the Squeak specific names should remain functional. So all VM environment variable access should be though a routine, somewhat like
if ((ev = getvmenvvar("PLUGINS"))) squeakPlugins = strdup(ev);
where getvmenvvar is something like
char *
getvmenvvar(const char *var)
{
char varname[64];
char *value;
#if PHARO_VM
# define VM_VAR_PREFIX "PHARO_"
#elif CUIS_VM
# define VM_VAR_PREFIX "CUIS_"
#elif NEWSPEAK_VM
# define VM_VAR_PREFIX "NEWSPEAK_"
#endif
#if defined(VM_VAR_PREFIX)
strcpy(varname,VM_VAR_PREFIX);
strcat(varname,var);
if ((value = getenv(varname))
return value;
#endif
/* now the default prefix */
strcpy(varname,"SQUEAK_");
strcat(varname,var);
return getenv(varname);
}
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/314
Hi Richo,
see commit 128b467faf11cc491671e92b578edd0453827aab on
opensmalltalk-vm. If possible can you (along with a friend with a Mac if
you don't have one) take a look at the code on MacOS X and update
sqUnixSerial.c appropriately? I'd love to play around with this on MacOS X
but you know what you're doing so you could lead the way.
On Thu, Nov 29, 2018 at 5:25 PM Ricardo Moran <richi.moran(a)gmail.com> wrote:
> Hi,
>
> I think I found a bug with the named serial ports in windows.
> I can open a named port without problem the first time but if I close it
> and try to open it again it fails until I restart the image. This doesn't
> happen with numeric ports. I could reproduce this bug in both Squeak5.2 and
> Pharo6.1 (both using windows 8.1).
>
> I think the problem is that SerialPort>>#primClosePortByName: calls the
> "primitiveSerialPortCloseByName" but I couldn't find this primitive
> anywhere in the SerialPlugin source (
> https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/src/plugins/Seri…).
> So I'm guessing that the port is never properly closed.
>
> I added the missing primitive (find attached) and recompiled the vm, and
> now it seems to work. So my question is: how can I contribute this small
> fix? Should I commit to the VM Maker Inbox repository?
>
> Thanks,
> Richo
>
>
--
_,,,^..^,,,_
best, Eliot
Build Update for OpenSmalltalk/opensmalltalk-vm
-------------------------------------
Build: #1509
Status: Errored
Duration: 10 mins and 34 secs
Commit: 128b467 (Cog)
Author: Eliot Miranda
Message: MacOS X does support the tcsetattr serial port support supposed by
sqUnixSerial.c. So instead of using the null support that was in
sqMacSerialPort.c, update the Mac builds to use sqUnixSerial.c, and
rename the mac's file to platforms/Cross/plugins/SerialPlugin/sqNullSerialPort.c
THIS IS UNTESTED! In particular the code in sqUnixSerial.c (dubiously IMO)
does not use serialPortBaseName, and instead makes an assumption that
serial ports are as defined by serialPortBaseNameDefault, i.e. are in the range
/dev/tty50 to /dev/tty59. It would be great if
a) someone tested the code on MacOS X
b) the naming convention were better.
On Mac OS X (see e.g. https://software.intel.com/en-us/setting-up-serial-terminal-on-system-with-…),
the serial ports are /dev/tty.NAME., e.g. /dev/cu.Bluetooth-Incoming-Port,
/dev/cu.BoseQuietControl30-SPPD, etc.
View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/b09fe2fd075c...12…
View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/462559908?utm_m…
--
You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut….
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati….
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.