Vm-dev June 2018

vm-dev@lists.squeakfoundation.org

21 participants
83 discussions

Start a nNew thread

Build failed: opensmalltalk-vm 1.0.1339
by AppVeyor 17 Jun '18

17 Jun '18

1 0

Build failed: opensmalltalk-vm 1.0.1335
by AppVeyor 17 Jun '18

17 Jun '18

3 5

[OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)
by akgrant43 17 Jun '18

17 Jun '18

1.3.0: Change from Unix (UTC) timestamps to Squeak timestamps for file attributes. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268 -- Commit Summary -- * FileAttributesPlugin v1.3.0 * FileAttributesPlugin: Interpreter proxy is responsible for conversion -- File Changes -- M platforms/unix/vm/sqUnixMain.c (44) M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c (523) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268

3 8

[OpenSmalltalk/opensmalltalk-vm] cfbd87: FileAttributesPlugin v1.3.0
by GitHub 17 Jun '18

17 Jun '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: cfbd87ccd361d339df9ce3e2d7f9c6154335b71e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/cfbd87ccd361d339df… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2018-06-15 (Fri, 15 Jun 2018) Changed paths: M platforms/unix/vm/sqUnixMain.c M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c Log Message: ----------- FileAttributesPlugin v1.3.0 Convert file timestamps from Unix (UTC) to Squeak. This should finally get the timestamps on Windows correct (in all the timezone and DST combinations). Commit: 02d593f8a87170583976cd6b75f1df07f14e02aa https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/02d593f8a871705839… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2018-06-16 (Sat, 16 Jun 2018) Changed paths: M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c Log Message: ----------- FileAttributesPlugin: Interpreter proxy is responsible for conversion Commit: bd4ebc86045f2f11025fd8b8d9c5509d37050d12 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/bd4ebc86045f2f1102… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2018-06-16 (Sat, 16 Jun 2018) Changed paths: M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c Log Message: ----------- FileAttributesPlugin 1.3.1: clean-up type declarations - Use #var:type: instead of #var:declareC: - Use symbols for types instead of strings Commit: d583976248e7a65a03712edabd62fd91da628dc1 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d583976248e7a65a03… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2018-06-16 (Sat, 16 Jun 2018) Changed paths: M build.macos32x86/HowToBuild M build.macos64x64/HowToBuild M platforms/win32/vm/sqWin32.h M src/plugins/VMProfileLinuxSupportPlugin/VMProfileLinuxSupportPlugin.c Log Message: ----------- Merge remote-tracking branch 'upstream/Cog' into buildvmmakerimage Commit: 7aedb43079415666065532703299fccc8a6c743c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7aedb4307941566606… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2018-06-17 (Sun, 17 Jun 2018) Changed paths: M platforms/Mac OS/vm/sqMacTime.c M platforms/Mac OS/vm/sqMacTime.h Log Message: ----------- Mac add convertToLongSqueakTime() Commit: 2397f46cf91337a7d836aa1601c1318c312ed1dd https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2397f46cf91337a7d8… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2018-06-17 (Sun, 17 Jun 2018) Changed paths: M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c Log Message: ----------- Merge remote-tracking branch 'upstream/Cog' into buildvmmakerimage Commit: 309a810bab7d4598b7e2650dd1b5f598d0899782 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/309a810bab7d4598b7… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2018-06-17 (Sun, 17 Jun 2018) Changed paths: M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c Log Message: ----------- 1.3.2: Internalise unix to squeak time conversion for MacOS Commit: 84433d3607c6b951bb278616dd40817ded05d174 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/84433d3607c6b951bb… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2018-06-17 (Sun, 17 Jun 2018) Changed paths: M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c Log Message: ----------- FileAttributesPlugin: Exclude faConvertUnixToLongSqueakTime on Win32 Commit: 140ff02e7a49f9fbcd6e772cac5828ca3aa2fda5 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/140ff02e7a49f9fbcd… Author: akgrant43 <akgrant(a)gmail.com> Date: 2018-06-17 (Sun, 17 Jun 2018) Changed paths: M platforms/Mac OS/vm/sqMacTime.c M platforms/Mac OS/vm/sqMacTime.h M platforms/unix/vm/sqUnixMain.c M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c Log Message: ----------- Merge FileAttributesPlugin 1.3.2: Change from Unix (UTC) timestamps to Squeak timestamps for file attributes. Getting UTC timestamps on Windows is problematic... Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/2cc9f1a8cdd8...14… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

Build failed: opensmalltalk-vm 1.0.1337
by AppVeyor 17 Jun '18

17 Jun '18

1 0

Build failed: opensmalltalk-vm 1.0.1336
by AppVeyor 17 Jun '18

17 Jun '18

1 0

[OpenSmalltalk/opensmalltalk-vm] 2cc9f1: CogVM source as per FileAttributesPlugin.oscog-Ali...
by GitHub 17 Jun '18

17 Jun '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 2cc9f1a8cdd823ba59d53eb597e8f738ffaff2a1 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2cc9f1a8cdd823ba59… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-06-16 (Sat, 16 Jun 2018) Changed paths: M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c Log Message: ----------- CogVM source as per FileAttributesPlugin.oscog-AlistairGrant.30 (well, at least the FileAttributesPlugin(. 1.3.1: Change from Unix (UTC) timestamps to Squeak timestamps for file attributes. The posix routines just don't seem to handle timezones and DST correctly. **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

Build failed: opensmalltalk-vm 1.0.1334
by AppVeyor 16 Jun '18

16 Jun '18

1 0

Re: [Vm-dev] [Pharo-dev] FileAttributesPlugin: request for comment and testing
by Eliot Miranda 16 Jun '18

16 Jun '18

Hi Alistair, it looks good to me. I have only a few quibbles. I see a few <var: 'winAttrs' declareC: 'WIN32_FILE_ATTRIBUTE_DATA *winAttrs'> <var: 'accessDate' declareC: 'sqLong *accessDate'> that are better written as var:type: <var: 'winAttrs' type: 'WIN32_FILE_ATTRIBUTE_DATA *'> <var: 'accessDate' type: 'sqLong *'> and I prefer to use symbols for types, because they're usually not unique, so <var: 'winAttrs' type: #'WIN32_FILE_ATTRIBUTE_DATA *'> <var: 'accessDate' type: #'sqLong *'> On Tue, Jun 12, 2018 at 8:45 AM, Alistair Grant <akgrant0710(a)gmail.com> wrote: > Hi Esteban, Guille, Marcus, Cyril and Everyone, > > I'm (finally!) almost ready to merge in the FileAttributesPlugin > changes... > > I have one bug to fix in the VM related to file creation, modification > and access times on Windows. > > While I sort that out (and probably lose what remaining hair I have) I > was hoping that a few people could have a look at the PR on linux and / > or Mac - since it is an admittedly big one. > > Note that you can't merge the changes in to an existing image as > Iceberg will attempt to use the file system in the middle of the merge > and fail. (I haven't tested this after the latest refactor, but I expect > that hasn't changed). You'll need to use the image that has been > bootstrapped from the PR (link below). > > > The source code for the plugin is at: http://smalltalkhub.com/#!/~ > Alistair/FileAttributesPlugin > > PR: https://github.com/pharo-project/pharo/pull/1529 > > Fogbugz: > - https://pharo.fogbugz.com/f/cases/21368/Integrate-FileAttributesPlugin > - https://pharo.fogbugz.com/f/cases/18279/ > > Images: > > - 32 bit: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending% > 20pull%20request%20and%20branch%20Pipeline/job/PR- > 1529/1/artifact/bootstrap-cache/Pharo7.0-32bit-af43d95.zip > - 64 bit: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending% > 20pull%20request%20and%20branch%20Pipeline/job/PR- > 1529/1/artifact/bootstrap-cache/Pharo7.0-64bit-af43d95.zip > > It requires a recent VM, from May 9 or later (the current stable VM). > > > > What are the changes? > ===================== > > - Fixes FileReference>>isSymlink > Currently it only returns true for a broken symbolic link. > - Adds the ability to retrieve symbolic link attributes. > - Extends the set of file attributes that can be retrieved to all > attributes returned by the libc stat() and lstat() calls. > - Refactors the code to be more efficient. In particular > FileReference>>exists. > > > 1. #isSymlink now works properly on Linux (and it should also work on > MacOS and BSD). > 2. The list of file attributes available from DiskDirectoryEntry now is: > #accessTime (new) > #changeTime (new) > #deviceId (new) > #gid (new) > #inode (new) > #isBlock (new) > #isCharacter (new) > #isExecutable (new) > #isFIFO (new) > #isRegular (new) > #isSocket (new) > #isSymlink (works) > #numberOfHardLinks (new) > #targetFile (new) > #uid (new) > > #creationTime > #exists > #isDirectory > #isFile > #isReadable > #isWritable > #modificationTime > #permissions > #size > 3. FileReference>>exists is faster than before (well, at least on my > linux laptop). This is useful as it is called often. > 4. It is possible to retrieve symbolic link attributes, i.e. all the > attributes listed above plus the target path. > > > The public interface hasn't changed. There are a number of internal > changes to FileSystem. > > As implied above, the changes are all backward compatible (except > the broken #isSymlink), although a couple deserve mention: > > 1. Obviously #isSymlink now answers correctly (previously it would only > answer correctly for a broken link). > 2. Requesting any of the attributes listed above (except #isSymlink) > will return the value of the target path. If the FileReference is to a > broken symbolic link, it will return the attributes of the symbolic > link (keeping existing behaviour). > 3. The attributes of a symbolic link can be retrieved using > FileReference>>symlinkEntry. > > Overall, performance is slightly better than before. Code that accesses a > single attribute through FileReference will be faster than before (it used > to retrieve all supported elements and throw the unused ones away). Code > that needs to access multiple attributes and uses FileSystemDirectoryEntry > can access the new attributes without any additional performance cost. > > > > Rough development timeline > ========================== > > > April 2017: Started development > > May 2017: First working version. I've been using this in my personal > environment since May last year. > > August 2017: Plugin review by Nicolas Cellier (thanks, Nicolas!) > > September 2017 - January 2018 : Plugin review by Eliot Miranda (thanks > Eliot!) > This was very detailed and tidied up parameter checking, error > return codes, making the code simulator friendly, etc. > > November 2017: FileAttributesPlugin added to the VM. > > February 2018: Tidy up Windows specific code, fix error handling in > #creationTime. > > June 2018: Refactored to place primitives in File instead of > FileAttributesPluginPrims (which matched FilePluginPrims). > > > > Testing > ======= > > - As mentioned above I've been using this on a daily basis since May 2017. > Some of the packages I have loaded include: Roassal2, Glorp, > OSSubprocess, NeoCSV, DataFrame. > - Automated tests have been added for the new functionality. > - Additional automated tests have been added for existing functionality. > - All existing tests pass > > > Thanks! > Alistair > > -- _,,,^..^,,,_ best, Eliot

2 1

Build failed: opensmalltalk-vm 1.0.1333
by AppVeyor 16 Jun '18

16 Jun '18

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev June 2018