Vm-dev September 2018

vm-dev@lists.squeakfoundation.org

19 participants
41 discussions

[OpenSmalltalk/opensmalltalk-vm] HowToBuild doesn't have to mention missing libssl (#186)
by Nicolas Cellier 18 Oct '18

18 Oct '18

Because we don't need to link against libssl. Keep the hint from Eliot for an hypothetical libfoobar.dylib missing. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/186 -- Commit Summary -- * HowToBuild doesn't have to mention missing libssl -- File Changes -- M build.macos32x86/HowToBuild (31) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/186.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/186.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/186

3 5

[OpenSmalltalk/opensmalltalk-vm] Krono/upgrade gcc (#234)
by Tobias Pape 18 Oct '18

18 Oct '18

Upgrade GCC, demote Newspeak builds You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/234 -- Commit Summary -- * gcc 4.8 seems buggy, try with 6 on linux. * yes * be lenient on Newspeak -- File Changes -- M .travis.yml (58) M .travis_build.sh (21) M .travis_install.sh (8) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/234.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/234.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/234

2 3

VM Maker: VMMaker.oscog-eem.2445.mcz
by commits＠source.squeak.org 02 Oct '18

02 Oct '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2445.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2445 Author: eem Time: 28 September 2018, 5:34:39.268193 pm UUID: ecf80f10-9e24-4ff5-8a41-d65cb2690c94 Ancestors: VMMaker.oscog-eem.2444 Fix degenerate calculations of preload and skew (i.e. a preload that sets notSkewMask to all ones and skewMask to zero, and there-by fix accessing the word beyond the end of a bitmap. If using external forms such access can crash the VM by trying to access a word that is not in memory (e.g. in an unmapped page). N.B. when preload is true, notSkewMask is all ones and skewMask is zero this extra word is read but discarded. Clean up primitiveCopyBits & primitiveWarpBits to use the more modern (and simpler) methodReturnReceiver style. Recategorise some C library extensions as such. =============== Diff against VMMaker.oscog-eem.2444 =============== Item was changed: ----- Method: BitBltSimulation>>copyLoop (in category 'inner loop') ----- copyLoop | prevWord thisWord skewWord halftoneWord mergeWord hInc y unskew skewMask notSkewMask mergeFnwith destWord | "This version of the inner loop assumes noSource = false." <inline: false> <var: #prevWord type: #'unsigned int'> <var: #thisWord type: #'unsigned int'> <var: #skewWord type: #'unsigned int'> <var: #halftoneWord type: #'unsigned int'> <var: #mergeWord type: #'unsigned int'> <var: #destWord type: #'unsigned int'> <var: #skewMask type: #'unsigned int'> <var: #notSkewMask type: #'unsigned int'> <var: #unskew type: #int> "unskew is a bitShift and MUST remain signed, while skewMask is unsigned." <var: #mergeFnwith declareC: 'unsigned int (*mergeFnwith)(unsigned int, unsigned int)'> mergeFnwith := self cCoerce: (opTable at: combinationRule+1) to: 'unsigned int (*)(unsigned int, unsigned int)'. mergeFnwith. "null ref for compiler" hInc := hDir * 4. "Byte delta" + "degenerate skew fixed in sourceSkewAndPointerInit, eem 9/28/2018" + self assert: (skew > -32 and: [skew < 32]). + skew < 0 + ifTrue: + [unskew := skew + 32. + skewMask := AllOnes << (0 - skew)] - "degenerate skew fixed for Sparc. 10/20/96 ikp" - skew = -32 - ifTrue: [skew := unskew := skewMask := 0] ifFalse: + [skew = 0 - [skew < 0 ifTrue: + [unskew := 0. + skewMask := AllOnes] - [unskew := skew+32. - skewMask := AllOnes << (0-skew)] ifFalse: + [unskew := skew - 32. + skewMask := AllOnes >> skew]]. - [skew = 0 - ifTrue: - [unskew := 0. - skewMask := AllOnes] - ifFalse: - [unskew := skew-32. - skewMask := AllOnes >> skew]]]. notSkewMask := skewMask bitInvert32. noHalftone ifTrue: [halftoneWord := AllOnes. halftoneHeight := 0] ifFalse: [halftoneWord := self halftoneAt: 0]. y := dy. "Here is the vertical loop, in two versions, one for the combinationRule = 3 copy mode, one for the general case." combinationRule = 3 ifTrue: [1 to: bbH do: "here is the vertical loop for combinationRule = 3 copy mode; no need to call merge" [ :i | halftoneHeight > 1 ifTrue: "Otherwise, its always the same" [halftoneWord := self halftoneAt: y. y := y + vDir]. preload ifTrue: "load the 64-bit shifter" [prevWord := self srcLongAt: sourceIndex. self incSrcIndex: hInc] ifFalse: [prevWord := 0]. "Note: the horizontal loop has been expanded into three parts for speed:" "This first section requires masking of the destination store..." destMask := mask1. thisWord := self srcLongAt: sourceIndex. "pick up next word" self incSrcIndex: hInc. skewWord := ((prevWord bitAnd: notSkewMask) bitShift: unskew) bitOr: "32-bit rotate" ((thisWord bitAnd: skewMask) bitShift: skew). prevWord := thisWord. destWord := self dstLongAt: destIndex. destWord := (destMask bitAnd: (skewWord bitAnd: halftoneWord)) bitOr: (destWord bitAnd: destMask bitInvert32). self dstLongAt: destIndex put: destWord. self incDestIndex: hInc. "This central horizontal loop requires no store masking" destMask := AllOnes. (skew = 0 and: [halftoneWord = AllOnes]) ifTrue: "Very special inner loop for STORE mode with no skew -- just move words" [hDir = -1 ifTrue: "Woeful patch: revert to older code for hDir = -1" [2 to: nWords-1 do: [ :word | thisWord := self srcLongAt: sourceIndex. self incSrcIndex: hInc. self dstLongAt: destIndex put: thisWord. self incDestIndex: hInc]] ifFalse: [2 to: nWords-1 do: [ :word | "Note loop starts with prevWord loaded (due to preload)" self dstLongAt: destIndex put: prevWord. self incDestIndex: hInc. prevWord := self srcLongAt: sourceIndex. self incSrcIndex: hInc]]] ifFalse: [2 to: nWords-1 do: [ :word | thisWord := self srcLongAt: sourceIndex. self incSrcIndex: hInc. skewWord := ((prevWord bitAnd: notSkewMask) bitShift: unskew) bitOr: "32-bit rotate" ((thisWord bitAnd: skewMask) bitShift: skew). prevWord := thisWord. self dstLongAt: destIndex put: (skewWord bitAnd: halftoneWord). self incDestIndex: hInc]]. "This last section, if used, requires masking of the destination store..." nWords > 1 ifTrue: [destMask := mask2. thisWord := self srcLongAt: sourceIndex. "pick up next word" self incSrcIndex: hInc. skewWord := ((prevWord bitAnd: notSkewMask) bitShift: unskew) bitOr: "32-bit rotate" ((thisWord bitAnd: skewMask) bitShift: skew). destWord := self dstLongAt: destIndex. destWord := (destMask bitAnd: (skewWord bitAnd: halftoneWord)) bitOr: (destWord bitAnd: destMask bitInvert32). self dstLongAt: destIndex put: destWord. self incDestIndex: hInc]. self incSrcIndex: sourceDelta. self incDestIndex: destDelta]] ifFalse: [1 to: bbH do: "here is the vertical loop for the general case (combinationRule ~= 3)" [ :i | halftoneHeight > 1 ifTrue: "Otherwise, its always the same" [halftoneWord := self halftoneAt: y. y := y + vDir]. preload ifTrue: "load the 64-bit shifter" [prevWord := self srcLongAt: sourceIndex. self incSrcIndex: hInc] ifFalse: [prevWord := 0]. "Note: the horizontal loop has been expanded into three parts for speed:" "This first section requires masking of the destination store..." destMask := mask1. thisWord := self srcLongAt: sourceIndex. "pick up next word" self incSrcIndex: hInc. skewWord := ((prevWord bitAnd: notSkewMask) bitShift: unskew) bitOr: "32-bit rotate" ((thisWord bitAnd: skewMask) bitShift: skew). prevWord := thisWord. destWord := self dstLongAt: destIndex. mergeWord := self mergeFn: (skewWord bitAnd: halftoneWord) with: destWord. destWord := (destMask bitAnd: mergeWord) bitOr: (destWord bitAnd: destMask bitInvert32). self dstLongAt: destIndex put: destWord. self incDestIndex: hInc. "This central horizontal loop requires no store masking" destMask := AllOnes. 2 to: nWords-1 do: "Normal inner loop does merge:" [ :word | thisWord := self srcLongAt: sourceIndex. "pick up next word" self incSrcIndex: hInc. skewWord := ((prevWord bitAnd: notSkewMask) bitShift: unskew) bitOr: "32-bit rotate" ((thisWord bitAnd: skewMask) bitShift: skew). prevWord := thisWord. mergeWord := self mergeFn: (skewWord bitAnd: halftoneWord) with: (self dstLongAt: destIndex). self dstLongAt: destIndex put: mergeWord. self incDestIndex: hInc]. "This last section, if used, requires masking of the destination store..." nWords > 1 ifTrue: [destMask := mask2. thisWord := self srcLongAt: sourceIndex. "pick up next word" self incSrcIndex: hInc. skewWord := ((prevWord bitAnd: notSkewMask) bitShift: unskew) bitOr: "32-bit rotate" ((thisWord bitAnd: skewMask) bitShift: skew). destWord := self dstLongAt: destIndex. mergeWord := self mergeFn: (skewWord bitAnd: halftoneWord) with: destWord. destWord := (destMask bitAnd: mergeWord) bitOr: (destWord bitAnd: destMask bitInvert32). self dstLongAt: destIndex put: destWord. self incDestIndex: hInc]. self incSrcIndex: sourceDelta. self incDestIndex: destDelta]]! Item was changed: ----- Method: BitBltSimulation>>primitiveCopyBits (in category 'primitives') ----- primitiveCopyBits "Invoke the copyBits primitive. If the destination is the display, then copy it to the screen." | rcvr | <export: true> rcvr := interpreterProxy stackValue: interpreterProxy methodArgumentCount. + (self loadBitBltFrom: rcvr) ifFalse: + [^interpreterProxy primitiveFail]. - (self loadBitBltFrom: rcvr) ifFalse:[^interpreterProxy primitiveFail]. self copyBits. + interpreterProxy failed ifTrue: [^nil]. - interpreterProxy failed ifTrue:[^nil]. self showDisplayBits. + interpreterProxy failed ifTrue: [^nil]. + (combinationRule = 22 or: [combinationRule = 32]) + ifTrue: [interpreterProxy methodReturnInteger: bitCount] + ifFalse: [interpreterProxy methodReturnReceiver]! - interpreterProxy failed ifTrue:[^nil]. - interpreterProxy pop: interpreterProxy methodArgumentCount. - (combinationRule = 22) | (combinationRule = 32) ifTrue:[ - interpreterProxy pop: 1. - ^ interpreterProxy pushInteger: bitCount].! Item was changed: ----- Method: BitBltSimulation>>primitiveWarpBits (in category 'primitives') ----- primitiveWarpBits "Invoke the warpBits primitive. If the destination is the display, then copy it to the screen." | rcvr | <export: true> rcvr := interpreterProxy stackValue: interpreterProxy methodArgumentCount. (self loadWarpBltFrom: rcvr) ifFalse:[^interpreterProxy primitiveFail]. self warpBits. interpreterProxy failed ifTrue:[^nil]. self showDisplayBits. interpreterProxy failed ifTrue:[^nil]. + interpreterProxy methodReturnReceiver! - interpreterProxy pop: interpreterProxy methodArgumentCount.! Item was changed: ----- Method: BitBltSimulation>>sourceSkewAndPointerInit (in category 'setup') ----- sourceSkewAndPointerInit "This is only used when source and dest are same depth, ie, when the barrel-shift copy loop is used." | dWid sxLowBits dxLowBits pixPerM1 | <inline: true> pixPerM1 := destPPW - 1. "A mask, assuming power of two" sxLowBits := sx bitAnd: pixPerM1. dxLowBits := dx bitAnd: pixPerM1. "check if need to preload buffer (i.e., two words of source needed for first word of destination)" hDir > 0 ifTrue: ["n Bits stored in 1st word of dest" dWid := bbW min: destPPW - dxLowBits. preload := (sxLowBits + dWid) > pixPerM1] ifFalse: [dWid := bbW min: dxLowBits + 1. preload := (sxLowBits - dWid + 1) < 0]. "calculate right-shift skew from source to dest" + skew := (sourceMSB + ifTrue: [sxLowBits - dxLowBits] + ifFalse: [dxLowBits - sxLowBits]) * destDepth. " -32..32 " - sourceMSB - ifTrue:[skew := (sxLowBits - dxLowBits) * destDepth] - ifFalse:[skew := (dxLowBits - sxLowBits) * destDepth]. " -32..32 " preload ifTrue: + [skew ~= 0 ifTrue: + [skew := skew < 0 ifTrue: [skew + 32] ifFalse: [skew - 32]]. + skew = 0 ifTrue: + [preload := false]]. - [skew < 0 - ifTrue: [skew := skew+32] - ifFalse: [skew := skew-32]]. "Calc byte addr and delta from longWord info" + sourceIndex := sourceBits + (sy * sourcePitch) + ((sx // (32 // sourceDepth)) * 4). - sourceIndex := sourceBits + (sy * sourcePitch) + ((sx // (32//sourceDepth)) *4). "calculate increments from end of 1 line to start of next" sourceDelta := (sourcePitch * vDir) - (4 * (nWords * hDir)). preload ifTrue: ["Compensate for extra source word fetched" + sourceDelta := sourceDelta - (4*hDir)]! - sourceDelta := sourceDelta - (4*hDir)].! Item was changed: + ----- Method: VMClass>>asString: (in category 'C library extensions') ----- - ----- Method: VMClass>>asString: (in category 'C library simulation') ----- asString: aStringOrStringIndex "aStringOrStringIndex is either a string or an address in the heap. Create a String of the requested length form the bytes in the heap starting at stringIndex." <doNotGenerate> | sz | aStringOrStringIndex isString ifTrue: [^aStringOrStringIndex]. sz := self strlen: aStringOrStringIndex. ^self strncpy: (ByteString new: sz) _: aStringOrStringIndex _: sz! Item was changed: + ----- Method: VMClass>>asString:size: (in category 'C library extensions') ----- - ----- Method: VMClass>>asString:size: (in category 'C library simulation') ----- asString: stringIndex size: stringSize "stringIndex is an address in the heap. Create a String of the requested length form the bytes in the heap starting at stringIndex." <doNotGenerate> ^self strncpy: (ByteString new: stringSize) _: stringIndex _: stringSize!

2 2

Build failed: opensmalltalk-vm 1.0.1399
by AppVeyor 30 Sep '18

30 Sep '18

3 3

Still Failing: OpenSmalltalk/opensmalltalk-vm#1422 (Cog - 057c592)
by Travis CI 30 Sep '18

30 Sep '18

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1422 Status: Still Failing Duration: 10 mins and 11 secs Commit: 057c592 (Cog) Author: Eliot Miranda Message: Rescue the Win32 builds after a misstep preparing the changes for VMMaker.oscog-eem.2441; additional definitions in sqWin32Directory.c are now no longer conditional in PharoVM. Edit if's and while's in sqWin32Directory.c; these are not functions and hence a space after the keyword is appropriate. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/b1caec7928a9...05… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/435289501?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

Build failed: opensmalltalk-vm 1.0.1400
by AppVeyor 30 Sep '18

30 Sep '18

1 0

[OpenSmalltalk/opensmalltalk-vm] 057c59: Rescue the Win32 builds after a misstep preparing ...
by GitHub 30 Sep '18

30 Sep '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 057c59271227b5f607a6ff85a3941dfd0c96cbbe https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/057c59271227b5f607… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-09-30 (Sun, 30 Sep 2018) Changed paths: M platforms/win32/vm/sqWin32Directory.c Log Message: ----------- Rescue the Win32 builds after a misstep preparing the changes for VMMaker.oscog-eem.2441; additional definitions in sqWin32Directory.c are now no longer conditional in PharoVM. Edit if's and while's in sqWin32Directory.c; these are not functions and hence a space after the keyword is appropriate. **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

Failed: OpenSmalltalk/opensmalltalk-vm#1421 (Cog - b1caec7)
by Travis CI 29 Sep '18

29 Sep '18

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1421 Status: Failed Duration: 19 mins and 10 secs Commit: b1caec7 (Cog) Author: Eliot Miranda Message: CogVM source as per VMMaker.oscog-eem.2445 BitBlt plugin copyBits. Fix degenerate calculations of preload and skew (i.e. a preload that sets notSkewMask to all ones and skewMask to zero, and there-by fix accessing the word beyond the end of a bitmap. If using external forms such access can crash the VM by trying to access a word that is not in memory (e.g. in an unmapped page). N.B. when preload is true, notSkewMask is all ones and skewMask is zero this extra word is read but discarded. Clean up primitiveCopyBits & primitiveWarpBits to use the more modern (and simpler) methodReturnReceiver style. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/d952580fab8f...b1… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/434863694?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

[OpenSmalltalk/opensmalltalk-vm] 01cdaf: CogVM source as per VMMaker.oscog-eem.2441
by GitHub 29 Sep '18

29 Sep '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 01cdaff8bcaeacb7aacca4ac300cb63c304505b8 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/01cdaff8bcaeacb7aa… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-09-18 (Tue, 18 Sep 2018) Changed paths: M platforms/Cross/plugins/FilePlugin/FilePlugin.h M platforms/iOS/vm/Common/Classes/sqSqueakFileDirectoryAPI.m M platforms/unix/plugins/FilePlugin/sqUnixFile.c M platforms/win32/vm/sqWin32Directory.c M src/plugins/FilePlugin/FilePlugin.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2441 Eliminate the variation on dir_[Entry]Lookup between PharoVM and SqueakVM, leaving the difference only in makeDirEntryName:size:createDate:modDate:isDir:fileSize:[posixPermissions:isSymlink:]. Commit: b1caec7928a93f1dcae3382f7499a0643b5ee655 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b1caec7928a93f1dca… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-09-28 (Fri, 28 Sep 2018) Changed paths: M src/plugins/BitBltPlugin/BitBltPlugin.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2445 BitBlt plugin copyBits. Fix degenerate calculations of preload and skew (i.e. a preload that sets notSkewMask to all ones and skewMask to zero, and there-by fix accessing the word beyond the end of a bitmap. If using external forms such access can crash the VM by trying to access a word that is not in memory (e.g. in an unmapped page). N.B. when preload is true, notSkewMask is all ones and skewMask is zero this extra word is read but discarded. Clean up primitiveCopyBits & primitiveWarpBits to use the more modern (and simpler) methodReturnReceiver style. Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/d952580fab8f...b1… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

Customize OS X App
by Christophe Demarey 28 Sep '18

28 Sep '18

Hi, Would it be possible to ship OpenSmalltalk vm with a customizable menu? For example, OpenSmalltalk VM for Pharo looks like this picture: It is very strange for users. Would it be possible to have a way to customize menu entries? I think this part is encoded in MainMenu.nib. It will also be useful to package end-user applications by allowing developers to customize the application menu. Regards, Christophe.

4 7

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev September 2018