Vm-dev November 2019

vm-dev@lists.squeakfoundation.org

19 participants
178 discussions

VM Maker: VMMaker.oscog-eem.2598.mcz
by commits＠source.squeak.org 28 Nov '19

28 Nov '19

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2598.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2598 Author: eem Time: 28 November 2019, 2:59:35.467528 pm UUID: e195198a-a4ee-4bd9-92c2-42accc436f7a Ancestors: VMMaker.oscog-eem.2597 Fix plugin generation given renamed plugins =============== Diff against VMMaker.oscog-eem.2597 =============== Item was changed: ----- Method: VMMaker class>>generateVMPlugins (in category 'configurations') ----- generateVMPlugins ^VMMaker generatePluginsTo: self sourceTree, '/src' options: #() platformDir: self sourceTree, '/platforms' + including:#(ADPCMCodecPlugin AsynchFilePlugin - including:#( ADPCMCodecPlugin AsynchFilePlugin BalloonEnginePlugin B3DAcceleratorPlugin B3DEnginePlugin BMPReadWriterPlugin BitBltSimulation + BochsIA32Plugin BochsX64Plugin GdbARMv6Plugin GdbARMv8Plugin - BochsIA32Plugin BochsX64Plugin CameraPlugin CroquetPlugin DeflatePlugin DropPlugin "Cryptography Plugins:" DESPlugin DSAPlugin MD5Plugin SHA256Plugin "FT2Plugin" FFTPlugin FileCopyPlugin FilePlugin FileAttributesPlugin FloatArrayPlugin FloatMathPlugin + GeniePlugin HostWindowPlugin IA32ABIPlugin ImmX11Plugin InternetConfigPlugin - GeniePlugin GdbARMPlugin HostWindowPlugin IA32ABIPlugin ImmX11Plugin InternetConfigPlugin JPEGReadWriter2Plugin JPEGReaderPlugin JoystickTabletPlugin KlattSynthesizerPlugin LargeIntegersPlugin LocalePlugin MIDIPlugin MacMenubarPlugin Matrix2x3Plugin MiscPrimitivePlugin Mpeg3Plugin QuicktimePlugin RePlugin ScratchPlugin SecurityPlugin SerialPlugin SocketPlugin SoundCodecPlugin SoundGenerationPlugin SoundPlugin SqueakSSLPlugin StarSqueakPlugin ThreadedFFIPlugin ThreadedARM32FFIPlugin ThreadedARM64FFIPlugin ThreadedIA32FFIPlugin ThreadedX64SysVFFIPlugin ThreadedX64Win64FFIPlugin UnicodePlugin UnixAioPlugin UUIDPlugin UnixOSProcessPlugin Win32OSProcessPlugin VMProfileLinuxSupportPlugin VMProfileMacSupportPlugin WeDoPlugin XDisplayControlPlugin)!

1 0

VM Maker: VMMaker.oscog-eem.2597.mcz
by commits＠source.squeak.org 28 Nov '19

28 Nov '19

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2597.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2597 Author: eem Time: 28 November 2019, 2:49:55.799893 pm UUID: 7a69be2e-f0d0-4d41-9854-65432d621fed Ancestors: VMMaker.oscog-eem.2596 Spur: Avoid inlining endCompaction to prevent duplication in compact. =============== Diff against VMMaker.oscog-eem.2596 =============== Item was changed: ----- Method: SpurPlanningCompactor>>endCompaction (in category 'compaction') ----- endCompaction + <inline: false> manager unmarkSurvivingObjectsForCompact; endSlidingCompaction. self repinRememberedSet. self releaseSavedFirstFieldsSpace!

1 0

VM Maker: VMMaker.oscog-eem.2596.mcz
by commits＠source.squeak.org 28 Nov '19

28 Nov '19

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2596.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2596 Author: eem Time: 28 November 2019, 2:33:58.668671 pm UUID: 8500baf3-a5ae-4594-9f3b-08cedfdf1fb3 Ancestors: VMMaker.oscog-cb.2595 Spur: Make a minor refactoring to reinitializeScanFrom: to make it more readable (move assignment to firstMobileObject into scanForFirstFreeAndFirstMobileObjectFrom:). Improve the ImageLeakChecker to bounds check objects while swizzling, and hence detect the damaged images produced by the issue 444 planning compactor bug as corrupted. Refactor swizzleObj: to swizzleObj:in: so that ImageLeakChecker/SpurLeakCheckingSegmentManager can produce more informative diagnostics. Improve the leak checker to first bounds check oops against the heap extent before probing the heap map. This prevents ImageLeakChecker from crashing on issue 444 corrupted images. =============== Diff against VMMaker.oscog-cb.2595 =============== Item was added: + ----- Method: ImageLeakChecker class>>ancilliaryClasses (in category 'translation') ----- + ancilliaryClasses + "Answer any extra classes to be included in the translation." + ^super ancilliaryClasses, { SpurLeakCheckingSegmentManager }! Item was changed: ----- Method: ImageLeakChecker class>>isAcceptableAncilliaryClass: (in category 'translation') ----- isAcceptableAncilliaryClass: aClass + ^aClass == CogStackPage + or: [aClass == SpurLeakCheckingSegmentManager + or: [self objectMemoryClass ancilliaryClasses includes: aClass]]! - ^aClass == CogStackPage or: [self objectMemoryClass ancilliaryClasses includes: aClass]! Item was added: + ----- Method: ImageLeakChecker>>initializeInterpreter: (in category 'initialization') ----- + initializeInterpreter: bytesToShift + objectMemory segmentManager noteValidHeapExtent: bytesToShift. + super initializeInterpreter: bytesToShift! Item was changed: ----- Method: ImageLeakChecker>>main:_: (in category 'api') ----- main: argc _: argv <var: 'argc' type: #int> <var: 'argv' declareC: 'char *argv[]'> <returnTypeC: #int> <api> + | forVersion argi ifh ok okSwizzle | - | forVersion argi ifh ok | <var: 'ifh' type: #'FILE *'> argi := 1. forVersion := false. [argi < argc and: [((argv at: argi) at: 0) = $-]] whileTrue: [(self strcmp: (self asCommandLineArgument: 'version') _: (argv at: argi)) = 0 ifTrue: ['%s\n' printf: (self cCode: 'interpreterVersion' inSmalltalk: ['don''t ask silly questions']). forVersion := true]. (self strcmp: (self asCommandLineArgument: 'verbose') _: (argv at: argi)) = 0 ifTrue: [verbose := true]. argi := argi + 1]. (argc = argi and: [forVersion]) ifTrue: [^0]. (argc ~= (argi + 1) or: [(ifh := self sqImageFileOpen: (argv at: argi) _: 'rb') = 0]) ifTrue: ['Usage: %s [%s] [%s] imageFileName\n' printf: {(argv at: 0). self asCommandLineArgument: 'verbose'. self asCommandLineArgument: 'version'}. ^self cCode: [1] inSmalltalk: [false]]. self readImageFromFile: ifh HeapSize: 0 StartingAt: 0. self sqImageFileClose: ifh. + okSwizzle := objectMemory segmentManager detectedInvalidOop not. ok := objectMemory runLeakCheckerForResult: GCModeFull. + (verbose and: [okSwizzle and: [ok]]) ifTrue: - (verbose and: [ok]) ifTrue: ['Image %s is free of leaks\n' printf: {(argv at: argi)}]. ^self cCode: [ok ifTrue: [0] ifFalse: [2]] inSmalltalk: [ok]! Item was added: + ----- Method: ImageLeakChecker>>verbose (in category 'accessing') ----- + verbose + ^verbose! Item was added: + ----- Method: Spur32BitCoMemoryManager>>isInHeapBounds: (in category 'plugin support') ----- + isInHeapBounds: address + "Answer if the given address is within the entire range ST object memory. + For quick checking during leak checking only!!" + ^(self oop: address isGreaterThanOrEqualTo: memory) + and: [self oop: address isLessThan: endOfMemory]! Item was added: + ----- Method: Spur64BitCoMemoryManager>>isInHeapBounds: (in category 'plugin support') ----- + isInHeapBounds: address + "Answer if the given address is within the entire range ST object memory. + For quick checking during leak checking only!!" + ^(self oop: address isGreaterThanOrEqualTo: memory) + and: [self oop: address isLessThan: endOfMemory]! Item was added: + SpurSegmentManager subclass: #SpurLeakCheckingSegmentManager + instanceVariableNames: 'oldHeapBase oldHeapLimit detectedInvalidOop subsequentReport' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMaker-Utilities'! Item was added: + ----- Method: SpurLeakCheckingSegmentManager>>detectedInvalidOop (in category 'accessing') ----- + detectedInvalidOop + ^detectedInvalidOop! Item was added: + ----- Method: SpurLeakCheckingSegmentManager>>initialize (in category 'initialization') ----- + initialize + super initialize. + detectedInvalidOop := false. + subsequentReport := false! Item was added: + ----- Method: SpurLeakCheckingSegmentManager>>noteValidHeapExtent: (in category 'initialization') ----- + noteValidHeapExtent: bytesToShift + oldHeapBase := manager memoryBaseForImageRead - bytesToShift. + oldHeapLimit := self lastSegment segStart + self lastSegment segSize - self lastSegment swizzle! Item was added: + ----- Method: SpurLeakCheckingSegmentManager>>swizzleObj:in: (in category 'snapshot') ----- + swizzleObj: objOop in: containerOopOrNil + <inline: false> + "Override to check that objOop is in bounds." + (self oop: objOop isGreaterThanOrEqualTo: oldHeapBase andLessThan: oldHeapLimit) ifFalse: + [manager coInterpreter verbose ifTrue: + [subsequentReport ifFalse: + ['Swizzling:\n' printf. + subsequentReport := true]. + containerOopOrNil + ifNil: ['Oop %p is out of bounds\n' printf: { objOop }] + ifNotNil: ['Oop %p is out of bounds at/in %p\n' printf: { objOop. containerOopOrNil - manager nilObject }]]. + detectedInvalidOop := true]. + "And now swizzle inline" + numSegments - 1 to: 1 by: -1 do: + [:i| + objOop >= (segments at: i) segStart ifTrue: + [^objOop + (segments at: i) swizzle]]. + ^objOop + (segments at: 0) swizzle! Item was changed: ----- Method: SpurMemoryManager>>checkHeapIntegrity:classIndicesShouldBeValid: (in category 'debug support') ----- (excessive size, no diff calculated) Item was changed: ----- Method: SpurMemoryManager>>checkOopIntegrity:named: (in category 'debug support') ----- checkOopIntegrity: obj named: name <inline: false> <var: #name type: #'char *'> + ((self oop: obj isLessThan: endOfMemory) + and: [(heapMap heapMapAtWord: (self pointerForOop: obj)) ~= 0]) ifTrue: - (heapMap heapMapAtWord: (self pointerForOop: obj)) ~= 0 ifTrue: [^true]. coInterpreter print: name; print: ' leak '; printHex: obj; cr. ^false! Item was changed: ----- Method: SpurMemoryManager>>checkOopIntegrity:named:index: (in category 'debug support') ----- checkOopIntegrity: obj named: name index: i <inline: false> <var: #name type: #'char *'> + ((self oop: obj isLessThan: endOfMemory) + and: [(heapMap heapMapAtWord: (self pointerForOop: obj)) ~= 0]) ifTrue: - (heapMap heapMapAtWord: (self pointerForOop: obj)) ~= 0 ifTrue: [^true]. coInterpreter print: name; print: ' leak @ '; printNum: i; print: ' = '; printHex: obj; cr. ^false! Item was changed: ----- Method: SpurMemoryManager>>initializeFreeSpacePostLoad: (in category 'snapshot') ----- initializeFreeSpacePostLoad: freeListObj "Reinitialize the free list info. The freeLists object needs to be swizzled because its neither a free, nor a pointer object. Free objects have already been swizzled in adjustAllOopsBy:" self assert: (self numSlotsOf: freeListObj) = self numFreeLists. self assert: (self formatOf: freeListObj) = self wordIndexableFormat. freeLists := self firstIndexableField: freeListObj. freeListsMask := 0. 0 to: self numFreeLists - 1 do: [:i| (freeLists at: i) ~= 0 ifTrue: [freeListsMask := freeListsMask bitOr: (1 << i). + freeLists at: i put: (segmentManager swizzleObj: (freeLists at: i) in: freeListObj)]]! - freeLists at: i put: (segmentManager swizzleObj: (freeLists at: i))]]! Item was added: + ----- Method: SpurMemoryManager>>isInHeapBounds: (in category 'plugin support') ----- + isInHeapBounds: address + "Answer if the given address is within the entire range ST object memory. + For quick checking during leak checking only!!" + ^(self oop: address isGreaterThanOrEqualTo: newSpaceStart) + and: [self oop: address isLessThan: endOfMemory]! Item was changed: ----- Method: SpurMemoryManager>>swizzleFieldsOfFreeChunk: (in category 'snapshot') ----- swizzleFieldsOfFreeChunk: chunk <inline: true> | field chunkBytes | field := self fetchPointer: self freeChunkNextIndex ofFreeChunk: chunk. field ~= 0 ifTrue: [self storePointerNoAssert: self freeChunkNextIndex ofFreeChunk: chunk + withValue: (segmentManager swizzleObj: field in: chunk)]. - withValue: (segmentManager swizzleObj: field)]. chunkBytes := self bytesInObject: chunk. false ifTrue: "The prevPointer is not guaranteed to be valid in older images. updateListStartingAt: via updateFreeLists does restore the prev pointer in all small free lists, so simply avoid swizzling it now." [(self isLilliputianSize: chunkBytes) ifFalse: [field := self fetchPointer: self freeChunkPrevIndex ofFreeChunk: chunk. field ~= 0 ifTrue: [self storePointerNoAssert: self freeChunkPrevIndex ofFreeChunk: chunk + withValue: (segmentManager swizzleObj: field in: chunk)]]]. - withValue: (segmentManager swizzleObj: field)]]]. chunkBytes >= (self numFreeLists * self allocationUnit) ifTrue: [self freeChunkParentIndex to: self freeChunkLargerIndex do: [:index| field := self fetchPointer: index ofFreeChunk: chunk. field ~= 0 ifTrue: [self storePointerNoAssert: index ofFreeChunk: chunk + withValue: (segmentManager swizzleObj: field in: chunk)]]]! - withValue: (segmentManager swizzleObj: field)]]]! Item was changed: ----- Method: SpurMemoryManager>>swizzleFieldsOfObject: (in category 'snapshot') ----- swizzleFieldsOfObject: oop | fieldAddr fieldOop | <inline: true> fieldAddr := oop + (self lastPointerOfWhileSwizzling: oop). [self oop: fieldAddr isGreaterThanOrEqualTo: oop + self baseHeaderSize] whileTrue: [fieldOop := self longAt: fieldAddr. (self isNonImmediate: fieldOop) ifTrue: + [self longAt: fieldAddr put: (segmentManager swizzleObj: fieldOop in: oop)]. - [self longAt: fieldAddr put: (segmentManager swizzleObj: fieldOop)]. fieldAddr := fieldAddr - self bytesPerOop]! Item was changed: ----- Method: SpurMemoryManager>>swizzleObjStackAt: (in category 'obj stacks') ----- swizzleObjStackAt: objStackRootIndex "On load, swizzle the pointers in an obj stack. Answer the obj stack's oop." | firstPage page stackOrNil index field | firstPage := stackOrNil := self fetchPointer: objStackRootIndex ofObject: hiddenRootsObj. stackOrNil = nilObj ifTrue: [^stackOrNil]. [self assert: (self numSlotsOfAny: stackOrNil) = ObjStackPageSlots. self assert: (self fetchPointer: ObjStackMyx ofObject: stackOrNil) = objStackRootIndex. "There are four fixed slots in an obj stack, and a Topx of 0 indicates empty, so if there were 5 slots in an oop stack, full would be 2, and the last 0-rel index is 4. Hence the last index is topx + fixed slots - 1, or topx + ObjStackNextx" index := (self fetchPointer: ObjStackTopx ofObject: stackOrNil) + ObjStackNextx. "swizzle fields including ObjStackNextx, excluding ObjStackFreex and leave field containing the next link." [field := self fetchPointer: index ofObject: stackOrNil. (field = 0 or: [self isImmediate: field]) ifFalse: + [field := segmentManager swizzleObj: field in: stackOrNil. - [field := segmentManager swizzleObj: field. self storePointer: index ofObjStack: stackOrNil withValue: field]. (index := index - 1) >= ObjStackNextx] whileTrue. (stackOrNil := field) ~= 0] whileTrue. (stackOrNil := self fetchPointer: ObjStackFreex ofObject: firstPage) ~= 0 ifTrue: [page := firstPage. + [stackOrNil := segmentManager swizzleObj: stackOrNil in: firstPage. - [stackOrNil := segmentManager swizzleObj: stackOrNil. self storePointer: ObjStackFreex ofObjStack: page withValue: stackOrNil. page := stackOrNil. (stackOrNil := self fetchPointer: ObjStackFreex ofObject: page) ~= 0] whileTrue]. self assert: (self isValidObjStackAt: objStackRootIndex). ^self fetchPointer: objStackRootIndex ofObject: hiddenRootsObj! Item was changed: ----- Method: SpurPlanningCompactor>>reinitializeScanFrom: (in category 'compaction') ----- reinitializeScanFrom: initialObject "Search for firstFreeObject and firstMobileObject from initialObject, which is the hiddenRootsObject on the first pass, and the objectAfterLastMobileObject on subsequent passes)." - firstMobileObject := manager endOfMemory. firstFreeObject := self scanForFirstFreeAndFirstMobileObjectFrom: initialObject. firstFreeObject ifNotNil: [mobileStart := manager startOfObject: firstFreeObject]. objectAfterLastMobileObject ifNotNil: [manager allOldSpaceEntitiesFrom: firstFreeObject to: objectAfterLastMobileObject do: [:o| ((manager isPinned: o) or: [(manager isMarked: o) not or: [objectAfterLastMobileObject = o]]) ifFalse: [manager setIsMarkedOf: o to: false]]. firstMobileObject := objectAfterLastMobileObject]! Item was changed: ----- Method: SpurPlanningCompactor>>scanForFirstFreeAndFirstMobileObjectFrom: (in category 'compaction') ----- scanForFirstFreeAndFirstMobileObjectFrom: initialObject + "Scan from initialObject, setting firstMobileObject to the first marked + object after the first free object found, or endOfMemory if none is found. + Answer the first free object found, or nil if none." - "Scan from initialObject, setting firstMobileObject to the first marked object after - the first free object found. Answer the first free object found, or nil if none." <inline: false> | firstFree | + firstMobileObject := manager endOfMemory. manager allOldSpaceEntitiesFrom: initialObject do: [:o| (manager isMarked: o) ifTrue: [firstFree ifNotNil: [firstMobileObject := o. ^firstFree]] ifFalse: [firstFree ifNil: [firstFree := o]]]. ^firstFree! Item was added: + ----- Method: SpurSegmentManager>>swizzleObj:in: (in category 'snapshot') ----- + swizzleObj: objOop in: containerOrNil + "Hook for error reporting in SpurLeakCheckingSegmentManager" + <inline: #always> + ^self swizzleObj: objOop!

1 0

ARM emulation alternatiaves
by Ben Coman 28 Nov '19

28 Nov '19

Following a thread from a post in my feed led me to... Dynarmic - A dynamic recompiler for ARM. https://github.com/MerryMage/dynarmic and from there on to... VisUAL - a highly visual ARM emulator https://salmanarif.bitbucket.io/visual/index.html It seems only to do a subset of instructions, so maybe not practical for working with Cog, but a few of the features could potentially aid debugging generated code... * users can navigate program history by browsing past register values. This feature can help debugging and understanding complex code easier. * Pointers in ARM assembly can be quite difficult to understand, especially since ARM assembly has 9 different variations of pointer behaviour when it comes to load/store instructions. VisUAL provides an information pane that displays useful pointer information when needed. * Instructions to load/store multiple instructions in the form of a stack can be visualised. cheers -ben

1 0

VM Maker: VMMaker.oscog-cb.2595.mcz
by commits＠source.squeak.org 28 Nov '19

28 Nov '19

ClementBera uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-cb.2595.mcz ==================== Summary ==================== Name: VMMaker.oscog-cb.2595 Author: cb Time: 28 November 2019, 8:54:30.534147 pm UUID: 5bd3af22-bdf4-425c-b63c-6eb29fbfc606 Ancestors: VMMaker.oscog-eem.2594 Fixed a fascinating bug in Planning compactor. Sometimes Planning decides to go for a multi-pass compaction, but in one compaction it compacts it all, so that firstFreeObject is the last object on heap, on the object after firstFreeObject is outside of the heap. Planning gets confused in this case, while everything is compacted. So I changed to abort compaction in that case, since everything is already compacted. =============== Diff against VMMaker.oscog-eem.2594 =============== Item was changed: ----- Method: SpurPlanningCompactor>>compact (in category 'compaction - api') ----- compact "Sweep all of old space, sliding unpinned marked objects down over free and unmarked objects. Let the segmentManager mark which segments contain pinned objects via notePinned:." | finalPass firstPass | <inline: #never> "for profiling" self initializeScanCheckingForFullyCompactedHeap ifTrue: [^self unmarkObjectsInFullyCompactedHeap]. self initializeCompaction. firstPass := true. [finalPass := self planCompactSavingForwarders. self assert: (self validRelocationPlanInPass: finalPass) = 0. self updatePointers. self copyAndUnmark: firstPass. "Would like to check here, but can't if multi-pass." false ifTrue: [manager checkFreeSpace: GCModeFull]. "Currently we do only a single pass if a normal GC, assuming that a pass will always compact plenty of space. But we should perhaps check this assumption by looking at the large free tree and seeing that the ratio of the largest free chunk to the total ammount of free space is high." finalPass or: [biasForGC]] whileFalse: [firstPass := false. + self reinitializeScanFrom: firstFreeObject. + firstMobileObject > firstFreeObject ifFalse: + ["We get here when firstFreeObject is the last object in memory. + firstMobileObject may be random value from previous compaction + in this case, and heap is fully compacted. Abort compaction." + "We set firstFreeObject to firstMobileObject for unmarking." + firstFreeObject := firstMobileObject. + self unmarkObjectsFromFirstFreeObject. + manager checkFreeSpace: GCModeFull. + ^self endCompaction]. + self updateSavedFirstFieldsSpaceIfNecessary]. - self reinitializeScanFrom: firstFreeObject; - updateSavedFirstFieldsSpaceIfNecessary]. manager checkFreeSpace: GCModeFull. self endCompaction!

1 0

[OpenSmalltalk/opensmalltalk-vm] 9d2cdc: Bring the pharo.stack.spur build up to date w.r.t....
by Eliot Miranda 27 Nov '19

27 Nov '19

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 9d2cdcb6cc0a43cf5ce63a76fd39cd3233523b34 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9d2cdcb6cc0a43cf5c… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2019-11-27 (Wed, 27 Nov 2019) Changed paths: M build.macos64x64/pharo.stack.spur/Makefile Log Message: ----------- Bring the pharo.stack.spur build up to date w.r.t. pharo.cog.spur to help debug the stack corruption issue. [ci skip]

1 0

VM Maker: VMMaker.oscog-eem.2594.mcz
by commits＠source.squeak.org 26 Nov '19

26 Nov '19

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2594.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2594 Author: eem Time: 25 November 2019, 5:15:25.766951 pm UUID: ed66c0f5-0e21-4a13-b5b7-6fd82c34c944 Ancestors: VMMaker.oscog-eem.2593 Progress towards ARMv8 code generation. Add a BS version of computeMaximumSize. =============== Diff against VMMaker.oscog-eem.2593 =============== Item was changed: ----- Method: CogARMCompiler>>cResultRegister (in category 'abi') ----- cResultRegister + "Answer the register through which C functions return integral results." - "Answer the register through which C funcitons return integral results." <inline: true> ^R0! Item was changed: CogAbstractInstruction subclass: #CogARMv8Compiler instanceVariableNames: '' classVariableNames: 'AL CC CS D0 D1 D10 D11 D12 D13 D14 D15 D16 D17 D18 D19 D2 D20 D21 D22 D23 D24 D25 D26 D27 D28 D29 D3 D30 D31 D4 D5 D6 D7 D8 D9 EQ GE GT HI LE LS LT MI NE PL R0 R1 R10 R11 R12 R13 R14 R15 R16 R17 R18 R19 R2 R20 R21 R22 R23 R24 R25 R26 R27 R28 R29 R3 R30 R31 R4 R5 R6 R7 R8 R9 VC VS' poolDictionaries: 'ARMv8A64Opcodes' category: 'VMMaker-JIT'! + + !CogARMv8Compiler commentStamp: 'eem 11/25/2019 16:30' prior: 0! + I generate ARMv8 machine code instructions from CogAbstractInstructions with CogRTLOpcodes. + Here in "Arm ARM" refers to + Arm® Architecture Reference Manual + Armv8, for Armv8-A architecture profile + https://developer.arm.com/docs/ddi0487/latest/arm-architecture-reference-ma…! Item was added: + ----- Method: CogARMv8Compiler>>cResultRegister (in category 'abi') ----- + cResultRegister + "Answer the register through which C functions return integral results." + <inline: true> + ^R0! Item was added: + ----- Method: CogARMv8Compiler>>computeMaximumSize (in category 'generate machine code') ----- + computeMaximumSize + "Because we don't use Thumb, each ARMv8 instruction has 4 bytes. Several + abstract opcodes need more than one instruction. Instructions that refer + to constants and/or literals depend on literals being stored in-line or out-of-line. + + N.B. The ^N forms are to get around the bytecode compiler's long branch + limits which are exceeded when each case jumps around the otherwise." + + opcode + caseOf: { + "Noops & Pseudo Ops" + [Label] -> [^0]. + [Literal] -> [^4]. + [AlignmentNops] -> [^(operands at: 0) - 4]. + [Fill32] -> [^4]. + [Nop] -> [^4]. + "Control" + [Call] -> [^4]. + [CallFull] -> [^8]. + [JumpR] -> [^4]. + [Jump] -> [^4]. + [JumpFull] -> [^8]. + [JumpLong] -> [^4]. + [JumpZero] -> [^4]. + [JumpNonZero] -> [^4]. + [JumpNegative] -> [^4]. + [JumpNonNegative] -> [^4]. + [JumpOverflow] -> [^4]. + [JumpNoOverflow] -> [^4]. + [JumpCarry] -> [^4]. + [JumpNoCarry] -> [^4]. + [JumpLess] -> [^4]. + [JumpGreaterOrEqual] -> [^4]. + [JumpGreater] -> [^4]. + [JumpLessOrEqual] -> [^4]. + [JumpBelow] -> [^4]. + [JumpAboveOrEqual] -> [^4]. + [JumpAbove] -> [^4]. + [JumpBelowOrEqual] -> [^4]. + [JumpLongZero] -> [^4]. + [JumpLongNonZero] -> [^4]. + [JumpFPEqual] -> [^8]. + [JumpFPNotEqual] -> [^8]. + [JumpFPLess] -> [^8]. + [JumpFPGreaterOrEqual] -> [^8]. + [JumpFPGreater] -> [^8]. + [JumpFPLessOrEqual] -> [^8]. + [JumpFPOrdered] -> [^8]. + [JumpFPUnordered] -> [^8]. + [RetN] -> [^(operands at: 0) = 0 ifTrue: [4] ifFalse: [8]]. + [Stop] -> [^4]. + + "Arithmetic" + [AddCqR] -> [^8]. + [AndCqR] -> [^8]. + [AndCqRR] -> [^8]. + [CmpCqR] -> [^8]. + [OrCqR] -> [^8]. + [SubCqR] -> [^8]. + [TstCqR] -> [^8]. + [XorCqR] -> [^8]. + [AddCwR] -> [^8]. + [AndCwR] -> [^8]. + [CmpCwR] -> [^8]. + [OrCwR] -> [^8]. + [SubCwR] -> [^8]. + [XorCwR] -> [^8]. + [AddRR] -> [^4]. + [AndRR] -> [^4]. + [CmpRR] -> [^4]. + [OrRR] -> [^4]. + [XorRR] -> [^4]. + [SubRR] -> [^4]. + [NegateR] -> [^4]. + [LoadEffectiveAddressMwrR] -> [8]. + + [LogicalShiftLeftCqR] -> [^4]. + [LogicalShiftRightCqR] -> [^4]. + [ArithmeticShiftRightCqR] -> [^4]. + [LogicalShiftLeftRR] -> [^4]. + [LogicalShiftRightRR] -> [^4]. + [ArithmeticShiftRightRR] -> [^4]. + [AddRdRd] -> [^4]. + [CmpRdRd] -> [^4]. + [SubRdRd] -> [^4]. + [MulRdRd] -> [^4]. + [DivRdRd] -> [^4]. + [SqrtRd] -> [^4]. + [ClzRR] -> [^4]. + "Data Movement" + [MoveCqR] -> [^4]. + [MoveCwR] -> [^4]. + [MoveRR] -> [^4]. + [MoveRdRd] -> [^4]. + [MoveAwR] -> [^(self isAddressRelativeToVarBase: (operands at: 0)) + ifTrue: [4] + ifFalse: [8]]. + [MoveRAw] -> [^(self isAddressRelativeToVarBase: (operands at: 1)) + ifTrue: [4] + ifFalse: [8]]. + [MoveAbR] -> [^(self isAddressRelativeToVarBase: (operands at: 0)) + ifTrue: [4] + ifFalse: [8]]. + [MoveRAb] -> [^(self isAddressRelativeToVarBase: (operands at: 1)) + ifTrue: [4] + ifFalse: [8]]. + [MoveRMwr] -> [^self is12BitValue: (operands at: 1) + ifTrue: [:u :i| 4] + ifFalse: [8]]. + [MoveRdM64r] -> [^8]. + [MoveMbrR] -> [^self is12BitValue: (operands at: 0) + ifTrue: [:u :i| 4] + ifFalse: [8]]. + [MoveRMbr] -> [^self is12BitValue: (operands at: 1) + ifTrue: [:u :i| 4] + ifFalse: [8]]. + [MoveRM16r] -> [^self is12BitValue: (operands at: 1) + ifTrue: [:u :i| 4] + ifFalse: [8]]. + [MoveM16rR] -> [self halt]. + [MoveM64rRd] -> [^8]. + [MoveMwrR] -> [^self is12BitValue: (operands at: 0) + ifTrue: [:u :i| 4] + ifFalse: [8]]. + [MoveXbrRR] -> [^4]. + [MoveRXbrR] -> [^4]. + [MoveXwrRR] -> [^4]. + [MoveRXwrR] -> [^4]. + [PopR] -> [^4]. + [PushR] -> [^4]. + [PushCw] -> [self halt]. + [PushCq] -> [self halt]. + [PrefetchAw] -> [self halt]. + "Conversion" + [ConvertRRd] -> [^8]. + }. + ^0 "to keep C compiler quiet" + ! Item was added: + ----- Method: CogARMv8Compiler>>isPCDependent (in category 'testing') ----- + isPCDependent + "Answer if the receiver is a pc-dependent instruction. With out-of-line literals any instruction + that refers to a literal depends on the address of the literal, so add them in addition to the jumps." + ^self isJump + or: [opcode = AlignmentNops + or: [opcode ~= Literal and: [dependent notNil and: [dependent opcode = Literal]]]]!

1 0

[OpenSmalltalk/opensmalltalk-vm] 6e6793: Use diskutil eject, not assume there is an eject c...
by Eliot Miranda 26 Nov '19

26 Nov '19

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 6e6793d5374f78222d7f12ce2bed61260c78fe8d https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/6e6793d5374f78222d… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2019-11-25 (Mon, 25 Nov 2019) Changed paths: M image/getGoodSpurVM.sh Log Message: ----------- Use diskutil eject, not assume there is an eject command (wot I 'ave written). [ci skip]

1 0

VM Maker: VMMaker.oscog-eem.2593.mcz
by commits＠source.squeak.org 26 Nov '19

26 Nov '19

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2593.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2593 Author: eem Time: 25 November 2019, 4:25:37.475274 pm UUID: 54657ad2-3651-4c19-9cdf-3699c8ae5faf Ancestors: VMMaker.oscog-eem.2592 ARM Cogits: Get initialization for the ARMv8 ISA to select CogARMv8Compiler/GdbARMv8Alien. Implement CogARMv8Compiler>>stopsFrom:to:. Use memset:_:_: instead of me:ms:et: et al. Reduce the size of an abstract instruction on ARMv5 with out-of-line literals. We need only two words, not the five for the in-line literals case. =============== Diff against VMMaker.oscog-eem.2592 =============== Item was changed: ----- Method: CoInterpreter>>initStackPagesAndInterpret (in category 'initialization') ----- initStackPagesAndInterpret "Initialize the stack pages and enter interpret. Use alloca'ed memory so that when we have a JIT its stack pointer will be on the native stack since alloca allocates memory on the stack. Certain thread systems use the native stack pointer as the frame ID so putting the stack anywhere else can confuse the thread system." "Override to establish the setjmp/longjmp handler for reentering the interpreter from machine code, and disable executablity on the heap and stack pages." "This should be in its own initStackPages method but Slang can't inline C code strings." | stackPageBytes stackPagesBytes theStackMemory | <var: #theStackMemory type: #'char *'> stackPageBytes := self stackPageByteSize. stackPagesBytes := self computeStackZoneSize. theStackMemory := self cCode: [self alloca: stackPagesBytes] inSmalltalk: [stackPages initializeWithByteSize: stackPagesBytes for: self]. + self cCode: [self memset: theStackMemory _: 0 _: stackPagesBytes]. - self cCode: [self me: theStackMemory ms: 0 et: stackPagesBytes]. self sqMakeMemoryNotExecutableFrom: objectMemory startOfMemory asUnsignedInteger To: objectMemory memoryLimit asUnsignedInteger. self sqMakeMemoryNotExecutableFrom: theStackMemory asUnsignedInteger To: theStackMemory asUnsignedInteger + stackPagesBytes. stackPages initializeStack: theStackMemory numSlots: stackPagesBytes / objectMemory wordSize pageSize: stackPageBytes / objectMemory wordSize. self assert: self minimumUnusedHeadroom = stackPageBytes. "Once the stack pages are initialized we can continue to bootstrap the system." self loadInitialContext. "We're ready for the heartbeat (poll interrupt)" self ioInitHeartbeat. self initialEnterSmalltalkExecutive. ^nil! Item was changed: ----- Method: CogARMCompiler>>machineCodeBytes (in category 'generate machine code') ----- machineCodeBytes + "Answer the maximum number of bytes of machine code generated for any abstract instruction." + ^self subclassResponsibility! - "Answer the maximum number of bytes of machine code generated for any abstract instruction. - e.g. CmpCwR => - mov R3, #<addressByte1>, 12 - orr R3, R3, #<addressByte2>, 8 - orr R3, R3, #<addressByte3>, 4 - orr R3, R3, #<addressByte4>, 0 - cmp R?, R3" - ^20! Item was changed: ----- Method: CogARMCompiler>>machineCodeWords (in category 'generate machine code') ----- machineCodeWords + ^self machineCodeBytes / 4! - "Answer the maximum number of words of machine code generated for any abstract instruction. - e.g. CmpCwR => - mov R3, #<addressByte1>, 12 - orr R3, R3, #<addressByte2>, 8 - orr R3, R3, #<addressByte3>, 4 - orr R3, R3, #<addressByte4>, 0 - cmp R?, R3" - ^5! Item was changed: ----- Method: CogARMv8Compiler class>>ISA (in category 'translation') ----- ISA "Answer the name of the ISA the receiver implements." ^#ARMv8! Item was added: + ----- Method: CogARMv8Compiler>>stop (in category 'encoding') ----- + stop + "generate a HLT; C6.2.92 Arm ARM" + <inline: true> + ^2r11010100010000000000000000000000 "16rD4400000"! Item was added: + ----- Method: CogARMv8Compiler>>stopsFrom:to: (in category 'generate machine code') ----- + stopsFrom: startAddr to: endAddr + self assert: endAddr - startAddr + 1 \\ 4 = 0. + startAddr to: endAddr by: 4 do: + [:addr | objectMemory long32At: addr put: self stop]! Item was changed: ----- Method: CogIA32Compiler>>stopsFrom:to: (in category 'generate machine code') ----- stopsFrom: startAddr to: endAddr self + cCode: [self memset: startAddr _: self stop _: endAddr - startAddr + 1] - cCode: [self me: startAddr ms: self stop et: endAddr - startAddr + 1] inSmalltalk: [| alignedEnd alignedStart stops | stops := self stop << 8 + self stop. stops := stops << 16 + stops. alignedStart := startAddr + 3 // 4 * 4. alignedEnd := endAddr - 1 // 4 * 4. alignedEnd <= startAddr ifTrue: [startAddr to: endAddr do: [:addr | objectMemory byteAt: addr put: self stop]] ifFalse: [startAddr to: alignedStart - 1 do: [:addr | objectMemory byteAt: addr put: self stop]. alignedStart to: alignedEnd by: 4 do: [:addr | objectMemory long32At: addr put: stops]. alignedEnd + 4 to: endAddr do: [:addr | objectMemory byteAt: addr put: self stop]]]! Item was added: + ----- Method: CogInLineLiteralsARMCompiler>>machineCodeBytes (in category 'generate machine code') ----- + machineCodeBytes + "Answer the maximum number of bytes of machine code generated for any abstract instruction. + e.g. CmpCwR => + mov R3, #<addressByte1>, 12 + orr R3, R3, #<addressByte2>, 8 + orr R3, R3, #<addressByte3>, 4 + orr R3, R3, #<addressByte4>, 0 + cmp R?, R3" + ^20! Item was changed: ----- Method: CogMIPSELCompiler class>>printFormatForOpcodeName: (in category 'debug printing') ----- printFormatForOpcodeName: opcodeName "Answer a sequence of $r, $f or nil for the operands in the opcode, used for printing, where r => integer register, f => floating point register, and nil => numeric or address operand. Subclasses can override to provide a format string for their own private opcodes." + ^(opcodeName beginsWith: 'Br') ifTrue: [' rr'] ifFalse: [#()]! - ^(opcodeName startsWith: 'Br') ifTrue: [' rr'] ifFalse: [#()]! Item was added: + ----- Method: CogOutOfLineLiteralsARMCompiler>>machineCodeBytes (in category 'generate machine code') ----- + machineCodeBytes + "Answer the maximum number of bytes of machine code generated for any abstract instruction." + ^8! Item was changed: ----- Method: CogX64Compiler>>stopsFrom:to: (in category 'generate machine code') ----- stopsFrom: startAddr to: endAddr self + cCode: [self memset: startAddr _: self stop _: endAddr - startAddr + 1] - cCode: [self me: startAddr ms: self stop et: endAddr - startAddr + 1] inSmalltalk: [| alignedEnd alignedStart stops | stops := self stop << 8 + self stop. stops := stops << 16 + stops. stops := stops << 32 + stops. alignedStart := startAddr + 7 // 8 * 8. alignedEnd := endAddr - 1 // 8 * 8. alignedEnd <= startAddr ifTrue: [startAddr to: endAddr do: [:addr | objectMemory byteAt: addr put: self stop]] ifFalse: [startAddr to: alignedStart - 1 do: [:addr | objectMemory byteAt: addr put: self stop]. alignedStart to: alignedEnd by: 8 do: [:addr | objectMemory long64At: addr put: stops]. alignedEnd + 8 to: endAddr do: [:addr | objectMemory byteAt: addr put: self stop]]]! Item was changed: ----- Method: Cogit class>>initializeMiscConstants (in category 'class initialization') ----- initializeMiscConstants super initializeMiscConstants. Debug := InitializationOptions at: #Debug ifAbsent: [false]. (InitializationOptions includesKey: #EagerInstructionDecoration) ifTrue: [EagerInstructionDecoration := InitializationOptions at: #EagerInstructionDecoration] ifFalse: [EagerInstructionDecoration ifNil: [EagerInstructionDecoration := false]]. "speeds up single stepping but could lose fidelity" ProcessorClass := (InitializationOptions at: #ISA ifAbsentPut: [self objectMemoryClass defaultISA]) caseOf: { + [#X64] -> [BochsX64Alien]. - [#X64] -> [BochsX64Alien]. [#IA32] -> [BochsIA32Alien]. [#ARMv5] -> [GdbARMAlien]. + [#ARMv8] -> [GdbARMv8Alien]. [#MIPSEL] -> [MIPSELSimulator] }. CogCompilerClass := self activeCompilerClass. (CogCompilerClass withAllSuperclasses copyUpTo: CogAbstractInstruction) reverseDo: [:compilerClass| compilerClass initialize; initializeAbstractRegisters]. self objectMemoryClass objectRepresentationClass initializeMiscConstants. "Our criterion for which methods to JIT is literal count. The default value is 60 literals or less." MaxLiteralCountForCompile := InitializationOptions at: #MaxLiteralCountForCompile ifAbsent: [60]. "we special-case 0, 1 & 2 argument sends, N is numArgs >= 3" NumSendTrampolines := 4. "Currently not even the ceImplicitReceiverTrampoline contains object references." NumObjRefsInRuntime := 0. "6 is a fine number for the max number of PCI entries. 8 is too large." MaxCPICCases := 6. "One variable defines whether in a block and whether in a vanilla or full block." InVanillaBlock := 1. InFullBlock := 2. NSCSelectorIndex := (NSSendCache instVarNames indexOf: #selector) - 1. NSCNumArgsIndex := (NSSendCache instVarNames indexOf: #numArgs) - 1. NSCClassTagIndex := (NSSendCache instVarNames indexOf: #classTag) - 1. NSCEnclosingObjectIndex := (NSSendCache instVarNames indexOf: #enclosingObject) - 1. NSCTargetIndex := (NSSendCache instVarNames indexOf: #target) - 1. NumOopsPerNSC := NSSendCache instVarNames size. "Max size to alloca when compiling. Mac OS X 10.6.8 segfaults approaching 8Mb. Linux 2.6.9 segfaults above 11Mb. WIndows XP segfaults approaching 2Mb." MaxStackAllocSize := 1024 * 1024 * 3 / 2 ! Item was changed: ----- Method: SpurGenerationScavenger>>computeRefCountToShrinkRT (in category 'remembered set') ----- computeRefCountToShrinkRT "Some time in every scavenger's life there may come a time when someone writes code that stresses the remembered table. One might conclude that if the remembered table is full, then the right thing to do is simply to tenure everything, emptying the remembered table. Bt in some circumstances this can be counter-productive, and result in the same situation arising soon after tenuring everything. Instead, we can try and selectively prune the remembered table, tenuring only those objects that are referenced by many objects in the remembered table. That's what this algorithm does. It reference counts young objects referenced from the remembered set, and then sets a threshold used to tenure objects oft referenced from the remembered set, thereby allowing the remembered set to shrink, while not tenuring everything. Once in a network monitoring application in a galaxy not dissimilar from the one this code inhabits, a tree of nodes referring to large integers was in precisely this situation. The nodes were old, and the integers were in new space. Some of the nodes referred to shared numbers, some their own unique numbers. The numbers were updated frequently. Were new space simply tenured when the remembered table was full, the remembered table would soon fill up as new numbers were computed. Only by selectively pruning the remembered table of nodes that shared data, was a balance achieved whereby the remembered table population was kept small, and tenuring rates were low." <inline: #never> | population | <var: 'population' declareC: 'long population[MaxRTRefCount + 1]'> + self cCode: [self memset: population _: 0 _: (self sizeof: #long) * (MaxRTRefCount + 1)] - self cCode: [self me: population ms: 0 et: (self sizeof: #long) * (MaxRTRefCount + 1)] inSmalltalk: [population := CArrayAccessor on: (Array new: MaxRTRefCount + 1 withAll: 0)]. self assert: self allNewSpaceObjectsHaveZeroRTRefCount. self referenceCountRememberedReferents: population. self setRefCountToShrinkRT: population "For debugging: (manager allNewSpaceObjectsDo: [:o| manager rtRefCountOf: o put: 0])"! Item was changed: ----- Method: SpurSegmentManager>>allocateOrExtendSegmentInfos (in category 'private') ----- allocateOrExtendSegmentInfos "Increase the number of allocated segInfos by 16." | newNumSegs | numSegInfos = 0 ifTrue: [numSegInfos := 16. segments := self + cCode: [self calloc: numSegInfos _: (self sizeof: SpurSegmentInfo)] - cCode: [self c: numSegInfos alloc: (self sizeof: SpurSegmentInfo)] inSmalltalk: [CArrayAccessor on: ((1 to: numSegInfos) collect: [:i| SpurSegmentInfo new])]. ^self]. newNumSegs := numSegInfos + 16. segments := self + cCode: [self realloc: segments _: newNumSegs * (self sizeof: SpurSegmentInfo)] - cCode: [self re: segments alloc: newNumSegs * (self sizeof: SpurSegmentInfo)] inSmalltalk: [CArrayAccessor on: segments object, ((numSegInfos to: newNumSegs) collect: [:i| SpurSegmentInfo new])]. self cCode: [segments = 0 ifTrue: [self error: 'out of memory; cannot allocate more segments']. self + memset: segments + numSegInfos + _: 0 + _: newNumSegs - numSegInfos * (self sizeof: SpurSegmentInfo)]. - me: segments + numSegInfos - ms: 0 - et: newNumSegs - numSegInfos * (self sizeof: SpurSegmentInfo)]. numSegInfos := newNumSegs! Item was changed: ----- Method: StackInterpreter>>initStackPages (in category 'initialization') ----- initStackPages "Initialize the stackPages. This version is only for simulation because Slang refuses to inline it, which makes the alloca invalid." | stackPageBytes stackPagesBytes theStackMemory | stackPageBytes := self stackPageByteSize. stackPagesBytes := self computeStackZoneSize. theStackMemory := self cCode: [self alloca: stackPagesBytes] inSmalltalk: [stackPages initializeWithByteSize: stackPagesBytes for: self]. + self cCode: [self memset: theStackMemory _: 0 _: stackPagesBytes]. - self cCode: [self me: theStackMemory ms: 0 et: stackPagesBytes]. stackPages initializeStack: theStackMemory numSlots: stackPagesBytes / objectMemory wordSize pageSize: stackPageBytes / objectMemory wordSize! Item was changed: ----- Method: StackInterpreter>>initStackPagesAndInterpret (in category 'initialization') ----- initStackPagesAndInterpret "Initialize the stack pages and enter interpret. Use alloca'ed memory so that when we have a JIT its stack pointer will be on the native stack since alloca allocates memory on the stack. Certain thread systems use the native stack pointer as the frame ID so putting the stack anywhere else can confuse the thread system." "This should be in its own initStackPages method but Slang can't inline C code strings." | stackPageBytes stackPagesBytes theStackMemory | <var: #theStackMemory type: #'void *'> stackPageBytes := self stackPageByteSize. stackPagesBytes := self computeStackZoneSize. theStackMemory := self cCode: [self alloca: stackPagesBytes] inSmalltalk: [stackPages initializeWithByteSize: stackPagesBytes for: self]. + self cCode: [self memset: theStackMemory _: 0 _: stackPagesBytes]. - self cCode: [self me: theStackMemory ms: 0 et: stackPagesBytes]. stackPages initializeStack: theStackMemory numSlots: stackPagesBytes / objectMemory wordSize pageSize: stackPageBytes / objectMemory wordSize. "Once the stack pages are initialized we can continue to bootstrap the system." self loadInitialContext. "We're ready for the heartbeat (poll interrupt)" self ioInitHeartbeat. self initialEnterSmalltalkExecutive. ^nil! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiCall:ArgArrayOrNil:NumArgs: (in category 'callout support') ----- ffiCall: externalFunction ArgArrayOrNil: argArrayOrNil NumArgs: nArgs "Generic callout. Does the actual work. If argArrayOrNil is nil it takes args from the stack and the spec from the method. If argArrayOrNil is not nil takes args from argArrayOrNil and the spec from the receiver." | flags argTypeArray address argType oop argSpec argClass err theCalloutState calloutState requiredStackSize stackSize allocation result primNumArgs | <inline: true> <var: #theCalloutState type: #'CalloutState'> <var: #calloutState type: #'CalloutState *'> <var: #allocation type: #'char *'> primNumArgs := interpreterProxy methodArgumentCount. (interpreterProxy is: externalFunction KindOfClass: interpreterProxy classExternalFunction) ifFalse: [^self ffiFail: FFIErrorNotFunction]. "Load and check the values in the externalFunction before we call out" flags := interpreterProxy fetchInteger: ExternalFunctionFlagsIndex ofObject: externalFunction. interpreterProxy failed ifTrue: [^self ffiFail: FFIErrorBadArgs]. "This must come early for compatibility with the old FFIPlugin. Image-level code may assume the function pointer is loaded eagerly. Thanks to Nicolas Cellier." address := self ffiLoadCalloutAddress: externalFunction. interpreterProxy failed ifTrue: [^0 "error code already set by ffiLoadCalloutAddress:"]. argTypeArray := interpreterProxy fetchPointer: ExternalFunctionArgTypesIndex ofObject: externalFunction. "must be array of arg types" ((interpreterProxy isArray: argTypeArray) and: [(interpreterProxy slotSizeOf: argTypeArray) = (nArgs + 1)]) ifFalse: [^self ffiFail: FFIErrorBadArgs]. "check if the calling convention is supported" self cppIf: COGMTVM ifTrue: [(self ffiSupportsCallingConvention: (flags bitAnd: FFICallTypesMask)) ifFalse: [^self ffiFail: FFIErrorCallType]] ifFalse: "not masking causes threaded calls to fail, which is as they should if the plugin is not threaded." [(self ffiSupportsCallingConvention: flags) ifFalse: [^self ffiFail: FFIErrorCallType]]. requiredStackSize := self externalFunctionHasStackSizeSlot ifTrue: [interpreterProxy fetchInteger: ExternalFunctionStackSizeIndex ofObject: externalFunction] ifFalse: [-1]. interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: (argArrayOrNil isNil ifTrue: [PrimErrBadMethod] ifFalse: [PrimErrBadReceiver])]. stackSize := requiredStackSize < 0 ifTrue: [DefaultMaxStackSize] ifFalse: [requiredStackSize]. self cCode: [] inSmalltalk: [theCalloutState := self class calloutStateClass new]. calloutState := self addressOf: theCalloutState. + self cCode: [self memset: calloutState _: 0 _: (self sizeof: #CalloutState)]. - self cCode: [self me: calloutState ms: 0 et: (self sizeof: #CalloutState)]. calloutState callFlags: flags. "Fetch return type and args" argType := interpreterProxy fetchPointer: 0 ofObject: argTypeArray. argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. argClass := interpreterProxy fetchPointer: 1 ofObject: argType. (err := self ffiCheckReturn: argSpec With: argClass in: calloutState) ~= 0 ifTrue: [^self ffiFail: err]. "cannot return" "alloca the outgoing stack frame, leaving room for marshalling args, and including space for the return struct, if any. Additional space reserved for saving register args like mandated by Win64 X64 or PPC ABI, will be managed by the call itself" allocation := self alloca: stackSize + calloutState structReturnSize + self cStackAlignment. self mustAlignStack ifTrue: [allocation := self cCoerce: (allocation asUnsignedIntegerPtr bitClear: self cStackAlignment - 1) to: #'char *']. calloutState argVector: allocation; currentArg: allocation; limit: allocation + stackSize. 1 to: nArgs do: [:i| argType := interpreterProxy fetchPointer: i ofObject: argTypeArray. argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. argClass := interpreterProxy fetchPointer: 1 ofObject: argType. oop := argArrayOrNil isNil ifTrue: [interpreterProxy stackValue: nArgs - i] ifFalse: [interpreterProxy fetchPointer: i - 1 ofObject: argArrayOrNil]. err := self ffiArgument: oop Spec: argSpec Class: argClass in: calloutState. err ~= 0 ifTrue: [self cleanupCalloutState: calloutState. self cppIf: COGMTVM ifTrue: [err = PrimErrObjectMayMove negated ifTrue: [^PrimErrObjectMayMove]]. "N.B. Do not fail if object may move because caller will GC and retry." ^self ffiFail: err]]. "coercion failed or out of stack space" "Failures must be reported back from ffiArgument:Spec:Class:in:. Should not fail from here on in." self assert: interpreterProxy failed not. self ffiLogCallout: externalFunction. (requiredStackSize < 0 and: [self externalFunctionHasStackSizeSlot]) ifTrue: [stackSize := calloutState currentArg - calloutState argVector. interpreterProxy storeInteger: ExternalFunctionStackSizeIndex ofObject: externalFunction withValue: stackSize]. "Go out and call this guy" result := self ffiCalloutTo: address SpecOnStack: argArrayOrNil notNil in: calloutState. self cleanupCalloutState: calloutState. "Can not safely use argumentCount (via e.g. methodReturnValue:) since it may have been changed by a callback." interpreterProxy pop: primNumArgs + 1 thenPush: result. ^result! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiCall:ArgArrayOrNil:NumArgs: (in category 'callout support') ----- ffiCall: externalFunction ArgArrayOrNil: argArrayOrNil NumArgs: nArgs "Generic callout. Does the actual work. If argArrayOrNil is nil it takes args from the stack and the spec from the method. If argArrayOrNil is not nil takes args from argArrayOrNil and the spec from the receiver." | flags argTypeArray address argType oop argSpec argClass err theCalloutState calloutState requiredStackSize stackSize allocation result primNumArgs | <inline: true> <var: #theCalloutState type: #'CalloutState'> <var: #calloutState type: #'CalloutState *'> <var: #allocation type: #'char *'> primNumArgs := interpreterProxy methodArgumentCount. (interpreterProxy is: externalFunction KindOfClass: interpreterProxy classExternalFunction) ifFalse: [^self ffiFail: FFIErrorNotFunction]. "Load and check the values in the externalFunction before we call out" flags := interpreterProxy fetchInteger: ExternalFunctionFlagsIndex ofObject: externalFunction. interpreterProxy failed ifTrue: [^self ffiFail: FFIErrorBadArgs]. "This must come early for compatibility with the old FFIPlugin. Image-level code may assume the function pointer is loaded eagerly. Thanks to Nicolas Cellier." address := self ffiLoadCalloutAddress: externalFunction. interpreterProxy failed ifTrue: [^0 "error code already set by ffiLoadCalloutAddress:"]. argTypeArray := interpreterProxy fetchPointer: ExternalFunctionArgTypesIndex ofObject: externalFunction. "must be array of arg types" ((interpreterProxy isArray: argTypeArray) and: [(interpreterProxy slotSizeOf: argTypeArray) = (nArgs + 1)]) ifFalse: [^self ffiFail: FFIErrorBadArgs]. "check if the calling convention is supported" self cppIf: COGMTVM ifTrue: [(self ffiSupportsCallingConvention: (flags bitAnd: FFICallTypesMask)) ifFalse: [^self ffiFail: FFIErrorCallType]] ifFalse: "not masking causes threaded calls to fail, which is as they should if the plugin is not threaded." [(self ffiSupportsCallingConvention: flags) ifFalse: [^self ffiFail: FFIErrorCallType]]. requiredStackSize := self externalFunctionHasStackSizeSlot ifTrue: [interpreterProxy fetchInteger: ExternalFunctionStackSizeIndex ofObject: externalFunction] ifFalse: [-1]. interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: (argArrayOrNil isNil ifTrue: [PrimErrBadMethod] ifFalse: [PrimErrBadReceiver])]. stackSize := requiredStackSize < 0 ifTrue: [DefaultMaxStackSize] ifFalse: [requiredStackSize]. self cCode: [] inSmalltalk: [theCalloutState := self class calloutStateClass new]. calloutState := self addressOf: theCalloutState. + self cCode: [self memset: calloutState _: 0 _: (self sizeof: #CalloutState)]. - self cCode: [self me: calloutState ms: 0 et: (self sizeof: #CalloutState)]. calloutState callFlags: flags. "Fetch return type and args" argType := interpreterProxy fetchPointer: 0 ofObject: argTypeArray. argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. argClass := interpreterProxy fetchPointer: 1 ofObject: argType. (err := self ffiCheckReturn: argSpec With: argClass in: calloutState) ~= 0 ifTrue: [^self ffiFail: err]. "cannot return" "alloca the outgoing stack frame, leaving room for marshalling args, and including space for the return struct, if any. Additional space reserved for saving register args like mandated by Win64 X64 or PPC ABI, will be managed by the call itself" allocation := self alloca: stackSize + calloutState structReturnSize + self cStackAlignment. self mustAlignStack ifTrue: [allocation := self cCoerce: (allocation asUnsignedIntegerPtr bitClear: self cStackAlignment - 1) to: #'char *']. calloutState argVector: allocation; currentArg: allocation; limit: allocation + stackSize. (calloutState structReturnSize > 0 and: [self nonRegisterStructReturnIsViaImplicitFirstArgument and: [(self returnStructInRegisters: calloutState structReturnSize) not]]) ifTrue: [err := self ffiPushPointer: calloutState limit in: calloutState. err ~= 0 ifTrue: [self cleanupCalloutState: calloutState. self cppIf: COGMTVM ifTrue: [err = PrimErrObjectMayMove negated ifTrue: [^PrimErrObjectMayMove]]. "N.B. Do not fail if object may move because caller will GC and retry." ^self ffiFail: err]]. 1 to: nArgs do: [:i| argType := interpreterProxy fetchPointer: i ofObject: argTypeArray. argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. argClass := interpreterProxy fetchPointer: 1 ofObject: argType. oop := argArrayOrNil isNil ifTrue: [interpreterProxy stackValue: nArgs - i] ifFalse: [interpreterProxy fetchPointer: i - 1 ofObject: argArrayOrNil]. err := self ffiArgument: oop Spec: argSpec Class: argClass in: calloutState. err ~= 0 ifTrue: [self cleanupCalloutState: calloutState. self cppIf: COGMTVM ifTrue: [err = PrimErrObjectMayMove negated ifTrue: [^PrimErrObjectMayMove]]. "N.B. Do not fail if object may move because caller will GC and retry." ^self ffiFail: err]]. "coercion failed or out of stack space" "Failures must be reported back from ffiArgument:Spec:Class:in:. Should not fail from here on in." self assert: interpreterProxy failed not. self ffiLogCallout: externalFunction. (requiredStackSize < 0 and: [self externalFunctionHasStackSizeSlot]) ifTrue: [stackSize := calloutState currentArg - calloutState argVector. interpreterProxy storeInteger: ExternalFunctionStackSizeIndex ofObject: externalFunction withValue: stackSize]. "Go out and call this guy" result := self ffiCalloutTo: address SpecOnStack: argArrayOrNil notNil in: calloutState. self cleanupCalloutState: calloutState. "Can not safely use argumentCount (via e.g. methodReturnValue:) since it may have been changed by a callback." interpreterProxy pop: primNumArgs + 1 thenPush: result. ^result!

1 0

VM Maker: Cog-eem.372.mcz
by commits＠source.squeak.org 26 Nov '19

26 Nov '19

Eliot Miranda uploaded a new version of Cog to project VM Maker: http://source.squeak.org/VMMaker/Cog-eem.372.mcz ==================== Summary ==================== Name: Cog-eem.372 Author: eem Time: 25 November 2019, 4:03:59.413435 pm UUID: 648ac787-06aa-4536-8bce-1fff8acb5593 Ancestors: Cog-eem.371 Nuke the obsolete invocation primitives (the ones that took three bounds arguments). Use the error code on the ARM & ARMv8 aliens. Avoid several uses of << and >> in performance-critical tests in the GdbARMAlien. bitShift: saves an invocation. =============== Diff against Cog-eem.371 =============== Item was removed: - ----- Method: BochsIA32Alien>>primitiveRunInMemory:minimumAddress:maximumAddress:readOnlyBelow: (in category 'primitives') ----- - primitiveRunInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" maximumAddress: maximimAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" - "Run the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the - memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range - calls, jumps and memory read/writes into ProcessorSimulationTrap signals." - <primitive: 'primitiveRunInMemoryMinAddressMaxAddressReadWrite' module: 'BochsIA32Plugin' error: ec> - ^ec == #'inappropriate operation' - ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray - minimumAddress: minimumAddress] - ifFalse: [self reportPrimitiveFailure] - - "self printRegistersOn: Transcript"! Item was changed: ----- Method: BochsIA32Alien>>primitiveRunInMemory:minimumAddress:readOnlyBelow: (in category 'primitives') ----- primitiveRunInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" "Run the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range calls, jumps and memory read/writes into ProcessorSimulationTrap signals." <primitive: 'primitiveRunInMemoryMinimumAddressReadWrite' module: 'BochsIA32Plugin' error: ec> + ^(ec isPrimitiveError + or: [ec == #'inappropriate operation']) + ifTrue: + [self + handleExecutionPrimitiveFailureIn: memoryArray + minimumAddress: minimumAddress] + ifFalse: [self reportPrimitiveFailure]! - ^ec == #'inappropriate operation' - ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray - minimumAddress: minimumAddress] - ifFalse: [self reportPrimitiveFailure] - - "self printRegistersOn: Transcript"! Item was removed: - ----- Method: BochsIA32Alien>>primitiveSingleStepInMemory:minimumAddress:maximumAddress:readOnlyBelow: (in category 'primitives') ----- - primitiveSingleStepInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" maximumAddress: maximimAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" - "Single-step the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the - memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range - calls, jumps and memory read/writes into ProcessorSimulationTrap signals." - <primitive: 'primitiveSingleStepInMemoryMinAddressMaxAddressReadWrite' module: 'BochsIA32Plugin' error: ec> - ^ec == #'inappropriate operation' - ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray - minimumAddress: minimumAddress] - ifFalse: [self reportPrimitiveFailure]! Item was changed: ----- Method: BochsIA32Alien>>primitiveSingleStepInMemory:minimumAddress:readOnlyBelow: (in category 'primitives') ----- primitiveSingleStepInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" "Single-step the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range calls, jumps and memory read/writes into ProcessorSimulationTrap signals." <primitive: 'primitiveSingleStepInMemoryMinimumAddressReadWrite' module: 'BochsIA32Plugin' error: ec> + ^(ec isPrimitiveError + or: [ec == #'inappropriate operation']) + ifTrue: + [self + handleExecutionPrimitiveFailureIn: memoryArray + minimumAddress: minimumAddress] - ^ec == #'inappropriate operation' - ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray - minimumAddress: minimumAddress] ifFalse: [self reportPrimitiveFailure]! Item was changed: ----- Method: BochsX64Alien>>primitiveRunInMemory:minimumAddress:readOnlyBelow: (in category 'primitives') ----- primitiveRunInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" "Run the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range calls, jumps and memory read/writes into ProcessorSimulationTrap signals." <primitive: 'primitiveRunInMemoryMinimumAddressReadWrite' module: 'BochsX64Plugin' error: ec> + ^(ec isPrimitiveError + or: [ec == #'inappropriate operation']) + ifTrue: + [self + handleExecutionPrimitiveFailureIn: memoryArray + minimumAddress: minimumAddress] + ifFalse: [self reportPrimitiveFailure]! - ^ec == #'inappropriate operation' - ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray - minimumAddress: minimumAddress] - ifFalse: [self reportPrimitiveFailure] - - "self printRegistersOn: Transcript"! Item was changed: ----- Method: BochsX64Alien>>primitiveSingleStepInMemory:minimumAddress:readOnlyBelow: (in category 'primitives') ----- primitiveSingleStepInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" "Single-step the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range calls, jumps and memory read/writes into ProcessorSimulationTrap signals." <primitive: 'primitiveSingleStepInMemoryMinimumAddressReadWrite' module: 'BochsX64Plugin' error: ec> + ^(ec isPrimitiveError + or: [ec == #'inappropriate operation']) + ifTrue: + [self + handleExecutionPrimitiveFailureIn: memoryArray + minimumAddress: minimumAddress] - ^ec == #'inappropriate operation' - ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray - minimumAddress: minimumAddress] ifFalse: [self reportPrimitiveFailure]! Item was changed: ----- Method: GdbARMAlien>>extractOffsetFromBL: (in category 'testing') ----- extractOffsetFromBL: instr "we are told this is a BL <offset> instruction, so work out the offset it encodes" | relativeJump | relativeJump := instr bitAnd: 16r00FFFFFF. + (relativeJump bitShift: -23) = 0 ifTrue: + [^relativeJump bitShift: 2]. + ^((relativeJump bitOr: 16r3F000000) bitShift: 2) signedIntFromLong! - relativeJump := (relativeJump bitAt: 24) = 1 - ifTrue: [((relativeJump bitOr: 16r3F000000) << 2) signedIntFromLong] - ifFalse: [relativeJump << 2]. - ^relativeJump! Item was added: + ----- Method: GdbARMAlien>>handleExecutionPrimitiveFailureIn:minimumAddress:code: (in category 'error handling') ----- + handleExecutionPrimitiveFailureIn: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>"code: errorCode "<Integer>" + "Handle an execution primitive failure. Convert out-of-range call and absolute + memory read into register instructions into ProcessorSimulationTrap signals." + "self printRegistersOn: Transcript" + | pcOnEntry pc instr | + pc := pcOnEntry := self pc. + errorCode = InstructionPrefetchError ifTrue: + [pc := self pc: self priorPc]. + + (pc between: minimumAddress and: memoryArray byteSize - 1) ifTrue: + [instr := memoryArray unsignedLongAt: pc + 1 bigEndian: false. + + errorCode = InstructionPrefetchError ifTrue: + [^self handleFailingBranch: instr to: pcOnEntry at: pc]. + + (self instructionIsAnyLoadStore: instr) ifTrue: + [^self handleFailingLoadStore: instr at: pc]. + + (self instructionIsAnyFPArithmetic: instr) ifTrue: + [^self handleFailingFPArithmetic: instr at: pc]. + + ^self handleExecutionPrimitiveFailureAt: pc in: memoryArray]. + + ^self reportPrimitiveFailure! Item was changed: ----- Method: GdbARMAlien>>handleFailingBranch:to:at: (in category 'error handling') ----- handleFailingBranch: instr to: address at: pc (self instructionIsBL: instr) ifTrue: [self assert: address = (pc + 8 + (self extractOffsetFromBL: instr)) signedIntToLong. ^(ProcessorSimulationTrap pc: pc nextpc: pc + 4 address: (pc + 8 + (self extractOffsetFromBL: instr)) signedIntToLong type: #call) signal]. (self instructionIsBLX: instr) ifTrue: [self assert: address = (self perform: (self registerStateGetters at: (instr bitAnd: 15) + 1)). ^(ProcessorSimulationTrap pc: pc nextpc: pc + 4 + address: address - address: (self perform: (self registerStateGetters at: (instr bitAnd: 15) + 1)) type: #call) signal]. (self instructionIsBX: instr) ifTrue: [self assert: address = (self perform: (self registerStateGetters at: (instr bitAnd: 15) + 1)). ^(ProcessorSimulationTrap pc: pc nextpc: pc + 4 + address: address - address: (self perform: (self registerStateGetters at: (instr bitAnd: 15) + 1)) type: #jump) signal]. (self instructionIsB: instr) ifTrue: [self assert: address = (pc + 8 + (self extractOffsetFromBL: instr)) signedIntToLong. ^(ProcessorSimulationTrap pc: pc nextpc: pc + 4 + address: address - address: (pc + 8 + (self extractOffsetFromBL: instr)) signedIntToLong type: #jump) signal]. (self instructionIsReturnViaLR: instr) ifTrue: + [self assert: address = self lr. + ^(ProcessorSimulationTrap - [^(ProcessorSimulationTrap pc: pc nextpc: pc + 4 address: self lr type: #return) signal]. ^self reportPrimitiveFailure! Item was changed: ----- Method: GdbARMAlien>>handleFailingLoadStore:at: (in category 'error handling') ----- handleFailingLoadStore: instr at: pc "See e.g. ARM DDI0406A pp. A8-120, 124, 128, 132, 152, 156, etc. etc" + | baseReg regIdx destReg srcReg offset | - | baseReg destReg srcReg offset | "find the register used as the base of the address and the register to load into or store from" + baseReg := self registerStateGetters at: ((instr bitShift: -16) bitAnd: 15) + 1. + srcReg := self registerStateGetters at: (regIdx := ((instr bitShift: -12) bitAnd: 15) + 1). + destReg := self registerStateSetters at: regIdx. - baseReg := self registerStateGetters at: (instr >> 16 bitAnd: 15)+ 1. - srcReg := self registerStateGetters at: (instr >> 12 bitAnd: 15)+ 1. - destReg := self registerStateSetters at: (instr >> 12 bitAnd: 15) + 1. "work out the relevant offset, whether an immediate or register value" offset := self extractOffsetFromLoadStore: instr. (self instructionIsLDR: instr) ifTrue: [^(ProcessorSimulationTrap pc: pc nextpc: pc + 4 address: (self perform: baseReg) + offset type: #read accessor: destReg) signal]. + (self instructionIsSTR: instr) ifTrue: - (self instructionIsLDRB: instr) ifTrue: [^(ProcessorSimulationTrap pc: pc nextpc: pc + 4 address: (self perform: baseReg) + offset + type: #write + accessor: srcReg) - type: #read - accessor: destReg) signal]. + (self instructionIsLDRB: instr) ifTrue: - (self instructionIsLDRH: instr) ifTrue: [^(ProcessorSimulationTrap pc: pc nextpc: pc + 4 address: (self perform: baseReg) + offset type: #read accessor: destReg) signal]. + (self instructionIsSTRB: instr) ifTrue: - (self instructionIsSTR: instr) ifTrue: [^(ProcessorSimulationTrap pc: pc nextpc: pc + 4 address: (self perform: baseReg) + offset type: #write accessor: srcReg) signal]. + (self instructionIsLDRH: instr) ifTrue: - (self instructionIsSTRB: instr) ifTrue: [^(ProcessorSimulationTrap pc: pc nextpc: pc + 4 address: (self perform: baseReg) + offset + type: #read + accessor: destReg) - type: #write - accessor: srcReg) signal]. (self instructionIsSTRH: instr) ifTrue: [^(ProcessorSimulationTrap pc: pc nextpc: pc + 4 address: (self perform: baseReg) + offset type: #write accessor: srcReg) signal]. self error: 'handleFailingLoadStore:at: invoked for non-load/store?'! Item was changed: ----- Method: GdbARMAlien>>instructionIsAddSP: (in category 'testing') ----- instructionIsAddSP: instr + "is this an add sp, sp, #? - instruction?" + ^(instr bitShift: -28) < 16rF "test for allowed condcode - 0xF is extension" + and: [(instr bitAnd: 16rFFFFF00) = 16r28DD000]! - "is this an add sp, sp, #? - instruction?" - ^instr >> 28 < 16rF "test for allowed condcode - 0xF is extension" and: [(instr bitAnd: (16rFFFFF00)) = (16r28DD000)]! Item was changed: ----- Method: GdbARMAlien>>instructionIsAlignSP: (in category 'testing') ----- instructionIsAlignSP: instr "is this a subs sp, sp, #4 - instruction?" + ^(instr bitShift: -28) < 16rF "test for allowed condcode - 0xF is extension" + and: [(instr bitAnd: 16rFFFFFFF) = 16r2DDD004]! - ^instr >> 28 < 16rF "test for allowed condcode - 0xF is extension" and: [(instr bitAnd: (16rFFFFFFF)) = (16r2DDD004)]! Item was changed: ----- Method: GdbARMAlien>>instructionIsAnyFPArithmetic: (in category 'testing') ----- instructionIsAnyFPArithmetic: instr "Identify VFP instructions. See C3.1 - C3.4 in the ARM ARM v5 DDI01001." | cp isFP | "All FP instructions are coprocessor instructions on coproc 10 or 11" + cp := (instr bitShift: -8) bitAnd: 16rF. - cp := instr>>8 bitAnd: 16rF. isFP := cp = 10 or:[cp = 11]. + (isFP and: [((instr bitShift: -25) bitAnd: 7) = 6]) ifTrue: [^true]. + (isFP and: [((instr bitShift: -24) bitAnd: 16rF) = 16rE]) ifTrue: [^true]. - (isFP and: [(instr>>25 bitAnd: 7) = 6]) ifTrue: [^true]. - (isFP and: [(instr>>24 bitAnd: 16rF) = 16rE]) ifTrue: [^true]. "nope" ^false! Item was changed: ----- Method: GdbARMAlien>>instructionIsB: (in category 'testing') ----- instructionIsB: instr "is this a B <offset> instruction?" "first test for non-NV condition code; some important instructions use it" + ^(instr bitShift: -28) < 16rF - instr >> 28 = 16rF ifTrue:[^false]. "See ARM DDI0406A p. A8-44" + and: [(instr bitShift: -24) bitAnd: 16rF = 16rA]! - ^ (instr bitAnd: (16rF<<24)) = (16rA<<24)! Item was changed: ----- Method: GdbARMAlien>>instructionIsBL: (in category 'testing') ----- instructionIsBL: instr "is this a BL <offset> instruction?" "first test for non-NV condition code; some important instructions use it" + ^(instr bitShift: -28) < 16rF - instr >> 28 = 16rF ifTrue:[^false]. "see ARM DDI0406A p. A8-58" + and: [((instr bitShift: -24) bitAnd: 16rF) = 16rB]! - ^(instr bitAnd: (16rF<<24)) = (16rB<<24)! Item was changed: ----- Method: GdbARMAlien>>instructionIsBLX: (in category 'testing') ----- instructionIsBLX: instr "is this a BLX <targetReg> instruction? We DO NOT support the BLX immed version" "first test for non-NV condition code; some important instructions use it" + (instr bitShift: -28) = 16rF ifTrue:[^false]. - instr >> 28 = 16rF ifTrue:[^false]. "See ARM DDI0406A p A8-60" ^(instr bitAnd: 16r0FFFFFF0) = 16r12FFF30! Item was changed: ----- Method: GdbARMAlien>>instructionIsBX: (in category 'testing') ----- instructionIsBX: instr "is this a BX <targetReg> instruction?" "first test for non-NV condition code; some important instructions use it" + (instr bitShift: -28) = 16rF ifTrue:[^false]. - instr >> 28 = 16rF ifTrue:[^false]. "See ARM DDI0406A p. A8-62" ^(instr bitAnd: 16r0FFFFFF0) = 16r12FFF10! Item was changed: ----- Method: GdbARMAlien>>instructionIsImmediateOffsetLoadStore: (in category 'testing') ----- instructionIsImmediateOffsetLoadStore: instr "is this any of the immediate offset LDR,STR instructions?" | op1 | "first test for non-NV condition code; some important instructions use it" + (instr bitShift: -28) = 16rF ifTrue:[^false]. - instr >> 28 = 16rF ifTrue:[^false]. "test for 010 group of load/stores" + op1 := (instr bitShift: -25) bitAnd: 7. - op1 := instr >>25 bitAnd: 7. op1 = 2 ifTrue:[^true]. "test for the ridiculously muddled 000 group" op1 > 0 ifTrue:[^false]. "bit 21 must not be 1 and bit 22 must be 1" + ((instr bitShift: -21) bitAnd: 3) = 2 ifFalse:[^false]. - (instr bitAnd: 3 <<21) = (2<<21) ifFalse:[^false]. "bits 4:7need to be 16rB for our purpose" + ^(instr bitAnd: 16rF0) = 16rB0! - ^(instr bitAnd: 16rF0) = 16rB0 - - ! Item was changed: ----- Method: GdbARMAlien>>instructionIsLDR: (in category 'testing') ----- instructionIsLDR: instr "is this a LDR instruction?" | foo | "first test for non-NV condition code; some important instructions use it" + (instr bitShift: -28) = 16rF ifTrue:[^false]. - instr >> 28 = 16rF ifTrue:[^false]. "See ARM DDI0406A p. A8-120" + foo := (instr bitShift: -20) bitAnd: 16rE5. - foo := (instr >> 20 bitAnd: 16rE5). ^foo = 16r41 "ldr r1, [r2, #+/-imm]" or:[foo = 16r61 "ldr r1, [r2, r3]"]! Item was changed: ----- Method: GdbARMAlien>>instructionIsLDRB: (in category 'testing') ----- instructionIsLDRB: instr "is this a LDRB instruction?" | foo | "first test for non-NV condition code; some important instructions use it" + (instr bitShift: -28) = 16rF ifTrue:[^false]. - instr >> 28 = 16rF ifTrue:[^false]. "See ARM DDI0406A p. A8-128" + foo := (instr bitShift: -20) bitAnd: 16rE5. - foo := (instr >> 20 bitAnd: 16rE5). ^foo = 16r45 "ldrb r1, [r2, #+/-imm]" or:[foo = 16r65 "ldrb r1, [r2, r3]"]! Item was changed: ----- Method: GdbARMAlien>>instructionIsLDRH: (in category 'testing') ----- instructionIsLDRH: instr "is this a LDRH instruction?" | foo | "first test for non-NV condition code; some important instructions use it" + (instr bitShift: -28) = 16rF ifTrue:[^false]. - instr >> 28 = 16rF ifTrue:[^false]. "See ARM DDI0406A p. A8-154" (instr bitAnd: 16rF0) = 16rB0 ifFalse:[^false]. + foo := (instr bitShift: -20) bitAnd: 16rE3. - foo := (instr >> 20 bitAnd: 16rE3). ^foo = 16r3 "ldrh r1, [r2, #+/-imm]" or:[foo = 16r1 "ldrh r1, [r2, r3]"]! Item was changed: ----- Method: GdbARMAlien>>instructionIsLDRSP: (in category 'testing') ----- instructionIsLDRSP: instr "is this a LDR sp, [??] instruction? Special case to detect LDR sp, [] affecting stack pointer" + ^(self instructionIsLDR: instr) and:[((instr bitShift: -12) bitAnd: 16rF) = 13]! - ^(self instructionIsLDR: instr) and:[(instr >>12 bitAnd: 16rF) = 13]! Item was changed: ----- Method: GdbARMAlien>>instructionIsPop: (in category 'testing') ----- instructionIsPop: instr "is this a pop - ldr r??, [sp], #4 - instruction?" + ^(instr bitShift: -28) < 16rF "test for allowed condcode - 0xF is extension" and: [(instr bitAnd: (16rFFF0FFF)) = (16r49D0004)]! - ^instr >> 28 < 16rF "test for allowed condcode - 0xF is extension" and: [(instr bitAnd: (16rFFF0FFF)) = (16r49D0004)]! Item was changed: ----- Method: GdbARMAlien>>instructionIsPush: (in category 'testing') ----- instructionIsPush: instr "is this a push -str r??, [sp, #-4] - instruction?" + ^(instr bitShift: -28) < 16rF "test for allowed condcode - 0xF is extension" and: [(instr bitAnd: (16rFFF0FFF)) = (16r52D0004)]! - ^instr >> 28 < 16rF "test for allowed condcode - 0xF is extension" and: [(instr bitAnd: (16rFFF0FFF)) = (16r52D0004)]! Item was changed: ----- Method: GdbARMAlien>>instructionIsRegisterOffsetLoadStore: (in category 'testing') ----- instructionIsRegisterOffsetLoadStore: instr "is this any of the register offset LDR,STR instructions?" | op1 | "first test for non-NV condition code; some important instructions use it" + (instr bitShift: -28) = 16rF ifTrue:[^false]. - instr >> 28 = 16rF ifTrue:[^false]. + op1 := (instr bitShift: -25) bitAnd: 7. - op1 := instr >>25 bitAnd: 7. "test for the 011 group - check bit 4 as well" (op1 = 3 and:[(instr bitAnd: 16r10) = 0]) ifTrue:[^true]. "test for the ridiculously muddled 000 group" op1 > 0 ifTrue:[^false]. "bit 21 & 22 must not be 1" + ((instr bitShift: -21) bitAnd: 3) = 0 ifFalse:[^false]. - (instr bitAnd: 3 <<21) = 0 ifFalse:[^false]. "bits 4:7need to be 16rB for our purpose" + ^(instr bitAnd: 16rF0) = 16rB0! - ^(instr bitAnd: 16rF0) = 16rB0 - - ! Item was changed: ----- Method: GdbARMAlien>>instructionIsSTR: (in category 'testing') ----- instructionIsSTR: instr "is this a STR instruction?" | foo | "first test for non-NV condition code; some important instructions use it" + (instr bitShift: -28) = 16rF ifTrue:[^false]. - instr >> 28 = 16rF ifTrue:[^false]. "See ARM DDI0406A p. A8-382" + foo := (instr bitShift: -20) bitAnd: 16rE5. - foo := (instr >> 20 bitAnd: 16rE5). ^foo = 16r40 "str r1, [r2, #+/-imm]" or:[foo = 16r60] "str r1, [r2, #-imm]"! Item was changed: ----- Method: GdbARMAlien>>instructionIsSTRB: (in category 'testing') ----- instructionIsSTRB: instr "is this a STRB instruction?" | foo | "first test for non-NV condition code; some important instructions use it" + (instr bitShift: -28) = 16rF ifTrue:[^false]. - instr >> 28 = 16rF ifTrue:[^false]. "See ARM DDI0406A p. A8-388" + foo := (instr bitShift: -20) bitAnd: 16rE5. - foo := (instr >> 20 bitAnd: 16rE5). ^foo = 16r44 "strb r1, [r2, #+/-imm]" or:[foo = 16r64] "strb r1, [r2, #-imm]"! Item was changed: ----- Method: GdbARMAlien>>instructionIsSTRH: (in category 'testing') ----- instructionIsSTRH: instr "is this a STRH instruction?" | foo | "first test for non-NV condition code; some important instructions use it" + (instr bitShift: -28) = 16rF ifTrue:[^false]. - instr >> 28 = 16rF ifTrue:[^false]. "See ARM DDI0406A p. A8-154" (instr bitAnd: 16rF0) = 16rB0 ifFalse:[^false]. + foo := (instr bitShift: -20) bitAnd: 16rE3. - foo := (instr >> 20 bitAnd: 16rE3). ^foo = 16r4 "strh r1, [r2, #+/-imm]" or:[foo = 16r0 "strh r1, [r2, r3]"]! Item was changed: ----- Method: GdbARMAlien>>instructionIsSTRSP: (in category 'testing') ----- instructionIsSTRSP: instr "is this a STR sp, [??] instruction? Special case to detect STR sp, [] affecting stack pointer" + ^(self instructionIsSTR: instr) and:[((instr bitShift: -12) bitAnd: 16rF) = 13]! - ^(self instructionIsSTR: instr) and:[(instr >>12 bitAnd: 16rF) = 13]! Item was removed: - ----- Method: GdbARMAlien>>primitiveRunInMemory:minimumAddress:maximumAddress:readOnlyBelow: (in category 'primitives') ----- - primitiveRunInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" maximumAddress: maximimAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" - "Run the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the - memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range - calls, jumps and memory read/writes into ProcessorSimulationTrap signals." - <primitive: 'primitiveRunInMemoryMinAddressMaxAddressReadWrite' module: 'GdbARMPlugin' error: ec> - ^ec == #'inappropriate operation' - ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray - minimumAddress: minimumAddress] - ifFalse: [self reportPrimitiveFailure] - - "self printRegistersOn: Transcript"! Item was changed: ----- Method: GdbARMAlien>>primitiveRunInMemory:minimumAddress:readOnlyBelow: (in category 'primitives') ----- primitiveRunInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" "Run the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range calls, jumps and memory read/writes into ProcessorSimulationTrap signals. Note that minWriteMaxExecAddress is both the minimum writeable address AND the maximum executable address" <primitive: 'primitiveRunInMemoryMinimumAddressReadWrite' module: 'GdbARMPlugin' error: ec> + ^ec isPrimitiveError + ifTrue: + [self handleExecutionPrimitiveFailureIn: memoryArray + minimumAddress: minimumAddress + code: ec errorCode] + ifFalse: + [ec == #'inappropriate operation' + ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray + minimumAddress: minimumAddress] + ifFalse: [self reportPrimitiveFailure]]! - ^ec == #'inappropriate operation' - ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray - minimumAddress: minimumAddress] - ifFalse: [self reportPrimitiveFailure] - - "self printRegistersOn: Transcript"! Item was removed: - ----- Method: GdbARMAlien>>primitiveSingleStepInMemory:minimumAddress:maximumAddress:readOnlyBelow: (in category 'primitives') ----- - primitiveSingleStepInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" maximumAddress: maximimAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" - "Single-step the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the - memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range - calls, jumps and memory read/writes into ProcessorSimulationTrap signals." - <primitive: 'primitiveSingleStepInMemoryMinAddressMaxAddressReadWrite' module: 'GdbARMPlugin' error: ec> - ^ec == #'inappropriate operation' - ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray - minimumAddress: minimumAddress] - ifFalse: [self reportPrimitiveFailure]! Item was changed: ----- Method: GdbARMAlien>>primitiveSingleStepInMemory:minimumAddress:readOnlyBelow: (in category 'primitives') ----- primitiveSingleStepInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" "Single-step the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range calls, jumps and memory read/writes into ProcessorSimulationTrap signals." <primitive: 'primitiveSingleStepInMemoryMinimumAddressReadWrite' module: 'GdbARMPlugin' error: ec> + ^ec isPrimitiveError + ifTrue: + [self handleExecutionPrimitiveFailureIn: memoryArray + minimumAddress: minimumAddress + code: ec errorCode] + ifFalse: + [ec == #'inappropriate operation' + ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray + minimumAddress: minimumAddress] + ifFalse: [self reportPrimitiveFailure]]! - ^ec == #'inappropriate operation' - ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray - minimumAddress: minimumAddress] - ifFalse: [self reportPrimitiveFailure]! Item was removed: - ----- Method: GdbARMv8Alien>>primitiveRunInMemory:minimumAddress:maximumAddress:readOnlyBelow: (in category 'primitives') ----- - primitiveRunInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" maximumAddress: maximimAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" - "Run the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the - memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range - calls, jumps and memory read/writes into ProcessorSimulationTrap signals." - <primitive: 'primitiveRunInMemoryMinAddressMaxAddressReadWrite' module: 'GdbARMv8Plugin' error: ec> - ^ec == #'inappropriate operation' - ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray - minimumAddress: minimumAddress] - ifFalse: [self reportPrimitiveFailure] - - "self printRegistersOn: Transcript"! Item was changed: ----- Method: GdbARMv8Alien>>primitiveRunInMemory:minimumAddress:readOnlyBelow: (in category 'primitives') ----- primitiveRunInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" "Run the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range calls, jumps and memory read/writes into ProcessorSimulationTrap signals. Note that minWriteMaxExecAddress is both the minimum writeable address AND the maximum executable address" <primitive: 'primitiveRunInMemoryMinimumAddressReadWrite' module: 'GdbARMv8Plugin' error: ec> ^ec isPrimitiveError ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray minimumAddress: minimumAddress code: ec errorCode] ifFalse: [ec == #'inappropriate operation' ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray minimumAddress: minimumAddress] + ifFalse: [self reportPrimitiveFailure]]! - ifFalse: [self reportPrimitiveFailure]] - - "self printRegistersOn: Transcript"! Item was removed: - ----- Method: GdbARMv8Alien>>primitiveSingleStepInMemory:minimumAddress:maximumAddress:readOnlyBelow: (in category 'primitives') ----- - primitiveSingleStepInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" maximumAddress: maximimAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" - "Single-step the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the - memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range - calls, jumps and memory read/writes into ProcessorSimulationTrap signals." - <primitive: 'primitiveSingleStepInMemoryMinAddressMaxAddressReadWrite' module: 'GdbARMv8Plugin' error: ec> - ^ec == #'inappropriate operation' - ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray - minimumAddress: minimumAddress] - ifFalse: [self reportPrimitiveFailure]! Item was changed: ----- Method: GdbARMv8Alien>>primitiveSingleStepInMemory:minimumAddress:readOnlyBelow: (in category 'primitives') ----- primitiveSingleStepInMemory: memoryArray "<Bitmap|ByteArray>" minimumAddress: minimumAddress "<Integer>" readOnlyBelow: minimumWritableAddress "<Integer>" "Single-step the receiver using the argument as the store. Origin the argument at 0. i.e. the first byte of the memoryArray is address 0. Make addresses below minimumAddress illegal. Convert out-of-range calls, jumps and memory read/writes into ProcessorSimulationTrap signals." <primitive: 'primitiveSingleStepInMemoryMinimumAddressReadWrite' module: 'GdbARMv8Plugin' error: ec> + ^ec isPrimitiveError + ifTrue: + [self handleExecutionPrimitiveFailureIn: memoryArray + minimumAddress: minimumAddress + code: ec errorCode] + ifFalse: + [ec == #'inappropriate operation' + ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray + minimumAddress: minimumAddress] + ifFalse: [self reportPrimitiveFailure]]! - ^ec == #'inappropriate operation' - ifTrue: [self handleExecutionPrimitiveFailureIn: memoryArray - minimumAddress: minimumAddress] - ifFalse: [self reportPrimitiveFailure]!

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
18
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev November 2019