Vm-dev March 2019

vm-dev@lists.squeakfoundation.org

27 participants
98 discussions

VM Maker: Cog-eem.354.mcz
by commits＠source.squeak.org 16 Mar '19

16 Mar '19

Eliot Miranda uploaded a new version of Cog to project VM Maker: http://source.squeak.org/VMMaker/Cog-eem.354.mcz ==================== Summary ==================== Name: Cog-eem.354 Author: eem Time: 16 March 2019, 1:44:07.412059 pm UUID: 46932143-1042-4836-b362-84b799def68d Ancestors: Cog-eem.353 Provide an edit script to map cCode: 'func(...)''s to the new _: style. =============== Diff against Cog-eem.353 =============== Item was added: + ----- Method: CogScripts class>>eliminateCCodeInSmalltalkFrom: (in category 'plugin scripts') ----- + eliminateCCodeInSmalltalkFrom: aPluginClass + "Edit any self cCode: 'something that looks like a C call' [ inSmalltalk: [ ...] ] + into the function: arg1 _: arg2 style, ensuring that if the class has (a) simulator + subclass(es), that a stub implementation exists in the subclass. Write any failures + to the transcript." + + "(Smalltalk organization classesInCategory: #'3DICC-Plugins') do: + [:aPluginClass| + CogScripts eliminateCCodeInSmalltalkFrom: aPluginClass]" + + | transformations | + transformations := Dictionary new. + aPluginClass selectorsAndMethodsDo: + [:selector :method| + (self mapCCodeToSmalltalkIn: method) + ifNotNil: [:edit| transformations at: selector put: edit] + ifNil: [((method sendsSelector: #cCode:) or: [method sendsSelector: #cCode:inSmalltalk:]) ifTrue: + [Transcript cr; show: 'mapCCodeToSmalltalkIn: failed to edit cCode:... in ', aPluginClass name, '>>', selector]]]. + transformations keys sort do: + [:selector| + [:code :messages| + (aPluginClass compile: code notifying: nil) + ifNil: [Transcript cr; show: 'Failed to compile mapCCodeToSmalltalkIn: transformation for ', aPluginClass name, '>>', selector] + ifNotNil: + [(aPluginClass allSubclasses select: [:sc| sc name endsWith: 'Simulator']) do: + [:sc| + messages do: + [:msg| + (sc includesSelector: msg selector) ifFalse: + [sc compile: msg createStubMethod classified: 'simulation']]]]] + valueWithArguments: (transformations at: selector)]! Item was added: + ----- Method: CogScripts class>>mapCCodeToSmalltalkIn: (in category 'plugin scripts') ----- + mapCCodeToSmalltalkIn: aMethod + "Answer new source code for aMethod where cCode: strings have been mapped to the new foo: arg1 _: arg2 + format and any inSmalltalk: code is included in a trailing comment." + | methodNode edits text | + methodNode := aMethod methodNode. + edits := Dictionary new. + methodNode block nodesDo: + [:n| | cCode | + (n isMessage + and: [(#(cCode: cCode:inSmalltalk:) includes: n selector key) + and: [(cCode := n arguments first value key) isString + and: [cCode notEmpty]]]) ifTrue: + [| argVec | + argVec := self processedCCodeCallFor: cCode. + edits at: (methodNode encoder sourceRangeFor: n) + put: (String streamContents: + [:s| | first | + argVec size > 2 ifTrue: + [s nextPutAll: 'cCoerce: (self ']. + s nextPutAll: argVec first. + argVec size > 1 ifTrue: + [first := true. + argVec second do: + [:thing| | param | + thing ~~ #, ifTrue: + [s nextPutAll: (first + ifTrue: [': '] + ifFalse: [' _: ']). + first := false. + param := thing isArray + ifTrue: [s nextPutAll: '(self cCoerce: '. thing first] + ifFalse: [thing]. + (methodNode encoder lookupVariable: param ifAbsent: []) + ifNotNil: [s nextPutAll: param] + ifNil: [s store: param]]. + thing isArray ifTrue: + [(self printTypeFor: thing last on: s) ifFalse: + [^nil]. + s nextPut: $)]]]. + argVec size > 2 ifTrue: + [s nextPut: $). + (self printTypeFor: argVec last on: s) ifFalse: + [^nil]]. + #cCode:inSmalltalk: == n selector key ifTrue: + [| r | + r := methodNode encoder sourceRangeFor: n arguments last. + s space; nextPutAll: ' "inSmalltalk: '; nextPutAll: (methodNode sourceText copyFrom: r first to: r last); nextPut: $"]])]]. + edits ifEmpty: [^nil]. + text := methodNode sourceText asString. + (edits keys asSortedCollection: [:a :b| a first > b first]) do: + [:range| + text := text copyReplaceFrom: range first to: range last with: (edits at: range)]. + ^{ text. + (edits collect: + [:string| | selectorString index | + selectorString := (string beginsWith: 'cCoerce:') ifTrue: [string allButFirst: 10] ifFalse: [string]. + (index := selectorString indexOfSubCollection: '"inSmalltalk') > 0 ifTrue: + [selectorString := selectorString first: index - 1]. + (selectorString occurrencesOf: $)) > (selectorString occurrencesOf: $() ifTrue: + [selectorString := selectorString first: (selectorString lastIndexOf: $)) - 1]. + (selectorString beginsWith: 'self') ifTrue: + [selectorString := selectorString allButFirst: 4]. + selectorString := selectorString extractSelector. + Message + selector: selectorString asSymbol + arguments: (1 to: selectorString numArgs) asArray]) }! Item was added: + ----- Method: CogScripts class>>printTypeFor:on: (in category 'plugin scripts') ----- + printTypeFor: anArray on: aWriteStream + | type | + type := String streamContents: + [:s| + anArray + do: [:ea| [s nextPutAll: ea] on: Error do: [:ex| ^false]] + separatedBy: [s space]]. + aWriteStream nextPutAll: ' to: '; store: type asSymbol. + ^true! Item was added: + ----- Method: CogScripts class>>processedCCodeCallFor: (in category 'plugin scripts') ----- + processedCCodeCallFor: aCCodeString + "Take a cCode: string containing a C call and answer a literal array encoding the parameter + list with any casts moved to the back, for ease of generating self cCoerce: thing to: type. + + 'func(a,b)' => #(func #(a b)) + '(type)func()' => #(func #() #(type)) + 'func((type)a)') => #(func #(#(a #(type))))) + " + | argVec parameterList | + argVec := Compiler evaluate: '#(', aCCodeString, ')'. + [argVec size > 2 and: [argVec last == #';']] whileTrue: [argVec := argVec allButLast]. + argVec last notEmpty ifTrue: + [parameterList := (argVec last splitBy: #(#,)) collect: [:p| p size > 1 ifTrue: [{p last. p first}] ifFalse: [p first]]. + argVec at: argVec size put: parameterList]. + ^argVec first isArray + ifTrue: [argVec allButFirst, {argVec first}] + ifFalse: [argVec]! Item was added: + ----- Method: String>>extractSelector (in category '*Cog-script support') ----- + extractSelector + "Dan's code for hunting down selectors with keyword parts; while this doesn't give a true parse, + in most cases it does what we want, and where it doesn't, we're none the worse for it. + Unlike findSelector this doesn't require that the poutative selector has been interned." + | sel possibleParens | + sel := self withBlanksTrimmed. + (sel includes: $:) ifTrue: + [sel := sel copyReplaceAll: ':' with: ': '. "for the style (aa max:bb) with no space" + sel := sel copyReplaceAll: '[:' with: '[ :'. "for the style ([:a) with no space" + possibleParens := sel findTokens: Character separators. + sel := self class streamContents: + [:s | | level | + level := 0. + possibleParens do: + [:token | + (level = 0 and: [token endsWith: ':']) + ifTrue: [s nextPutAll: token] + ifFalse: [level := level + + (token occurrencesOf: $() - (token occurrencesOf: $)) + + (token occurrencesOf: $[) - (token occurrencesOf: $]) + + (token occurrencesOf: ${) - (token occurrencesOf: $})]]]]. + sel isEmpty ifTrue: [^ nil]. + ^sel!

1 0

Pharo FFI on aarch64/arm64
by ken.dickey＠whidbey.com 15 Mar '19

15 Mar '19

Greetings, I have been making small progress in getting Pharo's FFI unit tests to pass on arm64. Built from recent OpenSmalltalk opensmalltalk-vm build.linux64ARMv8/pharo.stack.spur I get a pharo vm whose UI is pretty slow (no JIT so far), so current progress is slow. I am looking at #FFICallbackThunk>initializeARM32 but I don't yet understand quite what this code is trying to do, so have not made proper changes for arm64. Anybody care to join in or advise me on this? Note that I am neither a Pharo nor a UnifiedFFI user, so I may be making really dumb mistakes at this point (i.e. _you_ could help me out here! 8^). Thanks much in advance, -KenD

2 2

Canceled: OpenSmalltalk/opensmalltalk-vm#1717 (Cog - 0e3761c)
by Travis CI 13 Mar '19

13 Mar '19

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1717 Status: Canceled Duration: 23 mins and 39 secs Commit: 0e3761c (Cog) Author: Eliot Miranda Message: CogVM source as per VMMaker.oscog-eem.2530 Slang: Fix bug in dead-code elimination. In checking whether a name is defined at compile-time or not we have to deal with both TDefineNode and TVarableNode, and so must use nameOrValue, not just value. This affects finalizeReference: which was having variables used in a "cppIf: PharoVM ifTrue: ..." arm deleted since the code generator incorresctly assessed the arm as dead code. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/484d7684e6ab...0e… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/505961014?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

Canceled: OpenSmalltalk/opensmalltalk-vm#1717 (Cog - 0e3761c)
by Travis CI 13 Mar '19

13 Mar '19

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1717 Status: Canceled Duration: 7 mins and 20 secs Commit: 0e3761c (Cog) Author: Eliot Miranda Message: CogVM source as per VMMaker.oscog-eem.2530 Slang: Fix bug in dead-code elimination. In checking whether a name is defined at compile-time or not we have to deal with both TDefineNode and TVarableNode, and so must use nameOrValue, not just value. This affects finalizeReference: which was having variables used in a "cppIf: PharoVM ifTrue: ..." arm deleted since the code generator incorresctly assessed the arm as dead code. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/484d7684e6ab...0e… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/505961014?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

[OpenSmalltalk/opensmalltalk-vm] 0266ad: **[ci skip]** Add a build directory for making the...
by Eliot Miranda 13 Mar '19

13 Mar '19

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 0266ad20d2fce07bd09a875fec529e739fb50250 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0266ad20d2fce07bd0… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2019-03-13 (Wed, 13 Mar 2019) Changed paths: A build.macos32x86/pharo.cog.v3/Makefile A build.macos32x86/pharo.cog.v3/mvm A build.macos32x86/pharo.cog.v3/plugins.ext A build.macos32x86/pharo.cog.v3/plugins.int Log Message: ----------- **[ci skip]** Add a build directory for making the old Pharo V3 VM.

1 0

Errored: OpenSmalltalk/opensmalltalk-vm#1717 (Cog - 0e3761c)
by Travis CI 13 Mar '19

13 Mar '19

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1717 Status: Errored Duration: 35 mins and 38 secs Commit: 0e3761c (Cog) Author: Eliot Miranda Message: CogVM source as per VMMaker.oscog-eem.2530 Slang: Fix bug in dead-code elimination. In checking whether a name is defined at compile-time or not we have to deal with both TDefineNode and TVarableNode, and so must use nameOrValue, not just value. This affects finalizeReference: which was having variables used in a "cppIf: PharoVM ifTrue: ..." arm deleted since the code generator incorresctly assessed the arm as dead code. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/484d7684e6ab...0e… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/505961014?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

[OpenSmalltalk/opensmalltalk-vm] 0e3761: CogVM source as per VMMaker.oscog-eem.2530
by Eliot Miranda 13 Mar '19

13 Mar '19

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 0e3761c888d2545c9846f360f99dcfa25317aff5 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0e3761c888d2545c98… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2019-03-13 (Wed, 13 Mar 2019) Changed paths: M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/cointerpmt.c M spur64src/vm/cointerpmt.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/gcc3x-cointerpmt.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/cointerpmt.c M spursrc/vm/cointerpmt.h M spursrc/vm/gcc3x-cointerp.c M spursrc/vm/gcc3x-cointerpmt.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/plugins/DESPlugin/DESPlugin.c M src/plugins/FilePlugin/FilePlugin.c M src/plugins/LargeIntegers/LargeIntegers.c M src/plugins/XDisplayControlPlugin/XDisplayControlPlugin.c M src/vm/cogit.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2530 Slang: Fix bug in dead-code elimination. In checking whether a name is defined at compile-time or not we have to deal with both TDefineNode and TVarableNode, and so must use nameOrValue, not just value. This affects finalizeReference: which was having variables used in a "cppIf: PharoVM ifTrue: ..." arm deleted since the code generator incorresctly assessed the arm as dead code.

1 0

VM Maker: VMMaker.oscog-eem.2530.mcz
by commits＠source.squeak.org 13 Mar '19

13 Mar '19

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2530.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2530 Author: eem Time: 13 March 2019, 12:24:13.20642 pm UUID: 4d90ede0-0700-4d15-8173-2aaf2360b7d1 Ancestors: VMMaker.oscog-eem.2529 Oops. The previous commit broke the warning for defines/variables. Undo the regression on warnings while keeping the bug fix for dead code elimination. =============== Diff against VMMaker.oscog-eem.2529 =============== Item was changed: ----- Method: CCodeGenerator>>nilOrBooleanConditionFor: (in category 'utilities') ----- nilOrBooleanConditionFor: nodeOrNil "If nodeOrNil is one of the conditional sends for which we do translation-time dead code elimination (i.e. cppIf:ifTrue: et al or ifTrue: et al) and the conditional does evaluate to a translation-time boolean constant, answer that constant, otherwise answer nil. Used to prune dead code, either for code generaton or dead variable elimination." generateDeadCode ifTrue: [^nil]. nodeOrNil ifNil: [^nil]. nodeOrNil isSend ifFalse: [^nil]. (#(ifTrue: ifFalse: ifTrue:ifFalse: ifFalse:ifTrue:) includes: nodeOrNil selector) ifTrue: [^self nilOrBooleanConstantReceiverOf: nodeOrNil receiver]. (#(and: or:) includes: nodeOrNil selector) ifTrue: [^self nilOrBooleanConstantReceiverOf: nodeOrNil]. (#(cppIf:ifTrue: cppIf:ifTrue:ifFalse:) includes: nodeOrNil selector) ifTrue: + [| maybeName value | - [| maybeName | - maybeName := nodeOrNil args first isConstant ifTrue: - [nodeOrNil args first nameOrValue]. (vmClass notNil and: [nodeOrNil args first isConstant + and: [(value := nodeOrNil args first value) isSymbol + and: [((vmClass ifNil: [VMBasicConstants]) defineAtCompileTime: value) not + and: [(vmClass bindingOf: value) notNil]]]]) ifTrue: - and: [maybeName isSymbol - and: [(vmClass defineAtCompileTime: maybeName) not - and: [(vmClass bindingOf: maybeName) notNil]]]]) ifTrue: [self logger nextPutAll: 'Warning: cppIf: reference to '; + store: value; - store: maybeName; nextPutAll: ' when variable of same name exists.'; cr]. + maybeName := nodeOrNil args first isConstant ifTrue: + [nodeOrNil args first nameOrValue]. + ^(optionsDictionary notNil - (optionsDictionary notNil and: [nodeOrNil args first isConstant and: [(#(true false) includes: (optionsDictionary at: maybeName ifAbsent: [nil])) and: [((vmClass ifNil: [VMBasicConstants]) defineAtCompileTime: maybeName) not]]]) ifTrue: + [optionsDictionary at: nodeOrNil args first name]]. - [^optionsDictionary at: maybeName]]. ^nil!

1 0

VM Maker: VMMaker.oscog-eem.2528.mcz
by commits＠source.squeak.org 13 Mar '19

13 Mar '19

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2528.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2528 Author: eem Time: 12 March 2019, 3:27:02.082826 pm UUID: 4e2a39e8-85bd-4a4a-a04b-86567f28f1ea Ancestors: VMMaker.oscog-eem.2527 Spur 64-bits: Fix https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/376; Bug in primitive 551 (SmallFloat64>> truncated). Fiox by also checking that the truncated value is in integer range. =============== Diff against VMMaker.oscog-eem.2527 =============== Item was changed: ----- Method: InterpreterPrimitives>>primitiveSmallFloatTruncated (in category 'arithmetic float primitives') ----- primitiveSmallFloatTruncated <option: #Spur64BitMemoryManager> | rcvr trunc | <var: #rcvr type: #double> <var: #trunc type: #double> rcvr := objectMemory smallFloatValueOf: self stackTop. self cCode: [self mod: rcvr f: (self addressOf: trunc)] inSmalltalk: [trunc := rcvr truncated]. + ((trunc between: objectMemory minSmallInteger asFloat and: objectMemory maxSmallInteger asFloat) + and: [objectMemory isIntegerValue: trunc asInteger]) - (trunc between: objectMemory minSmallInteger asFloat and: objectMemory maxSmallInteger asFloat) ifTrue: [self stackTopPut: (objectMemory integerObjectOf: trunc asInteger)] ifFalse: [self primitiveFail]!

1 0

VM Maker: VMMaker.oscog-eem.2529.mcz
by commits＠source.squeak.org 13 Mar '19

13 Mar '19

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2529.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2529 Author: eem Time: 13 March 2019, 11:54:28.516707 am UUID: 0f0801c0-ef39-4573-ad13-b3e08bc86f12 Ancestors: VMMaker.oscog-eem.2528 Slang: Fix bug in dead-code elimination. In checking whether a name is defined at compile-time or not we have to deal with both TDefineNode and TVarableNode, and so must use nameOrValue, not just value. This affects finalizeReference: which was having variables used in a "cppIf: PharoVM ifTrue: ..." arm deleted since the code generator incorresctly assessed the arm as dead code. =============== Diff against VMMaker.oscog-eem.2527 =============== Item was changed: ----- Method: CCodeGenerator>>nilOrBooleanConditionFor: (in category 'utilities') ----- nilOrBooleanConditionFor: nodeOrNil "If nodeOrNil is one of the conditional sends for which we do translation-time dead code elimination (i.e. cppIf:ifTrue: et al or ifTrue: et al) and the conditional does evaluate to a translation-time boolean constant, answer that constant, otherwise answer nil. Used to prune dead code, either for code generaton or dead variable elimination." generateDeadCode ifTrue: [^nil]. nodeOrNil ifNil: [^nil]. nodeOrNil isSend ifFalse: [^nil]. (#(ifTrue: ifFalse: ifTrue:ifFalse: ifFalse:ifTrue:) includes: nodeOrNil selector) ifTrue: [^self nilOrBooleanConstantReceiverOf: nodeOrNil receiver]. (#(and: or:) includes: nodeOrNil selector) ifTrue: [^self nilOrBooleanConstantReceiverOf: nodeOrNil]. (#(cppIf:ifTrue: cppIf:ifTrue:ifFalse:) includes: nodeOrNil selector) ifTrue: + [| maybeName | + maybeName := nodeOrNil args first isConstant ifTrue: + [nodeOrNil args first nameOrValue]. + (vmClass notNil - [(vmClass notNil and: [nodeOrNil args first isConstant + and: [maybeName isSymbol + and: [(vmClass defineAtCompileTime: maybeName) not + and: [(vmClass bindingOf: maybeName) notNil]]]]) ifTrue: - and: [nodeOrNil args first value isSymbol - and: [((vmClass ifNil: [VMBasicConstants]) defineAtCompileTime: nodeOrNil args first value) not - and: [(vmClass bindingOf: nodeOrNil args first value) notNil]]]]) ifTrue: [self logger nextPutAll: 'Warning: cppIf: reference to '; + store: maybeName; - store: nodeOrNil args first value; nextPutAll: ' when variable of same name exists.'; cr]. + (optionsDictionary notNil - ^(optionsDictionary notNil and: [nodeOrNil args first isConstant + and: [(#(true false) includes: (optionsDictionary at: maybeName ifAbsent: [nil])) + and: [((vmClass ifNil: [VMBasicConstants]) defineAtCompileTime: maybeName) not]]]) ifTrue: + [^optionsDictionary at: maybeName]]. - and: [#(true false) includes: (optionsDictionary at: nodeOrNil args first name ifAbsent: [nil])]]) ifTrue: - [optionsDictionary at: nodeOrNil args first name]]. ^nil! Item was changed: ----- Method: InterpreterPrimitives>>primitiveSmallFloatTruncated (in category 'arithmetic float primitives') ----- primitiveSmallFloatTruncated <option: #Spur64BitMemoryManager> | rcvr trunc | <var: #rcvr type: #double> <var: #trunc type: #double> rcvr := objectMemory smallFloatValueOf: self stackTop. self cCode: [self mod: rcvr f: (self addressOf: trunc)] inSmalltalk: [trunc := rcvr truncated]. + ((trunc between: objectMemory minSmallInteger asFloat and: objectMemory maxSmallInteger asFloat) + and: [objectMemory isIntegerValue: trunc asInteger]) - (trunc between: objectMemory minSmallInteger asFloat and: objectMemory maxSmallInteger asFloat) ifTrue: [self stackTopPut: (objectMemory integerObjectOf: trunc asInteger)] ifFalse: [self primitiveFail]!

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev March 2019