Vm-dev August 2019

vm-dev@lists.squeakfoundation.org

20 participants
77 discussions

[OpenSmalltalk/opensmalltalk-vm] Image buffer corruption when running build.macos64x64 targets (#392)
by Gene Ragan 22 Nov '19

22 Nov '19

Building from the latest sources on the Cog branch, I see the attached image when loading various images using various OSX builds. I have tried the 64-bit Pharo, Squeak and newspeak builds with their associated images. I see some variation of the attached image below. If I rollback the source to the 201901172323 tag, I am able to build and load an image and see the window as expected. <img width="811" alt="Screen Shot 2019-04-23 at 6 47 51 PM" src="https://user-images.githubusercontent.com/32800969/56627814-3fea6280-65fc-1…"> -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/392

3 4

[OpenSmalltalk/opensmalltalk-vm] Remove macRoman translation of keyboard keyValue in Win32 VM (#401)
by Nicolas Cellier 04 Nov '19

04 Nov '19

There is code that transforms the presumably latin-1 key value into approximately MacRoman encoding in platforms/win32/vm/sqWin32Window.c I let the archeologists debate if this code dates from Jurassic period or more distant paleozoic era, all I know is that we pay for what we don't buy... Thus I propose to entirely remove that piece of code and disentangle a bit the spaghetti keyboard handling. We indeed do not need this extra level of complexity anymore, images do not use macRoman encoding for a long time On the contrary, images have to undo the translation by sending `macToSqueak` message in various subclasses of `KeyboardInputInterpreter`. For the transition period, old images running on new VMs, or new images running on old VMs, might encounter a few hickups while interpreting non ASCII characters in case of exotic `KeyboardInputInterpreter`. That won't be the case of main `UTF32InputInterpreter` since it mostly uses the utf32 code passed through `eventBuffer sixth` position rather than keyValue passed thru `eventBuffer third`, except for some CTRL+key for which the keyValue is more-than-often < 128, and thus unaffcted by the proposed change. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/401

2 3

[OpenSmalltalk/opensmalltalk-vm] Latest Linux VM can't handle -vm-display-null (#421)
by Max Leske 16 Oct '19

16 Oct '19

On Linux (Debian 10, Ubuntu 14.04.5) `curl get.pharo.org/64/vmLatest80 | bash; ./pharo` fails with > could not find module vm-display-null -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/421

3 5

[OpenSmalltalk/opensmalltalk-vm] OSVM 201804030952 crashes in Context(Object)>copy (#265)
by Fabio Niephaus 26 Sep '19

26 Sep '19

OSVM `201804030952` sometimes crashes in `Context(Object)>copy` when running Squeak SUnit tests. Full stack trace at: https://travis-ci.org/squeak-smalltalk/squeak-app/jobs/387262157#L2073 Another trace is at: https://travis-ci.org/squeak-smalltalk/squeak-app/jobs/382950107#L1717 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/265

3 5

VM Maker Inbox: VMMaker.oscog-nice.2547.mcz
by commits＠source.squeak.org 05 Sep '19

05 Sep '19

Nicolas Cellier uploaded a new version of VMMaker to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/VMMaker.oscog-nice.2547.mcz ==================== Summary ==================== Name: VMMaker.oscog-nice.2547 Author: nice Time: 31 August 2019, 2:02:51.22464 am UUID: 66e4c466-c54c-4035-a7fa-6078386cbc66 Ancestors: VMMaker.oscog-nice.2546 Fix genPrimitiveHighBit We must not modify ReceiverResultReg when we CompletePrimitive (in case of negative receiver). Hence, like in WIN64, we must better use TempReg. =============== Diff against VMMaker.oscog-nice.2546 =============== Item was changed: ----- Method: CogObjectRepresentation>>genPrimitiveHighBit (in category 'primitive generators') ----- genPrimitiveHighBit + "Implementation notes: there are two reasons to use TempReg + -1) if primitive fails, ReceiverResultReg must remain unchanged (we CompletePrimitive) + -2) CLZ/BSR only work on 64bits for registers R0-R7 on Intel X64. But Win64 uses R9 + Normally, this should be backEnd dependent, but for now we have a single 64bits target..." + | jumpNegativeReceiver | <var: #jumpNegativeReceiver type: #'AbstractInstruction *'> "remove excess tag bits from the receiver oop" + cogit MoveR: ReceiverResultReg R: TempReg. self numSmallIntegerTagBits > 1 ifTrue: + [cogit OrCq: 1 << self numSmallIntegerTagBits - 1 R: TempReg. + cogit ArithmeticShiftRightCq: self numSmallIntegerTagBits - 1 R: TempReg]. - [cogit OrCq: 1 << self numSmallIntegerTagBits - 1 R: ReceiverResultReg. - cogit ArithmeticShiftRightCq: self numSmallIntegerTagBits - 1 R: ReceiverResultReg]. "and use the abstract cogit facility for case of single tag-bit" + jumpNegativeReceiver := cogit genHighBitIn: TempReg ofSmallIntegerOopWithSingleTagBit: TempReg. - jumpNegativeReceiver := cogit genHighBitIn: ReceiverResultReg ofSmallIntegerOopWithSingleTagBit: ReceiverResultReg. "Jump is NULL if above operation is not implemented, else return the result" jumpNegativeReceiver = 0 ifFalse: + [cogit MoveR: TempReg R: ReceiverResultReg. + cogit genConvertIntegerToSmallIntegerInReg: ReceiverResultReg. - [cogit genConvertIntegerToSmallIntegerInReg: ReceiverResultReg. cogit genPrimReturn. jumpNegativeReceiver jmpTarget: cogit Label]. ^CompletePrimitive! Item was removed: - ----- Method: CogObjectRepresentation>>genPrimitiveHighBitgenPrimitiveHighBit (in category 'primitive generators') ----- - genPrimitiveHighBitgenPrimitiveHighBit - | jumpNegativeReceiver | - <var: #jumpNegativeReceiver type: #'AbstractInstruction *'> - "remove excess tag bits from the receiver oop" - self numSmallIntegerTagBits > 1 - ifTrue: - [cogit OrCw: 1 << self numSmallIntegerTagBits - 1 R: ReceiverResultReg. - cogit ArithmeticShiftRightCq: self numSmallIntegerTagBits - 1 R: ReceiverResultReg]. - "and use the abstract cogit facility for case of single tag-bit" - jumpNegativeReceiver := cogit genHighBitIn: ReceiverResultReg ofSmallIntegerOopWithSingleTagBit: ReceiverResultReg. - "The jump instruction is NULL when backend does not really has a jitted implementation: fallback to normal primitive" - jumpNegativeReceiver = 0 ifTrue: [^CompletePrimitive]. - cogit genPrimReturn. - jumpNegativeReceiver jmpTarget: cogit Label. - ^UnimplementedPrimitive! Item was removed: - ----- Method: CogObjectRepresentationFor64BitSpur>>genPrimitiveHighBit (in category 'primitive generators') ----- - genPrimitiveHighBit - "Implementation notes: same as super, but CLZ/BSR only work on 64bits for registers R0-R7 on Intel X64. - Normally, this should be backEnd dependent, but for now we have a single 64bits target..." - | jumpNegativeReceiver reg | - <var: #jumpNegativeReceiver type: #'AbstractInstruction *'> - "remove excess tag bits from the receiver oop" - - ReceiverResultReg > 7 - ifTrue: [cogit MoveR: ReceiverResultReg R: (reg := TempReg)] - ifFalse: [reg := ReceiverResultReg]. - self numSmallIntegerTagBits > 1 - ifTrue: - [cogit OrCw: 1 << self numSmallIntegerTagBits - 1 R: reg. - cogit ArithmeticShiftRightCq: self numSmallIntegerTagBits - 1 R: reg]. - "and use the abstract cogit facility for case of single tag-bit" - jumpNegativeReceiver := cogit genHighBitIn: reg ofSmallIntegerOopWithSingleTagBit: reg. - "Jump is NULL if above operation is not implemented, else return the result" - jumpNegativeReceiver = 0 - ifFalse: - [ReceiverResultReg > 7 - ifTrue: [cogit MoveR: reg R: ReceiverResultReg]. - cogit genConvertIntegerToSmallIntegerInReg: ReceiverResultReg. - cogit genPrimReturn. - jumpNegativeReceiver jmpTarget: cogit Label]. - ^CompletePrimitive!

3 5

[OpenSmalltalk/opensmalltalk-vm] 32-bit macOS CI builds broken due to new Metal integration (#397)
by Fabio Niephaus 03 Sep '19

03 Sep '19

It looks like the new Metal integration is not (yet) 32-bit compatible. Maybe we should use the old integration for 32-bit builds or nuke 32-bit builds for macOS completely (Apple is removing 32-bit support soon anyway). Example: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/538780335 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/397

2 3

CMake StackInterpreter Headless build
by Ben Coman 03 Sep '19

03 Sep '19

How can I build the StackInterpreter with the Pharo Headless build? I tried... -DCOG_JIT:BOOL="False" but get the message... [CMake] CMake Warning: Manually-specified variables were not used by the project: COG_JIT The following with the new binary doesn't distinguish it for me... $ build/vm/pharo --version my.image Pharo 8.1.0 built on Aug 30 2019 18:06:20 Compiler: 7.4.0 Built from: acaeef692 - Commit: acaeef692 - Date: 2019-08-28 22:49:49 +0800 Is there anyway to check that a particular binary is a StackInterpreter? Can this be added to "--version" ? Here is the full log... Found cmake executable at /usr/bin/cmake. 1> /usr/bin/cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE="Debug" -DCOG_JIT:BOOL="False" -DCMAKE_INSTALL_PREFIX="/mnt/c/Users/Ben/Source/Repos/opensmalltalk-vm/out/install/WSL-Debug" "/mnt/c/Users/Ben/Source/Repos/opensmalltalk-vm/CMakeLists.txt"; 1> [CMake] -- acaeef692 - Commit: acaeef692 - Date: 2019-08-28 22:49:49 +0800 1> [CMake] -- int 4 1> [CMake] -- long 8 1> [CMake] -- long long 8 1> [CMake] -- void* 8 1> [CMake] -- C Compiler: /usr/bin/cc 1> [CMake] -- C++ Compiler: /usr/bin/c++ 1> [CMake] -- Resource Compiler: 1> [CMake] -- Adding plugin: SecurityPlugin 1> [CMake] -- Adding plugin: FilePlugin 1> [CMake] -- Adding plugin: FileAttributesPlugin 1> [CMake] -- Adding plugin: UUIDPlugin 1> [CMake] -- Adding plugin: SocketPlugin 1> [CMake] -- Adding plugin: SurfacePlugin 1> [CMake] -- Adding plugin: LargeIntegers 1> [CMake] -- Adding plugin: JPEGReaderPlugin 1> [CMake] -- Adding plugin: JPEGReadWriter2Plugin 1> [CMake] -- Adding plugin: MiscPrimitivePlugin 1> [CMake] -- Adding plugin: B2DPlugin 1> [CMake] -- Adding plugin: LocalePlugin 1> [CMake] -- Adding plugin: SqueakSSL 1> [CMake] -- Adding plugin: DSAPrims 1> [CMake] -- Adding plugin: UnixOSProcessPlugin 1> [CMake] Adding third-party libraries for linux: pthreadedPlugin-0.0.1 1> [CMake] Adding third-party libraries for linux: libffi-3.3-rc0 1> [CMake] Adding third-party libraries for linux: libgit2-0.25.1 1> [CMake] Adding third-party libraries for linux: libssh2-1.7.0 1> [CMake] Adding third-party libraries for linux: openssl-1.0.2q 1> [CMake] Adding third-party libraries for linux: SDL2-2.0.7 1> [CMake] -- Configuring done 1> [CMake] -- Generating done 1> [CMake] CMake Warning: 1> [CMake] Manually-specified variables were not used by the project: 1> [CMake] COG_JIT 1> [CMake] -- Build files have been written to: /mnt/c/Users/Ben/Source/Repos/opensmalltalk-vm/out/build/WSL-Debug 1> Starting CMake target info extraction ... 1> CMake server connection made. 1> Extracted includes paths. 1> Extracted CMake variables. 1> Extracted source files and headers. 1> Extracted global settings. 1> Extracted code model. 1> Collating data ... 1> Warning: CMake 3.11 or newer is required for install target integration 1> Target info extraction done. 1> CMake generation finished. cheers -ben P.S. btw, the -DCOG_JIT:BOOL="False" comes from first trying-the-simplest-thing of unticking "COG_JIT" in this Visual Studio configuration dialog... [image: image.png]

2 1

[OpenSmalltalk/opensmalltalk-vm] hack to restore B3DAcceleratorPlugin on macos32x86 (#422)
by Nicolas Cellier 02 Sep '19

02 Sep '19

This is a temporary hack because MacOS32 is going away soon anyway It restore the files from 5a38b3483dc5c82c7ecc85a590fdf1b095377a1f in platforms/iOS/plugins/B3DAcceleratorPlugin32 and hack the build.macos32x86 makefiles to use that NOTE: the CI fails with a Newspeak-64 segfault during tests, but it can't be related to macosx32 B3DAcceleratorPlugin fix obviously... You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/422 -- Commit Summary -- * hack to restore B3DAcceleratorPlugin on macos32x86 -- File Changes -- M build.macos32x86/common/Makefile.plugin (5) M build.macos32x86/common/Makefile.vm (8) A platforms/iOS/plugins/B3DAcceleratorPlugin32/Makefile (14) A platforms/iOS/plugins/B3DAcceleratorPlugin32/sqMacOpenGL.h (47) A platforms/iOS/plugins/B3DAcceleratorPlugin32/sqMacOpenGL.m (403) A platforms/iOS/plugins/B3DAcceleratorPlugin32/zzz/sqMacOpenGL.c (690) A platforms/iOS/plugins/B3DAcceleratorPlugin32/zzz/sqMacOpenGL.h (38) A platforms/iOS/plugins/B3DAcceleratorPlugin32/zzz/sqMacOpenGLInfo.c (324) A platforms/iOS/plugins/B3DAcceleratorPlugin32/zzz/sqMacUIConstants.h (24) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/422.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/422.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/422

1 1

Failed: OpenSmalltalk/opensmalltalk-vm#1795 (Cog - 4a3b1d4)
by Travis CI 31 Aug '19

31 Aug '19

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1795 Status: Failed Duration: 54 mins and 43 secs Commit: 4a3b1d4 (Cog) Author: Nicolas Cellier Message: Merge pull request #419 from ronsaldo/bug/fix-minheadless-squeakssl-mac-build Minheadless SqueakSSL plugin compilation bug fix Notes from ronsaldo: On the minheadless VM that is built using cmake, the add_vm_plugin_sources cmake macro requires specifying the the plugin sources explicitly, which is omitting the src/plugins/SqueakSSL/SqueakSSL.c in the compilation of the plugin. By using the other macro (add_vm_plugin_auto), the platform specific files are automatically found with a glob pattern. This is a mistake that I introduced myself. This problem can be reproduced in Pharo using the minheadless vm of this repository on OS X with the following script: ´´´smalltalk url := 'https://google.com' asZnUrl. ZnClient new url: url; get; response ´´´ Additional note: why Mac needs the explicit ${SqueakSSL_Sources} while Windows and Unix don't? In the case of the minheadless VM for OS X, we are treating the VM as it were an unix since we are removing all of the platform specific windowing code in this VM variant. For this reason, in the cases where OS X is different than another unix, the plugin code has to be added manually. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/20a361a0f8d4...4a… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/579128570?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

[OpenSmalltalk/opensmalltalk-vm] Minheadless SqueakSSL plugin compilation bug fix (#419)
by Ronie Salgado 31 Aug '19

31 Aug '19

I fixed a mistake in the compilation of the SqueakSSL plugin in the minheadless VM for Mac. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419 -- Commit Summary -- * I fixed a mistake in the compilation of the SqueakSSL plugin in the minheadless VM for Mac. -- File Changes -- M cmake/PluginsCommon.cmake (2) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419

5 9

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev August 2019