Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: 222999facd182d2b8acd37c7f9f4b1d269393eca
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/222999facd182d2b8a…
Author: Eliot Miranda <eliot.miranda(a)gmail.com>
Date: 2020-10-04 (Sun, 04 Oct 2020)
Changed paths:
M platforms/Cross/vm/sqVirtualMachine.c
M platforms/Mac OS/vm/sqMacWindow.c
M platforms/iOS/plugins/HostWindowPlugin/sqMacHostWindow.h
M platforms/iOS/plugins/HostWindowPlugin/sqMacHostWindow.m
M platforms/iOS/vm/Common/Classes/sqSqueakScreenAPI.m
M platforms/iOS/vm/Common/Classes/sqSqueakScreenAndWindow.m
M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m
M platforms/iOS/vm/OSX/sqSqueakOSXDropAPI.m
M platforms/win32/plugins/HostWindowPlugin/sqWin32HostWindowPlugin.c
Log Message:
-----------
Minor cleanups before attempting the iOS HostWindowPlugin. [ci skip]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi,
Perhaps good to give some feedback after the fix a while ago,
of the "__builtin_return_address" fix from a while ago.
Here's a screenshot of the Cog VM on Solaris 11.4 (for Intel/AMD) :
https://sourceforge.net/projects/solaris-squeak/
This seems to be working fine, runs the internal 'Tests' mostly ok.
Also special thanks for the 'configure' fixes, the software configures OK,
for the moment on Solaris.
Regards,
David Stes
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJfd2GrAAoJEAwpOKXMq1MaxDQIAJKzQCISznpwvB1Fps4E1gmF
cj+SWBlIDkYrUZZH4xK0r8YjyH3UWT1M22eWu3CBdK7oxbKVLZGNH6oDWj00TSYl
EQM6BqlXWotmdaXjM84q1G8U7K+XDauD11BuZC2/da94kxjH+Z8paNMOsF/FlgUX
W0Ttq7xEEmORT+G8yRTFf6hvbJs1qdRDMh0sLabTtUfB2zcAo018TU+HbpLmjr2t
HW+12avs4nCo+PkjlRJV7RK9rj/nhcxeYqlqc5ROyGwNF5i6tGixFc7uc9O8nJdg
zfW9cJ24gBafK4AOO29QlJE4Lp5PkY29t+TqK+Q4E5+tokrntmhl/yCk1KZavAE=
=XAsw
-----END PGP SIGNATURE-----
Build Update for OpenSmalltalk/opensmalltalk-vm
-------------------------------------
Build: #2220
Status: Still Failing
Duration: 1 hr, 18 mins, and 45 secs
Commit: f679770 (Cog)
Author: Nicolas Cellier
Message: Rescue Win64 cygwin/mingw build and fix issue #498
I (Nicolas Cellier) guess that this only affect cygwin build since there is a parallel Makefile.msvc.tools
`-mno-stack-arg-probe` prevents stack overflow detection when trying to allocate more than a page size on stack, see:
https://archive.is/J01oT
This option makes the VM crash at startup when built for mingw target via cygwin cross-platform toolchain.
Removing the option let the VM start, and the image can at least run some essential SUnit TestCase
Note sure however whether the VM is fully operational or not because I do not know if `-mno-stack-arg-probe` is really required or just an optimization...
`-mno-stack-arg-probe` could eventually work if we would be able to allocate a big enough stack at startup.
That's what we do when using MSVC tool chain:
> ../common/Makefile.msvc.tools:# the default stack size to 2Mb to avoid crashes in the JIT's alloca.
> ../common/Makefile.msvc.tools:DEFAULT_STACK_SIZE:=2097152
> ../common/Makefile.msvc.tools:STACK_LD_FLAG=/STACK:$(DEFAULT_STACK_SIZE),$(DEFAULT_STACK_SIZE)
> ../common/Makefile.msvc.tools:BASELDFLAGS:= $(STACK_LD_FLAG) /DYNAMICBASE /LARGEADDRESSAWARE /NXCOMPAT /DEBUG:FULL
This is supposed to have a solution in mingw too, see:
https://stackoverflow.com/questions/52406183/mingw-stack-size-reserved-or-c…
That's exactly what we are trying to do here:
> ../common/Makefile.tools:BASELDFLAGS:=-m64 -mthreads -Wl,--stack -Xlinker 2097152,2097152 -Wl,$(EXPORT)
Unfortunately, this option is apparently ignored (or overriden?)...
View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/b7c90f4f1790...f6…
View the full build log and details: https://travis-ci.org/github/OpenSmalltalk/opensmalltalk-vm/builds/73184962…
--
You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut….
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati….
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
Nope, wrong guess, the incantation was correct...
It should not be `--stack=reserved,committed` but `--stack reserved,committed`
We cannot pass an argument containing a coma (,) via `-Wl,--stack,reserved,committed` because it would transform the command into `--stack reserved committed`
So there was a mixture of `-Wl,` and `-Xlinker`, which was misleading but correct...
See https://stackoverflow.com/questions/7221141/any-difference-between-wl-optio…
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f679770b318090f0ab…
Err, case of blindness! I see it know:
we pass `--stack -Xlinker 2097152,2097152` where it should have been `-Xlinker --stack=2097152,2097152`
I will check if we can restore `-mno-stack-arg-probe` with above invocation...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f679770b318090f0ab…
Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: f679770b318090f0abdddeabc59568a6520ed7f2
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f679770b318090f0ab…
Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>
Date: 2020-10-01 (Thu, 01 Oct 2020)
Changed paths:
M build.win64x64/common/Makefile.tools
Log Message:
-----------
Rescue Win64 cygwin/mingw build and fix issue #498
I (Nicolas Cellier) guess that this only affect cygwin build since there is a parallel Makefile.msvc.tools
`-mno-stack-arg-probe` prevents stack overflow detection when trying to allocate more than a page size on stack, see:
https://archive.is/J01oT
This option makes the VM crash at startup when built for mingw target via cygwin cross-platform toolchain.
Removing the option let the VM start, and the image can at least run some essential SUnit TestCase
Note sure however whether the VM is fully operational or not because I do not know if `-mno-stack-arg-probe` is really required or just an optimization...
`-mno-stack-arg-probe` could eventually work if we would be able to allocate a big enough stack at startup.
That's what we do when using MSVC tool chain:
> ../common/Makefile.msvc.tools:# the default stack size to 2Mb to avoid crashes in the JIT's alloca.
> ../common/Makefile.msvc.tools:DEFAULT_STACK_SIZE:=2097152
> ../common/Makefile.msvc.tools:STACK_LD_FLAG=/STACK:$(DEFAULT_STACK_SIZE),$(DEFAULT_STACK_SIZE)
> ../common/Makefile.msvc.tools:BASELDFLAGS:= $(STACK_LD_FLAG) /DYNAMICBASE /LARGEADDRESSAWARE /NXCOMPAT /DEBUG:FULL
This is supposed to have a solution in mingw too, see:
https://stackoverflow.com/questions/52406183/mingw-stack-size-reserved-or-c…
That's exactly what we are trying to do here:
> ../common/Makefile.tools:BASELDFLAGS:=-m64 -mthreads -Wl,--stack -Xlinker 2097152,2097152 -Wl,$(EXPORT)
Unfortunately, this option is apparently ignored (or overriden?)...