Vm-dev June 2020

vm-dev@lists.squeakfoundation.org

23 participants
106 discussions

[OpenSmalltalk/opensmalltalk-vm] Simplify gitignore build directories [skip ci] (#351)
by Ben Coman 10 Sep '20

10 Sep '20

I noticed that modified Makefiles weren't being pickup up by `git status`. It was too tedious trying to fix the existing definitions, so I've condensed them down to 4 lines from 34. I'm reasonably sure the result is the same, but if I've missed something its low impact, so maybe just integrate first to let everyone suck-n-see. Doing a `git status` before each `git commit` will let you confirm that its working. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/351 -- Commit Summary -- * Simplify gitignore build directories -- File Changes -- M .gitignore (43) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/351.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/351.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/351

2 2

[OpenSmalltalk/opensmalltalk-vm] third-party: Stop building/using vulnerable software (#386)
by Holger Freyther 10 Sep '20

10 Sep '20

You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386 -- Commit Summary -- * third-party: Stop building/using vulnerable software -- File Changes -- M third-party/libgit2.spec (10) M third-party/libpng.spec (6) M third-party/libssh2.spec (6) M third-party/openssl.spec (6) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386

7 13

[OpenSmalltalk/opensmalltalk-vm] fix libgit2 makefile (#390)
by maenu 10 Sep '20

10 Sep '20

I am using MacPort's CMake which works fine, except that it needs a path argument for the libgit2 makefile. Can somebody check if this is compatible with their CMakes? You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/390 -- Commit Summary -- * fix libgit2 makefile -- File Changes -- M build.macos64x64/third-party/Makefile.libgit2 (2) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/390.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/390.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/390

2 2

[OpenSmalltalk/opensmalltalk-vm] Sunupdate (#496)
by David Stes 03 Sep '20

03 Sep '20

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hello, There's two updates for the SunOS port here. - - Change #define sk_GENERAL_NAME_freefunc for SunPRO C compiler - - SunOS: add a note in HowToBuild on pkg-config The first change is for the OpenSSL SqueakSSL case of openssl 1.0.2, to fix a type cast ... I think this potentially impacts all openssl 1.0.2 platforms that use --disable-dynamicopenssl but it seems OK (I think/hope). For the second change this is a "documentation" update to the HowToBuild "HOWTO" documentation in the build.sunos directory; this has no further impact. Thanks, David Stes -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJes8ijAAoJEAwpOKXMq1MamV8H/2MrggX6VzRxGCdP40MN5vyE HuynHVCC68dLneHoYSvaMi4IrVGXS6lYMGa8FfNZsWuVCZDW/rii1nZNH9qo6zCM 6QRekLwKOpp63tXGpKj3C/e8skju6cPvCd9LGWguSqPUVHwFCqOSawYI4OEckvvr 6Nvnqk7ER2yE/iuJSeWgIRLVq4kE/Aq3x8wAtf7zgITHhxr8fEG5+H/Y7icKHW1J aTv2Z7jDHTcJqM/sEC0la2e8K2iDHkhKBim0K/PS1LtLgzZGAfycdmHJoq0KccRT gXpEHjsDIEdfvWmIU9xjIiwsIdg5Cz7l5Y7ipb8s1l5cZKv4ct5JnwBl2+Rw+MY= =oc8N -----END PGP SIGNATURE----- You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/496 -- Commit Summary -- * Merge pull request #4 from OpenSmalltalk/Cog * Merge pull request #5 from OpenSmalltalk/Cog * SunOS: add a note in HowToBuild on pkg-config * Change #define sk_GENERAL_NAME_freefunc for SunPRO C compiler -- File Changes -- M build.sunos64x64/HowToBuild (10) M platforms/unix/plugins/SqueakSSL/openssl_overlay.h (2) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/496.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/496.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/496

2 15

[OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)
by Christoph Thiede 21 Aug '20

21 Aug '20

A bit of context: For Squeak, I am currently implementing full-fledged handling of DND events sent by the host system. Actually, Squeak only handles `SQDragDrop` at the moment. However, when logging all received DND events on the image side, I discovered that whenever a file is dropped into the VM, after the last `SQDragMove` an `SQDragLeave` is received before the eventual `SQDragDrop`. This looks very suspicious to me. Neither does the same happen on any other platform (tested on Win32, too), nor does it appear logical to me in any way. If I release the mouse button *over* the image, the drag did not leave, so a "drag leave" should not be recorded. This MR makes sure that in `dndInDrop()`, an `SQDragLeave` event is only recorded if the drop was not successful. (Please note that the `SQDragDrop` event itself will be sent in a deferred manner; `dndInDrop()` itself only calls `XConvertSelection()` from the X-Server which then will send a `SelectionNotify` which will trigger `dndGetSelection()` and eventually have `generateSqueakDropEventIfDroppedFiles()` called.) Please review carefully, as I am a bloody VM newbie and this is my very first commit to this repo! :-) Mentioning @eliotmiranda who appears to be the code owner of this plugin, according to the file's history. Todos: - [ ] Think about backward compatibility: Squeak did not respect any of the drag events but `SQDragDrop` until today, and I'm reworking that handling ATM, so there will be no problem. But are there other users of this plugin that could rely on the old behavior which I consider a bug? Or does the `sq` in the prefix unambiguously stand for `Squeak`? - [ ] Are there any tests I could run to make sure that this change cannot break anything else? You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508 -- Commit Summary -- * Fix a typo * Comment out suspicious line * Merge branch 'Cog' into sqUnixXdnd * Refactor changes * Don't skip SQDragLeave if XGetSelectionOwner failed -- File Changes -- M platforms/unix/vm-display-X11/sqUnixXdnd.c (11) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508

9 47

Win64 Builds broken, slow build times?
by Tom Beckmann 12 Aug '20

12 Aug '20

Hi everyone, I just tried building build.win64x64/squeak.cog.spur on the Cog branch but got a segfault on startup. I then tentatively went back 10 commits (HEAD~10) and it worked again. This is the output I received in gdb: Thread 1 received signal SIGSEGV, Segmentation fault. 0x00000000004016f3 in interpret () at ../../spur64src/vm/gcc3x-cointerp.c:2809 2809 memset(theStackMemory, 0, stackPagesBytes); (gdb) bt #0 0x00000000004016f3 in interpret () at ../../spur64src/vm/gcc3x-cointerp.c:2809 #1 0x000000000052c34c in sqMain (argc=2, argv=0x1dd53a0) at ../../platforms/win32/vm/sqWin32Main.c:1709 #2 0x000000000052c7f2 in WinMain (hInst=0x400000, hPrevInstance=0x0, lpCmdLine=0xfc437c "../../../Squeak6.0alpha-19582-64bit-202003021730-Windows/Squeak6.0alpha-19582-64bit.image", nCmdShow=10) at ../../platforms/win32/vm/sqWin32Main.c:1802 #3 0x00000000004013c7 in __tmainCRTStartup () at /usr/src/debug/mingw64-x86_64-runtime-7.0.0-1/crt/crtexe.c:339 #4 0x00000000004014cb in WinMainCRTStartup () at /usr/src/debug/mingw64-x86_64-runtime-7.0.0-1/crt/crtexe.c:195 The main reason I'm writing, however, is that I only haven't done a bisect yet because building the VM appears unusually slow, when compared to building on Linux, as in, orders of magnitude slower. I believe I have the same setup as we do on appveyor on windows using cygwin64. Incremental builds seem to recompile a lot of files and it appears there are race conditions when building with multiple threads (-j8). Are these known limitations of the Windows build or am I potentially just having the wrong setup? Thank you for any pointers! Tom

4 7

[OpenSmalltalk/opensmalltalk-vm] primitives 54 and 554 for timesTwoPower: answer incorrect result on 64bits macOS VM (#383)
by Nicolas Cellier 20 Jul '20

20 Jul '20

This is due to a macOS bug in 64bits libm! (Hard to believe, isn't it?) I've opened a ticket https://bugreport.apple.com/web/?problemID=48021471 > Area: > Something not on this list > > Summary: ldexp incorrectly rounds gradual underflow for some specific values. > > Steps to Reproduce: > #include <math.h> > #include <stdio.h> > int main() { > int exp=-54; double y=ldexp(11.0,exp); /* y is binary 1.011*2^-51 */ > double u=ldexp(1.0,-1074); /* u is the minimal denormalized IEEE754 double */ > double v=ldexp(y,-1023); /* v is binary 1.011*2^-1074 and should round to u */ > printf("u=%g v=%g\n",u,v); > return 0; > } > > Expected Results: > v should be rounded to 1.0*2^-1074 (round to nearest, tie to even default rule) > Thus we should have u == v. > > Actual Results: > v is rounded upward to binary 10.0*2^-1074 = 1.0*2^-1073 > output is u=4.94066e-324 v=9.88131e-324 > > Note 1: this fails for 4 different values of exp -54,-53,+968,+969 > (replace exponent -1023 by -1074-3-exp, that is -1023,-1024,-2045,-2046) > Note 2: this did not happen previously with 32bits libm version. > Note 3: this sounds a bit like this bug https://stackoverflow.com/questions/32150888/should-ldexp-round-correctly > > Version/Build: > macOS HighSierra 10.13.16 > > Configuration: > compiled with > clang --version > Apple LLVM version 10.0.0 (clang-1000.11.45.5) > Target: x86_64-apple-darwin17.7.0 > Thread model: posix > InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin > Xcode Version 10.1 (10B61) > > -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/383

5 6

Support an updated image format number for Sista
by David T. Lewis 20 Jul '20

20 Jul '20

Hi Eliot, This is a belated follow up on earlier private discussion during a Squeak board meeting a few months ago, in which we agreed that identifying "Sista in use" in the image format number would be a useful thing to do. I previously added the documentation for this in ImageFormat-dtl.39.mcz (as well as the updated ckformat.c program to match). Attached here is a change set that can be loaded into a VMMaker image to add VM support for setting and reading the updated image format numbers. Here I used a primitive to initially set or clear the "sista bit". There are other ways this could be done, but this at least gets us started with a working implementation. By way of explanation, I am copying below both the change set preamble and the earlier ImageFormat commit notice: === Change Set: VMM-Sista-bit-dtl Date: 12 January 2020 Author: David T. Lewis Let the image inform the interpreter that alternate bytecodes either are or are not in use, and remember that setting when writing or reading the image format number in a shapshot file header. Provide primitiveMultipleBytecodesActive to allow the setting to be updated from the image. Expected usage is that the image can call this primitive after recompiling with Systa bytecodes, or after reverting back. Note that an alternative implemenation would be to use a VM parameter. The primitive was chosen here because it can perform parameter checking and does not require coordinated update the the VM parameter usage. Expected usage is that this feature will remain unused for some grace period (perhaps a few months) during which an updated VM can be widely circulated. After that period, images using Sista bytecodes may be safely saved with the updated image format number indicating that multiple bytecodes are in use. This change set includes helper methods in SmalltalkImage for testing or setting the multipleBytecodeSetsActive setting in the VM. Note the change set postscript which is necessary for initializing a class variable prior to code generation. === Name: ImageFormat-dtl.37 Author: dtl Time: 20 July 2019, 5:23:59.004 pm UUID: 52b464d5-0bf7-4326-bde3-4f18ad70b239 Ancestors: ImageFormat-dtl.36 Identify extended bytecodes for Sista in the image format number. Bit 10 identifies an image that contains extended bytecodes. Thus a 32 bit Spur image is 6521, with Sista it is 7033, and a 64 bit Spur image is 68021, with Sista it is 68533. It is expected that additional bytecode sets can be identified by an additional field in the image header, probably 32 bits containing two 16 bit fields, if both zero then Sista. Per discussion with Eliot and Bert in a Squeak oversight board meeting 2019-05-15. Dave

4 10

VM Maker: VMMaker.oscog-eem.2761.mcz
by commits＠source.squeak.org 19 Jul '20

19 Jul '20

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2761.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2761 Author: eem Time: 24 June 2020, 11:15:52.846414 am UUID: 34b29eae-6069-4cb7-8a89-7365fb398dfb Ancestors: VMMaker.oscog-eem.2760 Cherry Picking from various recent commits, but avoiding the extremely desirable, but as yet unfinished, VMMaker.oscog-nice.2761 transformInAssignmentTo: changes.the "thisContext method includes: 42" crash. MiscPrimitivePlugin: fix several uses of sizeOfSTArrayFromCPrimitive: that don''t check for potential failure if e.g. invoked on a CompiledMethod. Returning from a primitive normally when the primtiive has failed leads to disaster since the stack gets cu back but shouldn't be. For CompiledMethod isBytes: is true but isWordsOrBytes: is false. sizeOfSTArrayFromCPrimitive: checks for isWordsOrBytes:. The primtiives check that the argument is isBytes: but don't check if sizeOfSTArrayFromCPrimitive: fails. More general fixes, such as fixing isBytes: to be false for CompiledMethod, or introducing isPureBytes: and using it, are not quick fixes. hence this limited fix here. Primitive infrastructure: consequently guard the various methodReturnXXX''s with an assert to check that a primitive has not failed. Also make sure that the SpurNBitCoMemoryManagers do not follow any reference to a Cog method in the first field of a CompiledMethod. Cosmetic changes for ThreadedFFIPlugins from VMMaker.oscog-nice.2762 Do not try to generate SHA256Plugin, it's obsolete and absent from latest cryptography packages. This from VMMaker.oscog-nice.2761. Slang: Fix TParseNode>>isSameAs: implementations to incluyde an identity check. TReturnNode always answered false to this in the past. Optimize inlineFunctionCall:in: to avoid a rewrite of the copied parse tree being inlined if the actuals match the formals. Uses the improved bindVariablesIn:. Use a setter for variable & expression in TAssignmentNode to ease breakpointing/debugging. =============== Diff against VMMaker.oscog-eem.2760 =============== Item was changed: ----- Method: CogARMCompiler>>concretizeAndCqRR (in category 'generate machine code - concretize') ----- concretizeAndCqRR "Will get inlined into concretizeAt: switch." "AND is very important since it's used to mask all sorts of flags in the jit. We take special care to try to find compact ways to make the masks" <inline: true> | val srcReg dstReg | val := operands at: 0. srcReg := operands at: 1. dstReg := operands at: 2. self rotateable8bitBitwiseImmediate: val ifTrue: [:rot :immediate :invert| self machineCodeAt: 0 put: (invert ifTrue: [self bics: dstReg rn: srcReg imm: immediate ror: rot] ifFalse: [self ands: dstReg rn: srcReg imm: immediate ror: rot]). ^4] ifFalse: [| hb | hb := (operands at: 0) highBit. "First see if the constant can be made from a simple shift of 0xFFFFFFFF" 1 << hb = (val +1) ifTrue: "MVN temp reg, 0, making 0xffffffff" [self machineCodeAt: 0 put:(self mvn: ConcreteIPReg imm: 0 ror: 0). "Then AND reg, temp reg, lsr #(32-hb)" self machineCodeAt: 4 put: (self dataOpType: AndOpcode rd: dstReg rn: srcReg rm: ConcreteIPReg lsr: 32 - hb). + ^8]]. + ^self concretizeDataOperationCwR: AndOpcode R: dstReg! - ^8]. - ^self concretizeDataOperationCwR: AndOpcode R: dstReg]! Item was added: + ----- Method: Float32Array class>>ccg:prolog:expr:index: (in category '*VMMaker-plugin generation') ----- + ccg: cg prolog: aBlock expr: aString index: anInteger + + ^cg ccgLoad: aBlock expr: aString asWBFloatPtrFrom: anInteger! Item was added: + ----- Method: Float32Array class>>ccgDeclareCForVar: (in category '*VMMaker-plugin generation') ----- + ccgDeclareCForVar: aSymbolOrString + + ^'float *', aSymbolOrString! Item was removed: - ----- Method: FloatArray class>>ccg:prolog:expr:index: (in category '*VMMaker-plugin generation') ----- - ccg: cg prolog: aBlock expr: aString index: anInteger - - ^cg ccgLoad: aBlock expr: aString asWBFloatPtrFrom: anInteger! Item was removed: - ----- Method: FloatArray class>>ccgDeclareCForVar: (in category '*VMMaker-plugin generation') ----- - ccgDeclareCForVar: aSymbolOrString - - ^'float *', aSymbolOrString! Item was changed: ----- Method: InterpreterProxy>>methodReturnBool: (in category 'stack access') ----- methodReturnBool: boolean "Sets the return value for a method" + self deny: self failed. self pop: argumentCount+1 thenPushBool: boolean. ^0! Item was changed: ----- Method: InterpreterProxy>>methodReturnFloat: (in category 'stack access') ----- methodReturnFloat: aFloat "Sets the return value for a method" <var: 'aFloat' type: #double> + self deny: self failed. self pop: argumentCount+1 thenPushFloat: aFloat. ^0! Item was changed: ----- Method: InterpreterProxy>>methodReturnInteger: (in category 'stack access') ----- methodReturnInteger: integer "Sets the return value for a method" + self deny: self failed. self pop: argumentCount+1 thenPushInteger: integer. ^0! Item was changed: ----- Method: InterpreterProxy>>methodReturnReceiver (in category 'stack access') ----- methodReturnReceiver "Sets the return value for a method" + self deny: self failed. self pop: argumentCount. ^0! Item was changed: ----- Method: InterpreterProxy>>methodReturnString: (in category 'stack access') ----- methodReturnString: aCString "Attempt to answer a ByteString for a given C string as the result of a primitive." <var: 'aCString' type: #'char *'> + self deny: self failed. aCString ifNil: [primFailCode := PrimErrOperationFailed] ifNotNil: [(self stringForCString: aCString) ifNil: [primFailCode := PrimErrNoMemory] ifNotNil: [:result| self pop: argumentCount+1 thenPush: result]]. ^0! Item was changed: ----- Method: InterpreterProxy>>methodReturnValue: (in category 'stack access') ----- methodReturnValue: oop "Sets the return value for a method" + self deny: self failed. self pop: argumentCount+1 thenPush: oop. ^0! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveCompareString (in category 'primitives') ----- primitiveCompareString "ByteString (class) compare: string1 with: string2 collated: order" <export: true> | len1 len2 order string1 string2 orderOop string1Oop string2Oop | <var: 'order' type: #'unsigned char *'> <var: 'string1' type: #'unsigned char *'> <var: 'string2' type: #'unsigned char *'> orderOop := interpreterProxy stackValue: 0. string2Oop := interpreterProxy stackValue: 1. string1Oop := interpreterProxy stackValue: 2. ((interpreterProxy isBytes: orderOop) and: [(interpreterProxy isBytes: string2Oop) and: [interpreterProxy isBytes: string1Oop]]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. order := interpreterProxy firstIndexableField: orderOop. (interpreterProxy sizeOfSTArrayFromCPrimitive: order) < 256 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. string1 := interpreterProxy firstIndexableField: string1Oop. string2 := interpreterProxy firstIndexableField: string2Oop. len1 := interpreterProxy sizeOfSTArrayFromCPrimitive: string1. len2 := interpreterProxy sizeOfSTArrayFromCPrimitive: string2. + interpreterProxy failed ifTrue: "the sizeOfSTArrayFromCPrimitive:'s fail for e.g. CompiledMethod" + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. 0 to: (len1 min: len2) - 1 do: [ :i | | c1 c2 | c1 := order at: (string1 at: i). c2 := order at: (string2 at: i). c1 = c2 ifFalse: [^interpreterProxy methodReturnInteger: (c1 < c2 ifTrue: [1] ifFalse: [3])]]. interpreterProxy methodReturnInteger: (len1 = len2 ifTrue: [2] ifFalse: [len1 < len2 ifTrue: [1] ifFalse: [3]])! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveCompressToByteArray (in category 'primitives') ----- primitiveCompressToByteArray "Bitmap compress: bm toByteArray: ba" <export: true> | bm ba eqBytes i j k lowByte size destSize word | <var: 'ba' type: #'unsigned char *'> <var: 'bm' type: #'int *'> bm := self cCode: [interpreterProxy arrayValueOf: (interpreterProxy stackValue: 1)] inSmalltalk: [interpreterProxy cCoerce: (interpreterProxy arrayValueOf: (interpreterProxy stackValue: 1)) to: #'int *']. interpreterProxy failed ifTrue: [^nil]. (interpreterProxy isBytes: (interpreterProxy stackValue: 0)) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. (interpreterProxy isOopImmutable: (interpreterProxy stackValue: 0)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. ba := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 0). size := interpreterProxy sizeOfSTArrayFromCPrimitive: bm. destSize := interpreterProxy sizeOfSTArrayFromCPrimitive: ba. + interpreterProxy failed ifTrue: "the sizeOfSTArrayFromCPrimitive:'s fail for e.g. CompiledMethod" + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. destSize < ((size * 4) + 7 + (size // 1984 * 3)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrUnsupported]. "Size may be OK but we don't know, hence fail with unsupported" i := self encodeInt: size in: ba at: 0. k := 0. [k < size] whileTrue: [word := bm at: k. lowByte := word bitAnd: 255. eqBytes := (word >> 8 bitAnd: 255) = lowByte and: [(word >> 16 bitAnd: 255) = lowByte and: [(word >> 24 bitAnd: 255) = lowByte]]. j := k. [j + 1 < size and: [word = (bm at: j + 1)]] whileTrue: [j := j + 1]. j > k ifTrue: [eqBytes ifTrue: [i := self encodeInt: j - k + 1 * 4 + 1 in: ba at: i. ba at: i put: lowByte. i := i + 1] ifFalse: [i := self encodeInt: j - k + 1 * 4 + 2 in: ba at: i. i := self encodeBytesOf: word in: ba at: i]. k := j + 1] ifFalse: [eqBytes ifTrue: [i := self encodeInt: 1 * 4 + 1 in: ba at: i. ba at: i put: lowByte. i := i + 1. k := k + 1] ifFalse: [[j + 1 < size and: [(bm at: j) ~= (bm at: j + 1)]] whileTrue: [j := j + 1]. j + 1 = size ifTrue: [j := j + 1]. i := self encodeInt: j - k * 4 + 3 in: ba at: i. k to: j - 1 by: 1 do: [ :m | i := self encodeBytesOf: (bm at: m) in: ba at: i]. k := j]]]. interpreterProxy methodReturnInteger: i! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveConvert8BitSigned (in category 'primitives') ----- primitiveConvert8BitSigned "SampledSound (class) convert8bitSignedFrom: aByteArray to16Bit: aSoundBuffer" <export: true> | aByteArray aSoundBuffer arraySize byteArrayOop soundBufferOop | <var: 'aByteArray' type: #'unsigned char *'> <var: 'aSoundBuffer' type: #'unsigned short *'> byteArrayOop := interpreterProxy stackValue: 1. (interpreterProxy isBytes: byteArrayOop) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. aByteArray := interpreterProxy firstIndexableField: byteArrayOop. soundBufferOop := interpreterProxy stackValue: 0. + (interpreterProxy isOopImmutable: soundBufferOop) ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrNoModification]. aSoundBuffer := self cCode: [interpreterProxy arrayValueOf: soundBufferOop] inSmalltalk: [interpreterProxy cCoerce: (interpreterProxy arrayValueOf: soundBufferOop) to: #'unsigned short *']. - interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - (interpreterProxy isOopImmutable: soundBufferOop) ifTrue: - [^interpreterProxy primitiveFailFor: PrimErrNoModification]. arraySize := interpreterProxy sizeOfSTArrayFromCPrimitive: aByteArray. + interpreterProxy failed ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. (interpreterProxy byteSizeOf: soundBufferOop) < (2 * arraySize) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. 0 to: arraySize - 1 do: [ :i | | s | s := aByteArray at: i. aSoundBuffer at: i put: (s > 127 ifTrue: [s - 256 bitShift: 8] ifFalse: [s bitShift: 8])]. interpreterProxy methodReturnReceiver! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveDecompressFromByteArray (in category 'primitives') ----- primitiveDecompressFromByteArray "Bitmap decompress: bm fromByteArray: ba at: index" <export: true> | bm ba index i anInt code data end k n pastEnd | <var: 'ba' type: #'unsigned char *'> <var: 'bm' type: #'int *'> <var: 'anInt' type: #'unsigned int'> <var: 'code' type: #'unsigned int'> <var: 'data' type: #'unsigned int'> <var: 'n' type: #'unsigned int'> bm := self cCode: [interpreterProxy arrayValueOf: (interpreterProxy stackValue: 2)] inSmalltalk: [interpreterProxy cCoerce: (interpreterProxy arrayValueOf: (interpreterProxy stackValue: 2)) to: #'int *']. (interpreterProxy isOopImmutable: (interpreterProxy stackValue: 2)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. (interpreterProxy isBytes: (interpreterProxy stackValue: 1)) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. ba := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 1). index := interpreterProxy stackIntegerValue: 0. - interpreterProxy failed ifTrue: [^nil]. - i := index - 1. - k := 0. end := interpreterProxy sizeOfSTArrayFromCPrimitive: ba. pastEnd := interpreterProxy sizeOfSTArrayFromCPrimitive: bm. + interpreterProxy failed ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. + i := index - 1. + k := 0. [i < end] whileTrue: [anInt := ba at: i. i := i + 1. anInt <= 223 ifFalse: [anInt <= 254 ifTrue: [anInt := anInt - 224 * 256 + (ba at: i). i := i + 1] ifFalse: [anInt := 0. 1 to: 4 by: 1 do: [ :j | anInt := (anInt bitShift: 8) + (ba at: i). i := i + 1]]]. n := anInt >> 2. k + n > pastEnd ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. code := anInt bitAnd: 3. "code = 0 ifTrue: [nil]." code = 1 ifTrue: [data := ba at: i. i := i + 1. data := data bitOr: (data bitShift: 8). data := data bitOr: (data bitShift: 16). 1 to: n do: [ :j | bm at: k put: data. k := k + 1]]. code = 2 ifTrue: [data := 0. 1 to: 4 do: [ :j | data := (data bitShift: 8) bitOr: (ba at: i). i := i + 1]. 1 to: n do: [ :j | bm at: k put: data. k := k + 1]]. code = 3 ifTrue: [1 to: n do: [ :m | data := 0. 1 to: 4 do: [ :j | data := (data bitShift: 8) bitOr: (ba at: i). i := i + 1]. bm at: k put: data. k := k + 1]]]. interpreterProxy pop: interpreterProxy methodArgumentCount! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveFindFirstInString (in category 'primitives') ----- primitiveFindFirstInString "ByteString (class) findFirstInString: aString inSet: inclusionMap startingAt: start" <export: true> | aString i inclusionMap stringSize aStringOop inclusionMapOop | <var: 'aString' type: #'unsigned char *'> <var: 'inclusionMap' type: #'unsigned char *'> aStringOop := interpreterProxy stackValue: 2. (interpreterProxy isBytes: aStringOop) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. inclusionMapOop := interpreterProxy stackValue: 1. (interpreterProxy isBytes: inclusionMapOop) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. i := interpreterProxy stackIntegerValue: 0. + interpreterProxy failed ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. i := i - 1. "Convert to 0-based index." i < 0 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. inclusionMap := interpreterProxy firstIndexableField: inclusionMapOop. (interpreterProxy sizeOfSTArrayFromCPrimitive: inclusionMap) ~= 256 ifTrue: [^interpreterProxy methodReturnInteger: 0]. aString := interpreterProxy firstIndexableField: aStringOop. stringSize := interpreterProxy sizeOfSTArrayFromCPrimitive: aString. + interpreterProxy failed ifTrue: "the sizeOfSTArrayFromCPrimitive:'s fail for e.g. CompiledMethod" + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. [i < stringSize and: [(inclusionMap at: (aString at: i)) = 0]] whileTrue: [i := i + 1]. interpreterProxy methodReturnInteger: (i >= stringSize ifTrue: [0] ifFalse: [i + 1])! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveFindSubstring (in category 'primitives') ----- primitiveFindSubstring "ByteString findSubstring: key in: body startingAt: start matchTable: matchTable" <export: true> + | body key keySize bodySize matchTable start bodyOop keyOop matchTableOop | - | body key keySize matchTable start bodyOop keyOop matchTableOop | <var: #key type: #'unsigned char *'> <var: #body type: #'unsigned char *'> <var: #matchTable type: #'unsigned char *'> keyOop := interpreterProxy stackValue: 3. (interpreterProxy isBytes: keyOop) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. bodyOop := interpreterProxy stackValue: 2. (interpreterProxy isBytes: bodyOop) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. start := interpreterProxy stackIntegerValue: 1. interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. matchTableOop := interpreterProxy stackValue: 0. (interpreterProxy isBytes: matchTableOop) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. matchTable := interpreterProxy firstIndexableField: matchTableOop. (interpreterProxy sizeOfSTArrayFromCPrimitive: matchTable) < 256 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. key := interpreterProxy firstIndexableField: keyOop. (keySize := interpreterProxy sizeOfSTArrayFromCPrimitive: key) > 0 ifTrue: [keySize := keySize - 1. "adjust for zero relative indexes" start := start - 1 max: 0. "adjust for zero relative indexes" + body := interpreterProxy firstIndexableField: bodyOop. + bodySize := interpreterProxy sizeOfSTArrayFromCPrimitive: body. + interpreterProxy failed ifTrue: "the sizeOfSTArrayFromCPrimitive:'s fail for e.g. CompiledMethod" + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. + start to: bodySize - 1 - keySize do: - body := interpreterProxy firstIndexableField: bodyOop. - start to: (interpreterProxy sizeOfSTArrayFromCPrimitive: body) - 1 - keySize do: [ :startIndex | | index | index := 0. [(matchTable at: (body at: startIndex + index)) = (matchTable at: (key at: index))] whileTrue: [index = keySize ifTrue: [^interpreterProxy methodReturnInteger: startIndex + 1]. index := index + 1]]]. ^interpreterProxy methodReturnInteger: 0! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveIndexOfAsciiInString (in category 'primitives') ----- primitiveIndexOfAsciiInString "ByteString indexOfAscii: anInteger inString: aString startingAt: start" <export: true> + | integerOop startOop anInteger aString start stringSize stringOop | - | anInteger aString start stringSize aStringOop | <var: #aString type: #'unsigned char *'> + integerOop := interpreterProxy stackValue: 2. + stringOop := interpreterProxy stackValue: 1. + startOop := interpreterProxy stackValue: 0. + ((interpreterProxy isIntegerObject: integerOop) + and: [(interpreterProxy isIntegerObject: startOop) + and: [(interpreterProxy isBytes: stringOop) + and: [interpreterProxy isWordsOrBytes: stringOop]]]) ifFalse: "sizeOfSTArrayFromCPrimitive: is defined only for words or bytes" - anInteger := interpreterProxy stackIntegerValue: 2. - interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. + (start := interpreterProxy integerValueOf: startOop) >= 1 ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. + anInteger := interpreterProxy integerValueOf: integerOop. + aString := interpreterProxy firstIndexableField: stringOop. - aStringOop := interpreterProxy stackValue: 1. - (interpreterProxy isBytes: aStringOop) ifFalse: - [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - start := interpreterProxy stackIntegerValue: 0. - interpreterProxy failed ifTrue: - [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - start >= 1 ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. - aString := interpreterProxy firstIndexableField: aStringOop. stringSize := interpreterProxy sizeOfSTArrayFromCPrimitive: aString. start - 1 to: stringSize - 1 do: + [:pos | - [ :pos | (aString at: pos) = anInteger ifTrue: [^interpreterProxy methodReturnInteger: pos + 1]]. ^interpreterProxy methodReturnInteger: 0! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveStringHash (in category 'primitives') ----- primitiveStringHash "ByteArray (class) hashBytes: aByteArray startingWith: speciesHash" <export: true> | aByteArray hash byteArrayOop | <var: 'aByteArray' type: #'unsigned char *'> <var: 'hash' type: #'unsigned int'> hash := interpreterProxy stackIntegerValue: 0. interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. byteArrayOop := interpreterProxy stackValue: 1. + ((interpreterProxy isBytes: byteArrayOop) + and: [interpreterProxy isWordsOrBytes: byteArrayOop]) ifFalse: "filters out CompiledMethods" - (interpreterProxy isBytes: byteArrayOop) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. aByteArray := interpreterProxy firstIndexableField: byteArrayOop. 0 to: (interpreterProxy sizeOfSTArrayFromCPrimitive: aByteArray) - 1 do: [ :pos | hash := hash + (aByteArray at: pos) * 16r19660D ]. interpreterProxy methodReturnInteger: (hash bitAnd: 16r0FFFFFFF)! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveTranslateStringWithTable (in category 'primitives') ----- primitiveTranslateStringWithTable "ByteString (class) translate: aString from: start to: stop table: table" <export: true> | aString start stop table aStringOop tableOop | <var: #table type: #'unsigned char *'> <var: #aString type: #'unsigned char *'> aStringOop := interpreterProxy stackValue: 3. (interpreterProxy isBytes: aStringOop) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. (interpreterProxy isOopImmutable: aStringOop) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. start := interpreterProxy stackIntegerValue: 2. - interpreterProxy failed ifTrue: - [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. stop := interpreterProxy stackIntegerValue: 1. interpreterProxy failed ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. tableOop := interpreterProxy stackValue: 0. (interpreterProxy isBytes: tableOop) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. aString := interpreterProxy firstIndexableField: aStringOop. (start >= 1 and: [stop <= (interpreterProxy sizeOfSTArrayFromCPrimitive: aString)]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. table := interpreterProxy firstIndexableField: tableOop. (interpreterProxy sizeOfSTArrayFromCPrimitive: table) < 256 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. + interpreterProxy failed ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. start - 1 to: stop - 1 do: [ :i | aString at: i put: (table at: (aString at: i))]. interpreterProxy methodReturnReceiver! Item was added: + ----- Method: Spur32BitCoMemoryManager>>followForwardedObjectFields:toDepth: (in category 'forwarding') ----- + followForwardedObjectFields: objOop toDepth: depth + "Follow pointers in the object to depth. + Answer if any forwarders were found. + How to avoid cyclic structures?? A temporary mark bit? eem 6/22/2020 no need since depth is always finite." + <api> + <inline: false> + | found fmt numSlots | + found := false. + self assert: ((self isPointers: objOop) or: [self isOopCompiledMethod: objOop]). + fmt := self formatOf: objOop. + numSlots := self numPointerSlotsOf: objOop format: fmt. + "It is essential to skip the first field of a method because it may be a + reference to a Cog method in the method zone, not a real object at all." + ((self isCompiledMethodFormat: fmt) + ifTrue: [1] + ifFalse: [0]) + to: numSlots - 1 + do: [:i| | oop | + oop := self fetchPointer: i ofObject: objOop. + (self isNonImmediate: oop) ifTrue: + [(self isForwarded: oop) ifTrue: + [found := true. + oop := self followForwarded: oop. + self storePointer: i ofObject: objOop withValue: oop]. + (depth > 0 + and: [(self hasPointerFields: oop) + and: [self followForwardedObjectFields: oop toDepth: depth - 1]]) ifTrue: + [found := true]]]. + ^found! Item was added: + ----- Method: Spur64BitCoMemoryManager>>followForwardedObjectFields:toDepth: (in category 'forwarding') ----- + followForwardedObjectFields: objOop toDepth: depth + "Follow pointers in the object to depth. + Answer if any forwarders were found. + How to avoid cyclic structures?? A temporary mark bit? eem 6/22/2020 no need since depth is always finite." + <api> + <inline: false> + | found fmt numSlots | + found := false. + self assert: ((self isPointers: objOop) or: [self isOopCompiledMethod: objOop]). + fmt := self formatOf: objOop. + numSlots := self numPointerSlotsOf: objOop format: fmt. + "It is essential to skip the first field of a method because it may be a + reference to a Cog method in the method zone, not a real object at all." + ((self isCompiledMethodFormat: fmt) + ifTrue: [1] + ifFalse: [0]) + to: numSlots - 1 + do: [:i| | oop | + oop := self fetchPointer: i ofObject: objOop. + (self isNonImmediate: oop) ifTrue: + [(self isForwarded: oop) ifTrue: + [found := true. + oop := self followForwarded: oop. + self storePointer: i ofObject: objOop withValue: oop]. + (depth > 0 + and: [(self hasPointerFields: oop) + and: [self followForwardedObjectFields: oop toDepth: depth - 1]]) ifTrue: + [found := true]]]. + ^found! Item was changed: ----- Method: SpurMemoryManager>>followForwardedObjectFields:toDepth: (in category 'forwarding') ----- followForwardedObjectFields: objOop toDepth: depth "Follow pointers in the object to depth. Answer if any forwarders were found. + How to avoid cyclic structures?? A temporary mark bit? eem 6/22/2020 no need since depth is always finite." - How to avoid cyclic structures?? A temproary mark bit?" <api> <inline: false> + | found numSlots | - | oop found | found := false. self assert: ((self isPointers: objOop) or: [self isOopCompiledMethod: objOop]). + numSlots := self numPointerSlotsOf: objOop. + 0 to: numSlots - 1 do: + [:i| | oop | - 0 to: (self numPointerSlotsOf: objOop) - 1 do: - [:i| oop := self fetchPointer: i ofObject: objOop. (self isNonImmediate: oop) ifTrue: [(self isForwarded: oop) ifTrue: [found := true. oop := self followForwarded: oop. self storePointer: i ofObject: objOop withValue: oop]. (depth > 0 and: [(self hasPointerFields: oop) and: [self followForwardedObjectFields: oop toDepth: depth - 1]]) ifTrue: [found := true]]]. ^found! Item was changed: ----- Method: SpurMemoryManager>>numPointerSlotsOf: (in category 'object access') ----- numPointerSlotsOf: objOop "Answer the number of pointer fields in the given object. Works with CompiledMethods, as well as ordinary objects." <api> <inline: true> + | fmt | - | fmt contextSize numLiterals header | fmt := self formatOf: objOop. + ^self numPointerSlotsOf: objOop format: fmt! - fmt <= self lastPointerFormat ifTrue: - [(fmt = self indexablePointersFormat - and: [self isContextNonImm: objOop]) ifTrue: - ["contexts end at the stack pointer" - contextSize := coInterpreter fetchStackPointerOf: objOop. - ^CtxtTempFrameStart + contextSize]. - ^self numSlotsOf: objOop "all pointers"]. - fmt = self forwardedFormat ifTrue: [^1]. - fmt < self firstCompiledMethodFormat ifTrue: [^0]. "no pointers" - - "CompiledMethod: contains both pointers and bytes" - header := self methodHeaderOf: objOop. - numLiterals := self literalCountOfMethodHeader: header. - ^numLiterals + LiteralStart! Item was added: + ----- Method: SpurMemoryManager>>numPointerSlotsOf:format: (in category 'object access') ----- + numPointerSlotsOf: objOop format: fmt + "Answer the number of pointer fields in the given object. + Works with CompiledMethods, as well as ordinary objects." + <inline: #always> + | contextSize numLiterals header | + fmt <= self lastPointerFormat ifTrue: + [(fmt = self indexablePointersFormat + and: [self isContextNonImm: objOop]) ifTrue: + ["contexts end at the stack pointer" + contextSize := coInterpreter fetchStackPointerOf: objOop. + ^CtxtTempFrameStart + contextSize]. + ^self numSlotsOf: objOop "all pointers"]. + fmt = self forwardedFormat ifTrue: [^1]. + fmt < self firstCompiledMethodFormat ifTrue: [^0]. "no pointers" + + "CompiledMethod: contains both pointers and bytes" + header := self methodHeaderOf: objOop. + numLiterals := self literalCountOfMethodHeader: header. + ^numLiterals + LiteralStart! Item was changed: ----- Method: StackInterpreter>>methodReturnBool: (in category 'plugin primitive support') ----- methodReturnBool: boolean "Sets the return value for a method. In the CoInterpreter we replace the cumbersome primResult machinery." + self deny: self failed. self pop: argumentCount+1 thenPushBool: boolean. ^0! Item was changed: ----- Method: StackInterpreter>>methodReturnFloat: (in category 'plugin primitive support') ----- methodReturnFloat: aFloat "Sets the return value for a method." <var: 'aFloat' type: #double> + self deny: self failed. self pop: argumentCount+1 thenPushFloat: aFloat. ^0! Item was changed: ----- Method: StackInterpreter>>methodReturnInteger: (in category 'plugin primitive support') ----- methodReturnInteger: integer "Sets the return value for a method. In the CoInterpreter we replace the cumbersome primResult machinery." + self deny: self failed. self pop: argumentCount+1 thenPushInteger: integer. ^0! Item was changed: ----- Method: StackInterpreter>>methodReturnReceiver (in category 'plugin primitive support') ----- methodReturnReceiver "Sets the return value for a method" + self deny: self failed. self pop: argumentCount. ^0! Item was changed: ----- Method: StackInterpreter>>methodReturnString: (in category 'plugin primitive support') ----- methodReturnString: aCString "Attempt to answer a ByteString for a given C string as the result of a primitive." <var: 'aCString' type: #'char *'> + self deny: self failed. aCString ifNil: [primFailCode := PrimErrOperationFailed] ifNotNil: [(self stringForCString: aCString) ifNil: [primFailCode := PrimErrNoMemory] ifNotNil: [:result| self pop: argumentCount+1 thenPush: result]]. ^0! Item was changed: ----- Method: StackInterpreter>>methodReturnValue: (in category 'plugin primitive support') ----- methodReturnValue: oop "Sets the return value for a method. In the CoInterpreter we replace the cumbersome primResult machinery." + self deny: self failed. self pop: argumentCount+1 thenPush: oop. ^0! Item was changed: ----- Method: TAssignmentNode>>bindVariablesIn: (in category 'transformations') ----- bindVariablesIn: aDictionary + self setVar: (variable bindVariablesIn: aDictionary) + exp: (expression bindVariablesIn: aDictionary)! - variable := variable bindVariablesIn: aDictionary. - expression := expression bindVariablesIn: aDictionary.! Item was changed: ----- Method: TAssignmentNode>>isSameAs: (in category 'testing') ----- isSameAs: aTParseNode + ^self == aTParseNode + or: [aTParseNode isAssignment + and: [(variable isSameAs: aTParseNode variable) + and: [expression isSameAs: aTParseNode expression]]]! - ^aTParseNode isAssignment - and: [(variable isSameAs: aTParseNode variable) - and: [expression isSameAs: aTParseNode expression]]! Item was changed: ----- Method: TAssignmentNode>>postCopy (in category 'copying') ----- postCopy + self setVar: variable copy exp: expression copy! - variable := variable copy. - expression := expression copy! Item was changed: ----- Method: TAssignmentNode>>replaceNodesIn: (in category 'transformations') ----- replaceNodesIn: aDictionary + ^aDictionary + at: self + ifAbsent: + [self setVar: (variable replaceNodesIn: aDictionary) + exp: (expression replaceNodesIn: aDictionary)]! - ^aDictionary at: self ifAbsent: [ - variable := variable replaceNodesIn: aDictionary. - expression := expression replaceNodesIn: aDictionary. - self]! Item was added: + ----- Method: TAssignmentNode>>setVar:exp: (in category 'private') ----- + setVar: varNode exp: expressionNode + "This is a private setter, just for breakpointing..." + variable := varNode. + expression := expressionNode! Item was changed: ----- Method: TConstantNode>>isSameAs: (in category 'comparing') ----- isSameAs: aTParseNode + ^self == aTParseNode + or: [aTParseNode isConstant + and: [value class == aTParseNode value class + and: [value = aTParseNode value]]]! - ^aTParseNode isConstant - and: [value class == aTParseNode value class - and: [value = aTParseNode value]]! Item was changed: ----- Method: TDefineNode>>isSameAs: (in category 'comparing') ----- isSameAs: aTParseNode + ^self == aTParseNode + or: [self class == aTParseNode class + and: [value class == aTParseNode value class + and: [value = aTParseNode value + and: [name = aTParseNode nameOrValue]]]]! - ^self class == aTParseNode class - and: [value class == aTParseNode value class - and: [value = aTParseNode value - and: [name = aTParseNode nameOrValue]]]! Item was changed: ----- Method: TMethod>>deny: (in category 'error handling') ----- deny: aBooleanOrBlock - <doNotGenerate> aBooleanOrBlock value ifTrue: [AssertionFailure signal: 'Assertion failed']! Item was changed: ----- Method: TMethod>>inlineFunctionCall:in: (in category 'inlining') ----- inlineFunctionCall: aSendNode in: aCodeGen "Answer the body of the called function, substituting the actual parameters for the formal argument variables in the method body. Assume caller has established that: 1. the method arguments are all substitutable nodes, and 2. the method to be inlined contains no additional embedded returns." | sel meth doNotRename argsForInlining substitutionDict | + aCodeGen maybeBreakForInlineOf: aSendNode in: self. sel := aSendNode selector. meth := (aCodeGen methodNamed: sel) copy. meth ifNil: [^self inlineBuiltin: aSendNode in: aCodeGen]. doNotRename := Set withAll: args. argsForInlining := aSendNode argumentsForInliningCodeGenerator: aCodeGen. meth args with: argsForInlining do: [ :argName :exprNode | exprNode isLeaf ifTrue: [doNotRename add: argName]]. (meth statements size = 2 and: [meth statements first isSend and: [meth statements first selector == #flag:]]) ifTrue: [meth statements removeFirst]. meth renameVarsForInliningInto: self except: doNotRename in: aCodeGen. meth renameLabelsForInliningInto: self. self addVarsDeclarationsAndLabelsOf: meth except: doNotRename. substitutionDict := Dictionary new: meth args size * 2. meth args with: argsForInlining do: [ :argName :exprNode | + (exprNode isVariable and: [exprNode name = argName]) ifFalse: + [substitutionDict at: argName put: exprNode]. - substitutionDict at: argName put: exprNode. (doNotRename includes: argName) ifFalse: [locals remove: argName]]. meth parseTree bindVariablesIn: substitutionDict. ^meth parseTree endsWithReturn ifTrue: [meth parseTree copyWithoutReturn] ifFalse: [meth parseTree]! Item was added: + ----- Method: TParseNode>>deny: (in category 'as yet unclassified') ----- + deny: aBooleanOrBlock + aBooleanOrBlock value ifTrue: [AssertionFailure signal: 'Assertion failed']! Item was changed: ----- Method: TParseNode>>isSameAs: (in category 'comparing') ----- isSameAs: aTParseNode "Answer if the ParseTree rooted at this node is the same as aTParseNode. By default answer false and have subclasses override as appropriate." + ^self == aTParseNode! - ^false! Item was added: + ----- Method: TReturnNode>>isSameAs: (in category 'comparing') ----- + isSameAs: aTParseNode + ^self == aTParseNode + or: [aTParseNode isReturn + and: [expression isSameAs: aTParseNode expression]]! Item was changed: ----- Method: TSendNode>>isSameAs: (in category 'comparing') ----- isSameAs: aTParseNode + self == aTParseNode ifTrue: [^true]. (aTParseNode isSend and: [selector == aTParseNode selector and: [receiver isSameAs: aTParseNode receiver]]) ifFalse: [^false]. arguments with: aTParseNode args do: [:a :b| (a isSameAs: b) ifFalse: [^false]]. ^true! Item was changed: ----- Method: TStmtListNode>>bindVariablesIn: (in category 'transformations') ----- bindVariablesIn: aDictionary + aDictionary notEmpty ifTrue: + [statements := statements collect: [:s| s bindVariablesIn: aDictionary]]! - statements := statements collect: [ :s | s bindVariablesIn: aDictionary ].! Item was changed: ----- Method: TStmtListNode>>isSameAs: (in category 'testing') ----- isSameAs: aTParseNode + self == aTParseNode ifTrue: [^true]. (aTParseNode isStmtList and: [statements size = aTParseNode statements size]) ifFalse: [^false]. statements with: aTParseNode statements do: [:mine :theirs| (mine isSameAs: theirs) ifFalse: [^false]]. ^true! Item was changed: ----- Method: TVariableNode>>isSameAs: (in category 'comparing') ----- isSameAs: aTParseNode + ^self == aTParseNode + or: [aTParseNode isVariable + and: [name = aTParseNode name]]! - ^aTParseNode isVariable - and: [name = aTParseNode name]! Item was changed: + ----- Method: ThreadedFFIPlugin>>canReturnInRegistersStructOfSize: (in category 'marshalling-struct') ----- - ----- Method: ThreadedFFIPlugin>>canReturnInRegistersStructOfSize: (in category 'marshalling') ----- canReturnInRegistersStructOfSize: returnStructSize "Answer if a struct result of a given size can be returned via registers or not. Size is a necessary condition, but it might not be a sufficient condition. For example, SysV X64 also require that struct fields be properly aligned." ^self subclassResponsibility! Item was changed: + ----- Method: ThreadedFFIPlugin>>ffiPushSignedLongLongOop:in: (in category 'marshalling') ----- - ----- Method: ThreadedFFIPlugin>>ffiPushSignedLongLongOop:in: (in category 'callout support') ----- ffiPushSignedLongLongOop: oop in: calloutState <var: #calloutState type: #'CalloutState *'> "Push a longlong type (e.g., a 64bit integer). Note: Coercions from float are *not* supported." | value | <var: #value type: #sqLong> (oop = interpreterProxy nilObject or: [oop = interpreterProxy falseObject]) ifTrue:[value := 0] ifFalse: [oop = interpreterProxy trueObject ifTrue:[value := 1] ifFalse: [value := interpreterProxy signed64BitValueOf: oop. interpreterProxy failed ifTrue: [^FFIErrorCoercionFailed]]]. ^self ffiPushSignedLongLong: value in: calloutState! Item was changed: + ----- Method: ThreadedFFIPlugin>>ffiPushStructure:ofSize:typeSpec:ofLength:in: (in category 'marshalling-struct') ----- - ----- Method: ThreadedFFIPlugin>>ffiPushStructure:ofSize:typeSpec:ofLength:in: (in category 'marshalling') ----- ffiPushStructure: pointer ofSize: structSize typeSpec: argSpec ofLength: argSpecSize in: calloutState <var: #pointer type: #'void *'> <var: #argSpec type: #'sqInt *'> <var: #calloutState type: #'CalloutState *'> <inline: true> self subclassResponsibility! Item was changed: + ----- Method: ThreadedFFIPlugin>>ffiPushStructureContentsOf:in: (in category 'marshalling-struct') ----- - ----- Method: ThreadedFFIPlugin>>ffiPushStructureContentsOf:in: (in category 'callout support') ----- ffiPushStructureContentsOf: oop in: calloutState <var: #calloutState type: #'CalloutState *'> "Push the contents of the given external structure" | ptrClass ptrAddress | <inline: true> ptrClass := interpreterProxy fetchClassOf: oop. ptrClass = interpreterProxy classExternalAddress ifTrue: "ExternalAddress is bytes" [ptrAddress := (interpreterProxy fetchPointer: 0 ofObject: oop) asVoidPointer. "There is no way we can make sure the structure is valid. But we can at least check for attempts to pass pointers to ST memory." (interpreterProxy isInMemory: ptrAddress) ifTrue: [^FFIErrorInvalidPointer]. ^self ffiPushStructure: ptrAddress ofSize: (calloutState ffiArgHeader bitAnd: FFIStructSizeMask) typeSpec: calloutState ffiArgSpec ofLength: calloutState ffiArgSpecSize in: calloutState]. ptrClass = interpreterProxy classByteArray ifTrue: ["The following is a somewhat pessimistic test but I like being sure..." (interpreterProxy byteSizeOf: oop) = (calloutState ffiArgHeader bitAnd: FFIStructSizeMask) ifFalse:[^FFIErrorStructSize]. ptrAddress := interpreterProxy firstIndexableField: oop. (calloutState ffiArgHeader anyMask: FFIFlagPointer) ifFalse: "Since this involves passing the address of the first indexable field we need to fail the call if it is threaded and the object is young, since it may move during the call." [self cppIf: COGMTVM ifTrue: [((calloutState callFlags anyMask: FFICallFlagThreaded) and: [interpreterProxy isYoung: oop]) ifTrue: [^PrimErrObjectMayMove negated]]. ^self ffiPushStructure: ptrAddress ofSize: (calloutState ffiArgHeader bitAnd: FFIStructSizeMask) typeSpec: calloutState ffiArgSpec ofLength: calloutState ffiArgSpecSize in: calloutState]. "If FFIFlagPointer + FFIFlagStructure is set use ffiPushPointer on the contents" (calloutState ffiArgHeader bitAnd: FFIStructSizeMask) = BytesPerWord ifFalse: [^FFIErrorStructSize]. ptrAddress := (interpreterProxy fetchPointer: 0 ofObject: oop) asVoidPointer. (interpreterProxy isInMemory: ptrAddress) ifTrue: [^FFIErrorInvalidPointer]. ^self ffiPushPointer: ptrAddress in: calloutState]. ^FFIErrorBadArg! Item was changed: + ----- Method: ThreadedFFIPlugin>>ffiPushUnsignedLongLongOop:in: (in category 'marshalling') ----- - ----- Method: ThreadedFFIPlugin>>ffiPushUnsignedLongLongOop:in: (in category 'callout support') ----- ffiPushUnsignedLongLongOop: oop in: calloutState <var: #calloutState type: #'CalloutState *'> "Push an unsigned longlong type (e.g., a 64bit integer). Note: Coercions from float are *not* supported." | value | <var: #value type: #usqLong> (oop = interpreterProxy nilObject or: [oop = interpreterProxy falseObject]) ifTrue:[value := 0] ifFalse: [oop = interpreterProxy trueObject ifTrue:[value := 1] ifFalse: [value := interpreterProxy positive64BitValueOf: oop. interpreterProxy failed ifTrue: [^FFIErrorCoercionFailed]]]. ^self ffiPushUnsignedLongLong: value in: calloutState! Item was changed: + ----- Method: ThreadedFFIPlugin>>ffiPushVoid:in: (in category 'marshalling') ----- - ----- Method: ThreadedFFIPlugin>>ffiPushVoid:in: (in category 'callout support') ----- ffiPushVoid: ignored in: calloutState <var: #calloutState type: #'CalloutState *'> "This is a fallback in case somebody tries to pass a 'void' value. We could simply ignore the argument but I think it's better to let the caller know what he did" ^FFIErrorAttemptToPassVoid! Item was changed: + ----- Method: ThreadedFFIPlugin>>nonRegisterStructReturnIsViaImplicitFirstArgument (in category 'marshalling-struct') ----- - ----- Method: ThreadedFFIPlugin>>nonRegisterStructReturnIsViaImplicitFirstArgument (in category 'marshalling') ----- nonRegisterStructReturnIsViaImplicitFirstArgument "Answer if a struct returned in memory is returned to the referent of a pointer passed as an implciit first argument. It almost always is. Subclasses can override if not." ^true! Item was changed: + ----- Method: ThreadedFFIPlugin>>returnStructInRegisters: (in category 'marshalling-struct') ----- - ----- Method: ThreadedFFIPlugin>>returnStructInRegisters: (in category 'marshalling') ----- returnStructInRegisters: calloutState "Answer if struct result is returned in registers or not. Use the OS specific encoding stored in structReturnType. Since it is OS dependent, leave the responsibility to subclass" <var: #calloutState type: #'CalloutState *'> ^self subclassResponsibility! Item was changed: ----- Method: ThreadedX64SysVFFIPlugin>>registerType:ForUnionSpecs:OfLength:StartingAt:ByteOffset:EightbyteOffset: (in category 'marshalling') ----- registerType: initialRegisterType ForUnionSpecs: specs OfLength: specSize StartingAt: indexPtr ByteOffset: byteOffset EightbyteOffset: eightbyteOffset "Answer with a number characterizing the register type for passing a union of size <= 16 bytes. On input, the index points to the structure header (the one with FFIFlagStructure + structSize) On output, the index points to the structure trailer (the FFIFlagStructure)." <var: #specs type: #'unsigned int*'> <var: #indexPtr type: #'unsigned int*'> - <var: #subIndex type: #'unsigned int'> <inline: false> | registerType spec atomic isInt recurse subLevel | registerType := initialRegisterType. [indexPtr at: 0 put: (indexPtr at: 0) + 1. subLevel := 0. (indexPtr at: 0) < specSize] whileTrue: [spec := specs at: (indexPtr at: 0). isInt := false. recurse := false. spec = FFIFlagStructure "this marks end of structure/union" ifTrue: [subLevel = 0 ifTrue: [^registerType]. subLevel := subLevel - 1] ifFalse: [(spec anyMask: FFIFlagPointer) ifTrue: [isInt := true] ifFalse: [(spec bitAnd: FFIFlagStructure + FFIFlagAtomic) caseOf: {[FFIFlagStructure] -> [recurse := (self isUnionSpec: specs OfLength: specSize StartingAt: (indexPtr at: 0))not. recurse ifFalse: [subLevel := subLevel + 1]]. [FFIFlagAtomic] -> [atomic := self atomicTypeOf: spec. isInt := (atomic >> 1) ~= (FFITypeSingleFloat >> 1)]} otherwise: ["invalid spec" ^-1]]. isInt ifTrue: ["If this eightbyte contains an int field, then we must use an int register" registerType := registerType bitOr: 1 << eightbyteOffset]. recurse ifTrue: ["struct in union require a recursive form, because we handle byteOffset/eightbyteOffset differently" registerType := self registerType: registerType ForStructSpecs: specs OfLength: specSize StartingAt: indexPtr ByteOffset: byteOffset EightbyteOffset: eightbyteOffset]]]. self assert: subLevel = 0. ^registerType! Item was changed: ----- Method: ThreadedX64SysVFFIPlugin>>registerTypeForStructSpecs:OfLength: (in category 'marshalling') ----- registerTypeForStructSpecs: specs OfLength: specSize "Answer with a number characterizing the register type for passing a struct of size <= 16 bytes. The bit at offset i of registerType is set to 1 if eightbyte at offset i is a int register (RAX ...) The bit at offset 2 indicates if there is a single eightbyte (struct size <= 8) * 2r00 for float float (XMM0 XMM1) * 2r01 for int float (RAX XMM0) * 2r10 for float int (XMM0 RAX) * 2r11 for int int (RAX RDX) * 2r100 for float (XMM0) * 2r101 for int (RAX) * 2r110 INVALID (not aligned) Beware, the bits must be read from right to left for decoding register type. Note: this method reconstructs the struct layout according to X64 alignment rules. Therefore, it will not work for packed struct or other exotic alignment." <var: #specs type: #'unsigned int*'> - <var: #subIndex type: #'unsigned int'> <inline: false> | index byteSize registerType | index := 0. byteSize := (specs at: index) bitAnd: FFIStructSizeMask. byteSize > 16 ifTrue: [^2r110]. (self checkAlignmentOfStructSpec: specs OfLength: specSize StartingAt: index) ifFalse: [^2r110]. registerType := byteSize <= 8 ifTrue: [2r100] ifFalse: [0]. ^(self isUnionSpec: specs OfLength: specSize StartingAt: 0) ifTrue: [ self registerType: registerType ForUnionSpecs: specs OfLength: specSize StartingAt: (self addressOf: index) ByteOffset: 0 EightbyteOffset: 0 ] ifFalse: [ self registerType: registerType ForStructSpecs: specs OfLength: specSize StartingAt: (self addressOf: index) ByteOffset: 0 EightbyteOffset: 0 ]! Item was changed: ----- Method: VMMaker class>>generateVMPlugins (in category 'configurations') ----- generateVMPlugins ^VMMaker generatePluginsTo: self sourceTree, '/src' options: #() platformDir: self sourceTree, '/platforms' including:#(ADPCMCodecPlugin AsynchFilePlugin BalloonEnginePlugin B3DAcceleratorPlugin B3DEnginePlugin BMPReadWriterPlugin BitBltSimulation BochsIA32Plugin BochsX64Plugin GdbARMv6Plugin GdbARMv8Plugin CameraPlugin CroquetPlugin DeflatePlugin DropPlugin + "Cryptography Plugins:" DESPlugin DSAPlugin MD5Plugin - "Cryptography Plugins:" DESPlugin DSAPlugin MD5Plugin SHA256Plugin "FT2Plugin" FFTPlugin FileCopyPlugin FilePlugin FileAttributesPlugin Float64ArrayPlugin FloatArrayPlugin FloatMathPlugin GeniePlugin HostWindowPlugin IA32ABIPlugin ImmX11Plugin InternetConfigPlugin JPEGReadWriter2Plugin JPEGReaderPlugin JoystickTabletPlugin KlattSynthesizerPlugin LargeIntegersPlugin LocalePlugin MIDIPlugin MacMenubarPlugin Matrix2x3Plugin MiscPrimitivePlugin Mpeg3Plugin QuicktimePlugin RePlugin ScratchPlugin SecurityPlugin SerialPlugin SocketPlugin SoundCodecPlugin SoundGenerationPlugin SoundPlugin SqueakSSLPlugin StarSqueakPlugin ThreadedFFIPlugin ThreadedARM32FFIPlugin ThreadedARM64FFIPlugin ThreadedIA32FFIPlugin ThreadedX64SysVFFIPlugin ThreadedX64Win64FFIPlugin UnicodePlugin UnixAioPlugin UUIDPlugin UnixOSProcessPlugin Win32OSProcessPlugin VMProfileLinuxSupportPlugin VMProfileMacSupportPlugin WeDoPlugin XDisplayControlPlugin)!

3 4

[OpenSmalltalk/opensmalltalk-vm] `CompiledMethod someInstance includes: 40` segfaults reproducibly (#512)
by Fabio Niephaus 02 Jul '20

02 Jul '20

*Tested with OSVM 202003021730 (Squeak5.3 release VM) on macOS Catalina.* ``` Squeak5.3-19439-64bit.app $ ./Contents/MacOS/Squeak Segmentation fault Mon Jun 22 22:47:47 2020 VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git C stack backtrace & registers: rax 0xfffffffffffffff8 rbx 0x0000000000000001 rcx 0x0000000000000001 rdx 0x0000000101b6f620 rdi 0x0000000000000000 rsi 0x0000000000000009 rbp 0x00007ffeee184d60 rsp 0x00007ffeee184d60 r8 0x000000010809d8c0 r9 0x0000000000000003 r10 0x0000000107435918 r11 0x0000000109934c70 r12 0x00007ffeee191bf8 r13 0x000000010809d8c0 r14 0x0000000000000028 r15 0x0000000000000000 rip 0x0000000101a7b171 0 Squeak 0x0000000101a7b171 sizeOfSTArrayFromCPrimitive + 12 1 Squeak 0x0000000101ad8880 reportStackState + 818 2 Squeak 0x0000000101ad8bd4 sigsegv + 195 3 libsystem_platform.dylib 0x00007fff6ecda5fd _sigtramp + 29 4 ??? 0x0000000000000000 0x0 + 0 5 Squeak 0x0000000101b2178d primitiveIndexOfAsciiInString + 123 6 Squeak 0x0000000101a5cd6d primitiveExternalCall + 228 7 Squeak 0x0000000101a8de00 slowPrimitiveResponse + 94 8 Squeak 0x0000000101a5b01b executeNewMethod + 91 9 Squeak 0x0000000101a5bd71 ceSendsupertonumArgs + 1024 10 ??? 0x00000001072fe1b0 0x0 + 4415545776 11 Squeak 0x0000000101a47fe2 interpret + 630 12 Squeak 0x0000000101ad9ff1 -[sqSqueakMainApplication runSqueak] + 393 13 Foundation 0x00007fff3727729b __NSFirePerformWithOrder + 360 14 CoreFoundation 0x00007fff34ae63c5 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23 15 CoreFoundation 0x00007fff34ae62f7 __CFRunLoopDoObservers + 457 16 CoreFoundation 0x00007fff34ae5895 __CFRunLoopRun + 874 17 CoreFoundation 0x00007fff34ae4ece CFRunLoopRunSpecific + 462 18 HIToolbox 0x00007fff33713abd RunCurrentEventLoopInMode + 292 19 HIToolbox 0x00007fff337136f4 ReceiveNextEventCommon + 359 20 HIToolbox 0x00007fff33713579 _BlockUntilNextEventMatchingListInModeWithFilter + 64 21 AppKit 0x00007fff31d5b829 _DPSNextEvent + 883 22 AppKit 0x00007fff31d5a070 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1352 23 AppKit 0x00007fff31d4bd7e -[NSApplication run] + 658 24 AppKit 0x00007fff31d1db86 NSApplicationMain + 777 25 libdyld.dylib 0x00007fff6eae1cc9 start + 1 Smalltalk stack dump: 0x7ffeee191bf8 M CompiledMethod(ByteArray)>indexOf:startingAt: 0x108056db0: a(n) CompiledMethod 0x7ffeee191c38 M CompiledMethod(SequenceableCollection)>indexOf: 0x108056db0: a(n) CompiledMethod 0x7ffeee191c70 M CompiledMethod(SequenceableCollection)>includes: 0x108056db0: a(n) CompiledMethod 0x7ffeee191ca8 M UndefinedObject>DoIt 0x107ce58e0: a(n) UndefinedObject 0x7ffeee191d00 I Compiler>evaluateCue:ifFail: 0x1074f25e0: a(n) Compiler 0x7ffeee191d58 I Compiler>evaluateCue:ifFail:logged: 0x1074f25e0: a(n) Compiler 0x7ffeee191db0 I Compiler>evaluate:in:to:environment:notifying:ifFail:logged: 0x1074f25e0: a(n) Compiler 0x7ffeee191e28 M [] in SmalltalkEditor(TextEditor)>evaluateSelectionAndDo: 0x1074f27e8: a(n) SmalltalkEditor 0x7ffeee191e60 M BlockClosure>on:do: 0x1074f2938: a(n) BlockClosure 0x7ffeee192950 I SmalltalkEditor(TextEditor)>evaluateSelectionAndDo: 0x1074f27e8: a(n) SmalltalkEditor 0x7ffeee192998 I SmalltalkEditor(TextEditor)>printIt 0x1074f27e8: a(n) SmalltalkEditor 0x7ffeee1929d8 I SmalltalkEditor(TextEditor)>printIt: 0x1074f27e8: a(n) SmalltalkEditor 0x7ffeee192a30 I SmalltalkEditor(TextEditor)>dispatchOnKeyboardEvent: 0x1074f27e8: a(n) SmalltalkEditor 0x7ffeee192a78 I SmalltalkEditor(TextEditor)>keyStroke: 0x1074f27e8: a(n) SmalltalkEditor 0x7ffeee192ab8 M [] in TextMorphForEditView(TextMorph)>keyStroke: 0x10745c8d8: a(n) TextMorphForEditView 0x7ffeee192b08 M TextMorphForEditView(TextMorph)>handleInteraction:fromEvent: 0x10745c8d8: a(n) TextMorphForEditView 0x7ffeee192b48 M TextMorphForEditView>handleInteraction:fromEvent: 0x10745c8d8: a(n) TextMorphForEditView 0x7ffeee192b98 M [] in TextMorphForEditView(TextMorph)>keyStroke: 0x10745c8d8: a(n) TextMorphForEditView 0x7ffeee192bd8 I StandardToolSet class>codeCompletionAround:textMorph:keyStroke: 0x1080b25b0: a(n) StandardToolSet class 0x7ffeee192c30 I ToolSet class>codeCompletionAround:textMorph:keyStroke: 0x1080aaeb8: a(n) ToolSet class 0x7ffeee192c78 M TextMorphForEditView(TextMorph)>keyStroke: 0x10745c8d8: a(n) TextMorphForEditView 0x7ffeee192cc8 I TextMorphForEditView>keyStroke: 0x10745c8d8: a(n) TextMorphForEditView 0x7ffeee192d18 I TextMorphForEditView(Morph)>handleKeystroke: 0x10745c8d8: a(n) TextMorphForEditView 0x7ffeee192d68 I TextMorphForEditView(TextMorph)>handleKeystroke: 0x10745c8d8: a(n) TextMorphForEditView 0x7ffeee192da0 M KeyboardEvent>sentTo: 0x1074f2bf0: a(n) KeyboardEvent 0x7ffeee192de0 M TextMorphForEditView(Morph)>handleEvent: 0x10745c8d8: a(n) TextMorphForEditView 0x7ffeee192e18 M TextMorphForEditView(Morph)>handleFocusEvent: 0x10745c8d8: a(n) TextMorphForEditView 0x7ffeee192e60 M MorphicEventDispatcher>doHandlingForFocusEvent:with: 0x1074f19f8: a(n) MorphicEventDispatcher 0x7ffeee186868 M MorphicEventDispatcher>dispatchFocusEvent:with: 0x1074f19f8: a(n) MorphicEventDispatcher 0x7ffeee1868a8 M TextMorphForEditView(Morph)>processFocusEvent:using: 0x10745c8d8: a(n) TextMorphForEditView 0x7ffeee1868e8 M TextMorphForEditView(Morph)>processFocusEvent: 0x10745c8d8: a(n) TextMorphForEditView 0x7ffeee186938 M [] in HandMorph>sendFocusEvent:to:clear: 0x108437960: a(n) HandMorph 0x7ffeee186978 M BlockClosure>ensure: 0x1074f1ad8: a(n) BlockClosure 0x7ffeee1869b8 M KeyboardEvent(MorphicEvent)>becomeActiveDuring: 0x1074f1830: a(n) KeyboardEvent 0x7ffeee186a08 M [] in HandMorph>sendFocusEvent:to:clear: 0x108437960: a(n) HandMorph 0x7ffeee186a48 M BlockClosure>ensure: 0x1074f1ca8: a(n) BlockClosure 0x7ffeee186a88 M HandMorph>becomeActiveDuring: 0x108437960: a(n) HandMorph 0x7ffeee186ad8 M [] in HandMorph>sendFocusEvent:to:clear: 0x108437960: a(n) HandMorph 0x7ffeee186b18 M BlockClosure>ensure: 0x1074f1e78: a(n) BlockClosure 0x7ffeee186b58 M PasteUpMorph>becomeActiveDuring: 0x108190d20: a(n) PasteUpMorph 0x7ffeee186ba0 M HandMorph>sendFocusEvent:to:clear: 0x108437960: a(n) HandMorph 0x7ffeee186bf8 M HandMorph>sendEvent:focus:clear: 0x108437960: a(n) HandMorph 0x7ffeee186c40 M HandMorph>sendKeyboardEvent: 0x108437960: a(n) HandMorph 0x7ffeee186c80 M HandMorph>handleEvent: 0x108437960: a(n) HandMorph 0x7ffeee186cd8 M HandMorph>processEvents 0x108437960: a(n) HandMorph 0x7ffeee186d10 M [] in WorldState>doOneCycleNowFor: 0x1083735e0: a(n) WorldState 0x7ffeee186d58 M Array(SequenceableCollection)>do: 0x107d0a660: a(n) Array 0x7ffeee186d90 M WorldState>handsDo: 0x1083735e0: a(n) WorldState 0x7ffeee186dd0 M WorldState>doOneCycleNowFor: 0x1083735e0: a(n) WorldState 0x7ffeee186e08 M WorldState>doOneCycleFor: 0x1083735e0: a(n) WorldState 0x7ffeee186e40 M PasteUpMorph>doOneCycle 0x108190d20: a(n) PasteUpMorph 0x7ffeee186e70 M [] in MorphicProject>spawnNewProcess 0x108551af8: a(n) MorphicProject 0x10ac31138 s [] in BlockClosure>newProcess Most recent primitives collect:from:to: value at: at: buildTreeFrom:maxDepth: buildTreeFrom:maxDepth: buildTreeFrom:maxDepth: buildTreeFrom:maxDepth: buildTreeFrom:maxDepth: new: second removeFirst parent: parent: parent: parent: replaceFrom:to:with:startingAt: replaceFrom:to:with:startingAt: size at: size at: at: at:put: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: bitLengthAt: bitLengthAt: bitLengthAt: maxCode maxCode maxCode bitLengthAt: bitLengthAt: bitLengthAt: bitLengthAt: bitLengthAt: bitLengthAt: bitLengthAt: bitLengthAt: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: value:value: with:do: with:do: with:do: with:do: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: bitPosition bitPosition bitPosition basicNew size on:from:to: on:from:to: at: nextBits:put: nextBits:put: nextBits:put: byteAt:put: byteAt:put: nextBytePut: bitXor: size replaceFrom:to:with:startingAt: size replaceFrom:to:with:startingAt: encodeLengthField: assert: assert: size size size size wordSize size at: at: at: perform: size createMethod:class:header: createMethod:class:header: createMethod:class:header: createMethod:class:header: createMethod:class:header: createMethod:class:header: at:put: at:put: at:put: objectAt: objectAt:put: literalAt: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: basicNew withArgs:executeMethod: someInstance **IncrementalGC** wait value wait value signal wait finalizeValues finalizeValues signal wait signal signal wait indexOfAscii:inString:startingAt: stack page bytes 4096 available headroom 1480 minimum unused headroom 1936 (Segmentation fault) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/512

3 6

← Newer
1
2
3
4
5
6
7
...
11
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev June 2020