ping @dtlewis290 @marceltaeumel
--
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c2841037fa9ed86a3a…
You are receiving this because you are subscribed to this thread.
Message ID: <OpenSmalltalk/opensmalltalk-vm/commit/c2841037fa9ed86a3a204b14fe6d0f808fa5f045/62242818(a)github.com>
I don't know how MUSL handles this case, maybe one should guard against that, if thats required.
That said, in this case it's probably better to forego the dyn-load part in the first place…
--
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c2841037fa9ed86a3a…
You are receiving this because you are subscribed to this thread.
Message ID: <OpenSmalltalk/opensmalltalk-vm/commit/c2841037fa9ed86a3a204b14fe6d0f808fa5f045/62242805(a)github.com>
- Adds some commentary to build files
- Pins macOS builds to `macos-10.15` because that has been our build platform for the past weeks; `macos-11` is the new default on GHA `macos-latest`
- Specialize filters for `building/**` in our GHA `.yml` files to reduce the number of actually needed builds
You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/609
-- Commit Summary --
* Improves path matching to avoid unnecessary builds. Pin mac builds to macos-10.15 for now until requested otherwise; "macos-latest" became macos-11 only recently. [ci skip]
* Add build job for macos64ARMv8.
-- File Changes --
M .github/workflows/extra-arm.yml (2)
M .github/workflows/extra.yml (4)
M .github/workflows/linux-arm.yml (10)
M .github/workflows/linux.yml (10)
A .github/workflows/macos-arm.yml (131)
M .github/workflows/macos.yml (6)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/609.patchhttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/609.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/609
You are receiving this because you are subscribed to this thread.
Message ID: <OpenSmalltalk/opensmalltalk-vm/pull/609(a)github.com>
Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: a82c72f884d9a5d893e92d779eb63700820fc560
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a82c72f884d9a5d893…
Author: Marcel Taeumel <marcel.taeumel(a)hpi.de>
Date: 2021-12-17 (Fri, 17 Dec 2021)
Changed paths:
M .github/workflows/extra-arm.yml
M .github/workflows/extra.yml
M .github/workflows/linux-arm.yml
M .github/workflows/linux.yml
M .github/workflows/macos.yml
Log Message:
-----------
Improves path matching to avoid unnecessary builds. Pin mac builds to macos-10.15 for now until requested otherwise; "macos-latest" became macos-11 only recently. [ci skip]
Commit: 7c761e7cf027bbc2cadc2ce7da6c163fa072074d
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7c761e7cf027bbc2ca…
Author: Marcel Taeumel <marcel.taeumel(a)hpi.de>
Date: 2021-12-17 (Fri, 17 Dec 2021)
Changed paths:
A .github/workflows/macos-arm.yml
Log Message:
-----------
Add build job for macos64ARMv8.
Commit: 9ca20bd3cf79ec66285270eaae9256dedfd23ef2
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9ca20bd3cf79ec6628…
Author: Marcel Taeumel <marcel.taeumel(a)hpi.de>
Date: 2021-12-20 (Mon, 20 Dec 2021)
Changed paths:
M .github/workflows/extra-arm.yml
M .github/workflows/extra.yml
M .github/workflows/linux-arm.yml
M .github/workflows/linux.yml
A .github/workflows/macos-arm.yml
M .github/workflows/macos.yml
Log Message:
-----------
Merge pull request #609 from marceltaeumel/marceltaeumel/gha-macos-arm
Adds builds for macos64ARMv8 to GHA
Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/27d2d9f0c76b...9c…
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi,
I have a question on the "classic VM" (from subversion) and the
"JPEGReadWriter2" for the pluginJPEGReadWriter2Plugin
For Debian / Ubuntu Linux a configure option was added recently to squeak,
--link-shared-lib
The idea here is to compile the VM with the systems provided library.
By default the directory platforms/Cross/plugins/JPEGReaderWriter2
contains a copy of the files of the libjpeg(-turbo?) library.
As a test, I have tried to compile on OpenIndiana and Slackware Linux,
with --link-shared-lib.
The compile works, the squeakvm links against -lpcre and -ljpeg.
BUT ... unfortunately on Slackware Linux 32bit it does not work :
The test from Example from http://wiki.squeak.org/squeak/4043
| jpgPicURL aStream |
jpgPicURL := 'https://upload.wikimedia.org/wikipedia/commons/thumb/c/ce/Quartz_Br%C3%A9si…'.
aStream := HTTPSocket httpGet: jpgPicURL.
(JPEGReadWriter2 formFromStream: aStream) asMorph openInHand
The above test works when building the VM without --link-shared-lib
but fails with I configure with --link-shared-lib.
In the first case an image is displayed, in the second case the VM starts,
the shared library libjpeg.so is loaded but nothing is displayed,
when I run the test from http://wiki.squeak.org/squeak/4043
On Slackware Linux 14.2 /usr/lib/libjpeg.so points to libjpeg.so.62
I have many questions ... (1) why is the JPEG plugin delivered in two variants
there is JPEG ReadWriter and a JPEG ReadWriter2.
Smalltalk listBuiltinModule:16.
Smalltalk listBuiltinModule:17.
(2) why is this plugin not built as an external module instead of builtinModule
(3) why not removing all copied files from platforms/Cross/plugins/JPEG*
and provide a cmake file there for the configuration of JPEG
I like the idea of using the systems provided library.
However I am not convinced the option OPT--link-shared-lib is the right way,
to do that in Squeak VM classic.
The option --link-shared-lib seems not a good name to me.
It is "too general' for something specific like --enable-jpeg or --disable-jpeg
(4) Is the author of that plugin or those plugins still maintaining the plugin,
using Squeak ?
(5) do Smalltalk systems like Cuis or Squeak really need a JPEG plugin ,
this seems something that could be optional instead of enabled by default
Regards,
David Stes
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJhv1PTAAoJENdFDkXGicizKyYH/2thJnqmR1M7FDl5fKanSTzu
hpHNLZoL45Nsz5CWLqxehrAQHZWZuU70izQWM8zyOadYLnpfFcFnDvAQkSv9H184
UqQQEk/Ic6AvEwm0obWemR8H4GhOVBT+mmlsN0GOZFoTcIM9Wqk4RvEeThZiUnaP
mWEGkdJnfNHkP3V/ZCvhjD0YOcwh35bUPtpuF9IISe6PtAVkk0+bgmv7Se1MIjgV
8/cjbYaaDqovKwhZRJ5LXVQb31R6AOFtzUBBBtofw/WBy9InYtH1mxliGYx/j1lP
E6whtYEWc0GA9VvN3PQ4Ge201NCMA7CygcBw5rhI3qSmuNKB0C9q7VDkG5oZbME=
=uE9J
-----END PGP SIGNATURE-----