Vm-dev May 2021

vm-dev@lists.squeakfoundation.org

21 participants
56 discussions

[OpenSmalltalk/opensmalltalk-vm] Fix include order (#562)
by Nicolas Cellier 02 Aug '21

02 Aug '21

This enables the linux builds again, while preserving windows and macos builds. That is a fix for https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/560 If this is compatible with TERF VM, then it should be merged ASAP, the builds are red for too long. (we'll have to inquire next point of failure...) You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/562 -- Commit Summary -- * always include <stdio.h> **BEFORE** defining fseeko/ftello * Discard the EXPORT from sqAssert.h for declaring VM functions * Make sure that config.h is included first * Generate source with VMMaker.oscog-nice.2957 so as to restore sqConfig.h inclusion at top * try and omit HAVE_CONFIG_H for compiling getVersion -- File Changes -- M platforms/Cross/plugins/B3DAcceleratorPlugin/sqOpenGLRenderer.c (3) M platforms/Cross/plugins/IA32ABI/xabicc.c (5) M platforms/Cross/plugins/SoundCodecPrims/sqSoundCodecPluginBasicPrims.c (4) M platforms/Cross/plugins/Squeak3D/b3dInit.c (3) M platforms/Cross/plugins/Squeak3D/b3dMain.c (3) M platforms/Cross/plugins/SurfacePlugin/SurfacePlugin.c (4) M platforms/Cross/vm/sqAssert.h (11) M platforms/Cross/vm/sqHeapMap.c (4) M platforms/Cross/vm/sqSCCSVersion.h (2) M platforms/Cross/vm/sqVirtualMachine.c (3) M platforms/unix/config/getversion.c (1) M platforms/unix/plugins/FileAttributesPlugin/faSupport.c (3) M platforms/unix/vm/aio.c (12) M platforms/unix/vm/sqUnixVMProfile.c (5) M platforms/win32/vm/sqPlatformSpecific.h (1) M spur64src/vm/cogit.h (2) M spur64src/vm/cogitARMv8.c (8) M spur64src/vm/cogitX64SysV.c (8) M spur64src/vm/cogitX64WIN64.c (8) M spur64src/vm/cointerp.c (49) M spur64src/vm/cointerp.h (4) M spur64src/vm/cointerpmt.c (31) M spur64src/vm/cointerpmt.h (3) M spur64src/vm/gcc3x-cointerp.c (49) M spur64src/vm/gcc3x-cointerpmt.c (31) M spurlowcode64src/vm/cogit.h (3) M spurlowcode64src/vm/cogitARMv8.c (16) M spurlowcode64src/vm/cogitX64SysV.c (12) M spurlowcode64src/vm/cogitX64WIN64.c (12) M spurlowcode64src/vm/cointerp.c (53) M spurlowcode64src/vm/cointerp.h (5) M spurlowcode64src/vm/gcc3x-cointerp.c (53) M spurlowcodesrc/vm/cogit.h (3) M spurlowcodesrc/vm/cogitARMv5.c (12) M spurlowcodesrc/vm/cogitIA32.c (12) M spurlowcodesrc/vm/cogitMIPSEL.c (16) M spurlowcodesrc/vm/cointerp.c (57) M spurlowcodesrc/vm/cointerp.h (5) M spurlowcodesrc/vm/gcc3x-cointerp.c (57) M spurlowcodestack64src/vm/gcc3x-interp.c (25) M spurlowcodestack64src/vm/interp.c (25) M spurlowcodestacksrc/vm/gcc3x-interp.c (25) M spurlowcodestacksrc/vm/interp.c (25) M spursista64src/vm/cogit.h (2) M spursista64src/vm/cogitARMv8.c (12) M spursista64src/vm/cogitX64SysV.c (8) M spursista64src/vm/cogitX64WIN64.c (8) M spursista64src/vm/cointerp.c (49) M spursista64src/vm/cointerp.h (4) M spursista64src/vm/gcc3x-cointerp.c (49) M spursistasrc/vm/cogit.h (2) M spursistasrc/vm/cogitARMv5.c (8) M spursistasrc/vm/cogitIA32.c (8) M spursistasrc/vm/cogitMIPSEL.c (14) M spursistasrc/vm/cointerp.c (49) M spursistasrc/vm/cointerp.h (2) M spursistasrc/vm/gcc3x-cointerp.c (49) M spursrc/vm/cogit.h (2) M spursrc/vm/cogitARMv5.c (8) M spursrc/vm/cogitIA32.c (8) M spursrc/vm/cogitMIPSEL.c (10) M spursrc/vm/cointerp.c (57) M spursrc/vm/cointerp.h (4) M spursrc/vm/cointerpmt.c (81) M spursrc/vm/cointerpmt.h (5) M spursrc/vm/gcc3x-cointerp.c (57) M spursrc/vm/gcc3x-cointerpmt.c (81) M spurstack64src/vm/gcc3x-interp.c (25) M spurstack64src/vm/interp.c (25) M spurstack64src/vm/validImage.c (17) M spurstacksrc/vm/gcc3x-interp.c (25) M spurstacksrc/vm/interp.c (25) M spurstacksrc/vm/validImage.c (17) M src/plugins/Squeak3D/Squeak3D.c (8) M src/vm/cogit.h (2) M src/vm/cogitARMv5.c (8) M src/vm/cogitIA32.c (8) M src/vm/cogitMIPSEL.c (12) M src/vm/cointerp.c (10) M src/vm/cointerp.h (2) M src/vm/gcc3x-cointerp.c (10) M stacksrc/vm/gcc3x-interp.c (12) M stacksrc/vm/interp.c (12) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/562.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/562.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/562

9 19

[OpenSmalltalk/opensmalltalk-vm] For epoll aio, close and reopen the epoll fd in forked child process (#552)
by David T Lewis 24 Jul '21

24 Jul '21

Factor the epoll initiation out of aioInit into new epollInit function and invoke it via pthread_atfork in the child process after a fork. Prevents misdelivery of events from the common kernel epoll structures. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/552 -- Commit Summary -- * For epoll aio, close and reopen the epoll fd in forked child process -- File Changes -- M platforms/unix/vm/aio.c (23) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/552.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/552.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/552

2 3

[OpenSmalltalk/opensmalltalk-vm] How to build on Win32 using WSL/Ubuntu | Missing headers (#510)
by Christoph Thiede 09 Jul '21

09 Jul '21

`build.win32x86/HowToBuild` describes how we can build the VM using cygwin. However, I have installed WSL instead. When running `mvm`, it gives me: ``` ../../platforms/win32/vm/sqWin32Utils.c:11:10: fatal error: Windows.h: No such file or directory ``` What do I have to do to enable mingw to find these header files? Any help is appreciated. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/510

7 20

VM Maker Inbox: VMMaker.oscog-eem.2765.mcz
by commits＠source.squeak.org 09 Jul '21

09 Jul '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/VMMaker.oscog-eem.2765.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2765 Author: eem Time: 23 June 2020, 6:41:19.556484 pm UUID: 91b9976e-60b9-4b5c-a2f8-b621dd454a07 Ancestors: VMMaker.oscog-eem.2764 Spur: Rewrite the revised followForwardedObjectFields:toDepth: soi it can be correctly inlined. Slang: Change the order of application of ensureConditionalAssignmentsAreTransformedIn: so it is always the last thing done in tryToInlineMethodsIn:. Straight-forward optimization of bindVariablesIn: in the common case of methods being inlined swith unchanged parameters. =============== Diff against VMMaker.oscog-eem.2764 =============== Item was changed: ----- Method: Spur32BitCoMemoryManager>>followForwardedObjectFields:toDepth: (in category 'as yet unclassified') ----- followForwardedObjectFields: objOop toDepth: depth "Follow pointers in the object to depth. Answer if any forwarders were found. How to avoid cyclic structures?? A temporary mark bit? eem 6/22/2020 no need since depth is always finite." <api> <inline: false> + | found fmt limit | - | oop found fmt | found := false. self assert: ((self isPointers: objOop) or: [self isOopCompiledMethod: objOop]). fmt := self formatOf: objOop. + limit := (self numPointerSlotsOf: objOop format: fmt) - 1. "It is essential to skip the first field of a method because it may be a reference to a Cog method in the method zone, not a real object at all." ((self isCompiledMethodFormat: fmt) ifTrue: [1] ifFalse: [0]) + to: limit + do: [:i| | oop | - to: (self numPointerSlotsOf: objOop format: fmt) - 1 - do: [:i| oop := self fetchPointer: i ofObject: objOop. (self isNonImmediate: oop) ifTrue: [(self isForwarded: oop) ifTrue: [found := true. oop := self followForwarded: oop. self storePointer: i ofObject: objOop withValue: oop]. (depth > 0 and: [(self hasPointerFields: oop) and: [self followForwardedObjectFields: oop toDepth: depth - 1]]) ifTrue: [found := true]]]. ^found! Item was changed: ----- Method: Spur64BitCoMemoryManager>>followForwardedObjectFields:toDepth: (in category 'forwarding') ----- followForwardedObjectFields: objOop toDepth: depth "Follow pointers in the object to depth. Answer if any forwarders were found. How to avoid cyclic structures?? A temporary mark bit? eem 6/22/2020 no need since depth is always finite." <api> <inline: false> + | found fmt limit | - | oop found fmt | found := false. self assert: ((self isPointers: objOop) or: [self isOopCompiledMethod: objOop]). fmt := self formatOf: objOop. + limit := (self numPointerSlotsOf: objOop format: fmt) - 1. "It is essential to skip the first field of a method because it may be a reference to a Cog method in the method zone, not a real object at all." ((self isCompiledMethodFormat: fmt) ifTrue: [1] ifFalse: [0]) + to: limit + do: [:i| | oop | - to: (self numPointerSlotsOf: objOop format: fmt) - 1 - do: [:i| oop := self fetchPointer: i ofObject: objOop. (self isNonImmediate: oop) ifTrue: [(self isForwarded: oop) ifTrue: [found := true. oop := self followForwarded: oop. self storePointer: i ofObject: objOop withValue: oop]. (depth > 0 and: [(self hasPointerFields: oop) and: [self followForwardedObjectFields: oop toDepth: depth - 1]]) ifTrue: [found := true]]]. ^found! Item was changed: ----- Method: TMethod>>exitVar:label:in: (in category 'inlining') ----- exitVar: exitVar label: exitLabel in: aCodeGen "Replace each return statement in this method with an assignment to the exit variable followed by either a return or a goto to the given label. Answer if a goto was generated." "Optimization: If exitVar is nil, the return value of the inlined method is not being used, so don't add the assignment statement." | labelUsed map elisions eliminateReturnSelfs | labelUsed := false. map := Dictionary new. elisions := Set new. "Conceivably one might ^self from a struct class and mean it. In most cases though ^self means `get me outta here, fast'. So unless this method is from a VMStruct class, elide any ^self's" eliminateReturnSelfs := ((definingClass inheritsFrom: VMClass) and: [definingClass isStructClass]) not and: [returnType = #void or: [returnType = #sqInt]]. parseTree nodesDo: [:node | | replacement | node isReturn ifTrue: [self transformReturnSubExpression: node toAssignmentOf: exitVar andGoto: exitLabel unless: eliminateReturnSelfs into: [:rep :labelWasUsed| replacement := rep. labelWasUsed ifTrue: [labelUsed := true]] in: aCodeGen. "replaceNodesIn: is strictly top-down, so any replacement for ^expr ifTrue: [...^fu...] ifFalse: [...^bar...] will prevent replacement of either ^fu or ^bar. The corollary is that ^expr ifTrue: [foo] ifFalse: [^bar] must be transformed into expr ifTrue: [^foo] ifFalse: [^bar]" (node expression isConditionalSend and: [node expression hasExplicitReturn]) ifTrue: [elisions add: node. (node expression args reject: [:arg| arg endsWithReturn]) do: [:nodeNeedingReturn| self transformReturnSubExpression: nodeNeedingReturn statements last toAssignmentOf: exitVar andGoto: exitLabel unless: eliminateReturnSelfs into: [:rep :labelWasUsed| replacement := rep. + labelWasUsed ifTrue: [labelUsed := true]] + in: aCodeGen. - labelWasUsed ifTrue: [labelUsed := true]]. map at: nodeNeedingReturn statements last put: replacement]] ifFalse: [map at: node put: (replacement ifNil: [TLabeledCommentNode new setComment: 'return ', node expression printString])]]]. map isEmpty ifTrue: [self deny: labelUsed. ^false]. "Now do a top-down replacement for all returns that should be mapped to assignments and gotos" parseTree replaceNodesIn: map. "Now it is safe to eliminate the returning ifs..." elisions isEmpty ifFalse: [| elisionMap | elisionMap := Dictionary new. elisions do: [:returnNode| elisionMap at: returnNode put: returnNode expression]. parseTree replaceNodesIn: elisionMap]. "Now flatten any new statement lists..." parseTree nodesDo: [:node| | list | (node isStmtList and: [node statements notEmpty and: [node statements last isStmtList]]) ifTrue: [list := node statements last statements. node statements removeLast; addAllLast: list]]. ^labelUsed! Item was changed: ----- Method: TMethod>>inlineFunctionCall:in: (in category 'inlining') ----- inlineFunctionCall: aSendNode in: aCodeGen "Answer the body of the called function, substituting the actual parameters for the formal argument variables in the method body. Assume caller has established that: 1. the method arguments are all substitutable nodes, and 2. the method to be inlined contains no additional embedded returns." | sel meth doNotRename argsForInlining substitutionDict | + aCodeGen maybeBreakForInlineOf: aSendNode in: self. sel := aSendNode selector. meth := (aCodeGen methodNamed: sel) copy. meth ifNil: [^self inlineBuiltin: aSendNode in: aCodeGen]. doNotRename := Set withAll: args. argsForInlining := aSendNode argumentsForInliningCodeGenerator: aCodeGen. meth args with: argsForInlining do: [ :argName :exprNode | exprNode isLeaf ifTrue: [doNotRename add: argName]]. (meth statements size = 2 and: [meth statements first isSend and: [meth statements first selector == #flag:]]) ifTrue: [meth statements removeFirst]. meth renameVarsForInliningInto: self except: doNotRename in: aCodeGen. meth renameLabelsForInliningInto: self. self addVarsDeclarationsAndLabelsOf: meth except: doNotRename. substitutionDict := Dictionary new: meth args size * 2. meth args with: argsForInlining do: [ :argName :exprNode | + (exprNode isVariable and: [exprNode name = argName]) ifFalse: + [substitutionDict at: argName put: exprNode]. - substitutionDict at: argName put: exprNode. (doNotRename includes: argName) ifFalse: [locals remove: argName]]. meth parseTree bindVariablesIn: substitutionDict. ^meth parseTree endsWithReturn ifTrue: [meth parseTree copyWithoutReturn] ifFalse: [meth parseTree]! Item was changed: ----- Method: TMethod>>tryToInlineMethodsIn: (in category 'inlining') ----- tryToInlineMethodsIn: aCodeGen "Expand any (complete) inline methods sent by this method. Set the complete flag when all inlining has been done. Answer if something was inlined." | didSomething statementLists | "complete ifTrue: [^false]." self definedAsMacro ifTrue: [complete ifTrue: [^false]. ^complete := true]. - self ensureConditionalAssignmentsAreTransformedIn: aCodeGen. didSomething := self tryToInlineMethodStatementsIn: aCodeGen statementListsInto: [:stmtLists| statementLists := stmtLists]. didSomething := (self tryToInlineMethodExpressionsIn: aCodeGen) or: [didSomething]. + self ensureConditionalAssignmentsAreTransformedIn: aCodeGen. didSomething ifTrue: [writtenToGlobalVarsCache := nil]. complete ifFalse: [self checkForCompletenessIn: aCodeGen. complete ifTrue: [didSomething := true]]. "marking a method complete is progress" ^didSomething! Item was changed: ----- Method: TStmtListNode>>bindVariablesIn: (in category 'transformations') ----- bindVariablesIn: aDictionary + aDictionary notEmpty ifTrue: + [statements := statements collect: [:s| s bindVariablesIn: aDictionary]]! - statements := statements collect: [ :s | s bindVariablesIn: aDictionary ].!

2 1

Reed Solomon plugins & performance slow down
by Robert Withers 03 Jun '21

03 Jun '21

Hey all'y'all, I got the plugins working correctly. Published to Cryptography. The plugins are attached. Unfortunately profiling indicates a slow down. The leaves did change from GaloisField methods to GaloisFieldPoly methods. I will work on pluginizing the GFPoly methods, such as #evaluateAt: & #multiplyByMonomialDegree:coefficient:... Here are the results without plugins (135 seconds): > WITHOUT PLUGINS > > - 132032 tallies, 135390 msec. > > **Tree** > -------------------------------- > Process: (40) 57626: nil > -------------------------------- > > **Leaves** > 16.9% {22843ms} RSFECGenericGF>>exp: > 9.2% {12450ms} RSFECGenericGF>>maskValue: > 8.6% {11659ms} RSFECGenericGF>>addOrSubtract:by: > 7.2% {9806ms} RSFECGenericGF>>log: > 6.6% {8958ms} RSFECGenericGF>>normalizeIndex: > 4.9% {6578ms} RSFECGenericGF>>multiply:by: > 2.3% {3130ms} RSErasureGalois>>maskValue: > 2.3% {3118ms} RSFECGenericGFPoly>>evaluateAt: > 1.6% {2175ms} RSErasureGalois>>normalizeIndex: > 1.3% {1718ms} RSFECGenericGFPoly>>addOrSubtractPoly: > 1.3% {1702ms} RSFECGenericGFPoly>>multiplyByMonomialDegree:coefficient: > 1.2% {1606ms} RSErasureGalois>>log: > 1.1% {1516ms} RSErasureGalois>>galoisMultiply:by: And here are the results with plugins (152 seconds): > WITH PLUGINS > > - 149040 tallies, 152531 msec. > > **Tree** > -------------------------------- > Process: (40) 89223: nil > -------------------------------- > > **Leaves** > 27.9% {42565ms} RSFECGenericGFWithPlugin>>addOrSubtract:by: > 17.3% {26440ms} RSFECGenericGFPoly>>evaluateAt: > 8.5% {12926ms} RSFECGenericGFWithPlugin>>maskValue: > 7.3% {11062ms} RSFECGenericGFPoly>>multiplyByMonomialDegree:coefficient: > 6.5% {9854ms} RSFECGenericGFPoly>>addOrSubtractPoly: > 5.6% {8598ms} RSFECGenericGFWithPlugin>>multiply:by: > 2.6% {4032ms} RSErasureGaloisWithPlugin>>galoisMultiply:by: > 2.4% {3601ms} RSErasureGaloisWithPlugin>>addOrSubtract:by: > 2.1% {3137ms} RSErasureGaloisWithPlugin>>maskValue: > 1.6% {2436ms} RSFECGenericGFPoly>>multiplyPoly: -- --- Kindly, Robert

2 13

Build failed: opensmalltalk-vm 1.0.2448
by AppVeyor 30 May '21

30 May '21

1 0

[OpenSmalltalk/opensmalltalk-vm] 1b31cb: Use export to simplify windows Makefiles. Fix BIT...
by Eliot Miranda 30 May '21

30 May '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 1b31cb8634e4dacd2487678e882d33af718bdca5 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1b31cb8634e4dacd24… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-05-30 (Sun, 30 May 2021) Changed paths: M build.win32x86/common/Makefile M build.win32x86/common/Makefile.lib.extra M build.win32x86/common/Makefile.msvc M build.win32x86/common/Makefile.msvc.flags M build.win32x86/common/Makefile.msvc.plugin M build.win32x86/common/Makefile.msvc.tools M build.win32x86/common/Makefile.plugin M build.win32x86/common/Makefile.tools M build.win64x64/common/Makefile M build.win64x64/common/Makefile.lib.extra M build.win64x64/common/Makefile.msvc M build.win64x64/common/Makefile.msvc.flags M build.win64x64/common/Makefile.msvc.plugin M build.win64x64/common/Makefile.msvc.tools M build.win64x64/common/Makefile.plugin M build.win64x64/common/Makefile.tools M platforms/win32/plugins/Mpeg3Plugin/Makefile.msvc Log Message: ----------- Use export to simplify windows Makefiles. Fix BIT_IDENTICAL_FLOATING_POINT build for MSVC Makefiles (have no time to test non-MSVC currently).

1 0

Build failed: opensmalltalk-vm 1.0.2447
by AppVeyor 30 May '21

30 May '21

1 0

[OpenSmalltalk/opensmalltalk-vm] 1cdfb3: Use export in Mac Makefiles to reduce command-line...
by Eliot Miranda 30 May '21

30 May '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 1cdfb34b842dae8d63febab9271b05074ab94c79 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1cdfb34b842dae8d63… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-05-29 (Sat, 29 May 2021) Changed paths: M build.macos32x86/common/Makefile.app M build.macos32x86/common/Makefile.vm M build.macos64ARMv8/common/Makefile.app M build.macos64ARMv8/common/Makefile.vm M build.macos64x64/common/Makefile.app M build.macos64x64/common/Makefile.vm Log Message: ----------- Use export in Mac Makefiles to reduce command-line args in submake invocations.

1 0

trying to use kdbg with the build.debug vm
by Robert Withers 30 May '21

30 May '21

I d/l and made kdbg. I can run it and load the debug vm. How could I set a breakpoint in my RSFECPlugin.c code, starting with primitiveExp() such that it will break when I call it from Squeak? -- --- Kindly, Robert

1 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev May 2021