Vm-dev August 2021

vm-dev@lists.squeakfoundation.org

17 participants
161 discussions

VM Maker: VMMaker.oscog-eem.3012.mcz
by commits＠source.squeak.org 02 Aug '21

02 Aug '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3012.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3012 Author: eem Time: 1 August 2021, 11:22:35.709916 pm UUID: b743cd66-0506-49a9-a445-95d97e2ab623 Ancestors: VMMaker.oscog-eem.3011 Cogit: Fix a Slang slip with CogARMv8Compiler>>computeMaximumSize. USe SP rather than NativeSPReg within CogARMv8Compiler, as NativeSPReg is really for the outside world (the Cogit's world). =============== Diff against VMMaker.oscog-eem.3011 =============== Item was changed: ----- Method: CogARMv8Compiler>>computeMaximumSize (in category 'generate machine code') ----- computeMaximumSize "Because we don't use Thumb, each ARMv8 instruction has 4 bytes. Several abstract opcodes need more than one instruction. Instructions that refer to constants and/or literals depend on literals being stored out-of-line or encoded in immediate instruction fields (i.e. we only support OutOfLineLiteralsManager. N.B. The ^N forms are to get around the old bytecode compiler's long branch limits which are exceeded when each case jumps around the otherwise." opcode caseOf: { "Noops & Pseudo Ops" [Label] -> [^0]. [Literal] -> [^self literalSize]. [AlignmentNops] -> [^(operands at: 0) - 4]. "Control" [CallFull] -> [^8]. [JumpFull] -> [^8]. [JumpLongZero] -> [^8]. [JumpLongNonZero] -> [^8]. [JumpMulOverflow] -> [^8]. [JumpNoMulOverflow] -> [^8]. [JumpFPOrdered] -> [^8]. [JumpFPUnordered] -> [^8]. [RetN] -> [^(operands at: 0) = 0 ifTrue: [4] ifFalse: [8]]. [NativeRetN] -> [^(operands at: 0) = 0 ifTrue: [4] ifFalse: [8]]. "Arithmetic" [AddCqR] -> [^self isPossiblyShiftableNegatableImm12: (operands at: 0) signedIntFromLong64 ifTrue: [:ign|4] ifFalse: [8]]. [AddCqRR] -> [^self isPossiblyShiftableNegatableImm12: (operands at: 0) signedIntFromLong64 ifTrue: [:ign|4] ifFalse: [8]]. [CmpCqR] -> [^self isPossiblyShiftableNegatableImm12: (operands at: 0) signedIntFromLong64 ifTrue: [:ign|4] ifFalse: [8]]. [SubCqR] -> [^self isPossiblyShiftableNegatableImm12: (operands at: 0) signedIntFromLong64 ifTrue: [:ign|4] ifFalse: [8]]. [LoadEffectiveAddressMwrR] -> [^self isPossiblyShiftableNegatableImm12: (operands at: 0) signedIntFromLong64 ifTrue: [:ign|4] ifFalse: [8]]. [AndCqR] -> [^self isImmNImmSImmREncodableBitmask: (operands at: 0) ifTrue: [:n :imms :immr|4] ifFalse:[8]]. [AndCqRR] -> ["N.B. For three operand logical ops only support AndCqRR with a NativeSPReg target, used for alignment purposes." + ^self isImmNImmSImmREncodableBitmask: (operands at: 0) + ifTrue: [:n :imms :immr| (operands at: 2) = SP ifTrue: [8] ifFalse: [4]] + ifFalse:[(operands at: 2) = SP ifTrue: [12] ifFalse: [8]]]. - ^(self isImmNImmSImmREncodableBitmask: (operands at: 0) ifTrue: [:n :imms :immr|4] ifFalse:[8]) - + ((operands at: 2) = NativeSPReg ifTrue: [4] ifFalse: [0])]. [OrCqR] -> [^self isImmNImmSImmREncodableBitmask: (operands at: 0) ifTrue: [:n :imms :immr|4] ifFalse:[8]]. [OrCqRR] -> [^self isImmNImmSImmREncodableBitmask: (operands at: 0) ifTrue: [:n :imms :immr|4] ifFalse:[8]]. [TstCqR] -> [^self isImmNImmSImmREncodableBitmask: (operands at: 0) ifTrue: [:n :imms :immr|4] ifFalse:[8]]. [XorCqR] -> [^self isImmNImmSImmREncodableBitmask: (operands at: 0) ifTrue: [:n :imms :immr|4] ifFalse:[8]]. [AddCwR] -> [^8]. [AndCwR] -> [^8]. [CmpCwR] -> [^8]. [CmpC32R] -> [^8]. [OrCwR] -> [^8]. [SubCwR] -> [^8]. [XorCwR] -> [^8]. [SubRR] -> [^(operands at: 0) = SP ifTrue: [8] ifFalse: [4]]. [SubRRR] -> [^(operands at: 0) = SP ifTrue: [8] ifFalse: [4]]. "ARMv8 Specific Arithmetic" [MulOverflowRRR] -> [^12]. "Data Movement" [MoveAwR] -> [^((self isAddressRelativeToVarBase: (operands at: 0)) or: [cogit addressIsInCurrentCompilation: (operands at: 0)]) ifTrue: [(operands at: 1) ~= SP ifTrue: [4] ifFalse: [8]] ifFalse: [(operands at: 1) ~= SP ifTrue: [8] ifFalse: [12]]]. [MoveRAw] -> [^((self isAddressRelativeToVarBase: (operands at: 1)) or: [cogit addressIsInCurrentCompilation: (operands at: 1)]) ifTrue: [(operands at: 0) ~= SP ifTrue: [4] ifFalse: [8]] ifFalse: [(operands at: 0) ~= SP ifTrue: [8] ifFalse: [12]]]. [MoveAwRR] -> [self assert: (self isAddressRelativeToVarBase: (operands at: 0)). ^((operands at: 1) = SP or: [(operands at: 2) = SP]) ifTrue: [8] ifFalse: [4]]. [MoveRRAw] -> [self assert: (self isAddressRelativeToVarBase: (operands at: 2)). ^((operands at: 0) = SP or: [(operands at: 1) = SP]) ifTrue: [8] ifFalse: [4]]. [MoveAbR] -> [^(self isAddressRelativeToVarBase: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. [MoveRAb] -> [^(self isAddressRelativeToVarBase: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. [MoveMwrR] -> [^(self isImm12orImm9offset: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. [MoveRMwr] -> [^(self isImm12orImm9offset: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. [MoveM32rR] -> [^(self isImm12orImm9offset: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. [MoveRM32r] -> [^(self isImm12orImm9offset: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. [MoveM16rR] -> [^(self isImm12orImm9offset: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. [MoveRM16r] -> [^(self isImm12orImm9offset: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. [MoveMbrR] -> [^(self isImm12orImm9offset: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. [MoveRMbr] -> [^(self isImm12orImm9offset: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. [MoveM64rRd] -> [^(self isUnsigned12BitMultipleOf8: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. [MoveRdM64r] -> [^(self isUnsigned12BitMultipleOf8: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. [PushCw] -> [^8]. [PushCq] -> [^8]. } otherwise: [^4]. ^0 "to keep C compiler quiet" ! Item was changed: ----- Method: CogARMv8Compiler>>concretizeLogicalOp:CqRDest: (in category 'generate machine code - concretize') ----- concretizeLogicalOp: op CqRDest: destReg "AND (immediate) - 64-bit variant on page C6-775 ORR (immediate) - 64-bit variant on page C6-1125 EOR (immediate) - 64-bit variant on page C6-896 ANDS (immediate) - 64-bit variant on page C6-779 C6.2.329 TST (immediate) C6-1346" <inline: false> | srcReg constant effectiveDestReg offset | constant := operands at: 0. srcReg := operands at: 1. "N.B. For three operand logical ops only support AndCq: const R: reg R: NativeSPReg, which is used for alignment." + effectiveDestReg := (opcode = AndCqRR and: [destReg = SP]) ifTrue: [RISCTempReg] ifFalse: [destReg]. - effectiveDestReg := (opcode = AndCqRR and: [destReg = NativeSPReg]) ifTrue: [RISCTempReg] ifFalse: [destReg]. self isImmNImmSImmREncodableBitmask: constant ifTrue: [:n :imms :immr| machineCode at: 0 put: 2r1001001 << 25 + (op << 29) + (n << 22) + (immr << 16) + (imms << 10) + (srcReg << 5) + effectiveDestReg. offset := 4] ifFalse: [offset := self emitMoveCw: constant intoR: RISCTempReg at: 0. "OPC N 00 0 AND (shifted register) - 64-bit variant on page C6-777 00 1 BIC (shifted register) - 64-bit variant on page C6-808 01 0 ORR (shifted register) - 64-bit variant on page C6-1127 01 1 ORN (shifted register) - 64-bit variant on page C6-1123 10 0 EOR (shifted register) - 64-bit variant on page C6-898 10 1 EON (shifted register) - 64-bit variant on page C6-894 11 0 ANDS (shifted register) - 64-bit variant on page C6-781 11 0 BICS (shifted register) - 64-bit variant on page C6-810" machineCode at: offset // 4 put: 2r1000101 << 25 + (op << 29) + (RISCTempReg << 16) + (srcReg << 5) + effectiveDestReg. offset := offset + 4]. + (opcode = AndCqRR and: [destReg = SP]) ifFalse: - (opcode = AndCqRR and: [destReg = NativeSPReg]) ifFalse: [^offset]. machineCode at: offset // 4 put: (self movern: effectiveDestReg rd: destReg). ^offset + 4 "cogit processor disassembleInstructionAt: 0 In: machineCode object" "cogit processor disassembleInstructionAt: 4 In: machineCode object" "cogit processor disassembleInstructionAt: 8 In: machineCode object"! Item was changed: ----- Method: CogARMv8Compiler>>concretizeNativeRetN (in category 'generate machine code - concretize processor-specific') ----- concretizeNativeRetN "Will get inlined into concretizeAt: switch." <var: #offset type: #sqInt> <inline: true> | offset | offset := operands at: 0. "C6.2.218 RET p1147" offset = 0 ifTrue: [machineCode at: 0 put: 2r1101011001 << 22 + (XZR << 16) + (LR << 5). ^4]. "C6.2.4 ADD (immediate) p761" machineCode + at: 0 put: (self addrn: SP rd: SP imm: offset shiftBy12: false); - at: 0 put: (self addrn: NativeSPReg rd: NativeSPReg imm: offset shiftBy12: false); at: 1 put: 2r1101011001 << 22 + (XZR << 16) + (LR << 5). ^8! Item was changed: ----- Method: CogARMv8Compiler>>genLoadCStackPointers (in category 'smalltalk calling convention') ----- genLoadCStackPointers "Load the frame and stack pointer registers with those of the C stack, effecting a switch to the C stack. Used when machine code calls into the CoInterpreter run-time (e.g. to invoke interpreter primitives). Override to try and use MoveAwRR/ldp" cogit cStackPointerAddress + 8 = cogit cFramePointerAddress ifTrue: [cogit gen: MoveAwRR operand: cogit cStackPointerAddress + operand: SP + operand: FP. - operand: NativeSPReg - operand: FPReg. ^0]. ^super genLoadCStackPointers! Item was changed: ----- Method: CogARMv8Compiler>>genLoadNativeSPRegWithAlignedSPReg (in category 'smalltalk calling convention') ----- genLoadNativeSPRegWithAlignedSPReg + cogit AndCq: (objectMemory wordSize * 2 - 1) bitInvert R: SPReg R: SP! - cogit AndCq: (objectMemory wordSize * 2 - 1) bitInvert R: SPReg R: NativeSPReg!

1 0

[OpenSmalltalk/opensmalltalk-vm] 4adbe5: CogVM source as per VMMaker.oscog-eem.3011
by Eliot Miranda 02 Aug '21

02 Aug '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 4adbe56d3b850524689b6d893e5cb28c6e9e82c4 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/4adbe56d3b85052468… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-08-01 (Sun, 01 Aug 2021) Changed paths: M spur64src/vm/cogit.h M spur64src/vm/cogitARMv8.c M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/cointerpmt.c M spur64src/vm/cointerpmt.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/gcc3x-cointerpmt.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitARMv8.c M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitARMv8.c M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/cointerpmt.c M spursrc/vm/cointerpmt.h M spursrc/vm/gcc3x-cointerp.c M spursrc/vm/gcc3x-cointerpmt.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstack64src/vm/validImage.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M spurstacksrc/vm/validImage.c M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c M src/plugins/SqueakFFIPrims/ARM64FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/gcc3x-cointerp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3011 Cogit: Get the stack adjustment after primitive success right for FastCPrimitiveFlag primitives, with or without the FastCPrimitiveAlignForFloatsFlag. Support a FastCPrimitiveAlignForFloatsFlag to accompany FastCPrimitiveFlag. Use the facility in primitiveFFI{Double,Float}At[Put]. On win32 clang emits instructions that insist on at least a 16 byte aligned stack. Hence identify fast machine code primitives with the FastCPrimitiveUseCABIFlag flag, refactor compileOnStackExternalPrimitive: to compileOnStackExternalPrimitive:flags:, extend the set of PrimCall flags, etc. Remember to set the native stack pointer for a FastCPrimitive on ARMv8. This is almost certainly the cause of current Cog crashes on ARMv8.

1 0

VM Maker: VMMaker.oscog-eem.3011.mcz
by commits＠source.squeak.org 02 Aug '21

02 Aug '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3011.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3011 Author: eem Time: 1 August 2021, 10:51:32.195381 pm UUID: c31b5783-0c4c-472a-a602-4eeb7922c5cb Ancestors: VMMaker.oscog-eem.3010 Cogit: Get the stack adjustment after primitive success right for FastCPrimitiveFlag primitives, with or without the FastCPrimitiveAlignForFloatsFlag. =============== Diff against VMMaker.oscog-eem.3010 =============== Item was changed: ----- Method: CogAbstractInstruction>>genLoadStackPointersForFastPrimCall: (in category 'smalltalk calling convention') ----- genLoadStackPointersForFastPrimCall: spareReg "Switch back to the Smalltalk stack where there may be a C return address on top of stack below the last primitive argument. Assign SPReg first because typically it is used immediately afterwards." self hasLinkRegister ifTrue: [self genLoadStackPointers] ifFalse: [cogit MoveAw: cogit stackPointerAddress R: spareReg; "N.B. dont use SubCq:R:R: since it may generate MoveR:spareRegR:SPReg;SubCq:wordSize R:SPReg + which allows for the ret addr to be smashed by an interrupt between the two instructions." - which allows for the ret addr to be smashed by an interrupt between the two insructions." SubCq: objectMemory wordSize R: spareReg; MoveR: spareReg R: SPReg; MoveAw: cogit framePointerAddress R: FPReg]. ^0! Item was changed: ----- Method: SimpleStackBasedCogit>>compileOnStackExternalPrimitive:flags: (in category 'primitive generators') ----- compileOnStackExternalPrimitive: primitiveRoutine flags: flags "Compile a fast call of a C primitive using the current stack page, avoiding the stack switch except on failure. This convention still uses stackPointer and argumentCount to access operands. Push all operands to the stack, assign stackPointer, argumentCount, and zero primFailCode. Make the call (saving a LinkReg if required). Test for failure and return. On failure on Spur, if there is an accessor depth, assign framePointer and newMethod, do the stack switch, call checkForAndFollowForwardedPrimitiveState, and loop back if forwarders are found. Fall through to frame build." <var: #primitiveRoutine declareC: 'void (*primitiveRoutine)(void)'> | jmp retry calleeSavedReg | + self assert: (objectRepresentation hasSpurMemoryManagerAPI and: [flags anyMask: PrimCallOnSmalltalkStack]). - self assert: (flags anyMask: PrimCallOnSmalltalkStack). "Clear the primFailCode and set argumentCount" self MoveCq: 0 R: TempReg. self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. methodOrBlockNumArgs ~= 0 ifTrue: [self MoveCq: methodOrBlockNumArgs R: TempReg]. self MoveR: TempReg Aw: coInterpreter argumentCountAddress. self genExternalizeStackPointerForFastPrimitiveCall. backEnd hasLinkRegister ifTrue: [self PushR: LinkReg]. retry := self Label. calleeSavedReg := NoReg. (SPReg ~= NativeSPReg and: [(self isCalleeSavedReg: SPReg) not]) ifTrue: [calleeSavedReg := self availableRegisterOrNoneIn: ABICalleeSavedRegisterMask. self deny: calleeSavedReg = NoReg. self MoveR: SPReg R: calleeSavedReg]. (flags anyMask: PrimCallOnSmalltalkStackAlign2x) ifTrue: [self AndCq: (objectMemory wordSize * 2 - 1) bitInvert R: SPReg R: NativeSPReg] ifFalse: [SPReg ~= NativeSPReg ifTrue: [backEnd genLoadNativeSPRegWithAlignedSPReg]]. self CallFullRT: primitiveRoutine. self MoveAw: coInterpreter primFailCodeAddress R: TempReg. calleeSavedReg ~= NoReg ifTrue: [self MoveR: calleeSavedReg R: SPReg]. self CmpCq: 0 R: TempReg. jmp := self JumpNonZero: 0. + "At this point the primitive has cut back stackPointer to point to the result. + The original retpc is (argumentCount + 1) words beneath it." + self MoveAw: coInterpreter stackPointerAddress R: TempReg. + self MoveMw: (methodOrBlockNumArgs + 1 * objectMemory wordSize) negated + r: TempReg + R: (backEnd hasLinkRegister ifTrue: [LinkReg] ifFalse: [ClassReg]). + self MoveR: TempReg R: SPReg. backEnd hasLinkRegister + ifTrue: [self PopR: ReceiverResultReg] "i.e. get result" + ifFalse: + [self MoveMw: 0 r: TempReg R: ReceiverResultReg; + MoveR: ClassReg Mw: 0 r: TempReg]. "i.e. get result and restore retpc" - ifTrue: [self PopR: LinkReg] - ifFalse: [self PopR: TempReg]. "i.e. save retpc" - self MoveAw: coInterpreter stackPointerAddress R: SPReg. - self PopR: ReceiverResultReg. - backEnd hasLinkRegister ifFalse: [self PushR: TempReg]. "i.e. restore retpc" self RetN: 0. jmp jmpTarget: self Label. + (coInterpreter accessorDepthForExternalPrimitiveMethod: methodObj) >= 0 + ifTrue: + [| skip | + "Given that following primitive state to the accessor depth is recursive, we're asking for + trouble if we run the fixup on the Smalltalk stack page. Run it on the full C stack instead. + This won't be a performance issue since primitive failure should be very rare." + self MoveR: FPReg Aw: coInterpreter framePointerAddress. + self MoveCw: primitiveRoutine asInteger R: TempReg. + self MoveR: TempReg Aw: coInterpreter primitiveFunctionPointerAddress. + self genLoadCStackPointersForPrimCall. + methodLabel addDependent: + (self annotateAbsolutePCRef: + (self MoveCw: methodLabel asInteger R: ClassReg)). + self MoveMw: (self offset: CogMethod of: #methodObject) r: ClassReg R: TempReg. + self MoveR: TempReg Aw: coInterpreter newMethodAddress. + self CallFullRT: (self cCode: [#checkForAndFollowForwardedPrimitiveState asUnsignedIntegerPtr] + inSmalltalk: [self simulatedTrampolineFor: #checkForAndFollowForwardedPrimitiveState]). + backEnd genLoadStackPointersForFastPrimCall: ClassReg. + self CmpCq: 0 R: ABIResultReg. + skip := self JumpZero: 0. + self MoveCq: 0 R: TempReg. + self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. + self Jump: retry. + skip jmpTarget: self Label] + ifFalse: "must reload SPReg to undo any alignment change," + [(flags anyMask: PrimCallOnSmalltalkStackAlign2x) ifTrue: + [backEnd genLoadStackPointersForFastPrimCall: ClassReg]]. - (objectRepresentation hasSpurMemoryManagerAPI - and: [(coInterpreter accessorDepthForExternalPrimitiveMethod: methodObj) >= 0]) ifTrue: - [| skip | - "Given that following primitive state to the accessor depth is recursive, we're asking for - trouble if we run the fixup on the Smalltalk stack page. Run it on the full C stack instead. - This won't be a performance issue since primitive failure should be very rare." - self MoveR: FPReg Aw: coInterpreter framePointerAddress. - self MoveCw: primitiveRoutine asInteger R: TempReg. - self MoveR: TempReg Aw: coInterpreter primitiveFunctionPointerAddress. - self genLoadCStackPointersForPrimCall. - methodLabel addDependent: - (self annotateAbsolutePCRef: - (self MoveCw: methodLabel asInteger R: ClassReg)). - self MoveMw: (self offset: CogMethod of: #methodObject) r: ClassReg R: TempReg. - self MoveR: TempReg Aw: coInterpreter newMethodAddress. - self CallFullRT: (self cCode: [#checkForAndFollowForwardedPrimitiveState asUnsignedIntegerPtr] - inSmalltalk: [self simulatedTrampolineFor: #checkForAndFollowForwardedPrimitiveState]). - backEnd genLoadStackPointersForFastPrimCall: ClassReg. - self CmpCq: 0 R: ABIResultReg. - skip := self JumpZero: 0. - self MoveCq: 0 R: TempReg. - self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. - self Jump: retry. - skip jmpTarget: self Label]. "Finally remember to reload ReceiverResultReg if required. Even if arguments have been pushed, the prolog sequence assumes it is live." (self register: ReceiverResultReg isInMask: ABICallerSavedRegisterMask) ifTrue: [self MoveMw: (backEnd hasLinkRegister ifTrue: [methodOrBlockNumArgs] ifFalse: [methodOrBlockNumArgs + 1]) * objectMemory wordSize r: SPReg R: ReceiverResultReg]. ^0!

1 0

VM Maker: VMMaker.oscog-eem.3010.mcz
by commits＠source.squeak.org 02 Aug '21

02 Aug '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3010.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3010 Author: eem Time: 1 August 2021, 3:04:23.430035 pm UUID: db70c36d-4f15-4c05-b173-491815f4b8a7 Ancestors: VMMaker.oscog-eem.3009 Support a FastCPrimitiveAlignForFloatsFlag to accompany FastCPrimitiveFlag. Use the facility in primitiveFFI{Double,Float}At[Put]. On win32 clang emits instructions that insist on a more aligned stack (in this commit I'm hoping 16 byte alignment is sufficient; it may prove to be more). Hence identify fast machine code primitives with the FastCPrimitiveUseCABIFlag flag, refactor compileOnStackExternalPrimitive: to compileOnStackExternalPrimitive:flags:, extend the set of PrimCall flags, etc. Remember to set the native stack pointer for a FastCPrimitive on ARMv8. This is almost certainly the cause of current Cog crashes on ARMv8. Simulation: Make addressOf:put: support multiple byte writes. It will call the put block once for every byte, but the last one will at least include all the data written. This allows primitiveFFI{Double,Float}At[Put] to simulate correctly. In-Image Compilation: take baby steps towards supporting in-image compilation of FastCPrimitive methods. The issue is how to get functionPointerForCompiledMethod:primitiveIndex:primitivePropertyFlagsInto: to work with the in-image framework. This probably needs CurrentImageCoInterpreterFacade to have a CurrentImageObjectMemoryFacade to intercept memory accesses. =============== Diff against VMMaker.oscog-eem.3009 =============== Item was added: + ----- Method: CArray>>asVoidPointer (in category 'converting') ----- + asVoidPointer + ^self! Item was changed: ----- Method: CArray>>coerceTo:sim: (in category 'converting') ----- coerceTo: cTypeString sim: interpreterSimulator ^cTypeString caseOf: { ['int'] -> [self ptrAddress]. ['float *'] -> [self asSingleFloatAccessor]. ['double *'] -> [self asDoubleFloatAccessor]. ['sqInt *'] -> [self shallowCopy unitSize: interpreter bytesPerOop; beSigned]. ['unsigned int *'] -> [self shallowCopy unitSize: 4; beUnsigned]. ['int *'] -> [self shallowCopy unitSize: 4; beSigned]. ['unsigned short *'] -> [self shallowCopy unitSize: 2; beUnsigned]. ['short *'] -> [self shallowCopy unitSize: 2; beSigned]. ['unsigned char *'] -> [self shallowCopy unitSize: 1; beUnsigned]. ['char *'] -> [self shallowCopy unitSize: 1; beUnsigned]. "C is ambivalent on the issue; sigh... SocketPlugin assumes unsigned" ['unsigned'] -> [self ptrAddress]. ['sqInt'] -> [self ptrAddress]. ['usqInt'] -> [self ptrAddress]. + ['sqIntptr_t'] -> [self] "this is used, in e.g. ffiAddressOf:startingAt:size: to coerce a pointer to an integer; it does not imply a real conversion. it is just to be able to pass the pointer as an integer" }! - ['sqIntptr_t'] -> [self shallowCopy unitSize: interpreter bytesPerOop; yourself] }! Item was changed: ----- Method: CCodeGenerator>>generateBitInvert:on:indent: (in category 'C translation') ----- generateBitInvert: msgNode on: aStream indent: level "Generate the C code for this message onto the given stream. If the selector is bitInvert32 then cast to unsigned int to ensure a 32-bit value on 64-bit platforms." | castToUnsignedInt castToUnsignedLong castToUnsignedLongLong | + msgNode selector == #bitInvert ifTrue: "quick hack; can do the full job (of coercing -1 to the right type) later..." + [aStream nextPutAll: '(-1 - ('. + self emitCExpression: msgNode receiver on: aStream. + aStream next: 2 put: $). + ^self]. (castToUnsignedInt := msgNode selector = #bitInvert32) ifTrue: [aStream nextPutAll: '(unsigned int)']. aStream nextPut: $~. (castToUnsignedLong := msgNode selector = #bitInvert64 and: [vmClass notNil and: [vmClass objectMemoryClass wordSize = 8]]) ifTrue: [aStream nextPutAll: '(usqIntptr_t)']. (castToUnsignedLongLong := msgNode selector = #bitInvert64 and: [vmClass isNil or: [vmClass objectMemoryClass wordSize = 4]]) ifTrue: [aStream nextPutAll: '(unsigned long long)']. self assert: castToUnsignedInt asBit + castToUnsignedLong asBit + castToUnsignedLongLong asBit <= 1. "We should only do a single cast" self emitCExpression: msgNode receiver on: aStream! Item was changed: ----- Method: CCodeGenerator>>initializeCTranslationDictionary (in category 'C translation support') ----- initializeCTranslationDictionary "Initialize the dictionary mapping message names to actions for C code generation." | pairs | translationDict := Dictionary new: 200. pairs := #( #& #generateAnd:on:indent: #| #generateOr:on:indent: #abs #generateAbs:on:indent: #and: #generateSequentialAnd:on:indent: #or: #generateSequentialOr:on:indent: #not #generateNot:on:indent: #+ #generatePlus:on:indent: #- #generateMinus:on:indent: #negated #generateNegated:on:indent: #* #generateTimes:on:indent: #/ #generateDivide:on:indent: #// #generateDivide:on:indent: #\\ #generateModulo:on:indent: #<< #generateShiftLeft:on:indent: #>> #generateShiftRight:on:indent: #>>> #generateSignedShiftRight:on:indent: #, #generateComma:on:indent: #min: #generateMin:on:indent: #max: #generateMax:on:indent: #between:and: #generateBetweenAnd:on:indent: #bitAnd: #generateBitAnd:on:indent: #bitOr: #generateBitOr:on:indent: #bitXor: #generateBitXor:on:indent: #bitShift: #generateBitShift:on:indent: #signedBitShift: #generateSignedBitShift:on:indent: + #bitInvert #generateBitInvert:on:indent: #bitInvert32 #generateBitInvert:on:indent: #bitInvert64 #generateBitInvert:on:indent: #bitClear: #generateBitClear:on:indent: #truncateTo: #generateTruncateTo:on:indent: #rounded #generateRounded:on:indent: #even #generateEven:on:indent: #odd #generateOdd:on:indent: #byteSwap32 #generateByteSwap32:on:indent: #byteSwap64 #generateByteSwap64:on:indent: #byteSwapped32IfBigEndian: generateByteSwap32IfBigEndian:on:indent: #byteSwapped64IfBigEndian: generateByteSwap64IfBigEndian:on:indent: #< #generateLessThan:on:indent: #<= #generateLessThanOrEqual:on:indent: #= #generateEqual:on:indent: #> #generateGreaterThan:on:indent: #>= #generateGreaterThanOrEqual:on:indent: #~= #generateNotEqual:on:indent: #== #generateEqual:on:indent: #~~ #generateNotEqual:on:indent: #isNil #generateIsNil:on:indent: #notNil #generateNotNil:on:indent: #whileTrue: #generateWhileTrue:on:indent: #whileFalse: #generateWhileFalse:on:indent: #whileTrue #generateDoWhileTrue:on:indent: #whileFalse #generateDoWhileFalse:on:indent: #to:do: #generateToDo:on:indent: #to:by:do: #generateToByDo:on:indent: #repeat #generateRepeat:on:indent: #timesRepeat: #generateTimesRepeat:on:indent: #ifTrue: #generateIfTrue:on:indent: #ifFalse: #generateIfFalse:on:indent: #ifTrue:ifFalse: #generateIfTrueIfFalse:on:indent: #ifFalse:ifTrue: #generateIfFalseIfTrue:on:indent: #ifNotNil: #generateIfNotNil:on:indent: #ifNil: #generateIfNil:on:indent: #ifNotNil:ifNil: #generateIfNotNilIfNil:on:indent: #ifNil:ifNotNil: #generateIfNilIfNotNil:on:indent: #at: #generateAt:on:indent: #at:put: #generateAtPut:on:indent: #basicAt: #generateAt:on:indent: #basicAt:put: #generateAtPut:on:indent: #integerValueOf: #generateIntegerValueOf:on:indent: #integerObjectOf: #generateIntegerObjectOf:on:indent: #isIntegerObject: #generateIsIntegerObject:on:indent: #cCode: #generateInlineCCode:on:indent: #cCode:inSmalltalk: #generateInlineCCode:on:indent: #cPreprocessorDirective: #generateInlineCPreprocessorDirective:on:indent: #cppIf:ifTrue:ifFalse: #generateInlineCppIfElse:on:indent: #cppIf:ifTrue:cppIf:ifTrue:ifFalse: #generateInlineCppIfElse:on:indent: #cppIf:ifTrue: #generateInlineCppIfElse:on:indent: #cppIf:ifFalse: #generateInlineCppIfElse:on:indent: #cCoerce:to: #generateCCoercion:on:indent: #cCoerceSimple:to: #generateCCoercion:on:indent: #addressOf: #generateAddressOf:on:indent: #addressOf:put: #generateAddressOf:on:indent: #asAddress:put: #generateAsAddress:on:indent: #signedIntFromLong64 #generateSignedIntFromLong64:on:indent: #signedIntFromLong #generateSignedIntFromLong:on:indent: #signedIntFromShort #generateSignedIntFromShort:on:indent: #signedIntToLong64 #generateSignedIntToLong64:on:indent: #signedIntToLong #generateSignedIntToLong:on:indent: #signedIntToShort #generateSignedIntToShort:on:indent: #preIncrement #generatePreIncrement:on:indent: #preDecrement #generatePreDecrement:on:indent: #inline: #generateInlineDirective:on:indent: #asFloat #generateAsFloat:on:indent: #asInteger #generateAsInteger:on:indent: #asIntegerPtr #generateAsIntegerPtr:on:indent: #asUnsignedInteger #generateAsUnsignedInteger:on:indent: #asUnsignedIntegerPtr #generateAsUnsignedIntegerPtr:on:indent: #asLong #generateAsLong:on:indent: #asUnsignedLong #generateAsUnsignedLong:on:indent: #asUnsignedLongLong #generateAsUnsignedLongLong:on:indent: #asVoidPointer #generateAsVoidPointer:on:indent: #asSymbol #generateAsSymbol:on:indent: #flag: #generateFlag:on:indent: #anyMask: #generateAnyMask:on:indent: #allMask: #generateAllMask:on:indent: #noMask: #generateNoMask:on:indent: #raisedTo: #generateRaisedTo:on:indent: #touch: #generateTouch:on:indent: #bytesPerOop #generateBytesPerOop:on:indent: #bytesPerWord #generateBytesPerWord:on:indent: #wordSize #generateBytesPerWord:on:indent: #baseHeaderSize #generateBaseHeaderSize:on:indent: #minSmallInteger #generateSmallIntegerConstant:on:indent: #maxSmallInteger #generateSmallIntegerConstant:on:indent: #sharedCodeNamed:inCase: #generateSharedCodeDirective:on:indent: #perform: #generatePerform:on:indent: #perform:with: #generatePerform:on:indent: #perform:with:with: #generatePerform:on:indent: #perform:with:with:with: #generatePerform:on:indent: #perform:with:with:with:with: #generatePerform:on:indent: #perform:with:with:with:with:with: #generatePerform:on:indent: #value #generateValue:on:indent: #value: #generateValue:on:indent: #value:value: #generateValue:on:indent: #value:value:value: #generateValue:on:indent: #value:value:value:value: #generateValue:on:indent: #value:value:value:value:value: #generateValue:on:indent: #value:value:value:value:value:value: #generateValue:on:indent: #deny: #generateDeny:on:indent: #shouldNotImplement #generateSmalltalkMetaError:on:indent: #shouldBeImplemented #generateSmalltalkMetaError:on:indent: #subclassResponsibility #generateSmalltalkMetaError:on:indent: ). 1 to: pairs size by: 2 do: [:i | translationDict at: (pairs at: i) put: (pairs at: i + 1)]. pairs := #( #ifTrue: #generateIfTrueAsArgument:on:indent: #ifFalse: #generateIfFalseAsArgument:on:indent: #ifTrue:ifFalse: #generateIfTrueIfFalseAsArgument:on:indent: #ifFalse:ifTrue: #generateIfFalseIfTrueAsArgument:on:indent: #ifNotNil: #generateIfNotNilAsArgument:on:indent: #ifNil: #generateIfNilAsArgument:on:indent: #ifNotNil:ifNil: #generateIfNotNilIfNilAsArgument:on:indent: #ifNil:ifNotNil: #generateIfNilIfNotNilAsArgument:on:indent: #cCode: #generateInlineCCodeAsArgument:on:indent: #cCode:inSmalltalk: #generateInlineCCodeAsArgument:on:indent: #cppIf:ifTrue:ifFalse: #generateInlineCppIfElseAsArgument:on:indent: #cppIf:ifTrue: #generateInlineCppIfElseAsArgument:on:indent: #value #generateValueAsArgument:on:indent: #value: #generateValueAsArgument:on:indent: #value:value: #generateValueAsArgument:on:indent: ). asArgumentTranslationDict := Dictionary new: 8. 1 to: pairs size by: 2 do: [:i | asArgumentTranslationDict at: (pairs at: i) put: (pairs at: i + 1)]. ! Item was changed: ----- Method: CFloatArray>>coerceTo:sim: (in category 'converting') ----- coerceTo: cTypeString sim: interpreterSimulator ^cTypeString caseOf: { + ['float *'] -> [self shallowCopy unitSize: 4; yourself]. + ['double *'] -> [self shallowCopy unitSize: 8; yourself]. + ['sqIntptr_t'] -> [self] "this is used, in e.g. ffiAddressOf:startingAt:size: to coerce a pointer to an integer; it does not imply a real conversion. it is just to be able to pass the pointer as an integer" } - ['float *'] -> [self shallowCopy unitSize: 4; yourself]. - ['double *'] -> [self shallowCopy unitSize: 8; yourself] } otherwise: [self asNonFloatAccessor coerceTo: cTypeString sim: interpreterSimulator]! Item was changed: ----- Method: CoInterpreter class>>initializeMiscConstants (in category 'initialization') ----- initializeMiscConstants super initializeMiscConstants. COGVM := true. MinBackwardJumpCountForCompile := 40. MaxNumArgs := 15. PrimCallNeedsNewMethod := 1. PrimCallNeedsPrimitiveFunction := 2. PrimCallMayEndureCodeCompaction := 4. PrimCallCollectsProfileSamples := 8. PrimCallDoNotJIT := 16. PrimCallIsExternalCall := 32. "CheckAllocationFillerAfterPrimCall := 32. this has never been successfully used in all the years we've had it; nuking it" PrimCallOnSmalltalkStack := 64. "Speed up simple external prims by avoiding stack switch" + PrimCallOnSmalltalkStackAlign2x := 128. "Align stack to a 2 x word size boundary, e.g. for MMX instructions etc" + FastCPrimitiveUseCABIFlag := 256. + "Flags for use in export:flags:, shifted to overlap with the PrimCallXXX flags above" + FastCPrimitiveFlag := 1. "a.k.a. PrimCallOnSmalltalkStack" + FastCPrimitiveAlignForFloatsFlag := 2. "a.k.a. PrimCallOnSmalltalkStackAlign2x" + FastCPrimitiveUseCABIFlag := 4. "a.k.a. FastCPrimitiveUseCABIFlag" - "Flags for use in export:flags:, shifted and combined with the PrimCallXXX flags above" - FastCPrimitiveFlag := 1. PrimitiveMetadataFlagsShift := PrimCallOnSmalltalkStack highBit - FastCPrimitiveFlag highBit. "the primitive trace log; a record of the last 256 named/external primitives or significant events invoked." PrimTraceLogSize := 256. "Room for 256 selectors. Must be 256 because we use a byte to hold the index" TraceBufferSize := 256 * 3. "Room for 256 events" TraceContextSwitch := self objectMemoryClass basicNew integerObjectOf: 1. TraceBlockActivation := self objectMemoryClass basicNew integerObjectOf: 2. TraceBlockCreation := self objectMemoryClass basicNew integerObjectOf: 3. TraceIncrementalGC := self objectMemoryClass basicNew integerObjectOf: 4. TraceFullGC := self objectMemoryClass basicNew integerObjectOf: 5. TraceCodeCompaction := self objectMemoryClass basicNew integerObjectOf: 6. TraceOwnVM := self objectMemoryClass basicNew integerObjectOf: 7. TraceDisownVM := self objectMemoryClass basicNew integerObjectOf: 8. TraceThreadSwitch := self objectMemoryClass basicNew integerObjectOf: 9. TracePreemptDisowningThread := self objectMemoryClass basicNew integerObjectOf: 10. TraceVMCallback := self objectMemoryClass basicNew integerObjectOf: 11. TraceVMCallbackReturn := self objectMemoryClass basicNew integerObjectOf: 12. TraceStackOverflow := self objectMemoryClass basicNew integerObjectOf: 13. TracePrimitiveFailure := self objectMemoryClass basicNew integerObjectOf: 14. TracePrimitiveRetry := self objectMemoryClass basicNew integerObjectOf: 15. TraceIsFromMachineCode := 1. TraceIsFromInterpreter := 2. CSCallbackEnter := 3. CSCallbackLeave := 4. CSEnterCriticalSection := 5. CSExitCriticalSection := 6. CSResume := 7. CSSignal := 8. CSSuspend := 9. CSWait := 10. CSYield := 11. CSCheckEvents := 12. CSThreadSchedulingLoop := 13. CSOwnVM := 14. CSThreadBind := 15. CSSwitchIfNeccessary := 16. TraceSources := CArrayAccessor on: #('?' 'm' 'i' 'callbackEnter' 'callbackLeave' 'enterCritical' 'exitCritical' 'resume' 'signal' 'suspend' 'wait' 'yield' 'eventcheck' 'threadsched' 'ownVM' 'bindToThread' 'switchIfNecessary'). "this is simulation only" RumpCStackSize := 4096! Item was changed: ----- Method: CoInterpreter class>>metadataFlagsForPrimitive: (in category 'spur compilation support') ----- metadataFlagsForPrimitive: aPrimitiveMethodOrNil "We allow methods to decorate themselves with 8 flags (only one specified so far: FastCPrimitiveFlag) using the export:flags: pragma." aPrimitiveMethodOrNil ifNil: [^0]. ^(aPrimitiveMethodOrNil pragmaAt: #export:flags:) ifNil: [0] ifNotNil: [:pragma| | flags | (flags := pragma arguments second) isInteger ifTrue: [flags] + ifFalse: [self valueOfMetadataFlag: flags]]! - ifFalse: - [(self bindingOf: flags) - ifNil: [self error: 'could not find primitive flag'. 0] - ifNotNil: - [:binding| | flagValue | - ((flagValue := binding value) isInteger and: [flagValue between: 1 and: 255]) - ifTrue: [flagValue] - ifFalse: [self error: 'integer flag required'. 0]]]]! Item was added: + ----- Method: CoInterpreter class>>valueOfMetadataFlag: (in category 'spur compilation support') ----- + valueOfMetadataFlag: symbolOrArray + "We allow methods to decorate themselves with 8 flags (only one specified so far: FastCPrimitiveFlag) + using the export:flags: pragma. A single flag is supplied as a symbol. Multiple flags are supplied as + an array of symbols (pragmas take only literal arguments)." + ^symbolOrArray isArray + ifTrue: + [symbolOrArray inject: 0 into: [:flags :flagName| flags + (self valueOfMetadataFlag: flagName)]] + ifFalse: + [(self bindingOf: symbolOrArray) + ifNil: [self error: 'could not find primitive flag'. 0] + ifNotNil: + [:binding| | flagValue | + ((flagValue := binding value) isInteger and: [flagValue between: 1 and: 255]) + ifTrue: [flagValue] + ifFalse: [self error: 'integer flag required'. 0]]]! Item was changed: ----- Method: CoInterpreter>>functionPointerForCompiledMethod:primitiveIndex:primitivePropertyFlagsInto: (in category 'cog jit support') ----- functionPointerForCompiledMethod: methodObj primitiveIndex: primitiveIndex primitivePropertyFlagsInto: flagsPtr <api> <returnTypeC: 'void (*functionPointerForCompiledMethodprimitiveIndexprimitivePropertyFlagsInto(sqInt methodObj, sqInt primitiveIndex, sqInt *flagsPtr))(void)'> | functionPointer | <var: #functionPointer declareC: #'void (*functionPointer)(void)'> flagsPtr ifNotNil: [flagsPtr at: 0 put: (self primitivePropertyFlags: primitiveIndex)]. functionPointer := self functionPointerFor: primitiveIndex inClass: nil. functionPointer == #primitiveCalloutToFFI ifTrue: [^self functionForPrimitiveCallout]. functionPointer == #primitiveExternalCall ifTrue: [| lit | lit := self attemptToLinkExternalPrimitive: methodObj. "N.B. We only support the FastCPrimitiveFlag on Spur because Spur will *not* run a GC to satisfy an allocation in a primitive. The V3 ObjectMemory will and hence the depth of stack needed in a V3 primitive is probably too large to safely execute on a stack page." objectMemory hasSpurMemoryManagerAPI ifTrue: [| flags shiftedMetadataFlags | flags := objectMemory fetchPointer: ExternalCallLiteralFlagsIndex ofObject: lit. (objectMemory isIntegerObject: flags) ifTrue: [shiftedMetadataFlags := ((objectMemory integerValueOf: flags) bitAnd: 16rFF) bitShift: PrimitiveMetadataFlagsShift. + shiftedMetadataFlags ~= 0 ifTrue: + [flagsPtr at: 0 put: shiftedMetadataFlags]]]. - flagsPtr at: 0 put: ((flagsPtr at: 0) bitOr: shiftedMetadataFlags)]]. ^self functionForPrimitiveExternalCall: methodObj]. ^functionPointer! Item was changed: ----- Method: CoInterpreter>>primitivePropertyFlagsForSpur: (in category 'cog jit support') ----- primitivePropertyFlagsForSpur: primIndex <inline: true> "Answer any special requirements of the given primitive. Spur always needs to set primitiveFunctionPointer and newMethod so primitives can retry on failure due to forwarders." | baseFlags | self cCode: [] inSmalltalk: [#(mcprimHashMultiply: primitiveExternalCall primitiveCalloutToFFI)]. "For senders..." primIndex = PrimNumberHashMultiply ifTrue: + [^PrimCallOnSmalltalkStack+FastCPrimitiveUseCABIFlag]. - [^PrimCallOnSmalltalkStack]. baseFlags := PrimCallNeedsPrimitiveFunction + PrimCallNeedsNewMethod. profileSemaphore ~= objectMemory nilObject ifTrue: [baseFlags := baseFlags bitOr: PrimCallCollectsProfileSamples]. (self isCalloutPrimitiveIndex: primIndex) "For callbacks & module unloading" ifTrue: [baseFlags := baseFlags bitOr: PrimCallMayEndureCodeCompaction + PrimCallIsExternalCall] ifFalse: [(self isCodeCompactingPrimitiveIndex: primIndex) ifTrue: "For code reclamations" [baseFlags := baseFlags bitOr: PrimCallMayEndureCodeCompaction]]. ^baseFlags! Item was changed: ----- Method: CogARMv8Compiler>>computeMaximumSize (in category 'generate machine code') ----- computeMaximumSize "Because we don't use Thumb, each ARMv8 instruction has 4 bytes. Several abstract opcodes need more than one instruction. Instructions that refer to constants and/or literals depend on literals being stored out-of-line or encoded in immediate instruction fields (i.e. we only support OutOfLineLiteralsManager. N.B. The ^N forms are to get around the old bytecode compiler's long branch limits which are exceeded when each case jumps around the otherwise." opcode caseOf: { "Noops & Pseudo Ops" [Label] -> [^0]. [Literal] -> [^self literalSize]. [AlignmentNops] -> [^(operands at: 0) - 4]. "Control" [CallFull] -> [^8]. [JumpFull] -> [^8]. [JumpLongZero] -> [^8]. [JumpLongNonZero] -> [^8]. [JumpMulOverflow] -> [^8]. [JumpNoMulOverflow] -> [^8]. [JumpFPOrdered] -> [^8]. [JumpFPUnordered] -> [^8]. [RetN] -> [^(operands at: 0) = 0 ifTrue: [4] ifFalse: [8]]. [NativeRetN] -> [^(operands at: 0) = 0 ifTrue: [4] ifFalse: [8]]. "Arithmetic" [AddCqR] -> [^self isPossiblyShiftableNegatableImm12: (operands at: 0) signedIntFromLong64 ifTrue: [:ign|4] ifFalse: [8]]. [AddCqRR] -> [^self isPossiblyShiftableNegatableImm12: (operands at: 0) signedIntFromLong64 ifTrue: [:ign|4] ifFalse: [8]]. [CmpCqR] -> [^self isPossiblyShiftableNegatableImm12: (operands at: 0) signedIntFromLong64 ifTrue: [:ign|4] ifFalse: [8]]. [SubCqR] -> [^self isPossiblyShiftableNegatableImm12: (operands at: 0) signedIntFromLong64 ifTrue: [:ign|4] ifFalse: [8]]. [LoadEffectiveAddressMwrR] -> [^self isPossiblyShiftableNegatableImm12: (operands at: 0) signedIntFromLong64 ifTrue: [:ign|4] ifFalse: [8]]. [AndCqR] -> [^self isImmNImmSImmREncodableBitmask: (operands at: 0) ifTrue: [:n :imms :immr|4] ifFalse:[8]]. + [AndCqRR] -> ["N.B. For three operand logical ops only support AndCqRR with a NativeSPReg target, used for alignment purposes." + ^(self isImmNImmSImmREncodableBitmask: (operands at: 0) ifTrue: [:n :imms :immr|4] ifFalse:[8]) + + ((operands at: 2) = NativeSPReg ifTrue: [4] ifFalse: [0])]. - [AndCqRR] -> [^self isImmNImmSImmREncodableBitmask: (operands at: 0) ifTrue: [:n :imms :immr|4] ifFalse:[8]]. [OrCqR] -> [^self isImmNImmSImmREncodableBitmask: (operands at: 0) ifTrue: [:n :imms :immr|4] ifFalse:[8]]. [OrCqRR] -> [^self isImmNImmSImmREncodableBitmask: (operands at: 0) ifTrue: [:n :imms :immr|4] ifFalse:[8]]. [TstCqR] -> [^self isImmNImmSImmREncodableBitmask: (operands at: 0) ifTrue: [:n :imms :immr|4] ifFalse:[8]]. [XorCqR] -> [^self isImmNImmSImmREncodableBitmask: (operands at: 0) ifTrue: [:n :imms :immr|4] ifFalse:[8]]. [AddCwR] -> [^8]. [AndCwR] -> [^8]. [CmpCwR] -> [^8]. [CmpC32R] -> [^8]. [OrCwR] -> [^8]. [SubCwR] -> [^8]. [XorCwR] -> [^8]. [SubRR] -> [^(operands at: 0) = SP ifTrue: [8] ifFalse: [4]]. [SubRRR] -> [^(operands at: 0) = SP ifTrue: [8] ifFalse: [4]]. "ARMv8 Specific Arithmetic" [MulOverflowRRR] -> [^12]. "Data Movement" [MoveAwR] -> [^((self isAddressRelativeToVarBase: (operands at: 0)) or: [cogit addressIsInCurrentCompilation: (operands at: 0)]) ifTrue: [(operands at: 1) ~= SP ifTrue: [4] ifFalse: [8]] ifFalse: [(operands at: 1) ~= SP ifTrue: [8] ifFalse: [12]]]. [MoveRAw] -> [^((self isAddressRelativeToVarBase: (operands at: 1)) or: [cogit addressIsInCurrentCompilation: (operands at: 1)]) ifTrue: [(operands at: 0) ~= SP ifTrue: [4] ifFalse: [8]] ifFalse: [(operands at: 0) ~= SP ifTrue: [8] ifFalse: [12]]]. [MoveAwRR] -> [self assert: (self isAddressRelativeToVarBase: (operands at: 0)). ^((operands at: 1) = SP or: [(operands at: 2) = SP]) ifTrue: [8] ifFalse: [4]]. [MoveRRAw] -> [self assert: (self isAddressRelativeToVarBase: (operands at: 2)). ^((operands at: 0) = SP or: [(operands at: 1) = SP]) ifTrue: [8] ifFalse: [4]]. [MoveAbR] -> [^(self isAddressRelativeToVarBase: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. [MoveRAb] -> [^(self isAddressRelativeToVarBase: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. [MoveMwrR] -> [^(self isImm12orImm9offset: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. [MoveRMwr] -> [^(self isImm12orImm9offset: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. [MoveM32rR] -> [^(self isImm12orImm9offset: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. [MoveRM32r] -> [^(self isImm12orImm9offset: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. [MoveM16rR] -> [^(self isImm12orImm9offset: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. [MoveRM16r] -> [^(self isImm12orImm9offset: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. [MoveMbrR] -> [^(self isImm12orImm9offset: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. [MoveRMbr] -> [^(self isImm12orImm9offset: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. [MoveM64rRd] -> [^(self isUnsigned12BitMultipleOf8: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. [MoveRdM64r] -> [^(self isUnsigned12BitMultipleOf8: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. [PushCw] -> [^8]. [PushCq] -> [^8]. } otherwise: [^4]. ^0 "to keep C compiler quiet" ! Item was changed: ----- Method: CogARMv8Compiler>>concretizeLogicalOp:CqRDest: (in category 'generate machine code - concretize') ----- concretizeLogicalOp: op CqRDest: destReg "AND (immediate) - 64-bit variant on page C6-775 ORR (immediate) - 64-bit variant on page C6-1125 EOR (immediate) - 64-bit variant on page C6-896 ANDS (immediate) - 64-bit variant on page C6-779 C6.2.329 TST (immediate) C6-1346" <inline: false> + | srcReg constant effectiveDestReg offset | - | srcReg constant | constant := operands at: 0. srcReg := operands at: 1. + "N.B. For three operand logical ops only support AndCq: const R: reg R: NativeSPReg, which is used for alignment." + effectiveDestReg := (opcode = AndCqRR and: [destReg = NativeSPReg]) ifTrue: [RISCTempReg] ifFalse: [destReg]. + self isImmNImmSImmREncodableBitmask: constant - ^self isImmNImmSImmREncodableBitmask: constant ifTrue: [:n :imms :immr| machineCode at: 0 put: 2r1001001 << 25 + (op << 29) + (n << 22) + (immr << 16) + (imms << 10) + (srcReg << 5) + + effectiveDestReg. + offset := 4] - + destReg. - 4] ifFalse: + [offset := self emitMoveCw: constant intoR: RISCTempReg at: 0. - [| offset | - offset := self emitMoveCw: constant intoR: RISCTempReg at: 0. "OPC N 00 0 AND (shifted register) - 64-bit variant on page C6-777 00 1 BIC (shifted register) - 64-bit variant on page C6-808 01 0 ORR (shifted register) - 64-bit variant on page C6-1127 01 1 ORN (shifted register) - 64-bit variant on page C6-1123 10 0 EOR (shifted register) - 64-bit variant on page C6-898 10 1 EON (shifted register) - 64-bit variant on page C6-894 11 0 ANDS (shifted register) - 64-bit variant on page C6-781 11 0 BICS (shifted register) - 64-bit variant on page C6-810" machineCode + at: offset // 4 + put: 2r1000101 << 25 + + (op << 29) + + (RISCTempReg << 16) + + (srcReg << 5) + + effectiveDestReg. + offset := offset + 4]. + (opcode = AndCqRR and: [destReg = NativeSPReg]) ifFalse: + [^offset]. + machineCode at: offset // 4 put: (self movern: effectiveDestReg rd: destReg). + ^offset + 4 - at: offset // 4 - put: 2r1000101 << 25 - + (op << 29) - + (RISCTempReg << 16) - + (srcReg << 5) - + destReg. - offset + 4] "cogit processor disassembleInstructionAt: 0 In: machineCode object" "cogit processor disassembleInstructionAt: 4 In: machineCode object" "cogit processor disassembleInstructionAt: 8 In: machineCode object"! Item was added: + ----- Method: CogARMv8Compiler>>genLoadNativeSPRegWithAlignedSPReg (in category 'smalltalk calling convention') ----- + genLoadNativeSPRegWithAlignedSPReg + cogit AndCq: (objectMemory wordSize * 2 - 1) bitInvert R: SPReg R: NativeSPReg! Item was changed: SharedPool subclass: #CogMethodConstants instanceVariableNames: '' + classVariableNames: 'CMBlock CMClosedPIC CMFree CMMaxUsageCount CMMethod CMOpenPIC CompletePrimitive EncounteredUnknownBytecode InsufficientCodeSpace MaxLiteralCountForCompile MaxMethodSize MaxNegativeErrorCode MaxNumArgs MaxStackCheckOffset MethodTooBig NotFullyInitialized PrimCallCollectsProfileSamples PrimCallDoNotJIT PrimCallIsExternalCall PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod PrimCallNeedsPrimitiveFunction PrimCallOnSmalltalkStack PrimCallOnSmalltalkStackAlign2x PrimCallUseCABI ShouldNotJIT UnfailingPrimitive UnimplementedPrimitive YoungSelectorInPIC' - classVariableNames: 'CMBlock CMClosedPIC CMFree CMMaxUsageCount CMMethod CMOpenPIC CompletePrimitive EncounteredUnknownBytecode InsufficientCodeSpace MaxLiteralCountForCompile MaxMethodSize MaxNegativeErrorCode MaxNumArgs MaxStackCheckOffset MethodTooBig NotFullyInitialized PrimCallCollectsProfileSamples PrimCallDoNotJIT PrimCallIsExternalCall PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod PrimCallNeedsPrimitiveFunction PrimCallOnSmalltalkStack ShouldNotJIT UnfailingPrimitive UnimplementedPrimitive YoungSelectorInPIC' poolDictionaries: '' category: 'VMMaker-JIT'! Item was changed: CogClass subclass: #CurrentImageCoInterpreterFacade instanceVariableNames: 'memory cogit coInterpreter objectMemory objectMap headerToMethodMap cachedObject cachedOop variables cFramePointer cStackPointer' classVariableNames: '' + poolDictionaries: 'CogMethodConstants VMBasicConstants VMBytecodeConstants VMObjectIndices VMSqueakClassIndices' - poolDictionaries: 'CogMethodConstants VMBasicConstants VMObjectIndices VMSqueakClassIndices' category: 'VMMaker-Support'! !CurrentImageCoInterpreterFacade commentStamp: 'eem 8/6/2014 14:59' prior: 0! A CurrentImageCoInterpreterFacade is a stand-in for an object memory (ObjectMemory, SpurMemoryManager, etc) that allows the Cogits to access image objects as if they were in the simulator VM's heap. hence it allows the Cogits to generate code for methdos in the current image, for testing, etc. Instance Variables cachedObject: <Object> cachedOop: <Integer> coInterpreter: <CoInterpreter> cogit: <Cogit> headerToMethodMap: <Dictionary> memory: <ByteArray> objectMap: <IdentityDictionary> objectMemory: <NewObjectMemory|SpurMemoryManager> variables: <Dictionary> cachedObject - the object matching cachedOop, to speed-up oop to obejct mapping cachedOop - the last used oop coInterpreter - the CoInterpreter simulator used by the cogit. cogit - the code egnerator in use headerToMethodMap - a map from header to CompiledMethod memory - a rump memory for holding various interpreter variables (e.g. stackLimit) that are accessed as memory locations by generated code objectMap - map from objects to their oops objectMemory - the object memory used to encode various values, answer queries, etc variables - a map from the names of variables to their addresses in memory ! Item was added: + ----- Method: CurrentImageCoInterpreterFacade>>fakeLinkedExternalLiteralFor: (in category 'private') ----- + fakeLinkedExternalLiteralFor: methodOop + | method | + method := self objectForOop: methodOop. + self assert: (method isCompiledMethod and: [method primitive = PrimNumberExternalCall]). + self shouldBeImplemented! Item was changed: ----- Method: CurrentImageCoInterpreterFacade>>functionPointerForCompiledMethod:primitiveIndex:primitivePropertyFlagsInto: (in category 'accessing') ----- functionPointerForCompiledMethod: methodOop primitiveIndex: primIndex primitivePropertyFlagsInto: flagsPtr ^([coInterpreter functionPointerForCompiledMethod: methodOop primitiveIndex: primIndex primitivePropertyFlagsInto: flagsPtr] on: Error do: [:ex| + "N.B. THIS IS WORK IN PROGRESS!! NO TIME TO MAKE fakeLinkedExternalLiteralFor: WORK PROPERLY AT THE MOMENT" + (ex signalerContext findContextSuchThat: [:ctxt| ctxt selector == #attemptToLinkExternalPrimitive:]) + ifNotNil: [ex resume: (self fakeLinkedExternalLiteralFor: methodOop)] + ifNil: [#someExternalPrimitive]]) ifNotNil: - #someExternalPrimitive]) ifNotNil: [:symbol| self addressForLabel: symbol]! Item was added: + ----- Method: CurrentImageCoInterpreterFacade>>hasSpurMemoryManagerAPI (in category 'testing') ----- + hasSpurMemoryManagerAPI + ^objectMemory hasSpurMemoryManagerAPI! Item was added: + ----- Method: CurrentImageCoInterpreterFacade>>recordPrimTraceForMethod: (in category 'cog jit support') ----- + recordPrimTraceForMethod: methodOop + ^coInterpreter recordPrimTraceForMethod: methodOop! Item was added: + ----- Method: InterpreterPlugin>>objectMemory (in category 'simulation support') ----- + objectMemory + ^interpreterProxy objectMemory! Item was removed: - ----- Method: SimpleStackBasedCogit>>compileOnStackExternalPrimitive: (in category 'primitive generators') ----- - compileOnStackExternalPrimitive: primitiveRoutine - "Compile a fast call of a C primitive using the current stack page, avoiding the stack switch except on failure. - This convention still uses stackPointer and argumentCount to access operands. Push all operands to the stack, - assign stackPointer, argumentCount, and zero primFailCode. Make the call (saving a LinkReg if required). - Test for failure and return. On failure on Spur, if there is an accessor depth, assign framePointer and newMethod, - do the stack switch, call checkForAndFollowForwardedPrimitiveState, and loop back if forwarders are found. - Fall through to frame build." - - <var: #primitiveRoutine declareC: 'void (*primitiveRoutine)(void)'> - | jmp retry calleeSavedReg | - "Clear the primFailCode and set argumentCount" - self MoveCq: 0 R: TempReg. - self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. - methodOrBlockNumArgs ~= 0 ifTrue: - [self MoveCq: methodOrBlockNumArgs R: TempReg]. - self MoveR: TempReg Aw: coInterpreter argumentCountAddress. - self genExternalizeStackPointerForFastPrimitiveCall. - backEnd hasLinkRegister ifTrue: - [self PushR: LinkReg]. - retry := self Label. - calleeSavedReg := NoReg. - (SPReg ~= NativeSPReg - and: [(self isCalleeSavedReg: SPReg) not]) ifTrue: - [calleeSavedReg := self availableRegisterOrNoneIn: ABICalleeSavedRegisterMask. - self deny: calleeSavedReg = NoReg. - self MoveR: SPReg R: calleeSavedReg]. - self CallFullRT: primitiveRoutine. - self MoveAw: coInterpreter primFailCodeAddress R: TempReg. - calleeSavedReg ~= NoReg ifTrue: - [self MoveR: calleeSavedReg R: SPReg]. - self CmpCq: 0 R: TempReg. - jmp := self JumpNonZero: 0. - backEnd hasLinkRegister - ifTrue: [self PopR: LinkReg] - ifFalse: [self PopR: TempReg]. "i.e. save retpc" - self MoveAw: coInterpreter stackPointerAddress R: SPReg. - self PopR: ReceiverResultReg. - backEnd hasLinkRegister ifFalse: [self PushR: TempReg]. "i.e. restore retpc" - self RetN: 0. - - jmp jmpTarget: self Label. - (objectRepresentation hasSpurMemoryManagerAPI - and: [(coInterpreter accessorDepthForExternalPrimitiveMethod: methodObj) >= 0]) ifTrue: - [| skip | - "Given that following primitive state to the accessor depth is recursive, we're asking for - trouble if we run the fixup on the Smalltalk stack page. Run it on the full C stack instead. - This won't be a performance issue since primitive failure should be very rare." - self MoveR: FPReg Aw: coInterpreter framePointerAddress. - self MoveCw: primitiveRoutine asInteger R: TempReg. - self MoveR: TempReg Aw: coInterpreter primitiveFunctionPointerAddress. - self genLoadCStackPointersForPrimCall. - methodLabel addDependent: - (self annotateAbsolutePCRef: - (self MoveCw: methodLabel asInteger R: ClassReg)). - self MoveMw: (self offset: CogMethod of: #methodObject) r: ClassReg R: TempReg. - self MoveR: TempReg Aw: coInterpreter newMethodAddress. - self CallFullRT: (self cCode: [#checkForAndFollowForwardedPrimitiveState asUnsignedIntegerPtr] - inSmalltalk: [self simulatedTrampolineFor: #checkForAndFollowForwardedPrimitiveState]). - backEnd genLoadStackPointersForFastPrimCall: ClassReg. - self CmpCq: 0 R: ABIResultReg. - skip := self JumpZero: 0. - self MoveCq: 0 R: TempReg. - self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. - self Jump: retry. - skip jmpTarget: self Label]. - "Finally remember to reload ReceiverResultReg if required. Even if - arguments have been pushed, the prolog sequence assumes it is live." - (self register: ReceiverResultReg isInMask: ABICallerSavedRegisterMask) ifTrue: - [self MoveMw: (backEnd hasLinkRegister ifTrue: [methodOrBlockNumArgs] ifFalse: [methodOrBlockNumArgs + 1]) * objectMemory wordSize - r: SPReg - R: ReceiverResultReg]. - ^0! Item was added: + ----- Method: SimpleStackBasedCogit>>compileOnStackExternalPrimitive:flags: (in category 'primitive generators') ----- + compileOnStackExternalPrimitive: primitiveRoutine flags: flags + "Compile a fast call of a C primitive using the current stack page, avoiding the stack switch except on failure. + This convention still uses stackPointer and argumentCount to access operands. Push all operands to the stack, + assign stackPointer, argumentCount, and zero primFailCode. Make the call (saving a LinkReg if required). + Test for failure and return. On failure on Spur, if there is an accessor depth, assign framePointer and newMethod, + do the stack switch, call checkForAndFollowForwardedPrimitiveState, and loop back if forwarders are found. + Fall through to frame build." + + <var: #primitiveRoutine declareC: 'void (*primitiveRoutine)(void)'> + | jmp retry calleeSavedReg | + self assert: (flags anyMask: PrimCallOnSmalltalkStack). + + "Clear the primFailCode and set argumentCount" + self MoveCq: 0 R: TempReg. + self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. + methodOrBlockNumArgs ~= 0 ifTrue: + [self MoveCq: methodOrBlockNumArgs R: TempReg]. + self MoveR: TempReg Aw: coInterpreter argumentCountAddress. + self genExternalizeStackPointerForFastPrimitiveCall. + backEnd hasLinkRegister ifTrue: + [self PushR: LinkReg]. + retry := self Label. + calleeSavedReg := NoReg. + (SPReg ~= NativeSPReg + and: [(self isCalleeSavedReg: SPReg) not]) ifTrue: + [calleeSavedReg := self availableRegisterOrNoneIn: ABICalleeSavedRegisterMask. + self deny: calleeSavedReg = NoReg. + self MoveR: SPReg R: calleeSavedReg]. + (flags anyMask: PrimCallOnSmalltalkStackAlign2x) + ifTrue: [self AndCq: (objectMemory wordSize * 2 - 1) bitInvert R: SPReg R: NativeSPReg] + ifFalse: + [SPReg ~= NativeSPReg ifTrue: + [backEnd genLoadNativeSPRegWithAlignedSPReg]]. + self CallFullRT: primitiveRoutine. + self MoveAw: coInterpreter primFailCodeAddress R: TempReg. + calleeSavedReg ~= NoReg ifTrue: + [self MoveR: calleeSavedReg R: SPReg]. + self CmpCq: 0 R: TempReg. + jmp := self JumpNonZero: 0. + backEnd hasLinkRegister + ifTrue: [self PopR: LinkReg] + ifFalse: [self PopR: TempReg]. "i.e. save retpc" + self MoveAw: coInterpreter stackPointerAddress R: SPReg. + self PopR: ReceiverResultReg. + backEnd hasLinkRegister ifFalse: [self PushR: TempReg]. "i.e. restore retpc" + self RetN: 0. + + jmp jmpTarget: self Label. + (objectRepresentation hasSpurMemoryManagerAPI + and: [(coInterpreter accessorDepthForExternalPrimitiveMethod: methodObj) >= 0]) ifTrue: + [| skip | + "Given that following primitive state to the accessor depth is recursive, we're asking for + trouble if we run the fixup on the Smalltalk stack page. Run it on the full C stack instead. + This won't be a performance issue since primitive failure should be very rare." + self MoveR: FPReg Aw: coInterpreter framePointerAddress. + self MoveCw: primitiveRoutine asInteger R: TempReg. + self MoveR: TempReg Aw: coInterpreter primitiveFunctionPointerAddress. + self genLoadCStackPointersForPrimCall. + methodLabel addDependent: + (self annotateAbsolutePCRef: + (self MoveCw: methodLabel asInteger R: ClassReg)). + self MoveMw: (self offset: CogMethod of: #methodObject) r: ClassReg R: TempReg. + self MoveR: TempReg Aw: coInterpreter newMethodAddress. + self CallFullRT: (self cCode: [#checkForAndFollowForwardedPrimitiveState asUnsignedIntegerPtr] + inSmalltalk: [self simulatedTrampolineFor: #checkForAndFollowForwardedPrimitiveState]). + backEnd genLoadStackPointersForFastPrimCall: ClassReg. + self CmpCq: 0 R: ABIResultReg. + skip := self JumpZero: 0. + self MoveCq: 0 R: TempReg. + self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. + self Jump: retry. + skip jmpTarget: self Label]. + "Finally remember to reload ReceiverResultReg if required. Even if + arguments have been pushed, the prolog sequence assumes it is live." + (self register: ReceiverResultReg isInMask: ABICallerSavedRegisterMask) ifTrue: + [self MoveMw: (backEnd hasLinkRegister ifTrue: [methodOrBlockNumArgs] ifFalse: [methodOrBlockNumArgs + 1]) * objectMemory wordSize + r: SPReg + R: ReceiverResultReg]. + ^0! Item was changed: ----- Method: SimpleStackBasedCogit>>compilePrimitive (in category 'primitive generators') ----- compilePrimitive "Compile a primitive. If possible, performance-critical primitives will be generated by their own routines (primitiveGenerator). Otherwise, if there is a primitive at all, we call the C routine with the usual stack-switching dance, test the primFailCode and then either return on success or continue to the method body." <inline: false> | primitiveDescriptor primitiveRoutine flags | <var: #primitiveDescriptor type: #'PrimitiveDescriptor *'> <var: #primitiveRoutine declareC: 'void (*primitiveRoutine)(void)'> primitiveIndex = 0 ifTrue: [^0]. "If a descriptor specifies an argument count (by numArgs >= 0) then it must match for the generated code to be correct. For example for speed many primitives use ResultReceiverReg instead of accessing the stack, so the receiver better be at numArgs down the stack. Use the interpreter version if not." ((primitiveDescriptor := self primitiveGeneratorOrNil) notNil and: [primitiveDescriptor primitiveGenerator notNil and: [(primitiveDescriptor primNumArgs < 0 "means generator doesn't care" or: [primitiveDescriptor primNumArgs = (coInterpreter argumentCountOf: methodObj)])]]) ifTrue: [| opcodeIndexAtPrimitive code | "Note opcodeIndex so that any arg load instructions for unimplemented primitives can be discarded." opcodeIndexAtPrimitive := opcodeIndex. code := objectRepresentation perform: primitiveDescriptor primitiveGenerator. (code < 0 and: [code ~= UnimplementedPrimitive]) ifTrue: "Generator failed, so no point continuing..." [^code]. "If the primitive can never fail then there is nothing more that needs to be done." code = UnfailingPrimitive ifTrue: [^0]. "If the machine code version handles all cases the only reason to call the interpreter primitive is to reap the primitive error code. Don't bother if it isn't used." (code = CompletePrimitive and: [(self methodUsesPrimitiveErrorCode: methodObj header: methodHeader) not]) ifTrue: [^0]. "Discard any arg load code generated by the primitive generator." code = UnimplementedPrimitive ifTrue: [opcodeIndex := opcodeIndexAtPrimitive]]. primitiveRoutine := coInterpreter functionPointerForCompiledMethod: methodObj primitiveIndex: primitiveIndex primitivePropertyFlagsInto: (self addressOf: flags put: [:val| flags := val]). (flags anyMask: PrimCallDoNotJIT) ifTrue: [^ShouldNotJIT]. - (flags anyMask: PrimCallOnSmalltalkStack) ifTrue: - [(flags anyMask: PrimCallNeedsPrimitiveFunction) ifTrue: "TEMPORARY HACK!!!!" - [^self compileOnStackExternalPrimitive: primitiveRoutine]. - ^self compileMachineCodeInterpreterPrimitive: (self cCoerceSimple: (coInterpreter mcprimFunctionForPrimitiveIndex: primitiveIndex) - to: 'void (*)(void)')]. - (primitiveRoutine = 0 "no primitive" or: [primitiveRoutine = (self cCoerceSimple: #primitiveFail to: 'void (*)(void)')]) ifTrue: [^self genFastPrimFail]. + + (flags anyMask: PrimCallOnSmalltalkStack) ifTrue: + [self deny: ((flags anyMask: FastCPrimitiveUseCABIFlag) and: [flags anyMask: PrimCallOnSmalltalkStackAlign2x]). + (flags anyMask: FastCPrimitiveUseCABIFlag) ifTrue: + [^self compileMachineCodeInterpreterPrimitive: (self cCoerceSimple: (coInterpreter mcprimFunctionForPrimitiveIndex: primitiveIndex) + to: 'void (*)(void)')]. + ^self compileOnStackExternalPrimitive: primitiveRoutine flags: flags]. minValidCallAddress := minValidCallAddress min: primitiveRoutine asUnsignedInteger. ^self compileInterpreterPrimitive: primitiveRoutine flags: flags! Item was changed: ----- Method: SpurMemoryManager>>memcpy:_:_: (in category 'simulation') ----- memcpy: destAddress _: sourceAddress _: bytes "For SpurGenerationScavenger>>copyToFutureSpace:bytes:. N.B. If ranges overlap, must use memmove." <doNotGenerate> | nToCopy offset | (destAddress isInteger and: [sourceAddress isInteger]) ifFalse: "CogMethodProxies..." + [(sourceAddress isCollection "String, etc..." + or: [sourceAddress isCArray + or: [destAddress isCArray]]) ifTrue: - [sourceAddress isCollection ifTrue: "CArray, String, etc..." [^super memcpy: destAddress _: sourceAddress _: bytes]. ^self memcpy: destAddress asInteger _: sourceAddress asInteger _: bytes]. self deny: ((destAddress <= sourceAddress and: [destAddress + bytes > sourceAddress]) or: [sourceAddress <= destAddress and: [sourceAddress + bytes > destAddress]]). self assert: (destAddress \\ 8) + (sourceAddress \\ 8) = 0. "for now..." nToCopy := bytes. offset := 0. memory bytesPerElement = 8 ifTrue: [0 to: nToCopy - 8 by: 8 do: [:i| self long64At: destAddress + i put: (self long64At: sourceAddress + i)]. offset := nToCopy - (nToCopy \\ 8). nToCopy := nToCopy \\ 8]. nToCopy >= 4 ifTrue: [0 to: nToCopy - 4 by: 4 do: [:i| self long32At: destAddress + i + offset put: (self long32At: sourceAddress + i + offset)]. offset := offset + nToCopy - (nToCopy \\ 4). nToCopy := nToCopy \\ 4]. 0 to: nToCopy - 1 do: [:i| self byteAt: destAddress + i + offset put: (self byteAt: sourceAddress + i + offset)]. ^destAddress! Item was changed: ----- Method: ThreadedFFIPlugin>>primitiveFFIDoubleAt (in category 'primitives') ----- primitiveFFIDoubleAt "Answer a 64-bit IEEE double the given byte offset." + <export: true flags: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> - <export: true flags: #FastCPrimitiveFlag> | byteOffset rcvr floatValue | <var: #floatValue type: #double> byteOffset := interpreterProxy stackValue: 0. rcvr := interpreterProxy stackValue: 1. (interpreterProxy isIntegerObject: byteOffset) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. (self ffiAddressOf: rcvr startingAt: (interpreterProxy integerValueOf: byteOffset) size: (self sizeof: #double)) ifNil: [^interpreterProxy primitiveFailFor: PrimErrBadIndex] ifNotNil: [:addr| self memcpy: (self addressOf: floatValue) _: addr _: (self sizeof: #double). ^interpreterProxy methodReturnFloat: floatValue]! Item was changed: ----- Method: ThreadedFFIPlugin>>primitiveFFIDoubleAtPut (in category 'primitives') ----- primitiveFFIDoubleAtPut "Store a 64-bit IEEE double the given byte offset." + <export: true flags: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> - <export: true flags: #FastCPrimitiveFlag> | byteOffset rcvr floatValue valueOop | <var: #floatValue type: #double> valueOop := interpreterProxy stackValue: 0. (interpreterProxy isFloatObject: valueOop) ifTrue: [floatValue := self cCoerce: (interpreterProxy floatValueOf: valueOop) to: #double] ifFalse: [(interpreterProxy isIntegerObject: valueOop) ifTrue: [floatValue := self cCoerce: (interpreterProxy integerValueOf: valueOop) to: #double] ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]]. byteOffset := interpreterProxy stackValue: 1. (interpreterProxy isIntegerObject: byteOffset) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. rcvr := interpreterProxy stackValue: 2. (self ffiAddressOf: rcvr startingAt: (interpreterProxy integerValueOf: byteOffset) size: (self sizeof: #double)) ifNil: [^interpreterProxy primitiveFailFor: PrimErrBadIndex] ifNotNil: [:addr| + self memcpy: addr _: (self addressOf: floatValue put: [:v| floatValue := Float fromIEEE64Bit: v]) _: (self sizeof: #double). - self memcpy: addr _: (self addressOf: floatValue) _: (self sizeof: floatValue). ^interpreterProxy methodReturnValue: valueOop]! Item was changed: ----- Method: ThreadedFFIPlugin>>primitiveFFIFloatAt (in category 'primitives') ----- primitiveFFIFloatAt "Answer a 32-bit IEEE float the given byte offset." + <export: true flags: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> - <export: true flags: #FastCPrimitiveFlag> | byteOffset rcvr floatValue | <var: #floatValue type: #float> byteOffset := interpreterProxy stackValue: 0. rcvr := interpreterProxy stackValue: 1. (interpreterProxy isIntegerObject: byteOffset) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. (self ffiAddressOf: rcvr startingAt: (interpreterProxy integerValueOf: byteOffset) size: (self sizeof: #float)) ifNil: [^interpreterProxy primitiveFailFor: PrimErrBadIndex] ifNotNil: [:addr| + self memcpy: (self addressOf: floatValue put: [:v| floatValue := Float fromIEEE32Bit: v]) _: addr _: (self sizeof: #float). - self memcpy: (self addressOf: floatValue) _: addr _: (self sizeof: #float). ^interpreterProxy methodReturnFloat: floatValue]! Item was changed: ----- Method: ThreadedFFIPlugin>>primitiveFFIFloatAtPut (in category 'primitives') ----- primitiveFFIFloatAtPut "Store a 32-bit IEEE float the given byte offset." + <export: true flags: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> - <export: true flags: #FastCPrimitiveFlag> | byteOffset rcvr floatValue valueOop | <var: #floatValue type: #float> valueOop := interpreterProxy stackValue: 0. (interpreterProxy isFloatObject: valueOop) ifTrue: [floatValue := self cCoerce: (interpreterProxy floatValueOf: valueOop) to: #float] ifFalse: [(interpreterProxy isIntegerObject: valueOop) ifTrue: [floatValue := self cCoerce: (interpreterProxy integerValueOf: valueOop) to: #float] ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]]. byteOffset := interpreterProxy stackValue: 1. (interpreterProxy isIntegerObject: byteOffset) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. rcvr := interpreterProxy stackValue: 2. (self ffiAddressOf: rcvr startingAt: (interpreterProxy integerValueOf: byteOffset) size: (self sizeof: #float)) ifNil: [^interpreterProxy primitiveFailFor: PrimErrBadIndex] ifNotNil: [:addr| self memcpy: addr _: (self addressOf: floatValue) _: (self sizeof: floatValue). ^interpreterProxy methodReturnValue: valueOop]! Item was changed: SharedPool subclass: #VMBasicConstants instanceVariableNames: '' + classVariableNames: 'BaseHeaderSize BytecodeSetHasExtensions BytesPerOop BytesPerWord COGMTVM COGVM CloneOnGC CloneOnScavenge DisownVMForFFICall DisownVMForThreading DoAssertionChecks DoExpensiveAssertionChecks FastCPrimitiveAlignForFloatsFlag FastCPrimitiveFlag FastCPrimitiveUseCABIFlag GCCheckFreeSpace GCCheckImageSegment GCCheckPrimCall GCCheckShorten GCModeBecome GCModeFull GCModeIncremental GCModeNewSpace HashMultiplyConstant HashMultiplyMask IMMUTABILITY LowcodeVM MULTIPLEBYTECODESETS NewspeakVM PharoVM PrimErrBadArgument PrimErrBadIndex PrimErrBadMethod PrimErrBadNumArgs PrimErrBadReceiver PrimErrCallbackError PrimErrFFIException PrimErrGenericFailure PrimErrInappropriate PrimErrInternalError PrimErrLimitExceeded PrimErrNamedInternal PrimErrNeedCompaction PrimErrNoCMemory PrimErrNoMemory PrimErrNoModification PrimErrNotFound PrimErrOSError PrimErrObjectIsPinned PrimErrObjectMayMove PrimErrObjectMoved PrimErrObjectNotPinned PrimErrOperationFailed PrimErrUninitialized PrimErr Unsupported PrimErrWritePastObject PrimNoErr PrimNumberHandlerMarker PrimNumberNoContextSwitchMarker PrimNumberUnwindMarker SPURVM STACKVM SistaVM TempVectReadBarrier VMBIGENDIAN' - classVariableNames: 'BaseHeaderSize BytecodeSetHasExtensions BytesPerOop BytesPerWord COGMTVM COGVM CloneOnGC CloneOnScavenge DisownVMForFFICall DisownVMForThreading DoAssertionChecks DoExpensiveAssertionChecks FastCPrimitiveFlag GCCheckFreeSpace GCCheckImageSegment GCCheckPrimCall GCCheckShorten GCModeBecome GCModeFull GCModeIncremental GCModeNewSpace HashMultiplyConstant HashMultiplyMask IMMUTABILITY LowcodeVM MULTIPLEBYTECODESETS NewspeakVM PharoVM PrimErrBadArgument PrimErrBadIndex PrimErrBadMethod PrimErrBadNumArgs PrimErrBadReceiver PrimErrCallbackError PrimErrFFIException PrimErrGenericFailure PrimErrInappropriate PrimErrInternalError PrimErrLimitExceeded PrimErrNamedInternal PrimErrNeedCompaction PrimErrNoCMemory PrimErrNoMemory PrimErrNoModification PrimErrNotFound PrimErrOSError PrimErrObjectIsPinned PrimErrObjectMayMove PrimErrObjectMoved PrimErrObjectNotPinned PrimErrOperationFailed PrimErrUninitialized PrimErrUnsupported PrimErrWritePastObject PrimNoErr PrimNumberHand lerMarker PrimNumberNoContextSwitchMarker PrimNumberUnwindMarker SPURVM STACKVM SistaVM TempVectReadBarrier VMBIGENDIAN' poolDictionaries: '' category: 'VMMaker-Interpreter'! !VMBasicConstants commentStamp: '<historical>' prior: 0! I am a shared pool for basic constants upon which the VM as a whole depends. self ensureClassPool. self classPool declare: #BytesPerWord from: VMSqueakV3ObjectRepresentationConstants classPool. self classPool declare: #BaseHeaderSize from: VMSqueakV3ObjectRepresentationConstants classPool (ObjectMemory classPool keys select: [:k| k beginsWith: 'Byte']) do: [:k| self classPool declare: k from: ObjectMemory classPool]! Item was changed: ----- Method: VMClass>>addressOf:put: (in category 'translation support') ----- addressOf: anObject put: aBlock <doNotGenerate> "Simulate a C pointer. Translates into &anObject in C. Provides something that evaluates aBlock with the new value in response to at:put:" + | thing firstIndex things | - | thing | thing := anObject. ^CPluggableAccessor new setObject: nil; atBlock: [:obj :idx| thing] + atPutBlock: + [:obj :idx :val| + "Handle the common case of a single assignment as gracefully as possible" + (firstIndex isNil or: [firstIndex = idx]) + ifTrue: [firstIndex := idx. thing := val] + ifFalse: "handle the rare case of multiple writes through the pointer, a multi-byte assignment from memcpy:_:_: et al" + [self assert: (#(#'memcpy:_:_:' #'memmove:_:_:' #'strncpy:_:_:') includes: thisContext sender sender selector). + things ifNil: [things := OrderedCollection with: thing]. + self assert: things size + firstIndex = idx. + things addLast: val. + thing := (self objectMemory endianness == #little + ifTrue: [things] + ifFalse: [things reverse]) inject: 0 into: [:word :byte| (word bitShift: 8) + byte]]. + aBlock value: thing]! - atPutBlock: [:obj :idx :val| aBlock value: (thing := val)]!

1 0

OpenIndiana cog-spur and stack-spur 5.0.3003
by stes＠PANDORA.BE 01 Aug '21

01 Aug '21

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 OpenSmalltalk updated binaries for OpenIndiana available at: http://pkg.openindiana.org/hipster/en/search.shtml?token=cog-spur&action=Se… The cog-spur and stack-spur are both updated to 5.0.3003. However the cog-spur is actually a stub that still refers to the older 2967. The stack-spur from oscog-eem.3003 seems to work fine. Also the VEP (VectorEnginePlugin) separate package was updated to the latest "Cuis" VectorEnginePlugin; this package is optional. Regards, David Stes -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJhBxMdAAoJENdFDkXGicizRWIH/0+RyYTIY/j8VQ7PvKXDgHwy 7Y5pLh+A+2ppKj8hrRYqLpMtzzdD+2qidDAWw7X5MoghN6b/BPQgsbhd5K1r2Hu+ frvozGZq7sC5DBFtOMdNZWi4F25/888+lz2gRLxfQ6GxrQM3nzroPOov/YbZzMsJ PQ2VRMKIR64MWEo1hMe46/WeHP2486VIpET9Kwx1Lz4wAHRO4UunvIkoMvjnS372 T/9eJpqu4ApgY63XO4QAvNwsHX3s0wEEC2GCUc3QBhiUMcJKsdWwR/ZV1aMg2F3T JVcdFN/HKZd1R0i4ih7xkiG7b0fj4yAjGLQnjlx2G0hpxWcRRQyjQk3JSQLtp2E= =IcGh -----END PGP SIGNATURE-----

1 0

[OpenSmalltalk/opensmalltalk-vm] 62c17c: Fix the value of null Spur primitive metadata. Pro...
by Eliot Miranda 01 Aug '21

01 Aug '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 62c17ce555bbb79bea9bc3576eafbd78ba913551 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/62c17ce555bbb79bea… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-08-01 (Sun, 01 Aug 2021) Changed paths: M platforms/Cross/vm/sq.h M platforms/Mac OS/vm/sqMacUnixExternalPrims.c M platforms/minheadless/common/sqExternalPrimitives.c M platforms/unix/vm/sqUnixExternalPrims.c M platforms/win32/vm/sqWin32ExternalPrims.c Log Message: ----------- Fix the value of null Spur primitive metadata. Provide some defines in sq.h for comprehension.

1 0

[OpenSmalltalk/opensmalltalk-vm] 03c4ef: CogVM source as per VMMaker.oscog-eem.3009
by Eliot Miranda 01 Aug '21

01 Aug '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 03c4ef31be60a30edc1e2beb5be8e28becd8c1e5 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/03c4ef31be60a30edc… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-07-31 (Sat, 31 Jul 2021) Changed paths: M spur64src/vm/cogit.h M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/cointerpmt.c M spur64src/vm/cointerpmt.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/gcc3x-cointerpmt.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/cointerpmt.c M spursrc/vm/cointerpmt.h M spursrc/vm/gcc3x-cointerp.c M spursrc/vm/gcc3x-cointerpmt.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/plugins/ADPCMCodecPlugin/ADPCMCodecPlugin.c M src/plugins/AsynchFilePlugin/AsynchFilePlugin.c M src/plugins/B2DPlugin/B2DPlugin.c M src/plugins/BitBltPlugin/BitBltPlugin.c M src/plugins/CroquetPlugin/CroquetPlugin.c M src/plugins/FFTPlugin/FFTPlugin.c M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c M src/plugins/FilePlugin/FilePlugin.c M src/plugins/IA32ABI/IA32ABI.c M src/plugins/ImmX11Plugin/ImmX11Plugin.c M src/plugins/JPEGReaderPlugin/JPEGReaderPlugin.c M src/plugins/LargeIntegers/LargeIntegers.c M src/plugins/MIDIPlugin/MIDIPlugin.c M src/plugins/RePlugin/RePlugin.c M src/plugins/ScratchPlugin/ScratchPlugin.c M src/plugins/SocketPlugin/SocketPlugin.c M src/plugins/SoundGenerationPlugin/SoundGenerationPlugin.c M src/plugins/SoundPlugin/SoundPlugin.c M src/plugins/Squeak3D/Squeak3D.c M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c M src/plugins/SqueakFFIPrims/ARM64FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c M src/plugins/StarSqueakPlugin/StarSqueakPlugin.c M src/plugins/UnicodePlugin/UnicodePlugin.c M src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c M src/vm/cogit.h M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/gcc3x-cointerp.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3009 Spur: Fix a bad bug with computing accessor depths. Exported primitives in the StackInterpreter and subclasses had their accessor depths computed after inlining, which is too late. Add VM parameter 76 to answer the minimumUnusedHeadroom on a stack page. This is useful in checking that a FastCPrimitiveFlag primitive has not consumed too much stack.

1 0

VM Maker: VMMaker.oscog-eem.3009.mcz
by commits＠source.squeak.org 01 Aug '21

01 Aug '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3009.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3009 Author: eem Time: 31 July 2021, 10:06:09.440839 pm UUID: d75b453d-0170-480a-bcb1-d7a2721e1a10 Ancestors: VMMaker.oscog-eem.3008 Slang: fix bug in copying of TBraceCaseNode, which was forgetting to do any kind of copy at all. This caused destructive update of the parse tree of ThreadedX64SysVFFIPlugin>>#ffiCalloutTo:SpecOnStack:in: when computing its accessor depth. =============== Diff against VMMaker.oscog-eem.3008 =============== Item was added: + ----- Method: TBraceCaseNode>>postCopy (in category 'copying') ----- + postCopy + caseLabels := caseLabels collect: [:ea| ea copy]. + cases := cases collect: [:ea| ea copy]! Item was added: + ----- Method: TBraceCaseNode>>printOn:level: (in category 'printing') ----- + printOn: aStream level: level + aStream crtab: level; nextPut: ${. + caseLabels with: cases do: + [:caseLabel :case| + caseLabel printOn: aStream. + aStream nextPutAll: ' -> '. + case printOn: aStream level: level + 1. + aStream nextPut: $.]. + aStream space; nextPut: $}!

1 0

VM Maker: VMMaker.oscog-eem.3008.mcz
by commits＠source.squeak.org 01 Aug '21

01 Aug '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3008.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3008 Author: eem Time: 31 July 2021, 8:34:40.390618 pm UUID: 1e79edb0-7b90-41e3-8c4c-bf737b4b23a6 Ancestors: VMMaker.oscog-eem.3007 And in computing accessor depths at the right time make sure to use a TMethod's smalltalkSelector to not be confused by smart syntax. =============== Diff against VMMaker.oscog-eem.3007 =============== Item was changed: ----- Method: CCodeGenerator>>accessorDepthForMethod: (in category 'spur primitive compilation') ----- accessorDepthForMethod: method "Compute the depth the method traverses object structure, assuming it is a primitive. This is in support of Spur's lazy become. A primitive may fail because it may encounter a forwarder. The primitive failure code needs to know to what depth it must follow arguments to follow forwarders and, if any are found and followed, retry the primitive. This method determines that depth. It starts by collecting references to the stack and then follows these through assignments to variables and use of accessor methods such as fetchPointer:ofObject:. For example | obj field | obj := self stackTop. field := objectMemory fetchPointer: 1 ofObject: obj. self storePointer: 1 ofObject: field withValue: (self stackValue: 1) has depth 2, since field is accessed, and field is an element of obj. The information is cached since it needs to be computed *before* inlining" ^accessorDepthCache at: method smalltalkSelector ifAbsentPut: [beganInlining ifTrue: [((vmClass primitiveTable includes: method smalltalkSelector) or: [method export]) ifTrue: [-1] ifFalse: [self error: 'it is too late to compute accessor depths!!']] ifFalse: [((method definingClass includesSelector: method smalltalkSelector) ifTrue: + [(method definingClass >> method smalltalkSelector) pragmaAt: #accessorDepth:]) - [(method definingClass >> method selector) pragmaAt: #accessorDepth:]) ifNil: [((self accessorChainsForMethod: method interpreterClass: (vmClass ifNil: [StackInterpreter])) inject: 0 into: [:length :chain| length max: (self accessorDepthForChain: chain)]) - 1] ifNotNil: [:pragma| pragma arguments first]]]!

1 0

VM Maker: VMMaker.oscog-eem.3007.mcz
by commits＠source.squeak.org 01 Aug '21

01 Aug '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3007.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3007 Author: eem Time: 31 July 2021, 8:25:08.230439 pm UUID: f4cf3c82-08f5-4cbb-b32a-14e7d8d60a1b Ancestors: VMMaker.oscog-eem.3006 Spur: Fix a bad bug with computing accessor depths. Exported primitives in the StackInterpreter and suclasses had their accessor depths computed after inlining, which is too late. Compute and cache accessor depths before inlining. Fix a bad regression in primitiveAccessorDepthForExternalPrimitiveMethod:. Now that this needs a shift to eliminate the primitive flags, it must use a signed shift. Add VM parameter 76 to answer the minimumUnusedHeadroom on a stack page. This is useful in checking that a FastCPrimitiveFlag primitive has not consumed too much stack. =============== Diff against VMMaker.oscog-eem.3006 =============== Item was changed: Object subclass: #CCodeGenerator + instanceVariableNames: 'vmClass structClasses translationDict asArgumentTranslationDict inlineList constants variables variableDeclarations scopeStack methods macros apiMethods apiVariables kernelReturnTypes currentMethod headerFiles globalVariableUsage useSymbolicConstants generateDeadCode requiredSelectors previousCommentMarksInlining previousCommenter logger suppressAsmLabels asmLabelCounts pools selectorTranslations staticallyResolvedPolymorphicReceivers optionsDictionary breakSrcInlineSelectors breakDestInlineSelectors breakOnInline vmMaker accessorDepthCache beganInlining' - instanceVariableNames: 'vmClass structClasses translationDict asArgumentTranslationDict inlineList constants variables variableDeclarations scopeStack methods macros apiMethods apiVariables kernelReturnTypes currentMethod headerFiles globalVariableUsage useSymbolicConstants generateDeadCode requiredSelectors previousCommentMarksInlining previousCommenter logger suppressAsmLabels asmLabelCounts pools selectorTranslations staticallyResolvedPolymorphicReceivers optionsDictionary breakSrcInlineSelectors breakDestInlineSelectors breakOnInline vmMaker' classVariableNames: 'NoRegParmsInAssertVMs' poolDictionaries: 'VMBasicConstants' category: 'VMMaker-Translation to C'! !CCodeGenerator commentStamp: 'tpr 5/2/2003 14:30' prior: 0! This class oversees the translation of a subset of Smalltalk to C, allowing the comforts of Smalltalk during development and the efficiency and portability of C for the resulting interpreter. See VMMaker for more useful info! Item was changed: ----- Method: CCodeGenerator>>accessorDepthForMethod: (in category 'spur primitive compilation') ----- accessorDepthForMethod: method "Compute the depth the method traverses object structure, assuming it is a primitive. This is in support of Spur's lazy become. A primitive may fail because it may encounter a forwarder. The primitive failure code needs to know to what depth it must follow arguments to follow forwarders and, if any are found and followed, retry the primitive. This method determines that depth. It starts by collecting references to the stack and then follows these through assignments to variables and use of accessor methods such as fetchPointer:ofObject:. For example | obj field | obj := self stackTop. field := objectMemory fetchPointer: 1 ofObject: obj. self storePointer: 1 ofObject: field withValue: (self stackValue: 1) + has depth 2, since field is accessed, and field is an element of obj. - has depth 2, since field is accessed, and field is an element of obj." + The information is cached since it needs to be computed *before* inlining" + ^accessorDepthCache + at: method smalltalkSelector + ifAbsentPut: + [beganInlining + ifTrue: + [((vmClass primitiveTable includes: method smalltalkSelector) + or: [method export]) + ifTrue: [-1] + ifFalse: [self error: 'it is too late to compute accessor depths!!']] + ifFalse: + [((method definingClass includesSelector: method smalltalkSelector) ifTrue: + [(method definingClass >> method selector) pragmaAt: #accessorDepth:]) + ifNil: + [((self + accessorChainsForMethod: method + interpreterClass: (vmClass ifNil: [StackInterpreter])) + inject: 0 + into: [:length :chain| length max: (self accessorDepthForChain: chain)]) - 1] + ifNotNil: [:pragma| pragma arguments first]]]! - ^((method definingClass includesSelector: method selector) ifTrue: - [(method definingClass >> method selector) pragmaAt: #accessorDepth:]) - ifNil: - [((self - accessorChainsForMethod: method - interpreterClass: (vmClass ifNil: [StackInterpreter])) - inject: 0 - into: [:length :chain| length max: (self accessorDepthForChain: chain)]) - 1] - ifNotNil: [:pragma| pragma arguments first]! Item was changed: ----- Method: CCodeGenerator>>doBasicInlining: (in category 'inlining') ----- doBasicInlining: inlineFlagOrSymbol "Inline the bodies of all methods that are suitable for inlining. This method does only the basic inlining suitable for both the core VM and plugins - no bytecode inlining etc" | pass progress | + beganInlining := true. self collectInlineList: inlineFlagOrSymbol. pass := 0. progress := true. [progress] whileTrue: [ "repeatedly attempt to inline methods until no further progress is made" progress := false. ('Inlining pass ', (pass := pass + 1) printString, '...') displayProgressAt: Sensor cursorPoint from: 0 to: methods size during: [:bar | (self sortMethods: methods) withIndexDo: [:m :i | bar value: i. currentMethod := m. (m tryToInlineMethodsIn: self) ifTrue: [progress := true]]]]. ! Item was changed: ----- Method: CCodeGenerator>>doInlining: (in category 'inlining') ----- doInlining: inlineFlagOrSymbol "Inline the bodies of all methods that are suitable for inlining." "Modified slightly for the core VM translator, since the first level of inlining for the interpret loop must be performed in order that the instruction implementations can easily discover their addresses. Remember to inline the bytecode routines as well" | removed | + beganInlining := true. inlineFlagOrSymbol isSymbol ifTrue: [self inlineDispatchesInMethodNamed: #interpret localizingVars: #(). self doBasicInlining: inlineFlagOrSymbol. self pruneUnreachableMethods. ^self]. inlineFlagOrSymbol ifFalse: [self inlineDispatchesInMethodNamed: #interpret localizingVars: #(). self pruneUnreachableMethods. ^self]. self doBasicInlining: inlineFlagOrSymbol. vmClass ifNil: [^self]. 'Inlining bytecodes' displayProgressAt: Sensor cursorPoint from: 1 to: 2 during: [:bar | self inlineDispatchesInMethodNamed: #interpret localizingVars: vmClass namesOfVariablesToLocalize. bar value: 1. removed := self removeMethodsReferingToGlobals: vmClass namesOfVariablesToLocalize except: #interpret. bar value: 2]. "only prune when generating the interpreter itself" self pruneUnreachableMethods. self reportShouldNotBeRemoved: removed varList: vmClass namesOfVariablesToLocalize! Item was changed: ----- Method: CCodeGenerator>>initialize (in category 'initialize-release') ----- initialize translationDict := Dictionary new. inlineList := Array new. constants := Dictionary new: 100. variables := Set new: 100. variableDeclarations := Dictionary new: 100. methods := Dictionary new: 500. kernelReturnTypes := self computeKernelReturnTypes. macros := Dictionary new. self initializeCTranslationDictionary. headerFiles := OrderedCollection new. globalVariableUsage := Dictionary new. useSymbolicConstants := true. generateDeadCode := true. scopeStack := OrderedCollection new. self getLogger. pools := IdentitySet new. selectorTranslations := IdentityDictionary new. + accessorDepthCache := IdentityDictionary new. + beganInlining := false. suppressAsmLabels := false. previousCommentMarksInlining := false. previousCommenter := nil. breakSrcInlineSelectors := IdentitySet new. breakDestInlineSelectors := IdentitySet new! Item was changed: + ----- Method: CoInterpreter>>minimumUnusedHeadroom (in category 'stack pages') ----- - ----- Method: CoInterpreter>>minimumUnusedHeadroom (in category 'debug support') ----- minimumUnusedHeadroom "Traverse all stack pages looking for non-zero bytes in the headroom part of each page. Answer the minimum size of unused headroom (zero bytes) in the pages. This is for checking that there is enough headroom allocated in stack pages." | minUnused page | + <inline: #never> - <var: #page type: #'StackPage *'> <var: #p type: #'char *'> minUnused := (stackPages stackPageAt: 0) baseAddress - (stackPages stackPageAt: 0) lastAddress. 0 to: numStackPages - 1 do: [:i| | p unused | page := stackPages stackPageAt: i. p := page lastAddress. [p := p + objectMemory wordSize. (self longAtPointer: p) = 0 and: [p <= page baseAddress]] whileTrue. unused := p - objectMemory wordSize - page lastAddress. unused < minUnused ifTrue: [minUnused := unused]]. ^minUnused! Item was changed: ----- Method: StackInterpreter>>primitiveAccessorDepthForExternalPrimitiveMethod: (in category 'primitive support') ----- primitiveAccessorDepthForExternalPrimitiveMethod: methodObj ^(objectMemory integerValueOf: (objectMemory fetchPointer: 2 + ofObject: (self literal: 0 ofMethod: methodObj))) >>> 8! - ofObject: (self literal: 0 ofMethod: methodObj))) bitShift: -8! Item was added: + ----- Method: StackInterpreterPrimitives>>minimumUnusedHeadroom (in category 'system control primitives') ----- + minimumUnusedHeadroom + <inline: #always> + ^-1! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveAllVMParameters: (in category 'system control primitives') ----- (excessive size, no diff calculated) Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveGetVMParameter: (in category 'system control primitives') ----- primitiveGetVMParameter: arg "See primitiveVMParameter method comment. N.B. written as a returning case to avoid branch limits in the V3 bytecode set." arg caseOf: { [1] -> [^self positiveMachineIntegerFor: objectMemory oldSpaceSize]. [2] -> [^objectMemory integerObjectOf: objectMemory newSpaceSize]. [3] -> [^self positiveMachineIntegerFor: objectMemory totalMemorySize]. [6] -> [^objectMemory integerObjectOf: objectMemory tenuringThreshold]. [7] -> [^objectMemory integerObjectOf: objectMemory statFullGCs]. [8] -> [^objectMemory integerObjectOf: objectMemory statFullGCUsecs + 500 // 1000]. [9] -> [^objectMemory integerObjectOf: (objectMemory hasSpurMemoryManagerAPI ifTrue: [objectMemory statScavenges] ifFalse: [objectMemory statIncrGCs])]. [10] -> [^objectMemory integerObjectOf: (objectMemory hasSpurMemoryManagerAPI ifTrue: [objectMemory statScavengeGCUsecs] ifFalse: [objectMemory statIncrGCUsecs]) + 500 // 1000]. [11] -> [^objectMemory integerObjectOf: objectMemory statTenures]. [12] -> [^objectMemory integerObjectOf: eventTraceMask]. [13] -> [^self getVMTickerStartUSecs]. [14] -> [^self getVMTickerCount]. [15] -> [^self getVMTickeeCallCount]. [16] -> [^self positive64BitIntegerFor: statIdleUsecs]. [17] -> [^(SistaVM and: [self isCog]) ifTrue: [objectMemory floatObjectOf: self getCogCodeZoneThreshold] ifFalse: [ConstZero]]. [18] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue: [objectMemory integerObjectOf: objectMemory statCompactionUsecs + 500 // 1000] ifFalse: [ConstZero]]. [19] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue: [objectMemory integerObjectOf: objectMemory scavengeThresholdAsExtent] ifFalse: [ConstZero]]. [20] -> [^objectMemory positive64BitIntegerFor: self ioUTCStartMicroseconds]. [21] -> [^objectMemory integerObjectOf: objectMemory rootTableCount]. [22] -> [^objectMemory integerObjectOf: objectMemory statRootTableOverflows]. [23] -> [^objectMemory integerObjectOf: extraVMMemory]. [24] -> [^objectMemory integerObjectOf: objectMemory shrinkThreshold]. [25] -> [^objectMemory integerObjectOf: objectMemory growHeadroom]. [26] -> [^objectMemory integerObjectOf: self ioHeartbeatMilliseconds]. [27] -> [^objectMemory integerObjectOf: objectMemory statMarkCount]. [28] -> [^objectMemory integerObjectOf: objectMemory statSweepCount]. [29] -> [^objectMemory integerObjectOf: objectMemory statMkFwdCount]. [30] -> [^objectMemory integerObjectOf: objectMemory statCompMoveCount]. [31] -> [^objectMemory integerObjectOf: objectMemory statGrowMemory]. [32] -> [^objectMemory integerObjectOf: objectMemory statShrinkMemory]. [33] -> [^objectMemory integerObjectOf: objectMemory statRootTableCount]. [34] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue:"was statAllocationCount" [objectMemory positive64BitIntegerFor: objectMemory currentAllocatedBytes]]. [35] -> [^objectMemory integerObjectOf: objectMemory statSurvivorCount]. [36] -> [^objectMemory integerObjectOf: (self microsecondsToMilliseconds: objectMemory statGCEndUsecs)]. [37] -> [^objectMemory integerObjectOf: objectMemory statSpecialMarkCount]. [38] -> [^objectMemory integerObjectOf: objectMemory statIGCDeltaUsecs + 500 // 1000]. [39] -> [^objectMemory integerObjectOf: statPendingFinalizationSignals]. [40] -> [^objectMemory integerObjectOf: objectMemory wordSize]. [41] -> [^objectMemory integerObjectOf: self imageFormatVersion]. [42] -> [^objectMemory integerObjectOf: numStackPages]. [43] -> [^objectMemory integerObjectOf: desiredNumStackPages]. [44] -> [^objectMemory integerObjectOf: objectMemory edenBytes]. [45] -> [^objectMemory integerObjectOf: desiredEdenBytes]. [46] -> [^self getCogCodeSize]. [47] -> [^self getDesiredCogCodeSize]. [48] -> [^self getImageHeaderFlagsParameter]. [49] -> [^objectMemory integerObjectOf: self ioGetMaxExtSemTableSize]. [52] -> [^objectMemory integerObjectOf: objectMemory rootTableCapacity]. [53] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue: [objectMemory integerObjectOf: objectMemory numSegments]]. [54] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue: [objectMemory integerObjectOf: objectMemory freeSize]]. [55] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue: [objectMemory floatObjectOf: objectMemory getHeapGrowthToSizeGCRatio]]. [56] -> [^self positive64BitIntegerFor: statProcessSwitch]. [57] -> [^self positive64BitIntegerFor: statIOProcessEvents]. [58] -> [^self positive64BitIntegerFor: statForceInterruptCheck]. [59] -> [^self positive64BitIntegerFor: statCheckForEvents]. [60] -> [^self positive64BitIntegerFor: statStackOverflow]. [61] -> [^self positive64BitIntegerFor: statStackPageDivorce]. [62] -> [^self getCodeCompactionCount]. [63] -> [^self getCodeCompactionMSecs]. [64] -> [^self getCogMethodCount]. [65] -> [^self getCogVMFeatureFlags]. [66] -> [^objectMemory integerObjectOf: self stackPageByteSize]. [67] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue: [self positiveMachineIntegerFor: objectMemory maxOldSpaceSize]]. [68] -> [^objectMemory floatObjectOf: stackPages statAverageLivePagesWhenMapping]. [69] -> [^objectMemory integerObjectOf: stackPages statMaxPageCountWhenMapping]. [70] -> [^objectMemory integerObjectOf: self vmProxyMajorVersion]. [71] -> [^objectMemory integerObjectOf: self vmProxyMinorVersion]. [72] -> [^objectMemory integerObjectOf: objectMemory statMarkUsecs + 500 // 1000]. [73] -> [^objectMemory integerObjectOf: objectMemory statSweepUsecs + 500 // 1000]. [74] -> [^objectMemory hasSpurMemoryManagerAPI ifTrue: [objectMemory integerObjectOf: objectMemory statMaxAllocSegmentTime + 500 // 1000]]. + [75] -> [^objectMemory booleanObjectOf: self primitiveDoMixedArithmetic]. + [76] -> [^objectMemory integerObjectOf: self minimumUnusedHeadroom] } - [75] -> [^objectMemory booleanObjectOf: self primitiveDoMixedArithmetic] } otherwise: [^nil]! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveVMParameter (in category 'system control primitives') ----- primitiveVMParameter "Behaviour depends on argument count: 0 args: return an Array of VM parameter values; 1 arg: return the indicated VM parameter; 2 args: set the VM indicated parameter. VM parameters are numbered as follows: 1 end (v3)/size(Spur) of old-space (0-based, read-only) 2 end (v3)/size(Spur) of young/new-space (read-only) 3 end (v3)/size(Spur) of heap (read-only) 4 nil (was allocationCount (read-only)) 5 nil (was allocations between GCs (read-write) 6 survivor count tenuring threshold (read-write) 7 full GCs since startup (read-only) 8 total milliseconds in full GCs since startup (read-only) 9 incremental GCs (SqueakV3) or scavenges (Spur) since startup (read-only) 10 total milliseconds in incremental GCs (SqueakV3) or scavenges (Spur) since startup (read-only) 11 tenures of surving objects since startup or reset (read-write) 12-20 were specific to ikp's JITTER VM, now 12 16 open for use 13 if started, the start time in utc microseconds of the high-priority ticker 14 if started, the number of checkHighPriorityTickees calls 15 if started, the number of tickee calls from checkHighPriorityTickees 16 total microseconds at idle since start-up (if non-zero) 17 fraction of the code zone to use (Sista only; used to control code zone use to preserve sendAndBranchData on counter tripped callback) 18 total milliseconds in compaction phase of full GC since start-up (Spur only) 19 scavenge threshold, the effective size of eden. When eden fills to the threshold a scavenge is scheduled. Newer Spur VMs only. 20 utc microseconds at VM start-up (actually at time initialization, which precedes image load). 21 root/remembered table size (occupancy) (read-only) 22 root table overflows since startup (read-only) 23 bytes of extra memory to reserve for VM buffers, plugins, etc (stored in image file header). 24 memory threshold above which shrinking object memory (rw) 25 memory headroom when growing object memory (rw) 26 interruptChecksEveryNms - force an ioProcessEvents every N milliseconds (rw) 27 number of times mark loop iterated for current IGC/FGC (read-only) includes ALL marking 28 number of times sweep loop iterated for current IGC/FGC (read-only) 29 number of times make forward loop iterated for current IGC/FGC (read-only) 30 number of times compact move loop iterated for current IGC/FGC (read-only) 31 number of grow memory requests (read-only) 32 number of shrink memory requests (read-only) 33 number of root table entries used for current IGC/FGC (read-only) 34 Spur: bytes allocated in total since start-up or reset (read-write) (Used to be number of allocations done before current IGC/FGC (read-only)) 35 number of survivor objects after current IGC/FGC (read-only) 36 millisecond clock when current IGC/FGC completed (read-only) 37 number of marked objects for Roots of the world, not including Root Table entries for current IGC/FGC (read-only) 38 milliseconds taken by current IGC (read-only) 39 Number of finalization signals for Weak Objects pending when current IGC/FGC completed (read-only) 40 BytesPerOop for this image 41 imageFormatVersion for the VM 42 number of stack pages in use 43 desired number of stack pages (stored in image file header, max 65535) 44 size of eden, in bytes 45 desired size of eden, in bytes (stored in image file header) 46 machine code zone size, in bytes (Cog only; otherwise nil) 47 desired machine code zone size (stored in image file header; Cog only; otherwise nil) 48 various header flags. See getImageHeaderFlags. 49 max size the image promises to grow the external semaphore table to (0 sets to default, which is 256 as of writing) 50-51 nil; reserved for VM parameters that persist in the image (such as eden above) 52 root/remembered table capacity 53 number of segments (Spur only; otherwise nil) 54 total size of free old space (Spur only, otherwise nil) 55 ratio of growth and image size at or above which a GC will be performed post scavenge 56 number of process switches since startup (read-only) 57 number of ioProcessEvents calls since startup (read-only) 58 number of ForceInterruptCheck calls since startup (read-only) 59 number of check event calls since startup (read-only) 60 number of stack page overflows since startup (read-only) 61 number of stack page divorces since startup (read-only) 62 compiled code compactions since startup (read-only; Cog only; otherwise nil) 63 total milliseconds in compiled code compactions since startup (read-only; Cog only; otherwise nil) 64 the number of methods that currently have jitted machine-code 65 various VM feature flags; see getCogVMFeatureFlags 66 the byte size of a stack page 67 the max allowed size of old space (Spur only; nil otherwise; 0 implies no limit except that of the underlying platform) 68 the average number of live stack pages when scanned by GC (at scavenge/gc/become et al) (read-write) 69 the maximum number of live stack pages when scanned by GC (at scavenge/gc/become et al) (read-write) 70 the vmProxyMajorVersion (the interpreterProxy VM_MAJOR_VERSION) 71 the vmProxyMinorVersion (the interpreterProxy VM_MINOR_VERSION) 72 total milliseconds in full GCs Mark phase since startup (read-only) 73 total milliseconds in full GCs Sweep phase since startup (read-only, can be 0 depending on compactors) 74 maximum pause time due to segment allocation 75 whether the arithmetic primitives perform conversion in case of mixed SmallInteger/Float (true) or fail (false) + 76 the minimum unused headroom in all stack pages; Cog VMs only Note: Thanks to Ian Piumarta for this primitive." | paramsArraySize index | + paramsArraySize := 76. - paramsArraySize := 75. argumentCount = 0 ifTrue: [^self primitiveAllVMParameters: paramsArraySize]. argumentCount > 2 ifTrue: [^self primitiveFailFor: PrimErrBadNumArgs]. "index read & checks" index := self stackValue: (argumentCount = 1 ifTrue: [0] ifFalse: [1]). (objectMemory isIntegerObject: index) ifFalse: [^self primitiveFailFor: PrimErrBadArgument]. index := objectMemory integerValueOf: index. (index < 1 or: [index > paramsArraySize]) ifTrue: [^self primitiveFailFor: PrimErrBadIndex]. argumentCount = 1 ifTrue: "read VM parameter; written this way to avoid branch limits in V3 bytecode set" [| result | result := self primitiveGetVMParameter: index. ^self methodReturnValue: (result ifNil: [objectMemory nilObject])]. "write a VM parameter" self primitiveSetVMParameter: index arg: self stackTop! Item was changed: ----- Method: TMethod>>prepareMethodIn: (in category 'transformations') ----- prepareMethodIn: aCodeGen "Record sends of builtin operators, map sends of the special selector dispatchOn:in: with case statement nodes, and map sends of caseOf:[otherwise:] to switch statements. Declare limit variables for to:[by:]do: loops with limits that potentially have side-effects. As a hack also update the types of variables introduced to implement cascades correctly. This has to be done at the same time as this is done, so why not piggy back here?" extraVariableNumber ifNotNil: [declarations keysAndValuesDo: [:varName :decl| decl isBlock ifTrue: [self assert: ((varName beginsWith: 'cascade') and: [varName last isDigit]). locals add: varName. self declarationAt: varName put: (decl value: self value: aCodeGen), ' ', varName]]]. aCodeGen pushScope: declarations while:"N.B. nodesWithParentsDo: is bottom-up, hence replacement is destructive and conserved." [parseTree nodesWithParentsDo: [:node :parent| node isSend ifTrue: [aCodeGen ifStaticallyResolvedPolymorphicReceiverThenUpdateSelectorIn: node. (aCodeGen isBuiltinSelector: node selector) ifTrue: [node isBuiltinOperator: true. "If a to:by:do:'s limit has side-effects, declare the limit variable, otherwise delete it from the args" node selector = #to:by:do: ifTrue: [self ensureToByDoLoopLimitIsSafeAndEfficient: node in: aCodeGen]] ifFalse: + [(StackInterpreter isStackAccessor: node selector) + ifTrue: "compute and cache the accessor depth early, before inlining destroys the accessor chains" + [self export ifTrue: + [aCodeGen accessorDepthForMethod: self]] + ifFalse: + [(CaseStatements includes: node selector) ifTrue: + [parent replaceNodesIn: (Dictionary newFromPairs: { node. self buildCaseStmt: node in: aCodeGen})]. + (#(caseOf: #caseOf:otherwise:) includes: node selector) ifTrue: + [parent replaceNodesIn: (Dictionary newFromPairs: { node. self buildSwitchStmt: node parent: parent })]. + (#(printf: f:printf:) includes: node selector) ifTrue: + [self transformPrintf: node]]]]]]! - [(CaseStatements includes: node selector) ifTrue: - [parent replaceNodesIn: (Dictionary newFromPairs: { node. self buildCaseStmt: node in: aCodeGen})]. - (#(caseOf: #caseOf:otherwise:) includes: node selector) ifTrue: - [parent replaceNodesIn: (Dictionary newFromPairs: { node. self buildSwitchStmt: node parent: parent })]. - (#(printf: f:printf:) includes: node selector) ifTrue: - [self transformPrintf: node]]]]]!

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev August 2021