Vm-dev September 2021

vm-dev@lists.squeakfoundation.org

15 participants
137 discussions

[OpenSmalltalk/opensmalltalk-vm] primitiveSSLCreate fails sporadically on Windows (#554)
by Christoph Thiede 28 Oct '21

28 Oct '21

Hi all, I think this is not a new issue, but I am experiencing it with increasing frequency on my Win 10 machine: When instantiating SqueakSSL, primitiveCreate fails. I don't see an error in the console so I cannot tell more details about the error. Sometimes restarting my image helps, but right now, it does not. Other images running with the same VM (202010232046) can still access the internet via SSL. Maybe it plays a role that the affected image puts the plugin much more under stress by always holding at least one open connection to a server. Is this a known problem? Are there any workarounds? Looking forward to a fix, Christoph -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/554

5 27

[OpenSmalltalk/opensmalltalk-vm] Do not use linux-latest runner, use an older stable version. (#598)
by David T Lewis 02 Oct '21

02 Oct '21

A VM compiled on ubuntu-20.04 (aka latest) will not run on ubuntu-16.04 due to runtime library link issues. Therefore select ubuntu-18.04 as a build runner that is likely to support a wider range of existing Linux systems. Addresses this problem: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/598 -- Commit Summary -- * <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/598/commits/783c850d…">Do not use linux-latest runner, use an older stable version.</a> -- File Changes -- M .github/workflows/linux.yml (2) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/598.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/598.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/598

11 41

New unicode plugin
by Bruce O'Neel 01 Oct '21

01 Oct '21

HI, On my arm64 system the unicode plugin is disabled. But on my two Raspberry PI Arm 32 systems, one old and one new, the unicode plugin tries to build but fails because @UNICODE_PLUGIN_CFLAGS@ is not substituted. What debian package is it trying to find the cflags for? Thanks. bruce

4 9

[OpenSmalltalk/opensmalltalk-vm] 41d426: Win64:
by Eliot Miranda 01 Oct '21

01 Oct '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 41d4265dabd70568eeb45846e169a1c20f6ea74c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/41d4265dabd70568ee… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-09-30 (Thu, 30 Sep 2021) Changed paths: M platforms/win32/vm/sqWin32Backtrace.c Log Message: ----------- Win64: Hack around an apparent bug with Win64 exception delivery in that the vectored exception handler is given a Context whose frame pointer (rbp) is two words off. Have backtrace_from_fp look a few words away from a frame pointer if is invalid. Correct a slip in backtrace in computing the starting frame pointer. We now get a meaningful stack trace in optimized MSVC/Clang builds.

1 0

[OpenSmalltalk/opensmalltalk-vm] 28ded8: CogVM source as per VMMaker.oscog-eem.3080
by Eliot Miranda 30 Sep '21

30 Sep '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 28ded868bc36c232c4e18b99756a5985c884e3ff https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/28ded868bc36c232c4… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-09-30 (Thu, 30 Sep 2021) Changed paths: M src/plugins/FilePlugin/FilePlugin.c M src/plugins/Matrix2x3Plugin/Matrix2x3Plugin.c M src/plugins/MiscPrimitivePlugin/MiscPrimitivePlugin.c M src/plugins/ScratchPlugin/ScratchPlugin.c M src/plugins/Squeak3D/Squeak3D.c M src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3080 Spur: Fix bad bug in comptation of accessor depths for primitives. The algorithm was fooled by code which assigned through an oject accessor, e.g. bm := interpreterProxy arrayValueOf: (interpreterProxy stackValue: 1). as opposed to bmOop := interpreterProxy stackValue: 1. bm := interpreterProxy arrayValueOf: bmOop. In any case rewrite primitiveCompressToByteArray & primitiveDecompressFromByteArray to avoid the repeated slow stack accesses. Generate fresh src/spur64.stack code because these had a modified Monticello package stamp.

1 0

VM Maker: VMMaker.oscog-eem.3080.mcz
by commits＠source.squeak.org 30 Sep '21

30 Sep '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3080.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3080 Author: eem Time: 30 September 2021, 1:53:54.974044 pm UUID: ce2200b5-6a9f-4819-a0b7-a1ea8e2458a4 Ancestors: VMMaker.oscog-eem.3079 Spur: Fix bad bug in comptation of accessor depths for primitives. The algorithm was fooled by code which assigned through an oject accessor, e.g. bm := interpreterProxy arrayValueOf: (interpreterProxy stackValue: 1). as opposed to bmOop := interpreterProxy stackValue: 1. bm := interpreterProxy arrayValueOf: bmOop. In any case rewrite primitiveCompressToByteArray & primitiveDecompressFromByteArray to avoid the repeated slow stack accesses. =============== Diff against VMMaker.oscog-eem.3079 =============== Item was changed: ----- Method: CCodeGenerator>>accessorChainsForMethod:interpreterClass: (in category 'spur primitive compilation') ----- accessorChainsForMethod: method interpreterClass: interpreterClass "Answer a set of access paths from arguments through objects, in the method, assuming it is a primitive. This is in support of Spur's lazy become. A primitive may fail because it may encounter a forwarder. The primitive failure code needs to know to what depth it must follow arguments to follow forwarders and, if any are found and followed, retry the primitive. This method determines that depth. It starts by collecting references to the stack and then follows these through assignments to variables and use of accessor methods such as fetchPointer:ofObject:. For example | obj field | obj := self stackTop. field := objectMemory fetchPointer: 1 ofObject: obj. self storePointer: 1 ofObject: field withValue: (self stackValue: 1) has depth 2, since field is accessed, and field is an element of obj." | accessors assignments roots chains extendedChains extended lastPass | self accessorsAndAssignmentsForMethod: method actuals: (self actualsForMethod: method) depth: 0 interpreterClass: interpreterClass into: [:theRoots :theAccessors :theAssignments| roots := theRoots. accessors := theAccessors. assignments := theAssignments]. "Compute the transitive closure of assignments of accessor sends or variables to variables from the roots. Start from the stack accesses (the roots). On the last pass look only for accessors of the targets of the tip assignments." chains := OrderedCollection new. + roots do: + [:root| + chains + addAll: (assignments + select: [:assignment| assignment expression = root] + thenCollect: [:assignment| OrderedCollection with: assignment]); + addAll: (accessors + select: [:accessor| accessor anySatisfy: [:subnode| subnode = root]] + thenCollect: [:accessor| OrderedCollection with: accessor])]. - roots do: [:root| chains addAll: (assignments - select: [:assignment| assignment expression = root] - thenCollect: [:assignment| OrderedCollection with: assignment])]. lastPass := false. [extended := false. extendedChains := OrderedCollection new: chains size * 2. chains do: [:chain| | tip refs accessorRefs variableRefs | + chain last isAssignment + ifTrue: + [tip := chain last variable. + refs := accessors select: [:send| send args anySatisfy: [:arg| tip isSameAs: arg]]] + ifFalse: + [tip := chain last. + refs := #()]. - tip := chain last variable. - refs := accessors select: [:send| send args anySatisfy: [:arg| tip isSameAs: arg]]. lastPass ifFalse: [accessorRefs := refs collect: [:send| assignments detect: [:assignment| assignment expression = send and: [(chain includes: assignment) not]] ifNone: []] thenSelect: [:assignmentOrNil| assignmentOrNil notNil]. variableRefs := assignments select: [:assignment| (tip isSameAs: assignment expression) and: [(tip isSameAs: assignment variable) not and: [(chain includes: assignment) not]]]. refs := (Set withAll: accessorRefs) addAll: variableRefs; yourself]. refs isEmpty ifTrue: [extendedChains add: chain] ifFalse: [lastPass ifFalse: [extended := true]. self assert: (refs noneSatisfy: [:assignment| chain includes: assignment]). extendedChains addAll: (refs collect: [:assignment| chain, {assignment}])]]. extended or: [lastPass not]] whileTrue: [chains := extendedChains. extended ifFalse: [lastPass := true]]. ^chains! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveCompressToByteArray (in category 'primitives') ----- primitiveCompressToByteArray "Bitmap compress: bm toByteArray: ba" <export: true flags: #FastCPrimitiveFlag> + | bmOop baOop bm ba eqBytes i j k lowByte size destSize word | - | bm ba eqBytes i j k lowByte size destSize word | <var: 'ba' type: #'unsigned char *'> <var: 'bm' type: #'int *'> + bmOop := interpreterProxy stackValue: 1. + baOop := interpreterProxy stackValue: 0. + bm := self cCode: [interpreterProxy arrayValueOf: bmOop] - bm := self cCode: [interpreterProxy arrayValueOf: (interpreterProxy stackValue: 1)] inSmalltalk: [interpreterProxy + cCoerce: (interpreterProxy arrayValueOf: bmOop) - cCoerce: (interpreterProxy arrayValueOf: (interpreterProxy stackValue: 1)) to: #'int *']. interpreterProxy failed ifTrue: [^nil]. + (interpreterProxy isBytes: baOop) ifFalse: - (interpreterProxy isBytes: (interpreterProxy stackValue: 0)) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. + (interpreterProxy isOopImmutable: baOop) ifTrue: - (interpreterProxy isOopImmutable: (interpreterProxy stackValue: 0)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. + ba := interpreterProxy firstIndexableField: baOop. - ba := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 0). size := interpreterProxy sizeOfSTArrayFromCPrimitive: bm. destSize := interpreterProxy sizeOfSTArrayFromCPrimitive: ba. interpreterProxy failed ifTrue: "the sizeOfSTArrayFromCPrimitive:'s fail for e.g. CompiledMethod" [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. destSize < ((size * 4) + 7 + (size // 1984 * 3)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrUnsupported]. "Size may be OK but we don't know, hence fail with unsupported" i := self encodeInt: size in: ba at: 0. k := 0. [k < size] whileTrue: [word := bm at: k. lowByte := word bitAnd: 255. eqBytes := (word >> 8 bitAnd: 255) = lowByte and: [(word >> 16 bitAnd: 255) = lowByte and: [(word >> 24 bitAnd: 255) = lowByte]]. j := k. [j + 1 < size and: [word = (bm at: j + 1)]] whileTrue: [j := j + 1]. j > k ifTrue: [eqBytes ifTrue: [i := self encodeInt: j - k + 1 * 4 + 1 in: ba at: i. ba at: i put: lowByte. i := i + 1] ifFalse: [i := self encodeInt: j - k + 1 * 4 + 2 in: ba at: i. i := self encodeBytesOf: word in: ba at: i]. k := j + 1] ifFalse: [eqBytes ifTrue: [i := self encodeInt: 1 * 4 + 1 in: ba at: i. ba at: i put: lowByte. i := i + 1. k := k + 1] ifFalse: [[j + 1 < size and: [(bm at: j) ~= (bm at: j + 1)]] whileTrue: [j := j + 1]. j + 1 = size ifTrue: [j := j + 1]. i := self encodeInt: j - k * 4 + 3 in: ba at: i. k to: j - 1 by: 1 do: [ :m | i := self encodeBytesOf: (bm at: m) in: ba at: i]. k := j]]]. interpreterProxy methodReturnInteger: i! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveDecompressFromByteArray (in category 'primitives') ----- primitiveDecompressFromByteArray "Bitmap decompress: bm fromByteArray: ba at: index" <export: true flags: #FastCPrimitiveFlag> + | bmOop baOop bm ba index i anInt code data end k n pastEnd | - | bm ba index i anInt code data end k n pastEnd | <var: 'ba' type: #'unsigned char *'> <var: 'bm' type: #'int *'> <var: 'anInt' type: #'unsigned int'> <var: 'code' type: #'unsigned int'> <var: 'data' type: #'unsigned int'> <var: 'n' type: #'unsigned int'> + bmOop := interpreterProxy stackValue: 2. + baOop := interpreterProxy stackValue: 1. + bm := self cCode: [interpreterProxy arrayValueOf: bmOop] - bm := self cCode: [interpreterProxy arrayValueOf: (interpreterProxy stackValue: 2)] inSmalltalk: [interpreterProxy + cCoerce: (interpreterProxy arrayValueOf: bmOop) - cCoerce: (interpreterProxy arrayValueOf: (interpreterProxy stackValue: 2)) to: #'int *']. + (interpreterProxy isOopImmutable: bmOop) ifTrue: - (interpreterProxy isOopImmutable: (interpreterProxy stackValue: 2)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. + (interpreterProxy isBytes: baOop) ifFalse: - (interpreterProxy isBytes: (interpreterProxy stackValue: 1)) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. + ba := interpreterProxy firstIndexableField: baOop. - ba := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 1). index := interpreterProxy stackIntegerValue: 0. end := interpreterProxy sizeOfSTArrayFromCPrimitive: ba. pastEnd := interpreterProxy sizeOfSTArrayFromCPrimitive: bm. interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. i := index - 1. k := 0. [i < end] whileTrue: [anInt := ba at: i. i := i + 1. anInt <= 223 ifFalse: [anInt <= 254 ifTrue: [anInt := anInt - 224 * 256 + (ba at: i). i := i + 1] ifFalse: [anInt := 0. 1 to: 4 by: 1 do: [ :j | anInt := (anInt bitShift: 8) + (ba at: i). i := i + 1]]]. n := anInt >> 2. k + n > pastEnd ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. code := anInt bitAnd: 3. "code = 0 ifTrue: [nil]." code = 1 ifTrue: [data := ba at: i. i := i + 1. data := data bitOr: (data bitShift: 8). data := data bitOr: (data bitShift: 16). 1 to: n do: [ :j | bm at: k put: data. k := k + 1]]. code = 2 ifTrue: [data := 0. 1 to: 4 do: [ :j | data := (data bitShift: 8) bitOr: (ba at: i). i := i + 1]. 1 to: n do: [ :j | bm at: k put: data. k := k + 1]]. code = 3 ifTrue: [1 to: n do: [ :m | data := 0. 1 to: 4 do: [ :j | data := (data bitShift: 8) bitOr: (ba at: i). i := i + 1]. bm at: k put: data. k := k + 1]]]. interpreterProxy pop: interpreterProxy methodArgumentCount!

1 0

[OpenSmalltalk/opensmalltalk-vm] 65d9d8: Fix symbolic C stack backtrace in WIN64 builds.
by Eliot Miranda 30 Sep '21

30 Sep '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 65d9d814015f68f472966bdd6ee0263bd4d1c9e0 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/65d9d814015f68f472… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-09-29 (Wed, 29 Sep 2021) Changed paths: M platforms/win32/vm/sqWin32Backtrace.c M platforms/win32/vm/sqWin32Main.c Log Message: ----------- Fix symbolic C stack backtrace in WIN64 builds. In a CLang-compiled debug VM we now see Stack backtrace: [00007FF7B97495AC] indirect + 0x6c in VirtendConsole.exe [00007FF7B97494B8] crashInThisOrAnotherThread + 0x48 in VirtendConsole.exe [00007FF7B966E8D6] primitiveCrashVM + 0xe6 in VirtendConsole.exe [00007FF7B965A83F] primitiveExternalCall + 0x2bf in VirtendConsole.exe [00007FF7B9653B1F] interpretMethodFromMachineCode + 0x2ff in VirtendConsole.exe [00007FF7B96593C2] ceSendsupertonumArgs + 0xc72 in VirtendConsole.exe [000000000003B863] ??? + 0x0 in (null) Alas in a Clang-compiled -O2 VM we see only Stack backtrace: [00007FF7EAEF7593] indirect + 0x43 in VirtendConsole.exe [00007FF7F3446A58] ??? + 0x0 in (null) So still some investigation of Clang code generation is required, but the basic facility works if the stack can be walked.

1 0

VM Maker: VMMaker.oscog-eem.3079.mcz
by commits＠source.squeak.org 29 Sep '21

29 Sep '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3079.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3079 Author: eem Time: 29 September 2021, 11:25:53.371526 am UUID: 7d3c0c0f-23b9-4dc2-bf4f-548035ecbd58 Ancestors: VMMaker.oscog-mt.3078 VMMaker: don't generate nedless exampleFoo.h files; just one ciopy in src is sufficient. StackInterpreter: fix a compilation warning. =============== Diff against VMMaker.oscog-mt.3078 =============== Item was changed: ----- Method: CrossPlatformVMMaker>>interpreterExportsFilePath (in category 'generate sources') ----- interpreterExportsFilePath "Return the full path for the interpreter exports file. Since we're leaving it up to platform makefiles to specify the actual named prims, just produce an example file." + ^self makefileDirectory fullNameFor: 'exampleSqNamedPrims.h'! - ^self coreVMDirectory fullNameFor: 'exampleSqNamedPrims.h'! Item was changed: ----- Method: StackInterpreter>>longPrintOop: (in category 'debug printing') ----- longPrintOop: oop <export: true> "useful for VM debugging; use export: not api, so it will be accessible on win32 and won't be written to cointerp.h" | fmt lastIndex startIP column cls | - <var: 'field16' type: #'unsigned short'> - <var: 'field32' type: #'unsigned int'> - <var: 'field64' type: #usqLong> (objectMemory isImmediate: oop) ifTrue: [^objectMemory printImmediateObject: oop on: transcript]. (objectMemory addressCouldBeObj: oop) ifFalse: [^objectMemory printCantBeObject: oop on: transcript]. (objectMemory isFreeObject: oop) ifTrue: [^objectMemory printFreeObject: oop on: transcript]. (objectMemory isForwarded: oop) ifTrue: [^objectMemory printForwarder: oop on: transcript]. (cls := objectMemory fetchClassOfNonImm: oop) ifNil: ['16r%lx has a nil class!!!!\n' f: transcript printf: oop] ifNotNil: [| className length | className := self nameOfClass: cls lengthInto: (self addressOf: length put: [:v| length := v]). '16r%lx: a(n) %.*s' f: transcript printf: {oop. length. className }. objectMemory hasSpurMemoryManagerAPI ifTrue: ['(%lx=>16r%lx)' f: transcript printf: { objectMemory compactClassIndexOf: oop. cls }]]. fmt := objectMemory formatOf: oop. ' format %lx' f: transcript printf: fmt. fmt > objectMemory lastPointerFormat ifTrue: [' nbytes %ld' f: transcript printf: (objectMemory numBytesOf: oop)] ifFalse: [(objectMemory isIndexableFormat: fmt) ifTrue: [| len | len := objectMemory lengthOf: oop. ' size %ld' f: transcript printf: len - (objectMemory fixedFieldsOf: oop format: fmt length: len)]]. objectMemory printHeaderTypeOf: oop on: transcript. self print: ' hash '; printHexnp: (objectMemory rawHashBitsOf: oop). self cr. (fmt between: objectMemory firstLongFormat and: objectMemory firstCompiledMethodFormat - 1) ifTrue: ["This will answer false if splObj: ClassAlien is nilObject" (self is: oop KindOfClass: (objectMemory splObj: ClassAlien)) ifTrue: [^' datasize %ld %s @ %p\n' f: transcript printf: {objectMemory sizeFieldOfAlien: oop. (self isIndirectAlien: oop) ifTrue: ['indirect'] ifFalse: [(self isPointerAlien: oop) ifTrue: ['pointer'] ifFalse: ['direct']]. (self startOfAlienData: oop) asUnsignedInteger }]. (self is: oop KindOfClass: (self superclassOf: (objectMemory splObj: ClassString))) ifTrue: [^objectMemory printStringDataOf: oop on: transcript]. ^objectMemory printNonPointerDataOf: oop on: transcript]. "this is nonsense. apologies." startIP := (objectMemory lastPointerOf: oop) + objectMemory bytesPerOop - objectMemory baseHeaderSize / objectMemory bytesPerOop. lastIndex := 256 min: startIP. lastIndex > 0 ifTrue: [1 to: lastIndex do: [:i| | fieldOop | fieldOop := objectMemory fetchPointer: i - 1 ofObject: oop. self space; printNum: i - 1; space; printHex: fieldOop; space. (i = 1 and: [objectMemory isCompiledMethod: oop]) ifTrue: [self printMethodHeaderOop: fieldOop] ifFalse: [self printOopShortInner: fieldOop]. self cr]]. (objectMemory isCompiledMethod: oop) ifFalse: [startIP > lastIndex ifTrue: [self print: '...'; cr]] ifTrue: [startIP := startIP * objectMemory wordSize + 1. lastIndex := objectMemory lengthOf: oop. lastIndex - startIP > 100 ifTrue: [lastIndex := startIP + 100]. column := 1. startIP to: lastIndex do: [:index| | byte | column = 1 ifTrue: ['16r%08p: ' f: transcript printf: (oop + BaseHeaderSize + index - 1) asVoidPointer]. byte := objectMemory fetchByte: index - 1 ofObject: oop. '%02x/%-3d%c' f: transcript printf: { byte. byte. column = 8 ifTrue: [Character cr] ifFalse: [Character space] }. (column := column + 1) > 8 ifTrue: [column := 1]]. (column between: 2 and: 7) ifTrue: [self cr]]! Item was changed: Object subclass: #VMMaker + instanceVariableNames: 'inline forBrowser allPlugins internalPlugins externalPlugins platformName sourceDirName platformRootDirName logger interpreterClassName is64BitVM optionsDictionary abortBlock sourceDirectory coreVMDirectory' - instanceVariableNames: 'inline forBrowser allPlugins internalPlugins externalPlugins platformName sourceDirName platformRootDirName logger interpreterClassName is64BitVM optionsDictionary abortBlock' classVariableNames: 'DirNames' poolDictionaries: '' category: 'VMMaker-Building'! !VMMaker commentStamp: 'eem 3/27/2017 15:46' prior: 0! This class coordinates generating sources for the various VMs and the set of plugins that comprise the Cog VM. See the class side for generating all or some configurations. The source is intended to be generated in the context of the opensmalltalk-vm source tree available via git from https://github.com/OpenSmalltalk/opensmalltalk-vm. See VMMaker class>>initialize for the relative locations of this image and the source tree (for example, in the image directory of the opensmalltalk-vm tree). Invoke a single configuration via e.g. VMMaker generateSqueakSpurCog64VM or a set via e.g. VMMaker generateAllConfigurationsUnderVersionControl The source tree on branch Cog at https://github.com/OpenSmalltalk/opensmalltalk-vm is generated via generateAllConfigurationsUnderVersionControl. Note that "Squeak" in these cofiguarations means virtual machines that support various versions of Squeak, Pharo and Cuis smalltalks. IIABDFI. Words to the wise: In the old days, VM sources would be generated per-platform. Now, all the source generated by the above generators and included in https://github.com/OpenSmalltalk/opensmalltalk-vm is separately versioned, and we use only CrossPlatformVMMaker to generate them. All platform-specific variations, such as whether to use a struct to hold the interpreter's global variables, which plugins to include in a VM, etc, are included in the generated osurce. All plugins are generated such that they can be compiled as either internal or external plugins. What specific variations to use are therefore controlled by the platform-specific makefiles, and the decision is deferred from source generation time to VM build time. The source is designed to be platform neutral. This form is chosen carefully to allow VMs to be built from fully checked-in, and hence fully versioned source. Old commentary: This class builds a VM codebase from the in-image and on-file code. The platforms file tree you need can be downloaded via cvs from http://squeak.Sourceforge.net. See also the swiki (http://minnow.cc.gatech.edu/squeak/2106) for instructions. It is fairly configurable as to where directories live and can handle multiple platform's source trees at once. It's main purpose is to allow easy building of source trees with any combination of internal/external/unused plugins to suit your platform needs and capabilities. For example, the Acorn has no need of Sound or AsynchFile plugins since I haven't written any platform code for them. There is a simple UI tool for this VMMakerTool openInWorld will open a reasonably self explanatory tool with balloon help to explain all the fields - and a help window on top of that. There are some simple workspace & inspector commands, allowing scripted building: VMMaker default initializeAllExternal generateEntire for example will build sources for a system with all the plugins external whereas VMMaker default initializeAllInternal generateEntire would build all applicable plugins for internal compilation. (VMMaker forPlatform: 'Mac OS') initializeAllExternal generateEntire would build a source tree for a Mac even on a Windows machine (err, ignoring for now the irritation of lineends). If you have a slightly more complex configuration you want to use, perhaps with Socket and Serial support external (because for your case they are rarely used and saving the space has some value) then you could try (VMMaker default initializeAllInternalBut: #(SocketPlugin SerialPlugin) generateEntire More complex still would be (VMMaker default initializeInternal: #(BitBltPlugin MiscPrimsPlugin FilePlugin) external: #(SocketPlugin ZipPlugin B2DPlugin) which allows you to precisely list all the plugins to use. WARNING If you miss out a plugin you need, it won't be there. This message is really best suited to use by a UI like VMMakerTool. To save a configuration for later use, you need to send #saveConfiguration to an active instance of VMMaker. Obviously you could simply use (VMMaker default initializeAllInternalBut: #(SocketPlugin SerialPlugin) saveConfiguration but inspecting VMMaker default and altering the internalPlugins and externalPlugins or the boolean flags for inline or forBrowser followed by saving the configuration allows ultimate power for now. To load a saved configuration file, use #loadConfigurationFrom: aFilename whilst inspecting a VMMaker. The loaded state will completely override any pre-existing state, so take care. You can generate only parts of the source tree if you wish; as shown above #generateEntire will create the whole collection of internal and external plugins as well as the core VM. To create only the external plugins use #generateExternalPlugins, or create a single plugin with #generateExternalPlugin: name. To assemble the main VM including the internal plugins, use #generateMainVM. The interpreter 'interp.c' file is made with #generateInterpreterFile. You can generate a single internal plugin with #generateInternalPlugin: only if it has already been generated before; this interlocking is intended to make sure the named primitive table in the vm is correct. There are some rules to observe in order to use this:- - under the working directory (by default - you can configure it) you need a directory called 'platforms' (also configurable) with subdirectories named as the platform names returned by Smalltalk platformName (ie unix, RiscOS, Mac OS, etc - this isn't configurable). At the very least you need the one for your own platform and the pseudo-platform called 'Cross'. By adding a 'DirNames' entry for #machineType you can cross 'compile' for some other platform. Now all we need is a cross-compiler for the C code :-) - under this directory you must have a simple structure of directories for each generated plugin that you support on the platform, plus 'vm'. In each directory you place any/all platform specific files (and subdirectories) for that plugin. In 'misc' you can place any miscellaneous files such as makefiles, resources etc. For example, for unix you have platforms/ unix/ plugins/ AsynchFilePlugin / sqUnixAsynchfile.c vm/ sqGnu.h Profile/ misc/ makefile.in util/ ...etc Any plugins requiring platform files that you don't support shouldn't appear in the resulting code tree. If you try to include an unsupported plugin in the list to be made external, the VMMaker simply ignores it. However, if you include it in the list to be made internal you will get an error since that seems like a potentially serious source of confusion. There are three lists of plugins maintained herein:- 1) the list of all known generatable plugins. We scan this list and compare with the supported plugins as indicated by the file tree. 2) the list of chosen internal plugins. 3) the list of chosen external plugins. See initializeAllPlugins, initialiseAllExternal etc for fairly obvious usage. There is also a short list of directory names in the class variable 'DirNames' that you can alter if needed. Known problems:- a) since Squeak has really poor filename handling, you can't simply change the directory names to '/foo/bar/myEvilCodeBase' and expect it to work. You fix file names and I'll fix VMMaker :-) b) Squeak copying of a file loses the assorted permissions, filetype info and other useful bits. To workaround this problem, see the FileCopyPlugin, which provides the platform independent part of a simple access for the OS filecopy capability. So far there are functional plugins for unix, Mac and Acorn. DOS machines appear not to need one. This is less of a problem in practise now that unix, Acorn & Mac no longer copy files from /platforms to /src. inline <Boolean> - is the generated code to be inlined or not forBrowser <Boolean> - is this to be a build for in-Browser use? Only relevent to Macs allPlugins <Collection> - all the known possible plugins internalPlugins <Collection> - the plugins chosen to be generated for internal linking externalPlugins <Collection> - the plugins intended to be external plugins exportList <Collection> - a list of function names exported from plugins intended to be internal platformName <String> - the name of the platform for which we are building a source tree. It is possible to do 'cross-compiles' sourceDirName, platformRootDirName <String> - the name of the directory into which we write the generated sources and the name of the directory where we should find the platforms tree.! Item was changed: ----- Method: VMMaker>>coreVMDirectory (in category 'target directories') ----- coreVMDirectory "return the target directory for the main VM sources, interp.c etc" + ^coreVMDirectory ifNil: + [coreVMDirectory := self sourceDirectory directoryNamed: self class coreVMDirName. + coreVMDirectory assureExistence. + coreVMDirectory]! - | fd | - fd := self sourceDirectory directoryNamed: self class coreVMDirName. - fd assureExistence. - ^ fd! Item was changed: ----- Method: VMMaker>>generateExportsFile (in category 'exports') ----- generateExportsFile "Store the exports on the given file" + | cg contents filePath fileStream isExample | - | cg contents filePath fileStream | filePath := self interpreterExportsFilePath. "don't bother endlessly regenerating the example file." + isExample := filePath includesSubstring: 'example'. (internalPlugins isEmpty + and: [isExample - and: [(filePath includesSubstring: 'example') and: [FileDirectory default fileExists: filePath]]) ifTrue: [^self]. cg := self createCodeGenerator. cg vmClass: self interpreterClass. contents := String streamContents: + [:s| | plugins | + s nextPutAll: '/* This is an '; + nextPutAll: (isExample ifTrue: ['example of an '] ifFalse: ['']); + nextPutAll: 'automatically generated table of all builtin modules in the VM'; + crtab; - [:s| - s - nextPutAll:'/* This is an automatically generated table of all builtin modules in the VM'; - cr; - next: 3 put: Character space; nextPutAll: (cg shortMonticelloDescriptionForClass: cg vmClass); - cr; - nextPutAll:' */'; cr. + isExample ifTrue: + [s nextPutAll: ' A real sqNamedPrims.h is generated from plugins.int by either mkNamedPrims.sh or mkNamedPrims.c'; + cr]. + s nextPutAll:' */'; + cr. + s cr; nextPutAll: 'extern sqExport vm_exports[];'. - s cr; nextPutAll:'extern sqExport vm_exports[];'. s cr; nextPutAll: 'extern sqExport os_exports[];'. + plugins := internalPlugins ifEmpty: + #(BitBltSimulation FilePlugin LargeIntegersPlugin MiscPrimitivePlugin SoundPlugin ThreadedFFIPlugin UUIDPlugin). + self plugins: plugins do: + [:cls| s cr; nextPutAll: 'extern sqExport '; nextPutAll: cls moduleName; nextPutAll: '_exports[];' ]. - self internalPluginsDo:[:cls| - s cr; nextPutAll: 'extern sqExport '; nextPutAll: cls moduleName; nextPutAll:'_exports[];'. - ]. s cr. + s cr; nextPutAll: 'sqExport *pluginExports[] = {'. + s crtab; nextPutAll: 'vm_exports,'. - s cr; nextPutAll:'sqExport *pluginExports[] = {'. - s crtab; nextPutAll:'vm_exports,'. s crtab; nextPutAll: 'os_exports,'. + self plugins: plugins do: + [:cls| s crtab; nextPutAll: cls moduleName; nextPutAll: '_exports,']. + s crtab; nextPutAll: 'NULL'. + s cr; nextPutAll: '};'; cr]. - self internalPluginsDo:[:cls| - s crtab; nextPutAll: cls moduleName; nextPutAll:'_exports,' - ]. - s crtab; nextPutAll:'NULL'. - s cr; nextPutAll:'};'; cr]. (cg needToGenerateHeader: (FileDirectory baseNameFor: filePath) file: filePath contents: contents) ifTrue: [[fileStream := VMMaker forceNewFileNamed: filePath] on: FileDoesNotExistException do:[^self couldNotOpenFile: filePath]. fileStream nextPutAll: contents; close]! Item was changed: ----- Method: VMMaker>>makefileDirectory (in category 'target directories') ----- makefileDirectory + "where to put generated makefile related files. + N.B. If generating sources to a variant-specific subdirectory of the main source directory + (inferred by self sourceDirectory containingDirectory localName = 'src') + then generate in that parent, rather than diplicate in all variant-specific subdirectories." + | parent | + ^(parent := self sourceDirectory containingDirectory) localName = 'src' + ifTrue: [parent] + ifFalse: [self sourceDirectory]! - "where to put generated makefile related files" - ^self sourceDirectory! Item was changed: ----- Method: VMMaker>>sourceDirectory (in category 'target directories') ----- sourceDirectory + ^sourceDirectory ifNil: + [sourceDirectory := FileDirectory default directoryNamed: self sourceDirectoryName. + sourceDirectory assureExistence. + sourceDirectory]! - | fd | - fd := FileDirectory default directoryNamed: self sourceDirectoryName. - fd assureExistence. - ^fd!

1 0

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] CogVM source as per VMMaker.oscog-eem.3076 (c6b7045)
by Eliot Miranda 29 Sep '21

29 Sep '21

On Wed, Sep 29, 2021 at 8:55 AM Marcel Taeumel ***(a)***.***> wrote: > I did that already. Please double-check whether I broke stuff. :-) Wasn't > much. > Cool; thanks! > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c6b70458764ba471a1…>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADY5VUEGGLCRSU2AMC46BUTUE…> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&m…> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=u…>. > > -- _,,,^..^,,,_ best, Eliot -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c6b70458764ba471a1…

1 0

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] CogVM source as per VMMaker.oscog-eem.3076 (c6b7045)
by Marcel Taeumel 29 Sep '21

29 Sep '21

I did that already. Please double-check whether I broke stuff. :-) Wasn't much. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c6b70458764ba471a1…

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev September 2021