Vm-dev January 2022

vm-dev@lists.squeakfoundation.org

15 participants
50 discussions

[OpenSmalltalk/opensmalltalk-vm] primitiveTranslateStringWithTable modifies symbols in place, it should be reserved for non-literal strings only (#561)
by fmateoc 21 Feb '22

21 Feb '22

After making sure a string was not interned, ( "Symbol findInterned: 'test123'" returned nil ), I did | s | s := #TEST123. s translateToLowercase. s -> (Symbol findInterned: s) and the resulting s is a Symbol and it is not interned. To make sure that the primitive is invoked (and not its fallback code), put a halt in ByteString class >> #translate:from:to:table: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/561

2 2

[OpenSmalltalk/opensmalltalk-vm] squeak.cog.spur_linux32ARMv6_202003021730 ---- seg fault on Cuis image (#597)
by Dr. Nicola Mingotti 20 Feb '22

20 Feb '22

Hi guys, i report you that according to my latest tests with Cuis on a BeagleBone Black the VM in the title is not running. But the latest-build does run ! bye ================= output ================================== root@beaglebone:~/cuis-project# ./sqcogspurlinuxhtRPi/squeak Cuis-Smalltalk-Dev/Cuis5.0-4834-32.image Segmentation fault Wed Sep 15 15:55:11 2021 /root/cuis-project/sqcogspurlinuxhtRPi/lib/squeak/5.0-202003021730/squeak Squeak VM version: 5.0-202003021730 Tue Mar 3 09:42:45 UTC 2020 gcc 4.9.2 [Production Spur VM] Built from: CoInterpreter VMMaker.oscog-nice.2712 uuid: da64ef0b-fb0a-4770-ac16-f9b448234615 Mar 3 2020 With: StackToRegisterMappingCogit VMMaker.oscog-eem.2719 uuid: e40f3e94-3a54-411b-9613-5d19114ea131 Mar 3 2020 Revision: VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Build host: Linux travis-job-97835d24-79f4-41d1-b7e9-c81bd8bf7149 4.4.0-104-generic #127~14.04.1-Ubuntu SMP Mon Dec 11 12:44:15 UTC 2017 armv7l GNU/Linux plugin path: ./sqcogspurlinuxhtRPi/lib/squeak/5.0-202003021730 [default: /root/cuis-project/sqcogspurlinuxhtRPi/lib/squeak/5.0-202003021730/] C stack backtrace & registers: r0 0x00000000 r1 0x03004c70 r2 0x03004d30 r3 0x03004c70 r4 0x00000000 r5 0xbe952e90 r6 0x03012d40 r7 0x00224250 r8 0x00000000 r9 0x00000001 r10 0x00216288 fp 0x0021a278 ip 0x000005ec sp 0xbe950ea8 lr 0x00069290 pc 0x0004fe44 *[0x0] /lib/arm-linux-gnueabihf/libc.so.6(vsprintf+0x4e)[0xb6d2a293] Smalltalk stack dump: 0xbe952e64 M SystemDictionary(Set)>findElementOrNil: 0x30cc098: a(n) SystemDictionary 0xbe952e90 I SystemDictionary(Dictionary)>at:put: 0x30cc098: a(n) SystemDictionary 0xbe952ebc I SystemDictionary>at:put: 0x30cc098: a(n) SystemDictionary 0xbe952f08 I [] in SystemDictionary>snapshot:andQuit:embedded:clearAllClassState: 0x30cc098: a(n) SystemDictionary 0x3a79bf0 s [] in BlockClosure>newProcess Most recent primitives maxIdentityHash identityHash at: at: stack page bytes 4096 available headroom 2788 minimum unused headroom 3776 (Segmentation fault) Aborted root@beaglebone:~/cuis-project# ========================================== -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/597

2 2

becomeForward: behavior
by Florin Mateoc 25 Jan '22

25 Jan '22

Hi, I am a bit surprised by the #becomeForward: behavior in Squeak. This is a one way become, where the target of the operation is the receiver, which sheds its identity/existence. Nobody points to it after the primitive execution, so it is discarded. This understanding also conforms to the method comment. As such, I remember a pattern of usage in VisualAge Smalltalk, where one way become was used as a cheap cleanup/avoidance of memory leaks, by doing oneWayBecome: nil. It's not that I advocate for it, but this works in Squeak too, except in Squeak #becomeForward: does an additional thing to the pointers redirection, it changes the identityHash of the argument, the non (obvious) target. While I understand this may be useful in certain situations, I think it is a dangerous conflation of activities. A new primitive that sets the identity hash could be used (VA has it) explicitly instead when such behavior is desired. As it is, if I do "Object new becomeForward: nil", it succeeds and it changes nil's identityHash. Sorry if this has been debated before, Cheers, Florin

5 11

VM Maker: VMMaker.oscog-eem.3142.mcz
by commits＠source.squeak.org 23 Jan '22

23 Jan '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3142.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3142 Author: eem Time: 21 January 2022, 5:10:43.282744 pm UUID: ecaa84c0-26c9-440b-bc13-59a6e56c5e7c Ancestors: VMMaker.oscog-eem.3141 Change the revised primitiveSuspend to behave clkoser to the original, always answeriong the list the receiver was on if bnlocked. make the newer variant available as a named prim itive (primitiveSuspendV2). AFAICT using primitiveSuspendV2 breaks lots of things (SqueakSSL tests hang, Virtend login hangs). So while the idea is right, in practice answering nil if the receiver is suspended while waiting on a condition variable breaks more things than it fixes. =============== Diff against VMMaker.oscog-eem.3141 =============== Item was changed: ----- Method: CoInterpreterPrimitives>>primitiveSuspend (in category 'process primitives') ----- primitiveSuspend "Primitive. Suspend the receiver, aProcess, such that it can be executed again by sending #resume. If the given process is not the active process, take it off its corresponding list. If the list was not its run queue assume it was on some condition variable (Semaphore, Mutex) and back up its pc to the send that invoked the wait state the process entered. Hence when the process resumes + it will reenter the wait state. Answer the list the receiver was previously on, + unless it was the activ eProcess, in which case answer nil." - it will reenter the wait state. Answer the list the receiver was previously on iff - it was not active and not blocked, otherwise answer nil." | process myList myContext ok | process := self stackTop. process = self activeProcess ifTrue: [| inInterpreter | "We're going to switch process, either to an interpreted frame or a machine code frame. To know whether to return or enter machine code we have to know from whence we came. We could have come from the interpreter, either directly or via a machine code primitive. We could have come from machine code. The instructionPointer tells us where from:" self pop: 1 thenPush: objectMemory nilObject. inInterpreter := instructionPointer >= objectMemory startOfMemory. self transferTo: self wakeHighestPriority from: CSSuspend. ^self forProcessPrimitiveReturnToExecutivePostContextSwitch: inInterpreter]. myList := objectMemory fetchPointer: MyListIndex ofObject: process. myContext := objectMemory fetchPointer: SuspendedContextIndex ofObject: process. ((objectMemory isPointers: myList) and: [(objectMemory numSlotsOf: myList) > LastLinkIndex and: [(objectMemory isContext: myContext) and: [self isResumableContext: myContext]]]) ifFalse: [^self primitiveFailFor: PrimErrBadReceiver]. ok := self removeProcess: process fromList: myList. ok ifFalse: [^self primitiveFailFor: PrimErrOperationFailed]. objectMemory storePointerUnchecked: MyListIndex ofObject: process withValue: objectMemory nilObject. self assert: RevisedSuspend. (RevisedSuspend + and: [(objectMemory fetchClassTagOfNonImm: myList) ~= classLinkedListClassTag]) ifTrue: + [self backupContext: myContext toBlockingSendTo: myList]. + self pop: 1 thenPush: myList! - and: [(objectMemory fetchClassTagOfNonImm: myList) ~= classLinkedListClassTag]) - ifTrue: - [self backupContext: myContext toBlockingSendTo: myList. - self pop: 1 thenPush: objectMemory nilObject] - ifFalse: - [self pop: 1 thenPush: myList]! Item was added: + ----- Method: CoInterpreterPrimitives>>primitiveSuspendV2 (in category 'process primitives') ----- + primitiveSuspendV2 + "Primitive. Suspend the receiver, aProcess, such that it can be executed again + by sending #resume. If the given process is not the active process, take it off + its corresponding list. If the list was not its run queue assume it was on some + condition variable (Semaphore, Mutex) and back up its pc to the send that + invoked the wait state the process entered. Hence when the process resumes + it will reenter the wait state. Answer the list the receiver was previously on iff + it was not active and not blocked, otherwise answer nil. + c.f. primitiveSuspend, which always answers the list the process was on, if blocked." + <export: true> + | process myList myContext ok | + process := self stackTop. + process = self activeProcess ifTrue: + [| inInterpreter | + "We're going to switch process, either to an interpreted frame or a machine + code frame. To know whether to return or enter machine code we have to + know from whence we came. We could have come from the interpreter, + either directly or via a machine code primitive. We could have come from + machine code. The instructionPointer tells us where from:" + self pop: 1 thenPush: objectMemory nilObject. + inInterpreter := instructionPointer >= objectMemory startOfMemory. + self transferTo: self wakeHighestPriority from: CSSuspend. + ^self forProcessPrimitiveReturnToExecutivePostContextSwitch: inInterpreter]. + myList := objectMemory fetchPointer: MyListIndex ofObject: process. + myContext := objectMemory fetchPointer: SuspendedContextIndex ofObject: process. + ((objectMemory isPointers: myList) + and: [(objectMemory numSlotsOf: myList) > LastLinkIndex + and: [(objectMemory isContext: myContext) + and: [self isResumableContext: myContext]]]) ifFalse: + [^self primitiveFailFor: PrimErrBadReceiver]. + ok := self removeProcess: process fromList: myList. + ok ifFalse: + [^self primitiveFailFor: PrimErrOperationFailed]. + objectMemory storePointerUnchecked: MyListIndex ofObject: process withValue: objectMemory nilObject. + self assert: RevisedSuspend. + (RevisedSuspend + and: [(objectMemory fetchClassTagOfNonImm: myList) ~= classLinkedListClassTag]) + ifTrue: + [self backupContext: myContext toBlockingSendTo: myList. + self pop: 1 thenPush: objectMemory nilObject] + ifFalse: + [self pop: 1 thenPush: myList]! Item was changed: ----- Method: CogVMSimulator class>>initialize (in category 'class initialization') ----- initialize "These are primitives that alter the state of the stack. They are here simply for assert checking. After invocation the Cogit should not check for the expected stack delta when these primitives succeed, because the stack will usually have been modified." StackAlteringPrimitives := #( primitiveClosureValue primitiveClosureValueWithArgs primitiveClosureValueNoContextSwitch primitiveClone primitiveInstVarAt primitiveSlotAt "because these can cause code compactions..." primitiveEnterCriticalSection primitiveExitCriticalSection primitiveFullClosureValue primitiveFullClosureValueWithArgs primitiveFullClosureValueNoContextSwitch + primitiveSignal primitiveWait primitiveResume primitiveSuspend primitiveSuspendV2 primitiveYield - primitiveSignal primitiveWait primitiveResume primitiveSuspend primitiveYield primitiveExecuteMethodArgsArray primitiveExecuteMethod primitivePerform primitivePerformWithArgs primitivePerformInSuperclass primitiveTerminateTo primitiveStoreStackp primitiveDoPrimitiveWithArgs) asIdentitySet! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveSuspend (in category 'process primitives') ----- primitiveSuspend "Primitive. Suspend the receiver, aProcess, such that it can be executed again by sending #resume. If the given process is not the active process, take it off its corresponding list. If the list was not its run queue assume it was on some condition variable (Semaphore, Mutex) and back up its pc to the send that invoked the wait state the process entered. Hence when the process resumes + it will reenter the wait state. Answer the list the receiver was previously on, + unless it was the activ eProcess, in which case answer nil." - it will reenter the wait state. Answer the list the receiver was previously on iff - it was not active and not blocked, otherwise answer nil." | process myList myContext ok | process := self stackTop. process = self activeProcess ifTrue: [self pop: 1 thenPush: objectMemory nilObject. ^self transferTo: self wakeHighestPriority]. myList := objectMemory fetchPointer: MyListIndex ofObject: process. myContext := objectMemory fetchPointer: SuspendedContextIndex ofObject: process. ((objectMemory isPointers: myList) and: [(objectMemory numSlotsOf: myList) > LastLinkIndex and: [(objectMemory isContext: myContext) and: [self isResumableContext: myContext]]]) ifFalse: [^self primitiveFailFor: PrimErrBadReceiver]. ok := self removeProcess: process fromList: myList. ok ifFalse: [^self primitiveFailFor: PrimErrOperationFailed]. objectMemory storePointerUnchecked: MyListIndex ofObject: process withValue: objectMemory nilObject. self assert: RevisedSuspend. (RevisedSuspend + and: [(objectMemory fetchClassTagOfNonImm: myList) ~= classLinkedListClassTag]) ifTrue: + [self backupContext: myContext toBlockingSendTo: myList]. + self pop: 1 thenPush: myList! - and: [(objectMemory fetchClassTagOfNonImm: myList) ~= classLinkedListClassTag]) - ifTrue: - [self backupContext: myContext toBlockingSendTo: myList. - self pop: 1 thenPush: objectMemory nilObject] - ifFalse: - [self pop: 1 thenPush: myList]! Item was added: + ----- Method: StackInterpreterPrimitives>>primitiveSuspendV2 (in category 'process primitives') ----- + primitiveSuspendV2 + "Primitive. Suspend the receiver, aProcess, such that it can be executed again + by sending #resume. If the given process is not the active process, take it off + its corresponding list. If the list was not its run queue assume it was on some + condition variable (Semaphore, Mutex) and back up its pc to the send that + invoked the wait state the process entered. Hence when the process resumes + it will reenter the wait state. Answer the list the receiver was previously on iff + it was not active and not blocked, otherwise answer nil. + c.f. primitiveSuspend, which always answers the list the process was on, if blocked." + <export: true> + | process myList myContext ok | + process := self stackTop. + process = self activeProcess ifTrue: + [self pop: 1 thenPush: objectMemory nilObject. + ^self transferTo: self wakeHighestPriority]. + myList := objectMemory fetchPointer: MyListIndex ofObject: process. + myContext := objectMemory fetchPointer: SuspendedContextIndex ofObject: process. + ((objectMemory isPointers: myList) + and: [(objectMemory numSlotsOf: myList) > LastLinkIndex + and: [(objectMemory isContext: myContext) + and: [self isResumableContext: myContext]]]) ifFalse: + [^self primitiveFailFor: PrimErrBadReceiver]. + ok := self removeProcess: process fromList: myList. + ok ifFalse: + [^self primitiveFailFor: PrimErrOperationFailed]. + objectMemory storePointerUnchecked: MyListIndex ofObject: process withValue: objectMemory nilObject. + self assert: RevisedSuspend. + (RevisedSuspend + and: [(objectMemory fetchClassTagOfNonImm: myList) ~= classLinkedListClassTag]) + ifTrue: + [self backupContext: myContext toBlockingSendTo: myList. + self pop: 1 thenPush: objectMemory nilObject] + ifFalse: + [self pop: 1 thenPush: myList]!

4 4

[OpenSmalltalk/opensmalltalk-vm] 0df634: CogVM source as per VMMaker.oscog-eem.3142
by Eliot Miranda 22 Jan '22

22 Jan '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 0df6348be41fe4af0d0877aec1c89fabbc3df623 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0df6348be41fe4af0d… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2022-01-21 (Fri, 21 Jan 2022) Changed paths: M src/spur32.cog.lowcode/cogit.h M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cogit.h M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.sista/cogit.h M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur64.cog.lowcode/cogit.h M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cogit.h M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cogit.h M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/v3.cog/cogit.h M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3142 Change the revised primitiveSuspend to behave clkoser to the original, always answering the list the receiver was on if bnlocked. make the newer variant available as a named primitive (primitiveSuspendV2). AFAICT using primitiveSuspendV2 breaks lots of things (SqueakSSL tests hang, Virtend login hangs). So while the idea is right, in practice answering nil if the receiver is suspended while waiting on a condition variable breaks more things than it fixes.

1 0

building SqueakSSL on linux64x64
by Eliot Miranda 21 Jan '22

21 Jan '22

Hi Tobias, Hi All, I'm trying to build a virtend server VM for linux64x64 that includes SqueakSSL as an internal plugin. Building yields a VM but there is no opensll shared object linked in (ldd shows nothing). Is one supposed to be unable to build SqueakSSL as an internal plugin? There is no mention at all of SqueakSSL in building/linux64x64/HowToBuild. There should be *some* mention of SqueakSSL in the HowToBuild files. Where is doc on how to build the plugin on 64-bit linux? _,,,^..^,,,_ best, Eliot

2 1

[OpenSmalltalk/opensmalltalk-vm] 456909: CogVM source as per VMMaker.oscog-eem.3141
by Eliot Miranda 19 Jan '22

19 Jan '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 4569091a7b88eb7c23d5d5fed1250c99dcce8a71 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/4569091a7b88eb7c23… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2022-01-19 (Wed, 19 Jan 2022) Changed paths: M src/spur32.cog.lowcode/cogit.h M src/spur32.cog.lowcode/cogitARMv5.c M src/spur32.cog.lowcode/cogitIA32.c M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cogit.h M src/spur32.cog/cogitARMv5.c M src/spur32.cog/cogitIA32.c M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.sista/cogit.h M src/spur32.sista/cogitARMv5.c M src/spur32.sista/cogitIA32.c M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/validImage.c M src/spur64.cog.lowcode/cogit.h M src/spur64.cog.lowcode/cogitARMv8.c M src/spur64.cog.lowcode/cogitX64SysV.c M src/spur64.cog.lowcode/cogitX64WIN64.c M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cogit.h M src/spur64.cog/cogitARMv8.c M src/spur64.cog/cogitX64SysV.c M src/spur64.cog/cogitX64WIN64.c M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cogit.h M src/spur64.sista/cogitARMv8.c M src/spur64.sista/cogitX64SysV.c M src/spur64.sista/cogitX64WIN64.c M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/validImage.c M src/v3.cog/cogit.h M src/v3.cog/cogitARMv5.c M src/v3.cog/cogitIA32.c M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3141 Interpreter: restore the long running primitive check, but this time compiled conditinally via -DLRPCheck. Slang: fix an extra cr in generating functions that have functional results (e.g. genInvokeInterpretTrampoline). Neater genMarshallNArgs: for x64.

1 0

VM Maker: VMMaker.oscog-eem.3141.mcz
by commits＠source.squeak.org 19 Jan '22

19 Jan '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3141.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3141 Author: eem Time: 19 January 2022, 12:00:15.348155 pm UUID: 1b33ac59-585e-4a96-a101-48eee1765764 Ancestors: VMMaker.oscog-eem.3140 oops; LRPMonitor => LRPCheck in StackInterpreter class>>declareCVarsIn: =============== Diff against VMMaker.oscog-eem.3140 =============== Item was changed: ----- Method: StackInterpreter class>>declareCVarsIn: (in category 'translation') ----- declareCVarsIn: aCCodeGenerator | vmClass | self class == thisContext methodClass ifFalse: [^self]. "Don't duplicate decls in subclasses" vmClass := aCCodeGenerator vmClass. "Generate primitiveTable etc based on vmClass, not just StackInterpreter" aCCodeGenerator addHeaderFile: '<stdio.h> /* for printf */'; addHeaderFile: '<stdlib.h> /* for e.g. alloca */'; addHeaderFile: '<setjmp.h>'; addHeaderFile: '<wchar.h> /* for wint_t */'; addHeaderFile: '"vmCallback.h"'; addHeaderFile: '"sqMemoryFence.h"'; addHeaderFile: '"sqImageFileAccess.h"'; addHeaderFile: '"sqSetjmpShim.h"'; addHeaderFile: '"dispdbg.h"'. LowcodeVM ifTrue: [aCCodeGenerator addHeaderFile: '"sqLowcodeFFI.h"']. vmClass declareInterpreterVersionIn: aCCodeGenerator defaultName: 'Stack'. aCCodeGenerator var: #interpreterProxy type: #'struct VirtualMachine*'. aCCodeGenerator declareVar: #sendTrace type: 'volatile int'; declareVar: #byteCount type: #usqLong. "see dispdbg.h" "These need to be pointers or unsigned." self declareC: #(instructionPointer method newMethod) as: #usqInt in: aCCodeGenerator. "These are all pointers; char * because Slang has no support for C pointer arithmetic." self declareC: #(localIP localSP localFP stackPointer framePointer stackLimit breakSelector) as: #'char *' in: aCCodeGenerator. aCCodeGenerator var: #breakSelectorLength declareC: 'sqInt breakSelectorLength = MinSmallInteger'. self declareC: #(stackPage overflowedPage) as: #'StackPage *' in: aCCodeGenerator. aCCodeGenerator var: #transcript type: #'FILE *'. aCCodeGenerator removeVariable: 'stackPages'. "this is an implicit receiver in the translated code." "This defines bytecodeSetSelector as 0 if MULTIPLEBYTECODESETS is not defined, for the benefit of the interpreter on slow machines." aCCodeGenerator addConstantForBinding: (self bindingOf: #MULTIPLEBYTECODESETS). MULTIPLEBYTECODESETS == false ifTrue: [aCCodeGenerator removeVariable: 'bytecodeSetSelector']. BytecodeSetHasExtensions == false ifTrue: [aCCodeGenerator removeVariable: 'extA'; removeVariable: 'extB']. aCCodeGenerator var: #methodCache declareC: 'sqIntptr_t methodCache[MethodCacheSize + 1 /* ', (MethodCacheSize + 1) printString, ' */]'. NewspeakVM ifTrue: [aCCodeGenerator var: #nsMethodCache declareC: 'sqIntptr_t nsMethodCache[NSMethodCacheSize + 1 /* ', (NSMethodCacheSize + 1) printString, ' */]'] ifFalse: [aCCodeGenerator removeVariable: #nsMethodCache; removeVariable: 'localAbsentReceiver'; removeVariable: 'localAbsentReceiverOrZero']. AtCacheTotalSize isInteger ifTrue: [aCCodeGenerator var: #atCache declareC: 'sqInt atCache[AtCacheTotalSize + 1 /* ', (AtCacheTotalSize + 1) printString, ' */]']. aCCodeGenerator var: #primitiveTable declareC: 'void (*primitiveTable[MaxPrimitiveIndex + 2 /* ', (MaxPrimitiveIndex + 2) printString, ' */])(void) = ', vmClass primitiveTableString. vmClass primitiveTable do: [:symbolOrNot| (symbolOrNot isSymbol and: [symbolOrNot ~~ #primitiveFail]) ifTrue: [(aCCodeGenerator methodNamed: symbolOrNot) ifNotNil: [:tMethod| tMethod returnType: #void]]]. vmClass objectMemoryClass hasSpurMemoryManagerAPI ifTrue: [aCCodeGenerator var: #primitiveAccessorDepthTable type: 'signed char' sizeString: 'MaxPrimitiveIndex + 2 /* ', (MaxPrimitiveIndex + 2) printString, ' */' array: (vmClass primitiveAccessorDepthTableUsing: aCCodeGenerator)] ifFalse: [aCCodeGenerator removeVariable: #primitiveAccessorDepthTable]. aCCodeGenerator var: #displayBits type: #'void *'; var: #primitiveCalloutPointer declareC: 'void *primitiveCalloutPointer = (void *)-1'. self declareC: #(displayWidth displayHeight displayDepth) as: #int in: aCCodeGenerator. aCCodeGenerator var: #primitiveFunctionPointer declareC: 'void (*primitiveFunctionPointer)()'; var: 'pcPreviousToFunction' declareC: 'sqInt (* const pcPreviousToFunction)(sqInt,sqInt) = ', (aCCodeGenerator cFunctionNameFor: PCPreviousToFunction); var: #externalPrimitiveTable declareC: 'void (*externalPrimitiveTable[MaxExternalPrimitiveTableSize + 1 /* ', (MaxExternalPrimitiveTableSize + 1) printString, ' */])(void)'; var: #interruptCheckChain declareC: 'void (*interruptCheckChain)(void) = 0'; var: #showSurfaceFn declareC: 'int (*showSurfaceFn)(sqIntptr_t, int, int, int, int)'; var: #jmpBuf declareC: 'jmp_buf jmpBuf[MaxJumpBuf + 1 /* ', (MaxJumpBuf + 1) printString, ' */]'; var: #suspendedCallbacks declareC: 'usqInt suspendedCallbacks[MaxJumpBuf + 1 /* ', (MaxJumpBuf + 1) printString, ' */]'; var: #suspendedMethods declareC: 'usqInt suspendedMethods[MaxJumpBuf + 1 /* ', (MaxJumpBuf + 1) printString, ' */]'. self declareCAsUSqLong: #(nextPollUsecs nextWakeupUsecs "these are high-frequency enough that they're overflowing quite quickly on modern hardware" statProcessSwitch statIOProcessEvents statForceInterruptCheck statCheckForEvents statStackOverflow statStackPageDivorce statIdleUsecs) in: aCCodeGenerator. aCCodeGenerator var: #nextProfileTick type: #sqLong. aCCodeGenerator var: #reenterInterpreter type: 'jmp_buf'. LowcodeVM ifTrue: [aCCodeGenerator var: #lowcodeCalloutState type: #'sqLowcodeCalloutState*'. self declareC: #(nativeSP nativeStackPointer shadowCallStackPointer) as: #'char *' in: aCCodeGenerator] ifFalse: [#(lowcodeCalloutState nativeSP nativeStackPointer shadowCallStackPointer) do: [:var| aCCodeGenerator removeVariable: var]]. (self instVarNames select: [:ivn| ivn beginsWith: 'longRunningPrimitive']) do: [:lrpmVar| aCCodeGenerator var: lrpmVar + declareC: '#if LRPCheck\', ((lrpmVar endsWith: 'Usecs') ifTrue: [#usqLong] ifFalse: [#sqInt]), ' ', lrpmVar, '\#endif']! - declareC: '#if LRPMonitor\', ((lrpmVar endsWith: 'Usecs') ifTrue: [#usqLong] ifFalse: [#sqInt]), ' ', lrpmVar, '\#endif']!

1 0

VM Maker: VMMaker.oscog-eem.3140.mcz
by commits＠source.squeak.org 19 Jan '22

19 Jan '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3140.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3140 Author: eem Time: 19 January 2022, 11:35:24.48811 am UUID: 92e5f37d-acf4-411c-ab3f-8f85b766ca3d Ancestors: VMMaker.oscog-eem.3139 Interpreter: restore the long riunning primiitve check, but this time compiled in conditinally via -DLRPCheck. Slang: ITIMER_HEARTBEAT (as well as LRPCheck) needs to be included in names defined at compile time. fix an extra cr in generating functions that have functional results (e.g. genInvokeInterpretTrampoline). VMMaker: Add an openInterpreterMultiWindowBrowser convenience. Comment typoes. =============== Diff against VMMaker.oscog-eem.3139 =============== Item was changed: ----- Method: CoInterpreter>>forceInterruptCheckFromHeartbeat (in category 'process primitive support') ----- forceInterruptCheckFromHeartbeat "Force an interrupt check ASAP. This version is the entry-point to forceInterruptCheck for the heartbeat timer to allow for repeatable debugging." suppressHeartbeatFlag ifFalse: + [self checkForLongRunningPrimitive. + self sqLowLevelMFence. - [self sqLowLevelMFence. deferSmash ifTrue: [deferredSmash := true. self sqLowLevelMFence] ifFalse: [self forceInterruptCheck]]! Item was changed: ----- Method: CoInterpreter>>primitivePropertyFlagsForSpur: (in category 'cog jit support') ----- primitivePropertyFlagsForSpur: primIndex <inline: true> "Answer any special requirements of the given primitive. Spur always needs to set primitiveFunctionPointer and newMethod so primitives can retry on failure due to forwarders." | baseFlags | self cCode: [] inSmalltalk: [#( primitiveObjectAtPut primitiveCopyObject primitiveSpurStringReplace primitiveSpurFloatArrayAt primitiveSpurFloatArrayAtPut primitiveExternalCall primitiveCalloutToFFI)]. "For senders..." baseFlags := profileSemaphore = objectMemory nilObject ifTrue: [0] ifFalse: [PrimCallCollectsProfileSamples]. (primIndex = PrimNumberObjectAtPut or: [primIndex = PrimNumberCopyObject or: [primIndex = PrimNumberStringReplace or: [primIndex = PrimNumberShortArrayAt or: [primIndex = PrimNumberShortArrayAtPut]]]]) ifTrue: [^baseFlags + PrimCallOnSmalltalkStack]. (primIndex = PrimNumberFloatArrayAt or: [primIndex = PrimNumberFloatArrayAtPut]) ifTrue: [^baseFlags + PrimCallOnSmalltalkStack + PrimCallOnSmalltalkStackAlign2x]. + "N.B. if and when this changes remember to add back support for the longRunningPrimitiveCheck" baseFlags := baseFlags + PrimCallNeedsPrimitiveFunction + PrimCallNeedsNewMethod. (self isCalloutPrimitiveIndex: primIndex) ifTrue: "For callbacks & module unloading" [^baseFlags + PrimCallMayEndureCodeCompaction + PrimCallIsExternalCall]. (self isCodeCompactingPrimitiveIndex: primIndex) ifTrue: "For code reclamations" [^baseFlags bitOr: PrimCallMayEndureCodeCompaction]. ^baseFlags! Item was changed: ----- Method: CoInterpreter>>primitivePropertyFlagsForV3: (in category 'cog jit support') ----- primitivePropertyFlagsForV3: primIndex <inline: true> "Answer any special requirements of the given primitive" | baseFlags | baseFlags := profileSemaphore ~= objectMemory nilObject ifTrue: [PrimCallNeedsNewMethod + PrimCallCollectsProfileSamples] ifFalse: [0]. + self cppIf: #LRPCheck + ifTrue: + [longRunningPrimitiveCheckSemaphore ifNotNil: + [baseFlags := baseFlags bitOr: PrimCallNeedsNewMethod]]. + (self isCalloutPrimitiveIndex: primIndex) ifTrue: "For callbacks & module unloading" [baseFlags := baseFlags bitOr: PrimCallNeedsNewMethod + PrimCallNeedsPrimitiveFunction + PrimCallMayEndureCodeCompaction + PrimCallIsExternalCall]. (self isCodeCompactingPrimitiveIndex: primIndex) ifTrue: [baseFlags := baseFlags bitOr: PrimCallNeedsNewMethod + PrimCallMayEndureCodeCompaction]. ^baseFlags! Item was changed: ----- Method: CoInterpreterMT>>checkForEventsMayContextSwitch: (in category 'process primitive support') ----- checkForEventsMayContextSwitch: mayContextSwitch "Check for possible interrupts and handle one if necessary. Answer if a context switch has occurred." | switched sema now | <inline: false> <var: #now type: #usqLong> self assertSaneThreadAndProcess. cogit assertCStackWellAligned. statCheckForEvents := statCheckForEvents + 1. "restore the stackLimit if it has been smashed." self restoreStackLimit. self externalWriteBackHeadFramePointers. self assert: stackPage = stackPages mostRecentlyUsedPage. "Allow the platform to do anything it needs to do synchronously." self ioSynchronousCheckForEvents. self checkCogCompiledCodeCompactionCalledFor. objectMemory needGCFlag ifTrue: ["sufficientSpaceAfterGC: runs the incremental GC and then, if not enough space is available, the fullGC." (objectMemory sufficientSpaceAfterGC: 0) ifFalse: [self setSignalLowSpaceFlagAndSaveProcess]]. mayContextSwitch ifFalse: [^false]. switched := false. self assert: deferThreadSwitch not. deferThreadSwitch := true. (profileProcess ~= objectMemory nilObject or: [nextProfileTick > 0 and:[self ioHighResClock >= nextProfileTick]]) ifTrue: [self zeroNextProfileTick. "Take a sample (if not already done so) for the profiler if it is active. This must be done before any of the synchronousSignals below or else we will attribute a pause in ioRelinquishProcessor to the newly activated process." profileProcess = objectMemory nilObject ifTrue: [profileProcess := self activeProcess. profileMethod := objectMemory nilObject]. "and signal the profiler semaphore if it is present" (profileSemaphore ~= objectMemory nilObject and: [self synchronousSignal: profileSemaphore]) ifTrue: [switched := true]]. + self cppIf: #LRPCheck + ifTrue: + [self checkDeliveryOfLongRunningPrimitiveSignal ifTrue: + [switched := true]]. + objectMemory signalLowSpace ifTrue: [objectMemory signalLowSpace: false. "reset flag" sema := objectMemory splObj: TheLowSpaceSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]. "inIOProcessEvents prevents reentrancy into ioProcessEvents and allows disabling ioProcessEvents e.g. for native GUIs. We would like to manage that here but can't since the platform code may choose to call ioProcessEvents itself in various places." false ifTrue: [((now := self ioUTCMicroseconds) >= nextPollUsecs and: [inIOProcessEvents = 0]) ifTrue: [statIOProcessEvents := statIOProcessEvents + 1. inIOProcessEvents := inIOProcessEvents + 1. self ioProcessEvents. "sets interruptPending if interrupt key pressed; may callback" inIOProcessEvents > 0 ifTrue: [inIOProcessEvents := inIOProcessEvents - 1]. nextPollUsecs := now + 20000 "msecs to wait before next call to ioProcessEvents. Note that strictly speaking we might need to update 'now' at this point since ioProcessEvents could take a very long time on some platforms"]] ifFalse: [(now := self ioUTCMicroseconds) >= nextPollUsecs ifTrue: [statIOProcessEvents := statIOProcessEvents + 1. self ioProcessEvents. "sets interruptPending if interrupt key pressed; may callback" nextPollUsecs := now + 20000 "msecs to wait before next call to ioProcessEvents. Note that strictly speaking we might need to update 'now' at this point since ioProcessEvents could take a very long time on some platforms"]]. interruptPending ifTrue: [interruptPending := false. "reset interrupt flag" sema := objectMemory splObj: TheInterruptSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]. nextWakeupUsecs ~= 0 ifTrue: [now >= nextWakeupUsecs ifTrue: [nextWakeupUsecs := 0. "set timer interrupt to 0 for 'no timer'" sema := objectMemory splObj: TheTimerSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]]. "signal any pending finalizations" pendingFinalizationSignals > 0 ifTrue: [pendingFinalizationSignals := 0. sema := objectMemory splObj: TheFinalizationSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]. "signal all semaphores in semaphoresToSignal" self signalExternalSemaphores ifTrue: [switched := true]. deferThreadSwitch := false. checkThreadActivation ifTrue: [checkThreadActivation := false. self cedeToHigherPriorityThreads]. "N.B. This may not return if we do switch." self threadSwitchIfNecessary: self activeProcess from: CSCheckEvents. ^switched! Item was changed: ----- Method: CoInterpreterMT>>forceInterruptCheckFromHeartbeat (in category 'process primitive support') ----- forceInterruptCheckFromHeartbeat "Force an interrupt check ASAP. This version is the entry-point to forceInterruptCheck for the heartbeat timer to allow for repeatable debugging. N.B. SYNCHRONIZE WITH deferStackLimitSmashAround:" suppressHeartbeatFlag ifFalse: + [self checkForLongRunningPrimitive. + self sqLowLevelMFence. - [self sqLowLevelMFence. deferSmash ifTrue: [deferredSmash := true. self sqLowLevelMFence] ifFalse: [self forceInterruptCheck. self checkVMOwnershipFromHeartbeat]]! Item was added: + ----- Method: CoInterpreterPrimitives>>primitiveLongRunningPrimitiveSemaphore (in category 'process primitives') ----- + primitiveLongRunningPrimitiveSemaphore + "Primitive. Install the semaphore to be used for collecting long-running primitives, + or nil if no semaphore should be used." + <export: true> + <option: #LRPCheck> + | sema flushState activeContext | + self methodArgumentCount ~= 1 ifTrue: + [^self primitiveFailFor: PrimErrBadNumArgs]. + sema := self stackValue: 0. + sema = objectMemory nilObject + ifTrue: + [flushState := longRunningPrimitiveCheckSemaphore notNil. + longRunningPrimitiveCheckSemaphore := nil] + ifFalse: + [flushState := longRunningPrimitiveCheckSemaphore isNil. + (objectMemory isSemaphoreOop: sema) ifFalse: + [^self primitiveFailFor: PrimErrBadArgument]. + longRunningPrimitiveCheckSemaphore := sema]. + "If we've switched checking on or off we must void machine code + (and machine code pcs in contexts) since we will start or stop setting + newMethod in machine code primitive invocations, and so generate + slightly different code from here on in." + flushState ifTrue: + [self push: instructionPointer. + activeContext := self voidVMStateForSnapshotFlushingExternalPrimitivesIf: false. + self marryContextInNewStackPageAndInitializeInterpreterRegisters: activeContext. + self assert: (((self stackValue: 0) = objectMemory nilObject and: [longRunningPrimitiveCheckSemaphore isNil]) + or: [(self stackValue: 0) = longRunningPrimitiveCheckSemaphore + and: [objectMemory isSemaphoreOop: sema]])]. + self voidLongRunningPrimitive: 'install'. + self pop: 1. + flushState ifTrue: + [cogit ceInvokeInterpret]! Item was changed: ----- Method: CogX64Compiler>>genMarshallNArgs:arg:arg:arg:arg: (in category 'abi') ----- genMarshallNArgs: numArgs arg: regOrConst0 arg: regOrConst1 arg: regOrConst2 arg: regOrConst3 "Generate the code to pass up to four arguments in a C run-time call. Hack: each argument is either a negative number, which encodes a positive constant, or a non-negative number, that of a register. The encoding for constants is defined by trampolineArgConstant: & trampolineArgValue:. Pass a constant as the result of trampolineArgConstant:. Run-time calls have no more than four arguments, so chosen so that on ARM32, where in its C ABI the first four integer arguments are passed in registers, all arguments can be passed in registers. We defer to the back end to generate this code not so much that the back end knows whether it uses the stack or registers to pass arguments (it does, but...). In fact we defer for an extremely evil reason. Doing so allows the x64 (where up to 6 args are passed) to assign the register arguments in an order that allows some of the argument registers to be used for specific abstract registers, specifically ReceiverResultReg and ClassReg. This is evil, evil, evil, but also it's really nice to keep using the old register assignments the original author has grown accustomed to. How can this possibly work? Look at Cogit class>>runtime for a list of the run-time calls and their arguments, including which arguments are passed in which registers. Look at CogX64Compiler's subclass implementations of initializeAbstractRegisters. There are no calls in which ReceiverResultReg (RDX) and/or ClassReg (RCX) are passed along with Arg0Reg and Arg1Reg, and none in which the use of either ReceiverResultReg or ClassReg conflict for args 3 & 4. So if args are assigned in order, the registers do not get overwritten. Yes, this is evil, but it's so nice to continue to use RCX & RDX. Argument registers for args 0 to 3 in SysV are RDI RSI RDX RCX, and in Win64 are RCX RDX R8 R9" <inline: true> SysV ifFalse: "WIN64 ABI allways reserve shadow space on the stack for callee to save up to 4 register parameters" [cogit SubCq: 32 R: RSP]. - numArgs = 0 ifTrue: [^self]. self assert: numArgs <= 4. + numArgs > 0 ifTrue: + [(cogit isTrampolineArgConstant: regOrConst0) + ifTrue: [cogit MoveCq: (cogit trampolineArgValue: regOrConst0) R: CArg0Reg] "a.k.a. Arg0Reg" - (cogit isTrampolineArgConstant: regOrConst0) - ifTrue: [cogit MoveCq: (cogit trampolineArgValue: regOrConst0) R: CArg0Reg] "a.k.a. Arg0Reg" - ifFalse: - [regOrConst0 ~= CArg0Reg ifTrue: - [cogit MoveR: regOrConst0 R: CArg0Reg]]. - numArgs = 1 ifTrue: [^self]. - (cogit isTrampolineArgConstant: regOrConst1) - ifTrue: [cogit MoveCq: (cogit trampolineArgValue: regOrConst1) R: CArg1Reg] "a.k.a. Arg1Reg" - ifFalse: - [regOrConst1 ~= CArg1Reg ifTrue: - [cogit MoveR: regOrConst1 R: CArg1Reg]]. - numArgs = 2 ifTrue: [^self]. - (cogit isTrampolineArgConstant: regOrConst2) - ifTrue: [cogit MoveCq: (cogit trampolineArgValue: regOrConst2) R: CArg2Reg] "a.k.a. ReceiverResultReg (SysV) ClassReg (Win64)" - ifFalse: - [regOrConst2 ~= CArg2Reg ifTrue: - [cogit MoveR: regOrConst2 R: CArg2Reg]]. - numArgs = 3 ifTrue: [^self]. - (cogit isTrampolineArgConstant: regOrConst3) - ifTrue: [cogit MoveCq: (cogit trampolineArgValue: regOrConst3) R: CArg3Reg] "a.k.a. ClassReg (SysV) ReceiverResultReg (Win64)" ifFalse: + [regOrConst0 ~= CArg0Reg ifTrue: + [cogit MoveR: regOrConst0 R: CArg0Reg]]. + numArgs > 1 ifTrue: + [(cogit isTrampolineArgConstant: regOrConst1) + ifTrue: [cogit MoveCq: (cogit trampolineArgValue: regOrConst1) R: CArg1Reg] "a.k.a. Arg1Reg" + ifFalse: + [regOrConst1 ~= CArg1Reg ifTrue: + [cogit MoveR: regOrConst1 R: CArg1Reg]]. + numArgs > 2 ifTrue: + [(cogit isTrampolineArgConstant: regOrConst2) + ifTrue: [cogit MoveCq: (cogit trampolineArgValue: regOrConst2) R: CArg2Reg] "a.k.a. ReceiverResultReg (SysV) ClassReg (Win64)" + ifFalse: + [regOrConst2 ~= CArg2Reg ifTrue: + [cogit MoveR: regOrConst2 R: CArg2Reg]]. + numArgs > 3 ifTrue: + [(cogit isTrampolineArgConstant: regOrConst3) + ifTrue: [cogit MoveCq: (cogit trampolineArgValue: regOrConst3) R: CArg3Reg] "a.k.a. ClassReg (SysV) ReceiverResultReg (Win64)" + ifFalse: + [regOrConst3 ~= CArg3Reg ifTrue: + [cogit MoveR: regOrConst3 R: CArg3Reg]]]]]]! - [regOrConst3 ~= CArg3Reg ifTrue: - [cogit MoveR: regOrConst3 R: CArg3Reg]]! Item was changed: ----- Method: Cogit class>>defineAtCompileTime: (in category 'C translation') ----- defineAtCompileTime: anObject "Override to define at translation time those variables that need to be defined at compile time only in plugins, but not in the main VM, because the VM generated is specific to these varables." anObject isSymbol ifFalse: [^false]. (#(STACKVM COGVM COGMTVM SPURVM) includes: anObject) ifTrue: [^false]. + ^VMBasicConstants defineAtCompileTime: anObject! - ^VMBasicConstants namesDefinedAtCompileTime includes: anObject! Item was changed: ----- Method: InterpreterPrimitives class>>defineAtCompileTime: (in category 'C translation') ----- defineAtCompileTime: anObject "Override to define at translation time those variables that need to be defined at compile time only in plugins, but not in the main VM, because the VM generated is specific to these varables." anObject isSymbol ifFalse: [^false]. (#(STACKVM COGVM COGMTVM SPURVM) includes: anObject) ifTrue: [^false]. + ^VMBasicConstants defineAtCompileTime: anObject! - ^VMBasicConstants namesDefinedAtCompileTime includes: anObject! Item was changed: ----- Method: SimpleStackBasedCogit>>compileInterpreterPrimitive:flags: (in category 'primitive generators') ----- compileInterpreterPrimitive: primitiveRoutine flags: flags "Compile a call to an interpreter primitive. Call the C routine with the usual stack-switching dance, test the primFailCode and then either return on success or continue to the method body." <var: #primitiveRoutine declareC: 'void (*primitiveRoutine)(void)'> | jmp continueAfterProfileSample jumpToTakeSample | self deny: (backEnd hasVarBaseRegister and: [self register: VarBaseReg isInMask: ABICallerSavedRegisterMask]). "Save processor fp, sp and return pc in the interpreter's frame stack and instruction pointers" self genExternalizePointersForPrimitiveCall. "Switch to the C stack." self genLoadCStackPointersForPrimCall. "Old old full prim trace is in VMMaker-eem.550 and prior. Old simpler full prim trace is in VMMaker-eem.2969 and prior." (coInterpreter recordPrimTraceForMethod: methodObj) ifTrue: [self genFastPrimTraceUsing: ClassReg and: SendNumArgsReg]. "Clear the primFailCode and set argumentCount" self MoveCq: 0 R: TempReg. self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. methodOrBlockNumArgs ~= 0 ifTrue: [self AddCq: methodOrBlockNumArgs R: TempReg]. "As small or smaller than move on most archs" self MoveR: TempReg Aw: coInterpreter argumentCountAddress. "If required, set primitiveFunctionPointer and newMethod" (flags anyMask: PrimCallNeedsPrimitiveFunction) ifTrue: [self MoveCw: primitiveRoutine asInteger R: TempReg. self MoveR: TempReg Aw: coInterpreter primitiveFunctionPointerAddress]. (flags anyMask: PrimCallNeedsNewMethod+PrimCallMayEndureCodeCompaction) ifTrue: ["The ceActivateFailingPrimitiveMethod: machinery can't handle framelessness." (flags anyMask: PrimCallMayEndureCodeCompaction) ifTrue: [needsFrame := true]. methodLabel addDependent: (self annotateAbsolutePCRef: (self MoveCw: methodLabel asInteger R: ClassReg)). self MoveMw: (self offset: CogMethod of: #methodObject) r: ClassReg R: TempReg. self MoveR: TempReg Aw: coInterpreter newMethodAddress]. "Invoke the primitive. If the primitive (potentially) contains a call-back then its code may disappear and consequently we cannot return here, sicne here may evaporate. Instead sideways-call the routine, substituting cePrimReturnEnterCogCode[Profiling] as the return address, so the call always returns there." self PrefetchAw: coInterpreter primFailCodeAddress. (flags anyMask: PrimCallMayEndureCodeCompaction) ifTrue: ["On Spur ceActivateFailingPrimitiveMethod: would like to retry if forwarders are found. So insist on PrimCallNeedsPrimitiveFunction being set too." objectMemory hasSpurMemoryManagerAPI ifTrue: [self assert: (flags anyMask: PrimCallNeedsPrimitiveFunction)]. backEnd genMarshallNArgs: 0 arg: nil arg: nil arg: nil arg: nil; genSubstituteReturnAddress: ((flags anyMask: PrimCallCollectsProfileSamples) ifTrue: [cePrimReturnEnterCogCodeProfiling] ifFalse: [cePrimReturnEnterCogCode]). self JumpFullRT: primitiveRoutine asInteger. ^0]. "Call the C primitive routine." backEnd genMarshallNArgs: 0 arg: nil arg: nil arg: nil arg: nil. + self CallFullRT: primitiveRoutine asInteger. - "If the primitive is in the interpreter then its address won't change relative to the code zone over time, - whereas if it is in a plugin its address could change if the module is un/re/over/loaded. - So if in the interpreter and in range use a normal call instruction." - ((flags anyMask: PrimCallIsInternalPrim) - and: [backEnd isWithinCallRange: primitiveRoutine asInteger]) - ifTrue: [self CallRT: primitiveRoutine asInteger] - ifFalse: [self CallFullRT: primitiveRoutine asInteger]. backEnd genRemoveNArgsFromStack: 0. objectRepresentation maybeCompileRetryOnPrimitiveFail: primitiveIndex. "Switch back to the Smalltalk stack. Stack better be in either of these two states: success: stackPointer -> result (was receiver) arg1 ... argN return pc failure: receiver arg1 ... stackPointer -> argN return pc" backEnd genLoadStackPointersForPrimCall: ClassReg. "genLoadStackPointersForPrimCall: leaves the stack in these states: NoLinkRegister LinkRegister success: result (was receiver) stackPointer -> result (was receiver) stackPointer -> arg1 arg1 ... ... argN argN return pc failure: receiver receiver arg1 arg1 ... ... argN stackPointer -> argN stackPointer -> return pc which corresponds to the stack on entry after pushRegisterArgs. In either case we can write the instructionPointer to top of stack or load it into the LinkRegister to reestablish the return pc." backEnd hasLinkRegister ifTrue: [self MoveAw: coInterpreter instructionPointerAddress R: LinkReg] ifFalse: [self MoveAw: coInterpreter instructionPointerAddress R: ClassReg. self MoveR: ClassReg Mw: 0 r: SPReg]. "Test primitive failure" self MoveAw: coInterpreter primFailCodeAddress R: TempReg. self flag: 'ask concrete code gen if move sets condition codes?'. self CmpCq: 0 R: TempReg. jmp := self JumpNonZero: 0. "placing the test here attributes the tick to the primitive plus any checkForAndFollowForwardedPrimitiveState scanning, but attributes all of a failing primitive to the current method (in ceStackOverflow: on frame build)." (backEnd has64BitPerformanceCounter and: [flags anyMask: PrimCallCollectsProfileSamples]) ifTrue: [jumpToTakeSample := self genCheckForProfileTimerTick: (self registerMaskFor: NoReg)]. "Fetch result from stack" continueAfterProfileSample := self MoveMw: (backEnd hasLinkRegister ifTrue: [0] ifFalse: [objectMemory wordSize]) r: SPReg R: ReceiverResultReg. self RetN: objectMemory wordSize. "return to caller, popping receiver" (backEnd has64BitPerformanceCounter and: [flags anyMask: PrimCallCollectsProfileSamples]) ifTrue: [jumpToTakeSample jmpTarget: self Label. self genTakeProfileSample. backEnd genLoadStackPointerForPrimCall: ClassReg. backEnd hasLinkRegister ifTrue: [self MoveAw: coInterpreter instructionPointerAddress R: LinkReg] ifFalse: [self MoveAw: coInterpreter instructionPointerAddress R: ClassReg. self MoveR: ClassReg Mw: 0 r: SPReg]. self Jump: continueAfterProfileSample]. "Jump to restore of receiver reg and proceed to frame build for failure." jmp jmpTarget: self Label. "Restore receiver reg from stack. If on RISCs ret pc is in LinkReg, if on CISCs ret pc is on stack." self MoveMw: objectMemory wordSize * (methodOrBlockNumArgs + (backEnd hasLinkRegister ifTrue: [0] ifFalse: [1])) r: SPReg R: ReceiverResultReg. ^0! Item was changed: InterpreterPrimitives subclass: #StackInterpreter (excessive size, no diff calculated) Item was changed: ----- Method: StackInterpreter class>>declareCVarsIn: (in category 'translation') ----- declareCVarsIn: aCCodeGenerator | vmClass | self class == thisContext methodClass ifFalse: [^self]. "Don't duplicate decls in subclasses" vmClass := aCCodeGenerator vmClass. "Generate primitiveTable etc based on vmClass, not just StackInterpreter" aCCodeGenerator addHeaderFile: '<stdio.h> /* for printf */'; addHeaderFile: '<stdlib.h> /* for e.g. alloca */'; addHeaderFile: '<setjmp.h>'; addHeaderFile: '<wchar.h> /* for wint_t */'; addHeaderFile: '"vmCallback.h"'; addHeaderFile: '"sqMemoryFence.h"'; addHeaderFile: '"sqImageFileAccess.h"'; addHeaderFile: '"sqSetjmpShim.h"'; addHeaderFile: '"dispdbg.h"'. LowcodeVM ifTrue: [aCCodeGenerator addHeaderFile: '"sqLowcodeFFI.h"']. vmClass declareInterpreterVersionIn: aCCodeGenerator defaultName: 'Stack'. aCCodeGenerator var: #interpreterProxy type: #'struct VirtualMachine*'. aCCodeGenerator declareVar: #sendTrace type: 'volatile int'; declareVar: #byteCount type: #usqLong. "see dispdbg.h" "These need to be pointers or unsigned." self declareC: #(instructionPointer method newMethod) as: #usqInt in: aCCodeGenerator. "These are all pointers; char * because Slang has no support for C pointer arithmetic." self declareC: #(localIP localSP localFP stackPointer framePointer stackLimit breakSelector) as: #'char *' in: aCCodeGenerator. aCCodeGenerator var: #breakSelectorLength declareC: 'sqInt breakSelectorLength = MinSmallInteger'. self declareC: #(stackPage overflowedPage) as: #'StackPage *' in: aCCodeGenerator. aCCodeGenerator var: #transcript type: #'FILE *'. aCCodeGenerator removeVariable: 'stackPages'. "this is an implicit receiver in the translated code." "This defines bytecodeSetSelector as 0 if MULTIPLEBYTECODESETS is not defined, for the benefit of the interpreter on slow machines." aCCodeGenerator addConstantForBinding: (self bindingOf: #MULTIPLEBYTECODESETS). MULTIPLEBYTECODESETS == false ifTrue: [aCCodeGenerator removeVariable: 'bytecodeSetSelector']. BytecodeSetHasExtensions == false ifTrue: [aCCodeGenerator removeVariable: 'extA'; removeVariable: 'extB']. aCCodeGenerator var: #methodCache declareC: 'sqIntptr_t methodCache[MethodCacheSize + 1 /* ', (MethodCacheSize + 1) printString, ' */]'. NewspeakVM ifTrue: [aCCodeGenerator var: #nsMethodCache declareC: 'sqIntptr_t nsMethodCache[NSMethodCacheSize + 1 /* ', (NSMethodCacheSize + 1) printString, ' */]'] ifFalse: [aCCodeGenerator removeVariable: #nsMethodCache; removeVariable: 'localAbsentReceiver'; removeVariable: 'localAbsentReceiverOrZero']. AtCacheTotalSize isInteger ifTrue: [aCCodeGenerator var: #atCache declareC: 'sqInt atCache[AtCacheTotalSize + 1 /* ', (AtCacheTotalSize + 1) printString, ' */]']. aCCodeGenerator var: #primitiveTable declareC: 'void (*primitiveTable[MaxPrimitiveIndex + 2 /* ', (MaxPrimitiveIndex + 2) printString, ' */])(void) = ', vmClass primitiveTableString. vmClass primitiveTable do: [:symbolOrNot| (symbolOrNot isSymbol and: [symbolOrNot ~~ #primitiveFail]) ifTrue: [(aCCodeGenerator methodNamed: symbolOrNot) ifNotNil: [:tMethod| tMethod returnType: #void]]]. vmClass objectMemoryClass hasSpurMemoryManagerAPI ifTrue: [aCCodeGenerator var: #primitiveAccessorDepthTable type: 'signed char' sizeString: 'MaxPrimitiveIndex + 2 /* ', (MaxPrimitiveIndex + 2) printString, ' */' array: (vmClass primitiveAccessorDepthTableUsing: aCCodeGenerator)] ifFalse: [aCCodeGenerator removeVariable: #primitiveAccessorDepthTable]. aCCodeGenerator var: #displayBits type: #'void *'; var: #primitiveCalloutPointer declareC: 'void *primitiveCalloutPointer = (void *)-1'. self declareC: #(displayWidth displayHeight displayDepth) as: #int in: aCCodeGenerator. aCCodeGenerator var: #primitiveFunctionPointer declareC: 'void (*primitiveFunctionPointer)()'; var: 'pcPreviousToFunction' declareC: 'sqInt (* const pcPreviousToFunction)(sqInt,sqInt) = ', (aCCodeGenerator cFunctionNameFor: PCPreviousToFunction); var: #externalPrimitiveTable declareC: 'void (*externalPrimitiveTable[MaxExternalPrimitiveTableSize + 1 /* ', (MaxExternalPrimitiveTableSize + 1) printString, ' */])(void)'; var: #interruptCheckChain declareC: 'void (*interruptCheckChain)(void) = 0'; var: #showSurfaceFn declareC: 'int (*showSurfaceFn)(sqIntptr_t, int, int, int, int)'; var: #jmpBuf declareC: 'jmp_buf jmpBuf[MaxJumpBuf + 1 /* ', (MaxJumpBuf + 1) printString, ' */]'; var: #suspendedCallbacks declareC: 'usqInt suspendedCallbacks[MaxJumpBuf + 1 /* ', (MaxJumpBuf + 1) printString, ' */]'; var: #suspendedMethods declareC: 'usqInt suspendedMethods[MaxJumpBuf + 1 /* ', (MaxJumpBuf + 1) printString, ' */]'. + self declareCAsUSqLong: #(nextPollUsecs nextWakeupUsecs - self declareCAsUSqLong: #(nextPollUsecs nextWakeupUsecs longRunningPrimitiveGCUsecs - longRunningPrimitiveStartUsecs longRunningPrimitiveStopUsecs "these are high-frequency enough that they're overflowing quite quickly on modern hardware" statProcessSwitch statIOProcessEvents statForceInterruptCheck statCheckForEvents statStackOverflow statStackPageDivorce statIdleUsecs) in: aCCodeGenerator. aCCodeGenerator var: #nextProfileTick type: #sqLong. aCCodeGenerator var: #reenterInterpreter type: 'jmp_buf'. LowcodeVM ifTrue: [aCCodeGenerator var: #lowcodeCalloutState type: #'sqLowcodeCalloutState*'. self declareC: #(nativeSP nativeStackPointer shadowCallStackPointer) as: #'char *' in: aCCodeGenerator] ifFalse: [#(lowcodeCalloutState nativeSP nativeStackPointer shadowCallStackPointer) do: + [:var| aCCodeGenerator removeVariable: var]]. + (self instVarNames select: [:ivn| ivn beginsWith: 'longRunningPrimitive']) do: + [:lrpmVar| + aCCodeGenerator + var: lrpmVar + declareC: '#if LRPMonitor\', ((lrpmVar endsWith: 'Usecs') ifTrue: [#usqLong] ifFalse: [#sqInt]), ' ', lrpmVar, '\#endif']! - [:var| aCCodeGenerator removeVariable: var]]! Item was added: + ----- Method: StackInterpreter>>checkDeliveryOfLongRunningPrimitiveSignal (in category 'primitive support') ----- + checkDeliveryOfLongRunningPrimitiveSignal + "Check for a hit of the longRunningPrimitive probe and if so attempt to signal the + longRunningPrimitiveCheckSemaphore. Answer if a process switch occurred as a result." + <option: #LRPCheck> + <inline: #never> + (longRunningPrimitiveStopUsecs > longRunningPrimitiveStartUsecs "a hit" + and: [longRunningPrimitiveCheckSemaphore notNil "deliverable" + and: [longRunningPrimitiveSignalUndelivered]]) ifTrue: "but not yet delivered" + [longRunningPrimitiveSignalUndelivered := false. + longRunningPrimitiveGCUsecs := (objectMemory gcStartUsecs < longRunningPrimitiveStopUsecs + and: [objectMemory statGCEndUsecs > longRunningPrimitiveStartUsecs]) + ifTrue: [objectMemory statGCEndUsecs - objectMemory gcStartUsecs] + ifFalse: [0]. + "Signal the LRP check semaphore if it is present" + ^self synchronousSignal: longRunningPrimitiveCheckSemaphore]. + ^false! Item was changed: ----- Method: StackInterpreter>>checkForEventsMayContextSwitch: (in category 'process primitive support') ----- checkForEventsMayContextSwitch: mayContextSwitch "Check for possible interrupts and handle one if necessary. Answer if a context switch has occurred." | switched sema now | <inline: false> <var: #now type: #usqLong> statCheckForEvents := statCheckForEvents + 1. "restore the stackLimit if it has been smashed." self restoreStackLimit. self externalWriteBackHeadFramePointers. self assert: stackPage = stackPages mostRecentlyUsedPage. "Allow the platform to do anything it needs to do synchronously." self ioSynchronousCheckForEvents. self checkCogCompiledCodeCompactionCalledFor. objectMemory needGCFlag ifTrue: ["sufficientSpaceAfterGC: runs the incremental GC and then, if not enough space is available, the fullGC." (objectMemory sufficientSpaceAfterGC: 0) ifFalse: [self setSignalLowSpaceFlagAndSaveProcess]]. mayContextSwitch ifFalse: [^false]. switched := false. (profileProcess ~= objectMemory nilObject or: [nextProfileTick > 0 and:[self ioHighResClock >= nextProfileTick]]) ifTrue: [self zeroNextProfileTick. "Take a sample (if not already done so) for the profiler if it is active. This must be done before any of the synchronousSignals below or else we will attribute a pause in ioRelinquishProcessor to the newly activated process." profileProcess = objectMemory nilObject ifTrue: [profileProcess := self activeProcess. profileMethod := objectMemory nilObject]. "and signal the profiler semaphore if it is present" (profileSemaphore ~= objectMemory nilObject and: [self synchronousSignal: profileSemaphore]) ifTrue: [switched := true]]. + self cppIf: #LRPCheck + ifTrue: + [self checkDeliveryOfLongRunningPrimitiveSignal ifTrue: + [switched := true]]. + objectMemory signalLowSpace ifTrue: [objectMemory signalLowSpace: false. "reset flag" sema := objectMemory splObj: TheLowSpaceSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]. "inIOProcessEvents prevents reentrancy into ioProcessEvents and allows disabling ioProcessEvents e.g. for native GUIs. We would like to manage that here but can't since the platform code may choose to call ioProcessEvents itself in various places." false ifTrue: [((now := self ioUTCMicroseconds) >= nextPollUsecs and: [inIOProcessEvents = 0]) ifTrue: [statIOProcessEvents := statIOProcessEvents + 1. inIOProcessEvents := inIOProcessEvents + 1. self ioProcessEvents. "sets interruptPending if interrupt key pressed; may callback" inIOProcessEvents > 0 ifTrue: [inIOProcessEvents := inIOProcessEvents - 1]. nextPollUsecs := now + 20000 "msecs to wait before next call to ioProcessEvents. Note that strictly speaking we might need to update 'now' at this point since ioProcessEvents could take a very long time on some platforms"]] ifFalse: [(now := self ioUTCMicroseconds) >= nextPollUsecs ifTrue: [statIOProcessEvents := statIOProcessEvents + 1. self ioProcessEvents. "sets interruptPending if interrupt key pressed; may callback" nextPollUsecs := now + 20000 "msecs to wait before next call to ioProcessEvents. Note that strictly speaking we might need to update 'now' at this point since ioProcessEvents could take a very long time on some platforms"]]. interruptPending ifTrue: [interruptPending := false. "reset interrupt flag" sema := objectMemory splObj: TheInterruptSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]. nextWakeupUsecs ~= 0 ifTrue: [now >= nextWakeupUsecs ifTrue: [nextWakeupUsecs := 0. "set timer interrupt to 0 for 'no timer'" sema := objectMemory splObj: TheTimerSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]]. "signal any pending finalizations" pendingFinalizationSignals > 0 ifTrue: [pendingFinalizationSignals := 0. sema := objectMemory splObj: TheFinalizationSemaphore. (sema ~= objectMemory nilObject and: [self synchronousSignal: sema]) ifTrue: [switched := true]]. "signal all semaphores in semaphoresToSignal" self signalExternalSemaphores ifTrue: [switched := true]. ^switched! Item was added: + ----- Method: StackInterpreter>>checkForLongRunningPrimitive (in category 'primitive support') ----- + checkForLongRunningPrimitive + "Called from forceInterruptCheckFromHeartbeat. If the system has been running + the same primitive on two successive heartbeats then signal profileMethod." + <inline: true> + self cppIf: #LRPCheck + ifTrue: + [longRunningPrimitiveCheckSemaphore ifNil: + [^nil]. + (longRunningPrimitiveStartUsecs > 0 + and: [longRunningPrimitiveCheckMethod = newMethod + and: [longRunningPrimitiveCheckSequenceNumber = statCheckForEvents]]) ifTrue: + [longRunningPrimitiveStopUsecs := self ioUTCMicroseconds. + self assert: longRunningPrimitiveStopUsecs > longRunningPrimitiveStartUsecs. + ^nil]. + "See traceProfileState & mapProfileState." + longRunningPrimitiveStopUsecs = 0 ifTrue: + [longRunningPrimitiveCheckSequenceNumber := statCheckForEvents. + longRunningPrimitiveCheckMethod := newMethod. + longRunningPrimitiveStartUsecs := self ioUTCMicroseconds. + self sqLowLevelMFence]]! Item was changed: ----- Method: StackInterpreter>>forceInterruptCheckFromHeartbeat (in category 'process primitive support') ----- forceInterruptCheckFromHeartbeat "Force an interrupt check ASAP. This version is the entry-point to forceInterruptCheck for the heartbeat timer to allow for repeatable debugging." suppressHeartbeatFlag ifFalse: + [self checkForLongRunningPrimitive. + self forceInterruptCheck]! - [self forceInterruptCheck]! Item was changed: ----- Method: StackInterpreter>>initialize (in category 'initialization') ----- initialize "Here we can initialize the variables C initializes to zero. #initialize methods do /not/ get translated." super initialize. primitiveDoMixedArithmetic := true. "whether we authorize primitives to perform mixed arithmetic or not". newFinalization := false. stackLimit := 0. "This is also the initialization flag for the stack system." stackPage := overflowedPage := 0. extraFramesToMoveOnOverflow := 0. bytecodeSetSelector := 0. highestRunnableProcessPriority := 0. nextPollUsecs := 0. nextWakeupUsecs := 0. tempOop := tempOop2 := theUnknownShort := 0. interruptPending := false. inIOProcessEvents := 0. fullScreenFlag := 0. sendWheelEvents := deferDisplayUpdates := false. displayBits := displayWidth := displayHeight := displayDepth := 0. pendingFinalizationSignals := statPendingFinalizationSignals := 0. globalSessionID := 0. jmpDepth := 0. + longRunningPrimitiveStartUsecs := longRunningPrimitiveStopUsecs := 0. maxExtSemTabSizeSet := false. debugCallbackInvokes := debugCallbackPath := debugCallbackReturns := 0. primitiveCalloutPointer := -1. "initialized in declaration in declareCVarsIn:" transcript := Transcript. "initialized to stdout in readImageFromFile:HeapSize:StartingAt:" pcPreviousToFunction := PCPreviousToFunction. "initialized via StackInterpreter class>>declareCVarsIn:" statForceInterruptCheck := statStackOverflow := statCheckForEvents := statProcessSwitch := statIOProcessEvents := statStackPageDivorce := statIdleUsecs := 0! Item was changed: ----- Method: StackInterpreter>>mapProfileState (in category 'object memory support') ----- mapProfileState (objectMemory shouldRemapObj: profileProcess) ifTrue: [profileProcess := objectMemory remapObj: profileProcess]. (objectMemory shouldRemapObj: profileMethod) ifTrue: [profileMethod := objectMemory remapObj: profileMethod]. (objectMemory shouldRemapObj: profileSemaphore) ifTrue: + [profileSemaphore := objectMemory remapObj: profileSemaphore]. + self cppIf: #LRPCheck + ifTrue: + ["The longRunningPrimitiveCheckMethod (LRPCM) is sampled in an interrupt. Be very careful with it. + If longRunningPrimitiveCheckSequenceNumber (LRPCSN) = statCheckForEvents then LRPCM has + been recenty sampled and could be mapped or not, but it must be newMethod and we can simply + copy newMethod. If LRPCSN ~= statCheckForEvents then LRPCM must be some extant object and + needs to be remapped." + self sqLowLevelMFence. + longRunningPrimitiveCheckMethod ifNotNil: + [longRunningPrimitiveCheckSequenceNumber = statCheckForEvents + ifTrue: [longRunningPrimitiveCheckMethod := newMethod] + ifFalse: + [(objectMemory shouldRemapObj: longRunningPrimitiveCheckMethod) ifTrue: + [longRunningPrimitiveCheckMethod := self remapObj: longRunningPrimitiveCheckMethod]]. + self sqLowLevelMFence]. + longRunningPrimitiveCheckSemaphore ifNotNil: + [(objectMemory shouldRemapObj: longRunningPrimitiveCheckSemaphore) ifTrue: + [longRunningPrimitiveCheckSemaphore := objectMemory remapObj: longRunningPrimitiveCheckSemaphore]]]! - [profileSemaphore := objectMemory remapObj: profileSemaphore]! Item was changed: ----- Method: StackInterpreter>>traceProfileState (in category 'object memory support') ----- traceProfileState objectMemory hasSpurMemoryManagerAPI ifTrue: [self followForwardingPointersInProfileState]. objectMemory markAndTrace: profileProcess. objectMemory markAndTrace: profileMethod. + objectMemory markAndTrace: profileSemaphore. + + self cppIf: #LRPCheck + ifTrue: + ["The longRunningPrimitiveCheckMethod (LRPCM) is sampled in an interrupt. Be very careful with it. + If longRunningPrimitiveCheckSequenceNumber (LRPCSN) = statCheckForEvents then LRPCM has + been recenty sampled, but it must be newMethod and we don't need to trace it twice. If LRPCSN + ~= statCheckForEvents then LRPCM must be some extant object and needs to be traced." + self sqLowLevelMFence. + (longRunningPrimitiveCheckMethod ~= nil + and: [longRunningPrimitiveCheckSequenceNumber ~= statCheckForEvents]) ifTrue: + [(objectMemory isForwarded: longRunningPrimitiveCheckMethod) ifTrue: + [longRunningPrimitiveCheckMethod := objectMemory followForwarded: longRunningPrimitiveCheckMethod]. + objectMemory markAndTrace: longRunningPrimitiveCheckMethod]. + longRunningPrimitiveCheckSemaphore ~= nil ifTrue: + [(objectMemory isForwarded: longRunningPrimitiveCheckSemaphore) ifTrue: + [longRunningPrimitiveCheckSemaphore := objectMemory followForwarded: longRunningPrimitiveCheckSemaphore]. + objectMemory markAndTrace: longRunningPrimitiveCheckSemaphore]]! - objectMemory markAndTrace: profileSemaphore! Item was added: + ----- Method: StackInterpreter>>voidLongRunningPrimitive: (in category 'primitive support') ----- + voidLongRunningPrimitive: reason + "Void the state associated with the long-running primitive check. + This is done when a new semaphore is installed or when it appears + that is longRunningPrimitiveCheckMethod is invalid, e.g. because it + has eben sampled in the middle of a GC." + <var: #reason type: #'char *'> + <option: #LRPCheck> + <inline: #never> + longRunningPrimitiveCheckMethod := nil. + longRunningPrimitiveStartUsecs := + longRunningPrimitiveStopUsecs := 0. + longRunningPrimitiveSignalUndelivered := true. + self sqLowLevelMFence! Item was added: + ----- Method: StackInterpreterPrimitives>>primitiveLongRunningPrimitive (in category 'process primitives') ----- + primitiveLongRunningPrimitive + "Primitive. Answer an Array with the current long-running primitive method identified by + the heartbeat, the minimum number of milliseconds it was active for, and the milliseconds + of GC activity there-in, or nil if none." + <export: true> + <option: #LRPCheck> + | lrpcm result primms gcms | + self sqLowLevelMFence. + "Since the longRunningPrimitiveCheckMethod is sampled at + interrupt time be careful to validate it before returning it." + (longRunningPrimitiveStopUsecs > longRunningPrimitiveStartUsecs "a hit" + and: [(lrpcm := longRunningPrimitiveCheckMethod) notNil "there is a method" + and: [(objectMemory addressCouldBeObj: lrpcm) "method looks valid" + and: [(objectMemory isCompiledMethod: lrpcm)]]]) + ifTrue: [result := objectMemory instantiateClass: (objectMemory splObj: ClassArray) indexableSize: 3. + primms := (longRunningPrimitiveStopUsecs - longRunningPrimitiveStartUsecs) + 500 // 1000. + gcms := longRunningPrimitiveGCUsecs + 500 // 1000. + objectMemory storePointer: 0 ofObject: result withValue: lrpcm. + objectMemory storePointerUnchecked: 1 ofObject: result withValue: (objectMemory integerObjectOf: primms). + objectMemory storePointerUnchecked: 2 ofObject: result withValue: (objectMemory integerObjectOf: gcms)] + ifFalse: [result := objectMemory nilObject]. + self voidLongRunningPrimitive: 'get'. + self methodReturnValue: result! Item was added: + ----- Method: StackInterpreterPrimitives>>primitiveLongRunningPrimitiveSemaphore (in category 'process primitives') ----- + primitiveLongRunningPrimitiveSemaphore + "Primitive. Install the semaphore to be used for collecting long-running primitives, + or nil if no semaphore should be used." + <export: true> + <option: #LRPCheck> + | sema | + sema := self stackValue: 0. + sema = objectMemory nilObject + ifTrue: + [longRunningPrimitiveCheckSemaphore := nil] + ifFalse: + [(objectMemory isSemaphoreOop: sema) ifFalse: + [^self primitiveFail]. + longRunningPrimitiveCheckSemaphore := sema]. + self voidLongRunningPrimitive: 'install'. + self methodReturnReceiver! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveObjectPointsTo (in category 'object access primitives') ----- primitiveObjectPointsTo "This primitive is assumed to be fast (see e.g. MethodDictionary>>includesKey:) so make it so. + N.B. Works correctly for cogged methods too." - N.B. Works forrectly for cogged methods too." | rcvr thang header fmt numSlots methodHeader | thang := self stackTop. rcvr := self stackValue: 1. (objectMemory isImmediate: rcvr) ifTrue: [^self pop: 2 thenPushBool: false]. "Inlined version of lastPointerOf: for speed in determining if rcvr is a context." header := objectMemory baseHeader: rcvr. fmt := objectMemory formatOfHeader: header. (objectMemory isPointersFormat: fmt) ifTrue: [(fmt = objectMemory indexablePointersFormat and: [objectMemory isContextHeader: header]) ifTrue: [(self isMarriedOrWidowedContext: rcvr) ifTrue: [self externalWriteBackHeadFramePointers. (self isStillMarriedContext: rcvr) ifTrue: [^self pop: 2 thenPushBool: (self marriedContext: rcvr pointsTo: thang stackDeltaForCurrentFrame: 2)]]. "contexts end at the stack pointer" numSlots := CtxtTempFrameStart + (self fetchStackPointerOf: rcvr)] ifFalse: [numSlots := objectMemory numSlotsOf: rcvr]] ifFalse: [fmt < objectMemory firstCompiledMethodFormat "no pointers" ifTrue: [^self pop: 2 thenPushBool: false]. "CompiledMethod: contains both pointers and bytes:" methodHeader := objectMemory methodHeaderOf: rcvr. methodHeader = thang ifTrue: [^self pop: 2 thenPushBool: true]. numSlots := (objectMemory literalCountOfMethodHeader: methodHeader) + LiteralStart]. self assert: numSlots - 1 * objectMemory bytesPerOop + objectMemory baseHeaderSize = (objectMemory lastPointerOf: rcvr). objectMemory baseHeaderSize to: numSlots - 1 * objectMemory bytesPerOop + objectMemory baseHeaderSize by: objectMemory bytesPerOop do: [:i| (objectMemory longAt: rcvr + i) = thang ifTrue: [^self pop: 2 thenPushBool: true]]. self pop: 2 thenPushBool: false! Item was changed: ----- Method: TMethod>>emitCFunctionPrototype:generator:isPrototype: (in category 'C code generation') ----- emitCFunctionPrototype: aStream generator: aCodeGen isPrototype: isPrototype "<Boolean>" "Emit a C function header for this method onto the given stream. Answer if the method has any compileTimeOptionPragmas" | compileTimeOptionPragmas returnTypeIsFunctionPointer | (compileTimeOptionPragmas := self compileTimeOptionPragmas) notEmpty ifTrue: [self outputConditionalDefineFor: compileTimeOptionPragmas on: aStream]. returnTypeIsFunctionPointer := returnType notNil and: [returnType last = $) and: [returnType includesSubstring: (aCodeGen cFunctionNameFor: selector)]]. export ifTrue: [aStream nextPutAll: 'EXPORT('; nextPutAll: returnType; nextPut: $)] ifFalse: [self isStatic ifTrue: [aStream nextPutAll: 'static '] ifFalse: [isPrototype ifTrue: [aStream nextPutAll: 'extern ']]. (isPrototype or: [inline ~~ #always]) ifFalse: [aStream nextPutAll: 'inline ']. aStream nextPutAll: (returnType ifNil: [#sqInt])]. (functionAttributes isNil or: [returnTypeIsFunctionPointer]) ifFalse: [aStream space; nextPutAll: functionAttributes]. - isPrototype ifTrue: [aStream space] ifFalse: [aStream cr]. returnTypeIsFunctionPointer ifFalse: + [isPrototype ifTrue: [aStream space] ifFalse: [aStream cr]. + aStream - [aStream nextPutAll: (aCodeGen cFunctionNameFor: selector); nextPut: $(. args isEmpty ifTrue: [aStream nextPutAll: #void] ifFalse: [args do: [:arg| aStream nextPutAll: (self declarationAt: arg)] separatedBy: [aStream nextPutAll: ', ']]. aStream nextPut: $)]. isPrototype ifTrue: [aStream nextPut: $;; cr. compileTimeOptionPragmas isEmpty ifFalse: [aCodeGen maybeEmitPrimitiveFailureDefineFor: selector on: aStream. self terminateConditionalDefineFor: compileTimeOptionPragmas on: aStream]]. ^compileTimeOptionPragmas notEmpty! Item was changed: ----- Method: VMBasicConstants class>>defineAtCompileTime: (in category 'C translation') ----- defineAtCompileTime: anObject ^anObject isSymbol + and: ["("self namesDefinedAtCompileTime includes: anObject") + ifTrue: [compileTimeQueries add: anObject. true] + ifFalse: [translationTimeQueries add: anObject. false]"] + + "compileTimeQueries := Set new. + translationTimeQueries := Set new" + "self class + removeInstVarName: 'compileTimeQueries'; + removeInstVarName: 'translationTimeQueries'"! - and: [self namesDefinedAtCompileTime includes: anObject]! Item was changed: ----- Method: VMBasicConstants class>>namesDefinedAtCompileTime (in category 'C translation') ----- namesDefinedAtCompileTime "Answer the set of names for variables that should be defined at compile time. Some of these get default values during simulation, and hence get defaulted in the various initializeMiscConstants methods. But that they have values should /not/ cause the code generator to do dead code elimination based on their default values. In particular, methods marked with <option: ANameDefinedAtCompileTime> will be emitted within #if defined(ANameDefinedAtCompileTime)...#endif. + And of course this is backwards. We'd like to define names that are defined at translation time. + But doing so would entail defining (or referencing) hundreds of class and pool variables. This way + is more manageable" - And of course this is backwards. We'd like to define names that are defined at translation time." ^#(VMBIGENDIAN IMMUTABILITY STACKVM COGVM COGMTVM SPURVM PharoVM "Pharo vs Squeak" TerfVM VM_TICKER "Terf vs Squeak & Qwaq/Teleplace/Terf high-priority thread support" EnforceAccessControl "Newspeak" CheckRememberedInTrampoline "IMMUTABILITY" BIT_IDENTICAL_FLOATING_POINT PLATFORM_SPECIFIC_FLOATING_POINT "Alternatives for using fdlibm for floating-point" + ITIMER_HEARTBEAT "older linux's woultn't allow a higher priority thread, hence no threaded heartbeat." TestingPrimitives OBSOLETE_ALIEN_PRIMITIVES "Ancient crap in the IA32ABI plugin" LLDB "As of lldb-370.0.42 Swift-3.1, passing function parameters to printOopsSuchThat fails with Internal error [IRForTarget]: Couldn't rewrite one of the arguments of a function call. Turning off link time optimization with -fno-lto has no effect. hence we define some debugging functions as being <option: LLDB>" + LRPCheck "Optional checking for long running primitives" "processor related" __ARM_ARCH__ __arm__ __arm32__ ARM32 __arm64__ ARM64 _M_I386 _X86_ i386 i486 i586 i686 __i386__ __386__ X86 I386 x86_64 __amd64 __x86_64 __amd64__ __x86_64__ _M_AMD64 _M_X64 + __mips__ __mips __powerpc __powerpc__ __powerpc64__ __POWERPC__ __ppc__ __ppc64__ __PPC__ __PPC64__ __sparc__ __sparc __sparc_v8__ __sparc_v9__ __sparcv8 __sparcv9 "Compiler brand related" + __ACK__ __CC_ARM __clang__ __GNUC__ _MSC_VER __ICC + __SUNPRO_C "os related" ACORN + _AIX __ANDROID__ __APPLE__ __BEOS__ __linux__ __MACH__ __MINGW32__ __FreeBSD__ __NetBSD__ __OpenBSD__ __osf__ + EPLAN9 __unix__ __unix UNIX WIN32 _WIN32 _WIN32_WCE WIN64 _WIN64 _WIN64_WCE)! Item was changed: ----- Method: VMClass class>>initialize (in category 'initialization') ----- initialize InitializationOptions ifNil: [InitializationOptions := Dictionary new]. ExpensiveAsserts := false. (Smalltalk classNamed: #Utilities) ifNotNil: [:utilitiesClass| (utilitiesClass classPool at: #CommonRequestStrings ifAbsent: []) ifNotNil: [:commonRequestStringHolder| (commonRequestStringHolder contents asString includesSubstring: 'VMClass open') ifFalse: + [Utilities appendToCommonRequests: '-\VMMaker generateConfiguration\VMMaker generateAllConfigurationsUnderVersionControl\VMMaker generateAllSpurConfigurations\VMClass openCogSpurMultiWindowBrowser\VMClass openCogV3MultiWindowBrowser\VMClass openObjectMemoriesInterpretersBrowser\VMClass openSpurMultiWindowBrowser\VMClass openCogitMultiWindowBrowser\openInterpreterMultiWindowBrowser' withCRs]]]! - [Utilities appendToCommonRequests: '-\VMMaker generateConfiguration\VMMaker generateAllConfigurationsUnderVersionControl\VMMaker generateAllSpurConfigurations\VMClass openCogSpurMultiWindowBrowser\VMClass openCogV3MultiWindowBrowser\VMClass openObjectMemoriesInterpretersBrowser\VMClass openSpurMultiWindowBrowser\VMClass openCogitMultiWindowBrowser' withCRs]]]! Item was added: + ----- Method: VMClass class>>openInterpreterMultiWindowBrowser (in category 'utilities') ----- + openInterpreterMultiWindowBrowser + "Answer a new multi-window browser on the Spur classes, the Cog StackInterpreter classes, and the support classes" + | b | + b := Browser open. + #( InterpreterPrimitives StackInterpreter StackInterpreterPrimitives + CoInterpreter CoInterpreterPrimitives CoInterpreterMT + StackInterpreterSimulator CogVMSimulator) + do: [:className| + (Smalltalk classNamed: className) ifNotNil: + [:class| b selectCategoryForClass: class; selectClass: class]] + separatedBy: + [b multiWindowState addNewWindow]. + b multiWindowState selectWindowIndex: 1!

1 0

[OpenSmalltalk/opensmalltalk-vm] Feature Request: Simple Protocol for Independent Computing Environments (Issue #612)
by asarch 19 Jan '22

19 Jan '22

What about using the SPICE protocol with the VM in order to improve the image session and the host operating system interaction, (among other things, like the ability to share the sessions across the net): https://www.spice-space.org/static/docs/spice_protocol.pdf -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/612 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/issues/612(a)github.com>

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev January 2022