Vm-dev July 2022

vm-dev@lists.squeakfoundation.org

15 participants
78 discussions

VM Maker: VMMaker.oscog-eem.3223.mcz
by commits＠source.squeak.org 26 Jul '22

26 Jul '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3223.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3223 Author: eem Time: 26 July 2022, 2:18:20.973227 pm UUID: 26a1e5de-8a04-4964-8ecf-aaa2c3a3c3d5 Ancestors: VMMaker.oscog-eem.3222 Fix primitiveSocketListenWithOrWithoutBacklog not having its accessor depth computed. Add a breakpoint to the accessorDepth calculation. This pointsa to the Slang selector breakpoints needing to be properly typed, e.g. (breakpoints at: aTMethodSelector ifPresent: [:coll| coll includes: #accessorDepth] ifAbsent: [false]) etc =============== Diff against VMMaker.oscog-eem.3222 =============== Item was changed: ----- Method: CCodeGenerator>>accessorDepthForMethod: (in category 'spur primitive compilation') ----- accessorDepthForMethod: method "TMethod" "Compute the depth the method traverses object structure, assuming it is a primitive. This is in support of Spur's lazy become. A primitive may fail in argument validation because it encounters a forwarder. The primitive failure code needs to know to what depth it must follow arguments to find forwarders, so that if any are found, they can be followed and the primitive retried. This method determines that depth. It starts by collecting references to the stack and then follows these through assignments to variables and use of accessor methods such as fetchPointer:ofObject:. For example | obj field | obj := self stackTop. field := objectMemory fetchPointer: 1 ofObject: obj. self storePointer: 1 ofObject: field withValue: (self stackValue: 1) has depth 2, since field is accessed, and field is an element of obj. The information is cached since it needs to be computed *before* inlining." ^accessorDepthCache at: method smalltalkSelector ifAbsentPut: + [self maybeBreakForTestToInline: method smalltalkSelector in: method. + beganInlining - [beganInlining ifTrue: [(method export or: [vmClass notNil or: [vmClass primitiveTable includes: method smalltalkSelector]]) ifTrue: [-1] ifFalse: [self error: 'it is too late to compute accessor depths!!']] ifFalse: [((method definingClass includesSelector: method smalltalkSelector) ifTrue: [(method definingClass >> method smalltalkSelector) pragmaAt: #accessorDepth:]) ifNotNil: [:pragma| pragma arguments first] ifNil: ["Deal with clichés of the form primitiveFoo objectMemory hasSpurMemoryManagerAPI ifTrue: [self primitiveFooSpur] ifFalse: [self primitiveFooV3] and primitiveFoo interpreterProxy methodArgumentCount = M ifTrue: [self primitiveFooM] ifFalse: [self primitiveFooN] etc..." method isIfThenElseClicheGiven: self IfTrue: [:ifTrueCliche :ifFalseCliche| method extractSpurPrimitiveSelector ifNotNil: [:actualSelector| | subMethod | (subMethod := self methodNamed: actualSelector) ifNil: [subMethod := self compileToTMethodSelector: actualSelector in: method definingClass]. self accessorDepthForMethod: subMethod] ifNil: [(self accessorDepthForMethod: (self methodNamed: ifTrueCliche)) max: (self accessorDepthForMethod: (self methodNamed: ifFalseCliche))]] ifFalse: [self accessorDepthForMethod: method interpreterClass: (vmClass ifNil: [StackInterpreter])]]]]! Item was changed: ----- Method: CCodeGenerator>>exportsNeedingMetadata (in category 'spur primitive compilation') ----- exportsNeedingMetadata + ^self sortedExportMethods select: [:m| self methodNeedsMetadata: m]! - ^self sortedExportMethods reject: - [:m| | selector | - selector := m smalltalkSelector. - selector = #initialiseModule - or: [(InterpreterPlugin includesSelector: selector) - or: [vmClass notNil and: [(selector beginsWith: 'prim') not]]]]! Item was added: + ----- Method: CCodeGenerator>>methodNeedsMetadata: (in category 'spur primitive compilation') ----- + methodNeedsMetadata: aTMethod + "Answer if aTMethod really needs primitive metadata. This is a hack to filter out some functions that definitely don't need metadata." + | selector | + selector := aTMethod smalltalkSelector. + (#(initialiseModule shutdownModule moduleUnloaded:) includes: selector) ifTrue: + [^false]. + (InterpreterPlugin includesSelector: selector) ifTrue: + [^false]. + vmClass ifNotNil: + [(selector beginsWith: 'prim') ifFalse: + [^false]]. + ^true + + ! Item was added: + ----- Method: SmartSyntaxPluginTMethod>>prepareMethodIn: (in category 'transformations') ----- + prepareMethodIn: aCodeGen + "Override to ensure accessor depth is calculated for plugin primitives." + super prepareMethodIn: aCodeGen. + (self export + and: [aCodeGen methodNeedsMetadata: self]) ifTrue: + [aCodeGen accessorDepthForMethod: self]!

1 0

[OpenSmalltalk/opensmalltalk-vm] 51a12b: Fix type declaration problem in DeflatePlugin affe...
by David T Lewis 26 Jul '22

26 Jul '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 51a12b2e7e74b00954cc028e7ad37bcec142408b https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/51a12b2e7e74b00954… Author: David T. Lewis <lewis(a)mail.msen.com> Date: 2022-07-25 (Mon, 25 Jul 2022) Changed paths: M src/plugins/ZipPlugin/ZipPlugin.c Log Message: ----------- Fix type declaration problem in DeflatePlugin affecting RiscV64 compilation thanks Key Dickey: http://lists.squeakfoundation.org/pipermail/vm-dev/2022-July/038221.html

1 0

VM Maker: VMMaker.oscog-eem.3222.mcz
by commits＠source.squeak.org 26 Jul '22

26 Jul '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3222.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3222 Author: eem Time: 26 July 2022, 12:11:03.160721 pm UUID: f96f49a4-54f0-42a0-bcbb-bd5b6cc3e68a Ancestors: VMMaker.oscog-dtl.3221 Simulation: fix a memcpy:_:_: case which was using a deprecated path to byteAt:put:. Slang: Fix accessorDepth calculations for clichés such as primitiveSocketListenWithOrWithoutBacklog "Backward compatibility" <export: true> interpreterProxy methodArgumentCount = 2 ifTrue:[^self primitiveSocketListenOnPort] ifFalse:[^self primitiveSocketListenOnPortBacklog] =============== Diff against VMMaker.oscog-dtl.3221 =============== Item was changed: ----- Method: CCodeGenerator>>accessorDepthForMethod: (in category 'spur primitive compilation') ----- accessorDepthForMethod: method "TMethod" "Compute the depth the method traverses object structure, assuming it is a primitive. This is in support of Spur's lazy become. A primitive may fail in argument validation because it encounters a forwarder. The primitive failure code needs to know to what depth it must follow arguments to find forwarders, so that if any are found, they can be followed and the primitive retried. This method determines that depth. It starts by collecting references to the stack and then follows these through assignments to variables and use of accessor methods such as fetchPointer:ofObject:. For example | obj field | obj := self stackTop. field := objectMemory fetchPointer: 1 ofObject: obj. self storePointer: 1 ofObject: field withValue: (self stackValue: 1) has depth 2, since field is accessed, and field is an element of obj. The information is cached since it needs to be computed *before* inlining." ^accessorDepthCache at: method smalltalkSelector ifAbsentPut: [beganInlining ifTrue: [(method export or: [vmClass notNil or: [vmClass primitiveTable includes: method smalltalkSelector]]) ifTrue: [-1] ifFalse: [self error: 'it is too late to compute accessor depths!!']] ifFalse: [((method definingClass includesSelector: method smalltalkSelector) ifTrue: [(method definingClass >> method smalltalkSelector) pragmaAt: #accessorDepth:]) ifNotNil: [:pragma| pragma arguments first] ifNil: + ["Deal with clichés of the form - ["Deal with the primitiveFoo objectMemory hasSpurMemoryManagerAPI ifTrue: [self primitiveFooSpur] ifFalse: [self primitiveFooV3] + and + primitiveFoo + interpreterProxy methodArgumentCount = M + ifTrue: [self primitiveFooM] + ifFalse: [self primitiveFooN] + etc..." + method + isIfThenElseClicheGiven: self + IfTrue: + [:ifTrueCliche :ifFalseCliche| + method extractSpurPrimitiveSelector + ifNotNil: + [:actualSelector| | subMethod | + (subMethod := self methodNamed: actualSelector) ifNil: + [subMethod := self compileToTMethodSelector: actualSelector in: method definingClass]. + self accessorDepthForMethod: subMethod] + ifNil: + [(self accessorDepthForMethod: (self methodNamed: ifTrueCliche)) + max: (self accessorDepthForMethod: (self methodNamed: ifFalseCliche))]] + ifFalse: + [self accessorDepthForMethod: method interpreterClass: (vmClass ifNil: [StackInterpreter])]]]]! - cliché" - method extractSpurPrimitiveSelector - ifNotNil: - [:actualSelector| | subMethod | - (subMethod := self methodNamed: actualSelector) ifNil: - [subMethod := self compileToTMethodSelector: actualSelector in: method definingClass]. - self accessorDepthForMethod: subMethod] - ifNil: [self accessorDepthForMethod: method interpreterClass: (vmClass ifNil: [StackInterpreter])]]]]! Item was added: + ----- Method: TMethod>>isIfThenElseClicheGiven:IfTrue:ifFalse: (in category 'primitive compilation') ----- + isIfThenElseClicheGiven: aCodeGenerator IfTrue: binaryBlock ifFalse: unaryBlock + "If the receiver is a cliché of the form + primitiveFoo + objectMemory hasSpurMemoryManagerAPI + ifTrue: [self primitiveFooSpur] + ifFalse: [self primitiveFooV3] + or + primitiveFoo + interpreterProxy methodArgumentCount = M + ifTrue: [self primitiveFooM] + ifFalse: [self primitiveFooN] + then answer the result of invoking binaryBlock with the two selectors in each arm of the ifTrue:ifFalse:. + Otherwise answer the result of evaluating the unary block." + | firstStmt getSelector | + ((firstStmt := parseTree statements first) isSend + and: [firstStmt isSend + and: [(#(ifTrue:ifFalse: ifFalse:ifTrue:) includes: firstStmt selector) + and: [(firstStmt args allSatisfy: + [:node| | subnode | + node isStmtList + and: [node statements size = 1 + and: [((subnode := node statements first) isSend and: [subnode args isEmpty]) + or: [subnode isReturn and: [subnode expression isSend and: [subnode expression args isEmpty]]]]]]) + and: [parseTree noneSatisfy: + [:node| node isSend and: [aCodeGenerator isStackAccessor: node selector given: aCodeGenerator vmClass]]]]]]) ifTrue: + [getSelector := [:subnode| subnode isReturn ifTrue: [subnode expression selector] ifFalse: [subnode selector]]. + ^binaryBlock + value: (getSelector value: firstStmt args first statements first) + value: (getSelector value: firstStmt args second statements first)]. + ^unaryBlock value! Item was changed: ----- Method: VMClass>>memcpy:_:_: (in category 'C library simulation') ----- memcpy: dest _: src _: bytes <doNotGenerate> "implementation of memcpy(3). N.B. If ranges overlap, must use memmove." | getBlock setBlock source destination | source := src isVMSimulationAddress ifTrue: [src asInteger] ifFalse: [src]. destination := dest isVMSimulationAddress ifTrue: [dest asInteger] ifFalse: [dest]. (source isInteger and: [destination isInteger]) ifTrue: [ self deny: ((destination <= source and: [destination + bytes > source]) or: [source <= destination and: [source + bytes > destination]])]. "Determine the source and destination access blocks based on the parameter type" getBlock := source isCollection ifTrue: [source isString ifTrue: "basicAt: answers integers" [[ :idx | source basicAt: idx]] ifFalse: [source class == ByteArray ifTrue: [[ :idx | source at: idx]]]] ifFalse: [source isInteger ifTrue: [[ :idx | self byteAt: source + idx - 1]] ifFalse: [source isCArray ifTrue: [[ :idx | source at: idx - 1]]]]. getBlock ifNil: [self error: 'unhandled type of source string']. setBlock := destination isCollection ifTrue: [destination isString ifTrue: "basicAt:put: stores integers" [[ :idx | destination basicAt: idx put: (getBlock value: idx)]] ifFalse: [destination class == ByteArray ifTrue: [[ :idx | destination at: idx put: (getBlock value: idx)]]]] ifFalse: [destination isInteger ifTrue: + [| objectMemory | + objectMemory := self objectMemory. + [ :idx | objectMemory byteAt: destination + idx - 1 put: (getBlock value: idx)]] - [[ :idx | self byteAt: destination + idx - 1 put: (getBlock value: idx)]] ifFalse: [destination isCArray ifTrue: [[ :idx | destination at: idx - 1 put: (getBlock value: idx)]]]]. setBlock ifNil: [self error: 'unhandled type of destination string']. 1 to: bytes do: setBlock. ^destination! Item was changed: ----- Method: VMPluginCodeGenerator>>accessorsAndAssignmentsForSubMethodNamed:actuals:depth:interpreterClass:into: (in category 'spur primitive compilation') ----- accessorsAndAssignmentsForSubMethodNamed: selector actuals: actualParameters depth: depth interpreterClass: interpreterClass into: aTrinaryBlock "Evaluate aTrinaryBlock with the root accessor sends, accessor sends and assignments in the sub-method named selector." | method map | (inProgressSelectors includes: selector) ifTrue: [^nil]. inProgressSelectors add: selector. method := self methodNamed: selector. "this is unsatisfactory. a pluggable scheme that asks the relevant plugin the right question would be better but for now the only cross-plugin load is for loadBitBltFrom:warping: and variants." (#(loadBitBltFrom: loadWarpBltFrom: loadBitBltFrom:warping:) includes: selector) ifTrue: [(method isNil or: [method definingClass ~~ BitBltSimulation]) ifTrue: [method := (BitBltSimulation >> selector) asTranslationMethodOfClass: TMethod]]. method ifNil: [^nil]. map := Dictionary new. + method argsForAccessorChainComputation do: [:var| map at: var put: depth asString, var]. - method args do: [:var| map at: var put: depth asString, var]. method locals do: [:var| map at: var put: depth asString, var]. ^self accessorsAndAssignmentsForMethod: (method copy renameVariablesUsing: map) + actuals: (actualParameters ifEmpty: [method argsForAccessorChainComputation]) - actuals: actualParameters depth: depth + 1 interpreterClass: interpreterClass into: aTrinaryBlock! Item was changed: ----- Method: VMPluginCodeGenerator>>isStackAccessor:given: (in category 'spur primitive compilation') ----- isStackAccessor: selector given: interpreterClass + ^(interpreterClass notNil and: [interpreterClass isStackAccessor: selector]) - ^(interpreterClass isStackAccessor: selector) or: [pluginClass isStackAccessor: selector] !

1 0

VM Maker: CogTools-eem.93.mcz
by commits＠source.squeak.org 26 Jul '22

26 Jul '22

Eliot Miranda uploaded a new version of CogTools to project VM Maker: http://source.squeak.org/VMMaker/CogTools-eem.93.mcz ==================== Summary ==================== Name: CogTools-eem.93 Author: eem Time: 26 July 2022, 11:56:59.213388 am UUID: b59134c5-2632-4288-9986-11cc195e3a9c Ancestors: CogTools-eem.92 Extend VMProfilerMacSymbolsManager with support for M1 Macs. The VMProfiler still has to use the new primitive primitiveTextSymbols:. But this is a start. =============== Diff against CogTools-eem.92 =============== Item was changed: ----- Method: VMProfilerMacSymbolsManager>>archName (in category 'parsing') ----- archName "Answer the architecture name for use with nm, size et al." ^(Smalltalk image getSystemAttribute: 1003) caseOf: { ['intel'] -> ['i386']. + ['x64'] -> ['x86_64']. + ['aarch64'] -> ['arm64'] }! - ['x64'] -> ['x86_64'] }! Item was changed: ----- Method: VMProfilerMacSymbolsManager>>primitiveExecutableModulesAndOffsets (in category 'primitives') ----- primitiveExecutableModulesAndOffsets + "Answer an Array with information on the VM executable and all loaded libraries. + The data is flat, occurring in quartets of executable module name, the vm address relocation, the load address and the size for each module. + Hence the effective start address for each module is the sum of the first and second entries following the module name." - "Answer an Array of pairs of executable module names (the VM executable and - all loaded libraries) and the vm address relocation, if any, is for the module." <primitive: 'primitiveExecutableModulesAndOffsets' module: 'VMProfileMacSupportPlugin'> ^self primitiveFailed "self basicNew primitiveExecutableModulesAndOffsets"! Item was added: + ----- Method: VMProfilerMacSymbolsManager>>primitiveTextSymbols: (in category 'primitives') ----- + primitiveTextSymbols: moduleIndex + "Answer an Array of pairs of address, name, for text symbols in the n'th loaded module, + as defined by the _dyld_image_count enumeration." + <primitive: 'primitiveTextSymbols' module: 'VMProfileMacSupportPlugin' error: ec> + ^self primitiveFailed + + "self basicNew primitiveTextSymbols: 0"!

1 0

OSProcessPlugin: VMConstruction-Plugins-OSProcessPlugin.oscog-eem.75.mcz
by squeak-dev-noreply＠lists.squeakfoundation.org 26 Jul '22

26 Jul '22

Eliot Miranda uploaded a new version of VMConstruction-Plugins-OSProcessPlugin to project OSProcessPlugin: http://www.squeaksource.com/OSProcessPlugin/VMConstruction-Plugins-OSProces… ==================== Summary ==================== Name: VMConstruction-Plugins-OSProcessPlugin.oscog-eem.75 Author: eem Time: 26 July 2022, 11:55:07.302605 am UUID: 23069f86-bf3a-4464-b880-75817e312ba5 Ancestors: VMConstruction-Plugins-OSProcessPlugin.oscog-eem.74 Get primitiveEnvironmentAt[AsBytes] to simulate correctly.

1 0

VM Maker: VMMaker.oscog.seperateMarking-WoC.3222.mcz
by commits＠source.squeak.org 26 Jul '22

26 Jul '22

Tom Braun uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog.seperateMarking-WoC.3222.mcz ==================== Summary ==================== Name: VMMaker.oscog.seperateMarking-WoC.3222 Author: WoC Time: 26 July 2022, 4:46:39.622721 pm UUID: d102a150-a9ed-4b32-b4be-f2e2d319383a Ancestors: VMMaker.oscog.seperateMarking-WoC.3207, VMMaker.oscog-dtl.3221 introduce a new class (hierarchy) for garbage collection and put some (by far not all) gc methods from the SpurMemoryManager there =============== Diff against VMMaker.oscog.seperateMarking-WoC.3207 =============== Item was removed: - ----- Method: Spur32BitMMLECoSimulator>>globalGarbageCollect (in category 'gc - global') ----- - globalGarbageCollect - "If we're /not/ a clone, clone the VM and push it over the cliff. - If it survives, destroy the clone and continue. We should be OK until next time." - parent ifNil: - [coInterpreter cr; print: 'GC number '; printNum: statFullGCs; tab; flush. - CloneOnGC ifTrue: - [coInterpreter cloneSimulation objectMemory globalGarbageCollect. - Smalltalk garbageCollect]]. - ^super globalGarbageCollect! Item was added: + ----- Method: Spur32BitMMLECoSimulator>>preGlobalGCActions (in category 'gc - global') ----- + preGlobalGCActions + "If we're /not/ a clone, clone the VM and push it over the cliff. + If it survives, destroy the clone and continue. We should be OK until next time." + parent ifNil: + [coInterpreter cr; print: 'GC number '; printNum: statFullGCs; tab; flush. + CloneOnGC ifTrue: + [coInterpreter cloneSimulation objectMemory gc globalGarbageCollect. + Smalltalk garbageCollect]]! Item was removed: - ----- Method: Spur32BitMMLESimulator>>globalGarbageCollect (in category 'gc - global') ----- - globalGarbageCollect - "If we're /not/ a clone, clone the VM and push it over the cliff. - If it survives, destroy the clone and continue. We should be OK until next time." - parent ifNil: - [coInterpreter cr; print: 'GC number '; printNum: statFullGCs; tab; flush. - CloneOnGC ifTrue: - [coInterpreter cloneSimulation objectMemory globalGarbageCollect. - Smalltalk garbageCollect]]. - ^super globalGarbageCollect! Item was added: + ----- Method: Spur32BitMMLESimulator>>preGlobalGCActions (in category 'gc - global') ----- + preGlobalGCActions + "If we're /not/ a clone, clone the VM and push it over the cliff. + If it survives, destroy the clone and continue. We should be OK until next time." + parent ifNil: + [coInterpreter cr; print: 'GC number '; printNum: statFullGCs; tab; flush. + CloneOnGC ifTrue: + [coInterpreter cloneSimulation objectMemory gc globalGarbageCollect. + Smalltalk garbageCollect]]! Item was changed: ----- Method: Spur64BitMMLECoSimulator>>coInterpreter:cogit: (in category 'initialization') ----- coInterpreter: aCoInterpreter cogit: aCogit coInterpreter := aCoInterpreter. cogit := aCogit. marker coInterpreter: aCoInterpreter. scavenger coInterpreter: aCoInterpreter. + compactor coInterpreter: aCoInterpreter. + gc coInterpreter: aCoInterpreter + ! - compactor coInterpreter: aCoInterpreter! Item was removed: - ----- Method: Spur64BitMMLECoSimulator>>globalGarbageCollect (in category 'gc - global') ----- - globalGarbageCollect - "If we're /not/ a clone, clone the VM and push it over the cliff. - If it survives, destroy the clone and continue. We should be OK until next time." - parent ifNil: - [coInterpreter cr; print: 'GC number '; printNum: statFullGCs; tab; flush. - CloneOnGC ifTrue: - [coInterpreter cloneSimulation objectMemory globalGarbageCollect. - Smalltalk garbageCollect]]. - ^super globalGarbageCollect! Item was added: + ----- Method: Spur64BitMMLECoSimulator>>preGlobalGCActions (in category 'gc - global') ----- + preGlobalGCActions + "If we're /not/ a clone, clone the VM and push it over the cliff. + If it survives, destroy the clone and continue. We should be OK until next time." + parent ifNil: + [coInterpreter cr; print: 'GC number '; printNum: statFullGCs; tab; flush. + CloneOnGC ifTrue: + [coInterpreter cloneSimulation objectMemory gc globalGarbageCollect. + Smalltalk garbageCollect]]! Item was removed: - ----- Method: Spur64BitMMLESimulator>>globalGarbageCollect (in category 'gc - global') ----- - globalGarbageCollect - "If we're /not/ a clone, clone the VM and push it over the cliff. - If it survives, destroy the clone and continue. We should be OK until next time." - parent ifNil: - [coInterpreter cr; print: 'GC number '; printNum: statFullGCs; tab; flush. - CloneOnGC ifTrue: - [coInterpreter cloneSimulation objectMemory globalGarbageCollect. - Smalltalk garbageCollect]]. - ^super globalGarbageCollect! Item was added: + ----- Method: Spur64BitMMLESimulator>>preGlobalGCActions (in category 'gc - global') ----- + preGlobalGCActions + "If we're /not/ a clone, clone the VM and push it over the cliff. + If it survives, destroy the clone and continue. We should be OK until next time." + parent ifNil: + [coInterpreter cr; print: 'GC number '; printNum: statFullGCs; tab; flush. + CloneOnGC ifTrue: + [coInterpreter cloneSimulation objectMemory gc globalGarbageCollect. + Smalltalk garbageCollect]]! Item was changed: SpurMarker subclass: #SpurAllAtOnceMarker + instanceVariableNames: '' - instanceVariableNames: 'marking' classVariableNames: '' + poolDictionaries: '' - poolDictionaries: 'SpurObjStackConstants VMBasicConstants' category: 'VMMaker-SpurMemoryManager'! Item was removed: - ----- Method: SpurAllAtOnceMarker>>initialize (in category 'instance initialization') ----- - initialize - - marking := false! Item was removed: - ----- Method: SpurAllAtOnceMarker>>marking (in category 'marking') ----- - marking - <cmacro: '() GIV(marking)'> - - ^ marking! Item was added: + CogClass subclass: #SpurGarbageCollector + instanceVariableNames: 'marker scavenger compactor manager coInterpreter' + classVariableNames: '' + poolDictionaries: 'SpurMemoryManagementConstants' + category: 'VMMaker-SpurMemoryManager'! Item was added: + ----- Method: SpurGarbageCollector class>>classesForTranslation (in category 'as yet unclassified') ----- + classesForTranslation + + ^ self shouldBeImplemented! Item was added: + ----- Method: SpurGarbageCollector>>coInterpreter (in category 'accessing') ----- + coInterpreter + + ^ coInterpreter! Item was added: + ----- Method: SpurGarbageCollector>>coInterpreter: (in category 'accessing') ----- + coInterpreter: anObject + + coInterpreter := anObject.! Item was added: + ----- Method: SpurGarbageCollector>>compactor (in category 'accessing') ----- + compactor + + ^ compactor! Item was added: + ----- Method: SpurGarbageCollector>>compactor: (in category 'accessing') ----- + compactor: anObject + + compactor := anObject.! Item was added: + ----- Method: SpurGarbageCollector>>doScavenge: (in category 'scavenge') ----- + doScavenge: tenuringCriterion + "The inner shell for scavenge, abstrascted out so globalGarbageCollect can use it." + <inline: false> + self doAllocationAccountingForScavenge. + manager gcPhaseInProgress: ScavengeInProgress. + manager pastSpaceStart: (scavenger scavenge: tenuringCriterion). + self assert: (self + oop: manager pastSpaceStart + isGreaterThanOrEqualTo: scavenger pastSpace start + andLessThanOrEqualTo: scavenger pastSpace limit). + manager freeStart: scavenger eden start. + manager gcPhaseInProgress: 0. + self resetAllocationAccountingAfterGC! Item was added: + ----- Method: SpurGarbageCollector>>fullGC (in category 'global') ----- + fullGC + + ^ self subclassResponsibility! Item was added: + ----- Method: SpurGarbageCollector>>incrementalCollect (in category 'global') ----- + incrementalCollect + + ^ self subclassResponsibility! Item was added: + ----- Method: SpurGarbageCollector>>manager (in category 'accessing') ----- + manager + + ^ manager! Item was added: + ----- Method: SpurGarbageCollector>>manager: (in category 'accessing') ----- + manager: anObject + + manager := anObject.! Item was added: + ----- Method: SpurGarbageCollector>>marker (in category 'accessing') ----- + marker + + ^ marker! Item was added: + ----- Method: SpurGarbageCollector>>marker: (in category 'accessing') ----- + marker: anObject + + marker := anObject.! Item was added: + ----- Method: SpurGarbageCollector>>scavenger (in category 'accessing') ----- + scavenger + + ^ scavenger! Item was added: + ----- Method: SpurGarbageCollector>>scavenger: (in category 'accessing') ----- + scavenger: anObject + + scavenger := anObject.! Item was added: + ----- Method: SpurGarbageCollector>>scavengingGCTenuringIf: (in category 'scavenge') ----- + scavengingGCTenuringIf: tenuringCriterion + "Run the scavenger." + <inline: false> + self assert: manager remapBufferCount = 0. + (self asserta: scavenger eden limit - manager freeStart > coInterpreter interpreterAllocationReserveBytes) ifFalse: + [coInterpreter tab; + printNum: scavenger eden limit - manager freeStart; space; + printNum: coInterpreter interpreterAllocationReserveBytes; space; + printNum: coInterpreter interpreterAllocationReserveBytes - (scavenger eden limit - manager freeStart); cr]. + manager checkMemoryMap. + manager checkFreeSpace: GCModeNewSpace. + manager runLeakCheckerFor: GCModeNewSpace. + + coInterpreter + preGCAction: GCModeNewSpace; + "would prefer this to be in mapInterpreterOops, but + compatibility with ObjectMemory dictates it goes here." + flushMethodCacheFrom: manager newSpaceStart to: manager oldSpaceStart. + manager needGCFlag: false. + + manager gcStartUsecs: coInterpreter ioUTCMicrosecondsNow. + + self doScavenge: tenuringCriterion. + + manager statScavenges: manager statScavenges + 1. + manager statGCEndUsecs: coInterpreter ioUTCMicrosecondsNow. + manager statSGCDeltaUsecs: manager statGCEndUsecs - manager gcStartUsecs. + manager statScavengeGCUsecs: manager statScavengeGCUsecs + manager statSGCDeltaUsecs. + manager statRootTableCount: scavenger rememberedSetSize. + + scavenger logScavenge. + + coInterpreter postGCAction: GCModeNewSpace. + + manager runLeakCheckerFor: GCModeNewSpace. + manager checkFreeSpace: GCModeNewSpace! Item was changed: CogClass subclass: #SpurMarker + instanceVariableNames: 'manager coInterpreter marking' - instanceVariableNames: 'manager coInterpreter' classVariableNames: '' + poolDictionaries: 'SpurObjStackConstants VMBasicConstants' - poolDictionaries: '' category: 'VMMaker-SpurMemoryManager'! Item was added: + ----- Method: SpurMarker>>initialize (in category 'initialize-release') ----- + initialize + + marking := false! Item was added: + ----- Method: SpurMarker>>marking (in category 'marking') ----- + marking + <cmacro: '() GIV(marking)'> + + ^ marking! Item was changed: CogClass subclass: #SpurMemoryManager (excessive size, no diff calculated) Item was changed: ----- Method: SpurMemoryManager class>>ancilliaryClasses (in category 'translation') ----- ancilliaryClasses "Answer any extra classes to be included in the translation." + ^{ SpurScavengeLogRecord. SpurSegmentManager. SpurSegmentInfo }, + self gcClass classesForTranslation, - ^{ SpurGenerationScavenger. SpurScavengeLogRecord. SpurSegmentManager. SpurSegmentInfo. SpurAllAtOnceMarker }, - self compactorClass classesForTranslation, SpurNewSpaceSpace withAllSubclasses ! Item was added: + ----- Method: SpurMemoryManager class>>gcClass (in category 'accessing class hierarchy') ----- + gcClass + "Answer the garbage collection algorithm to use." + ^Smalltalk classNamed: (InitializationOptions at: #gcClass ifAbsent: [#SpurStopTheWorldGarbageCollector])! Item was changed: ----- Method: SpurMemoryManager class>>initialize (in category 'class initialization') ----- initialize "SpurMemoryManager initialize" BitsPerByte := 8. "Initialize at least the become constants for the Spur bootstrap where the old ObjectMemory simulator is used before a Spur simulator is created.." self initializeSpurObjectRepresentationConstants. "An obj stack is a stack of objects stored in a hidden root slot, such as the markStack or the ephemeronQueue. It is a linked list of segments, with the hot end at the head of the list. It is a word object. The stack pointer is in ObjStackTopx and 0 means empty. The list goes through ObjStackNextx. We don't want to shrink objStacks, since they're used in GC and it's good to keep their memory around. So unused pages created by popping emptied pages are kept on the ObjStackFreex list. ObjStackNextx must be the last field for swizzleObjStackAt:." ObjStackPageSlots := 4092. "+ double header = 16k bytes per page in 32-bits, 32k bytes per page in 64 bits" ObjStackTopx := 0. ObjStackMyx := 1. ObjStackFreex := 2. ObjStackNextx := 3. ObjStackFixedSlots := 4. ObjStackLimit := ObjStackPageSlots - ObjStackFixedSlots. "The hiddenRootsObject contains the classTable pages and up to 8 additional objects. Currently we use four; the three objStacks (the mark stack, the weaklings and the mourn queue), and the rememberedSet." MarkStackRootIndex := self basicNew classTableRootSlots. WeaklingStackRootIndex := MarkStackRootIndex + 1. MournQueueRootIndex := MarkStackRootIndex + 2. RememberedSetRootIndex := MarkStackRootIndex + 3. + EphemeronStackRootIndex := MarkStackRootIndex + 4. MarkObjectsForEnumerationPrimitives := false. "The remap buffer support is for compatibility; Spur doesn't GC during allocation. Eventually this should die." RemapBufferSize := 25. "Extra roots are for plugin support." ExtraRootsSize := 64. "max. # of external roots; used e.g. by the PyBridge plugin which uses three entries" "gcPhaseInProgress takes these values to identify phases as required." ScavengeInProgress := 1. SlidingCompactionInProgress := 2! Item was changed: ----- Method: SpurMemoryManager>>allocateMemoryOfSize:newSpaceSize:stackSize:codeSize: (in category 'spur bootstrap') ----- allocateMemoryOfSize: memoryBytes newSpaceSize: newSpaceBytes stackSize: stackBytes codeSize: codeBytes "Intialize the receiver for bootsraping an image. Set up a large oldSpace and an empty newSpace and set-up freeStart and scavengeThreshold to allocate in oldSpace. Later on (in initializePostBootstrap) freeStart and scavengeThreshold will be set to sane values." <doNotGenerate> self assert: (memoryBytes \\ self allocationUnit = 0 and: [newSpaceBytes \\ self allocationUnit = 0 and: [codeBytes \\ self allocationUnit = 0]]). self allocateMemoryOfSize: memoryBytes + newSpaceBytes + codeBytes + stackBytes. newSpaceStart := codeBytes + stackBytes. endOfMemory := freeOldSpaceStart := memoryBytes + newSpaceBytes + codeBytes + stackBytes. "leave newSpace empty for the bootstrap" freeStart := newSpaceBytes + newSpaceStart. oldSpaceStart := newSpaceBytes + newSpaceStart. scavengeThreshold := memory size * memory bytesPerElement. "i.e. /don't/ scavenge." marker := self class markerClass simulatorClass new manager: self; yourself. scavenger := SpurGenerationScavenger simulatorClass new. scavenger manager: self. scavenger newSpaceStart: newSpaceStart newSpaceBytes: newSpaceBytes survivorBytes: newSpaceBytes // self scavengerDenominator. + compactor := self class compactorClass simulatorClass new manager: self; yourself. + + gc := self class gcClass simulatorClass new manager: self; yourself. - compactor := self class compactorClass simulatorClass new manager: self; yourself ! Item was changed: ----- Method: SpurMemoryManager>>coInterpreter: (in category 'simulation') ----- coInterpreter: aCoInterpreter <doNotGenerate> coInterpreter := aCoInterpreter. + marker ifNotNil: + [marker coInterpreter: aCoInterpreter]. scavenger ifNotNil: [scavenger coInterpreter: aCoInterpreter]. compactor ifNotNil: [compactor coInterpreter: aCoInterpreter]! Item was added: + ----- Method: SpurMemoryManager>>compactionStartUsecs: (in category 'accessing') ----- + compactionStartUsecs: anInteger + + compactionStartUsecs := anInteger! Item was added: + ----- Method: SpurMemoryManager>>freeLists (in category 'accessing') ----- + freeLists + + ^ freeLists! Item was added: + ----- Method: SpurMemoryManager>>freeStart: (in category 'accessing') ----- + freeStart: anInteger + + freeStart := anInteger! Item was changed: ----- Method: SpurMemoryManager>>fullGC (in category 'gc - global') ----- fullGC + <doNotGenerate> + + gc fullGC! - "Perform a full eager compacting GC. Answer the size of the largest free chunk." - <returnTypeC: #usqLong> - <inline: #never> "for profiling" - needGCFlag := false. - gcStartUsecs := coInterpreter ioUTCMicrosecondsNow. - statMarkCount := 0. - coInterpreter preGCAction: GCModeFull. - self globalGarbageCollect. - coInterpreter postGCAction: GCModeFull. - statGCEndUsecs := coInterpreter ioUTCMicrosecondsNow. - self updateFullGCStats. - ^(freeLists at: 0) ~= 0 - ifTrue: [self bytesInBody: self findLargestFreeChunk] - ifFalse: [0]! Item was added: + ----- Method: SpurMemoryManager>>gc (in category 'accessing') ----- + gc + + ^ gc! Item was added: + ----- Method: SpurMemoryManager>>gc: (in category 'accessing') ----- + gc: aSpurGarbageCollector + + gc := aSpurGarbageCollector! Item was added: + ----- Method: SpurMemoryManager>>gcMarkEndUsecs: (in category 'accessing') ----- + gcMarkEndUsecs: anInteger + + gcMarkEndUsecs := anInteger! Item was added: + ----- Method: SpurMemoryManager>>gcStartUsecs: (in category 'accessing') ----- + gcStartUsecs: anInteger + + gcStartUsecs := anInteger! Item was removed: - ----- Method: SpurMemoryManager>>globalGarbageCollect (in category 'gc - global') ----- - globalGarbageCollect - <inline: true> "inline into fullGC" - self assert: self validObjStacks. - self assert: (self isEmptyObjStack: markStack). - self assert: (self isEmptyObjStack: weaklingStack). - - "Mark objects /before/ scavenging, to empty the rememberedTable of unmarked roots." - marker markObjects: true. - gcMarkEndUsecs := coInterpreter ioUTCMicrosecondsNow. - - scavenger forgetUnmarkedRememberedObjects. - - coInterpreter setGCMode: GCModeNewSpace. - self doScavenge: MarkOnTenure. - coInterpreter setGCMode: GCModeFull. - - "Mid-way the leak check must be more lenient. Unmarked classes will have been - expunged from the table, but unmarked instances will not yet have been reclaimed." - self runLeakCheckerFor: GCModeFull - excludeUnmarkedObjs: true - classIndicesShouldBeValid: true. - - compactionStartUsecs := coInterpreter ioUTCMicrosecondsNow. - segmentManager prepareForGlobalSweep. "for notePinned:" - compactor compact. - self attemptToShrink. - self setHeapSizeAtPreviousGC. - - self assert: self validObjStacks. - self assert: (self isEmptyObjStack: markStack). - self assert: (self isEmptyObjStack: weaklingStack). - self assert: self allObjectsUnmarked. - self runLeakCheckerFor: GCModeFull! Item was changed: ----- Method: SpurMemoryManager>>initialize (in category 'initialization') ----- initialize "We can put all initializations that set something to 0 or to false here. In C all global variables are initialized to 0, and 0 is false." | moreThanEnough | remapBuffer := Array new: RemapBufferSize. remapBufferCount := extraRootCount := 0. "see below" freeListsMask := totalFreeOldSpace := lowSpaceThreshold := 0. checkForLeaks := 0. needGCFlag := signalLowSpace := false. becomeEffectsFlags := gcPhaseInProgress := validatedIntegerClassFlags := 0. statScavenges := statIncrGCs := statFullGCs := 0. statMaxAllocSegmentTime := 0. statMarkUsecs := statSweepUsecs := statScavengeGCUsecs := statIncrGCUsecs := statFullGCUsecs := statCompactionUsecs := statGCEndUsecs := gcSweepEndUsecs := 0. statSGCDeltaUsecs := statIGCDeltaUsecs := statFGCDeltaUsecs := 0. statGrowMemory := statShrinkMemory := statRootTableCount := statAllocatedBytes := 0. statRootTableOverflows := statMarkCount := statCompactPassCount := statCoalesces := 0. "We can initialize things that are allocated but are lazily initialized." unscannedEphemerons := SpurContiguousObjStack new. "we can initialize things that are virtual in C." scavenger := SpurGenerationScavenger simulatorClass new manager: self; yourself. segmentManager := SpurSegmentManager simulatorClass new manager: self; yourself. compactor := self class compactorClass simulatorClass new manager: self; yourself. marker := self class markerClass simulatorClass new manager: self; yourself. + gc := self class gcClass simulatorClass new manager: self; yourself. "We can also initialize here anything that is only for simulation." heapMap := CogCheck32BitHeapMap new. "N.B. We *don't* initialize extraRoots because we don't simulate it." "This is needed on 64-bits. We don't want a simulation creating a huge heap by default. By default use 512Mb on 64-bits, 256Mb on 32-bits." moreThanEnough := 1024 * 1024 * 1024 / (16 / self wordSize). "One million dollars, ha ha ha ha ha,... ha, ha ha ha ha, ..." maxOldSpaceSize := self class initializationOptions ifNotNil: [:initOpts| initOpts at: #maxOldSpaceSize ifAbsent: [moreThanEnough]] ifNil: [moreThanEnough]! Item was added: + ----- Method: SpurMemoryManager>>marker (in category 'accessing') ----- + marker + + ^ marker! Item was added: + ----- Method: SpurMemoryManager>>needGCFlag: (in category 'accessing') ----- + needGCFlag: anInteger + + needGCFlag := anInteger ~= 0! Item was changed: ----- Method: SpurMemoryManager>>nilUnmarkedWeaklingSlots (in category 'weakness and ephemerality') ----- nilUnmarkedWeaklingSlots "Nil the unmarked slots in the weaklings on the weakling stack, finalizing those that lost references. Finally, empty the weaklingStack." <inline: #never> "for profiling" self cCode: '' inSmalltalk: [coInterpreter transcript nextPutAll: 'nilling...'; flush]. self eassert: [self allOldMarkedWeakObjectsOnWeaklingStack]. weaklingStack = nilObj ifTrue: [^self]. self objStack: weaklingStack from: 0 do: [:weakling| | anyUnmarked | anyUnmarked := self nilUnmarkedWeaklingSlotsIn: weakling. anyUnmarked ifTrue: ["fireFinalization: could grow the mournQueue and if so, additional pages must be marked to avoid being GC'ed." + self assert: marker marking. - self assert: marking. coInterpreter fireFinalization: weakling]]. self emptyObjStack: weaklingStack! Item was added: + ----- Method: SpurMemoryManager>>pastSpaceStart: (in category 'accessing') ----- + pastSpaceStart: anInteger + + pastSpaceStart := anInteger! Item was added: + ----- Method: SpurMemoryManager>>preGlobalGCActions (in category 'gc - global') ----- + preGlobalGCActions + <doNotGenerate>! Item was added: + ----- Method: SpurMemoryManager>>statGCEndUsecs: (in category 'accessing') ----- + statGCEndUsecs: anInteger + + statGCEndUsecs := anInteger! Item was added: + ----- Method: SpurMemoryManager>>statMarkCount: (in category 'accessing') ----- + statMarkCount: anInteger + + statMarkCount := anInteger! Item was added: + ----- Method: SpurMemoryManager>>statRootTableCount: (in category 'accessing') ----- + statRootTableCount: anInteger + + statRootTableCount := anInteger! Item was added: + ----- Method: SpurMemoryManager>>statSGCDeltaUsecs: (in category 'accessing') ----- + statSGCDeltaUsecs: anInteger + + statSGCDeltaUsecs := anInteger! Item was added: + ----- Method: SpurMemoryManager>>statScavengeGCUsecs: (in category 'accessing') ----- + statScavengeGCUsecs: anInteger + + statScavengeGCUsecs := anInteger! Item was added: + ----- Method: SpurMemoryManager>>statScavenges: (in category 'accessing') ----- + statScavenges: anInteger + + statScavenges := anInteger! Item was added: + SpurGarbageCollector subclass: #SpurStopTheWorldGarbageCollector + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMaker-SpurMemoryManager'! Item was added: + ----- Method: SpurStopTheWorldGarbageCollector class>>classesForTranslation (in category 'as yet unclassified') ----- + classesForTranslation + + ^ {self . SpurGenerationScavenger . SpurAllAtOnceMarker . SpurPlanningCompactor}! Item was added: + ----- Method: SpurStopTheWorldGarbageCollector class>>sourceSortingKey (in category 'as yet unclassified') ----- + sourceSortingKey + "To keep methods in the same order while refactoring..." + ^SpurMemoryManager name! Item was added: + ----- Method: SpurStopTheWorldGarbageCollector>>fullGC (in category 'as yet unclassified') ----- + fullGC + "Perform a full eager compacting GC. Answer the size of the largest free chunk." + <returnTypeC: #usqLong> + <inline: #never> "for profiling" + + manager needGCFlag: 0. + manager gcStartUsecs: coInterpreter ioUTCMicrosecondsNow. + manager statMarkCount: 0. + coInterpreter preGCAction: GCModeFull. + self globalGarbageCollect. + coInterpreter postGCAction: GCModeFull. + manager statGCEndUsecs: coInterpreter ioUTCMicrosecondsNow. + manager updateFullGCStats. + ^(manager freeLists at: 0) ~= 0 + ifTrue: [self bytesInBody: manager findLargestFreeChunk] + ifFalse: [0]! Item was added: + ----- Method: SpurStopTheWorldGarbageCollector>>globalGarbageCollect (in category 'as yet unclassified') ----- + globalGarbageCollect + <inline: true> "inline into fullGC" + + manager preGlobalGCActions. + + self assert: self validObjStacks. + self assert: (self isEmptyObjStack: manager markStack). + self assert: (self isEmptyObjStack: manager weaklingStack). + + "Mark objects /before/ scavenging, to empty the rememberedTable of unmarked roots." + marker markObjects: true. + manager gcMarkEndUsecs: coInterpreter ioUTCMicrosecondsNow. + + scavenger forgetUnmarkedRememberedObjects. + + coInterpreter setGCMode: GCModeNewSpace. + self doScavenge: MarkOnTenure. + coInterpreter setGCMode: GCModeFull. + + "Mid-way the leak check must be more lenient. Unmarked classes will have been + expunged from the table, but unmarked instances will not yet have been reclaimed." + manager runLeakCheckerFor: GCModeFull + excludeUnmarkedObjs: true + classIndicesShouldBeValid: true. + + manager compactionStartUsecs: coInterpreter ioUTCMicrosecondsNow. + manager segmentManager prepareForGlobalSweep. "for notePinned:" + compactor compact. + manager attemptToShrink. + manager setHeapSizeAtPreviousGC. + + self assert: manager validObjStacks. + self assert: (manager isEmptyObjStack: manager markStack). + self assert: (manager isEmptyObjStack: manager weaklingStack). + self assert: manager allObjectsUnmarked. + manager runLeakCheckerFor: GCModeFull! Item was added: + ----- Method: SpurStopTheWorldGarbageCollector>>incrementalCollect (in category 'as yet unclassified') ----- + incrementalCollect + "not supported in a stop the world GC -> no op" + + <doNotGenerate> + ^ self shouldNotImplement!

1 0

CRC fix input
by ken.dickey＠whidbey.com 26 Jul '22

26 Jul '22

Greetings, The src/plugins/ZipPlugin/ZipPlugin.c function primitiveUpdateGZipCrc32() is currently broken on RiscV64. This is due to a "boxed" 64 bit int, only 32 bits of which is actually used here. The choice I made was to add a definition to platforms/Cross/vm/sqMemoryAccess.h vvv---vvv /* usqInt32 is a 32 bit unsigned integer on 32 and 64 bit systems */ #define usqInt32 unsigned int ^^^---^^^ And then change the local def in primitiveUpdateGZipCrc32() vvv---vvv usqInt32 crc; ^^^---^^^ [A] This works for arch64/arm64 and riscv64/RV64G in both Cuis and Squeak, but I currently lack other systems to test on. [B] This _one_ variable use is the _only_ place so far that I have found with this problem. If the VMMaker ZipPlugin generated the unsigned 32 bit int var def directly, sqMemoryAccess.h could remain unchanged. What is the best way to approach this? Thanks much, -KenD

3 3

VM Maker: VMMaker.oscog-dtl.3221.mcz
by commits＠source.squeak.org 26 Jul '22

26 Jul '22

David T. Lewis uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-dtl.3221.mcz ==================== Summary ==================== Name: VMMaker.oscog-dtl.3221 Author: dtl Time: 25 July 2022, 8:08:58.54002 pm UUID: df740252-bcf3-465c-aa64-588b37ed0dd2 Ancestors: VMMaker.oscog-eem.3220 Fix type declaration problem in DeflatePlugin affecting RiscV64 compilation, thanks Key Dickey http://lists.squeakfoundation.org/pipermail/vm-dev/2022-July/038221.html =============== Diff against VMMaker.oscog-eem.3220 =============== Item was changed: ----- Method: DeflatePlugin>>primitiveUpdateGZipCrc32 (in category 'primitives') ----- primitiveUpdateGZipCrc32 "Primitive. Update a 32bit CRC value." <export: true> <primitiveMetadata: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> "Using AlignForFloats since the arithmetic is potentially vectorizable..." | collection stopIndex startIndex crc length bytePtr | <var: #bytePtr type: #'unsigned char *'> + <var: #crc type: #'unsigned int'> collection := interpreterProxy stackValue: 0. stopIndex := interpreterProxy stackIntegerValue: 1. startIndex := interpreterProxy stackIntegerValue: 2. crc := interpreterProxy positive32BitValueOf: (interpreterProxy stackValue: 3). interpreterProxy failed ifTrue: [^self]. ((interpreterProxy isBytes: collection) and:[stopIndex >= startIndex and:[startIndex > 0]]) ifFalse:[^interpreterProxy primitiveFail]. length := interpreterProxy byteSizeOf: collection. (stopIndex <= length) ifFalse:[^interpreterProxy primitiveFail]. bytePtr := interpreterProxy firstIndexableField: collection. self cCode:'' inSmalltalk:[zipCrcTable := CArrayAccessor on: GZipWriteStream crcTable]. startIndex := startIndex - 1. stopIndex := stopIndex - 1. startIndex to: stopIndex do: [:i| crc := (zipCrcTable at: ((crc bitXor: (bytePtr at: i)) bitAnd: 255)) bitXor: crc >> 8]. interpreterProxy methodReturnValue: (interpreterProxy positive32BitIntegerFor: crc)!

1 0

VM Maker: VMMaker-dtl.434.mcz
by commits＠source.squeak.org 26 Jul '22

26 Jul '22

David T. Lewis uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker-dtl.434.mcz ==================== Summary ==================== Name: VMMaker-dtl.434 Author: dtl Time: 24 July 2022, 6:37:41.373 pm UUID: 1ba8463f-b249-4f77-8327-9129856ceddc Ancestors: VMMaker-dtl.433 VMMaker 4.19.15 Fix type declaration problem in DeflatePlugin affecting RiscV64 compilation, thanks Key Dickey http://lists.squeakfoundation.org/pipermail/vm-dev/2022-July/038221.html =============== Diff against VMMaker-dtl.433 =============== Item was changed: ----- Method: DeflatePlugin>>primitiveUpdateGZipCrc32 (in category 'primitives') ----- primitiveUpdateGZipCrc32 "Primitive. Update a 32bit CRC value." | collection stopIndex startIndex crc length bytePtr | <export: true> <var: #bytePtr type: #'unsigned char *'> + <var: #crc type: #'unsigned int'> interpreterProxy methodArgumentCount = 4 ifFalse:[^interpreterProxy primitiveFail]. collection := interpreterProxy stackObjectValue: 0. stopIndex := interpreterProxy stackIntegerValue: 1. startIndex := interpreterProxy stackIntegerValue: 2. crc := interpreterProxy positive32BitValueOf: (interpreterProxy stackValue: 3). interpreterProxy failed ifTrue: [^0]. ((interpreterProxy isBytes: collection) and:[stopIndex >= startIndex and:[startIndex > 0]]) ifFalse:[^interpreterProxy primitiveFail]. length := interpreterProxy byteSizeOf: collection. (stopIndex <= length) ifFalse:[^interpreterProxy primitiveFail]. bytePtr := interpreterProxy firstIndexableField: collection. self cCode:'' inSmalltalk:[zipCrcTable := CArrayAccessor on: GZipWriteStream crcTable]. startIndex := startIndex - 1. stopIndex := stopIndex - 1. startIndex to: stopIndex do: [:i| crc := (zipCrcTable at: ((crc bitXor: (bytePtr at: i)) bitAnd: 255)) bitXor: (crc >> 8)]. interpreterProxy pop: 5 "args + rcvr" thenPush: (interpreterProxy positive32BitIntegerFor: crc)! Item was changed: ----- Method: VMMaker class>>versionString (in category 'version testing') ----- versionString "VMMaker versionString" + ^'4.19.15'! - ^'4.19.14'!

1 0

Re: [Vm-dev] CRC fix input (David T. Lewis)
by ken.dickey＠whidbey.com 26 Jul '22

26 Jul '22

Dave, Many thanks for the explanations. At this point I am using the image scripts to generate a VMMaker image, which on RasPi4 Linux gets close and dies, but I am able to run the CoInterp init methods and generate code. One wrinkle with the Squeak 6 version is that attempting to open a repo in the Monticello Browser (e.g. VMMakerInbox) generates "Error: primitiveSSLCreate failed". I was able to access the repos via a 5.3 Squeak image and use the package-cache to be able to load a Monticello package into VMMaker. I am able to generate and build aarch64 and riscv64 images for test. The ThreadedRiscV64FFIPlugin shares much of the mechanics with ThreadedARM64FFIPlugin so is a subclass. Because of this, some updates for riscv64 require a change to the ThreadedARM64FFIPlugin level. The problem of the week is to get the C casting/coercion right for both arm64 and riscv64, but [A] I have not used C much in the last couple of decades and [B] I don't yet get know the VMMaker idioms to get the generated code to do what I want. Still learning. I know what I want at the CPU/machine/asm level and can get the (hacked) generated C code to work on both arm64 and riscv64 VM binaries (in the opensmalltalk-vm github repo see src/plugins/SqueakFFIPrims/RiscV64FFIPlugin.c) but have not yet figured out how to teach VMMaker how to get a clean RiscV64FFIPlugin.c from the Smalltalk source. The problem is to get the FFI called function to return the properly cased float/double/other as the riscv64 gcc is very finicky to stick to the strict ABI. Much less forgiving (or less creative) than the arm64 gcc codegen. So I am currently in an observe, theorize, test, repeat (er, hack, gen code, build) cycle as I learn the mechanics and I am re-remembering all the reasons I droped development in C in favor of Smalltalk. If you are deep into the mechanics, you can take a look at the attached, but I will be experimenting in the mean time. I am happy to do an off-line if you have a deep desire to get into the weeds on this, but I suspect a bit more experimenting will get the Smalltalk->C->gcc->run end-to-end up. Thanks once again for the kind background description. -KenD

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev July 2022