Vm-dev March 2024

vm-dev@lists.squeakfoundation.org

13 participants
32 discussions

[OpenSmalltalk/opensmalltalk-vm] 4a3e4e: Regen the BMPReadWriterPlugin so it has an officia...
by Eliot Miranda 20 Mar '24

20 Mar '24

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 4a3e4e0f5ce16a4595cb95823987fb2cd63c643e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/4a3e4e0f5ce16a4595… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2024-03-19 (Tue, 19 Mar 2024) Changed paths: M src/plugins/BMPReadWriterPlugin/BMPReadWriterPlugin.c Log Message: ----------- Regen the BMPReadWriterPlugin so it has an official version stamp. To unsubscribe from these emails, change your notification settings at https://github.com/OpenSmalltalk/opensmalltalk-vm/settings/notifications

3 2

VM Maker: VMMaker.threaded-LM.3355.mcz
by commits＠source.squeak.org 20 Mar '24

20 Mar '24

Leon Matthes uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.threaded-LM.3355.mcz ==================== Summary ==================== Name: VMMaker.threaded-LM.3355 Author: LM Time: 20 March 2024, 3:45:46.213376 pm UUID: 537e53f3-b38a-4f82-a7d8-b3eeb232e2ce Ancestors: VMMaker.threaded-LM.3354 Fix a critical bug in threadSwitchIfNecessary:from: . If the activeProcess context was nil, it wasn't restored correctly. This has been fixed now. This has a problem though, as we need to marry the activeProcess context every time we do a thread switch, this can cause a lot of GCs, as we create a lot of context objects. Maybe we can fix this later? =============== Diff against VMMaker.threaded-LM.3354 =============== Item was changed: ----- Method: CoInterpreterMT>>ownVM:withFlags: (in category 'vm scheduling') ----- ownVM: vmThreadHandle withFlags: additionalFlags <public> <inline: false> <var: #vmThreadHandle type: #'void *'> <var: #vmThread type: #'CogVMThread *'> "This is the entry-point for plugins and primitives that wish to reacquire the VM after having released it via disownVM or callbacks that want to acquire it without knowing their ownership status. This call will block until the VM is owned by the current thread or an error occurs. The argument should be the value answered by disownVM, or 0 for callbacks that don't know if they have disowned or not. This is both an optimization to avoid having to query thread- local storage for the current thread's index (since it can easily keep it in some local variable), and a record of when an unbound process becomes affined to a thread for the dynamic extent of some operation. Answer 0 if the current thread is known to the VM (and on return owns the VM). Answer 1 if the current thread is unknown to the VM and takes ownership. Answer -1 if the current thread is unknown to the VM and fails to take ownership." | flags vmThread | vmThread := self cCoerce: vmThreadHandle to: #'CogVMThread *'. vmThread ifNil: [^self ownVMFromUnidentifiedThread]. self assert: vmThread = (cogThreadManager vmThreadAt: vmThread index). flags := vmThread disownFlags bitOr: additionalFlags. + vmThread := cogThreadManager acquireVMFor: vmThread. + disownCount := disownCount - 1. + (flags anyMask: DisownVMForProcessorRelinquish) ifTrue: ["Presumably we have nothing to do; this primitive is typically called from the background process. So we should /not/ try and activate any threads in the pool; they will waste cycles finding there is no runnable process, and will cause a VM abort if no runnable process is found. But we /do/ want to allow FFI calls that have completed, or callbacks a chance to get into the VM; they do have something to do. DisownVMForProcessorRelinquish indicates this." relinquishing := false. self sqLowLevelMFence]. - vmThread := cogThreadManager acquireVMFor: vmThread. - disownCount := disownCount - 1. - disowningVMThread ifNotNil: [vmThread = disowningVMThread ifTrue: [self assert: (vmThread cFramePointer isNil or: [CFramePointer = vmThread cFramePointer and: [CStackPointer = vmThread cStackPointer]]). self assert: self successful. self assert: (objectMemory fetchPointer: MyListIndex ofObject: self activeProcess) = objectMemory nilObject. disowningVMThread := nil. cogit recordEventTrace ifTrue: [self recordTrace: TraceOwnVM thing: ConstOne source: 0]. ^0]. "if not preempted we're done." self preemptDisowningThread]. "We've been preempted; we must restore state and update the threadId in our process, and may have to put the active process to sleep." self restoreVMStateFor: vmThread andFlags: flags. cogit recordEventTrace ifTrue: [self recordTrace: TraceOwnVM thing: ConstTwo source: 0]. ^flags bitAnd: OwnVMForeignThreadFlag! Item was changed: ----- Method: CoInterpreterMT>>primitiveProcessBindToThreadAffinity (in category 'process primitives') ----- primitiveProcessBindToThreadAffinity "Attempt to bind the receiver to the thread affinity of the argument or nil, where the receiver is a Process. The thread affinity may be an integer where: 0 - means no thread affinity, the process is free to run on any thread. > 0 - positive values mean the process has to run on the thread with this specific index. < 0 - negative values mean the process may run on on any thread **APART** from the thread with the absolute value of the index. Usually values of 1, -1 and 0 are used. Thread number 1 is the thread the VM started with. On some OSes this thread has special priviliges. I.e. on macOS only thread 1 can make draw calls. Therefore it is mostly important whether a thread must run on thread 1, must **not** run on thread 1 or whether it doesn't care. If successful the VM will ensure that there is at least one compatible thread active." | aProcess affinity waitingPriority activePriority | <export: true> self cCode: [] inSmalltalk: [cogThreadManager isNil ifTrue: [^self primitiveFail]]. processHasThreadAffinity ifFalse: [^self primitiveFailFor: PrimErrUnsupported]. affinity := self stackTop. aProcess := self stackValue: 1. ((affinity = objectMemory nilObject or: [(objectMemory isIntegerObject: affinity) and: [affinity ~= (objectMemory integerObjectOf: 0)]]) and: [(objectMemory isPointers: aProcess) and: [(objectMemory slotSizeOf: aProcess) >= (ThreadIdIndex + 1)]]) ifFalse: [^self primitiveFailFor: PrimErrBadArgument]. affinity := affinity = objectMemory nilObject ifTrue: [0] ifFalse: [objectMemory integerValueOf: affinity]. affinity abs >= cogThreadManager maxNumThreads ifTrue: [^self primitiveFailFor: PrimErrLimitExceeded]. + (self bindProcess: aProcess toAffinity: affinity) ifNotNil: [:ec| ^self primitiveFailFor: ec]. self methodReturnReceiver. waitingPriority := self getMaxWaitingPriority. activePriority := self quickFetchInteger: PriorityIndex ofObject: aProcess. affinity := self threadAffinityOfProcess: aProcess. (aProcess = self activeProcess and: [(activeProcessAffined := affinity ~= 0) and: [(cogThreadManager vmOwnerIsCompatibleWith: affinity) not]]) ifTrue: [activePriority < waitingPriority ifTrue: [self reduceWaitingPriorityFrom: waitingPriority to: activePriority "TODO: Check if this is correct?"]. self threadSwitchIfNecessary: aProcess from: CSThreadBind]! Item was changed: ----- Method: CoInterpreterMT>>temporaryAffinityOfProcess: (in category 'process primitive support') ----- temporaryAffinityOfProcess: aProcess + <inline: false> "useful for debugging so don't inline" "Answer the threadId of the thread threadIdField is temporarily bound to, or 0 if none." ^ self temporaryAffinedThreadId: (self threadAffinityFieldOf: aProcess)! Item was changed: ----- Method: CoInterpreterMT>>threadAffinityOfProcess: (in category 'process primitive support') ----- threadAffinityOfProcess: aProcess + <inline: false> + "useful for debugging, so don't inline" ^self threadAffinityOfThreadID: (self threadAffinityFieldOf: aProcess)! Item was changed: ----- Method: CoInterpreterMT>>threadSwitchIfNecessary:from: (in category 'process primitive support') ----- threadSwitchIfNecessary: newProc from: sourceCode "Invoked from transferTo:from: or primitiveProcessBindToThreadId to switch threads if the new process is bound or affined to some other thread." + | newProcThreadAffinity vmThread activeContext threadSwitchNecessary | - | newProcThreadAffinity vmThread activeContext | self assert: (cogThreadManager vmOwnerIs: cogThreadManager ioGetThreadLocalThreadIndex). deferThreadSwitch ifTrue: [^self]. cogThreadManager assertValidProcessorStackPointersForIndex: cogThreadManager getVMOwner. "If the current process is unaffined or it is affined to the current thread we're ok to run, but we should yield asap if a higher-priority thread wants the VM." newProcThreadAffinity := self threadAffinityOfProcess: newProc. + threadSwitchNecessary := (activeProcessAffined := newProcThreadAffinity ~= 0) + and: [(cogThreadManager vmOwnerIsCompatibleWith: newProcThreadAffinity) not]. + threadSwitchNecessary ifFalse: - ((activeProcessAffined := newProcThreadAffinity ~= 0) - and: [(cogThreadManager vmOwnerIsCompatibleWith: newProcThreadAffinity) not]) ifFalse: [(self quickFetchInteger: PriorityIndex ofObject: newProc) < self getMaxWaitingPriority ifTrue: [checkThreadActivation := true. self forceInterruptCheck]. + "We're done, no thread switch necessary" ^self]. "The current process is affined to a thread, but not to the current owner. So switch to that owner." + self cCode: [] inSmalltalk: - self cCode: '' inSmalltalk: [transcript ensureCr; f: 'threadSwitchIfNecessary: %08x from: %s(%d) owner %d -> %d\n' printf: { newProc. TraceSources at: sourceCode. sourceCode. cogThreadManager getVMOwner. newProcThreadAffinity }]. + "If the activeProcess doesn't have a context yet, it needs one from which the new thread can resume execution." - "We at least need to externalize the stack pointers to enable a thread switch..." (objectMemory fetchPointer: SuspendedContextIndex ofObject: newProc) = objectMemory nilObject ifTrue: [self assert: newProc = self activeProcess. + "The instructionPointer is popped from the stack in 'externalSetStackPageAndPointersForSuspendedContextOfProcess:' " self push: instructionPointer. + "We at least need to externalize the stack pointers to enable a thread switch..." self externalWriteBackHeadFramePointers. + activeContext := self ensureFrameIsMarried: framePointer SP: stackPointer. + objectMemory storePointer: SuspendedContextIndex ofObject: newProc withValue: activeContext]. - false ifTrue: - "If the activeProcess doesn't have a context yet, it needs one from which the new thread can resume execution." - [activeContext := self ensureFrameIsMarried: framePointer SP: stackPointer. - objectMemory storePointer: SuspendedContextIndex ofObject: newProc withValue: activeContext]]. newProcThreadAffinity < 0 ifTrue: [self assert: newProcThreadAffinity negated = cogThreadManager getVMOwner. vmThread := cogThreadManager ensureWillingThread. self deny: vmThread index = cogThreadManager getVMOwner. self assert: (cogThreadManager threadIndex: vmThread index isCompatibleWith: newProcThreadAffinity)] ifFalse: [vmThread := cogThreadManager vmThreadAt: newProcThreadAffinity. vmThread priority: (self quickFetchInteger: PriorityIndex ofObject: newProc). vmThread vmThreadState = CTMUnavailable ifTrue: [vmThread setVmThreadState: CTMWantingOwnership]]. self returnToSchedulingLoopAndReleaseVMOrWakeThread: vmThread source: CSSwitchIfNeccessary! Item was changed: ----- Method: CoInterpreterMT>>transferTo:from: (in category 'process primitive support') ----- transferTo: newProc from: sourceCode "Record a process to be awoken on the next interpreter cycle. Override to potentially switch threads either if the new process is bound to another thread, or if there is no runnable process but there is a waiting thread. Note that the abort on no runnable process has beeen moved here from wakeHighestPriority." | sched oldProc activeContext | <inline: false> statProcessSwitch := statProcessSwitch + 1. self push: instructionPointer. self externalWriteBackHeadFramePointers. self assertValidExecutionPointe: instructionPointer r: framePointer s: stackPointer. "ensureMethodIsCogged: in makeBaseFrameFor: in externalSetStackPageAndPointersForSuspendedContextOfProcess: below may do a code compaction. Nil instructionPointer to avoid it getting pushed twice." instructionPointer := 0. sched := self schedulerPointer. oldProc := objectMemory fetchPointer: ActiveProcessIndex ofObject: sched. self recordContextSwitchFrom: oldProc in: sourceCode. activeContext := self ensureFrameIsMarried: framePointer SP: stackPointer + objectMemory wordSize. objectMemory storePointer: SuspendedContextIndex ofObject: oldProc withValue: activeContext. newProc ifNil: ["Two possibilities. One, there is at least one thread waiting to own the VM in which case it should be activated. Two, there are no processes to run and so abort. This is new in the MT VM, and only happens when the primitiveRelinquishProcessor has been preempted. In that case the idle Process is not runnable and there is no Process to return to. By setting the activeProcess to nilObject, any threads woken by the heartbeat don't actually start running Smalltalk. This is then fixed when an AWOL thread comes back and restores its previous state." objectMemory storePointer: ActiveProcessIndex ofObject: sched withValue: objectMemory nilObject. cogThreadManager willingVMThread ifNotNil: [:vmThread| vmThread vmThreadState = CTMWantingOwnership ifTrue: [self returnToSchedulingLoopAndReleaseVMOrWakeThread: vmThread source: sourceCode]]. "self error: 'scheduler could not find a runnable process'" + "relinquishing := true". + self returnToSchedulingLoopAndReleaseVMOrWakeThread: nil source: sourceCode]. - self returnToSchedulingLoopAndReleaseVMOrWakeThread: nil source: sourceCode]. "Switch to the new process" objectMemory storePointer: ActiveProcessIndex ofObject: sched withValue: newProc; storePointerUnchecked: MyListIndex ofObject: newProc withValue: objectMemory nilObject. self externalSetStackPageAndPointersForSuspendedContextOfProcess: newProc. "Finally thread switch if required" self threadSwitchIfNecessary: newProc from: sourceCode! Item was changed: ----- Method: CoInterpreterMT>>tryToExecuteSmalltalk: (in category 'vm scheduling') ----- tryToExecuteSmalltalk: vmThread "Attempt to run the current process, if it exists, on the given vmThread." <var: #vmThread type: #'CogVMThread *'> | activeProc threadAffinity | self assert: (cogThreadManager vmOwnerIs: vmThread index). self assert: cogThreadManager ioGetThreadLocalThreadIndex = vmThread index. disowningVMThread ifNil: [activeProc := self activeProcess] ifNotNil: [self preemptDisowningThread. activeProc := self wakeHighestPriority. activeProc ifNil: [activeProc := objectMemory nilObject] ifNotNil: [objectMemory storePointerUnchecked: MyListIndex ofObject: activeProc withValue: objectMemory nilObject]. objectMemory storePointer: ActiveProcessIndex ofObject: self schedulerPointer withValue: activeProc]. + "There is a special case here. + When the VM has relinquished, but then another thread finishes external code execution, there may no longer be a process to run. + However, the relinquishing flag may already have been reset by another thread that has owned the VM again." + activeProc = objectMemory nilObject + ifTrue: ["self warning: 'tryToExecuteSmalltalk: no active process!!'." + "relinquishing := true". + ^nil]. - activeProc = objectMemory nilObject ifTrue:[^nil]. threadAffinity := self threadAffinityOfProcess: activeProc. (cogThreadManager vmOwnerIsCompatibleWith: threadAffinity) ifTrue: [self assert: (objectMemory fetchPointer: MyListIndex ofObject: self activeProcess) = objectMemory nilObject. (objectMemory fetchPointer: SuspendedContextIndex ofObject: activeProc) ~= objectMemory nilObject ifTrue: [self externalSetStackPageAndPointersForSuspendedContextOfProcess: activeProc]. instructionPointer = cogit ceReturnToInterpreterPC ifTrue: [self deny: (self isMachineCodeFrame: framePointer). instructionPointer := self iframeSavedIP: framePointer]. self enterSmalltalkExecutive. "When we return here we should have already given up the VM and so we cannot touch any interpreter state." self error: 'NOTREACHED'.]. cogThreadManager returnToSchedulingLoopAndWakeThreadFor: threadAffinity source: CSTryToExecuteSmalltalk. "This is only reached if the above call has failed, then ownership has not been transferred and we still need to release the VM."!

2 1

VM Maker: VMMaker.threaded-LM.3354.mcz
by commits＠source.squeak.org 19 Mar '24

19 Mar '24

Leon Matthes uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.threaded-LM.3354.mcz ==================== Summary ==================== Name: VMMaker.threaded-LM.3354 Author: LM Time: 19 March 2024, 2:33:25.880875 pm UUID: 469cd714-e1fa-435c-ad9d-b577ee0536d2 Ancestors: VMMaker.threaded-LM.3353 Increase Owner Log to 1Mi entries. Some small additional adjustments =============== Diff against VMMaker.threaded-LM.3353 =============== Item was changed: ----- Method: CoInterpreterMT>>threadAffinityFieldValueOf: (in category 'process primitive support') ----- threadAffinityFieldValueOf: aProcess + <inline: false> "Should not be inlined, as it's useful for debugging." ^processHasThreadAffinity ifTrue: [| field | field := objectMemory fetchPointer: ThreadIdIndex ofObject: aProcess. field = objectMemory nilObject ifTrue: [0] ifFalse: [objectMemory integerValueOf: field]] ifFalse: [0]! Item was changed: ----- Method: CogThreadManager class>>initialize (in category 'class initialization') ----- initialize "CogThreadManager initialize" CTMUninitialized := 0. CTMInitializing := 1. CTMUnavailable := 2. "off doing its own thing and not available to run the VM, e.g. calling-out." CTMAssignableOrInVM := 3. "either owning the VM or blocked on its osSemaphore available for VM work" CTMWantingOwnership := 4. "with something specific to do in the VM (e.g. return a result from a call-out, make a call-back)" CTMUnknownOwner := -1. "Define the size of the stack of processes at time of disown/own." AWOLProcessesIncrement := 4. + OwnerLogSize := 1024 * 1024 "1M entries for logging owner switches".! - OwnerLogSize := 100 * 1024.! Item was changed: ----- Method: FilePlugin>>primitiveFileReadPinningAndDisowning (in category 'file primitives') ----- primitiveFileReadPinningAndDisowning "This version of primitiveFileRead is for garbage collectors that support pinning and the multi-threaded VM. It actually does the own/disown dance if the bytearray is pinned." | count startIndex array file slotSize elementSize bytesRead vmHandle | <inline: true> <var: 'file' type: #'SQFile *'> <var: 'count' type: #'size_t'> <var: 'startIndex' type: #'size_t'> <var: 'slotSize' type: #'size_t'> <var: 'elementSize' type: #'size_t'> count := interpreterProxy positiveMachineIntegerValueOf: (interpreterProxy stackValue: 0). startIndex := interpreterProxy positiveMachineIntegerValueOf: (interpreterProxy stackValue: 1). array := interpreterProxy stackValue: 2. file := self fileValueOf: (interpreterProxy stackValue: 3). vmHandle := nil. (interpreterProxy failed "buffer can be any indexable words or bytes object except CompiledMethod" or: [(interpreterProxy isWordsOrBytes: array) not]) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. slotSize := interpreterProxy slotSizeOf: array. (startIndex >= 1 and: [startIndex + count - 1 <= slotSize]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. - (interpreterProxy isPinned: array) ifTrue: - [vmHandle := interpreterProxy disownVM: DisownVMForThreading]. "Note: adjust startIndex for zero-origin byte indexing" elementSize := slotSize = 0 ifTrue: [1] ifFalse: [(interpreterProxy byteSizeOf: array) // slotSize]. + + (interpreterProxy isPinned: array) ifTrue: + [vmHandle := interpreterProxy disownVM: DisownVMForThreading]. bytesRead := self sqFile: file Read: count * elementSize Into: (interpreterProxy cCoerce: (interpreterProxy firstIndexableField: array) to: #'char *') At: startIndex - 1 * elementSize. vmHandle ifNotNil: [interpreterProxy ownVM: vmHandle]. interpreterProxy failed ifFalse: [interpreterProxy methodReturnInteger: bytesRead // elementSize] "answer # of elements read"! Item was changed: ----- Method: SpurMemoryManager>>printOopsFrom:to: (in category 'debug printing') ----- printOopsFrom: startAddress to: endAddress <public> "useful for VM debugging" | oop limit firstNonEntity inEmptySpace lastNonEntity | oop := self objectBefore: startAddress. limit := endAddress asUnsignedIntegerPtr min: endOfMemory. oop := oop ifNil: [startAddress] ifNotNil: [(self objectAfter: oop) = startAddress ifTrue: [startAddress] ifFalse: [oop]]. + inEmptySpace := false. - inEmptySpace := false. [self oop: oop isLessThan: limit] whileTrue: [self printEntity: oop. [oop := self objectAfter: oop. (self long64At: oop) = 0] whileTrue: [inEmptySpace ifFalse: [inEmptySpace := true. firstNonEntity := oop]. lastNonEntity := oop]. inEmptySpace ifTrue: [inEmptySpace := false. coInterpreter print: 'skipped empty space from '; printHexnp: firstNonEntity; print:' to '; printHexnp: lastNonEntity; cr. oop := self objectStartingAt: oop]]!

1 0

VM Maker: CogTools.threaded-LM.101.mcz
by commits＠source.squeak.org 19 Mar '24

19 Mar '24

Leon Matthes uploaded a new version of CogTools to project VM Maker: http://source.squeak.org/VMMaker/CogTools.threaded-LM.101.mcz ==================== Summary ==================== Name: CogTools.threaded-LM.101 Author: LM Time: 19 March 2024, 2:31:31.223119 pm UUID: 6c68a7e6-059f-46bf-93e0-a8b4facea625 Ancestors: CogTools.threaded-LM.100 Increase Owner Log Size =============== Diff against CogTools.threaded-LM.100 =============== Item was changed: ----- Method: ThreadInspector>>getOwnerLogFromVM (in category 'accessing') ----- getOwnerLogFromVM |bytes numElements bigEndian| + bytes := (ByteArray new: 3*8*1024*1024 "The log is currently 1Mi entries"). - bytes := (ByteArray new: 3*8*1024*100 "The log is currently 100Ki entries"). numElements := self primitiveGetOwnerLog: bytes. bigEndian := Smalltalk endianness = #big. self assert: Smalltalk wordSize = 8. "TODO: Decode 32-bit VM log" ^ (0 to: numElements - 1) collect: [:index | |bytesOffset| bytesOffset := index * 24. CogVMOwnerLog new timestamp: (bytes long64At: bytesOffset + 1 bigEndian: bigEndian); "+1 because Smalltalk is 1-indexed" vmOwner: (bytes long64At: bytesOffset + 9 bigEndian: bigEndian); successfulSwitch: (bytes long64At: bytesOffset + 17 bigEndian: bigEndian) ~= 0; yourself].!

1 0

[OpenSmalltalk/opensmalltalk-vm] ca5548: BMPReadWriterPlugin generated source per VMMaker-d...
by David T Lewis 18 Mar '24

18 Mar '24

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: ca5548dbdec6856e5ca0358f2ef1d636631bfbb1 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ca5548dbdec6856e5c… Author: David T Lewis <lewis(a)mail.msen.com> Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M src/plugins/BMPReadWriterPlugin/BMPReadWriterPlugin.c Log Message: ----------- BMPReadWriterPlugin generated source per VMMaker-dtl.442. Fix bug in BMPReadWriterPlugin that caused unnecessary primitive failures. Fix provided by Juan Vuletich, see https://lists.cuis.st/mailman/archives/cuis-dev/2024-March/008599.html To unsubscribe from these emails, change your notification settings at https://github.com/OpenSmalltalk/opensmalltalk-vm/settings/notifications

1 0

VM Maker: VMMaker.oscog-dtl.3352.mcz
by commits＠source.squeak.org 18 Mar '24

18 Mar '24

David T. Lewis uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-dtl.3352.mcz ==================== Summary ==================== Name: VMMaker.oscog-dtl.3352 Author: dtl Time: 18 March 2024, 1:47:49.34839 pm UUID: 3f1e452d-7dfd-4f60-9bc2-2d930e0a28eb Ancestors: VMMaker.oscog-eem.3351 Fix bug in BMPReadWriterPlugin that caused unnecessary primitive failures. Fix provided by Juan Vuletich https://lists.cuis.st/mailman/archives/cuis-dev/2024-March/008599.html =============== Diff against VMMaker.oscog-eem.3351 =============== Item was changed: ----- Method: BMPReadWriterPlugin>>primitiveRead24BmpLine (in category 'primitives') ----- primitiveRead24BmpLine | width formBitsIndex formBitsOop pixelLineOop formBitsSize formBits pixelLineSize pixelLine | <export: true> <inline: false> <var: #formBits type: 'unsigned int *'> <var: #pixelLine type: 'unsigned char *'> interpreterProxy methodArgumentCount = 4 ifFalse:[^interpreterProxy primitiveFail]. width := interpreterProxy stackIntegerValue: 0. width <= 0 ifTrue:[^interpreterProxy primitiveFail]. formBitsIndex := interpreterProxy stackIntegerValue: 1. formBitsOop := interpreterProxy stackObjectValue: 2. pixelLineOop := interpreterProxy stackObjectValue: 3. interpreterProxy failed ifTrue:[^nil]. (interpreterProxy isWords: formBitsOop) ifFalse:[^interpreterProxy primitiveFail]. (interpreterProxy isBytes: pixelLineOop) ifFalse:[^interpreterProxy primitiveFail]. formBitsSize := interpreterProxy slotSizeOf: formBitsOop. formBits := interpreterProxy firstIndexableField: formBitsOop. pixelLineSize := interpreterProxy slotSizeOf: pixelLineOop. pixelLine := interpreterProxy firstIndexableField: pixelLineOop. + (formBitsIndex + width - 1 <= formBitsSize and:[width*3 <= pixelLineSize]) - (formBitsIndex + width <= formBitsSize and:[width*3 <= pixelLineSize]) ifFalse:[^interpreterProxy primitiveFail]. "do the actual work" self cCode:' formBits += formBitsIndex-1; while(width--) { unsigned int rgb; rgb = (*pixelLine++); rgb += (*pixelLine++) << 8; rgb += (*pixelLine++) << 16; if(rgb) rgb |= 0xFF000000; else rgb |= 0xFF000001; *formBits++ = rgb; } ' inSmalltalk:[formBits. pixelLine. ^interpreterProxy primitiveFail]. interpreterProxy pop: 4. "args" ! Item was changed: ----- Method: BMPReadWriterPlugin>>primitiveWrite24BmpLine (in category 'primitives') ----- primitiveWrite24BmpLine | width formBitsIndex formBitsOop pixelLineOop formBitsSize formBits pixelLineSize pixelLine | <export: true> <inline: false> <var: #formBits type: 'unsigned int *'> <var: #pixelLine type: 'unsigned char *'> interpreterProxy methodArgumentCount = 4 ifFalse:[^interpreterProxy primitiveFail]. width := interpreterProxy stackIntegerValue: 0. width <= 0 ifTrue:[^interpreterProxy primitiveFail]. formBitsIndex := interpreterProxy stackIntegerValue: 1. formBitsOop := interpreterProxy stackObjectValue: 2. pixelLineOop := interpreterProxy stackObjectValue: 3. interpreterProxy failed ifTrue:[^nil]. (interpreterProxy isWords: formBitsOop) ifFalse:[^interpreterProxy primitiveFail]. (interpreterProxy isBytes: pixelLineOop) ifFalse:[^interpreterProxy primitiveFail]. formBitsSize := interpreterProxy slotSizeOf: formBitsOop. formBits := interpreterProxy firstIndexableField: formBitsOop. pixelLineSize := interpreterProxy slotSizeOf: pixelLineOop. pixelLine := interpreterProxy firstIndexableField: pixelLineOop. + (formBitsIndex + width - 1 <= formBitsSize and:[width*3 <= pixelLineSize]) - (formBitsIndex + width <= formBitsSize and:[width*3 <= pixelLineSize]) ifFalse:[^interpreterProxy primitiveFail]. "do the actual work. Read 32 bit at a time from formBits, and store the low order 24 bits or each word into pixelLine in little endian order." self cCode:' formBits += formBitsIndex-1; while(width--) { unsigned int rgb; rgb = *formBits++; (*pixelLine++) = (rgb ) & 0xFF; (*pixelLine++) = (rgb >> 8 ) & 0xFF; (*pixelLine++) = (rgb >> 16) & 0xFF; } ' inSmalltalk:[formBits. pixelLine. ^interpreterProxy primitiveFail]. interpreterProxy pop: 4. "args" !

1 0

VM Maker: VMMaker-dtl.442.mcz
by commits＠source.squeak.org 18 Mar '24

18 Mar '24

David T. Lewis uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker-dtl.442.mcz ==================== Summary ==================== Name: VMMaker-dtl.442 Author: dtl Time: 18 March 2024, 1:42:53.99 pm UUID: fa3530b4-3415-49e2-8448-53850dcd6005 Ancestors: VMMaker-dtl.441 VMMaker 4.20.8 - Fix bug in BMPReadWriterPlugin that caused unnecessary primitive failures. Fix provided by Juan Vuletich https://lists.cuis.st/mailman/archives/cuis-dev/2024-March/008599.html =============== Diff against VMMaker-dtl.441 =============== Item was changed: ----- Method: BMPReadWriterPlugin>>primitiveRead24BmpLine (in category 'primitives') ----- primitiveRead24BmpLine | width formBitsIndex formBitsOop pixelLineOop formBitsSize formBits pixelLineSize pixelLine | <export: true> <inline: false> <var: #formBits type: 'unsigned int *'> <var: #pixelLine type: 'unsigned char *'> interpreterProxy methodArgumentCount = 4 ifFalse:[^interpreterProxy primitiveFail]. width := interpreterProxy stackIntegerValue: 0. width <= 0 ifTrue:[^interpreterProxy primitiveFail]. formBitsIndex := interpreterProxy stackIntegerValue: 1. formBitsOop := interpreterProxy stackObjectValue: 2. pixelLineOop := interpreterProxy stackObjectValue: 3. interpreterProxy failed ifTrue:[^nil]. (interpreterProxy isWords: formBitsOop) ifFalse:[^interpreterProxy primitiveFail]. (interpreterProxy isBytes: pixelLineOop) ifFalse:[^interpreterProxy primitiveFail]. formBitsSize := interpreterProxy slotSizeOf: formBitsOop. formBits := interpreterProxy firstIndexableField: formBitsOop. pixelLineSize := interpreterProxy slotSizeOf: pixelLineOop. pixelLine := interpreterProxy firstIndexableField: pixelLineOop. + (formBitsIndex + width - 1 <= formBitsSize and:[width*3 <= pixelLineSize]) - (formBitsIndex + width <= formBitsSize and:[width*3 <= pixelLineSize]) ifFalse:[^interpreterProxy primitiveFail]. "do the actual work" self cCode:' formBits += formBitsIndex-1; while(width--) { unsigned int rgb; rgb = (*pixelLine++); rgb += (*pixelLine++) << 8; rgb += (*pixelLine++) << 16; if(rgb) rgb |= 0xFF000000; else rgb |= 0xFF000001; *formBits++ = rgb; } ' inSmalltalk:[formBits. pixelLine. ^interpreterProxy primitiveFail]. interpreterProxy pop: 4. "args" ! Item was changed: ----- Method: BMPReadWriterPlugin>>primitiveWrite24BmpLine (in category 'primitives') ----- primitiveWrite24BmpLine | width formBitsIndex formBitsOop pixelLineOop formBitsSize formBits pixelLineSize pixelLine | <export: true> <inline: false> <var: #formBits type: 'unsigned int *'> <var: #pixelLine type: 'unsigned char *'> interpreterProxy methodArgumentCount = 4 ifFalse:[^interpreterProxy primitiveFail]. width := interpreterProxy stackIntegerValue: 0. width <= 0 ifTrue:[^interpreterProxy primitiveFail]. formBitsIndex := interpreterProxy stackIntegerValue: 1. formBitsOop := interpreterProxy stackObjectValue: 2. pixelLineOop := interpreterProxy stackObjectValue: 3. interpreterProxy failed ifTrue:[^nil]. (interpreterProxy isWords: formBitsOop) ifFalse:[^interpreterProxy primitiveFail]. (interpreterProxy isBytes: pixelLineOop) ifFalse:[^interpreterProxy primitiveFail]. formBitsSize := interpreterProxy slotSizeOf: formBitsOop. formBits := interpreterProxy firstIndexableField: formBitsOop. pixelLineSize := interpreterProxy slotSizeOf: pixelLineOop. pixelLine := interpreterProxy firstIndexableField: pixelLineOop. + (formBitsIndex + width - 1 <= formBitsSize and:[width*3 <= pixelLineSize]) - (formBitsIndex + width <= formBitsSize and:[width*3 <= pixelLineSize]) ifFalse:[^interpreterProxy primitiveFail]. "do the actual work. Read 32 bit at a time from formBits, and store the low order 24 bits or each word into pixelLine in little endian order." self cCode:' formBits += formBitsIndex-1; while(width--) { unsigned int rgb; rgb = *formBits++; (*pixelLine++) = (rgb ) & 0xFF; (*pixelLine++) = (rgb >> 8 ) & 0xFF; (*pixelLine++) = (rgb >> 16) & 0xFF; } ' inSmalltalk:[formBits. pixelLine. ^interpreterProxy primitiveFail]. interpreterProxy pop: 4. "args" ! Item was changed: ----- Method: VMMaker class>>versionString (in category 'version testing') ----- versionString "VMMaker versionString" + ^'4.20.8'! - ^'4.20.7'!

1 0

VM Maker: CogTools.threaded-LM.100.mcz
by commits＠source.squeak.org 14 Mar '24

14 Mar '24

Leon Matthes uploaded a new version of CogTools to project VM Maker: http://source.squeak.org/VMMaker/CogTools.threaded-LM.100.mcz ==================== Summary ==================== Name: CogTools.threaded-LM.100 Author: LM Time: 14 March 2024, 6:53:15.21034 pm UUID: 7f0734a1-9058-46e4-98db-d453ff3a2cd0 Ancestors: CogTools.threaded-LM.99 ThreadInspector: use stepped horizontal owner line =============== Diff against CogTools.threaded-LM.99 =============== Item was changed: ----- Method: PlotSeries>>drawOn: (in category 'drawing') ----- drawOn: aCanvas points isEmpty ifTrue: [^ self]. "" drawArea ifTrue: ["" type == #straightened ifTrue: [self drawStraightenedAreaOn: aCanvas]. type == #stepped + ifTrue: [self drawSteppedAreaOn: aCanvas]]. - ifTrue: [self drawSteppedAreaOn: aCanvas]. - type == #steppedHorizontal - ifTrue: [self drawSteppedHorizontalLineOn: aCanvas]]. drawLine ifTrue: ["" type == #straightened ifTrue: [self drawStraightenedLineOn: aCanvas]. type == #stepped + ifTrue: [self drawSteppedLineOn: aCanvas]. + type == #steppedHorizontal + ifTrue: [self drawSteppedHorizontalLineOn: aCanvas]]. - ifTrue: [self drawSteppedLineOn: aCanvas]]. drawPoints ifTrue: [self drawPointsOn: aCanvas]! Item was changed: ----- Method: PlotSeries>>drawSteppedHorizontalLineOn: (in category 'drawing') ----- drawSteppedHorizontalLineOn: aCanvas | lineColor lastScaledPoint | lineColor := self lineColor. lastScaledPoint := nil. points do: [:point | | scaledPoint | scaledPoint := point scaledPoint. lastScaledPoint ifNotNil: [aCanvas line: lastScaledPoint to: scaledPoint x @ lastScaledPoint y width: width color: lineColor.]. lastScaledPoint := scaledPoint]!

1 0

[OpenSmalltalk/opensmalltalk-vm] mmap() sqUnixSpurMemory patch (Issue #665)
by David Stes 03 Mar '24

03 Mar '24

Hi, I have sent in the past email to Eliot Miranda about an issue which I discovered in August 2021 (two years ago), and I thought to raise an issue here. It is a Linux/UNIX patch issue with the behavior of the mmap() system call or library call as used by the OpenSmalltalk COG vm. When way back in 2021 some changes were made for Linux ARM8 to the file saUnixSpurMemory.c I reported that this was breaking the Solaris 11.3 build. Curiously the Solaris 11.4 build was still working fine. I think (I don't know) that perhaps the behavior of mmap() on Solaris 11.4 is slightly diferent than on 11.3, to match (perhaps) the Linux kernel behavior of mmap(). An idea that I have is to ask some UNIX guru's whether there exist a autoconf-archive (configure script) test or script to test the behavior of mmap() for portability. However here I will just report what the issue is : since august 2021 I am building succesfully on Solaris with the following patch ``` --- opensmalltalk-vm-sun-v5.0.34/platforms/unix/vm/sqUnixSpurMemory.c Fri Aug 13 19:54:42 2021 +++ p0/opensmalltalk-vm-sun-v5.0.34/platforms/unix/vm/sqUnixSpurMemory.c Sun Aug 15 14:11:58 2021 @@ -277,16 +277,21 @@ { void *hint = sbrk(0); // a hint of the lowest possible address for mmap void *result; + char *address; + unsigned long alignment; pageSize = getpagesize(); pageMask = ~(pageSize - 1); + alignment = max(pageSize,1024*1024); + address = (char *)(((usqInt)hint + alignment - 1) & ~(alignment - 1)); + #if !defined(MAP_JIT) # define MAP_JIT 0 #endif *desiredSize = roundUpToPage(*desiredSize); - result = mmap(hint, *desiredSize, + result = mmap(address, *desiredSize, #if DUAL_MAPPED_CODE_ZONE PROT_READ | PROT_EXEC, #else ``` I really need Eliot's help on this. Eliot : what I did was try to understand your code and you seem to make some alignment calculations on the desired memory location that you request through mmap(). I believe that the traditional UNIX mmap() or the Solaris 10 and Solaris 11.3 mmap() is reacting slightly differently to the requested memory "hint". By some experimentatoin and debugging I found the above patch, which I wrote based on looking at your code and try to mirror the calculations that you are doing, which are not fully symmetric. By copying some code, I discovered that with the above patch the build for both Solaris 11.3 and Solaris 11.4 are working fine again. I think this is a general UNIX issue that could be of interest to all UNIX software. If an autoconfigure autoconf-archive test would exist to test the behavior of mmap() then that could be dealt in all software that uses mmap() with anonymous memory mapping. As far as I know the history of the mmap() call is that it originated in the world of Sun and Solaris and is since a very long time present in Linux as well, and I think some improvements in Linux where then backported to Solaris 11.4. That would explain why the current OpenSmalltalk-VM code works fine on Solaris 11.4. For reasons of portability to all flavors of UNIX and Linux, I think a configure build test for the code could benefit portability of your Cog VM. Let us know please what you think. I could simply submit my patch as a patch to mainstream upstream OpenSmalltalk but I don't know your opinion about it. And the way I have been using it as a platform specific patch (that I apply prior to the build on Solaris) is fine for me as well. Regards, David Stes -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/665 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/issues/665(a)github.com>

4 19

[OpenSmalltalk/opensmalltalk-vm] 558dd5: [unix] harmonize i/o device name variable names
by Tobias Pape 02 Mar '24

02 Mar '24

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 558dd51ac385e7f6299b4c53f5549d5737cb4d9e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/558dd51ac385e7f629… Author: Tobias Pape <tobias(a)netshed.de> Date: 2024-03-02 (Sat, 02 Mar 2024) Changed paths: M platforms/unix/vm-sound-ALSA/sqUnixSoundALSA.c M platforms/unix/vm-sound-OSS/sqUnixSoundOSS.c Log Message: ----------- [unix] harmonize i/o device name variable names also avoids clash with BSD stdlib To unsubscribe from these emails, change your notification settings at https://github.com/OpenSmalltalk/opensmalltalk-vm/settings/notifications

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev March 2024