Status: Accepted Owner: siguc...@gmail.com Labels: Type-Defect Priority-Medium
New issue 131 by siguc...@gmail.com: Bug in Freetype plugin primitive http://code.google.com/p/cog/issues/detail?id=131
primitiveLoadOutlineSizesFrom: aFace
uses non-existing ivar for reading flags:
interpreterProxy storeInteger: FT2OutlineFlagsIndex ofObject: rcvr withValue: (self cCode: 'gs->outline.flags' inSmalltalk: [gs]).
(FT2OutlineFlagsIndex is nil) , causing overriding number of contours (null=0=FT2OutlineContoursSizeIndex).. which later causing VM crash when invoking primitiveLoadOutlineArraysFrom: because of attempt to read outside of array range.
The fix is to remove the above code. (i wanted to attach file here, but quota exceeded)
Comment #1 on issue 131 by guillermopolito@gmail.com: Bug in Freetype plugin primitive http://code.google.com/p/cog/issues/detail?id=131
Mirrored in https://pharo.fogbugz.com/default.asp?11388#82909
Updates: Status: Done
Comment #2 on issue 131 by siguc...@gmail.com: Bug in Freetype plugin primitive http://code.google.com/p/cog/issues/detail?id=131
fixed in Freetype-Plugin-IgorStasenko.64 (http://www.squeaksource.com/FreetypePlugin)
Comment #3 on issue 131 by nicolas....@gmail.com: Bug in Freetype plugin primitive http://code.google.com/p/cog/issues/detail?id=131
This is a bug in Pharo only, because Pharo removed the flags inst. var. Probably because the inst. var. was unused.
In Squeak, the inst. var. still exists, and thus this is not a bug. Though, what is the purpose of these flags exactly?
On Fri, Nov 1, 2013 at 7:24 AM, cog@googlecode.com wrote:
Comment #3 on issue 131 by nicolas....@gmail.com: Bug in Freetype plugin primitive http://code.google.com/p/cog/**issues/detail?id=131http://code.google.com/p/cog/issues/detail?id=131
This is a bug in Pharo only, because Pharo removed the flags inst. var. Probably because the inst. var. was unused.
In Squeak, the inst. var. still exists, and thus this is not a bug. Though, what is the purpose of these flags exactly?
I don't know. But clearly the inst var is used, but by the VM. Pharo doesn't need to remove the inst var does it?
-- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/**hosting/settingshttps://code.google.com/hosting/settings
On 1 November 2013 19:09, Eliot Miranda eliot.miranda@gmail.com wrote:
On Fri, Nov 1, 2013 at 7:24 AM, cog@googlecode.com wrote:
Comment #3 on issue 131 by nicolas....@gmail.com: Bug in Freetype plugin primitive http://code.google.com/p/cog/**issues/detail?id=131http://code.google.com/p/cog/issues/detail?id=131
This is a bug in Pharo only, because Pharo removed the flags inst. var. Probably because the inst. var. was unused.
In Squeak, the inst. var. still exists, and thus this is not a bug. Though, what is the purpose of these flags exactly?
I don't know. But clearly the inst var is used, but by the VM. Pharo doesn't need to remove the inst var does it?
i don't know how Freetype in Pharo end up not using that ivar. i don't remember anyone did any functional changes to FreeType code in Pharo. Which means, this was some leftovers, which was there from the beginning.
-- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/**hosting/settingshttps://code.google.com/hosting/settings
-- best, Eliot
My guess is that applying CodeCritique blindly had some form of colateral effect... Look in http://www.squeaksource.com/Pharo and http://code.google.com/p/pharo/issues/detail?id=4139
Name: FreeType-StephaneDucasse.546 Author: StephaneDucasse Time: 1 May 2011, 7:31 pm UUID: dd92dfb5-4aa1-4891-be40-063e97818fb0 Ancestors: FreeType-MarcusDenker.545
- Issue 4138: AnnouncementSpy rewritten without ToolBuilder. - Issue 4141: Cleaned a bit ChangeSorter - Issue 4139: Small CodeCritique cleanup. - Issue 4134: Package SUnitGUI is dirty and almost empty. - Issue 4137: Move more methods to Compatibility Package.
2013/11/2 Igor Stasenko siguctua@gmail.com
On 1 November 2013 19:09, Eliot Miranda eliot.miranda@gmail.com wrote:
On Fri, Nov 1, 2013 at 7:24 AM, cog@googlecode.com wrote:
Comment #3 on issue 131 by nicolas....@gmail.com: Bug in Freetype plugin primitive http://code.google.com/p/cog/issues/detail?id=131
This is a bug in Pharo only, because Pharo removed the flags inst. var. Probably because the inst. var. was unused.
In Squeak, the inst. var. still exists, and thus this is not a bug. Though, what is the purpose of these flags exactly?
I don't know. But clearly the inst var is used, but by the VM. Pharo doesn't need to remove the inst var does it?
i don't know how Freetype in Pharo end up not using that ivar. i don't remember anyone did any functional changes to FreeType code in Pharo. Which means, this was some leftovers, which was there from the beginning.
-- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings
-- best, Eliot
-- Best regards, Igor Stasenko.
vm-dev@lists.squeakfoundation.org
-
cog＠googlecode.com -
Eliot Miranda -
Igor Stasenko -
Nicolas Cellier