VM built and run on same processor in Linux
===================================== Riscv64 squeak.stack.spur - BaseImageTests 1936 run 1934 Passed, 2 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul ProcessorTest>>testGrabProcessor
===================================== Aarch64 squeak.stack.spur 1936 run 1934 Passed, 1 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul
===================================== Aarch64 squeak.cog.spur 1936 run 1934 Passed, 1 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul
=====================================
Hmm... I thought we fixed an issue with alphaRgbMul ... does the test check the wrong behavior? Or did we have a regression here? Nicolas? 😅
________________________________ From: ken.dickey@whidbey.com ken.dickey@whidbey.com Sent: Wednesday, November 22, 2023 9:33:25 PM To: Squeak Machine Development Discussion vm-dev@lists.squeakfoundation.org Subject: [Vm-dev] Cuis Basic Image Tests on VM Candidate build 5.0-202311211431
VM built and run on same processor in Linux
===================================== Riscv64 squeak.stack.spur - BaseImageTests 1936 run 1934 Passed, 2 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul ProcessorTest>>testGrabProcessor
===================================== Aarch64 squeak.stack.spur 1936 run 1934 Passed, 1 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul
===================================== Aarch64 squeak.cog.spur 1936 run 1934 Passed, 1 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul
=====================================
Where can I find those tests?
Am 23.11.2023 07:53:55 schrieb Taeumel, Marcel marcel.taeumel@hpi.de:
Hmm... I thought we fixed an issue with alphaRgbMul ... does the test check the wrong behavior? Or did we have a regression here? Nicolas? 😅
________________________________ From: ken.dickey@whidbey.com ken.dickey@whidbey.com Sent: Wednesday, November 22, 2023 9:33:25 PM To: Squeak Machine Development Discussion vm-dev@lists.squeakfoundation.org Subject: [Vm-dev] Cuis Basic Image Tests on VM Candidate build 5.0-202311211431
VM built and run on same processor in Linux
===================================== Riscv64 squeak.stack.spur - BaseImageTests 1936 run 1934 Passed, 2 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul ProcessorTest>>testGrabProcessor
===================================== Aarch64 squeak.stack.spur 1936 run 1934 Passed, 1 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul
===================================== Aarch64 squeak.cog.spur 1936 run 1934 Passed, 1 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul
=====================================
Hi Ken --
Yes, we did a minor adaptation to #testAllAlphasRgbMul. It will then work with both OSVM 2022.06 and the RC 202311211431.
Find the change attached.
Best, Marcel
Am 22.11.2023 21:33:45 schrieb ken.dickey@whidbey.com ken.dickey@whidbey.com:
VM built and run on same processor in Linux
===================================== Riscv64 squeak.stack.spur - BaseImageTests 1936 run 1934 Passed, 2 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul ProcessorTest>>testGrabProcessor
===================================== Aarch64 squeak.stack.spur 1936 run 1934 Passed, 1 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul
===================================== Aarch64 squeak.cog.spur 1936 run 1934 Passed, 1 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul
=====================================
My bad. I mixed up the method versions. No, there is no single version of #testAllAlphasRgbMul that works with both OSVM 2202.06 and RC 202311211431.
Hmm....
Best, Marcel
Am 23.11.2023 11:50:53 schrieb Marcel marcel.taeumel@hpi.uni-potsdam.de:
Hi Ken --
Yes, we did a minor adaptation to #testAllAlphasRgbMul. It will then work with both OSVM 2022.06 and the RC 202311211431.
Find the change attached.
Best, Marcel
Am 22.11.2023 21:33:45 schrieb ken.dickey@whidbey.com ken.dickey@whidbey.com:
VM built and run on same processor in Linux
===================================== Riscv64 squeak.stack.spur - BaseImageTests 1936 run 1934 Passed, 2 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul ProcessorTest>>testGrabProcessor
===================================== Aarch64 squeak.stack.spur 1936 run 1934 Passed, 1 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul
===================================== Aarch64 squeak.cog.spur 1936 run 1934 Passed, 1 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul
=====================================
Hi Marcel,
I think the test is being too strict. Any reasonable rounding criteria should be accepted. I just modified the Cuis test to read:
computedValue := (blt destForm bits at: 1) digitAt: 4. theoreticalValue := destAlpha * sourceAlpha / 255.0. correctAlphas := correctAlphas + ((computedValue - theoreticalValue) abs < 1.0 ifTrue: [ 1 ] ifFalse: [ 0 ]) ]].
This way the test asses with both VMs, and I think it is perfectly fine.
Thanks,
On 11/23/2023 9:31 AM, Taeumel, Marcel wrote:
My bad. I mixed up the method versions. No, there is no single version of #testAllAlphasRgbMul that works with both OSVM 2202.06 and RC 202311211431.
Hmm....
Best, Marcel
Am 23.11.2023 11:50:53 schrieb Marcel marcel.taeumel@hpi.uni-potsdam.de:
Hi Ken --
Yes, we did a minor adaptation to #testAllAlphasRgbMul. It will then work with both OSVM 2022.06 and the RC 202311211431.
Find the change attached.
Best, Marcel
Am 22.11.2023 21:33:45 schrieb ken.dickey@whidbey.com ken.dickey@whidbey.com:
VM built and run on same processor in Linux
===================================== Riscv64 squeak.stack.spur - BaseImageTests 1936 run 1934 Passed, 2 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul ProcessorTest>>testGrabProcessor
===================================== Aarch64 squeak.stack.spur 1936 run 1934 Passed, 1 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul
===================================== Aarch64 squeak.cog.spur 1936 run 1934 Passed, 1 failed, 0 errors
BitBltTest>>#testAllAlphasRgbMul
=====================================
vm-dev@lists.squeakfoundation.org
-
Juan Vuletich -
ken.dickey＠whidbey.com -
Taeumel, Marcel