This week I was able to triangulate when the fullscreen bug on OS-X was introduced, but I was not able to verify whether Pablo’s proposed fix resolved the problem for me as I don’t have a local VM build set up (and that would be a customized one anyway) and I don’t know where PR builds are kept
Stephan
Hi Stephan, Deployment is disabled for PR builds and feature branches. I admit this would've been useful for you in this particular case, but I think it's reasonable to only build bleeding edge VMs from dev.
Fabio
On Sat, 23 Mar 2019 at 10:59 am, Stephan Eggermont stephan@stack.nl wrote:
This week I was able to triangulate when the fullscreen bug on OS-X was introduced, but I was not able to verify whether Pablo’s proposed fix resolved the problem for me as I don’t have a local VM build set up (and that would be a customized one anyway) and I don’t know where PR builds are kept
Stephan
Fabio Niephaus lists@fniephaus.com wrote:
Hi Stephan, Deployment is disabled for PR builds and feature branches. I admit this would've been useful for you in this particular case, but I think it's reasonable to only build bleeding edge VMs from dev.
Why? Keeping them long doesn’t make sense, I agree, but just keeping what was build the last few days would solve this
Stephan
On Sat, Mar 23, 2019 at 11:44 AM Stephan Eggermont stephan@stack.nl wrote:
Fabio Niephaus lists@fniephaus.com wrote:
Hi Stephan, Deployment is disabled for PR builds and feature branches. I admit this would've been useful for you in this particular case, but I think it's reasonable to only build bleeding edge VMs from dev.
Why? Keeping them long doesn’t make sense, I agree, but just keeping what was build the last few days would solve this
Stephan
For feature branches, we could enable deployments. But so far, there was no need for it. Deploying pull request is quite dangerous actually. Someone could steal our deployment certificates, API keys etc. by simply opening a PR against our code base.
Fabio
vm-dev@lists.squeakfoundation.org