Hi,
using the sources from svn, the 'make install' step fails:
gcc -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -Wall -Werror -DHAVE_CONFIG_H -I/tmp/squeak-svn/bld -I/tmp/squeak-svn/platforms/unix/vm -I/tmp/squeak-svn/platforms/Cross/vm -I/tmp/squeak-svn/platforms/unix/src/vm -I/tmp/squeak-svn/bld -I/tmp/squeak-svn/platforms/unix/vm -I/tmp/squeak-svn/platforms/Cross/vm -I/tmp/squeak-svn/platforms/unix/src/vm -I/tmp/squeak-svn/platforms/Cross/plugins/FilePlugin -I/tmp/squeak-svn/platforms/Cross/plugins/B3DAcceleratorPlugin -I/tmp/squeak-svn/platforms/unix/plugins/B3DAcceleratorPlugin -c /tmp/squeak-svn/platforms/unix/vm-display-fbdev/sqUnixFBDev.c -fPIC -DPIC -DPIC -o sqUnixFBDev.o cc1: warnings being treated as errors /tmp/squeak-svn/platforms/unix/vm/sqUnixEvent.c:219: warning: 'recordWindowEvent' defined but not used make[1]: *** [sqUnixFBDev.lo] Erreur 1 make: *** [vm-display-fbdev.la] Erreur 2
El mié, 10-10-2007 a las 17:44 +0200, Damien Cassou escribió:
Hi,
using the sources from svn, the 'make install' step fails:
gcc -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -Wall -Werror -DHAVE_CONFIG_H -I/tmp/squeak-svn/bld -I/tmp/squeak-svn/platforms/unix/vm -I/tmp/squeak-svn/platforms/Cross/vm -I/tmp/squeak-svn/platforms/unix/src/vm -I/tmp/squeak-svn/bld -I/tmp/squeak-svn/platforms/unix/vm -I/tmp/squeak-svn/platforms/Cross/vm -I/tmp/squeak-svn/platforms/unix/src/vm -I/tmp/squeak-svn/platforms/Cross/plugins/FilePlugin -I/tmp/squeak-svn/platforms/Cross/plugins/B3DAcceleratorPlugin -I/tmp/squeak-svn/platforms/unix/plugins/B3DAcceleratorPlugin -c /tmp/squeak-svn/platforms/unix/vm-display-fbdev/sqUnixFBDev.c -fPIC -DPIC -DPIC -o sqUnixFBDev.o cc1: warnings being treated as errors /tmp/squeak-svn/platforms/unix/vm/sqUnixEvent.c:219: warning: 'recordWindowEvent' defined but not used make[1]: *** [sqUnixFBDev.lo] Erreur 1 make: *** [vm-display-fbdev.la] Erreur 2
I had the same problem some time ago, just go to the file: platforms/unix/vm-display-fbdev/Makefile.in and change the line: XCFLAGS = $(X_CFLAGS) -Wall -Werror by XCFLAGS = $(X_CFLAGS) -Wall
Regards. José L
Ok, it works (after another configure/make/make install).
However, this is a workaround. Can somebody corrects the repository please?
2007/10/10, José L. Redrejo Rodríguez jredrejo@edu.juntaextremadura.net:
El mié, 10-10-2007 a las 17:44 +0200, Damien Cassou escribió:
Hi,
using the sources from svn, the 'make install' step fails:
gcc -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -Wall -Werror -DHAVE_CONFIG_H -I/tmp/squeak-svn/bld -I/tmp/squeak-svn/platforms/unix/vm -I/tmp/squeak-svn/platforms/Cross/vm -I/tmp/squeak-svn/platforms/unix/src/vm -I/tmp/squeak-svn/bld -I/tmp/squeak-svn/platforms/unix/vm -I/tmp/squeak-svn/platforms/Cross/vm -I/tmp/squeak-svn/platforms/unix/src/vm -I/tmp/squeak-svn/platforms/Cross/plugins/FilePlugin -I/tmp/squeak-svn/platforms/Cross/plugins/B3DAcceleratorPlugin -I/tmp/squeak-svn/platforms/unix/plugins/B3DAcceleratorPlugin -c /tmp/squeak-svn/platforms/unix/vm-display-fbdev/sqUnixFBDev.c -fPIC -DPIC -DPIC -o sqUnixFBDev.o cc1: warnings being treated as errors /tmp/squeak-svn/platforms/unix/vm/sqUnixEvent.c:219: warning: 'recordWindowEvent' defined but not used make[1]: *** [sqUnixFBDev.lo] Erreur 1 make: *** [vm-display-fbdev.la] Erreur 2
I had the same problem some time ago, just go to the file: platforms/unix/vm-display-fbdev/Makefile.in and change the line: XCFLAGS = $(X_CFLAGS) -Wall -Werror by XCFLAGS = $(X_CFLAGS) -Wall
Regards. José L
On Oct 10, 2007, at 18:06 , José L. Redrejo Rodríguez wrote:
El mié, 10-10-2007 a las 17:44 +0200, Damien Cassou escribió:
Hi,
using the sources from svn, the 'make install' step fails:
gcc -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -Wall -Werror -DHAVE_CONFIG_H -I/tmp/squeak-svn/bld -I/tmp/squeak-svn/platforms/unix/vm -I/tmp/squeak-svn/platforms/Cross/vm -I/tmp/squeak-svn/platforms/unix/src/vm -I/tmp/squeak-svn/bld -I/tmp/squeak-svn/platforms/unix/vm -I/tmp/squeak-svn/platforms/Cross/vm -I/tmp/squeak-svn/platforms/unix/src/vm -I/tmp/squeak-svn/platforms/Cross/plugins/FilePlugin -I/tmp/squeak-svn/platforms/Cross/plugins/B3DAcceleratorPlugin -I/tmp/squeak-svn/platforms/unix/plugins/B3DAcceleratorPlugin -c /tmp/squeak-svn/platforms/unix/vm-display-fbdev/sqUnixFBDev.c -fPIC -DPIC -DPIC -o sqUnixFBDev.o cc1: warnings being treated as errors /tmp/squeak-svn/platforms/unix/vm/sqUnixEvent.c:219: warning: 'recordWindowEvent' defined but not used make[1]: *** [sqUnixFBDev.lo] Erreur 1 make: *** [vm-display-fbdev.la] Erreur 2
I had the same problem some time ago, just go to the file: platforms/unix/vm-display-fbdev/Makefile.in and change the line: XCFLAGS = $(X_CFLAGS) -Wall -Werror by XCFLAGS = $(X_CFLAGS) -Wall
I did put a "if (0) recordWindowEvent(0,0,0,0)" in there ...
- Bert -
On 10/10/07, Bert Freudenberg bert@freudenbergs.de wrote:
On Oct 10, 2007, at 18:06 , José L. Redrejo Rodríguez wrote:
El mié, 10-10-2007 a las 17:44 +0200, Damien Cassou escribió:
Hi,
using the sources from svn, the 'make install' step fails:
gcc -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -Wall -Werror -DHAVE_CONFIG_H -I/tmp/squeak-svn/bld -I/tmp/squeak-svn/platforms/unix/vm -I/tmp/squeak-svn/platforms/Cross/vm -I/tmp/squeak-svn/platforms/unix/src/vm -I/tmp/squeak-svn/bld -I/tmp/squeak-svn/platforms/unix/vm -I/tmp/squeak-svn/platforms/Cross/vm -I/tmp/squeak-svn/platforms/unix/src/vm -I/tmp/squeak-svn/platforms/Cross/plugins/FilePlugin -I/tmp/squeak-svn/platforms/Cross/plugins/B3DAcceleratorPlugin -I/tmp/squeak-svn/platforms/unix/plugins/B3DAcceleratorPlugin -c /tmp/squeak-svn/platforms/unix/vm-display-fbdev/sqUnixFBDev.c -fPIC -DPIC -DPIC -o sqUnixFBDev.o cc1: warnings being treated as errors /tmp/squeak-svn/platforms/unix/vm/sqUnixEvent.c:219: warning: 'recordWindowEvent' defined but not used make[1]: *** [sqUnixFBDev.lo] Erreur 1 make: *** [vm-display-fbdev.la] Erreur 2
This raises the question: shouldn't we take warnings more seriously?
I think that it's perfectly reasonable to have -Werror in SVN, and just leave it off in the release tarballs. If you're building from SVN, you should be smart enough to fix any warnings that appear on your platform, or turn off the switch. People who can't do that should perhaps limit themselves to the "safer" release tarballs.
Warnings are there for a reason; let's not kill the messenger.
Andrew
Am Wednesday 10 October 2007 schrieb Damien Cassou:
Hi,
using the sources from svn, the 'make install' step fails:
gcc -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -Wall -Werror -DHAVE_CONFIG_H -I/tmp/squeak-svn/bld -I/tmp/squeak-svn/platforms/unix/vm -I/tmp/squeak-svn/platforms/Cross/vm -I/tmp/squeak-svn/platforms/unix/src/vm -I/tmp/squeak-svn/bld -I/tmp/squeak-svn/platforms/unix/vm -I/tmp/squeak-svn/platforms/Cross/vm -I/tmp/squeak-svn/platforms/unix/src/vm -I/tmp/squeak-svn/platforms/Cross/plugins/FilePlugin -I/tmp/squeak-svn/platforms/Cross/plugins/B3DAcceleratorPlugin -I/tmp/squeak-svn/platforms/unix/plugins/B3DAcceleratorPlugin -c /tmp/squeak-svn/platforms/unix/vm-display-fbdev/sqUnixFBDev.c -fPIC -DPIC -DPIC -o sqUnixFBDev.o cc1: warnings being treated as errors /tmp/squeak-svn/platforms/unix/vm/sqUnixEvent.c:219: warning: 'recordWindowEvent' defined but not used make[1]: *** [sqUnixFBDev.lo] Erreur 1 make: *** [vm-display-fbdev.la] Erreur 2
I knew there was something I wanted to report here. I encountered the same problem some days ago. I solved this by removing the -Werror flag from the makefile.in in vm-display-fbdev. I guess it's really safe to do that. And the other device makefiles don't have that anyway.
I will make a proper mantis bug report for this.
Martin
vm-dev@lists.squeakfoundation.org