Hi Ronie,

What is your procedure for building with MSVC ? I'd like to have a go at it.

cheers -ben

On Sat, 1 Dec 2018 at 07:20, Ronie Salgado notifications@github.com wrote:

Quick fixup of the minheadless VM for windows using the CMake building scripts. The VM builds and works with Cygwin for 32 bits. It builds with MSVC, but fails with several errors on runtime.

---

You can view, comment on, or merge this pull request online at:

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311 Commit Summary

• Fix the build of the minheadless VM for Pharo in Win32.

File Changes

• *M* CMakeLists.txt

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-0 (23)

• *M* build.minheadless.cmake/x64/common/configure_variant.sh

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-1 (1)

• *M* cmake/Plugins.cmake

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-2 (9)

• *M* cmake/PluginsPharo.cmake

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-3 (19)

• *M* platforms/Cross/plugins/IA32ABI/ia32abicc.c

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-4 (4)

• *M* platforms/Cross/plugins/IA32ABI/x64win64abicc.c

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-5 (8)

• *M* platforms/Cross/plugins/IA32ABI/xabicc.c

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-6 (6)

• *M* platforms/Cross/plugins/Mpeg3Plugin/libmpeg/changesForSqueak.c

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-7 (3)

• *M* platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3private.h

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-8 (3)

• *M* platforms/minheadless/windows/sqPlatformSpecific-Win32.c

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-9 (123)

• *M* platforms/minheadless/windows/sqWin32Directory.c

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-10 (269)

• *A* platforms/minheadless/windows/sqWin32Stubs.c

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-11 (19)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311, or mute the thread https://github.com/notifications/unsubscribe-auth/ABolJ8jAUbhxA8NQPK4dTjyPdyEuzmS1ks5u0b00gaJpZM4Y8jIn .