[OpenSmalltalk/opensmalltalk-vm] af9b52: Fix a comment typo in sqImageFileAccessViaStdio.h.
Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: af9b525662b27e8cb19983f7f6f40561b17fcc4f https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/af9b525662b27e8cb19... Author: Eliot Miranda eliot.miranda@gmail.com Date: 2022-10-08 (Sat, 08 Oct 2022)
Changed paths: M platforms/Cross/vm/sqImageFileAccessViaStdio.h M platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c
Log Message: ----------- Fix a comment typo in sqImageFileAccessViaStdio.h. Fix some formatting in sqWin32FilePrims.c; if( is bad; if is a keyword, not a function. char* foo is bad; the type of bar in "char* foo, bar;" is char. This is why in K&R the asterisk is always associated with the variable, not the base type. Returns should be om their own line for breakpointing when debugging.
On 8. Oct 2022, at 21:55, Eliot Miranda noreply@github.com wrote:
Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: af9b525662b27e8cb19983f7f6f40561b17fcc4f https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/af9b525662b27e8cb19... Author: Eliot Miranda eliot.miranda@gmail.com Date: 2022-10-08 (Sat, 08 Oct 2022)
Changed paths: M platforms/Cross/vm/sqImageFileAccessViaStdio.h M platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c
Log Message:
Fix a comment typo in sqImageFileAccessViaStdio.h. Fix some formatting in sqWin32FilePrims.c; if( is bad; if is a keyword, not a function. char* foo is bad; the type of bar in "char* foo, bar;" is char.
Ok, so it's "typedef pchar char*" from now on…
This is why in K&R the asterisk is always associated with the variable, not the base type. Returns should be om their own line for breakpointing when debugging.
On 8. Oct 2022, at 21:55, Eliot Miranda noreply@github.com wrote:
Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: af9b525662b27e8cb19983f7f6f40561b17fcc4f https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/af9b525662b27e8cb19... Author: Eliot Miranda eliot.miranda@gmail.com Date: 2022-10-08 (Sat, 08 Oct 2022)
Changed paths: M platforms/Cross/vm/sqImageFileAccessViaStdio.h M platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c
Log Message:
Fix a comment typo in sqImageFileAccessViaStdio.h. Fix some formatting in sqWin32FilePrims.c; if( is bad; if is a keyword, not a function. char* foo is bad; the type of bar in "char* foo, bar;" is char.
Ok, so it's "typedef pchar char*" from now on…
Aaand I got it the wrong way around again -.- suits me righ xD
-t
This is why in K&R the asterisk is always associated with the variable, not the base type. Returns should be om their own line for breakpointing when debugging.
Am So., 9. Okt. 2022 um 11:27 Uhr schrieb Tobias Pape Das.Linux@gmx.de:
char* foo is bad; the type of bar in "char* foo, bar;" is char.
Ok, so it's "typedef pchar char*" from now on…
And typedef const char *pcchar; because otherwise some inexperienced C programmer will use const pchar x and not get the const string which they wanted...
Or in other words: don't do this. ;-)
On 9. Oct 2022, at 12:21, Jakob Reschke jakres+squeak@gmail.com wrote:
Am So., 9. Okt. 2022 um 11:27 Uhr schrieb Tobias Pape Das.Linux@gmx.de:
char* foo is bad; the type of bar in "char* foo, bar;" is char.
Ok, so it's "typedef pchar char*" from now on…
And typedef const char *pcchar; because otherwise some inexperienced C programmer will use const pchar x and not get the const string which they wanted...
Or in other words: don't do this. ;-)
HA! :D
vm-dev@lists.squeakfoundation.org
-
Eliot Miranda -
Jakob Reschke -
Tobias Pape