[OpenSmalltalk/opensmalltalk-vm] Do not convert line ending of image/*.sh files on windows (#238)
Cygwin cannot run scripts with crlf. I added image/*.sh to the gitattributes to not convert their line ending. You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/238
-- Commit Summary --
* Cygwin cannot run scripts with crlf. I added image/*.sh to the gitattributes to not convert their line ending.
-- File Changes --
M .gitattributes (1)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/238.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/238.diff
Hi Cyril,
Which file was causing problems (so I can do a git checkout and manual inspect the file before applying your PR)?
Thanks, Alistair
It was buildspurvmmakerimage.sh and all the scripts it calls.
Note that there is a workaround: put `set -o igncr` in your .bash_profile See https://stackoverflow.com/questions/14598753/running-bash-script-in-cygwin-o... for example.
I agree that it's preferable to correctly set the git file attributes and avoid the problem at the source!
Thank you for the information! I did not knew. I'll probably still try to avoid adding this, like that I'll encounter the problems and do PR to correct them.
Merged #238.
vm-dev@lists.squeakfoundation.org
-
akgrant43 -
CyrilFerlicot
-
Nicolas Cellier