Hi guys. I've just commited. I didn't update yet the class comments because maybe they change again...so I will wait. For me what was more important is to be uniform with the pattern, and that is done now and it is nice. Regarding the prefix VM and the suffix Config, I don't have a strong thought. For me, the most information the better. First, because we have OCompletion ;) and second because you almost never type these classes. THe maximum you do is MyConf generateWithSources.
Anyway, I would appreciate if you can take a look and tell me. For the moment I let the suffix Config and I removed the "VM". For Cog and CogMT they look ok. With Stack they look awkward, but ok, I can live with that.
Thanks
Mariano
Name: CMakeVMMaker-MarianoMartinezPeck.96 Author: MarianoMartinezPeck Time: 23 April 2011, 1:36:10 pm UUID: 86ebc45f-3439-4be2-9ac3-5c975eab2b05 Ancestors: CMakeVMMaker-MarianoMartinezPeck.94
IMPORTANT: this commit renames ALL configurations. So, Hudson confs must be updated.
- All confs classes were renamed with the following pattern: <VM>-<OS>-[Debug-]<SpecialOptions?> (without the '-')
- Unix confs were moved to 'CMakeVMMaker-Unix' instead of 'CMakeVMMaker-Unix-Cog'.
- FreeBSD was moved to 'CMakeVMMaker-FreeBSD' instead of 'CMakeVMMaker-FreeBSD-Cog'
- Integrated with CMakeVMMaker-EstebanLorenzano.96
On Sat, Apr 23, 2011 at 9:16 AM, stephane ducasse < stephane.ducasse@gmail.com> wrote:
keep config this is important in the name.
On Apr 22, 2011, at 11:29 PM, Mariano Martinez Peck wrote:
There are some confs that look a little ugly without the VM prefix. For
example, StackUnixConfig
it sounds like a conf for a unix stack hehehehe
I am not convinced about removing the VM prefix...but ok, you all agree
so.. ;)
On Fri, Apr 22, 2011 at 11:08 PM, Mariano Martinez Peck <
marianopeck@gmail.com> wrote:
Now...you suggested to remove the prefix VM....and what about the suffix
Config ? should we keep them or remove it ?
On Fri, Apr 22, 2011 at 10:43 PM, Mariano Martinez Peck <
marianopeck@gmail.com> wrote:
On Fri, Apr 22, 2011 at 10:41 PM, Igor Stasenko siguctua@gmail.com
wrote:
On 22 April 2011 21:38, Mariano Martinez Peck marianopeck@gmail.com
wrote:
On Thu, Apr 28, 2011 at 8:34 PM, Jeremy Kajikawa <
jeremy.kajikawa@gmail.com> wrote:
Do you need to put "VM" into ALL of the config strings?
Good point. I don't know. Maybe we don't need it.
How about ... <Machine>-<OS>-[Debug-]<SpecialOptions?>
I like it :)
With examples like the following...
Cog-Windows Cog-Windows-Debug CogMT-Windows CogMT-Windows-Debug CogMT-Unix CogMT-Unix-NoGL CogMT-Unix-Debug-NoGL Stack-Windows Stack-Windows-Debug Stack-Windows-Debug-FixedVerSI Stack-Unix Stack-Unix-Debug Stack-Unix-Debug-FixedVerSI
You cannot use '-' in class name. However we can use underline.
Sorry, I didn't plant to use '-' it was just to make it clear for the
email.
CogMT_Unix_Debug_NoGL
but then i think
CogMTUnixDebugNoGL
Exaclty, like that.
will be better.
Are these usable and readable by everyone?
I like this last change. For the prefix without the "VM" I am not sure.
I don't have a strong position.
I would go with this one.
Yeah. VM can be omitted.
Excellent.
Igor ? Esteban? (since you are the guys that mostly maintain them)
I am fine with it. As to me, as long as things work i don't care much about naming. This stuff is not used too often and by many..
But it will !!! As long as we start to document and improve the
infrastructure new people will arrive to the VM world. At least that's what I am trying to do since the last months.
But i agree that consistent naming is good to have, so if you have a time to spend on polishing this, do it :)
Ok, I will...we have long weekend ;) Then you update the Hudson confs hehehe
--
Best regards, Igor Stasenko AKA sig.
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
vm-dev@lists.squeakfoundation.org