[OpenSmalltalk/opensmalltalk-vm] Refixed slip in mvm (PR #646)

List overview All Threads
Download

newer

older

VM Maker:...

VM Maker: VMMaker-dtl.436.mcz

Ken Dickey

25 Jul 2022 25 Jul '22

9:02 p.m.

Elided 1 line (TARGET_ARCH) You can view, comment on, or merge this pull request online at:

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646

-- Commit Summary --

* Refixed slip in mvm

-- File Changes --

M building/linux64riscv/squeak.stack.spur/build/mvm (1)

-- Patch Links --

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646.diff

-- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/pull/646@github.com>

Attachments:

attachment.html (text/html — 2.6 KB)

Show replies by date

Ken Dickey

25 Jul 25 Jul

9:43 p.m.

New subject: [OpenSmalltalk/opensmalltalk-vm] Refixed slip in mvm (PR #646)

@KenDickey pushed 1 commit.

9e99f5b7a6ba288082b3d6fe4f782cf85501bb70 Added CoInterpreter init invocation

-- View it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646/files/2da3a2fc3df... You are receiving this because you are subscribed to this thread. Message ID: OpenSmalltalk/opensmalltalk-vm/pull/646/push/10541274171@github.com

Ken Dickey

26 Jul 26 Jul

12:34 a.m.

New subject: [OpenSmalltalk/opensmalltalk-vm] Refixed slip in mvm (PR #646)

@KenDickey pushed 1 commit.

2c93f75f5d29b1fbe1ca992015c5ce67d551be98 Clean VMMaker gen. FFI Tests GREEN

-- View it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646/files/9e99f5b7a6b... You are receiving this because you are subscribed to this thread. Message ID: OpenSmalltalk/opensmalltalk-vm/pull/646/push/10542514800@github.com

Ken Dickey

8:51 p.m.

New subject: [OpenSmalltalk/opensmalltalk-vm] Refixed slip in mvm (PR #646)

@KenDickey pushed 1 commit.

e716ce4d76ed7b26c1e21408a981d5a5fd63a5f0 crc fix for riscv64

-- View it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646/files/2c93f75f5d2... You are receiving this because you are subscribed to this thread. Message ID: OpenSmalltalk/opensmalltalk-vm/pull/646/push/10552348268@github.com

Ken Dickey

8:55 p.m.

New subject: [OpenSmalltalk/opensmalltalk-vm] Refixed slip in mvm (PR #646)

More bits & bobs for RV64g. All tested on riscv64.

-- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646#issuecomment-1195... You are receiving this because you are subscribed to this thread. Message ID: OpenSmalltalk/opensmalltalk-vm/pull/646/c1195862680@github.com

Ken Dickey

30 Jul 30 Jul

3:58 a.m.

New subject: [OpenSmalltalk/opensmalltalk-vm] Refixed slip in mvm (PR #646)

@KenDickey pushed 1 commit.

2394934519ddc293e5d7efb167d843d214740760 Dump a few registers on fault

-- View it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646/files/e716ce4d76e... You are receiving this because you are subscribed to this thread. Message ID: OpenSmalltalk/opensmalltalk-vm/pull/646/push/10587826612@github.com

Eliot Miranda

9:27 p.m.

New subject: [OpenSmalltalk/opensmalltalk-vm] Refixed slip in mvm (PR #646)

@eliotmiranda requested changes on this pull request.

Hi Ken, can you do a different version which doesn't include either of src/plugins/SqueakFFIPrims/RiscV64FFIPlugin.c src/plugins/ZipPlugin/ZipPlugin.c ? I generate these carefully. Your generations are against changed VMMaker packages (see the static const char *moduleName = "ZipPlugin * VMMaker.oscog-eem.3218 " INT_EXT; lines). So I don't want to accept these changes and have to regenerate the plugin files again. Everything else looks fine.

-- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646#pullrequestreview... You are receiving this because you are subscribed to this thread. Message ID: OpenSmalltalk/opensmalltalk-vm/pull/646/review/1056471550@github.com

Ken Dickey

9:41 p.m.

New subject: [OpenSmalltalk/opensmalltalk-vm] Refixed slip in mvm (PR #646)

@KenDickey pushed 1 commit.

5467b10eb38c6d96445e3c2c5a26ae532d2d7677 Don't truncate register values

-- View it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646/files/2394934519d... You are receiving this because you are subscribed to this thread. Message ID: OpenSmalltalk/opensmalltalk-vm/pull/646/push/10591453278@github.com

Ken Dickey

9:51 p.m.

New subject: [OpenSmalltalk/opensmalltalk-vm] Refixed slip in mvm (PR #646)

@KenDickey pushed 1 commit.

eeb5f38532345a20cfed4a5321f5be64dd5bf7ae from release

-- View it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646/files/5467b10eb38... You are receiving this because you are subscribed to this thread. Message ID: OpenSmalltalk/opensmalltalk-vm/pull/646/push/10591484090@github.com

Ken Dickey

10:01 p.m.

New subject: [OpenSmalltalk/opensmalltalk-vm] Refixed slip in mvm (PR #646)

nonRegisterStructReturnIsViaImplicitFirstArgument still needs to return false/0

If you remove VMMaker method ThreadedARM64FFIPlugin>>nonRegisterStructReturnIsViaImplicitFirstArgument

The inherited behavior should be correct.

I am not much of a GIT user. Is current close enough?

-- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646#issuecomment-1200... You are receiving this because you are subscribed to this thread. Message ID: OpenSmalltalk/opensmalltalk-vm/pull/646/c1200285537@github.com

Eliot Miranda

2 Aug 2 Aug

5:07 p.m.

New subject: [OpenSmalltalk/opensmalltalk-vm] Refixed slip in mvm (PR #646)

@eliotmiranda approved this pull request.

641

Age (days ago)

649

Last active (days ago)

vm-dev@lists.squeakfoundation.org

10 comments

2 participants

tags (0)

participants (2)

Eliot Miranda
Ken Dickey