Changing the implementation of the fullScreen primitive to follow the guidelines here:
https://developer.apple.com/library/archive/documentation/General/Conceptual...
It works from the primitive and from the green button in the window You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381
-- Commit Summary --
* Fixing the change to fullscreen
-- File Changes --
M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m (23)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381.diff
johnmci commented on this pull request.
The apple documents are not clear, one is a test for the state of the view at the moment, the other is a test to see if the window is capable of full screen? @property(getter=isInFullScreenMode, readonly) BOOL inFullScreenMode; The value of this property is YES when the view is in full screen mode or NO when it is not.
NSFullScreenWindowMask The window can appear full screen. A fullscreen window does not draw its title bar, and may have special handling for its toolbar. This mask is automatically toggled when toggleFullScreen: is called.
eliotmiranda approved this pull request.
Merged #381 into Cog.
Appears to work perfectly. Thanks Pablo!
Should that be fixed in pharo.cog.spur_macos64x64_201903251926?. I still manage to get an unresponsive Pharo image when doing in a playground: Display toggleFullscreen
vm-dev@lists.squeakfoundation.org