seaside-dev February 2008

seaside-dev@lists.squeakfoundation.org

15 participants
32 discussions

Seaside-Core-dkh.65
by Philippe Marschall 04 Mar '08

04 Mar '08

Could someone from Cincom please have a look this and check whether it's ok and would make it possible to remove the Squeak::Date and Seaside::Date classes from the Seaside port on CST? Cheers Philippe

3 6

Seaside-Core-dkh.65
by Philippe Marschall 29 Feb '08

29 Feb '08

The problem I have with this is that it works very fine for encoded adapter but gives the tester of a non-encoded server adapter that something is broken when it's not. Damn, someone should really do the J2EE refactoring so we know whether we are on an encoded server adapter. Cheers Philippe

2 1

WAMiniCalendar rewrite
by Paolo Bonzini 29 Feb '08

29 Feb '08

The attached changeset reimplements WAMiniCalendar to not use Squeak's additional date classes (except if one uses the #month and #month: accessors; for now in GNU Smalltalk they will not be available). In addition, to make the patch more palatable, it eases localization (one has to reimplement #monthNames and #weekDays). I checked that the methods I used, especially #addDays: and #subtractDays:, are available in VW too. Paolo WAComponent subclass: #WAMiniCalendar instanceVariableNames: 'monthIndex year date canSelectBlock selectBlock' classVariableNames: '' poolDictionaries: '' category: 'Seaside-Core-Components-Widgets'! WAMiniCalendar comment: 'WAMiniCalendar renders a monthly calendar. Users can navigate by month, year, or select a year and a month. Users can select a date in the calendar. Set canSelectBlock to control which dates a user can select. Use selectBlock to perform an action when a user selects a date. WAMiniCalendar>>date returns the selected date. Select "Mini Calendar" tab of the Functional Seaside Test Suite to run an example (http://127.0.0.1:xxxx/seaside/tests/alltests) Instance Variables: canSelectBlock <BlockClosure with date argument> return true if date argument should be rendered with a link, ie user can select that date date <WAValueHolder on a date> Selected date monthIndex <WAValueHolder on an Integer> Currently displayed month year <WAValueHolder on an Integer> Currently displayed year selectBlock <BlockClosure with date argument> called when user selects a date '! !WAMiniCalendar class methodsFor: 'testing'! canBeRoot ^true ! example ^self new ! ! !WAMiniCalendar methodsFor: 'testing'! canSelect: aDate ^canSelectBlock value: aDate ! ! !WAMiniCalendar methodsFor: 'accessing'! canSelectBlock: aBlock canSelectBlock := aBlock ! month ^Month month: self monthIndex year: self year ! month: aMonth self monthIndex: aMonth monthIndex. self year: aMonth year. ! selectBlock: aBlock selectBlock := aBlock ! states ^Array with: date with: monthIndex with: year ! ! !WAMiniCalendar methodsFor: 'accessing-delegated'! date ^date contents ! date: aDate date contents: aDate. monthIndex contents: aDate monthIndex. year contents: aDate year ! monthIndex ^monthIndex contents ! monthIndex: anInteger monthIndex contents: anInteger ! year ^year contents ! year: anIntegerOrString year contents: ([anIntegerOrString asInteger] on: Error do: [:error | 1900]) ! ! !WAMiniCalendar methodsFor: 'initialization'! initialize super initialize. monthIndex := WAValueHolder with: Date today monthIndex. year := WAValueHolder with: Date today year. date := WAValueHolder new. canSelectBlock := [:value | true]. selectBlock := [:value | self answer: value] ! ! !WAMiniCalendar methodsFor: 'localization'! monthNames ^(1 to: 12) collect: [ :each | Date nameOfMonth: each ] ! weekDays ^(1 to: 7) collect: [:i | (Date nameOfDay: i) first: 3] ! ! !WAMiniCalendar methodsFor: 'private'! monthName ^(Date nameOfMonth: self monthIndex) ! monthHeading ^self monthName , ' ' , self year toString ! weeksDo: aBlock | day nextMonth | day := Date newDay: 1 monthIndex: self monthIndex year: self year. day := day subtractDays: day dayOfWeek. nextMonth := (self monthIndex \\ 12) + 1. [ day monthIndex = nextMonth ] whileFalse: [ aBlock value: day. day := day addDays: 7 ] ! ! !WAMiniCalendar methodsFor: 'rendering'! renderCellForDate: aDate on: html html tableData: [(aDate monthIndex = self monthIndex and: [ aDate year = self year ]) ifTrue: [html span class: (self date = aDate ifTrue: ['calendarArchiveDate']); with: [(self canSelect: aDate) ifTrue: [html anchor callback: [self select: aDate]; with: aDate dayOfMonth] ifFalse: [html text: aDate dayOfMonth]]]] ! renderContentOn: html html div class: 'calendar'; with: [html span class: 'calendarCaption'; with: [self renderMonthHeadingOn: html]. html table: [html tableRow class: 'calendarTitle'; with: [self weekDays do: [:each | html tableData: each]]. self weeksDo: [:week | self renderRowForWeek: week on: html]]. self renderMonthNavigationOn: html. html space; space. self renderYearNavigationOn: html] ! renderMonthHeadingOn: html html form: [html select list: (1 to: 12); on: #monthIndex of: self; labels: [:index | Date nameOfMonth: index]. html textInput maxLength: 4; on: #year of: self. html submitButton text: 'Refresh'] ! renderMonthNavigationOn: html | tab | tab := #(12 1 2 3 4 5 6 7 8 9 10 11 12 1). html span class: 'calendarPrevious'; with: [html anchor callback: [ self monthIndex = 1 ifTrue: [ self monthIndex: 12; year: self year - 1] ifFalse: [ self monthIndex: self monthIndex - 1 ]]; with: ((self monthNames at: (tab at: self monthIndex)) first: 3)]. html space. html span class: 'calendarNext'; with: [html anchor callback: [ self monthIndex = 12 ifTrue: [ self monthIndex: 1; year: self year + 1] ifFalse: [ self monthIndex: self monthIndex + 1 ]]; with: ((self monthNames at: (tab at: self monthIndex + 2)) first: 3)]. ! renderRowForWeek: initialDay on: html html tableRow: [0 to: 6 do: [:each | self renderCellForDate: (initialDay addDays: each) on: html]] ! renderYearNavigationOn: html html span class: 'calendarPrevious'; with: [html anchor callback: [self year: self year - 1]; with: self year - 1]. html space. html span class: 'calendarNext'; with: [html anchor callback: [self year: self year + 1]; with: self year + 1] ! ! !WAMiniCalendar methodsFor: 'action'! select: aDate self date: aDate. selectBlock value: aDate ! !

3 5

Seaside-Core
by Dale Henrichs 29 Feb '08

29 Feb '08

The class BlockContext is not in GemStone, so I assume that BlockContext>>handleRequest: and BlockContext>>renderOn: (both in Seaside-Core) should be moved to Seaside-Squeak-Core .... I'll do the move myself, but I thought I'd double check with you guys in case there is a better place... Dale

3 3

Seaside-Core-lr.62
by Philippe Marschall 29 Feb '08

29 Feb '08

WACacheTest clicking the links of increases a continuation count only the second time, often clicking a link will reduce "foreign" continuations. Might be a GC effect. an explaining text couldn't hurt WACallbackTest 'Side Effect' doesn't seem to work because I see no different to 'Idempotent' an explaining text couldn't hurt WAColusreTest, I'm not sure if 'go with ensure' does the right thing (tm) the back button behavior seems broken 'ensure' -> 1a -> 'ensure' -> back-button to the first ensure -> 1a -> 1a -> 1a -> ... an explaining text couldn't hurt WACookieTest the remove button removes only the value WAErrorTest couldn't test, test will follow no idea what WAHomeTest home test should do WATableReportTest broken in my image WATransactionTest looking good Cheers Philippe

6 20

WAFormTag exception
by Gerhard Obermann 28 Feb '08

28 Feb '08

Hi! I would suggest to change the method "before" in WAFormTag (see below). With this change testing of rendering methods doesn't produce an exception! before "Define the default action form buttons. Some implementation notes on this feature: (1) a tab-index of -1 is not valid XHTML, but most todays browser accept it and ignore the element in the tab-order. (2) Internet Explorer requires an additional text field (without other functionality) to make the default action work. Other browser should not include this text-field, as it prevents remembering form input." | userAgent aRequest | defaultAction ifNil: [ ^ nil ]. canvas div: [ canvas submitButton tabIndex: -1; value: 'Default'; callback: defaultAction; style: 'position: absolute; top: -100em'. aRequest := self session currentRequest. aRequest ifNotNil: [ userAgent := aRequest userAgent. (userAgent notNil and: [ userAgent includesSubString: 'MSIE' ]) ifTrue: [ canvas textInput tabIndex: -1; callback: [ :v | ]; style: 'position: absolute; top: -100em' ] ] ]

1 0

halo bugs?
by Paolo Bonzini 27 Feb '08

27 Feb '08

1) missing method WAConfiguration >> name ^self class name 2) wrong name for WAHalo class>>#initializeClass (should be #initialize, or else its caller WAToolDecoration>>#toggleHalos should be changed. Paolo

2 1

Seaside2.8a1-cw.532
by Philippe Marschall 26 Feb '08

26 Feb '08

deleted, no your experiments in your on repository ffs! Philippe

3 4

WABrush questionable namings
by Gerhard Obermann 26 Feb '08

26 Feb '08

Hi! During my trial to create a generic WABrush seaside editor i have found some questionable namings in WABrush and all subclasses! Ill hope that some of these could be addressed with Seaside 2.9! Here is the result after checking mostly all classes: - WASelectTag - #enabled: aBlock <-> #disabled: Boolean .. Its a little bit confusing to use enabled: in that case - WATimeInput - public api -> public - initialize-release -> initialization - WAAnchorTag - conveniance -> convenience - #tag -> category accessing - WAHeadingTag - #tag -> category accessing - WATagBrush -#tag -> category accessing - WAImageTag -#tag -> category accessing - WADivTag - public api -> public - WAFormInputTag: .. why is it necessary to set also the class ? with: aBlock self type isNil ifFalse: [ self attributes at: 'type' ifAbsentPut: [ self type ]. self class: self type ]. super with: aBlock WATagBrush, WACheckboxTag, WARAdionButtonTag, WASubmitButtonTag - #canHaveShortcut -> testing - WACheckboxTag #submitFormNamed: -> conveniance (see WAAnchorTag) - WAButtonTag - initialize-release -> initialization - WAImageButtonTag - callback: -> callbacks - WAFormTag - initialize-release -> initialization - WAGenericTag - initialize-release -> initialization - WAHeadingTag - conveniance -> convenience - #tag -> accessing - WAImageTag - initialize-release -> initialization - #tag -> accessing Cheers Gerhard

4 10

ISO 3166 codes
by Paolo Bonzini 24 Feb '08

24 Feb '08

Here is a list of ISO 3166 3-character country codes, as the ones "desired" by the failing test WALocaleTest>>#testLanguageNameIso3: ABW Aruba AFG Afghanistan AGO Angola AIA Anguilla ALA Åland Islands ALB Albania AND Andorra ANT Netherlands Antilles ARE United Arab Emirates ARG Argentina ARM Armenia ASM American Samoa ATA Antarctica ATF French Southern Territories ATG Antigua and Barbuda AUS Australia AUT Austria AZE Azerbaijan BDI Burundi BEL Belgium BEN Benin BFA Burkina Faso BGD Bangladesh BGR Bulgaria BHR Bahrain BHS Bahamas BIH Bosnia and Herzegovina BLM Saint Barthélemy BLR Belarus BLZ Belize BMU Bermuda BOL Bolivia BRA Brazil BRB Barbados BRN Brunei Darussalam BTN Bhutan BVT Bouvet Island BWA Botswana CAF Central African Republic CAN Canada CCK Cocos (Keeling) Islands CHE Switzerland CHL Chile CHN China CIV Côte d'Ivoire CMR Cameroon COD Congo, the Democratic Republic of the COG Congo COK Cook Islands COL Colombia COM Comoros CPV Cape Verde CRI Costa Rica CUB Cuba CXR Christmas Island CYM Cayman Islands CYP Cyprus CZE Czech Republic DEU Germany DJI Djibouti DMA Dominica DNK Denmark DOM Dominican Republic DZA Algeria ECU Ecuador EGY Egypt ERI Eritrea ESH Western Sahara ESP Spain EST Estonia ETH Ethiopia FIN Finland FJI Fiji FLK Falkland Islands (Malvinas) FRA France FRO Faroe Islands FSM Micronesia, Federated States of GAB Gabon GBR United Kingdom GEO Georgia GGY Guernsey GHA Ghana GIN Guinea GIB Gibraltar GLP Guadeloupe GMB Gambia GNB Guinea-Bissau GNQ Equatorial Guinea GRC Greece GRD Grenada GRL Greenland GTM Guatemala GUF French Guiana GUM Guam GUY Guyana HKG Hong Kong HMD Heard Island and McDonald Islands HND Honduras HRV Croatia HTI Haiti HUN Hungary IDN Indonesia IMN Isle of Man IND India IOT British Indian Ocean Territory IRL Ireland IRN Iran, Islamic Republic of IRQ Iraq ISL Iceland ISR Israel ITA Italy JAM Jamaica JEY Jersey JOR Jordan JPN Japan KAZ Kazakhstan KEN Kenya KGZ Kyrgyzstan KHM Cambodia KIR Kiribati KNA Saint Kitts and Nevis KOR Korea, Republic of KWT Kuwait LAO Lao People's Democratic Republic LBN Lebanon LBR Liberia LBY Libyan Arab Jamahiriya LCA Saint Lucia LIE Liechtenstein LKA Sri Lanka LSO Lesotho LTU Lithuania LUX Luxembourg LVA Latvia MAC Macao MAF Saint Martin (French part) MAR Morocco MCO Monaco MDA Moldova, Republic of MDG Madagascar MDV Maldives MEX Mexico MHL Marshall Islands MKD Macedonia, the former Yugoslav Republic of MLI Mali MLT Malta MMR Myanmar MNE Montenegro MNG Mongolia MNP Northern Mariana Islands MOZ Mozambique MRT Mauritania MSR Montserrat MTQ Martinique MUS Mauritius MWI Malawi MYS Malaysia MYT Mayotte NAM Namibia NCL New Caledonia NER Niger NFK Norfolk Island NGA Nigeria NIC Nicaragua NOR Norway NIU Niue NLD Netherlands NPL Nepal NRU Nauru NZL New Zealand OMN Oman PAK Pakistan PAN Panama PCN Pitcairn PER Peru PHL Philippines PLW Palau PNG Papua New Guinea POL Poland PRI Puerto Rico PRK Korea, Democratic People's Republic of PRT Portugal PRY Paraguay PSE Palestinian Territory, Occupied PYF French Polynesia QAT Qatar REU Réunion ROU Romania RUS Russian Federation RWA Rwanda SAU Saudi Arabia SDN Sudan SEN Senegal SGP Singapore SGS South Georgia and the South Sandwich Islands SHN Saint Helena SJM Svalbard and Jan Mayen SLB Solomon Islands SLE Sierra Leone SLV El Salvador SMR San Marino SOM Somalia SPM Saint Pierre and Miquelon SRB Serbia STP Sao Tome and Principe SUR Suriname SVK Slovakia SVN Slovenia SWE Sweden SWZ Swaziland SYC Seychelles SYR Syrian Arab Republic TCA Turks and Caicos Islands TCD Chad TGO Togo THA Thailand TJK Tajikistan TKL Tokelau TKM Turkmenistan TLS Timor-Leste TON Tonga TTO Trinidad and Tobago TUN Tunisia TUR Turkey TUV Tuvalu TWN Taiwan, Province of China TZA Tanzania, United Republic of UGA Uganda UKR Ukraine UMI United States Minor Outlying Islands URY Uruguay USA United States UZB Uzbekistan VAT Holy See (Vatican City State) VCT Saint Vincent and the Grenadines VEN Venezuela VGB Virgin Islands, British VIR Virgin Islands, U.S. VNM Viet Nam VUT Vanuatu WLF Wallis and Futuna WSM Samoa YEM Yemen ZAF South Africa ZMB Zambia ZWE Zimbabwe That's it. Paolo

3 3

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

seaside-dev February 2008