seaside-dev June 2011

seaside-dev@lists.squeakfoundation.org

8 participants
4 discussions

Start a nNew thread

WADivTag >> #clear
by Philippe Marschall 27 Jun '11

27 Jun '11

Do we need/want that? It's from 2005. Cheers Philippe

4 8

Set vs. IdentitySet in WAFileLibrary>>#filenames
by Paolo Bonzini 22 Jun '11

22 Jun '11

Hi, Gwenael Casaccio recently found the following assumption in Seaside while working on an unrelated change to GNU Smalltalk. In WAFileLibrary>>#filenames, you are building strings from selectors: ^self fileSelectors collect: [:each | self asFilename: each] This however is assuming that #fileSelectors (and hence Behavior>>#selectors) returns an Array or a Set. Gwen would like to change Behavior>>#selectors return an IdentitySet. In this case #filenames would return an IdentitySet of strings, which is pretty much unusable. The possible solution is to send #asArray or #asSet before #collect:. Does this seem okay? Can you make the change so that when I finally upgrade to 3.0.x I will not see this issue? Thanks! Paolo

3 4

commit messages
by Julian Fitzell 22 Jun '11

22 Jun '11

Hi all, Nick's going to think this is directed at him since he just committed, but it's not; I've been observing this for a while now. :) Would committers please do everyone else a favour and include at least *one line* of description about the included change? The common pattern at the moment seems to be to put the issue number in the commit message and the package information in the issue, but this gives no clue what was done to fix the issue. Particularly now that diffs in the emails are turned off, this makes it basically impossible to follow what's going on without loading every committed package and looking at the code. A simple indication of what class/method you changed/added/deleted would be a start. For example: ---------- Fixed http://code.google.com/p/seaside/issues/detail?id=xxx Added WAFoo>>bar, which wraps the call to super in an exception handler ---------- Ideally, if it's not obvious, you'd also include a line or two about the reason you made the fix you did. This should only take you a few seconds and I (along with anyone looking back at the code history in the future) will thank you. Thank you! (see? :) ) Julian

5 16

state of 3.0.5
by Philippe Marschall 09 Jun '11

09 Jun '11

Hi guys Here's the current state of 3.0.5: I saved the images from Jenkins and uploaded them to the web site. The change log has also been updated [1]. Everything but the Metacello configuration seems to work fine. If I load the Metacello configuration into a Pharo 1.2 it tries to load a version of OB that does not work in Pharo 1.2. [1] http://code.google.com/p/seaside/wiki/Seaside305Changelog Cheers Philippe

3 10

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

seaside-dev June 2011