seaside-dev September 2020

seaside-dev@lists.squeakfoundation.org

3 participants
9 discussions

Start a nNew thread

Seaside-dev_Profiler_page_'GC_S
by Elizabeth 17 Sep '20

17 Sep '20

Let's have a chat here: galleries.daswanitailors.com secure chat It's hard to chat via unsecure email.

1 0

Profiler page 'GC Stats' problem with profiler.svg ByteArray
by tim Rowledge 15 Sep '20

15 Sep '20

For most excellent reason I took a look at the profiler page for my current development stuff and bravely clicked on the 'GC Stats' link. It did not go well. The fault is related to the 'profiler.svg' provided by WAToolFiles>>#profilerSvg. What happens (in Squeak 5.3-19435) is that the ByteArray returned is being turned into a mime document with a mimetype of 'svg+xml'. Unfortunately that is *not * being seen as a binary type and thus we go down the path of trying to run GRPharoUtf8CodecStream>>#nextPutAll: which sends #isByteString to the ByteArray; which dNU:. After an afternoon poking around it appears to me that the most likely cause of the issue is in WAMimeType>>#isBinary where we see this - ++++++++++++++ isBinary "answers whether the contents of a document of the receiving mime type are binary" self main = 'text' ifTrue: [ ^ false ]. self main = 'application' ifTrue: [ "application/json is text" self sub = 'json' ifTrue: [ ^ false ] ]. GRPlatform subStringsIn: self sub splitBy: $+ do: [ :each | "application/(x-)javascript and application/xml are text" (#('x-javascript' 'javascript' 'xml') includes: each) ifTrue: [ ^ false ] ]. ^ true ++++++++++++++ From the comments (hey, actual comments - well done author) it looks to me that the testing of 'sub' ought to in fact be inside the ifTrue: block above. i.e. we check for main = 'application' AND sub includes the other bits. As-is we check sub for including 'xml' even if main is not 'application'. That means that svg+xml counts as not-binary, which I strongly suspect is incorrect. So, making the obvious trivial edits we get --------------------- isBinary "answers whether the contents of a document of the receiving mime type are binary" self main = 'text' ifTrue: [ ^ false ]. self main = 'application' ifTrue: [ "application/json is text" self sub = 'json' ifTrue: [ ^ false ] . GRPlatform subStringsIn: self sub splitBy: $+ do: [ :each | "application/(x-)javascript and application/xml are text" (#('x-javascript' 'javascript' 'xml') includes: each) ifTrue: [ ^ false ] ] ]. ^ true ----------------------- ... and the profiler svg is properly rendered and the page load does not fail and there is no text sent to the Transcript from a background process that causes it to crash, which is what lead me to all this fun stuff. I've added this to a new issue on github. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim My Go this amn keyboar oesn't have any 's.

2 2

Seaside-dev_Profiler_page_'GC_S
by Elizabeth 15 Sep '20

15 Sep '20

I'm online now, waiting, let's have a nice talk:) Here is my page: galleries.daswanitailors.com profile

1 0

Seaside-dev_Profiler_page_'GC_Stats'_
by Elizabeth 15 Sep '20

15 Sep '20

Have you found my fotos?

1 0

Seaside-dev_Profiler_page_'GC_S
by Elizabeth 15 Sep '20

15 Sep '20

You don't like me?

1 0

Seaside-dev_Profiler_page_'GC_S
by Elizabeth 15 Sep '20

15 Sep '20

I added new pics for you! You can view them here: galleries.daswanitailors.com my gallery

1 0

Seaside-dev_Profiler_page_'GC_S
by Elizabeth 15 Sep '20

15 Sep '20

Plz contact me on this site: galleries.daswanitailors.com here I can't use this e-mail for chat.

1 0

Seaside-dev_Profiler_page_'GC_Stats'_
by Elizabeth 15 Sep '20

15 Sep '20

I'm waiting online! Please contact me in my chat: galleries.daswanitailors.com here

1 0

Seaside-dev Profiler page 'GC Stats' problem with profiler.svgByteArray
by Elizabeth 15 Sep '20

15 Sep '20

I'm a 30 y.o. woman looking for an affair. I am ready to try anything are you interested? If you want to see my pics, you can view them in my gallery: galleries.daswanitailors.com all pics On Tue, Sep 15, 2020, at 3:21 AM, Seaside wrote: >For most excellent reason I took a look at the profiler page for my current development stuff and bravely clicked on the 'GC Stats' link. It did not go well. > >The fault is related to the ' ' provided by WAToolFiles#profilerSvg. >

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

seaside-dev September 2020