I have made some changes in my local environment to Phato's MailMessage and Seaside's WAEmailMessage to support creation of multi-part MIME messages (e.g. HTML and plaintext).
I would like to contribute these changes, but I'm not sure how to proceed because the Seaside changes are dependent on the Pharo changes.
Should I submit all the changes to Seaside and include the Pharo changes as Seaside extensions to Pharo or submit the changes separately to Pharo and Seaside?
And of course my changes are for Pharo only and therefore the other Seaside platforms would not be supported. Do I need to make sure this works on all platforms before submitting?
Cheers, TF
2010/12/26 Tony Fleig tony.fleig@gmail.com:
I have made some changes in my local environment to Phato's MailMessage and Seaside's WAEmailMessage to support creation of multi-part MIME messages (e.g. HTML and plaintext). I would like to contribute these changes, but I'm not sure how to proceed because the Seaside changes are dependent on the Pharo changes.
First, thank you for wanting to contribute this. Changes that depend on changes in Pharo are a bit problematic because that requires users to use an unreleased Pharo version. Then again anything depends on the specific case. Anyways I still recommend creating an issue even if we can't merge it for a year (see below).
Should I submit all the changes to Seaside and include the Pharo changes as Seaside extensions to Pharo or submit the changes separately to Pharo and Seaside?
Ideally you create an issue in our issue tracker [1] and attach the Seaside related code (ideally in .mcz files).
And of course my changes are for Pharo only and therefore the other Seaside platforms would not be supported. Do I need to make sure this works on all platforms before submitting?
Maybe. We'll let you know in the comments if something is not OK and needs to be changed.
[1] http://code.google.com/p/seaside/issues/list
Cheers Philippe
Hi Tony,
It probably makes sense to integrate the changes that are not dependent on Seaside into Pharo.
Have you already created an issue in the Pharo tracker? If not here is the link: http://code.google.com/p/pharo/issues. To draw attention to the proposed changes it helps to announce it on the mailing list.
Cheers, Adrian
On Dec 26, 2010, at 18:39 , Tony Fleig wrote:
I have made some changes in my local environment to Phato's MailMessage and Seaside's WAEmailMessage to support creation of multi-part MIME messages (e.g. HTML and plaintext).
I would like to contribute these changes, but I'm not sure how to proceed because the Seaside changes are dependent on the Pharo changes.
Should I submit all the changes to Seaside and include the Pharo changes as Seaside extensions to Pharo or submit the changes separately to Pharo and Seaside?
And of course my changes are for Pharo only and therefore the other Seaside platforms would not be supported. Do I need to make sure this works on all platforms before submitting?
Cheers, TF _______________________________________________ seaside-dev mailing list seaside-dev@lists.squeakfoundation.org http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
seaside-dev@lists.squeakfoundation.org
-
Adrian Lienhard -
Philippe Marschall -
Tony Fleig