Vm-dev October 2015

vm-dev@lists.squeakfoundation.org

29 participants
86 discussions

image install of ubuntu 64-bit has an issue
by Robert Withers 25 Oct '15

25 Oct '15

Here is what I did for 64-bit Ubuntu Cog image install steps: 1. install 64-bit ubuntu 2. sudo apt-get install subversion 3. mkdir Cog 4. cd Cog 5. svn co _http://www.squeakvm.org/svn/squeak/branches/Cog/image_ 6. svn co _http://www.squeakvm.org/svn/squeak/branches/Cog_ oscogvm 7. cd image 8. update shell scripts to have bash rather than sh 9. run buildspurtrunkvmmakerimage.sh; it fails 10. sudo apt-get install squeak-vm 11. run buildspurtrunkvmmakerimage.sh; it fails The error is below. Thank you for any help, Robert cogspurlinuxht/squeak trunk50.image UpdateSqueakTrunkImage.st /usr/bin/ldd didn't produce any output and the system is 64 bit. You may need to (re)install the 32-bit libraries. cogspurlinuxht/squeak SpurVMMaker.image BuildSqueakSpurTrunkVMMakerImage.st /usr/bin/ldd didn't produce any output and the system is 64 bit. You may need to (re)install the 32-bit libraries.

4 16

Fwd: absolute value of an unsigned
by Nicolas Cellier 24 Oct '15

24 Oct '15

Oups wrong list ---------- Forwarded message ---------- From: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2015-10-24 1:57 GMT+02:00 Subject: absolute value of an unsigned To: vm-dev-request(a)lists.squeakfoundation.org In smalltalk (a - b) abs allways makes sense... But if ever one of the variables is translated unsigned, then C code abs(a-b) means something else... It means (a-b) \\ 16rFFFFFFFF It should be abs((signed)(a-b)) in 32 bits (or sqInt...) Plus the problem of abs behind defined int abs(int) (see labs post above), I strongly believe it's urgent to let CCodeGenerator>>initializeCTranslationDictionary ... pairs := #( #& #generateAbs:on:indent: and CCodeGenerator>>generateAnd:on:indent: correctly infer types and introduce long abs and signed cast when due. Example of potentially wrongly generated code: shrinkObjectMemory

1 0

positive32BitIntegerFor: -> positiveMachineIntegerFor
by Nicolas Cellier 24 Oct '15

24 Oct '15

Some senders should use positiveMachineIntegerFor: for 64 bits compliance I noticed: primitiveSecondsClock primitiveClockLogAddresses lot of MacMenubarPlugin which convert handles to Smalltalk int These are probably 32 bits, but IMO it does not hurt to use machine integer - at least it's consistent with sqInt declaration : primitiveImageFormatVersion primitiveHeartbeatFrequency I may report more ...

1 0

function used without being declared
by Nicolas Cellier 24 Oct '15

24 Oct '15

In 32bits, this is bad and not C99 conformant. But in 64bits, this is worse than bad. Most functions return or take sqInt parameters wich are going to be 64bits long but assumed int (32 bits) without the declaration...

1 0

CCode generation of rotatedFloatBitsOf:
by Nicolas Cellier 24 Oct '15

24 Oct '15

I have this infamous warning : shift count > width of type value = (((usqInt) (((usqInt)oop))) >> (3 + 1)) + ((oop & (1 << 3) ? *-1 << ((64 - 3) - 1)* : 0)); It's true, -1 is an int (32 bits) so the 60 bit shift may not work... May I suggest Smalltalk code change: ^oop asUnsignedInteger >> (self numTagBits + 1) + ((oop anyMask: self smallFloatSignBit) ifTrue: [-1 *asUnsignedInteger* << (64 - self numTagBits - 1)] ifFalse: [0])

1 0

64-bit CCode generation of abs
by Nicolas Cellier 24 Oct '15

24 Oct '15

shouldn't the absolute value be generated as labs(x) rather than abs(x) for 64bits long sqInt?

1 0

Re: [squeak-dev] The Trunk: Network-topa.166.mcz
by Tobias Pape 22 Oct '15

22 Oct '15

On 22.10.2015, at 14:37, David T. Lewis <lewis(a)mail.msen.com> wrote: > On Thu, Oct 22, 2015 at 06:28:09AM +0000, commits(a)source.squeak.org wrote: >> Tobias Pape uploaded a new version of Network to project The Trunk: >> http://source.squeak.org/trunk/Network-topa.166.mcz >> >> ==================== Summary ==================== >> >> Name: Network-topa.166 >> Author: topa >> Time: 21 October 2015, 8:26:14.656 pm >> UUID: d6d9910f-fa67-4c69-9a89-030c81233e90 >> Ancestors: Network-topa.165 >> >> UUIDGenerator >> - Use new Random>>#nextBytes:into:startingAt: (needs Kernel-ul.960) for even more speed >> - Fix UUIDGenerator class>>#initialize to correctly register at startup >> - Do not reset default on startup but rather reseed TheRandom >> >> Timings improved: '1,190,000 per second. 842 nanoseconds per run.' (0.25 times slower than primitive version) >> > > This is outstanding. The UUID plugin has long been a source of problems in > the VM, partly due to issues in various Linux distributions. > > http://bugs.squeak.org/view.php?id=7358 > > Making the plugin unnecessary is a big improvement. Thats what I thought. Probably we want to present this (Mersenne PRNG + new UUID gen) to the Pharo core developers (cc) so that we can just remove the UUID plugin from the VMs (cc vm-dev)? Best regards -Tobias

4 3

Re: [Vm-dev] VM Maker: VMMaker.oscog-eem.1492.mcz
by Robert Withers 22 Oct '15

22 Oct '15

I think I have a 32-bit ubuntu install so these changes may not make a difference. Although, would I be able to run 64-bit images in the simulator on a 32-bit machine? That would be very cool. I would still be interested in building the latest VMMaker generated code in Pharo. In search of training and guidance, is there a write up on which packages to load (Cog, Cog.pharo, CogVMMakerPharoCompatibility, VMMaker.oscog, ...)? thank you, Robert On 10/18/2015 12:33 AM, commits(a)source.squeak.org wrote: > > Eliot Miranda uploaded a new version of VMMaker to project VM Maker: > http://source.squeak.org/VMMaker/VMMaker.oscog-eem.1492.mcz > > ==================== Summary ==================== > > Name: VMMaker.oscog-eem.1492 > Author: eem > Time: 17 October 2015, 5:32:12.348 pm > UUID: a0778a36-b0e9-4e06-af1a-0e50572c9db1 > Ancestors: VMMaker.oscog-eem.1491 > > x64 Cogit: > Get the Cogit to a state where the 64-bit Spur image starts simulating. It's a new world ;-) > > Reimplement CMethodCacheAccessor, introducing CArrayOfLongsAccessor for the primitive trace log. > > Alter CogStackPage and surrogates so that CogStackPageSurrogate64 is properly laid out. > > Revise the signedIntToFrom/Foo methods, and add some tests to check their behaviour. > > Provide two move multi-tab browser opening conveniences. > > =============== Diff against VMMaker.oscog-eem.1491 =============== > > Item was added: > + CObjectAccessor subclass: #CArrayOfLongsAccessor > + instanceVariableNames: 'objectMemory address elementByteSize' > + classVariableNames: '' > + poolDictionaries: '' > + category: 'VMMaker-JITSimulation'! > + > + !CArrayOfLongsAccessor commentStamp: 'eem 10/8/2015 12:49' prior: 0! > + A CArrayOfLongsAccessor is a class that wraps an Array stored in the heap. It maps at:[put:] into a suitably aligned and offset longAt:[put:], for accessing Arrays stored in the heap, such as the primTraceLog. > + > + Instance Variables > + address: <Integer> > + entryByteSize: <Integer> > + objectMemory: <NewCoObjectMemorySimulator|Spur64BitMMLECoSimulator|Spur64BitMMLECoSimulator|Spur64BitMMBECoSimulator|Spur64BitMMBECoSimulator> > + > + address > + - the base address in the heap of the start of the array > + > + entryByteSize > + - the size of an element, in bytes > + > + objectMemory > + - the memory manager whose heap is being accessed > + ! > > Item was added: > + ----- Method: CArrayOfLongsAccessor>>address (in category 'accessing') ----- > + address > + ^address! > > Item was added: > + ----- Method: CArrayOfLongsAccessor>>at: (in category 'accessing') ----- > + at: index > + "Map at: into a suitably aligned and offset longAt:, for accessing Arrays stored in the heap, such as the primTraceLog." > + ^objectMemory longAt: index * elementByteSize + address! > > Item was added: > + ----- Method: CArrayOfLongsAccessor>>at:put: (in category 'accessing') ----- > + at: index put: aValue > + "Map at:put: into a suitably aligned and offset longAt:put:, for accessing Arrays stored in the heap, such as the primTraceLog." > + ^objectMemory longAt: index * elementByteSize + address put: aValue! > > Item was added: > + ----- Method: CArrayOfLongsAccessor>>objectMemory:at: (in category 'initialize-release') ----- > + objectMemory: anObjectMemory at: anAddress > + objectMemory := anObjectMemory. > + object := anObjectMemory memory. > + offset := anAddress / anObjectMemory wordSize. > + elementByteSize := anObjectMemory wordSize. > + address := anAddress! > > Item was changed: > + CArrayOfLongsAccessor subclass: #CMethodCacheAccessor > + instanceVariableNames: 'methodCacheArray entrySize functionPointerIndex' > - CObjectAccessor subclass: #CMethodCacheAccessor > - instanceVariableNames: 'methodCacheArray functionPointerIndex entrySize' > classVariableNames: '' > poolDictionaries: '' > category: 'VMMaker-JITSimulation'! > > !CMethodCacheAccessor commentStamp: '<historical>' prior: 0! > I am used to simulate accesses to the methodCache so it can live partly in memory, partly in a Smalltalk Array. This is necessary because in simulation function pointers are Smalltalk symbols (under simulation primitive dispatch is done via perform:). > ! > > Item was changed: > ----- Method: CMethodCacheAccessor>>at: (in category 'accessing') ----- > at: index > "The special handling of functionPointerIndex is necessary because in simulation function > pointers are Smalltalk symbols (under simulation primitive dispatch is done via perform:)." > index - 1 \\ entrySize = functionPointerIndex ifTrue: > [^methodCacheArray at: index]. > + ^objectMemory longAt: index * elementByteSize + address! > - ^object at: index + offset! > > Item was changed: > ----- Method: CMethodCacheAccessor>>at:put: (in category 'accessing') ----- > at: index put: value > "The special handling of functionPointerIndex is necessary because in simulation function > pointers are Smalltalk symbols (under simulation primitive dispatch is done via perform:)." > + (index = 16r44F and: [value = 16r1D]) ifTrue: > + [self halt]. > index - 1 \\ entrySize = functionPointerIndex ifTrue: > + [objectMemory longAt: index * elementByteSize + address put: (0 = value ifTrue: [value] ifFalse: [value identityHash]). > + ^methodCacheArray at: index put: value]. > + ^objectMemory longAt: index * elementByteSize + address put: value! > - [^methodCacheArray at: index put: value]. > - ^object at: index + offset put: value! > > Item was removed: > - ----- Method: CMethodCacheAccessor>>memory:offset:array:functionPointerIndex:entrySize: (in category 'initialize-release') ----- > - memory: anObject offset: baseIndex array: cacheArray functionPointerIndex: fpIndex entrySize: esz > - object := anObject. > - offset := baseIndex. > - methodCacheArray := cacheArray. > - functionPointerIndex := fpIndex - 1. > - entrySize := esz! > > Item was added: > + ----- Method: CMethodCacheAccessor>>objectMemory:at:array:functionPointerIndex:entrySize: (in category 'initialize-release') ----- > + objectMemory: anObjectMemory at: anAddress array: cacheArray functionPointerIndex: fpIndex entrySize: wordsPerCacheEntry > + self objectMemory: anObjectMemory > + at: anAddress - anObjectMemory wordSize. "implicit -1 for indices in at:[put:]; the MethodCache is one-relative" > + methodCacheArray := cacheArray. > + functionPointerIndex := fpIndex - 1. > + entrySize := wordsPerCacheEntry! > > Item was added: > + ----- Method: CObjectAccessor class>>defaultIntegerBaseInDebugger (in category 'debugger') ----- > + defaultIntegerBaseInDebugger > + ^VMClass defaultIntegerBaseInDebugger! > > Item was changed: > ----- Method: CoInterpreter>>methodCacheAddress (in category 'cog jit support') ----- > methodCacheAddress > <api> > <returnTypeC: #'void *'> > + ^self cCode: [methodCache] inSmalltalk: [methodCache address]! > - ^self cCode: [methodCache] inSmalltalk: [methodCache offset - 1 * objectMemory wordSize]! > > Item was changed: > ----- Method: CoInterpreterStackPages>>longAt:put: (in category 'memory access') ----- > + longAt: byteAddress put: a32Or64BitValue > - longAt: byteAddress put: a32BitValue > <doNotGenerate> > self assert: (byteAddress >= minStackAddress and: [byteAddress < maxStackAddress]). > + ^objectMemory longAt: byteAddress put: a32Or64BitValue! > - ^objectMemory longAt: byteAddress put: a32BitValue! > > Item was changed: > ----- Method: CoInterpreterStackPagesLSB>>byteAt: (in category 'memory access') ----- > byteAt: byteAddress > | lowBits long | > + lowBits := byteAddress bitAnd: objectMemory wordSize - 1. > - lowBits := byteAddress bitAnd: 3. > long := self longAt: byteAddress - lowBits. > + lowBits > 0 ifTrue: > + [long := long bitShift: lowBits * -8]. > + ^long bitAnd: 16rFF! > - ^(lowBits caseOf: { > - [0] -> [ long ]. > - [1] -> [ long bitShift: -8 ]. > - [2] -> [ long bitShift: -16 ]. > - [3] -> [ long bitShift: -24 ] > - }) bitAnd: 16rFF! > > Item was changed: > ----- Method: CoInterpreterStackPagesLSB>>byteAt:put: (in category 'memory access') ----- > byteAt: byteAddress put: byte > | lowBits long longAddress | > + self assert: (byte between: 0 and: 16rFF). > + lowBits := byteAddress bitAnd: objectMemory wordSize - 1. > - lowBits := byteAddress bitAnd: 3. > longAddress := byteAddress - lowBits. > long := self longAt: longAddress. > + long := (long bitOr: (16rFF bitShift: lowBits * 8)) bitXor: (byte bitXor: 16rFF). > - long := lowBits caseOf: { > - [0] -> [ (long bitAnd: 16rFFFFFF00) bitOr: byte ]. > - [1] -> [ (long bitAnd: 16rFFFF00FF) bitOr: (byte bitShift: 8) ]. > - [2] -> [ (long bitAnd: 16rFF00FFFF) bitOr: (byte bitShift: 16) ]. > - [3] -> [ (long bitAnd: 16r00FFFFFF) bitOr: (byte bitShift: 24) ] > - }. > - > self longAt: longAddress put: long. > ^byte! > > Item was changed: > VMStructType subclass: #CogStackPage > + instanceVariableNames: 'stackLimit headSP headFP baseFP baseAddress realStackLimit lastAddress trace padToWord nextPage prevPage' > - instanceVariableNames: 'stackLimit headSP headFP baseFP baseAddress realStackLimit lastAddress trace nextPage prevPage' > classVariableNames: '' > poolDictionaries: 'VMBasicConstants VMBytecodeConstants' > category: 'VMMaker-Interpreter'! > > !CogStackPage commentStamp: 'eem 8/14/2015 12:06' prior: 0! > I am a class that helps organize the StackInterpreter's collection of stack pages. I represent the control block for a single stack page in the collection of stack pages represented by an InterpreterStackPages or CoInterpreterStackPages instance.! > > Item was added: > + ----- Method: CogStackPage class>>getter:bitPosition:bitWidth:type: (in category 'code generation') ----- > + getter: getter bitPosition: bitPosition bitWidth: bitWidth type: typeOrNil > + ^String streamContents: > + [:s| | startByte endByte accessor | > + startByte := bitPosition // 8. > + endByte := bitPosition + bitWidth - 1 // 8. > + self assert: bitPosition \\ 8 = 0. > + self assert: startByte \\ (bitWidth // 8) = 0. > + accessor := #('byte' 'short' 'long' 'long') > + at: endByte - startByte + 1 > + ifAbsent: ['long64']. > + s nextPutAll: getter; crtab: 1; nextPut: $^. > + (typeOrNil notNil and: [typeOrNil last = $*]) ifTrue: > + [accessor := 'unsigned', (accessor copy > + at: 1 put: accessor first asUppercase; > + yourself)]. > + (typeOrNil notNil and: ['*StackPage*' match: typeOrNil]) ifTrue: > + [s nextPutAll: 'stackPages surrogateAtAddress: (']. > + s nextPutAll: 'memory '; > + nextPutAll: accessor; > + nextPutAll: 'At: address + '; print: startByte + 1. > + (typeOrNil notNil and: ['*StackPage*' match: typeOrNil]) ifTrue: > + [s nextPut: $)]] > + > + "| bitPosition | > + bitPosition := 0. > + (self fieldAccessorsForBytesPerWord: 4) collect: > + [:spec| > + bitPosition := bitPosition + spec second. > + self getter: spec first > + bitPosition: bitPosition - spec second > + bitWidth: spec second > + type: (spec at: 3 ifAbsent: [])]"! > > Item was changed: > ----- Method: CogStackPage class>>instVarNamesAndTypesForTranslationDo: (in category 'translation') ----- > instVarNamesAndTypesForTranslationDo: aBinaryBlock > "enumerate aBinaryBlock with the names and C type strings for the inst vars to include in a StackPage struct." > > self allInstVarNames do: > [:ivn| > + (ivn = 'padToWord' and: [BytesPerWord = 4]) ifFalse: > - ivn ~= 'stackPagesMemory' ifTrue: > [aBinaryBlock > value: ivn > + value: ((ivn = 'trace' or: [ivn = 'padToWord']) > - value: (ivn = 'trace' > ifTrue: [#int] > ifFalse: > [(ivn endsWith: 'Page') > ifTrue: ['struct _StackPage *'] > ifFalse: [#'char *']])]]! > > Item was added: > + ----- Method: CogStackPage class>>setter:bitPosition:bitWidth:type: (in category 'code generation') ----- > + setter: getter bitPosition: bitPosition bitWidth: bitWidth type: typeOrNil > + ^String streamContents: > + [:s| | startByte endByte accessor | > + startByte := bitPosition // 8. > + endByte := bitPosition + bitWidth - 1 // 8. > + self assert: bitPosition \\ 8 = 0. > + self assert: startByte \\ (bitWidth // 8) = 0. > + accessor := #('byte' 'short' 'long' 'long') > + at: endByte - startByte + 1 > + ifAbsent: ['long64']. > + s nextPutAll: getter; nextPutAll: ': aValue'; crtab: 1; > + nextPutAll: 'self assert: (address + '; print: startByte; > + nextPutAll: ' >= zoneBase and: [address + '; print: endByte; > + nextPutAll: ' < zoneLimit]).'; crtab: 1. > + (typeOrNil notNil and: [typeOrNil last = $*]) ifTrue: > + [accessor := 'unsigned', (accessor copy > + at: 1 put: accessor first asUppercase; > + yourself)]. > + (typeOrNil notNil and: ['*StackPage*' match: typeOrNil]) ifFalse: > + [s nextPut: $^]. > + s nextPutAll: 'memory '; > + nextPutAll: accessor; nextPutAll: 'At: address + '; print: startByte + 1; > + nextPutAll: ' put: aValue'. > + (typeOrNil notNil and: ['*StackPage*' match: typeOrNil]) ifTrue: > + [s nextPutAll: ' asInteger.'; crtab: 1; nextPutAll: '^aValue']] > + > + "| bitPosition | > + bitPosition := 0. > + (self fieldAccessorsForBytesPerWord: 4) collect: > + [:spec| > + bitPosition := bitPosition + spec second. > + self setter: spec first > + bitPosition: bitPosition - spec second > + bitWidth: spec second > + type: (spec at: 3 ifAbsent: [])]"! > > Item was changed: > + ----- Method: CogStackPageSurrogate32 class>>alignedByteSize (in category 'accessing') ----- > - ----- Method: CogStackPageSurrogate32 class>>alignedByteSize (in category 'instance creation') ----- > alignedByteSize > ^40! > > Item was changed: > ----- Method: CogStackPageSurrogate32>>nextPage: (in category 'accessing') ----- > nextPage: aValue > self assert: (address + 32 >= zoneBase and: [address + 35 < zoneLimit]). > + memory unsignedLongAt: address + 33 put: aValue asInteger. > + ^aValue! > - ^memory > - unsignedLongAt: address + 33 > - put: aValue asInteger! > > Item was added: > + ----- Method: CogStackPageSurrogate32>>padToWord (in category 'accessing') ----- > + padToWord > + ^memory longAt: address + 33! > > Item was added: > + ----- Method: CogStackPageSurrogate32>>padToWord: (in category 'accessing') ----- > + padToWord: aValue > + self assert: (address + 32 >= zoneBase and: [address + 35 < zoneLimit]). > + ^memory longAt: address + 33 put: aValue! > > Item was changed: > ----- Method: CogStackPageSurrogate32>>prevPage: (in category 'accessing') ----- > prevPage: aValue > self assert: (address + 36 >= zoneBase and: [address + 39 < zoneLimit]). > + memory unsignedLongAt: address + 37 put: aValue asInteger. > + ^aValue! > - ^memory > - unsignedLongAt: address + 37 > - put: aValue asInteger! > > Item was changed: > ----- Method: CogStackPageSurrogate32>>stackLimit: (in category 'accessing') ----- > stackLimit: aValue > + self assert: (address + 0 >= zoneBase and: [address + 3 < zoneLimit]). > + ^memory unsignedLongAt: address + 1 put: aValue! > - self assert: (address >= zoneBase and: [address + 3 < zoneLimit]). > - ^memory unsignedLongAt: address + 1 put: aValue signedIntToLong! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>baseAddress (in category 'accessing') ----- > baseAddress > + ^memory unsignedLong64At: address + 33! > - ^memory long64At: address + 33! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>baseAddress: (in category 'accessing') ----- > baseAddress: aValue > self assert: (address + 32 >= zoneBase and: [address + 39 < zoneLimit]). > + ^memory unsignedLong64At: address + 33 put: aValue! > - ^memory long64At: address + 33 put: aValue! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>baseFP (in category 'accessing') ----- > baseFP > + ^memory unsignedLong64At: address + 25! > - ^memory long64At: address + 25! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>baseFP: (in category 'accessing') ----- > baseFP: aValue > self assert: (address + 24 >= zoneBase and: [address + 31 < zoneLimit]). > + ^memory unsignedLong64At: address + 25 put: aValue! > - ^memory long64At: address + 25 put: aValue! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>headFP (in category 'accessing') ----- > headFP > + ^memory unsignedLong64At: address + 17! > - ^memory long64At: address + 17! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>headFP: (in category 'accessing') ----- > headFP: aValue > self assert: (address + 16 >= zoneBase and: [address + 23 < zoneLimit]). > + ^memory unsignedLong64At: address + 17 put: aValue! > - ^memory long64At: address + 17 put: aValue! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>headSP (in category 'accessing') ----- > headSP > + ^memory unsignedLong64At: address + 9! > - ^memory long64At: address + 9! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>headSP: (in category 'accessing') ----- > headSP: aValue > self assert: (address + 8 >= zoneBase and: [address + 15 < zoneLimit]). > + ^memory unsignedLong64At: address + 9 put: aValue! > - ^memory long64At: address + 9 put: aValue! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>lastAddress (in category 'accessing') ----- > lastAddress > + ^memory unsignedLong64At: address + 49! > - ^memory long64At: address + 49! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>lastAddress: (in category 'accessing') ----- > lastAddress: aValue > + self assert: (address + 48 >= zoneBase and: [address + 55 < zoneLimit]). > + ^memory unsignedLong64At: address + 49 put: aValue! > - self assert: (address + 48 >= zoneBase and: [address + 35 < zoneLimit]). > - ^memory long64At: address + 49 put: aValue! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>nextPage (in category 'accessing') ----- > nextPage > + ^stackPages surrogateAtAddress: (memory unsignedLong64At: address + 65)! > - ^stackPages surrogateAtAddress: (memory long64At: address + 65)! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>nextPage: (in category 'accessing') ----- > nextPage: aValue > self assert: (address + 64 >= zoneBase and: [address + 71 < zoneLimit]). > + memory unsignedLong64At: address + 65 put: aValue asInteger. > + ^aValue! > - ^memory > - long64At: address + 65 > - put: aValue asInteger! > > Item was added: > + ----- Method: CogStackPageSurrogate64>>padToWord (in category 'accessing') ----- > + padToWord > + ^memory long64At: address + 65! > > Item was added: > + ----- Method: CogStackPageSurrogate64>>padToWord: (in category 'accessing') ----- > + padToWord: aValue > + self assert: (address + 64 >= zoneBase and: [address + 71 < zoneLimit]). > + ^memory long64At: address + 65 put: aValue! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>prevPage (in category 'accessing') ----- > prevPage > + ^stackPages surrogateAtAddress: (memory unsignedLong64At: address + 73)! > - ^stackPages surrogateAtAddress: (memory long64At: address + 73)! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>prevPage: (in category 'accessing') ----- > prevPage: aValue > self assert: (address + 72 >= zoneBase and: [address + 79 < zoneLimit]). > + memory unsignedLong64At: address + 73 put: aValue asInteger. > + ^aValue! > - ^memory > - long64At: address + 73 > - put: aValue asInteger! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>realStackLimit (in category 'accessing') ----- > realStackLimit > + ^memory unsignedLong64At: address + 41! > - ^memory long64At: address + 41! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>realStackLimit: (in category 'accessing') ----- > realStackLimit: aValue > self assert: (address + 40 >= zoneBase and: [address + 47 < zoneLimit]). > + ^memory unsignedLong64At: address + 41 put: aValue! > - ^memory long64At: address + 41 put: aValue! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>stackLimit (in category 'accessing') ----- > stackLimit > + ^memory unsignedLong64At: address + 1! > - ^memory long64At: address + 1! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>stackLimit: (in category 'accessing') ----- > stackLimit: aValue > + self assert: (address + 0 >= zoneBase and: [address + 7 < zoneLimit]). > + ^memory unsignedLong64At: address + 1 put: aValue! > - self assert: (address >= zoneBase and: [address + 7 < zoneLimit]). > - ^memory long64At: address + 1 put: aValue! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>trace (in category 'accessing') ----- > trace > + ^memory long64At: address + 57! > - ^memory longAt: address + 57! > > Item was changed: > ----- Method: CogStackPageSurrogate64>>trace: (in category 'accessing') ----- > trace: aValue > + self assert: (address + 56 >= zoneBase and: [address + 63 < zoneLimit]). > + ^memory long64At: address + 57 put: aValue! > - self assert: (address + 56 >= zoneBase and: [address + 59 < zoneLimit]). > - ^memory longAt: address + 57 put: aValue! > > Item was changed: > ----- Method: CogVMSimulator>>ceSendFromInLineCacheMiss: (in category 'trampolines') ----- > ceSendFromInLineCacheMiss: oPIC > "Override to map the address into a CogMethodSurrogate" > | surrogate | > surrogate := oPIC isInteger > ifTrue: [cogit cogMethodSurrogateAt: oPIC] > ifFalse: [oPIC]. > self logSend: surrogate selector. > + (surrogate cmNumArgs = 0 > + and: [(self stackValue: 1) = 16r8169D0 > + and: [self stackTop = 16r53EA7]]) ifTrue: > + [self halt]. > ^super ceSendFromInLineCacheMiss: surrogate! > > Item was changed: > ----- Method: CogVMSimulator>>moveMethodCacheToMemoryAt: (in category 'initialization') ----- > moveMethodCacheToMemoryAt: address > | oldMethodCache | > oldMethodCache := methodCache. > - self flag: 'broken for 64-bit VM because Bitmap access unit is 32-bits'. > "In the VM the methodCache is written as a normal array with 1-relative addressing. > In C this works by allocating an extra element in the methodCache array (see > class-side declareCVarsIn:). In simulation simply position the start of the methodCache > one word lower, achieving the same effect. -1 because CArrayAccessor is 0-relative > and adds 1 on accesses itself." > methodCache := CMethodCacheAccessor new > + objectMemory: objectMemory > + at: address > - memory: objectMemory memory > - offset: address / objectMemory wordSize > array: oldMethodCache > functionPointerIndex: MethodCachePrimFunction > entrySize: MethodCacheEntrySize. > + self assert: address - objectMemory wordSize = self methodCacheAddress. > 1 to: MethodCacheSize do: > [:i| > self assert: (methodCache at: i) = 0]. > methodCache at: 1 put: 16rC4EC4. > + self assert: (objectMemory longAt: address) = 16rC4EC4. > - self assert: (self longAt: address) = 16rC4EC4. > 1 to: MethodCacheSize do: > [:i| > methodCache at: i put: (oldMethodCache at: i)]! > > Item was changed: > ----- Method: CogVMSimulator>>movePrimTraceLogToMemoryAt: (in category 'initialization') ----- > movePrimTraceLogToMemoryAt: address > | oldTraceLog | > oldTraceLog := primTraceLog. > + primTraceLog := CArrayOfLongsAccessor new > + objectMemory: objectMemory at: address. > + self assert: address = self primTraceLogAddress. > - self flag: 'broken for 64-bit VM because Bitmap access unit is 32-bits'. > - primTraceLog := CObjectAccessor new > - memory: objectMemory memory > - offset: address / objectMemory wordSize. > 0 to: PrimTraceLogSize - 1 do: > [:i| > self assert: (primTraceLog at: i) = 0]. > primTraceLog at: 0 put: 16rC4EC4. > + self assert: (objectMemory longAt: address) = 16rC4EC4. > - self assert: (self longAt: address) = 16rC4EC4. > 0 to: PrimTraceLogSize - 1 do: > [:i| > primTraceLog at: i put: (oldTraceLog at: i)]! > > Item was changed: > ----- Method: Cogit>>cCoerceSimple:to: (in category 'translation support') ----- > cCoerceSimple: value to: cTypeString > <doNotGenerate> > + cTypeString last == $* ifTrue: > + [cTypeString == #'CogMethod *' ifTrue: > + [^(value isInteger and: [value < 0]) > + ifTrue: [value] "it's an error code; leave it be" > + ifFalse: [self cogMethodSurrogateAt: value asUnsignedInteger]]. > + cTypeString == #'CogBlockMethod *' ifTrue: > + [^self cogBlockMethodSurrogateAt: value asUnsignedInteger]. > + cTypeString == #'NSSendCache *' ifTrue: > + [^self nsSendCacheSurrogateAt: value asUnsignedInteger]. > + (cTypeString == #'AbstractInstruction *' > + and: [value isBehavior]) ifTrue: > + [^CogCompilerClass]. > + cTypeString == #'StackPage *' ifTrue: > + [^coInterpreter stackPages surrogateAtAddress: value]]. > - cTypeString == #'CogMethod *' ifTrue: > - [^(value isInteger and: [value < 0]) > - ifTrue: [value] "it's an error code; leave it be" > - ifFalse: [self cogMethodSurrogateAt: value asUnsignedInteger]]. > - cTypeString == #'CogBlockMethod *' ifTrue: > - [^self cogBlockMethodSurrogateAt: value asUnsignedInteger]. > - cTypeString == #'NSSendCache *' ifTrue: > - [^self nsSendCacheSurrogateAt: value asUnsignedInteger]. > - (cTypeString == #'AbstractInstruction *' > - and: [value isBehavior]) ifTrue: > - [^CogCompilerClass]. > ^super cCoerceSimple: value to: cTypeString! > > Item was added: > + ----- Method: Integer>>signedIntFromChar (in category '*VMMaker-interpreter simulator') ----- > + signedIntFromChar > + "Self is an unsigned 8-bit integer in twos-comp form" > + > + | shortBits | > + shortBits := self bitAnd: 16rFF. > + ^(self bitAnd: 16r80) "sign bit" = 0 > + ifTrue: [shortBits] > + ifFalse: [shortBits - 16r100]! > > Item was changed: > ----- Method: Integer>>signedIntFromLong (in category '*VMMaker-interpreter simulator') ----- > signedIntFromLong > "Self is a signed or unsigned 32-bit integer" > > + | bits | > + (self >= -1073741824 and: [self <= 1073741823]) ifTrue: "These are known to be SmallIntegers..." > + [^self]. > + bits := self bitAnd: 16rFFFFFFFF. > + (bits digitAt: 4) <= 16r7F ifTrue: [^bits]. > + ^bits - 16r100000000! > - | sign | > - self < 0 ifTrue: [^self]. > - sign := self bitAnd: 16r80000000. > - sign = 0 ifTrue: [^ self]. > - ^ self - sign - sign! > > Item was changed: > ----- Method: Integer>>signedIntFromLong64 (in category '*VMMaker-interpreter simulator') ----- > signedIntFromLong64 > "Self is a signed or unsigned 64-bit integer" > > + | bits | > + "This case is handled by the SmallInteger subclass..." > + "(self >= -1073741824 and: [self <= 1073741823]) ifTrue: > + [^self]." > + bits := self bitAnd: 16rFFFFFFFFFFFFFFFF. > + (bits digitAt: 8) <= 16r7F ifTrue: [^bits]. > + ^bits - 16r10000000000000000! > - | sign | > - self < 0 ifTrue: [^self]. > - sign := self bitAnd: 16r8000000000000000. > - sign = 0 ifTrue: [^self]. > - ^self - sign - sign! > > Item was added: > + ----- Method: Integer>>signedIntToChar (in category '*VMMaker-interpreter simulator') ----- > + signedIntToChar > + "Produces an 8-bit value in twos-comp form. Truncates if out-of-range as per a C cast" > + > + ^self bitAnd: 16rFF! > > Item was changed: > ----- Method: Integer>>signedIntToLong (in category '*VMMaker-interpreter simulator') ----- > signedIntToLong > + "Produces a 32-bit value in twos-comp form. Truncates if out-of-range as per a C cast" > - "Produces a 32-bit value in twos-comp form. Sorry no error checking" > > + ^self bitAnd: 16rFFFFFFFF! > - self >= 0 > - ifTrue: [^ self] > - ifFalse: [^ self + 16r80000000 + 16r80000000] > - ! > > Item was changed: > ----- Method: Integer>>signedIntToLong64 (in category '*VMMaker-interpreter simulator') ----- > signedIntToLong64 > + "Produces a 64-bit value in twos-comp form. Truncates if out-of-range as per a C cast" > - "Produces a 64-bit value in twos-comp form. Sorry no error checking" > > + ^self bitAnd: 16rFFFFFFFFFFFFFFFF! > - self >= 0 > - ifTrue: [^ self] > - ifFalse: [^ self + 16r8000000000000000 + 16r8000000000000000] > - ! > > Item was changed: > ----- Method: Integer>>signedIntToShort (in category '*VMMaker-interpreter simulator') ----- > signedIntToShort > + "Produces a 16-bit value in twos-comp form. Truncates if out-of-range as per a C cast" > - "Produces a 16-bit value (0-65k) in twos-comp form. Sorry no error checking" > > ^self bitAnd: 16rFFFF! > > Item was added: > + ----- Method: SmallInteger>>signedIntFromLong64 (in category '*VMMaker-interpreter simulator') ----- > + signedIntFromLong64 > + "Self is a signed or unsigned 64-bit integer. > + Currently SmallIntegers are either 31-bit (in the 32-bit implementation) or 61-bit > + (in the 64-bit implementation) so save some time by overriding in the subclass." > + ^self! > > Item was added: > + ----- Method: VMClass class>>openCogTestsMultiWindowBrowser (in category 'utilities') ----- > + openCogTestsMultiWindowBrowser > + "Answer a new multi-window browser on the test classes in VMMaker" > + "self openCogTestsMultiWindowBrowser" > + | testClasses b | > + testClasses := (PackageInfo named: 'VMMaker') classes select: [:c| c inheritsFrom: TestCase]. > + testClasses removeAll: AbstractInstructionTests allSubclasses. > + testClasses removeAll: (testClasses select: [:c| '*Plugin*' match: c name]). > + b := Browser open. > + testClasses do: > + [:class| b selectCategoryForClass: class; selectClass: class] > + separatedBy: > + [b multiWindowState addNewWindow]. > + b multiWindowState selectWindowIndex: 1! > > Item was added: > + ----- Method: VMClass class>>openCogitMultiWindowBrowser (in category 'utilities') ----- > + openCogitMultiWindowBrowser > + "Answer a new multi-window browser on the ObjectMemory classes, the Cog Interpreter classes, and the main JIT classes" > + "self openCogitMultiWindowBrowser" > + | b | > + b := Browser open. > + Cogit withAllSubclasses, > + CogObjectRepresentation withAllSubclasses, > + {CogMethodZone. CogRTLOpcodes }, > + (CogAbstractInstruction withAllSubclasses reject: [:c| c name endsWith: 'Tests']), > + {VMStructType. VMMaker. CCodeGenerator. TMethod} > + do: [:class| > + b selectCategoryForClass: class; selectClass: class] > + separatedBy: > + [b multiWindowState addNewWindow]. > + b multiWindowState selectWindowIndex: 1! > > Item was added: > + TestCase subclass: #VMMakerIntegerTests > + instanceVariableNames: '' > + classVariableNames: '' > + poolDictionaries: '' > + category: 'VMMaker-Tests'! > > Item was added: > + ----- Method: VMMakerIntegerTests>>testSignedIntFromFoo (in category 'tests') ----- > + testSignedIntFromFoo > + self assert: 16r55 signedIntFromChar equals: 16r55. > + self assert: 16r155 signedIntFromChar equals: 16r55. > + self assert: 16rAA signedIntFromChar < 0. > + self assert: (16rAA signedIntFromChar bitAnd: 16rFF) = 16rAA. > + > + self assert: 16r5555 signedIntFromShort equals: 16r5555. > + self assert: 16r15555 signedIntFromShort equals: 16r5555. > + self assert: 16rAAAA signedIntFromShort < 0. > + self assert: (16rAAAA signedIntFromShort bitAnd: 16rFFFF) = 16rAAAA. > + > + self assert: 16r55555555 signedIntFromLong equals: 16r55555555. > + self assert: 16r155555555 signedIntFromLong equals: 16r55555555. > + self assert: 16rAAAAAAAA signedIntFromLong< 0. > + self assert: (16rAAAAAAAA signedIntFromLong bitAnd: 16rFFFFFFFF) = 16rAAAAAAAA. > + > + self assert: 16r5555555555555555 signedIntFromLong64 equals: 16r5555555555555555. > + self assert: 16r15555555555555555 signedIntFromLong64 equals: 16r5555555555555555. > + self assert: 16rAAAAAAAAAAAAAAAA signedIntFromLong64< 0. > + self assert: (16rAAAAAAAAAAAAAAAA signedIntFromLong64 bitAnd: 16rFFFFFFFFFFFFFFFF) = 16rAAAAAAAAAAAAAAAA! > > Item was added: > + ----- Method: VMMakerIntegerTests>>testSignedIntToFoo (in category 'tests') ----- > + testSignedIntToFoo > + #(16r55 -16r56 16r5555 -16r5556 16r55555555 -16r55555556 16r5555555555555555 -16r5555555555555556) do: > + [:n| > + n abs digitLength = 1 ifTrue: > + [self assert: n signedIntToChar signedIntFromChar equals: n]. > + self assert: (n signedIntToChar signedIntFromChar bitAnd: 16rFF) equals: (n bitAnd: 16rFF). > + n abs digitLength <= 2 ifTrue: > + [self assert: n signedIntToShort signedIntFromShort equals: n]. > + self assert: (n signedIntToShort signedIntFromShort bitAnd: 16rFFFF) equals: (n bitAnd: 16rFFFF). > + n abs digitLength <= 4 ifTrue: > + [self assert: n signedIntToLong signedIntFromLong equals: n]. > + self assert: (n signedIntToLong signedIntFromLong bitAnd: 16rFFFFFFFF) equals: (n bitAnd: 16rFFFFFFFF). > + n abs digitLength <= 8 ifTrue: > + [self assert: n signedIntToLong64 signedIntFromLong64 equals: n]. > + self assert: (n signedIntToLong64 signedIntFromLong64 bitAnd: 16rFFFFFFFFFFFFFFFF) equals: (n bitAnd: 16rFFFFFFFFFFFFFFFF)]! >

4 9

[commit][3479] JMM - adjustments to archive, also alter app bundle identifier to say what we are actually building
by commits＠squeakvm.org 22 Oct '15

22 Oct '15

Revision: 3479 Author: johnmci Date: 2015-10-21 16:18:32 -0700 (Wed, 21 Oct 2015) Log Message: ----------- JMM - adjustments to archive, also alter app bundle identifier to say what we are actually building Modified Paths: -------------- branches/Cog/build.macos32x86/squeak.cog.spur/SqueakCogSpur32x86.plist branches/Cog/build.macos32x86/squeak.cog.spur/SqueakCogSpur32x86.xcodeproj/project.pbxproj branches/Cog/build.macos32x86/squeak.cog.spur/SqueakCogSpur32x86.xcworkspace/xcuserdata/johnmci.xcuserdatad/UserInterfaceState.xcuserstate Modified: branches/Cog/build.macos32x86/squeak.cog.spur/SqueakCogSpur32x86.plist =================================================================== --- branches/Cog/build.macos32x86/squeak.cog.spur/SqueakCogSpur32x86.plist 2015-10-20 22:39:11 UTC (rev 3478) +++ branches/Cog/build.macos32x86/squeak.cog.spur/SqueakCogSpur32x86.plist 2015-10-21 23:18:32 UTC (rev 3479) @@ -2,20 +2,6 @@ <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> <plist version="1.0"> <dict> - <key>Fabric</key> - <dict> - <key>APIKey</key> - <string>add501476623fc20212a60334cd537d16dfd566f</string> - <key>Kits</key> - <array> - <dict> - <key>KitInfo</key> - <dict/> - <key>KitName</key> - <string>Crashlytics</string> - </dict> - </array> - </dict> <key>CFBundleDevelopmentRegion</key> <string>English</string> <key>CFBundleDocumentTypes</key> @@ -382,7 +368,7 @@ <key>CFBundleGetInfoString</key> <string>Squeak Cog Spur http://www.mirandabanda.org</string> <key>CFBundleIdentifier</key> - <string>org.squeak.osx6464.cog</string> + <string>$(PRODUCT_BUNDLE_IDENTIFIER)</string> <key>CFBundleInfoDictionaryVersion</key> <string>6.0</string> <key>CFBundleName</key> @@ -394,13 +380,31 @@ <key>CFBundleSignature</key> <string>????</string> <key>CFBundleVersion</key> - <string>6</string> + <string>7</string> + <key>Fabric</key> + <dict> + <key>APIKey</key> + <string>add501476623fc20212a60334cd537d16dfd566f</string> + <key>Kits</key> + <array> + <dict> + <key>KitInfo</key> + <dict/> + <key>KitName</key> + <string>Crashlytics</string> + </dict> + </array> + </dict> <key>LSApplicationCategoryType</key> <string>public.app-category.developer-tools</string> <key>LSBackgroundOnly</key> <false/> <key>LSMinimumSystemVersion</key> <string>${MACOSX_DEPLOYMENT_TARGET}</string> + <key>NSMainNibFile</key> + <string>MainMenu</string> + <key>NSPrincipalClass</key> + <string>SqueakOSXApplication</string> <key>SqueakBrowserMouseCmdButton1</key> <integer>3</integer> <key>SqueakBrowserMouseCmdButton2</key> @@ -465,6 +469,12 @@ <integer>2</integer> <key>SqueakPluginsBuiltInOrLocalOnly</key> <false/> + <key>SqueakResourceDirectory</key> + <string></string> + <key>SqueakTrustedDirectory</key> + <string>/foobar/tooBar/forSqueak/bogus/</string> + <key>SqueakUIFadeForFullScreenInSeconds</key> + <real>0.5</real> <key>SqueakUIFlushPrimaryDeferNMilliseconds</key> <integer>20</integer> <key>SqueakUIFlushSecondaryCheckForPossibleNeedEveryNMilliseconds</key> @@ -475,24 +485,16 @@ <true/> <key>SqueakUnTrustedDirectory</key> <string>~/Library/Preferences/Squeak/Internet/Untrusted/</string> + <key>SqueakUseFileMappedMMAP</key> + <false/> <key>SqueakWindowAttribute</key> - <data>ggAAHw==</data> + <data> + ggAAHw== + </data> <key>SqueakWindowHasTitle</key> <true/> <key>SqueakWindowType</key> <integer>6</integer> - <key>SqueakResourceDirectory</key> - <string></string> - <key>SqueakTrustedDirectory</key> - <string>/foobar/tooBar/forSqueak/bogus/</string> - <key>NSMainNibFile</key> - <string>MainMenu</string> - <key>NSPrincipalClass</key> - <string>SqueakOSXApplication</string> - <key>SqueakUseFileMappedMMAP</key> - <false/> - <key>SqueakUIFadeForFullScreenInSeconds</key> - <real>0.5</real> <key>UTExportedTypeDeclarations</key> <array> <dict> Modified: branches/Cog/build.macos32x86/squeak.cog.spur/SqueakCogSpur32x86.xcodeproj/project.pbxproj =================================================================== --- branches/Cog/build.macos32x86/squeak.cog.spur/SqueakCogSpur32x86.xcodeproj/project.pbxproj 2015-10-20 22:39:11 UTC (rev 3478) +++ branches/Cog/build.macos32x86/squeak.cog.spur/SqueakCogSpur32x86.xcodeproj/project.pbxproj 2015-10-21 23:18:32 UTC (rev 3479) @@ -1844,7 +1844,6 @@ ARCHS = "$(ARCHS_STANDARD_32_BIT)"; CLANG_ANALYZER_SECURITY_INSECUREAPI_RAND = YES; CLANG_ANALYZER_SECURITY_INSECUREAPI_STRCPY = YES; - "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = ""; DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym"; GCC_C_LANGUAGE_STANDARD = "compiler-default"; GCC_PREPROCESSOR_DEFINITIONS = SQUEAK_BUILTIN_PLUGIN; @@ -1852,7 +1851,6 @@ GCC_WARN_UNUSED_VARIABLE = YES; HEADER_SEARCH_PATHS = /usr/include/uuid; MACOSX_DEPLOYMENT_TARGET = 10.6; - "PROVISIONING_PROFILE[sdk=iphoneos*]" = "65867c1c-f0f6-4de4-84cd-3e77826cb368"; SEPARATE_STRIP = YES; }; name = Distribution; @@ -1864,7 +1862,7 @@ ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; CLANG_ENABLE_OBJC_ARC = NO; CLANG_USE_OPTIMIZATION_PROFILE = NO; - CODE_SIGN_IDENTITY = ""; + CODE_SIGN_IDENTITY = "Developer ID Application"; COMBINE_HIDPI_IMAGES = YES; FRAMEWORK_SEARCH_PATHS = ( "$(inherited)", @@ -1886,8 +1884,9 @@ LD_GENERATE_MAP_FILE = YES; MACOSX_DEPLOYMENT_TARGET = 10.6; OTHER_CFLAGS = ""; - PRODUCT_BUNDLE_IDENTIFIER = com.squeak.cog.spur; + PRODUCT_BUNDLE_IDENTIFIER = org.squeak.osx3286.cog; PRODUCT_NAME = Squeak; + PROVISIONING_PROFILE = "a81f3cd0-20de-4e0b-b7a8-a98bcd57ec0c"; }; name = Debug; }; @@ -1899,7 +1898,6 @@ CLANG_ENABLE_OBJC_ARC = NO; CLANG_USE_OPTIMIZATION_PROFILE = NO; CODE_SIGN_IDENTITY = "Developer ID Application"; - "CODE_SIGN_IDENTITY[sdk=macosx*]" = "iPhone Distribution: Corporate Smalltalk Consulting Ltd (DTYH6QWG79)"; COMBINE_HIDPI_IMAGES = YES; FRAMEWORK_SEARCH_PATHS = ( "$(inherited)", @@ -1920,9 +1918,9 @@ LD_GENERATE_MAP_FILE = YES; MACOSX_DEPLOYMENT_TARGET = 10.6; OTHER_CFLAGS = ""; - PRODUCT_BUNDLE_IDENTIFIER = com.squeak.cog.spur; + PRODUCT_BUNDLE_IDENTIFIER = org.squeak.osx3286.cog; PRODUCT_NAME = Squeak; - "PROVISIONING_PROFILE[sdk=macosx*]" = "3a8c5546-20a8-40a9-afb4-4218872c980c"; + PROVISIONING_PROFILE = "a9c24a26-f48b-45e4-ab61-12d8c233f0fa"; }; name = Distribution; }; Modified: branches/Cog/build.macos32x86/squeak.cog.spur/SqueakCogSpur32x86.xcworkspace/xcuserdata/johnmci.xcuserdatad/UserInterfaceState.xcuserstate =================================================================== (Binary files differ)

1 0

Re: [Vm-dev] VM Maker: VMMaker.oscog-eem.1497.mcz
by Nicolas Cellier 22 Oct '15

22 Oct '15

2015-10-21 1:07 GMT+02:00 <commits(a)source.squeak.org>: > > Eliot Miranda uploaded a new version of VMMaker to project VM Maker: > http://source.squeak.org/VMMaker/VMMaker.oscog-eem.1497.mcz > > ==================== Summary ==================== > > Name: VMMaker.oscog-eem.1497 > Author: eem > Time: 20 October 2015, 4:07:03.853 pm > UUID: 0719f4d7-3dd5-4f5c-bc36-07461475c215 > Ancestors: VMMaker.oscog-eem.1496 > > Make sure signed comparisons are used in the relevamt isIntegerValue: > implementations. > > =============== Diff against VMMaker.oscog-eem.1496 =============== > > Item was changed: > ----- Method: ObjectMemory>>isIntegerValue: (in category 'interpreter > access') ----- > isIntegerValue: intValue > "Answer if the given value can be represented as a Smalltalk > integer value. > In C, use a shift and XOR to set the sign bit if and only if the > top two bits of the given > value are the same, then test the sign bit. Note that the top two > bits are equal for > exactly those integers in the range that can be represented in > 31-bits or 63-bits." > <api> > ^self > + cCode: [(intValue bitXor: (intValue << 1)) asInteger >= 0] > - cCode: [(intValue bitXor: (intValue << 1)) >= 0] > inSmalltalk: [intValue >= 16r-40000000 and: [intValue <= > 16r3FFFFFFF]]! > > To be even more pedantic and warnig free, this is what I have since March: ^self cCode: [(intValue asUnsignedInteger bitXor: (intValue asUnsignedInteger << 1)) asInteger >= 0] inSmalltalk: [intValue >= self minSmallInteger and: [intValue <= self maxSmallInteger]] > Item was changed: > ----- Method: Spur32BitMemoryManager>>isIntegerValue: (in category > 'interpreter access') ----- > isIntegerValue: intValue > "Answer if the given value can be represented as a Smalltalk > integer value. > In C, use a shift and XOR to set the sign bit if and only if the > top two bits of the given > value are the same, then test the sign bit. Note that the top two > bits are equal for > exactly those integers in the range that can be represented in > 31-bits or 63-bits." > <api> > ^self > + cCode: [(intValue bitXor: (intValue << 1)) asInteger >= 0] > - cCode: [(intValue bitXor: (intValue << 1)) >= 0] > inSmalltalk: [intValue >= 16r-40000000 and: [intValue <= > 16r3FFFFFFF]]! > >

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev October 2015