Vm-dev December 2017

vm-dev@lists.squeakfoundation.org

22 participants
79 discussions

[OpenSmalltalk/opensmalltalk-vm] b183fd: Further simplify .travis.yml.
by GitHub 17 Dec '17

17 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: b183fd4d3eee8d01d05c4f5d3289bebcab6d0e58 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b183fd4d3eee8d01d0… Author: Fabio Niephaus <code(a)fniephaus.com> Date: 2017-12-17 (Sun, 17 Dec 2017) Changed paths: M .travis.yml Log Message: ----------- Further simplify .travis.yml. Also, add IP address to SSH known hosts instead of domain (#160).

1 0

[OpenSmalltalk/opensmalltalk-vm] dd2960: Build VMs in different stages.
by GitHub 17 Dec '17

17 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: dd29608d83cab8fcf8ee3b994b32443aa86b60a1 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/dd29608d83cab8fcf8… Author: Fabio Niephaus <code(a)fniephaus.com> Date: 2017-12-17 (Sun, 17 Dec 2017) Changed paths: M .travis.yml Log Message: ----------- Build VMs in different stages. This way, we reduce the load on the build pipeline. If one stage fails, the next stage is not build. Build stages docs: https://docs.travis-ci.com/user/build-stages Also, use an alias for Pharo deployment step and add Pharo file server to SSH known hosts (should fix #160)

1 0

[OpenSmalltalk/opensmalltalk-vm] 8fb0bf: CogVm source as per VMMaker.oscog-eem.2295
by GitHub 14 Dec '17

14 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 8fb0bf01caec6c308da830ec5862e5f77abd095e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8fb0bf01caec6c308d… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-14 (Thu, 14 Dec 2017) Changed paths: M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c Log Message: ----------- CogVm source as per VMMaker.oscog-eem.2295 Spur Image Segments: The short cut in ensureNoNewObjectsIn: was wrong. Best not take any short cuts here at all.

1 0

VM Maker: VMMaker.oscog-eem.2295.mcz
by commits＠source.squeak.org 14 Dec '17

14 Dec '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2295.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2295 Author: eem Time: 14 December 2017, 12:46:34.493554 pm UUID: de695ed3-1ddf-4936-a415-aa207ab3605d Ancestors: VMMaker.oscog-eem.2294 Spur Image Segments: The short cut in ensureNoNewObjectsIn: was wrong. Best not take any short cuts here at all. =============== Diff against VMMaker.oscog-eem.2294 =============== Item was changed: - SystemOrganization addCategory: #VMMaker! SystemOrganization addCategory: #'VMMaker-Building'! SystemOrganization addCategory: #'VMMaker-Interpreter'! SystemOrganization addCategory: #'VMMaker-InterpreterSimulation'! SystemOrganization addCategory: #'VMMaker-InterpreterSimulation-Morphic'! SystemOrganization addCategory: #'VMMaker-JIT'! SystemOrganization addCategory: #'VMMaker-JITSimulation'! SystemOrganization addCategory: #'VMMaker-Multithreading'! SystemOrganization addCategory: #'VMMaker-Plugins'! SystemOrganization addCategory: #'VMMaker-Plugins-FFI'! SystemOrganization addCategory: #'VMMaker-Plugins-IOS'! SystemOrganization addCategory: #'VMMaker-PostProcessing'! SystemOrganization addCategory: #'VMMaker-SmartSyntaxPlugins'! SystemOrganization addCategory: #'VMMaker-SpurMemoryManager'! SystemOrganization addCategory: #'VMMaker-SpurMemoryManagerSimulation'! SystemOrganization addCategory: #'VMMaker-Support'! SystemOrganization addCategory: #'VMMaker-Tests'! SystemOrganization addCategory: #'VMMaker-Translation to C'! Item was changed: ----- Method: SpurMemoryManager>>ensureNoNewObjectsIn: (in category 'image segment in/out') ----- ensureNoNewObjectsIn: outPointerArray "This is part of loadImageSegmentFrom:outPointers:. + Since the remembered bit is currently used to identify classes in the segment, setting remembered bits - Since the reembered bit is currently used to identify classes in the segment, setting remembered bits in new objects in the segment is difficult. Instead simply arrange that there are no new objects in outPointerArray, obviating the need to remember any of the loaded objects in the segment." | scanClassTable | - (self isRemembered: outPointerArray) ifFalse: [^0]. scanClassTable := false. 0 to: (self numSlotsOf: outPointerArray) - 1 do: [:i| | oop clone hash | oop := self fetchPointer: i ofObject: outPointerArray. (self isYoung: oop) ifTrue: [clone := self cloneInOldSpace: oop forPinning: false. clone = 0 ifTrue: [^PrimErrNoMemory halt]. ((hash := self rawHashBitsOf: oop) ~= 0 and: [(self classOrNilAtIndex: hash) = oop]) ifTrue: [scanClassTable := true]. self forward: oop to: clone. self storePointerUnchecked: i ofObject: outPointerArray withValue: clone]]. - scavenger forgetObject: outPointerArray. scanClassTable ifTrue: [self postBecomeScanClassTable: BecamePointerObjectFlag]. ^0!

1 0

[OpenSmalltalk/opensmalltalk-vm] ee8a0d: Add a reminder to the gitci script to check for in...
by GitHub 12 Dec '17

12 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: ee8a0df488d0a326e2c8e06c0796d8a3b07f2362 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ee8a0df488d0a326e2… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-12 (Tue, 12 Dec 2017) Changed paths: M scripts/gitci Log Message: ----------- Add a reminder to the gitci script to check for incoming before committing.

1 0

[OpenSmalltalk/opensmalltalk-vm] 1d0047: CogVM source as per VMMaker.oscog-eem.2294
by GitHub 12 Dec '17

12 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 1d00475b1eb288f3ef079e81c0ad9f64e463acab https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1d00475b1eb288f3ef… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-12 (Tue, 12 Dec 2017) Changed paths: M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2294 Spur Image Segments: Fix objectsReachableFromRoots: which was computing a transitive closure that could include duplicates. Fix ifAProxy:updateCopy: to fill the fields beyond the stack pointer of single contexts. Refactor to nuke the unused argument in copyObj:toAddr:[startAt:]stopAt:savedFirstFields:index: Fix a comment typo and add a counter through the arrayOfObjects/objects copied to segment, for debugging.

1 0

VM Maker: VMMaker.oscog-eem.2294.mcz
by commits＠source.squeak.org 12 Dec '17

12 Dec '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2294.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2294 Author: eem Time: 12 December 2017, 11:38:23.481307 am UUID: 99a04f27-cda6-4cc2-a5ff-a96e116a63d4 Ancestors: VMMaker.oscog-eem.2293 Spur Image Segments: Fix objectsReachableFromRoots: which was computing a transitive closure that could include duplicates. Fix ifAProxy:updateCopy: to fill the fields beyond the stack pointer of single contexts. Refactor to nuke the unused argument in copyObj:toAddr:[startAt:]stopAt:savedFirstFields:index: Fix a comment typo and add a counter throuhh the arrayOfObjects/objects copied to segment, for debugging. Add the CoInterpreter simulation only versions of mapOopsFrom:to:outPointers:outHashes:. =============== Diff against VMMaker.oscog-eem.2293 =============== Item was added: + ----- Method: Spur32BitMMLECoSimulator>>mapOopsFrom:to:outPointers:outHashes: (in category 'image segment in/out') ----- + mapOopsFrom: segStart to: segAddr outPointers: outPointerArray outHashes: savedOutHashes + self leakCheckImageSegments ifTrue: + [self halt]. + ^super mapOopsFrom: segStart to: segAddr outPointers: outPointerArray outHashes: savedOutHashes! Item was added: + ----- Method: Spur64BitMMLECoSimulator>>mapOopsFrom:to:outPointers:outHashes: (in category 'image segment in/out') ----- + mapOopsFrom: segStart to: segAddr outPointers: outPointerArray outHashes: savedOutHashes + self leakCheckImageSegments ifTrue: + [self halt]. + ^super mapOopsFrom: segStart to: segAddr outPointers: outPointerArray outHashes: savedOutHashes! Item was removed: - ----- Method: SpurMemoryManager>>copyObj:toAddr:startAt:stopAt:savedFirstFields:index: (in category 'image segment in/out') ----- - copyObj: objOop toAddr: segAddr startAt: segStart stopAt: endSeg savedFirstFields: savedFirstFields index: i - "This is part of storeImageSegmentInto:outPointers:roots:. - Copy objOop into the segment beginning at segAddr, and forward it to the copy, - saving its first field in savedFirstField, and setting its marked bit to indicate it has - been copied. If it is a class in the class table, set the copy's hash to 0 for reassignment - on load, and mark it as a class by setting its isRemembered bit. - Answer the next segmentAddr if successful. Answer an appropriate error code if not" - - "Copy the object..." - | bodySize copy hash | - <inline: false> - self deny: (self isCopiedIntoSegment: objOop). - bodySize := self bytesInObject: objOop. - (self oop: segAddr + bodySize isGreaterThanOrEqualTo: endSeg) ifTrue: - [^PrimErrWritePastObject halt]. - self mem: segAddr asVoidPointer cp: (self startOfObject: objOop) asVoidPointer y: bodySize. - copy := self objectStartingAt: segAddr. - - "Clear remembered, mark bits of all headers copied into the segment (except classes)" - self - setIsRememberedOf: copy to: false; - setIsMarkedOf: copy to: false. - - "Make any objects with hidden dynamic state (contexts, methods) look like normal objects." - self ifAProxy: objOop updateCopy: copy. - - "If the object is a class, zero its identityHash (which is its classIndex) and set its - isRemembered bit. It will be assigned a new hash and entered into the table on load." - hash := self rawHashBitsOf: objOop. - (hash > self lastClassIndexPun and: [(self classOrNilAtIndex: hash) = objOop]) ifTrue: - [self setHashBitsOf: copy to: 0. - self setIsRememberedOf: copy to: true]. - - "Now forward the object to its copy in the segment." - self storePointerUnchecked: i ofObject: savedFirstFields withValue: (self fetchPointer: 0 ofObject: objOop); - storePointerUnchecked: 0 ofObject: objOop withValue: copy; - markAsCopiedIntoSegment: objOop. - - "Answer the new end of segment" - ^segAddr + bodySize! Item was added: + ----- Method: SpurMemoryManager>>copyObj:toAddr:stopAt:savedFirstFields:index: (in category 'image segment in/out') ----- + copyObj: objOop toAddr: segAddr stopAt: endSeg savedFirstFields: savedFirstFields index: i + "This is part of storeImageSegmentInto:outPointers:roots:. + Copy objOop into the segment beginning at segAddr, and forward it to the copy, + saving its first field in savedFirstField, and setting its marked bit to indicate it has + been copied. If it is a class in the class table, set the copy's hash to 0 for reassignment + on load, and mark it as a class by setting its isRemembered bit. + Answer the next segmentAddr if successful. Answer an appropriate error code if not" + + "Copy the object..." + | bodySize copy hash | + <inline: false> + self deny: (self isCopiedIntoSegment: objOop). + bodySize := self bytesInObject: objOop. + (self oop: segAddr + bodySize isGreaterThanOrEqualTo: endSeg) ifTrue: + [^PrimErrWritePastObject halt]. + self mem: segAddr asVoidPointer cp: (self startOfObject: objOop) asVoidPointer y: bodySize. + copy := self objectStartingAt: segAddr. + + "Clear remembered, mark bits of all headers copied into the segment (except classes)" + self + setIsRememberedOf: copy to: false; + setIsMarkedOf: copy to: false. + + "Make any objects with hidden dynamic state (contexts, methods) look like normal objects." + self ifAProxy: objOop updateCopy: copy. + + "If the object is a class, zero its identityHash (which is its classIndex) and set its + isRemembered bit. It will be assigned a new hash and entered into the table on load." + hash := self rawHashBitsOf: objOop. + (hash > self lastClassIndexPun and: [(self classOrNilAtIndex: hash) = objOop]) ifTrue: + [self setHashBitsOf: copy to: 0. + self setIsRememberedOf: copy to: true]. + + "Now forward the object to its copy in the segment." + self storePointerUnchecked: i ofObject: savedFirstFields withValue: (self fetchPointer: 0 ofObject: objOop); + storePointerUnchecked: 0 ofObject: objOop withValue: copy; + markAsCopiedIntoSegment: objOop. + + "Answer the new end of segment" + ^segAddr + bodySize! Item was changed: ----- Method: SpurMemoryManager>>ifAProxy:updateCopy: (in category 'image segment in/out') ----- ifAProxy: objOop updateCopy: copy "This is part of storeImageSegmentInto:outPointers:roots:. If the object being copied to the segment is weird and has exotic state, i.e. a married context or a jitted method, update the copy with the vanilla state." + (self isContext: objOop) ifTrue: - ((self isContext: objOop) - and: [coInterpreter isMarriedOrWidowedContext: objOop]) ifTrue: [| numMediatedSlots | + (coInterpreter isMarriedOrWidowedContext: objOop) + ifTrue: + ["Since the context is here via objectsReachableFromRoots: we know it cannot be divorced. + I'd like to assert coInterpreter checkIsStillMarriedContext: objOop currentFP: framePointer, + here but that requires access to framePointer." + numMediatedSlots := coInterpreter numSlotsOfMarriedContext: objOop. + 0 to: numMediatedSlots - 1 do: + [:i| | oop | + oop := coInterpreter fetchPointer: i ofMarriedContext: objOop. + self storePointerUnchecked: i ofObject: copy withValue: oop]] + ifFalse: + [numMediatedSlots := self numPointerSlotsOf: objOop]. - "Since the context is here via objectsReachableFromRoots: we know it cannot be divorced. - I'd like to assert coInterpreter checkIsStillMarriedContext: objOop currentFP: framePointer, - here but that requires access to framePointer." - numMediatedSlots := coInterpreter numSlotsOfMarriedContext: objOop. - 0 to: numMediatedSlots - 1 do: - [:i| | oop | - oop := coInterpreter fetchPointer: i ofMarriedContext: objOop. - self storePointerUnchecked: i ofObject: copy withValue: oop]. "And make sure to nil the slots beyond the top of stack..." numMediatedSlots to: (self numSlotsOf: objOop) - 1 do: + [:i| self storePointerUnchecked: i ofObject: copy withValue: nilObj]]! - [:i| - self storePointerUnchecked: i ofObject: copy withValue: nilObj]]! Item was changed: ----- Method: SpurMemoryManager>>mapOopsFrom:to:outPointers:outHashes: (in category 'image segment in/out') ----- mapOopsFrom: segStart to: segAddr outPointers: outPointerArray outHashes: savedOutHashes "This is part of storeImageSegmentInto:outPointers:roots:. Now scan, adding out pointers to the outPointersArray; all objects in arrayOfObjects have had their first fields set to point to their copies in segmentWordArray. Answer the outIndex if the scan succeded. Fail if outPointers is too small and answer -1. As established by copyObj:toAddr:startAt:stopAt:savedFirstFields:index:, the marked bit is set for all objects in the segment the remembered bit is set for all classes in the segment. Class indices should be set as follows (see assignClassIndicesAndPinFrom:to:outPointers:filling:) - class indices for classes in the segment " + | objOop objIndex outIndex | + outIndex := objIndex := 0. "objIndex is for debugging; it mirrors indices in the sender's arrayOfObjects." - | objOop outIndex | - outIndex := 0. self fillObj: outPointerArray numSlots: (self numSlotsOf: outPointerArray) with: nilObj. objOop := self objectStartingAt: segStart. [self oop: objOop isLessThan: segAddr] whileTrue: [| heapOop oop hash segIndex | heapOop := self fetchClassOfNonImm: objOop. + "Set the classIndex of the instance. This is a segment offset (segAddr - segStart / allocationUnit) for instances of - "Set the classIndex of the instance. This is a segment offset (segAddr - segStart / allocatiopnUnit) for instances of classes within the segment, and an outPointer index (index in outPointers + TopHashBit) for classes outside the segment." (self isCopiedIntoSegment: heapOop) ifTrue: "oop is a class in the segment; storeImageSegmentInto:outPointers:roots: established offset is within range." [oop := self fetchPointer: 0 ofObject: heapOop. self assert: (self oop: oop isGreaterThanOrEqualTo: segStart andLessThan: segAddr). segIndex := oop - segStart / self allocationUnit + self firstClassIndexPun. (segIndex anyMask: TopHashBit) ifTrue: "Too many classes in the segment" [^-1 halt]] ifFalse: "oop is an outPointer; locate or allocate its oop" [hash := self rawHashBitsOf: heapOop. (self is: hash outPointerClassHashFor: heapOop in: outPointerArray limit: outIndex) ifTrue: [segIndex := hash] ifFalse: "oop is a new outPointer; allocate its oop" [outIndex := self newOutPointer: heapOop at: outIndex in: outPointerArray hashes: savedOutHashes. outIndex = 0 ifTrue: "no room in outPointers; fail" [^-1 halt]. segIndex := self rawHashBitsOf: heapOop]. self assert: (segIndex anyMask: TopHashBit)]. self setClassIndexOf: objOop to: segIndex. 0 to: (self numPointerSlotsOf: objOop) - 1 do: [:i| heapOop := self fetchPointer: i ofObject: objOop. (self isNonImmediate: heapOop) ifTrue: [(self isCopiedIntoSegment: heapOop) ifTrue: "oop is an object in the segment." [oop := self fetchPointer: 0 ofObject: heapOop. self assert: (self oop: oop isGreaterThanOrEqualTo: segStart andLessThan: segAddr). oop := oop - segStart] ifFalse: "oop is an outPointer; locate or allocate its oop" [hash := self rawHashBitsOf: heapOop. (self is: hash outPointerClassHashFor: heapOop in: outPointerArray limit: outIndex) ifTrue: [oop := hash - TopHashBit * self bytesPerOop + TopOopBit] ifFalse: "oop is a new outPointer; allocate its oop" [outIndex := self newOutPointer: heapOop at: outIndex in: outPointerArray hashes: savedOutHashes. outIndex = 0 ifTrue: "no room in outPointers; fail" [^-1 halt]. self assert: ((self rawHashBitsOf: heapOop) anyMask: TopHashBit). oop := (self rawHashBitsOf: heapOop) - TopHashBit * self bytesPerOop + TopOopBit]]. self storePointerUnchecked: i ofObject: objOop withValue: oop]]. + objOop := self objectAfter: objOop limit: segAddr. + objIndex := objIndex + 1]. - objOop := self objectAfter: objOop limit: segAddr]. ^outIndex! Item was changed: ----- Method: SpurMemoryManager>>objectsReachableFromRoots: (in category 'image segment in/out') ----- objectsReachableFromRoots: arrayOfRoots "This is part of storeImageSegmentInto:outPointers:roots:. Answer an Array of all the objects only reachable from the argument, an Array of root objects, starting with arrayOfRoots. If there is no space, answer a SmallInteger whose value is the number of slots required. This is used to collect the objects to include in an image segment on Spur, separate from creating the segment, hence simplifying the implementation. Thanks to Igor Stasenko for this idea." | freeChunk ptr start limit count oop objOop | <var: #freeChunk type: #usqInt> "& hence start & ptr are too; limit is also because of addressAfter:" <inline: #never> self assert: (self isArray: arrayOfRoots). "Mark all objects except those only reachable from the arrayOfRoots by marking each object in arrayOfRoots and then marking all reachable objects (from the system roots). This leaves unmarked only objects reachable from the arrayOfRoots. N.B. A side-effect of the marking is that all forwarders in arrayOfRoots will be followed." self assert: self allObjectsUnmarked. self markObjectsIn: arrayOfRoots. self markObjects: false. "After the mark phase all unreachable weak slots will have been nilled and all active ephemerons fired." self assert: (self isEmptyObjStack: markStack). self assert: (self isEmptyObjStack: weaklingStack). self assert: self noUnscannedEphemerons. + "Now unmark the roots before collecting the transitive closure of unmarked objects accessible from the roots." + self unmarkObjectsIn: arrayOfRoots. + "Use the largest free chunk to answer the result." freeChunk := self allocateLargestFreeChunk. "N.B. Does /not/ update totalFreeOldSpace" totalFreeOldSpace := totalFreeOldSpace - (self bytesInObject: freeChunk). "but must update so that growth in the markStack does not cause assert fails." ptr := start := freeChunk + self baseHeaderSize. limit := self addressAfter: freeChunk. count := 0. "First put the arrayOfRoots; order is important." + self noCheckPush: arrayOfRoots onObjStack: markStack. - count := count + 1. - ptr < limit ifTrue: - [self longAt: ptr put: arrayOfRoots. - ptr := ptr + self bytesPerOop]. "Now collect the roots and the transitive closure of unmarked objects from them." + [self isEmptyObjStack: markStack] whileFalse: + [objOop := self popObjStack: markStack. + self assert: (self isMarked: objOop). + count := count + 1. + ptr < limit ifTrue: + [self longAt: ptr put: objOop. + ptr := ptr + self bytesPerOop]. + oop := self fetchClassOfNonImm: objOop. + (self isMarked: oop) ifFalse: + [self setIsMarkedOf: oop to: true. + self noCheckPush: oop onObjStack: markStack]. + ((self isContextNonImm: objOop) + and: [coInterpreter isStillMarriedContext: objOop]) "widow now, before the copy loop" + ifTrue: + [0 to: (coInterpreter numSlotsOfMarriedContext: objOop) - 1 do: + [:i| + oop := coInterpreter fetchPointer: i ofMarriedContext: objOop. + ((self isImmediate: oop) + or: [self isMarked: oop]) ifFalse: + [self setIsMarkedOf: oop to: true. + self noCheckPush: oop onObjStack: markStack]]] + ifFalse: + [0 to: (self numPointerSlotsOf: objOop) - 1 do: + [:i| + oop := self fetchPointer: i ofObject: objOop. + ((self isImmediate: oop) + or: [self isMarked: oop]) ifFalse: + [self setIsMarkedOf: oop to: true. + self noCheckPush: oop onObjStack: markStack]]]]. - 0 to: (self numSlotsOf: arrayOfRoots) - 1 do: - [:rx| - oop := self fetchPointer: rx ofObject: arrayOfRoots. - (self isNonImmediate: oop) ifTrue: - [self deny: (self isForwarded: oop). - self noCheckPush: oop onObjStack: markStack. - "Collect the unmarked objects reachable from this root." - [self isEmptyObjStack: markStack] whileFalse: - [objOop := self popObjStack: markStack. - count := count + 1. - ptr < limit ifTrue: - [self longAt: ptr put: objOop. - ptr := ptr + self bytesPerOop]. - oop := self fetchClassOfNonImm: objOop. - (self isMarked: oop) ifFalse: - [self setIsMarkedOf: oop to: true. - self noCheckPush: oop onObjStack: markStack]. - ((self isContextNonImm: objOop) - and: [coInterpreter isStillMarriedContext: objOop]) "widow now, before the loop" - ifTrue: - [0 to: (coInterpreter numSlotsOfMarriedContext: objOop) - 1 do: - [:i| - oop := coInterpreter fetchPointer: i ofMarriedContext: objOop. - ((self isImmediate: oop) - or: [self isMarked: oop]) ifFalse: - [self setIsMarkedOf: oop to: true. - self noCheckPush: oop onObjStack: markStack]]] - ifFalse: - [0 to: (self numPointerSlotsOf: objOop) - 1 do: - [:i| - oop := self fetchPointer: i ofObject: objOop. - ((self isImmediate: oop) - or: [self isMarked: oop]) ifFalse: - [self setIsMarkedOf: oop to: true. - self noCheckPush: oop onObjStack: markStack]]]]]]. - self unmarkAllObjects. "Now try and allocate the result" (count > (ptr - start / self bytesPerOop) "not enough room" or: [limit ~= ptr and: [limit - ptr <= self allocationUnit]]) ifTrue: "can't split a single word" [self freeObject: freeChunk. self checkFreeSpace: GCModeImageSegment. ^self integerObjectOf: count]. "There's room; set the format, & classIndex and shorten." self setFormatOf: freeChunk to: self arrayFormat. self setClassIndexOf: freeChunk to: ClassArrayCompactIndex. self shorten: freeChunk toIndexableSize: count. (self isForwarded: freeChunk) ifTrue: [freeChunk := self followForwarded: freeChunk]. self possibleRootStoreInto: freeChunk. self checkFreeSpace: GCModeImageSegment. self runLeakCheckerFor: GCModeImageSegment. ^freeChunk! Item was changed: ----- Method: SpurMemoryManager>>storeImageSegmentInto:outPointers:roots: (in category 'image segment in/out') ----- storeImageSegmentInto: segmentWordArrayArg outPointers: outPointerArrayArg roots: arrayOfRootsArg "This primitive is called from Squeak as... <imageSegment> storeSegmentFor: arrayOfRoots into: aWordArray outPointers: anArray. This primitive will store a binary image segment (in the same format as objects in the heap) of the set of objects in arrayOfObjects. All pointers from within the set to objects outside the set will be copied into the array of outPointers. In their place in the image segment will be an oop equal to the offset in the outPointer array (the first would be 8), but with the high bit set. Since Spur has a class table the load primitive must insert classes that have instances into the class table. This primitive marks such classes using the isRemembered bit, which isn't meaningful as a remembered bit in the segment. The primitive expects the segmentWordArray and outPointerArray to be more than adequately long. In this case it returns normally, and truncates the two arrays to exactly the right size. The primitive can fail for the following reasons with the specified failure codes: PrimErrGenericError: the segmentWordArray is too small for the version stamp PrimErrWritePastObject: the segmentWordArray is too small to contain the reachable objects PrimErrBadIndex: the outPointerArray is too small PrimErrNoMemory: additional allocations failed PrimErrLimitExceeded: there is no room in the hash field to store out pointer indices or class references." <inline: false> | segmentWordArray outPointerArray arrayOfRoots arrayOfObjects savedFirstFields savedOutHashes segStart segAddr endSeg outIndex numClassesInSegment | <var: 'segAddr' type: #usqInt> ((self isObjImmutable: segmentWordArrayArg) or: [self isObjImmutable: outPointerArrayArg]) ifTrue: [^PrimErrNoModification]. "Since segmentWordArrayArg & outPointerArrayArg may get shortened, they can't be pinned." ((self isPinned: segmentWordArrayArg) or: [self isPinned: outPointerArrayArg]) ifTrue: [^PrimErrObjectIsPinned]. (self numSlotsOf: outPointerArrayArg) > self maxIdentityHash ifTrue: [^PrimErrLimitExceeded]. self runLeakCheckerFor: GCModeImageSegment. "First scavenge to collect any new space garbage that refers to the graph." self scavengingGC. segmentWordArray := self updatePostScavenge: segmentWordArrayArg. outPointerArray := self updatePostScavenge: outPointerArrayArg. arrayOfRoots := self updatePostScavenge: arrayOfRootsArg. self deny: (self forwardersIn: outPointerArray). self deny: (self forwardersIn: arrayOfRoots). "Now compute the transitive closure, collecting the sequence of objects to be stored in the arrayOfObjects array. Included in arrayOfObjects are the arrayOfRoots and all its contents. All objects have been unmarked." arrayOfObjects := self objectsReachableFromRoots: arrayOfRoots. arrayOfObjects ifNil: [^PrimErrNoMemory]. self assert: self allObjectsUnmarked. "work to be done when the incremental GC is written" self deny: (self forwardersIn: arrayOfObjects). "Both to expand the max size of segment and to reduce the length of the load-time pass that adds classes to the class table, move classes to the front of arrayOfObjects, leaving the root array as the first element." numClassesInSegment := self moveClassesForwardsIn: arrayOfObjects. "The scheme is to copy the objects into segmentWordArray, and then map the oops in segmentWordArray. Therefore the primitive needs to both map efficiently originals to copies in segmentWordArray and be able to undo any side-effects if the primitive fails because either segmentWordArray or outPointerArray is too small. The mapping is done by having the objects to be stored in arrayOfObjects refer to their mapped locations through their first field, just like a forwarding pointer, but without becoming a forwarder, saving their first field in savedFirstFields, and the objects in outPointerArray pointing to their locations in the outPointerArray through their identityHashes, saved in savedOutHashes. Since arrayOfObjects and its savedFirstFields, and outPointerArray and its saved hashes, can be enumerated side-by-side, the hashes can be restored to the originals. So the first field of the heap object corresponding to an object in arrayOfObjects is set to its location in segmentWordArray, and the hash of an object in outPointerArray is set to its index in outPointerArray plus the top hash bit. Classes in arrayOfObjects have their marked bit set. Oops in objects in segmentWordArray are therefore mapped by accessing the original oop, and following its first field. Class indices in segmentWordArray are mapped by fetching the original class, and testing its marked bit. If marked, the first field is followed to access the class copy in the segment. Out pointers (objects and classes, which are unmarked), the object's identityHash is set (eek!!!!) to its index in the outPointerArray. So savedOutHashes parallels the outPointerArray. The saved hash array is initialized with an out-of-range hash value so that the first unused entry can be identified." savedFirstFields := self allocateSlots: (self numSlotsOf: arrayOfObjects) format: self wordIndexableFormat classIndex: self wordSizeClassIndexPun. savedOutHashes := self allocateSlots: (self numSlotsForBytes: (self numSlotsOf: outPointerArray) * 4) format: self firstLongFormat classIndex: self thirtyTwoBitLongsClassIndexPun. (savedFirstFields isNil or: [savedOutHashes isNil]) ifTrue: [self freeObject: arrayOfObjects. ^PrimErrNoMemory]. self fillObj: savedFirstFields numSlots: (self numSlotsOf: savedFirstFields) with: 0. self fillObj: savedOutHashes numSlots: (self numSlotsOf: savedOutHashes) with: self savedOutHashFillValue. segAddr := segmentWordArray + self baseHeaderSize. endSeg := self addressAfter: segmentWordArray. "Write a version number for byte order and version check." segAddr >= endSeg ifTrue: [^PrimErrGenericFailure]. self long32At: segAddr put: self imageSegmentVersion. self long32At: segAddr + 4 put: self imageSegmentVersion. segStart := segAddr := segAddr + self allocationUnit. self assert: arrayOfRoots = (self fetchPointer: 0 ofObject: arrayOfObjects). "Copy all reachable objects to the segment, setting the marked bit for all objects (clones) in the segment, and the remembered bit for all classes (clones) in the segment." 0 to: (self numSlotsOf: arrayOfObjects) - 1 do: [:i| | newSegAddrOrError objOop | "Check that classes in the segment are addressible. Since the top bit of the hash field is used to tag classes external to the segment, the segment offset must not inadvertently set this bit. This limit still allows for a million or more classes." (i = numClassesInSegment and: [segAddr - segStart / self allocationUnit + self lastClassIndexPun >= TopHashBit]) ifTrue: [^self return: PrimErrLimitExceeded restoringObjectsIn: arrayOfObjects upTo: i savedFirstFields: savedFirstFields]. objOop := self fetchPointer: i ofObject: arrayOfObjects. self deny: ((self isImmediate: objOop) or: [self isForwarded: objOop]). newSegAddrOrError := self copyObj: objOop toAddr: segAddr - startAt: segStart stopAt: endSeg savedFirstFields: savedFirstFields index: i. (self oop: newSegAddrOrError isLessThan: segStart) ifTrue: [^self return: newSegAddrOrError restoringObjectsIn: arrayOfObjects upTo: i savedFirstFields: savedFirstFields]. segAddr := newSegAddrOrError]. "Check that it can be safely shortened." (endSeg ~= segAddr and: [endSeg - segAddr < (self baseHeaderSize + self bytesPerOop)]) ifTrue: [^self return: PrimErrWritePastObject restoringObjectsIn: arrayOfObjects upTo: -1 savedFirstFields: savedFirstFields]. "Now scan, adding out pointers to the outPointersArray; all objects in arrayOfObjects have their first field pointing to the corresponding copy in segmentWordArray." (outIndex := self mapOopsFrom: segStart to: segAddr outPointers: outPointerArray outHashes: savedOutHashes) < 0 ifTrue: "no room in outPointers; fail" [^self return: PrimErrBadIndex restoringObjectsIn: arrayOfObjects savedFirstFields: savedFirstFields and: outPointerArray savedHashes: savedOutHashes]. "We're done. Shorten the results, restore hashes and return." self shorten: segmentWordArray toIndexableSize: segAddr - (segmentWordArray + self baseHeaderSize) / 4. self shorten: outPointerArray toIndexableSize: outIndex. ^self return: PrimNoErr restoringObjectsIn: arrayOfObjects savedFirstFields: savedFirstFields and: outPointerArray savedHashes: savedOutHashes! Item was added: + ----- Method: SpurMemoryManager>>unmarkObjectsIn: (in category 'image segment in/out') ----- + unmarkObjectsIn: arrayOfRoots + "This is part of storeImageSegmentInto:outPointers:roots:." + 0 to: (self numSlotsOf: arrayOfRoots) - 1 do: + [:i| | oop | + oop := self followField: i ofObject: arrayOfRoots. + (self isNonImmediate: oop) ifTrue: + [self setIsMarkedOf: oop to: false]]! Item was changed: ----- Method: StackInterpreterPrimitives>>cloneContext: (in category 'primitive support') ----- cloneContext: aContext | sz cloned spouseFP sp | <var: #spouseFP type: #'char *'> sz := objectMemory numSlotsOf: aContext. cloned := objectMemory eeInstantiateMethodContextSlots: sz. cloned ~= 0 ifTrue: [0 to: StackPointerIndex do: [:i| objectMemory storePointerUnchecked: i ofObject: cloned withValue: (self externalInstVar: i ofContext: aContext)]. MethodIndex to: ReceiverIndex do: [:i| objectMemory storePointerUnchecked: i ofObject: cloned + withValue: (objectMemory fetchPointer: i ofObject: aContext)]. - withValue: (self fetchPointer: i ofObject: aContext)]. (self isStillMarriedContext: aContext) ifTrue: [spouseFP := self frameOfMarriedContext: aContext. sp := (self stackPointerIndexForFrame: spouseFP) - 1. 0 to: sp do: [:i| objectMemory storePointerUnchecked: i + CtxtTempFrameStart ofObject: cloned withValue: (self temporary: i in: spouseFP)]] ifFalse: [sp := (self fetchStackPointerOf: aContext) - 1. 0 to: sp do: [:i| objectMemory storePointerUnchecked: i + CtxtTempFrameStart ofObject: cloned + withValue: (objectMemory fetchPointer: i + CtxtTempFrameStart ofObject: aContext)]]]. - withValue: (self fetchPointer: i + CtxtTempFrameStart ofObject: aContext)]]]. ^cloned!

1 0

smalltalkCI cache
by Nicolas Cellier 11 Dec '17

11 Dec '17

Hi Fabio, thanks for fixing https://github.com/hpi-swa/smalltalkCI/issues/350 however, this was not enough for opensmallalk-vm health. It looks like the build still use old version of images: For example https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/313641141 Starting Squeak build... download_image 1.59sDownloading 'Squeak-5.1.tar.gz' testing image... Extracting image... image_info_9711 0.00sImage Information Image ----- /home/travis/build/OpenSmalltalk/opensmalltalk-vm/smalltalkCI-master/_builds/TravisCI.image Squeak5.1 latest update: #16548 Current Change Set: Unnamed1 Image format 6521 (32 bit) Tests are failing for other reasons currently, but latest update does look like the old one no? Is there some cache in travis/smalltalkCI preventing the update?

2 5

[OpenSmalltalk/opensmalltalk-vm] feca0b: Add HostWindowPlugin native window support stubs f...
by GitHub 11 Dec '17

11 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: feca0b4f913201d9140d7a9fd9ba7f0260df1d4e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/feca0b4f913201d914… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-11 (Mon, 11 Dec 2017) Changed paths: M platforms/iOS/plugins/HostWindowPlugin/sqMacHostWindow.m Log Message: ----------- Add HostWindowPlugin native window support stubs for iOS (this for the Terf VM).

1 0

[OpenSmalltalk/opensmalltalk-vm] 3e4db1: include sys/ucontext.h unconditionally in sqUnixMa...
by GitHub 11 Dec '17

11 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 3e4db144896baceb78e276986cf85a0a53da542a https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3e4db144896baceb78… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-12-10 (Sun, 10 Dec 2017) Changed paths: M platforms/unix/vm/sqUnixMain.c Log Message: ----------- include sys/ucontext.h unconditionally in sqUnixMain.c Also give a prototype to isdigit and toupper (thru ctype.h).

5 7

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev December 2017