Vm-dev December 2017

vm-dev@lists.squeakfoundation.org

22 participants
79 discussions

[OpenSmalltalk/opensmalltalk-vm] 48adf8: There is no sys/ucontext.h in OpenBSD
by GitHub 11 Dec '17

11 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 48adf8eec95c18cf71d2ee91008d08b8efb81b92 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/48adf8eec95c18cf71… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-12-11 (Mon, 11 Dec 2017) Changed paths: M platforms/unix/vm/sqUnixMain.c Log Message: ----------- There is no sys/ucontext.h in OpenBSD

1 0

[OpenSmalltalk/opensmalltalk-vm] ea2243: Revert mis-geberated plugins so that their version...
by GitHub 09 Dec '17

09 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: ea2243cd397b9dec8e6bf5d6e8a6030acf536774 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ea2243cd397b9dec8e… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-08 (Fri, 08 Dec 2017) Changed paths: M src/plugins/ADPCMCodecPlugin/ADPCMCodecPlugin.c M src/plugins/AioPlugin/AioPlugin.c M src/plugins/AsynchFilePlugin/AsynchFilePlugin.c M src/plugins/B2DPlugin/B2DPlugin.c M src/plugins/BitBltPlugin/BitBltPlugin.c M src/plugins/CroquetPlugin/CroquetPlugin.c M src/plugins/DSAPrims/DSAPrims.c M src/plugins/FFTPlugin/FFTPlugin.c M src/plugins/FilePlugin/FilePlugin.c M src/plugins/JPEGReaderPlugin/JPEGReaderPlugin.c M src/plugins/Klatt/Klatt.c M src/plugins/LargeIntegers/LargeIntegers.c M src/plugins/Matrix2x3Plugin/Matrix2x3Plugin.c M src/plugins/MiscPrimitivePlugin/MiscPrimitivePlugin.c M src/plugins/ScratchPlugin/ScratchPlugin.c M src/plugins/SocketPlugin/SocketPlugin.c M src/plugins/SoundGenerationPlugin/SoundGenerationPlugin.c M src/plugins/Squeak3D/Squeak3D.c M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c M src/plugins/StarSqueakPlugin/StarSqueakPlugin.c M src/plugins/UnicodePlugin/UnicodePlugin.c M src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c M src/plugins/Win32OSProcessPlugin/Win32OSProcessPlugin.c M src/plugins/ZipPlugin/ZipPlugin.c Log Message: ----------- Revert mis-geberated plugins so that their version numbers aren't incremented erroneously once their correct source is generated. Commit: f2e9e01e011299eb4904263bec965e012497922c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f2e9e01e011299eb49… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-08 (Fri, 08 Dec 2017) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64SysV.c M nsspur64src/vm/cogitX64WIN64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/plugins/ADPCMCodecPlugin/ADPCMCodecPlugin.c M src/plugins/AioPlugin/AioPlugin.c M src/plugins/AsynchFilePlugin/AsynchFilePlugin.c M src/plugins/B2DPlugin/B2DPlugin.c M src/plugins/BitBltPlugin/BitBltPlugin.c M src/plugins/DSAPrims/DSAPrims.c M src/plugins/FFTPlugin/FFTPlugin.c M src/plugins/FilePlugin/FilePlugin.c M src/plugins/JPEGReaderPlugin/JPEGReaderPlugin.c M src/plugins/Klatt/Klatt.c M src/plugins/LargeIntegers/LargeIntegers.c M src/plugins/Matrix2x3Plugin/Matrix2x3Plugin.c M src/plugins/MiscPrimitivePlugin/MiscPrimitivePlugin.c M src/plugins/ScratchPlugin/ScratchPlugin.c M src/plugins/SocketPlugin/SocketPlugin.c M src/plugins/Squeak3D/Squeak3D.c M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c M src/plugins/StarSqueakPlugin/StarSqueakPlugin.c M src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c M src/plugins/Win32OSProcessPlugin/Win32OSProcessPlugin.c M src/plugins/ZipPlugin/ZipPlugin.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2293 Fix forgotten variables in the unused variable elimination scheme for inlined value:[value:*] and to:by:do: Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/62efa00572c6...f2…

1 0

VM Maker: VMMaker.oscog-eem.2293.mcz
by commits＠source.squeak.org 09 Dec '17

09 Dec '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2293.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2293 Author: eem Time: 8 December 2017, 4:03:39.353313 pm UUID: 42fb0654-3c58-4388-b25e-dbad57cd0747 Ancestors: VMMaker.oscog-eem.2292 Fix vorgotten variables in the unused variable elimination scheme for inlined value:[value:*] and to:by:do: =============== Diff against VMMaker.oscog-eem.2292 =============== Item was changed: ----- Method: CCodeGenerator>>generateToByDo:on:indent: (in category 'C translation') ----- generateToByDo: msgNode on: aStream indent: level "Generate the C code for this message onto the given stream." "N.B. MessageNode>>asTranslatorNodeIn: adds the limit var as a hidden fourth argument." | blockExpr iterationVar limitExpr mayHaveSideEffects limitVar step | blockExpr := msgNode args third. blockExpr args size = 1 ifFalse: [self error: 'wrong number of block arguments']. iterationVar := blockExpr args first. limitExpr := msgNode args first. aStream nextPutAll: 'for (', iterationVar, ' = '. + self noteUsedVariableName: iterationVar. self emitCExpression: msgNode receiver on: aStream. mayHaveSideEffects := msgNode args size = 4. "See TMethod>>prepareMethodIn:" mayHaveSideEffects ifTrue: [limitVar := msgNode args last. aStream nextPutAll: ', ', limitVar name, ' = '. self emitCExpression: limitExpr on: aStream. limitExpr := limitVar]. aStream nextPutAll: '; ', iterationVar. step := msgNode args at: 2. self generateToByDoLimitExpression: limitExpr negative: (self stepExpressionIsNegative: step) on: aStream. aStream nextPutAll: '; ', iterationVar, ' += '. self emitCExpression: step on: aStream. aStream nextPutAll: ') {'; cr. blockExpr emitCCodeOn: aStream level: level + 1 generator: self. aStream tab: level. aStream nextPut: $}! Item was changed: ----- Method: CCodeGenerator>>generateValue:on:indent: (in category 'C translation') ----- generateValue: aTSendNode on: aStream indent: level "Reduce [:formal ... :formalN| body ] value: actual ... value: actualN to body with formals substituted for by actuals." | substitution substitutionDict newLabels | self assert: aTSendNode receiver isStmtList. self assert: aTSendNode receiver args size = aTSendNode args size. substitution := aTSendNode receiver copy. substitution renameLabelsForInliningInto: currentMethod. substitutionDict := Dictionary new: aTSendNode args size * 2. aTSendNode receiver args with: aTSendNode args do: [ :argName :exprNode | exprNode isLeaf ifTrue: [substitutionDict at: argName put: exprNode] ifFalse: [aStream nextPutAll: argName; nextPutAll: ' = '. + self noteUsedVariableName: argName. exprNode emitCCodeAsExpressionOn: aStream level: level generator: self. aStream nextPut: $; ; crtab: level]]. substitution bindVariablesIn: substitutionDict; emitCCodeOn: aStream level: level generator: self. newLabels := Set withAll: currentMethod labels. substitution nodesDo: [:node| node isLabel ifTrue: [node label ifNotNil: [:label| newLabels add: label]]]. "now add the new labels so that a subsequent inline of the same block will be renamed with different labels." currentMethod labels: newLabels! Item was added: + ----- Method: CCodeGenerator>>noteUsedVariableName: (in category 'utilities') ----- + noteUsedVariableName: variableName + currentMethod ifNotNil: + [:m| m noteUsedVariableName: variableName]!

1 0

[OpenSmalltalk/opensmalltalk-vm] 62efa0: CogVM source as per VMMaker.oscog-eem.2292
by GitHub 08 Dec '17

08 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 62efa00572c6a558f7fc04489278764bb46bc023 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/62efa00572c6a558f7… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-08 (Fri, 08 Dec 2017) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64SysV.c M nsspur64src/vm/cogitX64WIN64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/plugins/ADPCMCodecPlugin/ADPCMCodecPlugin.c M src/plugins/AioPlugin/AioPlugin.c M src/plugins/AsynchFilePlugin/AsynchFilePlugin.c M src/plugins/B2DPlugin/B2DPlugin.c M src/plugins/BitBltPlugin/BitBltPlugin.c M src/plugins/CroquetPlugin/CroquetPlugin.c M src/plugins/DSAPrims/DSAPrims.c M src/plugins/FFTPlugin/FFTPlugin.c M src/plugins/FilePlugin/FilePlugin.c M src/plugins/JPEGReaderPlugin/JPEGReaderPlugin.c M src/plugins/Klatt/Klatt.c M src/plugins/LargeIntegers/LargeIntegers.c M src/plugins/Matrix2x3Plugin/Matrix2x3Plugin.c M src/plugins/MiscPrimitivePlugin/MiscPrimitivePlugin.c M src/plugins/ScratchPlugin/ScratchPlugin.c M src/plugins/SocketPlugin/SocketPlugin.c M src/plugins/SoundGenerationPlugin/SoundGenerationPlugin.c M src/plugins/Squeak3D/Squeak3D.c M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c M src/plugins/StarSqueakPlugin/StarSqueakPlugin.c M src/plugins/UnicodePlugin/UnicodePlugin.c M src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c M src/plugins/Win32OSProcessPlugin/Win32OSProcessPlugin.c M src/plugins/ZipPlugin/ZipPlugin.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2292 CoInterpreter: Fix bug in new ceReapAndResetErrorCodeFor:; need to write the error code to the word above stack top, stack top holding the return address. Slang: (Hopefully!) Eliminate unused local variable warnings by having TMethod code generation output the body to a scratch stream, noting used variables encountered during generation, and then outputting only variables that were seen during the parse (since the code egnerator does dead code eleimination during generation). Better format labels, trying to indent them by a single tab.

1 0

VM Maker: VMMaker.oscog-eem.2292.mcz
by commits＠source.squeak.org 08 Dec '17

08 Dec '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2292.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2292 Author: eem Time: 8 December 2017, 3:00:06.051233 pm UUID: be5cc6cd-dd15-479b-903e-8dadd3746d9b Ancestors: VMMaker.oscog-eem.2291 Interpreter: Eliminate some uses of #== to compare integral values. Slang: (Hopefully!) Eliminate unused local variable warnings by having TMethod code generation output the body to a scratch stream, noting used variables encountered during generation, and then outputting only variables that were seen during the parse (since the code egnerator does dead code eleimination during generation). Better format labels, trying to indent them by a single tab. =============== Diff against VMMaker.oscog-eem.2291 =============== Item was changed: ----- Method: CCodeGenerator>>generateInlineCCode:on:indent: (in category 'C translation') ----- generateInlineCCode: msgNode on: aStream indent: level "Generate the C code for this message onto the given stream. There are two forms, self cCode: aString ... and self cCode: aBlock." msgNode args first isConstant ifTrue: [(msgNode args first value at: 1 ifAbsent: nil) = $# ifTrue: [aStream cr]. + aStream nextPutAll: msgNode args first value. + self noteVariableUsageInString: msgNode args first value] - aStream nextPutAll: msgNode args first value] ifFalse: [msgNode args first emitCCodeOn: aStream level: level generator: self]! Item was changed: ----- Method: CCodeGenerator>>generateInlineCCodeAsArgument:on:indent: (in category 'C translation') ----- generateInlineCCodeAsArgument: msgNode on: aStream indent: level "Generate the C code for this message onto the given stream. There are two forms, self cCode: aString ... and self cCode: aBlock." (msgNode args first isConstant and: [msgNode args first value isString]) ifTrue: [(msgNode args first value at: 1 ifAbsent: nil) = $# ifTrue: [aStream cr]. + aStream nextPutAll: msgNode args first value. + self noteVariableUsageInString: msgNode args first value] - aStream nextPutAll: msgNode args first value] ifFalse: [msgNode args first emitCCodeAsArgumentOn: aStream level: level generator: self]! Item was changed: ----- Method: CCodeGenerator>>generateInlineCPreprocessorDirective:on:indent: (in category 'C translation') ----- generateInlineCPreprocessorDirective: msgNode on: aStream indent: level "Generate the C preprocessor directive for this message onto the given stream." + aStream cr; nextPutAll: msgNode args first value. + self noteVariableUsageInString: msgNode args first value! - aStream cr; nextPutAll: msgNode args first value! Item was added: + ----- Method: CCodeGenerator>>noteVariableUsageInString: (in category 'utilities') ----- + noteVariableUsageInString: aString + currentMethod ifNotNil: + [:m| + (Scanner new typedScanTokens: aString) do: + [:token| + (token isString and: [token first isLetter or: [token first == $_]]) ifTrue: + [m noteUsedVariableName: token]]]! Item was changed: ----- Method: CoInterpreter>>callbackEnter: (in category 'callback support') ----- callbackEnter: callbackID "Re-enter the interpreter for executing a callback" | currentCStackPointer currentCFramePointer savedReenterInterpreter wasInMachineCode calledFromMachineCode | <volatile> <export: true> <var: #currentCStackPointer type: #'void *'> <var: #currentCFramePointer type: #'void *'> <var: #callbackID type: #'sqInt *'> <var: #savedReenterInterpreter type: #'jmp_buf'> "For now, do not allow a callback unless we're in a primitiveResponse" (self asserta: primitiveFunctionPointer ~= 0) ifFalse: [^false]. self assert: primFailCode = 0. "Check if we've exceeded the callback depth" (self asserta: jmpDepth < MaxJumpBuf) ifFalse: [^false]. jmpDepth := jmpDepth + 1. wasInMachineCode := self isMachineCodeFrame: framePointer. calledFromMachineCode := instructionPointer <= objectMemory startOfMemory. "Suspend the currently active process" suspendedCallbacks at: jmpDepth put: self activeProcess. "We need to preserve newMethod explicitly since it is not activated yet and therefore no context has been created for it. If the caller primitive for any reason decides to fail we need to make sure we execute the correct method and not the one 'last used' in the call back" suspendedMethods at: jmpDepth put: newMethod. self flag: 'need to debug this properly. Conceptually it is the right thing to do but it crashes in practice'. false ifTrue: ["Signal external semaphores since a signalSemaphoreWithIndex: request may have been issued immediately prior to this callback before the VM has any chance to do a signalExternalSemaphores in checkForEventsMayContextSwitch:" self signalExternalSemaphores. "If no process is awakened by signalExternalSemaphores then transfer to the highest priority runnable one." + (suspendedCallbacks at: jmpDepth) = self activeProcess ifTrue: - (suspendedCallbacks at: jmpDepth) == self activeProcess ifTrue: [self transferTo: self wakeHighestPriority from: CSCallbackLeave]] ifFalse: [self transferTo: self wakeHighestPriority from: CSCallbackLeave]. "Typically, invoking the callback means that some semaphore has been signaled to indicate the callback. Force an interrupt check as soon as possible." self forceInterruptCheck. "Save the previous CStackPointers and interpreter entry jmp_buf." currentCStackPointer := cogit getCStackPointer. currentCFramePointer := cogit getCFramePointer. self mem: savedReenterInterpreter asVoidPointer cp: reenterInterpreter y: (self sizeof: #'jmp_buf'). cogit assertCStackWellAligned. + (self setjmp: (jmpBuf at: jmpDepth)) = 0 ifTrue: "Fill in callbackID" - (self setjmp: (jmpBuf at: jmpDepth)) == 0 ifTrue: "Fill in callbackID" [callbackID at: 0 put: jmpDepth. self enterSmalltalkExecutive. self assert: false "NOTREACHED"]. "Restore the previous CStackPointers and interpreter entry jmp_buf." cogit setCStackPointer: currentCStackPointer. cogit setCFramePointer: currentCFramePointer. self mem: reenterInterpreter cp: (self cCoerceSimple: savedReenterInterpreter to: #'void *') y: (self sizeof: #'jmp_buf'). "Transfer back to the previous process so that caller can push result" self putToSleep: self activeProcess yieldingIf: preemptionYields. self transferTo: (suspendedCallbacks at: jmpDepth) from: CSCallbackLeave. newMethod := suspendedMethods at: jmpDepth. "see comment above" argumentCount := self argumentCountOf: newMethod. self assert: wasInMachineCode = (self isMachineCodeFrame: framePointer). calledFromMachineCode ifTrue: [instructionPointer asUnsignedInteger >= objectMemory startOfMemory ifTrue: [self iframeSavedIP: framePointer put: instructionPointer. instructionPointer := cogit ceReturnToInterpreterPC]] ifFalse: ["Even if the context was flushed to the heap and rebuilt in transferTo:from: above it will remain an interpreted frame because the context's pc would remain a bytecode pc. So the instructionPointer must also be a bytecode pc." self assert: (self isMachineCodeFrame: framePointer) not. self assert: instructionPointer > objectMemory startOfMemory]. self assert: primFailCode = 0. jmpDepth := jmpDepth-1. ^true! Item was changed: ----- Method: CoInterpreter>>ceNonLocalReturn: (in category 'trampolines') ----- ceNonLocalReturn: returnValue <api> | closure home unwindContextOrNilOrZero ourContext frameToReturnTo contextToReturnTo theFP callerFP newPage | <var: #frameToReturnTo type: #'char *'> <var: #theFP type: #'char *'> <var: #callerFP type: #'char *'> <var: #newPage type: #'StackPage *'> <var: #thePage type: #'StackPage *'> "self shortPrintFrameAndCallers: framePointer. self printOop: returnValue. self halt." self assert: (self isMachineCodeFrame: framePointer). self assert: (self frameIsBlockActivation: framePointer). "Since this is a block activation the closure is on the stack above any args and the frame." closure := self pushedReceiverOrClosureOfFrame: framePointer. home := nil. "Walk the closure's lexical chain to find the context or frame to return from (home)." [closure ~= objectMemory nilObject] whileTrue: [home := objectMemory followField: ClosureOuterContextIndex ofObject: closure. closure := objectMemory followField: ClosureIndex ofObject: home]. "home is to be returned from provided there is no unwind-protect activation between this frame and home's sender. Search for an unwind. findUnwindThroughContext: will answer either the context for an unwind-protect activation or nilObj if the sender cannot be found or 0 if no unwind is found but the sender is. We must update the current page's headFrame pointers to enable the search to identify widowed contexts correctly." self externalWriteBackHeadFramePointers. unwindContextOrNilOrZero := self findUnwindThroughContext: home. unwindContextOrNilOrZero = objectMemory nilObject ifTrue: ["error: can't find home on chain; cannot return" ourContext := self ensureFrameIsMarried: framePointer SP: stackPointer. ^self externalCannotReturn: returnValue from: ourContext]. unwindContextOrNilOrZero ~= 0 ifTrue: [^self externalAboutToReturn: returnValue through: unwindContextOrNilOrZero]. "Now we know home is on the sender chain. We could be returning to either a context or a frame. Find out which." contextToReturnTo := nil. (self isMarriedOrWidowedContext: home) ifTrue: [self assert: (self checkIsStillMarriedContext: home currentFP: framePointer). theFP := self frameOfMarriedContext: home. (self isBaseFrame: theFP) ifTrue: [contextToReturnTo := self frameCallerContext: theFP] ifFalse: [frameToReturnTo := self frameCallerFP: theFP]] ifFalse: [contextToReturnTo := objectMemory fetchPointer: SenderIndex ofObject: home. ((objectMemory isContext: contextToReturnTo) and: [self isMarriedOrWidowedContext: contextToReturnTo]) ifTrue: [self assert: (self checkIsStillMarriedContext: contextToReturnTo currentFP: framePointer). frameToReturnTo := self frameOfMarriedContext: contextToReturnTo. contextToReturnTo := nil]]. "If returning to a context we must make a frame for it unless it is dead." contextToReturnTo ~= nil ifTrue: [frameToReturnTo := self establishFrameForContextToReturnTo: contextToReturnTo. + frameToReturnTo = 0 ifTrue: - frameToReturnTo == 0 ifTrue: ["error: home's sender is dead; cannot return" ourContext := self ensureFrameIsMarried: framePointer SP: stackPointer. ^self externalCannotReturn: returnValue from: ourContext]]. "Now we have a frame to return to. If it is on a different page we must free intervening pages and nil out intervening contexts. We must free intervening stack pages because if we leave the pages to be divorced then their contexts will be divorced with intact senders and instruction pointers. This code is similar to primitiveTerminateTo." self assert: stackPages pageListIsWellFormed. newPage := stackPages stackPageFor: frameToReturnTo. newPage ~~ stackPage ifTrue: [| currentCtx thePage nextCntx | currentCtx := self frameCallerContext: stackPage baseFP. self assert: (objectMemory isContext: currentCtx). stackPages freeStackPage: stackPage. [self assert: (objectMemory isContext: currentCtx). (self isMarriedOrWidowedContext: currentCtx) and: [(stackPages stackPageFor: (theFP := self frameOfMarriedContext: currentCtx)) = newPage]] whileFalse: [(self isMarriedOrWidowedContext: currentCtx) ifTrue: [thePage := stackPages stackPageFor: theFP. currentCtx := self frameCallerContext: thePage baseFP. stackPages freeStackPage: thePage] ifFalse: [nextCntx := objectMemory fetchPointer: SenderIndex ofObject: currentCtx. self markContextAsDead: currentCtx. currentCtx := nextCntx]]. self setStackPageAndLimit: newPage. self setStackPointersFromPage: newPage]. "Two cases. Returning to the top frame or an interior frame. The top frame has its instruction pointer on top of stack. An interior frame has its instruction pointer in the caller frame. We need to peel back any frames on the page until we get to the correct frame." framePointer = frameToReturnTo ifTrue: [instructionPointer := self popStack] ifFalse: [[callerFP := framePointer. framePointer := self frameCallerFP: framePointer. framePointer ~~ frameToReturnTo] whileTrue. instructionPointer := (self frameCallerSavedIP: callerFP) asUnsignedInteger. stackPointer := (self frameCallerSP: callerFP)]. ^self return: returnValue toExecutive: false! Item was changed: ----- Method: CoInterpreter>>commonCallerReturn (in category 'return bytecodes') ----- commonCallerReturn "Return to the previous context/frame (sender for method activations, caller for block activations)." <sharedCodeNamed: 'commonCallerReturn' inCase: #returnTopFromBlock> | callersFPOrNull doWeHaveANativeFrame | <var: #callersFPOrNull type: #'char *'> "TODO: Store/restore the nativeSP more properly, when it exists" LowcodeVM ifTrue: [ doWeHaveANativeFrame := self frameHasNativeFrame: localFP. doWeHaveANativeFrame ifTrue: [ nativeStackPointer := (self nativePreviousStackPointerIn: localFP) - 1. nativeSP := 0. self setFrameHasNotNativeFrame: localFP. ]. ]. callersFPOrNull := self frameCallerFP: localFP. + callersFPOrNull = 0 "baseFrame" ifTrue: - callersFPOrNull == 0 "baseFrame" ifTrue: [self assert: localFP = stackPage baseFP. ^self baseFrameReturn]. localIP := self frameCallerSavedIP: localFP. localSP := localFP + (self frameStackedReceiverOffset: localFP). localFP := callersFPOrNull. localIP asUnsignedInteger < objectMemory startOfMemory ifTrue: [localIP asUnsignedInteger ~= cogit ceReturnToInterpreterPC ifTrue: ["localIP in the cog method zone indicates a return to machine code." ^self returnToMachineCodeFrame]. localIP := self pointerForOop: (self iframeSavedIP: localFP)]. self setMethod: (self iframeMethod: localFP). self fetchNextBytecode. self internalStackTopPut: localReturnValue! Item was changed: ----- Method: CoInterpreter>>instructionPointerForFrame:currentFP:currentIP: (in category 'frame access') ----- instructionPointerForFrame: spouseFP currentFP: currentFP currentIP: instrPtr "Answer the bytecode pc object (i.e. SmallInteger) for an active frame. The bytecode pc is derived from the frame's pc. If the frame is the top frame on the current stack the frame pc is whatever the current instruction pointer is. If the frame is the top frame on some other stack the frame pc is the value on top of stack. Otherwise the frame pc is the saved pc of the frame above. Once the frame pc is found it must be mapped to a bytecode pc." <var: #spouseFP type: #'char *'> <var: #currentFP type: #'char *'> | value theIP thePage theFPAbove | <var: #thePage type: #'StackPage *'> <var: #theFPAbove type: #'char *'> spouseFP = currentFP ifTrue: [theIP := self oopForPointer: instrPtr] ifFalse: [thePage := stackPages stackPageFor: spouseFP. theFPAbove := self findFrameAbove: spouseFP inPage: thePage. + theIP := theFPAbove = 0 - theIP := theFPAbove == 0 ifTrue: [stackPages longAt: thePage headSP] ifFalse:[self oopForPointer: (self frameCallerSavedIP: theFPAbove)]]. value := self contextInstructionPointer: theIP frame: spouseFP. ^value signedIntFromLong < 0 ifTrue: [self mustMapMachineCodePC: (objectMemory integerValueOf: value) context: (self frameContext: spouseFP)] ifFalse: [value]! Item was changed: ----- Method: StackInterpreter>>callbackEnter: (in category 'callback support') ----- callbackEnter: callbackID "Re-enter the interpreter for executing a callback" <export: true> <var: #callbackID type: #'sqInt *'> "For now, do not allow a callback unless we're in a primitiveResponse" (self asserta: primitiveFunctionPointer ~= 0) ifFalse: [^false]. "Check if we've exceeded the callback depth" (self asserta: jmpDepth < MaxJumpBuf) ifFalse: [^false]. jmpDepth := jmpDepth + 1. "Suspend the currently active process" suspendedCallbacks at: jmpDepth put: self activeProcess. "We need to preserve newMethod explicitly since it is not activated yet and therefore no context has been created for it. If the caller primitive for any reason decides to fail we need to make sure we execute the correct method and not the one 'last used' in the call back" suspendedMethods at: jmpDepth put: newMethod. "Signal external semaphores since a signalSemaphoreWithIndex: request may have been issued immediately prior to this callback before the VM has any chance to do a signalExternalSemaphores in checkForEventsMayContextSwitch:" self signalExternalSemaphores. "If no process is awakened by signalExternalSemaphores then transfer to the highest priority runnable one." + (suspendedCallbacks at: jmpDepth) = self activeProcess ifTrue: - (suspendedCallbacks at: jmpDepth) == self activeProcess ifTrue: [self transferTo: self wakeHighestPriority]. "Typically, invoking the callback means that some semaphore has been signaled to indicate the callback. Force an interrupt check as soon as possible." self forceInterruptCheck. + (self setjmp: (jmpBuf at: jmpDepth)) = 0 ifTrue: "Fill in callbackID" - (self setjmp: (jmpBuf at: jmpDepth)) == 0 ifTrue: "Fill in callbackID" [callbackID at: 0 put: jmpDepth. self interpret]. "Transfer back to the previous process so that caller can push result" self putToSleep: self activeProcess yieldingIf: preemptionYields. self transferTo: (suspendedCallbacks at: jmpDepth). newMethod := suspendedMethods at: jmpDepth. "see comment above" argumentCount := self argumentCountOf: newMethod. jmpDepth := jmpDepth-1. "clean out the primPops etc since we'll be returning via primitive" self initPrimCall. ^true! Item was changed: ----- Method: StackInterpreter>>commonCallerReturn (in category 'return bytecodes') ----- commonCallerReturn "Return to the previous context/frame (sender for method activations, caller for block activations)." <sharedCodeInCase: #returnTopFromBlock> | callersFPOrNull doWeHaveANativeFrame | <var: #callersFPOrNull type: #'char *'> "TODO: Store/restore the nativeSP more properly, when it exists" LowcodeVM ifTrue: [ doWeHaveANativeFrame := self frameHasNativeFrame: localFP. doWeHaveANativeFrame ifTrue: [ nativeStackPointer := (self nativePreviousStackPointerIn: localFP) - 1. nativeSP := 0. self setFrameHasNotNativeFrame: localFP. ]. ]. callersFPOrNull := self frameCallerFP: localFP. + callersFPOrNull = 0 "baseFrame" ifTrue: - callersFPOrNull == 0 "baseFrame" ifTrue: [self assert: localFP = stackPage baseFP. ^self baseFrameReturn]. localIP := self frameCallerSavedIP: localFP. localSP := localFP + (self frameStackedReceiverOffset: localFP). localFP := callersFPOrNull. self setMethod: (self frameMethod: localFP). self fetchNextBytecode. self internalStackTopPut: localReturnValue! Item was changed: ----- Method: StackInterpreter>>commonReturn (in category 'return bytecodes') ----- commonReturn "Do an ^-return (return from method), checking for unwinds if this is a block activation. Note: Assumed to be inlined into the dispatch loop." <sharedCodeInCase: #returnReceiver> | closure home unwindContextOrNilOrZero frameToReturnTo contextToReturnTo theFP callerFP newPage | <var: #frameToReturnTo type: #'char *'> <var: #theFP type: #'char *'> <var: #callerFP type: #'char *'> <var: #newPage type: #'StackPage *'> <var: #thePage type: #'StackPage *'> "If this is a method simply return to the sender/caller." (self iframeIsBlockActivation: localFP) ifFalse: [^self commonCallerReturn]. "Since this is a block activation the closure is on the stack above any args and the frame." closure := self pushedReceiverOrClosureOfFrame: localFP. home := nil. "Walk the closure's lexical chain to find the context or frame to return from (home)." [closure ~= objectMemory nilObject] whileTrue: [home := objectMemory followField: ClosureOuterContextIndex ofObject: closure. closure := objectMemory followField: ClosureIndex ofObject: home]. "home is to be returned from provided there is no unwind-protect activation between this frame and home's sender. Search for an unwind. findUnwindThroughContext: will answer either the context for an unwind-protect activation or nilObj if the sender cannot be found or 0 if no unwind is found but the sender is. We must update the current page's headFrame pointers to enable the search to identify widowed contexts correctly." self writeBackHeadFramePointers. self externalizeIPandSP. unwindContextOrNilOrZero := self findUnwindThroughContext: home. unwindContextOrNilOrZero = objectMemory nilObject ifTrue: ["error: can't find home on chain; cannot return" ^self internalCannotReturn: localReturnValue]. unwindContextOrNilOrZero ~= 0 ifTrue: [^self internalAboutToReturn: localReturnValue through: unwindContextOrNilOrZero]. "Now we know home is on the sender chain. We could be returning to either a context or a frame. Find out which." contextToReturnTo := nil. (self isMarriedOrWidowedContext: home) ifTrue: [self assert: (self checkIsStillMarriedContext: home currentFP: localFP). theFP := self frameOfMarriedContext: home. (self isBaseFrame: theFP) ifTrue: [contextToReturnTo := self frameCallerContext: theFP] ifFalse: [frameToReturnTo := self frameCallerFP: theFP]] ifFalse: [contextToReturnTo := objectMemory fetchPointer: SenderIndex ofObject: home. ((objectMemory isContext: contextToReturnTo) and: [self isMarriedOrWidowedContext: contextToReturnTo]) ifTrue: [self assert: (self checkIsStillMarriedContext: contextToReturnTo currentFP: localFP). frameToReturnTo := self frameOfMarriedContext: contextToReturnTo. contextToReturnTo := nil]]. "If returning to a context we must make a frame for it unless it is dead." contextToReturnTo ~= nil ifTrue: [frameToReturnTo := self establishFrameForContextToReturnTo: contextToReturnTo. + frameToReturnTo = 0 ifTrue: "error: home's sender is dead; cannot return" + [^self internalCannotReturn: localReturnValue]]. - frameToReturnTo == 0 ifTrue: - ["error: home's sender is dead; cannot return" - ^self internalCannotReturn: localReturnValue]]. "Now we have a frame to return to. If it is on a different page we must free intervening pages and nil out intervening contexts. We must free intervening stack pages because if we leave the pages to be divorced then their contexts will be divorced with intact senders and instruction pointers. This code is similar to primitiveTerminateTo. We must move any frames on intervening pages above the frame linked to because these may be in use, e.g. via co-routining (see baseFrameReturn)." self assert: stackPages pageListIsWellFormed. newPage := stackPages stackPageFor: frameToReturnTo. newPage ~~ stackPage ifTrue: [| currentCtx thePage nextCntx | currentCtx := self frameCallerContext: stackPage baseFP. stackPages freeStackPage: stackPage. [self assert: (objectMemory isContext: currentCtx). (self isMarriedOrWidowedContext: currentCtx) and: [(stackPages stackPageFor: (theFP := self frameOfMarriedContext: currentCtx)) = newPage]] whileFalse: [(self isMarriedOrWidowedContext: currentCtx) ifTrue: [thePage := stackPages stackPageFor: theFP. theFP ~= thePage headFP ifTrue: ["Since we've just deallocated a page we know that newStackPage won't deallocate an existing one." self moveFramesIn: thePage through: (self findFrameAbove: theFP inPage: thePage) toPage: stackPages newStackPage]. currentCtx := self frameCallerContext: thePage baseFP. stackPages freeStackPage: thePage] ifFalse: [nextCntx := objectMemory fetchPointer: SenderIndex ofObject: currentCtx. self markContextAsDead: currentCtx. currentCtx := nextCntx]]. self setStackPageAndLimit: newPage. localSP := stackPage headSP. localFP := stackPage headFP]. "Two cases. Returning to the top frame on a new page or an interior frame on the current page. The top frame has its instruction pointer on top of stack. An interior frame has its instruction pointer in the caller frame. We need to peel back any frames on the page until we get to the correct frame." localFP = frameToReturnTo ifTrue: "pop the saved IP, push the return value and continue." [localIP := self pointerForOop: self internalStackTop] ifFalse: [[callerFP := localFP. localFP := self frameCallerFP: localFP. localFP ~~ frameToReturnTo] whileTrue. localIP := self frameCallerSavedIP: callerFP. localSP := (self frameCallerSP: callerFP) - objectMemory wordSize]. self maybeReturnToMachineCodeFrame. self setMethod: (self frameMethod: localFP). self fetchNextBytecode. self internalStackTopPut: localReturnValue! Item was changed: ----- Method: StackInterpreter>>context:hasSender: (in category 'internal interpreter access') ----- context: thisCntx hasSender: aContext "Does thisCntx have aContext in its sender chain? Cheapo implementation above extant machinery." | handlerOrNilOrZero | <inline: true> handlerOrNilOrZero := self findMethodWithPrimitive: -1 FromContext: thisCntx UpToContext: aContext. + ^handlerOrNilOrZero = 0! - ^handlerOrNilOrZero == 0! Item was changed: ----- Method: StackInterpreter>>externalDivorceFrame:andContext: (in category 'frame access') ----- externalDivorceFrame: theFP andContext: ctxt "Divorce a single frame and its context. If it is not the top frame of a stack this means splitting its stack." | thePage onCurrent theSP callerCtx newPage frameAbove callerFP callerSP callerIP theIP | <inline: false> <var: #theFP type: #'char *'> <var: #thePage type: #'StackPage *'> <var: #theSP type: #'char *'> <var: #newPage type: #'StackPage *'> <var: #frameAbove type: #'char *'> <var: #callerFP type: #'char *'> <var: #callerSP type: #'char *'> "stackPage needs to have current head pointers to avoid confusion." self assert: (stackPage = 0 or: [stackPage = stackPages mostRecentlyUsedPage]). thePage := stackPages stackPageFor: theFP. (onCurrent := thePage = stackPage) ifFalse: [stackPages markStackPageNextMostRecentlyUsed: thePage]. theSP := self findSPOf: theFP on: thePage. self updateStateOfSpouseContextForFrame: theFP WithSP: theSP. callerCtx := self ensureCallerContext: theFP. + (frameAbove := self findFrameAbove: theFP inPage: thePage) = 0 - (frameAbove := self findFrameAbove: theFP inPage: thePage) == 0 ifTrue: "If we're divorcing the top frame we can simply peel it off." [theIP := stackPages longAt: thePage headSP] ifFalse: "othewise move all frames above to a new stack and then peel the frame off." [newPage := stackPages newStackPage. theIP := self oopForPointer: (self frameCallerSavedIP: frameAbove). frameAbove := self moveFramesIn: thePage through: frameAbove toPage: newPage. onCurrent ifTrue: [self setStackPageAndLimit: newPage. self setStackPointersFromPage: newPage] ifFalse: [stackPages markStackPageMostRecentlyUsed: newPage]. self assert: (self frameCallerContext: frameAbove) = ctxt]. objectMemory storePointerUnchecked: InstructionPointerIndex ofObject: ctxt withValue: (self contextInstructionPointer: theIP frame: theFP). objectMemory storePointer: SenderIndex ofObject: ctxt withValue: callerCtx. callerFP := self frameCallerFP: theFP. + callerFP = 0 "theFP is a base frame; it is now alone; free the entire page" - callerFP == 0 "theFP is a base frame; it is now alone; free the entire page" ifTrue: [stackPages freeStackPage: thePage] ifFalse: [callerIP := self oopForPointer: (self frameCallerSavedIP: theFP). callerSP := (self frameCallerSP: theFP) - objectMemory wordSize. stackPages longAt: callerSP put: callerIP. self setHeadFP: callerFP andSP: callerSP inPage: thePage] ! Item was changed: ----- Method: StackInterpreter>>imageFormatCompatibilityVersion (in category 'image save/restore') ----- imageFormatCompatibilityVersion "This VM is backward-compatible with the immediately preceding version." + ^objectMemory wordSize = 4 ifTrue: [6504] ifFalse: [68002]! - ^objectMemory wordSize == 4 ifTrue: [6504] ifFalse: [68002]! Item was changed: ----- Method: StackInterpreter>>instructionPointerForFrame:currentFP:currentIP: (in category 'frame access') ----- instructionPointerForFrame: spouseFP currentFP: currentFP currentIP: instrPtr "Answer the bytecode pc object (i.e. SmallInteger) for an active frame. The bytecode pc is derived from the frame's pc. If the frame is the top frame on the current stack the frame pc is whatever the current instruction pointer is. If the frame is the top frame on some other stack the frame pc is the value on top of stack. Otherwise the frame pc is the saved pc of the frame above. Once the frame pc is found it must be mapped to a bytecode pc." <var: #spouseFP type: #'char *'> <var: #currentFP type: #'char *'> | theIP thePage theFPAbove | <var: #thePage type: #'StackPage *'> <var: #theFPAbove type: #'char *'> spouseFP = currentFP ifTrue: [theIP := self oopForPointer: instrPtr] ifFalse: [thePage := stackPages stackPageFor: spouseFP. theFPAbove := self findFrameAbove: spouseFP inPage: thePage. + theIP := theFPAbove = 0 - theIP := theFPAbove == 0 ifTrue: [stackPages longAt: thePage headSP] ifFalse:[self oopForPointer: (self frameCallerSavedIP: theFPAbove)]]. ^self contextInstructionPointer: theIP frame: spouseFP! Item was changed: ----- Method: StackInterpreter>>isBaseFrame: (in category 'frame access') ----- isBaseFrame: theFP "A base frame (first frame in a stack page) is so marked by having a null saved fp." <inline: true> <var: #theFP type: #'char *'> + ^(stackPages longAt: theFP + FoxSavedFP) = 0! - ^(stackPages longAt: theFP + FoxSavedFP) == 0! Item was changed: ----- Method: TLabeledCommentNode>>printOptionalLabelOn: (in category 'printing') ----- printOptionalLabelOn: aStream + label ifNotNil: + [self unindentTabs: aStream. + aStream + nextPutAll: label; + nextPut: $:; + tab]! - label ~= nil ifTrue: [ - self unindentOneTab: aStream. - aStream nextPutAll: label. - aStream nextPut: $:. - aStream tab. - ].! Item was removed: - ----- Method: TLabeledCommentNode>>unindentOneTab: (in category 'C code generation') ----- - unindentOneTab: aStream - "Remove the last tab from the given stream if possible." - - (aStream isKindOf: ReadWriteStream) ifFalse: [ ^self ]. - aStream position > 0 ifTrue: [ - aStream position: aStream position - 1. - "restore stream position if previous char was not a tab" - aStream peek = Character tab ifFalse: [ aStream next ]. - ].! Item was added: + ----- Method: TLabeledCommentNode>>unindentTabs: (in category 'C code generation') ----- + unindentTabs: aStream + "Remove all but one tab up to the beginning of line from the given stream if possible." + + (aStream isKindOf: ReadWriteStream) ifFalse: [ ^self ]. + [aStream position > 0] whileTrue: + [aStream position: aStream position - 1. + "restore stream position if previous char was not a tab" + aStream peek == Character tab ifFalse: + [^aStream next; tab]]! Item was changed: Object subclass: #TMethod + instanceVariableNames: 'args comment complete declarations definingClass export extraVariableNumber globalStructureBuildMethodHasFoo inline labels locals parseTree primitive properties returnType selector sharedCase sharedLabel static writtenToGlobalVarsCache functionAttributes usedVariablesCache' - instanceVariableNames: 'args comment complete declarations definingClass export extraVariableNumber globalStructureBuildMethodHasFoo inline labels locals parseTree primitive properties returnType selector sharedCase sharedLabel static writtenToGlobalVarsCache functionAttributes' classVariableNames: 'CaseStatements' poolDictionaries: '' category: 'VMMaker-Translation to C'! !TMethod commentStamp: 'dtl 9/15/2008 09:06' prior: 0! A TMethod is a translation method, representing a MethodNode that is to be translated to C source. It has a parseTree of translation nodes that mirrors the parse tree of the corresponding Smalltalk method.! Item was changed: ----- Method: TMethod>>emitCCodeOn:generator: (in category 'C code generation') ----- emitCCodeOn: aStream generator: aCodeGen "Emit C code for this method onto the given stream. All calls to inlined methods should already have been expanded." + | bodyStream conditional | - | conditional | aCodeGen currentMethod: self. + usedVariablesCache := Set new. self emitCCommentOn: aStream. "place method comment and method name before function." aStream crtab; nextPutAll: '/* '; nextPutAll: self definingClass name; nextPutAll: '>>#'; nextPutAll: self smalltalkSelector; nextPutAll: ' */'. aStream cr. conditional := self emitCFunctionPrototype: aStream generator: aCodeGen isPrototype: false. aStream cr; nextPut: ${. + bodyStream := ReadWriteStream on: (ByteString new: 128). + aCodeGen "Generation will note used variables in usedVariablesCache" - self emitCLocalsOn: aStream generator: aCodeGen. - aCodeGen pushScope: declarations + while: [parseTree emitCCodeOn: bodyStream level: 1 generator: aCodeGen]. + self emitCLocalsOn: aStream generator: aCodeGen. + usedVariablesCache := nil. + aStream nextPutAll: bodyStream contents. - while: [parseTree emitCCodeOn: aStream level: 1 generator: aCodeGen]. (returnType = #void or: [parseTree endsWithReturn]) ifFalse: [aStream tab; nextPutAll: 'return 0;'; cr]. aStream nextPut: $}; cr. conditional ifTrue: [self terminateConditionalDefineFor: self compileTimeOptionPragmas on: aStream]! Item was changed: ----- Method: TMethod>>emitCLocalsOn:generator: (in category 'C code generation') ----- emitCLocalsOn: aStream generator: aCodeGen "Emit a C function header for this method onto the given stream." | volatileVariables | volatileVariables := properties includesKey: #volatile. self refersToGlobalStruct ifTrue: [aStream next: 3 put: Character space; "there's already an opening ${ on this line; see sender" nextPutAll: (volatileVariables ifTrue: ['DECL_MAYBE_VOLATILE_SQ_GLOBAL_STRUCT'] ifFalse: ['DECL_MAYBE_SQ_GLOBAL_STRUCT'])]. aStream cr. locals isEmpty ifFalse: [(aCodeGen sortStrings: locals) do: + [ :var | | decl | + decl := self declarationAt: var. + (volatileVariables or: [(decl beginsWith: 'static') or: [usedVariablesCache includes: var]]) ifTrue: + [aStream next: 4 put: Character space. + volatileVariables ifTrue: + [aStream nextPutAll: #volatile; space]. + aStream + nextPutAll: decl; + nextPut: $;; + cr]]. - [ :var | - aStream next: 4 put: Character space. - volatileVariables ifTrue: - [aStream nextPutAll: #volatile; space]. - aStream - nextPutAll: (self declarationAt: var); - nextPut: $;; - cr]. aStream cr]! Item was added: + ----- Method: TMethod>>noteUsedVariableName: (in category 'utilities') ----- + noteUsedVariableName: token + usedVariablesCache ifNotNil: + [usedVariablesCache add: token]! Item was changed: ----- Method: TVariableNode>>emitCCodeOn:level:generator: (in category 'C code generation') ----- emitCCodeOn: aStream level: level generator: aCodeGen aStream nextPutAll: (name = 'nil' + ifTrue: [aCodeGen cLiteralFor: nil] + ifFalse: [aCodeGen returnPrefixFromVariable: name]). + aCodeGen currentMethod ifNotNil: + [:m| m noteUsedVariableName: name]! - ifTrue: [ aCodeGen cLiteralFor: nil ] - ifFalse: [ aCodeGen returnPrefixFromVariable: name ])!

1 0

VM Maker: VMMaker.oscog-eem.2291.mcz
by commits＠source.squeak.org 08 Dec '17

08 Dec '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2291.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2291 Author: eem Time: 8 December 2017, 2:51:58.63029 pm UUID: db3fbe11-c38f-4fc2-9569-51a31b905acf Ancestors: VMMaker.oscog-eem.2290 CoInterpreter: Fix bug in new ceReapAndResetErrorCodeFor:; need to write the error code to the word above stack top, stack top holding the return address. Make sure ceReapAndResetErrorCodeFor: simulates properly with the CogVMSimulator method coercing the address to a CogMethod. =============== Diff against VMMaker.oscog-eem.2290 =============== Item was changed: ----- Method: CoInterpreter>>ceReapAndResetErrorCodeFor: (in category 'trampolines') ----- ceReapAndResetErrorCodeFor: cogMethod <api> <var: #cogMethod type: #'CogMethod *'> - self break. self assert: primFailCode ~= 0. newMethod := cogMethod methodObject. + self reapAndResetErrorCodeTo: stackPointer + objectMemory wordSize + header: cogMethod methodHeader! - self reapAndResetErrorCodeTo: stackPointer header: cogMethod methodHeader! Item was added: + ----- Method: CogVMSimulator>>ceReapAndResetErrorCodeFor: (in category 'trampolines') ----- + ceReapAndResetErrorCodeFor: cogMethod + "Override to map the address into a CogMethodSurrogate" + | surrogate | + surrogate := cogMethod isInteger + ifTrue: [cogit cogMethodSurrogateAt: cogMethod] + ifFalse: [cogMethod]. + ^super ceReapAndResetErrorCodeFor: surrogate!

1 0

[OpenSmalltalk/opensmalltalk-vm] 67dde2: CogVM source as per VMMaker.oscog-eem.2289
by GitHub 08 Dec '17

08 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 67dde2d720d8c3c52687ec078fca15d3aa60328b https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/67dde2d720d8c3c526… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-07 (Thu, 07 Dec 2017) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64SysV.c M nsspur64src/vm/cogitX64WIN64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspur64src/vm/interp.h M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspursrc/vm/interp.h M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstack64src/vm/interp.h M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M nsspurstacksrc/vm/interp.h M platforms/Cross/vm/sqVirtualMachine.c M platforms/Cross/vm/sqVirtualMachine.h M spur64src/vm/cogit.h M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/interp.h M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/interp.h M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/interp.h M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestack64src/vm/interp.h M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spurlowcodestacksrc/vm/interp.h M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursista64src/vm/interp.h M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursistasrc/vm/interp.h M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spursrc/vm/interp.h M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstack64src/vm/interp.h M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M spurstacksrc/vm/interp.h M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M src/vm/interp.h M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c M stacksrc/vm/interp.h Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2289 Refactor reaping the primFailCode on method activation to pull it out of the common path and hence lay the ground for a platform error object since all failures now call a single reapAndResetErrorCodeTo:header: Add support for conveying os/library error codes through a special primitive failure code object. The error code is a signed 64-bit value (so that e.g. answering -1 is not expensive). Specific image-level clients can map that value to unsigned as appropriate. Clients use interpreterProxy->primitiveFailForOSError(sqLong) Commit: ba79f5f04d4e1ee178951e80cc0b41ad7c713997 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ba79f5f04d4e1ee178… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-08 (Fri, 08 Dec 2017) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64SysV.c M nsspur64src/vm/cogitX64WIN64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M platforms/Cross/vm/sqVirtualMachine.c M platforms/Cross/vm/sqVirtualMachine.h M spur64src/vm/cogit.h M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/plugins/ADPCMCodecPlugin/ADPCMCodecPlugin.c M src/plugins/BitBltPlugin/BitBltPlugin.c M src/plugins/MiscPrimitivePlugin/MiscPrimitivePlugin.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2290 Slang: Include short int as a valid integral type. Eliminate noisy unnecessary casts of constant integers to various unsigned types on inlining. Eliminate noisy carriage returns between comment and leaf in translations of commented leaf nodes in expressions. Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/db7115e8c73b...ba…

1 0

VM Maker: VMMaker.oscog-eem.2290.mcz
by commits＠source.squeak.org 08 Dec '17

08 Dec '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2290.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2290 Author: eem Time: 8 December 2017, 10:56:23.758751 am UUID: db77672d-ac4b-4a9e-9e62-49d34e07678c Ancestors: VMMaker.oscog-eem.2289 Slang: Include short int as a valid integral type. Eliminate noisy unnecessary casts of constant integers to various unsigned types on inlining. Eliminate noisy carriage returns between comment and leaf in translations of commented leaf nodes in expressions. =============== Diff against VMMaker.oscog-eem.2289 =============== Item was changed: ----- Method: CCodeGenerator>>isIntegralCType: (in category 'inlining') ----- isIntegralCType: aCType "<String>" ^(#('sqLong' 'usqLong' 'sqInt' 'usqInt' 'sqIntptr_t' 'usqIntptr_t' + 'long' 'long long' 'int' 'short' 'short int' 'char' 'signed char' - 'long' 'int' 'short' 'char' 'signed char' 'size_t' 'pid_t') includes: aCType asString) or: [(aCType beginsWith: 'unsigned') "Accept e.g. 'unsigned long' and also 'unsigned : 8'" and: [(aCType includesAnyOf: '[*]') not]]! Item was added: + ----- Method: CCodeGenerator>>isNode:constantValueWithinRangeOfType: (in category 'type inference') ----- + isNode: aNode constantValueWithinRangeOfType: aType + "Answer if aNode is a constant value within the range of an integral type. + If aNode isn't an integral constant or aType isn't an integral type then answer false." + | value | + ^aNode expression isConstant + and: [(self isIntegralCType: aType) + and: [(value := aNode expression value) isInteger + and: [value positive + and: [(aType first = $u + ifTrue: [value digitLength] + ifFalse: [value highBit + 7 // 8]) <= (self sizeOfIntegralCType: aType)]]]]! Item was changed: ----- Method: TMethod>>propagateReturnIn: (in category 'inlining support') ----- propagateReturnIn: aCodeGen "Propagate the return type to all return nodes" | map coercionType | returnType = #void ifTrue: [^self]. "The following is necessary for functions returning functions, which have problematic syntax" coercionType := aCodeGen extractTypeFor: (aCodeGen cFunctionNameFor: self selector) fromDeclaration: returnType. map := IdentityDictionary new. parseTree nodesDo:[:node| (node isReturn + and: [(aCodeGen typeFor: node expression in: self) ~= coercionType + and: [(aCodeGen isNode: node constantValueWithinRangeOfType: coercionType) not]]) ifTrue: + [map at: node expression put: (aCodeGen nodeToCast: node expression to: coercionType)]]. - and: [(aCodeGen typeFor: node expression in: self) ~= coercionType]) ifTrue: - [map at: node expression put: (TSendNode new - setSelector: #cCoerce:to: - receiver: (TVariableNode new setName: 'self') - arguments: {node expression. - TConstantNode new setValue: coercionType})]]. self replaceNodesIn: map! Item was changed: ----- Method: TStmtListNode>>emitCCodeAsArgumentOn:level:generator: (in category 'C code generation') ----- emitCCodeAsArgumentOn: aStream level: level generator: aCodeGen | size | (size := statements size) = 1 ifTrue: [^statements first emitCCodeAsArgumentOn: aStream level: level generator: aCodeGen]. + "Get rid of the annoying newlines in ? : if-then-elses" + (size = 2 and: [statements first isComment and: [statements last isLeaf]]) ifTrue: + [statements first emitCCodeAsArgumentOn: aStream level: 0 generator: aCodeGen. + aStream space. + ^statements last emitCCodeAsArgumentOn: aStream level: 0 generator: aCodeGen]. aStream nextPut: $(. "N.B. Comma binds weakest of all C operators." statements withIndexDo: [:s :idx| | p1 p2 | p1 := aStream position. s emitCCommentOn: aStream level: level generator: aCodeGen. (s isLeaf and: [s isLabel not and: [idx < statements size]]) ifFalse: [s emitCCodeAsArgumentOn: aStream level: level + 1 generator: aCodeGen]. p2 := aStream position. (idx < size and: [p2 > p1]) ifTrue: [((self endsWithCloseBracket: aStream) or: [s isComment]) ifFalse: [aStream nextPut: $,]. aStream crtab: level]]. aStream nextPut: $)!

1 0

VM Maker: VMMaker.oscog-eem.2289.mcz
by commits＠source.squeak.org 08 Dec '17

08 Dec '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2289.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2289 Author: eem Time: 7 December 2017, 7:53:17.487328 pm UUID: 2cc5ca31-b578-409a-81c2-4502a4cb0732 Ancestors: VMMaker.oscog-eem.2288 Add support for conveying os/library error codes through a special primitive failure code object. The error code is a signed 64-bit value (so that e.g. answering -1 is not expensive). Specific image-level clients can map that value to unsigned as appropriate. Make sure ceReapAndResetErrorCodeFor: is exported to the Cogit. Document that primitive 255 ius reserved for use as a failure flag by the R/Squeak VM. =============== Diff against VMMaker.oscog-eem.2288 =============== Item was changed: ----- Method: CoInterpreter>>ceReapAndResetErrorCodeFor: (in category 'trampolines') ----- ceReapAndResetErrorCodeFor: cogMethod + <api> <var: #cogMethod type: #'CogMethod *'> self break. self assert: primFailCode ~= 0. newMethod := cogMethod methodObject. self reapAndResetErrorCodeTo: stackPointer header: cogMethod methodHeader! Item was removed: - ----- Method: CoInterpreter>>getErrorObjectFromPrimFailCode (in category 'message sending') ----- - getErrorObjectFromPrimFailCode - "Answer the errorCode object to supply to a failing primitive method that accepts one. - If there is a primitive error table and the primFailCode is a valid index there-in answer - the corresponding entry in the table, otherwise simply answer the code as an integer." - ^super getErrorObjectFromPrimFailCode! Item was changed: VMClass subclass: #InterpreterPrimitives + instanceVariableNames: 'objectMemory messageSelector argumentCount newMethod primFailCode osErrorCode profileMethod profileProcess profileSemaphore nextProfileTick preemptionYields newFinalization sHEAFn' - instanceVariableNames: 'objectMemory messageSelector argumentCount newMethod primFailCode profileMethod profileProcess profileSemaphore nextProfileTick preemptionYields newFinalization sHEAFn' classVariableNames: 'CrossedX EndOfRun MillisecondClockMask' poolDictionaries: 'VMBasicConstants VMBytecodeConstants VMMethodCacheConstants VMObjectIndices VMSqueakClassIndices VMStackFrameOffsets' category: 'VMMaker-Interpreter'! + !InterpreterPrimitives commentStamp: 'eem 12/7/2017 18:44' prior: 0! - !InterpreterPrimitives commentStamp: 'eem 12/7/2017 11:21' prior: 0! InterpreterPrimitives implements most of the VM's core primitives. It is the root of the interpreter hierarchy so as to share the core primitives amongst the varioius interpreters. Instance Variables argumentCount: <Integer> messageSelector: <Integer> newMethod: <Integer> nextProfileTick: <Integer> objectMemory: <ObjectMemory> (simulation only) preemptionYields: <Boolean> primFailCode: <Integer> + osErrorCode: <Integer> profileMethod: <Integer> profileProcess: <Integer> profileSemaphore: <Integer> secHasEnvironmentAccess <Integer> argumentCount - the number of arguments of the current message messageSelector - the oop of the selector of the current message newMethod - the oop of the result of looking up the current message nextProfileTick - the millisecond clock value of the next profile tick (if profiling is in effect) objectMemory - the memory manager and garbage collector that manages the heap preemptionYields - a boolean controlling the process primitives. If true (old, incorrect, blue-book semantics) a preempted process is sent to the back of its run-queue. If false, a process preempted by a higher-priority process is put back at the head of its run queue, hence preserving cooperative scheduling within priorities. primFailCode + - primitive success/failure flag, 0 for success, otherwise the reason code for failure - - primtiive success/failure flag, 0 for success, otherwise the reason code for failure + osErrorCode + - a 64-bit value settable by external primitives conveying arbitrary error codes from the operating system and/or system libraries + profileMethod - the oop of the method at the time nextProfileTick was reached profileProcess - the oop of the activeProcess at the time nextProfileTick was reached profileSemaphore - the oop of the semaphore to signal when nextProfileTick is reached secHasEnvironmentAccess - the function to call to check if access to the envronment should be granted to primitiveGetenv ! Item was changed: ----- Method: InterpreterPrimitives class>>declareCVarsIn: (in category 'C translation') ----- declareCVarsIn: aCCodeGen + aCCodeGen + var: 'osErrorCode' type: #sqLong; + var: 'sHEAFn' declareC: 'int (*sHEAFn)() = 0' "the hasEnvironmentAccess function"! - aCCodeGen var: 'sHEAFn' declareC: 'int (*sHEAFn)() = 0' "the hasEnvironmentAccess function"! Item was added: + ----- Method: InterpreterPrimitives>>primitiveFailForOSError: (in category 'primitive support') ----- + primitiveFailForOSError: osError + <var: 'osError' type: #sqLong> + "Set PrimErrOSError primitive failure and associated osErrorCode." + <api> + osErrorCode := osError. + ^primFailCode := PrimErrOSError! Item was changed: Object subclass: #InterpreterProxy + instanceVariableNames: 'primFailCode remapBuffer stack method argumentCount bb thisSessionID osErrorCode' - instanceVariableNames: 'primFailCode remapBuffer stack method argumentCount bb thisSessionID' classVariableNames: '' + poolDictionaries: 'VMBasicConstants' - poolDictionaries: '' category: 'VMMaker-InterpreterSimulation'! + !InterpreterProxy commentStamp: 'eem 12/7/2017 19:37' prior: 0! + This class should provide the definition of what interpreter support plugins need and can have access to. Note that the proxy related files platforms - Cross - vm - sqVirtualMachine.[ch] are kept under the git tree at http://www.github.com/opensmalltalk/vm. - !InterpreterProxy commentStamp: '<historical>' prior: 0! - This class should provide the definition of what interpreter support plugins need and can have access to. Note that the proxy related files platforms - Cross - vm - sqVirtualMachine.[ch] are kept under the SVN tree at www.squeakvm.org . The main use of the class is to support the vm simulator! Item was added: + ----- Method: InterpreterProxy>>primitiveFailForOSError: (in category 'other') ----- + primitiveFailForOSError: osError + <var: 'osError' type: #sqLong> + "Set PrimErrOSError primitive failure and associated osErrorCode. + Primitive 255 is called to indicate that we are currently simulating a primitive that should fail and the VM should handle that case appropriately (if supported by the VM)." + <primitive: 255> + osErrorCode := osError. + ^primFailCode := PrimErrOSError! Item was added: + ----- Method: ObjectMemory>>nonIndexablePointerFormat (in category 'header formats') ----- + nonIndexablePointerFormat + ^1! Item was changed: ----- Method: StackInterpreter class>>initializePrimitiveTable (in category 'initialization') ----- (excessive size, no diff calculated) Item was changed: ----- Method: StackInterpreter class>>vmProxyMinorVersion (in category 'api version') ----- vmProxyMinorVersion "Define the VM_PROXY_MINOR version for this VM as used to define the api in platforms/Cross/vm/sqVirtualMachine.[ch]" + ^14 "primitiveFailForOSError: added"! - ^14 "statNumGCs added"! Item was added: + ----- Method: StackInterpreter>>cloneOSErrorObj:numSlots: (in category 'message sending') ----- + cloneOSErrorObj: errObj numSlots: numSlots + "If errObj is a pointer object with at least two slots, then answer a clone + of the error object with the second slot set to the value of osErrorCode." + | clone | + <inline: true> + clone := objectMemory hasSpurMemoryManagerAPI + ifTrue: [objectMemory + eeInstantiateSmallClassIndex: (objectMemory classIndexOf: errObj) + format: objectMemory nonIndexablePointerFormat + numSlots: numSlots] + ifFalse: [objectMemory + eeInstantiateSmallClass: (objectMemory fetchClassOfNonImm: errObj) + numSlots: numSlots]. + 0 to: numSlots - 1 do: + [:i| objectMemory + storePointerUnchecked: i + ofObject: clone + withValue: (objectMemory fetchPointer: i ofObject: errObj)]. + objectMemory + storePointerUnchecked: 1 + ofObject: clone + withValue: (self signed64BitIntegerFor: osErrorCode). + ^clone! Item was changed: ----- Method: StackInterpreter>>getErrorObjectFromPrimFailCode (in category 'message sending') ----- getErrorObjectFromPrimFailCode "Answer the errorCode object to supply to a failing primitive method that accepts one. If there is a primitive error table and the primFailCode is a valid index there-in answer the corresponding entry in the table, otherwise simply answer the code as an integer." + | table errObj numSlots | - | table | primFailCode > 0 ifTrue: [table := objectMemory splObj: PrimErrTableIndex. primFailCode <= (objectMemory numSlotsOf: table) ifTrue: + [errObj := objectMemory followField: primFailCode - 1 ofObject: table. + "If this is a PrimErrOSError and there's a clonable object in the table at that index, + answer a clone of the error object with the second slot set to the value of osErrorCode." + (primFailCode = PrimErrOSError + and: [(objectMemory formatOf: errObj) = objectMemory nonIndexablePointerFormat + and: [(numSlots := objectMemory numSlotsOf: errObj) >= 2]]) ifTrue: + [errObj := self cloneOSErrorObj: errObj numSlots: numSlots]. + ^errObj]]. - [^objectMemory fetchPointer: primFailCode - 1 ofObject: table]]. ^objectMemory integerObjectOf: primFailCode! Item was changed: SharedPool subclass: #VMBasicConstants instanceVariableNames: '' + classVariableNames: 'BaseHeaderSize BytecodeSetHasExtensions BytesPerOop BytesPerWord COGMTVM COGVM DisownVMLockOutFullGC DoAssertionChecks DoExpensiveAssertionChecks GCCheckPrimCall GCModeBecome GCModeFreeSpace GCModeFull GCModeImageSegment GCModeIncremental GCModeNewSpace HashMultiplyConstant HashMultiplyMask IMMUTABILITY LowcodeVM MULTIPLEBYTECODESETS NewspeakVM PharoVM PrimErrBadArgument PrimErrBadIndex PrimErrBadMethod PrimErrBadNumArgs PrimErrBadReceiver PrimErrCallbackError PrimErrGenericFailure PrimErrInappropriate PrimErrLimitExceeded PrimErrNamedInternal PrimErrNoCMemory PrimErrNoMemory PrimErrNoModification PrimErrNotFound PrimErrOSError PrimErrObjectIsPinned PrimErrObjectMayMove PrimErrObjectMoved PrimErrObjectNotPinned PrimErrUnsupported PrimErrWritePastObject PrimNoErr SPURVM STACKVM SistaVM VMBIGENDIAN' - classVariableNames: 'BaseHeaderSize BytecodeSetHasExtensions BytesPerOop BytesPerWord COGMTVM COGVM DisownVMLockOutFullGC DoAssertionChecks DoExpensiveAssertionChecks GCCheckPrimCall GCModeBecome GCModeFreeSpace GCModeFull GCModeImageSegment GCModeIncremental GCModeNewSpace HashMultiplyConstant HashMultiplyMask IMMUTABILITY LowcodeVM MULTIPLEBYTECODESETS NewspeakVM PharoVM PrimErrBadArgument PrimErrBadIndex PrimErrBadMethod PrimErrBadNumArgs PrimErrBadReceiver PrimErrCallbackError PrimErrGenericFailure PrimErrInappropriate PrimErrLimitExceeded PrimErrNamedInternal PrimErrNoCMemory PrimErrNoMemory PrimErrNoModification PrimErrNotFound PrimErrObjectIsPinned PrimErrObjectMayMove PrimErrObjectMoved PrimErrObjectNotPinned PrimErrUnsupported PrimErrWritePastObject PrimNoErr SPURVM STACKVM SistaVM VMBIGENDIAN' poolDictionaries: '' category: 'VMMaker-Interpreter'! !VMBasicConstants commentStamp: '<historical>' prior: 0! I am a shared pool for basic constants upon which the VM as a whole depends. self ensureClassPool. self classPool declare: #BytesPerWord from: VMSqueakV3ObjectRepresentationConstants classPool. self classPool declare: #BaseHeaderSize from: VMSqueakV3ObjectRepresentationConstants classPool (ObjectMemory classPool keys select: [:k| k beginsWith: 'Byte']) do: [:k| self classPool declare: k from: ObjectMemory classPool]! Item was changed: ----- Method: VMClass class>>initializePrimitiveErrorCodes (in category 'initialization') ----- initializePrimitiveErrorCodes "Define the VM's primitive error codes. N.B. these are replicated in platforms/Cross/vm/sqVirtualMachine.h." "VMClass initializePrimitiveErrorCodes" | pet | PrimErrTableIndex := 51. "Zero-relative" "See SmalltalkImage>>recreateSpecialObjectsArray for the table definition. If the table exists and is large enough the corresponding entry is returned as the primitive error, otherwise the error is answered numerically." pet := Smalltalk specialObjectsArray at: PrimErrTableIndex + 1 ifAbsent: [#()]. pet isArray ifFalse: [pet := #()]. PrimNoErr := 0. "for helper methods that need to answer success or an error code." PrimErrGenericFailure := pet indexOf: nil ifAbsent: 1. PrimErrBadReceiver := pet indexOf: #'bad receiver' ifAbsent: 2. PrimErrBadArgument := pet indexOf: #'bad argument' ifAbsent: 3. PrimErrBadIndex := pet indexOf: #'bad index' ifAbsent: 4. PrimErrBadNumArgs := pet indexOf: #'bad number of arguments' ifAbsent: 5. PrimErrInappropriate := pet indexOf: #'inappropriate operation' ifAbsent: 6. PrimErrUnsupported := pet indexOf: #'unsupported operation' ifAbsent: 7. PrimErrNoModification := pet indexOf: #'no modification' ifAbsent: 8. PrimErrNoMemory := pet indexOf: #'insufficient object memory' ifAbsent: 9. PrimErrNoCMemory := pet indexOf: #'insufficient C memory' ifAbsent: 10. PrimErrNotFound := pet indexOf: #'not found' ifAbsent: 11. PrimErrBadMethod := pet indexOf: #'bad method' ifAbsent: 12. PrimErrNamedInternal := pet indexOf: #'internal error in named primitive machinery' ifAbsent: 13. PrimErrObjectMayMove := pet indexOf: #'object may move' ifAbsent: 14. PrimErrLimitExceeded := pet indexOf: #'resource limit exceeded' ifAbsent: 15. PrimErrObjectIsPinned := pet indexOf: #'object is pinned' ifAbsent: 16. PrimErrWritePastObject := pet indexOf: #'primitive write beyond end of object' ifAbsent: 17. PrimErrObjectMoved := pet indexOf: #'object moved' ifAbsent: 18. PrimErrObjectNotPinned := pet indexOf: #'object not pinned' ifAbsent: 19. + PrimErrCallbackError := pet indexOf: #'error in callback' ifAbsent: 20. + PrimErrOSError := pet indexOf: #'operating system error' ifAbsent: 21! - PrimErrCallbackError := pet indexOf: #'error in callback' ifAbsent: 20!

1 0

VM Maker: VMMaker.oscog-eem.2288.mcz
by commits＠source.squeak.org 08 Dec '17

08 Dec '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2288.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2288 Author: eem Time: 7 December 2017, 6:03:19.789714 pm UUID: 25ebdfbd-1a60-4052-bacc-1cb49ec6f83b Ancestors: VMMaker.oscog-eem.2287 Refactor reaping the primFailCode on method activation to pull it out of the common path and hence lay the ground for a platform error object since all failures now call a single reapAndResetErrorCodeTo:header: =============== Diff against VMMaker.oscog-eem.2287 =============== Item was changed: ----- Method: CoInterpreter>>activateCoggedNewMethod: (in category 'message sending') ----- activateCoggedNewMethod: inInterpreter "Activate newMethod when newMethod has been cogged, i.e. create a machine-code frame and (re)enter machine-code." + | methodHeader cogMethod rcvr numTemps switched | - | methodHeader cogMethod rcvr numTemps errorCode switched | <var: #cogMethod type: #'CogMethod *'> methodHeader := self rawHeaderOf: newMethod. self assert: (self isCogMethodReference: methodHeader). cogMethod := self cCoerceSimple: methodHeader to: #'CogMethod *'. methodHeader := cogMethod methodHeader. rcvr := self stackValue: cogMethod cmNumArgs. "could new rcvr be set at point of send?" self push: instructionPointer. cogMethod stackCheckOffset = 0 ifTrue: ["frameless method; nothing to activate..." cogit numRegArgs > 0 ifTrue: "dont use and: so as to get Slang to inline cogit numRegArgs > 0" [cogMethod cmNumArgs <= cogit numRegArgs ifTrue: [self callRegisterArgCogMethod: cogMethod at: cogit noCheckEntryOffset receiver: rcvr]]. self push: cogMethod asInteger + cogit noCheckEntryOffset. self push: rcvr. cogit ceCallCogCodePopReceiverReg. self error: 'should not be reached']. self push: framePointer. framePointer := stackPointer. self push: cogMethod asInteger. self push: objectMemory nilObject. "FxThisContext field" self push: rcvr. "clear remaining temps to nil" numTemps := self temporaryCountOfMethodHeader: methodHeader. cogMethod cmNumArgs + 1 to: numTemps do: [:i | self push: objectMemory nilObject]. + ((self methodHeaderHasPrimitive: methodHeader) + and: [primFailCode ~= 0]) ifTrue: + [self reapAndResetErrorCodeTo: stackPointer header: methodHeader]. - (self methodHeaderHasPrimitive: methodHeader) ifTrue: - [| initialPC | - "Store the error code if the method starts with a long store temp. No instructionPointer skip because we're heading for machine code." - initialPC := (self initialIPForHeader: methodHeader method: newMethod) + (self sizeOfCallPrimitiveBytecode: methodHeader). - primFailCode ~= 0 ifTrue: - [(objectMemory byteAt: initialPC) = (self longStoreBytecodeForHeader: methodHeader) ifTrue: - [errorCode := self getErrorObjectFromPrimFailCode. - self stackTopPut: errorCode "nil if primFailCode == 1, or primFailCode"]. - primFailCode := 0]]. "Now check for stack overflow or an event (interrupt, must scavenge, etc)." stackPointer >= stackLimit ifTrue: [self assert: cogMethod stackCheckOffset > cogit noCheckEntryOffset. self push: cogMethod asInteger + cogMethod stackCheckOffset. self push: rcvr. cogit ceEnterCogCodePopReceiverReg. self error: 'should not be reached']. instructionPointer := cogMethod asInteger + cogMethod stackCheckOffset. switched := self handleStackOverflowOrEventAllowContextSwitch: (self canContextSwitchIfActivating: newMethod header: methodHeader). self returnToExecutive: inInterpreter postContextSwitch: switched! Item was changed: ----- Method: CoInterpreter>>activateNewMethod (in category 'message sending') ----- activateNewMethod + | methodHeader numArgs numTemps rcvr inInterpreter switched | - | methodHeader numArgs numTemps rcvr errorCode inInterpreter switched | methodHeader := objectMemory methodHeaderOf: newMethod. numTemps := self temporaryCountOfMethodHeader: methodHeader. numArgs := self argumentCountOfMethodHeader: methodHeader. rcvr := self stackValue: numArgs. "could new rcvr be set at point of send?" self assert: (objectMemory isOopForwarded: rcvr) not. "Because this is an uncogged method we need to continue via the interpreter. We could have been reached either from the interpreter, in which case we should simply return, or from a machine code frame or from a compiled primitive. In these latter two cases we must longjmp back to the interpreter. The instructionPointer tells us which path we took. If the sender was an interpreter frame but called through a (failing) primitive then make sure we restore the saved instruction pointer and avoid pushing ceReturnToInterpreterPC which is only valid between an interpreter caller frame and a machine code callee frame." (inInterpreter := instructionPointer >= objectMemory startOfMemory) ifFalse: [instructionPointer = cogit ceReturnToInterpreterPC ifTrue: [instructionPointer := self iframeSavedIP: framePointer]]. self push: instructionPointer. self push: framePointer. framePointer := stackPointer. self push: newMethod. self setMethod: newMethod methodHeader: methodHeader. self push: objectMemory nilObject. "FxThisContext field" self push: (self encodeFrameFieldHasContext: false isBlock: false numArgs: numArgs). self push: 0. "FoxIFSavedIP" self push: rcvr. "clear remaining temps to nil" numArgs+1 to: numTemps do: [:i | self push: objectMemory nilObject]. instructionPointer := (self initialIPForHeader: methodHeader method: newMethod) - 1. (self methodHeaderHasPrimitive: methodHeader) ifTrue: ["Skip the CallPrimitive bytecode, if it's there, and store the error code if the method starts with a long store temp. Strictly no need to skip the store because it's effectively a noop." instructionPointer := instructionPointer + (self sizeOfCallPrimitiveBytecode: methodHeader). primFailCode ~= 0 ifTrue: + [self reapAndResetErrorCodeTo: stackPointer header: methodHeader]]. - [(objectMemory byteAt: instructionPointer + 1) - = (self longStoreBytecodeForHeader: methodHeader) ifTrue: - [errorCode := self getErrorObjectFromPrimFailCode. - self stackTopPut: errorCode "nil if primFailCode == 1, or primFailCode"]. - primFailCode := 0]]. "Now check for stack overflow or an event (interrupt, must scavenge, etc)." switched := true. stackPointer < stackLimit ifTrue: [switched := self handleStackOverflowOrEventAllowContextSwitch: (self canContextSwitchIfActivating: newMethod header: methodHeader)]. self returnToExecutive: inInterpreter postContextSwitch: switched! Item was added: + ----- Method: CoInterpreter>>ceReapAndResetErrorCodeFor: (in category 'trampolines') ----- + ceReapAndResetErrorCodeFor: cogMethod + <var: #cogMethod type: #'CogMethod *'> + self break. + self assert: primFailCode ~= 0. + newMethod := cogMethod methodObject. + self reapAndResetErrorCodeTo: stackPointer header: cogMethod methodHeader! Item was added: + ----- Method: CoInterpreter>>getErrorObjectFromPrimFailCode (in category 'message sending') ----- + getErrorObjectFromPrimFailCode + "Answer the errorCode object to supply to a failing primitive method that accepts one. + If there is a primitive error table and the primFailCode is a valid index there-in answer + the corresponding entry in the table, otherwise simply answer the code as an integer." + ^super getErrorObjectFromPrimFailCode! Item was changed: ----- Method: CoInterpreter>>internalActivateNewMethod (in category 'message sending') ----- internalActivateNewMethod + | methodHeader numTemps rcvr switched | - | methodHeader numTemps rcvr errorCode switched | <inline: true> methodHeader := self rawHeaderOf: newMethod. self assert: (self isCogMethodReference: methodHeader) not. numTemps := self temporaryCountOfMethodHeader: methodHeader. self assert: argumentCount = (self argumentCountOfMethodHeader: methodHeader). rcvr := self internalStackValue: argumentCount. "could new rcvr be set at point of send?" self assert: (objectMemory isOopForwarded: rcvr) not. self internalPush: localIP. self internalPush: localFP. localFP := localSP. self internalPush: newMethod. self setMethod: newMethod methodHeader: methodHeader. self internalPush: objectMemory nilObject. "FxThisContext field" self internalPush: (self encodeFrameFieldHasContext: false isBlock: false numArgs: (self argumentCountOfMethodHeader: methodHeader)). self internalPush: 0. "FoxIFSavedIP" self internalPush: rcvr. "Initialize temps..." argumentCount + 1 to: numTemps do: [:i | self internalPush: objectMemory nilObject]. "-1 to account for pre-increment in fetchNextBytecode" localIP := self pointerForOop: (self initialIPForHeader: methodHeader method: newMethod) - 1. (self methodHeaderHasPrimitive: methodHeader) ifTrue: ["Skip the CallPrimitive bytecode, if it's there, and store the error code if the method starts with a long store temp. Strictly no need to skip the store because it's effectively a noop." localIP := localIP + (self sizeOfCallPrimitiveBytecode: methodHeader). primFailCode ~= 0 ifTrue: + [self reapAndResetErrorCodeTo: localSP header: methodHeader]]. - [(objectMemory byteAt: localIP + 1) - = (self longStoreBytecodeForHeader: methodHeader) ifTrue: - [errorCode := self getErrorObjectFromPrimFailCode. - self internalStackTopPut: errorCode "nil if primFailCode == 1, or primFailCode"]. - primFailCode := 0]]. self assert: (self frameNumArgs: localFP) == argumentCount. self assert: (self frameIsBlockActivation: localFP) not. self assert: (self frameHasContext: localFP) not. "Now check for stack overflow or an event (interrupt, must scavenge, etc)." localSP < stackLimit ifTrue: [self externalizeIPandSP. switched := self handleStackOverflowOrEventAllowContextSwitch: (self canContextSwitchIfActivating: newMethod header: methodHeader). self returnToExecutive: true postContextSwitch: switched. self internalizeIPandSP]! Item was changed: ----- Method: CoInterpreter>>justActivateNewMethod (in category 'message sending') ----- justActivateNewMethod + | methodHeader activateCogMethod cogMethod numArgs numTemps rcvr initialIP | - | methodHeader activateCogMethod cogMethod numArgs numTemps rcvr errorCode initialIP | <var: #cogMethod type: #'CogMethod *'> <var: #initialIP type: #usqInt> <inline: true> methodHeader := self rawHeaderOf: newMethod. (activateCogMethod := self isCogMethodReference: methodHeader) ifTrue: [cogMethod := self cCoerceSimple: methodHeader to: #'CogMethod *'. methodHeader := cogMethod methodHeader]. numTemps := self temporaryCountOfMethodHeader: methodHeader. numArgs := self argumentCountOfMethodHeader: methodHeader. rcvr := self stackValue: numArgs. "could new rcvr be set at point of send?" self assert: (objectMemory isOopForwarded: rcvr) not. (activateCogMethod and: [instructionPointer asUnsignedInteger >= objectMemory startOfMemory]) ifTrue: [self iframeSavedIP: framePointer put: instructionPointer. instructionPointer := cogit ceReturnToInterpreterPC]. self push: instructionPointer. self push: framePointer. framePointer := stackPointer. initialIP := self initialIPForHeader: methodHeader method: newMethod. activateCogMethod ifTrue: [self push: cogMethod asUnsignedInteger. self push: objectMemory nilObject. "FoxThisContext field" instructionPointer := cogMethod asUnsignedInteger + cogMethod stackCheckOffset] ifFalse: [self push: newMethod. self setMethod: newMethod methodHeader: methodHeader. self push: objectMemory nilObject. "FoxThisContext field" self push: (self encodeFrameFieldHasContext: false isBlock: false numArgs: numArgs). self push: 0. "FoxIFSavedIP" instructionPointer := initialIP - 1]. self push: rcvr. "clear remaining temps to nil" numArgs+1 to: numTemps do: [:i | self push: objectMemory nilObject]. (self methodHeaderHasPrimitive: methodHeader) ifTrue: ["Skip the CallPrimitive bytecode, if it's there, and store the error code if the method starts with a long store temp. Strictly no need to skip the store because it's effectively a noop." - initialIP := initialIP + (self sizeOfCallPrimitiveBytecode: methodHeader). activateCogMethod ifFalse: + [instructionPointer := initialIP + (self sizeOfCallPrimitiveBytecode: methodHeader)]. - [instructionPointer := initialIP]. primFailCode ~= 0 ifTrue: + [self reapAndResetErrorCodeTo: stackPointer header: methodHeader]]. - [(objectMemory byteAt: initialIP + 1) - = (self longStoreBytecodeForHeader: methodHeader) ifTrue: - [errorCode := self getErrorObjectFromPrimFailCode. - self stackTopPut: errorCode "nil if primFailCode == 1, or primFailCode"]. - primFailCode := 0]]. ^methodHeader! Item was changed: ----- Method: CogVMSimulator>>saneFunctionPointerForFailureOfPrimIndex: (in category 'primitive support') ----- saneFunctionPointerForFailureOfPrimIndex: primIndex + "For simulation override to do the check specially when the + primitiveFunctionPointer is an invalid address proxy for a primitive." | basePrimitive | (instructionPointer < objectMemory nilObject asUnsignedInteger + and: [primitiveFunctionPointer isInteger + and: [self isPrimitiveFunctionPointerAnIndex not + and: [primIndex ~= PrimNumberExternalCall + and: [(self isMetaPrimitiveIndex: primIndex) not]]]]) ifTrue: - and: [primitiveFunctionPointer isInteger]) ifTrue: [basePrimitive := self functionPointerFor: primIndex inClass: objectMemory nilObject. ^(cogit lookupAddress: primitiveFunctionPointer) endsWith: basePrimitive]. ^super saneFunctionPointerForFailureOfPrimIndex: primIndex! Item was changed: CogClass subclass: #Cogit + instanceVariableNames: 'coInterpreter objectMemory objectRepresentation processor threadManager methodZone methodZoneBase codeBase minValidCallAddress lastNInstructions simulatedAddresses simulatedTrampolines simulatedVariableGetters simulatedVariableSetters printRegisters printInstructions compilationTrace clickConfirm breakPC breakBlock singleStep guardPageSize traceFlags traceStores breakMethod methodObj enumeratingCogMethod methodHeader initialPC endPC methodOrBlockNumArgs inBlock needsFrame hasYoungReferent primitiveIndex backEnd literalsManager postCompileHook methodLabel stackCheckLabel blockEntryLabel blockEntryNoContextSwitch blockNoContextSwitchOffset stackOverflowCall sendMiss missOffset entryPointMask checkedEntryAlignment uncheckedEntryAlignment cmEntryOffset entry cmNoCheckEntryOffset noCheckEntry fullBlockEntry cbEntryOffset fullBlockNoContextSwitchEntry cbNoSwitchEntryOffset picMNUAbort picInterpretAbort endCPICCase0 endCPICCase1 firstCPICCaseOffset cPICCaseSize cP ICEndSize closedPICSize openPICSize fixups abstractOpcodes generatorTable byte0 byte1 byte2 byte3 bytecodePC bytecodeSetOffset opcodeIndex numAbstractOpcodes blockStarts blockCount labelCounter cStackAlignment expectedSPAlignment expectedFPAlignment codeModified maxLitIndex ceMethodAbortTrampoline cePICAbortTrampoline ceCheckForInterruptTrampoline ceCPICMissTrampoline ceReturnToInterpreterTrampoline ceBaseFrameReturnTrampoline ceReapAndResetErrorCodeTrampoline ceSendMustBeBooleanAddTrueTrampoline ceSendMustBeBooleanAddFalseTrampoline ceCannotResumeTrampoline ceEnterCogCodePopReceiverReg ceCallCogCodePopReceiverReg ceCallCogCodePopReceiverAndClassRegs cePrimReturnEnterCogCode cePrimReturnEnterCogCodeProfiling ceNonLocalReturnTrampoline ceFetchContextInstVarTrampoline ceStoreContextInstVarTrampoline ceEnclosingObjectTrampoline ceFlushICache ceCheckFeaturesFunction ceTraceLinkedSendTrampoline ceTraceBlockActivationTrampoline ceTraceStoreTrampoline ceGetFP ceGetSP ceCaptureCStackPointer s ordinarySendTrampolines superSendTrampolines directedSuperSendTrampolines dynamicSuperSendTrampolines outerSendTrampolines selfSendTrampolines firstSend lastSend realCEEnterCogCodePopReceiverReg realCECallCogCodePopReceiverReg realCECallCogCodePopReceiverAndClassRegs trampolineTableIndex trampolineAddresses objectReferencesInRuntime runtimeObjectRefIndex cFramePointerInUse debugPrimCallStackOffset ceTryLockVMOwner ceUnlockVMOwner extA extB numExtB tempOop numIRCs indexOfIRC theIRCs receiverTags implicitReceiverSendTrampolines cogMethodSurrogateClass cogBlockMethodSurrogateClass nsSendCacheSurrogateClass CStackPointer CFramePointer cPICPrototype cPICEndOfCodeOffset cPICEndOfCodeLabel ceMallocTrampoline ceFreeTrampoline ceFFICalloutTrampoline debugBytecodePointers debugOpcodeIndices disassemblingMethod cogConstituentIndex' - instanceVariableNames: 'coInterpreter objectMemory objectRepresentation processor threadManager methodZone methodZoneBase codeBase minValidCallAddress lastNInstructions simulatedAddresses simulatedTrampolines simulatedVariableGetters simulatedVariableSetters printRegisters printInstructions compilationTrace clickConfirm breakPC breakBlock singleStep guardPageSize traceFlags traceStores breakMethod methodObj enumeratingCogMethod methodHeader initialPC endPC methodOrBlockNumArgs inBlock needsFrame hasYoungReferent primitiveIndex backEnd literalsManager postCompileHook methodLabel stackCheckLabel blockEntryLabel blockEntryNoContextSwitch blockNoContextSwitchOffset stackOverflowCall sendMiss missOffset entryPointMask checkedEntryAlignment uncheckedEntryAlignment cmEntryOffset entry cmNoCheckEntryOffset noCheckEntry fullBlockEntry cbEntryOffset fullBlockNoContextSwitchEntry cbNoSwitchEntryOffset picMNUAbort picInterpretAbort endCPICCase0 endCPICCase1 firstCPICCaseOffset cPICCaseSize cP ICEndSize closedPICSize openPICSize fixups abstractOpcodes generatorTable byte0 byte1 byte2 byte3 bytecodePC bytecodeSetOffset opcodeIndex numAbstractOpcodes blockStarts blockCount labelCounter cStackAlignment expectedSPAlignment expectedFPAlignment codeModified maxLitIndex ceMethodAbortTrampoline cePICAbortTrampoline ceCheckForInterruptTrampoline ceCPICMissTrampoline ceReturnToInterpreterTrampoline ceBaseFrameReturnTrampoline ceSendMustBeBooleanAddTrueTrampoline ceSendMustBeBooleanAddFalseTrampoline ceCannotResumeTrampoline ceEnterCogCodePopReceiverReg ceCallCogCodePopReceiverReg ceCallCogCodePopReceiverAndClassRegs cePrimReturnEnterCogCode cePrimReturnEnterCogCodeProfiling ceNonLocalReturnTrampoline ceFetchContextInstVarTrampoline ceStoreContextInstVarTrampoline ceEnclosingObjectTrampoline ceFlushICache ceCheckFeaturesFunction ceTraceLinkedSendTrampoline ceTraceBlockActivationTrampoline ceTraceStoreTrampoline ceGetFP ceGetSP ceCaptureCStackPointers ordinarySendTrampolines superSen dTrampolines directedSuperSendTrampolines dynamicSuperSendTrampolines outerSendTrampolines selfSendTrampolines firstSend lastSend realCEEnterCogCodePopReceiverReg realCECallCogCodePopReceiverReg realCECallCogCodePopReceiverAndClassRegs trampolineTableIndex trampolineAddresses objectReferencesInRuntime runtimeObjectRefIndex cFramePointerInUse debugPrimCallStackOffset ceTryLockVMOwner ceUnlockVMOwner extA extB numExtB tempOop numIRCs indexOfIRC theIRCs receiverTags implicitReceiverSendTrampolines cogMethodSurrogateClass cogBlockMethodSurrogateClass nsSendCacheSurrogateClass CStackPointer CFramePointer cPICPrototype cPICEndOfCodeOffset cPICEndOfCodeLabel ceMallocTrampoline ceFreeTrampoline ceFFICalloutTrampoline debugBytecodePointers debugOpcodeIndices disassemblingMethod cogConstituentIndex' classVariableNames: 'AltBlockCreationBytecodeSize AltFirstSpecialSelector AltNSSendIsPCAnnotated AltNumSpecialSelectors AnnotationConstantNames AnnotationShift AnnotationsWithBytecodePCs BlockCreationBytecodeSize Debug DisplacementMask DisplacementX2N EagerInstructionDecoration FirstAnnotation FirstSpecialSelector HasBytecodePC IsAbsPCReference IsAnnotationExtension IsDirectedSuperSend IsDisplacementX2N IsNSDynamicSuperSend IsNSImplicitReceiverSend IsNSSelfSend IsNSSendCall IsObjectReference IsRelativeCall IsSendCall IsSuperSend MapEnd MaxCPICCases MaxCompiledPrimitiveIndex MaxStackAllocSize MaxX2NDisplacement NSCClassTagIndex NSCEnclosingObjectIndex NSCNumArgsIndex NSCSelectorIndex NSCTargetIndex NSSendIsPCAnnotated NumObjRefsInRuntime NumOopsPerNSC NumSpecialSelectors NumTrampolines ProcessorClass RRRName' poolDictionaries: 'CogAbstractRegisters CogCompilationConstants CogMethodConstants CogRTLOpcodes VMBasicConstants VMBytecodeConstants VMObjectIndices VMStackFrameOffsets' category: 'VMMaker-JIT'! Cogit class instanceVariableNames: 'generatorTable primitiveTable'! !Cogit commentStamp: 'eem 2/25/2017 17:53' prior: 0! I am the code generator for the Cog VM. My job is to produce machine code versions of methods for faster execution and to manage inline caches for faster send performance. I can be tested in the current image using my class-side in-image compilation facilities. e.g. try StackToRegisterMappingCogit genAndDis: (Integer >> #benchFib) I have concrete subclasses that implement different levels of optimization: SimpleStackBasedCogit is the simplest code generator. StackToRegisterMappingCogit is the current production code generator It defers pushing operands to the stack until necessary and implements a register-based calling convention for low-arity sends. SistaCogit is an experimental code generator with support for counting conditional branches, intended to support adaptive optimization. RegisterAllocatingCogit is an experimental code generator with support for allocating temporary variables to registers. It is inended to serve as the superclass to SistaCogit once it is working. SistaRegisterAllocatingCogit and SistaCogitClone are temporary classes that allow testing a clone of SistaCogit that inherits from RegisterAllocatingCogit. Once things work these will be merged and will replace SistaCogit. coInterpreter <CoInterpreterSimulator> the VM's interpreter with which I cooperate methodZoneManager <CogMethodZoneManager> the manager of the machine code zone objectRepresentation <CogObjectRepresentation> the object used to generate object accesses processor <BochsIA32Alien|?> the simulator that executes the IA32/x86 machine code I generate when simulating execution in Smalltalk simulatedTrampolines <Dictionary of Integer -> MessageSend> the dictionary mapping trap jump addresses to run-time routines used to warp from simulated machine code in to the Smalltalk run-time. simulatedVariableGetters <Dictionary of Integer -> MessageSend> the dictionary mapping trap read addresses to variables in run-time objects used to allow simulated machine code to read variables in the Smalltalk run-time. simulatedVariableSetters <Dictionary of Integer -> MessageSend> the dictionary mapping trap write addresses to variables in run-time objects used to allow simulated machine code to write variables in the Smalltalk run-time. printRegisters printInstructions clickConfirm <Boolean> flags controlling debug printing and code simulation breakPC <Integer> machine code pc breakpoint cFramePointer cStackPointer <Integer> the variables representing the C stack & frame pointers, which must change on FFI callback and return selectorOop <sqInt> the oop of the methodObj being compiled methodObj <sqInt> the bytecode method being compiled initialPC endPC <Integer> the start and end pcs of the methodObj being compiled methodOrBlockNumArgs <Integer> argument count of current method or block being compiled needsFrame <Boolean> whether methodObj or block needs a frame to execute primitiveIndex <Integer> primitive index of current method being compiled methodLabel <CogAbstractOpcode> label for the method header blockEntryLabel <CogAbstractOpcode> label for the start of the block dispatch code stackOverflowCall <CogAbstractOpcode> label for the call of ceStackOverflow in the method prolog sendMissCall <CogAbstractOpcode> label for the call of ceSICMiss in the method prolog entryOffset <Integer> offset of method entry code from start (header) of method entry <CogAbstractOpcode> label for the first instruction of the method entry code noCheckEntryOffset <Integer> offset of the start of a method proper (after the method entry code) from start (header) of method noCheckEntry <CogAbstractOpcode> label for the first instruction of start of a method proper fixups <Array of <AbstractOpcode Label | nil>> the labels for forward jumps that will be fixed up when reaching the relevant bytecode. fixups has one element per byte in methodObj's bytecode; initialPC maps to fixups[0]. abstractOpcodes <Array of <AbstractOpcode>> the code generated when compiling methodObj byte0 byte1 byte2 byte3 <Integer> individual bytes of current bytecode being compiled in methodObj bytecodePointer <Integer> bytecode pc (same as Smalltalk) of the current bytecode being compiled opcodeIndex <Integer> the index of the next free entry in abstractOpcodes (this code is translated into C where OrderedCollection et al do not exist) numAbstractOpcodes <Integer> the number of elements in abstractOpcocdes blockStarts <Array of <BlockStart>> the starts of blocks in the current method blockCount the index into blockStarts as they are being noted, and hence eventually the total number of blocks in the current method labelCounter <Integer> a nicety for numbering labels not needed in the production system but probably not expensive enough to worry about ceStackOverflowTrampoline <Integer> ceSend0ArgsTrampoline <Integer> ceSend1ArgsTrampoline <Integer> ceSend2ArgsTrampoline <Integer> ceSendNArgsTrampoline <Integer> ceSendSuper0ArgsTrampoline <Integer> ceSendSuper1ArgsTrampoline <Integer> ceSendSuper2ArgsTrampoline <Integer> ceSendSuperNArgsTrampoline <Integer> ceSICMissTrampoline <Integer> ceCPICMissTrampoline <Integer> ceStoreCheckTrampoline <Integer> ceReturnToInterpreterTrampoline <Integer> ceBaseFrameReturnTrampoline <Integer> ceSendMustBeBooleanTrampoline <Integer> ceClosureCopyTrampoline <Integer> the various trampolines (system-call-like jumps from machine code to the run-time). See Cogit>>generateTrampolines for the mapping from trampoline to run-time routine and then read the run-time routine for a funcitonal description. ceEnterCogCodePopReceiverReg <Integer> the enilopmart (jump from run-time to machine-code) methodZoneBase <Integer> ! Cogit class instanceVariableNames: 'generatorTable primitiveTable'! Item was changed: ----- Method: Cogit class>>numTrampolines (in category 'accessing') ----- numTrampolines + ^39 "31 + 4 each for self and super sends" + (LowcodeVM ifTrue: [1] ifFalse: [0]) - ^38 "30 + 4 each for self and super sends" + (LowcodeVM ifTrue: [1] ifFalse: [0]) "self withAllSubclasses collect: [:c| {c. (c instVarNames select: [:ea| ea beginsWith: 'ce']) size}]"! Item was changed: ----- Method: SimpleStackBasedCogit>>compileGetErrorCode (in category 'compile abstract instructions') ----- compileGetErrorCode "After pushing the temporaries but before the stack limit check a primitive method + needs to fetch the error code, if any. If the primitive has failed, call the trampoline + that will assign it to the last temp." - needs to fetch the error code, if any, and replace the last temp with it." <inline: false> + | jmpNoError | - | jmpNoError primErrorTable primErrorTableSize jmpIntError jmpGotError | <var: #jmpNoError type: #'AbstractInstruction *'> - <var: #jmpIntError type: #'AbstractInstruction *'> - <var: #jmpGotError type: #'AbstractInstruction *'> self MoveAw: coInterpreter primFailCodeAddress R: TempReg. self flag: 'ask concrete code gen if move sets condition codes?'. self CmpCq: 0 R: TempReg. jmpNoError := self JumpZero: 0. + methodLabel addDependent: + (self annotateAbsolutePCRef: + (self MoveCw: methodLabel asInteger R: ClassReg)). + self CallRT: ceReapAndResetErrorCodeTrampoline. - primErrorTable := coInterpreter primErrTable. - primErrorTableSize := objectMemory lengthOf: primErrorTable. - self flag: 'use CmpCqR if pc mapping means stable contexts never contain native pcs'. - "Can't use CmpCqR here because table could change its size. - Assume generated code is flushed whenever primitive error table is changed." - self CmpCw: primErrorTableSize R: TempReg. - jmpIntError := self JumpAboveOrEqual: 0. "Filter out negative values as well" - objectRepresentation genFetchIndexRegister: TempReg from: primErrorTable into: ClassReg. - jmpGotError := self Jump: 0. - jmpIntError jmpTarget: self Label. - objectRepresentation genConvertIntegerToSmallIntegerInReg: TempReg. - self MoveR: TempReg R: ClassReg. - jmpGotError jmpTarget: (self MoveR: ClassReg Mw: 0 r: SPReg). - "zero the error code to agree with the interpreter's (internal)ActivateNewMethod." - self MoveCq: 0 R: TempReg. - self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. jmpNoError jmpTarget: self Label! Item was changed: ----- Method: SimpleStackBasedCogit>>generateMissAbortTrampolines (in category 'initialization') ----- generateMissAbortTrampolines "Generate the run-time entries for the various method and PIC entry misses and aborts. Read the class-side method trampolines for documentation on the various trampolines" ceMethodAbortTrampoline := self genMethodAbortTrampoline. cePICAbortTrampoline := self genPICAbortTrampoline. ceCPICMissTrampoline := self genTrampolineFor: #ceCPICMiss:receiver: called: 'ceCPICMissTrampoline' arg: ClassReg + arg: ReceiverResultReg. + ceReapAndResetErrorCodeTrampoline := self genTrampolineFor: #ceReapAndResetErrorCodeFor: + called: 'ceReapAndResetErrorCodeTrampoline' + arg: ClassReg! - arg: ReceiverResultReg! Item was changed: ----- Method: StackInterpreter>>getErrorObjectFromPrimFailCode (in category 'message sending') ----- getErrorObjectFromPrimFailCode "Answer the errorCode object to supply to a failing primitive method that accepts one. If there is a primitive error table and the primFailCode is a valid index there-in answer + the corresponding entry in the table, otherwise simply answer the code as an integer." - the coprresponding entry in the table, otherwise simply answer the code as an integer." | table | primFailCode > 0 ifTrue: [table := objectMemory splObj: PrimErrTableIndex. primFailCode <= (objectMemory numSlotsOf: table) ifTrue: [^objectMemory fetchPointer: primFailCode - 1 ofObject: table]]. ^objectMemory integerObjectOf: primFailCode! Item was changed: ----- Method: StackInterpreter>>internalActivateNewMethod (in category 'message sending') ----- internalActivateNewMethod + | methodHeader numTemps rcvr | - | methodHeader numTemps rcvr errorCode | <inline: true> methodHeader := objectMemory methodHeaderOf: newMethod. numTemps := self temporaryCountOfMethodHeader: methodHeader. self assert: argumentCount = (self argumentCountOfMethodHeader: methodHeader). rcvr := self internalStackValue: argumentCount. "could new rcvr be set at point of send?" self assert: (objectMemory isOopForwarded: rcvr) not. self internalPush: localIP. self internalPush: localFP. localFP := localSP. self internalPush: newMethod. self setMethod: newMethod methodHeader: methodHeader. self internalPush: (self encodeFrameFieldHasContext: false isBlock: false numArgs: (self argumentCountOfMethodHeader: methodHeader)). self internalPush: objectMemory nilObject. "FxThisContext field" self internalPush: rcvr. "Initialize temps..." argumentCount + 1 to: numTemps do: [:i | self internalPush: objectMemory nilObject]. "-1 to account for pre-increment in fetchNextBytecode" localIP := self pointerForOop: (self initialIPForHeader: methodHeader method: newMethod) - 1. (self methodHeaderHasPrimitive: methodHeader) ifTrue: ["Skip the CallPrimitive bytecode, if it's there, and store the error code if the method starts with a long store temp. Strictly no need to skip the store because it's effectively a noop." localIP := localIP + (self sizeOfCallPrimitiveBytecode: methodHeader). primFailCode ~= 0 ifTrue: + [self reapAndResetErrorCodeTo: localSP header: methodHeader]]. - [(objectMemory byteAt: localIP + 1) - = (self longStoreBytecodeForHeader: methodHeader) ifTrue: - [errorCode := self getErrorObjectFromPrimFailCode. - self internalStackTopPut: errorCode "nil if primFailCode == 1, or primFailCode"]. - primFailCode := 0]]. self assert: (self frameNumArgs: localFP) == argumentCount. self assert: (self frameIsBlockActivation: localFP) not. self assert: (self frameHasContext: localFP) not. "Now check for stack overflow or an event (interrupt, must scavenge, etc)." localSP < stackLimit ifTrue: [self externalizeIPandSP. self handleStackOverflowOrEventAllowContextSwitch: (self canContextSwitchIfActivating: newMethod header: methodHeader). self internalizeIPandSP]! Item was changed: ----- Method: StackInterpreter>>justActivateNewMethod (in category 'message sending') ----- justActivateNewMethod + | methodHeader numArgs numTemps rcvr | - | methodHeader numArgs numTemps rcvr errorCode | <inline: true> methodHeader := objectMemory methodHeaderOf: newMethod. numTemps := self temporaryCountOfMethodHeader: methodHeader. numArgs := self argumentCountOfMethodHeader: methodHeader. rcvr := self stackValue: numArgs. "could new rcvr be set at point of send?" self assert: (objectMemory isOopForwarded: rcvr) not. self push: instructionPointer. self push: framePointer. framePointer := stackPointer. self push: newMethod. self setMethod: newMethod methodHeader: methodHeader. self push: (self encodeFrameFieldHasContext: false isBlock: false numArgs: numArgs). self push: objectMemory nilObject. "FxThisContext field" self push: rcvr. "clear remaining temps to nil" numArgs+1 to: numTemps do: [:i | self push: objectMemory nilObject]. instructionPointer := (self initialIPForHeader: methodHeader method: newMethod) - 1. (self methodHeaderHasPrimitive: methodHeader) ifTrue: ["Skip the CallPrimitive bytecode, if it's there, and store the error code if the method starts with a long store temp. Strictly no need to skip the store because it's effectively a noop." instructionPointer := instructionPointer + (self sizeOfCallPrimitiveBytecode: methodHeader). primFailCode ~= 0 ifTrue: + [self reapAndResetErrorCodeTo: stackPointer header: methodHeader]]. - [(objectMemory byteAt: instructionPointer + 1) - = (self longStoreBytecodeForHeader: methodHeader) ifTrue: - [errorCode := self getErrorObjectFromPrimFailCode. - self stackTopPut: errorCode "nil if primFailCode == 1, or primFailCode"]. - primFailCode := 0]]. ^methodHeader! Item was added: + ----- Method: StackInterpreter>>reapAndResetErrorCodeTo:header: (in category 'primitive support') ----- + reapAndResetErrorCodeTo: theSP header: methodHeader + "Assuming the primFailCode is non-zero, check if the method consumes the error code + and if so, assign it through theSP. Then zero the primFailCode. This is infrequent code, + so keep it out of the common path." + <inline: #never> + | initialPC | + self assert: primFailCode ~= 0. + initialPC := (self initialIPForHeader: methodHeader method: newMethod) + (self sizeOfCallPrimitiveBytecode: methodHeader). + (objectMemory byteAt: initialPC) = (self longStoreBytecodeForHeader: methodHeader) ifTrue: + [stackPages longAtPointer: theSP put: self getErrorObjectFromPrimFailCode]. + primFailCode := 0! Item was changed: ----- Method: StackInterpreter>>sizeOfCallPrimitiveBytecode: (in category 'compiled methods') ----- sizeOfCallPrimitiveBytecode: methodHeader + "Answer the size of the CallPrimitive bytecode that may be used to store a method's primitive." + "NewsqueakV4: 249 11111001 iiiiiiii jjjjjjjj Call Primitive #iiiiiiii + (jjjjjjjj * 256)" + "SistaV1: 248 11111000 iiiiiiii mssjjjjj Call Primitive #iiiiiiii + ( jjjjj * 256)" + "V3+Closures: 139 11101111 iiiiiiii jjjjjjjj Call Primitive #iiiiiiii + (jjjjjjjj * 256)" - "Answer if the method starts with a long store temp bytecode, which indicates it has a primitive error code." - "249 11111001 i i i i i i i i jjjjjjjj Call Primitive #iiiiiiii + (jjjjjjjj * 256)" <api> <inline: true> ^objectMemory hasSpurMemoryManagerAPI ifTrue: [3] ifFalse: [MULTIPLEBYTECODESETS ifTrue: [(objectMemory headerIndicatesAlternateBytecodeSet: methodHeader) ifTrue: [3] ifFalse: [0]] ifFalse: [0]]! Item was changed: ----- Method: StackToRegisterMappingCogit>>generateMissAbortTrampolines (in category 'initialization') ----- generateMissAbortTrampolines "Generate the run-time entries for the various method and PIC entry misses and aborts. Read the class-side method trampolines for documentation on the various trampolines" 0 to: self numRegArgs + 1 do: [:numArgs| methodAbortTrampolines at: numArgs put: (self genMethodAbortTrampolineFor: numArgs)]. 0 to: self numRegArgs + 1 do: [:numArgs| picAbortTrampolines at: numArgs put: (self genPICAbortTrampolineFor: numArgs)]. 0 to: self numRegArgs + 1 do: [:numArgs| picMissTrampolines at: numArgs + put: (self genPICMissTrampolineFor: numArgs)]. + ceReapAndResetErrorCodeTrampoline := self genTrampolineFor: #ceReapAndResetErrorCodeFor: + called: 'ceReapAndResetErrorCodeTrampoline' + arg: ClassReg! - put: (self genPICMissTrampolineFor: numArgs)]!

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev December 2017