Vm-dev December 2017

vm-dev@lists.squeakfoundation.org

22 participants
79 discussions

[OpenSmalltalk/opensmalltalk-vm] db7115: Cog VM source as per VMMaker.oscog-eem.2287
by GitHub 07 Dec '17

07 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: db7115e8c73b9b7a3390d1b4a71b84fd2f1fe1b1 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/db7115e8c73b9b7a33… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-07 (Thu, 07 Dec 2017) Changed paths: M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspur64src/vm/interp.h M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspursrc/vm/interp.h M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/plugins/BitBltPlugin/BitBltPlugin.c M src/plugins/MiscPrimitivePlugin/MiscPrimitivePlugin.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- Cog VM source as per VMMaker.oscog-eem.2287 Spur: Rewrite determining the accessorDepth for the meta primitives (primitiveDoPrimitiveWithArgs and primitiveDoNamedPrimitiveWithArgs, 118 & 218). Have primitiveDoNamedPrimitiveWithArgs fetch the accessorDepth. Discard the confused setting of newMethod to the prim index. Introduce metaAccessorDepth and eliminate tempOop3. This fixes a crash when stepping through something likely to fail such as [DoubleWordArray new: 64*1024*1024] repeat. Fix a slip in printDecodeMethodHeaderOop:

1 0

VM Maker: VMMaker.oscog-eem.2287.mcz
by commits＠source.squeak.org 07 Dec '17

07 Dec '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2287.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2287 Author: eem Time: 7 December 2017, 1:22:10.777155 pm UUID: 5da6c657-35ff-49b0-b61f-571cb1c4308d Ancestors: VMMaker.oscog-eem.2286 Spur: Rewrite determining the accessorDepth for the meta primitives (primitiveDoPrimitiveWithArgs and primitiveDoNamedPrimitiveWithArgs, 118 & 218). Have primitiveDoNamedPrimitiveWithArgs fetch the accessorDepth. Discard the confused setting of newMethod to the prim index. Introduce metaAccessorDepth and eliminate tempOop3. This fixes a crash when stepping through something likely to fail such as [DoubleWordArray new: 64*1024*1024] repeat. Write descriptions in the class comment for the variables of CoInterpreter and StackInterpreter and add a description for a new variable in InterpreterPrimitives. Add the missing DoubleWordArray>>longAt:bigEndian: needed by the Bochs alien primitive failure code. Fix a slip in printDecodeMethodHeaderOop: =============== Diff against VMMaker.oscog-eem.2286 =============== Item was changed: StackInterpreterPrimitives subclass: #CoInterpreter instanceVariableNames: 'cogit cogMethodZone gcMode cogCodeSize desiredCogCodeSize heapBase lastCoggableInterpretedBlockMethod reenterInterpreter deferSmash deferredSmash primTraceLog primTraceLogIndex traceLog traceLogIndex traceSources cogCompiledCodeCompactionCalledFor statCodeCompactionCount statCodeCompactionUsecs lastUncoggableInterpretedBlockMethod flagInterpretedMethods maxLiteralCountForCompile minBackwardJumpCountForCompile' classVariableNames: 'CSCallbackEnter CSCallbackLeave CSCheckEvents CSEnterCriticalSection CSExitCriticalSection CSOwnVM CSResume CSSignal CSSuspend CSSwitchIfNeccessary CSThreadBind CSThreadSchedulingLoop CSWait CSYield HasBeenReturnedFromMCPC HasBeenReturnedFromMCPCOop MFMethodFlagFrameIsMarkedFlag MinBackwardJumpCountForCompile PrimNumberHashMultiply PrimTraceLogSize ReturnToInterpreter RumpCStackSize TraceBlockActivation TraceBlockCreation TraceBufferSize TraceCodeCompaction TraceContextSwitch TraceDisownVM TraceFullGC TraceIncrementalGC TraceIsFromInterpreter TraceIsFromMachineCode TraceOwnVM TracePreemptDisowningThread TracePrimitiveFailure TracePrimitiveRetry TraceSources TraceStackOverflow TraceThreadSwitch TraceVMCallback TraceVMCallbackReturn' poolDictionaries: 'CogMethodConstants VMStackFrameOffsets' category: 'VMMaker-JIT'! + !CoInterpreter commentStamp: 'eem 12/7/2017 11:19' prior: 0! + I am a variant of the StackInterpreter that can co-exist with the Cog JIT. I interpret unjitted methods, either because they have been found for the first time or because they are judged to be too big to JIT. See CogMethod class's comment for method interoperability. + + cogCodeSize + - the current size of the machine code zone + + cogCompiledCodeCompactionCalledFor + - a variable set when the machine code zone runs out of space, causing a machine code zone compaction at the next available opportunity + + cogMethodZone + - the manager for the machine code zone (instance of CogMethodZone) + + cogit + - the JIT (co-jit) (instance of SimpleStackBasedCogit, StackToRegisterMappoingCogit, etc) + + deferSmash + - a flag causing deferral of smashes of the stackLimit around the call of functionSymbol (for assert checks) + + deferredSmash + - a flag noting deferral of smashes of the stackLimit around the call of functionSymbol (for assert checks) + + desiredCogCodeSize + - the desred size of the machine code zone, set at startup or via primitiveVMParameter to be written at snapshot time + + flagInterpretedMethods + - true if methods that are interpreted shoudl have their flag bit set (used to identity methods that are interpreted because they're unjittable for some reason) + + gcMode + - the variable holding the gcMode, used to inform the cogit of how to scan the machine code zone for oops on GC + + heapBase + - the address in memory of the base of the objectMemory's heap, which is immediately above the machine code zone + + lastCoggableInterpretedBlockMethod + - a variable used to invoke the cogit for a block mehtod being invoked repeatedly in the interpreter + + lastUncoggableInterpretedBlockMethod + - a variable used to avoid invoking the cogit for an unjittable method encountered on block evaluation + + maxLiteralCountForCompile + - the variable controlling which methods to jit. methods with a literal count above this value will not be jitted (on the grounds that large methods are typically used for initialization, and take up a lot of space in the code zone) + + minBackwardJumpCountForCompile + - the variable controlling when to attempt to jit a method being interpreted. If as many backward jumps as this occur, the current method will be jitted + + primTraceLog + - a small array implementing a crcular buffer logging the last N primitive invocations, GCs, code compactions, etc used for crash reporting + + primTraceLogIndex + - the index into primTraceLog of the next entry + + reenterInterpreter + - the jmpbuf used to jmp back into the interpreter when transitioning from machine code to the interpreter + + statCodeCompactionCount + - the count of machine code zone compactions + + statCodeCompactionUsecs + - the total microseconds spent in machine code zone compactions + + traceLog + - a log of various events, used in debugging + + traceLogIndex + - the index into traceLog of the next entry + + traceSources + - the names associated with the codes of events in traceLog! - !CoInterpreter commentStamp: '<historical>' prior: 0! - I am a variant of the StackInterpreter that can co-exist with the Cog JIT. I interpret unjitted methods, either because they have been found for the first time or because they are judged to be too big to JIT. See CogMethod class's comment for method interoperability.! Item was removed: - ----- Method: CoInterpreter>>saneFunctionPointerForFailureOfPrimIndex: (in category 'primitive support') ----- - saneFunctionPointerForFailureOfPrimIndex: primIndex - ^instructionPointer >= objectMemory nilObject asUnsignedInteger - ifTrue: - [super saneFunctionPointerForFailureOfPrimIndex: primIndex] - ifFalse: - [self - cCode: - [primitiveFunctionPointer = (self functionPointerFor: primIndex - inClass: objectMemory nilObject)] - inSmalltalk: - [(primitiveFunctionPointer isInteger - ifTrue: - [(cogit lookupAddress: primitiveFunctionPointer) - endsWith: (self functionPointerFor: primIndex - inClass: objectMemory nilObject)] - ifFalse: - [primitiveFunctionPointer = (self functionPointerFor: primIndex - inClass: objectMemory nilObject)])]]! Item was changed: ----- Method: CoInterpreterMT>>markAndTraceInterpreterOops: (in category 'object memory support') ----- markAndTraceInterpreterOops: fullGCFlag "Mark and trace all oops in the interpreter's state." "Assume: All traced variables contain valid oops. N.B. Don't trace messageSelector and lkupClass; these are ephemeral, live only during message lookup and because createActualMessageTo will not cause a GC these cannot change during message lookup." | oop | <var: #vmThread type: #'CogVMThread *'> "Must mark stack pages first to initialize the per-page trace flags for full garbage collect before any subsequent tracing." self markAndTraceStackPages: fullGCFlag. self markAndTraceTraceLog. self markAndTracePrimTraceLog. objectMemory markAndTrace: objectMemory specialObjectsOop. "also covers nilObj, trueObj, falseObj, and compact classes" (objectMemory isImmediate: newMethod) ifFalse: [objectMemory markAndTrace: newMethod]. self traceProfileState. tempOop = 0 ifFalse: [objectMemory markAndTrace: tempOop]. tempOop2 = 0 ifFalse: [objectMemory markAndTrace: tempOop2]. - tempOop3 = 0 ifFalse: [objectMemory markAndTrace: tempOop3]. 1 to: objectMemory remapBufferCount do: [:i| oop := objectMemory remapBuffer at: i. (objectMemory isIntegerObject: oop) ifFalse: [objectMemory markAndTrace: oop]]. "Callback support - trace suspended callback list - will be made per-thread soon" 1 to: jmpDepth do: [:i| oop := suspendedCallbacks at: i. (objectMemory isIntegerObject: oop) ifFalse: [objectMemory markAndTrace: oop]. oop := suspendedMethods at: i. (objectMemory isIntegerObject: oop) ifFalse: [objectMemory markAndTrace: oop]]. "Per-thread state; trace each thread's own newMethod and stack of awol processes." 1 to: cogThreadManager getNumThreads do: [:i| | vmThread | vmThread := cogThreadManager vmThreadAt: i. vmThread state notNil ifTrue: [vmThread newMethodOrNull notNil ifTrue: [objectMemory markAndTrace: vmThread newMethodOrNull]. 0 to: vmThread awolProcIndex - 1 do: [:j| objectMemory markAndTrace: (vmThread awolProcesses at: j)]]]! Item was added: + ----- Method: CogVMSimulator>>saneFunctionPointerForFailureOfPrimIndex: (in category 'primitive support') ----- + saneFunctionPointerForFailureOfPrimIndex: primIndex + | basePrimitive | + (instructionPointer < objectMemory nilObject asUnsignedInteger + and: [primitiveFunctionPointer isInteger]) ifTrue: + [basePrimitive := self functionPointerFor: primIndex inClass: objectMemory nilObject. + ^(cogit lookupAddress: primitiveFunctionPointer) endsWith: basePrimitive]. + + ^super saneFunctionPointerForFailureOfPrimIndex: primIndex! Item was added: + ----- Method: DoubleWordArray>>longAt:bigEndian: (in category '*VMMaker-JITSimulation') ----- + longAt: byteIndex bigEndian: bigEndian + "Compatiblity with the ByteArray & Alien methods of the same name." + | wordIndex lowBits word hiWord | + wordIndex := byteIndex - 1 // 8 + 1. + lowBits := byteIndex - 1 bitAnd: 7. + word := (self at: wordIndex) bitShift: lowBits * -8. + lowBits > 4 ifTrue: "access straddles two words" + [hiWord := (self at: wordIndex + 1) bitShift: 8 - lowBits * 8. + word := word + hiWord]. + word := word bitAnd: 16rFFFFFFFF. + bigEndian ifTrue: + [word := ((word bitShift: -24) bitAnd: 16rFF) + + ((word bitShift: -8) bitAnd: 16rFF00) + + ((word bitAnd: 16rFF00) bitShift: 8) + + ((word bitAnd: 16rFF) bitShift: 24)]. + (word bitShift: -24) > 127 ifTrue: + [word := word - 16r100000000]. + ^word! Item was changed: VMClass subclass: #InterpreterPrimitives instanceVariableNames: 'objectMemory messageSelector argumentCount newMethod primFailCode profileMethod profileProcess profileSemaphore nextProfileTick preemptionYields newFinalization sHEAFn' classVariableNames: 'CrossedX EndOfRun MillisecondClockMask' poolDictionaries: 'VMBasicConstants VMBytecodeConstants VMMethodCacheConstants VMObjectIndices VMSqueakClassIndices VMStackFrameOffsets' category: 'VMMaker-Interpreter'! + !InterpreterPrimitives commentStamp: 'eem 12/7/2017 11:21' prior: 0! - !InterpreterPrimitives commentStamp: 'eem 12/11/2012 17:11' prior: 0! InterpreterPrimitives implements most of the VM's core primitives. It is the root of the interpreter hierarchy so as to share the core primitives amongst the varioius interpreters. Instance Variables + argumentCount: <Integer> + messageSelector: <Integer> + newMethod: <Integer> + nextProfileTick: <Integer> + objectMemory: <ObjectMemory> (simulation only) + preemptionYields: <Boolean> + primFailCode: <Integer> + profileMethod: <Integer> + profileProcess: <Integer> + profileSemaphore: <Integer> + secHasEnvironmentAccess <Integer> - argumentCount: <Integer> - messageSelector: <Integer> - newMethod: <Integer> - nextProfileTick: <Integer> - objectMemory: <ObjectMemory> (simulation only) - preemptionYields: <Boolean> - primFailCode: <Integer> - profileMethod: <Integer> - profileProcess: <Integer> - profileSemaphore: <Integer> argumentCount - the number of arguments of the current message messageSelector - the oop of the selector of the current message newMethod - the oop of the result of looking up the current message nextProfileTick - the millisecond clock value of the next profile tick (if profiling is in effect) objectMemory - the memory manager and garbage collector that manages the heap preemptionYields - a boolean controlling the process primitives. If true (old, incorrect, blue-book semantics) a preempted process is sent to the back of its run-queue. If false, a process preempted by a higher-priority process is put back at the head of its run queue, hence preserving cooperative scheduling within priorities. primFailCode - primtiive success/failure flag, 0 for success, otherwise the reason code for failure profileMethod - the oop of the method at the time nextProfileTick was reached profileProcess - the oop of the activeProcess at the time nextProfileTick was reached profileSemaphore - the oop of the semaphore to signal when nextProfileTick is reached + + secHasEnvironmentAccess + - the function to call to check if access to the envronment should be granted to primitiveGetenv ! Item was changed: InterpreterPrimitives subclass: #StackInterpreter (excessive size, no diff calculated) Item was changed: ----- Method: StackInterpreter class>>initializePrimitiveTable (in category 'initialization') ----- (excessive size, no diff calculated) Item was changed: ----- Method: StackInterpreter>>checkForAndFollowForwardedPrimitiveState (in category 'primitive support') ----- checkForAndFollowForwardedPrimitiveState "In Spur a primitive may fail due to encountering a forwarder. On failure, check the accessorDepth for the primitive and if non-negative scan the args to the depth, following any forwarders. Answer if any are found so + the prim can be retried. The primitive index is derived from newMethod." - the prim can be retried. The primitive index is derived from newMethod. - If the primitive is 118, then primitiveDoPrimitiveWithArgs sets newMethod - to a SmallInteger whose value is the primitive it is evaluating." <option: #SpurObjectMemory> | primIndex accessorDepth found scannedStackFrame | self assert: self failed. found := scannedStackFrame := false. + primIndex := self primitiveIndexOf: newMethod. + self assert: (argumentCount = (self argumentCountOf: newMethod) or: [self isMetaPrimitiveIndex: primIndex]). + "If the primitive is one of the meta primitives PrimNumberDoPrimitive or + PrimNumberDoExternalCall, then metaAccessorDepth will have been set + to nil at the start of the primitive, and to the accessor depth of the called + primitive (or external call) immediately before dispatch. Hence if primIndex + is that of a meta primiitve then if metaAccessorDepth is -2, the accessor + depth is that of the meta primitive, and if > -2, then metaAccessorDepth is + the accessor depth of the primitive (or external call). SImilarly, if the + primitive is primitiveExternalCall then the accessor depth is that of + primitiveExternalCall until primitiveFunctionPointer is assigned, at which + point the accessor depth is taken from the slot in newMethod's first literal." + accessorDepth := ((self isMetaPrimitiveIndex: primIndex) + and: [metaAccessorDepth > -2]) + ifTrue: [metaAccessorDepth] + ifFalse: + [(primIndex = PrimNumberExternalCall + and: [primitiveFunctionPointer ~~ #primitiveExternalCall]) + ifTrue: [self primitiveAccessorDepthForExternalPrimitiveMethod: newMethod] + ifFalse: [primitiveAccessorDepthTable at: primIndex]]. + self assert: (self saneFunctionPointerForFailureOfPrimIndex: primIndex). - primIndex := (objectMemory isIntegerObject: newMethod) - ifTrue: [objectMemory integerValueOf: newMethod] - ifFalse: - [self assert: argumentCount = (self argumentCountOf: newMethod). - self primitiveIndexOf: newMethod]. - accessorDepth := primitiveAccessorDepthTable at: primIndex. - "For the method-executing primitives, failure could have been in those primitives or the - primitives of the methods they execute. Find out which failed by seeing what is in effect." - ((primIndex = PrimNumberExternalCall and: [primitiveFunctionPointer ~~ #primitiveExternalCall]) - or: [primIndex = PrimNumberDoExternalCall and: [primitiveFunctionPointer ~~ #primitiveDoNamedPrimitiveWithArgs]]) - ifTrue: - [accessorDepth := self primitiveAccessorDepthForExternalPrimitiveMethod: newMethod] - ifFalse: - [self assert: (self saneFunctionPointerForFailureOfPrimIndex: primIndex)]. self assert: (accessorDepth between: -1 and: 4). accessorDepth >= 0 ifTrue: [0 to: argumentCount do: [:index| | oop | oop := self stackValue: index. (objectMemory isNonImmediate: oop) ifTrue: [(objectMemory isForwarded: oop) ifTrue: [self assert: index < argumentCount. "receiver should have been caught at send time." found := true. oop := objectMemory followForwarded: oop. self stackValue: index put: oop. scannedStackFrame ifFalse: [scannedStackFrame := true. self followForwardedFrameContents: framePointer stackPointer: stackPointer + (argumentCount + 1 * objectMemory wordSize) "don't repeat effort"]]. (accessorDepth > 0 and: [(objectMemory hasPointerFields: oop) and: [objectMemory followForwardedObjectFields: oop toDepth: accessorDepth]]) ifTrue: [found := true]]]]. ^found! Item was changed: ----- Method: StackInterpreter>>checkInterpreterIntegrity (in category 'object memory support') ----- checkInterpreterIntegrity "Perform an integrity/leak check using the heapMap. Assume clearLeakMapAndMapAccessibleObjects has set a bit at each object's header. Check that all oops in the interpreter's state points to a header. Answer 0 if all checks pass." | flags | flags := 0. + (objectMemory checkOopIntegrity: objectMemory specialObjectsOop named: 'specialObjectsOop') ifFalse: - (objectMemory checkOopIntegrity: objectMemory specialObjectsOop named: 'specialObjectsOop')ifFalse: [flags := 1]. "No longer check messageSelector; it is ephemeral, not living beyond message lookup. (objectMemory isNonImmediate: messageSelector) ifTrue: + [(objectMemory checkOopIntegrity: messageSelector named: 'messageSelector') ifFalse: + [flags := flags + N]]." + (objectMemory checkOopIntegrity: newMethod named: 'newMethod') ifFalse: + [flags := flags + 2]. - [(objectMemory checkOopIntegrity: messageSelector named: 'messageSelector')ifFalse: - [ok := false]]." - "Work around the primitiveDoPrimitiveWithArgs hack" - (objectMemory hasSpurMemoryManagerAPI - and: [objectMemory isIntegerObject: newMethod]) ifFalse: - [(objectMemory checkOopIntegrity: newMethod named: 'newMethod')ifFalse: - [flags := flags + 2]]. "No longer check lkupClass; it is ephemeral, not living beyond message lookup. + (objectMemory checkOopIntegrity: lkupClass named: 'lkupClass') ifFalse: + [flags := flags + N]." + (objectMemory checkOopIntegrity: profileProcess named: 'profileProcess') ifFalse: - (objectMemory checkOopIntegrity: lkupClass named: 'lkupClass')ifFalse: - [ok := false]." - (objectMemory checkOopIntegrity: profileProcess named: 'profileProcess')ifFalse: [flags := flags + 4]. + (objectMemory checkOopIntegrity: profileMethod named: 'profileMethod') ifFalse: - (objectMemory checkOopIntegrity: profileMethod named: 'profileMethod')ifFalse: [flags := flags + 8]. + (objectMemory checkOopIntegrity: profileSemaphore named: 'profileSemaphore') ifFalse: - (objectMemory checkOopIntegrity: profileSemaphore named: 'profileSemaphore')ifFalse: [flags := flags + 16]. tempOop = 0 ifFalse: + [(objectMemory checkOopIntegrity: tempOop named: 'tempOop') ifFalse: - [(objectMemory checkOopIntegrity: tempOop named: 'tempOop')ifFalse: [flags := flags + 32]]. tempOop2 = 0 ifFalse: + [(objectMemory checkOopIntegrity: tempOop2 named: 'tempOop2') ifFalse: - [(objectMemory checkOopIntegrity: tempOop2 named: 'tempOop2')ifFalse: [flags := flags + 64]]. - tempOop3 = 0 ifFalse: - [(objectMemory checkOopIntegrity: tempOop3 named: 'tempOop3')ifFalse: - [flags := flags + 128]]. "Callback support - check suspended callback list" 1 to: jmpDepth do: [:i| (objectMemory checkOopIntegrity: (suspendedCallbacks at: i) named: 'suspendedCallbacks' index: i) ifFalse: + [flags := flags + 128]. - [flags := flags + 256]. (objectMemory checkOopIntegrity: (suspendedMethods at: i) named: 'suspendedMethods' index: i) ifFalse: + [flags := flags + 256]]. - [flags := flags + 512]]. self checkLogIntegrity ifFalse: + [flags := flags + 512]. - [flags := flags + 1024]. ^flags! Item was changed: ----- Method: StackInterpreter>>initialize (in category 'initialization') ----- initialize "Here we can initialize the variables C initializes to zero. #initialize methods do /not/ get translated." checkAllocFiller := false. "must precede initializeObjectMemory:" primFailCode := 0. stackLimit := 0. "This is also the initialization flag for the stack system." stackPage := overflowedPage := 0. extraFramesToMoveOnOverflow := 0. bytecodeSetSelector := 0. highestRunnableProcessPriority := 0. nextProfileTick := 0. nextPollUsecs := 0. nextWakeupUsecs := 0. + tempOop := tempOop2 := theUnknownShort := 0. - tempOop := tempOop2 := tempOop3 := theUnknownShort := 0. interruptPending := false. inIOProcessEvents := 0. fullScreenFlag := 0. deferDisplayUpdates := false. displayBits := displayWidth := displayHeight := displayDepth := 0. pendingFinalizationSignals := statPendingFinalizationSignals := 0. globalSessionID := 0. jmpDepth := 0. longRunningPrimitiveStartUsecs := longRunningPrimitiveStopUsecs := 0. maxExtSemTabSizeSet := false. debugCallbackInvokes := debugCallbackPath := debugCallbackReturns := 0. statForceInterruptCheck := statStackOverflow := statCheckForEvents := statProcessSwitch := statIOProcessEvents := statStackPageDivorce := statIdleUsecs := 0! Item was changed: ----- Method: StackInterpreter>>initializeInterpreter: (in category 'initialization') ----- initializeInterpreter: bytesToShift "Initialize Interpreter state before starting execution of a new image." interpreterProxy := self sqGetInterpreterProxy. self dummyReferToProxy. objectMemory initializeObjectMemory: bytesToShift. self checkAssumedCompactClasses. self initializeExtraClassInstVarIndices. method := newMethod := objectMemory nilObject. self cCode: '' inSmalltalk: [breakSelectorLength ifNil: [breakSelectorLength := objectMemory minSmallInteger]]. methodDictLinearSearchLimit := 8. self initialCleanup. LowcodeVM ifTrue: [ self setupNativeStack ]. profileSemaphore := profileProcess := profileMethod := objectMemory nilObject. interruptKeycode := 2094. "cmd-. as used for Mac but no other OS" [globalSessionID = 0] whileTrue: [globalSessionID := self cCode: [(self time: #NULL) + self ioMSecs] inSmalltalk: [(Random new next * SmallInteger maxVal) asInteger]]. + metaAccessorDepth := -2. + super initializeInterpreter: bytesToShift! - super initializeInterpreter: bytesToShift.! Item was added: + ----- Method: StackInterpreter>>isMetaPrimitiveIndex: (in category 'primitive support') ----- + isMetaPrimitiveIndex: primIndex + "This virtual machine provides two primitives that executes arbitrary primitives, one + for indexed primitivces and one for named primitives. These meta primitives are used + in the debugger to execute primitives while simulating execution. Spur needs to know + the accessor depth for a primitive so that failures due to forwarders can be fixed up + and retried. This method identifies such meta primitives so that metaAccessorDepth + can be substituted when appropriate." + <inline: true> + ^primIndex = PrimNumberDoPrimitive + or: [primIndex = PrimNumberDoExternalCall]! Item was changed: ----- Method: StackInterpreter>>mapInterpreterOops (in category 'object memory support') ----- mapInterpreterOops "Map all oops in the interpreter's state to their new values during garbage collection or a become: operation." "Assume: All traced variables contain valid oops." <inline: false> self mapStackPages. self mapMachineCode: self getGCMode. self mapTraceLogs. self mapVMRegisters. self mapProfileState. self remapCallbackState. (tempOop ~= 0 and: [objectMemory shouldRemapOop: tempOop]) ifTrue: [tempOop := objectMemory remapObj: tempOop]. (tempOop2 ~= 0 and: [objectMemory shouldRemapOop: tempOop2]) ifTrue: + [tempOop2 := objectMemory remapObj: tempOop2]! - [tempOop2 := objectMemory remapObj: tempOop2]. - (tempOop3 ~= 0 - and: [objectMemory shouldRemapOop: tempOop3]) ifTrue: - [tempOop3 := objectMemory remapObj: tempOop3]! Item was changed: ----- Method: StackInterpreter>>markAndTraceInterpreterOops: (in category 'object memory support') ----- markAndTraceInterpreterOops: fullGCFlag "Mark and trace all oops in the interpreter's state." "Assume: All traced variables contain valid oops. N.B. Don't trace messageSelector and lkupClass; these are ephemeral, live only during message lookup and because createActualMessageTo will not cause a GC these cannot change during message lookup." | oop | "Must mark stack pages first to initialize the per-page trace flags for full garbage collect before any subsequent tracing." self markAndTraceStackPages: fullGCFlag. self markAndTraceTraceLog. self markAndTracePrimTraceLog. objectMemory markAndTrace: objectMemory specialObjectsOop. "also covers nilObj, trueObj, falseObj, and compact classes" (objectMemory isImmediate: newMethod) ifFalse: [objectMemory markAndTrace: newMethod]. self traceProfileState. tempOop = 0 ifFalse: [objectMemory markAndTrace: tempOop]. tempOop2 = 0 ifFalse: [objectMemory markAndTrace: tempOop2]. - tempOop3 = 0 ifFalse: [objectMemory markAndTrace: tempOop3]. + "V3 memory manager support" + 1 to: objectMemory remapBufferCount do: + [:i | + oop := objectMemory remapBuffer at: i. + (objectMemory isImmediate: oop) ifFalse: [objectMemory markAndTrace: oop]]. - 1 to: objectMemory remapBufferCount do: [:i | - oop := objectMemory remapBuffer at: i. - (objectMemory isIntegerObject: oop) ifFalse: [objectMemory markAndTrace: oop]]. + "Old callback support - trace suspended callback list" + 1 to: jmpDepth do: + [:i| - "Callback support - trace suspended callback list" - 1 to: jmpDepth do:[:i| oop := suspendedCallbacks at: i. + (objectMemory isImmediate: oop) ifFalse:[objectMemory markAndTrace: oop]. - (objectMemory isIntegerObject: oop) ifFalse:[objectMemory markAndTrace: oop]. oop := suspendedMethods at: i. + (objectMemory isImmediate: oop) ifFalse:[objectMemory markAndTrace: oop]]! - (objectMemory isIntegerObject: oop) ifFalse:[objectMemory markAndTrace: oop]. - ]! Item was changed: ----- Method: StackInterpreter>>printDecodeMethodHeaderOop: (in category 'printing') ----- printDecodeMethodHeaderOop: methodHeaderOop self printOopShort: methodHeaderOop. (self methodHeaderHasPrimitive: methodHeaderOop) ifTrue: [self print: ' hasPrim']. (self methodHeaderIndicatesLargeFrame: methodHeaderOop) ifTrue: [self print: ' largeFrame']. (SistaVM and: [self isOptimizedMethodHeader: methodHeaderOop]) ifTrue: [self print: ' optimized']. + (MULTIPLEBYTECODESETS and: [(objectMemory integerValueOf: methodHeaderOop) < 0]) ifTrue: - (MULTIPLEBYTECODESETS and: [objectMemory integerValueOf: methodHeaderOop]) < 0 ifTrue: [self print: ' altSet']. NewspeakVM ifTrue: [| s | s := (self accessModifierOfMethodHeader: methodHeaderOop) caseOf: { [0] -> [' public']. [1] -> [' private']. [2] -> [' protected']. [3] -> [' access undefined'] }. self print: s]. self print: ' nLits '; printNum: (objectMemory literalCountOfMethodHeader: methodHeaderOop); print: ' nArgs '; printNum: (self argumentCountOfMethodHeader: methodHeaderOop); print: ' nTemps '; printNum: (self temporaryCountOfMethodHeader: methodHeaderOop)! Item was changed: ----- Method: StackInterpreter>>saneFunctionPointerForFailureOfPrimIndex: (in category 'primitive support') ----- saneFunctionPointerForFailureOfPrimIndex: primIndex + | basePrimitive | + <var: 'basePrimitive' declareC: 'void (*basePrimitive)(void)'> + basePrimitive := self functionPointerFor: primIndex inClass: objectMemory nilObject. + ^primitiveFunctionPointer = basePrimitive + or: [(basePrimitive = #primitiveExternalCall and: [self isPrimitiveFunctionPointerAnIndex not]) + or: [(self isMetaPrimitiveIndex: primIndex) and: [metaAccessorDepth > -2]]]! - ^primitiveFunctionPointer = (self functionPointerFor: primIndex inClass: objectMemory nilObject)! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveDoNamedPrimitiveWithArgs (in category 'plugin primitives') ----- primitiveDoNamedPrimitiveWithArgs "Simulate an primitiveExternalCall invocation (e.g. for the Debugger). Do not cache anything. e.g. ContextPart>>tryNamedPrimitiveIn: aCompiledMethod for: aReceiver withArgs: arguments" | argumentArray arraySize methodArg methodHeader moduleName functionName moduleLength functionLength spec addr primRcvr isArray | <var: #addr declareC: 'void (*addr)()'> + objectMemory hasSpurMemoryManagerAPI ifTrue: "See checkForAndFollowForwardedPrimitiveState" + [metaAccessorDepth := -2]. argumentArray := self stackTop. methodArg := self stackValue: 2. ((objectMemory isArray: argumentArray) and: [objectMemory isOopCompiledMethod: methodArg]) ifFalse: [^self primitiveFailFor: -2]. "invalid args" arraySize := objectMemory numSlotsOf: argumentArray. (self roomToPushNArgs: arraySize) ifFalse: [^self primitiveFailFor: -2]. "invalid args" methodHeader := objectMemory methodHeaderOf: methodArg. (objectMemory literalCountOfMethodHeader: methodHeader) > 2 ifFalse: [^self primitiveFailFor: -3]. "invalid methodArg state" spec := objectMemory fetchPointer: 1 "first literal" ofObject: methodArg. isArray := self isInstanceOfClassArray: spec. (isArray and: [(objectMemory numSlotsOf: spec) = 4 and: [(self primitiveIndexOfMethod: methodArg header: methodHeader) = PrimNumberExternalCall]]) ifFalse: [^self primitiveFailFor: -3]. "invalid methodArg state" (self argumentCountOfMethodHeader: methodHeader) = arraySize ifFalse: [^self primitiveFailFor: -2]. "invalid args (Array args wrong size)" "The function has not been loaded yet. Fetch module and function name." moduleName := objectMemory fetchPointer: 0 ofObject: spec. moduleName = objectMemory nilObject ifTrue: [moduleLength := 0] ifFalse: [self success: (objectMemory isBytes: moduleName). moduleLength := objectMemory lengthOf: moduleName. self cCode: '' inSmalltalk: [ (#('FloatArrayPlugin' 'Matrix2x3Plugin') includes: (self stringOf: moduleName)) "??" + ifTrue: [moduleLength := 0 "Cause all of these to fail. Why?? eem 12/7/2017 09:37"]]]. - ifTrue: [moduleLength := 0 "Cause all of these to fail"]]]. functionName := objectMemory fetchPointer: 1 ofObject: spec. self success: (objectMemory isBytes: functionName). functionLength := objectMemory lengthOf: functionName. self successful ifFalse: [^self primitiveFailFor: -3]. "invalid methodArg state" + "Spur needs to know the primitive's accessorDepth." + objectMemory hasSpurMemoryManagerAPI + ifTrue: + [addr := self ioLoadExternalFunction: functionName + objectMemory baseHeaderSize + OfLength: functionLength + FromModule: moduleName + objectMemory baseHeaderSize + OfLength: moduleLength + AccessorDepthInto: (self addressOf: metaAccessorDepth + put: [:val| metaAccessorDepth := val]). + addr = 0 ifTrue: + [metaAccessorDepth := -2]] + ifFalse: + [addr := self ioLoadExternalFunction: functionName + objectMemory baseHeaderSize + OfLength: functionLength + FromModule: moduleName + objectMemory baseHeaderSize + OfLength: moduleLength]. - addr := self ioLoadExternalFunction: functionName + objectMemory baseHeaderSize - OfLength: functionLength - FromModule: moduleName + objectMemory baseHeaderSize - OfLength: moduleLength. addr = 0 ifTrue: [^self primitiveFailFor: -1]. "could not find function; answer generic failure (see below)" "Cannot fail this primitive from now on. Can only fail the external primitive." tempOop := objectMemory eeInstantiateClassIndex: ClassArrayCompactIndex format: objectMemory arrayFormat + numSlots: 4. - numSlots: (objectMemory hasSpurMemoryManagerAPI - ifTrue: [5] - ifFalse: [4]). objectMemory storePointerUnchecked: 0 ofObject: tempOop withValue: (argumentArray := self popStack); storePointerUnchecked: 1 ofObject: tempOop withValue: (primRcvr := self popStack); storePointerUnchecked: 2 ofObject: tempOop withValue: self popStack; "the method" storePointerUnchecked: 3 ofObject: tempOop withValue: self popStack. "the context receiver" self push: primRcvr. "replace context receiver with actual receiver" argumentCount := arraySize. 1 to: arraySize do: [:index| self push: (objectMemory fetchPointer: index - 1 ofObject: argumentArray)]. + self callExternalPrimitive: addr. - objectMemory hasSpurMemoryManagerAPI - ifTrue: - [objectMemory storePointerUnchecked: 4 ofObject: tempOop withValue: newMethod. - newMethod := methodArg. - self callExternalPrimitive: addr. "On Spur, sets primitiveFunctionPointer" - self maybeRetryPrimitiveOnFailure. - newMethod := objectMemory fetchPointer: 4 ofObject: tempOop] - ifFalse: - [self callExternalPrimitive: addr]. self successful ifFalse: "If primitive failed, then restore state for failure code" [self pop: arraySize + 1. self push: (objectMemory fetchPointer: 3 ofObject: tempOop). self push: (objectMemory fetchPointer: 2 ofObject: tempOop). self push: (objectMemory fetchPointer: 1 ofObject: tempOop). self push: (objectMemory fetchPointer: 0 ofObject: tempOop). argumentCount := 3. "Must reset primitiveFunctionPointer for checkForAndFollowForwardedPrimitiveState" objectMemory hasSpurMemoryManagerAPI ifTrue: [primitiveFunctionPointer := #primitiveDoNamedPrimitiveWithArgs]. "Hack. A nil prim error code (primErrorCode = 1) is interpreted by the image as meaning this primitive is not implemented. So to pass back nil as an error code we use -1 to indicate generic failure." primFailCode = 1 ifTrue: [primFailCode := -1]]! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveDoPrimitiveWithArgs (in category 'control primitives') ----- primitiveDoPrimitiveWithArgs "Implement either ProtoObject>>tryPrimitive: primIndex withArgs: argArray or Context>>receiver: anObject tryPrimitive: primIndex withArgs: argArray. If this primitive fails, arrange that its error code is a negative integer, to distinguish between this failing and the primitive it invokes failing." | argumentArray arraySize index primIdx savedNumArgs rcvr | + objectMemory hasSpurMemoryManagerAPI ifTrue: "See checkForAndFollowForwardedPrimitiveState" + [metaAccessorDepth := -2]. (argumentCount between: 2 and: 3) ifFalse: [^self primitiveFailFor: PrimErrUnsupported negated]. argumentArray := self stackTop. primIdx := self stackValue: 1. ((objectMemory isArray: argumentArray) and: [objectMemory isIntegerObject: primIdx]) ifFalse: [^self primitiveFailFor: PrimErrBadArgument negated]. arraySize := objectMemory numSlotsOf: argumentArray. (self roomToPushNArgs: arraySize) ifFalse: [^self primitiveFailFor: PrimErrLimitExceeded negated]. primIdx := objectMemory integerValueOf: primIdx. primitiveFunctionPointer := self functionPointerFor: primIdx inClass: nil. primitiveFunctionPointer = 0 ifTrue: [primitiveFunctionPointer := #primitiveDoPrimitiveWithArgs. ^self primitiveFailFor: PrimErrBadIndex negated]. "Pop primIndex and argArray, then push args in place..." (savedNumArgs := argumentCount) = 3 ifTrue: "...and receiver if the three arg form" [tempOop2 := self stackValue: 4. "actual receiver" rcvr := self stackValue: 3. "receiver for primitive" (objectMemory isOopForwarded: rcvr) ifTrue: [rcvr := objectMemory followForwarded: rcvr]. self pop: 4; push: rcvr] "use first arg as receiver" ifFalse: [self pop: 2]. argumentCount := arraySize. index := 1. + [index <= arraySize] whileTrue: - [index <= argumentCount] whileTrue: [self push: (objectMemory fetchPointer: index - 1 ofObject: argumentArray). index := index + 1]. self isPrimitiveFunctionPointerAnIndex ifTrue: [self externalQuickPrimitiveResponse. tempOop2 := 0. ^nil]. "We use tempOop instead of pushRemappableOop:/popRemappableOop here because in the Cogit primitiveEnterCriticalSection, primitiveSignal, primitiveResume et al longjmp back to either the interpreter or machine code, depending on the process activated. So if we're executing one of these primitives, control won't actually return here and the matching popRemappableOop: wouldn't occur, potentially overflowing the remap buffer. Note that while recursion could occur (nil tryPrimitive: 118 withArgs: #(118 #(110 #()))) it counts as shooting oneself in the foot." tempOop := argumentArray. "prim might alloc/gc" "Run the primitive (sets primFailCode)" + objectMemory hasSpurMemoryManagerAPI ifTrue: "See checkForAndFollowForwardedPrimitiveState" + [metaAccessorDepth := primitiveAccessorDepthTable at: primIdx]. + self slowPrimitiveResponse. - objectMemory hasSpurMemoryManagerAPI - ifTrue: - [tempOop3 := newMethod. - newMethod := objectMemory integerObjectOf: primIdx. - self slowPrimitiveResponse. - newMethod := tempOop3. - tempOop3 := 0] - ifFalse: - [self slowPrimitiveResponse]. self successful ifFalse: "If primitive failed, then restore state for failure code" [self pop: arraySize. savedNumArgs = 3 ifTrue: [rcvr := self stackTop. self stackTopPut: tempOop2. self push: rcvr]. self pushInteger: primIdx. self push: tempOop. primitiveFunctionPointer := #primitiveDoPrimitiveWithArgs. argumentCount := savedNumArgs]. tempOop := tempOop2 := 0!

1 0

Stalled travis_tests in linux32x86
by Nicolas Cellier 07 Dec '17

07 Dec '17

Hi, for quite some times the travis build for linux32x86 times out during the .travis_test.sh phase. It's very hard for me to build a 32bits vm from 64bits ubuntu (14.xx). So I've tried with a 32bits VM (debian9), changed to opensmalltalk root directory of my working copy, and export ARCH="linux32x86" export FLAVOR="squeak.cog.spur" export TRAVIS_BUILD_DIR=`pwd` export TRAVIS_OS_NAME=linux ./.travis_build.sh ./.travis_test.sh The tests effectively seem to block with 100% CPU. So I performed a few stack dump via kill -USR1, and it seems that tests are stuck in a very long operation, here is one of the samples: All Smalltalk process stacks (active first): Process 0x192cda8 priority 40 0xbfc67d94 M MultiByteFileStream(StandardFileStream)>basicNext 0x129bdc8: a(n) MultiByteFileStream 0xbfc67db0 M UTF8TextConverter>skipSeparatorsAndPeekNextFrom: 0x129bd58: a(n) UTF8TextConverter 0xbfc67dd0 M UTF8TextConverter>parseLangTagFor:fromStream: 0x129bd58: a(n) UTF8TextConverter 0xbfc67df0 M UTF8TextConverter>nextChunkFromStream: 0x129bd58: a(n) UTF8TextConverter 0xbfc67e0c M MultiByteFileStream>nextChunk 0x129bdc8: a(n) MultiByteFileStream 0xbfc67e5c M [] in MCMockPackageInfo(PackageInfo)>changeRecordsForMethod:do: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc67e7c M BlockClosure>ensure: 0x129bf80: a(n) BlockClosure 0xbfc74bb0 M MCMockPackageInfo(PackageInfo)>changeRecordsForMethod:do: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc74bd0 M MCMockPackageInfo(PackageInfo)>changeRecordForOverriddenMethod: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc74bec M MCMockPackageInfo(PackageInfo)>isOverrideOfYourMethod: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc74c0c M [] in MCMockPackageInfo(PackageInfo)>overriddenMethodsDo: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc74c30 M [] in MCMockPackageInfo(PackageInfo)>methodsInCategory:ofClass:do: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc74c54 M Array(SequenceableCollection)>do: 0x129d178: a(n) Array 0xbfc74c70 M MCMockPackageInfo(PackageInfo)>methodsInCategory:ofClass:do: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc74c9c M [] in MCMockPackageInfo(PackageInfo)>overriddenMethodsInClass:do: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc74cbc M [] in MCMockPackageInfo(PackageInfo)>overrideCategoriesForClass:do: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc74ce0 M Array(SequenceableCollection)>do: 0x129aa48: a(n) Array 0xbfc74cfc M MCMockPackageInfo(PackageInfo)>overrideCategoriesForClass:do: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc74d1c M MCMockPackageInfo(PackageInfo)>overriddenMethodsInClass:do: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc74d40 M [] in MCMockPackageInfo(PackageInfo)>allOverriddenMethodsDo: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc74d60 M [] in MCTestCase class(Behavior)>allSubclassesDo: 0x1b38d88: a(n) MCTestCase class 0xbfc74d84 M Array(SequenceableCollection)>do: 0x1ae4c70: a(n) Array 0xbfc74da0 M MCTestCase class(Class)>subclassesDo: 0x1b38d88: a(n) MCTestCase class 0xbfc74dbc M MCTestCase class(Behavior)>allSubclassesDo: 0x1b38d88: a(n) MCTestCase class 0xbfc74ddc M [] in TestCase class(Behavior)>allSubclassesDo: 0x1b35988: a(n) TestCase class 0xbfc74e00 M Array(SequenceableCollection)>do: 0x27fa510: a(n) Array 0xbfc74e1c M TestCase class(Class)>subclassesDo: 0x1b35988: a(n) TestCase class 0xbfc74e38 M TestCase class(Behavior)>allSubclassesDo: 0x1b35988: a(n) TestCase class 0xbfc74e58 M [] in Object class(Behavior)>allSubclassesDo: 0x1a25910: a(n) Object class 0xbfc74e7c M Array(SequenceableCollection)>do: 0x1297d50: a(n) Array 0xbfc6bb9c M Object class(Class)>subclassesDo: 0x1a25910: a(n) Object class 0xbfc6bbb8 M Object class(Behavior)>allSubclassesDo: 0x1a25910: a(n) Object class 0xbfc6bbd8 M [] in ProtoObject class(Behavior)>allSubclassesDo: 0x1a25a98: a(n) ProtoObject class 0xbfc6bbfc M Array(SequenceableCollection)>do: 0x4334a28: a(n) Array 0xbfc6bc18 M ProtoObject class(Class)>subclassesDo: 0x1a25a98: a(n) ProtoObject class 0xbfc6bc34 M ProtoObject class(Behavior)>allSubclassesDo: 0x1a25a98: a(n) ProtoObject class 0xbfc6bc58 I ProtoObject class(Behavior)>withAllSubclassesDo: 0x1a25a98: a(n) ProtoObject class 0xbfc6bc74 M MCMockPackageInfo(PackageInfo)>allOverriddenMethodsDo: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc6bc90 M MCMockPackageInfo(PackageInfo)>overriddenMethodsDo: 0x1a265d0: a(n) MCMockPackageInfo 0xbfc6bcac M [] in MCMockPackageInfo(PackageInfo)>overriddenMethods 0x1a265d0: a(n) MCMockPackageInfo 0xbfc6bcd0 M Array class(SequenceableCollection class)>new:streamContents: 0x1a124a8: a(n) Array class 0xbfc6bcf0 M Array class(SequenceableCollection class)>streamContents: 0x1a124a8: a(n) Array class 0xbfc6bd0c M MCMockPackageInfo(PackageInfo)>overriddenMethods 0x1a265d0: a(n) MCMockPackageInfo 0xbfc6bd2c M [] in MCPackage>snapshot 0x129ca58: a(n) MCPackage 0xbfc6bd48 M BlockClosure>on:do: 0x129cac8: a(n) BlockClosure 0xbfc6bd6c M CurrentReadOnlySourceFiles class>cacheDuring: 0x1baa718: a(n) CurrentReadOnlySourceFiles class 0xbfc6bd94 M MCPackage>snapshot 0x129ca58: a(n) MCPackage 0xbfc6bdb4 M MCPackageLoader>updatePackage:withSnapshot: 0x129cc40: a(n) MCPackageLoader 0xbfc6bde0 I MCPackageLoader class>updatePackage:withSnapshot: 0x1c00d30: a(n) MCPackageLoader class 0xbfc6be08 I MCSnapshot>updatePackage: 0x4148418: a(n) MCSnapshot 0xbfc6be2c I MCMethodDefinitionTest(MCTestCase)>restoreMocks 0x4049e20: a(n) MCMethodDefinitionTest 0xbfc6be44 M MCMethodDefinitionTest>tearDown 0x4049e20: a(n) MCMethodDefinitionTest 0xbfc6be5c M [] in MCMethodDefinitionTest(TestCase)>runCase 0x4049e20: a(n) MCMethodDefinitionTest 0xbfc6be7c M MethodContext(ContextPart)>resume: 0x129c2e0: a(n) MethodContext 0xbfc68c2c M BlockClosure>ensure: 0x129c128: a(n) BlockClosure 0xbfc68c48 M MCMethodDefinitionTest(TestCase)>runCase 0x4049e20: a(n) MCMethodDefinitionTest 0xbfc68c60 M SCISqueakTestRunner(SCITestRunner)>basicRunCase: 0x4050a68: a(n) SCISqueakTestRunner 0xbfc68c80 M [] in SCISqueakTestRunner(SCITestRunner)>runCase: 0x4050a68: a(n) SCISqueakTestRunner 0xbfc68c9c M BlockClosure>on:do: 0x129c218: a(n) BlockClosure 0xbfc68cc4 M [] in SCISqueakTestRunner(SCITestRunner)>runCase: 0x4050a68: a(n) SCISqueakTestRunner 0xbfc68ce0 M BlockClosure>on:do: 0x129c340: a(n) BlockClosure 0xbfc68d08 M [] in SCISqueakTestRunner(SCITestRunner)>runCase: 0x4050a68: a(n) SCISqueakTestRunner 0xbfc68d24 M Time class>millisecondsToRun: 0x1a10700: a(n) Time class 0xbfc68d40 M SmalltalkCI class>timeToRun: 0x3afeee8: a(n) SmalltalkCI class 0xbfc68d64 M SCISqueakTestRunner(SCITestRunner)>runCase: 0x4050a68: a(n) SCISqueakTestRunner 0xbfc68d80 M MCMethodDefinitionTest(TestCase)>run: 0x4049e20: a(n) MCMethodDefinitionTest 0xbfc68d9c M [] in SCISqueakTestRunner(SCITestRunner)>runAll 0x4050a68: a(n) SCISqueakTestRunner 0xbfc68dbc M OrderedCollection>do: 0x401f7f0: a(n) OrderedCollection 0xbfc68de0 I SCISqueakTestRunner(SCITestRunner)>runAll 0x4050a68: a(n) SCISqueakTestRunner 0xbfc68df8 M [] in SCISqueakTestRunner(SCITestRunner)>run 0x4050a68: a(n) SCISqueakTestRunner 0xbfc68e1c I Time class>millisecondsToRun: 0x1a10700: a(n) Time class 0xbfc68e40 I SmalltalkCI class>timeToRun: 0x3afeee8: a(n) SmalltalkCI class 0xbfc68e5c M [] in SCISqueakTestRunner(SCITestRunner)>run 0x4050a68: a(n) SCISqueakTestRunner 0xbfc68e7c M BlockClosure>ensure: 0x4050b80: a(n) BlockClosure 0x4050c10 s SCISqueakTestRunner(SCITestRunner)>run 0x41492c8 s SCISqueakTestRunner class(SCITestRunner class)>runSuite:spec: 0x401e3f0 s SCISqueakTestRunner class(SCITestRunner class)>runClasses:spec: 0x4040da0 s SCISqueakTestRunner class(SCITestRunner class)>runSpec: 0x4148790 s SmalltalkCISqueak(SmalltalkCI)>runTests 0x414a428 s [] in SmalltalkCISqueak(SmalltalkCI)>basicTest 0x3bab9b0 s SmalltalkCISqueak class(SmalltalkCI class)>run:spec:in: 0x401e4c0 s [] in SmalltalkCISqueak(SmalltalkCI)>basicTest 0x4040e00 s [] in SmalltalkCISqueak class(SmalltalkCI class)>fold:on:block: 0x41487f0 s Time class>millisecondsToRun: 0x414a488 s SmalltalkCI class>timeToRun: 0x401e560 s SmalltalkCISqueak class(SmalltalkCI class)>fold:on:block: 0x4040e60 s SmalltalkCISqueak class(SmalltalkCI class)>fold:block: 0x4148850 s SmalltalkCISqueak class(SmalltalkCI class)>stage:id:block: 0x401e5c0 s SmalltalkCISqueak(SmalltalkCI)>basicTest 0x401e620 s [] in SmalltalkCISqueak(SmalltalkCI)>test 0x401da40 s BlockClosure>on:do: 0x401dae0 s [] in SmalltalkCISqueak(SmalltalkCI)>test 0x4040bc0 s [] in SmalltalkCISqueak class(SmalltalkCI class)>withBuildStatusReportingDo: 0x401db70 s BlockClosure>on:do: 0x401dbe8 s SmalltalkCISqueak class(SmalltalkCI class)>withBuildStatusReportingDo: 0x401dc48 s SmalltalkCISqueak(SmalltalkCI)>test 0x4040c20 s SmalltalkCI class>test:projectDirectory: 0x41486d0 s SmalltalkCI class>test: 0x401dd48 s UndefinedObject>DoIt 0x401de88 s Compiler>evaluateCue:ifFail: 0x401df20 s Compiler>evaluateCue:ifFail:logged: 0x4040c80 s Compiler>evaluate:in:to:notifying:ifFail:logged: 0x401e178 s Compiler class>evaluate:for:notifying:logged: 0x4040ce0 s Compiler class>evaluate:for:logged: 0x4148730 s Compiler class>evaluate:logged: 0x414a3c8 s [] in ReadStream(PositionableStream)>fileInAnnouncing: 0x401e1f0 s BlockClosure>on:do: 0x401e268 s [] in ReadStream(PositionableStream)>fileInAnnouncing: 0x4040d40 s [] in MorphicUIManager>displayProgress:at:from:to:during: 0x401e2e8 s BlockClosure>on:do: 0x401e360 s [] in MorphicUIManager>displayProgress:at:from:to:during: 0x401d240 s BlockClosure>ensure: 0x401d2f0 s MorphicUIManager>displayProgress:at:from:to:during: 0x40409e0 s ProgressInitiationException>defaultResumeValue 0x41484f0 s ProgressInitiationException(Exception)>resume 0x414a248 s ProgressInitiationException>defaultAction 0x3bab890 s UndefinedObject>handleSignal: 0x401d3b8 s ProgressInitiationException(Exception)>signal 0x401d418 s ProgressInitiationException>display:at:from:to:during: 0x4040a40 s ProgressInitiationException class>display:at:from:to:during: 0x4148550 s ByteString(String)>displayProgressAt:from:to:during: 0x414a2a8 s ByteString(String)>displayProgressFrom:to:during: 0x401d4a0 s ReadStream(PositionableStream)>fileInAnnouncing: 0x4040aa0 s ReadStream(PositionableStream)>fileIn 0x41485b0 s CodeLoader>installSourceFile: 0x414a308 s [] in CodeLoader>installSourceFiles 0x3bab8f0 s Array(SequenceableCollection)>do: 0x401d780 s CodeLoader>installSourceFiles 0x401d930 s ProjectLauncher>startUpAfterLogin 0x4040b00 s ProjectLauncher>startUp 0x4148610 s [] in AutoStart class>startUp: 0x414a368 s WorldState>runStepMethodsIn: 0x3bab950 s PasteUpMorph>runStepMethods 0x401d9c8 s WorldState>doOneCycleNowFor: 0x4040b60 s WorldState>doOneCycleFor: 0x4148670 s PasteUpMorph>doOneCycle 0x1e09b00 s [] in MorphicProject>spawnNewProcess 0x1ad4dd8 s [] in BlockClosure>newProcess It' like MCMethodDefinitionTest>tearDown never finish (or is very very long) because MCMockPackageInfo(PackageInfo)>overriddenMethods is very very long. I don't know what is different on linux32x86 VM compared to OSX, but it would be interesting to understand what's going on exactly...

5 11

[OpenSmalltalk/opensmalltalk-vm] db2ea9: Make sure that all Bochs processor libvrary builds...
by GitHub 06 Dec '17

06 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: db2ea9bc96fff71cc2560cecf061fefa58380841 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/db2ea9bc96fff71cc2… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M .gitignore M build.macos32x86/bochsx64/conf.COG.dbg A build.macos32x86/bochsx64/makeclean A build.macos32x86/bochsx86/conf.COG.dbg A build.macos32x86/bochsx86/exploration/Makefile A build.macos32x86/bochsx86/makeclean M build.macos64x64/bochsx64/conf.COG M build.macos64x64/bochsx64/conf.COG.dbg A build.macos64x64/bochsx64/makeclean M build.macos64x64/bochsx86/conf.COG M build.macos64x64/bochsx86/conf.COG.dbg A build.macos64x64/bochsx86/exploration/Makefile A build.macos64x64/bochsx86/makeclean Log Message: ----------- Make sure that all Bochs processor libvrary builds have a conf.COG.dbg for debugging, and an exploration directory for generatign accessor source. Add a makeclean script to ease using the conf.COG.dbg.

1 0

[OpenSmalltalk/opensmalltalk-vm] 660d1e: Fix a minor typo in build.win*/common/Makefile.too...
by GitHub 06 Dec '17

06 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 660d1e2d3869ef9d7b22b455efab49315d19587e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/660d1e2d3869ef9d7b… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M build.win32x86/common/Makefile.tools M build.win64x64/common/Makefile.tools Log Message: ----------- Fix a minor typo in build.win*/common/Makefile.tools

1 0

[OpenSmalltalk/opensmalltalk-vm] cc2392: Revamp the Bochs processor accessor source generat...
by GitHub 06 Dec '17

06 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: cc2392b3554c68cdf292a43e5efeef006d5a5f15 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/cc2392b3554c68cdf2… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M .gitignore M build.macos32x86/bochsx64/exploration/Makefile M build.macos64x64/bochsx64/exploration/Makefile A build.macos64x64/bochsx86/conf.COG.dbg M processors/IA32/bochs/exploration/Makefile A processors/IA32/bochs/exploration/Makefile.64 M processors/IA32/bochs/exploration/printcpu.c M processors/IA32/bochs/exploration/printcpucr.c M processors/IA32/bochs/exploration/printcpuxmm.c M processors/IA32/bochs/explorationx64/Makefile A processors/IA32/bochs/explorationx64/Makefile.64 M processors/IA32/bochs/explorationx64/printcpu.c M processors/IA32/bochs/explorationx64/printcpucr.c M processors/IA32/bochs/explorationx64/printcpuxmm.c Log Message: ----------- Revamp the Bochs processor accessor source generation to add generation of the accessors when using 64-bits. Commit: e12e643ffc4f0e38ea769d440f60f8bdab81cd60 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/e12e643ffc4f0e38ea… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M build.win32x86/common/Makefile.tools Log Message: ----------- Merge branch 'Cog' of https://github.com/OpenSmalltalk/opensmalltalk-vm into Cog Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/53e966784526...e1…

1 0

VM Maker: VMMaker.oscog-eem.2286.mcz
by commits＠source.squeak.org 06 Dec '17

06 Dec '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2286.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2286 Author: eem Time: 6 December 2017, 11:30:07.090643 am UUID: 71ca5d81-dc4e-42db-901a-f69e462b6da1 Ancestors: VMMaker.oscog-eem.2285 Simulation on 64-bit Squeak. Update DoubleWordArray with the low level accessors. Extend MemoryTests to test these accessors in DoubleWordArray. Beef up the tests to test all the classes that support the accessors more thoroughly. Add 64-bit access in Bitmap (which is big endian) as the expected failure. Have ByteArray use integerAt:[put:]size:signed: for 32 and 64 bit access as these primitives are fast. Change the oop range in CurrentImageCoInterpreterFacadeFor64BitSpurObjectRepresentation so that it matches code produced by the real JIT on Mac OS X. Fix a bug in the oop<->object mapping (actually its artguably a bug in IdentityDictionary). Add IdentityDictionary>>keyAtNonIdentityValue:ifAbsent: to fix the bug. Slang generation: Extract logging to a method and have it include the target directory. =============== Diff against VMMaker.oscog-eem.2285 =============== Item was changed: ----- Method: Bitmap>>long64At:put: (in category '*VMMaker-JITSimulation') ----- long64At: byteIndex put: aValue | lowBits mask wordIndex | (lowBits := byteIndex - 1 \\ 4) = 0 ifTrue: [self "N.B. Do the access that can fail first, before altering the receiver" longAt: byteIndex put: (aValue bitShift: -32); unsignedLongAt: byteIndex + 4 put: (aValue bitAnd: 16rffffffff). ^aValue]. "There will always be three accesses; two partial words and a full word in the middle" wordIndex := byteIndex - 1 // 4 + 1. aValue < 0 ifTrue: [(aValue bitShift: -32) < -2147483648 ifTrue: [^self errorImproperStore]] ifFalse: [16r7FFFFFFF < (aValue bitShift: -32) ifTrue: [^self errorImproperStore]]. + mask := 16rFFFFFFFF bitShift: lowBits * -8. - mask := 16rFFFFFFFF bitShift: 4 - lowBits * -8. self at: wordIndex + 2 put: (((self at: wordIndex + 2) bitAnd: mask) bitXor: ((aValue bitShift: lowBits * 8) bitAnd: mask bitInvert32)). self at: wordIndex + 1 put: ((aValue bitShift: lowBits * -8) bitAnd: 16rFFFFFFFF). self at: wordIndex put: (((self at: wordIndex) bitAnd: mask bitInvert32) bitXor: ((aValue bitShift: 4 - lowBits + 4 * -8) bitAnd: mask)). "(wordIndex to: wordIndex + 2) collect: [:i| (self at: i) hex]" ^aValue! Item was changed: ----- Method: Bitmap>>unsignedLongAt:put: (in category '*VMMaker-JITSimulation') ----- unsignedLongAt: byteIndex put: aValue "Compatiblity with the ByteArray & Alien methods of the same name." | lowBits mask wordIndex | wordIndex := byteIndex - 1 // 4 + 1. (lowBits := byteIndex - 1 bitAnd: 3) = 0 ifTrue: [^self at: wordIndex put: aValue]. mask := 16rFFFFFFFF bitShift: lowBits * -8. + (aValue bitShift: -32) = 0 ifFalse: + [^self errorImproperStore]. self at: wordIndex put: (((self at: wordIndex) bitAnd: mask bitInvert) bitXor: ((aValue bitShift: lowBits * -8) bitAnd: mask)). self at: wordIndex + 1 put: (((self at: wordIndex + 1) bitAnd: mask) bitXor: (16rFFFFFFFF bitAnd: ((aValue bitShift: (4 - lowBits * 8)) bitAnd: mask bitInvert))). ^aValue! Item was changed: ----- Method: ByteArray>>long64At: (in category '*VMMaker-accessing') ----- long64At: index "Answer a 64-bit integer in Smalltalk order (little-endian)." + ^self integerAt: index size: 8 signed: true! - | n1 n2 | - n1 := self unsignedLongAt: index bigEndian: false. - n2 := self unsignedLongAt: index+4 bigEndian: false. - ^(n2 bitShift: 32) + n1! Item was changed: ----- Method: ByteArray>>long64At:put: (in category '*VMMaker-accessing') ----- + long64At: index put: value - long64At: index put: val "I store 64-bit integers in Smalltalk (little-endian) order." + ^self integerAt: index put: value size: 8 signed: true! - self unsignedLongAt: index put: (val bitAnd: 16rFFFFFFFF) bigEndian: false. - self unsignedLongAt: index+4 put: (val bitShift: -32) bigEndian: false. - ^val - ! Item was changed: ----- Method: ByteArray>>longAt: (in category '*VMMaker-accessing') ----- longAt: byteIndex + "Store a 32bit signed integer starting at the given byte offset" + ^self integerAt: byteIndex size: 4 signed: true! - ^self signedLongAt: byteIndex! Item was changed: ----- Method: ByteArray>>longAt:put: (in category '*VMMaker-accessing') ----- longAt: byteIndex put: aValue + "Store a 32bit signed integer starting at the given byte offset" + ^self integerAt: byteIndex put: aValue size: 4 signed: true! - ^self signedLongAt: byteIndex put: aValue! Item was added: + ----- Method: ByteArray>>unsignedLong64At: (in category '*VMMaker-accessing') ----- + unsignedLong64At: byteOffset + "Answer a 64-bit integer in Smalltalk order (little-endian)." + ^self integerAt: byteOffset size: 8 signed: false! Item was added: + ----- Method: ByteArray>>unsignedLong64At:put: (in category '*VMMaker-accessing') ----- + unsignedLong64At: byteOffset put: value + "I store 64-bit integers in Smalltalk (little-endian) order." + ^self integerAt: byteOffset put: value size: 8 signed: false! Item was changed: ----- Method: CurrentImageCoInterpreterFacadeFor64BitSpurObjectRepresentation>>objectForOop: (in category 'private-cacheing') ----- objectForOop: anOop "This is a keyAtValue: search and so needs speeding up either by a reverse map or a simple cache." ^(anOop bitAnd: 7) caseOf: { [0] -> [anOop = cachedOop ifTrue: [cachedObject] + ifFalse: [cachedObject := objectMap keyAtNonIdentityValue: anOop. "may raise Error" - ifFalse: [cachedObject := objectMap keyAtValue: anOop. "may raise Error" cachedOop := anOop. "Don't assign until accessed without error" cachedObject]]. [1] -> [anOop signedIntFromLong64 >> 3]. [2] -> [Character value: anOop >> 3]. [4] -> [objectMemory smallFloatValueOf: anOop] }! Item was changed: ----- Method: CurrentImageCoInterpreterFacadeFor64BitSpurObjectRepresentation>>oopForObject: (in category 'object map') ----- oopForObject: o o isNumber ifTrue: [o isInteger ifTrue: [(o between: objectMemory minSmallInteger and: objectMemory maxSmallInteger) ifTrue: [^objectMemory integerObjectOf: o asInteger]] ifFalse: [o isFloat ifTrue: [(objectMemory isSmallFloatValue: o) ifTrue: + [^objectMemory smallFloatObjectOf: o]]]] - [^objectMemory smallFloatValueOf: o]]]] ifFalse: [o isCharacter ifTrue: [^objectMemory characterObjectOf: o asInteger]]. + ^objectMap at: o ifAbsentPut: [objectMap size * 8 + (1024 * 1024 * 1024 * 4)]! - ^objectMap at: o ifAbsentPut: [objectMap size * 8 + (1024 * 1024)]! Item was added: + ----- Method: DoubleWordArray class>>defaultIntegerBaseInDebugger (in category '*VMMaker-debugger') ----- + defaultIntegerBaseInDebugger + ^16! Item was added: + ----- Method: DoubleWordArray>>byteAt: (in category '*VMMaker-JITSimulation') ----- + byteAt: byteAddress + "Extract a byte from a DoubleWordArray (little-endian version)" + | lowBits | + lowBits := byteAddress - 1 bitAnd: 7. + ^((self at: byteAddress - 1 - lowBits // 8 + 1) + bitShift: lowBits * -8) + bitAnd: 16rFF! Item was added: + ----- Method: DoubleWordArray>>long64At: (in category '*VMMaker-JITSimulation') ----- + long64At: byteIndex + | lowBits wordIndex value high low | + wordIndex := byteIndex - 1 // 8 + 1. + (lowBits := byteIndex - 1 \\ 8) = 0 + ifTrue: + [value := self at: wordIndex] + ifFalse: + [high := (self at: wordIndex + 1) bitShift: 8 - lowBits * 8. + low := (self at: wordIndex) bitShift: lowBits * -8. + high = 0 ifTrue: + [^low]. + value := high + low]. + ^(value bitShift: -56) <= 127 + ifTrue: [value] + ifFalse: [value - 16r10000000000000000]! Item was added: + ----- Method: DoubleWordArray>>long64At:put: (in category '*VMMaker-JITSimulation') ----- + long64At: byteIndex put: aValue + "Compatiblity with the ByteArray & Alien methods of the same name." + | wordIndex lowBits mask allOnes | + wordIndex := byteIndex - 1 // 8 + 1. + ((aValue bitShift: -63) between: -1 and: 0) ifFalse: + [self errorImproperStore]. + allOnes := 16rFFFFFFFFFFFFFFFF. + (lowBits := byteIndex - 1 bitAnd: 7) = 0 ifTrue: + [^self at: wordIndex put: (aValue >= 0 ifTrue: [aValue] ifFalse: [aValue bitAnd: allOnes])]. + mask := allOnes bitShift: 8 - lowBits * -8. + self at: wordIndex put: (((self at: wordIndex) bitAnd: mask) bitXor: ((aValue bitShift: lowBits * 8) bitAnd: allOnes - mask)). + self at: wordIndex + 1 put: (((self at: wordIndex + 1) bitAnd: allOnes - mask) bitXor: (allOnes bitAnd: ((aValue bitShift: 8 - lowBits * -8) bitAnd: mask))). + ^aValue! Item was added: + ----- Method: DoubleWordArray>>longAt: (in category '*VMMaker-JITSimulation') ----- + longAt: byteIndex + "Compatiblity with the ByteArray & Alien methods of the same name." + | wordIndex lowBits word hiWord | + wordIndex := byteIndex - 1 // 8 + 1. + lowBits := byteIndex - 1 bitAnd: 7. + word := (self at: wordIndex) bitShift: lowBits * -8. + lowBits > 4 ifTrue: "access straddles two words" + [hiWord := (self at: wordIndex + 1) bitShift: 8 - lowBits * 8. + word := word + hiWord]. + word := word bitAnd: 16rFFFFFFFF. + (word bitShift: -24) > 127 ifTrue: + [word := word - 16r100000000]. + ^word! Item was added: + ----- Method: DoubleWordArray>>longAt:put: (in category '*VMMaker-JITSimulation') ----- + longAt: byteIndex put: aValue + "Compatiblity with the ByteArray & Alien methods of the same name." + | wordIndex lowBits word allOnes loMask hiMask | + wordIndex := byteIndex - 1 // 8 + 1. + lowBits := byteIndex - 1 bitAnd: 7. + ((aValue bitShift: -31) between: -1 and: 0) ifFalse: + [self errorImproperStore]. + lowBits <= 4 ifTrue: "access fits in a single word" + [| mask | + mask := 16rFFFFFFFF bitShift: lowBits * 8. + word := self at: wordIndex. + self at: wordIndex put: ((word bitOr: mask) bitXor: (((aValue bitShift: lowBits * 8) bitAnd: mask) bitXor: mask)). + ^aValue]. + "access straddles two words; make lowMask ones where destination is unchanged to avoid overflow" + allOnes := 16rFFFFFFFFFFFFFFFF. + loMask := allOnes bitShift: 8 - lowBits * -8. + hiMask := 16rFFFFFFFF bitShift: 8 - lowBits * -8. + word := self at: wordIndex. + self at: wordIndex put: ((word bitAnd: loMask) bitOr: ((aValue bitAnd: (16rFFFFFFFF bitShift: (lowBits bitAnd: 3) * -8)) bitShift: lowBits * 8)). + word := self at: wordIndex + 1. + self at: wordIndex + 1 put: ((word bitOr: hiMask) bitXor: ((((aValue bitShift: 4 - (lowBits bitAnd: 3) * -8)) bitAnd: hiMask) bitXor: hiMask)). + ^aValue! Item was added: + ----- Method: DoubleWordArray>>unsignedByteAt: (in category '*VMMaker-JITSimulation') ----- + unsignedByteAt: byteAddress + "Extract a byte from a 64-bit word array (little-endian version)" + | lowBits | + lowBits := byteAddress - 1 bitAnd: 7. + ^((self at: byteAddress - 1 - lowBits // 8 + 1) + bitShift: lowBits * -8) + bitAnd: 16rFF! Item was added: + ----- Method: DoubleWordArray>>unsignedByteAt:put: (in category '*VMMaker-JITSimulation') ----- + unsignedByteAt: byteAddress put: byte + "Insert a byte into a 64-bit word (little-endian version)" + | longWord shift lowBits longAddr | + (byte < 0 or: [byte > 255]) ifTrue:[^self errorImproperStore]. + lowBits := byteAddress - 1 bitAnd: 7. + longWord := self at: (longAddr := (byteAddress - 1 - lowBits) // 8 + 1). + shift := lowBits * 8. + longWord := longWord + - (longWord bitAnd: (16rFF bitShift: shift)) + + (byte bitShift: shift). + self at: longAddr put: longWord. + ^byte! Item was added: + ----- Method: DoubleWordArray>>unsignedLong64At: (in category '*VMMaker-JITSimulation') ----- + unsignedLong64At: byteIndex + "Compatiblity with the ByteArray & Alien methods of the same name." + | wordIndex lowBits high low | + wordIndex := byteIndex - 1 // 8 + 1. + (lowBits := byteIndex - 1 bitAnd: 7) = 0 ifTrue: + [^self at: wordIndex]. + high := (self at: wordIndex + 1) bitShift: 8 - lowBits * 8. + low := (self at: wordIndex) bitShift: lowBits * -8. + ^high = 0 ifTrue: [low] ifFalse: [high + low]! Item was added: + ----- Method: DoubleWordArray>>unsignedLong64At:put: (in category '*VMMaker-JITSimulation') ----- + unsignedLong64At: byteIndex put: aValue + "Compatiblity with the ByteArray & Alien methods of the same name." + | wordIndex lowBits mask allOnes | + wordIndex := byteIndex - 1 // 8 + 1. + (lowBits := byteIndex - 1 bitAnd: 7) = 0 ifTrue: + [^self at: wordIndex put: aValue]. + (aValue bitShift: -64) = 0 ifFalse: + [self errorImproperStore]. + mask := (allOnes := 16rFFFFFFFFFFFFFFFF) bitShift: 8 - lowBits * -8. + self at: wordIndex put: (((self at: wordIndex) bitAnd: mask) bitXor: ((aValue bitShift: lowBits * 8) bitAnd: allOnes - mask)). + self at: wordIndex + 1 put: (((self at: wordIndex + 1) bitAnd: allOnes - mask) bitXor: (allOnes bitAnd: ((aValue bitShift: 8 - lowBits * -8) bitAnd: mask))). + ^aValue! Item was added: + ----- Method: DoubleWordArray>>unsignedLongAt: (in category '*VMMaker-JITSimulation') ----- + unsignedLongAt: byteIndex + "Compatiblity with the ByteArray & Alien methods of the same name." + | wordIndex lowBits word hiWord | + wordIndex := byteIndex - 1 // 8 + 1. + lowBits := byteIndex - 1 bitAnd: 7. + word := (self at: wordIndex) bitShift: lowBits * -8. + lowBits > 4 ifTrue: "access straddles two words" + [hiWord := (self at: wordIndex + 1) bitShift: 8 - lowBits * 8. + word := word + hiWord]. + ^word bitAnd: 16rFFFFFFFF! Item was added: + ----- Method: DoubleWordArray>>unsignedLongAt:put: (in category '*VMMaker-JITSimulation') ----- + unsignedLongAt: byteIndex put: aValue + "Compatiblity with the ByteArray & Alien methods of the same name." + | wordIndex lowBits word allOnes loMask hiMask | + wordIndex := byteIndex - 1 // 8 + 1. + lowBits := byteIndex - 1 bitAnd: 7. + (aValue bitShift: -32) ~= 0 ifTrue: + [self errorImproperStore]. + lowBits <= 4 ifTrue: "access fits in a single word" + [| mask | + mask := 16rFFFFFFFF bitShift: lowBits * 8. + word := self at: wordIndex. + self at: wordIndex put: ((word bitOr: mask) bitXor: (((aValue bitShift: lowBits * 8) bitAnd: mask) bitXor: mask)). + ^aValue]. + "access straddles two words; make lowMask ones where destination is unchanged to avoid overflow" + allOnes := 16rFFFFFFFFFFFFFFFF. + loMask := allOnes bitShift: 8 - lowBits * -8. + hiMask := 16rFFFFFFFF bitShift: 8 - lowBits * -8. + word := self at: wordIndex. + self at: wordIndex put: ((word bitAnd: loMask) bitOr: ((aValue bitAnd: (16rFFFFFFFF bitShift: (lowBits bitAnd: 3) * -8)) bitShift: lowBits * 8)). + word := self at: wordIndex + 1. + self at: wordIndex + 1 put: ((word bitOr: hiMask) bitXor: ((((aValue bitShift: 4 - (lowBits bitAnd: 3) * -8)) bitAnd: hiMask) bitXor: hiMask)). + ^aValue! Item was added: + ----- Method: DoubleWordArray>>unsignedShortAt: (in category '*VMMaker-JITSimulation') ----- + unsignedShortAt: byteIndex + "Compatiblity with the ByteArray & Alien methods of the same name." + | zi word | + zi := byteIndex - 1. + word := self at: zi // 8 + 1. + (zi bitAnd: 1) ~= 0 ifTrue: + [self notYetImplemented]. "i.e. odd access implies implementing straddling two words" + (zi bitAnd: 7) ~= 0 ifTrue: + [word := word bitShift: (zi bitAnd: 7) * -8]. + ^word bitAnd: 16rFFFF! Item was added: + ----- Method: DoubleWordArray>>unsignedShortAt:put: (in category '*VMMaker-JITSimulation') ----- + unsignedShortAt: byteAddress put: short + "Insert a double byte into a 64-bit word (little-endian version)" + | longWord shift lowBits longAddr | + (short < 0 or: [short > 65535]) ifTrue:[^self errorImproperStore]. + lowBits := byteAddress - 1 bitAnd: 7. + (lowBits bitAnd: 1) ~= 0 ifTrue: + [self notYetImplemented]. "i.e. odd access implies implementing straddling two words" + longWord := self at: (longAddr := (byteAddress - 1 - lowBits) // 8 + 1). + shift := lowBits * 8. + longWord := longWord + - (longWord bitAnd: (16rFFFF bitShift: shift)) + + (short bitShift: shift). + self at: longAddr put: longWord. + ^short! Item was added: + ----- Method: IdentityDictionary>>keyAtNonIdentityValue: (in category '*VMMaker-accessing') ----- + keyAtNonIdentityValue: value + "Answer the key that is the external name for the argument, value. If + there is none, answer the result of evaluating exceptionBlock. + Use =, not ==, so strings like 'this' can be found." + + ^self keyAtNonIdentityValue: value ifAbsent: [self errorValueNotFound]! Item was added: + ----- Method: IdentityDictionary>>keyAtNonIdentityValue:ifAbsent: (in category '*VMMaker-accessing') ----- + keyAtNonIdentityValue: value ifAbsent: exceptionBlock + "Answer the key that is the external name for the argument, value. If + there is none, answer the result of evaluating exceptionBlock. + Use =, not ==, so strings like 'this' can be found." + + self associationsDo: + [:association | value = association value ifTrue: [^association key]]. + ^exceptionBlock value! Item was changed: ----- Method: LittleEndianBitmap>>asByteArray (in category 'converting') ----- asByteArray "Faster way to make a byte array from me. copyFromByteArray: makes equal Bitmap." | f bytes hack | + Smalltalk isLittleEndian ifTrue: + [bytes := self shallowCopy. + ByteArray adoptInstance: bytes. + ^bytes]. f := Form extent: 4@self size depth: 8 bits: self. bytes := ByteArray new: self size * 4. hack := Form new hackBits: bytes. + hack swapEndianness. - SmalltalkImage current isBigEndian ifTrue:[hack swapEndianness]. hack copyBits: f boundingBox from: f + at: 0@0 - at: (0@0) clippingBox: hack boundingBox rule: Form over fillColor: nil map: nil. - "f displayOn: hack." + ^bytes + "| v | v := LittleEndianBitmap withAll: (1 to: 4). + [v asByteArray] bench '19,700,000 per second. 50.8 nanoseconds per run.'" + "| v | v := Bitmap withAll: (1 to: 4). + [v asByteArray] bench '977,000 per second. 1.02 microseconds per run.'"! - ^bytes! Item was changed: ----- Method: LittleEndianBitmap>>longAt:put: (in category 'accessing') ----- longAt: byteIndex put: aValue "Compatibility with the ByteArray method of the same name." | lowBits wordIndex mask | lowBits := byteIndex - 1 bitAnd: 3. wordIndex := byteIndex - 1 // 4 + 1. aValue < 0 ifTrue: [aValue < -2147483648 ifTrue: [^self errorImproperStore]] ifFalse: [16r7FFFFFFF < aValue ifTrue: [^self errorImproperStore]]. lowBits = 0 ifTrue: [self at: wordIndex put: (16rFFFFFFFF bitAnd: aValue). ^aValue]. + mask := 16rFFFFFFFF bitShift: 4 - lowBits * -8. - mask := 16rFFFFFFFF bitShift: lowBits * -8. self at: wordIndex put: (((self at: wordIndex) bitAnd: mask) bitXor: ((aValue bitShift: lowBits * 8) bitAnd: mask bitInvert32)). self at: wordIndex + 1 put: (((self at: wordIndex + 1) bitAnd: mask bitInvert32) bitXor: ((aValue bitShift: 4 - lowBits * -8) bitAnd: mask)). ^aValue "(1 to: 8) collect: [:ba| | bm | bm := LittleEndianBitmap new: 4. bm at: 1 put: 16r55555555. bm at: 2 put: 16rAAAAAAAA. bm longAt: ba put: 16r04030201. { (bm at: 1) hex. (bm at: 2) hex }]"! Item was changed: ----- Method: LittleEndianBitmap>>unsignedLongAt:put: (in category 'accessing') ----- unsignedLongAt: byteIndex put: aValue "Compatiblity with the ByteArray & Alien methods of the same name." | lowBits mask wordIndex | wordIndex := byteIndex - 1 // 4 + 1. (lowBits := byteIndex - 1 bitAnd: 3) = 0 ifTrue: [^self at: wordIndex put: aValue]. + (aValue bitShift: -32) = 0 ifFalse: + [^self errorImproperStore]. + mask := 16rFFFFFFFF bitShift: 4 - lowBits * -8. + self at: wordIndex put: (((self at: wordIndex) bitAnd: mask) bitXor: ((aValue bitShift: lowBits * 8) bitAnd: mask bitInvert32)). + self at: wordIndex + 1 put: (((self at: wordIndex + 1) bitAnd: mask bitInvert32) bitXor: (16rFFFFFFFF bitAnd: ((aValue bitShift: 4 - lowBits * -8) bitAnd: mask))). - mask := 16rFFFFFFFF bitShift: lowBits * -8. - self at: wordIndex put: (((self at: wordIndex) bitAnd: mask) bitXor: ((aValue bitShift: 4 - lowBits * 8) bitAnd: mask bitInvert32)). - self at: wordIndex + 1 put: (((self at: wordIndex + 1) bitAnd: mask bitInvert32) bitXor: (16rFFFFFFFF bitAnd: ((aValue bitShift: lowBits * -8) bitAnd: mask))). ^aValue! Item was added: + ----- Method: MemoryTests>>expectedFailures (in category 'testing') ----- + expectedFailures + "As yet we don't support Spur on any big endian platforms, let alone 64-bit ones." + ^#(testBitmap64BitLongs)! Item was removed: - ----- Method: MemoryTests>>test64BitBitmapAccessViaByteArray (in category 'testing') ----- - test64BitBitmapAccessViaByteArray - "MemoryTests new test64BitBitmapAccessViaByteArray" - "(1 to: bits size) collect: [:i| (bits at: i) hex] #('16r23456700' '16rABCDEF01' '16r89' '16r0')" - | bigPositive littlePositive bigNegative littleNegative | - ByteArray adoptInstance: ((bigPositive := Bitmap new: 2) - at: 1 put: 16r01234567; - at: 2 put: 16r89ABCDEF; - yourself). - ByteArray adoptInstance: ((bigNegative := Bitmap new: 2) - at: 1 put: 16rFEDCBA98; - at: 2 put: 16r76543210; - yourself). - ByteArray adoptInstance: ((littlePositive := LittleEndianBitmap new: 2) - at: 1 put: 16r89ABCDEF; - at: 2 put: 16r01234567; - yourself). - ByteArray adoptInstance: ((littleNegative := LittleEndianBitmap new: 2) - at: 1 put: 16r76543210; - at: 2 put: 16rFEDCBA98; - yourself). - 1 to: 8 do: - [:i| - (0 to: 7) do: [:j| | bytes bits | "In a true block so that one can restart" - "BigEndian is just plain perverse, sigh..." - i + j - 1 \\ 4 = 0 ifTrue: - [(bytes := ByteArray new: 32) - replaceFrom: i + j - to: i + j + 7 - with: bigPositive - startingAt: 1. - Bitmap adoptInstance: (bits := bytes copy). - self assert: 16r0123456789ABCDEF equals: (bits unsignedLong64At: i + j). - self assert: 16r0123456789ABCDEF equals: (bits long64At: i + j). - (bytes := ByteArray new: 32) - replaceFrom: i + j - to: i + j + 7 - with: bigNegative - startingAt: 1. - Bitmap adoptInstance: (bits := bytes copy). - self assert: 16rFEDCBA9876543210 equals: (bits unsignedLong64At: i + j). - self assert: (bits long64At: i + j) < 0. - self assert: 16rFEDCBA9876543210 equals: ((bits long64At: i + j) bitAnd: 16rFFFFFFFFFFFFFFFF)]. - (bytes := ByteArray new: 32) - replaceFrom: i + j - to: i + j + 7 - with: littlePositive - startingAt: 1. - LittleEndianBitmap adoptInstance: (bits := bytes copy). - self assert: 16r0123456789ABCDEF equals: (bits unsignedLong64At: i + j). - self assert: 16r0123456789ABCDEF equals: (bits long64At: i + j). - (bytes := ByteArray new: 32) - replaceFrom: i + j - to: i + j + 7 - with: littleNegative - startingAt: 1. - LittleEndianBitmap adoptInstance: (bits := bytes copy). - self assert: 16rFEDCBA9876543210 equals: (bits unsignedLong64At: i + j). - self assert: (bits long64At: i + j) < 0. - self assert: 16rFEDCBA9876543210 equals: ((bits long64At: i + j) bitAnd: 16rFFFFFFFFFFFFFFFF)]]! Item was added: + ----- Method: MemoryTests>>testByteArray16BitShorts (in category 'testing') ----- + testByteArray16BitShorts + "Test that ByteArray provides little-endian access for 16-bit accessors" + self testLittleEndianShortAccessFor: ByteArray! Item was added: + ----- Method: MemoryTests>>testByteArray32BitLongs (in category 'testing') ----- + testByteArray32BitLongs + "Test that ByteArray provides big-endian access for 32-bit accessors" + self testLittleEndian32BitLongAccessFor: ByteArray! Item was added: + ----- Method: MemoryTests>>testByteArray64BitLongs (in category 'testing') ----- + testByteArray64BitLongs + "Test that ByteArray provides big-endian access for 64-bit accessors" + self testLittleEndian64BitLongAccessFor: ByteArray! Item was added: + ----- Method: MemoryTests>>testDoubleWordArray16BitShorts (in category 'testing') ----- + testDoubleWordArray16BitShorts + "Test that DoubleWordArray provides little-endian access for 16-bit accessors" + self testLittleEndianShortAccessFor: DoubleWordArray! Item was added: + ----- Method: MemoryTests>>testDoubleWordArray32BitLongs (in category 'testing') ----- + testDoubleWordArray32BitLongs + "Test that DoubleWordArray provides little-endian access for 32-bit accessors" + self testLittleEndian32BitLongAccessFor: DoubleWordArray! Item was added: + ----- Method: MemoryTests>>testDoubleWordArray64BitLongs (in category 'testing') ----- + testDoubleWordArray64BitLongs + "Test that DoubleWordArray provides little-endian access for 64-bit accessors" + self testLittleEndian64BitLongAccessFor: DoubleWordArray! Item was added: + ----- Method: MemoryTests>>testLittleEndian32BitLongAccessFor: (in category 'test support') ----- + testLittleEndian32BitLongAccessFor: aClass + "Test that ByteArray provides big-endian access for 32-bit accessors" + "memory copy changeClassTo: ByteArray" + | memory | + memory := aClass new: 64 / (aClass new: 0) bytesPerElement. + "signed access" + 0 to: 30 do: + [:shift| + #(-1 1) do: + [:initial| | value | + value := initial bitShift: shift. + memory longAt: 1 put: value. + self assert: value equals: (memory longAt: 1). + "aligned store" + memory + longAt: 5 put: 16r55550000; + longAt: 9 put: 16r00005555. + self assert: 16r55555555 equals: (memory longAt: 7). + memory longAt: 7 put: value. + self assert: value equals: (memory longAt: 7). + "check bytes either side have not been changed" + 5 to: 6 do: + [:i| self assert: 0 equals: (memory byteAt: i)]. + 11 to: 15 do: + [:i| self assert: 0 equals: (memory byteAt: i)]. + "unaligned store" + memory + longAt: 6 put: 16r55550000; + longAt: 10 put: 16r00005555. + self assert: 16r55555555 equals: (memory longAt: 8). + memory longAt: 8 put: value. + self assert: value equals: (memory longAt: 8). + "check bytes either side have not been changed" + 5 to: 7 do: + [:i| self assert: 0 equals: (memory byteAt: i)]. + 12 to: 15 do: + [:i| self assert: 0 equals: (memory byteAt: i)]]]. + "unsigned access" + 0 to: 31 do: + [:shift| | value | + value := 1 bitShift: shift. + memory unsignedLongAt: 1 put: value. + self assert: value equals: (memory unsignedLongAt: 1). + "aligned store" + memory + longAt: 5 put: 16r55550000; + longAt: 9 put: 16r00005555. + self assert: 16r55555555 equals: (memory unsignedLongAt: 7). + memory unsignedLongAt: 7 put: value. + self assert: value equals: (memory unsignedLongAt: 7). + "check bytes either side have not been changed" + 5 to: 6 do: + [:i| self assert: 0 equals: (memory byteAt: i)]. + 11 to: 15 do: + [:i| self assert: 0 equals: (memory byteAt: i)]. + "unaligned store" + memory + longAt: 6 put: 16r55550000; + longAt: 10 put: 16r00005555. + self assert: 16r55555555 equals: (memory unsignedLongAt: 8). + memory unsignedLongAt: 8 put: value. + self assert: value equals: (memory unsignedLongAt: 8). + "check bytes either side have not been changed" + 5 to: 7 do: + [:i| self assert: 0 equals: (memory byteAt: i)]. + 12 to: 15 do: + [:i| self assert: 0 equals: (memory byteAt: i)]]! Item was added: + ----- Method: MemoryTests>>testLittleEndian64BitLongAccessFor: (in category 'test support') ----- + testLittleEndian64BitLongAccessFor: aClass + "Test that the given class provides little-endian access for 64-bit accessors" + "memory copy changeClassTo: ByteArray" + | memory | + memory := aClass new: 64 / (aClass new: 0) bytesPerElement. + "signed access" + 0 to: 62 do: + [:shift| + #(-1 1) do: + [:initial| | value | + value := initial bitShift: shift. + memory long64At: 1 put: value. + self assert: value equals: (memory long64At: 1). + "aligned store" + memory + long64At: 9 put: 16r5555550000000000; + long64At: 17 put: 16r0000005555555555. + self assert: 16r5555555555555555 equals: (memory long64At: 14). + memory long64At: 14 put: value. + self assert: value equals: (memory long64At: 14). + "check bytes either side have not been changed" + 9 to: 13 do: + [:i| self assert: 0 equals: (memory byteAt: i)]. + 22 to: 31 do: + [:i| self assert: 0 equals: (memory byteAt: i)]. + "unaligned store" + memory + long64At: 10 put: 16r5555550000000000; + long64At: 18 put: 16r0000005555555555. + self assert: 16r5555555555555555 equals: (memory long64At: 15). + memory long64At: 15 put: value. + self assert: value equals: (memory long64At: 15). + "check bytes either side have not been changed" + 9 to: 14 do: + [:i| self assert: 0 equals: (memory byteAt: i)]. + 23 to: 31 do: + [:i| self assert: 0 equals: (memory byteAt: i)]]]. + "unsigned access" + 0 to: 63 do: + [:shift| | value | + value := 1 bitShift: shift. + memory unsignedLong64At: 1 put: value. + self assert: value equals: (memory unsignedLong64At: 1). + "aligned store" + memory + unsignedLong64At: 9 put: 16r5555550000000000; + unsignedLong64At: 17 put: 16r0000005555555555. + self assert: 16r5555555555555555 equals: (memory unsignedLong64At: 14). + memory unsignedLong64At: 14 put: value. + self assert: value equals: (memory unsignedLong64At: 14). + "check bytes either side have not been changed" + 9 to: 13 do: + [:i| self assert: 0 equals: (memory byteAt: i)]. + 22 to: 31 do: + [:i| self assert: 0 equals: (memory byteAt: i)]. + "unaligned store" + memory + unsignedLong64At: 10 put: 16r5555550000000000; + unsignedLong64At: 18 put: 16r0000005555555555. + self assert: 16r5555555555555555 equals: (memory unsignedLong64At: 15). + memory unsignedLong64At: 15 put: value. + self assert: value equals: (memory unsignedLong64At: 15). + "check bytes either side have not been changed" + 9 to: 14 do: + [:i| self assert: 0 equals: (memory byteAt: i)]. + 23 to: 31 do: + [:i| self assert: 0 equals: (memory byteAt: i)]]! Item was added: + ----- Method: MemoryTests>>testLittleEndianBitmap16BitShorts (in category 'testing') ----- + testLittleEndianBitmap16BitShorts + "Test that LittleEndianBitmap provides little-endian access for 16-bit accessors" + self testLittleEndianShortAccessFor: LittleEndianBitmap! Item was changed: ----- Method: MemoryTests>>testLittleEndianBitmap32BitLongs (in category 'testing') ----- testLittleEndianBitmap32BitLongs "Test that LittleEndianBitmap provides little-endian access for 32-bit accessors" + self testLittleEndian32BitLongAccessFor: LittleEndianBitmap! - | memory | - memory := LittleEndianBitmap new: 64. - 0 to: 30 do: - [:shift| - #(-1 1) do: - [:initial| | value | - value := initial bitShift: shift. - memory longAt: 1 put: value. - self assert: value equals: (memory longAt: 1). - memory - longAt: 5 put: 16r55550000; - longAt: 9 put: 16r00005555. - self assert: 16r55555555 equals: (memory longAt: 7). - memory longAt: 7 put: value. - self assert: value equals: (memory longAt: 7). - self assert: 0 equals: (memory at: (shift <= 15 = (initial >= 0) ifTrue: [9] ifFalse: [5]))]]. - 31 to: 32 do: - [:shift| - self should: [memory longAt: 1 put: -1 << shift - 1] raise: Error. - self should: [memory longAt: 1 put: 1 << shift] raise: Error]. - 0 to: 31 do: - [:shift| | value | - value := 1 bitShift: shift. - memory unsignedLongAt: 1 put: value. - self assert: value equals: (memory unsignedLongAt: 1). - memory - longAt: 5 put: 16r55550000; - longAt: 9 put: 16r00005555. - self assert: 16r55555555 equals: (memory unsignedLongAt: 7). - memory unsignedLongAt: 7 put: value. - self assert: value equals: (memory unsignedLongAt: 7). - self assert: 0 equals: (memory at: (shift <= 15 ifTrue: [9] ifFalse: [5]))]. - self should: [memory unsignedLongAt: 1 put: -1] raise: Error. - 32 to: 33 do: - [:shift| - self should: [memory unsignedLongAt: 1 put: 1 << shift] raise: Error]! Item was changed: ----- Method: MemoryTests>>testLittleEndianBitmap64BitLongs (in category 'testing') ----- testLittleEndianBitmap64BitLongs + "Test that LittleEndianBitmap provides little-endian access for 64-bit accessors" + self testLittleEndian64BitLongAccessFor: LittleEndianBitmap! - "Test that Bitmap provides little-endian access for 64-bit accessors" - | memory | - memory := LittleEndianBitmap new: 64. - 0 to: 62 do: - [:shift| - #(-1 1) do: - [:initial| | value | - value := initial bitShift: shift. - memory long64At: 1 put: value. - self assert: value equals: (memory long64At: 1). - memory - long64At: 10 put: 16r5555550000000000; - long64At: 18 put: 16r0000005555555555. - self assert: 16r5555555555555555 equals: (memory long64At: 15). - "(1 to: 6) collect: [:i| (memory at: i) hex]" - memory long64At: 13 put: value. - self assert: value equals: (memory long64At: 13). - self assert: 0 equals: (memory at: (shift <= 15 = (initial >= 0) ifTrue: [17] ifFalse: [13])). - self assert: 0 equals: (memory at: (shift <= 15 = (initial >= 0) ifTrue: [21] ifFalse: [13]))]]. - 63 to: 64 do: - [:shift| - self should: [memory long64At: 1 put: -1 << shift - 1] raise: Error. - self should: [memory long64At: 1 put: 1 << shift] raise: Error]. - 0 to: 63 do: - [:shift| | value | - value := 1 bitShift: shift. - memory unsignedLong64At: 1 put: value. - self assert: value equals: (memory unsignedLong64At: 1). - memory - unsignedLong64At: 10 put: 16r5555550000000000; - unsignedLong64At: 18 put: 16r0000005555555555. - self assert: 16r5555555555555555 equals: (memory unsignedLong64At: 15). - memory unsignedLong64At: 7 put: value. - self assert: value equals: (memory unsignedLong64At: 7). - self assert: 0 equals: (memory at: (shift <= 31 ifTrue: [17] ifFalse: [9])). - self assert: 0 equals: (memory at: (shift <= 31 ifTrue: [21] ifFalse: [13]))]. - self should: [memory unsignedLong64At: 1 put: -1] raise: Error. - 64 to: 65 do: - [:shift| - self should: [memory unsignedLong64At: 1 put: 1 << shift] raise: Error]! Item was added: + ----- Method: MemoryTests>>testLittleEndianShortAccessFor: (in category 'test support') ----- + testLittleEndianShortAccessFor: aClass + | memory | + 1 to: 9 by: 2 do: + [:i| + memory := aClass new: 64 / (aClass new: 0) bytesPerElement. + memory unsignedShortAt: i put: 16r7FFF. + 1 to: i - 1 do: + [:j| self assert: 0 equals: (memory byteAt: j)]. + self assert: 16rFF equals: (memory byteAt: i). + self assert: 16r7F equals: (memory byteAt: i + 1). + (i + 2 to: 8) do: + [:j| self assert: 0 equals: (memory byteAt: j)]]. + + 16 to: 32 do: + [:shift| + self should: [memory unsignedShortAt: 1 put: -1 << shift - 1] raise: Error. + self should: [memory unsignedShortAt: 1 put: 1 << shift] raise: Error]. + ! Item was added: + ----- Method: MemoryTests>>testSignedOutOfRangeAccess (in category 'testing') ----- + testSignedOutOfRangeAccess + {ByteArray. Bitmap. LittleEndianBitmap. DoubleWordArray} do: + [:class| | bytesPerElement memory | + bytesPerElement := (class new: 0) bytesPerElement. + memory := class new: 64 / bytesPerElement. + 1 to: 16 do: + [:i| + self should: [memory byteAt: i put: 1 << 8] raise: Error. + self should: [memory byteAt: i put: -1 << 7 - 1] raise: Error. + self should: [memory shortAt: i put: 1 << 16] raise: Error. + self should: [memory shortAt: i put: -1 << 15 - 1] raise: Error. + self should: [memory longAt: i put: 1 << 32] raise: Error. + self should: [memory longAt: i put: -1 << 31 - 1] raise: Error. + self should: [memory long64At: i put: 1 << 64] raise: Error. + self should: [memory long64At: i put: -1 << 63 - 1] raise: Error]. + 1 to: memory size do: + [:i| + self assert: 0 equals: (memory at: i)]]! Item was added: + ----- Method: MemoryTests>>testUnsignedOutOfRangeAccess (in category 'testing') ----- + testUnsignedOutOfRangeAccess + {ByteArray. Bitmap. LittleEndianBitmap. DoubleWordArray} do: + [:class| | bytesPerElement memory | + bytesPerElement := (class new: 0) bytesPerElement. + memory := class new: 64 / bytesPerElement. + 1 to: 16 do: + [:i| + self should: [memory unsignedByteAt: i put: 1 << 8] raise: Error. + self should: [memory unsignedByteAt: i put: -1] raise: Error. + self should: [memory unsignedShortAt: i put: 1 << 16] raise: Error. + self should: [memory unsignedShortAt: i put: -1] raise: Error. + self should: [memory unsignedLongAt: i put: 1 << 32] raise: Error. + self should: [memory unsignedLongAt: i put: -1] raise: Error. + self should: [memory unsignedLong64At: i put: 1 << 64] raise: Error. + self should: [memory unsignedLong64At: i put: -1] raise: Error]. + 1 to: memory size do: + [:i| + self assert: 0 equals: (memory at: i)]]! Item was changed: ----- Method: Spur64BitCoMemoryManager class>>simulatorClass (in category 'simulation') ----- simulatorClass + ^Spur64BitMMLECoSimulatorFor64Bits basicNew memoryClass + ifNil: [Spur64BitMMLECoSimulator] + ifNotNil: [Spur64BitMMLECoSimulatorFor64Bits]! - ^Spur64BitMMLECoSimulator! Item was changed: ----- Method: VMMaker>>generateEntire (in category 'generate sources') ----- generateEntire "Generate the interp, internal plugins and exports as well as the external plugins. + If this comes from a generator method, log it for convenience." - If this comes from a generator, log it for convenience." abortBlock := [^self]. + self logGeneration. - self configurationGeneratorNameOrNil ifNotNil: - [:generator| - logger cr; nextPutAll: (generator selector copyReplaceAll: 'generate' with: ''). - interpreterClassName ifNotNil: - [logger space; nextPutAll: (CCodeGenerator shortMonticelloDescriptionForClass: (Smalltalk classNamed: interpreterClassName))]. - logger cr; flush]. self generateMainVM. self generateExternalPlugins! Item was changed: ----- Method: VMMaker>>generatePlugins (in category 'generate sources') ----- generatePlugins "Generate the ``external'' plugins. + If this comes from a generator method, log it for convenience." - If this comes from a generator, log it for convenience." abortBlock := [^self]. + self logGeneration. - self configurationGeneratorNameOrNil ifNotNil: - [:generator| - logger cr; nextPutAll: (generator selector copyReplaceAll: 'generate' with: ''). - interpreterClassName ifNotNil: - [logger space; nextPutAll: (CCodeGenerator shortMonticelloDescriptionForClass: (Smalltalk classNamed: interpreterClassName))]. - logger cr; flush]. self generateExternalPlugins! Item was added: + ----- Method: VMMaker>>logGeneration (in category 'generate sources') ----- + logGeneration + self configurationGeneratorNameOrNil ifNotNil: + [:generator| + logger cr; nextPutAll: (generator selector copyReplaceAll: 'generate' with: ''). + interpreterClassName ifNotNil: + [logger space; nextPutAll: (CCodeGenerator shortMonticelloDescriptionForClass: (Smalltalk classNamed: interpreterClassName))]. + sourceDirName ifNotNil: + [logger nextPutAll: ' to '; nextPutAll: sourceDirName]. + logger cr; flush]!

1 0

Garbage Collection (was Re: [Pharo-dev] Discussing the roadmap)
by Ben Coman 04 Dec '17

04 Dec '17

Hi Eliot, Clement, On 7 July 2017 at 00:41, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > > > - Better support for large heaps (GC tuning API, incremental GC). > > Pharo 64 bit is now able to manage large heap. However better > > performance can be proposed by offering better settings for the > > different GC zone. > > The most important thing here is the incremental GC. Spur has a generation > scavenger that collects garbage in newly created objects (new space), > and a mark-compact collector that collects and compacts garbage in old space. > > Right now on my 2.3GHz MacMini doing normal development, the generation > scavenger causes pauses of 1ms or less, and the mark-compact collector > than causes pauses of around 200ms. Both account for about 0.75% of > entire execution time (1.5% total), so the scavenger is invoked frequently > and the pauses that it creates are not noticeable. But the occasional > pauses created by the mark-compact collector /are/ noticeable, > especially in games and music. > > The idea for the incremental collector is to implement a mark-sweep or > mark-sweep-compact collector for old space that works incrementally, > doing a little bit of work on each invocation, probably immediately after a scavenge. > It is intended to avoid the long pauses caused by the non-incremental > mark-compact collector and make the system more suitable for games, music, etc. Reading http://www.mirandabanda.org/cogblog/2013/09/13/lazy-become-and-a-partial-re… "An alternative implementation, oft-used in Lisp systems, is to add a read barrier to all object access, and mark objects as forwarders. This can be used to implement a >>>lazy copying garbage collection<<<< where objects are copied from one semi-space to another in parallel to the main program (the “mutator”). To become, or move an object one replaces the object’s header or first field with a forwarding pointer to the desired target or copy in a new location, marking the “corpse” as forwarded. The program checks the forwarded flag on each access. If there is hardware support, as in a Lisp machine, this can work well. But without hardware support, and like the object table representation, it has costs, slowing down program execution due to the scattering of forwarding checks and forwarding pointer follows throughout program execution." I'm curious... Given we now have forwarders with Spur, are we already sufficiently paying the cost of forwarding checks that a lazy copying garbage collector might be a feasible form of incremental garbage collection? I presume "parallel to the main program" means garbage collection occuring in a separate thread to the main vm thread, potentially resulting in very low main program pause times for garbage collection. I found this a useful summary of the terminology... * https://www.dynatrace.com/resources/ebooks/javabook/reduce-garbage-collecti… and I'm curious how our planned Incremental CG fits those categories. That article got me contemplating our performance constraint of the VM only operating in only in a single native thread. Even though GC is a only a few percent of performance, I wondered what a concurrent GC might look like for us. I found this video describing concurrent GC in Go (ignore first 11:20 and the second half was not so interesting) * https://pusher.com/sessions/meetup/the-realtime-guild/golangs-realtime-garb… where they present some interesting charts of their concern with latency pauses. (btw they reference a multi-language GC latency benchmark https://github.com/WillSewell/gc-latency-experiment) And for balance of that I found... https://blog.plan99.net/modern-garbage-collection-911ef4f8bd8e And then my mind wandered around implementation details of concurrent garbage collection. To organise and quiet my thoughts I needed to put pen to paper, so I thought sharing that might stir thoughts for others. Probably naive and please excuse the brain dump format... Considering two threads... * Main program thread "MP" * Garbage collection thread "GC" with object-space shared between them, consisting of objects split in object-header & object-body... 1. Only "MP" mutates the object-body, updating slots creating new edges in the object-graph, and relocating objects in memory using forwarders. This rule avoids potential race conditions without needing to add synchronisation code affecting performance of "MP". 2. Concurrently "GC" performs a Marking Phase by following the object-graph tricolour tagging objects gray & black. it needs to mutate the object-header, in a synchronised way something like... a. Load object-header from shared object-space into local variable H <== object-header b. Modify header into another local variable H' <== H + updated GC color bits c. Atomic compare-and-swap H' back into object-space object-header <== if H then H' "MP" gets priority. Conflicts presumed rare. Then considering object mutation by "MP" concurrent/overlapped with "GC" marking... 3. TLDR; see 4. In old-space if 'mutated' object is linked to a 'target' object a. if 'mutated' isBlack, "MP" marks 'target' gray (to be later processed by "GC"). b. if 'mutated' isGray, overlapped 'mutated' gray->black by "GC" while 'target' remains white would break tricolor invariant (is it a credible case?), options... i. mark 'target' gray, the state anyway in case 'mutated' gray -> black ii. re-mark 'mutated' gray, i.e. normally gray->gray, and rarely black->gray iii. optimisticly just check after mutation if color changed (cached reads cheaper than writes and conflicts presumed rare) then set color to gray. c. if 'mutated' isWhite, options... i. do nothing and let "GC" reach 'target' normally, as long as overlapped white->black cannot occur ii. if white->black possible, do same as (3.b) "MP" marks 'target' gray, to be later processed by "GC". 4. Overall simplification of (3.) might be... "MP" checks for any color change during mutation, and only then marks 'mutated' object gray. How expensive would such a check be? Presumed marking is infrequent and can be done safely like (2.) 5. Eden/survivor space is ignored by "GC" thread. No point in adding work to the gray set until survivors filtered. Stop the world scavenging done as normal by "MP", only marking objects gray when they are moved to old-space. Post scavenging options... a. Resume the world and leave it for "GC" to process these recently grayed objects. b. Keep world stopped for "MP" to complete marking, emptying gray set to transition to Sweep Phase, at which point "MP" resumes the world. It doesn't matter if subsequently objects are added to the gray set, since existing white objects can never again be referenced by "MP". 6. Sweeping can be safely done by "GC" since white-objects are unreachable from "MP". "GC" can also take time to determine an optimum page P to compact and then (per 1.) passes to "MP" via a relocation-queue the objects to be relocated using forwarding pointers. "GC" could even spend extra time to determine the optimum relocation-destination without impacting the performance of "MP". When "MP" empties the relocation-queue, "GC" starts on the next Marking Phase. 7. Now a question remains about multi-threaded flattening of forwarding pointers. If two threads simultaneously perform an identical transform from... someObject-slot --> forwarder-b --> finalObject-c to... someObject-slot --> finalObject-c does it matter that these operation may be done twice overlapping? Options... a. One mitigation could be for "GC" to identify forwarders to be flattened and queue them for "MP" to process (reuse the compaction-queue). This is work that "MP" would need to do anyway, but brings it forward to be dealt with at a convenient time. b. I guess "MP" and "GC" could play nice together if when encountering a slot containing with a forwarding pointer they both do something similar to (2.) like... i. Load object-slot from shared object-space into local variable S <== slot ii. Set local variable S' <== flattened/followed pointer iii. Atomic compare-and-swap S' back into object-space, (object-slot <== if S then S') - "MP" gets priority but presume conflicts rare anyway. - While this violates rule (1.) the presumed frequency of encountering forwarding pointers is low for "MP", so performance should not be affected. Indeed by "GC" pre-emptively flattening forwarders the frequency "MP" sees reduces. 8. The release of the compacted page back to the OS is held up by forwarding pointers. Forwarders are part of the graph followed in the Marking Phase they get marked gray/black just like objects if they are referenced. After forwarders are fully flattened they are skipped by Marking and end up marked white and released just like any other object. Once all forwarders are released, the page is released to the OS. If "GC" can effectively flatten pointers concurrently with "MP" during its normal Marking Phase, then pages would be released back to the OS in a timely manner. Now one thing I am curious about how the GC tri-color marking is implemented. At https://clementbera.wordpress.com/2014/01/16/spurs-new-object-format it describes how Spur's object header has three bits for GC. * isGray * isRemembered * isMarked (I presume this means marked "black") Do the bits imply the gray set is not stored in a separate data structure on the heap, but rather distributed in-place, which I guess would require multiple passes through memory to grow the gray set? So this is not an area I'm set up to seriously work on, but I remain curious and hopefully its a useful seed discussion for others. cheers -ben P.S. At https://clementbera.wordpress.com/2017/09/19/vm-learning-memory-management/ nice to hear that you have Sophie (I presume) continuing with the VM.

3 3

[OpenSmalltalk/opensmalltalk-vm] 2a260d: Enable ASLR and DEP in Windows
by GitHub 01 Dec '17

01 Dec '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 2a260de3b3e63ba205e49db619ff571cf7348fce https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a260de3b3e63ba205… Author: Luís Câmara <luis.camara(a)live.com.pt> Date: 2017-11-03 (Fri, 03 Nov 2017) Changed paths: M build.win32x86/common/Makefile.tools Log Message: ----------- Enable ASLR and DEP in Windows Commit: 53e966784526b9b0559fce1b1d74cc942b4f2300 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/53e966784526b9b055… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-12-01 (Fri, 01 Dec 2017) Changed paths: M build.win32x86/common/Makefile.tools Log Message: ----------- Merge pull request #166 from luis140219/patch-2 Enable ASLR and DEP in Win32 Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/106fdde6feb8...53…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev December 2017