Vm-dev July 2017

vm-dev@lists.squeakfoundation.org

18 participants
54 discussions

[OpenSmalltalk/opensmalltalk-vm] 6a2c4f: Fix SqueakImageLength for UNICODE.
by GitHub 20 Jul '17

20 Jul '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 6a2c4f408bc54dfa91f4c7bb8de5d992867b927e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/6a2c4f408bc54dfa91… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-07-20 (Thu, 20 Jul 2017) Changed paths: M platforms/win32/vm/sqWin32Window.c Log Message: ----------- Fix SqueakImageLength for UNICODE.

1 0

[OpenSmalltalk/opensmalltalk-vm] acdbde: sqWin32Utils.c needs to include tchar.h.
by GitHub 20 Jul '17

20 Jul '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: acdbdea909dcbe0b4b3050497bfeac2dbbf2ba5e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/acdbdea909dcbe0b4b… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-07-20 (Thu, 20 Jul 2017) Changed paths: M build.win32x86/common/Makefile M platforms/win32/vm/sqWin32Utils.c M platforms/win32/vm/sqWin32Window.c Log Message: ----------- sqWin32Utils.c needs to include tchar.h. Correct SqueakImageLength's definition to agree with its declaration.

1 0

VM Maker: VMMaker.oscog-eem.2256.mcz
by commits＠source.squeak.org 19 Jul '17

19 Jul '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2256.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2256 Author: eem Time: 19 July 2017, 2:30:03.191349 pm UUID: a09b02f9-394f-4d4e-bb52-4380bd587207 Ancestors: VMMaker.oscog-eem.2255 Provide primitive 248 as a don't-copy-hash alternative to primitive 72 (primitiveArrayBecomeForward, the primitive in elementsForwardIdentityTo: which implements becomeForward:. =============== Diff against VMMaker.oscog-eem.2255 =============== Item was changed: ----- Method: InterpreterPrimitives>>primitiveArrayBecomeOneWayCopyHash (in category 'object access primitives') ----- primitiveArrayBecomeOneWayCopyHash "Similar to primitiveArrayBecomeOneWay but accepts a third argument deciding whether to + copy the receiver's elements identity hashes over the argument's elements identity hashes." - copy the receiver's element's identity hash over the argument's elementy's identity hash." | copyHashFlag ec | self stackTop = objectMemory trueObject ifTrue: [copyHashFlag := true] ifFalse: [self stackTop = objectMemory falseObject ifTrue: [copyHashFlag := false] ifFalse: [self primitiveFailFor: PrimErrBadArgument. ^nil]]. ec := objectMemory become: (self stackValue: 2) with: (self stackValue: 1) twoWay: false copyHash: copyHashFlag. ec = PrimNoErr ifTrue: [self pop: argumentCount] ifFalse: [self primitiveFailFor: ec]! Item was added: + ----- Method: InterpreterPrimitives>>primitiveArrayBecomeOneWayNoCopyHash (in category 'object access primitives') ----- + primitiveArrayBecomeOneWayNoCopyHash + "Similar to primitiveArrayBecomeOneWay but does /not/ copy the receiver's + elements identity hashes over the argument's elements identity hashes." + + | arg rcvr ec | + arg := self stackTop. + rcvr := self stackValue: 1. + ec := objectMemory become: rcvr with: arg twoWay: false copyHash: false. + ec = PrimNoErr + ifTrue: [self pop: 1] + ifFalse: [self primitiveFailFor: ec]! Item was changed: ----- Method: StackInterpreter class>>initializePrimitiveTable (in category 'initialization') ----- (excessive size, no diff calculated)

1 0

VM Maker: VMMaker.oscog-eem.2255.mcz
by commits＠source.squeak.org 19 Jul '17

19 Jul '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2255.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2255 Author: eem Time: 19 July 2017, 10:59:59.730933 am UUID: 496474d7-fcb8-4a80-9e16-19f6b510bcc0 Ancestors: VMMaker.oscog-eem.2254 Rewrite remaining pop:;push: users in primiotives to use pop:thenPush: =============== Diff against VMMaker.oscog-eem.2254 =============== Item was changed: ----- Method: CroquetPlugin>>primitiveOrthoNormInverseMatrix (in category 'transforms') ----- primitiveOrthoNormInverseMatrix | srcOop dstOop src dst x y z rx ry rz | <export: true> + <var: #src type: #'float *'> + <var: #dst type: #'float *'> + <var: #x type: #double> + <var: #y type: #double> + <var: #z type: #double> + <var: #rx type: #double> + <var: #ry type: #double> + <var: #rz type: #double> - <var: #src declareC:'float *src'> - <var: #dst declareC:'float *dst'> - <var: #x declareC:'double x'> - <var: #y declareC:'double y'> - <var: #z declareC:'double z'> - <var: #rx declareC:'double rx'> - <var: #ry declareC:'double ry'> - <var: #rz declareC:'double rz'> interpreterProxy methodArgumentCount = 0 ifFalse:[^interpreterProxy primitiveFail]. srcOop := interpreterProxy stackObjectValue: 0. interpreterProxy failed ifTrue:[^nil]. ((interpreterProxy isWords: srcOop) and:[(interpreterProxy slotSizeOf: srcOop) = 16]) ifFalse:[^interpreterProxy primitiveFail]. dstOop := interpreterProxy clone: srcOop. "reload srcOop in case of GC" srcOop := interpreterProxy stackObjectValue: 0. src := interpreterProxy firstIndexableField: srcOop. dst := interpreterProxy firstIndexableField: dstOop. "Transpose upper 3x3 matrix" "dst at: 0 put: (src at: 0)." dst at: 1 put: (src at: 4). dst at: 2 put: (src at: 8). dst at: 4 put: (src at: 1). "dst at: 5 put: (src at: 5)." dst at: 6 put: (src at: 9). dst at: 8 put: (src at: 2). dst at: 9 put: (src at: 6). "dst at: 10 put: (src at: 10)." "Compute inverse translation vector" x := src at: 3. y := src at: 7. z := src at: 11. rx := (x * (dst at: 0)) + (y * (dst at: 1)) + (z * (dst at: 2)). ry := (x * (dst at: 4)) + (y * (dst at: 5)) + (z * (dst at: 6)). rz := (x * (dst at: 8)) + (y * (dst at: 9)) + (z * (dst at: 10)). + dst at: 3 put: (self cCoerce: 0.0-rx to: #float). + dst at: 7 put: (self cCoerce: 0.0-ry to: #float). + dst at: 11 put: (self cCoerce: 0.0-rz to: #float). - dst at: 3 put: (self cCoerce: 0.0-rx to: 'float'). - dst at: 7 put: (self cCoerce: 0.0-ry to: 'float'). - dst at: 11 put: (self cCoerce: 0.0-rz to: 'float'). + interpreterProxy pop: 1 thenPush: dstOop! - interpreterProxy pop: 1. - ^interpreterProxy push: dstOop. - ! Item was changed: ----- Method: InterpreterPrimitives>>primitiveGetLogDirectory (in category 'I/O primitives') ----- primitiveGetLogDirectory "Primitive. Answer the VM's current log directory" | ptr sz stringOop | <var: 'ptr' type: 'char*'> <export: true> ptr := self ioGetLogDirectory. ptr == nil ifTrue:[^self success: false]. sz := self strlen: ptr. stringOop := objectMemory instantiateClass: objectMemory classString indexableSize: sz. 0 to: sz-1 do:[:i| objectMemory storeByte: i ofObject: stringOop withValue: (ptr at: i)]. + self pop: argumentCount+1 thenPush: stringOop! - self pop: self methodArgumentCount+1. - self push: stringOop.! Item was changed: ----- Method: InterpreterPrimitives>>primitiveGetWindowLabel (in category 'I/O primitives') ----- primitiveGetWindowLabel "Primitive. Answer the OS window's label" | ptr sz labelOop | <var: 'ptr' type: 'char*'> <export: true> ptr := self ioGetWindowLabel. ptr == nil ifTrue:[^self success: false]. sz := self strlen: ptr. labelOop := objectMemory instantiateClass: objectMemory classString indexableSize: sz. 0 to: sz-1 do:[:i| objectMemory storeByte: i ofObject: labelOop withValue: (ptr at: i)]. + self pop: argumentCount+1 thenPush: labelOop! - self pop: self methodArgumentCount+1. - self push: labelOop.! Item was changed: ----- Method: InterpreterPrimitives>>primitiveImageName (in category 'other primitives') ----- primitiveImageName "When called with a single string argument, record the string as the current image file name. When called with zero arguments, return a string containing the current image file name." | s sz sCRIfn okToRename | <var: #sCRIfn type: 'void *'> argumentCount = 1 ifTrue: [ "If the security plugin can be loaded, use it to check for rename permission. If not, assume it's ok" sCRIfn := self ioLoadFunction: 'secCanRenameImage' From: 'SecurityPlugin'. sCRIfn ~= 0 ifTrue: [okToRename := self cCode: '((sqInt (*)(void))sCRIfn)()' inSmalltalk: [self dispatchMappedPluginEntry: sCRIfn]. okToRename ifFalse: [^self primitiveFail]]. s := self stackTop. self assertClassOf: s is: (objectMemory splObj: ClassByteString). self successful ifTrue: [ sz := self stSizeOf: s. self imageNamePut: (s + objectMemory baseHeaderSize) Length: sz. self pop: 1. "pop s, leave rcvr on stack" ]. ] ifFalse: [ sz := self imageNameSize. s := objectMemory instantiateClass: (objectMemory splObj: ClassByteString) indexableSize: sz. self imageNameGet: (s + objectMemory baseHeaderSize) Length: sz. + self pop: 1 thenPush: s - self pop: 1. "rcvr" - self push: s. ]! Item was changed: ----- Method: InterpreterPrimitives>>primitiveScanCharacters (in category 'I/O primitives') ----- primitiveScanCharacters "The character scanner primitive." | kernDelta stops sourceString scanStopIndex scanStartIndex rcvr scanDestX scanLastIndex scanXTable scanMap maxGlyph ascii stopReason glyphIndex sourceX sourceX2 nextDestX scanRightX nilOop | self methodArgumentCount = 6 ifFalse: [^ self primitiveFail]. "Load the receiver and arguments" kernDelta := self stackIntegerValue: 0. stops := self stackValue: 1. scanRightX := self stackIntegerValue: 2. sourceString := self stackValue: 3. scanStopIndex := self stackIntegerValue: 4. scanStartIndex := self stackIntegerValue: 5. rcvr := self stackValue: 6. self successful ifFalse: [^ nil]. "check argument type and range and rcvr" ((objectMemory isArray: stops) and: [(objectMemory slotSizeOf: stops) >= 258 and: [(objectMemory isBytes: sourceString) and: [scanStartIndex > 0 and: [scanStopIndex > 0 and: [scanStopIndex <= (objectMemory byteSizeOf: sourceString) and: [(objectMemory isPointers: rcvr) and: [(objectMemory slotSizeOf: rcvr) >= 4]]]]]]]) ifFalse: [^ self primitiveFail]. "Check required rcvr instVars" scanDestX := self fetchInteger: 0 ofObject: rcvr. scanLastIndex := self fetchInteger: 1 ofObject: rcvr. scanXTable := objectMemory fetchPointer: 2 ofObject: rcvr. scanMap := objectMemory fetchPointer: 3 ofObject: rcvr. ((objectMemory isArray: scanXTable) and: [(objectMemory isArray: scanMap) and: [(objectMemory slotSizeOf: scanMap) = 256 + and: [self successful "for the fetchInteger:ofObject:'s above"]]]) ifFalse: - and: [self successful "for the fetchInteger:ofObject:'s abobve"]]]) ifFalse: [^ self primitiveFail]. maxGlyph := (objectMemory slotSizeOf: scanXTable) - 2. "Okay, here we go. We have eliminated nearly all failure conditions, to optimize the inner fetches." scanLastIndex := scanStartIndex. nilOop := objectMemory nilObject. [scanLastIndex <= scanStopIndex] whileTrue: [ "Known to be okay since scanStartIndex > 0 and scanStopIndex <= sourceString size" ascii := objectMemory fetchByte: scanLastIndex - 1 ofObject: sourceString. "Known to be okay since stops size >= 258" (stopReason := objectMemory fetchPointer: ascii ofObject: stops) = nilOop ifFalse: ["Store everything back and get out of here since some stop conditionn needs to be checked" (objectMemory isIntegerValue: scanDestX) ifFalse: [^ self primitiveFail]. self storeInteger: 0 ofObject: rcvr withValue: scanDestX. self storeInteger: 1 ofObject: rcvr withValue: scanLastIndex. + self pop: 7 "args+rcvr" thenPush: stopReason. + ^nil]. - self pop: 7. "args+rcvr" - ^ self push: stopReason]. "Known to be okay since scanMap size = 256" glyphIndex := self fetchInteger: ascii ofObject: scanMap. "fail if the glyphIndex is out of range" (self failed or: [glyphIndex < 0 or: [glyphIndex > maxGlyph]]) ifTrue: [^ self primitiveFail]. sourceX := self fetchInteger: glyphIndex ofObject: scanXTable. sourceX2 := self fetchInteger: glyphIndex + 1 ofObject: scanXTable. "Above may fail if non-integer entries in scanXTable" self failed ifTrue: [^ nil]. nextDestX := scanDestX + sourceX2 - sourceX. nextDestX > scanRightX ifTrue: ["Store everything back and get out of here since we got to the right edge" (objectMemory isIntegerValue: scanDestX) ifFalse: [^ self primitiveFail]. self storeInteger: 0 ofObject: rcvr withValue: scanDestX. self storeInteger: 1 ofObject: rcvr withValue: scanLastIndex. self pop: 7 "args+rcvr" thenPush: (objectMemory fetchPointer: CrossedX - 1 ofObject: stops). ^nil]. scanDestX := nextDestX + kernDelta. scanLastIndex := scanLastIndex + 1]. (objectMemory isIntegerValue: scanDestX) ifFalse: [^ self primitiveFail]. self storeInteger: 0 ofObject: rcvr withValue: scanDestX. self storeInteger: 1 ofObject: rcvr withValue: scanStopIndex. self pop: 7 "args+rcvr" thenPush: (objectMemory fetchPointer: EndOfRun - 1 ofObject: stops)!

1 0

[OpenSmalltalk/opensmalltalk-vm] 219463: CogVM source as per VMMaker.oscog-eem.2254
by GitHub 19 Jul '17

19 Jul '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 21946313adde6fa3b0369616164710137a850941 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/21946313adde6fa3b0… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-07-18 (Tue, 18 Jul 2017) Changed paths: M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/plugins/FloatArrayPlugin/FloatArrayPlugin.c M src/plugins/MiscPrimitivePlugin/MiscPrimitivePlugin.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2254 Spur: Fail one-way become if copyHash is true and target is immutable. FloatArrayPlugin: Fix length & normalize to return at failure points instead of continuing.

1 0

VM Maker: VMMaker.oscog-eem.2254.mcz
by commits＠source.squeak.org 19 Jul '17

19 Jul '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2254.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2254 Author: eem Time: 18 July 2017, 3:02:56.421478 pm UUID: 4f2c2cce-f4a2-469a-93f1-97ed941df0ad Ancestors: VMMaker.oscog-eem.2253 Spur: Fail become if copyHash is true and target is immutable. FloatArrayPlugin: Fix length & normalize to return at failure points instead of continuing. =============== Diff against VMMaker.oscog-eem.2253 =============== Item was changed: ----- Method: FloatArrayPlugin>>primitiveLength (in category 'arithmetic primitives') ----- primitiveLength "Primitive. Compute the length of the argument (sqrt of sum of component squares)." <export: true> | rcvr rcvrPtr length len | <var: #rcvrPtr type: #'float *'> <var: #len type: #double> rcvr := interpreterProxy stackValue: 0. (interpreterProxy isWords: rcvr) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. - [interpreterProxy primitiveFailFor: PrimErrBadReceiver]. length := interpreterProxy stSizeOf: rcvr. rcvrPtr := self cCoerce: (interpreterProxy firstIndexableField: rcvr) to: #'float *'. len := 0.0. + 0 to: length-1 do: + [:i| len := len + ((self cCoerce: (rcvrPtr at: i) to: #double) * (self cCoerce: (rcvrPtr at: i) to: #double)) ]. - 0 to: length-1 do:[:i| - len := len + ((self cCoerce: (rcvrPtr at: i) to: #double) * (self cCoerce: (rcvrPtr at: i) to: #double)). - ]. len > 0.0 ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. - [interpreterProxy primitiveFailFor: PrimErrBadReceiver]. interpreterProxy pop: 1 thenPush: (interpreterProxy floatObjectOf: (self sqrt: len))! Item was changed: ----- Method: FloatArrayPlugin>>primitiveNormalize (in category 'arithmetic primitives') ----- primitiveNormalize "Primitive. Normalize the argument (A FloatArray) in place." <export: true> | rcvr rcvrPtr length len | <var: #rcvrPtr type: #'float *'> <var: #len type: #double> rcvr := interpreterProxy stackValue: 0. (interpreterProxy isWords: rcvr) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. - [interpreterProxy primitiveFailFor: PrimErrBadReceiver]. length := interpreterProxy stSizeOf: rcvr. rcvrPtr := self cCoerce: (interpreterProxy firstIndexableField: rcvr) to: #'float *'. len := 0.0. + 0 to: length - 1 do: + [:i| len := len + ((self cCoerce: (rcvrPtr at: i) to: #double) * (self cCoerce: (rcvrPtr at: i) to: #double)) ]. - 0 to: length-1 do:[:i| - len := len + ((self cCoerce: (rcvrPtr at: i) to: #double) * (self cCoerce: (rcvrPtr at: i) to: #double)). - ]. len > 0.0 ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. - [interpreterProxy primitiveFailFor: PrimErrBadReceiver]. len := self sqrt: len. + 0 to: length - 1 do: + [:i| rcvrPtr at: i put: ((self cCoerce: (rcvrPtr at: i) to: #double) / len) ]. - 0 to: length-1 do:[:i| - rcvrPtr at: i put: ((self cCoerce: (rcvrPtr at: i) to: #double) / len). - ]. "Leave receiver on the stack."! Item was changed: ----- Method: SpurMemoryManager>>containsOnlyValidBecomeObjects:and:twoWay:copyHash: (in category 'become implementation') ----- containsOnlyValidBecomeObjects: array1 and: array2 twoWay: isTwoWay copyHash: copyHash "Answer 0 if neither array contains an object inappropriate for the become operation. Otherwise answer an informative error code for the first offending object found: Can't become: immediates => PrimErrInappropriate Shouldn't become pinned objects => PrimErrObjectIsPinned. Shouldn't become immutable objects => PrimErrNoModification. Can't copy hash into immediates => PrimErrInappropriate. Two-way become may require memory to create copies => PrimErrNoMemory. As a side-effect unforward any forwarders in the two arrays if answering 0." <inline: true> | fieldOffset effectsFlags oop1 oop2 size | fieldOffset := self lastPointerOf: array1. effectsFlags := size := 0. "array1 is known to be the same size as array2" [fieldOffset >= self baseHeaderSize] whileTrue: [oop1 := self longAt: array1 + fieldOffset. (self isOopForwarded: oop1) ifTrue: [oop1 := self followForwarded: oop1. self longAt: array1 + fieldOffset put: oop1]. self ifOopInvalidForBecome: oop1 errorCodeInto: [:errCode| ^errCode]. effectsFlags := effectsFlags bitOr: (self becomeEffectFlagsFor: oop1). oop2 := self longAt: array2 + fieldOffset. (self isOopForwarded: oop2) ifTrue: [oop2 := self followForwarded: oop2. self longAt: array2 + fieldOffset put: oop2]. isTwoWay ifTrue: [self ifOopInvalidForBecome: oop2 errorCodeInto: [:errCode| ^errCode]. size := size + (self bytesInObject: oop1) + (self bytesInObject: oop2). effectsFlags := effectsFlags bitOr: (self becomeEffectFlagsFor: oop2)] ifFalse: + [(copyHash and: [(self isImmediate: oop2) or: [self isImmutable: oop2]]) ifTrue: - [(copyHash and: [self isImmediate: oop2]) ifTrue: [^PrimErrInappropriate]]. fieldOffset := fieldOffset - self bytesPerOop]. size >= (totalFreeOldSpace + (scavengeThreshold - freeStart)) ifTrue: [^PrimErrNoMemory]. "only set flags after checking all args." becomeEffectsFlags := effectsFlags. ^0!

1 0

[OpenSmalltalk/opensmalltalk-vm] 300cbe: vm-sound-pulse: Change return value from int to vo...
by GitHub 18 Jul '17

18 Jul '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 300cbeb99097ded496ad6501f578b560e81d6833 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/300cbeb99097ded496… Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: 2017-07-18 (Tue, 18 Jul 2017) Changed paths: M platforms/unix/vm-sound-pulse/sqUnixSoundPulseAudio.c Log Message: ----------- vm-sound-pulse: Change return value from int to void These routines didn't return anything and callers didn't seem to check the return value. Change to void to fix these warnings: E: no-return-in-nonvoid-function platforms/unix/vm-sound-pulse/sqUnixSoundPulseAudio.c:455, 519, 528, 600, 713, 821, 814 Commit: a4d920cfbce4dc960dccb89bf88b60175a303e4f https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4d920cfbce4dc960d… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-07-18 (Tue, 18 Jul 2017) Changed paths: M platforms/unix/vm-sound-pulse/sqUnixSoundPulseAudio.c Log Message: ----------- Merge pull request #145 from zecke/fix-no-return vm-sound-pulse: Change return value from int to void Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/e0b6d370c7c4...a4…

1 0

Home work by post build script of OpenSUSE
by Holger Freyther 18 Jul '17

18 Jul '17

Hi, I started to write a rpm spec file to package the PharoVM on CentOS/RHEL/OpenSUSE and there is a list of warnings to resolve first before the packages are being published. I am pasting the list below. Most is in pure C code, some seems to be in the Smalltalk part as well. any volunteers to fix it or handle PRs in a timely manner? holger [ 90s] I: Program is using implicit definitions of functions getting [ 90s] pointers or implemented by macros. These functions need to use their [ 90s] correct prototypes to allow correct argument passing on e.g. x86_64 . [ 90s] - Implicit memory/string functions need #include <string.h>. [ 90s] - Implicit *printf functions need #include <stdio.h>. [ 90s] - Implicit *printf functions need #include <stdio.h>. [ 90s] - Implicit *read* functions need #include <unistd.h>. [ 90s] - Implicit *recv* functions need #include <sys/socket.h>. [ 90s] W: pharo6-ui-common implicit-pointer-decl /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/vm/sqVirtualMachine.c:593 [ 90s] W: pharo6-ui-common implicit-pointer-decl /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/plugins/SqueakSSL/sqUnixOpenSSL.c:173 [ 90s] W: pharo6-ui-common implicit-pointer-decl /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm/sqUnixMain.c:1569, 1602 [ 90s] [ 90s] I: A function uses a 'return;' statement, but has actually a value [ 90s] to return, like an integer ('return 42;') or similar. [ 90s] W: pharo6-ui-common voidreturn /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-sound-ALSA/sqUnixSoundALSA.c:673 [ 90s] E: pharo6-ui-common 64bit-portability-issue /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/plugins/SoundPlugin/sqUnixSound.c:194, 195, 196, 197 [ 90s] E: pharo6-ui-common 64bit-portability-issue /home/abuild/rpmbuild/BUILD/pharo6-vm-core/spursrc/vm/cogitIA32.c:8669, 18919, 21697, 28355 [ 90s] E: pharo6-ui-common 64bit-portability-issue /home/abuild/rpmbuild/BUILD/pharo6-vm-core/spursrc/vm/gcc3x-cointerp.c:32907 [ 90s] E: pharo6-ui-common 64bit-portability-issue /home/abuild/rpmbuild/BUILD/pharo6-vm-core/src/plugins/IA32ABI/IA32ABI.c:786, 833, 880, 927 [ 90s] E: pharo6-ui-common 64bit-portability-issue /home/abuild/rpmbuild/BUILD/pharo6-vm-core/src/plugins/SerialPlugin/SerialPlugin.c:237 [ 90s] E: pharo6-ui-common 64bit-portability-issue /home/abuild/rpmbuild/BUILD/pharo6-vm-core/src/plugins/SqueakFFIPrims/IA32FFIPlugin.c:545, 548, 554, 563, 568, 2825 [ 90s] [ 90s] I: Program returns random data in a function [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/B3DAcceleratorPlugin/sqOpenGLRenderer.c:118 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/audio/layer1.c:36 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/audio/layer3.c:1078 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/libmpeg3.c:68, 483 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3atrack.c:67 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3demux.c:1385 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3title.c:82, 98 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3vtrack.c:65 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/headers.c:118, 141, 185, 210, 233, 295, 314, 326, 377 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/mpeg3video.c:321 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/slice.h:152, 166, 87, 137, 114, 101 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-display-X11/sqUnixX11.c:6926 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-display-X11/sqUnixXdnd.c:803 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-sound-pulse/sqUnixSoundPulseAudio.c:455, 519, 528, 600, 713, 821, 814 [ 90s] [ 90s] I: Program returns random data in a function [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/B3DAcceleratorPlugin/sqOpenGLRenderer.c:118 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/audio/layer1.c:36 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/audio/layer3.c:1078 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/libmpeg3.c:68, 483 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3atrack.c:67 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3demux.c:1385 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3title.c:82, 98 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3vtrack.c:65 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/headers.c:118, 141, 185, 210, 233, 295, 314, 326, 377 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/mpeg3video.c:321 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/slice.h:152, 166, 87, 137, 114, 101 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-display-X11/sqUnixX11.c:6926 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-display-X11/sqUnixXdnd.c:803 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-sound-pulse/sqUnixSoundPulseAudio.c:455, 519, 528, 600, 713, 821, 814

1 0

[OpenSmalltalk/opensmalltalk-vm] e0b6d3: Add hostname checking short cut
by GitHub 17 Jul '17

17 Jul '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: e0b6d370c7c46a3e157986a933dbf17e6a0b744a https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/e0b6d370c7c46a3e15… Author: Tobias Pape <tobias(a)netshed.de> Date: 2017-07-17 (Mon, 17 Jul 2017) Changed paths: M platforms/iOS/plugins/SqueakSSL/sqMacSSL.c Log Message: ----------- Add hostname checking short cut

1 0

[OpenSmalltalk/opensmalltalk-vm] c2ff36: Fix a slip in the unix SqueakSSL plugin.
by GitHub 17 Jul '17

17 Jul '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: c2ff36014fc8d49694b58d86f79e8924e5540084 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c2ff36014fc8d49694… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-07-17 (Mon, 17 Jul 2017) Changed paths: M platforms/unix/plugins/SqueakSSL/sqUnixOpenSSL.c Log Message: ----------- Fix a slip in the unix SqueakSSL plugin.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev July 2017