Vm-dev July 2017

vm-dev@lists.squeakfoundation.org

18 participants
54 discussions

VM Maker: CogTools-sk.82.mcz
by commits＠source.squeak.org 11 Jul '17

11 Jul '17

Sophie Kaleba uploaded a new version of CogTools to project VM Maker: http://source.squeak.org/VMMaker/CogTools-sk.82.mcz ==================== Summary ==================== Name: CogTools-sk.82 Author: sk Time: 11 July 2017, 4:16:16.801546 pm UUID: 48900e89-c6c5-4b29-a586-3d7322342e57 Ancestors: CogTools-sk.81 * change the name of the class variable VMFileSystem to CompatibilityClass * remove the tempDirectory methods inherited from VMProfilerSymbolsManager =============== Diff against CogTools-sk.81 =============== Item was changed: ----- Method: PharoVMProfiler>>initialize (in category 'initialization') ----- initialize + self initializeMost. - super initializeMost. self withDetails: false. CompatibilityClass := PharoVMMethodConverter new. expressionTextMorph := PluggableTextMorph new. self initializeSymbols.! Item was changed: ----- Method: SqueakVMProfiler>>initialize (in category 'initialization') ----- initialize + self initializeMost. - super initializeMost. self withDetails: false. CompatibilityClass := SqueakVMMethodConverter new. expressionTextMorph := PluggableTextMorph new. super initializeSymbols. self toggleShowing: #module.! Item was changed: ----- Method: VMProfilerLinuxSymbolsManager class>>shutDown: (in category 'shut down') ----- shutDown: quitting (quitting and: [#('Mac OS' 'unix') includes: Smalltalk platformName]) ifTrue: [| tempDir | (tempDir := self tempDirectory) notNil ifTrue: [tempDir exists ifTrue: + [CompatibilityClass deleteContentsOf: tempDir]]]! - [VMFileSystem deleteContentsOf: tempDir]]]! Item was removed: - ----- Method: VMProfilerLinuxSymbolsManager class>>tempDirectory (in category 'accessing') ----- - tempDirectory - - ^ VMFileSystem ifNotNil: [VMFileSystem nameFordirPath:'/tmp/vmsyms' plus:OSProcess thisOSProcess pid printString] - ! Item was changed: ----- Method: VMProfilerLinuxSymbolsManager>>initializeMost (in category 'initialize-release') ----- initializeMost | shortNames | initialized := false. maxAddressMask := (2 raisedToInteger: 32) - 1. modulesByName := Dictionary new. symbolsByModule := Dictionary new. shortNames := Set new. tempDir := self class tempDirectory. + CompatibilityClass ensureExistenceOfDirectory: tempDir. - VMFileSystem ensureExistenceOfDirectory: tempDir. modules := self primitiveExecutableModules. modules := (1 to: modules size by: 2) collect: [:i| | fileName shortName counter longName | fileName := modules at: i. (fileName beginsWith: '/dgagent') ifTrue: [fileName := fileName allButFirst: 8]. + shortName := CompatibilityClass nameOfFile: fileName in: tempDir. - shortName := VMFileSystem nameOfFile: fileName in: tempDir. counter := 0. [shortNames includes: shortName] whileTrue: [counter := counter + 1. + shortName := (CompatibilityClass nameOfFile: fileName in: tempDir), counter printString]. - shortName := (VMFileSystem nameOfFile: fileName in: tempDir), counter printString]. shortNames add: shortName. longName := (modules at: i + 1) ifNil: [fileName] ifNotNil: [:symlink| symlink first = $/ ifTrue: [symlink] + ifFalse: [( CompatibilityClass parentPathOfFile: fileName ), '/', symlink]]. - ifFalse: [( VMFileSystem parentPathOfFile: fileName ), '/', symlink]]. "some files are off limits (e.g. /dgagent/lib/preload.so)" + (CompatibilityClass exists: longName) ifTrue: - (VMFileSystem exists: longName) ifTrue: [(modulesByName at: longName put: VMPExecutableModuleSymbol new) name: longName; shortName: shortName]]. "The primitive always answers the VM info in the first entry." vmModule := modules first. "now filter out the files we can't read..." modules := modules select: [:m| m notNil and: [modulesByName includesKey: m name]]! Item was changed: ----- Method: VMProfilerLinuxSymbolsManager>>parseSymbolsFor: (in category 'parsing') ----- parseSymbolsFor: module | proc symtab symStream | + (CompatibilityClass exists: tempDir fullName, '/', module shortName) ifFalse: - (VMFileSystem exists: tempDir fullName, '/', module shortName) ifFalse: [proc := OSProcess thisOSProcess command: 'objdump -j .text -tT "', module name, '" | fgrep .text | sort >"', tempDir fullName, '/', module shortName, '"']. symStream := (Array new: 1000) writeStream. symStream nextPut: module. proc ifNotNil: [[proc isComplete] whileFalse: [(Delay forMilliseconds: 25) wait]]. symtab := [StandardFileStream readOnlyFileNamed: (tempDir fullName,'/',module shortName) ] on: Error do: [:ex| "Handle flaky OSProcess stuff by reporting error and failing to parse" Transcript print: ex; flush. ^nil]. [| prev | prev := self parseSymbolsFrom: symtab to: symStream. symbolsByModule at: module put: (self relocateSymbols: symStream contents allButFirst inModule: module). (prev notNil and: [prev limit isNil]) ifTrue: [prev limit: module limit]] ensure: [symtab close]! Item was changed: ----- Method: VMProfilerMacSymbolsManager class>>shutDown: (in category 'shut down') ----- shutDown: quitting (quitting and: [#('Mac OS' 'unix') includes: Smalltalk platformName]) ifTrue: [| tempDir | (tempDir := self tempDirectory) notNil ifTrue: [tempDir exists ifTrue: + [CompatibilityClass deleteContentsOf: tempDir]]]! - [VMFileSystem deleteContentsOf: tempDir]]]! Item was removed: - ----- Method: VMProfilerMacSymbolsManager class>>tempDirectory (in category 'accessing') ----- - tempDirectory - - ^ VMFileSystem ifNotNil: [VMFileSystem nameFordirPath:'private/tmp/vmsyms' plus:OSProcess thisOSProcess pid printString] - ! Item was changed: ----- Method: VMProfilerMacSymbolsManager>>computeLimitFor:initialShift: (in category 'parsing') ----- computeLimitFor: module initialShift: initialShift "If we can't find a non-text symbol following the last text symbol, compute the ernd of text using the size command." | sizeFileName proc text size | sizeFileName := module shortName, '.size'. + (CompatibilityClass exists: tempDir fullName, '/', sizeFileName) ifFalse: - (VMFileSystem exists: tempDir fullName, '/', sizeFileName) ifFalse: ["N.B. Don't use the -f option (which meant flat symbols) as in El Capitan it is misinterpreted to mean -format." proc := OSProcess thisOSProcess command: 'cd ', tempDir fullName, ';size -arch ', self archName, " -f" ' "', module name, '" >"', sizeFileName, '"'. [proc isComplete] whileFalse: [(Delay forMilliseconds: 25) wait]]. text := (StandardFileStream readOnlyFileNamed: (tempDir fullName, '/', sizeFileName)) contentsOfEntireFile. size := Integer readFrom: (text copyAfter: Character lf) readStream. ^size + initialShift! Item was changed: ----- Method: VMProfilerMacSymbolsManager>>initializeMost (in category 'initialize-release') ----- initializeMost | shortNames | initialized := false. maxAddressMask := (2 raisedToInteger: Smalltalk wordSize * 8) - 1. modulesByName := Dictionary new. symbolsByModule := Dictionary new. shortNames := Set new. modules := self primitiveExecutableModulesAndOffsets. tempDir := self class tempDirectory. + CompatibilityClass ensureExistenceOfDirectory: tempDir. - VMFileSystem ensureExistenceOfDirectory: tempDir. modules := (1 to: modules size by: 4) collect: [:i| | shortName counter | + shortName := CompatibilityClass nameOfFile: (modules at: i) in: tempDir. - shortName := VMFileSystem nameOfFile: (modules at: i) in: tempDir. counter := 0. [shortNames includes: shortName] whileTrue: [counter := counter + 1. + shortName := (CompatibilityClass nameOfFile: (modules at: i) in: tempDir), counter printString]. - shortName := (VMFileSystem nameOfFile: (modules at: i) in: tempDir), counter printString]. shortNames add: shortName. (modulesByName at: (modules at: i) put: VMPExecutableModuleSymbol new) name: (modules at: i); shortName: shortName; vmshift: (modules at: i + 1); address: (maxAddressMask bitAnd: (modules at: i + 2) + (modules at: i + 1)); size: (modules at: i + 3)]. modules := self filter: modules. "The primitive always answers the VM info in the first entry." vmModule := modules first. modules := modules asSortedCollection: [:m1 :m2| m1 address <= m2 address]! Item was changed: ----- Method: VMProfilerMacSymbolsManager>>parseSymbolsFor: (in category 'parsing') ----- parseSymbolsFor: module | proc symtab symStream | + (CompatibilityClass exists: tempDir fullName, '/', module shortName) ifFalse: - (VMFileSystem exists: tempDir fullName, '/', module shortName) ifFalse: ["N.B. Don't use the -f option (which meant flat symbols) as in El Capitan it is misinterpreted to mean -format." proc := OSProcess thisOSProcess command: 'cd ', tempDir fullName, ';nm -n -arch ', self archName, " -f" ' "', module name, '" | grep -v " [aAU] " >"', module shortName, '"']. symStream := (Array new: 1000) writeStream. symStream nextPut: module. proc ifNotNil: [[proc isComplete] whileFalse: [(Delay forMilliseconds: 25) wait]]. symtab := [StandardFileStream readOnlyFileNamed: (tempDir fullName, '/', module shortName)] on: Error do: [:ex| "Handle flaky OSProcess stuff by reporting error and failing to parse" Transcript print: ex; flush. ^nil]. "Have caller eliminate modules with no text." symtab size = 0 ifTrue: [^nil]. module shortName = 'HIToolbox' ifTrue: [self halt]. [| prev | prev := self parseSymbolsFrom: symtab to: symStream. "CoreAUC has a huge chunk of data at the end of its text segment that causes the profiler to spend ages counting zeros. Hack fix by setting the end of the last symbol in the text segment to a little less than 1Mb." "00000000000f1922 retq" "Mavericks 13.4" "00000000000f3b21 retq" "Yosemite 14.5" module shortName = 'CoreAUC' ifTrue: [prev limit: 16rf8000]. symbolsByModule at: module put: (self relocateSymbols: symStream contents allButFirst inModule: module). (prev notNil and: [prev limit isNil]) ifTrue: [prev limit: module limit]] ensure: [symtab close]! Item was changed: Object subclass: #VMProfilerSymbolsManager instanceVariableNames: 'modules symbolsByModule modulesByName vmModule cogModule' + classVariableNames: 'CompatibilityClass' - classVariableNames: 'VMFileSystem' poolDictionaries: '' category: 'CogTools-VMProfiler'! Item was changed: ----- Method: VMProfilerSymbolsManager class>>tempDirectory (in category 'as yet unclassified') ----- tempDirectory + ^ CompatibilityClass ifNotNil: [CompatibilityClass nameFordirPath:'/tmp/vmsyms' plus:OSProcess thisOSProcess pid printString] - ^ VMFileSystem ifNotNil: [VMFileSystem nameFordirPath:'/tmp/vmsyms' plus:OSProcess thisOSProcess pid printString] ! Item was changed: ----- Method: VMProfilerSymbolsManager class>>using: (in category 'as yet unclassified') ----- + using: aCompatibilityClass - using: aFileSystem + CompatibilityClass := aCompatibilityClass. - VMFileSystem := aFileSystem. ^ self new !

1 0

[OpenSmalltalk/opensmalltalk-vm] 7bf908: Undo a mistaken commit setting fIsConsole on Win32...
by GitHub 10 Jul '17

10 Jul '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 7bf9088f3d906f81ae2c7d2ac7d8e1d39ef7e5ae https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7bf9088f3d906f81ae… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-07-10 (Mon, 10 Jul 2017) Changed paths: M build.macos64x64/makeall M build.macos64x64/makeallinstall M build.win32x86/common/Makefile M build.win64x64/common/Makefile M build.win64x64/common/Makefile.tools M platforms/win32/vm/sqWin32Main.c Log Message: ----------- Undo a mistaken commit setting fIsConsole on Win32/64. Undo a mistaken commit adding -mno-cygwin to the Win64 build. Remove v3 from the makeall* script on 64-bit Mac OS X. Fix a typo.

1 0

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] c6ec24: Merge branch 'Cog' of http://github.com/OpenSmallt...
by Jakob Reschke 10 Jul '17

10 Jul '17

...which explains the strange message of merging into Cog on a branch that is not really the Cog branch. Apart from that, the reason for "merging Cog into Cog" is that the quoted branch name is the remote branch name, while the branch name at the end of the sentence is the local branch name. Such merge messages are generated by git pull. It looks more useful when pulling from a remote branch that has a different name, either because it actually is a different branch of development or because the branch simply has a different name at the remote. 2017-07-10 19:15 GMT+02:00 Fabio Niephaus <lists(a)fniephaus.com>: >

1 0

[OpenSmalltalk/opensmalltalk-vm] c6ec24: Merge branch 'Cog' of http://github.com/OpenSmallt...
by GitHub 10 Jul '17

10 Jul '17

Branch: refs/heads/fniephaus/smalltalk-ci/no-exit Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: c6ec24cec26e148a59682e99c3a57b3837c2bbeb https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c6ec24cec26e148a59… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-07-10 (Mon, 10 Jul 2017) Changed paths: M .bintray.json M .travis_deploy.sh M image/buildsistareaderimage.sh M image/buildspurtrunk64image.sh M image/buildspurtrunkreader64image.sh M image/buildspurtrunkreaderimage.sh M image/buildspurtrunkvmmakerimage.sh M image/getGoodCogVM.sh M image/getGoodSpurNsvm.sh M image/getGoodSpurVM.sh M image/resizesqueakwindow.sh M image/updatespurimage.sh M image/updatevmmakerimage.sh M image/uploadspurimage.sh M platforms/Cross/vm/sqSCCSVersion.h M platforms/unix/vm/sqUnixHeartbeat.c Log Message: ----------- Merge branch 'Cog' of http://github.com/OpenSmalltalk/opensmalltalk-vm into Cog [no exit version]

3 2

Re: [Vm-dev] Vm-dev Digest, Vol 133, Issue 13
by Max Leske 10 Jul '17

10 Jul '17

Hi Luke, > On 10 Jul 2017, at 09:38, vm-dev-request(a)lists.squeakfoundation.org wrote: > > Hi Max, > > On 18 May 2017 at 13:32, Max Leske <maxleske(a)gmail.com <mailto:maxleske@gmail.com>> wrote: > >> >> We managed to figure out that OSProcess works when we use gcc <= 4.8 on >> Debian. We are happy to use 4.8 for now, so we're good. It would of course >> be super cool if we could use the series 6 gcc as that will soon ship with >> Debian 9 (stretch) but it's probably not trivial to just move to a new >> compiler version (as seems evident from the fact that a minor version >> change can mess up compilation). >> > > Thanks for tracking this problem down and sharing the details. I came upon > exactly the same problem with the Nix package and was able to work-around > that by also downgrading to gcc 4.8. I am sure it would have taken a long > time to work this out without the benefit of your experience. Sweet! Nice to know that others benefit from my work (or woes) :) > > Relatedly: Is there a suitable automated test that we can use to check that > our VMs are basically okay? I am pushing the switch to gcc 4.8 to resolve > this problem but I don't know whether this is causing other regressions or > what other obvious problems I have missed. I'd love a bit of test coverage > for the builds. There are tests that are being run for every commit to https://github.com/opensmalltalk/opensmalltalk-vm <https://github.com/opensmalltalk/opensmalltalk-vm>. Unfortunately, they don't explicitly include VM plugin related things. Also, the build is pretty much fixed to a specific GCC version by the build setup (depends on what Travis CI offers, for instance). I fully agree, that it would be very helpful to have a more elaborate test suite that would take into account things like architecture and available libraries. I think, that could be a nice project for an intern, or a bachelor's thesis (cc'ing pharo-dev and squeak-dev). As long as we don't have that, I'd use the GCC version from the build. You can get to that by browsing the latest build on travis and searching the log for "gcc" (currently version 4.6.3 on Ubuntu Precise). Cheers, Max

1 0

[OpenSmalltalk/opensmalltalk-vm]
by GitHub 10 Jul '17

10 Jul '17

Branch: refs/heads/fniephaus/no-exit Home: https://github.com/OpenSmalltalk/opensmalltalk-vm

1 0

[OpenSmalltalk/opensmalltalk-vm] 453d3d: Merge branch 'Cog' of http://github.com/OpenSmallt...
by GitHub 10 Jul '17

10 Jul '17

Branch: refs/heads/fniephaus/smalltalk-ci/no-exit Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 453d3dd493cba4e485cc23681e9ac0bd9c066355 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/453d3dd493cba4e485… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-07-10 (Mon, 10 Jul 2017) Changed paths: M .bintray.json M .travis_deploy.sh M image/buildsistareaderimage.sh M image/buildspurtrunk64image.sh M image/buildspurtrunkreader64image.sh M image/buildspurtrunkreaderimage.sh M image/buildspurtrunkvmmakerimage.sh M image/getGoodCogVM.sh M image/getGoodSpurNsvm.sh M image/getGoodSpurVM.sh M image/resizesqueakwindow.sh M image/updatespurimage.sh M image/updatevmmakerimage.sh M image/uploadspurimage.sh M platforms/unix/vm/sqUnixHeartbeat.c Log Message: ----------- Merge branch 'Cog' of http://github.com/OpenSmalltalk/opensmalltalk-vm into Cog [no exit version]

1 0

[OpenSmalltalk/opensmalltalk-vm] 0cf2d9: Merge branch 'Cog' of http://github.com/OpenSmallt...
by GitHub 10 Jul '17

10 Jul '17

Branch: refs/heads/fniephaus/no-exit Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 0cf2d9090d8a69e19045893d0f730c14e05086ba https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0cf2d9090d8a69e190… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-07-09 (Sun, 09 Jul 2017) Changed paths: M .bintray.json M .travis_deploy.sh M image/buildsistareaderimage.sh M image/buildspurtrunk64image.sh M image/buildspurtrunkreader64image.sh M image/buildspurtrunkreaderimage.sh M image/buildspurtrunkvmmakerimage.sh M image/getGoodCogVM.sh M image/getGoodSpurNsvm.sh M image/getGoodSpurVM.sh M image/resizesqueakwindow.sh M image/updatespurimage.sh M image/updatevmmakerimage.sh M image/uploadspurimage.sh M platforms/unix/vm/sqUnixHeartbeat.c Log Message: ----------- Merge branch 'Cog' of http://github.com/OpenSmalltalk/opensmalltalk-vm into Cog [no exit version]

1 0

[OpenSmalltalk/opensmalltalk-vm] 8053e9: Merge branch 'Cog' of http://github.com/OpenSmallt...
by GitHub 10 Jul '17

10 Jul '17

Branch: refs/heads/fniephaus/no-exit Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 8053e9f61e8934a23910b2a7b51b167718fc936c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8053e9f61e8934a239… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-07-09 (Sun, 09 Jul 2017) Changed paths: M .bintray.json M .travis_deploy.sh M image/buildsistareaderimage.sh M image/buildspurtrunk64image.sh M image/buildspurtrunkreader64image.sh M image/buildspurtrunkreaderimage.sh M image/buildspurtrunkvmmakerimage.sh M image/getGoodCogVM.sh M image/getGoodSpurNsvm.sh M image/getGoodSpurVM.sh M image/resizesqueakwindow.sh M image/updatespurimage.sh M image/updatevmmakerimage.sh M image/uploadspurimage.sh M platforms/unix/vm/sqUnixHeartbeat.c Log Message: ----------- Merge branch 'Cog' of http://github.com/OpenSmalltalk/opensmalltalk-vm into Cog [no exit version]

1 0

[OpenSmalltalk/opensmalltalk-vm] 570ecb: Merge branch 'Cog' of http://github.com/OpenSmallt...
by GitHub 10 Jul '17

10 Jul '17

Branch: refs/heads/fniephaus/no-exit Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 570ecbd8dd0b02038c6256d2903335280fda0346 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/570ecbd8dd0b02038c… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2017-07-09 (Sun, 09 Jul 2017) Changed paths: M image/buildsistareaderimage.sh M image/buildspurtrunk64image.sh M image/buildspurtrunkreader64image.sh M image/buildspurtrunkreaderimage.sh M image/buildspurtrunkvmmakerimage.sh M image/getGoodCogVM.sh M image/getGoodSpurNsvm.sh M image/getGoodSpurVM.sh M image/resizesqueakwindow.sh M image/updatespurimage.sh M image/updatevmmakerimage.sh M image/uploadspurimage.sh M platforms/unix/vm/sqUnixHeartbeat.c Log Message: ----------- Merge branch 'Cog' of http://github.com/OpenSmalltalk/opensmalltalk-vm into Cog [no exit version]

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev July 2017