Many months ago had deja vu about 4 found elements where as far as my
beleif goes are names od four created colour superclasses bugged two
misplaced two trown out..
V pet., 9. okt. 2020 08:20 je oseba <
vm-dev-request(a)lists.squeakfoundation.org> napisala:
> Send Vm-dev mailing list submissions to
> vm-dev(a)lists.squeakfoundation.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://lists.squeakfoundation.org/mailman/listinfo/vm-dev
> or, via email, send a message with subject or body 'help' to
> vm-dev-request(a)lists.squeakfoundation.org
>
> You can reach the person managing the list at
> vm-dev-owner(a)lists.squeakfoundation.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Vm-dev digest..."
>
>
> Today's Topics:
>
> 1. [OpenSmalltalk/opensmalltalk-vm] 7deac0: Unix(macOS)
> SocketPlugin: (Eliot Miranda)
> 2. Still Failing: OpenSmalltalk/opensmalltalk-vm#2229 (Cog -
> 7deac02) (Travis CI)
> 3. Build failed: opensmalltalk-vm 1.0.2231 (AppVeyor)
> 4. Re: [OpenSmalltalk/opensmalltalk-vm] Unix(macOS)
> SocketPlugin: (7deac02) (Tobias Pape)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Thu, 08 Oct 2020 21:27:11 -0700
> From: Eliot Miranda <noreply(a)github.com>
> To: vm-dev(a)lists.squeakfoundation.org
> Subject: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 7deac0: Unix(macOS)
> SocketPlugin:
> Message-ID:
> <OpenSmalltalk/opensmalltalk-vm/push/refs/heads/Cog/
> 3f129f-7deac0(a)github.com>
>
> Content-Type: text/plain; charset=UTF-8
>
> Branch: refs/heads/Cog
> Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
> Commit: 7deac028aeeb769c8782242fc23bebdfaaa58e3d
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7deac028aeeb769c87…
> Author: Eliot Miranda <eliot.miranda(a)gmail.com>
> Date: 2020-10-08 (Thu, 08 Oct 2020)
>
> Changed paths:
> M platforms/unix/plugins/SocketPlugin/sqUnixSocket.c
> M platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c
>
> Log Message:
> -----------
> Unix(macOS) SocketPlugin:
> Fix sendDone/primtiveSocketSendDone/sqSocketSendDone on macOS. The select
> in
> socketWritable does not answer true for writable sockets, presumably
> because
> the select in aioPoll already has done. So have dataHandler (which is
> called
> from aioPoll when the socket *is* writable) set a flag in
> privateSocketStruct
> notifiedOfWritability and use this to avoid the wrongly unsuccessful call
> of
> select in sqSocketSendDone. Clear notifiedOfWritability before any and all
> send/
> write system calls.
> Have sqWin32NewNet.c process the select result in its socketWritable in
> exactly
> the same way as sqUnixSocket.c's.
>
> I WELCOME ANY REVIEW OF THIS COMMIT!! Levente, Tobias, you might take a
> close
> look at this one.
>
>
>
>
> ------------------------------
>
> Message: 2
> Date: Fri, 09 Oct 2020 04:38:05 +0000
> From: Travis CI <builds(a)travis-ci.org>
> To: vm-dev(a)lists.squeakfoundation.org
> Subject: [Vm-dev] Still Failing: OpenSmalltalk/opensmalltalk-vm#2229
> (Cog - 7deac02)
> Message-ID:
> <5f7fe92d40c0e_13f999d81e89c465e7(a)travis-tasks-686c69676-jzpgl.mail
> >
> Content-Type: text/plain; charset="utf-8"
>
> Build Update for OpenSmalltalk/opensmalltalk-vm
> -------------------------------------
>
> Build: #2229
> Status: Still Failing
>
> Duration: 10 mins and 25 secs
> Commit: 7deac02 (Cog)
> Author: Eliot Miranda
> Message: Unix(macOS) SocketPlugin:
> Fix sendDone/primtiveSocketSendDone/sqSocketSendDone on macOS. The select
> in
> socketWritable does not answer true for writable sockets, presumably
> because
> the select in aioPoll already has done. So have dataHandler (which is
> called
> from aioPoll when the socket *is* writable) set a flag in
> privateSocketStruct
> notifiedOfWritability and use this to avoid the wrongly unsuccessful call
> of
> select in sqSocketSendDone. Clear notifiedOfWritability before any and all
> send/
> write system calls.
> Have sqWin32NewNet.c process the select result in its socketWritable in
> exactly
> the same way as sqUnixSocket.c's.
>
> I WELCOME ANY REVIEW OF THIS COMMIT!! Levente, Tobias, you might take a
> close
> look at this one.
>
> View the changeset:
> https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/3f129f28147b...7d…
>
> View the full build log and details:
> https://travis-ci.org/github/OpenSmalltalk/opensmalltalk-vm/builds/73417998…
>
>
> --
>
> You can unsubscribe from build emails from the
> OpenSmalltalk/opensmalltalk-vm repository going to
> https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…
> .
> Or unsubscribe from *all* email updating your settings at
> https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…
> .
> Or configure specific recipients for build notifications in your
> .travis.yml file. See https://docs.travis-ci.com/user/notifications.
>
>
Manpage says otherwise:
> If the time limit expires, `select()` returns 0
And some tutorial says:
>On success, `select()` and `pselect()` return the number of file descriptors contained in the three returned descriptor sets (that is, the total number of bits that are set in `readfds`, `writefds`, `exceptfds`) which *may be zero if the timeout expires before anything interesting happens*.
I don't see how `select` should ever return `0` for a writable `fd`
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7deac028aeeb769c87…
Build Update for OpenSmalltalk/opensmalltalk-vm
-------------------------------------
Build: #2229
Status: Still Failing
Duration: 10 mins and 25 secs
Commit: 7deac02 (Cog)
Author: Eliot Miranda
Message: Unix(macOS) SocketPlugin:
Fix sendDone/primtiveSocketSendDone/sqSocketSendDone on macOS. The select in
socketWritable does not answer true for writable sockets, presumably because
the select in aioPoll already has done. So have dataHandler (which is called
from aioPoll when the socket *is* writable) set a flag in privateSocketStruct
notifiedOfWritability and use this to avoid the wrongly unsuccessful call of
select in sqSocketSendDone. Clear notifiedOfWritability before any and all send/
write system calls.
Have sqWin32NewNet.c process the select result in its socketWritable in exactly
the same way as sqUnixSocket.c's.
I WELCOME ANY REVIEW OF THIS COMMIT!! Levente, Tobias, you might take a close
look at this one.
View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/3f129f28147b...7d…
View the full build log and details: https://travis-ci.org/github/OpenSmalltalk/opensmalltalk-vm/builds/73417998…
--
You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut….
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati….
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: 7deac028aeeb769c8782242fc23bebdfaaa58e3d
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7deac028aeeb769c87…
Author: Eliot Miranda <eliot.miranda(a)gmail.com>
Date: 2020-10-08 (Thu, 08 Oct 2020)
Changed paths:
M platforms/unix/plugins/SocketPlugin/sqUnixSocket.c
M platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c
Log Message:
-----------
Unix(macOS) SocketPlugin:
Fix sendDone/primtiveSocketSendDone/sqSocketSendDone on macOS. The select in
socketWritable does not answer true for writable sockets, presumably because
the select in aioPoll already has done. So have dataHandler (which is called
from aioPoll when the socket *is* writable) set a flag in privateSocketStruct
notifiedOfWritability and use this to avoid the wrongly unsuccessful call of
select in sqSocketSendDone. Clear notifiedOfWritability before any and all send/
write system calls.
Have sqWin32NewNet.c process the select result in its socketWritable in exactly
the same way as sqUnixSocket.c's.
I WELCOME ANY REVIEW OF THIS COMMIT!! Levente, Tobias, you might take a close
look at this one.
Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: 3f129f28147b828a83ca03ac32b384ce4d0acd1e
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3f129f28147b828a83…
Author: Eliot Miranda <eliot.miranda(a)gmail.com>
Date: 2020-10-08 (Thu, 08 Oct 2020)
Changed paths:
M platforms/unix/plugins/SocketPlugin/sqUnixSocket.c
M platforms/unix/vm/aio.c
M platforms/unix/vm/sqaio.h
M platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c
Log Message:
-----------
Improve the socket logging even more on unix. Avoid copying option names in
setsockopt/getsockopt operations. Tab sqWin32NewNet.c to 4 spaces per tab.