Vm-dev April 2020

vm-dev@lists.squeakfoundation.org

28 participants
227 discussions

Re: [Vm-dev] [squeak-dev] Squeak5.3 linux ARMv6 segfaults on startup
by Eliot Miranda 27 Apr '20

27 Apr '20

Hi Nicolas, On Sun, Apr 26, 2020 at 6:27 PM Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > > > On Apr 26, 2020, at 1:50 PM, Nicolas Cellier < > nicolas.cellier.aka.nice(a)gmail.com> wrote: > > > and https://source.squeak.org/VMMaker/VMMaker.oscog-nice.2732.diff > > Alas no. The bug is definitely still there in both 32-bit and 64-bits in the trunk of VMMaker under the simulator. Run with your favorite trunk image and in the simulation open up an About Squeak SystemReporter. The good news is that it is *only* in the simulator on 64-bits. On the real VM on my Mac I see no problems. Nicolas, can you point me to the (un)signed shifts that had to be changed in Slang to fix the problem in the real VM? That should make it trivial to fix the simulation. I ask because there are no senders of >>> in BitBltSimulation so I don't see an obvious place to focus on. > Thanks!! > > > Le dim. 26 avr. 2020 à 22:48, Nicolas Cellier < > nicolas.cellier.aka.nice(a)gmail.com> a écrit : > >> Hi Eliot, >> already fixed by >> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3fa41faef52a157954… >> >> Le dim. 26 avr. 2020 à 22:44, Eliot Miranda <eliot.miranda(a)gmail.com> a >> écrit : >> >>> Hi Tim, >>> >>> On Sun, Mar 22, 2020 at 2:50 PM Eliot Miranda <eliot.miranda(a)gmail.com> >>> wrote: >>> >>>> Hi Bruce, >>>> >>>> On Mar 22, 2020, at 8:31 AM, Bruce O'Neel <bruce.oneel(a)pckswarms.ch> >>>> wrote: >>>> >>>> Hi, >>>> >>>> Good news, playing with >>>> >>>> --enable-fast-bitblt >>>> >>>> >>>> and >>>> >>>> --disable-fast-bitblt >>>> >>>> >>>> does work in that it builds a working VM. >>>> >>>> Good news/bad news, it does not change the font problem. So that's not >>>> the problem. >>>> >>>> >>>> Great news. We now know it is an X11 problem and can stop worrying >>>> about the fast BitBLT code. Thanks. >>>> >>> >>> Looks like the problem, or at least a version of the problem, is nothing >>> to do with X11. If I open an About Squeak System Reporter in the simulator >>> (64-bits x64) I see the fixed pitch font corruption we saw on X11 on ARM. >>> So it looks tile the issue is actually in BitBlt itself. >>> >>> <SysRepFixedPitch.png> >>> >>> >>>> >>>> cheers >>>> >>>> bruce >>>> >>>> *21 March 2020 01:07 tim Rowledge <tim(a)rowledge.org <tim(a)rowledge.org>> >>>> wrote:* >>>> >>>> >>>> >>>> > On 2020-03-20, at 6:16 AM, Bruce O'Neel wrote: >>>> > >>>> > >>>> > I specialize in ridiculous. Good news, I guess, is that I dug up a >>>> monitor, and, walked it downstairs with a keyboard and mouse and attached >>>> it. The effect with the BitstreamVeraSans and ComicSans fonts are the same. >>>> Maybe it likes serfed fonts? >>>> >>>> I'm completely baffled by this. I don't get this effect with any ARM vm >>>> that I have that actually runs, with any image I have. >>>> >>>> > >>>> > So that means that it is not some funky X11 over the wire problem >>>> with the Mac and Windows X11 servers problem. That's good. >>>> >>>> Guess so, though it just makes life weirder. >>>> >>>> > >>>> > I have no idea then why. Are these fonts part of the image? Is it >>>> some funky binary format that for some reason Coq is mis-reading? >>>> >>>> Yes, the font glyphs are in-image. We've been using these ones for >>>> goodness knows how many years. >>>> >>>> > >>>> > I built a stack VM and I get the same result with a Squeak 5.3 image. >>>> >>>> There*shouldn't* be any difference between the stack & cog vms. >>>> >>>> You could try building a VM with the fastbitblt turned off I suppose - >>>> a quick hack is to find the BITBLT_FLAGS= -DENABLE_FAST_BLT and related >>>> lines in the Makefile in you squeak.cog.spur/build directory. I haven't >>>> actually built an ARM vm without that in years so I don't know it it even >>>> still works. >>>> >>>> >>>> tim >>>> -- >>>> tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim >>>> It is easier to change the specification to fit the program than vice >>>> versa. >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>> >>> -- >>> _,,,^..^,,,_ >>> best, Eliot >>> >>> > -- _,,,^..^,,,_ best, Eliot

2 1

VM Maker: VMMaker.oscog-eem.2747.mcz
by commits＠source.squeak.org 27 Apr '20

27 Apr '20

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2747.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2747 Author: eem Time: 27 April 2020, 11:06:08.992999 am UUID: 44a342bf-20ca-4a8b-be79-a9f0206ae5b8 Ancestors: VMMaker.oscog-eem.2746 BitBltSImulation: Nuke an unused cCode:inSmalltalk: in loadColorMap and stream-liner the initialization a bit. =============== Diff against VMMaker.oscog-eem.2746 =============== Item was changed: ----- Method: BitBltSimulation>>loadColorMap (in category 'interpreter interface') ----- loadColorMap "ColorMap, if not nil, must be longWords, and 2^N long, where N = sourceDepth for 1, 2, 4, 8 bits, or N = 9, 12, or 15 (3, 4, 5 bits per color) for 16 or 32 bits." | cmSize oldStyle oop cmOop | <inline: true> cmFlags := cmMask := cmBitsPerColor := 0. cmShiftTable := nil. cmMaskTable := nil. cmLookupTable := nil. cmOop := interpreterProxy fetchPointer: BBColorMapIndex ofObject: bitBltOop. cmOop = interpreterProxy nilObject ifTrue:[^true]. cmFlags := ColorMapPresent. "even if identity or somesuch - may be cleared later" + (interpreterProxy isWords: cmOop) + ifTrue: "This is an old-style color map (indexed only, with implicit RGBA conversion)" + [oldStyle := true. + cmSize := interpreterProxy slotSizeOf: cmOop. + cmLookupTable := interpreterProxy firstIndexableField: cmOop] + ifFalse: "A new-style color map (fully qualified)" + [oldStyle := false. + ((interpreterProxy isPointers: cmOop) + and:[(interpreterProxy slotSizeOf: cmOop) >= 3]) ifFalse:[^false]. + cmShiftTable := self loadColorMapShiftOrMaskFrom: + (interpreterProxy fetchPointer: 0 ofObject: cmOop). + cmMaskTable := self loadColorMapShiftOrMaskFrom: + (interpreterProxy fetchPointer: 1 ofObject: cmOop). + oop := interpreterProxy fetchPointer: 2 ofObject: cmOop. + oop = interpreterProxy nilObject + ifTrue:[cmSize := 0] + ifFalse:[(interpreterProxy isWords: oop) ifFalse:[^false]. + cmSize := (interpreterProxy slotSizeOf: oop). + cmLookupTable := interpreterProxy firstIndexableField: oop]. + cmFlags := cmFlags bitOr: ColorMapNewStyle]. - oldStyle := false. - (interpreterProxy isWords: cmOop) ifTrue:[ - "This is an old-style color map (indexed only, with implicit RGBA conversion)" - cmSize := interpreterProxy slotSizeOf: cmOop. - cmLookupTable := interpreterProxy firstIndexableField: cmOop. - oldStyle := true. - ] ifFalse: [ - "A new-style color map (fully qualified)" - ((interpreterProxy isPointers: cmOop) - and:[(interpreterProxy slotSizeOf: cmOop) >= 3]) ifFalse:[^false]. - cmShiftTable := self loadColorMapShiftOrMaskFrom: - (interpreterProxy fetchPointer: 0 ofObject: cmOop). - cmMaskTable := self loadColorMapShiftOrMaskFrom: - (interpreterProxy fetchPointer: 1 ofObject: cmOop). - oop := interpreterProxy fetchPointer: 2 ofObject: cmOop. - oop = interpreterProxy nilObject - ifTrue:[cmSize := 0] - ifFalse:[(interpreterProxy isWords: oop) ifFalse:[^false]. - cmSize := (interpreterProxy slotSizeOf: oop). - cmLookupTable := interpreterProxy firstIndexableField: oop]. - cmFlags := cmFlags bitOr: ColorMapNewStyle. - self cCode: '' inSmalltalk: - []. - ]. (cmSize bitAnd: cmSize - 1) = 0 ifFalse:[^false]. cmMask := cmSize - 1. cmBitsPerColor := 0. - cmSize = 512 ifTrue: [cmBitsPerColor := 3]. - cmSize = 4096 ifTrue: [cmBitsPerColor := 4]. - cmSize = 32768 ifTrue: [cmBitsPerColor := 5]. cmSize = 0 ifTrue:[cmLookupTable := nil. cmMask := 0] + ifFalse: + [cmFlags := cmFlags bitOr: ColorMapIndexedPart. + cmSize = 512 ifTrue: [cmBitsPerColor := 3]. + cmSize = 4096 ifTrue: [cmBitsPerColor := 4]. + cmSize = 32768 ifTrue: [cmBitsPerColor := 5]]. + oldStyle ifTrue: "needs implicit conversion" + [self setupColorMasks]. - ifFalse:[cmFlags := cmFlags bitOr: ColorMapIndexedPart]. - oldStyle "needs implicit conversion" - ifTrue:[ self setupColorMasks]. "Check if colorMap is just identity mapping for RGBA parts" (self isIdentityMap: cmShiftTable with: cmMaskTable) + ifTrue: [cmMaskTable := nil. cmShiftTable := nil] + ifFalse: [cmFlags := cmFlags bitOr: ColorMapFixedPart]. - ifTrue:[ cmMaskTable := nil. cmShiftTable := nil ] - ifFalse:[ cmFlags := cmFlags bitOr: ColorMapFixedPart]. ^true!

1 0

VM only zip
by K K Subbu 27 Apr '20

27 Apr '20

Hi, Currently, Squeak VM binaries files.squeak.org/6.0alpha come with the Image even though Image is available as a separate zip. The Image constitutes more than half the download size and is often useless because I update my image much more frequently than the VM binaries. Is it possible to exclude the Image from the platform binaries to keep them slim? Regards .. Subbu

2 4

Re: [Vm-dev] [squeak-dev] Squeak5.3 linux ARMv6 segfaults on startup
by Eliot Miranda 27 Apr '20

27 Apr '20

Hi Tim, On Sun, Mar 22, 2020 at 2:50 PM Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > Hi Bruce, > > On Mar 22, 2020, at 8:31 AM, Bruce O'Neel <bruce.oneel(a)pckswarms.ch> > wrote: > > Hi, > > Good news, playing with > > --enable-fast-bitblt > > > and > > --disable-fast-bitblt > > > does work in that it builds a working VM. > > Good news/bad news, it does not change the font problem. So that's not > the problem. > > > Great news. We now know it is an X11 problem and can stop worrying about > the fast BitBLT code. Thanks. > Looks like the problem, or at least a version of the problem, is nothing to do with X11. If I open an About Squeak System Reporter in the simulator (64-bits x64) I see the fixed pitch font corruption we saw on X11 on ARM. So it looks tile the issue is actually in BitBlt itself. [image: SysRepFixedPitch.png] > > > cheers > > bruce > > *21 March 2020 01:07 tim Rowledge <tim(a)rowledge.org <tim(a)rowledge.org>> > wrote:* > > > > > On 2020-03-20, at 6:16 AM, Bruce O'Neel wrote: > > > > > > I specialize in ridiculous. Good news, I guess, is that I dug up a > monitor, and, walked it downstairs with a keyboard and mouse and attached > it. The effect with the BitstreamVeraSans and ComicSans fonts are the same. > Maybe it likes serfed fonts? > > I'm completely baffled by this. I don't get this effect with any ARM vm > that I have that actually runs, with any image I have. > > > > > So that means that it is not some funky X11 over the wire problem with > the Mac and Windows X11 servers problem. That's good. > > Guess so, though it just makes life weirder. > > > > > I have no idea then why. Are these fonts part of the image? Is it some > funky binary format that for some reason Coq is mis-reading? > > Yes, the font glyphs are in-image. We've been using these ones for > goodness knows how many years. > > > > > I built a stack VM and I get the same result with a Squeak 5.3 image. > > There*shouldn't* be any difference between the stack & cog vms. > > You could try building a VM with the fastbitblt turned off I suppose - > a quick hack is to find the BITBLT_FLAGS= -DENABLE_FAST_BLT and related > lines in the Makefile in you squeak.cog.spur/build directory. I haven't > actually built an ARM vm without that in years so I don't know it it even > still works. > > > tim > -- > tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim > It is easier to change the specification to fit the program than vice > versa. > > > > > > > -- _,,,^..^,,,_ best, Eliot

2 1

[OpenSmalltalk/opensmalltalk-vm] 99553e: Fix the x86 & x86_64 simulators after the change t...
by Eliot Miranda 26 Apr '20

26 Apr '20

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 99553e018b7bf1ff01c7ad932b17a8e61fcdd9a1 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/99553e018b7bf1ff01… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2020-04-25 (Sat, 25 Apr 2020) Changed paths: M platforms/Cross/plugins/BochsIA32Plugin/sqBochsIA32Plugin.cpp M platforms/Cross/plugins/BochsX64Plugin/sqBochsX64Plugin.cpp M processors/IA32/bochs/cpu/cpu.cc M processors/IA32/bochs/cpu/proc_ctrl.cc Log Message: ----------- Fix the x86 & x86_64 simulators after the change to the sideways-jump interpret invocation uncovered a bug in them. Simplify the run invocation, eliminating a superfluous setjmp (cpu_loop does a setjmp). Modify the cpu_loop setjmp to set the stop_reason to the longjmp code. Eliminate a compiler warning in bochs/cpu/proc_ctrl.cc which needs different printf strings for 32 & 64 bits. [ci skip]

1 0

VM Maker: VMMaker.oscog-eem.2746.mcz
by commits＠source.squeak.org 26 Apr '20

26 Apr '20

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2746.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2746 Author: eem Time: 25 April 2020, 8:44:02.167448 pm UUID: ab08e05b-4fbf-48a4-a27b-7b9adf3d4bb0 Ancestors: VMMaker.oscog-eem.2745 Simulation: Fix stack alignment and simulation of reentering the interpreter via the jump call in ceInvokeInterpreter. Requires Cog-eem.405. =============== Diff against VMMaker.oscog-eem.2745 =============== Item was changed: ----- Method: Cogit>>handleCallOrJumpSimulationTrap: (in category 'simulation only') ----- handleCallOrJumpSimulationTrap: aProcessorSimulationTrap <doNotGenerate> | evaluable function memory result savedFramePointer savedStackPointer savedArgumentCount retpc | evaluable := simulatedTrampolines at: aProcessorSimulationTrap address ifAbsent: [self errorProcessingSimulationTrap: aProcessorSimulationTrap in: simulatedTrampolines]. function := evaluable isBlock ifTrue: ['aBlock; probably some plugin primitive'] ifFalse: [evaluable receiver == backEnd ifTrue: [^self handleABICallOrJumpSimulationTrap: aProcessorSimulationTrap evaluable: evaluable]. evaluable selector]. + memory := coInterpreter memory. + function == #interpret ifTrue: "i.e. we're here via ceInvokeInterpret and should discard all state back to enterSmalltalkExecutiveImplementation" + [processor + simulateJumpCallOf: aProcessorSimulationTrap address + memory: memory. + self recordInstruction: {'(simulated jump call of '. aProcessorSimulationTrap address. '/'. function. ')'}. + processor smashCallerSavedRegistersWithValuesFrom: 16r80000000 by: objectMemory wordSize in: memory. + coInterpreter reenterInterpreter. + "NOTREACHED" + self halt]. function ~~ #ceBaseFrameReturn: ifTrue: [coInterpreter assertValidExternalStackPointers]. (backEnd wantsNearAddressFor: function) ifTrue: [^self perform: function with: aProcessorSimulationTrap]. - memory := coInterpreter memory. processor simulateCallOf: aProcessorSimulationTrap address nextpc: aProcessorSimulationTrap nextpc memory: memory. retpc := processor retpcIn: memory. self recordInstruction: {'(simulated call of '. aProcessorSimulationTrap address. '/'. function. ')'}. - function == #interpret ifTrue: "i.e. we're here via ceInvokeInterpret and should discard all state back to enterSmalltalkExecutiveImplementation" - [coInterpreter reenterInterpreter]. savedFramePointer := coInterpreter framePointer. savedStackPointer := coInterpreter stackPointer. savedArgumentCount := coInterpreter argumentCount. result := ["self halt: evaluable selector." clickConfirm ifTrue: [(self confirm: 'skip run-time call?') ifFalse: [clickConfirm := false. self halt]]. evaluable valueWithArguments: (processor postCallArgumentsNumArgs: evaluable numArgs in: memory)] on: ReenterMachineCode do: [:ex| ex return: #continueNoReturn]. coInterpreter assertValidExternalStackPointers. "Verify the stack layout assumption compileInterpreterPrimitive: makes, provided we've not called something that has built a frame, such as closure value or evaluate method, or switched frames, such as primitiveSignal, primitiveWait, primitiveResume, primitiveSuspend et al." (function beginsWith: 'primitive') ifTrue: [coInterpreter primFailCode = 0 ifTrue: [(CogVMSimulator stackAlteringPrimitives includes: function) ifFalse: ["This is a rare case (e.g. in Scorch where a married context's sender is set to nil on trapTrpped and hence the stack layout is altered." (function == #primitiveSlotAtPut and: [objectMemory isContext: (coInterpreter frameReceiver: coInterpreter framePointer)]) ifFalse: [self assert: savedFramePointer = coInterpreter framePointer. self assert: savedStackPointer + (savedArgumentCount * objectMemory wordSize) = coInterpreter stackPointer]]] ifFalse: [self assert: savedFramePointer = coInterpreter framePointer. self assert: savedStackPointer = coInterpreter stackPointer]]. result ~~ #continueNoReturn ifTrue: [self recordInstruction: {'(simulated return to '. processor retpcIn: memory. ')'}. processor simulateReturnIn: memory. self assert: processor pc = retpc. processor smashCallerSavedRegistersWithValuesFrom: 16r80000000 by: objectMemory wordSize in: memory]. self assert: (result isInteger "an oop result" or: [result == coInterpreter or: [result == objectMemory or: [result == nil or: [result == #continueNoReturn]]]]). processor cResultRegister: (result ifNil: [0] ifNotNil: [result isInteger ifTrue: [result] ifFalse: [16rF00BA222]])! Item was changed: ----- Method: Cogit>>simulateCogCodeAt: (in category 'simulation only') ----- simulateCogCodeAt: address "<Integer>" <doNotGenerate> | stackZoneBase | stackZoneBase := coInterpreter stackZoneBase. processor pc: address. [[[singleStep ifTrue: [[processor sp < stackZoneBase ifTrue: [self halt]. self recordProcessing. self maybeBreakAt: processor pc] value. "So that the Debugger's Over steps over all this" processor singleStepIn: coInterpreter memory minimumAddress: guardPageSize readOnlyBelow: methodZone zoneEnd] ifFalse: [processor runInMemory: coInterpreter memory minimumAddress: guardPageSize readOnlyBelow: methodZone zoneEnd]. "((printRegisters or: [printInstructions]) and: [clickConfirm]) ifTrue: [(self confirm: 'continue?') ifFalse: [clickConfirm := false. self halt]]." true] whileTrue] on: ProcessorSimulationTrap do: [:ex| ex type == #read ifTrue: [self handleReadSimulationTrap: ex. ex resume: processor]. ex type == #write ifTrue: [self handleWriteSimulationTrap: ex. ex resume: processor]. + ex type == #jump ifTrue: + [processor hackFixNextPCOfJumpFor: ex using: objectMemory]. self handleCallOrJumpSimulationTrap: ex]. true] whileTrue!

1 0

VM Maker: Cog-eem.405.mcz
by commits＠source.squeak.org 26 Apr '20

26 Apr '20

Eliot Miranda uploaded a new version of Cog to project VM Maker: http://source.squeak.org/VMMaker/Cog-eem.405.mcz ==================== Summary ==================== Name: Cog-eem.405 Author: eem Time: 25 April 2020, 8:42:08.457845 pm UUID: 35edc518-f11b-43f8-90c7-6a93e755e67d Ancestors: Cog-eem.404 Include MIPS in the hack fix, and fix a comment. =============== Diff against Cog-eem.404 =============== Item was changed: ----- Method: GdbARMAlien>>hackFixNextPCOfJumpFor:using: (in category 'execution') ----- hackFixNextPCOfJumpFor: aProcessorSimulationTrap using: objectMemory "This is a hack fix before we revise the simulators. When a jump call is made, the + next pc is effectively the return address in the link reg, not the instruction following - next pc is effectively the return address on the stack, not the instruction following the jump. So reset it here. All this is because currently the simulators don't execute a control transfer to a fake address, as would a real processor. Once the processor simulators correctly emulate such control transfers, we can ditch this hack." aProcessorSimulationTrap nextpc: self lr! Item was added: + ----- Method: MIPSSimulator>>hackFixNextPCOfJumpFor:using: (in category 'processor api') ----- + hackFixNextPCOfJumpFor: aProcessorSimulationTrap using: objectMemory + "This is a hack fix before we revise the simulators. When a jump call is made, the + next pc is effectively the return address in the link reg, not the instruction following + the jump. So reset it here. All this is because currently the simulators don't execute + a control transfer to a fake address, as would a real processor. Once the processor + simulators correctly emulate such control transfers, we can ditch this hack." + + aProcessorSimulationTrap nextpc: self lr!

1 0

VM Maker: Cog-eem.404.mcz
by commits＠source.squeak.org 26 Apr '20

26 Apr '20

Eliot Miranda uploaded a new version of Cog to project VM Maker: http://source.squeak.org/VMMaker/Cog-eem.404.mcz ==================== Summary ==================== Name: Cog-eem.404 Author: eem Time: 25 April 2020, 8:38:56.265452 pm UUID: 61ffd076-549a-4f7f-b1ca-90fd7f70df67 Ancestors: Cog-eem.403 Add the jump-call hack fix for the processor simulators. =============== Diff against Cog-eem.403 =============== Item was added: + ----- Method: BochsIA32Alien>>hackFixNextPCOfJumpFor:using: (in category 'execution') ----- + hackFixNextPCOfJumpFor: aProcessorSimulationTrap using: objectMemory + "This is a hack fix before we revise the simulators. When a jump call is made, the + next pc is effectively the return address on the stack, not the instruction following + the jump. So reset it here. All this is because currently the simulators don't execute + a control transfer to a fake address, as would a real processor. Once the processor + simulators correctly emulate such control transfers, we can ditch this hack." + + aProcessorSimulationTrap nextpc: (objectMemory longAt: self sp)! Item was added: + ----- Method: BochsX64Alien>>hackFixNextPCOfJumpFor:using: (in category 'execution') ----- + hackFixNextPCOfJumpFor: aProcessorSimulationTrap using: objectMemory + "This is a hack fix before we revise the simulators. When a jump call is made, the + next pc is effectively the return address on the stack, not the instruction following + the jump. So reset it here. All this is because currently the simulators don't execute + a control transfer to a fake address, as would a real processor. Once the processor + simulators correctly emulate such control transfers, we can ditch this hack." + + aProcessorSimulationTrap nextpc: (objectMemory longAt: self sp)! Item was added: + ----- Method: GdbARMAlien>>hackFixNextPCOfJumpFor:using: (in category 'execution') ----- + hackFixNextPCOfJumpFor: aProcessorSimulationTrap using: objectMemory + "This is a hack fix before we revise the simulators. When a jump call is made, the + next pc is effectively the return address on the stack, not the instruction following + the jump. So reset it here. All this is because currently the simulators don't execute + a control transfer to a fake address, as would a real processor. Once the processor + simulators correctly emulate such control transfers, we can ditch this hack." + + aProcessorSimulationTrap nextpc: self lr!

1 0

[OpenSmalltalk/opensmalltalk-vm] 97bce7: And undo yet another inadvertent mod to the Bochs ...
by Eliot Miranda 26 Apr '20

26 Apr '20

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 97bce73cff19e7c526209816ec4911bfb605be0a https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/97bce73cff19e7c526… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2020-04-25 (Sat, 25 Apr 2020) Changed paths: M processors/IA32/bochs/cpu/cpu.cc Log Message: ----------- And undo yet another inadvertent mod to the Bochs sim. [ci skip]

1 0

[OpenSmalltalk/opensmalltalk-vm] 86da8c: Fix a cvompiler warning in the Bochs sim. [ci skip]
by Eliot Miranda 26 Apr '20

26 Apr '20

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 86da8ca85fe39eeaddb03697e2a3a97d8837490b https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/86da8ca85fe39eeadd… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2020-04-25 (Sat, 25 Apr 2020) Changed paths: M processors/IA32/bochs/cpu/proc_ctrl.cc Log Message: ----------- Fix a cvompiler warning in the Bochs sim. [ci skip]

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev April 2020