Vm-dev August 2021

vm-dev@lists.squeakfoundation.org

17 participants
161 discussions

[OpenSmalltalk/opensmalltalk-vm] 73f30a: Update VectorEnginePlugin
by David T Lewis 24 Aug '21

24 Aug '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 73f30ab892b238a732ce3e0e9a26388356e50737 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/73f30ab892b238a732… Author: David T. Lewis <lewis(a)mail.msen.com> Date: 2021-08-24 (Tue, 24 Aug 2021) Changed paths: M src/plugins/VectorEnginePlugin/VectorEnginePlugin.c Log Message: ----------- Update VectorEnginePlugin commit 86377f4de7ebd7682f049bef2b4557ac1b91b569 Author: Juan Vuletich <juan(a)jvuletich.org> Date: Sun Aug 22 16:50:25 2021 -0300 Fix for an unlikely invalid access in VectorEnginePlugin: always pass contour as argument.

1 0

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] CogVM source as per VMMaker.oscog-eem.3047 (12b0d50)
by Eliot Miranda 24 Aug '21

24 Aug '21

Hi Tim, > On Aug 23, 2021, at 11:26 AM, OpenSmalltalk-Bot ***(a)***.***> wrote: > > > > > > On 2021-08-22, at 11:55 PM, Marcel Taeumel ***(a)***.***> wrote: > > > > > > I can confirm that compilation performance (e.g. Morph compileAll) is back to normal in cog.spur :-) > > On Raspberry Pi 4 v8 it compiles cleanly but appears to be ~10% slower on the tinybenchmarks. I know they're not exactly high-value tests but the difference is noticeable I have reason not to believe this. In all the recent changes, no change has been made to the code generated for tinyBenchmarks. And I’m confident that the other changes made (save the now fixed regression) yield significant speed ups. Is there any other reason the timings could have changed? _,,,^..^,,,_ (phone) > > tim > -- > tim Rowledge; ***(a)***.***; http://www.rowledge.org/tim > Strange OpCodes: PNG: Pass Noxious Gas > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub, or unsubscribe. > Triage notifications on the go with GitHub Mobile for iOS or Android. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/12b0d50876312a74c5…

2 1

VM Maker: CogTools-eem.91.mcz
by commits＠source.squeak.org 24 Aug '21

24 Aug '21

Eliot Miranda uploaded a new version of CogTools to project VM Maker: http://source.squeak.org/VMMaker/CogTools-eem.91.mcz ==================== Summary ==================== Name: CogTools-eem.91 Author: eem Time: 23 August 2021, 5:56:40.624079 pm UUID: 4b95c5fc-8165-4db7-bbe1-5502f8927b02 Ancestors: CogTools-eem.90 Fixes to PluggableListMorphOfManyAlt gratefully received from Marcel. Recategorizations, and a big fix to findSymbol:event:. =============== Diff against CogTools-eem.90 =============== Item was changed: + ----- Method: PharoVMProfiler>>createParagraph (in category 'reports') ----- - ----- Method: PharoVMProfiler>>createParagraph (in category 'as yet unclassified') ----- createParagraph ^Paragraph new! Item was changed: + ----- Method: PharoVMProfiler>>getVMParameters (in category 'reports') ----- - ----- Method: PharoVMProfiler>>getVMParameters (in category 'as yet unclassified') ----- getVMParameters ^Smalltalk vm getParameters ! Item was removed: - ----- Method: PluggableListMorphOfManyAlt>>getList (in category 'model access') ----- - getList - "Answer the list to be displayed. Caches the returned list in the 'list' ivar" - getListSelector == nil ifTrue: [^ #()]. - list := model perform: getListSelector. - list == nil ifTrue: [^ #()]. - getListElementSelector ifNil: - [list := list collect: [ :item | item asStringOrText ]]. - ^ list! Item was changed: ----- Method: PluggableListMorphOfManyAlt>>itemSelectedAmongMultiple: (in category 'model access') ----- + itemSelectedAmongMultiple: viewIndex + ^self listSelectionAt: (self modelIndexFor: viewIndex)! - itemSelectedAmongMultiple: index - ^self listSelectionAt: index! Item was removed: - ----- Method: PluggableListMorphOfManyAlt>>list: (in category 'initialization') ----- - list: listOfStrings - scroller removeAllMorphs. - list := listOfStrings ifNil: [Array new]. - list isEmpty ifTrue: [^ self selectedMorph: nil]. - super list: listOfStrings. - - "At this point first morph is sensitized, and all morphs share same handler." - scroller firstSubmorph on: #mouseEnterDragging - send: #mouseEnterDragging:onItem: - to: self. - scroller firstSubmorph on: #mouseUp - send: #mouseUp:onItem: - to: self. - "This should add this behavior to the shared event handler thus affecting all items"! Item was changed: ----- Method: PluggableListMorphOfManyAlt>>mouseDown: (in category 'event handling') ----- mouseDown: event + | row index | - | oldIndex oldVal row | - Transcript cr; show: 'mouseDown:'. event yellowButtonPressed ifTrue: [^ self yellowButtonActivity: event shiftPressed]. row := self rowAtLocation: event position. row = 0 ifTrue: [^super mouseDown: event]. + index := self modelIndexFor: row. + - model okToChange ifFalse: [^ self]. "No change if model is locked" - - "Set meaning for subsequent dragging of selection" - dragOnOrOff := (self listSelectionAt: row) not. currentRow := row. - oldIndex := self getCurrentSelectionIndex. - oldVal := oldIndex ~= 0 ifTrue: [self listSelectionAt: oldIndex] ifFalse: [false]. + self changeModelSelection: index. - "Need to restore the old one, due to how model works, and set new one." - oldIndex ~= 0 ifTrue: [self listSelectionAt: oldIndex put: oldVal]. + "Set meaning for subsequent dragging of selection" + self + listSelectionAt: index + put: (dragOnOrOff := (self listSelectionAt: index) not) + ! - "Set or clear new primary selection (listIndex)" - self listSelectionAt: row put: oldVal not! Item was changed: ----- Method: PluggableListMorphOfManyAlt>>mouseMove: (in category 'event handling') ----- mouseMove: event "The mouse has moved, as characterized by the event provided. Adjust the scrollbar, and alter the selection as appropriate" + | row index | - | row | - Transcript cr; show: 'mouseMove:'. event position y < self top ifTrue: [scrollBar scrollUp: 1. row := self rowAtLocation: scroller topLeft + (1 @ 1)] ifFalse: [row := event position y > self bottom ifTrue: [scrollBar scrollDown: 1. self rowAtLocation: scroller bottomLeft + (1 @ -1)] ifFalse: [ self rowAtLocation: event position]]. row = 0 ifTrue: [^super mouseDown: event]. + index := self modelIndexFor: row. model okToChange ifFalse: [^self]. "No change if model is locked" + currentRow = row ifTrue: [^self]. - currentRow = row ifTrue: - [^self]. - currentRow := row. + dragOnOrOff ifNil: [ - dragOnOrOff ifNil: - ["Don't treat a mouse move immediately after a mouse down to the same index." - row = self getCurrentSelectionIndex ifTrue: [^self]. - "Was not set at mouse down, which means the mouse must have gone down in an area where there was no list item" + dragOnOrOff := (self listSelectionAt: index) not]. - dragOnOrOff := (self listSelectionAt: row) not]. + self changeModelSelection: index. + self listSelectionAt: index put: dragOnOrOff.! - "Set or clear new primary selection (listIndex)" - dragOnOrOff - ifTrue: [self changeModelSelection: row] - ifFalse: [self changeModelSelection: 0]. - - row changed! Item was changed: ----- Method: PluggableListMorphOfManyAlt>>mouseUp: (in category 'event handling') ----- mouseUp: event + dragOnOrOff := nil. "So improperly started drags will have not effect" + currentRow := nil. "So mouseMove won't trigger more than once" + + event hand newKeyboardFocus: self. + hasFocus := true. + Cursor normal show.! - dragOnOrOff := nil. "So improperly started drags will have no effect" - currentRow := nil "So mouseMove won't trigger more than once"! Item was removed: - ----- Method: PluggableListMorphOfManyAlt>>scrollSelectionIntoView (in category 'selection') ----- - scrollSelectionIntoView - "Make sure that the current selection is visible. - If the selections() will fit in the scroll region then scroll the selection(s) - to the middle of the visible region. If it is larger, make the first part visible." - | row rowBounds innerBounds i | - (row := self getCurrentSelectionIndex) = 0 ifTrue: - [^self]. - rowBounds := self listMorph drawBoundsForRow: row. - innerBounds := self innerBounds. - i := row + 1. - [(model perform: getSelectionListSelector with: i) - and: [(self listMorph drawBoundsForRow: i) bottom - rowBounds top < innerBounds height]] whileTrue: - [i := i + 1]. - rowBounds := rowBounds merge: (self listMorph drawBoundsForRow: i - 1). - self scrollToShow: (innerBounds align: innerBounds center with: rowBounds center)! Item was changed: ----- Method: PluggableListMorphOfManyAlt>>update: (in category 'updating') ----- update: aSymbol + + aSymbol == #allSelections ifTrue: [ + "Convenient - yet hard-coded - way to refresh all selections." + super update: getIndexSelector. + ^ self changed]. + aSymbol == getSelectionListSelector ifTrue: [ + ^ self changed]. + + super update: aSymbol.! - aSymbol == #allSelections ifTrue: - [^self updateList; selectionIndex: self getCurrentSelectionIndex]. - ^super update: aSymbol! Item was changed: + ----- Method: SqueakVMProfiler>>createParagraph (in category 'reports') ----- - ----- Method: SqueakVMProfiler>>createParagraph (in category 'as yet unclassified') ----- createParagraph ^NewParagraph new! Item was changed: ----- Method: SqueakVMProfiler>>findSymbol:event: (in category 'menus') ----- findSymbol: typeOrNil event: event | pattern matches selection anIndex | previousPattern ifNil: [previousPattern := '*']. pattern := UIManager default request: 'Symbol or pattern to find' initialAnswer: previousPattern. pattern isEmpty ifTrue: [^self]. previousPattern := pattern. matches := symbolManager symbolsSelect: (typeOrNil ifNotNil: [(pattern includesAnyOf: '#*') ifTrue: [[:sym| sym type == typeOrNil and: [sym nameMatches: pattern]]] ifFalse: [[:sym| sym type == typeOrNil and: [sym name includesSubstring: pattern caseSensitive: false]]]] ifNil: [(pattern includesAnyOf: '#*') ifTrue: [[:sym| sym nameMatches: pattern]] ifFalse: [[:sym| sym name includesSubstring: pattern caseSensitive: false]]]). matches isEmpty ifTrue: [^UIManager inform: 'No symbols match your query']. matches size = 1 ifTrue: [selection := matches first] ifFalse: [matches := matches asSortedCollection: [:s1 :s2| | sd1 sd2 | (sd1 := s1 displayText) asString < (sd2 := s2 displayText) asString or: [sd1 = sd2 and: [s1 address <= s2 address]]]. selection := (SelectionMenu labelList: {'Choose symbol'}, (matches collect: [:ea| ea type == #module ifTrue: [ea displayText] ifFalse: [ea displayText, ' @', (ea address printStringRadix: 16), + ((symbolManager moduleFor: ea) ifNotNil: [:m| ' in ', m displayText] ifNil: [''])]]) - ' in ', (symbolManager moduleFor: ea) displayText]]) lines: {1} selections: {nil}, matches) startUp. selection ifNil: [^self]]. (symbolTypes includes: selection type) ifFalse: [self toggleShowing: selection type]. minSelectionIndex := 0. 1 to: symbolList size do: [:i| selections at: i put: (((symbolList at: i) address >= selection address and: [(symbolList at: i) limit <= selection limit]) ifTrue: [minSelectionIndex = 0 ifTrue: [minSelectionIndex := i]. maxSelectionIndex := i. 1] ifFalse: [0])]. self changed: #symbolList. self addToHistory. "If selecting a label make sure there's not a zero address range so select from the previous non-label symbol to the following non-label symbol" selection address = selection limit ifTrue: [anIndex := minSelectionIndex. [(symbolList at: anIndex) type == #label and: [anIndex > 1]] whileTrue: [anIndex := anIndex - 1]. lowAddress := (symbolList at: anIndex) address. anIndex := maxSelectionIndex. [(symbolList at: anIndex) type == #label and: [anIndex < symbolList size]] whileTrue: [anIndex := anIndex + 1]. highAddress := (symbolList at: anIndex) address] ifFalse: [lowAddress := selection address. highAddress := selection limit]. self updateAddressDependents; updateButtons; plotGraph! Item was changed: + ----- Method: SqueakVMProfiler>>getVMParameters (in category 'reports') ----- - ----- Method: SqueakVMProfiler>>getVMParameters (in category 'as yet unclassified') ----- getVMParameters ^Smalltalk getVMParameters ! Item was changed: ----- Method: SqueakVMProfiler>>openInWindow (in category 'opening') ----- openInWindow "VMProfiler open" | window symbolListMorph labelsMorph buttons | (window := SystemWindow new) setProperty: #allowPaneSplitters toValue: false; model: self; setLabel: self class name; fillStyle: Color white; paneColor: Color white; color: Color white. (window respondsTo: #allowPaneSplitters:) ifTrue: [window allowPaneSplitters: false]. "Cope with Squeak 4.1 SystemWindow background color changes" window addMorph: (AlignmentMorph new color: Color white; yourself) frame: (0@0 corner: 1@1). symbolListMorph := PluggableListMorphOfManyAlt on: self list: #symbolList primarySelection: #symbolIndex + changePrimarySelection: nil - changePrimarySelection: #toggleListIndex: listSelection: #symbolSelectionAt: changeListSelection: #symbolSelectionAt:put: - getListElement: #listEntryForIndex: menu: #symbolListMenu:. symbolListMorph hScrollBarPolicy: #whenNeeded. "buggy misnamed selector :)" labelsMorph := VMProfileGraphLabelMorph model: self font: self labelFont getLabels: #positionedLabels. expressionTextMorph := PluggableTextMorph on: self text: nil accept: nil readSelection: #selectionRange menu: #expressionTextMenu:. expressionTextMorph setProperty: #alwaysAccept toValue: true; askBeforeDiscardingEdits: false; setBalloonText: 'type an expression to profile here'. buttons := OrderedCollection new. window addMorph: symbolListMorph frame: (0@0 corner: 0.15@1); addMorph: (graph := VMProfilePlotMorph model: self) frame: (0.15@0 corner: 1.0(a)0.7); addMorph: labelsMorph frame: (0.15(a)0.7 corner: 1.0(a)0.85); "address boxes" addMorph: (self addressTextMorph:'Type the low address of the histogram here' get: #lowAddressText set: #lowAddressText:) frame: (0.16(a)0.86 corner: 0.27(a)0.91); addMorph: (self addressTextMorph:'Type the high address of the histogram here' get: #highAddressText set: #highAddressText:) frame: (0.88(a)0.86 corner: 0.99(a)0.91); addMorph: (self totalTextMorph: 'Shows the total number of samples' get: #totalText) frame: (0.88(a)0.92 corner: 0.99(a)0.98); "symbol list check-box filters" addMorph: (self checkMorph: 'show module symbols' get: #showingModules set: #toggleShowModules) frame: (0.16(a)0.915 corner: 0.175(a)0.93); addMorph: (buttons addLast: (StringMorph contents: 'modules')) frame: (0.19(a)0.915 corner: 0.27(a)0.93); addMorph: (self checkMorph: 'show extern symbols' get: #showingPublicFunctions set: #toggleShowPublicFunctions) frame: (0.16(a)0.935 corner: 0.175(a)0.95); addMorph: (buttons addLast: (StringMorph contents: 'externs')) frame: (0.19(a)0.935 corner: 0.27(a)0.95); addMorph: (self checkMorph: 'show static symbols' get: #showingPrivateFunctions set: #toggleShowPrivateFunctions) frame: (0.16(a)0.955 corner: 0.175(a)0.97); addMorph: (buttons addLast: (StringMorph contents: 'statics')) frame: (0.19(a)0.955 corner: 0.27(a)0.97); addMorph: (self checkMorph: 'show static symbols' get: #showingLabels set: #toggleShowLabels) frame: (0.16(a)0.975 corner: 0.175(a)0.99); addMorph: (buttons addLast: (StringMorph contents: 'labels')) frame: (0.19(a)0.975 corner: 0.27(a)0.99); "history buttons" addMorph: (self historyButtonMorph: #backwardsButton help: 'go back to previous selection' set: #regress enable: #hasHistory color: #hasHistoryColor) frame: (0.28(a)0.86 corner: 0.315(a)0.90); addMorph: (self historyButtonMorph: #forwardsButton help: 'go forward to next selection' set: #progress enable: #hasFuture color: #hasFutureColor) frame: (0.32(a)0.86 corner: 0.355(a)0.90); "profiling buttons" addMorph: (self buttonMorph: #drawButton help: 'plot the graph' set: #plotGraph enable: #notProfilingAndData color: #clearColor) frame: (0.37(a)0.86 corner: 0.45(a)0.91); addMorph: (self buttonMorph: #clearButton help: 'clear the histogram data' set: #clearProfile enable: #notProfiling color: #clearColor) frame: (0.46(a)0.86 corner: 0.54(a)0.91); addMorph: (self buttonMorph: #startButton help: 'start the profiler' set: #startProfiling enable: #notProfiling color: #profileColor) frame: (0.28(a)0.915 corner: 0.36(a)0.96); addMorph: (self buttonMorph: #stopButton help: 'stop the profiler' set: #stopProfiling enable: #profiling color: #stopColor) frame: (0.37(a)0.915 corner: 0.45(a)0.96); addMorph: (self buttonMorph: #profileExpressionButton help: 'compile and profile the expression to the right' set: #profileExpression enable: #notProfiling color: #profileColor) frame: (0.46(a)0.915 corner: 0.54(a)0.96); addMorph: expressionTextMorph frame: (0.55(a)0.86 corner: 0.87(a)0.98); addMorph: (self checkMorph: 'Run the full garbage collector prior to profiling' get: #gcPriorToProfile set: #toggleGcPriorToProfile) frame: (0.28(a)0.97 corner: 0.295(a)0.985); addMorph: (buttons addLast: (StringMorph contents: 'gc prior')) frame: (0.30(a)0.97 corner: 0.365(a)0.995); addMorph: (self checkMorph: 'Clear the profile prior to profiling' get: #clearPriorToProfile set: #toggleClearPriorToProfile) frame: (0.37(a)0.97 corner: 0.385(a)0.985); addMorph: (buttons addLast: (StringMorph contents: 'clear prior')) frame: (0.39(a)0.97 corner: 0.455(a)0.995); addMorph: (self checkMorph: 'Run the profiled expression in its own process' get: #forkProfile set: #toggleForkProfile) frame: (0.46(a)0.97 corner: 0.475(a)0.985); addMorph: (buttons addLast: (StringMorph contents: 'fork profile')) frame: (0.48(a)0.97 corner: 0.545(a)0.995). . "A Color transparent fillStyle used to be the default. What a pain that things change so radically from release to release!!" graph fillStyle: Color transparent. self updateButtons. "weird!!" buttons do: [:buttonMorph| buttonMorph color: Color black]. "otherwise labels don't show :(" window openInWorld. self toggleShowing: #module. ^window! Item was changed: + ----- Method: VMProfiler>>createParagraph (in category 'reports') ----- - ----- Method: VMProfiler>>createParagraph (in category 'as yet unclassified') ----- createParagraph self subclassResponsibility ! Item was changed: + ----- Method: VMProfiler>>filterSamples: (in category 'reports') ----- - ----- Method: VMProfiler>>filterSamples: (in category 'as yet unclassified') ----- filterSamples: totals "Print sorted totals for all symbols with a total greater than 0.01% of the grand total." | substantial insubstantial cut labelWidthCut labelledInFull | cut := total / 10000.0. substantial := totals associations select: [:assoc| assoc value > cut]. labelWidthCut := total / 1000.0. labelledInFull := totals associations select: [:assoc| assoc value > labelWidthCut]. insubstantial := totals associations inject: 0 into: [:sum :assoc| (assoc value <= cut ifTrue: [assoc value] ifFalse: [0]) + sum]. substantial := substantial asSortedCollection: [:a1 :a2| a1 value > a2 value or: [a1 value = a2 value and: [a1 name < a2 name]]]. insubstantial > 0 ifTrue: [substantial := substantial asArray, {'...others...'->insubstantial}]. ^ {substantial. insubstantial. labelledInFull } ! Item was changed: + ----- Method: VMProfiler>>gcPriorToProfile (in category 'reports') ----- - ----- Method: VMProfiler>>gcPriorToProfile (in category 'as yet unclassified') ----- gcPriorToProfile ^gcPriorToProfile! Item was changed: + ----- Method: VMProfiler>>getVMParameters (in category 'reports') ----- - ----- Method: VMProfiler>>getVMParameters (in category 'as yet unclassified') ----- getVMParameters self subclassResponsibility ! Item was removed: - ----- Method: VMProfiler>>listEntryForIndex: (in category 'accessing') ----- - listEntryForIndex: index - ^(symbolList at: index ifAbsent: [^nil]) displayText! Item was changed: + ----- Method: VMProfiler>>toggleShowing: (in category 'selecting') ----- - ----- Method: VMProfiler>>toggleShowing: (in category 'as yet unclassified') ----- toggleShowing: aSymbol (symbolTypes includes: aSymbol) ifTrue: [symbolTypes remove: aSymbol] ifFalse: [symbolTypes add: aSymbol]. symbolTypes isEmpty ifTrue: [symbolTypes add: #module. self changed: #showingModules. aSymbol == #module ifTrue: [^self]]. self changed: #showingModules; changed: #showingPublicFunctions; changed: #showingPrivateFunctions; changed: #showingLabels. symbolList := symbolManager symbolsWithTypes: symbolTypes. selections := ByteArray new: symbolList size. self selectSymbolsInRange. self changed: #symbolList; changed: #positionedLabels! Item was changed: + ----- Method: VMProfiler>>withDetails (in category 'accessing') ----- - ----- Method: VMProfiler>>withDetails (in category 'as yet unclassified') ----- withDetails ^ withDetails! Item was changed: + ----- Method: VMProfiler>>withDetails: (in category 'accessing') ----- - ----- Method: VMProfiler>>withDetails: (in category 'as yet unclassified') ----- withDetails: aBoolean "is the boolean is set to true, then the profiler will provide a detailed report (with bytecode ranges within a function)" withDetails:= aBoolean!

1 0

VM Maker: VMMaker.oscog-eem.3048.mcz
by commits＠source.squeak.org 23 Aug '21

23 Aug '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3048.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3048 Author: eem Time: 23 August 2021, 12:07:16.741622 pm UUID: bc51357e-57ea-4cb7-9017-41d4f4ce62ff Ancestors: VMMaker.oscog-eem.3047 Simulator: make reportPerMethodProfilingOn: easier to digest via reportPerMethodProfilingOn:cutoff:. Add names of primitives to the per method report. =============== Diff against VMMaker.oscog-eem.3047 =============== Item was changed: ----- Method: CogVMSimulator>>reportPerMethodProfilingOn: (in category 'simulation only') ----- reportPerMethodProfilingOn: aStream "Generate a sorted report of bytecodes per method, and instructions per trampoline/cog method/pic. Answer an Array with the four totals." + ^self reportPerMethodProfilingOn: aStream cutoff: nil! - | total | - perMethodProfile ifNil: - [aStream nextPutAll: 'not collecting profile'. - ^self]. - total := 0. - aStream nextPutAll: 'bytecodes dispatched per method'; cr. - (perMethodProfile associations sorted: [:a1 :a2| a1 value >= a2 value]) do: - [:assoc| - total := total + assoc value. - aStream tab; print: assoc value; nextPut: $:; tab. - self printNameOfClass: (self methodClassOf: assoc key) count: 2 on: aStream. - aStream next: 2 put: $>. - self printStringOf: (self findSelectorOfMethod: assoc key) on: aStream. - aStream cr]. - aStream flush. - ^{total}, (cogit reportPerMethodProfilingOn: aStream)! Item was added: + ----- Method: CogVMSimulator>>reportPerMethodProfilingOn:cutoff: (in category 'simulation only') ----- + reportPerMethodProfilingOn: aStream cutoff: cutoffOrNilOrPair + "Generate a sorted report of bytecodes per method, and instructions per trampoline/cog method/pic. + Answer an Array with the four totals. cutoffOrNilOrPair is either nil, or an integer, or a pair of integers, + { interpreter cutoff, cogit cutoff }" + | total cutoff | + perMethodProfile ifNil: + [aStream nextPutAll: 'not collecting profile'. + ^self]. + cutoff := cutoffOrNilOrPair isArray ifTrue: [cutoffOrNilOrPair first] ifFalse: [cutoffOrNilOrPair]. + total := 0. + aStream nextPutAll: 'bytecodes dispatched per method'; cr. + (perMethodProfile associations sorted: [:a1 :a2| a1 value >= a2 value]) do: + [:assoc| + total := total + assoc value. + (cutoff isNil or: [assoc value >= cutoff]) ifTrue: + [self reportSingleMethodProfile: assoc on: aStream]]. + aStream flush. + ^{total}, (cogit + reportPerMethodProfilingOn: aStream + cutoff: (cutoffOrNilOrPair isArray ifTrue: [cutoffOrNilOrPair last] ifFalse: [cutoffOrNilOrPair]))! Item was added: + ----- Method: CogVMSimulator>>reportSingleMethodProfile:on: (in category 'simulation only') ----- + reportSingleMethodProfile: assoc on: aStream + "Generate a sorted report of bytecodes per method, and instructions per trampoline/cog method/pic. + Answer an Array with the four totals." + | primIndex literal | + aStream tab; print: assoc value; nextPut: $:; tab. + self printNameOfClass: (self methodClassOf: assoc key) count: 2 on: aStream. + aStream next: 2 put: $>. + self printStringOf: (self findSelectorOfMethod: assoc key) on: aStream. + primIndex := self primitiveIndexOf: assoc key. + (primIndex = 0 + or: [(self isQuickPrimitiveIndex: primIndex) + or: [(primitiveTable at: primIndex + 1) isInteger]]) ifFalse: + [aStream space; nextPutAll: (primitiveTable at: primIndex + 1). + (cogit primitiveGeneratorForPrimitiveIndex: primIndex) ifNotNil: + [:descriptor| + descriptor primitiveGenerator ifNotNil: + [:generator| aStream space; nextPutAll: generator]]. + primIndex = PrimNumberExternalCall ifTrue: + [literal := self literal: 0 ofMethod: assoc key. + aStream + space; + nextPutAll: (self stringOf: (objectMemory fetchPointer: ExternalCallLiteralModuleNameIndex ofObject: literal)); + space; + nextPutAll: (self stringOf: (objectMemory fetchPointer: ExternalCallLiteralFunctionNameIndex ofObject: literal))]]. + aStream cr! Item was changed: ----- Method: Cogit>>reportPerMethodProfilingOn: (in category 'analysis') ----- reportPerMethodProfilingOn: aStream <doNotGenerate> | mTotal pTotal tTotal | perMethodProfile ifNil: [aStream nextPutAll: 'not collecting profile'. ^self]. self moveProfileToMethods. aStream nextPutAll: 'instructions dispatched per trampoline'; cr. tTotal := 0. ((perMethodProfile associations select: [:assoc| assoc key < methodZoneBase]) sorted: [:a1 :a2| a1 value >= a2 value]) do: [:assoc| tTotal := tTotal + assoc value. aStream tab; print: assoc value; nextPut: $:; tab; nextPutAll: (self codeEntryNameFor: assoc key); cr]. aStream nextPutAll: 'instructions dispatched per method'; cr. mTotal := 0. ((perMethodProfile associations select: [:assoc| assoc key >= objectMemory startOfMemory and: [objectMemory isCompiledMethod: assoc key]]) sorted: [:a1 :a2| a1 value >= a2 value]) do: [:assoc| mTotal := mTotal + assoc value. + coInterpreter reportSingleMethodProfile: assoc on: aStream]. - aStream tab; print: assoc value; nextPut: $:; tab. - coInterpreter printNameOfClass: (coInterpreter methodClassOf: assoc key) count: 2 on: aStream. - aStream next: 2 put: $>. - coInterpreter printStringOf: (coInterpreter findSelectorOfMethod: assoc key) on: aStream. - aStream cr]. aStream nextPutAll: 'instructions dispatched per pic'; cr. pTotal := 0. ((perMethodProfile associations select: [:assoc| assoc key >= objectMemory startOfMemory and: [(objectMemory isCompiledMethod: assoc key) not]]) sorted: [:a1 :a2| a1 value >= a2 value]) do: [:assoc| pTotal := pTotal + assoc value. aStream tab; print: assoc value; nextPut: $:; tab. coInterpreter printStringOf: assoc key on: aStream. aStream cr]. aStream flush. ^{tTotal. mTotal. pTotal }! Item was added: + ----- Method: Cogit>>reportPerMethodProfilingOn:cutoff: (in category 'analysis') ----- + reportPerMethodProfilingOn: aStream cutoff: cutoffOrNil + <doNotGenerate> + | mTotal pTotal tTotal | + perMethodProfile ifNil: + [aStream nextPutAll: 'not collecting profile'. + ^self]. + self moveProfileToMethods. + aStream nextPutAll: 'instructions dispatched per trampoline'; cr. + tTotal := 0. + ((perMethodProfile associations select: [:assoc| assoc key < methodZoneBase]) sorted: [:a1 :a2| a1 value >= a2 value]) do: + [:assoc| + tTotal := tTotal + assoc value. + (cutoffOrNil isNil or: [assoc value >= cutoffOrNil]) ifTrue: + [aStream tab; print: assoc value; nextPut: $:; tab; nextPutAll: (self codeEntryNameFor: assoc key); cr]]. + aStream nextPutAll: 'instructions dispatched per method'; cr. + mTotal := 0. + ((perMethodProfile associations + select: [:assoc| assoc key >= objectMemory startOfMemory and: [objectMemory isCompiledMethod: assoc key]]) + sorted: [:a1 :a2| a1 value >= a2 value]) do: + [:assoc| + mTotal := mTotal + assoc value. + (cutoffOrNil isNil or: [assoc value >= cutoffOrNil]) ifTrue: + [coInterpreter reportSingleMethodProfile: assoc on: aStream]]. + aStream nextPutAll: 'instructions dispatched per pic'; cr. + pTotal := 0. + ((perMethodProfile associations + select: [:assoc| assoc key >= objectMemory startOfMemory and: [(objectMemory isCompiledMethod: assoc key) not]]) + sorted: [:a1 :a2| a1 value >= a2 value]) do: + [:assoc| + pTotal := pTotal + assoc value. + (cutoffOrNil isNil or: [assoc value >= cutoffOrNil]) ifTrue: + [aStream tab; print: assoc value; nextPut: $:; tab. + coInterpreter printStringOf: assoc key on: aStream. + aStream cr]]. + aStream flush. + ^{tTotal. mTotal. pTotal }! Item was changed: ----- Method: CurrentImageCoInterpreterFacade>>marryFrameCopiesTemps (in category 'frame access') ----- marryFrameCopiesTemps + ^coInterpreter marryFrameCopiesTemps! - ^ false! Item was added: + ----- Method: SimpleStackBasedCogit>>primitiveGeneratorForPrimitiveIndex: (in category 'simulation only') ----- + primitiveGeneratorForPrimitiveIndex: index + "If there is a generator for the primitive index then answer it; + otherwise answer nil." + <doNotGenerate> + ^(index between: 1 and: MaxCompiledPrimitiveIndex) ifTrue: + [self class initializationOptions at: #DoNotJIT ifPresent: + [:excluded| (excluded includes: index) ifTrue: [^nil]]. + primitiveGeneratorTable at: index]! Item was changed: ----- Method: StackInterpreterSimulator>>reportPerMethodProfilingOn: (in category 'simulation only') ----- reportPerMethodProfilingOn: aStream "Generate a sorted report of bytecodes per method, and instructions per trampoline/cog method/pic. Answer the total number of bytecodes executed." + ^self reportPerMethodProfilingOn: aStream cutoff: nil! - | total | - perMethodProfile ifNil: - [aStream nextPutAll: 'not collecting profile'. - ^self]. - total := 0. - aStream nextPutAll: 'bytecodes dispatched per method'; cr. - (perMethodProfile associations sorted: [:a1 :a2| a1 value >= a2 value]) do: - [:assoc| - total := total + assoc value. - aStream tab; print: assoc value; nextPut: $:; tab. - self printNameOfClass: (self methodClassOf: assoc key) count: 2 on: aStream. - aStream next: 2 put: $>. - self printStringOf: (self findSelectorOfMethod: assoc key) on: aStream. - aStream cr]. - aStream flush. - ^total! Item was added: + ----- Method: StackInterpreterSimulator>>reportPerMethodProfilingOn:cutoff: (in category 'simulation only') ----- + reportPerMethodProfilingOn: aStream cutoff: cutoffOrNil + "Generate a sorted report of bytecodes per method, and instructions per trampoline/cog method/pic. + Answer the total number of bytecodes executed." + | total | + perMethodProfile ifNil: + [aStream nextPutAll: 'not collecting profile'. + ^self]. + total := 0. + aStream nextPutAll: 'bytecodes dispatched per method'; cr. + (perMethodProfile associations sorted: [:a1 :a2| a1 value >= a2 value]) do: + [:assoc| + total := total + assoc value. + (cutoffOrNil isNil + or: [assoc value > cutoffOrNil]) ifTrue: + [aStream tab; print: assoc value; nextPut: $:; tab. + self printNameOfClass: (self methodClassOf: assoc key) count: 2 on: aStream. + aStream next: 2 put: $>. + self printStringOf: (self findSelectorOfMethod: assoc key) on: aStream. + aStream cr]]. + aStream flush. + ^total! Item was added: + ----- Method: StackInterpreterSimulator>>reportSingleMethodProfile:on: (in category 'simulation only') ----- + reportSingleMethodProfile: assoc on: aStream + "Generate a sorted report of bytecodes per method, and instructions per trampoline/cog method/pic. + Answer an Array with the four totals." + | primIndex literal | + aStream tab; print: assoc value; nextPut: $:; tab. + self printNameOfClass: (self methodClassOf: assoc key) count: 2 on: aStream. + aStream next: 2 put: $>. + self printStringOf: (self findSelectorOfMethod: assoc key) on: aStream. + primIndex := self primitiveIndexOf: assoc key. + ((self isQuickPrimitiveIndex: primIndex) + or: [(primitiveTable at: primIndex) isInteger]) ifFalse: + [aStream space; nextPutAll: (primitiveTable at: primIndex). + primIndex = PrimNumberExternalCall ifTrue: + [literal := self literal: 0 ofMethod: assoc key. + aStream + space; + nextPutAll: (self stringOf: (objectMemory fetchPointer: ExternalCallLiteralModuleNameIndex ofObject: literal)); + space; + nextPutAll: (self stringOf: (objectMemory fetchPointer: ExternalCallLiteralFunctionNameIndex ofObject: literal))]]. + aStream cr!

1 0

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] CogVM source as per VMMaker.oscog-eem.3047 (12b0d50)
by Marcel Taeumel 23 Aug '21

23 Aug '21

I can confirm that compilation performance (e.g. `Morph compileAll`) is back to normal in cog.spur :-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/12b0d50876312a74c5…

2 1

[OpenSmalltalk/opensmalltalk-vm] 12b0d5: CogVM source as per VMMaker.oscog-eem.3047
by Eliot Miranda 22 Aug '21

22 Aug '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 12b0d50876312a74c51be3a81232b55a4b3efb7f https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/12b0d50876312a74c5… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-08-21 (Sat, 21 Aug 2021) Changed paths: M spur64src/vm/cogit.h M spur64src/vm/cogitARMv8.c M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/cointerpmt.c M spur64src/vm/cointerpmt.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/gcc3x-cointerpmt.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitARMv8.c M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitARMv8.c M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/cointerpmt.c M spursrc/vm/cointerpmt.h M spursrc/vm/gcc3x-cointerp.c M spursrc/vm/gcc3x-cointerpmt.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/gcc3x-cointerp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3047 Fix the performance regression for compilation performance introduced by VMMaker.oscog-eem.2994 (primitiveFlushCacheByMethod).

1 0

VM Maker: VMMaker.oscog-eem.3047.mcz
by commits＠source.squeak.org 22 Aug '21

22 Aug '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3047.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3047 Author: eem Time: 21 August 2021, 8:09:37.258109 pm UUID: 548d0a5b-eb23-4df6-bbb1-0b431cc840b3 Ancestors: VMMaker.oscog-eem.3046 ...and fix the bug tail in Slang for introducing Cogit>>mapPerMethodProfile. i.e. add TBraceNode for braces, and update printf nodes to use braces rather than raw sequences. =============== Diff against VMMaker.oscog-eem.3046 =============== Item was changed: ----- Method: BraceNode>>asTranslatorNodeIn: (in category '*VMMaker-C translation') ----- asTranslatorNodeIn: aTMethod "Answer a TParseNode subclass equivalent of me." "This is for case statements" (elements allSatisfy: [:elem| elem isMessageNode and: [elem selector key = #->]]) ifTrue: [self assert: (elements allSatisfy: [:elem| elem receiver isBlockNode and: [elem arguments first isBlockNode and: [elem receiver isPotentialCCaseLabelIn: aTMethod]]]). ^TBraceCaseNode new caseLabels: (elements collect: [:elem| elem receiver asTranslatorNodeIn: aTMethod]); cases: (elements collect: [:elem| elem arguments first asTranslatorNodeIn: aTMethod]); comment: comment]. "This is for varargs selectors (variants of printf:)" + ^TBraceNode new + elements: (elements collect: [:elem| elem asTranslatorNodeIn: aTMethod])! - ^elements collect: [:elem| elem asTranslatorNodeIn: aTMethod]! Item was changed: ----- Method: CoInterpreter>>getCodeCompactionCount (in category 'internal interpreter access') ----- getCodeCompactionCount - <cmacro: '() integerObjectOf(GIV(statCodeCompactionCount))'> ^objectMemory integerObjectOf: statCodeCompactionCount! Item was changed: ----- Method: CoInterpreter>>getCodeCompactionMSecs (in category 'internal interpreter access') ----- getCodeCompactionMSecs - <cmacro: '() integerObjectOf((GIV(statCodeCompactionUsecs) + 500) / 1000)'> ^objectMemory integerObjectOf: statCodeCompactionUsecs + 500 // 1000! Item was changed: ----- Method: CoInterpreter>>getCogCodeSize (in category 'internal interpreter access') ----- getCogCodeSize - <cmacro: '() integerObjectOf(GIV(cogCodeSize))'> ^objectMemory integerObjectOf: cogCodeSize! Item was changed: ----- Method: TBraceCaseNode>>nodesDo:parent: (in category 'enumerating') ----- nodesDo: aBlock parent: parent "Apply aBlock to all nodes in the receiver with each node's parent. N.B. This is assumed to be bottom-up, leaves first." caseLabels do: + [:node| node nodesDo: aBlock parent: self]. - [:node| node nodesDo: aBlock parent: self.]. cases do: [:node| node nodesDo: aBlock parent: self]. aBlock value: self value: parent! Item was added: + TParseNode subclass: #TBraceNode + instanceVariableNames: 'elements' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMaker-Translation to C'! + + !TBraceNode commentStamp: 'eem 8/21/2021 19:41' prior: 0! + A TBraceNode is a holder for a naked brace node ({ expr1. ... exprN}). These are used in printf expressions, and also may pop up in macro methods (see Cogit>>#mapPerMethodProfile). + + Instance Variables + elements: <OrderedCollection> + + elements + - the expressions of the brace! Item was added: + ----- Method: TBraceNode>>bindVariableUsesIn: (in category 'transformations') ----- + bindVariableUsesIn: aDictionary + + elements := elements collect: [:node| node bindVariableUsesIn: aDictionary]! Item was added: + ----- Method: TBraceNode>>bindVariableUsesIn:andConstantFoldIf:in: (in category 'transformations') ----- + bindVariableUsesIn: aDictionary andConstantFoldIf: constantFold in: codeGen + "Answer either the receiver, if it contains no references to the given variables, or a new node with the given variables rebound." + | newElements | + newElements := elements collect: [:node| node bindVariableUsesIn: aDictionary andConstantFoldIf: constantFold in: codeGen]. + ^newElements = elements + ifTrue: [self] + ifFalse: [self shallowCopy + elements: newElements; + yourself]! Item was added: + ----- Method: TBraceNode>>bindVariablesIn: (in category 'transformations') ----- + bindVariablesIn: aDictionary + + elements := elements collect: [:node| node bindVariablesIn: aDictionary]! Item was added: + ----- Method: TBraceNode>>elements (in category 'accessing') ----- + elements + ^elements! Item was added: + ----- Method: TBraceNode>>elements: (in category 'accessing') ----- + elements: anObject + "Set the value of elements" + + elements := anObject! Item was added: + ----- Method: TBraceNode>>hasEffect (in category 'testing') ----- + hasEffect + "Answer if this node has an effect on execution state (does something). + Statements that don't have any effect can be elided if their value is unused." + ^elements anySatisfy: [:node| node hasEffect]! Item was added: + ----- Method: TBraceNode>>isBrace (in category 'testing') ----- + isBrace + ^true! Item was added: + ----- Method: TBraceNode>>nodesDo: (in category 'enumerating') ----- + nodesDo: aBlock + "Apply aBlock to all nodes in the receiver. + N.B. This is assumed to be bottom-up, leaves first." + elements do: + [:node| node nodesDo: aBlock]. + aBlock value: self! Item was added: + ----- Method: TBraceNode>>nodesDo:parent: (in category 'enumerating') ----- + nodesDo: aBlock parent: parent + "Apply aBlock to all nodes in the receiver with each node's parent. + N.B. This is assumed to be bottom-up, leaves first." + elements do: + [:node| node nodesDo: aBlock parent: self]. + aBlock value: self value: parent! Item was added: + ----- Method: TBraceNode>>nodesDo:parent:unless: (in category 'enumerating') ----- + nodesDo: aBlock parent: parent unless: cautionaryBlock + + (cautionaryBlock value: self value: parent) ifTrue: [^self]. + elements do: + [:node| node nodesDo: aBlock parent: self unless: cautionaryBlock]. + aBlock value: self value: parent! Item was added: + ----- Method: TBraceNode>>nodesDo:unless: (in category 'enumerating') ----- + nodesDo: aBlock unless: cautionaryBlock + + (cautionaryBlock value: self) ifTrue: [^self]. + elements do: + [:node| node nodesDo: aBlock unless: cautionaryBlock]. + aBlock value: self! Item was added: + ----- Method: TBraceNode>>postCopy (in category 'copying') ----- + postCopy + elements := elements collect: [:ea| ea copy]! Item was added: + ----- Method: TBraceNode>>printOn:level: (in category 'printing') ----- + printOn: aStream level: level + aStream crtab: level; nextPut: ${. + elements + do: [:element| element printOn: aStream] + separatedBy: [aStream nextPut: $.; space]. + aStream space; nextPut: $}! Item was added: + ----- Method: TBraceNode>>replaceNodesIn: (in category 'enumerating') ----- + replaceNodesIn: aDictionary + + ^aDictionary + at: self + ifAbsent: + [elements := elements collect: [:node| node replaceNodesIn: aDictionary]. + self]! Item was added: + ----- Method: TBraceNode>>typeOrNilFrom:in: (in category 'type inference') ----- + typeOrNilFrom: aCodeGenerator in: aTMethod + ^nil! Item was changed: ----- Method: TMethod>>newCascadeTempFor: (in category 'initialization') ----- newCascadeTempFor: aTParseNode | varName varNode | varName := self extraVariableName: 'cascade'. varNode := TVariableNode new setName: varName. aTParseNode isLeaf ifFalse: [self declarationAt: varName put: [:tm :cg| | type | type := tm determineTypeFor: aTParseNode in: cg. (VMStructType structTargetKindForType: type) == #struct ifTrue: ["can't copy structs into cascade temps; the struct is not updated. must change to a pointer." type := type, ' *'. parseTree nodesDo: [:node| (node isAssignment and: [node variable name = varName]) ifTrue: [node setExpression: (TSendNode new setSelector: #addressOf: receiver: (TVariableNode new setName: 'self') arguments: {node expression})]]]. + type ifNil: [#sqInt]]]. - type]]. ^varNode! Item was changed: ----- Method: TMethod>>transformPrintf: (in category 'transformations') ----- transformPrintf: sendNode "Handle forms of f:printf: & printf:. f:printf: is either logFile f: formatLiteral printf: args or formatLiteral f: streamName printf: args printf is formatLiteral printf: args" + | map newArgs | + newArgs := OrderedCollection new. + sendNode args do: + [:arg| + arg isBrace + ifTrue: [newArgs addAllLast: arg elements] + ifFalse: [newArgs addLast: arg]]. - | map | (sendNode receiver isConstant and: [sendNode receiver value isString]) ifTrue: [| format | format := sendNode receiver asPrintfFormatStringNode. sendNode selector first == $f ifTrue: "fprintf et al..." [sendNode receiver: (TVariableNode new setName: 'self'). + sendNode arguments: {sendNode args first. format}, newArgs allButFirst. - sendNode arguments: {sendNode args first. format}, sendNode args allButFirst. ^sendNode]. sendNode receiver: format. + sendNode arguments: newArgs. ^sendNode]. map := Dictionary new. sendNode nodesDo: [:subNode| (subNode isConstant and: [subNode value isString and: [subNode value includes: $%]]) ifTrue: [map at: subNode put: subNode asPrintfFormatStringNode]]. + sendNode arguments: newArgs. sendNode replaceNodesIn: map. ^sendNode! Item was added: + ----- Method: TParseNode>>isBrace (in category 'testing') ----- + isBrace + ^false! Item was changed: ----- Method: TSwitchStmtNode>>nodesDo:parent: (in category 'enumerating') ----- nodesDo: aBlock parent: parent "Apply aBlock to all nodes in the receiver with each node's parent. N.B. This is assumed to be bottom-up, leaves first." expression nodesDo: aBlock parent: self. cases do: [:pair| + pair first do: [:node| node nodesDo: aBlock parent: self]. + pair last nodesDo: aBlock parent: self]. - pair first do: [:node| node nodesDo: aBlock parent: self.]. - pair last nodesDo: aBlock parent: self.]. otherwiseOrNil ifNotNil: [otherwiseOrNil nodesDo: aBlock parent: self]. aBlock value: self value: parent!

1 0

VM Maker: CogTools-eem.90.mcz
by commits＠source.squeak.org 22 Aug '21

22 Aug '21

Eliot Miranda uploaded a new version of CogTools to project VM Maker: http://source.squeak.org/VMMaker/CogTools-eem.90.mcz ==================== Summary ==================== Name: CogTools-eem.90 Author: eem Time: 21 August 2021, 6:12:00.785794 pm UUID: 7df613ba-6053-42ff-932c-55ace1f665d8 Ancestors: CogTools-eem.89 Get the VMMaker to a semi-functional state in current Squeak. =============== Diff against CogTools-eem.89 =============== Item was changed: ----- Method: AxesMorph>>drawOn: (in category 'drawing') ----- drawOn: aCanvas super drawOn: aCanvas. + [aCanvas - aCanvas image: self form at: self topLeft + self borderWidth + rule: Form blend] + on: Deprecation + do: [:ex| ex resume]! - rule: Form blend! Item was changed: ----- Method: SqueakVMProfiler>>buttonMorph:help:set:enable:color: (in category 'opening') ----- buttonMorph: getLabelMessage help: help set: setter enable: enabler color: colorGetter | pbm | pbm := PluggableButtonMorphPlus on: self getState: nil action: setter label: getLabelMessage. + [pbm useRoundedCorners] on: MessageNotUnderstood do: []. pbm - useRoundedCorners; getEnabledSelector: enabler; setBalloonText: help; getColorSelector: colorGetter; offColor: Color transparent. ^pbm! Item was added: + ----- Method: VMPExecutableModuleSymbol>>asString (in category 'printing') ----- + asString + ^(name copyFrom: (name lastIndexOf: FileDirectory pathNameDelimiter) + 1 to: name size) asText allBold! Item was added: + ----- Method: VMPSymbol>>asString (in category 'printing') ----- + asString + "Answer the name as a string, which for the purposes of the symbol list is an unemphasized text." + ^name! Item was changed: ----- Method: VMProfiler class>>reportGCStats:upTime:on: (in category 'reports') ----- reportGCStats: gcStatsArray upTime: elapsedMilliseconds on: str | oldSpaceEnd youngSpaceEnd memoryEnd fullGCs fullGCTime incrGCs incrGCTime tenureCount rootOverflows | gcStatsArray ifNil: [^self]. oldSpaceEnd := gcStatsArray at: 2. "a.k.a. oldSpace size on Spur" fullGCs := gcStatsArray at: 7. fullGCTime := gcStatsArray at: 8. incrGCs := gcStatsArray at: 9. incrGCTime := gcStatsArray at: 10. tenureCount := gcStatsArray at: 11. rootOverflows := gcStatsArray at: 22. str cr. str nextPutAll: '**Memory**'; cr. str nextPutAll: ' old '; + nextPutAll: (oldSpaceEnd asStringWithCommasSigned: true); nextPutAll: ' bytes'; cr. - nextPutAll: oldSpaceEnd asStringWithCommasSigned; nextPutAll: ' bytes'; cr. self amOnSpur ifTrue: [(gcStatsArray at: 54) ifNotNil: [:freeSpace| str nextPutAll: ' free '; + nextPutAll: (freeSpace asStringWithCommasSigned: true); nextPutAll: ' bytes'; cr]] - nextPutAll: freeSpace asStringWithCommasSigned; nextPutAll: ' bytes'; cr]] ifFalse: [youngSpaceEnd := gcStatsArray at: 1. memoryEnd := gcStatsArray at: 3. str nextPutAll: ' young '; + nextPutAll: (youngSpaceEnd - oldSpaceEnd asStringWithCommasSigned: true); nextPutAll: ' bytes'; cr. - nextPutAll: (youngSpaceEnd - oldSpaceEnd) asStringWithCommasSigned; nextPutAll: ' bytes'; cr. str nextPutAll: ' used '; + nextPutAll: (youngSpaceEnd asStringWithCommasSigned: true); nextPutAll: ' bytes'; cr. - nextPutAll: youngSpaceEnd asStringWithCommasSigned; nextPutAll: ' bytes'; cr. str nextPutAll: ' free '; + nextPutAll: (memoryEnd - youngSpaceEnd asStringWithCommasSigned: true); nextPutAll: ' bytes'; cr]. - nextPutAll: (memoryEnd - youngSpaceEnd) asStringWithCommasSigned; nextPutAll: ' bytes'; cr]. str cr. str nextPutAll: '**GCs**'; cr. str nextPutAll: ' full '; print: fullGCs; nextPutAll: ' totalling '; nextPutAll: fullGCTime asStringWithCommas; nextPutAll: 'ms ('; nextPutAll: (CompatibilityClass print:(fullGCTime / elapsedMilliseconds * 100) showingDecimalPlaces: 3 ); nextPutAll: '% elapsed time)'. fullGCs = 0 ifFalse: [str nextPutAll: ', avg '; nextPutAll: (CompatibilityClass print:(fullGCTime / fullGCs) showingDecimalPlaces: 3); nextPutAll: 'ms']. str cr. str nextPutAll: (self amOnSpur ifTrue: [' scavenges '] ifFalse: [' incr ']); print: incrGCs; nextPutAll: ' totalling '; nextPutAll: incrGCTime asStringWithCommas; nextPutAll: 'ms ('; nextPutAll: (CompatibilityClass print:incrGCTime / elapsedMilliseconds * 100 showingDecimalPlaces: 3); nextPutAll: '% elapsed time)'. incrGCs = 0 ifFalse: [str nextPutAll:', avg '; nextPutAll: (CompatibilityClass print:incrGCTime / incrGCs showingDecimalPlaces:3); nextPutAll: 'ms']. str cr. str nextPutAll: ' tenures '; nextPutAll: tenureCount asStringWithCommas. tenureCount = 0 ifFalse: [str nextPutAll: ' (avg '; print: (incrGCs / tenureCount) asInteger; nextPutAll: ' GCs/tenure)']. str cr. str nextPutAll: ' root table '; nextPutAll: rootOverflows asStringWithCommas; nextPutAll:' overflows'. str cr. (gcStatsArray size >= 63 and: [(gcStatsArray at: 63) isInteger]) ifTrue: [| numCompactions compactionMsecs | str cr; nextPutAll: '**Compiled Code Compactions**'; cr. numCompactions := gcStatsArray at: 62. compactionMsecs := gcStatsArray at: 63. str tab; print: numCompactions; nextPutAll: ' totalling '; nextPutAll: compactionMsecs asStringWithCommas; nextPutAll: 'ms ('; nextPutAll: (CompatibilityClass print:compactionMsecs / elapsedMilliseconds * 100 showingDecimalPlaces: 3); nextPutAll: '% elapsed time)'. numCompactions = 0 ifFalse: [str nextPutAll: ', avg '; nextPutAll: (CompatibilityClass print:compactionMsecs / numCompactions showingDecimalPlaces:3); nextPutAll: 'ms']. str cr]. gcStatsArray size >= 61 ifTrue: [str cr; nextPutAll: '**Events**'; cr. (56 to: 61) with: #('Process switches' 'ioProcessEvents calls' 'Interrupt checks' 'Event checks' 'Stack overflows' 'Stack page divorces') do: [:index :eventName| | value n | value := gcStatsArray at: index. n := 22 - eventName size // 4 + 1. str nextPutAll: eventName; tab: n; print: value; nextPutAll: ' ('; print: (value * 1000 / elapsedMilliseconds) rounded; nextPutAll: ' per second)'; cr]]!

1 0

VM Maker: VMMaker.oscog-eem.3046.mcz
by commits＠source.squeak.org 22 Aug '21

22 Aug '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3046.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3046 Author: eem Time: 21 August 2021, 6:06:25.913827 pm UUID: 981441cf-e580-43c9-b601-3d7278b756f5 Ancestors: VMMaker.oscog-eem.3045 Fix the performance regression for compilation performance introduced by VMMaker.oscog-eem.2994. =============== Diff against VMMaker.oscog-eem.3045 =============== Item was changed: ----- Method: CoInterpreterPrimitives>>primitiveFlushCacheByMethod (in category 'system control primitives') ----- primitiveFlushCacheByMethod "The receiver is a compiledMethod. Clear all entries in the method lookup cache that refer to this method, presumably because it has been redefined, overridden or removed. + Override to flush appropriate machine code caches also." + super primitiveFlushCacheByMethod. + cogit unlinkSendsTo: self stackTop andFreeIf: false! - Override to flush the appropriate machine code state." - self primitiveVoidVMStateForMethod!

1 0

Making a Hash of things, er, strings
by ken.dickey＠whidbey.com 21 Aug '21

21 Aug '21

A brief, ignorable, experience report.. One idea for speeding up lookups is to have a Selector class be a subclass of Symbol and when a Symbol becomes a Selector to have hash value fields in the Selector. When a MethodDictionary is rehashed, there is a small set of hashes which are tried and the most perfect (least collisions) is used for that particular MethodDictionary. Because of Spur, we can have several direct subclasses of MathodDictionary differing only in which hash value is accessed. Just change the ClassID and the hash access method selects the proper hash value of symbols. As long as the hash accessor stays polymorphic, the PIC mechanics will work for us. So the question becomes "Are there string/symbol hash functions where this approach makes sense?". I.e. is there enough difference in hash functions that we can get close(r) to perfect hashes and have better results choosing one over another? As I wait for Lulu to deliver Andres' book, I found some string hash functions [note: https://azrael.digipen.edu/~mmead/www/Courses/CS280/HashFunctions-1.html ] and took an a first look at this, counting collisions for (hash \\ dictSize) + 1 or more efficiently [note https://craftinginterpreters.com/optimization.html] (hash bitAnd: (dictSize - 1)) + 1 Early results: vvv=========vvv "Count has collisions for all selectors in each of 1527 methodDicts" "For each Class methodDict, which hash has the fewest collisions?" HashCandidates globalCollisionsCounts. "Lower is Better" #hash collisions = 5466 #identityHash collisions = 6534 #hash0 collisions = 5331 #hash1 collisions = 5301 #hash2 collisions = 5419 #hash3 collisions = 5442 #hash4 collisions = 5436 #hash5 collisions = 14630 #hash6 collisions = 5442 #hash7 collisions = 5436 #hash8 collisions = 18708 #hash9 collisions = 25344 #hash10 collisions = 23518 #(5466 6534 5331 5301 5419 5442 5436 14630 5442 5436 18708 25344 23518) "Compare hashs for each MethodDict; lowest collisions wins" HashCandidates globalHashWinCounts. "Higher is Better" #hash win count = 664 #identityHash win count = 610 #hash0 win count = 672 #hash1 win count = 680 #hash2 win count = 662 #hash3 win count = 679 #hash4 win count = 666 #hash5 win count = 429 #hash6 win count = 679 #hash7 win count = 666 #hash8 win count = 350 #hash9 win count = 247 #hash10 win count = 263 #(664 610 672 680 662 679 666 429 679 666 350 247 263) ^^^=========^^^ One quick observation is that string hash is better than identityHash and hash1 (K&R) is better than current string hash. Also, the hashes used so far do not show much advantage against each other in the better cases. --- An unrelated idea is to "copy down" just megamorphic methods to subclasses to speed up megamorphic lookups. Neither of these ideas requires JIT/recompile to implement, just IDE changes. Just playing around.. -KenD

2 1

← Newer
1
2
3
4
5
6
7
8
...
17
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev August 2021